[vpp-dev] punt drops packets with TTL 1

2021-05-11 Thread Aloys Augustin (aloaugus) via lists.fd.io
Hello,

I recently ran into an issue where VPP would drop a packet immediately after 
going through the punt path if the incoming packet has a TTL of 1. I think it 
would make sense not to decrease the TTL when punting a packet.

I made the following patch to fix it: https://gerrit.fd.io/r/c/vpp/+/31969 
 

Could I kindly ask a committer to review it?

Thanks,
Aloys

smime.p7s
Description: S/MIME cryptographic signature

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19368): https://lists.fd.io/g/vpp-dev/message/19368
Mute This Topic: https://lists.fd.io/mt/82748246/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] FDIO Jenkins Maintenance - 2021-05-11 1800UTC - 2000UTC

2021-05-11 Thread Dave Wallace

*What*:

Jenkins has been placed in shutdown mode in preparation to perform 
unplanned maintenance


*When*:

2021-05-11 1800 UTC to 2000 UTC

*Impact*:

Jenkins sandbox and production will be unavailable during this time

*Why*:

The vendor will be moving network gateways to the new data center where 
the nomad servers now reside to address TCP connection issues aborting 
FD.io CI jobs.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19369): https://lists.fd.io/g/vpp-dev/message/19369
Mute This Topic: https://lists.fd.io/mt/82752846/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] What is the relationship between "struct vlib_frame_t" , "struct vlib_pending_frame_t" and "struct vlib_next_frame_t"? #vpp-dev

2021-05-11 Thread Mohanty, Chandan (Nokia - IN/Bangalore)
Hi Experts,
I am new to VPP.I have gone through the Node despatcher Functionality at 
https://fdio-vpp.readthedocs.io/en/latest/gettingstarted/developers/vlib.html?highlight=dispatch#graph-node-dispatcher

However below queries are arising. Kindly help me on clarifying those.

Q1.
What is the relationship between "struct vlib_frame_t" , "struct 
vlib_pending_frame_t" and "struct vlib_next_frame_t"?

In the Node despatch section there is text as below
"there are no guarantees that a pending frame will be processed immediately, 
which means that MORE packets may be added to the underlying vlib_frame_t ,
after It (?) has been attached to a vlib_pending_frame_t "

Q2.
Does this mean "vlib_frame_t" is placed inside "vlib_pending_frame_t".But from 
below structure description,it does not appear so.Kindly guide me here.

In the Node despatch section there is text as below
"Once a node finishes adding element to a frame, it will acquire a 
vlib_pending_frame_t and end up on the graph dispatcher’s RUN-QUEUE".
"Care must be taken to allocate new frames and pending frames if a 
(pending_frame, frame) PAIR  fills."
"Only one graph node at a time thinks it “owns” the target vlib_frame_t."

Q3.
Does this mean,each node has separate,independent (pending_frame, frame) PAIR?

Q4.
"Frame" is where all the other nodes send/place/put packet into. 
"pending_frame",is ,FROM,where the current node extracts/lifts packets and 
process?
But how "pending_frame" is replenished from "frame" or from somewhere,I am 
unable to understand.

Kindly Guide me on above queries.

typedef struct vlib_frame_t
{
/* Frame flags. */
u16 flags;

/* Number of scalar bytes in arguments. */
u8 scalar_size;

/* Number of bytes per vector argument. */
u8 vector_size;

/* Number of vector elements currently in frame. */
u16 n_vectors;

/* Scalar and vector arguments to next node. */
u8 arguments[0];
} vlib_frame_t;

typedef struct
{
/* Node and runtime for this frame. */
u32 node_runtime_index;

/* Frame index (in the heap). */
u32 frame_index;

/* Start of next frames for this node. */
u32 next_frame_index;

/* Special value for next_frame_index when there is no next frame. */
#define VLIB_PENDING_FRAME_NO_NEXT_FRAME ((u32) ~0)
} vlib_pending_frame_t;

typedef struct
{
/* Frame index. */
u32 frame_index;
/* Node runtime for this next. */
u32 node_runtime_index;
/* Next frame flags. */
u32 flags;
/* Reflects node frame-used flag for this next. */
#define VLIB_FRAME_NO_FREE_AFTER_DISPATCH \
VLIB_NODE_FLAG_FRAME_NO_FREE_AFTER_DISPATCH

/* This next frame owns enqueue to node
corresponding to node_runtime_index. */
#define VLIB_FRAME_OWNER (1 << 15)

/* Set when frame has been allocated for this next. */
#define VLIB_FRAME_IS_ALLOCATED VLIB_NODE_FLAG_IS_OUTPUT

/* Set when frame has been added to pending vector. */
#define VLIB_FRAME_PENDING VLIB_NODE_FLAG_IS_DROP

/* Set when frame is to be freed after dispatch. */
#define VLIB_FRAME_FREE_AFTER_DISPATCH VLIB_NODE_FLAG_IS_PUNT

/* Set when frame has traced packets. */
#define VLIB_FRAME_TRACE VLIB_NODE_FLAG_TRACE

/* Number of vectors enqueue to this next since last overflow. */
u32 vectors_since_last_overflow;
} vlib_next_frame_t;

Regards
Chandan

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19370): https://lists.fd.io/g/vpp-dev/message/19370
Mute This Topic: https://lists.fd.io/mt/82754180/21656
Mute #vpp-dev:https://lists.fd.io/g/vpp-dev/mutehashtag/vpp-dev
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] [tsc] FDIO Jenkins Maintenance - 2021-05-11 1800UTC - 2000UTC

2021-05-11 Thread Dave Wallace

The maintenance is complete and so far the CI jobs are looking happier.

We will continue to monitor the performance of the system.

Thank you again for your patience.
-daw-

On 5/11/2021 1:50 PM, Dave Wallace via lists.fd.io wrote:

*What*:

Jenkins has been placed in shutdown mode in preparation to perform 
unplanned maintenance


*When*:

2021-05-11 1800 UTC to 2000 UTC

*Impact*:

Jenkins sandbox and production will be unavailable during this time

*Why*:

The vendor will be moving network gateways to the new data center 
where the nomad servers now reside to address TCP connection issues 
aborting FD.io CI jobs.







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19371): https://lists.fd.io/g/vpp-dev/message/19371
Mute This Topic: https://lists.fd.io/mt/82757043/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] punt drops packets with TTL 1

2021-05-11 Thread Matthew Smith via lists.fd.io
Hi Aloys,

Your patch has been merged.

-Matt


On Tue, May 11, 2021 at 10:00 AM Aloys Augustin (aloaugus) via lists.fd.io
 wrote:

> Hello,
>
> I recently ran into an issue where VPP would drop a packet immediately
> after going through the punt path if the incoming packet has a TTL of 1. I
> think it would make sense not to decrease the TTL when punting a packet.
>
> I made the following patch to fix it: https://gerrit.fd.io/r/c/vpp/+/31969
>
>
> Could I kindly ask a committer to review it?
>
> Thanks,
> Aloys
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19372): https://lists.fd.io/g/vpp-dev/message/19372
Mute This Topic: https://lists.fd.io/mt/82748246/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] observing issue with LACP port selection logic

2021-05-11 Thread Sudhir CR via lists.fd.io
Hi all,
i am configuring LACP between two containers.
vpp version used : *20.09*
topology looks like below
[image: image.png]
in above topology since memif-4/4 interface is not part of same bond
interface on both the containers (different partner system id)
memif-4/4 should not be marked as active  interface and attached to
BondEthernet0 in container1 but is attaching
to BondEthernet0.

Any help in fixing the issue would be appreciated.

Please find configuration in container1 :

DBGvpp# show bond
interface name   sw_if_index  mode  load balance  active members
members
BondEthernet09lacp  l23   3  3

DBGvpp# show bond details
BondEthernet0
  mode: lacp
  load balance: l23
  number of active members: 3
memif2/2
memif3/3
memif4/4
  number of members: 3
memif2/2
memif3/3
memif4/4
  device instance: 0
  interface id: 0
  sw_if_index: 9
  hw_if_index: 9

DBGvpp# show lacp
actor state
 partner state
interface namesw_if_index  bond interface
exp/def/dis/col/syn/agg/tim/act  exp/def/dis/col/syn/agg/tim/act
memif2/2  2BondEthernet0  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-67-1e-01-0c-02,0009,00ff,0001),
(,7a-37-f7-00-0c-02,000f,00ff,0001)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
memif3/3  3BondEthernet0  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-67-1e-01-0c-02,0009,00ff,0002),
(,7a-37-f7-00-0c-02,000f,00ff,0002)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
memif4/4  4BondEthernet0  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-67-1e-01-0c-02,0009,00ff,0003),
(,7a-37-f7-00-0c-04,0010,00ff,0001)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
DBGvpp#

Please find configuration in container2 :
DBGvpp# show bond
interface name   sw_if_index  mode  load balance  active members
members
BondEthernet015   lacp  l23   2  2
BondEthernet116   lacp  l23   1  1
DBGvpp#
DBGvpp#

DBGvpp# show bond details
BondEthernet0
  mode: lacp
  load balance: l23
  number of active members: 2
memif2/2
memif3/3
  number of members: 2
memif2/2
memif3/3
  device instance: 0
  interface id: 0
  sw_if_index: 15
  hw_if_index: 15
BondEthernet1
  mode: lacp
  load balance: l23
  number of active members: 1
memif4/4
  number of members: 1
memif4/4
  device instance: 1
  interface id: 1
  sw_if_index: 16
  hw_if_index: 16

DBGvpp# show lacp
actor state
 partner state
interface namesw_if_index  bond interface
exp/def/dis/col/syn/agg/tim/act  exp/def/dis/col/syn/agg/tim/act
memif2/2  8BondEthernet0  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-37-f7-00-0c-02,000f,00ff,0001),
(,7a-67-1e-01-0c-02,0009,00ff,0001)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
memif3/3  9BondEthernet0  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-37-f7-00-0c-02,000f,00ff,0002),
(,7a-67-1e-01-0c-02,0009,00ff,0002)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
memif4/4  10   BondEthernet1  0   0   1   1   1
  1   1   10   0   1   1   1   1   1   1
  LAG ID: [(,7a-37-f7-00-0c-04,0010,00ff,0001),
(,7a-67-1e-01-0c-02,0009,00ff,0003)]
  RX-state: CURRENT, TX-state: TRANSMIT, MUX-state:
COLLECTING_DISTRIBUTING, PTX-state: PERIODIC_TX
DBGvpp#


Thanks and Regards,
Sudhir

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19373): https://lists.fd.io/g/vpp-dev/message/19373
Mute This Topic: https://lists.fd.io/mt/82763645/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-