Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

[Zhang Dongya]

Yes, I can login to link [1] and can see my account have been registered in
LF 5 years, however, when I login the gerrit web ui, it still reports
Forbidden error, my account username is ZhangDongya.

Ok, I will try to use git command line to give a try.

Florin Coras  于2022年10月13日周四 10:12写道：

> An LF account should suffice. Could you confirm your lf credentials work
> here [1]?
>
> And, in case you haven’t seen this already, here are the steps to get you
> started on pushing the patch, once the above is solved [2].
>
> Regards,
> Florin
>
> [1] https://identity.linuxfoundation.org/
> [2]
> https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pulling_code_via_ssh
>
>
> On Oct 12, 2022, at 6:21 PM, Zhang Dongya 
> wrote:
>
> Thanks a lot,I just add a check for tx_fifo there locally and it seems
> works.
>
> BTW,
>
> I'd like to help to submit a patch, however I don't know the reason when I
> trying to login gerrit using my linux foundation id, it always reports
> Forbidden error, do you know where I can get help to
> solve this ?  or gerrit need some approval for get involved?
>
> It's ok if you want to get it fixed asap.
>
> Florin Coras  于2022年10月12日周三 23:44写道：
>
>> Hi,
>>
>> It looks like a bug. We should make sure the fifo exists, which is
>> typically the case unless transport is stuck in half-open. Note that tcp
>> does timeout and cleanups those stuck half-open sessions, but we should
>> allow the app to cleanup as well.
>>
>> Let me know if you plan to push a patch or I should do it.
>>
>> Regards,
>> Florin
>>
>> On Oct 12, 2022, at 12:44 AM, Zhang Dongya 
>> wrote:
>>
>> Hi,
>>
>> I am now trying to use vpp host-stack to negotiate a valid TCP session,
>> however, I found if I call vnet_disconnect_session when the TCP stuck in
>> syn-sent state (this may be caused by I have shutdown the remove side).
>>
>> Vpp will crash in the following code which call svm_fifo_clear_deq_ntf
>> while the tx_fifo is not inited, this is because the tx_fifo will be
>> allocated init app_worker_init_connected.
>>
>> Is this a bug or I have something wrong with my using of host-stack?
>>
>>
>>
>> void
>> session_close (session_t * s)
>> {
>> if (!s)
>> return;
>>
>> if (s->session_state >= SESSION_STATE_CLOSING)
>> {
>> /* Session will only be removed once both app and transport
>> * acknowledge the close */
>> if (s->session_state == SESSION_STATE_TRANSPORT_CLOSED
>> || s->session_state == SESSION_STATE_TRANSPORT_DELETED)
>> session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
>> return;
>> }
>>
>> /* App closed so stop propagating dequeue notifications */
>> svm_fifo_clear_deq_ntf (s->tx_fifo);
>> s->session_state = SESSION_STATE_CLOSING;
>> session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
>> }
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22019): https://lists.fd.io/g/vpp-dev/message/22019
Mute This Topic: https://lists.fd.io/mt/94276501/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

[Florin Coras]

An LF account should suffice. Could you confirm your lf credentials work here 
[1]?

And, in case you haven’t seen this already, here are the steps to get you 
started on pushing the patch, once the above is solved [2]. 

Regards,
Florin

[1] https://identity.linuxfoundation.org/ 

[2] 
https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pulling_code_via_ssh
 



> On Oct 12, 2022, at 6:21 PM, Zhang Dongya  wrote:
> 
> Thanks a lot,I just add a check for tx_fifo there locally and it seems works.
> 
> BTW,
> 
> I'd like to help to submit a patch, however I don't know the reason when I 
> trying to login gerrit using my linux foundation id, it always reports 
> Forbidden error, do you know where I can get help to
> solve this ?  or gerrit need some approval for get involved?
> 
> It's ok if you want to get it fixed asap. 
> 
> Florin Coras mailto:fcoras.li...@gmail.com>> 
> 于2022年10月12日周三 23:44写道：
> Hi, 
> 
> It looks like a bug. We should make sure the fifo exists, which is typically 
> the case unless transport is stuck in half-open. Note that tcp does timeout 
> and cleanups those stuck half-open sessions, but we should allow the app to 
> cleanup as well. 
> 
> Let me know if you plan to push a patch or I should do it. 
> 
> Regards,
> Florin
> 
>> On Oct 12, 2022, at 12:44 AM, Zhang Dongya > > wrote:
>> 
>> Hi,
>> 
>> I am now trying to use vpp host-stack to negotiate a valid TCP session, 
>> however, I found if I call vnet_disconnect_session when the TCP stuck in 
>> syn-sent state (this may be caused by I have shutdown the remove side).
>> 
>> Vpp will crash in the following code which call svm_fifo_clear_deq_ntf while 
>> the tx_fifo is not inited, this is because the tx_fifo will be allocated 
>> init app_worker_init_connected.
>> 
>> Is this a bug or I have something wrong with my using of host-stack?
>> 
>> 
>> 
>> void
>> session_close (session_t * s)
>> {
>>   if (!s)
>> return;
>> 
>>   if (s->session_state >= SESSION_STATE_CLOSING)
>> {
>>   /* Session will only be removed once both app and transport
>>* acknowledge the close */
>>   if (s->session_state == SESSION_STATE_TRANSPORT_CLOSED
>> || s->session_state == SESSION_STATE_TRANSPORT_DELETED)
>>   session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
>>   return;
>> }
>> 
>>   /* App closed so stop propagating dequeue notifications */
>>   svm_fifo_clear_deq_ntf (s->tx_fifo);
>>   s->session_state = SESSION_STATE_CLOSING;
>>   session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
>> }
>> 
>> 
>> 
>> 
>> 
> 
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22018): https://lists.fd.io/g/vpp-dev/message/22018
Mute This Topic: https://lists.fd.io/mt/94276501/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

[Zhang Dongya]

Thanks a lot,I just add a check for tx_fifo there locally and it seems
works.

BTW,

I'd like to help to submit a patch, however I don't know the reason when I
trying to login gerrit using my linux foundation id, it always reports
Forbidden error, do you know where I can get help to
solve this ?  or gerrit need some approval for get involved?

It's ok if you want to get it fixed asap.

Florin Coras  于2022年10月12日周三 23:44写道：

> Hi,
>
> It looks like a bug. We should make sure the fifo exists, which is
> typically the case unless transport is stuck in half-open. Note that tcp
> does timeout and cleanups those stuck half-open sessions, but we should
> allow the app to cleanup as well.
>
> Let me know if you plan to push a patch or I should do it.
>
> Regards,
> Florin
>
> On Oct 12, 2022, at 12:44 AM, Zhang Dongya 
> wrote:
>
> Hi,
>
> I am now trying to use vpp host-stack to negotiate a valid TCP session,
> however, I found if I call vnet_disconnect_session when the TCP stuck in
> syn-sent state (this may be caused by I have shutdown the remove side).
>
> Vpp will crash in the following code which call svm_fifo_clear_deq_ntf
> while the tx_fifo is not inited, this is because the tx_fifo will be
> allocated init app_worker_init_connected.
>
> Is this a bug or I have something wrong with my using of host-stack?
>
>
>
> void
> session_close (session_t * s)
> {
> if (!s)
> return;
>
> if (s->session_state >= SESSION_STATE_CLOSING)
> {
> /* Session will only be removed once both app and transport
> * acknowledge the close */
> if (s->session_state == SESSION_STATE_TRANSPORT_CLOSED
> || s->session_state == SESSION_STATE_TRANSPORT_DELETED)
> session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
> return;
> }
>
> /* App closed so stop propagating dequeue notifications */
> svm_fifo_clear_deq_ntf (s->tx_fifo);
> s->session_state = SESSION_STATE_CLOSING;
> session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
> }
>
>
>
>
>
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22017): https://lists.fd.io/g/vpp-dev/message/22017
Mute This Topic: https://lists.fd.io/mt/94276501/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build VPP with clean Jenkins workspace

[Dave Wallace]

Marcel,

The build failure was caused by the fact that your gerrit change was not 
based on top of master and because there was another gerrit change 
merged [0] which changed the PKG_SUFFIX in build/external/Makefile [0].  
Thus build was not updating vpp-ext-deps in the CI docker container 
because the vpp-ext-dep version (22.03-3) was the same as that which was 
already installed by the CI pre-build scripts.


I rebased 37358 which resolves the cmake failure.

Thanks,
-daw-

[0] https://github.com/FDio/vpp/blob/master/build/external/Makefile#L23

On 10/11/22 17:43, Cornu, Marcel D wrote:


Hi all,

I submitted a patch toadd support for a new version of the ipsecmb 
library, used by the crypto_ipsecmb plugin.


https://gerrit.fd.io/r/c/vpp/+/37358 



A previous build downloaded and built the new version of the library 
and the build passed, great!


Subsequentbuilds are now failing stating thatsymbols from the new 
library version can’t be found.


It seems like an old library version is being picked up by the build.

I am wondering if workspaces are isolated? Or is it possible that a 
previously installed (old) version of the library could be installed 
and accessible in the workspace?


Is there any way to wipe the Jenkins workspace and start from a clean 
state?


Thanks,

Marcel





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22016): https://lists.fd.io/g/vpp-dev/message/22016
Mute This Topic: https://lists.fd.io/mt/94269242/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] libnl as external dependency?

[Stanislav Zaikin]

Hi Pim,

Not any problems at all. Until you start to play with vxlan interfaces,
bridge af and so on :)
I'm living on a bleeding edge with some custom patches to libnl (planning
to upstream them as well). So, for my case I need to link statically libnl
to the plugin (not to depend on the host version of libnl).
But since it's quite questionable to merge something similar to upstream -
I'm asking the community if it can be useful for smb also.

On Wed, 12 Oct 2022 at 20:10, Pim van Pelt  wrote:

> Hoi Stanislav,
>
> What's the issue with using libnl3-dev from Ubuntu/Debian? Are you
> imagining adding patches from libnl (I'd love to learn more, if you do :-).
>
> groet,
> Pim
>
> On Wed, Oct 12, 2022 at 4:58 PM Stanislav Zaikin 
> wrote:
>
>> Hello folks,
>>
>> I have a patch to download, build and link statically libnl3 for linux-cp
>> netlink plugin (as part of vpp-ext-deps and aligned with other packages in
>> build/external/packages/).
>>
>> Would it be useful for the rest of the community? For instance, not to be
>> dependent on the libnl version in the host or to be able to apply custom
>> patches for libnl.
>>
>> --
>> Best regards
>> Stanislav Zaikin
>>
>>
>>
>>
>
> --
> Pim van Pelt 
> PBVP1-RIPE - http://www.ipng.nl/
>
> 
>
>

-- 
Best regards
Stanislav Zaikin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22015): https://lists.fd.io/g/vpp-dev/message/22015
Mute This Topic: https://lists.fd.io/mt/94282694/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] libnl as external dependency?

[Pim van Pelt]

Hoi Stanislav,

What's the issue with using libnl3-dev from Ubuntu/Debian? Are you
imagining adding patches from libnl (I'd love to learn more, if you do :-).

groet,
Pim

On Wed, Oct 12, 2022 at 4:58 PM Stanislav Zaikin  wrote:

> Hello folks,
>
> I have a patch to download, build and link statically libnl3 for linux-cp
> netlink plugin (as part of vpp-ext-deps and aligned with other packages in
> build/external/packages/).
>
> Would it be useful for the rest of the community? For instance, not to be
> dependent on the libnl version in the host or to be able to apply custom
> patches for libnl.
>
> --
> Best regards
> Stanislav Zaikin
>
> 
>
>

-- 
Pim van Pelt 
PBVP1-RIPE - http://www.ipng.nl/

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22014): https://lists.fd.io/g/vpp-dev/message/22014
Mute This Topic: https://lists.fd.io/mt/94282694/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] VPP22.10 NAT44 VRF-to-Public

[Mohamed Naiem]

Hi Folks,
I'm new to VPP and trying to work on one setup where I have internal interface 
inside VRF and would like to provide internet connectivity to hosts via NAT.
The egress interface to upstream network has private IP but has default route 
to upstream router then to internet.

What I'm doing for testing, I created one loopback inside VRF 7023 which I want 
to source traffic from to internet.
In FRR which I use for control plane, I configured one default route in VRF to 
egress interface with 'nexthop-vrf default'

1- Interfaces as below

BondEthernet0.2000 (up):

L3 100.65.72.2/25 *> interface to upstream router*

loop10 (up):

L3 10.10.10.1/24 ip4 table-id 7023 fib-idx 2 *> traffic from vrf should be 
NATed*

loop11 (up):

L3 x.x.x.x/32 *> configured public IP here to NAT traffic to*

2- VRF routing on FRR as below.
FRR# show ip route vrf 7023
VRF 7023:
S>* 8.8.8.8/32 [1/0] is directly connected, bond0.2000 (vrf default), weight 1, 
00:29:59
C>* 10.10.10.0/24 is directly connected, lo10, 00:39:35

3- FRR has default route in global table as mentioned to upstream and I have 
internet connectivity from host.

4- I tried below config for NATing which doesn't look to be working for me.

nat44 plugin enable
set interface nat44 in loop10 out BondEthernet0.2000
nat44 add address x.x.x.x tenant-vrf 7023
nat44 forwarding enable

nat44 plugin enable inside-vrf 7023 outside-vrf 0
set interface nat44 in loop10 out BondEthernet0.2000
nat44 add interface address loop11
nat44 forwarding enable

I'm not clear with nat routing as well, my understanding this should be routing 
from vrf to global and might not need vrf default in FRR.

nat44 vrf table add 7023
nat44 vrf route add table 7023 0

if anyone has experience with such setup would appreciate help

Thanks,
Mohamed

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22013): https://lists.fd.io/g/vpp-dev/message/22013
Mute This Topic: https://lists.fd.io/mt/94285006/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] clang-15 fixes

[Damjan Marion via lists.fd.io]

Guys,


I submitted patch which fixes issues reported by clang 15.

https://gerrit.fd.io/r/c/vpp/+/37387

Mainly it is about variables which are computed but never used after….
Please take a look if your code is listed in this patch.

— 
Damjan




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22012): https://lists.fd.io/g/vpp-dev/message/22012
Mute This Topic: https://lists.fd.io/mt/94284807/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

[Florin Coras]

Hi, 

It looks like a bug. We should make sure the fifo exists, which is typically 
the case unless transport is stuck in half-open. Note that tcp does timeout and 
cleanups those stuck half-open sessions, but we should allow the app to cleanup 
as well. 

Let me know if you plan to push a patch or I should do it. 

Regards,
Florin

> On Oct 12, 2022, at 12:44 AM, Zhang Dongya  wrote:
> 
> Hi,
> 
> I am now trying to use vpp host-stack to negotiate a valid TCP session, 
> however, I found if I call vnet_disconnect_session when the TCP stuck in 
> syn-sent state (this may be caused by I have shutdown the remove side).
> 
> Vpp will crash in the following code which call svm_fifo_clear_deq_ntf while 
> the tx_fifo is not inited, this is because the tx_fifo will be allocated init 
> app_worker_init_connected.
> 
> Is this a bug or I have something wrong with my using of host-stack?
> 
> 
> 
> void
> session_close (session_t * s)
> {
>   if (!s)
> return;
> 
>   if (s->session_state >= SESSION_STATE_CLOSING)
> {
>   /* Session will only be removed once both app and transport
>* acknowledge the close */
>   if (s->session_state == SESSION_STATE_TRANSPORT_CLOSED
> || s->session_state == SESSION_STATE_TRANSPORT_DELETED)
>   session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
>   return;
> }
> 
>   /* App closed so stop propagating dequeue notifications */
>   svm_fifo_clear_deq_ntf (s->tx_fifo);
>   s->session_state = SESSION_STATE_CLOSING;
>   session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
> }
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22011): https://lists.fd.io/g/vpp-dev/message/22011
Mute This Topic: https://lists.fd.io/mt/94276501/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] VPP 22.10 RC2 artifacts are available!

[Andrew Yourtchenko]

Hi all,

VPP 22.19 RC2 milestone is complete, artifacts are available at packagecloud.io 

This sets us on to the finish line to the release, which is supposed to happen 
in two weeks.

We are now merging only the critical fixes into stable/2210 branch in 
preparation for the release.

--a /* your friendly 22.10 release manager */
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22010): https://lists.fd.io/g/vpp-dev/message/22010
Mute This Topic: https://lists.fd.io/mt/94283283/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] libnl as external dependency?

[Stanislav Zaikin]

Hello folks,

I have a patch to download, build and link statically libnl3 for linux-cp
netlink plugin (as part of vpp-ext-deps and aligned with other packages in
build/external/packages/).

Would it be useful for the rest of the community? For instance, not to be
dependent on the libnl version in the host or to be able to apply custom
patches for libnl.

-- 
Best regards
Stanislav Zaikin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22009): https://lists.fd.io/g/vpp-dev/message/22009
Mute This Topic: https://lists.fd.io/mt/94282694/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] 2022-10-12 FD.io VPP (master branch) Gerrit Change Report

[Dave Wallace]

New report generated today 
https://gist.github.com/dwallacelf/90f2c3b1a2a59b5bc186d89650826f6b


Please review the report and update/review/merge changes as appropriate.

Thanks,
-daw-

On 9/27/22 10:09 AM, Dave Wallace via lists.fd.io wrote:
New report generated today: 
https://gist.github.com/dwallacelf/4147e4d26ca154698ea3c881426160c3


Please review the report and update/review/merge changes as appropriate.

Thanks,
-daw-


On 9/14/22 3:55 PM, Dave Wallace via lists.fd.io wrote:
New report generated today: 
https://gist.github.com/dwallacelf/c60164b8affb65fdef690d7500d8de1a


Please review the report and update/review/merge changes as appropriate.

Thanks,
-daw-

On 9/1/22 4:04 PM, Dave Wallace via lists.fd.io wrote:

Folks,

I have updated a gerrit change report generator authored by Ole 
Troan [0] to produce a report that categorizes the state of the 
Gerrit review queue.  Each gerrit change is labeled with the 
following status:


== ===
Status Complete    Needs To Be Addressed
== ===
V - verified   v - not verified
E - not expired    e - expired
C - no unresolved comments c - comments not resolved
R - reviewed/approved  r - review incomplete
# - days since update  # - days since update > 30
== ===

Example: [VECr 23]
    - Verified
    - Not Expired
    - No unresolved comments
    - Review incomplete (Code-Review < +1)
    - 23 days since last update

The report generator sorts the gerrit changes into three categories 
based on the state and the person or group required to perform the 
next action:


- Committers:
  Status [VECR xx]: Gerrit Changes that have been verified, are not 
expired, no unresolved comments, & approved by a maintainer.
  Action: A committer should do a final review and submit the change 
or provide comment(s).


- Maintainers:
  Status [VECr]: Gerrit Changes that have been verified, are not 
expired, no unresolved comments, & not reviewed

  Action: The Maintainer should do a code review

- Authors:
  Status : Gerrit Changes that are either not verified, 
expired, or comments not resolved
  Action: Author should rebase the change, fix verification errors, 
and/or resolve comments to move the status to [VECr]


Here is a gist of the report generated today: 
https://gist.github.com/dwallacelf/8f6e7c0ea7ae07cae1460cf49b631e6f


In the near future, I will add this to a github action to generate 
an updated report daily.


Please review the report and look for gerrit changes which require 
your attention.

All feedback welcome.

Thanks,
-daw-

[0] https://github.com/dwallacelf/gerrit-review










-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22008): https://lists.fd.io/g/vpp-dev/message/22008
Mute This Topic: https://lists.fd.io/mt/94282673/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] vpp-debug-verify job enabled per-patch non-voting

[Dave Wallace]

Folks,

After removing the most egregious make test testcases which fail on the 
vpp_debug image, I have re-instated the vpp-debug-verify job as 
non-voting per-patch [0].  I will continue to work on fixing or removing 
testcases which are failing on non-related patches.


Please look for failures reported like this:
https://jenkins.fd.io/job/vpp-debug-verify-master-ubuntu2204-x86_64/1021/ 
: FAILURE (skipped)


Thanks,
-daw-

[0] https://jenkins.fd.io/job/vpp-debug-verify-master-ubuntu2204-x86_64 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22007): https://lists.fd.io/g/vpp-dev/message/22007
Mute This Topic: https://lists.fd.io/mt/94281766/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Crash in VPP22.06 in ip4_mtrie_16_lookup_step

[Benoit Ganne (bganne) via lists.fd.io]

I did not heard anything like this.
Can you try to reproduce with latest master? Do you have some proprietary 
plugins loaded also?

Best
ben

> -Original Message-
> From: vpp-dev@lists.fd.io  On Behalf Of Prashant
> Upadhyaya
> Sent: Wednesday, October 12, 2022 11:32
> To: vpp-dev 
> Subject: [vpp-dev] Crash in VPP22.06 in ip4_mtrie_16_lookup_step
> 
> Hi,
> 
> I am migrating from VPP21.06 where my usecase works without issues
> overnight, but in VPP22.06 it gives the following crash in 7 to 8
> minutes of run.
> Just wondering if this is a known issue or if anybody else has seen this.
> Further, when I run in VPP22.06 with a single worker thread, this
> crash is not seen, but when I run with 2 worker threads, then this
> crash is seen as below.
> With VPP21.06 the crash is not seen regardless of the number of worker
> threads.
> 
> Thread 5 "vpp_wk_1" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fff69156700 (LWP 5408)]
> 0x778327f8 in ip4_mtrie_16_lookup_step
> (dst_address_byte_index=2, dst_address=0x1025d44ea4,
> current_leaf=1915695212)
> at /home/centos/vpp/src/vnet/ip/ip4_mtrie.h:215
> 215   return (ply->leaves[dst_address-
> >as_u8[dst_address_byte_index]]);
> (gdb) bt
> #0  0x778327f8 in ip4_mtrie_16_lookup_step
> (dst_address_byte_index=2, dst_address=0x1025d44ea4,
> current_leaf=1915695212)
> at /home/centos/vpp/src/vnet/ip/ip4_mtrie.h:215
> #1  ip4_fib_forwarding_lookup (addr=0x1025d44ea4, fib_index=1) at
> /home/centos/vpp/src/vnet/fib/ip4_fib.h:146
> #2  ip4_lookup_inline (frame=0x7fffbc805a80, node=,
> vm=0x7fffbc72bc40) at /home/centos/vpp/src/vnet/ip/ip4_forward.h:327
> #3  ip4_lookup_node_fn_skx (vm=0x7fffbc72bc40, node=0x7fffbc7bc400,
> frame=0x7fffbc805a80) at
> /home/centos/vpp/src/vnet/ip/ip4_forward.c:101
> #4  0x77ea2a45 in dispatch_node (last_time_stamp= out>, frame=0x7fffbc805a80, dispatch_state=VLIB_NODE_STATE_POLLING,
> type=VLIB_NODE_TYPE_INTERNAL, node=0x7fffbc7bc400,
> vm=0x7fffbc7bc400) at /home/centos/vpp/src/vlib/main.c:961
> #5  dispatch_pending_node (vm=vm@entry=0x7fffbc72bc40,
> pending_frame_index=pending_frame_index@entry=6,
> last_time_stamp=)
> at /home/centos/vpp/src/vlib/main.c:1120
> #6  0x77ea4639 in vlib_main_or_worker_loop (is_main=0,
> vm=0x7fffbc72bc40, vm@entry=0x7fffb8c96700)
> at /home/centos/vpp/src/vlib/main.c:1589
> #7  vlib_worker_loop (vm=vm@entry=0x7fffbc72bc40) at
> /home/centos/vpp/src/vlib/main.c:1723
> #8  0x77edea81 in vlib_worker_thread_fn (arg=0x7fffb8cd5640)
> at /home/centos/vpp/src/vlib/threads.c:1579
> #9  0x77edde33 in vlib_worker_thread_bootstrap_fn
> (arg=0x7fffb8cd5640) at /home/centos/vpp/src/vlib/threads.c:418
> #10 0x76638ea5 in start_thread (arg=0x7fff69156700) at
> pthread_create.c:307
> #11 0x75db5b0d in clone () at
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
> 
> Regards
> -Prashant

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22006): https://lists.fd.io/g/vpp-dev/message/22006
Mute This Topic: https://lists.fd.io/mt/94277299/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Throughput of VPP on KVM is Significantly Worse than Linux Kernel

[Mohsin Kazmi via lists.fd.io]

Hi,

You can use VPP native virtio driver in VM.


./dpdk-devbind.py -b vfio-pci 00:03.0 00:04.0

cd /home/vpp


set loggin class pci level debug

set loggin class virtio level debug

create int virtio :00:03.0 gso-enabled

create int virtio :00:04.0 gso-enabled



https://s3-docs.fd.io/vpp/22.10/cli-reference/clis/clicmd_src_vnet_gso.html is 
the command to use software segmentation of packets when interface doesn’t 
support offload. While you need to enable GSO on the interfaces instead of 
chunking in the software.



Please pin the VM threads and Iperf threads to get the performance results.

-Best Regards,
Mohsin Kazmi

From: vpp-dev@lists.fd.io  on behalf of Xiaodong Xu 

Date: Thursday, October 6, 2022 at 10:24 PM
To: vpp-dev@lists.fd.io 
Subject: Re: [vpp-dev] Throughput of VPP on KVM is Significantly Worse than 
Linux Kernel
Hi Wentian,

Please take a look at 
https://s3-docs.fd.io/vpp/22.10/cli-reference/clis/clicmd_src_vnet_gso.html for 
the GSO feature in VPP.
I tried to turn on the TSO option too, however VPP doesn't seem to be able to 
forward traffic once TSO is turned on.

The test case for vhost-user driver I had run is similar to the topo shown at 
https://wiki.fd.io/view/VPP/Use_VPP_to_Chain_VMs_Using_Vhost-User_Interface#Two_Chained_QEMU_Instances_with_VPP_Vhost-User_Interfaces.
 The difference is that I don't have the 'VPP l2 xc1' / 'VPP l2 xc3' instances 
in the diagram, also the 'testpmd' application is replaced with VPP in my 
testing. You do need a VPP instance running on the host machine though, in 
order to bridge the two VMs together.

Xiaodong
On Thu, Oct 6, 2022 at 7:40 AM Bu Wentian 
mailto:buwent...@outlook.com>> wrote:
Hi Xiaodong,

Could you please tell me how to enable GSO in VPP? I read the startup.conf and 
searched the VPP documents but didn't find options about GSO. I found a TSO 
option in the default startup.conf. According to the comment, the "tso on" 
option must be enabled with "enable-tcp-udp-checksum" set. However, I tried to 
do so, but the VPP failed to start after enabling the two options.

I also read the document you mentioned 
(https://www.redhat.com/en/blog/hands-vhost-user-warm-welcome-dpdk), and I 
found a similar example in VPP document: 
https://s3-docs.fd.io/vpp/22.06/usecases/vhost/index.html . But the two 
examples both seem to using VPP as a bridge in the host, and run test in VMs. 
In my application scene, I need to run VPP in the guest rather than host. Can 
vhost-user work in this scene?


Sincerely,
Wentian



发件人: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>> 代表 Xiaodong Xu 
mailto:stid.s...@gmail.com>>
发送时间: 2022年10月6日 0:40
收件人: vpp-dev@lists.fd.io 
mailto:vpp-dev@lists.fd.io>>
主题: Re: [vpp-dev] Throughput of VPP on KVM is Significantly Worse than Linux 
Kernel

I actually tried to enable GSO on both input and output interfaces in VPP, and 
got a little bit of difference for the result. In most cases the throughput 
would be the same, but in some cases I see a burst of 4.5Gbps (3x of the 
original rate).

As Benoit said, even without GSO the throughput is way too low for VPP. I also 
see that KVM has the options 'gso', 'tso4' for either host or guest 
(https://libvirt.org/formatdomain.html#setting-nic-driver-specific-options)
 but they are all turned on by default.

In the meanwhile, I wonder if there is a GRO option (or maybe jumbo frame?) for 
VPP? As I suppose the GSO option applies to sending rather than receiving.

Regards,
Xiaodong

On Wed, Oct 5, 2022 at 8:55 AM Bu Wentian 
mailto:buwent...@outlook.com>> wrote:
Hi Benoit,
I checked the packet sizes by tcpdump, and the result is similar to what you 
said. I ran iperf server on M2 and iperf client on M1, and tcpdump on both. I 
found that on M1(sender), most of the packet length in tcpdump were 65160, 
irrespective of which dataplane the router used. However, on M2(receiver), when 
using Linux kernel as router, most of the packet length were 65160; when using 
VPP as router, most of the packet length varied from 1448 to 5792. I have 
pasted some output of tcpdump below.

I have tried some tuning tricks on VPP VM such as CPU pinning,  but didn't get 
significant improve on throughput. Xiaodong also said that the bottleneck is 
not CPU. I am not sure whether it is GSO that caused the performance difference 
between Linux routing and VPP routing. I still have a problem: since the Linux 
routing and VPP routing both work on Layer3, which means that they don't care 
about w

[vpp-dev] Crash in VPP22.06 in ip4_mtrie_16_lookup_step

[Prashant Upadhyaya]

Hi,

I am migrating from VPP21.06 where my usecase works without issues
overnight, but in VPP22.06 it gives the following crash in 7 to 8
minutes of run.
Just wondering if this is a known issue or if anybody else has seen this.
Further, when I run in VPP22.06 with a single worker thread, this
crash is not seen, but when I run with 2 worker threads, then this
crash is seen as below.
With VPP21.06 the crash is not seen regardless of the number of worker threads.

Thread 5 "vpp_wk_1" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff69156700 (LWP 5408)]
0x778327f8 in ip4_mtrie_16_lookup_step
(dst_address_byte_index=2, dst_address=0x1025d44ea4,
current_leaf=1915695212)
at /home/centos/vpp/src/vnet/ip/ip4_mtrie.h:215
215   return (ply->leaves[dst_address->as_u8[dst_address_byte_index]]);
(gdb) bt
#0  0x778327f8 in ip4_mtrie_16_lookup_step
(dst_address_byte_index=2, dst_address=0x1025d44ea4,
current_leaf=1915695212)
at /home/centos/vpp/src/vnet/ip/ip4_mtrie.h:215
#1  ip4_fib_forwarding_lookup (addr=0x1025d44ea4, fib_index=1) at
/home/centos/vpp/src/vnet/fib/ip4_fib.h:146
#2  ip4_lookup_inline (frame=0x7fffbc805a80, node=,
vm=0x7fffbc72bc40) at /home/centos/vpp/src/vnet/ip/ip4_forward.h:327
#3  ip4_lookup_node_fn_skx (vm=0x7fffbc72bc40, node=0x7fffbc7bc400,
frame=0x7fffbc805a80) at
/home/centos/vpp/src/vnet/ip/ip4_forward.c:101
#4  0x77ea2a45 in dispatch_node (last_time_stamp=, frame=0x7fffbc805a80, dispatch_state=VLIB_NODE_STATE_POLLING,
type=VLIB_NODE_TYPE_INTERNAL, node=0x7fffbc7bc400,
vm=0x7fffbc7bc400) at /home/centos/vpp/src/vlib/main.c:961
#5  dispatch_pending_node (vm=vm@entry=0x7fffbc72bc40,
pending_frame_index=pending_frame_index@entry=6,
last_time_stamp=)
at /home/centos/vpp/src/vlib/main.c:1120
#6  0x77ea4639 in vlib_main_or_worker_loop (is_main=0,
vm=0x7fffbc72bc40, vm@entry=0x7fffb8c96700)
at /home/centos/vpp/src/vlib/main.c:1589
#7  vlib_worker_loop (vm=vm@entry=0x7fffbc72bc40) at
/home/centos/vpp/src/vlib/main.c:1723
#8  0x77edea81 in vlib_worker_thread_fn (arg=0x7fffb8cd5640)
at /home/centos/vpp/src/vlib/threads.c:1579
#9  0x77edde33 in vlib_worker_thread_bootstrap_fn
(arg=0x7fffb8cd5640) at /home/centos/vpp/src/vlib/threads.c:418
#10 0x76638ea5 in start_thread (arg=0x7fff69156700) at
pthread_create.c:307
#11 0x75db5b0d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Regards
-Prashant

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22004): https://lists.fd.io/g/vpp-dev/message/22004
Mute This Topic: https://lists.fd.io/mt/94277299/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] Geneve Tunnel

[BAUER Stephan]

Hello all,

i have the following topology:

 With the following configuration (VPP-Host1, VPP-Host2 has the same config
with the other addresses):












*set int state GigabitEthernet2/6/0 upset int ip address
GigabitEthernet2/6/0 10.10.1.1/24 create
host-interface name vpp1outset int state host-vpp1out upset int ip address
host-vpp1out 10.10.4.2/24 ip route add 10.10.5.0/24
 via 10.10.1.2ip route add 10.10.2.0/24
 via 10.10.1.2create geneve tunnel local 10.10.1.1
remote 10.10.2.1 vni 13 l3-modeset int state geneve_tunnel0 upset int ip
address geneve_tunnel0 10.10.3.1/24 *

Every host in 10.10.1, 10.10.2, 10.10.4 and 10.10.5 can reach every other
host in any of those subnets. Only 10.10.3.1 cannot reach out to 10.10.3.2
(the tunnel is not working). On the bridge, I have Wireshark capturing the
packets, I see ARP Requests from 10.10.3.1 to 10.10.3.2, but 10.10.3.2 does
not respond. Maybe I misconfigured something? It looks like the Geneve
tunnels are sending, but not receiving anything. Does anyone have an Idea
what's wrong?

The ARP- Request:



Thanks in advance,

Stephan Bauer

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22003): https://lists.fd.io/g/vpp-dev/message/22003
Mute This Topic: https://lists.fd.io/mt/94276876/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[vpp-dev] vpp crash when close a host-stack tcp session in syn-sent state.

[Zhang Dongya]

Hi,

I am now trying to use vpp host-stack to negotiate a valid TCP session,
however, I found if I call vnet_disconnect_session when the TCP stuck in
syn-sent state (this may be caused by I have shutdown the remove side).

Vpp will crash in the following code which call svm_fifo_clear_deq_ntf
while the tx_fifo is not inited, this is because the tx_fifo will be
allocated init app_worker_init_connected.

Is this a bug or I have something wrong with my using of host-stack?



void
session_close (session_t * s)
{
if (!s)
return;

if (s->session_state >= SESSION_STATE_CLOSING)
{
/* Session will only be removed once both app and transport
* acknowledge the close */
if (s->session_state == SESSION_STATE_TRANSPORT_CLOSED
|| s->session_state == SESSION_STATE_TRANSPORT_DELETED)
session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
return;
}

/* App closed so stop propagating dequeue notifications */
svm_fifo_clear_deq_ntf (s->tx_fifo);
s->session_state = SESSION_STATE_CLOSING;
session_program_transport_ctrl_evt (s, SESSION_CTRL_EVT_CLOSE);
}

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#22002): https://lists.fd.io/g/vpp-dev/message/22002
Mute This Topic: https://lists.fd.io/mt/94276501/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-