Re: [vpp-dev] Fixing nat44ed vrf api handlers
I split it up and it's ready for review: https://gerrit.fd.io/r/c/vpp/+/38459 https://gerrit.fd.io/r/c/vpp/+/38551 I have last one question: In case API doesn't return all data (e.g nat44_ed_vrf_tables_send_details missing table_vrf_id assign of value) and if I decide to add it. Is it considered as silent behaviour change? Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22770): https://lists.fd.io/g/vpp-dev/message/22770 Mute This Topic: https://lists.fd.io/mt/97774402/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Fixing nat44ed vrf api handlers
Thanks for the reasonable explanations. So the option could be splitting it into two patches. The first could fix replies and the second could contain a new experimental API nat44_ed_vrf_tables_send_details_v2. I think it might be okay after that. Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22750): https://lists.fd.io/g/vpp-dev/message/22750 Mute This Topic: https://lists.fd.io/mt/97774402/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] Fixing nat44ed vrf api handlers
Hello Guys, I wrote a short patch to fix a couple api handlers for nat44ed [1] . ( https://gerrit.fd.io/r/c/vpp/+/38459 ) It was probably forgotten, so I'm reminding myself. I still have a question about whether it is possible to cherry-pick the patch to vpp v23.02 and 22.10. [1] https://gerrit.fd.io/r/c/vpp/+/38459 Thanks, Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22746): https://lists.fd.io/g/vpp-dev/message/22746 Mute This Topic: https://lists.fd.io/mt/97774402/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Memif performance
Hi Praveen, >From what I heard in the past. Gomemif does not reach such a throughput as >libmemif. If I may give you advice, use Go-libmemif ( >https://github.com/FDio/govpp/tree/master/extras/libmemif ) instead of >Gomemif. Anyway I will look into it if there is something wrong with the >gomemif. Dan. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#22177): https://lists.fd.io/g/vpp-dev/message/22177 Mute This Topic: https://lists.fd.io/mt/94956458/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/1480452/21656/631435203/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Help needed in bringing up memif with shm_open.
Hi,
To sync up, can you run loopback example?
I tried to reproduce your problem on 3.10.0-229.1.2.rt56.141.2.el7_1.x86_64 but
I got different result.
diff --git a/extras/libmemif/src/CMakeLists.txt
b/extras/libmemif/src/CMakeLists.txt
index ddb8a52..a11a65f 100644
--- a/extras/libmemif/src/CMakeLists.txt
+++ b/extras/libmemif/src/CMakeLists.txt
@@ -41,6 +41,12 @@ if(LIB_BSD)
target_link_libraries(memif ${LIB_BSD})
endif()
+find_library(LIB_LRT rt)
+if(LIB_BSD)
+ add_compile_definitions(HAS_LIB_LRT)
+ target_link_libraries(memif ${LIB_LRT})
+endif()
+
foreach(file ${MEMIF_HEADERS})
get_filename_component(dir ${file} DIRECTORY)
install(
diff --git a/extras/libmemif/src/main.c b/extras/libmemif/src/main.c
index 21b3994..132ce8d 100644
--- a/extras/libmemif/src/main.c
+++ b/extras/libmemif/src/main.c
@@ -184,6 +184,7 @@ memif_get_version_str ()
#define DBG_TX_BUF (0)
#define DBG_RX_BUF (1)
+#define MEMIF_DBG_SHM 1
#ifdef MEMIF_DBG_SHM
static void
@@ -1234,13 +1235,17 @@ memif_add_region (memif_connection_t *conn, uint8_t
has_buffers)
r->region_size = (has_buffers == 0) ? r->buffer_offset : r->buffer_offset +
conn->run_args.buffer_size * (1 << conn->run_args.log2_ring_size) *
(conn->run_args.num_s2m_rings + conn->run_args.num_m2s_rings);
-
+/*
if ((r->fd = memfd_create ("memif region 0", MFD_ALLOW_SEALING)) == -1)
return memif_syscall_error_handler (errno);
+*/
+ if ((r->fd = shm_open ("memif region 0", O_RDWR | O_CREAT, S_IRWXU)) == -1)
+return memif_syscall_error_handler (errno);
+/*
if ((fcntl (r->fd, F_ADD_SEALS, F_SEAL_SHRINK)) == -1)
return memif_syscall_error_handler (errno);
-
+*/
if ((ftruncate (r->fd, r->region_size)) == -1)
return memif_syscall_error_handler (errno);
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#21449): https://lists.fd.io/g/vpp-dev/message/21449
Mute This Topic: https://lists.fd.io/mt/91224655/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[vpp-dev] Memif can't link up after admin down
Hello there, I pushed the patch for VPP-1959 and I would be grateful for a review.(The patch contains fix and test.) https://gerrit.fd.io/r/c/vpp/+/34320 Long story short: After command #set interface state memif0/0 down is called vnet_sw_interface_set_flags_helper() where on the end of function is link-up changed to link-down. Unfortunately Admin-up wont link-up the memif interface again. Best regards, Daniel -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#20459): https://lists.fd.io/g/vpp-dev/message/20459 Mute This Topic: https://lists.fd.io/mt/86927715/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
