[vpp-dev] ACL panics in `hash_acl_set_heap`

2020-09-16 Thread Mahdi Varasteh
Hi VPP folks,

Setting ACL from VAPI, we have a panic `ACL plugin failed to allocate lookup 
heap of %U bytes` in `hash_acl_set_heap` function.
It doesn't happen always. Time to time and randomly this problem occurs. My 
system has 8G of RAM. VPP is running with the default `startup.conf`. I've set 
1024 hugepages, size 2M.

So any idea where should i look for the error? If it's necessary to change any 
setting, I'd be glad to hear out.

If any more information is needed, Inform me.

Regards, Mahdi.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17419): https://lists.fd.io/g/vpp-dev/message/17419
Mute This Topic: https://lists.fd.io/mt/76882936/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] ACL panics in `hash_acl_set_heap`

2020-09-16 Thread Andrew Yourtchenko
ACL plugin historically uses its own heaps for hash lookup data. It should be 
just 64M by default. It’s been like that since day1, so you might need to look 
at your memory usage on that box overall... 

I am not sure if custom heaps use the huge pages or not - maybe you need to 
have less huge pages.

I just had a discussion today about possibly getting rid of custom heap for the 
ACL plugin, due to it being in the way of other infra optimizations.

So you can give a shot to 
https://gerrit.fd.io/r/c/vpp/+/28882 

But it probably will only only go into 20.01; and will probably more hide the 
problem you are seeing, than anything. 

--a

>> On 16 Sep 2020, at 09:46, Mahdi Varasteh  wrote:
> Hi VPP folks,
> 
> Setting ACL from VAPI, we have a panic `ACL plugin failed to allocate lookup 
> heap of %U bytes` in `hash_acl_set_heap` function.
> It doesn't happen always. Time to time and randomly this problem occurs. My 
> system has 8G of RAM. VPP is running with the default `startup.conf`. I've 
> set 1024 hugepages, size 2M.
> 
> So any idea where should i look for the error? If it's necessary to change 
> any setting, I'd be glad to hear out.
> 
> If any more information is needed, Inform me.
> 
> Regards, Mahdi. 
> 
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#17422): https://lists.fd.io/g/vpp-dev/message/17422
Mute This Topic: https://lists.fd.io/mt/76882936/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [vpp-dev] ACL panics in `hash_acl_set_heap`

2020-09-16 Thread Mahdi Varasteh
Hi Andrew,

Thanks for you response. That makes sense. I will monitor my box memory usage.
Unfortunately I'm using VPP 20.05. So I will try to forwardport( we have it? 
:D) this patch to it.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17433): https://lists.fd.io/g/vpp-dev/message/17433
Mute This Topic: https://lists.fd.io/mt/76882936/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] ACL panics in `hash_acl_set_heap`

2020-09-16 Thread Andrew Yourtchenko
Hi Mahdi,

This patch should apply, ACL plugin had not seen much changes recently, but 
then you are not running a 20.05 anymore :-)

I would strongly suggest to evaluate on what limitations prevent you from 
following the master branch as close as possible and address them. This may 
seem daunting, but based on my experience with a dozen or so scenarios, 
following master is the most sustainable and flexible approach in the long 
term. 

With the current API compatibility process that went into action shortly past 
20.05, *if* you are using VPP as is, 20.09 should be a ~zero-cost move that you 
can evaluate (there are only 2 incompatible APIs in the “production” ones). 
(And then when you fix any usage of APIs deprecated in 20.09, 21.01 upgrade in 
the future will be similar zero-cost).

If you notice that the upgrade is painful for some reason, this will highlight 
the architectural issues/questions that need to be resolved. It’s much better 
to do it early and proactively.

—a 

> On 17 Sep 2020, at 06:01, Mahdi Varasteh  wrote:
> 
> Hi Andrew,
> 
> Thanks for you response. That makes sense. I will monitor my box memory usage.
> Unfortunately I'm using VPP 20.05. So I will try to forwardport( we have it? 
> :D) this patch to it. 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#17434): https://lists.fd.io/g/vpp-dev/message/17434
Mute This Topic: https://lists.fd.io/mt/76882936/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-