Re: [vpp-dev] Missing session.api.h file

[Dave Barach (dbarach)]

Cool... Thanks… Dave

From: Jon Loeliger [mailto:j...@netgate.com]
Sent: Sunday, March 5, 2017 10:06 AM
To: Dave Barach (dbarach) <dbar...@cisco.com>
Cc: Florin Coras <fcoras.li...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] Missing session.api.h file



On Sat, Mar 4, 2017 at 7:57 AM, Dave Barach (dbarach) 
<dbar...@cisco.com<mailto:dbar...@cisco.com>> wrote:
See https://gerrit.fd.io/r/#/c/5622...

Thanks… Dave

From: Dave Barach (dbarach)
Sent: Friday, March 3, 2017 10:50 PM
To: Jon Loeliger <j...@netgate.com<mailto:j...@netgate.com>>
Cc: Florin Coras <fcoras.li...@gmail.com<mailto:fcoras.li...@gmail.com>>; 
vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>>
Subject: RE: [vpp-dev] Missing session.api.h file

Oh, no need to bisect or otherwise screw around. I found the problem.

Too many routines called “vat_api_hookup” floating around, resulting in 
repeated calls to the version in api_format.c. I caught the dpdk plugin doing 
it, and I think there’s at least one more.

I’ll fix it in the morning. I’m too sleepy to do it accurately right now.

Thanks… Dave

Dave,

Your patch cleared that problem up nicely!

Thanks,
jdl

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Jon Loeliger]

On Sat, Mar 4, 2017 at 7:57 AM, Dave Barach (dbarach) <dbar...@cisco.com>
wrote:

> See https://gerrit.fd.io/r/#/c/5622...
>
>
>
> Thanks… Dave
>
>
>
> *From:* Dave Barach (dbarach)
> *Sent:* Friday, March 3, 2017 10:50 PM
> *To:* Jon Loeliger <j...@netgate.com>
> *Cc:* Florin Coras <fcoras.li...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io>
> *Subject:* RE: [vpp-dev] Missing session.api.h file
>
>
>
> Oh, no need to bisect or otherwise screw around. I found the problem.
>
>
>
> Too many routines called “vat_api_hookup” floating around, resulting in
> repeated calls to the version in api_format.c. I caught the dpdk plugin
> doing it, and I think there’s at least one more.
>
>
>
> I’ll fix it in the morning. I’m too sleepy to do it accurately right now.
>
>
>
> Thanks… Dave
>

Dave,

Your patch cleared that problem up nicely!

Thanks,
jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Dave Barach (dbarach)]

See https://gerrit.fd.io/r/#/c/5622...

Thanks… Dave

From: Dave Barach (dbarach)
Sent: Friday, March 3, 2017 10:50 PM
To: Jon Loeliger <j...@netgate.com>
Cc: Florin Coras <fcoras.li...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io>
Subject: RE: [vpp-dev] Missing session.api.h file

Oh, no need to bisect or otherwise screw around. I found the problem.

Too many routines called “vat_api_hookup” floating around, resulting in 
repeated calls to the version in api_format.c. I caught the dpdk plugin doing 
it, and I think there’s at least one more.

I’ll fix it in the morning. I’m too sleepy to do it accurately right now.

Thanks… Dave

From: Jon Loeliger [mailto:j...@netgate.com]
Sent: Friday, March 3, 2017 10:43 PM
To: Dave Barach (dbarach) <dbar...@cisco.com<mailto:dbar...@cisco.com>>
Cc: Florin Coras <fcoras.li...@gmail.com<mailto:fcoras.li...@gmail.com>>; 
vpp-dev <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>>
Subject: Re: [vpp-dev] Missing session.api.h file

On Fri, Mar 3, 2017 at 9:20 PM, Dave Barach (dbarach) 
<dbar...@cisco.com<mailto:dbar...@cisco.com>> wrote:
BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler' means pretty much what it 
says. Two places in the code are registering handlers for that specific 
message. Last registrant wins.

I found and fixed 30 of these when I first added the check. Most were 
relatively benign - duplicate but identical routines left around after the 
vpe.api break-up. I found one which was not benign, code working only by 
accident.

Yeah, I figured as much.  My mystery is that I didn't change any of my
code except for pulling new VPP from upstream.   I think.


I’ve started a build of master/latest to see what I see...

 I'll try to bisect it or something, but it may be Monday before I get to it.

Thanks… Dave

Thanks,
jdl

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Dave Barach (dbarach)]

Oh, no need to bisect or otherwise screw around. I found the problem.

Too many routines called “vat_api_hookup” floating around, resulting in 
repeated calls to the version in api_format.c. I caught the dpdk plugin doing 
it, and I think there’s at least one more.

I’ll fix it in the morning. I’m too sleepy to do it accurately right now.

Thanks… Dave

From: Jon Loeliger [mailto:j...@netgate.com]
Sent: Friday, March 3, 2017 10:43 PM
To: Dave Barach (dbarach) <dbar...@cisco.com>
Cc: Florin Coras <fcoras.li...@gmail.com>; vpp-dev <vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] Missing session.api.h file

On Fri, Mar 3, 2017 at 9:20 PM, Dave Barach (dbarach) 
<dbar...@cisco.com<mailto:dbar...@cisco.com>> wrote:
BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler' means pretty much what it 
says. Two places in the code are registering handlers for that specific 
message. Last registrant wins.

I found and fixed 30 of these when I first added the check. Most were 
relatively benign - duplicate but identical routines left around after the 
vpe.api break-up. I found one which was not benign, code working only by 
accident.

Yeah, I figured as much.  My mystery is that I didn't change any of my
code except for pulling new VPP from upstream.   I think.


I’ve started a build of master/latest to see what I see...

 I'll try to bisect it or something, but it may be Monday before I get to it.

Thanks… Dave

Thanks,
jdl

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Dave Barach (dbarach)]

BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler' means pretty much what it 
says. Two places in the code are registering handlers for that specific 
message. Last registrant wins.

I found and fixed 30 of these when I first added the check. Most were 
relatively benign - duplicate but identical routines left around after the 
vpe.api break-up. I found one which was not benign, code working only by 
accident.

I’ve started a build of master/latest to see what I see...

Thanks… Dave

From: vpp-dev-boun...@lists.fd.io [mailto:vpp-dev-boun...@lists.fd.io] On 
Behalf Of Jon Loeliger
Sent: Friday, March 3, 2017 10:07 PM
To: Florin Coras <fcoras.li...@gmail.com>
Cc: vpp-dev <vpp-dev@lists.fd.io>
Subject: Re: [vpp-dev] Missing session.api.h file

On Fri, Mar 3, 2017 at 7:11 PM, Jon Loeliger 
<j...@netgate.com<mailto:j...@netgate.com>> wrote:
On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras 
<fcoras.li...@gmail.com<mailto:fcoras.li...@gmail.com>> wrote:
Hi Jon,

Apologies about that. Alexander was kind enough to provide a quick solution 
here [1]. Will merge as soon as it passes verify.

Florin


Awesome!  Thank you!

jdl

That seems to have worked!

Thank you!


So, a different question now  Did something change about the
order or intended correct inclusion of the API message files?
That might be vague, sorry...

I'm now seeing these messages on VPP startup.

/usr/bin/vpp[2599]: vl_msg_api_config:672: BUG: multiple registrations of 
'vl_api_sw_interface_tag_add_del_reply_t_handler'

It all seems to be working so far, but am I somehow managing
to call in an API registration for each message twice now?
Like, did the include files somehow end up doubled up or something?

Yeah, I don't know either yet...

jdl


___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Jon Loeliger]

On Fri, Mar 3, 2017 at 7:11 PM, Jon Loeliger  wrote:

> On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras 
> wrote:
>
>> Hi Jon,
>>
>> Apologies about that. Alexander was kind enough to provide a quick
>> solution here [1]. Will merge as soon as it passes verify.
>>
>> Florin
>>
>
>
> Awesome!  Thank you!
>
> jdl
>

That seems to have worked!

Thank you!


So, a different question now  Did something change about the
order or intended correct inclusion of the API message files?
That might be vague, sorry...

I'm now seeing these messages on VPP startup.

/usr/bin/vpp[2599]: vl_msg_api_config:672: BUG: multiple registrations of
'vl_api_sw_interface_tag_add_del_reply_t_handler'

It all seems to be working so far, but am I somehow managing
to call in an API registration for each message twice now?
Like, did the include files somehow end up doubled up or something?

Yeah, I don't know either yet...

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Jon Loeliger]

On Fri, Mar 3, 2017 at 6:54 PM, Florin Coras  wrote:

> Hi Jon,
>
> Apologies about that. Alexander was kind enough to provide a quick
> solution here [1]. Will merge as soon as it passes verify.
>
> Florin
>


Awesome!  Thank you!

jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

Re: [vpp-dev] Missing session.api.h file

[Florin Coras]

Hi Jon, 

Apologies about that. Alexander was kind enough to provide a quick solution 
here [1]. Will merge as soon as it passes verify.

Florin

[1] https://gerrit.fd.io/r/#/c/5621/ 

> On Mar 3, 2017, at 4:38 PM, Jon Loeliger  wrote:
> 
> VPP-ers,
> 
> I've just build RPM packages out of the current top-of-tree VPP at
> commit c83c3b7f117b981b677f646a0e30f44ec70de239.
> 
> After a yum install, a file in /usr/include/ references session.api.h:
> 
> $ grep -r session.api.h /usr/include/
> /usr/include/vnet/vnet_all_api_h.h:#include 
> 
> Yet it is not installed:
> 
> $ find /usr/include -name session\*
> /usr/include/vnet/session
> /usr/include/vnet/session/session.h
> 
> In fact, if you look in the RPM build staging directory, it is missing
> there as well:
> 
> $ find  build-root/install-vpp-native/vpp/include/ -name session\*
> build-root/install-vpp-native/vpp/include/vnet/session
> build-root/install-vpp-native/vpp/include/vnet/session/session.h
> 
> Thanks,
> jdl
> 
> ___
> vpp-dev mailing list
> vpp-dev@lists.fd.io
> https://lists.fd.io/mailman/listinfo/vpp-dev

___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev

[vpp-dev] Missing session.api.h file

[Jon Loeliger]

VPP-ers,

I've just build RPM packages out of the current top-of-tree VPP at
commit c83c3b7f117b981b677f646a0e30f44ec70de239.

After a yum install, a file in /usr/include/ references session.api.h:

$ grep -r session.api.h /usr/include/
/usr/include/vnet/vnet_all_api_h.h:#include 

Yet it is not installed:

$ find /usr/include -name session\*
/usr/include/vnet/session
/usr/include/vnet/session/session.h

In fact, if you look in the RPM build staging directory, it is missing
there as well:

$ find  build-root/install-vpp-native/vpp/include/ -name session\*
build-root/install-vpp-native/vpp/include/vnet/session
build-root/install-vpp-native/vpp/include/vnet/session/session.h

Thanks,
jdl
___
vpp-dev mailing list
vpp-dev@lists.fd.io
https://lists.fd.io/mailman/listinfo/vpp-dev