Re: [vpp-dev] missing API trace output

2021-05-18 Thread Matthew Smith via lists.fd.io
Hi Ole,

I just tested. Your patch fixes the problem. I can see gre_tunnel_add_del
and gre_tunnel_dump in a trace now.

Thanks!
-Matt


On Tue, May 18, 2021 at 4:55 AM  wrote:

> Hi Matt,
>
> Would you mind seeing if this solves the issue?
> https://gerrit.fd.io/r/c/vpp/+/32358
>
> Cheers,
> Ole
>
>
> > On 14 May 2021, at 22:04, Matthew Smith via lists.fd.io  netgate@lists.fd.io> wrote:
> >
> > Hi all,
> >
> > When I create a GRE tunnel using the API, and then try to look at an API
> trace to see exactly how it was added, the gre_tunnel_add_del message
> requesting the tunnel creation does not show up in the output. Neither do
> subsequent gre_tunnel_dump messages. The tunnels are successfully created
> and when I send a gre_tunnel_dump I receive a gre_tunnel_details, so I know
> the messages are being received and processed.
> >
> > I'm retrieving the trace by running:
> >
> > vppctl api trace save foo
> > vppctl api trace dump /tmp/foo
> >
> > The build I'm seeing this on is from a copy of master from wednesday.
> This is the last commit:
> > fd77f8c00 quic: remove cmake --target
> >
> > I poked around and tracked this down to api_global_main.api_trace_cfg
> having trace_enable set to 0 on the entries for the GRE messages:
> >
> > (gdb) p api_global_main.msg_names[1253]
> > $23 = 0x7f95985ed677 "gre_tunnel_add_del"
> > (gdb) p api_global_main.api_trace_cfg[1253]
> > $24 = {size = 0, trace_enable = 0, replay_enable = 0}
> >
> > (gdb) p api_global_main.msg_names[1255]
> > $27 = 0x7f95985ed6a3 "gre_tunnel_dump"
> > (gdb) p api_global_main.api_trace_cfg[1255]
> > $28 = {size = 0, trace_enable = 0, replay_enable = 0}
> >
> > Are the GRE messages intentionally excluded from being traced? Or is
> this an oversight?
> >
> > Thanks!
> > -Matt
> >
> >
> > 
> >
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19402): https://lists.fd.io/g/vpp-dev/message/19402
Mute This Topic: https://lists.fd.io/mt/82833140/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] missing API trace output

2021-05-18 Thread Ole Troan
Hi Matt,

Would you mind seeing if this solves the issue?
https://gerrit.fd.io/r/c/vpp/+/32358

Cheers,
Ole


> On 14 May 2021, at 22:04, Matthew Smith via lists.fd.io 
>  wrote:
> 
> Hi all,
> 
> When I create a GRE tunnel using the API, and then try to look at an API 
> trace to see exactly how it was added, the gre_tunnel_add_del message 
> requesting the tunnel creation does not show up in the output. Neither do 
> subsequent gre_tunnel_dump messages. The tunnels are successfully created and 
> when I send a gre_tunnel_dump I receive a gre_tunnel_details, so I know the 
> messages are being received and processed.
> 
> I'm retrieving the trace by running:
> 
> vppctl api trace save foo
> vppctl api trace dump /tmp/foo
> 
> The build I'm seeing this on is from a copy of master from wednesday. This is 
> the last commit:
> fd77f8c00 quic: remove cmake --target
> 
> I poked around and tracked this down to api_global_main.api_trace_cfg having 
> trace_enable set to 0 on the entries for the GRE messages:
> 
> (gdb) p api_global_main.msg_names[1253]
> $23 = 0x7f95985ed677 "gre_tunnel_add_del"
> (gdb) p api_global_main.api_trace_cfg[1253]
> $24 = {size = 0, trace_enable = 0, replay_enable = 0}
> 
> (gdb) p api_global_main.msg_names[1255]
> $27 = 0x7f95985ed6a3 "gre_tunnel_dump"
> (gdb) p api_global_main.api_trace_cfg[1255]
> $28 = {size = 0, trace_enable = 0, replay_enable = 0}
> 
> Are the GRE messages intentionally excluded from being traced? Or is this an 
> oversight?
> 
> Thanks!
> -Matt
> 
> 
> 
> 



signature.asc
Description: Message signed with OpenPGP

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19398): https://lists.fd.io/g/vpp-dev/message/19398
Mute This Topic: https://lists.fd.io/mt/82833140/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [vpp-dev] missing API trace output

2021-05-18 Thread Ole Troan
Hi Matt,

Might be an oversight in code auto-generation. Looking.

Cheers,
Ole

> On 14 May 2021, at 22:04, Matthew Smith via lists.fd.io 
>  wrote:
> 
> Hi all,
> 
> When I create a GRE tunnel using the API, and then try to look at an API 
> trace to see exactly how it was added, the gre_tunnel_add_del message 
> requesting the tunnel creation does not show up in the output. Neither do 
> subsequent gre_tunnel_dump messages. The tunnels are successfully created and 
> when I send a gre_tunnel_dump I receive a gre_tunnel_details, so I know the 
> messages are being received and processed.
> 
> I'm retrieving the trace by running:
> 
> vppctl api trace save foo
> vppctl api trace dump /tmp/foo
> 
> The build I'm seeing this on is from a copy of master from wednesday. This is 
> the last commit:
> fd77f8c00 quic: remove cmake --target
> 
> I poked around and tracked this down to api_global_main.api_trace_cfg having 
> trace_enable set to 0 on the entries for the GRE messages:
> 
> (gdb) p api_global_main.msg_names[1253]
> $23 = 0x7f95985ed677 "gre_tunnel_add_del"
> (gdb) p api_global_main.api_trace_cfg[1253]
> $24 = {size = 0, trace_enable = 0, replay_enable = 0}
> 
> (gdb) p api_global_main.msg_names[1255]
> $27 = 0x7f95985ed6a3 "gre_tunnel_dump"
> (gdb) p api_global_main.api_trace_cfg[1255]
> $28 = {size = 0, trace_enable = 0, replay_enable = 0}
> 
> Are the GRE messages intentionally excluded from being traced? Or is this an 
> oversight?
> 
> Thanks!
> -Matt
> 
> 
> 
> 



signature.asc
Description: Message signed with OpenPGP

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19394): https://lists.fd.io/g/vpp-dev/message/19394
Mute This Topic: https://lists.fd.io/mt/82833140/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[vpp-dev] missing API trace output

2021-05-14 Thread Matthew Smith via lists.fd.io
Hi all,

When I create a GRE tunnel using the API, and then try to look at an API
trace to see exactly how it was added, the gre_tunnel_add_del message
requesting the tunnel creation does not show up in the output. Neither do
subsequent gre_tunnel_dump messages. The tunnels are successfully created
and when I send a gre_tunnel_dump I receive a gre_tunnel_details, so I know
the messages are being received and processed.

I'm retrieving the trace by running:

vppctl api trace save foo
vppctl api trace dump /tmp/foo

The build I'm seeing this on is from a copy of master from wednesday. This
is the last commit:
fd77f8c00 quic: remove cmake --target

I poked around and tracked this down to api_global_main.api_trace_cfg
having trace_enable set to 0 on the entries for the GRE messages:

(gdb) p api_global_main.msg_names[1253]
$23 = 0x7f95985ed677 "gre_tunnel_add_del"
(gdb) p api_global_main.api_trace_cfg[1253]
$24 = {size = 0, trace_enable = 0, replay_enable = 0}

(gdb) p api_global_main.msg_names[1255]
$27 = 0x7f95985ed6a3 "gre_tunnel_dump"
(gdb) p api_global_main.api_trace_cfg[1255]
$28 = {size = 0, trace_enable = 0, replay_enable = 0}

Are the GRE messages intentionally excluded from being traced? Or is this
an oversight?

Thanks!
-Matt

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#19384): https://lists.fd.io/g/vpp-dev/message/19384
Mute This Topic: https://lists.fd.io/mt/82833140/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-