Re: [vpp-dev] 18.07.1 dot release

2018-09-04 Thread avinash . gonsalves 
I would like to propose an enhancement for vpp to work with dpdk 
multicore-crypto scheduler ( 
http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html ).

For the software crypto pmd to be scheduled on multiple cores the following 
dpdk configuration is required:

vdev 
crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-core,corelist=3-4,ordering=enable

This does not work directly with base VPP code, the following enhancements are 
required

1. VPP Changes:

    - Recognize slave-lcore corelist assigned for multi-core crypto and pass 
the configuration during dpdk plugin device init(startup.conf)

    - Start the multi-core crypto scheduler for the correct device_id.

2. DPDK Patch 

    - Enable RTE_LIBRTE_PMD_CRYPTO_SCHEDULER

    - Enable PER_SLAVE_BUFF_SIZE to be configurable from start 
parameters(slave_buff_size=8192)

    - Ordering Fix for Multi Producer Queue

A patch was performance tested off VPP 17.10 (DPDK 17.08) release with 2,3,4 
crypto cores.

If everyone thinks this merits going into 18.07.1, i'll initiate a review 
(there have been a couple of posts on this already)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-04 Thread Damjan Marion via Lists.Fd.Io 

Dear Avinash,

Dot releases are only for bug fixes, new features should not go there...

-- 
Damjan

> On 4 Sep 2018, at 18:12, avinash.gonsal...@nokia.com wrote:
> 
> I would like to propose an enhancement for vpp to work with dpdk 
> multicore-crypto scheduler 
> (http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html 
> ).
> 
> For the software crypto pmd to be scheduled on multiple cores the following 
> dpdk configuration is required:
> 
> vdev 
> crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-core,corelist=3-4,ordering=enable
> 
> This does not work directly with base VPP code, the following enhancements 
> are required
> 
> 1. VPP Changes:
> 
> - Recognize slave-lcore corelist assigned for multi-core crypto and pass 
> the configuration during dpdk plugin device init(startup.conf)
> 
> - Start the multi-core crypto scheduler for the correct device_id.
> 
> 2. DPDK Patch 
> 
> - Enable RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
> 
> - Enable PER_SLAVE_BUFF_SIZE to be configurable from start 
> parameters(slave_buff_size=8192)
> 
> - Ordering Fix for Multi Producer Queue
> 
> A patch was performance tested off VPP 17.10 (DPDK 17.08) release with 2,3,4 
> crypto cores.
> 
> If everyone thinks this merits going into 18.07.1, i'll initiate a review 
> (there have been a couple of posts on this already)
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
> Mute This Topic: https://lists.fd.io/mt/25177447/675642
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> -=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10356): https://lists.fd.io/g/vpp-dev/message/10356
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-04 Thread Edward Warnicke 
Second that… bug fixes in 18.07.1… new features on master for 18.10

Ed


On September 4, 2018 at 12:21:28 PM, Damjan Marion via Lists.Fd.Io (
dmarion=me@lists.fd.io) wrote:


Dear Avinash,

Dot releases are only for bug fixes, new features should not go there...

-- 
Damjan

On 4 Sep 2018, at 18:12, avinash.gonsal...@nokia.com wrote:

I would like to propose an enhancement for vpp to work with dpdk
multicore-crypto scheduler (
http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html).

For the software crypto pmd to be scheduled on multiple cores the following
dpdk configuration is required:
vdev
crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-core,corelist=3-4,ordering=enable

This does not work directly with base VPP code, the following enhancements
are required

1. VPP Changes:

- Recognize slave-lcore corelist assigned for multi-core crypto and
pass the configuration during dpdk plugin device init(startup.conf)

- Start the multi-core crypto scheduler for the correct device_id.

2. DPDK Patch

- Enable RTE_LIBRTE_PMD_CRYPTO_SCHEDULER

- Enable PER_SLAVE_BUFF_SIZE to be configurable from start
parameters(slave_buff_size=8192)

- Ordering Fix for Multi Producer Queue

A patch was performance tested off VPP 17.10 (DPDK 17.08) release with
2,3,4 crypto cores.

If everyone thinks this merits going into 18.07.1, i'll initiate a review
(there have been a couple of posts on this already)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
Mute This Topic: https://lists.fd.io/mt/25177447/675642
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
-=-=-=-=-=-=-=-=-=-=-=-


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10356): https://lists.fd.io/g/vpp-dev/message/10356
Mute This Topic: https://lists.fd.io/mt/25177447/464962
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [hagb...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10357): https://lists.fd.io/g/vpp-dev/message/10357
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-04 Thread Gonsalves, Avinash (Nokia - IN/Bangalore) 
Done. Will send the patch for review after 18.07.1 is out.

-Avinash

From: Ed Warnicke 
Sent: Tuesday, September 04, 2018 10:52 PM
To: Damjan Marion via Lists.Fd.Io ; dmar...@me.com; 
Gonsalves, Avinash (Nokia - IN/Bangalore) 
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] 18.07.1 dot release

Second that… bug fixes in 18.07.1… new features on master for 18.10

Ed



On September 4, 2018 at 12:21:28 PM, Damjan Marion via 
Lists.Fd.Io<http://Lists.Fd.Io> 
(dmarion=me@lists.fd.io<mailto:dmarion=me@lists.fd.io>) wrote:

Dear Avinash,

Dot releases are only for bug fixes, new features should not go there...

--
Damjan


On 4 Sep 2018, at 18:12, 
avinash.gonsal...@nokia.com<mailto:avinash.gonsal...@nokia.com> wrote:

I would like to propose an enhancement for vpp to work with dpdk 
multicore-crypto scheduler 
(http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html).
For the software crypto pmd to be scheduled on multiple cores the following 
dpdk configuration is required:
vdev 
crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-core,corelist=3-4,ordering=enable
This does not work directly with base VPP code, the following enhancements are 
required
1. VPP Changes:
- Recognize slave-lcore corelist assigned for multi-core crypto and pass 
the configuration during dpdk plugin device init(startup.conf)
- Start the multi-core crypto scheduler for the correct device_id.
2. DPDK Patch
- Enable RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
- Enable PER_SLAVE_BUFF_SIZE to be configurable from start 
parameters(slave_buff_size=8192)
- Ordering Fix for Multi Producer Queue
A patch was performance tested off VPP 17.10 (DPDK 17.08) release with 2,3,4 
crypto cores.
If everyone thinks this merits going into 18.07.1, i'll initiate a review 
(there have been a couple of posts on this already)
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
Mute This Topic: https://lists.fd.io/mt/25177447/675642
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  
[dmar...@me.com<mailto:dmar...@me.com>]
-=-=-=-=-=-=-=-=-=-=-=-

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10356): https://lists.fd.io/g/vpp-dev/message/10356
Mute This Topic: https://lists.fd.io/mt/25177447/464962
Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev%2bow...@lists.fd.io>
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
[hagb...@gmail.com<mailto:hagb...@gmail.com>]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10358): https://lists.fd.io/g/vpp-dev/message/10358
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-04 Thread Edward Warnicke 
You can send the patch now to vpp/master … master is open for business :)
 18.07 is on the stable/1807 branch :)

Ed


On September 4, 2018 at 12:24:52 PM, Gonsalves, Avinash (Nokia -
IN/Bangalore) (avinash.gonsal...@nokia.com) wrote:

Done. Will send the patch for review after 18.07.1 is out.



-Avinash



*From:* Ed Warnicke 
*Sent:* Tuesday, September 04, 2018 10:52 PM
*To:* Damjan Marion via Lists.Fd.Io ;
dmar...@me.com; Gonsalves, Avinash (Nokia - IN/Bangalore) <
avinash.gonsal...@nokia.com>
*Cc:* vpp-dev@lists.fd.io
*Subject:* Re: [vpp-dev] 18.07.1 dot release



Second that… bug fixes in 18.07.1… new features on master for 18.10



Ed





On September 4, 2018 at 12:21:28 PM, Damjan Marion via Lists.Fd.Io (
dmarion=me@lists.fd.io) wrote:



Dear Avinash,



Dot releases are only for bug fixes, new features should not go there...



-- 
Damjan



On 4 Sep 2018, at 18:12, avinash.gonsal...@nokia.com wrote:



I would like to propose an enhancement for vpp to work with dpdk
multicore-crypto scheduler (
http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html).

For the software crypto pmd to be scheduled on multiple cores the following
dpdk configuration is required:
vdev
crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-core,corelist=3-4,ordering=enable

This does not work directly with base VPP code, the following enhancements
are required

1. VPP Changes:

- Recognize slave-lcore corelist assigned for multi-core crypto and
pass the configuration during dpdk plugin device init(startup.conf)

- Start the multi-core crypto scheduler for the correct device_id.

2. DPDK Patch

- Enable RTE_LIBRTE_PMD_CRYPTO_SCHEDULER

- Enable PER_SLAVE_BUFF_SIZE to be configurable from start
parameters(slave_buff_size=8192)

- Ordering Fix for Multi Producer Queue

A patch was performance tested off VPP 17.10 (DPDK 17.08) release with
2,3,4 crypto cores.

If everyone thinks this merits going into 18.07.1, i'll initiate a review
(there have been a couple of posts on this already)

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
Mute This Topic: https://lists.fd.io/mt/25177447/675642
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
-=-=-=-=-=-=-=-=-=-=-=-



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10356): https://lists.fd.io/g/vpp-dev/message/10356
Mute This Topic: https://lists.fd.io/mt/25177447/464962
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [hagb...@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10359): https://lists.fd.io/g/vpp-dev/message/10359
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-05 Thread Marco Varlese 
+1 
@avinash: if you plan to add that feature in 18.10, please, take a moment to add
that to the list here:
https://wiki.fd.io/view/Projects/vpp/Release_Plans/Release_Plan_18.10

Cheers,
On Tue, 2018-09-04 at 10:22 -0700, Edward Warnicke wrote:
> Second that… bug fixes in 18.07.1… new features on master for 18.10
> 
> Ed
>  
>   
> On September 4, 2018 at 12:21:28 PM, Damjan Marion via Lists.Fd.Io (
> dmarion=me@lists.fd.io) wrote:
>  
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > Dear Avinash,
> > 
> > 
> > Dot releases are only for bug fixes, new features
> > should not go there...
> > 
> > 
> > 
> > 
> > -- 
> > 
> > Damjan
> > 
> > 
> > 
> > > On 4 Sep 2018, at 18:12, avinash.gonsal...@nokia.com wrote:
> > > 
> > > 
> > > 
> > > I would like to propose an enhancement for vpp to work
> > > with dpdk multicore-crypto scheduler (
> > > http://doc.dpdk.org/guides-18.02/cryptodevs/scheduler.html).
> > > For the software crypto pmd to be scheduled on multiple
> > > cores the following dpdk configuration is required:
> > > vdev
> > > crypto_scheduler,slave=aesni_mb_1,slave=aesni_mb_2,mode=multi-
> > > core,corelist=3-4,ordering=enable
> > > This does not work directly with base VPP code, the
> > > following enhancements are required
> > > 1. VPP Changes:
> > > - Recognize slave-lcore corelist assigned
> > > for multi-core crypto and pass the configuration during dpdk plugin
> > > device init(startup.conf)
> > > - Start the multi-core crypto scheduler
> > > for the correct device_id.
> > > 2. DPDK Patch 
> > > - Enable
> > > RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
> > > - Enable PER_SLAVE_BUFF_SIZE to be
> > > configurable from start parameters(slave_buff_size=8192)
> > > - Ordering Fix for Multi Producer
> > > Queue
> > > A patch was performance tested off VPP 17.10 (DPDK
> > > 17.08) release with 2,3,4 crypto cores.
> > > If everyone thinks this merits going into 18.07.1, i'll
> > > initiate a review (there have been a couple of posts on this
> > > already)
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > 
> > > Links: You receive all messages sent to this group.
> > > 
> > > 
> > > 
> > > View/Reply Online (#10353): https://lists.fd.io/g/vpp-dev/message/10353
> > > 
> > > Mute This Topic: https://lists.fd.io/mt/25177447/675642
> > > 
> > > Group Owner: vpp-dev+ow...@lists.fd.io
> > > 
> > > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [dmar...@me.com]
> > > 
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > 
> > 
> > 
> > 
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 
> > Links: You receive all messages sent to this group.
> > 
> > 
> > 
> > View/Reply Online (#10356): https://lists.fd.io/g/vpp-dev/message/10356
> > 
> > Mute This Topic: https://lists.fd.io/mt/25177447/464962
> > 
> > Group Owner: vpp-dev+ow...@lists.fd.io
> > 
> > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [hagb...@gmail.com]
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 
> 
> -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
> View/Reply Online (#10357): https://lists.fd.io/g/vpp-dev/message/10357Mute
> This Topic: https://lists.fd.io/mt/25177447/675056Group Owner: vpp-
> dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [mvarl
> e...@suse.de]-=-=-=-=-=-=-=-=-=-=-=-
-- 
Marco V


SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10371): https://lists.fd.io/g/vpp-dev/message/10371
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-05 Thread Gonsalves, Avinash (Nokia - IN/Bangalore) 
Done. Added feature Multi-Core Crypto Dev support for VPP for Release 18.10
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10386): https://lists.fd.io/g/vpp-dev/message/10386
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-05 Thread Edward Warnicke 
Woot! :)

Ed

On Wed, Sep 5, 2018 at 1:00 PM Gonsalves, Avinash (Nokia - IN/Bangalore) <
avinash.gonsal...@nokia.com> wrote:

> Done. Added feature Multi-Core Crypto Dev support for VPP for Release
> 18.10 -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#10386): https://lists.fd.io/g/vpp-dev/message/10386
> Mute This Topic: https://lists.fd.io/mt/25177447/464962
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [hagb...@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10387): https://lists.fd.io/g/vpp-dev/message/10387
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] 18.07.1 dot release

2018-09-06 Thread Marco Varlese 
Cool... thanks!
On Wed, 2018-09-05 at 11:00 -0700, Gonsalves, Avinash (Nokia - IN/Bangalore)
wrote:
> Done. Added feature Multi-Core Crypto Dev support for VPP for Release 18.10
> -=-=-=-=-=-=-=-=-=-=-=-Links: You receive all messages sent to this group.
> View/Reply Online (#10386): https://lists.fd.io/g/vpp-dev/message/10386Mute
> This Topic: https://lists.fd.io/mt/25177447/675056Group Owner: vpp-
> dev+ow...@lists.fd.ioUnsubscribe: https://lists.fd.io/g/vpp-dev/unsubb  [mvarl
> e...@suse.de]-=-=-=-=-=-=-=-=-=-=-=-
-- 
Marco V


SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#10397): https://lists.fd.io/g/vpp-dev/message/10397
Mute This Topic: https://lists.fd.io/mt/25177447/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-