Re: [vpp-dev] Build failure question

2019-03-05 Thread Thomas F Herbert 



On 03/05/2019 09:40 AM, Damjan Marion wrote:



On 5 Mar 2019, at 15:14, Thomas F Herbert > wrote:




On 03/05/2019 02:37 AM, Damjan Marion wrote:



On 4 Mar 2019, at 22:52, Thomas F Herbert > wrote:


Damjan et. al.

I get build failures when builging from a tarball  outside of git 
tree on 19.01


I documented this in https://jira.fd.io/browse/VPP-1577

This is not reproduceable when building in git tree.

Could you please take a look at the cmake output and give me some 
suggestions.


—Tom



It is likely fixed in master, please try with master.

Yes, I believe it is fixed in master. Do you know which commit fixed it?


May be:

Yes, Thanks!
 I found it and backported the patch and am testing it. I had already 
found the problem with pack.cmake but missed the

version include changes.
I will update JIRA 1577 with results in case we decide to backport it.


Author:     Damjan Marion mailto:damar...@cisco.com>>
AuthorDate: Mon Jan 28 17:55:59 2019 +0100
Commit:     Marco Varlese >

CommitDate: Tue Jan 29 07:47:01 2019 +

    cmake: fix out-of-git-tree build

    Change-Id: Ib94637ec09799c23f3179599b54a2be6e2768425
    Signed-off-by: Damjan Marion >





--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12436): https://lists.fd.io/g/vpp-dev/message/12436
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build failure question

2019-03-05 Thread Damjan Marion via Lists.Fd.Io 


> On 5 Mar 2019, at 15:14, Thomas F Herbert  wrote:
> 
> 
> 
> 
> On 03/05/2019 02:37 AM, Damjan Marion wrote:
>> 
>> 
>>> On 4 Mar 2019, at 22:52, Thomas F Herbert >> > wrote:
>>> 
>>> Damjan et. al.
>>> 
>>> I get build failures when builging from a tarball  outside of git tree on 
>>> 19.01
>>> 
>>> I documented this in https://jira.fd.io/browse/VPP-1577 
>>> 
>>> This is not reproduceable when building in git tree.
>>> 
>>> Could you please take a look at the cmake output and give me some 
>>> suggestions.
>>> 
>>> —Tom
>>> 
>> 
>> It is likely fixed in master, please try with master.
> Yes, I believe it is fixed in master. Do you know which commit fixed it?

May be:

Author: Damjan Marion 
AuthorDate: Mon Jan 28 17:55:59 2019 +0100
Commit: Marco Varlese 
CommitDate: Tue Jan 29 07:47:01 2019 +

cmake: fix out-of-git-tree build

Change-Id: Ib94637ec09799c23f3179599b54a2be6e2768425
Signed-off-by: Damjan Marion 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12435): https://lists.fd.io/g/vpp-dev/message/12435
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build failure question

2019-03-05 Thread Thomas F Herbert 



On 03/05/2019 02:37 AM, Damjan Marion wrote:



On 4 Mar 2019, at 22:52, Thomas F Herbert > wrote:


Damjan et. al.

I get build failures when builging from a tarball  outside of git 
tree on 19.01


I documented this in https://jira.fd.io/browse/VPP-1577

This is not reproduceable when building in git tree.

Could you please take a look at the cmake output and give me some 
suggestions.


—Tom



It is likely fixed in master, please try with master.

Yes, I believe it is fixed in master. Do you know which commit fixed it?

--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12434): https://lists.fd.io/g/vpp-dev/message/12434
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build failure question

2019-03-04 Thread Damjan Marion via Lists.Fd.Io 


> On 4 Mar 2019, at 22:52, Thomas F Herbert  wrote:
> 
> Damjan et. al.
> 
> I get build failures when builging from a tarball  outside of git tree on 
> 19.01
> 
> I documented this in https://jira.fd.io/browse/VPP-1577 
> 
> This is not reproduceable when building in git tree.
> 
> Could you please take a look at the cmake output and give me some suggestions.
> 
> —Tom
> 

It is likely fixed in master, please try with master.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12428): https://lists.fd.io/g/vpp-dev/message/12428
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build failure question

2019-03-04 Thread Thomas F Herbert 



On 03/04/2019 05:12 PM, Paul Vinciguerra wrote:
Is this a “must have” or a “nice to have” feature?  I guess what I’m 
really asking is if this belongs in a CI job.
This breaks the building of downstream RPMs for CentOS. Until the 1807 
release, we have been maintaining this feature.
The downstream RPMs are built from a spec file and tarball created by 
the dist target in the top level Makefile


I am trying to write a patch to fix it. It would be preferable to have 
the patch backported but for now,
I am looking for help from CMake experts to see what is causing this 
side affect.

Paul

On Mar 4, 2019, at 4:52 PM, Thomas F Herbert > wrote:



Damjan et. al.

I get build failures when builging from a tarball  outside of git 
tree on 19.01


I documented this in https://jira.fd.io/browse/VPP-1577

This is not reproduceable when building in git tree.

Could you please take a look at the cmake output and give me some 
suggestions.


--Tom

--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12423): https://lists.fd.io/g/vpp-dev/message/12423
Mute This Topic: https://lists.fd.io/mt/30219549/1594641
Group Owner: vpp-dev+ow...@lists.fd.io 
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub 
 [pvi...@vinciconsulting.com ]

-=-=-=-=-=-=-=-=-=-=-=-


--
*Thomas F Herbert*
NFV and Fast Data Planes
Networking Group Office of the CTO
*Red Hat*
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12425): https://lists.fd.io/g/vpp-dev/message/12425
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [vpp-dev] Build failure question

2019-03-04 Thread Paul Vinciguerra 
Is this a “must have” or a “nice to have” feature?  I guess what I’m really 
asking is if this belongs in a CI job. 

Paul

> On Mar 4, 2019, at 4:52 PM, Thomas F Herbert  wrote:
> 
> Damjan et. al.
> 
> I get build failures when builging from a tarball  outside of git tree on 
> 19.01
> 
> I documented this in https://jira.fd.io/browse/VPP-1577
> 
> This is not reproduceable when building in git tree.
> 
> Could you please take a look at the cmake output and give me some suggestions.
> 
> --Tom
> 
> -- 
> Thomas F Herbert 
> NFV and Fast Data Planes 
> Networking Group Office of the CTO 
> Red Hat
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> 
> View/Reply Online (#12423): https://lists.fd.io/g/vpp-dev/message/12423
> Mute This Topic: https://lists.fd.io/mt/30219549/1594641
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [pvi...@vinciconsulting.com]
> -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#12424): https://lists.fd.io/g/vpp-dev/message/12424
Mute This Topic: https://lists.fd.io/mt/30219549/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-