Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL
> Makefile by testing for JENKINS_URL? Inputs to the program make should be understandable by human. When I want to predict locally what would the checkstyle job vote, I prefer something like: make checkstyle-all rather than: JENKINS_URL=jenkins.fd.io make checkstyle Or did you mean a different variable? Here [3] is a typical list. Vratko. [3] https://jenkins.fd.io/view/vpp/job/vpp-checkstyle-verify-master/12455/injectedEnvVars/ From: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra Sent: Wednesday, November 13, 2019 4:28 PM To: Dave Wallace Cc: vpp-dev Subject: Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace mailto:dwallac...@gmail.com>> wrote: Status update: Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) Ed Kern has added 'make install-dep' to the checkstyle verify build executors. The revert of my ci-management patch [2] will be abandoned. Florin's patch will be reverted once the new build executors are available and verified that yamllint is available. Sorry for the bog-up. Thanks, -daw- [1] https://gerrit.fd.io/r/c/vpp/+/23391 [2] https://gerrit.fd.io/r/c/ci-management/+/23410 On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io<http://Lists.Fd.Io> wrote: Dave, My bad. I had Vanessa merge a patch to ci-management [0] which I tested locally, but forgot that the build executors don't run 'make install-dep'. Unfortunately the ci-management verify jobs don't actually run any of the CI jobs to ensure that the system still works with the patch being submitted... I'm in the process of reverting the patch until the build executors can be upgraded. Thanks, -daw- [0] https://gerrit.fd.io/r/c/ci-management/+/23364 On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io<http://Lists.Fd.Io> wrote: I wonder where “yamllint” went? Multiple patches affected... 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) 07:28:24 HEAD detached at dce8b380a 07:28:24 nothing to commit, working tree clean 07:28:24 *** 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED 07:28:24 *** 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src 07:28:24 make: yamllint: Command not found 07:28:24 Makefile:561: recipe for target 'checkstyle' failed 07:28:24 make: *** [checkstyle] Error 127 07:28:24 Build step 'Execute shell' marked build as failure FWIW... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579 Mute This Topic: https://lists.fd.io/mt/55791974/675079 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com<mailto:dwallac...@gmail.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583 Mute This Topic: https://lists.fd.io/mt/55791974/675079 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev+ow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com<mailto:dwallac...@gmail.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589 Mute This Topic: https://lists.fd.io/mt/55791974/1594641 Group Owner: vpp-dev+ow...@lists.fd.io<mailto:vpp-dev%2bow...@lists.fd.io> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [pvi...@vinciconsulting.com<mailto:pvi...@vinciconsulting.com>] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14596): https://lists.fd.io/g/vpp-dev/message/14596 Mute This Topic: https://lists.fd.io/mt/55791974/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL
How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace wrote: > Status update: > > Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) > > Ed Kern has added 'make install-dep' to the checkstyle verify build > executors. > > The revert of my ci-management patch [2] will be abandoned. > > Florin's patch will be reverted once the new build executors are available > and verified that yamllint is available. > > Sorry for the bog-up. > > Thanks, > -daw- > > [1] https://gerrit.fd.io/r/c/vpp/+/23391 > [2] https://gerrit.fd.io/r/c/ci-management/+/23410 > > On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io wrote: > > Dave, > > My bad. I had Vanessa merge a patch to ci-management [0] which I tested > locally, but forgot that the build executors don't run 'make install-dep'. > > Unfortunately the ci-management verify jobs don't actually run any of the > CI jobs to ensure that the system still works with the patch being > submitted... > > I'm in the process of reverting the patch until the build executors can be > upgraded. > > Thanks, > -daw- > [0] https://gerrit.fd.io/r/c/ci-management/+/23364 > > On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote: > > I wonder where “yamllint” went? Multiple patches affected... > > > > 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) > > 07:28:24 HEAD detached at dce8b380a > > 07:28:24 nothing to commit, working tree clean > > 07:28:24 > *** > > 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED > > 07:28:24 > *** > > 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src > > 07:28:24 make: yamllint: Command not found > > 07:28:24 Makefile:561: recipe for target 'checkstyle' failed > > 07:28:24 make: *** [checkstyle] Error 127 > > 07:28:24 Build step 'Execute shell' marked build as failure > > > > FWIW... Dave > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579 > Mute This Topic: https://lists.fd.io/mt/55791974/675079 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583 > Mute This Topic: https://lists.fd.io/mt/55791974/675079 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589 > Mute This Topic: https://lists.fd.io/mt/55791974/1594641 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ > pvi...@vinciconsulting.com] > -=-=-=-=-=-=-=-=-=-=-=- > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14590): https://lists.fd.io/g/vpp-dev/message/14590 Mute This Topic: https://lists.fd.io/mt/55791974/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL
Status update: Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) Ed Kern has added 'make install-dep' to the checkstyle verify build executors. The revert of my ci-management patch [2] will be abandoned. Florin's patch will be reverted once the new build executors are available and verified that yamllint is available. Sorry for the bog-up. Thanks, -daw- [1] https://gerrit.fd.io/r/c/vpp/+/23391 [2] https://gerrit.fd.io/r/c/ci-management/+/23410 On 11/13/2019 8:58 AM, Dave Wallace via Lists.Fd.Io wrote: Dave, My bad. I had Vanessa merge a patch to ci-management [0] which I tested locally, but forgot that the build executors don't run 'make install-dep'. Unfortunately the ci-management verify jobs don't actually run any of the CI jobs to ensure that the system still works with the patch being submitted... I'm in the process of reverting the patch until the build executors can be upgraded. Thanks, -daw- [0] https://gerrit.fd.io/r/c/ci-management/+/23364 On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote: I wonder where “yamllint” went? Multiple patches affected... 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) 07:28:24 HEAD detached at dce8b380a 07:28:24 nothing to commit, working tree clean 07:28:24 *** 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED 07:28:24 *** 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src 07:28:24 make: yamllint: Command not found 07:28:24 Makefile:561: recipe for target 'checkstyle' failed 07:28:24 make: *** [checkstyle] Error 127 07:28:24 Build step 'Execute shell' marked build as failure FWIW... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14579):https://lists.fd.io/g/vpp-dev/message/14579 Mute This Topic:https://lists.fd.io/mt/55791974/675079 Group Owner:vpp-dev+ow...@lists.fd.io Unsubscribe:https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583 Mute This Topic: https://lists.fd.io/mt/55791974/675079 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14589): https://lists.fd.io/g/vpp-dev/message/14589 Mute This Topic: https://lists.fd.io/mt/55791974/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL
Can you leave it? The change in the makefile was backed out. Can we work on automating new containers when the makefile is updated? On Wed, Nov 13, 2019 at 8:58 AM Dave Wallace wrote: > Dave, > > My bad. I had Vanessa merge a patch to ci-management [0] which I tested > locally, but forgot that the build executors don't run 'make install-dep'. > > Unfortunately the ci-management verify jobs don't actually run any of the > CI jobs to ensure that the system still works with the patch being > submitted... > > I'm in the process of reverting the patch until the build executors can be > upgraded. > > Thanks, > -daw- > [0] https://gerrit.fd.io/r/c/ci-management/+/23364 > > On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote: > > I wonder where “yamllint” went? Multiple patches affected... > > > > 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) > > 07:28:24 HEAD detached at dce8b380a > > 07:28:24 nothing to commit, working tree clean > > 07:28:24 > *** > > 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED > > 07:28:24 > *** > > 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src > > 07:28:24 make: yamllint: Command not found > > 07:28:24 Makefile:561: recipe for target 'checkstyle' failed > > 07:28:24 make: *** [checkstyle] Error 127 > > 07:28:24 Build step 'Execute shell' marked build as failure > > > > FWIW... Dave > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579 > Mute This Topic: https://lists.fd.io/mt/55791974/675079 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583 > Mute This Topic: https://lists.fd.io/mt/55791974/1594641 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [ > pvi...@vinciconsulting.com] > -=-=-=-=-=-=-=-=-=-=-=- > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14584): https://lists.fd.io/g/vpp-dev/message/14584 Mute This Topic: https://lists.fd.io/mt/55791974/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL
Dave, My bad. I had Vanessa merge a patch to ci-management [0] which I tested locally, but forgot that the build executors don't run 'make install-dep'. Unfortunately the ci-management verify jobs don't actually run any of the CI jobs to ensure that the system still works with the patch being submitted... I'm in the process of reverting the patch until the build executors can be upgraded. Thanks, -daw- [0] https://gerrit.fd.io/r/c/ci-management/+/23364 On 11/13/2019 7:35 AM, Dave Barach via Lists.Fd.Io wrote: I wonder where “yamllint” went? Multiple patches affected... 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) 07:28:24 HEAD detached at dce8b380a 07:28:24 nothing to commit, working tree clean 07:28:24 *** 07:28:24 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED 07:28:24 *** 07:28:24 yamllint /w/workspace/vpp-checkstyle-verify-master/src 07:28:24 make: yamllint: Command not found 07:28:24 Makefile:561: recipe for target 'checkstyle' failed 07:28:24 make: *** [checkstyle] Error 127 07:28:24 Build step 'Execute shell' marked build as failure FWIW... Dave -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14579): https://lists.fd.io/g/vpp-dev/message/14579 Mute This Topic: https://lists.fd.io/mt/55791974/675079 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dwallac...@gmail.com] -=-=-=-=-=-=-=-=-=-=-=- -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14583): https://lists.fd.io/g/vpp-dev/message/14583 Mute This Topic: https://lists.fd.io/mt/55791974/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
