Re: [Warzone-dev] a minor fix
On 6/22/07, Giel van Schijndel <[EMAIL PROTECTED]> wrote: The Watermelon schreef: > > a minor fix to avoid excessive harmless asserts by projectile validity > check macro when using memory debugger like MSVC when debugging. > I assume the problem you're trying to fix with this patch is that psAttacker = NULL at some times, and dereferencing this to retrieve ->psSource and ->psDest results in a segmentation fault? PS the first portion of your patch is whitespace only, this was quite annoying in reviewing your patch. -- Giel yes it's a potential crash,though psAttacker should never be NULL,unless you fire a projectile with a script function.I think I forgot to include the changes which actually reduce the assert spam... not sure what you mean by 'the first portion of your patch is whitespace only'. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Warzone 2100 2.0.7 arrives in the stores
On 6/22/07, Ari Johnson <[EMAIL PROTECTED]> wrote: > On 6/22/07, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > > Ari Johnson schreef: > > > On 6/22/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > > > > > >> We just released Warzone 2100 version 2.0.7. > > >> This doesn't bring many stunning new features and is mainly intended to > > >> fix > > >> several remaining crashes and add a few config options for convenience. > > >> > > >> Summary of changes: > > >> - Access to the new Lobbyserver (When joining a game, leave the IP field > > >> empty > > >> to get a list of available games) > > >> - Screenshots are now saved as PNGs for better quality > > >> - Configurable framerate limit (eg. for laptop users) > > >> - Linux AutoPackage should work better > > >> - Crash and security fixes > > >> > > >> Details: http://wz2100.net/forum/index.php?topic=715.0 > > >> Download: http://wz2100.net/downloads.html > > >> > > > > > > Just a note: There will not be a Mac OS X version of 2.0.7 per se. I > > > have instead build it based on the 2.0 branch as of the time I just > > > committed my changes to make the 2.0 branch use Xcode like the trunk > > > does. > > > > > > Note that the following comes up and the game quits if you build a > > > Debug copy of the game, but the Release version seems to work alright. > > > > > > error: Invalid pointer passed to mem_Free by: > > > File: /Users/ari/work/warzone-2.0/macosx/../src/seqdisp.c > > > Line: 320 > > > > > > Attempt to free already freed pointer?error: Assert in Warzone: > > > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c:301 : > > > memFree (psDeleted != NULL) > > > Assertion failed: (psDeleted != ((void *)0)), function memFree, file > > > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c, line 301. > > > > > > > > > I am too busy right now to put any time into fixing Warzone bugs I > > > hope to have time to work on Warzone again in August or September. > > > Until then, please grab > > > http://hermes.theari.com/~ari/warzone-2.0.7.dmg > > > > > So this is revision 1573 from branches/2.0 ? If so then this is exactly > > equal to the tags/2.0.7 (besides the Xcode project file). > > Yes, it's r1573. > I should also point out: Because this uses the new Xcode stuff, it won't work on versions of Mac OS X before 10.4 "Tiger" but it is a Universal binary. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Warzone 2100 2.0.7 arrives in the stores
On 6/22/07, Giel van Schijndel <[EMAIL PROTECTED]> wrote: > Ari Johnson schreef: > > On 6/22/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > > > >> We just released Warzone 2100 version 2.0.7. > >> This doesn't bring many stunning new features and is mainly intended to fix > >> several remaining crashes and add a few config options for convenience. > >> > >> Summary of changes: > >> - Access to the new Lobbyserver (When joining a game, leave the IP field > >> empty > >> to get a list of available games) > >> - Screenshots are now saved as PNGs for better quality > >> - Configurable framerate limit (eg. for laptop users) > >> - Linux AutoPackage should work better > >> - Crash and security fixes > >> > >> Details: http://wz2100.net/forum/index.php?topic=715.0 > >> Download: http://wz2100.net/downloads.html > >> > > > > Just a note: There will not be a Mac OS X version of 2.0.7 per se. I > > have instead build it based on the 2.0 branch as of the time I just > > committed my changes to make the 2.0 branch use Xcode like the trunk > > does. > > > > Note that the following comes up and the game quits if you build a > > Debug copy of the game, but the Release version seems to work alright. > > > > error: Invalid pointer passed to mem_Free by: > > File: /Users/ari/work/warzone-2.0/macosx/../src/seqdisp.c > > Line: 320 > > > > Attempt to free already freed pointer?error: Assert in Warzone: > > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c:301 : > > memFree (psDeleted != NULL) > > Assertion failed: (psDeleted != ((void *)0)), function memFree, file > > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c, line 301. > > > > > > I am too busy right now to put any time into fixing Warzone bugs I > > hope to have time to work on Warzone again in August or September. > > Until then, please grab > > http://hermes.theari.com/~ari/warzone-2.0.7.dmg > > > So this is revision 1573 from branches/2.0 ? If so then this is exactly > equal to the tags/2.0.7 (besides the Xcode project file). Yes, it's r1573. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Warzone 2100 2.0.7 arrives in the stores
Ari Johnson schreef: > On 6/22/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > >> We just released Warzone 2100 version 2.0.7. >> This doesn't bring many stunning new features and is mainly intended to fix >> several remaining crashes and add a few config options for convenience. >> >> Summary of changes: >> - Access to the new Lobbyserver (When joining a game, leave the IP field >> empty >> to get a list of available games) >> - Screenshots are now saved as PNGs for better quality >> - Configurable framerate limit (eg. for laptop users) >> - Linux AutoPackage should work better >> - Crash and security fixes >> >> Details: http://wz2100.net/forum/index.php?topic=715.0 >> Download: http://wz2100.net/downloads.html >> > > Just a note: There will not be a Mac OS X version of 2.0.7 per se. I > have instead build it based on the 2.0 branch as of the time I just > committed my changes to make the 2.0 branch use Xcode like the trunk > does. > > Note that the following comes up and the game quits if you build a > Debug copy of the game, but the Release version seems to work alright. > > error: Invalid pointer passed to mem_Free by: > File: /Users/ari/work/warzone-2.0/macosx/../src/seqdisp.c > Line: 320 > > Attempt to free already freed pointer?error: Assert in Warzone: > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c:301 : > memFree (psDeleted != NULL) > Assertion failed: (psDeleted != ((void *)0)), function memFree, file > /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c, line 301. > > > I am too busy right now to put any time into fixing Warzone bugs I > hope to have time to work on Warzone again in August or September. > Until then, please grab > http://hermes.theari.com/~ari/warzone-2.0.7.dmg > So this is revision 1573 from branches/2.0 ? If so then this is exactly equal to the tags/2.0.7 (besides the Xcode project file). -- Giel signature.asc Description: OpenPGP digital signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] Warzone 2100 2.0.7 arrives in the stores
On 6/22/07, Dennis Schridde <[EMAIL PROTECTED]> wrote: > We just released Warzone 2100 version 2.0.7. > This doesn't bring many stunning new features and is mainly intended to fix > several remaining crashes and add a few config options for convenience. > > Summary of changes: > - Access to the new Lobbyserver (When joining a game, leave the IP field empty > to get a list of available games) > - Screenshots are now saved as PNGs for better quality > - Configurable framerate limit (eg. for laptop users) > - Linux AutoPackage should work better > - Crash and security fixes > > Details: http://wz2100.net/forum/index.php?topic=715.0 > Download: http://wz2100.net/downloads.html Just a note: There will not be a Mac OS X version of 2.0.7 per se. I have instead build it based on the 2.0 branch as of the time I just committed my changes to make the 2.0 branch use Xcode like the trunk does. Note that the following comes up and the game quits if you build a Debug copy of the game, but the Release version seems to work alright. error: Invalid pointer passed to mem_Free by: File: /Users/ari/work/warzone-2.0/macosx/../src/seqdisp.c Line: 320 Attempt to free already freed pointer?error: Assert in Warzone: /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c:301 : memFree (psDeleted != NULL) Assertion failed: (psDeleted != ((void *)0)), function memFree, file /Users/ari/work/warzone-2.0/macosx/../lib/framework/mem.c, line 301. I am too busy right now to put any time into fixing Warzone bugs I hope to have time to work on Warzone again in August or September. Until then, please grab http://hermes.theari.com/~ari/warzone-2.0.7.dmg Thanks. Ari ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] Warzone 2100 2.0.7 arrives in the stores
We just released Warzone 2100 version 2.0.7. This doesn't bring many stunning new features and is mainly intended to fix several remaining crashes and add a few config options for convenience. Summary of changes: - Access to the new Lobbyserver (When joining a game, leave the IP field empty to get a list of available games) - Screenshots are now saved as PNGs for better quality - Configurable framerate limit (eg. for laptop users) - Linux AutoPackage should work better - Crash and security fixes Details: http://wz2100.net/forum/index.php?topic=715.0 Download: http://wz2100.net/downloads.html --DevUrandom signature.asc Description: This is a digitally signed message part. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] a minor fix
The Watermelon schreef: > > a minor fix to avoid excessive harmless asserts by projectile validity > check macro when using memory debugger like MSVC when debugging. > I assume the problem you're trying to fix with this patch is that psAttacker = NULL at some times, and dereferencing this to retrieve ->psSource and ->psDest results in a segmentation fault? PS the first portion of your patch is whitespace only, this was quite annoying in reviewing your patch. -- Giel signature.asc Description: OpenPGP digital signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] a weird construct component index corruption problem
the component bit 'asBits[COMP_CONSTRUCT]' is corrupted after some time of gameplay(running with 7 ai players with 20x speed should trigger it in few minutes). It seems both asBits[COMP_CONSTRUCT] and asBits[COMP_SENSOR] are corrupted(random number between 100-255,construct should be in range of 0-2,since there is only 2 construct component and 1 null component,the number of sensor is probably 5-10) I added ASSERTS in droidSetBits(the one to initialize the droid asBits) in droid.c and in the droid creation function in objmem.c,but I didnt catch any droid with bogus construct component index,so I guess the asBits is corrupted by some droid update function,but I couldnt find the culprit,cos I am not sure if these functions have been changed recently or not and I never had this problem before. this bug is responsible for a null shape crash when rendering construct component with corrupted asBits[COMP_CNSTRUCT](the 'truck' on droid) ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] a minor fix
a minor fix to avoid excessive harmless asserts by projectile validity check
macro when using memory debugger like MSVC when debugging.
Index: src/projectile.c
===
--- src/projectile.c(revision 1555)
+++ src/projectile.c(working copy)
@@ -377,18 +377,26 @@
psObj->born = gameTime;
psObj->player = (UBYTE)player;
psObj->bVisible = FALSE;
- psObj->airTarget= (UBYTE)( ( psTarget != NULL &&
- psTarget->type == OBJ_DROID &&
- vtolDroid((DROID*)psTarget) ) ||
- ( psTarget == NULL &&
- (SDWORD)tarZ > map_Height(tarX,tarY) ) );
+ psObj->airTarget= (UBYTE)( (psTarget != NULL &&
+
psTarget->type == OBJ_DROID &&
+
vtolDroid((DROID*)psTarget)) ||
+
(psTarget == NULL &&
+
(SDWORD)tarZ > map_Height(tarX,tarY)) );
//Watermelon:use the source of the source of psObj :) (psAttacker is a
projectile)
if (bPenetrate)
{
- psObj->psSource = ((PROJ_OBJECT *)psAttacker)->psSource;
- psObj->psDamaged = ((PROJ_OBJECT *)psAttacker)->psDest;
- ((PROJ_OBJECT *)psAttacker)->state = PROJ_IMPACT;
+ if (psAttacker)
+ {
+ psObj->psSource = ((PROJ_OBJECT *)psAttacker)->psSource;
+ psObj->psDamaged = ((PROJ_OBJECT *)psAttacker)->psDest;
+ ((PROJ_OBJECT *)psAttacker)->state = PROJ_IMPACT;
+ }
+ else
+ {
+ psObj->psSource = NULL;
+ psObj->psDamaged = NULL;
+ }
}
else
{
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev
