Re: [Warzone-dev] a minor fix
The Watermelon schreef: On 6/22/07, Giel van Schijndel [EMAIL PROTECTED] wrote: The Watermelon schreef: a minor fix to avoid excessive harmless asserts by projectile validity check macro when using memory debugger like MSVC when debugging. I assume the problem you're trying to fix with this patch is that psAttacker = NULL at some times, and dereferencing this to retrieve -psSource and -psDest results in a segmentation fault? PS the first portion of your patch is whitespace only, this was quite annoying in reviewing your patch. yes it's a potential crash,though psAttacker should never be NULL,unless you fire a projectile with a script function.I think I forgot to include the changes which actually reduce the assert spam... Well this patch would actually prevent a segfault if a NULL pointer ever made it through that codepath. not sure what you mean by 'the first portion of your patch is whitespace only'. I mean this part: - psObj-airTarget= (UBYTE)( ( psTarget != NULL - psTarget-type == OBJ_DROID - vtolDroid((DROID*)psTarget) ) || - ( psTarget == NULL - (SDWORD)tarZ map_Height(tarX,tarY) ) ); + psObj-airTarget= (UBYTE)( (psTarget != NULL + psTarget-type == OBJ_DROID + vtolDroid((DROID*)psTarget)) || + (psTarget == NULL + (SDWORD)tarZ map_Height(tarX,tarY)) ); It adds a few tabs, removes some spaces and that's it. -- Giel signature.asc Description: OpenPGP digital signature ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] [bug #9382] segfault in projectile.c
URL: http://gna.org/bugs/?9382 Summary: segfault in projectile.c Project: Warzone Resurrection Project Submitted by: urbanvoyeur Submitted on: Saturday 06/23/2007 at 22:05 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: svn Operating System: Microsoft Windows ___ Details: segfault in projectile.c line 151 r1591, debug mode OS: win xp 32, intel chip. Skirmish, 7 players, using AIvolution script, 20x speed, Tech Level 1 I was not engaged in combat yet - less than 5 minutes into game. No commands recently issued. CHECK_PROJECTILE(psObj); dump and exe attached as 7 zip ___ File Attachments: --- Date: Saturday 06/23/2007 at 22:05 Name: segfault_projectile_c.7z Size: 679kB By: urbanvoyeur http://gna.org/bugs/download.php?file_id=2478 ___ Reply to this item at: http://gna.org/bugs/?9382 ___ Message sent via/by Gna! http://gna.org/ ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
[Warzone-dev] Update bug tracker to 2.0.7
Minor Item: Please update the bug tracker to include 2.0.7 in the release pull down. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
Re: [Warzone-dev] [Warzone-commits] r1592 - /trunk/tools/masterserver/wzmasterserver.py
Am Sonntag, 24. Juni 2007 schrieb Dennis Schridde: Author: devurandom Date: Sun Jun 24 00:27:14 2007 New Revision: 1592 URL: http://svn.gna.org/viewcvs/warzone?rev=1592view=rev Log: - Don't list wrongly configured gameservers (eg. behind a NAT) - Try to fix len(None) (TypeError: len() of unsized object) PS: EvilGuru (Freddie Witherden) contributed this patch. I forgot to give credit. --Dennis signature.asc Description: This is a digitally signed message part. ___ Warzone-dev mailing list Warzone-dev@gna.org https://mail.gna.org/listinfo/warzone-dev
