[wtr-general] Re: watir-classic Element#style vs watir-webdriver Element#style

2012-10-29 Thread Connor C
Excellent! 

Thanks Jarmo

On Saturday, 27 October 2012 17:01:06 UTC+1, Jarmo Pertman wrote:

 It is now implemented in Watir-Classic 3.3.0.

 Jarmo Pertman
 -
 IT does really matter - http://itreallymatters.net

 On Friday, October 26, 2012 7:23:24 PM UTC+3, Connor C wrote:

 Thanks Justin! 

 We've got something similar to what you suggested implemented all ready. 
 I was hoping that classic and webdriver would behave the same way in 4.0. I 
 wonder are the watir guys planning on changing these to match in the future 
 or is there some reason why they are both different?

 Thanks again,
 Connor

 On Friday, 26 October 2012 14:23:48 UTC+1, Justin Ko wrote:

 I also ran into this yesterday. There was talk in 
 http://rubyforge.org/pipermail/wtr-development/2012-February/003541.htmlabout
  fixing watir-classic to be the same. Though it looks like it was not 
 implemented.

 I think all you would need to do for watir-classic is change the style 
 method to:

 # return the css style as a string
 def style(property = nil)
 assert_exists
 if property
 ole_object.currentStyle.send(property)
 else
 ole_object.style.cssText
 end
 end

 It would make watir-classic similar to watir-webdriver. Though I think 
 you would get different formats for some of the properties (example 
 'color').

 Justin Ko


 On Friday, October 26, 2012 6:26:53 AM UTC-4, Connor C wrote:

 Hey Jarmo or whoever else can help :), 

 In the latest wair-classic the Element#style() method works as follows

# return the css style as a string
 def style
   assert_exists
   ole_object.style.cssText
 end


 but it still doesn't behave like the webdriver version (which takes a 
 property argument).

def style(property = nil)
   if property
 assert_exists
 @element.style property
   else
 attribute_value(style).to_s.strip
   end
 end


  It would be really useful if the watir-classic behaviour matched the 
 web driver version. Are there any plans to update this in the future or is 
 there a specfic reason they are different? 

 Thanks thanks thanks,
 Connor



-- 
Before posting, please read http://watir.com/support. In short: search before 
you ask, be nice.

watir-general@googlegroups.com
http://groups.google.com/group/watir-general
watir-general+unsubscr...@googlegroups.com


[wtr-general] watir-classic Element#style vs watir-webdriver Element#style

2012-10-26 Thread Connor C
Hey Jarmo or whoever else can help :), 

In the latest wair-classic the Element#style() method works as follows

   # return the css style as a string
def style
  assert_exists
  ole_object.style.cssText
end


but it still doesn't behave like the webdriver version (which takes a 
property argument).

   def style(property = nil)
  if property
assert_exists
@element.style property
  else
attribute_value(style).to_s.strip
  end
end


 It would be really useful if the watir-classic behaviour matched the web 
driver version. Are there any plans to update this in the future or is 
there a specfic reason they are different? 

Thanks thanks thanks,
Connor

-- 
Before posting, please read http://watir.com/support. In short: search before 
you ask, be nice.

watir-general@googlegroups.com
http://groups.google.com/group/watir-general
watir-general+unsubscr...@googlegroups.com


[wtr-general] Re: watir-classic Element#style vs watir-webdriver Element#style

2012-10-26 Thread Connor C
Thanks Justin! 

We've got something similar to what you suggested implemented all ready. I 
was hoping that classic and webdriver would behave the same way in 4.0. I 
wonder are the watir guys planning on changing these to match in the future 
or is there some reason why they are both different?

Thanks again,
Connor

On Friday, 26 October 2012 14:23:48 UTC+1, Justin Ko wrote:

 I also ran into this yesterday. There was talk in 
 http://rubyforge.org/pipermail/wtr-development/2012-February/003541.htmlabout 
 fixing watir-classic to be the same. Though it looks like it was not 
 implemented.

 I think all you would need to do for watir-classic is change the style 
 method to:

 # return the css style as a string
 def style(property = nil)
 assert_exists
 if property
 ole_object.currentStyle.send(property)
 else
 ole_object.style.cssText
 end
 end

 It would make watir-classic similar to watir-webdriver. Though I think you 
 would get different formats for some of the properties (example 'color').

 Justin Ko


 On Friday, October 26, 2012 6:26:53 AM UTC-4, Connor C wrote:

 Hey Jarmo or whoever else can help :), 

 In the latest wair-classic the Element#style() method works as follows

# return the css style as a string
 def style
   assert_exists
   ole_object.style.cssText
 end


 but it still doesn't behave like the webdriver version (which takes a 
 property argument).

def style(property = nil)
   if property
 assert_exists
 @element.style property
   else
 attribute_value(style).to_s.strip
   end
 end


  It would be really useful if the watir-classic behaviour matched the web 
 driver version. Are there any plans to update this in the future or is 
 there a specfic reason they are different? 

 Thanks thanks thanks,
 Connor



-- 
Before posting, please read http://watir.com/support. In short: search before 
you ask, be nice.

watir-general@googlegroups.com
http://groups.google.com/group/watir-general
watir-general+unsubscr...@googlegroups.com