[Wayland-bugs] [Bug 774187] New: touchscreen event under wayland causes any GTK3 app to crash

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=774187

Bug ID: 774187
   Summary: touchscreen event under wayland causes any GTK3 app to
crash
Classification: Platform
   Product: gtk+
   Version: 3.22.x
OS: Linux
Status: NEW
  Severity: normal
  Priority: Normal
 Component: Backend: Wayland
  Assignee: gtk-b...@gtk.org
  Reporter: p.panayio...@gmail.com
QA Contact: gtk-b...@gtk.org
CC: r...@robster.org.uk, wayland-bugs@lists.freedesktop.org
 GNOME version: ---

Created attachment 339440
  --> https://bugzilla.gnome.org/attachment.cgi?id=339440&action=edit
core dump

Hello Gnome developers, and thank you for your excellent work that has given us
an amazing desktop.

This is an annoying bug that causes any GTK3 application to crash when using
the touchscreen. Unless I'm mistaken, it hasn't been reported yet.

Steps to reproduce:

1. Start any GTK3 application, for instance:
$ gnome-calculator

2. Tap on the clock in the top panel, to open the calendar drop-down.

3. Now tap on the application's window.

4. The application crashes.

This is 100% reproducible on my machine. I'm running Arch Linux with Gnome 3.22
on a Dell Inspiron 15-7568.

Backtrace:

(gdb) bt
#0  0x76d6948d in  () at /usr/lib/libgdk-3.so.0
#1  0x710a01c8 in ffi_call_unix64 () at /usr/lib/libffi.so.6
#2  0x7109fc2a in ffi_call () at /usr/lib/libffi.so.6
#3  0x71f4708e in  () at /usr/lib/libwayland-client.so.0
#4  0x71f43d20 in  () at /usr/lib/libwayland-client.so.0
#5  0x71f44f74 in wl_display_dispatch_queue_pending () at
/usr/lib/libwayland-client.so.0
#6  0x76d6f7e4 in  () at /usr/lib/libgdk-3.so.0
#7  0x76d0f169 in gdk_display_get_event () at /usr/lib/libgdk-3.so.0
#8  0x76d6f4d2 in  () at /usr/lib/libgdk-3.so.0
#9  0x75fbc587 in g_main_context_dispatch () at
/usr/lib/libglib-2.0.so.0
#10 0x75fbc7f0 in  () at /usr/lib/libglib-2.0.so.0
#11 0x75fbc89c in g_main_context_iteration () at
/usr/lib/libglib-2.0.so.0
#12 0x7657654d in g_application_run () at /usr/lib/libgio-2.0.so.0
#13 0x0040c1c5 in calculator_main ()
#14 0x759d7291 in __libc_start_main () at /usr/lib/libc.so.6
#15 0x0040af1a in _start ()

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774187] touchscreen event under wayland causes any GTK3 app to crash

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=774187

--- Comment #1 from Pantelis Panayiotou  ---
I forgot:

The crash does not happen when running the application using the X11 backend:
$ GDK_BACKEND=x11 gnome-calculator

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 768128] with wayland and gtk_window_begin_move_drag there's apparently no way to track where the window is

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=768128

--- Comment #6 from Caolan McNamara  ---
(In reply to Olivier Fourdan from comment #5)
> 
> If I understand correctly, those floating toolbars in LO can be detached to
> become floating, or re-attached to the main client window as a given
> location where they become part of the main window again.
> 
> That makes me think of the (now deprecated) GtkHandleBox:
> 
>   https://developer.gnome.org/gtk3/stable/GtkHandleBox.html

Yeah, its the same concept as GtkHandleBox, that's broken since 3.20 on all
platforms (http://trac.wxwidgets.org/ticket/17539) and never(?) worked under
wayland.

I'll just disable the possibility of floating toolbars under wayland I think,
anything else either won't work or be some unusual fragile edge case

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774187] touchscreen event under wayland causes any GTK3 app to crash

2016-11-10 Thread mutter
https://bugzilla.gnome.org/show_bug.cgi?id=774187

Carlos Garnacho  changed:

   What|Removed |Added

 CC||carl...@gnome.org
  Component|Backend: Wayland|wayland
   Assignee|gtk-b...@gtk.org|mutter-ma...@gnome.bugs
Product|gtk+|mutter
 QA Contact|gtk-b...@gtk.org|mutter-ma...@gnome.bugs

--- Comment #2 from Carlos Garnacho  ---
Thanks for the bug report! This is a mutter issue, the event indicating the
touch is down is not sent to the client underneath when leaving from a
compositor grab (like the calendar's), so the next touch update event(s) are
handled when the client is in an inconsistent state.

This is not legal according to the wayland protocol, so it's mutter which is
acting wrong here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774187] touchscreen event under wayland causes any GTK3 app to crash

2016-11-10 Thread mutter
https://bugzilla.gnome.org/show_bug.cgi?id=774187

Jan Alexander Steffens (heftig)  changed:

   What|Removed |Added

 CC||jan.steff...@gmail.com

--- Comment #3 from Jan Alexander Steffens (heftig)  ---
Hmm, can't GTK abort instead of segfault if it finds the state inconsistent?

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

--- Comment #7 from Gustavo Noronha (kov)  ---
I was talking to Pekka Paalanen about the pixman fast path and he was telling
me:

1) good luck getting anything new into pixman
2) affine matrix + scaling, repeat/pad masking all make fast paths harder to
find

I believe the problematic bit in question is scaling, since it is not a problem
when not in hidpi, so we could take that out of the equation, but I'm not sure
how - sounds like it would be a much more intrusive change. Pekka suggested
that I try disabling bilinear filtering:

diff --git a/gtk/gtkcssshadowvalue.c b/gtk/gtkcssshadowvalue.c
index 35d3df7..6de2bf1 100644
--- a/gtk/gtkcssshadowvalue.c
+++ b/gtk/gtkcssshadowvalue.c
@@ -381,6 +381,7 @@ mask_surface_repeat (cairo_t *cr,

 pattern = cairo_pattern_create_for_surface (surface);
 cairo_pattern_set_extend (pattern, CAIRO_EXTEND_REPEAT);
+cairo_pattern_set_filter (pattern, CAIRO_FILTER_FAST);

 cairo_mask (cr, pattern);

That improves things quite a bit, but not as much as my patch does - resizing
the main gtk3-demo window is still quite jerky, for instance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 98672] screenshot tools like scrot or maim do not work under (gnome) wayland

2016-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98672

Bug ID: 98672
   Summary: screenshot tools like scrot or maim do not work under
(gnome) wayland
   Product: Wayland
   Version: unspecified
  Hardware: Other
OS: Linux (All)
Status: NEW
  Severity: normal
  Priority: medium
 Component: XWayland
  Assignee: wayland-bugs@lists.freedesktop.org
  Reporter: lesm...@gmx.de
QA Contact: xorg-t...@lists.x.org

screenshot tools like scrot or maim do not work under (gnome) wayland.

scrot and maim produce black images with the dimension of my display.

import of imagemagick produces following error message

$ import -window root foo.png
import: unable to read X window image `root': Resource temporarily
unavailable @ error/xwindow.c/XImportImage/4983.
import: missing an image filename `foo.png' @
error/import.c/ImportImageCommand/1287.

this happened on my system since gnome 3.22 which uses wayland by default.
previously i did not test wayland.

when using gnome with X then scrot and maim and import produce screenshots as
expected.

i reported this bug to the maim developers. they said the following: "you'll be
better off submitting bug reports to the wayland team since imlib2's X11 calls
aren't being translated properly."

https://github.com/naelstrof/maim/issues/67

i use arch linux.

$ pacman -Q gnome-shell wayland xorg-server-xwayland
gnome-shell 3.22.1+2+g5a08886-1
wayland 1.12.0-1
xorg-server-xwayland 1.18.4-1

please tell me what more information do you need.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774187] touchscreen event under wayland causes any GTK3 app to crash

2016-11-10 Thread mutter
https://bugzilla.gnome.org/show_bug.cgi?id=774187

--- Comment #4 from Carlos Garnacho  ---
Sure, we can add some asserts. Doesn't change the fact that the app will
unexpectedly end :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 98672] screenshot tools like scrot or maim do not work under (gnome) wayland

2016-11-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98672

--- Comment #1 from Olivier Fourdan  ---
By design, Wayland is a lot more secure than X11 and does not allow one
application to capture the content of other applications' windows, meanignath a
X11 based screenshot tool cannot work underWayland/Xwayland.

Both Weston and gnome-shell (Wayland compositors) have screencast and
screenshot features built-in.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

--- Comment #8 from Gustavo Noronha (kov)  ---
Created attachment 339535
  --> https://bugzilla.gnome.org/attachment.cgi?id=339535&action=edit
cssshadowvalue: scale the blur surface by the same factor as the target

Making sure the surfaces are using the same scale factor makes it more
likely a fast path will be used when pixman gets involved, as pointed
out by Benjamin Otte.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

Benjamin Otte (Company)  changed:

   What|Removed |Added

 Attachment #339535|none|accepted-commit_now
 status||

--- Comment #9 from Benjamin Otte (Company)  ---
Comment on attachment 339535
  --> https://bugzilla.gnome.org/attachment.cgi?id=339535
cssshadowvalue: scale the blur surface by the same factor as the target

+cairo_pattern_set_filter (pattern, CAIRO_FILTER_FAST);

I suppose that's a leftover from the last patch?

With that line removed: Push it to master and 3.22!

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

--- Comment #10 from Gustavo Noronha (kov)  ---
\o/ indeed it is a leftover from the test above. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

--- Comment #11 from Gustavo Noronha (kov)  ---
Attachment 339535 pushed as 942e904 - cssshadowvalue: scale the blur surface by
the same factor as the target

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

Gustavo Noronha (kov)  changed:

   What|Removed |Added

 Attachment #338532|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

Gustavo Noronha (kov)  changed:

   What|Removed |Added

 Attachment #339535|accepted-commit_now |committed
 status||

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 772075] GTK+ uses a lot more CPU under Wayland than under X11

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=772075

Gustavo Noronha (kov)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774148] Gtk.Popover misplacement in Wayland

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=774148

Cédric Bellegarde  changed:

   What|Removed |Added

Summary|Gtk.Popover misplacement in |Gtk.Popover misplacement in
   |Wayland (conflict between   |Wayland
   |set_relative_to() and   |
   |set_pointing_to()   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs


[Wayland-bugs] [Bug 774148] Gtk.Popover misplacement in Wayland

2016-11-10 Thread gtk+
https://bugzilla.gnome.org/show_bug.cgi?id=774148

--- Comment #2 from Cédric Bellegarde  ---
Seems issue comes from this code:
https://mail.gnome.org/archives/commits-list/2014-December/msg04928.html


  gtk_widget_translate_coordinates (priv->widget, GTK_WIDGET
(priv->window),
rect.x, rect.y, &rect.x, &rect.y);
  gdk_window_get_origin (gtk_widget_get_window (GTK_WIDGET (popover)),
 &win_x, &win_y);

sets unwanted values when having a popover pointing to a popover.

-- 
You are receiving this mail because:
You are on the CC list for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs