[PATCH libinput 2/2] test: suppress Python3 valgrind errors
Running through mesontest also runs parse-hwdb through valgrind and gives us a bunch of leaks that originate within Python somewhere - we don't care about those. Signed-off-by: Peter Hutterer --- test/valgrind.suppressions | 6 ++ 1 file changed, 6 insertions(+) diff --git a/test/valgrind.suppressions b/test/valgrind.suppressions index b7f43499..e3ad874f 100644 --- a/test/valgrind.suppressions +++ b/test/valgrind.suppressions @@ -39,3 +39,9 @@ ... fun:litest_backtrace } +{ + python:PyUnicode_New + Memcheck:Leak + ... + obj:/usr/lib*/libpython3*.so* +} -- 2.12.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH libinput 1/2] test: disable coredumps during test suite runs
Running valgrind through mesontest produces coredumps for a lot of tests (unclear why, the core dump merely shows a call to abort). But even without mesontest, creating a core dump for each failed test is a bad idea - if one fails, most likely many others fail and the coredumps quickly fill up the file system. Signed-off-by: Peter Hutterer --- test/litest.c | 5 + 1 file changed, 5 insertions(+) diff --git a/test/litest.c b/test/litest.c index 9eadc459..62e86da7 100644 --- a/test/litest.c +++ b/test/litest.c @@ -39,6 +39,7 @@ #include #include "linux/input.h" #include +#include #include #include #include @@ -3581,6 +3582,7 @@ litest_list_tests(struct list *tests) int main(int argc, char **argv) { + const struct rlimit corelimit = { 0, 0 }; enum litest_mode mode; list_init(&all_tests); @@ -3619,6 +3621,9 @@ main(int argc, char **argv) return EXIT_SUCCESS; } + if (setrlimit(RLIMIT_CORE, &corelimit) == 0) + perror("WARNING: Core dumps not disabled. Reason"); + return litest_run(argc, argv); } #endif -- 2.12.2 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [RESEND] [PATCH] weston: Add support for "--foo bar" style options
On Friday, 2017-05-05 14:20:33 -0400, Lyude wrote: > A little earlier today I ended up spending a lot of time trying to > figure out why weston wasn't managing to launch over SSH and telling me > that I did not have a --tty option specified, despite me passing the > option strings ["--tty", "3"]. Turns out weston just doesn't support > that. > > So, add support for this kind of format in addition to "--foo=bar" to > save others from making the same mistake I did. > > Signed-off-by: Lyude > --- > Resending since I realized I was no longer subscribed to this mailing list > after the first time I sent this, whoops. > > shared/option-parser.c | 28 > 1 file changed, 28 insertions(+) > > diff --git a/shared/option-parser.c b/shared/option-parser.c > index eee7546..82f2f31 100644 > --- a/shared/option-parser.c > +++ b/shared/option-parser.c > @@ -87,6 +87,28 @@ long_option(const struct weston_option *options, int > count, char *arg) > } > > static int > +long_option_with_arg(const struct weston_option *options, int count, char > *arg, char *param) > +{ > + int k, len; > + > + for (k = 0; k < count; k++) { > + if (!options[k].name) > + continue; > + > + len = strlen(options[k].name); > + if (strncmp(options[k].name, arg + 2, len) != 0) > + continue; > + > + if (options[k].type == WESTON_OPTION_BOOLEAN) > + continue; Am I understanding this right, that you're skipping this here because it is already be handled by long_option()? I think this is actually unreachable, in which case an assert might better document this, or you can add a small comment. With either of these, the patch is Reviewed-by: Eric Engestrom Thanks! > + > + return handle_option(options + k, param); > + } > + > + return 0; > +} > + > +static int > short_option(const struct weston_option *options, int count, char *arg) > { > int k; > @@ -148,6 +170,12 @@ parse_options(const struct weston_option *options, > if (long_option(options, count, argv[i])) > continue; > > + /* ...also handle --foo bar */ > + if (i + 1 < *argc && > + long_option_with_arg(options, count, > argv[i], argv[i+1])) { > + i++; > + continue; > + } > } else { > /* Short option, e.g -f or -f42 */ > if (short_option(options, count, argv[i])) > -- > 2.9.3 > ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: Skylane - implementation of Wayland in Rust
Hi, Sorry about stupid noobish questions. Now I dived in a bit and know eglCreateImageKHR is everything I need. After whole day I have weston-simple-dmabuf-intel and EGL apps (weston-simple-egl, Qt) running on `perceptia` using linux-dmabuf-unstable-v1 and wayland-drm (yes, I know it's implementation detail, but that's the only way I can think of to make EGL applications talk to me.) Plan for client is to use offscreen GBM buffers + dmabuf protocol. After today I'm optimistic about that. Thank you for help! ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel