Re: [PATCH v4] linux-dmabuf: clarify DRM_FORMAT_MOD_INVALID

2019-05-03 Thread Chia-I Wu
On Thu, May 2, 2019 at 4:36 AM Daniel Stone  wrote:
>
> Hi,
>
> On Wed, 1 May 2019 at 09:53, Pekka Paalanen  wrote:
> > On Wed, 24 Apr 2019 10:07:47 -0700 Chia-I Wu  wrote:
> > > Can you commit this patch for me, if all looks good?
> >
> > I was almost already pushing this, but Daniel said he wants to have
> > a good look first.
>
> Indeed, I hadn't followed the discussion on the list so I wanted to
> pick that up before pushing. I've read through it though and am happy
> with it, so I've pushed it with my R-b.
>
> Thanks for the patience!
Thanks.  I will update Mesa when I get around to it.
>
> Cheers,
> Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Using libweston with GTK/GDK

2019-05-03 Thread adlo
> On 3 May 2019, at 10:20, Pekka Paalanen  wrote:
> 
> your Makefile.am needs the rules to generate the headers and .c files.
> 
>> 

I tried copying an edited Makefile.am from the wayland-protocols git 
repository, but it complained about GNU-isms. Is there anything else I need to 
do other than just specifying the location of the .xml files?

Regards

adlo
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: Using libweston with GTK/GDK

2019-05-03 Thread Pekka Paalanen
On Fri, 03 May 2019 05:40:46 +0100
adlo  wrote:

> On Wed, 2019-05-01 at 12:34 +0300, Pekka Paalanen wrote:
> > 
> > it is all just the normal Wayland protocol exchange but with a new
> > interface of your own design. I'm not sure if there is a really
> > minimal example, but I'll list at least some.
> > 
> > One example of such private protocol extension is
> > https://gitlab.freedesktop.org/wayland/weston/blob/master/protocol/weston-desktop-shell.xml
> > 
> >   
> 
> autotools doesn't seem to be generating the header files. I've put 
> 
> AC_ARG_VAR([wayland_scanner], [The wayland-scanner executable])
> AC_PATH_PROG([wayland_scanner], [wayland-scanner])
> if test x$wayland_scanner = x; then
> if test "x$cross_compiling" != "xyes"; then
> PKG_CHECK_MODULES(WAYLAND_SCANNER, [wayland-scanner])
> wayland_scanner=`$PKG_CONFIG --variable=wayland_scanner 
> wayland-scanner`
> else
> AC_MSG_WARN([You are cross compiling without wayland-
> scanner in your path.  make check will fail.])
> fi
> fi
> 
> in my configure.ac.in. What else do I need to do?

Hi,

your Makefile.am needs the rules to generate the headers and .c files.

> 
> In the meantime, I worked around it by running wayland-scanner and
> manually generating the header files, but when trying to do this:
> 
> static const struct xyz_interface xyz_implementation =
> {
> 
> };
> 
> ...
> 
>   wl_global_create (server->compositor->wl_display,
> &xyz_interface, 1,
> server, bind_desktop_shell);
> 
> the compiler gave me messages like "xyz_implementation has initializer
> but incomplete type" and "storage size of xyz_implementation isn't
> known" How can I resolve this?

Make sure you generate server-side headers for server side code, and
client-side headers for client side code, and include the appropriate
one.

> Also, what's the best way to include my private protocol's header
> files, being as my code is in $(topdir)/src and the protocol headers
> are in $(topdir)/protocols?

Whatever you prefer.


Thanks,
pq


pgpIISBPApb71.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel