Re: [PATCH] configure: Up the libwayland version requirement

2015-10-15 Thread Pekka Paalanen 
On Wed, 14 Oct 2015 20:22:18 -0500
Derek Foreman  wrote:

> On 14/10/15 05:40 PM, Bryce Harrington wrote:
> > weston commit f7bb9352 requires recent libwayland changes for providing
> > ‘WL_POINTER_RELEASE_SINCE_VERSION’.  Increase the version requirement to
> > indicate that current weston git requires development version of
> > wayland.
> > 
> > NOTE: At release we should probably increase the wayland requirement for
> > weston to 1.10.0.
> > 
> > Signed-off-by: Bryce Harrington 
> 
> Turns a compile time barf into a configure time one, at least for anyone
> trying to build a git weston with a stable wayland right now...
> 
> Reviewed-by: Derek Foreman 
> 
> > ---
> >  configure.ac | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 67e80d0..e5afbc0 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -59,7 +59,7 @@ AC_CHECK_HEADERS([execinfo.h])
> >  
> >  AC_CHECK_FUNCS([mkostemp strchrnul initgroups posix_fallocate])
> >  
> > -COMPOSITOR_MODULES="wayland-server >= 1.9.0 pixman-1 >= 0.25.2"
> > +COMPOSITOR_MODULES="wayland-server >= 1.9.90 pixman-1 >= 0.25.2"
> >  
> >  AC_CONFIG_FILES([doc/doxygen/tools.doxygen doc/doxygen/tooldev.doxygen])
> >  
> > @@ -317,7 +317,7 @@ AC_SUBST(JPEG_LIBS)
> >  
> >  PKG_CHECK_MODULES(CAIRO, [cairo])
> >  
> > -PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.0])
> > +PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.90])
> >  
> >  AC_ARG_ENABLE(simple-clients,
> >AS_HELP_STRING([--disable-simple-clients],

I see configure.ac has two wayland-server and nine wayland-client
pkg-config references. The two you bump are the ones that are
unconditionally required, AFAICT.

Reviewed-by: Pekka Paalanen 


Thanks,
pq


pgpWfkhFY4Aor.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] configure: Up the libwayland version requirement

2015-10-15 Thread Bryce Harrington 
On Thu, Oct 15, 2015 at 11:34:50AM +0300, Pekka Paalanen wrote:
> On Wed, 14 Oct 2015 20:22:18 -0500
> Derek Foreman  wrote:
> 
> > On 14/10/15 05:40 PM, Bryce Harrington wrote:
> > > weston commit f7bb9352 requires recent libwayland changes for providing
> > > ‘WL_POINTER_RELEASE_SINCE_VERSION’.  Increase the version requirement to
> > > indicate that current weston git requires development version of
> > > wayland.
> > > 
> > > NOTE: At release we should probably increase the wayland requirement for
> > > weston to 1.10.0.
> > > 
> > > Signed-off-by: Bryce Harrington 
> > 
> > Turns a compile time barf into a configure time one, at least for anyone
> > trying to build a git weston with a stable wayland right now...
> > 
> > Reviewed-by: Derek Foreman 

Pushed

remote: Updating patchwork state for 
http://patchwork.freedesktop.org/project/wayland/list/
remote: I: patch #61896 updated using rev 
c6e6dc78c1ed2ac28a76c5724e7f3f067f1b2214
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/wayland/weston
   ae2541d..c6e6dc7  master -> master


> > > ---
> > >  configure.ac | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/configure.ac b/configure.ac
> > > index 67e80d0..e5afbc0 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -59,7 +59,7 @@ AC_CHECK_HEADERS([execinfo.h])
> > >  
> > >  AC_CHECK_FUNCS([mkostemp strchrnul initgroups posix_fallocate])
> > >  
> > > -COMPOSITOR_MODULES="wayland-server >= 1.9.0 pixman-1 >= 0.25.2"
> > > +COMPOSITOR_MODULES="wayland-server >= 1.9.90 pixman-1 >= 0.25.2"
> > >  
> > >  AC_CONFIG_FILES([doc/doxygen/tools.doxygen doc/doxygen/tooldev.doxygen])
> > >  
> > > @@ -317,7 +317,7 @@ AC_SUBST(JPEG_LIBS)
> > >  
> > >  PKG_CHECK_MODULES(CAIRO, [cairo])
> > >  
> > > -PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.0])
> > > +PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.90])
> > >  
> > >  AC_ARG_ENABLE(simple-clients,
> > >AS_HELP_STRING([--disable-simple-clients],
> 
> I see configure.ac has two wayland-server and nine wayland-client
> pkg-config references. The two you bump are the ones that are
> unconditionally required, AFAICT.
> 
> Reviewed-by: Pekka Paalanen 
> 
> 
> Thanks,
> pq

> -BEGIN PGP SIGNATURE-
> Version: GnuPG v2
> 
> iQIVAwUBVh9lNiNf5bQRqqqnAQjxyA//YZRS5NoM7ZEkc9NAQheqbjIqQmu8ZPE4
> kAzf/Y7JFygDnSezURrzleD0ETUYw6xMQvMHIM12TaHHPuNoYMVJ+A05DL9LuA3B
> ygqesDd2JqvdScTHpPGnYFMHCdtyH1lt/yZwtz4H+r4Ya8NFrxpxTssZ3BBt1lDL
> IaQFIkwyplujuSmCvUL8I2rNjESiokqRqptWUSeJwR68wsDqeB7DvIWxyX8pKYsK
> 1AXkaxJQrkbtQO/Xda5rgLP6d5QYGDOPRcjxji9StsnL0a3kX1sApX1DcKOnThyG
> bg2H/BiEYMxPeaRQ2XTgY5v5EkfpkUBk/ace03Ws4prINyvFsb+ujj6OwJktbunj
> 9CzYLNiWfw6LCLJs8/4sd/r05LBzeDVbkj9g6eDKI7ZbZhF7dANQ5SPvc0/AgvfD
> 36/4uNbrenoUnhcrai3hJCgQqDK7TLpnUJiVEE3adh3DWYnJ47pqdS9CI+TzyqUg
> 8J8ePAQA4e5ffL7cTlAUJs8pOy7FfQJWV77+j/xYyx3fg70j3zyp9cmcFIlBjsAh
> vrFfXDnKkr1QrOCWZliaH3wIttizW2CIw3SUVOwddIqSgfJNLaBu0VJo76TslKrD
> 16pGBlMo8yJPQemY2oeTc44PSfPEzCWIg97ZyyeTZY4FFyR3hb7Lle2B9jPxrrcp
> bj7THTobx94=
> =fXIs
> -END PGP SIGNATURE-

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] configure: Up the libwayland version requirement

2015-10-14 Thread Bryce Harrington 
weston commit f7bb9352 requires recent libwayland changes for providing
‘WL_POINTER_RELEASE_SINCE_VERSION’.  Increase the version requirement to
indicate that current weston git requires development version of
wayland.

NOTE: At release we should probably increase the wayland requirement for
weston to 1.10.0.

Signed-off-by: Bryce Harrington 
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 67e80d0..e5afbc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -59,7 +59,7 @@ AC_CHECK_HEADERS([execinfo.h])
 
 AC_CHECK_FUNCS([mkostemp strchrnul initgroups posix_fallocate])
 
-COMPOSITOR_MODULES="wayland-server >= 1.9.0 pixman-1 >= 0.25.2"
+COMPOSITOR_MODULES="wayland-server >= 1.9.90 pixman-1 >= 0.25.2"
 
 AC_CONFIG_FILES([doc/doxygen/tools.doxygen doc/doxygen/tooldev.doxygen])
 
@@ -317,7 +317,7 @@ AC_SUBST(JPEG_LIBS)
 
 PKG_CHECK_MODULES(CAIRO, [cairo])
 
-PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.0])
+PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.90])
 
 AC_ARG_ENABLE(simple-clients,
   AS_HELP_STRING([--disable-simple-clients],
-- 
1.9.1

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] configure: Up the libwayland version requirement

2015-10-14 Thread Derek Foreman 
On 14/10/15 05:40 PM, Bryce Harrington wrote:
> weston commit f7bb9352 requires recent libwayland changes for providing
> ‘WL_POINTER_RELEASE_SINCE_VERSION’.  Increase the version requirement to
> indicate that current weston git requires development version of
> wayland.
> 
> NOTE: At release we should probably increase the wayland requirement for
> weston to 1.10.0.
> 
> Signed-off-by: Bryce Harrington 

Turns a compile time barf into a configure time one, at least for anyone
trying to build a git weston with a stable wayland right now...

Reviewed-by: Derek Foreman 

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 67e80d0..e5afbc0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -59,7 +59,7 @@ AC_CHECK_HEADERS([execinfo.h])
>  
>  AC_CHECK_FUNCS([mkostemp strchrnul initgroups posix_fallocate])
>  
> -COMPOSITOR_MODULES="wayland-server >= 1.9.0 pixman-1 >= 0.25.2"
> +COMPOSITOR_MODULES="wayland-server >= 1.9.90 pixman-1 >= 0.25.2"
>  
>  AC_CONFIG_FILES([doc/doxygen/tools.doxygen doc/doxygen/tooldev.doxygen])
>  
> @@ -317,7 +317,7 @@ AC_SUBST(JPEG_LIBS)
>  
>  PKG_CHECK_MODULES(CAIRO, [cairo])
>  
> -PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.0])
> +PKG_CHECK_MODULES(TEST_CLIENT, [wayland-client >= 1.9.90])
>  
>  AC_ARG_ENABLE(simple-clients,
>AS_HELP_STRING([--disable-simple-clients],
> 

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel