Re: [PATCH] install pkg-config file to /usr/share

[Pekka Paalanen]

On Wed, 2 Dec 2015 18:13:41 -0800
Bryce Harrington  wrote:

> Hi Quentin,
> 
> Wayland has some Ubuntu PPA nightly builds set up, which I'm updating to
> include wayland-protocols, which weston now needs to build.  However,
> one of the targets for these PPAs is the Ubuntu LTS 14.04, which shipped
> with an older pkg-config (version 0.26) that lacks support for
> PKG_NOARCH_INSTALLDIR (or, at least, it fails build with a message about
> noarch_pkgconfigdir being undefined.)
> 
> I'm not sure what to do here; Derek suggested asking your advice.  Now,
> I could just toss a newer pkg-config package into the PPA to use with
> 14.04; this would be an easy solution but is just a crutch and wouldn't
> help anyone else that might want to build on Ubuntu 14.04.  Another
> solution might be to modify wayland-protocols to not require this
> feature, at least not when older pkg-config is present; but I'm not sure
> whether such a patch would be accepted or how it should be written.
> Third option would be to just not worry about supporting packages for
> the 14.04 LTS anymore... but the 16.04 LTS is still months off.

Hi,

this was talked about in irc around Nov 26:

< hardening> Am I the only one to get "Makefile.am:18: error:
'noarch_pkgconfig_DATA' is used but 'noarch_pkgconfigdir' is undefined"
when compiling wayland-protocol (just updated, was working fine before)

< SardemFF7> hardening: You need a recent pkg-conig

< SardemFF7> if you think it’s normal not to have a recent pkg-config
(and maybe pkg-config-dev package on some distro), you can add that
file to
wayland-protocols: https://github.com/sardemff7/eventd/blob/master/m4/compat.m4

< hardening> SardemFF7: giving a try

< hardening> SardemFF7: nice your trick worked here

< SardemFF7> It’s not a trick, it’s just a compat file which defines
the needed macro if it’s not there already :-D

< hardening> SardemFF7, pq: So perhaps it would be a nice idea to have
that upstream ?

< pq> hardening, probably :-)


Even though it was said the version of pkg-config adding the support
was released in 2012 (how come it didn't go into Ubuntu of 2014...), I
think it would be fine to add the fallback macro since people are
hitting the issue.


Thanks,
pq

> 
> Bryce
> 
> On Sun, Nov 22, 2015 at 07:48:38PM +0100, Quentin Glidic wrote:
> > On 22/11/2015 13:31, Igor Gnatenko wrote:  
> > >It is arch-independent, so no need to install it to /usr/lib*
> > >
> > >Signed-off-by: Igor Gnatenko 
> > >---
> > >  Makefile.am | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/Makefile.am b/Makefile.am
> > >index a32e977..71b8799 100644
> > >--- a/Makefile.am
> > >+++ b/Makefile.am
> > >@@ -15,5 +15,5 @@ dist_noinst_DATA =   
> > >\
> > >   $(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
> > > \
> > >   $(NULL)
> > >
> > >-pkgconfigdir = $(libdir)/pkgconfig
> > >+pkgconfigdir = $(datadir)/pkgconfig
> > >  pkgconfig_DATA = wayland-protocols.pc
> > >  
> > 
> > 
> > Ideally, we should use PKG_NOARCH_INSTALLDIR (in configure.ac) and
> > drop the *dir from Makefile.am.
> > 
> > If that is not wanted, this patch is fine:
> > Reviewed-by: Quentin Glidic 
> > 
> > (Sorry for the duplicate mail Igor.)
> > 
> > -- 
> > 
> > Quentin “Sardem FF7” Glidic
> > ___
> > wayland-devel mailing list
> > wayland-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel  
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel



pgpIKh7z2sEmw.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] install pkg-config file to /usr/share

[Bryce Harrington]

Hi Quentin,

Wayland has some Ubuntu PPA nightly builds set up, which I'm updating to
include wayland-protocols, which weston now needs to build.  However,
one of the targets for these PPAs is the Ubuntu LTS 14.04, which shipped
with an older pkg-config (version 0.26) that lacks support for
PKG_NOARCH_INSTALLDIR (or, at least, it fails build with a message about
noarch_pkgconfigdir being undefined.)

I'm not sure what to do here; Derek suggested asking your advice.  Now,
I could just toss a newer pkg-config package into the PPA to use with
14.04; this would be an easy solution but is just a crutch and wouldn't
help anyone else that might want to build on Ubuntu 14.04.  Another
solution might be to modify wayland-protocols to not require this
feature, at least not when older pkg-config is present; but I'm not sure
whether such a patch would be accepted or how it should be written.
Third option would be to just not worry about supporting packages for
the 14.04 LTS anymore... but the 16.04 LTS is still months off.

Bryce

On Sun, Nov 22, 2015 at 07:48:38PM +0100, Quentin Glidic wrote:
> On 22/11/2015 13:31, Igor Gnatenko wrote:
> >It is arch-independent, so no need to install it to /usr/lib*
> >
> >Signed-off-by: Igor Gnatenko 
> >---
> >  Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/Makefile.am b/Makefile.am
> >index a32e977..71b8799 100644
> >--- a/Makefile.am
> >+++ b/Makefile.am
> >@@ -15,5 +15,5 @@ dist_noinst_DATA = 
> >\
> > $(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
> > \
> > $(NULL)
> >
> >-pkgconfigdir = $(libdir)/pkgconfig
> >+pkgconfigdir = $(datadir)/pkgconfig
> >  pkgconfig_DATA = wayland-protocols.pc
> >
> 
> 
> Ideally, we should use PKG_NOARCH_INSTALLDIR (in configure.ac) and
> drop the *dir from Makefile.am.
> 
> If that is not wanted, this patch is fine:
> Reviewed-by: Quentin Glidic 
> 
> (Sorry for the duplicate mail Igor.)
> 
> -- 
> 
> Quentin “Sardem FF7” Glidic
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] install pkg-config file to /usr/share

[Igor Gnatenko]

It is arch-independent, so no need to install it to /usr/lib*

Signed-off-by: Igor Gnatenko 
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index a32e977..71b8799 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,5 +15,5 @@ dist_noinst_DATA =
\
$(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
\
$(NULL)
 
-pkgconfigdir = $(libdir)/pkgconfig
+pkgconfigdir = $(datadir)/pkgconfig
 pkgconfig_DATA = wayland-protocols.pc
-- 
2.6.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] install pkg-config file to /usr/share

[Quentin Glidic]

On 22/11/2015 13:31, Igor Gnatenko wrote:

It is arch-independent, so no need to install it to /usr/lib*

Signed-off-by: Igor Gnatenko 
---
  Makefile.am | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index a32e977..71b8799 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,5 +15,5 @@ dist_noinst_DATA =
\
$(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
\
$(NULL)

-pkgconfigdir = $(libdir)/pkgconfig
+pkgconfigdir = $(datadir)/pkgconfig
  pkgconfig_DATA = wayland-protocols.pc




Ideally, we should use PKG_NOARCH_INSTALLDIR (in configure.ac) and drop 
the *dir from Makefile.am.


If that is not wanted, this patch is fine:
Reviewed-by: Quentin Glidic 

(Sorry for the duplicate mail Igor.)

--

Quentin “Sardem FF7” Glidic
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel