[PATCH 2/4] Add a release request to wl_output

2014-05-19 Thread Neil Roberts
Outputs can come and go within the compositor. If we don't have a way
for the client to destroy the resource then the resources within the
compositor will effectively leak until the client disconnects. This is
similar to the release event for wl_pointer.
---
 protocol/wayland.xml | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 22eb6e7..d1680f7 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -1652,7 +1652,7 @@
 /request
   /interface
 
-  interface name=wl_output version=2
+  interface name=wl_output version=3
 description summary=compositor output region
   An output describes part of the compositor geometry.  The
   compositor works in the 'compositor coordinate system' and an
@@ -1790,6 +1790,12 @@
   /description
   arg name=factor type=int summary=scaling factor of output/
 /event
+
+!-- Version 3 additions --
+
+request name=release type=destructor since=3
+  description summary=release the output object/
+/request
   /interface
 
   interface name=wl_region version=1
-- 
1.9.0

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


Re: [PATCH 2/4] Add a release request to wl_output

2014-05-19 Thread Jason Ekstrand
Yup, we need this.

Reviewed-By: Jason Ekstrand ja...@jlekstrand.net


On Mon, May 19, 2014 at 12:26 PM, Neil Roberts n...@linux.intel.com wrote:

 Outputs can come and go within the compositor. If we don't have a way
 for the client to destroy the resource then the resources within the
 compositor will effectively leak until the client disconnects. This is
 similar to the release event for wl_pointer.
 ---
  protocol/wayland.xml | 8 +++-
  1 file changed, 7 insertions(+), 1 deletion(-)

 diff --git a/protocol/wayland.xml b/protocol/wayland.xml
 index 22eb6e7..d1680f7 100644
 --- a/protocol/wayland.xml
 +++ b/protocol/wayland.xml
 @@ -1652,7 +1652,7 @@
  /request
/interface

 -  interface name=wl_output version=2
 +  interface name=wl_output version=3
  description summary=compositor output region
An output describes part of the compositor geometry.  The
compositor works in the 'compositor coordinate system' and an
 @@ -1790,6 +1790,12 @@
/description
arg name=factor type=int summary=scaling factor of output/
  /event
 +
 +!-- Version 3 additions --
 +
 +request name=release type=destructor since=3
 +  description summary=release the output object/
 +/request
/interface

interface name=wl_region version=1
 --
 1.9.0

 ___
 wayland-devel mailing list
 wayland-devel@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/wayland-devel

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel