Re: [PATCH libinput 1/1] touchpad: reduce palm detection threshold to 70mm

2015-04-16 Thread Hans de Goede

Hi,

On 16-04-15 08:18, Peter Hutterer wrote:

https://bugzilla.redhat.com/show_bug.cgi?id=1209753 lists a touchpad 76mm wide
that suffers from palm touches

Signed-off-by: Peter Hutterer 


Looks good:

Reviewed-by: Hans de Goede 

Regards,

Hans


---
  src/evdev-mt-touchpad.c | 2 +-
  test/touchpad.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 4e5a558..452cb85 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -1135,7 +1135,7 @@ tp_init_palmdetect(struct tp_dispatch *tp,

/* Enable palm detection on touchpads >= 80 mm. Anything smaller
   probably won't need it, until we find out it does */
-   if (width/device->abs.absinfo_x->resolution < 80)
+   if (width/device->abs.absinfo_x->resolution < 70)
return 0;
}

diff --git a/test/touchpad.c b/test/touchpad.c
index cd86f04..4e425f5 100644
--- a/test/touchpad.c
+++ b/test/touchpad.c
@@ -2469,7 +2469,7 @@ touchpad_has_palm_detect_size(struct litest_device *dev)

rc = libinput_device_get_size(dev->libinput_device, &width, &height);

-   return rc == 0 && width >= 80;
+   return rc == 0 && width >= 70;
  }

  START_TEST(touchpad_palm_detect_at_edge)


___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel


[PATCH libinput 1/1] touchpad: reduce palm detection threshold to 70mm

2015-04-15 Thread Peter Hutterer
https://bugzilla.redhat.com/show_bug.cgi?id=1209753 lists a touchpad 76mm wide
that suffers from palm touches

Signed-off-by: Peter Hutterer 
---
 src/evdev-mt-touchpad.c | 2 +-
 test/touchpad.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
index 4e5a558..452cb85 100644
--- a/src/evdev-mt-touchpad.c
+++ b/src/evdev-mt-touchpad.c
@@ -1135,7 +1135,7 @@ tp_init_palmdetect(struct tp_dispatch *tp,
 
/* Enable palm detection on touchpads >= 80 mm. Anything smaller
   probably won't need it, until we find out it does */
-   if (width/device->abs.absinfo_x->resolution < 80)
+   if (width/device->abs.absinfo_x->resolution < 70)
return 0;
}
 
diff --git a/test/touchpad.c b/test/touchpad.c
index cd86f04..4e425f5 100644
--- a/test/touchpad.c
+++ b/test/touchpad.c
@@ -2469,7 +2469,7 @@ touchpad_has_palm_detect_size(struct litest_device *dev)
 
rc = libinput_device_get_size(dev->libinput_device, &width, &height);
 
-   return rc == 0 && width >= 80;
+   return rc == 0 && width >= 70;
 }
 
 START_TEST(touchpad_palm_detect_at_edge)
-- 
2.3.4

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel