Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Tue, 7 Jun 2016 15:20:51 +0300 Pekka Paalanen wrote: > On Tue, 10 May 2016 12:56:41 +0300 > Pekka Paalanen wrote: > > > On Fri, 6 May 2016 15:07:19 +0300 > > Pekka Paalanen wrote: > > > > > On Thu, 5 May 2016 15:46:46 -0700 > > > Bryce Harrington wrote: > > > > > > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > > > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > > > > > > > > > > From: Pekka Paalanen > > > > > > > > > > > > Hi, > > > > > > > > > > > > here is the v3 of the stabilization series, which I hope to the > > > > > > final to be > > > > > > merged. > > > > > > > > > > > > The wayland-protocols patches are essentially the same as v2, > > > > > > except few > > > > > > cosmetic changes as suggested by review comments. There are > > > > > > mentioned in the > > > > > > review log in each patch, if there were any. > > > > > > > > > > > > The weston patches are v3 too, though v2 was never posted. The > > > > > > changes to v1 > > > > > > are: > > > > > > - patches 6-7 are new (simple preparation) > > > > > > - patches 8-12 are the same as v1 > > > > > > - patches 13-17 are new, accounting for the spec changes from > > > > > > wayland-protocols v1 > > > > > > > > > > > > Note, that there are now tests for the wp_viewporter API. \o/ > > > > > > > > > > > > > > > > > > Wayland-protocols: > > > > > > > > > > > > Pekka Paalanen (5): > > > > > > stable: add viewporter draft > > > > > > stable/viewporter: remove wp_viewport.set request > > > > > > stable/viewporter: rename and build > > > > > > stable/viewporter: rephrase a wp_viewport paragraph > > > > > > stable/viewporter: add more error cases > > > > > > > > > > > > Makefile.am | 1 + > > > > > > stable/viewporter/README | 7 ++ > > > > > > stable/viewporter/viewporter.xml | 189 > > > > > > +++ > > > > > > 3 files changed, 197 insertions(+) > > > > > > create mode 100644 stable/viewporter/README > > > > > > create mode 100644 stable/viewporter/viewporter.xml > > > > > > > > > > For landing these 5 wayland-protocol patches, either as stable or > > > > > unstable, as Jonas decides: > > > > > > > > > > Acked-by: Bryce Harrington > > > > > > Recorded. > > > > Hi, > > > > the wayland-protocols patches are now pushed: > >cc276df..83bdaa5 master -> master > > > > Now we just need a wayland-protocols release. We should have a couple > > of days for the last minute "oops" just in case. > > > > > > > > > > > > > > > Weston: > > > > > > > > > > > > Pekka Paalanen (12): > > > > > > compositor: constify weston_surface_build_buffer_matrix() > > > > > > compositor: refactor into convert_size_by_transform_scale() > > > > > > compositor: migrate to stable viewporter.xml > > > > > > compositor: rename scaler to viewport(er) > > > > > > clients/scaler: migrate to wp_viewporter > > > > > > clients/simple-damage: migrate to wp_viewporter > > > > > > protocol: remove scaler.xml > > > > > > compositor: fix wp_viewport use after free > > > > > > compositor: check viewport source rect validity > > > > > > compositor: check viewport dst size validity > > > > > > compositor: fix wp_viewport.set_source errors > > > > > > tests: add wp_viewporter tests > > > > > > > > The first two patches in this set don't depend on the protocol and look > > > > fine to land during beta. The rest I'm not sure about, they're a bit > > > > more than a mere rename of the protocol and add functionality. I don't > > > > have anything against them but wouldn't want to land them on my R-b > > > > alone, and unless they're particularly urgent it would be much more > > > > comfortable to land them post-release. I reviewed all the patches and > > > > aside from the nitpicks already mentioned, for purposes of landing post > > > > release you can consider them: > > > > > > > > Reviewed-by: Bryce Harrington > > > > > > Recorded. > > > > > > Yes, they missed 1.11 now, will be for 1.12, expect the first two I > > > already pushed with your reviews. > > > > This still holds, weston patches won't land until 1.11 is out. > > Hi all, > > patches 8 - 17 are still in the queue. They apply to master today as > is, the only thing I think that needs fixing is to update the > wayland-protocols dependency, IIRC. > > If I understood right, they already have: > Reviewed-by: Bryce Harrington > Reviewed-by: Yong Bakos > > Hmm, Yong, did you give R-b for pathes 8-17? I'm not quite sure if "v3 > is Reviewed-by" means that. > > Anyone else want to ack/nack? > > If no-one replies, I'll push these patches on, say, Thursday with both > Yong and Bryce R-b. Hi, hmm, Yong didn't reply yet, so I didn't add his R-b to all patches, since I wasn't sure. All the remaining patches of the viewporter work so far are pushed: 0de859e..82d95a6 master -> master
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Tue, 10 May 2016 12:56:41 +0300 Pekka Paalanen wrote: > On Fri, 6 May 2016 15:07:19 +0300 > Pekka Paalanen wrote: > > > On Thu, 5 May 2016 15:46:46 -0700 > > Bryce Harrington wrote: > > > > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > > > > From: Pekka Paalanen > > > > > > > > > > Hi, > > > > > > > > > > here is the v3 of the stabilization series, which I hope to the final > > > > > to be > > > > > merged. > > > > > > > > > > The wayland-protocols patches are essentially the same as v2, except > > > > > few > > > > > cosmetic changes as suggested by review comments. There are mentioned > > > > > in the > > > > > review log in each patch, if there were any. > > > > > > > > > > The weston patches are v3 too, though v2 was never posted. The > > > > > changes to v1 > > > > > are: > > > > > - patches 6-7 are new (simple preparation) > > > > > - patches 8-12 are the same as v1 > > > > > - patches 13-17 are new, accounting for the spec changes from > > > > > wayland-protocols v1 > > > > > > > > > > Note, that there are now tests for the wp_viewporter API. \o/ > > > > > > > > > > > > > > > Wayland-protocols: > > > > > > > > > > Pekka Paalanen (5): > > > > > stable: add viewporter draft > > > > > stable/viewporter: remove wp_viewport.set request > > > > > stable/viewporter: rename and build > > > > > stable/viewporter: rephrase a wp_viewport paragraph > > > > > stable/viewporter: add more error cases > > > > > > > > > > Makefile.am | 1 + > > > > > stable/viewporter/README | 7 ++ > > > > > stable/viewporter/viewporter.xml | 189 > > > > > +++ > > > > > 3 files changed, 197 insertions(+) > > > > > create mode 100644 stable/viewporter/README > > > > > create mode 100644 stable/viewporter/viewporter.xml > > > > > > > > For landing these 5 wayland-protocol patches, either as stable or > > > > unstable, as Jonas decides: > > > > > > > > Acked-by: Bryce Harrington > > > > Recorded. > > Hi, > > the wayland-protocols patches are now pushed: >cc276df..83bdaa5 master -> master > > Now we just need a wayland-protocols release. We should have a couple > of days for the last minute "oops" just in case. > > > > > > > > > > > Weston: > > > > > > > > > > Pekka Paalanen (12): > > > > > compositor: constify weston_surface_build_buffer_matrix() > > > > > compositor: refactor into convert_size_by_transform_scale() > > > > > compositor: migrate to stable viewporter.xml > > > > > compositor: rename scaler to viewport(er) > > > > > clients/scaler: migrate to wp_viewporter > > > > > clients/simple-damage: migrate to wp_viewporter > > > > > protocol: remove scaler.xml > > > > > compositor: fix wp_viewport use after free > > > > > compositor: check viewport source rect validity > > > > > compositor: check viewport dst size validity > > > > > compositor: fix wp_viewport.set_source errors > > > > > tests: add wp_viewporter tests > > > > > > The first two patches in this set don't depend on the protocol and look > > > fine to land during beta. The rest I'm not sure about, they're a bit > > > more than a mere rename of the protocol and add functionality. I don't > > > have anything against them but wouldn't want to land them on my R-b > > > alone, and unless they're particularly urgent it would be much more > > > comfortable to land them post-release. I reviewed all the patches and > > > aside from the nitpicks already mentioned, for purposes of landing post > > > release you can consider them: > > > > > > Reviewed-by: Bryce Harrington > > > > Recorded. > > > > Yes, they missed 1.11 now, will be for 1.12, expect the first two I > > already pushed with your reviews. > > This still holds, weston patches won't land until 1.11 is out. Hi all, patches 8 - 17 are still in the queue. They apply to master today as is, the only thing I think that needs fixing is to update the wayland-protocols dependency, IIRC. If I understood right, they already have: Reviewed-by: Bryce Harrington Reviewed-by: Yong Bakos Hmm, Yong, did you give R-b for pathes 8-17? I'm not quite sure if "v3 is Reviewed-by" means that. Anyone else want to ack/nack? If no-one replies, I'll push these patches on, say, Thursday with both Yong and Bryce R-b. Thanks, pq pgpVNlmVdWNvS.pgp Description: OpenPGP digital signature ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Fri, 6 May 2016 15:07:19 +0300 Pekka Paalanen wrote: > On Thu, 5 May 2016 15:46:46 -0700 > Bryce Harrington wrote: > > > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > > > From: Pekka Paalanen > > > > > > > > Hi, > > > > > > > > here is the v3 of the stabilization series, which I hope to the final > > > > to be > > > > merged. > > > > > > > > The wayland-protocols patches are essentially the same as v2, except few > > > > cosmetic changes as suggested by review comments. There are mentioned > > > > in the > > > > review log in each patch, if there were any. > > > > > > > > The weston patches are v3 too, though v2 was never posted. The changes > > > > to v1 > > > > are: > > > > - patches 6-7 are new (simple preparation) > > > > - patches 8-12 are the same as v1 > > > > - patches 13-17 are new, accounting for the spec changes from > > > > wayland-protocols v1 > > > > > > > > Note, that there are now tests for the wp_viewporter API. \o/ > > > > > > > > > > > > Wayland-protocols: > > > > > > > > Pekka Paalanen (5): > > > > stable: add viewporter draft > > > > stable/viewporter: remove wp_viewport.set request > > > > stable/viewporter: rename and build > > > > stable/viewporter: rephrase a wp_viewport paragraph > > > > stable/viewporter: add more error cases > > > > > > > > Makefile.am | 1 + > > > > stable/viewporter/README | 7 ++ > > > > stable/viewporter/viewporter.xml | 189 > > > > +++ > > > > 3 files changed, 197 insertions(+) > > > > create mode 100644 stable/viewporter/README > > > > create mode 100644 stable/viewporter/viewporter.xml > > > > > > For landing these 5 wayland-protocol patches, either as stable or > > > unstable, as Jonas decides: > > > > > > Acked-by: Bryce Harrington > > Recorded. Hi, the wayland-protocols patches are now pushed: cc276df..83bdaa5 master -> master Now we just need a wayland-protocols release. We should have a couple of days for the last minute "oops" just in case. > > > > > > > Weston: > > > > > > > > Pekka Paalanen (12): > > > > compositor: constify weston_surface_build_buffer_matrix() > > > > compositor: refactor into convert_size_by_transform_scale() > > > > compositor: migrate to stable viewporter.xml > > > > compositor: rename scaler to viewport(er) > > > > clients/scaler: migrate to wp_viewporter > > > > clients/simple-damage: migrate to wp_viewporter > > > > protocol: remove scaler.xml > > > > compositor: fix wp_viewport use after free > > > > compositor: check viewport source rect validity > > > > compositor: check viewport dst size validity > > > > compositor: fix wp_viewport.set_source errors > > > > tests: add wp_viewporter tests > > > > The first two patches in this set don't depend on the protocol and look > > fine to land during beta. The rest I'm not sure about, they're a bit > > more than a mere rename of the protocol and add functionality. I don't > > have anything against them but wouldn't want to land them on my R-b > > alone, and unless they're particularly urgent it would be much more > > comfortable to land them post-release. I reviewed all the patches and > > aside from the nitpicks already mentioned, for purposes of landing post > > release you can consider them: > > > > Reviewed-by: Bryce Harrington > > Recorded. > > Yes, they missed 1.11 now, will be for 1.12, expect the first two I > already pushed with your reviews. This still holds, weston patches won't land until 1.11 is out. Thanks, pq > > > > Makefile.am | 27 ++- > > > > clients/scaler.c| 43 ++-- > > > > clients/simple-damage.c | 32 +-- > > > > configure.ac| 2 + > > > > protocol/scaler.xml | 208 -- > > > > src/compositor.c| 343 +++--- > > > > src/compositor.h| 5 +- > > > > tests/viewporter-test.c | 553 > > > > > > > > 8 files changed, 823 insertions(+), 390 deletions(-) > > > > delete mode 100644 protocol/scaler.xml > > > > create mode 100644 tests/viewporter-test.c > > > > pgpca4RJqL4FM.pgp Description: OpenPGP digital signature ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Thu, 5 May 2016 15:46:46 -0700 Bryce Harrington wrote: > On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > > > Hi, > > > > > > here is the v3 of the stabilization series, which I hope to the final to > > > be > > > merged. > > > > > > The wayland-protocols patches are essentially the same as v2, except few > > > cosmetic changes as suggested by review comments. There are mentioned in > > > the > > > review log in each patch, if there were any. > > > > > > The weston patches are v3 too, though v2 was never posted. The changes to > > > v1 > > > are: > > > - patches 6-7 are new (simple preparation) > > > - patches 8-12 are the same as v1 > > > - patches 13-17 are new, accounting for the spec changes from > > > wayland-protocols v1 > > > > > > Note, that there are now tests for the wp_viewporter API. \o/ > > > > > > > > > Wayland-protocols: > > > > > > Pekka Paalanen (5): > > > stable: add viewporter draft > > > stable/viewporter: remove wp_viewport.set request > > > stable/viewporter: rename and build > > > stable/viewporter: rephrase a wp_viewport paragraph > > > stable/viewporter: add more error cases > > > > > > Makefile.am | 1 + > > > stable/viewporter/README | 7 ++ > > > stable/viewporter/viewporter.xml | 189 > > > +++ > > > 3 files changed, 197 insertions(+) > > > create mode 100644 stable/viewporter/README > > > create mode 100644 stable/viewporter/viewporter.xml > > > > For landing these 5 wayland-protocol patches, either as stable or > > unstable, as Jonas decides: > > > > Acked-by: Bryce Harrington Recorded. > > > > > Weston: > > > > > > Pekka Paalanen (12): > > > compositor: constify weston_surface_build_buffer_matrix() > > > compositor: refactor into convert_size_by_transform_scale() > > > compositor: migrate to stable viewporter.xml > > > compositor: rename scaler to viewport(er) > > > clients/scaler: migrate to wp_viewporter > > > clients/simple-damage: migrate to wp_viewporter > > > protocol: remove scaler.xml > > > compositor: fix wp_viewport use after free > > > compositor: check viewport source rect validity > > > compositor: check viewport dst size validity > > > compositor: fix wp_viewport.set_source errors > > > tests: add wp_viewporter tests > > The first two patches in this set don't depend on the protocol and look > fine to land during beta. The rest I'm not sure about, they're a bit > more than a mere rename of the protocol and add functionality. I don't > have anything against them but wouldn't want to land them on my R-b > alone, and unless they're particularly urgent it would be much more > comfortable to land them post-release. I reviewed all the patches and > aside from the nitpicks already mentioned, for purposes of landing post > release you can consider them: > > Reviewed-by: Bryce Harrington Recorded. Yes, they missed 1.11 now, will be for 1.12, expect the first two I already pushed with your reviews. Thanks, pq > > > Makefile.am | 27 ++- > > > clients/scaler.c| 43 ++-- > > > clients/simple-damage.c | 32 +-- > > > configure.ac| 2 + > > > protocol/scaler.xml | 208 -- > > > src/compositor.c| 343 +++--- > > > src/compositor.h| 5 +- > > > tests/viewporter-test.c | 553 > > > > > > 8 files changed, 823 insertions(+), 390 deletions(-) > > > delete mode 100644 protocol/scaler.xml > > > create mode 100644 tests/viewporter-test.c > > > pgpMtZODniEg8.pgp Description: OpenPGP digital signature ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Wed, May 04, 2016 at 05:33:10PM -0700, Bryce Harrington wrote: > On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > > From: Pekka Paalanen > > > > Hi, > > > > here is the v3 of the stabilization series, which I hope to the final to be > > merged. > > > > The wayland-protocols patches are essentially the same as v2, except few > > cosmetic changes as suggested by review comments. There are mentioned in the > > review log in each patch, if there were any. > > > > The weston patches are v3 too, though v2 was never posted. The changes to v1 > > are: > > - patches 6-7 are new (simple preparation) > > - patches 8-12 are the same as v1 > > - patches 13-17 are new, accounting for the spec changes from > > wayland-protocols v1 > > > > Note, that there are now tests for the wp_viewporter API. \o/ > > > > > > Wayland-protocols: > > > > Pekka Paalanen (5): > > stable: add viewporter draft > > stable/viewporter: remove wp_viewport.set request > > stable/viewporter: rename and build > > stable/viewporter: rephrase a wp_viewport paragraph > > stable/viewporter: add more error cases > > > > Makefile.am | 1 + > > stable/viewporter/README | 7 ++ > > stable/viewporter/viewporter.xml | 189 > > +++ > > 3 files changed, 197 insertions(+) > > create mode 100644 stable/viewporter/README > > create mode 100644 stable/viewporter/viewporter.xml > > For landing these 5 wayland-protocol patches, either as stable or > unstable, as Jonas decides: > > Acked-by: Bryce Harrington > > > Weston: > > > > Pekka Paalanen (12): > > compositor: constify weston_surface_build_buffer_matrix() > > compositor: refactor into convert_size_by_transform_scale() > > compositor: migrate to stable viewporter.xml > > compositor: rename scaler to viewport(er) > > clients/scaler: migrate to wp_viewporter > > clients/simple-damage: migrate to wp_viewporter > > protocol: remove scaler.xml > > compositor: fix wp_viewport use after free > > compositor: check viewport source rect validity > > compositor: check viewport dst size validity > > compositor: fix wp_viewport.set_source errors > > tests: add wp_viewporter tests The first two patches in this set don't depend on the protocol and look fine to land during beta. The rest I'm not sure about, they're a bit more than a mere rename of the protocol and add functionality. I don't have anything against them but wouldn't want to land them on my R-b alone, and unless they're particularly urgent it would be much more comfortable to land them post-release. I reviewed all the patches and aside from the nitpicks already mentioned, for purposes of landing post release you can consider them: Reviewed-by: Bryce Harrington > > Makefile.am | 27 ++- > > clients/scaler.c| 43 ++-- > > clients/simple-damage.c | 32 +-- > > configure.ac| 2 + > > protocol/scaler.xml | 208 -- > > src/compositor.c| 343 +++--- > > src/compositor.h| 5 +- > > tests/viewporter-test.c | 553 > > > > 8 files changed, 823 insertions(+), 390 deletions(-) > > delete mode 100644 protocol/scaler.xml > > create mode 100644 tests/viewporter-test.c > > > > > > Thanks, > > pq > > > > ___ > > wayland-devel mailing list > > wayland-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/wayland-devel > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Tue, Apr 26, 2016 at 03:50:52PM +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > Hi, > > here is the v3 of the stabilization series, which I hope to the final to be > merged. > > The wayland-protocols patches are essentially the same as v2, except few > cosmetic changes as suggested by review comments. There are mentioned in the > review log in each patch, if there were any. > > The weston patches are v3 too, though v2 was never posted. The changes to v1 > are: > - patches 6-7 are new (simple preparation) > - patches 8-12 are the same as v1 > - patches 13-17 are new, accounting for the spec changes from > wayland-protocols v1 > > Note, that there are now tests for the wp_viewporter API. \o/ > > > Wayland-protocols: > > Pekka Paalanen (5): > stable: add viewporter draft > stable/viewporter: remove wp_viewport.set request > stable/viewporter: rename and build > stable/viewporter: rephrase a wp_viewport paragraph > stable/viewporter: add more error cases > > Makefile.am | 1 + > stable/viewporter/README | 7 ++ > stable/viewporter/viewporter.xml | 189 > +++ > 3 files changed, 197 insertions(+) > create mode 100644 stable/viewporter/README > create mode 100644 stable/viewporter/viewporter.xml For landing these 5 wayland-protocol patches, either as stable or unstable, as Jonas decides: Acked-by: Bryce Harrington > Weston: > > Pekka Paalanen (12): > compositor: constify weston_surface_build_buffer_matrix() > compositor: refactor into convert_size_by_transform_scale() > compositor: migrate to stable viewporter.xml > compositor: rename scaler to viewport(er) > clients/scaler: migrate to wp_viewporter > clients/simple-damage: migrate to wp_viewporter > protocol: remove scaler.xml > compositor: fix wp_viewport use after free > compositor: check viewport source rect validity > compositor: check viewport dst size validity > compositor: fix wp_viewport.set_source errors > tests: add wp_viewporter tests > > Makefile.am | 27 ++- > clients/scaler.c| 43 ++-- > clients/simple-damage.c | 32 +-- > configure.ac| 2 + > protocol/scaler.xml | 208 -- > src/compositor.c| 343 +++--- > src/compositor.h| 5 +- > tests/viewporter-test.c | 553 > > 8 files changed, 823 insertions(+), 390 deletions(-) > delete mode 100644 protocol/scaler.xml > create mode 100644 tests/viewporter-test.c > > > Thanks, > pq > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
On Apr 26, 2016, at 7:50 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen > > Hi, > > here is the v3 of the stabilization series, which I hope to the final to be > merged. > > The wayland-protocols patches are essentially the same as v2, except few > cosmetic changes as suggested by review comments. There are mentioned in the > review log in each patch, if there were any. > > The weston patches are v3 too, though v2 was never posted. The changes to v1 > are: > - patches 6-7 are new (simple preparation) > - patches 8-12 are the same as v1 > - patches 13-17 are new, accounting for the spec changes from > wayland-protocols v1 > > Note, that there are now tests for the wp_viewporter API. \o/ > > > Wayland-protocols: > > Pekka Paalanen (5): > stable: add viewporter draft > stable/viewporter: remove wp_viewport.set request > stable/viewporter: rename and build > stable/viewporter: rephrase a wp_viewport paragraph > stable/viewporter: add more error cases > > Makefile.am | 1 + > stable/viewporter/README | 7 ++ > stable/viewporter/viewporter.xml | 189 +++ > 3 files changed, 197 insertions(+) > create mode 100644 stable/viewporter/README > create mode 100644 stable/viewporter/viewporter.xml 1-5 look good and v3 is Reviewed-by Yong Bakos . yong > > Weston: > > Pekka Paalanen (12): > compositor: constify weston_surface_build_buffer_matrix() > compositor: refactor into convert_size_by_transform_scale() > compositor: migrate to stable viewporter.xml > compositor: rename scaler to viewport(er) > clients/scaler: migrate to wp_viewporter > clients/simple-damage: migrate to wp_viewporter > protocol: remove scaler.xml > compositor: fix wp_viewport use after free > compositor: check viewport source rect validity > compositor: check viewport dst size validity > compositor: fix wp_viewport.set_source errors > tests: add wp_viewporter tests > > Makefile.am | 27 ++- > clients/scaler.c| 43 ++-- > clients/simple-damage.c | 32 +-- > configure.ac| 2 + > protocol/scaler.xml | 208 -- > src/compositor.c| 343 +++--- > src/compositor.h| 5 +- > tests/viewporter-test.c | 553 > 8 files changed, 823 insertions(+), 390 deletions(-) > delete mode 100644 protocol/scaler.xml > create mode 100644 tests/viewporter-test.c > > > Thanks, > pq > > ___ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH wayland-protocols, weston v3 0/17] Stabilize wl_scaler as wp_viewporter
From: Pekka Paalanen Hi, here is the v3 of the stabilization series, which I hope to the final to be merged. The wayland-protocols patches are essentially the same as v2, except few cosmetic changes as suggested by review comments. There are mentioned in the review log in each patch, if there were any. The weston patches are v3 too, though v2 was never posted. The changes to v1 are: - patches 6-7 are new (simple preparation) - patches 8-12 are the same as v1 - patches 13-17 are new, accounting for the spec changes from wayland-protocols v1 Note, that there are now tests for the wp_viewporter API. \o/ Wayland-protocols: Pekka Paalanen (5): stable: add viewporter draft stable/viewporter: remove wp_viewport.set request stable/viewporter: rename and build stable/viewporter: rephrase a wp_viewport paragraph stable/viewporter: add more error cases Makefile.am | 1 + stable/viewporter/README | 7 ++ stable/viewporter/viewporter.xml | 189 +++ 3 files changed, 197 insertions(+) create mode 100644 stable/viewporter/README create mode 100644 stable/viewporter/viewporter.xml Weston: Pekka Paalanen (12): compositor: constify weston_surface_build_buffer_matrix() compositor: refactor into convert_size_by_transform_scale() compositor: migrate to stable viewporter.xml compositor: rename scaler to viewport(er) clients/scaler: migrate to wp_viewporter clients/simple-damage: migrate to wp_viewporter protocol: remove scaler.xml compositor: fix wp_viewport use after free compositor: check viewport source rect validity compositor: check viewport dst size validity compositor: fix wp_viewport.set_source errors tests: add wp_viewporter tests Makefile.am | 27 ++- clients/scaler.c| 43 ++-- clients/simple-damage.c | 32 +-- configure.ac| 2 + protocol/scaler.xml | 208 -- src/compositor.c| 343 +++--- src/compositor.h| 5 +- tests/viewporter-test.c | 553 8 files changed, 823 insertions(+), 390 deletions(-) delete mode 100644 protocol/scaler.xml create mode 100644 tests/viewporter-test.c Thanks, pq ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
