Re: [PATCH wayland-protocols 4/4] Makefile: install and dist stable protocols

[Pekka Paalanen]

On Mon, 22 Feb 2016 15:41:46 -0800
Bryce Harrington  wrote:

> On Mon, Feb 22, 2016 at 03:34:43PM +0200, Pekka Paalanen wrote:
> > From: Pekka Paalanen 
> > 
> > Signed-off-by: Pekka Paalanen   
> 
> Personally I'd squash 2,3,4 since they're all short "hook things up"
> changes that go together, but no biggie.

That is a possibility, sure. In my mind, patch 2 is the changes to the
spec and nothing else and very important to review. Patch 3 is hooking
it up in the build since patch 1 didn't do that when adding the file
(because the spec was not finished). Patch 4 could be landed completely
separately, if wanted, so it's separate.

> Reviewed-by: Bryce Harrington 

Thanks for the reviews for wayland-protocols. I'll probably do the
suggested changes as follow-ups.

Thanks,
pq

> 
> > ---
> >  Makefile.am | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 21b1a00..e0bd079 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -15,10 +15,12 @@ stable_protocols =  
> > \
> >  
> >  nobase_dist_pkgdata_DATA = 
> > \
> > $(unstable_protocols)   
> > \
> > +   $(stable_protocols) 
> > \
> > $(NULL)
> >  
> >  dist_noinst_DATA = 
> > \
> > $(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
> > \
> > +   $(sort $(foreach p,$(stable_protocols),$(dir $p)README))
> > \
> > $(NULL)
> >  
> >  noarch_pkgconfig_DATA = wayland-protocols.pc
> > -- 
> > 2.4.10


pgpx7WEp8CGxs.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols 4/4] Makefile: install and dist stable protocols

[Bryce Harrington]

On Mon, Feb 22, 2016 at 03:34:43PM +0200, Pekka Paalanen wrote:
> From: Pekka Paalanen 
> 
> Signed-off-by: Pekka Paalanen 

Personally I'd squash 2,3,4 since they're all short "hook things up"
changes that go together, but no biggie.

Reviewed-by: Bryce Harrington 

> ---
>  Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 21b1a00..e0bd079 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -15,10 +15,12 @@ stable_protocols =
> \
>  
>  nobase_dist_pkgdata_DATA =   
> \
>   $(unstable_protocols)   
> \
> + $(stable_protocols) 
> \
>   $(NULL)
>  
>  dist_noinst_DATA =   
> \
>   $(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
> \
> + $(sort $(foreach p,$(stable_protocols),$(dir $p)README))
> \
>   $(NULL)
>  
>  noarch_pkgconfig_DATA = wayland-protocols.pc
> -- 
> 2.4.10
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland-protocols 4/4] Makefile: install and dist stable protocols

[Pekka Paalanen]

From: Pekka Paalanen 

Signed-off-by: Pekka Paalanen 
---
 Makefile.am | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index 21b1a00..e0bd079 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -15,10 +15,12 @@ stable_protocols =  
\
 
 nobase_dist_pkgdata_DATA = 
\
$(unstable_protocols)   
\
+   $(stable_protocols) 
\
$(NULL)
 
 dist_noinst_DATA = 
\
$(sort $(foreach p,$(unstable_protocols),$(dir $p)README))  
\
+   $(sort $(foreach p,$(stable_protocols),$(dir $p)README))
\
$(NULL)
 
 noarch_pkgconfig_DATA = wayland-protocols.pc
-- 
2.4.10

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel