Re: [PATCH wayland-protocols 4/4] xdg-shell: Drop desktop environment specific state allocations

[Bryce Harrington]

On Fri, Jul 29, 2016 at 12:04:56PM +0800, Jonas Ådahl wrote:
> Instead of allocating state ranges that desktop environments can use as
> they want, let them introduce their own protocol and their own enums.
> 
> If such desktop environment protocols need the configure/ack_configure
> semantics, they can design their protocols to extend xdg_surface, and
> make their private configure events a latched state tied to
> xdg_surface.configure.
> 
> Signed-off-by: Jonas Ådahl 

Acked-by: Bryce Harrington 
> ---
>  unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 
>  1 file changed, 12 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml 
> b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index ef45ff4..72f070c 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -702,18 +702,6 @@
>  
>   States set in this way are double-buffered. They will get applied on
>   the next commit.
> -
> - Desktop environments may extend this enum by taking up a range of
> - values and documenting the range they chose in this description.
> - They are not required to document the values for the range that they
> - chose. Ideally, any good extensions from a desktop environment should
> - make its way into standardization into this enum.
> -
> - The current reserved ranges are:
> -
> - 0x - 0x0FFF: xdg-shell core values, documented below.
> - 0x1000 - 0x1FFF: GNOME
> - 0x2000 - 0x2FFF: EFL
>
>
>   
> -- 
> 2.7.4
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-protocols 4/4] xdg-shell: Drop desktop environment specific state allocations

[Quentin Glidic]

On 29/07/2016 06:04, Jonas Ådahl wrote:

Instead of allocating state ranges that desktop environments can use as
they want, let them introduce their own protocol and their own enums.

If such desktop environment protocols need the configure/ack_configure
semantics, they can design their protocols to extend xdg_surface, and
make their private configure events a latched state tied to
xdg_surface.configure.

Signed-off-by: Jonas Ådahl 
---


Great, with the shared configure event it makes a lot of sense:
Reviewed-by: Quentin Glidic 

Cheers,


 unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 
 1 file changed, 12 deletions(-)

diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml 
b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
index ef45ff4..72f070c 100644
--- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
+++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
@@ -702,18 +702,6 @@

States set in this way are double-buffered. They will get applied on
the next commit.
-
-   Desktop environments may extend this enum by taking up a range of
-   values and documenting the range they chose in this description.
-   They are not required to document the values for the range that they
-   chose. Ideally, any good extensions from a desktop environment should
-   make its way into standardization into this enum.
-
-   The current reserved ranges are:
-
-   0x - 0x0FFF: xdg-shell core values, documented below.
-   0x1000 - 0x1FFF: GNOME
-   0x2000 - 0x2FFF: EFL
   
   





--

Quentin “Sardem FF7” Glidic
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH wayland-protocols 4/4] xdg-shell: Drop desktop environment specific state allocations

[Jonas Ådahl]

Instead of allocating state ranges that desktop environments can use as
they want, let them introduce their own protocol and their own enums.

If such desktop environment protocols need the configure/ack_configure
semantics, they can design their protocols to extend xdg_surface, and
make their private configure events a latched state tied to
xdg_surface.configure.

Signed-off-by: Jonas Ådahl 
---
 unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 
 1 file changed, 12 deletions(-)

diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml 
b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
index ef45ff4..72f070c 100644
--- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
+++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
@@ -702,18 +702,6 @@
 
States set in this way are double-buffered. They will get applied on
the next commit.
-
-   Desktop environments may extend this enum by taking up a range of
-   values and documenting the range they chose in this description.
-   They are not required to document the values for the range that they
-   chose. Ideally, any good extensions from a desktop environment should
-   make its way into standardization into this enum.
-
-   The current reserved ranges are:
-
-   0x - 0x0FFF: xdg-shell core values, documented below.
-   0x1000 - 0x1FFF: GNOME
-   0x2000 - 0x2FFF: EFL
   
   

-- 
2.7.4

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel