Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --- > src/compositor-drm.c | 14 +- > src/compositor-fbdev.c | 2 +- > src/compositor-headless.c| 2 +- > src/compositor-rpi.c | 6 +- > src/compositor-wayland.c | 2 +- > src/compositor-x11.c | 2 +- > src/compositor.c | 29 +++-- > tests/presentation-test.c| 34 ++--- > 12 files changed, 101 insertions(+), 369 deletions(-) > delete mode 100644 protocol/presentation_timing.xml > As stated on IRC, in fact no changes are needed for the RDP compositor. Sorry for the noise. -- David FORT website: http://www.hardening-consulting.com/ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols
Le 04/11/2015 09:49, Jonas Ådahl a écrit : > Signed-off-by: Jonas Ådahl > --- > Makefile.am | 21 ++- > clients/presentation-shm.c | 65 +- > clients/weston-info.c| 19 +-- > protocol/presentation_timing.xml | 274 > --- > src/compositor-drm.c | 14 +- > src/compositor-fbdev.c | 2 +- > src/compositor-headless.c| 2 +- > src/compositor-rpi.c | 6 +- > src/compositor-wayland.c | 2 +- > src/compositor-x11.c | 2 +- > src/compositor.c | 29 +++-- > tests/presentation-test.c| 34 ++--- > 12 files changed, 101 insertions(+), 369 deletions(-) > delete mode 100644 protocol/presentation_timing.xml > The RDP compositor is not treated by this patch. -- David FORT website: http://www.hardening-consulting.com/ ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols
On Thu, Nov 05, 2015 at 01:57:45PM +0200, Pekka Paalanen wrote:
> On Wed, 4 Nov 2015 16:49:52 +0800
> Jonas Ådahl wrote:
>
> > Signed-off-by: Jonas Ådahl
> > ---
> > Makefile.am | 21 ++-
> > clients/presentation-shm.c | 65 +-
> > clients/weston-info.c| 19 +--
> > protocol/presentation_timing.xml | 274
> > ---
> > src/compositor-drm.c | 14 +-
> > src/compositor-fbdev.c | 2 +-
> > src/compositor-headless.c| 2 +-
> > src/compositor-rpi.c | 6 +-
> > src/compositor-wayland.c | 2 +-
> > src/compositor-x11.c | 2 +-
> > src/compositor.c | 29 +++--
> > tests/presentation-test.c| 34 ++---
> > 12 files changed, 101 insertions(+), 369 deletions(-)
> > delete mode 100644 protocol/presentation_timing.xml
>
> > diff --git a/clients/presentation-shm.c b/clients/presentation-shm.c
> > index 120c40c..9083d8e 100644
> > --- a/clients/presentation-shm.c
> > +++ b/clients/presentation-shm.c
> > @@ -38,7 +38,7 @@
> > #include
> > #include "shared/helpers.h"
> > #include "shared/os-compatibility.h"
> > -#include "presentation_timing-client-protocol.h"
> > +#include "presentation-timing-unstable-v1-client-protocol.h"
> >
> > enum run_mode {
> > RUN_MODE_FEEDBACK,
> > @@ -67,7 +67,7 @@ struct display {
> > struct wl_shm *shm;
> > uint32_t formats;
> >
> > - struct presentation *presentation;
> > + struct zwl_presentation1 *presentation;
>
> Hi Jonas,
>
> I see you added the prefix wl_ here. I think this is good, it is aiming
> to be a standard, generic extension usable everywhere where Wayland is.
>
> What I am not so sure about is whether keeping it unstable is still necessary.
> https://phabricator.freedesktop.org/T43
>
> Maybe we should just promote it stable while we are moving it, and
> avoid one round of renames. I don't know of anything that would need
> fixing or reconsidering in it, apart maybe from names (presentation?).
>
> Hmm, maybe if someone makes the case that one really *really* does
> not need 64 bits for seconds value, it could use a break. However,
> 64-bit nanoseconds value does not necessarily fit in a 32-bit seconds +
> 32-bit nsecs value when nsec is limited to [0, 9], so I think
> it's good as is. (And the code is already written and been out there
> for a long time.)
>
> What if we skipped this one with the unstable move?
If that what you think makes sense, and noone objects to it, I see no
reason not to. I haven't followed the details regarding the protocol
itself, so I have no opinion whether it is suitable or not.
Jonas
>
>
> Thanks,
> pq
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
Re: [PATCH weston 03/10] Use presentation timing protocol from wayland-protocols
On Wed, 4 Nov 2015 16:49:52 +0800
Jonas Ådahl wrote:
> Signed-off-by: Jonas Ådahl
> ---
> Makefile.am | 21 ++-
> clients/presentation-shm.c | 65 +-
> clients/weston-info.c| 19 +--
> protocol/presentation_timing.xml | 274
> ---
> src/compositor-drm.c | 14 +-
> src/compositor-fbdev.c | 2 +-
> src/compositor-headless.c| 2 +-
> src/compositor-rpi.c | 6 +-
> src/compositor-wayland.c | 2 +-
> src/compositor-x11.c | 2 +-
> src/compositor.c | 29 +++--
> tests/presentation-test.c| 34 ++---
> 12 files changed, 101 insertions(+), 369 deletions(-)
> delete mode 100644 protocol/presentation_timing.xml
> diff --git a/clients/presentation-shm.c b/clients/presentation-shm.c
> index 120c40c..9083d8e 100644
> --- a/clients/presentation-shm.c
> +++ b/clients/presentation-shm.c
> @@ -38,7 +38,7 @@
> #include
> #include "shared/helpers.h"
> #include "shared/os-compatibility.h"
> -#include "presentation_timing-client-protocol.h"
> +#include "presentation-timing-unstable-v1-client-protocol.h"
>
> enum run_mode {
> RUN_MODE_FEEDBACK,
> @@ -67,7 +67,7 @@ struct display {
> struct wl_shm *shm;
> uint32_t formats;
>
> - struct presentation *presentation;
> + struct zwl_presentation1 *presentation;
Hi Jonas,
I see you added the prefix wl_ here. I think this is good, it is aiming
to be a standard, generic extension usable everywhere where Wayland is.
What I am not so sure about is whether keeping it unstable is still necessary.
https://phabricator.freedesktop.org/T43
Maybe we should just promote it stable while we are moving it, and
avoid one round of renames. I don't know of anything that would need
fixing or reconsidering in it, apart maybe from names (presentation?).
Hmm, maybe if someone makes the case that one really *really* does
not need 64 bits for seconds value, it could use a break. However,
64-bit nanoseconds value does not necessarily fit in a 32-bit seconds +
32-bit nsecs value when nsec is limited to [0, 9], so I think
it's good as is. (And the code is already written and been out there
for a long time.)
What if we skipped this one with the unstable move?
Thanks,
pq
pgpoFp9IkauYn.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
[PATCH weston 03/10] Use presentation timing protocol from wayland-protocols
Signed-off-by: Jonas Ådahl
---
Makefile.am | 21 ++-
clients/presentation-shm.c | 65 +-
clients/weston-info.c| 19 +--
protocol/presentation_timing.xml | 274 ---
src/compositor-drm.c | 14 +-
src/compositor-fbdev.c | 2 +-
src/compositor-headless.c| 2 +-
src/compositor-rpi.c | 6 +-
src/compositor-wayland.c | 2 +-
src/compositor-x11.c | 2 +-
src/compositor.c | 29 +++--
tests/presentation-test.c| 34 ++---
12 files changed, 101 insertions(+), 369 deletions(-)
delete mode 100644 protocol/presentation_timing.xml
diff --git a/Makefile.am b/Makefile.am
index 9f7cc9d..175e924 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -123,8 +123,8 @@ nodist_weston_SOURCES =
\
protocol/input-method-server-protocol.h \
protocol/workspaces-protocol.c \
protocol/workspaces-server-protocol.h \
- protocol/presentation_timing-protocol.c \
- protocol/presentation_timing-server-protocol.h \
+ protocol/presentation-timing-unstable-v1-protocol.c \
+ protocol/presentation-timing-unstable-v1-server-protocol.h \
protocol/scaler-protocol.c \
protocol/scaler-server-protocol.h \
protocol/linux-dmabuf-unstable-v1-protocol.c\
@@ -503,8 +503,8 @@ weston_presentation_shm_SOURCES = \
clients/presentation-shm.c \
shared/helpers.h
nodist_weston_presentation_shm_SOURCES = \
- protocol/presentation_timing-protocol.c \
- protocol/presentation_timing-client-protocol.h
+ protocol/presentation-timing-unstable-v1-protocol.c \
+ protocol/presentation-timing-unstable-v1-client-protocol.h
weston_presentation_shm_CFLAGS = $(AM_CFLAGS) $(SIMPLE_CLIENT_CFLAGS)
weston_presentation_shm_LDADD = $(SIMPLE_CLIENT_LIBS) libshared.la -lm -lrt
@@ -554,8 +554,8 @@ nodist_libtoytoolkit_la_SOURCES = \
protocol/scaler-client-protocol.h \
protocol/workspaces-protocol.c \
protocol/workspaces-client-protocol.h \
- protocol/presentation_timing-protocol.c \
- protocol/presentation_timing-client-protocol.h \
+ protocol/presentation-timing-unstable-v1-protocol.c \
+ protocol/presentation-timing-unstable-v1-client-protocol.h \
protocol/xdg-shell-protocol.c \
protocol/xdg-shell-client-protocol.h\
protocol/ivi-application-protocol.c \
@@ -712,8 +712,8 @@ weston_info_SOURCES =
\
clients/weston-info.c \
shared/helpers.h
nodist_weston_info_SOURCES = \
- protocol/presentation_timing-protocol.c \
- protocol/presentation_timing-client-protocol.h
+ protocol/presentation-timing-unstable-v1-protocol.c \
+ protocol/presentation-timing-unstable-v1-client-protocol.h
weston_info_LDADD = $(WESTON_INFO_LIBS) libshared.la
weston_info_CFLAGS = $(AM_CFLAGS) $(CLIENT_CFLAGS)
@@ -1225,8 +1225,8 @@ presentation_weston_SOURCES = \
tests/presentation-test.c \
shared/helpers.h
nodist_presentation_weston_SOURCES = \
- protocol/presentation_timing-protocol.c \
- protocol/presentation_timing-client-protocol.h
+ protocol/presentation-timing-unstable-v1-protocol.c \
+ protocol/presentation-timing-unstable-v1-client-protocol.h
presentation_weston_CFLAGS = $(AM_CFLAGS) $(TEST_CLIENT_CFLAGS)
presentation_weston_LDADD = libtest-client.la
@@ -1348,7 +1348,6 @@ EXTRA_DIST += \
protocol/text-cursor-position.xml \
protocol/weston-test.xml\
protocol/xdg-shell.xml \
- protocol/presentation_timing.xml\
protocol/scaler.xml \
protocol/ivi-application.xml\
protocol/ivi-hmi-controller.xml
diff --git a/clients/presentation-shm.c b/clients/presentation-shm.c
index 120c40c..9083d8e 100644
--- a/clients/presentation-shm.c
+++ b/clients/presentation-shm.c
@@ -38,7 +38,7 @@
#include
#include "shared/helpers.h"
#include "shared/os-compatibility.h"
-#include "presentation_timing-client-protocol.h"
+#include "presentation-timing-unstable-v1-client-protocol.h"
enum run_mode {
RUN_MODE_FEEDBACK,
@@ -67,7 +67,7 @@ struct display {
struct wl_shm *shm;
uint32_t formats;
- struct presentation *presentation;
+ struct zwl_presentation1 *presentation;
clockid_t clk_id;
