Re: [PATCH weston 03/68] compositor-drm: Comment struct members

[Armin Krezović]

On 09.12.2016 20:57, Daniel Stone wrote:
> Clarify the difference between crtc_id (DRM object) and pipe (index into
> drmModeRes->crtcs array, possible_crtcs bitmask).
> 
> Signed-off-by: Daniel Stone 
> Reviewed-by: Quentin Glidic 
> Differential Revision: https://phabricator.freedesktop.org/D1405

Documenting structure members is always welcome.

Reviewed-by: Armin Krezović 

(this time it's me!)

> ---
>  libweston/compositor-drm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
> index a899213..268117d 100644
> --- a/libweston/compositor-drm.c
> +++ b/libweston/compositor-drm.c
> @@ -155,8 +155,8 @@ struct drm_output {
>   struct weston_output base;
>   drmModeConnector *connector;
>  
> - uint32_t crtc_id;
> - int pipe;
> + uint32_t crtc_id; /* object ID to pass to DRM functions */
> + int pipe; /* index of CRTC in resource array / bitmasks */
>   uint32_t connector_id;
>   drmModeCrtcPtr original_crtc;
>   struct drm_edid edid;
> 




signature.asc
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston 03/68] compositor-drm: Comment struct members

[Daniel Stone]

Clarify the difference between crtc_id (DRM object) and pipe (index into
drmModeRes->crtcs array, possible_crtcs bitmask).

Signed-off-by: Daniel Stone 
Reviewed-by: Quentin Glidic 
Differential Revision: https://phabricator.freedesktop.org/D1405
---
 libweston/compositor-drm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index a899213..268117d 100644
--- a/libweston/compositor-drm.c
+++ b/libweston/compositor-drm.c
@@ -155,8 +155,8 @@ struct drm_output {
struct weston_output base;
drmModeConnector *connector;
 
-   uint32_t crtc_id;
-   int pipe;
+   uint32_t crtc_id; /* object ID to pass to DRM functions */
+   int pipe; /* index of CRTC in resource array / bitmasks */
uint32_t connector_id;
drmModeCrtcPtr original_crtc;
struct drm_edid edid;
-- 
2.9.3

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel