Re: [wayland-protocols v2] linux-dmabuf: advertise format modifiers with modifier event

2016-11-19 Thread Yong Bakos
Hi Varad,

> On Nov 17, 2016, at 11:28 PM, Varad Gautam  wrote:
> 
> From: Varad Gautam 
> 
> advertise the supported fourcc format modifiers along with supported
> formats to the client.
> 
> bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
> versions to 3.
> 
> v2: specify request name in event description for clarity (Yong Bakos)
> 
> Signed-off-by: Varad Gautam 

One minor nit below but this is:

Reviewed-by: Yong Bakos 


> ---
> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 25 +++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
> 
> diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml 
> b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> index a0aa42e..3b008ee 100644
> --- a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> +++ b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
> @@ -26,7 +26,7 @@
> THIS SOFTWARE.
>   
> 
> -  
> +  
> 
>   Following the interfaces from:
>   
> https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt
> @@ -34,7 +34,8 @@
> 
>   This interface offers ways to create generic dmabuf-based
>   wl_buffers. Immediately after a client binds to this interface,
> -  the set of supported formats is sent with 'format' events.
> +  the set of supported formats and format modifiers is sent with
> +  'format' and 'modifier' events.
> 
>   The following are required from clients:
> 
> @@ -110,9 +111,27 @@
>   
>   
> 
> +
> +
> +  
> +This event advertises the formats that the server supports, along 
> with
> +the modifiers supported for each format. All the supported modifiers 
> for
> +all the supported formats are advertised once when the client binds 
> to
> +this interface. A roundtrip after binding guarantees that the client
> +has received all supported format-modifier pairs.
> +
> +For the definition of the format and modifier codes, see
> +zwp_linux_buffer_params_v1::create request.

For the definition of the format and modifier codes, see the 
zwp_linux_buffer_params_v1::create request.

(note the 'the').

yong



> +  
> +  
> +   +   summary="high 32 bits of layout modifier"/>
> +   +   summary="low 32 bits of layout modifier"/>
> +
>   
> 
> -  
> +  
> 
>   This temporary object is a collection of dmabufs and other
>   parameters that together form a single logical buffer. The temporary
> -- 
> 2.6.2
> 
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel


[wayland-protocols v2] linux-dmabuf: advertise format modifiers with modifier event

2016-11-17 Thread Varad Gautam
From: Varad Gautam 

advertise the supported fourcc format modifiers along with supported
formats to the client.

bump zwp_linux_dmabuf_v1, zwp_linux_buffer_params_v1 interface
versions to 3.

v2: specify request name in event description for clarity (Yong Bakos)

Signed-off-by: Varad Gautam 
---
 unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 25 +++---
 1 file changed, 22 insertions(+), 3 deletions(-)

diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml 
b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
index a0aa42e..3b008ee 100644
--- a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
+++ b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml
@@ -26,7 +26,7 @@
 THIS SOFTWARE.
   
 
-  
+  
 
   Following the interfaces from:
   
https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_image_dma_buf_import.txt
@@ -34,7 +34,8 @@
 
   This interface offers ways to create generic dmabuf-based
   wl_buffers. Immediately after a client binds to this interface,
-  the set of supported formats is sent with 'format' events.
+  the set of supported formats and format modifiers is sent with
+  'format' and 'modifier' events.
 
   The following are required from clients:
 
@@ -110,9 +111,27 @@
   
   
 
+
+
+  
+This event advertises the formats that the server supports, along with
+the modifiers supported for each format. All the supported modifiers 
for
+all the supported formats are advertised once when the client binds to
+this interface. A roundtrip after binding guarantees that the client
+has received all supported format-modifier pairs.
+
+For the definition of the format and modifier codes, see
+zwp_linux_buffer_params_v1::create request.
+  
+  
+  
+  
+
   
 
-  
+  
 
   This temporary object is a collection of dmabufs and other
   parameters that together form a single logical buffer. The temporary
-- 
2.6.2

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel