Re: [PATCH v2] shell: Add missing break to a case statement inside set_surface_type.
On Wed, Dec 04, 2013 at 06:37:16PM -0200, Rafael Antognolli wrote: This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. Thanks, committed. This https://bugs.freedesktop.org/show_bug.cgi?id=72321 so I appended that to the commit message. Kristian --- desktop-shell/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..1b63430 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -2399,6 +2399,7 @@ set_surface_type(struct shell_surface *shsurf) pev-geometry.x + shsurf-transient.x, pev-geometry.y + shsurf-transient.y); } + break; case SHELL_SURFACE_XWAYLAND: weston_view_set_position(shsurf-view, shsurf-transient.x, -- 1.8.3.1 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
RE: [PATCH v2] shell: Add missing break to a case statement inside set_surface_type.
Tested and works for me :). Thanks! This fixes https://bugs.freedesktop.org/show_bug.cgi?id=72321 U. Artie Eoff -Original Message- From: wayland-devel-boun...@lists.freedesktop.org [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Rafael Antognolli Sent: Wednesday, December 04, 2013 12:37 PM To: wayland-devel@lists.freedesktop.org Cc: Antognolli, Rafael Subject: [PATCH v2] shell: Add missing break to a case statement inside set_surface_type. This should fix the surface not going back to its original position after unsetting fullscreen or maximized states. --- desktop-shell/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index de54e37..1b63430 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell/shell.c @@ -2399,6 +2399,7 @@ set_surface_type(struct shell_surface *shsurf) pev-geometry.x + shsurf-transient.x, pev-geometry.y + shsurf-transient.y); } + break; case SHELL_SURFACE_XWAYLAND: weston_view_set_position(shsurf-view, shsurf-transient.x, -- 1.8.3.1 ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
