Re: [PATCH v3] protocol: warn clients about some wl_output properties

2019-02-18 Thread Jonas Ådahl
On Mon, Feb 18, 2019 at 04:28:18PM +, Daniel Stone wrote:
> Hi Simon,
> 
> On Mon, 18 Feb 2019 at 16:22, Simon Ser  wrote:
> > On Friday, October 26, 2018 11:13 AM, Simon Ser  wrote:
> > > Compositors also expose output refresh rate, which shouldn't be used
> > > for synchronization purposes.
> >
> > I'd like to bump this patch, because people apparently do use wl_output's
> > refresh rate for synchronization purposes in Firefox [1]. I think it
> > would be a good thing to make sure people are aware they should be using
> > frame callbacks instead.
> 
> Thanks a lot for bumping this. Patch is:
> Reviewed-by: Daniel Stone 

This is

Reviewed-by: Jonas Ådahl 

too.


Jonas

> 
> Cheers,
> Daniel
> ___
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH v3] protocol: warn clients about some wl_output properties

2019-02-18 Thread Daniel Stone
Hi Simon,

On Mon, 18 Feb 2019 at 16:22, Simon Ser  wrote:
> On Friday, October 26, 2018 11:13 AM, Simon Ser  wrote:
> > Compositors also expose output refresh rate, which shouldn't be used
> > for synchronization purposes.
>
> I'd like to bump this patch, because people apparently do use wl_output's
> refresh rate for synchronization purposes in Firefox [1]. I think it
> would be a good thing to make sure people are aware they should be using
> frame callbacks instead.

Thanks a lot for bumping this. Patch is:
Reviewed-by: Daniel Stone 

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH v3] protocol: warn clients about some wl_output properties

2019-02-18 Thread Simon Ser
On Friday, October 26, 2018 11:13 AM, Simon Ser  wrote:
> Compositors also expose output refresh rate, which shouldn't be used
> for synchronization purposes.

I'd like to bump this patch, because people apparently do use wl_output's
refresh rate for synchronization purposes in Firefox [1]. I think it
would be a good thing to make sure people are aware they should be using
frame callbacks instead.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1515448#c13

___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel