Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

[Quentin Glidic]

On 17/01/2017 12:54, Daniel Stone wrote:

Hi,

On 21 November 2016 at 11:07, Jan Engelhardt  wrote:

On Monday 2016-11-21 12:00, Daniel Stone wrote:

COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my
knowledge, these belong in LDADD


Negative. _LDADD is ignored for library type outputs, and _LIBADD
is ignored for program type outputs.

Everything is correct here..


I only said this on IRC rather than the list, but Jan is completely
right. Merge at leisure.



Added Daniel’s R-b, and pushed:
2d66a7d8..b2f32ab4  master -> master

Thanks,

--

Quentin “Sardem FF7” Glidic
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

[Daniel Stone]

Hi,

On 21 November 2016 at 11:07, Jan Engelhardt  wrote:
> On Monday 2016-11-21 12:00, Daniel Stone wrote:
>>COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my
>>knowledge, these belong in LDADD
>
> Negative. _LDADD is ignored for library type outputs, and _LIBADD
> is ignored for program type outputs.
>
> Everything is correct here..

I only said this on IRC rather than the list, but Jan is completely
right. Merge at leisure.

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

[Jan Engelhardt]

On Monday 2016-11-21 12:00, Daniel Stone wrote:
>On 18 August 2016 at 10:15, Quentin Glidic
> wrote:
>> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES = 
>>\
>>  lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la
>>  libweston_desktop_@LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON
>>  libweston_desktop_@LIBWESTON_MAJOR@_la_CFLAGS = $(AM_CFLAGS) 
>> $(COMPOSITOR_CFLAGS)
>> -libweston_desktop_@LIBWESTON_MAJOR@_la_LIBADD = 
>> libweston-@LIBWESTON_MAJOR@.la $(COMPOSITOR_LIBS)
>> +libweston_desktop_@LIBWESTON_MAJOR@_la_LIBADD =\
>> +   libweston-@LIBWESTON_MAJOR@.la  \
>> +   $(COMPOSITOR_LIBS)
>>  libweston_desktop_@LIBWESTON_MAJOR@_la_LDFLAGS = -version-info 
>> $(LT_VERSION_INFO)
>
>COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my
>knowledge, these belong in LDADD

Negative. _LDADD is ignored for library type outputs, and _LIBADD
is ignored for program type outputs.

Everything is correct here..
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

[Daniel Stone]

Hi Quentin,

On 18 August 2016 at 10:15, Quentin Glidic
 wrote:
> @@ -116,7 +116,9 @@ libweston_@LIBWESTON_MAJOR@_la_SOURCES =  
>   \
>  lib_LTLIBRARIES += libweston-desktop-@LIBWESTON_MAJOR@.la
>  libweston_desktop_@LIBWESTON_MAJOR@_la_CPPFLAGS = $(AM_CPPFLAGS) -DIN_WESTON
>  libweston_desktop_@LIBWESTON_MAJOR@_la_CFLAGS = $(AM_CFLAGS) 
> $(COMPOSITOR_CFLAGS)
> -libweston_desktop_@LIBWESTON_MAJOR@_la_LIBADD = 
> libweston-@LIBWESTON_MAJOR@.la $(COMPOSITOR_LIBS)
> +libweston_desktop_@LIBWESTON_MAJOR@_la_LIBADD =\
> +   libweston-@LIBWESTON_MAJOR@.la  \
> +   $(COMPOSITOR_LIBS)
>  libweston_desktop_@LIBWESTON_MAJOR@_la_LDFLAGS = -version-info 
> $(LT_VERSION_INFO)

COMPOSITOR_LIBS is full of -Lfoo -lsyslib. To the best of my
knowledge, these belong in LDADD, which is things to throw in the ld
command line; LIBADD is local libraries to add, which will be
dependency-tracked and also thrown through the libtool mangling
machinery.

Could you please test with a split that has $(COMPOSITOR_LIBS) et al
being set as LDADD, and only the local paths for LIBADD? Such a patch
would have my R-b, as the rest looks sound enough.

Cheers,
Daniel
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 2/2] Makefile.am: Link modules to libweston.la

[Pekka Paalanen]

On Thu, 18 Aug 2016 11:15:45 +0200
Quentin Glidic  wrote:

> From: Quentin Glidic 
> 
> Modules are using libweston symbols (at least weston_log) and should
> explicitly link to it.
> 
> This patch also reorders some flags.
> 
> Signed-off-by: Quentin Glidic 
> ---
> 
> It doesn’t allow to build with --no-undefined, but it gets closer to that.
> 
>  Makefile.am | 105 
> ++--
>  1 file changed, 73 insertions(+), 32 deletions(-)
> 

Hi,

both patches
Acked-by: Pekka Paalanen 
for landing before beta.

(Ack does not count as R-b.)


Thanks,
pq


pgpSys03QpTRf.pgp
Description: OpenPGP digital signature
___
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel