[webkit-changes] [87301] trunk/Source/WebCore
Title: [87301] trunk/Source/WebCore Revision 87301 Author commit-qu...@webkit.org Date 2011-05-25 09:50:53 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r87229. http://trac.webkit.org/changeset/87229 https://bugs.webkit.org/show_bug.cgi?id=61445 Lots of tests crashing in CFNetwork!URLResponse::createFilenameFromResponseHeaders on Windows XP (Requested by aroben on #webkit). * platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::wasCached): (WebCore::ResourceResponseBase::connectionReused): (WebCore::ResourceResponseBase::setConnectionReused): (WebCore::ResourceResponseBase::connectionID): (WebCore::ResourceResponseBase::setConnectionID): (WebCore::ResourceResponseBase::resourceLoadTiming): (WebCore::ResourceResponseBase::setResourceLoadTiming): (WebCore::ResourceResponseBase::resourceLoadInfo): (WebCore::ResourceResponseBase::setResourceLoadInfo): * platform/network/ResourceResponseBase.h: * platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit): * platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp trunk/Source/WebCore/platform/network/ResourceResponseBase.h trunk/Source/WebCore/platform/network/cf/ResourceResponse.h trunk/Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp trunk/Source/WebCore/platform/network/mac/ResourceResponseMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (87300 => 87301) --- trunk/Source/WebCore/ChangeLog 2011-05-25 16:48:03 UTC (rev 87300) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 16:50:53 UTC (rev 87301) @@ -1,3 +1,42 @@ +2011-05-25 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r87229. +http://trac.webkit.org/changeset/87229 +https://bugs.webkit.org/show_bug.cgi?id=61445 + +Lots of tests crashing in +CFNetwork!URLResponse::createFilenameFromResponseHeaders on +Windows XP (Requested by aroben on #webkit). + +* platform/network/ResourceResponseBase.cpp: +(WebCore::ResourceResponseBase::adopt): +(WebCore::ResourceResponseBase::suggestedFilename): +(WebCore::ResourceResponseBase::setSuggestedFilename): +(WebCore::ResourceResponseBase::httpStatusText): +(WebCore::ResourceResponseBase::setHTTPStatusText): +(WebCore::ResourceResponseBase::httpHeaderField): +(WebCore::ResourceResponseBase::setHTTPHeaderField): +(WebCore::ResourceResponseBase::httpHeaderFields): +(WebCore::ResourceResponseBase::isAttachment): +(WebCore::ResourceResponseBase::setLastModifiedDate): +(WebCore::ResourceResponseBase::lastModifiedDate): +(WebCore::ResourceResponseBase::wasCached): +(WebCore::ResourceResponseBase::connectionReused): +(WebCore::ResourceResponseBase::setConnectionReused): +(WebCore::ResourceResponseBase::connectionID): +(WebCore::ResourceResponseBase::setConnectionID): +(WebCore::ResourceResponseBase::resourceLoadTiming): +(WebCore::ResourceResponseBase::setResourceLoadTiming): +(WebCore::ResourceResponseBase::resourceLoadInfo): +(WebCore::ResourceResponseBase::setResourceLoadInfo): +* platform/network/ResourceResponseBase.h: +* platform/network/cf/ResourceResponse.h: +(WebCore::ResourceResponse::ResourceResponse): +* platform/network/cf/ResourceResponseCFNet.cpp: +(WebCore::ResourceResponse::platformLazyInit): +* platform/network/mac/ResourceResponseMac.mm: +(WebCore::ResourceResponse::platformLazyInit): + 2011-05-25 Igor Oliveira igor.olive...@openbossa.org Reviewed by Antonio Gomes. Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp (87300 => 87301) --- trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp 2011-05-25 16:48:03 UTC (rev 87300) +++
[webkit-changes] [87302] trunk/Source/WebCore
Title: [87302] trunk/Source/WebCore Revision 87302 Author le...@chromium.org Date 2011-05-25 10:04:47 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Levi Weintraub le...@chromium.org Reviewed by Eric Seidel. Switch addFocusRingRects to use IntPoint https://bugs.webkit.org/show_bug.cgi?id=60783 Switching addFocusRingRects to use an IntPoint representing the offset being applied instead of a pair of ints. No new tests as this is only refactoring. * platform/graphics/FloatSize.h: (WebCore::flooredIntPoint): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::addFocusRingRects): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::addFocusRingRects): * rendering/RenderBox.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::addFocusRingRects): * rendering/RenderInline.h: * rendering/RenderListBox.cpp: (WebCore::RenderListBox::addFocusRingRects): * rendering/RenderListBox.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::absoluteFocusRingQuads): * rendering/RenderObject.h: (WebCore::RenderObject::addFocusRingRects): * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::addFocusRingRects): * rendering/RenderTextControl.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::addFocusRingRects): * rendering/RenderTextControlSingleLine.h: * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addFocusRingRects): * rendering/svg/RenderSVGContainer.h: * rendering/svg/RenderSVGImage.cpp: (WebCore::RenderSVGImage::addFocusRingRects): * rendering/svg/RenderSVGImage.h: * rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::addFocusRingRects): * rendering/svg/RenderSVGPath.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/FloatSize.h trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderListBox.cpp trunk/Source/WebCore/rendering/RenderListBox.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderTextControl.cpp trunk/Source/WebCore/rendering/RenderTextControl.h trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp trunk/Source/WebCore/rendering/svg/RenderSVGImage.h trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp trunk/Source/WebCore/rendering/svg/RenderSVGPath.h Diff Modified: trunk/Source/WebCore/ChangeLog (87301 => 87302) --- trunk/Source/WebCore/ChangeLog 2011-05-25 16:50:53 UTC (rev 87301) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 17:04:47 UTC (rev 87302) @@ -1,3 +1,50 @@ +2011-05-25 Levi Weintraub le...@chromium.org + +Reviewed by Eric Seidel. + +Switch addFocusRingRects to use IntPoint +https://bugs.webkit.org/show_bug.cgi?id=60783 + +Switching addFocusRingRects to use an IntPoint representing the offset being +applied instead of a pair of ints. + +No new tests as this is only refactoring. + +* platform/graphics/FloatSize.h: +(WebCore::flooredIntPoint): +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::addFocusRingRects): +* rendering/RenderBlock.h: +* rendering/RenderBox.cpp: +(WebCore::RenderBox::addFocusRingRects): +* rendering/RenderBox.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::addFocusRingRects): +* rendering/RenderInline.h: +* rendering/RenderListBox.cpp: +(WebCore::RenderListBox::addFocusRingRects): +* rendering/RenderListBox.h: +* rendering/RenderObject.cpp: +(WebCore::RenderObject::paintFocusRing): +(WebCore::RenderObject::absoluteFocusRingQuads): +* rendering/RenderObject.h: +(WebCore::RenderObject::addFocusRingRects): +* rendering/RenderTextControl.cpp: +(WebCore::RenderTextControl::addFocusRingRects): +* rendering/RenderTextControl.h: +* rendering/RenderTextControlSingleLine.cpp: +(WebCore::RenderTextControlSingleLine::addFocusRingRects): +* rendering/RenderTextControlSingleLine.h: +* rendering/svg/RenderSVGContainer.cpp: +
[webkit-changes] [87309] trunk
Title: [87309] trunk Revision 87309 Author jap...@chromium.org Date 2011-05-25 11:51:27 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Nate Chapin jap...@chromium.org Reviewed by Adam Barth. Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled. https://bugs.webkit.org/show_bug.cgi?id=59113 * bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchUARules): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source. * dom/Document.h: (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles(). * html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): * xml/XMLTreeViewer.cpp: (WebCore::XMLTreeViewer::transformDocumentToTreeView): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/ScriptControllerBase.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/html/HTMLViewSourceDocument.cpp trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/xml/XMLTreeViewer.cpp Diff Modified: trunk/LayoutTests/ChangeLog (87308 => 87309) --- trunk/LayoutTests/ChangeLog 2011-05-25 18:48:25 UTC (rev 87308) +++ trunk/LayoutTests/ChangeLog 2011-05-25 18:51:27 UTC (rev 87309) @@ -1,3 +1,11 @@ +2011-05-25 Nate Chapin jap...@chromium.org + +Reviewed by Adam Barth. + +Add new console output for https://bugs.webkit.org/show_bug.cgi?id=59113. + +* http/tests/security/view-source-no-_javascript_-url-expected.txt: + 2011-05-25 Julien Chaffraix jchaffr...@codeaurora.org Reviewed by James Robinson. Modified: trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt (87308 => 87309) --- trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt 2011-05-25 18:48:25 UTC (rev 87308) +++ trunk/LayoutTests/http/tests/security/view-source-no-_javascript_-url-expected.txt 2011-05-25 18:51:27 UTC (rev 87309) @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://127.0.0.1:8000/security/resources/innocent-victim.html from frame with URL http://127.0.0.1:8000/security/view-source-no-_javascript_-url.html. Domains, protocols and ports must match. + This test passes if it does not alert FAIL. Modified: trunk/Source/WebCore/ChangeLog (87308 => 87309) --- trunk/Source/WebCore/ChangeLog 2011-05-25 18:48:25 UTC (rev 87308) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 18:51:27 UTC (rev 87309) @@ -1,3 +1,27 @@ +2011-05-25 Nate Chapin jap...@chromium.org + +Reviewed by Adam Barth. + +Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like +XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled. +https://bugs.webkit.org/show_bug.cgi?id=59113 + +* bindings/ScriptControllerBase.cpp: +(WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case. +* css/CSSStyleSelector.cpp: +(WebCore::CSSStyleSelector::matchUARules): +* dom/Document.cpp: +(WebCore::Document::Document): +(WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source. +* dom/Document.h: +(WebCore::Document::isViewSource): Renamed from usesViewSourceStyles(). +* html/HTMLViewSourceDocument.cpp: +(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): +* loader/FrameLoader.cpp: +(WebCore::FrameLoader::receivedFirstData): +* xml/XMLTreeViewer.cpp: +(WebCore::XMLTreeViewer::transformDocumentToTreeView): + 2011-05-25 Julien Chaffraix jchaffr...@codeaurora.org Reviewed by James Robinson. Modified: trunk/Source/WebCore/bindings/ScriptControllerBase.cpp (87308 => 87309) --- trunk/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-05-25 18:48:25 UTC (rev 87308) +++ trunk/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-05-25 18:51:27 UTC (rev 87309) @@ -29,6
[webkit-changes] [87310] trunk
Title: [87310] trunk
Revision 87310
Author rwlb...@webkit.org
Date 2011-05-25 12:01:46 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Rob Buis rb...@rim.com
Reviewed by Eric Seidel.
WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569
Updated improved pixel test result and add new SVG1.1 SE test and results.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
* svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
2011-05-25 Rob Buis rb...@rim.com
Reviewed by Eric Seidel.
New test rubber-stamped by Dirk Schulze.
WebKit does not handle missing filter elements correctly
https://bugs.webkit.org/show_bug.cgi?id=12569
Do not render elements that reference non-existant filters.
Test: svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::prepareToRenderSVGContent):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp
Added Paths
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (87309 => 87310)
--- trunk/LayoutTests/ChangeLog 2011-05-25 18:51:27 UTC (rev 87309)
+++ trunk/LayoutTests/ChangeLog 2011-05-25 19:01:46 UTC (rev 87310)
@@ -1,3 +1,17 @@
+2011-05-25 Rob Buis rb...@rim.com
+
+Reviewed by Eric Seidel.
+
+WebKit does not handle missing filter elements correctly
+https://bugs.webkit.org/show_bug.cgi?id=12569
+
+Updated improved pixel test result and add new SVG1.1 SE test and results.
+
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+* svg/W3C-SVG-1.1-SE/filters-felem-01-b.svg: Added.
+
2011-05-25 Nate Chapin jap...@chromium.org
Reviewed by Adam Barth.
Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
(Binary files differ)
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (0 => 87310)
--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt 2011-05-25 19:01:46 UTC (rev 87310)
@@ -0,0 +1,40 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (82,20) size 364x265
+ RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id=null] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+RenderSVGResourceFilter {filter} [id=nullreg] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ RenderSVGContainer {g} at (90,20) size 80x115
+RenderSVGPath {circle} at (100,30) size 60x60 [fill={[type=SOLID] [color=#FF]}] [cx=130.00] [cy=60.00] [r=30.00]
+RenderSVGPath {circle} at (90,20) size 80x80 [fill={[type=SOLID] [color=#00FF00]}] [cx=130.00] [cy=60.00] [r=40.00]
+RenderSVGText {text} at (95,111) size 70x24 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 70x24
+chunk 1 (middle anchor) text run 1 at (95.50,130.00) startOffset 0 endOffset 9 width 69.00: No filter
+ RenderSVGContainer {g} at (82,162) size 96x123
+RenderSVGPath {circle} at (100,180) size 60x60 [fill={[type=SOLID] [color=#00FF00]}] [cx=130.00] [cy=210.00] [r=30.00]
+RenderSVGPath {circle} at (82,162) size 96x96 [fill={[type=SOLID] [color=#FF]}] [cx=130.00] [cy=210.00] [r=40.00]
+ [filter=null] RenderSVGResourceFilter {filter} at (82,162) size 96x96
+RenderSVGText {text} at (91,261) size 78x24 contains 1 chunk(s)
+ RenderSVGInlineText {#text} at (0,0) size 78x24
+chunk 1 (middle anchor) text run 1 at (91.50,280.00) startOffset 0
[webkit-changes] [87313] trunk
Title: [87313] trunk
Revision 87313
Author commit-qu...@webkit.org
Date 2011-05-25 12:23:39 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
* storage/indexeddb/migrate-basics-expected.txt: Removed.
* storage/indexeddb/migrate-basics.html: Removed.
2011-05-25 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
* storage/IDBBackingStore.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
(WebCore::IDBFactoryBackendImpl::open):
* storage/IDBFactoryBackendImpl.h:
* storage/IDBFactoryBackendInterface.h:
* storage/IDBLevelDBBackingStore.cpp:
* storage/IDBLevelDBBackingStore.h:
* storage/IDBSQLiteBackingStore.cpp:
* storage/IDBSQLiteBackingStore.h:
2011-05-25 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
* public/WebIDBFactory.h:
* src/AssertMatchingEnums.cpp:
* src/IDBFactoryBackendProxy.cpp:
* src/IDBFactoryBackendProxy.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
(WebKit::WebIDBFactoryImpl::open):
* src/WebIDBFactoryImpl.h:
2011-05-25 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r87257.
http://trac.webkit.org/changeset/87257
https://bugs.webkit.org/show_bug.cgi?id=61457
This broke layout tests, see bug 61431. (Requested by
hwennborg on #webkit).
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::clearAllDatabases):
* DumpRenderTree/chromium/LayoutTestController.h:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBBackingStore.h
trunk/Source/WebCore/storage/IDBFactoryBackendImpl.cpp
trunk/Source/WebCore/storage/IDBFactoryBackendImpl.h
trunk/Source/WebCore/storage/IDBFactoryBackendInterface.h
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.h
trunk/Source/WebCore/storage/IDBSQLiteBackingStore.cpp
trunk/Source/WebCore/storage/IDBSQLiteBackingStore.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBFactory.h
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
Removed Paths
trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt
trunk/LayoutTests/storage/indexeddb/migrate-basics.html
Diff
Modified: trunk/LayoutTests/ChangeLog (87312 => 87313)
--- trunk/LayoutTests/ChangeLog 2011-05-25 19:22:25 UTC (rev 87312)
+++ trunk/LayoutTests/ChangeLog 2011-05-25 19:23:39 UTC (rev 87313)
@@ -1,3 +1,15 @@
+2011-05-25 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r87257.
+http://trac.webkit.org/changeset/87257
+https://bugs.webkit.org/show_bug.cgi?id=61457
+
+This broke layout tests, see bug 61431. (Requested by
+hwennborg on #webkit).
+
+* storage/indexeddb/migrate-basics-expected.txt: Removed.
+* storage/indexeddb/migrate-basics.html: Removed.
+
2011-05-25 Qi Zhang qi.2.zh...@nokia.com
Reviewed by Andreas Kling.
Deleted: trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt (87312 => 87313)
--- trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt 2011-05-25 19:22:25 UTC (rev 87312)
+++ trunk/LayoutTests/storage/indexeddb/migrate-basics-expected.txt 2011-05-25 19:23:39 UTC (rev 87313)
@@ -1,36 +0,0 @@
-Test migration from SQLite to LevelDB.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-webkitIndexedDB.open('MigrationDatabase')
-sqliteCreateSuccess():
-db = event.target.result
-db.setVersion('new version')
-sqliteSetVersionSuccess():
-window.db.createObjectStore('PlainOldStore', {autoIncrement: false})
-store =
[webkit-changes] [87315] trunk/Source
Title: [87315] trunk/Source Revision 87315 Author caio.olive...@openbossa.org Date 2011-05-25 12:28:22 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org Reviewed by Andreas Kling. [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain https://bugs.webkit.org/show_bug.cgi?id=61343 Create a stack to keep track of the sender objects. This is simpler than the similar mechanism in QObject (C++ API), that keeps a stack per-object. Since we do not support multiple threads, one static stack will be enough for handling the behavior. This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test. * bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::qtSenderStack): We have one static stack of QObject*. The top of the stack contains the last object that emitted signal that called a _javascript_ function. * bridge/qt/qt_instance.h: (JSC::Bindings::QtInstance::QtSenderStack::top): (JSC::Bindings::QtInstance::QtSenderStack::push): (JSC::Bindings::QtInstance::QtSenderStack::pop): Minimal functionality to manipulate the sender stack. * bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtConnectionObject::execute): Remove the previous code that modified the scope chain. Push the sender object to the stack before calling the _javascript_ function (the slot in Qt-speak) and pop it afterwards. 2011-05-25 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org Reviewed by Andreas Kling. [Qt] JSC bridge: implement __qt_sender__ without using Scope Chain https://bugs.webkit.org/show_bug.cgi?id=61343 Create a '__qt_sender__' property in the global object, that returns the top of the qtSenderStack. This is an alternative implementation for the feature of providing a way for a function (acting as a Qt 'slot') discover which object emitted the signal that caused it to be executed. This reduces the coupling of the Qt bridge and JSC internal implementation. The patch tries to use as much JSC public API as possible. This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test. * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld): Instead of emitting the QWebPage::_javascript_WindowObjectCleared() directly, calls a QWebPagePrivate function to do it. * Api/qwebframe_p.h: * Api/qwebframe.cpp: (QWebFramePrivate::didClearedWindowObject): Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh global object. (qtSenderCallback): Returns the JSObjectRef corresponding to the top of qtSenderStack. (QWebFramePrivate::addQtSenderToGlobalObject): Create a property with a qtSenderCallback as getter function in the global object. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bridge/qt/qt_instance.cpp trunk/Source/WebCore/bridge/qt/qt_instance.h trunk/Source/WebCore/bridge/qt/qt_runtime.cpp trunk/Source/WebKit/qt/Api/qwebframe.cpp trunk/Source/WebKit/qt/Api/qwebframe_p.h trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (87314 => 87315) --- trunk/Source/WebCore/ChangeLog 2011-05-25 19:25:50 UTC (rev 87314) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 19:28:22 UTC (rev 87315) @@ -1,3 +1,35 @@ +2011-05-25 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org + +Reviewed by Andreas Kling. + +[Qt] JSC bridge: implement __qt_sender__ without using Scope Chain +https://bugs.webkit.org/show_bug.cgi?id=61343 + +Create a stack to keep track of the sender objects. This is simpler than +the similar mechanism in QObject (C++ API), that keeps a stack per-object. + +Since we do not support multiple threads, one static stack will be enough for +handling the behavior. + +This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test. + +* bridge/qt/qt_instance.cpp: +(JSC::Bindings::QtInstance::qtSenderStack): +We have one static stack of QObject*. The top of the stack contains the +last object that emitted signal that called a _javascript_ function. + +* bridge/qt/qt_instance.h: +(JSC::Bindings::QtInstance::QtSenderStack::top): +(JSC::Bindings::QtInstance::QtSenderStack::push): +(JSC::Bindings::QtInstance::QtSenderStack::pop): +Minimal functionality to manipulate the sender stack. + +* bridge/qt/qt_runtime.cpp: +(JSC::Bindings::QtConnectionObject::execute): +Remove the previous code that modified the scope
[webkit-changes] [87323] trunk
Title: [87323] trunk
Revision 87323
Author scher...@chromium.org
Date 2011-05-25 14:47:39 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Andrew Scherkus scher...@chromium.org
Reviewed by Eric Carlson.
Fix media element regression where ended event stopped firing after changing the src attribute.
https://bugs.webkit.org/show_bug.cgi?id=61336
* media/media-ended-expected.txt: Added.
* media/media-ended.html: Added.
2011-05-25 Andrew Scherkus scher...@chromium.org
Reviewed by Eric Carlson.
Fix media element regression where ended event stopped firing after changing the src attribute.
https://bugs.webkit.org/show_bug.cgi?id=61336
Test: media/media-ended.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/media-ended-expected.txt
trunk/LayoutTests/media/media-ended.html
Diff
Modified: trunk/LayoutTests/ChangeLog (87322 => 87323)
--- trunk/LayoutTests/ChangeLog 2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/LayoutTests/ChangeLog 2011-05-25 21:47:39 UTC (rev 87323)
@@ -1,3 +1,14 @@
+2011-05-25 Andrew Scherkus scher...@chromium.org
+
+Reviewed by Eric Carlson.
+
+Fix media element regression where ended event stopped firing after changing the src attribute.
+
+https://bugs.webkit.org/show_bug.cgi?id=61336
+
+* media/media-ended-expected.txt: Added.
+* media/media-ended.html: Added.
+
2011-05-25 Jer Noble jer.no...@apple.com
Reviewed by Darin Adler.
Added: trunk/LayoutTests/media/media-ended-expected.txt (0 => 87323)
--- trunk/LayoutTests/media/media-ended-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-ended-expected.txt 2011-05-25 21:47:39 UTC (rev 87323)
@@ -0,0 +1,13 @@
+Test ended by:
+
+Play to the end.
+When 'ended' event fires, change the source.
+Verify that 'ended' event fires again on different source.
+EVENT(ended)
+EXPECTED (audio.ended == 'true') OK
+EXPECTED (audio.ended == 'false') OK
+
+EVENT(ended)
+EXPECTED (audio.ended == 'true') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-ended.html (0 => 87323)
--- trunk/LayoutTests/media/media-ended.html (rev 0)
+++ trunk/LayoutTests/media/media-ended.html 2011-05-25 21:47:39 UTC (rev 87323)
@@ -0,0 +1,51 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+
+script
+var endedCount = 0;
+var canplaythroughCount = 0;
+var audio;
+
+function start()
+{
+audio = document.querySelector(audio);
+waitForEvent(ended, ended);
+
+audio.src = "" content/silence)
+}
+
+function ended()
+{
+switch (++endedCount)
+{
+case 1:
+testExpected(audio.ended, true);
+
+// Change src but don't seek so that internal state isn't reset.
+audio.src = "" content/silence)
+testExpected(audio.ended, false);
+
+consoleWrite();
+break;
+case 2:
+testExpected(audio.ended, true);
+endTest();
+break;
+}
+}
+/script
+/head
+body _onload_=start()
+audio controls autoplay/audio
+pbTest ended by:/b
+ol
+liPlay to the end./li
+liWhen 'ended' event fires, change the source./li
+liVerify that 'ended' event fires again on different source./li
+/ol
+/p
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (87322 => 87323)
--- trunk/Source/WebCore/ChangeLog 2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/Source/WebCore/ChangeLog 2011-05-25 21:47:39 UTC (rev 87323)
@@ -1,3 +1,16 @@
+2011-05-25 Andrew Scherkus scher...@chromium.org
+
+Reviewed by Eric Carlson.
+
+Fix media element regression where ended event stopped firing after changing the src attribute.
+
+https://bugs.webkit.org/show_bug.cgi?id=61336
+
+Test: media/media-ended.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::prepareForLoad):
+
2011-05-25 Jer Noble jer.no...@apple.com
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (87322 => 87323)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-05-25 21:38:31 UTC (rev 87322)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-05-25 21:47:39 UTC (rev 87323)
@@ -515,6 +515,7 @@
// Perform the cleanup required for the resource load algorithm to run.
[webkit-changes] [87324] trunk
Title: [87324] trunk Revision 87324 Author jhoneyc...@apple.com Date 2011-05-25 14:56:21 -0700 (Wed, 25 May 2011) Log Message REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery https://bugs.webkit.org/show_bug.cgi?id=61428 rdar://problem/9457006 Reviewed by Adam Roben. Source/WebKit2: The crash occurs when Flash posts a message to a window that it creates, and in processing the message, it calls NPN_Evaluate to evaluate _javascript_ that removes the plug-in from the page. Flash then crashes when we return to Flash code. * Platform/WorkItem.h: (DerefWorkItem::DerefWorkItem): Initialize m_ptr. (DerefWorkItem::execute): Deref the object. (WorkItem::createDeref): Create and return a DerefWorkItem. * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::unprotectPluginFromDestruction): If the PluginView has only one reference left, deref it asynchronously. Tools: The crash occurs when Flash posts a message to a window that it creates, and in processing the message, it calls NPN_Evaluate to evaluate _javascript_ that removes the plug-in from the page. Flash then crashes when we return to Flash code. This test emulates that behavior. * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added. (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin): Initialize member vars. (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin): Remove our custom property from the message window, and destroy it. (CallJSThatDestroysPlugin::NPP_Destroy): Set m_isDestroyed, log that the plug-in was destroyed, and notify the layout test controller that we're done. (wndProc): Get the PluginTest object, and call its runTest() function. (CallJSThatDestroysPlugin::NPP_New): Setup the test: register a class for the message-only window, create it, and post a message to it to run the test. (CallJSThatDestroysPlugin::runTest): Execute JS that removes the plug-in from the page, and if we're not destroyed, log a success message. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Add new test to project. LayoutTests: * platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt: Added. * platform/win/plugins/call-_javascript_-that-destroys-plugin.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/WorkItem.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj Added Paths trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp Diff Modified: trunk/LayoutTests/ChangeLog (87323 => 87324) --- trunk/LayoutTests/ChangeLog 2011-05-25 21:47:39 UTC (rev 87323) +++ trunk/LayoutTests/ChangeLog 2011-05-25 21:56:21 UTC (rev 87324) @@ -1,3 +1,14 @@ +2011-05-25 Jon Honeycutt jhoneyc...@apple.com + +REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery +https://bugs.webkit.org/show_bug.cgi?id=61428 +rdar://problem/9457006 + +Reviewed by Adam Roben. + +* platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt: Added. +* platform/win/plugins/call-_javascript_-that-destroys-plugin.html: Added. + 2011-05-25 Andrew Scherkus scher...@chromium.org Reviewed by Eric Carlson. Added: trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt (0 => 87324) --- trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt (rev 0) +++ trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin-expected.txt 2011-05-25 21:56:21 UTC (rev 87324) @@ -0,0 +1,3 @@ +CONSOLE MESSAGE: line 0: PLUGIN: Success: executed script, and plug-in is not yet destroyed. +CONSOLE MESSAGE: line 0: PLUGIN: Plug-in destroyed. +This tests that, if a plug-in directs the browser to evaluate _javascript_ that removes the plug-in from the page, the plug-in is destroyed asynchronously. Added: trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html (0 => 87324) --- trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html (rev 0) +++ trunk/LayoutTests/platform/win/plugins/call-_javascript_-that-destroys-plugin.html 2011-05-25 21:56:21 UTC (rev 87324) @@ -0,0 +1,15 @@ +!DOCTYPE html +html +head +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); +/script +/head +body +embed type=application/x-webkit-test-netscape test=call-_javascript_-that-destroys-plugin/embed +pThis tests that, if a plug-in directs the browser to evaluate _javascript_ that removes the plug-in from the page, +the plug-in is destroyed asynchronously./p +/body
[webkit-changes] [87325] trunk/LayoutTests
Title: [87325] trunk/LayoutTests Revision 87325 Author ad...@chromium.org Date 2011-05-25 15:03:52 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Test expectations update, followup to r87291. The aforementioned change cleared out these files, when the intent seems to have been removal to remove them. * platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed. * platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed. * platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed. * platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (87324 => 87325) --- trunk/LayoutTests/ChangeLog 2011-05-25 21:56:21 UTC (rev 87324) +++ trunk/LayoutTests/ChangeLog 2011-05-25 22:03:52 UTC (rev 87325) @@ -1,3 +1,15 @@ +2011-05-25 Adam Klein ad...@chromium.org + +Unreviewed. Test expectations update, followup to r87291. + +The aforementioned change cleared out these files, when the intent +seems to have been removal to remove them. + +* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed. +* platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed. +* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt: Removed. +* platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt: Removed. + 2011-05-25 Jon Honeycutt jhoneyc...@apple.com REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => ) Deleted: trunk/LayoutTests/platform/chromium-mac/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt === Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-1-expected.txt ( => ) Deleted: trunk/LayoutTests/platform/chromium-win/ietestcenter/_javascript_/15.5.4.20-1-2-expected.txt === ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87326] trunk/LayoutTests
Title: [87326] trunk/LayoutTests Revision 87326 Author jer.no...@apple.com Date 2011-05-25 15:46:51 -0700 (Wed, 25 May 2011) Log Message Unreviewed; Update Skipped list for failing tests. A new full-screen test requires video full screen support, which does not exist on mac-leopard. Follow-up to r87322. * platform/mac-leopard/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-leopard/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (87325 => 87326) --- trunk/LayoutTests/ChangeLog 2011-05-25 22:03:52 UTC (rev 87325) +++ trunk/LayoutTests/ChangeLog 2011-05-25 22:46:51 UTC (rev 87326) @@ -1,3 +1,12 @@ +2011-05-25 Jer Noble jer.no...@apple.com + +Unreviewed; Update Skipped list for failing tests. + +A new full-screen test requires video full screen support, which does not +exist on mac-leopard. Follow-up to r87322. + +* platform/mac-leopard/Skipped: + 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Test expectations update, followup to r87291. Modified: trunk/LayoutTests/platform/mac-leopard/Skipped (87325 => 87326) --- trunk/LayoutTests/platform/mac-leopard/Skipped 2011-05-25 22:03:52 UTC (rev 87325) +++ trunk/LayoutTests/platform/mac-leopard/Skipped 2011-05-25 22:46:51 UTC (rev 87326) @@ -22,6 +22,7 @@ # These tests requires fullscreen video support media/media-fullscreen-inline.html media/media-fullscreen-not-in-document.html +fullscreen/full-screen-iframe-legacy.html # Tests of accessibility functionality not supported on Leopard accessibility/aria-list-and-listitem.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87328] trunk
Title: [87328] trunk Revision 87328 Author jer.no...@apple.com Date 2011-05-25 15:53:23 -0700 (Wed, 25 May 2011) Log Message 2011-05-24 Jer Noble jer.no...@apple.com Reviewed by Darin Adler. Video fails to play on Vimeo https://bugs.webkit.org/show_bug.cgi?id=61403 No new tests; Covered by media/video-canvas-source.html. Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when creating an AVAsset or QTMovie. Instead, we should just reject local-remote and remote-local and make our answer to hasSingleSecurityOrigin dynamic. When checking whether a given request has a single security origin, use a SecurityOrigin to check the host, port, and scheme. * WebCore.exp.in: * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::assetURL): Added. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Exchange ForbidCrossSiteReference for ForbidRemoteReferenceToLocal and ForbidLocalReferenceToRemote (WebCore::MediaPlayerPrivateAVFoundationObjC::hasSingleSecurityOrigin): Check to see that the requested and resolved URLs have the same host and port. * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Exchange NoCrossSiteAttribute for NoRemoteToLocalSiteAttribute and NoLocalToRemoteSiteAttribute. (WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin): Check to see that the requested and resolved URLs have the same host and port. * platform/mac/WebCoreSystemInterface.h: Added wkAVAssetResolvedURL. * platform/mac/WebCoreSystemInterface.mm: Ditto. 2011-05-24 Jer Noble jer.no...@apple.com Reviewed by Darin Adler. Video fails to play on Vimeo https://bugs.webkit.org/show_bug.cgi?id=61403 * WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and wkQTMovieResolvedURL. 2011-05-24 Jer Noble jer.no...@apple.com Reviewed by Darin Adler. Video fails to play on Vimeo https://bugs.webkit.org/show_bug.cgi?id=61403 * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface): Added support for wkAVAssetResolvedURL and wkQTMovieResolvedURL. 2011-05-25 Jer Noble jer.no...@apple.com Reviewed by Darin Adler. Video fails to play on Vimeo https://bugs.webkit.org/show_bug.cgi?id=61403 Added functions to retrieve the resolved URL for media types supported on mac. * WebKitSystemInterface.h: * WebKitSystemInterface.m: (WKAVAssetResolvedURL): Added. (WKQTMovieResolvedURL): Added. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitSystemInterface.h trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a Diff Modified: trunk/Source/WebCore/ChangeLog (87327 => 87328) --- trunk/Source/WebCore/ChangeLog 2011-05-25 22:49:56 UTC (rev 87327) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 22:53:23 UTC (rev 87328) @@ -1,3 +1,37 @@ +2011-05-24 Jer Noble jer.no...@apple.com + +Reviewed by Darin Adler. + +Video fails to play on Vimeo +https://bugs.webkit.org/show_bug.cgi?id=61403 + +No new tests; Covered by media/video-canvas-source.html. + +Vimeo redirects their assets from player.vimeo.com to av.vimeo.com, which is rejected +by AVFoundation and QTKit due to our setting a ForbidCrossSiteReference option when +creating an AVAsset or QTMovie. Instead, we should just reject local-remote and +remote-local and make our answer to hasSingleSecurityOrigin dynamic. + +When checking whether a given request has a
[webkit-changes] [87329] trunk/Source
Title: [87329] trunk/Source
Revision 87329
Author sle...@apple.com
Date 2011-05-25 16:00:45 -0700 (Wed, 25 May 2011)
Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=61407
part of rdar://problem/8675177
Move Quicklook quirk down into WebCore so it can be caculated when the user
starts a reload. Restructure the conditions so it only called when absolutely
necessary.
Reviewed by Brady Eidson.
No change in functionality so no new tests.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=61407
part of rdar://problem/8675177
Remove Quicklook pref. Moving it enirely down into WebCore so it can
be calculated only on reloads.
Reviewed by Brady Eidson.
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/network/cf/ResourceRequest.h
trunk/Source/WebCore/platform/network/mac/ResourceRequestMac.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (87328 => 87329)
--- trunk/Source/WebCore/ChangeLog 2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/ChangeLog 2011-05-25 23:00:45 UTC (rev 87329)
@@ -1,3 +1,25 @@
+2011-05-25 Stephanie Lewis sle...@apple.com
+
+Reviewed by Brady Eidson.
+
+https://bugs.webkit.org/show_bug.cgi?id=61407
+part of rdar://problem/8675177
+Move Quicklook quirk down into WebCore so it can be caculated when the user
+starts a reload. Restructure the conditions so it only called when absolutely
+necessary.
+
+No change in functionality so no new tests.
+
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::subresourceCachePolicy):
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+* platform/network/cf/ResourceRequest.h:
+* platform/network/mac/ResourceRequestMac.mm:
+(WebCore::initQuickLookResourceCachingQuirks):
+(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
+
2011-05-24 Jer Noble jer.no...@apple.com
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (87328 => 87329)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2011-05-25 23:00:45 UTC (rev 87329)
@@ -2407,15 +2407,16 @@
if (parentCachePolicy != CachePolicyVerify)
return parentCachePolicy;
}
+
+if (m_loadType == FrameLoadTypeReload)
+return CachePolicyRevalidate;
const ResourceRequest request(documentLoader()-request());
-Settings* settings = m_frame-settings();
-if (settings settings-useQuickLookResourceCachingQuirks() request.cachePolicy() == ReloadIgnoringCacheData !equalIgnoringCase(request.httpMethod(), post))
+#if PLATFORM(MAC)
+if (request.cachePolicy() == ReloadIgnoringCacheData !equalIgnoringCase(request.httpMethod(), post) ResourceRequest::useQuickLookResourceCachingQuirks())
return CachePolicyRevalidate;
+#endif
-if (m_loadType == FrameLoadTypeReload)
-return CachePolicyRevalidate;
-
if (request.cachePolicy() == ReturnCacheDataElseLoad)
return CachePolicyHistoryBuffer;
Modified: trunk/Source/WebCore/page/Settings.cpp (87328 => 87329)
--- trunk/Source/WebCore/page/Settings.cpp 2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.cpp 2011-05-25 23:00:45 UTC (rev 87329)
@@ -177,7 +177,6 @@
, m_usePreHTML5ParserQuirks(false)
, m_hyperlinkAuditingEnabled(false)
, m_crossOriginCheckInGetMatchedCSSRulesDisabled(false)
-, m_useQuickLookResourceCachingQuirks(false)
, m_forceCompositingMode(false)
, m_shouldInjectUserScriptsInInitialEmptyDocument(false)
, m_allowDisplayOfInsecureContent(true)
Modified: trunk/Source/WebCore/page/Settings.h (87328 => 87329)
--- trunk/Source/WebCore/page/Settings.h 2011-05-25 22:53:23 UTC (rev 87328)
+++ trunk/Source/WebCore/page/Settings.h 2011-05-25 23:00:45 UTC (rev 87329)
@@ -394,9 +394,6 @@
void setCrossOriginCheckInGetMatchedCSSRulesDisabled(bool flag) {
[webkit-changes] [87330] trunk/Source/WebCore
Title: [87330] trunk/Source/WebCore
Revision 87330
Author msab...@apple.com
Date 2011-05-25 16:05:29 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Michael Saboff msab...@apple.com
Reviewed by Sam Weinig.
Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
https://bugs.webkit.org/show_bug.cgi?id=61478
Cleanup of further comments after patch was landed. Changes include
using /2 instead of 1, adding a blank line after class include,
making method names start with lower case and adding clarifying
comments.
No new tests as the changes are stylistic and not functional.
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToPercentage):
(WebCore::MemoryCache::pruneDeadResourcesToPercentage):
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::pruneToPercentage):
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/MemoryCache.cpp
trunk/Source/WebCore/loader/cache/MemoryCache.h
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (87329 => 87330)
--- trunk/Source/WebCore/ChangeLog 2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/ChangeLog 2011-05-25 23:05:29 UTC (rev 87330)
@@ -1,3 +1,25 @@
+2011-05-25 Michael Saboff msab...@apple.com
+
+Reviewed by Sam Weinig.
+
+Cleanup of commented items from https://bugs.webkit.org/show_bug.cgi?id=61222
+https://bugs.webkit.org/show_bug.cgi?id=61478
+
+Cleanup of further comments after patch was landed. Changes include
+using /2 instead of 1, adding a blank line after class include,
+making method names start with lower case and adding clarifying
+comments.
+
+No new tests as the changes are stylistic and not functional.
+
+* loader/cache/MemoryCache.cpp:
+(WebCore::MemoryCache::pruneLiveResourcesToPercentage):
+(WebCore::MemoryCache::pruneDeadResourcesToPercentage):
+* loader/cache/MemoryCache.h:
+(WebCore::MemoryCache::pruneToPercentage):
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::respondToMemoryPressure):
+
2011-05-25 Stephanie Lewis sle...@apple.com
Reviewed by Brady Eidson.
Modified: trunk/Source/WebCore/loader/cache/MemoryCache.cpp (87329 => 87330)
--- trunk/Source/WebCore/loader/cache/MemoryCache.cpp 2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.cpp 2011-05-25 23:05:29 UTC (rev 87330)
@@ -176,7 +176,7 @@
pruneLiveResourcesToSize(targetSize);
}
-void MemoryCache::PruneLiveResourcesToPercentage(float prunePercentage)
+void MemoryCache::pruneLiveResourcesToPercentage(float prunePercentage)
{
if (!m_pruneEnabled)
return;
@@ -239,7 +239,7 @@
pruneDeadResourcesToSize(targetSize);
}
-void MemoryCache::PruneDeadResourcesToPercentage(float prunePercentage)
+void MemoryCache::pruneDeadResourcesToPercentage(float prunePercentage)
{
if (!m_pruneEnabled)
return;
Modified: trunk/Source/WebCore/loader/cache/MemoryCache.h (87329 => 87330)
--- trunk/Source/WebCore/loader/cache/MemoryCache.h 2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.h 2011-05-25 23:05:29 UTC (rev 87330)
@@ -141,8 +141,8 @@
void pruneToPercentage(float targetPercentLive)
{
-PruneDeadResourcesToPercentage(targetPercentLive); // Prune dead first, in case it was borrowing capacity from live.
-PruneLiveResourcesToPercentage(targetPercentLive);
+pruneDeadResourcesToPercentage(targetPercentLive); // Prune dead first, in case it was borrowing capacity from live.
+pruneLiveResourcesToPercentage(targetPercentLive);
}
void setDeadDecodedDataDeletionInterval(double interval) { m_deadDecodedDataDeletionInterval = interval; }
@@ -193,8 +193,8 @@
// pruneLive*() - Flush decoded data from resources still referenced by Web pages.
void pruneDeadResources(); // Automatically decide how much to prune.
void pruneLiveResources();
-void PruneDeadResourcesToPercentage(float prunePercentage);
-void PruneLiveResourcesToPercentage(float prunePercentage);
+void pruneDeadResourcesToPercentage(float prunePercentage); // Prune to % current size
+void pruneLiveResourcesToPercentage(float prunePercentage);
void pruneDeadResourcesToSize(unsigned targetSize);
void pruneLiveResourcesToSize(unsigned targetSize);
Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (87329 => 87330)
--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-05-25 23:00:45 UTC (rev 87329)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
[webkit-changes] [87331] trunk/Source/WebCore
Title: [87331] trunk/Source/WebCore Revision 87331 Author jer.no...@apple.com Date 2011-05-25 16:08:28 -0700 (Wed, 25 May 2011) Log Message Ureviewed; Build fix for Leopard and Snow Leopard. Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL. * WebCore.exp.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (87330 => 87331) --- trunk/Source/WebCore/ChangeLog 2011-05-25 23:05:29 UTC (rev 87330) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 23:08:28 UTC (rev 87331) @@ -1,3 +1,11 @@ +2011-05-25 Jer Noble jer.no...@apple.com + +Ureviewed; Build fix for Leopard and Snow Leopard. + +Move _wkQTMovieResolvedURL outside of a #if check for Leopard and SL. + +* WebCore.exp.in: + 2011-05-25 Michael Saboff msab...@apple.com Reviewed by Sam Weinig. Modified: trunk/Source/WebCore/WebCore.exp.in (87330 => 87331) --- trunk/Source/WebCore/WebCore.exp.in 2011-05-25 23:05:29 UTC (rev 87330) +++ trunk/Source/WebCore/WebCore.exp.in 2011-05-25 23:08:28 UTC (rev 87331) @@ -1375,6 +1375,7 @@ _wkQTMovieMaxTimeLoaded _wkQTMovieMaxTimeLoadedChangeNotification _wkQTMovieMaxTimeSeekable +_wkQTMovieResolvedURL _wkQTMovieSelectPreferredAlternates _wkQTMovieSetShowClosedCaptions _wkQTMovieViewSetDrawSynchronously @@ -1458,7 +1459,6 @@ _wkVerticalScrollbarPainterForController _wkWillEndLiveResize _wkWillStartLiveResize -_wkQTMovieResolvedURL _wkAVAssetResolvedURL #else _wkGetNSEventMomentumPhase ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87332] trunk/LayoutTests
Title: [87332] trunk/LayoutTests Revision 87332 Author ad...@chromium.org Date 2011-05-25 16:09:56 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Removing test_expectations for non-existent tests. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (87331 => 87332) --- trunk/LayoutTests/ChangeLog 2011-05-25 23:08:28 UTC (rev 87331) +++ trunk/LayoutTests/ChangeLog 2011-05-25 23:09:56 UTC (rev 87332) @@ -1,3 +1,9 @@ +2011-05-25 Adam Klein ad...@chromium.org + +Unreviewed. Removing test_expectations for non-existent tests. + +* platform/chromium/test_expectations.txt: + 2011-05-25 Jer Noble jer.no...@apple.com Unreviewed; Update Skipped list for failing tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87331 => 87332) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-25 23:08:28 UTC (rev 87331) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-25 23:09:56 UTC (rev 87332) @@ -2426,9 +2426,6 @@ BUGCR58970 LINUX : svg/text/text-tselect-02-f.svg = IMAGE PASS BUGCR58931 WIN LINUX : svg/W3C-SVG-1.1/pservers-grad-17-b.svg = IMAGE PASS -// Failing from around r62021 -BUGCR15797 WIN : fast/dom/object-embed-plugin-scripting.html = TIMEOUT PASS TEXT - // Failing from r69420, mac failing from r71493:r71496 BUGCR58735 SLOW : http/tests/misc/prefetch-purpose.html = PASS @@ -4134,26 +4131,6 @@ // New tests added in r87274 BUGCR83865 : fast/forms/color/input-value-sanitization-color.html = FAIL PASS -// Regression from webkit r87257 -BUGWK61431 DEBUG : storage/indexeddb/create-and-remove-object-store.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/cursor-continue.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/cursor-index-delete.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/cursor-update.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/database-basics.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/duplicates.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/exception-in-event-aborts.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/index-cursor.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/migrate-basics.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/objectstore-basics.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/objectstore-cursor.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/open-cursor.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/request-event-propagation.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/set_version_queue.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/transaction-after-close.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/transaction-basics.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/transaction-event-propagation.html = CRASH -BUGWK61431 DEBUG : storage/indexeddb/transaction-rollback.html = CRASH - // New tests added in webkit r87284 BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dx-attr.html = IMAGE BUGCR83869 : svg/dynamic-updates/SVGTextElement-dom-dy-attr.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87334] trunk/LayoutTests
Title: [87334] trunk/LayoutTests
Revision 87334
Author ad...@chromium.org
Date 2011-05-25 16:39:48 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 Adam Klein ad...@chromium.org
Unreviewed. Rebaseline svg tests after r87310.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
Added Paths
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (87333 => 87334)
--- trunk/LayoutTests/ChangeLog 2011-05-25 23:30:41 UTC (rev 87333)
+++ trunk/LayoutTests/ChangeLog 2011-05-25 23:39:48 UTC (rev 87334)
@@ -1,5 +1,20 @@
2011-05-25 Adam Klein ad...@chromium.org
+Unreviewed. Rebaseline svg tests after r87310.
+
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+* platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Removed.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
+* platform/chromium-win/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
+
+2011-05-25 Adam Klein ad...@chromium.org
+
Unreviewed. Removing test_expectations for non-existent tests.
* platform/chromium/test_expectations.txt:
Modified: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png
(Binary files differ)
Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (0 => 87334)
--- trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt 2011-05-25 23:39:48 UTC (rev 87334)
@@ -0,0 +1,40 @@
+layer at (0,0) size 480x360
+ RenderView at (0,0) size 480x360
+layer at (0,0) size 480x360
+ RenderSVGRoot {svg} at (0,0) size 480x360
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGContainer {g} at (82,20) size 362x264
+ RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceFilter {filter} [id=null] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+RenderSVGResourceFilter {filter} [id=nullreg] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+ RenderSVGContainer {g} at
[webkit-changes] [87335] trunk/Source
Title: [87335] trunk/Source
Revision 87335
Author mr...@apple.com
Date 2011-05-25 16:41:07 -0700 (Wed, 25 May 2011)
Log Message
rdar://problem/9504058 Need some way to query user gesture state from injected bundle
Reviewed by Sam Weinig.
Source/WebCore:
* WebCore.exp.in: Add an export that WebKit2 needs.
Source/WebKit2:
Add WKBundleIsProcessingUserGesture.
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
(WKBundleIsProcessingUserGesture):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isProcessingUserGesture):
* WebProcess/InjectedBundle/InjectedBundle.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (87334 => 87335)
--- trunk/Source/WebCore/ChangeLog 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebCore/ChangeLog 2011-05-25 23:41:07 UTC (rev 87335)
@@ -1,3 +1,11 @@
+2011-05-25 Mark Rowe mr...@apple.com
+
+Reviewed by Sam Weinig.
+
+rdar://problem/9504058 Need some way to query user gesture state from injected bundle
+
+* WebCore.exp.in: Add an export that WebKit2 needs.
+
2011-05-25 Jer Noble jer.no...@apple.com
Ureviewed; Build fix for Leopard and Snow Leopard.
Modified: trunk/Source/WebCore/WebCore.exp.in (87334 => 87335)
--- trunk/Source/WebCore/WebCore.exp.in 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-05-25 23:41:07 UTC (rev 87335)
@@ -540,6 +540,7 @@
__ZN7WebCore20ResourceResponseBase24setExpectedContentLengthEx
__ZN7WebCore20ResourceResponseBaseC2Ev
__ZN7WebCore20SpaceSplitStringData12createVectorEv
+__ZN7WebCore20UserGestureIndicator23s_processingUserGestureE
__ZN7WebCore20UserGestureIndicatorC1ENS_26ProcessingUserGestureStateE
__ZN7WebCore20UserGestureIndicatorD1Ev
__ZN7WebCore20makeRGBA32FromFloatsE
Modified: trunk/Source/WebKit2/ChangeLog (87334 => 87335)
--- trunk/Source/WebKit2/ChangeLog 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/ChangeLog 2011-05-25 23:41:07 UTC (rev 87335)
@@ -1,3 +1,19 @@
+2011-05-25 Mark Rowe mr...@apple.com
+
+Reviewed by Sam Weinig.
+
+rdar://problem/9504058 Need some way to query user gesture state from injected bundle
+
+Add WKBundleIsProcessingUserGesture.
+
+* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+(WKBundleIsPageBoxVisible):
+(WKBundleIsProcessingUserGesture):
+* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+* WebProcess/InjectedBundle/InjectedBundle.cpp:
+(WebKit::InjectedBundle::isProcessingUserGesture):
+* WebProcess/InjectedBundle/InjectedBundle.h:
+
2011-05-24 Jer Noble jer.no...@apple.com
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (87334 => 87335)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2011-05-25 23:41:07 UTC (rev 87335)
@@ -193,7 +193,12 @@
return toCopiedAPI(toImpl(bundleRef)-pageSizeAndMarginsInPixels(toImpl(frameRef), pageIndex, width, height, marginTop, marginRight, marginBottom, marginLeft));
}
-WK_EXPORT bool WKBundleIsPageBoxVisible(WKBundleRef bundleRef, WKBundleFrameRef frameRef, int pageIndex)
+bool WKBundleIsPageBoxVisible(WKBundleRef bundleRef, WKBundleFrameRef frameRef, int pageIndex)
{
return toImpl(bundleRef)-isPageBoxVisible(toImpl(frameRef), pageIndex);
}
+
+bool WKBundleIsProcessingUserGesture(WKBundleRef)
+{
+return InjectedBundle::isProcessingUserGesture();
+}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (87334 => 87335)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2011-05-25 23:41:07 UTC (rev 87335)
@@ -79,6 +79,8 @@
WK_EXPORT void WKBundleRemoveOriginAccessWhitelistEntry(WKBundleRef bundle, WKStringRef, WKStringRef, WKStringRef, bool);
WK_EXPORT void WKBundleResetOriginAccessWhitelists(WKBundleRef bundle);
+WK_EXPORT bool WKBundleIsProcessingUserGesture(WKBundleRef bundle);
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (87334 => 87335)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2011-05-25 23:39:48 UTC (rev 87334)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2011-05-25 23:41:07 UTC (rev 87335)
@@ -51,6
[webkit-changes] [87336] trunk/Source/WebCore
Title: [87336] trunk/Source/WebCore Revision 87336 Author mrobin...@webkit.org Date 2011-05-25 16:54:02 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Martin Robinson mrobin...@igalia.com Reviewed by Dirk Schulze. [Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo https://bugs.webkit.org/show_bug.cgi?id=60185 Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha state into PlatformContextCairo. Since Cairo is the only platform that needs to store this, this is the proper place for it. Change the image mask stack into a more generic state stack that can keep track of the multiple bits of platform specific state and properly handle save/restore pairs. No new tests. This is just a code refactor. * platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs. (WebCore::GraphicsContextState::GraphicsContextState): Ditto. * platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now. (WebCore::ContextShadow::drawRectShadow): * platform/graphics/cairo/FontCairo.cpp: Ditto. (WebCore::Font::drawGlyphs): * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::setPlatformFill): Ditto. (WebCore::setPlatformStroke): Ditto. (WebCore::GraphicsContext::setAlpha): Ditto. * platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the header file, since it can be private now. Abstract the image mask state and the global alpha in a generic State class. (WebCore::ImageMaskInformation::update): (WebCore::ImageMaskInformation::isValid): (WebCore::ImageMaskInformation::maskSurface): (WebCore::ImageMaskInformation::maskRect): (WebCore::PlatformContextCairo::State::State): Added. (WebCore::PlatformContextCairo::PlatformContextCairo): Intialize the state class when this class is constructed. (WebCore::PlatformContextCairo::restore): Now pop the last state off the state stack. (WebCore::PlatformContextCairo::~PlatformContextCairo): Added this so that we can forward declare the State class in the header. (WebCore::PlatformContextCairo::save): Push a new state onto the stack. (WebCore::PlatformContextCairo::pushImageMask): Operate on the state stack now. (WebCore::PlatformContextCairo::globalAlpha): Added. (WebCore::PlatformContextCairo::setGlobalAlpha): Added. (WebCore::PlatformContextCairo::drawSurfaceToContext: Call globalAlpha(). * platform/graphics/cairo/PlatformContextCairo.h: Changed the image mask stack into a more generic state stack, much like PlatformContextChromium. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/cairo/ContextShadowCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/PlatformContextCairo.h Diff Modified: trunk/Source/WebCore/ChangeLog (87335 => 87336) --- trunk/Source/WebCore/ChangeLog 2011-05-25 23:41:07 UTC (rev 87335) +++ trunk/Source/WebCore/ChangeLog 2011-05-25 23:54:02 UTC (rev 87336) @@ -1,3 +1,49 @@ +2011-05-25 Martin Robinson mrobin...@igalia.com + +Reviewed by Dirk Schulze. + +[Cairo] Move the global alpha property from GraphicsContext to PlatformContextCairo +https://bugs.webkit.org/show_bug.cgi?id=60185 + +Remove Cairo #ifdefs from GraphicsContext.h by pushing the global alpha +state into PlatformContextCairo. Since Cairo is the only platform that needs +to store this, this is the proper place for it. Change the image mask stack into +a more generic state stack that can keep track of the multiple bits of platform +specific state and properly handle save/restore pairs. + +No new tests. This is just a code refactor. + +* platform/graphics/GraphicsContext.h: Remove Cairo #ifdefs. +(WebCore::GraphicsContextState::GraphicsContextState): Ditto. +* platform/graphics/cairo/ContextShadowCairo.cpp: Access global alpha from PlatformContextCairo now. +(WebCore::ContextShadow::drawRectShadow): +* platform/graphics/cairo/FontCairo.cpp: Ditto. +(WebCore::Font::drawGlyphs): +* platform/graphics/cairo/GraphicsContextCairo.cpp: +(WebCore::setPlatformFill): Ditto. +(WebCore::setPlatformStroke): Ditto. +(WebCore::GraphicsContext::setAlpha): Ditto. +* platform/graphics/cairo/PlatformContextCairo.cpp: Moved ImageMaskInformation class from the +header file, since it can be private now. Abstract the image mask
[webkit-changes] [87339] trunk/LayoutTests
Title: [87339] trunk/LayoutTests Revision 87339 Author ad...@chromium.org Date 2011-05-25 17:27:05 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Test expectations update. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (87338 => 87339) --- trunk/LayoutTests/ChangeLog 2011-05-26 00:24:04 UTC (rev 87338) +++ trunk/LayoutTests/ChangeLog 2011-05-26 00:27:05 UTC (rev 87339) @@ -1,5 +1,11 @@ 2011-05-25 Adam Klein ad...@chromium.org +Unreviewed. Test expectations update. + +* platform/chromium/test_expectations.txt: + +2011-05-25 Adam Klein ad...@chromium.org + Unreviewed. Rebaseline svg tests after r87310. * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87338 => 87339) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-26 00:24:04 UTC (rev 87338) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-26 00:27:05 UTC (rev 87339) @@ -3852,7 +3852,7 @@ BUGSENORBLANCO WIN LINUX : animations/animation-drt-api-multiple-keyframes.html = TEXT BUGSENORBLANCO WIN LINUX : animations/animation-drt-api.html = TEXT -BUGSENORBLANCO GPU LEOPARD : compositing/direct-image-compositing.html = IMAGE CRASH +BUGSENORBLANCO GPU MAC : compositing/direct-image-compositing.html = IMAGE CRASH BUGSENORBLANCO MAC LINUX : fast/css/string-quote-binary.html = CRASH PASS BUGSENORBLANCO LINUX : fast/events/panScroll-click-hyperlink.html = TEXT BUGSENORBLANCO : fast/files/domurl-script-execution-context-crash.html = CRASH PASS @@ -4141,3 +4141,5 @@ BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-dy-prop.html = IMAGE BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE + +BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87340] trunk/LayoutTests
Title: [87340] trunk/LayoutTests Revision 87340 Author jer.no...@apple.com Date 2011-05-25 17:44:16 -0700 (Wed, 25 May 2011) Log Message Unreviewed; Skip failing tests after r87328. * platform/mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (87339 => 87340) --- trunk/LayoutTests/ChangeLog 2011-05-26 00:27:05 UTC (rev 87339) +++ trunk/LayoutTests/ChangeLog 2011-05-26 00:44:16 UTC (rev 87340) @@ -1,3 +1,9 @@ +2011-05-25 Jer Noble jer.no...@apple.com + +Unreviewed; Skip failing tests after r87328. + +* platform/mac/Skipped: + 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Test expectations update. Modified: trunk/LayoutTests/platform/mac/Skipped (87339 => 87340) --- trunk/LayoutTests/platform/mac/Skipped 2011-05-26 00:27:05 UTC (rev 87339) +++ trunk/LayoutTests/platform/mac/Skipped 2011-05-26 00:44:16 UTC (rev 87340) @@ -359,3 +359,6 @@ # console long eval test is timeout 60616 inspector/console/console-long-eval-crash.html +# Fails after r87328: +# https://bugs.webkit.org/show_bug.cgi?id=61487 +http/tests/media/video-cross-site.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87341] trunk/LayoutTests
Title: [87341] trunk/LayoutTests Revision 87341 Author ad...@chromium.org Date 2011-05-25 17:52:17 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Adam Klein ad...@chromium.org Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (87340 => 87341) --- trunk/LayoutTests/ChangeLog 2011-05-26 00:44:16 UTC (rev 87340) +++ trunk/LayoutTests/ChangeLog 2011-05-26 00:52:17 UTC (rev 87341) @@ -1,3 +1,9 @@ +2011-05-25 Adam Klein ad...@chromium.org + +Unreviewed. Fix to previous update, mark drag-not-loaded-image crash as DEBUG-only. + +* platform/chromium/test_expectations.txt: + 2011-05-25 Jer Noble jer.no...@apple.com Unreviewed; Skip failing tests after r87328. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (87340 => 87341) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-26 00:44:16 UTC (rev 87340) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-05-26 00:52:17 UTC (rev 87341) @@ -4142,4 +4142,4 @@ BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-x-prop.html = IMAGE BUGCR83869 : svg/dynamic-updates/SVGTextElement-svgdom-y-prop.html = IMAGE -BUGWK61486 : http/tests/misc/drag-not-loaded-image.html = CRASH +BUGWK61486 DEBUG : http/tests/misc/drag-not-loaded-image.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87342] trunk/Source/WebKit/chromium
Title: [87342] trunk/Source/WebKit/chromium Revision 87342 Author commit-qu...@webkit.org Date 2011-05-25 17:59:47 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Shishir Agrawal shis...@chromium.org Reviewed by Dimitri Glazkov. Fix crash in Chromium memory test. https://bugs.webkit.org/show_bug.cgi?id=61451 * src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebViewImpl.cpp Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (87341 => 87342) --- trunk/Source/WebKit/chromium/ChangeLog 2011-05-26 00:52:17 UTC (rev 87341) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-05-26 00:59:47 UTC (rev 87342) @@ -1,3 +1,13 @@ +2011-05-25 Shishir Agrawal shis...@chromium.org + +Reviewed by Dimitri Glazkov. + +Fix crash in Chromium memory test. +https://bugs.webkit.org/show_bug.cgi?id=61451 + +* src/WebViewImpl.cpp: +(WebKit::WebViewImpl::WebViewImpl): + 2011-05-25 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r87333. Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (87341 => 87342) --- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-05-26 00:52:17 UTC (rev 87341) +++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-05-26 00:59:47 UTC (rev 87342) @@ -368,7 +368,8 @@ m_page-setGroupName(pageGroupName); #if ENABLE(PAGE_VISIBILITY_API) -setVisibilityState(m_client-visibilityState(), true); +if (m_client) +setVisibilityState(m_client-visibilityState(), true); #endif m_inspectorSettingsMap = adoptPtr(new SettingsMap); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87344] trunk/Source/WebCore
Title: [87344] trunk/Source/WebCore
Revision 87344
Author jam...@google.com
Date 2011-05-25 18:07:57 -0700 (Wed, 25 May 2011)
Log Message
2011-05-25 James Robinson jam...@chromium.org
Reviewed by Geoffrey Garen
CachedResource overhead size calculation ignores the actual size of the URL
https://bugs.webkit.org/show_bug.cgi?id=61481
CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
can be significant.
This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
other types of strings instead of a fixed number.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::overheadSize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (87343 => 87344)
--- trunk/Source/WebCore/ChangeLog 2011-05-26 01:01:16 UTC (rev 87343)
+++ trunk/Source/WebCore/ChangeLog 2011-05-26 01:07:57 UTC (rev 87344)
@@ -1,3 +1,20 @@
+2011-05-25 James Robinson jam...@chromium.org
+
+Reviewed by Geoffrey Garen
+
+CachedResource overhead size calculation ignores the actual size of the URL
+https://bugs.webkit.org/show_bug.cgi?id=61481
+
+CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict
+it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself
+can be significant.
+
+This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for
+other types of strings instead of a fixed number.
+
+* loader/cache/CachedResource.cpp:
+(WebCore::CachedResource::overheadSize):
+
2011-05-25 Oliver Hunt oli...@apple.com
Reviewed by Geoffrey Garen.
Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (87343 => 87344)
--- trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-05-26 01:01:16 UTC (rev 87343)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp 2011-05-26 01:07:57 UTC (rev 87344)
@@ -607,11 +607,8 @@
unsigned CachedResource::overheadSize() const
{
-return sizeof(CachedResource) + m_response.memoryUsage() + 576;
-/*
-576 = 192 + // average size of m_url
- 384;// average size of m_clients hash map
-*/
+static const int kAverageClientsHashMapSize = 384;
+return sizeof(CachedResource) + m_response.memoryUsage() + kAverageClientsHashMapSize + m_resourceRequest.url().string().length() * 2;
}
void CachedResource::setLoadPriority(ResourceLoadPriority loadPriority)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [87345] trunk/Source
Title: [87345] trunk/Source
Revision 87345
Author oli...@apple.com
Date 2011-05-25 18:08:57 -0700 (Wed, 25 May 2011)
Log Message
Revert last change, something weird happened when I went to land.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/jit/JITStubs.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpCache.cpp
trunk/Source/_javascript_Core/runtime/RegExpCache.h
trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
trunk/Source/_javascript_Core/runtime/RegExpObject.h
trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp
trunk/Source/_javascript_Core/runtime/RegExpPrototype.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (87344 => 87345)
--- trunk/Source/_javascript_Core/ChangeLog 2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-05-26 01:08:57 UTC (rev 87345)
@@ -1,5 +1,9 @@
2011-05-25 Oliver Hunt oli...@apple.com
+Revert last change, something weird happened when I went to land.
+
+2011-05-25 Oliver Hunt oli...@apple.com
+
Reviewed by Geoffrey Garen.
Make RegExp GC allocated
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (87344 => 87345)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-05-26 01:08:57 UTC (rev 87345)
@@ -137,7 +137,7 @@
__ZN3JSC12JSGlobalData6createENS_15ThreadStackTypeE
__ZN3JSC12JSGlobalDataD1Ev
__ZN3JSC12RegExpObject6s_infoE
-__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEPNS_6RegExpE
+__ZN3JSC12RegExpObjectC1EPNS_14JSGlobalObjectEPNS_9StructureEN3WTF17NonNullPassRefPtrINS_6RegExpEEE
__ZN3JSC12SamplingTool5setupEv
__ZN3JSC12SmallStrings17createEmptyStringEPNS_12JSGlobalDataE
__ZN3JSC12SmallStrings27createSingleCharacterStringEPNS_12JSGlobalDataEh
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (87344 => 87345)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-05-26 01:08:57 UTC (rev 87345)
@@ -18,7 +18,7 @@
??0MD5@WTF@@QAE@XZ
??0Mutex@WTF@@QAE@XZ
??0RefCountedLeakCounter@WTF@@QAE@PBD@Z
-??0RegExpObject@JSC@@QAE@PAVJSGlobalObject@1@PAVStructure@1@PAVRegExp@1@JSC@@@WTF@@@Z
+??0RegExpObject@JSC@@QAE@PAVJSGlobalObject@1@PAVStructure@1@V?$NonNullPassRefPtr@VRegExp@JSC@@@WTF@@@Z
??0SHA1@WTF@@QAE@XZ
??0StringObject@JSC@@QAE@PAVExecState@1@PAVStructure@1@ABVUString@1@@Z
??0Structure@JSC@@AAE@AAVJSGlobalData@1@VJSValue@1@ABVTypeInfo@1@IPBUClassInfo@1@@Z
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (87344 => 87345)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-05-26 01:08:57 UTC (rev 87345)
@@ -1470,13 +1470,8 @@
{
visitor.append(m_globalObject);
visitor.append(m_ownerExecutable);
-if (m_rareData) {
+if (m_rareData)
m_rareData-m_evalCodeCache.visitAggregate(visitor);
-size_t regExpCount = m_rareData-m_regexps.size();
-WriteBarrierRegExp* regexps = m_rareData-m_regexps.data();
-for (size_t i = 0; i regExpCount; i++)
-visitor.append(regexps + i);
-}
visitor.appendValues(m_constantRegisters.data(), m_constantRegisters.size());
for (size_t i = 0; i m_functionExprs.size(); ++i)
visitor.append(m_functionExprs[i]);
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (87344 => 87345)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-05-26 01:07:57 UTC (rev 87344)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-05-26 01:08:57 UTC (rev 87345)
@@ -36,7 +36,7 @@
#include JSGlobalObject.h
#include JumpTable.h
#include Nodes.h
-#include
[webkit-changes] [87346] trunk/Source
Title: [87346] trunk/Source Revision 87346 Author oli...@apple.com Date 2011-05-25 18:12:46 -0700 (Wed, 25 May 2011) Log Message 2011-05-25 Oliver Hunt oli...@apple.com Reviewed by Geoffrey Garen. Make RegExp GC allocated https://bugs.webkit.org/show_bug.cgi?id=61490 Make RegExp GC allocated. Basically mechanical change to replace most use of [Pass]RefPtrRegExp with RegExp* or WriteBarrierRegExp where actual ownership happens. Made the RegExpCache use Strong references currently to avoid any changes in behaviour. * _javascript_Core.exp: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::visitAggregate): * bytecode/CodeBlock.h: (JSC::CodeBlock::addRegExp): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::addRegExp): (JSC::BytecodeGenerator::emitNewRegExp): * bytecompiler/BytecodeGenerator.h: * runtime/JSCell.h: * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::clearBuiltinStructures): (JSC::JSGlobalData::addRegExpToTrace): * runtime/JSGlobalData.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): * runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create): (JSC::RegExp::invalidateCode): * runtime/RegExp.h: (JSC::RegExp::createStructure): * runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create): * runtime/RegExpCache.h: * runtime/RegExpConstructor.cpp: (JSC::constructRegExp): * runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject): (JSC::RegExpObject::visitChildren): * runtime/RegExpObject.h: (JSC::RegExpObject::setRegExp): (JSC::RegExpObject::RegExpObjectData::RegExpObjectData): * runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype): (JSC::regExpProtoFuncCompile): * runtime/RegExpPrototype.h: * runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): 2011-05-25 James Robinson jam...@chromium.org Reviewed by Geoffrey Garen CachedResource overhead size calculation ignores the actual size of the URL https://bugs.webkit.org/show_bug.cgi?id=61481 CachedResource::overheadSize is used to determine the size of an entry in the memory cache to know when to evict it. When the resource is a large data: URL, for example representing image or audio data, the URL size itself can be significant. This patch uses an estimate of actual number of bytes used by the URL that is valid for ASCII urls and close for other types of strings instead of a fixed number. * loader/cache/CachedResource.cpp: (WebCore::CachedResource::overheadSize): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/runtime/JSCell.h trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp trunk/Source/_javascript_Core/runtime/JSGlobalData.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/RegExp.cpp trunk/Source/_javascript_Core/runtime/RegExp.h trunk/Source/_javascript_Core/runtime/RegExpCache.cpp trunk/Source/_javascript_Core/runtime/RegExpCache.h trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp trunk/Source/_javascript_Core/runtime/RegExpObject.cpp trunk/Source/_javascript_Core/runtime/RegExpObject.h trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp trunk/Source/_javascript_Core/runtime/RegExpPrototype.h trunk/Source/_javascript_Core/runtime/StringPrototype.cpp trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp trunk/Source/WebCore/bridge/qt/qt_runtime.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (87345 => 87346) --- trunk/Source/_javascript_Core/ChangeLog 2011-05-26 01:08:57 UTC (rev 87345) +++ trunk/Source/_javascript_Core/ChangeLog 2011-05-26 01:12:46 UTC (rev 87346) @@ -1,9 +1,5 @@ 2011-05-25 Oliver Hunt oli...@apple.com -Revert last change, something weird happened when I went to land. - -2011-05-25 Oliver Hunt oli...@apple.com - Reviewed by Geoffrey Garen. Make RegExp GC allocated Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (87345 => 87346) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-05-26 01:08:57 UTC (rev 87345) +++
