[webkit-changes] [89213] trunk
Title: [89213] trunk
Revision 89213
Author rob...@webkit.org
Date 2011-06-19 03:53:03 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Robert Hogan rob...@webkit.org
Reviewed by Alexey Proskuryakov.
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514
* platform/qt/Skipped: Unskip http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
2011-06-19 Robert Hogan rob...@webkit.org
Reviewed by Alexey Proskuryakov.
[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
https://bugs.webkit.org/show_bug.cgi?id=62514
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::WebCoreSynchronousLoader::willSendRequest):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/qt/ResourceHandleQt.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (89212 => 89213)
--- trunk/LayoutTests/ChangeLog 2011-06-19 04:13:49 UTC (rev 89212)
+++ trunk/LayoutTests/ChangeLog 2011-06-19 10:53:03 UTC (rev 89213)
@@ -1,3 +1,12 @@
+2011-06-19 Robert Hogan rob...@webkit.org
+
+Reviewed by Alexey Proskuryakov.
+
+[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
+https://bugs.webkit.org/show_bug.cgi?id=62514
+
+* platform/qt/Skipped: Unskip http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
+
2011-06-18 Yufeng Shen mile...@chromium.org
Reviewed by Darin Fisher.
Modified: trunk/LayoutTests/platform/qt/Skipped (89212 => 89213)
--- trunk/LayoutTests/platform/qt/Skipped 2011-06-19 04:13:49 UTC (rev 89212)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-06-19 10:53:03 UTC (rev 89213)
@@ -367,7 +367,6 @@
http/tests/xmlhttprequest/cache-override.html
http/tests/xmlhttprequest/cross-origin-authorization.html
http/tests/xmlhttprequest/cross-origin-no-authorization.html
-http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html
# === #
# Failing inserting tests. #
Modified: trunk/Source/WebCore/ChangeLog (89212 => 89213)
--- trunk/Source/WebCore/ChangeLog 2011-06-19 04:13:49 UTC (rev 89212)
+++ trunk/Source/WebCore/ChangeLog 2011-06-19 10:53:03 UTC (rev 89213)
@@ -1,3 +1,13 @@
+2011-06-19 Robert Hogan rob...@webkit.org
+
+Reviewed by Alexey Proskuryakov.
+
+[Qt] Qt Counterpart for http://trac.webkit.org/changeset/42078
+https://bugs.webkit.org/show_bug.cgi?id=62514
+
+* platform/network/qt/ResourceHandleQt.cpp:
+(WebCore::WebCoreSynchronousLoader::willSendRequest):
+
2011-06-18 Yufeng Shen mile...@chromium.org
Reviewed by Darin Fisher.
Modified: trunk/Source/WebCore/platform/network/qt/ResourceHandleQt.cpp (89212 => 89213)
--- trunk/Source/WebCore/platform/network/qt/ResourceHandleQt.cpp 2011-06-19 04:13:49 UTC (rev 89212)
+++ trunk/Source/WebCore/platform/network/qt/ResourceHandleQt.cpp 2011-06-19 10:53:03 UTC (rev 89213)
@@ -59,6 +59,7 @@
, m_data(data)
{}
+virtual void willSendRequest(ResourceHandle*, ResourceRequest, const ResourceResponse);
virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse response) { m_response = response; }
virtual void didReceiveData(ResourceHandle*, const char* data, int length, int) { m_data.append(data, length); }
virtual void didFinishLoading(ResourceHandle*, double /*finishTime*/) {}
@@ -69,6 +70,17 @@
Vectorchar m_data;
};
+void WebCoreSynchronousLoader::willSendRequest(ResourceHandle* handle, ResourceRequest request, const ResourceResponse /*redirectResponse*/)
+{
+// FIXME: This needs to be fixed to follow the redirect correctly even for cross-domain requests.
+if (!protocolHostAndPortAreEqual(handle-firstRequest().url(), request.url())) {
+ASSERT(m_error.isNull());
+m_error.setIsCancellation(true);
+request = ResourceRequest();
+return;
+}
+}
+
ResourceHandleInternal::~ResourceHandleInternal()
{
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89214] trunk/Source/WebCore
Title: [89214] trunk/Source/WebCore
Revision 89214
Author msab...@apple.com
Date 2011-06-19 05:55:20 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Michael Saboff msab...@apple.com
Reviewed by Darin Adler.
Add notify handler to trigger MemoryPressureHandler in all builds
https://bugs.webkit.org/show_bug.cgi?id=62679
Removed SIGUSR2 trigger and added a notify trigger for the
MemoryPressureHandler. The notify trigger is enabled for all builds.
No test added as only added new memory pressure trigger.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (89213 => 89214)
--- trunk/Source/WebCore/ChangeLog 2011-06-19 10:53:03 UTC (rev 89213)
+++ trunk/Source/WebCore/ChangeLog 2011-06-19 12:55:20 UTC (rev 89214)
@@ -1,3 +1,18 @@
+2011-06-19 Michael Saboff msab...@apple.com
+
+Reviewed by Darin Adler.
+
+Add notify handler to trigger MemoryPressureHandler in all builds
+https://bugs.webkit.org/show_bug.cgi?id=62679
+
+Removed SIGUSR2 trigger and added a notify trigger for the
+MemoryPressureHandler. The notify trigger is enabled for all builds.
+
+No test added as only added new memory pressure trigger.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::install):
+
2011-06-19 Robert Hogan rob...@webkit.org
Reviewed by Alexey Proskuryakov.
Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (89213 => 89214)
--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-06-19 10:53:03 UTC (rev 89213)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-06-19 12:55:20 UTC (rev 89214)
@@ -34,6 +34,7 @@
#if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD)
#import dispatch/dispatch.h
+#import notify.h
#ifndef DISPATCH_SOURCE_TYPE_VM
#define DISPATCH_SOURCE_TYPE_VM (_dispatch_source_type_vm)
@@ -51,12 +52,11 @@
#if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD)
static dispatch_source_t _cache_event_source = 0;
-#ifndef NDEBUG
-static dispatch_source_t _cache_event_source2 = 0;
-#endif
void MemoryPressureHandler::install()
{
+static int notifyToken;
+
if (m_installed)
return;
@@ -69,17 +69,8 @@
}
});
-#ifndef NDEBUG
-dispatch_async(dispatch_get_main_queue(), ^{
-_cache_event_source2 = dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGUSR2, 0, dispatch_get_main_queue());
-if (_cache_event_source2) {
-dispatch_set_context(_cache_event_source2, this);
-dispatch_source_set_event_handler(_cache_event_source2, ^{ memoryPressureHandler().respondToMemoryPressure();});
-dispatch_resume(_cache_event_source2);
-signal((int)SIGUSR2, SIG_IGN);
-}
-});
-#endif
+notify_register_dispatch(org.WebKit.lowMemory, notifyToken,
+ dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();});
m_installed = true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89217] trunk/Tools
Title: [89217] trunk/Tools
Revision 89217
Author senorbla...@chromium.org
Date 2011-06-19 11:16:52 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r89198.
http://trac.webkit.org/changeset/89198
https://bugs.webkit.org/show_bug.cgi?id=62953
Chromium breakage on Linux Tests (Requested by senorblanco
on #webkit).
* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (89216 => 89217)
--- trunk/Tools/ChangeLog 2011-06-19 17:00:27 UTC (rev 89216)
+++ trunk/Tools/ChangeLog 2011-06-19 18:16:52 UTC (rev 89217)
@@ -1,3 +1,16 @@
+2011-06-19 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r89198.
+http://trac.webkit.org/changeset/89198
+https://bugs.webkit.org/show_bug.cgi?id=62953
+
+Chromium breakage on Linux Tests (Requested by senorblanco
+on #webkit).
+
+* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
+* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
+* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
+
2011-06-18 Daniel Bates dba...@webkit.org
Reviewed by Eric Seidel.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py (89216 => 89217)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2011-06-19 17:00:27 UTC (rev 89216)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py 2011-06-19 18:16:52 UTC (rev 89217)
@@ -130,6 +130,30 @@
return self._get_modifier_char(test_name)
# override
+def _convert_json_to_current_version(self, results_json):
+archive_version = None
+if self.VERSION_KEY in results_json:
+archive_version = results_json[self.VERSION_KEY]
+
+super(JSONLayoutResultsGenerator,
+ self)._convert_json_to_current_version(results_json)
+
+# version 2-3
+if archive_version == 2:
+for results_for_builder in results_json.itervalues():
+try:
+test_results = results_for_builder[self.TESTS]
+except:
+continue
+
+for test in test_results:
+# Make sure all paths are relative
+test_path = self._get_path_relative_to_layout_test_root(test)
+if test_path != test:
+test_results[test_path] = test_results[test]
+del test_results[test]
+
+# override
def _insert_failure_summaries(self, results_for_builder):
summary = self._result_summary
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py (89216 => 89217)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2011-06-19 17:00:27 UTC (rev 89216)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py 2011-06-19 18:16:52 UTC (rev 89217)
@@ -67,33 +67,6 @@
json_string = _JSON_PREFIX + json_data + _JSON_SUFFIX
filesystem.write_text_file(file_path, json_string)
-
-def convert_trie_to_flat_paths(trie, prefix=None):
-Converts the directory structure in the given trie to flat paths, prepending a prefix to each.
-result = {}
-for name, data in trie.iteritems():
-if prefix:
-name = prefix + / + name
-
-if not results in data:
-result.update(convert_trie_to_flat_paths(data, name))
-else:
-result[name] = data
-
-return result
-
-
-def add_path_to_trie(path, value, trie):
-Inserts a single flat directory path and associated value into a directory trie structure.
-if not / in path:
-trie[path] = value
-return
-
-directory, slash, rest = path.partition(/)
-if not directory in trie:
-trie[directory] = {}
-add_path_to_trie(rest, value, trie[directory])
-
def test_timings_trie(port, individual_test_timings):
Breaks a filename into chunks by directory and puts the test time as a value in the lowest part, e.g.
foo/bar/baz.html: 1ms
@@ -115,8 +88,16 @@
# FIXME: Handle this better. Non-layout tests shouldn't be relativized.
test = test_result.filename
-
[webkit-changes] [89218] trunk/LayoutTests
Title: [89218] trunk/LayoutTests Revision 89218 Author senorbla...@chromium.org Date 2011-06-19 11:32:13 -0700 (Sun, 19 Jun 2011) Log Message 2011-06-19 Stephen White senorbla...@chromium.org Unreviewed. Marking several tests as crashing on Mac GPU. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (89217 => 89218) --- trunk/LayoutTests/ChangeLog 2011-06-19 18:16:52 UTC (rev 89217) +++ trunk/LayoutTests/ChangeLog 2011-06-19 18:32:13 UTC (rev 89218) @@ -1,3 +1,11 @@ +2011-06-19 Stephen White senorbla...@chromium.org + +Unreviewed. + +Marking several tests as crashing on Mac GPU. + +* platform/chromium/test_expectations.txt: + 2011-06-19 Robert Hogan rob...@webkit.org Reviewed by Alexey Proskuryakov. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (89217 => 89218) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-19 18:16:52 UTC (rev 89217) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-06-19 18:32:13 UTC (rev 89218) @@ -3966,3 +3966,7 @@ BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE PASS BUGCR86563 : fast/canvas/webgl/glsl-conformance.html = TEXT + +BUGCR86714 MAC GPU : compositing/tiling/huge-layer-resize.html = CRASH +BUGCR86714 MAC GPU : media/video-controls-rendering.html = CRASH +BUGCR86714 MAC GPU : media/video-zoom.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89219] trunk/Source/JavaScriptCore
Title: [89219] trunk/Source/_javascript_Core
Revision 89219
Author oli...@apple.com
Date 2011-06-19 12:47:45 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-17 Oliver Hunt oli...@apple.com
Reviewed by Gavin Barraclough.
JSONP is unnecessarily slow
https://bugs.webkit.org/show_bug.cgi?id=62920
JSONP has unfortunately become a fairly common idiom online, yet
it triggers very poor performance in JSC as we end up doing codegen
for a large number of property accesses that will
* only be run once, so the vast amount of logic we dump to handle
caching of accesses is unnecessary.
* We are doing codegen that is directly proportional to just
creating the object in the first place.
This patch extends the use of the literal parser to JSONP-like structures
in global code, handling a number of different forms I have seen online.
In an extreme case this improves performance of JSONP by more than 2x
due to removal of code generation and execution time, and a few optimisations
that I made to the parser itself.
* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):
* parser/Lexer.cpp:
(JSC::Lexer::isKeyword):
* parser/Lexer.h:
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
* runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse):
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):
(JSC::LiteralParser::makeIdentifier):
(JSC::LiteralParser::Lexer::lex):
(JSC::LiteralParser::Lexer::next):
(JSC::isSafeStringCharacter):
(JSC::LiteralParser::Lexer::lexString):
(JSC::LiteralParser::Lexer::lexNumber):
(JSC::LiteralParser::parse):
* runtime/LiteralParser.h:
(JSC::LiteralParser::LiteralParser):
(JSC::LiteralParser::tryLiteralParse):
(JSC::LiteralParser::Lexer::Lexer):
Modified Paths
trunk/Source/_javascript_Core/API/JSValueRef.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/parser/Lexer.cpp
trunk/Source/_javascript_Core/parser/Lexer.h
trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/runtime/LiteralParser.cpp
trunk/Source/_javascript_Core/runtime/LiteralParser.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSValueRef.cpp (89218 => 89219)
--- trunk/Source/_javascript_Core/API/JSValueRef.cpp 2011-06-19 18:32:13 UTC (rev 89218)
+++ trunk/Source/_javascript_Core/API/JSValueRef.cpp 2011-06-19 19:47:45 UTC (rev 89219)
@@ -234,7 +234,8 @@
{
ExecState* exec = toJS(ctx);
APIEntryShim entryShim(exec);
-LiteralParser parser(exec, string-ustring(), LiteralParser::StrictJSON);
+UString str = string-ustring();
+LiteralParser parser(exec, str.characters(), str.length(), LiteralParser::StrictJSON);
return toRef(exec, parser.tryLiteralParse());
}
Modified: trunk/Source/_javascript_Core/ChangeLog (89218 => 89219)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-19 18:32:13 UTC (rev 89218)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-19 19:47:45 UTC (rev 89219)
@@ -1,3 +1,50 @@
+2011-06-17 Oliver Hunt oli...@apple.com
+
+Reviewed by Gavin Barraclough.
+
+JSONP is unnecessarily slow
+https://bugs.webkit.org/show_bug.cgi?id=62920
+
+JSONP has unfortunately become a fairly common idiom online, yet
+it triggers very poor performance in JSC as we end up doing codegen
+for a large number of property accesses that will
+ * only be run once, so the vast amount of logic we dump to handle
+ caching of accesses is unnecessary.
+ * We are doing codegen that is directly proportional to just
+ creating the object in the first place.
+
+This patch extends the use of the literal parser to JSONP-like structures
+in global code, handling a number of different forms I have seen online.
+In an extreme case this improves performance of JSONP by more than 2x
+due to removal of code generation and execution time, and a few optimisations
+that I made to the parser itself.
+
+* API/JSValueRef.cpp:
+(JSValueMakeFromJSONString):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::callEval):
+(JSC::Interpreter::execute):
+* parser/Lexer.cpp:
+(JSC::Lexer::isKeyword):
+* parser/Lexer.h:
+* runtime/JSGlobalObjectFunctions.cpp:
+(JSC::globalFuncEval):
+* runtime/JSONObject.cpp:
+(JSC::JSONProtoFuncParse):
+* runtime/LiteralParser.cpp:
+
[webkit-changes] [89221] trunk/Source/WebCore
Title: [89221] trunk/Source/WebCore
Revision 89221
Author commit-qu...@webkit.org
Date 2011-06-19 13:48:17 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Una Sabovic una.sabo...@palm.com
Reviewed by Darin Adler.
Optimization: avoid call to clearRect() when bgColor is valid when painting the root background in RenderBoxModelObject::paintFillLayerExtended
https://bugs.webkit.org/show_bug.cgi?id=62908
When root layers base color is fully transparent backgroundRect was cleared before bgColor is applied.
Instead of clearing the rect we apply CompositeCopy operation when painting the background color.
No new tests. This is an optimization, it doesn't change any existing functionality.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):
* platform/graphics/GraphicsContext.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (89220 => 89221)
--- trunk/Source/WebCore/ChangeLog 2011-06-19 20:11:24 UTC (rev 89220)
+++ trunk/Source/WebCore/ChangeLog 2011-06-19 20:48:17 UTC (rev 89221)
@@ -1,3 +1,21 @@
+2011-06-19 Una Sabovic una.sabo...@palm.com
+
+Reviewed by Darin Adler.
+
+Optimization: avoid call to clearRect() when bgColor is valid when painting the root background in RenderBoxModelObject::paintFillLayerExtended
+https://bugs.webkit.org/show_bug.cgi?id=62908
+
+When root layers base color is fully transparent backgroundRect was cleared before bgColor is applied.
+Instead of clearing the rect we apply CompositeCopy operation when painting the background color.
+
+No new tests. This is an optimization, it doesn't change any existing functionality.
+
+* platform/graphics/GraphicsContext.cpp:
+(WebCore::GraphicsContext::fillRect):
+* platform/graphics/GraphicsContext.h:
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::paintFillLayerExtended):
+
2011-06-19 Dirk Schulze k...@webkit.org
Reviewed by Nikolas Zimmermann.
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (89220 => 89221)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2011-06-19 20:11:24 UTC (rev 89220)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2011-06-19 20:48:17 UTC (rev 89221)
@@ -613,6 +613,17 @@
generator.fill(this, rect);
}
+void GraphicsContext::fillRect(const FloatRect rect, const Color color, ColorSpace styleColorSpace, CompositeOperator op)
+{
+if (paintingDisabled())
+return;
+
+CompositeOperator previousOperator = compositeOperation();
+setCompositeOperation(op);
+fillRect(rect, color, styleColorSpace);
+setCompositeOperation(previousOperator);
+}
+
void GraphicsContext::fillRoundedRect(const RoundedIntRect rect, const Color color, ColorSpace colorSpace)
{
fillRoundedRect(rect.rect(), rect.radii().topLeft(), rect.radii().topRight(), rect.radii().bottomLeft(), rect.radii().bottomRight(), color, colorSpace);
Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.h (89220 => 89221)
--- trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2011-06-19 20:11:24 UTC (rev 89220)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext.h 2011-06-19 20:48:17 UTC (rev 89221)
@@ -293,6 +293,7 @@
void fillRect(const FloatRect);
void fillRect(const FloatRect, const Color, ColorSpace);
void fillRect(const FloatRect, Generator);
+void fillRect(const FloatRect, const Color, ColorSpace, CompositeOperator);
void fillRoundedRect(const IntRect, const IntSize topLeft, const IntSize topRight, const IntSize bottomLeft, const IntSize bottomRight, const Color, ColorSpace);
void fillRoundedRect(const RoundedIntRect, const Color, ColorSpace);
void fillRectWithRoundedHole(const IntRect, const RoundedIntRect roundedHoleRect, const Color, ColorSpace);
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (89220 => 89221)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-19 20:11:24 UTC (rev 89220)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2011-06-19 20:48:17 UTC (rev 89221)
@@ -742,22 +742,23 @@
backgroundRect.intersect(paintInfo.rect);
// If we have an alpha and we are painting the root element, go ahead and blend with the base background color.
Color baseColor;
+bool shouldClearBackground = false;
if (isOpaqueRoot) {
baseColor = view()-frameView()-baseBackgroundColor();
if (!baseColor.alpha())
-
[webkit-changes] [89224] trunk/Source/WebCore
Title: [89224] trunk/Source/WebCore Revision 89224 Author mr...@apple.com Date 2011-06-19 19:26:37 -0700 (Sun, 19 Jun 2011) Log Message Roll out r89223 since it appears to have broken all of the builds. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/DataTransferItem.cpp trunk/Source/WebCore/dom/DataTransferItem.h trunk/Source/WebCore/dom/DataTransferItems.cpp trunk/Source/WebCore/dom/DataTransferItems.h trunk/Source/WebCore/editing/CompositeEditCommand.cpp trunk/Source/WebCore/editing/CompositeEditCommand.h trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp trunk/Source/WebCore/inspector/InspectorCSSAgent.h trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorInstrumentation.h trunk/Source/WebCore/inspector/InspectorProfilerAgent.h trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp trunk/Source/WebCore/inspector/InspectorStyleSheet.h trunk/Source/WebCore/page/WebKitAnimationList.cpp trunk/Source/WebCore/page/WebKitAnimationList.h trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp trunk/Source/WebCore/svg/graphics/filters/SVGFilterBuilder.h trunk/Source/WebCore/websockets/ThreadableWebSocketChannelClientWrapper.cpp trunk/Source/WebCore/websockets/ThreadableWebSocketChannelClientWrapper.h trunk/Source/WebCore/websockets/WorkerThreadableWebSocketChannel.cpp trunk/Source/WebCore/websockets/WorkerThreadableWebSocketChannel.h Diff Modified: trunk/Source/WebCore/ChangeLog (89223 => 89224) --- trunk/Source/WebCore/ChangeLog 2011-06-19 21:07:33 UTC (rev 89223) +++ trunk/Source/WebCore/ChangeLog 2011-06-20 02:26:37 UTC (rev 89224) @@ -1,54 +1,3 @@ -2011-06-19 Darin Adler da...@apple.com - -Reviewed by Sam Weinig. - -RefPtr misused as argument type in a few classes -https://bugs.webkit.org/show_bug.cgi?id=62955 - -* dom/DataTransferItem.cpp: -(WebCore::DataTransferItem::DataTransferItem): -* dom/DataTransferItem.h: -* dom/DataTransferItems.cpp: -(WebCore::DataTransferItems::DataTransferItems): -* dom/DataTransferItems.h: -* editing/CompositeEditCommand.cpp: -(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): -* editing/CompositeEditCommand.h: -* inspector/InspectorConsoleInstrumentation.h: -* inspector/InspectorInstrumentation.cpp: -(WebCore::InspectorInstrumentation::addProfileImpl): -* inspector/InspectorInstrumentation.h: -* inspector/InspectorProfilerAgent.h: -* inspector/InspectorStyleSheet.cpp: -(WebCore::InspectorStyleSheet::inspectorStyleForId): -(WebCore::InspectorStyleSheet::rememberInspectorStyle): -* inspector/InspectorStyleSheet.h: -* page/WebKitAnimationList.cpp: -(WebCore::WebKitAnimationList::append): -(WebCore::WebKitAnimationList::insertAnimation): -* page/WebKitAnimationList.h: -* svg/graphics/filters/SVGFEImage.cpp: -(WebCore::FEImage::FEImage): -(WebCore::FEImage::create): -* svg/graphics/filters/SVGFEImage.h: -* svg/graphics/filters/SVGFilterBuilder.cpp: -(WebCore::SVGFilterBuilder::SVGFilterBuilder): -(WebCore::SVGFilterBuilder::add): -(WebCore::SVGFilterBuilder::appendEffectToEffectReferences): -* svg/graphics/filters/SVGFilterBuilder.h: -* websockets/ThreadableWebSocketChannelClientWrapper.cpp: -(WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback): -(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback): -(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback): -(WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback): -* websockets/ThreadableWebSocketChannelClientWrapper.h: -* websockets/WorkerThreadableWebSocketChannel.cpp: -(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer): -(WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel): -(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel): -* websockets/WorkerThreadableWebSocketChannel.h: -Use PassRefPtr or raw pointer as appropriate for RefPtr arguments. - 2011-06-19 Una Sabovic una.sabo...@palm.com Reviewed by Darin Adler. Modified: trunk/Source/WebCore/dom/DataTransferItem.cpp (89223 => 89224) --- trunk/Source/WebCore/dom/DataTransferItem.cpp 2011-06-19 21:07:33 UTC (rev 89223) +++ trunk/Source/WebCore/dom/DataTransferItem.cpp 2011-06-20 02:26:37 UTC (rev 89224) @@ -40,7 +40,7 @@ const char DataTransferItem::kindString[] = string; const char DataTransferItem::kindFile[] = file;
[webkit-changes] [89225] trunk/Source/WebKit/chromium
Title: [89225] trunk/Source/WebKit/chromium
Revision 89225
Author rn...@webkit.org
Date 2011-06-19 19:44:31 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Ryosuke Niwa rn...@webkit.org
Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (89224 => 89225)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-06-20 02:26:37 UTC (rev 89224)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-06-20 02:44:31 UTC (rev 89225)
@@ -1,3 +1,9 @@
+2011-06-19 Ryosuke Niwa rn...@webkit.org
+
+Rolled DEPS.
+
+* DEPS:
+
2011-06-18 Dimitri Glazkov dglaz...@chromium.org
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit/chromium/DEPS (89224 => 89225)
--- trunk/Source/WebKit/chromium/DEPS 2011-06-20 02:26:37 UTC (rev 89224)
+++ trunk/Source/WebKit/chromium/DEPS 2011-06-20 02:44:31 UTC (rev 89225)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '89567'
+ 'chromium_rev': '89636'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89226] trunk/Source/JavaScriptCore
Title: [89226] trunk/Source/_javascript_Core
Revision 89226
Author oli...@apple.com
Date 2011-06-19 19:57:36 -0700 (Sun, 19 Jun 2011)
Log Message
Minor fix to correct layout test results.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (89225 => 89226)
--- trunk/Source/_javascript_Core/ChangeLog 2011-06-20 02:44:31 UTC (rev 89225)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-06-20 02:57:36 UTC (rev 89226)
@@ -1,3 +1,10 @@
+2011-06-19 Oliver Hunt oli...@apple.com
+
+Minor fix to correct layout test results.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::execute):
+
2011-06-17 Oliver Hunt oli...@apple.com
Reviewed by Gavin Barraclough.
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (89225 => 89226)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-06-20 02:44:31 UTC (rev 89225)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-06-20 02:57:36 UTC (rev 89226)
@@ -770,8 +770,11 @@
case LiteralParser::JSONPPathEntryTypeDot: {
if (i == 0) {
PropertySlot slot(globalObject);
-if (!globalObject-getPropertySlot(callFrame, JSONPPath[i].m_pathEntryName, slot))
-return throwError(callFrame, createUndefinedVariableError(globalObject-globalExec(), JSONPPath[i].m_pathEntryName));
+if (!globalObject-getPropertySlot(callFrame, JSONPPath[i].m_pathEntryName, slot)) {
+if (i)
+return throwError(callFrame, createUndefinedVariableError(globalObject-globalExec(), JSONPPath[i].m_pathEntryName));
+goto failedJSONP;
+}
baseObject = slot.getValue(callFrame, JSONPPath[i].m_pathEntryName);
} else
baseObject = baseObject.get(callFrame, JSONPPath[i].m_pathEntryName);
@@ -812,7 +815,7 @@
}
return result;
}
-
+failedJSONP:
JSObject* error = program-compile(callFrame, scopeChain);
if (error)
return checkedReturn(throwError(callFrame, error));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [89227] trunk
Title: [89227] trunk
Revision 89227
Author commit-qu...@webkit.org
Date 2011-06-19 20:05:50 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* configure.ac:
2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
Unskipped the Media Stream tests.
* platform/gtk/Skipped:
2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* GNUmakefile.am:
2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
Reviewed by Martin Robinson.
[GTK] Enable Media Stream feature and make it default on
https://bugs.webkit.org/show_bug.cgi?id=60394
* Scripts/build-webkit:
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/configure.ac
Diff
Modified: trunk/ChangeLog (89226 => 89227)
--- trunk/ChangeLog 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/ChangeLog 2011-06-20 03:05:50 UTC (rev 89227)
@@ -1,3 +1,12 @@
+2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
+
+Reviewed by Martin Robinson.
+
+[GTK] Enable Media Stream feature and make it default on
+https://bugs.webkit.org/show_bug.cgi?id=60394
+
+* configure.ac:
+
2011-06-17 Joone Hur joone@collabora.co.uk
Reviewed by Martin Robinson.
Modified: trunk/LayoutTests/ChangeLog (89226 => 89227)
--- trunk/LayoutTests/ChangeLog 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/LayoutTests/ChangeLog 2011-06-20 03:05:50 UTC (rev 89227)
@@ -1,3 +1,14 @@
+2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
+
+Reviewed by Martin Robinson.
+
+[GTK] Enable Media Stream feature and make it default on
+https://bugs.webkit.org/show_bug.cgi?id=60394
+
+Unskipped the Media Stream tests.
+
+* platform/gtk/Skipped:
+
2011-06-19 Dirk Schulze k...@webkit.org
Uneviewed.
Modified: trunk/LayoutTests/platform/gtk/Skipped (89226 => 89227)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-06-20 03:05:50 UTC (rev 89227)
@@ -355,9 +355,6 @@
# Speech input is not yet enabled.
fast/speech
-# Media Stream API is not yet enabled.
-fast/dom/MediaStream
-
# Web Timing is not enabled.
# https://bugs.webkit.org/show_bug.cgi?id=42432
fast/dom/Window/window-properties-performance.html
Modified: trunk/Source/WebCore/ChangeLog (89226 => 89227)
--- trunk/Source/WebCore/ChangeLog 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/Source/WebCore/ChangeLog 2011-06-20 03:05:50 UTC (rev 89227)
@@ -1,3 +1,12 @@
+2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
+
+Reviewed by Martin Robinson.
+
+[GTK] Enable Media Stream feature and make it default on
+https://bugs.webkit.org/show_bug.cgi?id=60394
+
+* GNUmakefile.am:
+
2011-06-19 Una Sabovic una.sabo...@palm.com
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/GNUmakefile.am (89226 => 89227)
--- trunk/Source/WebCore/GNUmakefile.am 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/Source/WebCore/GNUmakefile.am 2011-06-20 03:05:50 UTC (rev 89227)
@@ -360,6 +360,16 @@
endif # END ENABLE_VIDEO_TRACK
#
+# Media Stream Support
+#
+if ENABLE_MEDIA_STREAM
+FEATURE_DEFINES += ENABLE_MEDIA_STREAM=1
+webcore_cppflags += -DENABLE_MEDIA_STREAM=1
+else
+webcore_cppflags += -DENABLE_MEDIA_STREAM=0
+endif # END ENABLE_MEDIA_STREAM
+
+#
# XHTML-MP Support
#
if ENABLE_XHTMLMP
Modified: trunk/Tools/ChangeLog (89226 => 89227)
--- trunk/Tools/ChangeLog 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/Tools/ChangeLog 2011-06-20 03:05:50 UTC (rev 89227)
@@ -1,3 +1,12 @@
+2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com
+
+Reviewed by Martin Robinson.
+
+[GTK] Enable Media Stream feature and make it default on
+https://bugs.webkit.org/show_bug.cgi?id=60394
+
+* Scripts/build-webkit:
+
2011-06-19 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r89198.
Modified: trunk/Tools/Scripts/build-webkit (89226 => 89227)
--- trunk/Tools/Scripts/build-webkit 2011-06-20 02:57:36 UTC (rev 89226)
+++ trunk/Tools/Scripts/build-webkit 2011-06-20 03:05:50 UTC (rev 89227)
@@ -228,8 +228,8 @@
{ option = media-statistics, desc = Toggle Media Statistics support,
define =
[webkit-changes] [89229] trunk
Title: [89229] trunk
Revision 89229
Author kei...@webkit.org
Date 2011-06-19 21:47:20 -0700 (Sun, 19 Jun 2011)
Log Message
2011-06-19 Keishi Hattori kei...@webkit.org
Reviewed by Kent Tamura.
Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262
* fast/forms/checkbox-click-indeterminate-expected.txt: Added.
* fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.
2011-06-19 Keishi Hattori kei...@webkit.org
Reviewed by Kent Tamura.
Clicking indeterminate checkbox should flip checkedness state
https://bugs.webkit.org/show_bug.cgi?id=62262
Test: fast/forms/checkbox-click-indeterminate.html
* html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick): Changed to flip checked flag when indeterminate.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/CheckboxInputType.cpp
Added Paths
trunk/LayoutTests/fast/forms/checkbox-click-indeterminate-expected.txt
trunk/LayoutTests/fast/forms/checkbox-click-indeterminate.html
Diff
Modified: trunk/LayoutTests/ChangeLog (89228 => 89229)
--- trunk/LayoutTests/ChangeLog 2011-06-20 03:50:36 UTC (rev 89228)
+++ trunk/LayoutTests/ChangeLog 2011-06-20 04:47:20 UTC (rev 89229)
@@ -1,3 +1,13 @@
+2011-06-19 Keishi Hattori kei...@webkit.org
+
+Reviewed by Kent Tamura.
+
+Clicking indeterminate checkbox should flip checkedness state
+https://bugs.webkit.org/show_bug.cgi?id=62262
+
+* fast/forms/checkbox-click-indeterminate-expected.txt: Added.
+* fast/forms/checkbox-click-indeterminate.html: Added. Tests behavior when clicking indeterminate checkbox.
+
2011-06-19 Oliver Hunt oli...@apple.com
Reviewed by Sam Weinig.
Added: trunk/LayoutTests/fast/forms/checkbox-click-indeterminate-expected.txt (0 => 89229)
--- trunk/LayoutTests/fast/forms/checkbox-click-indeterminate-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/checkbox-click-indeterminate-expected.txt 2011-06-20 04:47:20 UTC (rev 89229)
@@ -0,0 +1,20 @@
+This tests that clicking on indeterminate checkbox flips both checked/indeterminate states and calling preventDefault restores them.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Test if clicking on unchecked indeterminate checkbox flips both checked/indeterminate states
+PASS cb.checked is true
+PASS cb.indeterminate is false
+Test if clicking on checked indeterminate checkbox flips both checked/indeterminate states
+PASS cb.checked is false
+PASS cb.indeterminate is false
+Test if preventDefault restores the checked/indeterminate states
+PASS cb.checked is true
+PASS cb.indeterminate is false
+PASS cb.checked is false
+PASS cb.indeterminate is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/checkbox-click-indeterminate.html (0 => 89229)
--- trunk/LayoutTests/fast/forms/checkbox-click-indeterminate.html (rev 0)
+++ trunk/LayoutTests/fast/forms/checkbox-click-indeterminate.html 2011-06-20 04:47:20 UTC (rev 89229)
@@ -0,0 +1,47 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+var cb = document.createElement(input);
+document.body.appendChild(cb);
+cb.type = checkbox;
+
+description(This tests that clicking on indeterminate checkbox flips both checked/indeterminate states and calling preventDefault restores them.);
+
+debug(Test if clicking on unchecked indeterminate checkbox flips both checked/indeterminate states);
+cb.checked = false;
+cb.indeterminate = true;
+cb.click();
+shouldBeTrue('cb.checked');
+shouldBeFalse('cb.indeterminate');
+
+debug(Test if clicking on checked indeterminate checkbox flips both checked/indeterminate states);
+cb.checked = true;
+cb.indeterminate = true;
+cb.click();
+shouldBeFalse('cb.checked');
+shouldBeFalse('cb.indeterminate');
+
+debug(Test if preventDefault restores the checked/indeterminate states);
+cb.checked = false;
+cb.indeterminate = true;
+cb._onclick_ = function(e) {
+shouldBeTrue('cb.checked');
+shouldBeFalse('cb.indeterminate');
+e.preventDefault();
+};
+cb.click();
+shouldBeFalse('cb.checked');
+shouldBeTrue('cb.indeterminate');
+
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (89228 => 89229)
--- trunk/Source/WebCore/ChangeLog 2011-06-20 03:50:36 UTC (rev 89228)
+++ trunk/Source/WebCore/ChangeLog 2011-06-20 04:47:20 UTC (rev 89229)
@@ -1,3 +1,15 @@
+2011-06-19 Keishi Hattori kei...@webkit.org
+
+Reviewed by Kent Tamura.
+
+Clicking indeterminate checkbox should flip checkedness state
+
[webkit-changes] [89230] trunk
Title: [89230] trunk Revision 89230 Author morr...@google.com Date 2011-06-19 22:08:10 -0700 (Sun, 19 Jun 2011) Log Message 2011-06-19 MORITA Hajime morr...@google.com Reviewed by Dimitri Glazkov. The internals object should have createShadowContentElement() https://bugs.webkit.org/show_bug.cgi?id=62432 * Source/autotools/symbols.filter: Added some more symbols necessary for window.internals to function to the global symbol list. 2011-06-19 MORITA Hajime morr...@google.com Reviewed by Dimitri Glazkov. The internals object should have createShadowContentElement() https://bugs.webkit.org/show_bug.cgi?id=62432 * fast/dom/shadow/create-content-element-expected.txt: Added. * fast/dom/shadow/create-content-element.html: Added. 2011-06-19 MORITA Hajime morr...@google.com Reviewed by Dimitri Glazkov. The internals object should have createShadowContentElement() https://bugs.webkit.org/show_bug.cgi?id=62432 This change: - added Internals::createShadowContentElement(), which creates, ShadowContentElement instance which includes all host children, - added Internals::elementRenderTreeAsText() to help content layout testing, and - Unabstracted ShadowContentElement by giving a default shouldInclude() implementation. Test: fast/dom/shadow/create-content-element.html * WebCore.exp.in: * dom/ShadowContentElement.cpp: (WebCore::ShadowContentElement::create): Added. (WebCore::ShadowContentElement::ShadowContentElement): (WebCore::ShadowContentElement::~ShadowContentElement): (WebCore::ShadowContentElement::shouldInclude): Gave a default implementation which always returns true. * dom/ShadowContentElement.h: * html/HTMLSummaryElement.cpp: (WebCore::SummaryContentElement::SummaryContentElement): * rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Factored out for supportin per-element render tree dump. * rendering/RenderTreeAsText.h: * testing/Internals.cpp: (WebCore::Internals::createShadowContentElement): Added. (WebCore::Internals::elementRenderTreeAsText): dded. * testing/Internals.h: * testing/Internals.idl: 2011-06-19 MORITA Hajime morr...@google.com Reviewed by Dimitri Glazkov. The internals object should have createShadowContentElement() https://bugs.webkit.org/show_bug.cgi?id=62432 * win/WebKit2.def: Added some more symbols necessary for window.internals to function to the global symbol list. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/dom/ShadowContentElement.cpp trunk/Source/WebCore/dom/ShadowContentElement.h trunk/Source/WebCore/html/HTMLSummaryElement.cpp trunk/Source/WebCore/rendering/RenderTreeAsText.cpp trunk/Source/WebCore/rendering/RenderTreeAsText.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/win/WebKit2.def trunk/Source/autotools/symbols.filter Added Paths trunk/LayoutTests/fast/dom/shadow/create-content-element-expected.txt trunk/LayoutTests/fast/dom/shadow/create-content-element.html Diff Modified: trunk/ChangeLog (89229 => 89230) --- trunk/ChangeLog 2011-06-20 04:47:20 UTC (rev 89229) +++ trunk/ChangeLog 2011-06-20 05:08:10 UTC (rev 89230) @@ -1,3 +1,14 @@ +2011-06-19 MORITA Hajime morr...@google.com + +Reviewed by Dimitri Glazkov. + +The internals object should have createShadowContentElement() +https://bugs.webkit.org/show_bug.cgi?id=62432 + +* Source/autotools/symbols.filter: Added some more symbols necessary for +window.internals to function to the global symbol list. + + 2011-06-19 Adam Bergkvist adam.bergkv...@ericsson.com Reviewed by Martin Robinson. Modified: trunk/LayoutTests/ChangeLog (89229 => 89230) --- trunk/LayoutTests/ChangeLog 2011-06-20 04:47:20 UTC (rev 89229) +++ trunk/LayoutTests/ChangeLog 2011-06-20 05:08:10 UTC (rev 89230) @@ -1,3 +1,13 @@ +2011-06-19 MORITA Hajime morr...@google.com + +Reviewed by Dimitri Glazkov. + +The internals object should have createShadowContentElement() +https://bugs.webkit.org/show_bug.cgi?id=62432 + +* fast/dom/shadow/create-content-element-expected.txt: Added. +* fast/dom/shadow/create-content-element.html: Added. + 2011-06-19 Keishi Hattori kei...@webkit.org Reviewed by Kent Tamura. Added: trunk/LayoutTests/fast/dom/shadow/create-content-element-expected.txt (0 => 89230) --- trunk/LayoutTests/fast/dom/shadow/create-content-element-expected.txt (rev 0) +++
