[webkit-changes] [90313] trunk
Title: [90313] trunk Revision 90313 Author tk...@chromium.org Date 2011-07-01 23:00:50 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Kent Tamura [Chromium] Rebaseline for fast/forms/input-file-re-render.html https://bugs.webkit.org/show_bug.cgi?id=63733 Also, input-file-label.html passes now. * platform/chromium-linux/fast/forms/input-file-re-render-expected.png: * platform/chromium-linux/fast/forms/input-file-re-render-expected.txt: * platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png: * platform/chromium-mac/fast/forms/input-file-re-render-expected.png: * platform/chromium-win/fast/forms/input-file-re-render-expected.png: * platform/chromium-win/fast/forms/input-file-re-render-expected.txt: * platform/chromium/test_expectations.txt: 2011-07-01 Kent Tamura [Chromium] Rebaseline for fast/forms/input-file-re-render.html https://bugs.webkit.org/show_bug.cgi?id=63733 * DEPS: Update chromium revision to 91405 to have "Choose Files" string. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.png trunk/LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/forms/input-file-re-render-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png trunk/LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.png trunk/LayoutTests/platform/chromium-win/fast/forms/input-file-re-render-expected.txt trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/DEPS Diff Modified: trunk/LayoutTests/ChangeLog (90312 => 90313) --- trunk/LayoutTests/ChangeLog 2011-07-02 04:47:40 UTC (rev 90312) +++ trunk/LayoutTests/ChangeLog 2011-07-02 06:00:50 UTC (rev 90313) @@ -1,5 +1,20 @@ 2011-07-01 Kent Tamura +[Chromium] Rebaseline for fast/forms/input-file-re-render.html +https://bugs.webkit.org/show_bug.cgi?id=63733 + +Also, input-file-label.html passes now. + +* platform/chromium-linux/fast/forms/input-file-re-render-expected.png: +* platform/chromium-linux/fast/forms/input-file-re-render-expected.txt: +* platform/chromium-mac-leopard/fast/forms/input-file-re-render-expected.png: +* platform/chromium-mac/fast/forms/input-file-re-render-expected.png: +* platform/chromium-win/fast/forms/input-file-re-render-expected.png: +* platform/chromium-win/fast/forms/input-file-re-render-expected.txt: +* platform/chromium/test_expectations.txt: + +2011-07-01 Kent Tamura + [Chromium] Update the expectation of search-rtl.html https://bugs.webkit.org/show_bug.cgi?id=63787 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90312 => 90313) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-02 04:47:40 UTC (rev 90312) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-02 06:00:50 UTC (rev 90313) @@ -216,18 +216,6 @@ // Unskip after implementing LayoutTestController::setDefersLoading and ::goBack. BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL -// This test fails because WebLocalizedString::FileButtonChooseMultipleFilesLabel -// is not described in switch cases in ToMessageID(), in order to avoid compiler warnings -// in the Chromium patch. See here: http://codereview.chromium.org/7273024/. -// This failure is going to be removed when a planned Chromium patch is merged. -BUGWK49245 : fast/forms/input-file-label.html = FAIL - -// This test fails because the label of a multiple file chooser button is updated. -// We need to update expected.txt and expected.png. -BUGWK49245 WIN LINUX : fast/forms/input-file-re-render.html = FAIL -// Timing out on mac as of WebKit r90101. -BUGWK63733 MAC : fast/forms/input-file-re-render.html = TIMEOUT - // - // WONTFIX TESTS // - @@ -2338,11 +2326,8 @@ BUGWK45652 : fast/viewport/viewport-129.html = TEXT TIMEOUT MISSING -BUGWK45667 WIN LINUX : fast/files/read-file-async.html = CRASH PASS +BUGWK45667 : fast/files/read-file-async.html = CRASH PASS BUGWK45667 LINUX : fast/files/read-blob-async.html = CRASH PASS -// Timing out on mac as of WebKit r90101. -BUGWK63733 MAC : fast/files/read-file-async.html = TIMEOUT -BUGWK63733 MAC : fast/files/read-blob-async.html = TIMEOUT BUGWK45737 DEBUG SLOW : fast/frames/frame-limit.html = PASS Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/fast/forms/input-file-re-render-expected.txt (90312 => 90313) --- t
[webkit-changes] [90312] trunk/LayoutTests
Title: [90312] trunk/LayoutTests
Revision 90312
Author tk...@chromium.org
Date 2011-07-01 21:47:40 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Kent Tamura
[Chromium] Update the expectation of search-rtl.html
https://bugs.webkit.org/show_bug.cgi?id=63787
* platform/chromium-win/fast/forms/search-rtl-expected.txt:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-win/fast/forms/search-rtl-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90311 => 90312)
--- trunk/LayoutTests/ChangeLog 2011-07-02 04:45:24 UTC (rev 90311)
+++ trunk/LayoutTests/ChangeLog 2011-07-02 04:47:40 UTC (rev 90312)
@@ -1,3 +1,11 @@
+2011-07-01 Kent Tamura
+
+[Chromium] Update the expectation of search-rtl.html
+https://bugs.webkit.org/show_bug.cgi?id=63787
+
+* platform/chromium-win/fast/forms/search-rtl-expected.txt:
+* platform/chromium/test_expectations.txt:
+
2011-07-01 Ryosuke Niwa
Remove GTK baseline added in r90294 since the test was fixed in r90309.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90311 => 90312)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-02 04:45:24 UTC (rev 90311)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-02 04:47:40 UTC (rev 90312)
@@ -3745,8 +3745,6 @@
BUGWK60931 DEBUG : http/tests/security/_javascript_URL/xss-ALLOWED-from-_javascript_-url-window-open.html = CRASH
BUGWK60931 DEBUG : http/tests/security/_javascript_URL/xss-ALLOWED-to-_javascript_-url-window-open.html = CRASH
-BUGWK63787 WIN LINUX : fast/forms/search-rtl.html = IMAGE+TEXT IMAGE
-
// Flaky since added by r86478
BUGCR82881 : http/tests/appcache/interrupted-update.html = PASS TEXT
Modified: trunk/LayoutTests/platform/chromium-win/fast/forms/search-rtl-expected.txt (90311 => 90312)
--- trunk/LayoutTests/platform/chromium-win/fast/forms/search-rtl-expected.txt 2011-07-02 04:45:24 UTC (rev 90311)
+++ trunk/LayoutTests/platform/chromium-win/fast/forms/search-rtl-expected.txt 2011-07-02 04:47:40 UTC (rev 90312)
@@ -39,8 +39,8 @@
RenderBlock {DIV} at (139,3) size 9x9
RenderText {#text} at (0,0) size 0x0
RenderBlock {P} at (0,130) size 784x20
-RenderText {#text} at (0,0) size 34x19
- text run at (0,0) width 34: "FAIL"
+RenderText {#text} at (0,0) size 38x19
+ text run at (0,0) width 38: "PASS"
layer at (36,49) size 116x16 scrollX 28 scrollWidth 144
RenderBlock {DIV} at (0,0) size 116x16
RenderText {#text} at (-28,0) size 143x16
@@ -59,6 +59,4 @@
text run at (136,0) width 39 RTL: "\x{5D4}\x{5D5}\x{5D0} \x{5D6}\x{5D4} "
layer at (36,101) size 116x16
RenderBlock {DIV} at (0,0) size 116x16
-RenderText {#text} at (7,0) size 108x16
- text run at (7,0) width 108: "click the (x) button"
-caret: position 0 of child 0 {#text} of child 0 {DIV} of child 1 {DIV} of child 0 {DIV} of {#shadow-root} of child 9 {INPUT} of child 3 {P} of body
+caret: position 0 of child 0 {DIV} of child 1 {DIV} of child 0 {DIV} of {#shadow-root} of child 9 {INPUT} of child 3 {P} of body
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90311] trunk/LayoutTests
Title: [90311] trunk/LayoutTests Revision 90311 Author rn...@webkit.org Date 2011-07-01 21:45:24 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Ryosuke Niwa Remove GTK baseline added in r90294 since the test was fixed in r90309. (File name was wrong. It was supposed to be -expected.txt) * platform/gtk/editing/selection/directionality-after-undo-replace.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html Diff Modified: trunk/LayoutTests/ChangeLog (90310 => 90311) --- trunk/LayoutTests/ChangeLog 2011-07-02 02:38:16 UTC (rev 90310) +++ trunk/LayoutTests/ChangeLog 2011-07-02 04:45:24 UTC (rev 90311) @@ -1,5 +1,12 @@ 2011-07-01 Ryosuke Niwa +Remove GTK baseline added in r90294 since the test was fixed in r90309. +(File name was wrong. It was supposed to be -expected.txt) + +* platform/gtk/editing/selection/directionality-after-undo-replace.html: Removed. + +2011-07-01 Ryosuke Niwa + [GTK] editing/selection/directionality-after-undo-replace.html is failing https://bugs.webkit.org/show_bug.cgi?id=63853 Deleted: trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html (90310 => 90311) --- trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html 2011-07-02 02:38:16 UTC (rev 90310) +++ trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html 2011-07-02 04:45:24 UTC (rev 90311) @@ -1,10 +0,0 @@ -This tests WebKit preserves non-directional selection after unapplying replacement on Mac. To manually test on Mac, - -Select "world" by double-clicking the word -Replace "world" by a character by pressing a key -Undo -Extend selection to the left -" world" should be selected. - -hello world WebKit -FAIL - expected " world" but got "o" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90310] trunk/Tools
Title: [90310] trunk/Tools
Revision 90310
Author aba...@webkit.org
Date 2011-07-01 19:38:16 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Fix typo in master.cfg, hoping to trigger a master restart.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (90309 => 90310)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-02 02:34:52 UTC (rev 90309)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-02 02:38:16 UTC (rev 90310)
@@ -215,7 +215,7 @@
self.setCommand(self.command + rootArgument)
return shell.Test.start(self)
-def _parseOldRunWebKitTestsOutput(self):
+def _parseOldRunWebKitTestsOutput(self, logText):
incorrectLayoutLines = []
for line in logText.splitlines():
if line.find('had incorrect layout') >= 0 or line.find('were new') >= 0 or line.find('was new') >= 0:
@@ -231,7 +231,7 @@
self.incorrectLayoutLines = incorrectLayoutLines
-def _parseNewRunWebKitTestsOutput(self):
+def _parseNewRunWebKitTestsOutput(self, logText):
incorrectLayoutLines = []
expressions = {
'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
Modified: trunk/Tools/ChangeLog (90309 => 90310)
--- trunk/Tools/ChangeLog 2011-07-02 02:34:52 UTC (rev 90309)
+++ trunk/Tools/ChangeLog 2011-07-02 02:38:16 UTC (rev 90310)
@@ -1,5 +1,11 @@
2011-07-01 Adam Barth
+Fix typo in master.cfg, hoping to trigger a master restart.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
+2011-07-01 Adam Barth
+
Turn off new-run-webkit-tests and remove some debug logging.
* Scripts/run-webkit-tests:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90309] trunk/LayoutTests
Title: [90309] trunk/LayoutTests
Revision 90309
Author rn...@webkit.org
Date 2011-07-01 19:34:52 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Ryosuke Niwa
[GTK] editing/selection/directionality-after-undo-replace.html is failing
https://bugs.webkit.org/show_bug.cgi?id=63853
Reviewed by Ojan Vafai.
Don't do leapForward between mouseDown and mouseUp so that GTK recognizes the double-click.
* editing/selection/directionality-after-undo-replace.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90308 => 90309)
--- trunk/LayoutTests/ChangeLog 2011-07-02 02:20:16 UTC (rev 90308)
+++ trunk/LayoutTests/ChangeLog 2011-07-02 02:34:52 UTC (rev 90309)
@@ -1,3 +1,14 @@
+2011-07-01 Ryosuke Niwa
+
+[GTK] editing/selection/directionality-after-undo-replace.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=63853
+
+Reviewed by Ojan Vafai.
+
+Don't do leapForward between mouseDown and mouseUp so that GTK recognizes the double-click.
+
+* editing/selection/directionality-after-undo-replace.html:
+
2011-07-01 Kent Tamura
Reviewed by Tony Chang.
Modified: trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html (90308 => 90309)
--- trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html 2011-07-02 02:20:16 UTC (rev 90308)
+++ trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html 2011-07-02 02:34:52 UTC (rev 90309)
@@ -23,12 +23,11 @@
var test = document.getElementById('target');
eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth / 2, target.offsetTop + target.offsetHeight / 2);
eventSender.mouseDown();
-eventSender.leapForward(200);
eventSender.mouseUp();
eventSender.leapForward(200);
+
eventSender.mouseDown();
-eventSender.leapForward(200);
eventSender.mouseUp();
document.execCommand('InsertText', false, 'a');
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90308] trunk/Source
Title: [90308] trunk/Source
Revision 90308
Author micha...@google.com
Date 2011-07-01 19:20:16 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Michael Nordman
Reviewed by Darin Fisher.
[Chromium] FileSystem API can be used to learn about installed software on the user's computer
https://bugs.webkit.org/show_bug.cgi?id=63220
* public/WebMimeRegistry.h:
(WebKit::WebMimeRegistry::wellKnownMimeTypeForExtension):
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::wellKnownMimeTypeForExtension):
2011-07-01 Michael Nordman
Reviewed by Darin Fisher.
[Chromium] FileSystem API can be used to learn about installed software on the user's computer.
Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
without consulting the OS/registry.
https://bugs.webkit.org/show_bug.cgi?id=63220
No new tests, existing layout tests that invoke file.type apply.
* fileapi/File.cpp: Refactored the factory methods.
(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileSystemFile):
(WebCore::File::File):
* platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method.
(WebCore::mediaMIMETypeMap):
(WebCore::findMimeType):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
* platform/MIMETypeRegistry.h:
* platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method.
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
(WebCore::findMimeType):
* platform/chromium/PlatformBridge.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/File.cpp
trunk/Source/WebCore/platform/MIMETypeRegistry.cpp
trunk/Source/WebCore/platform/MIMETypeRegistry.h
trunk/Source/WebCore/platform/chromium/MIMETypeRegistryChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformBridge.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebMimeRegistry.h
trunk/Source/WebKit/chromium/src/PlatformBridge.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90307 => 90308)
--- trunk/Source/WebCore/ChangeLog 2011-07-02 01:05:59 UTC (rev 90307)
+++ trunk/Source/WebCore/ChangeLog 2011-07-02 02:20:16 UTC (rev 90308)
@@ -1,3 +1,30 @@
+2011-07-01 Michael Nordman
+
+Reviewed by Darin Fisher.
+
+[Chromium] FileSystem API can be used to learn about installed software on the user's computer.
+Added a new MIMETypeRegistry method to return a type based on a well known set of mappings
+without consulting the OS/registry.
+https://bugs.webkit.org/show_bug.cgi?id=63220
+
+No new tests, existing layout tests that invoke file.type apply.
+
+* fileapi/File.cpp: Refactored the factory methods.
+(WebCore::createBlobDataForFileWithType):
+(WebCore::createBlobDataForFile):
+(WebCore::createBlobDataForFileSystemFile):
+(WebCore::File::File):
+* platform/MIMETypeRegistry.cpp: Added getWellKnownMIMETypeForExtension() method.
+(WebCore::mediaMIMETypeMap):
+(WebCore::findMimeType):
+(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
+* platform/MIMETypeRegistry.h:
+* platform/chromium/MIMETypeRegistryChromium.cpp: Added getWellKnownMIMETypeForExtension() method.
+(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+(WebCore::MIMETypeRegistry::getWellKnownMIMETypeForExtension):
+(WebCore::findMimeType):
+* platform/chromium/PlatformBridge.h:
+
2011-07-01 Tim Horton
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/fileapi/File.cpp (90307 => 90308)
--- trunk/Source/WebCore/fileapi/File.cpp 2011-07-02 01:05:59 UTC (rev 90307)
+++ trunk/Source/WebCore/fileapi/File.cpp 2011-07-02 02:20:16 UTC (rev 90308)
@@ -33,20 +33,34 @@
namespace WebCore {
-static PassOwnPtr createBlobDataForFile(const String& path, const String& name = String())
+static PassOwnPtr createBlobDataForFileWithType(const String& path, const String& contentType)
{
-String type;
-const String& nameForMIMEType = !name.isEmpty() ? name : path;
-int index = nameForMIMEType.reverseFind('.');
-if (index != -1)
-type = MIMETypeRegistry::getMIMETypeForExtension(nameForMIMEType.substring(index + 1));
-
OwnPtr blobData = BlobData::create();
-blobData->setContentType(type);
+blobData->setContentType(contentType);
blobData->appendFile(path);
return blobData.release();
}
+static PassOwnPtr createBlobDataForFile(const String& path)
+{
+String type;
+int index = path.reverseFind('.');
+if (index != -1)
+type = MIMETypeRegistry::getMIMETypeForExtension(path.substri
[webkit-changes] [90307] trunk/Source/WebCore
Title: [90307] trunk/Source/WebCore
Revision 90307
Author commit-qu...@webkit.org
Date 2011-07-01 18:05:59 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Tim Horton
Reviewed by Darin Adler.
SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
https://bugs.webkit.org/show_bug.cgi?id=54325
Add image/svg+xml to the list of acceptable MIME types for the Image type.
* inspector/front-end/inspector.js:
(WebInspector):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (90306 => 90307)
--- trunk/Source/WebCore/ChangeLog 2011-07-02 00:55:59 UTC (rev 90306)
+++ trunk/Source/WebCore/ChangeLog 2011-07-02 01:05:59 UTC (rev 90307)
@@ -2,6 +2,18 @@
Reviewed by Darin Adler.
+SVG data:image/svg+xml;base64 URLs inside CSS throw mime type warning
+https://bugs.webkit.org/show_bug.cgi?id=54325
+
+Add image/svg+xml to the list of acceptable MIME types for the Image type.
+
+* inspector/front-end/inspector.js:
+(WebInspector):
+
+2011-07-01 Tim Horton
+
+Reviewed by Darin Adler.
+
Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (90306 => 90307)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2011-07-02 00:55:59 UTC (rev 90306)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2011-07-02 01:05:59 UTC (rev 90307)
@@ -1601,6 +1601,7 @@
"image/png": {2: true},
"image/gif": {2: true},
"image/bmp": {2: true},
+"image/svg+xml": {2: true},
"image/vnd.microsoft.icon":{2: true},
"image/x-icon":{2: true},
"image/x-xbitmap": {2: true},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90306] trunk/LayoutTests
Title: [90306] trunk/LayoutTests Revision 90306 Author tk...@chromium.org Date 2011-07-01 17:55:59 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Kent Tamura Reviewed by Tony Chang. Use common functions in fast/forms/search-rtl.html https://bugs.webkit.org/show_bug.cgi?id=63787 * fast/forms/search-rtl.html: Use searchCancelButtonPosition() to make this work on Chromium Windows and Chromium Linux. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/search-rtl.html trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90305 => 90306) --- trunk/LayoutTests/ChangeLog 2011-07-02 00:45:09 UTC (rev 90305) +++ trunk/LayoutTests/ChangeLog 2011-07-02 00:55:59 UTC (rev 90306) @@ -1,3 +1,14 @@ +2011-07-01 Kent Tamura + +Reviewed by Tony Chang. + +Use common functions in fast/forms/search-rtl.html +https://bugs.webkit.org/show_bug.cgi?id=63787 + +* fast/forms/search-rtl.html: Use searchCancelButtonPosition() to make + this work on Chromium Windows and Chromium Linux. +* platform/chromium/test_expectations.txt: + 2011-07-01 Sam Weinig Reduce parser nesting cap to 512 Modified: trunk/LayoutTests/fast/forms/search-rtl.html (90305 => 90306) --- trunk/LayoutTests/fast/forms/search-rtl.html 2011-07-02 00:45:09 UTC (rev 90305) +++ trunk/LayoutTests/fast/forms/search-rtl.html 2011-07-02 00:55:59 UTC (rev 90306) @@ -1,6 +1,7 @@ +
[webkit-changes] [90305] trunk/Tools
Title: [90305] trunk/Tools
Revision 90305
Author aba...@webkit.org
Date 2011-07-01 17:45:09 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Turn off new-run-webkit-tests and remove some debug logging.
* Scripts/run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/http_lock.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py
Diff
Modified: trunk/Tools/ChangeLog (90304 => 90305)
--- trunk/Tools/ChangeLog 2011-07-02 00:43:45 UTC (rev 90304)
+++ trunk/Tools/ChangeLog 2011-07-02 00:45:09 UTC (rev 90305)
@@ -1,5 +1,12 @@
2011-07-01 Adam Barth
+Turn off new-run-webkit-tests and remove some debug logging.
+
+* Scripts/run-webkit-tests:
+* Scripts/webkitpy/layout_tests/port/http_lock.py:
+
+2011-07-01 Adam Barth
+
Add some more debug logging to try to understand why we're getting
stuck acquring the HTTP lock.
Modified: trunk/Tools/Scripts/run-webkit-tests (90304 => 90305)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-02 00:43:45 UTC (rev 90304)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-02 00:45:09 UTC (rev 90305)
@@ -69,7 +69,7 @@
# new-run-webkit-tests by default.
# Example: return runningOnBuildBot() && isLeopard();
# would enable new-run-webkit-tests on only the leopard buildbots.
-return (isSnowLeopard() and !usingWebKit2());
+return 0;
}
my $harnessName = "old-run-webkit-tests";
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py (90304 => 90305)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py 2011-07-02 00:43:45 UTC (rev 90304)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py 2011-07-02 00:45:09 UTC (rev 90305)
@@ -104,7 +104,6 @@
_log.debug("OSError: %s" % e)
return
result = int(current_pid)
-_log.debug("Current lock pid: %s" % result)
return result
def _create_lock_file(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90304] trunk/Source/WebCore
Title: [90304] trunk/Source/WebCore
Revision 90304
Author commit-qu...@webkit.org
Date 2011-07-01 17:43:45 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Tim Horton
Reviewed by Darin Adler.
Errors encountered within SVG documents should be reported to the console
https://bugs.webkit.org/show_bug.cgi?id=62599
Add SVGElement::reportAttributeParsingError, which will
write a Web Inspector console message if passed an SVGParsingError
and the attribute which was being applied, only in the case where
there is actually an error.
Include the SVG document's URI when writing to the Web Inspector
console, so that the UI displays both the filename and the line number.
* svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
* svg/SVGElement.cpp:
(WebCore::SVGElement::reportAttributeParsingError):
* svg/SVGElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (90303 => 90304)
--- trunk/Source/WebCore/ChangeLog 2011-07-02 00:26:38 UTC (rev 90303)
+++ trunk/Source/WebCore/ChangeLog 2011-07-02 00:43:45 UTC (rev 90304)
@@ -1,3 +1,24 @@
+2011-07-01 Tim Horton
+
+Reviewed by Darin Adler.
+
+Errors encountered within SVG documents should be reported to the console
+https://bugs.webkit.org/show_bug.cgi?id=62599
+
+Add SVGElement::reportAttributeParsingError, which will
+write a Web Inspector console message if passed an SVGParsingError
+and the attribute which was being applied, only in the case where
+there is actually an error.
+
+Include the SVG document's URI when writing to the Web Inspector
+console, so that the UI displays both the filename and the line number.
+
+* svg/SVGDocumentExtensions.cpp:
+(WebCore::reportMessage):
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::reportAttributeParsingError):
+* svg/SVGElement.h:
+
2011-07-01 Scott Byer
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp (90303 => 90304)
--- trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp 2011-07-02 00:26:38 UTC (rev 90303)
+++ trunk/Source/WebCore/svg/SVGDocumentExtensions.cpp 2011-07-02 00:43:45 UTC (rev 90304)
@@ -198,7 +198,7 @@
static void reportMessage(Document* document, MessageLevel level, const String& message)
{
if (Frame* frame = document->frame())
-frame->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, level, message, parserLineNumber(document), String());
+frame->domWindow()->console()->addMessage(JSMessageSource, LogMessageType, level, message, parserLineNumber(document), document->documentURI());
}
void SVGDocumentExtensions::reportWarning(const String& message)
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (90303 => 90304)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2011-07-02 00:26:38 UTC (rev 90303)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2011-07-02 00:43:45 UTC (rev 90304)
@@ -103,6 +103,28 @@
return data;
}
+void SVGElement::reportAttributeParsingError(SVGParsingError error, Attribute* attribute)
+{
+if (error == NoError)
+return;
+
+String errorString = "<" + tagName() + "> attribute " + attribute->name().toString() + "=\"" + attribute->value() + "\"";
+SVGDocumentExtensions* extensions = document()->accessSVGExtensions();
+
+if (error == NegativeValueForbiddenError) {
+extensions->reportError("Invalid negative value for " + errorString);
+return;
+}
+
+if (error == ParsingAttributeFailedError) {
+extensions->reportError("Invalid value for " + errorString);
+return;
+}
+
+ASSERT_NOT_REACHED();
+}
+
+
bool SVGElement::isSupported(StringImpl* feature, StringImpl* version) const
{
return DOMImplementation::hasFeature(feature, version);
Modified: trunk/Source/WebCore/svg/SVGElement.h (90303 => 90304)
--- trunk/Source/WebCore/svg/SVGElement.h 2011-07-02 00:26:38 UTC (rev 90303)
+++ trunk/Source/WebCore/svg/SVGElement.h 2011-07-02 00:43:45 UTC (rev 90304)
@@ -49,6 +49,12 @@
AnimatedUnknown
};
+enum SVGParsingError {
+NoError,
+ParsingAttributeFailedError,
+NegativeValueForbiddenError
+};
+
typedef HashMap AttributeToPropertyTypeMap;
class CSSCursorImageValue;
@@ -123,6 +129,8 @@
SVGElementRareData* rareSVGData() const;
SVGElementRareData* ensureRareSVGData();
+void reportAttributeParsingError(SVGParsingError, Attribute*);
+
private:
friend class SVGElementInstance;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90303] trunk/Source
Title: [90303] trunk/Source
Revision 90303
Author commit-qu...@webkit.org
Date 2011-07-01 17:26:38 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Scott Byer
Reviewed by Adam Barth.
Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770
Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace
Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):
2011-07-01 Scott Byer
Reviewed by Adam Barth.
Smooth scrolling fixes
https://bugs.webkit.org/show_bug.cgi?id=63770
Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
scroll animation code.
* tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90302 => 90303)
--- trunk/Source/WebCore/ChangeLog 2011-07-02 00:16:52 UTC (rev 90302)
+++ trunk/Source/WebCore/ChangeLog 2011-07-02 00:26:38 UTC (rev 90303)
@@ -1,3 +1,19 @@
+2011-07-01 Scott Byer
+
+Reviewed by Adam Barth.
+
+Smooth scrolling fixes
+https://bugs.webkit.org/show_bug.cgi?id=63770
+
+Tests: Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollWheelTrace and .LinuxTrackPadTrace
+
+Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
+scroll animation code.
+
+* platform/ScrollAnimatorNone.cpp:
+(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
+(WebCore::ScrollAnimatorNone::scroll):
+
2011-07-01 Levi Weintraub
Switch primary virtual layout functions to new layout types
Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp (90302 => 90303)
--- trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2011-07-02 00:16:52 UTC (rev 90302)
+++ trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2011-07-02 00:26:38 UTC (rev 90303)
@@ -221,10 +221,10 @@
if (attackAreaLeft)
m_attackPosition = m_startPosition + m_desiredVelocity * attackAreaLeft;
else
-m_attackPosition = *m_currentPosition;
+m_attackPosition = m_releasePosition - (m_animationTime - m_releaseTime - m_attackTime) * m_desiredVelocity;
if (sustainTimeLeft) {
-double roundOff = m_releasePosition - (m_attackPosition + m_desiredVelocity * sustainTimeLeft);
+double roundOff = m_releasePosition - ((attackAreaLeft ? m_attackPosition : *m_currentPosition) + m_desiredVelocity * sustainTimeLeft);
m_desiredVelocity += roundOff / sustainTimeLeft;
}
@@ -289,14 +289,13 @@
case ScrollByDocument:
break;
case ScrollByLine:
-parameters = Parameters(true, 7 * kTickTime, Quadratic, 3 * kTickTime, Quadratic, 3 * kTickTime);
+parameters = Parameters(true, 10 * kTickTime, Quadratic, 3 * kTickTime, Quadratic, 3 * kTickTime);
break;
case ScrollByPage:
parameters = Parameters(true, 15 * kTickTime, Quadratic, 5 * kTickTime, Quadratic, 5 * kTickTime);
break;
case ScrollByPixel:
-if (fabs(multiplier) > 20)
-parameters = Parameters(true, 11 * kTickTime, Quadratic, 3 * kTickTime, Quadratic, 3 * kTickTime);
+parameters = Parameters(true, 11 * kTickTime, Quadratic, 3 * kTickTime, Quadratic, 3 * kTickTime);
break;
default:
break;
Modified: trunk/Source/WebKit/chromium/ChangeLog (90302 => 90303)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-02 00:16:52 UTC (rev 90302)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-02 00:26:38 UTC (rev 90303)
@@ -1,3 +1,17 @@
+2011-07-01 Scott Byer
+
+Reviewed by Adam Barth.
+
+Smooth scrolling fixes
+https://bugs.webkit.org/show_bug.cgi?id=63770
+
+Fix issues found in manual testing; distill the traces into unit tests. Fix the issues the tests exposed in the
+scroll animation code.
+
+* tests/ScrollAnimatorNoneTest.cpp:
+(ScrollAnimatorNoneTest::updateDataFromParameters):
+(TEST_F):
+
2011-07-01 Hans Wennborg
IndexedDB: make LevelDB the default back-end
Modified: trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp (90302 => 90303)
--- trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 2011-07-02 00:16:52 UTC (rev 90302)
+++ trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 20
[webkit-changes] [90301] trunk
Title: [90301] trunk
Revision 90301
Author wei...@apple.com
Date 2011-07-01 17:09:13 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Sam Weinig
Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856
Reviewed by Dan Bernstein.
Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
the nesting cap to 512 to cover more cases where rending recursion was biting us.
* page/Settings.h:
Reduce the nesting cap to 512.
2011-07-01 Sam Weinig
Reduce parser nesting cap to 512
https://bugs.webkit.org/show_bug.cgi?id=63856
Update test for new cap.
* fast/parser/block-nesting-cap-expected.txt:
* fast/parser/script-tests/block-nesting-cap.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt
trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.h
Diff
Modified: trunk/LayoutTests/ChangeLog (90300 => 90301)
--- trunk/LayoutTests/ChangeLog 2011-07-02 00:09:12 UTC (rev 90300)
+++ trunk/LayoutTests/ChangeLog 2011-07-02 00:09:13 UTC (rev 90301)
@@ -1,3 +1,13 @@
+2011-07-01 Sam Weinig
+
+Reduce parser nesting cap to 512
+https://bugs.webkit.org/show_bug.cgi?id=63856
+
+Update test for new cap.
+
+* fast/parser/block-nesting-cap-expected.txt:
+* fast/parser/script-tests/block-nesting-cap.js:
+
2011-07-01 Mihai Parparita
editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
Modified: trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt (90300 => 90301)
--- trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-07-02 00:09:12 UTC (rev 90300)
+++ trunk/LayoutTests/fast/parser/block-nesting-cap-expected.txt 2011-07-02 00:09:13 UTC (rev 90301)
@@ -1,11 +1,11 @@
-Test that the HTML parser does not allow the nesting depth of "block-level" elements to exceed 2048.
+Test that the HTML parser does not allow the nesting depth of elements to exceed 512.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS d2048.parentNode === d2046 is true
-PASS d2047.parentNode === d2046 is true
-PASS d2048.previousSibling === d2047 is true
+PASS d512.parentNode === d510 is true
+PASS d511.parentNode === d510 is true
+PASS d512.previousSibling === d511 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap.js (90300 => 90301)
--- trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap.js 2011-07-02 00:09:12 UTC (rev 90300)
+++ trunk/LayoutTests/fast/parser/script-tests/block-nesting-cap.js 2011-07-02 00:09:13 UTC (rev 90301)
@@ -1,6 +1,6 @@
-description('Test that the HTML parser does not allow the nesting depth of "block-level" elements to exceed 2048.');
+description('Test that the HTML parser does not allow the nesting depth of elements to exceed 512.');
-var depth = 2100;
+var depth = 514;
var markup = "";
var i;
for (i = 0; i < depth; ++i)
@@ -8,12 +8,12 @@
var doc = document.implementation.createHTMLDocument();
doc.body.innerHTML = markup;
-var d2046 = doc.getElementById("d2046");
-var d2047 = doc.getElementById("d2047");
-var d2048 = doc.getElementById("d2048");
+var d510 = doc.getElementById("d510");
+var d511 = doc.getElementById("d511");
+var d512 = doc.getElementById("d512");
-shouldBe("d2048.parentNode === d2046", "true");
-shouldBe("d2047.parentNode === d2046", "true");
-shouldBe("d2048.previousSibling === d2047", "true");
+shouldBe("d512.parentNode === d510", "true");
+shouldBe("d511.parentNode === d510", "true");
+shouldBe("d512.previousSibling === d511", "true");
var successfullyParsed = true;
Modified: trunk/Source/WebCore/ChangeLog (90300 => 90301)
--- trunk/Source/WebCore/ChangeLog 2011-07-02 00:09:12 UTC (rev 90300)
+++ trunk/Source/WebCore/ChangeLog 2011-07-02 00:09:13 UTC (rev 90301)
@@ -1,3 +1,16 @@
+2011-07-01 Sam Weinig
+
+Reduce parser nesting cap to 512
+https://bugs.webkit.org/show_bug.cgi?id=63856
+
+Reviewed by Dan Bernstein.
+
+Given Firefox's cap of 200, our cap of 2048 seemed a little excessive. Lower
+the nesting cap to 512 to cover more cases where rending recursion was biting us.
+
+* page/Settings.h:
+Reduce the nesting cap to 512.
+
2011-07-01 Darin Adler
Add change accidentally left out of last commit.
Modified: trunk/Source/WebCore/page/Settings.h (90300 => 90301)
--- trunk/Source/WebCore/page/Settings.h 2011-07-02 00:09:12 UTC (rev 90300)
+++ trunk/Source/WebCore/page/Settings.h 2011-07-02 00:09:13 UTC (rev 90301)
@@ -402,7 +402,7 @@
void setUsePreHTML5ParserQuirks(bool flag) { m_usePreHTML5ParserQuirks = flag; }
bool usePreHTML5ParserQuirks() const { return m_usePreHTML5ParserQuir
[webkit-changes] [90300] trunk/Tools
Title: [90300] trunk/Tools
Revision 90300
Author aba...@webkit.org
Date 2011-07-01 17:09:12 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Add some more debug logging to try to understand why we're getting
stuck acquring the HTTP lock.
* Scripts/webkitpy/layout_tests/port/http_lock.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py
Diff
Modified: trunk/Tools/ChangeLog (90299 => 90300)
--- trunk/Tools/ChangeLog 2011-07-02 00:05:07 UTC (rev 90299)
+++ trunk/Tools/ChangeLog 2011-07-02 00:09:12 UTC (rev 90300)
@@ -1,5 +1,12 @@
2011-07-01 Adam Barth
+Add some more debug logging to try to understand why we're getting
+stuck acquring the HTTP lock.
+
+* Scripts/webkitpy/layout_tests/port/http_lock.py:
+
+2011-07-01 Adam Barth
+
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py (90299 => 90300)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py 2011-07-02 00:05:07 UTC (rev 90299)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/http_lock.py 2011-07-02 00:09:12 UTC (rev 90300)
@@ -87,6 +87,7 @@
it deletes the lock file."""
lock_list = self._lock_file_list()
if not lock_list:
+_log.debug("No lock file list")
return
try:
current_lock_file = open(lock_list[0], 'r')
@@ -96,9 +97,15 @@
_log.debug("Removing stuck lock file: %s" % lock_list[0])
FileSystem().remove(lock_list[0])
return
-except (IOError, OSError):
+except IOError, e:
+_log.debug("IOError: %s" % e)
return
-return int(current_pid)
+except OSError, e:
+_log.debug("OSError: %s" % e)
+return
+result = int(current_pid)
+_log.debug("Current lock pid: %s" % result)
+return result
def _create_lock_file(self):
"""The lock files are used to schedule the running test sessions in first
@@ -121,7 +128,6 @@
self._guard_lock.release_lock()
return True
-
def wait_for_httpd_lock(self):
"""Create a lock file and wait until it's turn comes. If something goes wrong
it wont do any locking."""
@@ -131,3 +137,5 @@
while self._curent_lock_pid() != os.getpid():
time.sleep(1)
+
+_log.debug("HTTP lock acquired")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90299] trunk/LayoutTests
Title: [90299] trunk/LayoutTests
Revision 90299
Author mih...@chromium.org
Date 2011-07-01 17:05:07 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Mihai Parparita
editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=63855
Reviewed by Ryosuke Niwa.
Allow a trailing whitespace in the expected result, since Windows
has different word iterating behavior.
* editing/selection/directionality-after-undo-replace.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90298 => 90299)
--- trunk/LayoutTests/ChangeLog 2011-07-01 23:45:27 UTC (rev 90298)
+++ trunk/LayoutTests/ChangeLog 2011-07-02 00:05:07 UTC (rev 90299)
@@ -1,5 +1,17 @@
2011-07-01 Mihai Parparita
+editing/selection/directionality-after-undo-replace.html fails on Chromium Windows
+https://bugs.webkit.org/show_bug.cgi?id=63855
+
+Reviewed by Ryosuke Niwa.
+
+Allow a trailing whitespace in the expected result, since Windows
+has different word iterating behavior.
+
+* editing/selection/directionality-after-undo-replace.html:
+
+2011-07-01 Mihai Parparita
+
Remove Chromium Windows 7 and Vista media test expectations, since
clobbering the bots appears to have fixed the timeouts and failures.
Modified: trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html (90298 => 90299)
--- trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html 2011-07-01 23:45:27 UTC (rev 90298)
+++ trunk/LayoutTests/editing/selection/directionality-after-undo-replace.html 2011-07-02 00:05:07 UTC (rev 90299)
@@ -36,7 +36,8 @@
window.getSelection().modify('extend', 'left', 'character');
var actual = window.getSelection().toString();
-document.writeln(actual == ' world' ? 'PASS' : 'FAIL - expected " world" but got "' + actual + '"');
+// Windows has a trailing whitespace, other platforms don't.
+document.writeln((actual == ' world' || actual == ' world ') ? 'PASS' : 'FAIL - expected " world" but got "' + actual + '"');
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90298] trunk/Tools
Title: [90298] trunk/Tools
Revision 90298
Author aba...@webkit.org
Date 2011-07-01 16:45:27 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854
Reviewed by Dirk Pranke.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (90297 => 90298)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 23:41:45 UTC (rev 90297)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 23:45:27 UTC (rev 90298)
@@ -215,10 +215,7 @@
self.setCommand(self.command + rootArgument)
return shell.Test.start(self)
-def commandComplete(self, cmd):
-shell.Test.commandComplete(self, cmd)
-
-logText = cmd.logs['stdio'].getText()
+def _parseOldRunWebKitTestsOutput(self):
incorrectLayoutLines = []
for line in logText.splitlines():
if line.find('had incorrect layout') >= 0 or line.find('were new') >= 0 or line.find('was new') >= 0:
@@ -234,6 +231,40 @@
self.incorrectLayoutLines = incorrectLayoutLines
+def _parseNewRunWebKitTestsOutput(self):
+incorrectLayoutLines = []
+expressions = {
+'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
+'were flaky': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
+'new passes': re.compile(r'Expected to .+, but passed:\s+\((\d+)\)'),
+}
+testFailures = {}
+
+for line in logText.splitlines():
+if line.find('Exiting early') >= 0:
+incorrectLayoutLines.append(line)
+continue
+for name in expressions:
+match = expressions[name].search(line)
+if match:
+testFailures[name] = testFailures.get(name, 0) + int(match.group(1))
+
+# FIXME: Parse file names and put them in results
+
+for name in testFailures:
+incorrectLayoutLines.append(str(testFailures[name]) + ' ' + name)
+
+self.incorrectLayoutLines = incorrectLayoutLines
+
+def commandComplete(self, cmd):
+shell.Test.commandComplete(self, cmd)
+
+logText = cmd.logs['stdio'].getText()
+if logText.find("Collecting tests ...") >= 0:
+self._parseNewRunWebKitTestsOutput(logText)
+else:
+self._parseOldRunWebKitTestsOutput(logText)
+
def evaluateCommand(self, cmd):
if self.incorrectLayoutLines:
if len(self.incorrectLayoutLines) == 1:
@@ -272,30 +303,8 @@
shell.Test.commandComplete(self, cmd)
logText = cmd.logs['stdio'].getText()
-incorrectLayoutLines = []
-expressions = {
-'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
-'were flaky': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
-'new passes': re.compile(r'Expected to .+, but passed:\s+\((\d+)\)'),
-}
-testFailures = {}
+self._parseNewRunWebKitTestsOutput(logText)
-for line in logText.splitlines():
-if line.find('Exiting early') >= 0:
-incorrectLayoutLines.append(line)
-continue
-for name in expressions:
-match = expressions[name].search(line)
-if match:
-testFailures[name] = testFailures.get(name, 0) + int(match.group(1))
-
-# FIXME: Parse file names and put them in results
-
-for name in testFailures:
-incorrectLayoutLines.append(str(testFailures[name]) + ' ' + name)
-
-self.incorrectLayoutLines = incorrectLayoutLines
-
def evaluateCommand(self, cmd):
if cmd.rc != 0:
return FAILURE
Modified: trunk/Tools/ChangeLog (90297 => 90298)
--- trunk/Tools/ChangeLog 2011-07-01 23:41:45 UTC (rev 90297)
+++ trunk/Tools/ChangeLog 2011-07-01 23:45:27 UTC (rev 90298)
@@ -1,3 +1,12 @@
+2011-07-01 Adam Barth
+
+Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
+https://bugs.webkit.org/show_bug.cgi?id=63854
+
+Reviewed by Dirk Pranke.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
2011-07-01 Eric Seidel
new-run-webkit-tests results does not understand that mac uses test_expectations files
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90297] trunk/LayoutTests
Title: [90297] trunk/LayoutTests Revision 90297 Author mih...@chromium.org Date 2011-07-01 16:41:45 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Mihai Parparita Remove Chromium Windows 7 and Vista media test expectations, since clobbering the bots appears to have fixed the timeouts and failures. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90296 => 90297) --- trunk/LayoutTests/ChangeLog 2011-07-01 23:30:00 UTC (rev 90296) +++ trunk/LayoutTests/ChangeLog 2011-07-01 23:41:45 UTC (rev 90297) @@ -1,3 +1,10 @@ +2011-07-01 Mihai Parparita + +Remove Chromium Windows 7 and Vista media test expectations, since +clobbering the bots appears to have fixed the timeouts and failures. + +* platform/chromium/test_expectations.txt: + 2011-07-01 Ryosuke Niwa GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90296 => 90297) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 23:30:00 UTC (rev 90296) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 23:41:45 UTC (rev 90297) @@ -824,7 +824,7 @@ BUGCR78376 : http/tests/media/video-play-stall-seek.html = TIMEOUT // canplaythrough event is sent too early. -BUGCR73609 MAC XP LINUX : http/tests/media/video-play-stall.html = TEXT +BUGCR73609 : http/tests/media/video-play-stall.html = TEXT // video.buffered multiple TimeRanges support. BUGCR49165 SKIP : http/tests/media/video-buffered.html = PASS @@ -2914,7 +2914,7 @@ BUGCR74979 GPU MAC SKIP: media/video-canvas-alpha.html = IMAGE // This test needs completely new baselines. -BUGWK55718 BUGCR75354 XP MAC LINUX : media/media-document-audio-repaint.html = IMAGE+TEXT +BUGWK55718 BUGCR75354 : media/media-document-audio-repaint.html = IMAGE+TEXT BUGWK55968 BUGWK58306 GPU MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT CRASH BUGWK55968 GPU WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE @@ -4028,51 +4028,6 @@ // Added in http://trac.webkit.org/changeset/90148, null-derefing in TestNetscapgePlugin. BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH -// Caused by an ffmpeg roll -BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT -BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/remove-while-loading.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-cancel-load.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-cookie.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-error-abort.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT -BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT -BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT -BUGCR88197 VISTA WIN7 : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS -BUGCR88197 VISTA WIN7 : http/tests/security/local-video-source-from-remote.html = TEXT -BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-controls-do-not-fade-out.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-controls-rendering.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-delete-while-slider-thumb-clicked.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS -BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS -BUGCR88197 VISTA WIN7 : media/controls-after-reload.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/controls-drag-timebar.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/controls-right-click-on-timebar.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/controls-strict.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/controls-styling.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/controls-without-preload.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/event-attributes.html = TEXT -BUGCR88197 VISTA WIN7 : media/media-blocked-by-beforeload.html = TIMEOUT -BUGCR88197 VISTA WIN7 : media/media-document-audio-re
[webkit-changes] [90296] tags/Safari-534.50.2/Source
Title: [90296] tags/Safari-534.50.2/Source Revision 90296 Author lforsch...@apple.com Date 2011-07-01 16:30:00 -0700 (Fri, 01 Jul 2011) Log Message Versioning Modified Paths tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig (90295 => 90296) --- tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-01 23:24:21 UTC (rev 90295) +++ tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-01 23:30:00 UTC (rev 90296) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig (90295 => 90296) --- tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-01 23:24:21 UTC (rev 90295) +++ tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-01 23:30:00 UTC (rev 90296) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig (90295 => 90296) --- tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig 2011-07-01 23:24:21 UTC (rev 90295) +++ tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig 2011-07-01 23:30:00 UTC (rev 90296) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig (90295 => 90296) --- tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-01 23:24:21 UTC (rev 90295) +++ tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-01 23:30:00 UTC (rev 90296) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig (90295 => 90296) --- tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig 2011-07-01 23:24:21 UTC (rev 90295) +++ tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig 2011-07-01 23:30:00 UTC (rev 90296) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90295] trunk/Source/WebCore
Title: [90295] trunk/Source/WebCore
Revision 90295
Author da...@apple.com
Date 2011-07-01 16:24:21 -0700 (Fri, 01 Jul 2011)
Log Message
Add change accidentally left out of last commit.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
backing scale.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90294 => 90295)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 23:19:00 UTC (rev 90294)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 23:24:21 UTC (rev 90295)
@@ -1,5 +1,13 @@
2011-07-01 Darin Adler
+Add change accidentally left out of last commit.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateContentsScale): Multiply in the
+backing scale.
+
+2011-07-01 Darin Adler
+
Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (90294 => 90295)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-01 23:19:00 UTC (rev 90294)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-01 23:24:21 UTC (rev 90295)
@@ -1477,14 +1477,16 @@
void RenderLayerBacking::updateContentsScale(float scale)
{
+float combinedScale = scale * backingScaleFactor();
+
if (m_graphicsLayer)
-m_graphicsLayer->setContentsScale(scale);
+m_graphicsLayer->setContentsScale(combinedScale);
if (m_foregroundLayer)
-m_foregroundLayer->setContentsScale(scale);
+m_foregroundLayer->setContentsScale(combinedScale);
if (m_maskLayer)
-m_maskLayer->setContentsScale(scale);
+m_maskLayer->setContentsScale(combinedScale);
}
float RenderLayerBacking::pageScaleFactor() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90294] trunk/LayoutTests
Title: [90294] trunk/LayoutTests Revision 90294 Author rn...@webkit.org Date 2011-07-01 16:19:00 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Ryosuke Niwa GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853. * platform/gtk/editing/selection/after-line-break-expected.txt: Added. * platform/gtk/editing/selection/directionality-after-undo-replace.html: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/gtk/editing/selection/after-line-break-expected.txt trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html Diff Modified: trunk/LayoutTests/ChangeLog (90293 => 90294) --- trunk/LayoutTests/ChangeLog 2011-07-01 23:13:28 UTC (rev 90293) +++ trunk/LayoutTests/ChangeLog 2011-07-01 23:19:00 UTC (rev 90294) @@ -1,3 +1,10 @@ +2011-07-01 Ryosuke Niwa + +GTK rebaseline r90275. The failure of directionality-after-undo-replace.html is tracked by the bug 63853. + +* platform/gtk/editing/selection/after-line-break-expected.txt: Added. +* platform/gtk/editing/selection/directionality-after-undo-replace.html: Added. + 2011-07-01 Nate Chapin Unreviewed, remove extraneous newlines from Added: trunk/LayoutTests/platform/gtk/editing/selection/after-line-break-expected.txt (0 => 90294) --- trunk/LayoutTests/platform/gtk/editing/selection/after-line-break-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/editing/selection/after-line-break-expected.txt 2011-07-01 23:19:00 UTC (rev 90294) @@ -0,0 +1,12 @@ +EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document +EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification +EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +Test for rdar://problem/5973313 REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas. + +To test manually, click to the right of the first word on the first line to place the caret at the end of the line, then press the down arrow. The caret should move to the next (empty) line. Then click somewhere on that line. The caret should not stay there. + +Lorem + +ipsum Added: trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html (0 => 90294) --- trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html (rev 0) +++ trunk/LayoutTests/platform/gtk/editing/selection/directionality-after-undo-replace.html 2011-07-01 23:19:00 UTC (rev 90294) @@ -0,0 +1,10 @@ +This tests WebKit preserves non-directional selection after unapplying replacement on Mac. To manually test on Mac, + +Select "world" by double-clicking the word +Replace "world" by a character by pressing a key +Undo +Extend selection to the left +" world" should be selected. + +hello world WebKit +FAIL - expected " world" but got "o" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90293] trunk/Source
Title: [90293] trunk/Source
Revision 90293
Author da...@apple.com
Date 2011-07-01 16:13:28 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Darin Adler
Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848
Reviewed by Simon Fraser.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
Increased the maximum scale since scale factor can now include
both page contents scale and backing scale.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the
backing scale as well as the page contents scale.
(WebCore::RenderLayerBacking::updateForegroundLayer): Ditto.
(WebCore::RenderLayerBacking::updateMaskLayer): Ditto.
(WebCore::RenderLayerBacking::pageContentsScale): Added.
(WebCore::RenderLayerBacking::backingScale): Added.
* rendering/RenderLayerBacking.h: Added new private functions.
2011-07-01 Darin Adler
Consider backing scale factor when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848
Reviewed by Simon Fraser.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize): Set contents scale on the
non-composited content layer based on the backing scale factor.
(WebKit::LayerTreeHostCA::createPageOverlayLayer): Set contents
scale on the page overlay layer based on the backing scale factor.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
trunk/Source/WebCore/rendering/RenderLayerBacking.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90292 => 90293)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 23:09:57 UTC (rev 90292)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 23:13:28 UTC (rev 90293)
@@ -1,3 +1,24 @@
+2011-07-01 Darin Adler
+
+Consider backing scale when setting up graphics layers
+https://bugs.webkit.org/show_bug.cgi?id=63848
+
+Reviewed by Simon Fraser.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::clampedContentsScaleForScale):
+Increased the maximum scale since scale factor can now include
+both page contents scale and backing scale.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::createGraphicsLayer): Multiply in the
+backing scale as well as the page contents scale.
+(WebCore::RenderLayerBacking::updateForegroundLayer): Ditto.
+(WebCore::RenderLayerBacking::updateMaskLayer): Ditto.
+(WebCore::RenderLayerBacking::pageContentsScale): Added.
+(WebCore::RenderLayerBacking::backingScale): Added.
+* rendering/RenderLayerBacking.h: Added new private functions.
+
2011-07-01 Adele Peterson
Reviewed by Darin Adler.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (90292 => 90293)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-07-01 23:09:57 UTC (rev 90292)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-07-01 23:13:28 UTC (rev 90293)
@@ -1951,7 +1951,7 @@
{
// Define some limits as a sanity check for the incoming scale value
// those too small to see.
-const float maxScale = 5.0f;
+const float maxScale = 10.0f;
const float minScale = 0.01f;
// Avoid very slight scale changes that would be doing extra work for no benefit
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (90292 => 90293)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-01 23:09:57 UTC (rev 90292)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2011-07-01 23:13:28 UTC (rev 90293)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2009 Apple Inc. All rights reserved.
+ * Copyright (C) 2009, 2010, 2011 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -31,14 +31,13 @@
#include "AnimationController.h"
#include "CanvasRenderingContext.h"
-#include "CanvasRenderingContext2D.h"
#include "CSSPropertyNames.h"
#include "CSSStyleSelector.h"
+#include "Chrome.h"
#include "FrameView.h"
#include "GraphicsContext.h"
#include "GraphicsLayer.h"
#include "HTMLCanvasElement.h"
-#include "HTMLElement.h"
#include "HTMLIFrameElement.h"
#include "HTMLMediaElement.h"
#include "HTMLNames.h"
@@ -46,14 +45,12 @@
#include "KeyframeList.h"
#include "PluginViewBase.h"
#include "RenderApplet.h"
-#include "RenderBox.h"
#include "RenderIFrame.h"
#include "RenderImage.h"
#include "RenderLayerCompositor.h"
#incl
[webkit-changes] [90292] trunk/LayoutTests
Title: [90292] trunk/LayoutTests Revision 90292 Author jap...@chromium.org Date 2011-07-01 16:09:57 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Nate Chapin Unreviewed, remove extraneous newlines from expected results for fast/workers/worker-finish-crash.html. * fast/workers/worker-finish-crash-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90291 => 90292) --- trunk/LayoutTests/ChangeLog 2011-07-01 23:06:37 UTC (rev 90291) +++ trunk/LayoutTests/ChangeLog 2011-07-01 23:09:57 UTC (rev 90292) @@ -1,3 +1,10 @@ +2011-07-01 Nate Chapin + +Unreviewed, remove extraneous newlines from +expected results for fast/workers/worker-finish-crash.html. + +* fast/workers/worker-finish-crash-expected.txt: + 2011-07-01 Darin Adler The commit-bot checked in files without Subversion properties, so adding them now. Modified: trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt (90291 => 90292) --- trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt 2011-07-01 23:06:37 UTC (rev 90291) +++ trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt 2011-07-01 23:09:57 UTC (rev 90292) @@ -1,3 +1 @@ Test to ensure that finishing a Worker won't re-enter. We pass if we don't crash. - - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90291] trunk/LayoutTests
Title: [90291] trunk/LayoutTests Revision 90291 Author da...@apple.com Date 2011-07-01 16:06:37 -0700 (Fri, 01 Jul 2011) Log Message The commit-bot checked in files without Subversion properties, so adding them now. * fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added property svn:eol-style. * fast/loader/create-frame-in-DOMContentLoaded.html: Added properties svn:mime-type and svn:eol-style. Modified Paths trunk/LayoutTests/ChangeLog Property Changed trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html Diff Modified: trunk/LayoutTests/ChangeLog (90290 => 90291) --- trunk/LayoutTests/ChangeLog 2011-07-01 23:02:41 UTC (rev 90290) +++ trunk/LayoutTests/ChangeLog 2011-07-01 23:06:37 UTC (rev 90291) @@ -1,3 +1,10 @@ +2011-07-01 Darin Adler + +The commit-bot checked in files without Subversion properties, so adding them now. + +* fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added property svn:eol-style. +* fast/loader/create-frame-in-DOMContentLoaded.html: Added properties svn:mime-type and svn:eol-style. + 2011-07-01 Ryosuke Niwa Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner. Property changes: trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded-expected.txt Added: svn:eol-style Property changes: trunk/LayoutTests/fast/loader/create-frame-in-DOMContentLoaded.html Added: svn:mime-type Added: svn:eol-style ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90290] trunk/Source
Title: [90290] trunk/Source Revision 90290 Author ad...@apple.com Date 2011-07-01 16:02:41 -0700 (Fri, 01 Jul 2011) Log Message ../WebCore: WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851 Crash when loading a document in an editable WebView that has a subframe with an unstyled body Reviewed by Darin Adler. No new tests. I tried to make a test in DumpRenderTree with an editable WebView, but was unsuccessful in getting the crash to happen in that instance. * editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT. ../WebKit/mac: WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851 Crash when loading a document in an editable WebView that has a subframe with an unstyled body Reviewed by Darin Adler. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word, space, and after-white-space properties to subframes in the editable document. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm Diff Modified: trunk/Source/WebCore/ChangeLog (90289 => 90290) --- trunk/Source/WebCore/ChangeLog 2011-07-01 22:43:29 UTC (rev 90289) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 23:02:41 UTC (rev 90290) @@ -1,3 +1,15 @@ +2011-07-01 Adele Peterson + +Reviewed by Darin Adler. + +WebCore part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851 + Crash when loading a document in an editable WebView that has a subframe with an unstyled body + +No new tests. I tried to make a test in DumpRenderTree with an editable WebView, +but was unsuccessful in getting the crash to happen in that instance. + +* editing/Editor.cpp: (WebCore::Editor::applyEditingStyleToElement): Add a nil check that exits early, in addition to the ASSERT. + 2011-07-01 Levi Weintraub Switch overflow and collapsedMargins to new layout types Modified: trunk/Source/WebCore/editing/Editor.cpp (90289 => 90290) --- trunk/Source/WebCore/editing/Editor.cpp 2011-07-01 22:43:29 UTC (rev 90289) +++ trunk/Source/WebCore/editing/Editor.cpp 2011-07-01 23:02:41 UTC (rev 90290) @@ -2883,6 +2883,8 @@ CSSStyleDeclaration* style = element->style(); ASSERT(style); +if (!style) +return; ExceptionCode ec = 0; style->setProperty(CSSPropertyWordWrap, "break-word", false, ec); Modified: trunk/Source/WebKit/mac/ChangeLog (90289 => 90290) --- trunk/Source/WebKit/mac/ChangeLog 2011-07-01 22:43:29 UTC (rev 90289) +++ trunk/Source/WebKit/mac/ChangeLog 2011-07-01 23:02:41 UTC (rev 90290) @@ -1,3 +1,14 @@ +2011-07-01 Adele Peterson + +Reviewed by Darin Adler. + +WebKit part of fix for https://bugs.webkit.org/show_bug.cgi?id=63851 + Crash when loading a document in an editable WebView that has a subframe with an unstyled body + +* WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): +Only call applyEditingStyleToBodyElement for the main frame. There's no need to apply break-word, +space, and after-white-space properties to subframes in the editable document. + 2011-07-01 Andy Estes Reviewed by Mark Rowe. Modified: trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm (90289 => 90290) --- trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2011-07-01 22:43:29 UTC (rev 90289) +++ trunk/Source/WebKit/mac/WebView/WebHTMLRepresentation.mm 2011-07-01 23:02:41 UTC (rev 90290) @@ -220,7 +220,7 @@ } WebView *webView = [webFrame webView]; -if ([webView isEditable]) +if ([webView mainFrame] == webFrame && [webView isEditable]) core(webFrame)->editor()->applyEditingStyleToBodyElement(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90289] trunk/LayoutTests
Title: [90289] trunk/LayoutTests Revision 90289 Author rn...@webkit.org Date 2011-07-01 15:43:29 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Ryosuke Niwa Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90288 => 90289) --- trunk/LayoutTests/ChangeLog 2011-07-01 22:31:23 UTC (rev 90288) +++ trunk/LayoutTests/ChangeLog 2011-07-01 22:43:29 UTC (rev 90289) @@ -1,3 +1,9 @@ +2011-07-01 Ryosuke Niwa + +Skip the test added by r90275 in WebKit2 because setEditingBehavior hasn't been implemented in TestRunner. + +* platform/wk2/Skipped: + 2011-07-01 Hans Wennborg IndexedDB: make LevelDB the default back-end Modified: trunk/LayoutTests/platform/wk2/Skipped (90288 => 90289) --- trunk/LayoutTests/platform/wk2/Skipped 2011-07-01 22:31:23 UTC (rev 90288) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-01 22:43:29 UTC (rev 90289) @@ -1428,6 +1428,7 @@ # WebKitTestRunner needs layoutTestController.setEditingBehavior # +editing/selection/after-line-break.html editing/selection/rtl-move-selection-right-left.html editing/selection/5195166-1.html editing/selection/context-menu-text-selection.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90288] trunk/Source/WebCore
Title: [90288] trunk/Source/WebCore Revision 90288 Author le...@chromium.org Date 2011-07-01 15:31:23 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Levi Weintraub Switch overflow and collapsedMargins to new layout types https://bugs.webkit.org/show_bug.cgi?id=63840 Reviewed by Eric Seidel. Switching overflow and collapsedMargins over to the new layout unit abstraction. Also removing an unused function: blockDirectionOverflow No new tests, no functionality changes. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapsedMarginBeforeForChild): (WebCore::RenderBlock::collapsedMarginAfterForChild): * rendering/RenderBlock.h: (WebCore::RenderBlock::collapsedMarginBefore): (WebCore::RenderBlock::collapsedMarginAfter): * rendering/RenderBox.cpp: (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::addLayoutOverflow): (WebCore::RenderBox::addVisualOverflow): * rendering/RenderBox.h: (WebCore::RenderBox::layoutOverflowRect): (WebCore::RenderBox::minYLayoutOverflow): (WebCore::RenderBox::maxYLayoutOverflow): (WebCore::RenderBox::minXLayoutOverflow): (WebCore::RenderBox::maxXLayoutOverflow): (WebCore::RenderBox::maxLayoutOverflow): (WebCore::RenderBox::logicalLeftLayoutOverflow): (WebCore::RenderBox::logicalRightLayoutOverflow): (WebCore::RenderBox::visualOverflowRect): (WebCore::RenderBox::minYVisualOverflow): (WebCore::RenderBox::maxYVisualOverflow): (WebCore::RenderBox::minXVisualOverflow): (WebCore::RenderBox::maxXVisualOverflow): (WebCore::RenderBox::logicalLeftVisualOverflow): (WebCore::RenderBox::logicalRightVisualOverflow): (WebCore::RenderBox::addOverflowFromChild): (WebCore::RenderBox::collapsedMarginBefore): (WebCore::RenderBox::collapsedMarginAfter): * rendering/RenderOverflow.h: (WebCore::RenderOverflow::RenderOverflow): (WebCore::RenderOverflow::minYLayoutOverflow): (WebCore::RenderOverflow::maxYLayoutOverflow): (WebCore::RenderOverflow::minXLayoutOverflow): (WebCore::RenderOverflow::maxXLayoutOverflow): (WebCore::RenderOverflow::minYVisualOverflow): (WebCore::RenderOverflow::maxYVisualOverflow): (WebCore::RenderOverflow::minXVisualOverflow): (WebCore::RenderOverflow::maxXVisualOverflow): (WebCore::RenderOverflow::setMinYLayoutOverflow): (WebCore::RenderOverflow::setMaxYLayoutOverflow): (WebCore::RenderOverflow::setMinXLayoutOverflow): (WebCore::RenderOverflow::setMaxXLayoutOverflow): (WebCore::RenderOverflow::setMinYVisualOverflow): (WebCore::RenderOverflow::setMaxYVisualOverflow): (WebCore::RenderOverflow::setMinXVisualOverflow): (WebCore::RenderOverflow::setMaxXVisualOverflow): (WebCore::RenderOverflow::layoutOverflowRect): (WebCore::RenderOverflow::visualOverflowRect): (WebCore::RenderOverflow::move): (WebCore::RenderOverflow::addLayoutOverflow): (WebCore::RenderOverflow::addVisualOverflow): (WebCore::RenderOverflow::setLayoutOverflow): (WebCore::RenderOverflow::setVisualOverflow): (WebCore::RenderOverflow::resetLayoutOverflow): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderOverflow.h Diff Modified: trunk/Source/WebCore/ChangeLog (90287 => 90288) --- trunk/Source/WebCore/ChangeLog 2011-07-01 22:30:00 UTC (rev 90287) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 22:31:23 UTC (rev 90288) @@ -1,3 +1,72 @@ +2011-07-01 Levi Weintraub + +Switch overflow and collapsedMargins to new layout types +https://bugs.webkit.org/show_bug.cgi?id=63840 + +Reviewed by Eric Seidel. + +Switching overflow and collapsedMargins over to the new layout unit abstraction. + +Also removing an unused function: blockDirectionOverflow + +No new tests, no functionality changes. + +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::collapsedMarginBeforeForChild): +(WebCore::RenderBlock::collapsedMarginAfterForChild): +* rendering/RenderBlock.h: +(WebCore::RenderBlock::collapsedMarginBefore): +(WebCore::RenderBlock::collapsedMarginAfter): +* rendering/RenderBox.cpp: +(WebCore::RenderBox::addOverflowFromChild): +(WebCore::RenderBox::addLayoutOverflow): +(WebCore::RenderBox::addVisualOverflow): +* rendering/RenderBox.h: +(WebCore::RenderBox::layoutOverflowRect): +(WebCore::RenderBox::minYLayoutOverflow): +(WebCore::RenderBox::maxYLayoutOv
[webkit-changes] [90287] trunk
Title: [90287] trunk
Revision 90287
Author h...@chromium.org
Date 2011-07-01 15:30:00 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Hans Wennborg
IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817
Reviewed by Tony Chang.
Disable IndexedDB quota teset since quota enforcement is not yet
supported by the LevelDB back-end.
* platform/chromium/test_expectations.txt:
2011-07-01 Hans Wennborg
IndexedDB: make LevelDB the default back-end
https://bugs.webkit.org/show_bug.cgi?id=63817
Reviewed by Tony Chang.
Use LevelDB as the default back-end.
Covered by existing layout tests for indexeddb, which will now be
using the LevelDB back-end.
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (90286 => 90287)
--- trunk/LayoutTests/ChangeLog 2011-07-01 22:25:14 UTC (rev 90286)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 22:30:00 UTC (rev 90287)
@@ -1,3 +1,15 @@
+2011-07-01 Hans Wennborg
+
+IndexedDB: make LevelDB the default back-end
+https://bugs.webkit.org/show_bug.cgi?id=63817
+
+Reviewed by Tony Chang.
+
+Disable IndexedDB quota teset since quota enforcement is not yet
+supported by the LevelDB back-end.
+
+* platform/chromium/test_expectations.txt:
+
2011-07-01 Mihai Parparita
Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90286 => 90287)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 22:25:14 UTC (rev 90286)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 22:30:00 UTC (rev 90287)
@@ -4076,3 +4076,6 @@
BUGWK63509 : editing/style/smoosh-styles-003.html = PASS IMAGE
BUGCR88230 VISTA : fast/dom/dom-parse-serialize-display.html = PASS TIMEOUT
BUGCR88232 WIN DEBUG : fast/dom/non-numeric-values-numeric-parameters.html = CRASH PASS
+
+// Quota enforcement not yet implemented for LevelDB back-end.
+BUGCR83652 : storage/indexeddb/database-quota.html = TEXT
Modified: trunk/Source/WebKit/chromium/ChangeLog (90286 => 90287)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 22:25:14 UTC (rev 90286)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 22:30:00 UTC (rev 90287)
@@ -1,3 +1,18 @@
+2011-07-01 Hans Wennborg
+
+IndexedDB: make LevelDB the default back-end
+https://bugs.webkit.org/show_bug.cgi?id=63817
+
+Reviewed by Tony Chang.
+
+Use LevelDB as the default back-end.
+
+Covered by existing layout tests for indexeddb, which will now be
+using the LevelDB back-end.
+
+* src/WebIDBFactoryImpl.cpp:
+(WebKit::WebIDBFactoryImpl::open):
+
2011-07-01 Ryosuke Niwa
Reviewed by Ojan Vafai.
Modified: trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp (90286 => 90287)
--- trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp 2011-07-01 22:25:14 UTC (rev 90286)
+++ trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp 2011-07-01 22:30:00 UTC (rev 90287)
@@ -81,7 +81,7 @@
}
if (backingStoreType == DefaultBackingStore)
-backingStoreType = SQLiteBackingStore;
+backingStoreType = LevelDBBackingStore;
if (dataDir.isEmpty() && backingStoreType == LevelDBBackingStore) {
if (!tempDatabaseFolder.isEmpty()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90286] trunk/LayoutTests
Title: [90286] trunk/LayoutTests
Revision 90286
Author mih...@chromium.org
Date 2011-07-01 15:25:14 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Mihai Parparita
Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
(r90261 added a Leopard expectation for the Mac port, but Chromium
Leopard can pass with the default baseline).
* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90285 => 90286)
--- trunk/LayoutTests/ChangeLog 2011-07-01 22:11:46 UTC (rev 90285)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 22:25:14 UTC (rev 90286)
@@ -1,3 +1,11 @@
+2011-07-01 Mihai Parparita
+
+Rebaseline media/media-blocked-by-beforeload.html for Chromium Leopard
+(r90261 added a Leopard expectation for the Mac port, but Chromium
+Leopard can pass with the default baseline).
+
+* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
+
2011-07-01 Nate Chapin
Test for https://bugs.webkit.org/show_bug.cgi?id=63835.
Added: trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt (0 => 90286)
--- trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt 2011-07-01 22:25:14 UTC (rev 90286)
@@ -0,0 +1,40 @@
+Test to ensure that a media file blocked by a beforeload handler generates an error and does not block the document's 'load' event.
+
+*** Test initial state ***
+EXPECTED (video.networkState == '0') OK
+EXPECTED (video.error == 'null') OK
+
+*** Test blocking the 'src' attribute ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of 'src'
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+EXPECTED (video.error != 'null') OK
+EXPECTED (video.error.code == '4') OK
+EXPECTED (video.networkState == '3') OK
+
+*** Test using the element ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of first element
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+allowing load of second element
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'SOURCE') OK
+EXPECTED (video.error == 'null') OK
+
+EVENT('loadedmetadata')
+
+END OF TEST
+
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90285] trunk/Tools
Title: [90285] trunk/Tools
Revision 90285
Author e...@webkit.org
Date 2011-07-01 15:11:46 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Eric Seidel
new-run-webkit-tests results does not understand that mac uses test_expectations files
https://bugs.webkit.org/show_bug.cgi?id=63838
Reviewed by Adam Barth.
We've decided to "enable" test_expectations for the Mac port for now.
It makes the results.html results much more confusing to read, but at least they're
no longer lying to us.
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90284 => 90285)
--- trunk/Tools/ChangeLog 2011-07-01 22:06:07 UTC (rev 90284)
+++ trunk/Tools/ChangeLog 2011-07-01 22:11:46 UTC (rev 90285)
@@ -1,3 +1,18 @@
+2011-07-01 Eric Seidel
+
+new-run-webkit-tests results does not understand that mac uses test_expectations files
+https://bugs.webkit.org/show_bug.cgi?id=63838
+
+Reviewed by Adam Barth.
+
+We've decided to "enable" test_expectations for the Mac port for now.
+It makes the results.html results much more confusing to read, but at least they're
+no longer lying to us.
+
+* Scripts/webkitpy/layout_tests/layout_package/manager.py:
+* Scripts/webkitpy/layout_tests/port/base.py:
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+
2011-07-01 Adam Barth
Temporarily disable waiting for ReportCrash to see how this code
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py (90284 => 90285)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 22:06:07 UTC (rev 90284)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 22:11:46 UTC (rev 90285)
@@ -206,9 +206,7 @@
results['num_passes'] = num_passes
results['num_flaky'] = num_flaky
results['num_regressions'] = num_regressions
-# FIXME: If non-chromium ports start using an expectations file,
-# we should make this check more robust.
-results['uses_expectations_file'] = port_obj.name().find('chromium') != -1
+results['uses_expectations_file'] = port_obj.uses_test_expectations_file()
results['layout_tests_dir'] = port_obj.layout_tests_dir()
results['has_wdiff'] = port_obj.wdiff_available()
results['has_pretty_patch'] = port_obj.pretty_patch_available()
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (90284 => 90285)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-07-01 22:06:07 UTC (rev 90284)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-07-01 22:11:46 UTC (rev 90285)
@@ -711,6 +711,11 @@
'snowleopard' should precede 'leopard')."""
raise NotImplementedError
+def uses_test_expectations_file(self):
+# This is different from checking test_expectations() is None, because
+# some ports have Skipped files which are returned as part of test_expectations().
+return self._filesystem.exists(self.path_to_test_expectations_file())
+
def test_expectations(self):
"""Returns the test expectations for this port.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py (90284 => 90285)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-07-01 22:06:07 UTC (rev 90284)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py 2011-07-01 22:11:46 UTC (rev 90285)
@@ -207,8 +207,7 @@
prefix = "file://"
path = test_file
-self.assertEqual(port.filename_to_uri(test_file),
- abspath_to_uri(test_file))
+self.assertEqual(port.filename_to_uri(test_file), abspath_to_uri(test_file))
def test_get_option__set(self):
options, args = optparse.OptionParser().parse_args([])
@@ -234,8 +233,7 @@
def test_additional_platform_directory(self):
filesystem = MockFileSystem()
-options, args = optparse.OptionParser().parse_args([])
-port = base.Port(port_name='foo', filesystem=filesystem, options=options)
+port = base.Port(port_name='foo', filesystem=filesystem)
port.baseline_search_path = lambda: ['LayoutTests/platform/foo']
layout_test_dir = port.layout_tests_dir()
test_file = filesystem.join(layout_test_dir, 'fast', 'test.html')
@@ -247,7 +245,7 @@
self.assertEqual(port.baseline_path(), 'LayoutTests/platform/foo')
# Simple additional platform directory
-options.additional_platform_directory = ['/tmp/local-base
[webkit-changes] [90284] trunk
Title: [90284] trunk
Revision 90284
Author jap...@chromium.org
Date 2011-07-01 15:06:07 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Nate Chapin
Test for https://bugs.webkit.org/show_bug.cgi?id=63835.
Reviewed by Dmitry Titov.
* fast/workers/worker-finish-crash-expected.txt: Added.
* fast/workers/worker-finish-crash.html: Added.
2011-07-01 Nate Chapin
Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
https://bugs.webkit.org/show_bug.cgi?id=63835
Reviewed by Dmitry Titov.
Test: fast/workers/worker-finish-crash.html
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::notifyFinished):
* workers/WorkerScriptLoader.h:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.h
Added Paths
trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt
trunk/LayoutTests/fast/workers/worker-finish-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90283 => 90284)
--- trunk/LayoutTests/ChangeLog 2011-07-01 22:04:27 UTC (rev 90283)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 22:06:07 UTC (rev 90284)
@@ -1,3 +1,12 @@
+2011-07-01 Nate Chapin
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=63835.
+
+Reviewed by Dmitry Titov.
+
+* fast/workers/worker-finish-crash-expected.txt: Added.
+* fast/workers/worker-finish-crash.html: Added.
+
2011-07-01 Mihai Parparita
Reviewed by Darin Fisher.
Added: trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt (0 => 90284)
--- trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/workers/worker-finish-crash-expected.txt 2011-07-01 22:06:07 UTC (rev 90284)
@@ -0,0 +1,3 @@
+Test to ensure that finishing a Worker won't re-enter. We pass if we don't crash.
+
+
Added: trunk/LayoutTests/fast/workers/worker-finish-crash.html (0 => 90284)
--- trunk/LayoutTests/fast/workers/worker-finish-crash.html (rev 0)
+++ trunk/LayoutTests/fast/workers/worker-finish-crash.html 2011-07-01 22:06:07 UTC (rev 90284)
@@ -0,0 +1,18 @@
+
+Test to ensure that finishing a Worker won't re-enter. We pass if we don't crash.
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+var worker = new Worker("does-not-exist.js");
+worker._onerror_ = function() {
+window.stop();
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (90283 => 90284)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 22:04:27 UTC (rev 90283)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 22:06:07 UTC (rev 90284)
@@ -1,3 +1,17 @@
+2011-07-01 Nate Chapin
+
+Ensure WorkerScriptLoader::notifyFinished() doesn't re-enter.
+https://bugs.webkit.org/show_bug.cgi?id=63835
+
+Reviewed by Dmitry Titov.
+
+Test: fast/workers/worker-finish-crash.html
+
+* workers/WorkerScriptLoader.cpp:
+(WebCore::WorkerScriptLoader::WorkerScriptLoader):
+(WebCore::WorkerScriptLoader::notifyFinished):
+* workers/WorkerScriptLoader.h:
+
2011-07-01 Adrienne Walker
[chromium] Upload root layer textures first so that it is less likely to be skipped
Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (90283 => 90284)
--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2011-07-01 22:04:27 UTC (rev 90283)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2011-07-01 22:06:07 UTC (rev 90284)
@@ -52,6 +52,7 @@
, m_failed(false)
, m_identifier(0)
, m_targetType(targetType)
+, m_finishing(false)
{
}
@@ -181,8 +182,11 @@
void WorkerScriptLoader::notifyFinished()
{
-if (m_client)
-m_client->notifyFinished();
+if (!m_client || m_finishing)
+return;
+
+m_finishing = true;
+m_client->notifyFinished();
}
} // namespace WebCore
Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.h (90283 => 90284)
--- trunk/Source/WebCore/workers/WorkerScriptLoader.h 2011-07-01 22:04:27 UTC (rev 90283)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.h 2011-07-01 22:06:07 UTC (rev 90284)
@@ -92,6 +92,7 @@
bool m_failed;
unsigned long m_identifier;
ResourceRequestBase::TargetType m_targetType;
+bool m_finishing;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90283] trunk/Source/WebCore
Title: [90283] trunk/Source/WebCore
Revision 90283
Author e...@google.com
Date 2011-07-01 15:04:27 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adrienne Walker
[chromium] Upload root layer textures first so that it is less likely to be skipped
https://bugs.webkit.org/show_bug.cgi?id=63850
Reviewed by James Robinson.
This is a tiny follow-on patch to bug 63760. If the root layer is not
uploaded first, then it may not have enough space to fit into texture
memory and might be skipped, leaving a blue background.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::updateLayers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90282 => 90283)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 22:02:54 UTC (rev 90282)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 22:04:27 UTC (rev 90283)
@@ -1,3 +1,17 @@
+2011-07-01 Adrienne Walker
+
+[chromium] Upload root layer textures first so that it is less likely to be skipped
+https://bugs.webkit.org/show_bug.cgi?id=63850
+
+Reviewed by James Robinson.
+
+This is a tiny follow-on patch to bug 63760. If the root layer is not
+uploaded first, then it may not have enough space to fit into texture
+memory and might be skipped, leaving a blue background.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::updateLayers):
+
2011-07-01 Mihai Parparita
Reviewed by Darin Fisher.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (90282 => 90283)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-01 22:02:54 UTC (rev 90282)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-01 22:04:27 UTC (rev 90283)
@@ -349,13 +349,13 @@
#ifndef NDEBUG
s_inPaintLayerContents = false;
#endif
-
-updateCompositorResources(renderSurfaceLayerList);
// Update compositor resources for root layer.
{
TRACE_EVENT("LayerRendererChromium::updateLayer::updateRoot", this, 0);
m_rootLayerContentTiler->updateRect(m_rootLayerTextureUpdater.get());
}
+
+updateCompositorResources(renderSurfaceLayerList);
}
void LayerRendererChromium::paintLayerContents(const LayerList& renderSurfaceLayerList)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90282] trunk/Source/JavaScriptCore
Title: [90282] trunk/Source/_javascript_Core Revision 90282 Author oli...@apple.com Date 2011-07-01 15:02:54 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Oliver Hunt IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren() https://bugs.webkit.org/show_bug.cgi?id=63732 Reviewed by Gavin Barraclough. Initialise the memory at the head of the new storage so that GC is safe if triggered by reportExtraMemoryCost. * runtime/JSArray.cpp: (JSC::JSArray::increaseVectorPrefixLength): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSArray.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (90281 => 90282) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 22:02:44 UTC (rev 90281) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 22:02:54 UTC (rev 90282) @@ -1,5 +1,18 @@ 2011-07-01 Oliver Hunt +IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren() +https://bugs.webkit.org/show_bug.cgi?id=63732 + +Reviewed by Gavin Barraclough. + +Initialise the memory at the head of the new storage so that +GC is safe if triggered by reportExtraMemoryCost. + +* runtime/JSArray.cpp: +(JSC::JSArray::increaseVectorPrefixLength): + +2011-07-01 Oliver Hunt + GC sweep can occur before an object is completely initialised https://bugs.webkit.org/show_bug.cgi?id=63836 Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (90281 => 90282) --- trunk/Source/_javascript_Core/runtime/JSArray.cpp 2011-07-01 22:02:44 UTC (rev 90281) +++ trunk/Source/_javascript_Core/runtime/JSArray.cpp 2011-07-01 22:02:54 UTC (rev 90282) @@ -638,7 +638,10 @@ m_vectorLength = newLength; fastFree(storage->m_allocBase); - +ASSERT(newLength > vectorLength); +unsigned delta = newLength - vectorLength; +for (unsigned i = 0; i < delta; i++) +m_storage->m_vector[i].clear(); Heap::heap(this)->reportExtraMemoryCost(storageSize(newVectorLength) - storageSize(vectorLength)); return true; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90281] trunk
Title: [90281] trunk
Revision 90281
Author mih...@chromium.org
Date 2011-07-01 15:02:44 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Mihai Parparita
Reviewed by Darin Fisher.
location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777
* fast/history/location-replace-hash-expected.txt: Added.
* fast/history/location-replace-hash.html: Added.
* fast/history/resources/location-replace-hash-1.html: Added.
* fast/history/resources/location-replace-hash-2.html: Added.
2011-07-01 Mihai Parparita
Reviewed by Darin Fisher.
location.replace with a hash change does not update the history entry
https://bugs.webkit.org/show_bug.cgi?id=63777
location.replace('#foo') would not update the HistoryItem with the
new URL, thus navigating back to the page would use the previous
URL, even though it had been replaced. Make
HistoryController::updateForSameDocumentNavigation mirror
HistoryController::replaceState.
Test: fast/history/location-replace-hash.html
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForSameDocumentNavigation):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/HistoryController.cpp
Added Paths
trunk/LayoutTests/fast/history/location-replace-hash-expected.txt
trunk/LayoutTests/fast/history/location-replace-hash.html
trunk/LayoutTests/fast/history/resources/location-replace-hash-1.html
trunk/LayoutTests/fast/history/resources/location-replace-hash-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90280 => 90281)
--- trunk/LayoutTests/ChangeLog 2011-07-01 22:01:12 UTC (rev 90280)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 22:02:44 UTC (rev 90281)
@@ -1,3 +1,15 @@
+2011-07-01 Mihai Parparita
+
+Reviewed by Darin Fisher.
+
+location.replace with a hash change does not update the history entry
+https://bugs.webkit.org/show_bug.cgi?id=63777
+
+* fast/history/location-replace-hash-expected.txt: Added.
+* fast/history/location-replace-hash.html: Added.
+* fast/history/resources/location-replace-hash-1.html: Added.
+* fast/history/resources/location-replace-hash-2.html: Added.
+
2011-07-01 Ryosuke Niwa
Fix expected results after r90275. I checked in Mac-specific results for these tests.
Added: trunk/LayoutTests/fast/history/location-replace-hash-expected.txt (0 => 90281)
--- trunk/LayoutTests/fast/history/location-replace-hash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/history/location-replace-hash-expected.txt 2011-07-01 22:02:44 UTC (rev 90281)
@@ -0,0 +1,19 @@
+main frame - has 1 onunload handler(s)
+main frame - has 1 onunload handler(s)
+main frame - has 1 onunload handler(s)
+Tests that using location.replace to update the hash of a page preserves it when navigating back to it.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS currentPageId is 1
+PASS currentPageId is 1
+PASS testWindow.location.hash is "#foo"
+PASS currentPageId is 2
+PASS currentPageId is 1
+PASS testWindow.location.hash is "#foo"
+PASS Complete: navigated through all the states
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/history/location-replace-hash.html (0 => 90281)
--- trunk/LayoutTests/fast/history/location-replace-hash.html (rev 0)
+++ trunk/LayoutTests/fast/history/location-replace-hash.html 2011-07-01 22:02:44 UTC (rev 90281)
@@ -0,0 +1,70 @@
+
+
+
+
+
+
+description('Tests that using location.replace to update the hash of a page preserves it when navigating back to it.');
+
+jsTestIsAsync = true;
+
+var testWindow;
+
+_onload_ = function()
+{
+if (window.layoutTestController) {
+layoutTestController.setCanOpenWindows();
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+testWindow = window.open('resources/location-replace-hash-1.html');
+if (!testWindow)
+testFailed('Could not open test window');
+}
+
+var currentState = 0;
+var currentPageId;
+
+function onTestWindowNavigation(pageId)
+{
+// The page ID is put in a global so that the eval() inside of shouldBe can
+// see it
+currentPageId = pageId;
+currentState++;
+
+switch (currentState) {
+ case 1:
+ shouldBe('currentPageId', '1');
+ testWindow.location.replace('#foo');
+ break;
+ case 2:
+ shouldBe('currentPageId', '1');
+ shouldBe('testWindow.location.hash', '"#foo"');
+ testWindow.location = 'location-replace-hash-2.html';
+ break;
+ case 3:
+ shouldBe('currentPageId', '2');
+ testWindow.history.back();
+ break;
+ case 4:
+ shouldBe('currentPageId'
[webkit-changes] [90280] trunk/LayoutTests
Title: [90280] trunk/LayoutTests Revision 90280 Author rn...@webkit.org Date 2011-07-01 15:01:12 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Ryosuke Niwa Fix expected results after r90275. I checked in Mac-specific results for these tests. Move them to platform/mac and revert the changes in platform-independent results. Also copy results to platform/win because they fallback to Mac by default. * editing/deleting/delete-br-011-expected.txt: * editing/selection/anchor-focus2-expected.txt: * editing/selection/anchor-focus3-expected.txt: * platform/mac/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt. * platform/mac/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt. * platform/mac/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt. * platform/win/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt. * platform/win/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt. * platform/win/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/deleting/delete-br-011-expected.txt trunk/LayoutTests/editing/selection/anchor-focus2-expected.txt trunk/LayoutTests/editing/selection/anchor-focus3-expected.txt Added Paths trunk/LayoutTests/platform/mac/editing/deleting/delete-br-011-expected.txt trunk/LayoutTests/platform/mac/editing/selection/anchor-focus2-expected.txt trunk/LayoutTests/platform/mac/editing/selection/anchor-focus3-expected.txt trunk/LayoutTests/platform/win/editing/deleting/delete-br-011-expected.txt trunk/LayoutTests/platform/win/editing/selection/anchor-focus2-expected.txt trunk/LayoutTests/platform/win/editing/selection/anchor-focus3-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90279 => 90280) --- trunk/LayoutTests/ChangeLog 2011-07-01 21:47:44 UTC (rev 90279) +++ trunk/LayoutTests/ChangeLog 2011-07-01 22:01:12 UTC (rev 90280) @@ -1,5 +1,21 @@ 2011-07-01 Ryosuke Niwa +Fix expected results after r90275. I checked in Mac-specific results for these tests. +Move them to platform/mac and revert the changes in platform-independent results. +Also copy results to platform/win because they fallback to Mac by default. + +* editing/deleting/delete-br-011-expected.txt: +* editing/selection/anchor-focus2-expected.txt: +* editing/selection/anchor-focus3-expected.txt: +* platform/mac/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt. +* platform/mac/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt. +* platform/mac/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt. +* platform/win/editing/deleting/delete-br-011-expected.txt: Copied from LayoutTests/editing/deleting/delete-br-011-expected.txt. +* platform/win/editing/selection/anchor-focus2-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus2-expected.txt. +* platform/win/editing/selection/anchor-focus3-expected.txt: Copied from LayoutTests/editing/selection/anchor-focus3-expected.txt. + +2011-07-01 Ryosuke Niwa + Reviewed by Ojan Vafai. Move m_isDirectional from FrameSelection to VisibleSelection Modified: trunk/LayoutTests/editing/deleting/delete-br-011-expected.txt (90279 => 90280) --- trunk/LayoutTests/editing/deleting/delete-br-011-expected.txt 2011-07-01 21:47:44 UTC (rev 90279) +++ trunk/LayoutTests/editing/deleting/delete-br-011-expected.txt 2011-07-01 22:01:12 UTC (rev 90280) @@ -2,10 +2,6 @@ EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of DIV > BODY > HTML > #document to 2 of BODY > HTML > #document EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #docu
[webkit-changes] [90279] trunk/Tools
Title: [90279] trunk/Tools
Revision 90279
Author aba...@webkit.org
Date 2011-07-01 14:47:44 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Temporarily disable waiting for ReportCrash to see how this code
affects performance on the bots.
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py
Diff
Modified: trunk/Tools/ChangeLog (90278 => 90279)
--- trunk/Tools/ChangeLog 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/ChangeLog 2011-07-01 21:47:44 UTC (rev 90279)
@@ -1,3 +1,11 @@
+2011-07-01 Adam Barth
+
+Temporarily disable waiting for ReportCrash to see how this code
+affects performance on the bots.
+
+* Scripts/webkitpy/layout_tests/layout_package/manager.py:
+* Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
2011-07-01 Dmitry Lomov
Reviewed by Adam Roben.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py (90278 => 90279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 21:47:44 UTC (rev 90279)
@@ -668,9 +668,10 @@
try:
while not self.is_done():
-if self._port.executive().running_pids(self._port.is_crash_reporter):
-self._printer.print_update("Waiting for crash reporter ...")
-self._port.executive().wait_newest(self._port.is_crash_reporter)
+# Temporarily disabled to see how this code effect performance on the buildbots.
+# if self._port.executive().running_pids(self._port.is_crash_reporter):
+# self._printer.print_update("Waiting for crash reporter ...")
+# self._port.executive().wait_newest(self._port.is_crash_reporter)
manager_connection.run_message_loop(delay_secs=1.0)
# Make sure all of the workers have shut down (if possible).
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py (90278 => 90279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:44:03 UTC (rev 90278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:47:44 UTC (rev 90279)
@@ -130,7 +130,9 @@
# running. On Mac, ReportCrash chews up a bunch of resources and
# causes the tests to become unstable, so we don't want to run in
# parallel with ReportCrash.
-self._port.executive().wait_newest(self._port.is_crash_reporter)
+#
+# Temporarily disabled to see how this code effect performance on the buildbots.
+# self._port.executive().wait_newest(self._port.is_crash_reporter)
test_timeout_sec = self.timeout(test_input)
start = time.time()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90278] trunk/Tools
Title: [90278] trunk/Tools
Revision 90278
Author commit-qu...@webkit.org
Date 2011-07-01 14:44:03 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Dmitry Lomov
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=63818
Test bots shouldn't attempt to build TestWebKitAPI on Windows.
TestWebKitAPI builds as a part of general webkit build and is a
part of build products archive.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/run-api-tests:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-api-tests
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (90277 => 90278)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-01 21:44:03 UTC (rev 90278)
@@ -316,6 +316,12 @@
descriptionDone = ["unit-tests"]
command = ["perl", "./Tools/Scripts/run-api-tests", WithProperties("--%(configuration)s"), "--verbose"]
+def start(self):
+platform = self.getProperty('platform')
+if platform == 'win':
+self.setCommand(self.command + ['--no-build'])
+return shell.Test.start(self)
+
class RunPythonTests(shell.Test):
name = "webkitpy-test"
description = ["python-tests running"]
Modified: trunk/Tools/ChangeLog (90277 => 90278)
--- trunk/Tools/ChangeLog 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/ChangeLog 2011-07-01 21:44:03 UTC (rev 90278)
@@ -1,3 +1,15 @@
+2011-07-01 Dmitry Lomov
+
+Reviewed by Adam Roben.
+
+https://bugs.webkit.org/show_bug.cgi?id=63818
+Test bots shouldn't attempt to build TestWebKitAPI on Windows.
+TestWebKitAPI builds as a part of general webkit build and is a
+part of build products archive.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+* Scripts/run-api-tests:
+
2011-07-01 Adam Barth
We shouldn't wait for ReportCrash while the timeout is running
Modified: trunk/Tools/Scripts/run-api-tests (90277 => 90278)
--- trunk/Tools/Scripts/run-api-tests 2011-07-01 21:21:07 UTC (rev 90277)
+++ trunk/Tools/Scripts/run-api-tests 2011-07-01 21:44:03 UTC (rev 90278)
@@ -51,6 +51,8 @@
my $showHelp = 0;
my $verbose = 0;
my $dump = 0;
+my $build = 1;
+my $buildDefault = $build ? "build" : "do not build";
my $programName = basename($0);
my $usage = <@@ -58,12 +60,14 @@
--helpShow this help message
-v|--verbose Verbose output
-d|--dump-tests Dump the names of testcases without running them
+ --[no-]build Build (or do not build) unit tests prior to running (default: $buildDefault)
EOF
GetOptions(
'help' => \$showHelp,
'verbose|v' => \$verbose,
'dump|d' => \$dump,
+'build!' => \$build
);
if ($showHelp) {
@@ -72,7 +76,7 @@
}
setConfiguration();
-buildTestTool();
+buildTestTool() if $build;
setPathForRunningWebKitApp(\%ENV);
my %testsToRun = populateTests();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90277] trunk/Tools
Title: [90277] trunk/Tools
Revision 90277
Author aba...@webkit.org
Date 2011-07-01 14:21:07 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837
Reviewed by Eric Seidel.
Instead, we should move this check to worker.py.
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/layout_package/worker.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py
Diff
Modified: trunk/Tools/ChangeLog (90276 => 90277)
--- trunk/Tools/ChangeLog 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/ChangeLog 2011-07-01 21:21:07 UTC (rev 90277)
@@ -1,3 +1,15 @@
+2011-07-01 Adam Barth
+
+We shouldn't wait for ReportCrash while the timeout is running
+https://bugs.webkit.org/show_bug.cgi?id=63837
+
+Reviewed by Eric Seidel.
+
+Instead, we should move this check to worker.py.
+
+* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
+* Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
2011-07-01 Adam Roben
Stop setting unsafe headers on POSTs via XHR from TestFailures page
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py (90276 => 90277)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 21:21:07 UTC (rev 90277)
@@ -125,11 +125,6 @@
return self._run_compare_test()
def _run_compare_test(self):
-# Before running the test, we wait for any crash reporters to finish
-# running. On Mac, ReportCrash chews up a bunch of resources and
-# causes the tests to become unstable, so we don't want to run in
-# parallel with ReportCrash.
-self._port.executive().wait_newest(self._port.is_crash_reporter)
driver_output = self._driver.run_test(self._driver_input())
expected_driver_output = self._expected_driver_output()
test_result = self._compare_output(driver_output, expected_driver_output)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py (90276 => 90277)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:09:03 UTC (rev 90276)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py 2011-07-01 21:21:07 UTC (rev 90277)
@@ -126,6 +126,12 @@
self._done = True
def _run_test(self, test_input):
+# Before running the test, we wait for any crash reporters to finish
+# running. On Mac, ReportCrash chews up a bunch of resources and
+# causes the tests to become unstable, so we don't want to run in
+# parallel with ReportCrash.
+self._port.executive().wait_newest(self._port.is_crash_reporter)
+
test_timeout_sec = self.timeout(test_input)
start = time.time()
self._worker_connection.post_message('started_test', test_input, test_timeout_sec)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90276] trunk/Source/WebKit/qt
Title: [90276] trunk/Source/WebKit/qt Revision 90276 Author commit-qu...@webkit.org Date 2011-07-01 14:09:03 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Jade Han [Qt][Symbian] Update .def file for Symbian to build Tools https://bugs.webkit.org/show_bug.cgi?id=61200 Reviewed by Laszlo Gombos. Add newly introduced symbols to fix building the Tools directory for Symbian. * symbian/eabi/QtWebKitu.def: Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def Diff Modified: trunk/Source/WebKit/qt/ChangeLog (90275 => 90276) --- trunk/Source/WebKit/qt/ChangeLog 2011-07-01 21:07:39 UTC (rev 90275) +++ trunk/Source/WebKit/qt/ChangeLog 2011-07-01 21:09:03 UTC (rev 90276) @@ -1,7 +1,18 @@ 2011-07-01 Jade Han +[Qt][Symbian] Update .def file for Symbian to build Tools +https://bugs.webkit.org/show_bug.cgi?id=61200 + Reviewed by Laszlo Gombos. +Add newly introduced symbols to fix building the Tools directory for Symbian. + +* symbian/eabi/QtWebKitu.def: + +2011-07-01 Jade Han + +Reviewed by Laszlo Gombos. + [Qt][Symbian] Update .def file for Symbian https://bugs.webkit.org/show_bug.cgi?id=61200 Modified: trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def (90275 => 90276) --- trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-07-01 21:07:39 UTC (rev 90275) +++ trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-07-01 21:09:03 UTC (rev 90276) @@ -846,3 +846,35 @@ _ZN16QGraphicsWebView13setRenderHintEN8QPainter10RenderHintEb @ 845 NONAME _ZN16QGraphicsWebView14setRenderHintsE6QFlagsIN8QPainter10RenderHintEE @ 846 NONAME _ZNK16QGraphicsWebView11renderHintsEv @ 847 NONAME + _ZN18QWebSecurityOrigin24setApplicationCacheQuotaEx @ 848 NONAME + _ZN8QWebPage29applicationCacheQuotaExceededEP18QWebSecurityOriginy @ 849 NONAME + _ZNK8QWebView12hasSelectionEv @ 850 NONAME + _ZNK8QWebView12selectedHtmlEv @ 851 NONAME + _ZN23DumpRenderTreeSupportQt10findStringEP8QWebPageRK7QStringRK11QStringList @ 852 NONAME + _ZN23DumpRenderTreeSupportQt10shadowRootERK11QWebElement @ 853 NONAME + _ZN23DumpRenderTreeSupportQt11clearOpenerEP9QWebFrame @ 854 NONAME + _ZN23DumpRenderTreeSupportQt11contextMenuEP8QWebPage @ 855 NONAME + _ZN23DumpRenderTreeSupportQt13setAutofilledERK11QWebElementb @ 856 NONAME + _ZN23DumpRenderTreeSupportQt16addURLToRedirectERK7QStringS2_ @ 857 NONAME + _ZN23DumpRenderTreeSupportQt16ensureShadowRootERK11QWebElement @ 858 NONAME + _ZN23DumpRenderTreeSupportQt16removeShadowRootERK11QWebElement @ 859 NONAME + _ZN23DumpRenderTreeSupportQt16responseMimeTypeEP9QWebFrame @ 860 NONAME + _ZN23DumpRenderTreeSupportQt16setAlternateHtmlEP9QWebFrameRK7QStringRK4QUrlS7_ @ 861 NONAME + _ZN23DumpRenderTreeSupportQt20resetGeolocationMockEP8QWebPage @ 862 NONAME + _ZN23DumpRenderTreeSupportQt23setMinimumTimerIntervalEP8QWebPaged @ 863 NONAME + _ZN23DumpRenderTreeSupportQt24setMockDeviceOrientationEbdbdbd @ 864 NONAME + _ZN23DumpRenderTreeSupportQt25clearAllApplicationCachesEv @ 865 NONAME + _ZN23DumpRenderTreeSupportQt27defaultMinimumTimerIntervalEv @ 866 NONAME + _ZN23DumpRenderTreeSupportQt27removeMockDeviceOrientationEv @ 867 NONAME + _ZN23DumpRenderTreeSupportQt28setMockGeolocationPermissionEP8QWebPageb @ 868 NONAME + _ZN23DumpRenderTreeSupportQt33activeMockDeviceOrientationClientEb @ 869 NONAME + _ZN23DumpRenderTreeSupportQt44numberOfPendingGeolocationPermissionRequestsEP8QWebPage @ 870 NONAME + _ZN8QDRTNodeC1EPN7WebCore4NodeE @ 871 NONAME + _ZN8QDRTNodeC1ERKS_ @ 872 NONAME + _ZN8QDRTNodeC1Ev @ 873 NONAME + _ZN8QDRTNodeC2EPN7WebCore4NodeE @ 874 NONAME + _ZN8QDRTNodeC2ERKS_ @ 875 NONAME + _ZN8QDRTNodeC2Ev @ 876 NONAME + _ZN8QDRTNodeD1Ev @ 877 NONAME + _ZN8QDRTNodeD2Ev @ 878 NONAME + _ZN8QDRTNodeaSERKS_ @ 879 NONAME ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90274] trunk/LayoutTests
Title: [90274] trunk/LayoutTests Revision 90274 Author mih...@chromium.org Date 2011-07-01 13:52:04 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Mihai Parparita Add more Chromium flaky expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90273 => 90274) --- trunk/LayoutTests/ChangeLog 2011-07-01 20:45:52 UTC (rev 90273) +++ trunk/LayoutTests/ChangeLog 2011-07-01 20:52:04 UTC (rev 90274) @@ -1,5 +1,11 @@ 2011-07-01 Mihai Parparita +Add more Chromium flaky expectations. + +* platform/chromium/test_expectations.txt: + +2011-07-01 Mihai Parparita + Add more failing test expectations for Chromium media tests on Windows 7 and Vista. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90273 => 90274) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 20:45:52 UTC (rev 90273) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 20:52:04 UTC (rev 90274) @@ -4072,3 +4072,7 @@ BUGCR88197 VISTA WIN7 : media/video-autoplay.html = TIMEOUT BUGCR88197 VISTA WIN7 : media/video-buffered.html = TIMEOUT BUGCR88197 VISTA WIN7 CPU : media/video-canvas-alpha.html = TIMEOUT + +BUGWK63509 : editing/style/smoosh-styles-003.html = PASS IMAGE +BUGCR88230 VISTA : fast/dom/dom-parse-serialize-display.html = PASS TIMEOUT +BUGCR88232 WIN DEBUG : fast/dom/non-numeric-values-numeric-parameters.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90273] trunk/Source/JavaScriptCore
Title: [90273] trunk/Source/_javascript_Core
Revision 90273
Author oli...@apple.com
Date 2011-07-01 13:45:52 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Oliver Hunt
GC sweep can occur before an object is completely initialised
https://bugs.webkit.org/show_bug.cgi?id=63836
Reviewed by Gavin Barraclough.
In rare cases it's possible for a GC sweep to occur while a
live, but not completely initialised object is on the stack.
In such a case we may incorrectly choose to mark it, even
though it has no children that need marking.
We resolve this by always zeroing out the structure of any
value returned from JSCell::operator new(), and making the
markstack tolerant of a null structure.
* runtime/JSCell.h:
(JSC::JSCell::JSCell::~JSCell):
(JSC::JSCell::JSCell::operator new):
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/Structure.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90272 => 90273)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 20:42:08 UTC (rev 90272)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 20:45:52 UTC (rev 90273)
@@ -1,3 +1,25 @@
+2011-07-01 Oliver Hunt
+
+GC sweep can occur before an object is completely initialised
+https://bugs.webkit.org/show_bug.cgi?id=63836
+
+Reviewed by Gavin Barraclough.
+
+In rare cases it's possible for a GC sweep to occur while a
+live, but not completely initialised object is on the stack.
+In such a case we may incorrectly choose to mark it, even
+though it has no children that need marking.
+
+We resolve this by always zeroing out the structure of any
+value returned from JSCell::operator new(), and making the
+markstack tolerant of a null structure.
+
+* runtime/JSCell.h:
+(JSC::JSCell::JSCell::~JSCell):
+(JSC::JSCell::JSCell::operator new):
+* runtime/Structure.h:
+(JSC::MarkStack::internalAppend):
+
2011-07-01 Filip Pizlo
Reviewed by Gavin Barraclough.
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (90272 => 90273)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-01 20:42:08 UTC (rev 90272)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-01 20:45:52 UTC (rev 90273)
@@ -186,6 +186,9 @@
inline JSCell::~JSCell()
{
+#if ENABLE(GC_VALIDATION)
+m_structure.clear();
+#endif
}
inline Structure* JSCell::structure() const
@@ -356,12 +359,16 @@
inline void* JSCell::operator new(size_t size, JSGlobalData* globalData)
{
-return globalData->heap.allocate(size);
+JSCell* result = static_cast(globalData->heap.allocate(size));
+result->m_structure.clear();
+return result;
}
inline void* JSCell::operator new(size_t size, ExecState* exec)
{
-return exec->heap()->allocate(size);
+JSCell* result = static_cast(exec->heap()->allocate(size));
+result->m_structure.clear();
+return result;
}
inline void destructor(JSCell* cell)
Modified: trunk/Source/_javascript_Core/runtime/Structure.h (90272 => 90273)
--- trunk/Source/_javascript_Core/runtime/Structure.h 2011-07-01 20:42:08 UTC (rev 90272)
+++ trunk/Source/_javascript_Core/runtime/Structure.h 2011-07-01 20:45:52 UTC (rev 90273)
@@ -302,7 +302,7 @@
ASSERT(cell);
if (Heap::testAndSetMarked(cell))
return;
-if (cell->structure()->typeInfo().type() >= CompoundType)
+if (cell->structure() && cell->structure()->typeInfo().type() >= CompoundType)
m_values.append(cell);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90272] tags/Safari-534.50.2/Source/WebKit/mac
Title: [90272] tags/Safari-534.50.2/Source/WebKit/mac
Revision 90272
Author lforsch...@apple.com
Date 2011-07-01 13:42:08 -0700 (Fri, 01 Jul 2011)
Log Message
Merge 90223.
Modified Paths
tags/Safari-534.50.2/Source/WebKit/mac/ChangeLog
tags/Safari-534.50.2/Source/WebKit/mac/Misc/MailQuirksUserScript.js
Diff
Modified: tags/Safari-534.50.2/Source/WebKit/mac/ChangeLog (90271 => 90272)
--- tags/Safari-534.50.2/Source/WebKit/mac/ChangeLog 2011-07-01 20:29:55 UTC (rev 90271)
+++ tags/Safari-534.50.2/Source/WebKit/mac/ChangeLog 2011-07-01 20:42:08 UTC (rev 90272)
@@ -1,3 +1,31 @@
+2011-07-01 Lucas Forschler
+
+Merged 90233.
+
+2011-07-01 Andy Estes
+
+Reviewed by Mark Rowe.
+
+Simplify MailQuirksUserScript.js
+https://bugs.webkit.org/show_bug.cgi?id=63800
+
+MailQuirksUserScript.js is injected into WebViews in Mail.app on
+Leopard to resolve an incompatibility between it and the HTML5 parser.
+It did so by taking all nodes in the document between and
+and moving them to be children of . This maintains Mail.app's
+assumption that document.firstChild.firstChild == document.body.
+
+While this script fixed a specific issue with the Signature panel in
+Mail.app, it caused regressions in other WebViews. Since the issue with
+the Signature panel is with the empty node implicitly created by
+the parser, we can simplify this script by removing this implicit
+ in the case it has no attributes and no children. This fixes the
+Signature panel without affecting other WebViews that have non-trivial
+ nodes.
+
+* Misc/MailQuirksUserScript.js: If exists but has no attributes
+and no children, remove it.
+
2011-06-14 Lucas Forschler
Merged 88833.
Modified: tags/Safari-534.50.2/Source/WebKit/mac/Misc/MailQuirksUserScript.js (90271 => 90272)
--- tags/Safari-534.50.2/Source/WebKit/mac/Misc/MailQuirksUserScript.js 2011-07-01 20:29:55 UTC (rev 90271)
+++ tags/Safari-534.50.2/Source/WebKit/mac/Misc/MailQuirksUserScript.js 2011-07-01 20:42:08 UTC (rev 90272)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2010 Google Inc. All rights reserved.
+ * Copyright (C) 2011 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -29,29 +30,11 @@
*/
(function() {
-function childrenBefore(parent, stopAt)
-{
-var children = [];
-for (var child = parent.firstChild; child != stopAt; child = child.nextSibling)
-children.push(child);
-return children;
-}
-
-// If html or body is missing, Mail.app's assumption that
-// document.firstChild.firstChild == document.body is wrong anyway,
-// so return null to not move anything.
-if (!document.documentElement || !document.body)
-return;
-
-var children = childrenBefore(document, document.documentElement);
-children = children.concat(childrenBefore(document.documentElement, document.body));
-
-for (var i = children.length - 1; i >= 0; i--) {
-var child = children[i];
-// It's not possible to move doctype nodes into the body, so just remove them.
-if (child.nodeType == child.DOCUMENT_TYPE_NODE)
-child.parentNode.removeChild(child);
-else
-document.body.insertBefore(child, document.body.firstChild);
-}
+// The Mail.app signature panel makes the assumption that
+// document.firstChild.firstChild == document.body. This is no longer true
+// now that WebKit implements the HTML5 parser, which creates an implicit
+// node if not explicitly specified in content. Remove this implicit
+// so that Mail.app's assumption remains true.
+if (document.head && !document.head.childNodes.length && !document.head.attributes.length)
+document.documentElement.removeChild(document.head);
})();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90271] trunk/Source/WebCore
Title: [90271] trunk/Source/WebCore Revision 90271 Author t...@chromium.org Date 2011-07-01 13:29:55 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Tony Chang cleanup of flexbox and marquee data naming in StyleRareNonInheritedData https://bugs.webkit.org/show_bug.cgi?id=63827 Reviewed by Ojan Vafai. * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::boxAlign): (WebCore::InheritedFlags::boxFlex): (WebCore::InheritedFlags::boxFlexGroup): (WebCore::InheritedFlags::boxLines): (WebCore::InheritedFlags::boxOrdinalGroup): (WebCore::InheritedFlags::boxOrient): (WebCore::InheritedFlags::boxPack): (WebCore::InheritedFlags::marqueeIncrement): (WebCore::InheritedFlags::marqueeSpeed): (WebCore::InheritedFlags::marqueeLoopCount): (WebCore::InheritedFlags::marqueeBehavior): (WebCore::InheritedFlags::marqueeDirection): (WebCore::InheritedFlags::setBoxAlign): (WebCore::InheritedFlags::setBoxFlex): (WebCore::InheritedFlags::setBoxFlexGroup): (WebCore::InheritedFlags::setBoxLines): (WebCore::InheritedFlags::setBoxOrdinalGroup): (WebCore::InheritedFlags::setBoxOrient): (WebCore::InheritedFlags::setBoxPack): (WebCore::InheritedFlags::setMarqueeIncrement): (WebCore::InheritedFlags::setMarqueeSpeed): (WebCore::InheritedFlags::setMarqueeDirection): (WebCore::InheritedFlags::setMarqueeBehavior): (WebCore::InheritedFlags::setMarqueeLoopCount): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h Diff Modified: trunk/Source/WebCore/ChangeLog (90270 => 90271) --- trunk/Source/WebCore/ChangeLog 2011-07-01 20:27:46 UTC (rev 90270) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 20:29:55 UTC (rev 90271) @@ -1,3 +1,44 @@ +2011-07-01 Tony Chang + +cleanup of flexbox and marquee data naming in StyleRareNonInheritedData +https://bugs.webkit.org/show_bug.cgi?id=63827 + +Reviewed by Ojan Vafai. + +* rendering/style/RenderStyle.cpp: +(WebCore::RenderStyle::RenderStyle): +(WebCore::RenderStyle::diff): +* rendering/style/RenderStyle.h: +(WebCore::InheritedFlags::boxAlign): +(WebCore::InheritedFlags::boxFlex): +(WebCore::InheritedFlags::boxFlexGroup): +(WebCore::InheritedFlags::boxLines): +(WebCore::InheritedFlags::boxOrdinalGroup): +(WebCore::InheritedFlags::boxOrient): +(WebCore::InheritedFlags::boxPack): +(WebCore::InheritedFlags::marqueeIncrement): +(WebCore::InheritedFlags::marqueeSpeed): +(WebCore::InheritedFlags::marqueeLoopCount): +(WebCore::InheritedFlags::marqueeBehavior): +(WebCore::InheritedFlags::marqueeDirection): +(WebCore::InheritedFlags::setBoxAlign): +(WebCore::InheritedFlags::setBoxFlex): +(WebCore::InheritedFlags::setBoxFlexGroup): +(WebCore::InheritedFlags::setBoxLines): +(WebCore::InheritedFlags::setBoxOrdinalGroup): +(WebCore::InheritedFlags::setBoxOrient): +(WebCore::InheritedFlags::setBoxPack): +(WebCore::InheritedFlags::setMarqueeIncrement): +(WebCore::InheritedFlags::setMarqueeSpeed): +(WebCore::InheritedFlags::setMarqueeDirection): +(WebCore::InheritedFlags::setMarqueeBehavior): +(WebCore::InheritedFlags::setMarqueeLoopCount): +* rendering/style/StyleRareNonInheritedData.cpp: +(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): +(WebCore::StyleRareNonInheritedData::operator==): +* rendering/style/StyleRareNonInheritedData.h: +flexibleBox -> m_deprecatedFlexibleBox and marquee to m_marquee + 2011-07-01 Mike Reed Stop using deprecated SkDeviceFactory API Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (90270 => 90271) --- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2011-07-01 20:27:46 UTC (rev 90270) +++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2011-07-01 20:29:55 UTC (rev 90271) @@ -117,8 +117,8 @@ m_background.init(); surround.init(); rareNonInheritedData.init(); -rareNonInheritedData.access()->flexibleBox.init(); -rareNonInherite
[webkit-changes] [90270] trunk/Source/WebCore
Title: [90270] trunk/Source/WebCore
Revision 90270
Author commit-qu...@webkit.org
Date 2011-07-01 13:27:46 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Mike Reed
Stop using deprecated SkDeviceFactory API
https://bugs.webkit.org/show_bug.cgi?id=63488
Reviewed by James Robinson.
No new tests. Check-point for removing Factory API from Skia
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90269 => 90270)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 20:08:49 UTC (rev 90269)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 20:27:46 UTC (rev 90270)
@@ -1,3 +1,17 @@
+2011-07-01 Mike Reed
+
+Stop using deprecated SkDeviceFactory API
+https://bugs.webkit.org/show_bug.cgi?id=63488
+
+Reviewed by James Robinson.
+
+No new tests. Check-point for removing Factory API from Skia
+
+* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
+(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
+* platform/graphics/skia/PlatformContextSkia.cpp:
+(WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
+
2011-07-01 Jeffrey Pfau
Reviewed by Adam Barth.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp (90269 => 90270)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp 2011-07-01 20:08:49 UTC (rev 90269)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp 2011-07-01 20:27:46 UTC (rev 90270)
@@ -240,10 +240,8 @@
targetDesc.fStencilBits = 8;
targetDesc.fPlatformRenderTarget = m_fbo;
SkAutoTUnref target(static_cast(m_skiaContext->createPlatformSurface(targetDesc)));
-SkAutoTUnref factory(new SkGpuDeviceFactory(m_skiaContext, target.get()));
-SkAutoTUnref device(factory.get()->newDevice(0, SkBitmap::kARGB__Config, m_bufferSize.width(), m_bufferSize.height(), false, false));
-m_canvas = adoptPtr(new SkCanvas(factory.get()));
-m_canvas->setDevice(device.get());
+SkAutoTUnref device(new SkGpuDevice(m_skiaContext, target.get()));
+m_canvas = adoptPtr(new SkCanvas(device.get()));
context()->bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, 0);
return true;
Modified: trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp (90269 => 90270)
--- trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2011-07-01 20:08:49 UTC (rev 90269)
+++ trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp 2011-07-01 20:27:46 UTC (rev 90270)
@@ -740,17 +740,8 @@
GrPlatformSurfaceDesc drawBufDesc;
drawingBuffer->getGrPlatformSurfaceDesc(&drawBufDesc);
-GrTexture* drawBufTex = static_cast(gr->createPlatformSurface(drawBufDesc));
-// FIXME: This should use a smart pointer.
-SkDeviceFactory* factory = new SkGpuDeviceFactory(gr, drawBufTex);
-// FIXME: This should use a smart pointer.
-drawBufTex->unref();
-
-// FIXME: This should use a smart pointer.
-SkDevice* device = factory->newDevice(m_canvas, SkBitmap::kARGB__Config, drawingBuffer->size().width(), drawingBuffer->size().height(), false, false);
-// FIXME: This should use a smart pointer.
-m_canvas->setDevice(device)->unref();
-m_canvas->setDeviceFactory(factory)->unref();
+SkAutoTUnref drawBufTex(static_cast(gr->createPlatformSurface(drawBufDesc)));
+m_canvas->setDevice(new SkGpuDevice(gr, drawBufTex.get()))->unref();
} else
m_accelerationMode = GPU;
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90268] trunk/Source/JavaScriptCore
Title: [90268] trunk/Source/_javascript_Core
Revision 90268
Author commit-qu...@webkit.org
Date 2011-07-01 13:04:24 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Filip Pizlo
Reviewed by Gavin Barraclough.
DFG non-speculative JIT always performs slow C calls for div and mod.
https://bugs.webkit.org/show_bug.cgi?id=63684
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90267 => 90268)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 19:54:29 UTC (rev 90267)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 20:04:24 UTC (rev 90268)
@@ -1,3 +1,13 @@
+2011-07-01 Filip Pizlo
+
+Reviewed by Gavin Barraclough.
+
+DFG non-speculative JIT always performs slow C calls for div and mod.
+https://bugs.webkit.org/show_bug.cgi?id=63684
+
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::compile):
+
2011-07-01 Juan C. Montemayor
Reviewed by Oliver Hunt.
Modified: trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp (90267 => 90268)
--- trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp 2011-07-01 19:54:29 UTC (rev 90267)
+++ trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp 2011-07-01 20:04:24 UTC (rev 90268)
@@ -590,39 +590,120 @@
}
case ArithDiv: {
-JSValueOperand arg1(this, node.child1);
-JSValueOperand arg2(this, node.child2);
-GPRReg arg1GPR = arg1.gpr();
-GPRReg arg2GPR = arg2.gpr();
+DoubleOperand op1(this, node.child1);
+DoubleOperand op2(this, node.child2);
+FPRTemporary result(this, op1);
+FPRReg op1FPR = op1.fpr();
+FPRReg op2FPR = op2.fpr();
+FPRReg resultFPR = result.fpr();
-flushRegisters();
-
-GPRResult result(this);
-
-ASSERT(isFlushed());
-setupTwoStubArgs(arg1GPR, arg2GPR);
-m_jit.appendCall(operationArithDiv);
-m_jit.move(GPRInfo::returnValueGPR, result.gpr());
-
-jsValueResult(result.gpr(), m_compileIndex);
+m_jit.divDouble(op1FPR, op2FPR, resultFPR);
+
+doubleResult(resultFPR, m_compileIndex);
break;
}
case ArithMod: {
-JSValueOperand arg1(this, node.child1);
-JSValueOperand arg2(this, node.child2);
-GPRReg arg1GPR = arg1.gpr();
-GPRReg arg2GPR = arg2.gpr();
-flushRegisters();
+JSValueOperand op1(this, node.child1);
+JSValueOperand op2(this, node.child2);
+GPRTemporary eax(this, X86Registers::eax);
+GPRTemporary edx(this, X86Registers::edx);
-GPRResult result(this);
+FPRTemporary op1Double(this);
+FPRTemporary op2Double(this);
+
+GPRReg op1GPR = op1.gpr();
+GPRReg op2GPR = op2.gpr();
+
+FPRReg op1FPR = op1Double.fpr();
+FPRReg op2FPR = op2Double.fpr();
+
+JITCompiler::Jump firstOpNotInt;
+JITCompiler::Jump secondOpNotInt;
+JITCompiler::JumpList done;
+JITCompiler::Jump modByZero;
+
+if (!isKnownInteger(node.child1))
+firstOpNotInt = m_jit.branchPtr(MacroAssembler::Below, op1GPR, GPRInfo::tagTypeNumberRegister);
+if (!isKnownInteger(node.child2))
+secondOpNotInt = m_jit.branchPtr(MacroAssembler::Below, op2GPR, GPRInfo::tagTypeNumberRegister);
+
+modByZero = m_jit.branchTest32(MacroAssembler::Zero, op2GPR);
+
+GPRReg temp2 = InvalidGPRReg;
+if (op2GPR == X86Registers::eax || op2GPR == X86Registers::edx) {
+temp2 = allocate();
+m_jit.move(op2GPR, temp2);
+op2GPR = temp2;
+}
+
+m_jit.move(op1GPR, eax.gpr());
+m_jit.assembler().cdq();
+m_jit.assembler().idivl_r(op2GPR);
+
+if (temp2 != InvalidGPRReg)
+unlock(temp2);
+
+m_jit.orPtr(GPRInfo::tagTypeNumberRegister, X86Registers::edx);
+
+done.append(m_jit.jump());
+
+JITCompiler::Jump gotDoubleArgs;
+
+modByZero.link(&m_jit);
+
+m_jit.move(MacroAssembler::TrustedImmPtr(JSValue::encode(jsNumber(std::numeric_limits::quiet_NaN(, X86Registers::edx);
+done.append(m_jit.jump());
+
+if (!isKnownInteger(node.child1)) {
+firstOpNotInt.link(&m_jit);
+
+JITCompiler::Jump secondOpNotInt2;
+
+if (!isKnownInteger(node.child2))
+secondOpNotInt2 = m_jit.branchPtr(MacroAssembler::Below, op2GPR, GPRInfo::tagTypeNumberRegister);
+
+// first op is a double, second op is an int.
+m_jit.convertInt32ToDouble(op2GPR, op2FPR);
-ASSERT(isFlushed());
-setupTwoStubArgs(arg1GPR,
[webkit-changes] [90267] trunk/LayoutTests
Title: [90267] trunk/LayoutTests Revision 90267 Author mih...@chromium.org Date 2011-07-01 12:54:29 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Mihai Parparita Add more failing test expectations for Chromium media tests on Windows 7 and Vista. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90266 => 90267) --- trunk/LayoutTests/ChangeLog 2011-07-01 19:49:24 UTC (rev 90266) +++ trunk/LayoutTests/ChangeLog 2011-07-01 19:54:29 UTC (rev 90267) @@ -1,3 +1,10 @@ +2011-07-01 Mihai Parparita + +Add more failing test expectations for Chromium media tests on Windows 7 +and Vista. + +* platform/chromium/test_expectations.txt: + 2011-07-01 Juan C. Montemayor Reviewed by Oliver Hunt. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90266 => 90267) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 19:49:24 UTC (rev 90266) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 19:54:29 UTC (rev 90267) @@ -2914,7 +2914,7 @@ BUGCR74979 GPU MAC SKIP: media/video-canvas-alpha.html = IMAGE // This test needs completely new baselines. -BUGWK55718 BUGCR75354 : media/media-document-audio-repaint.html = PASS FAIL +BUGWK55718 BUGCR75354 XP MAC LINUX : media/media-document-audio-repaint.html = IMAGE+TEXT BUGWK55968 BUGWK58306 GPU MAC : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE+TEXT CRASH BUGWK55968 GPU WIN DEBUG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE @@ -2928,8 +2928,6 @@ BUGCR78999 WIN LINUX GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE+TEXT BUGCR78999 MAC GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE - - BUGCR72223 : media/video-frame-accurate-seek.html = IMAGE BUGWK53868 : fast/notifications/notifications-document-close-crash.html = PASS TEXT @@ -3583,8 +3581,6 @@ BUGDPRANKE : http/tests/navigation/redirect-on-back-updates-history-item.html = TIMEOUT PASS BUGWK60125 : fast/files/create-blob-url-crash.html = CRASH PASS -BUGWK60122 DEBUG : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS - // flakiness BUGDPRANKE : fast/dom/Document/document-reopen.html = TEXT PASS @@ -4033,10 +4029,8 @@ BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH // Caused by an ffmpeg roll +BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT -BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT -BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT -BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT @@ -4047,6 +4041,10 @@ BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT +BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT +BUGCR88197 VISTA WIN7 : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS +BUGCR88197 VISTA WIN7 : http/tests/security/local-video-source-from-remote.html = TEXT BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT @@ -4056,3 +4054,21 @@ BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS +BUGCR88197 VISTA WIN7 : media/controls-after-reload.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/controls-drag-timebar.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/controls-right-click-on-timebar.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/controls-strict.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/controls-styling.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/controls-without-preload.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/event-attributes.html = TEXT +BUGCR88197 VISTA WIN7 : media/media-blocked-by-beforeload.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/media-document-audio-repaint.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/media-ended.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/media-load-event.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/media-startT
[webkit-changes] [90266] trunk
Title: [90266] trunk Revision 90266 Author t...@chromium.org Date 2011-07-01 12:49:24 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Tony Chang Add chromium sql directory to git ignore. * .gitignore: Modified Paths trunk/.gitignore trunk/ChangeLog Diff Modified: trunk/.gitignore (90265 => 90266) --- trunk/.gitignore 2011-07-01 19:47:05 UTC (rev 90265) +++ trunk/.gitignore 2011-07-01 19:49:24 UTC (rev 90266) @@ -70,6 +70,7 @@ Source/WebKit/chromium/printing/ Source/WebKit/chromium/sdch/ Source/WebKit/chromium/skia/ +Source/WebKit/chromium/sql/ Source/WebKit/chromium/testing/ Source/WebKit/chromium/third_party/ Source/WebKit/chromium/tools/ Modified: trunk/ChangeLog (90265 => 90266) --- trunk/ChangeLog 2011-07-01 19:47:05 UTC (rev 90265) +++ trunk/ChangeLog 2011-07-01 19:49:24 UTC (rev 90266) @@ -1,3 +1,9 @@ +2011-07-01 Tony Chang + +Add chromium sql directory to git ignore. + +* .gitignore: + 2011-07-01 Patrick Gansterer Reviewed by Daniel Bates. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90264] trunk/Tools
Title: [90264] trunk/Tools
Revision 90264
Author aro...@apple.com
Date 2011-07-01 12:39:57 -0700 (Fri, 01 Jul 2011)
Log Message
Stop setting unsafe headers on POSTs via XHR from TestFailures page
Fixes TestFailures page causes a bunch of spew in the
Inspector's console about unsafe headers
Reviewed by Dan Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js (90263 => 90264)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js 2011-07-01 19:36:16 UTC (rev 90263)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js 2011-07-01 19:39:57 UTC (rev 90264)
@@ -60,8 +60,6 @@
var data = ""
xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');
-xhr.setRequestHeader('Content-Length', data.length);
-xhr.setRequestHeader('Connection', 'close');
xhr.send(data);
}
Modified: trunk/Tools/ChangeLog (90263 => 90264)
--- trunk/Tools/ChangeLog 2011-07-01 19:36:16 UTC (rev 90263)
+++ trunk/Tools/ChangeLog 2011-07-01 19:39:57 UTC (rev 90264)
@@ -1,3 +1,15 @@
+2011-07-01 Adam Roben
+
+Stop setting unsafe headers on POSTs via XHR from TestFailures page
+
+Fixes TestFailures page causes a bunch of spew in the
+Inspector's console about unsafe headers
+
+Reviewed by Dan Bates.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
+(fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
+
2011-07-01 Eric Seidel
Reviewed by Adam Barth.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90263] trunk/Tools
Title: [90263] trunk/Tools
Revision 90263
Author aba...@webkit.org
Date 2011-07-01 12:36:16 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Eric Seidel
Reviewed by Adam Barth.
Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
https://bugs.webkit.org/show_bug.cgi?id=63786
We're down to one bug blocking the "move to NRWT" bug:
https://bugs.webkit.org/show_bug.cgi?id=34984
so we're trying transitioning Snow Leopard to NRWT as an experiment.
If we run into any blocking issues we'll of course roll this back out
(or anyone reading this should feel encouraged to).
* Scripts/run-webkit-tests:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (90262 => 90263)
--- trunk/Tools/ChangeLog 2011-07-01 19:33:56 UTC (rev 90262)
+++ trunk/Tools/ChangeLog 2011-07-01 19:36:16 UTC (rev 90263)
@@ -1,3 +1,19 @@
+2011-07-01 Eric Seidel
+
+Reviewed by Adam Barth.
+
+Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
+https://bugs.webkit.org/show_bug.cgi?id=63786
+
+We're down to one bug blocking the "move to NRWT" bug:
+https://bugs.webkit.org/show_bug.cgi?id=34984
+so we're trying transitioning Snow Leopard to NRWT as an experiment.
+
+If we run into any blocking issues we'll of course roll this back out
+(or anyone reading this should feel encouraged to).
+
+* Scripts/run-webkit-tests:
+
2011-07-01 Adam Barth
Add a compat shim for --leaks. Support for --leaks will be added in
Modified: trunk/Tools/Scripts/run-webkit-tests (90262 => 90263)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-01 19:33:56 UTC (rev 90262)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-01 19:36:16 UTC (rev 90263)
@@ -55,28 +55,32 @@
return $isBuildBotUser{$ENV{"USER"}};
}
+sub usingWebKit2()
+{
+# If either -2 or --webkit-test-runner is passed, we're supposed to use WebKit2.
+# NRWT's WebKit2 support is still a work in progress:
+# https://bugs.webkit.org/show_bug.cgi?id=56729
+return grep(/(-2|--webkit-test-runner)/, @ARGV);
+}
+
sub useNewRunWebKitTests()
{
# Change this check to control which platforms use
# new-run-webkit-tests by default.
# Example: return runningOnBuildBot() && isLeopard();
# would enable new-run-webkit-tests on only the leopard buildbots.
-return 0;
+return (isSnowLeopard() and !usingWebKit2());
}
my $harnessName = "old-run-webkit-tests";
if (useNewRunWebKitTests()) {
$harnessName = "new-run-webkit-tests";
+push(@ARGV, "--child-processes=1");
+print "Running new-run-webkit-tests with one child process.\n";
+print "For more parallelism, run new-run-webkit-tests directly.\n";
if (runningOnBuildBot()) {
push(@ARGV, "--verbose");
-# old-run-webkit-tests treats --results-directory as $CWD relative.
-# new-run-webkit-tests treats --results-directory as build directory relative.
-# Override the passed in --results-directory by appending a new one
-# (later arguments override earlier ones in Python's optparse).
-push(@ARGV, "--results-directory");
-# The buildbot always uses $SRCDIR/layout-test-results, hardcode it:
-push(@ARGV, sourceDir() . "/layout-test-results");
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90262] trunk/Tools
Title: [90262] trunk/Tools
Revision 90262
Author aba...@webkit.org
Date 2011-07-01 12:33:56 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Add a compat shim for --leaks. Support for --leaks will be added in
https://bugs.webkit.org/show_bug.cgi?id=63832.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (90261 => 90262)
--- trunk/Tools/ChangeLog 2011-07-01 19:25:15 UTC (rev 90261)
+++ trunk/Tools/ChangeLog 2011-07-01 19:33:56 UTC (rev 90262)
@@ -1,5 +1,12 @@
2011-07-01 Adam Barth
+Add a compat shim for --leaks. Support for --leaks will be added in
+https://bugs.webkit.org/show_bug.cgi?id=63832.
+
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
+2011-07-01 Adam Barth
+
Reviewed by Darin Adler.
ReportCrash destabilizes new-run-webkit-tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (90261 => 90262)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-07-01 19:25:15 UTC (rev 90261)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-07-01 19:33:56 UTC (rev 90262)
@@ -278,8 +278,11 @@
# FIXME: Need: -l --leaksEnable leaks checking.
old_run_webkit_tests_compat = [
-# FIXME: NRWT needs to support remote links eventually.
+# FIXME: Remove this option once the bots don't refer to it.
+# results.html is smart enough to figure this out itself.
_compat_shim_option("--use-remote-links-to-tests"),
+# FIXME: Implement leak detection.
+_compat_shim_option("--leaks"),
]
results_options = [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90261] trunk/LayoutTests
Title: [90261] trunk/LayoutTests
Revision 90261
Author aro...@apple.com
Date 2011-07-01 12:25:15 -0700 (Fri, 01 Jul 2011)
Log Message
Add Leopard expected failure result for media/media-blocked-by-beforeload.html
The failure is tracked by .
* platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90260 => 90261)
--- trunk/LayoutTests/ChangeLog 2011-07-01 19:24:59 UTC (rev 90260)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 19:25:15 UTC (rev 90261)
@@ -1,3 +1,11 @@
+2011-07-01 Adam Roben
+
+Add Leopard expected failure result for media/media-blocked-by-beforeload.html
+
+The failure is tracked by .
+
+* platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
+
2011-07-01 Sheriff Bot
Unreviewed, rolling out r90254.
Added: trunk/LayoutTests/platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt (0 => 90261)
--- trunk/LayoutTests/platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-leopard/media/media-blocked-by-beforeload-expected.txt 2011-07-01 19:25:15 UTC (rev 90261)
@@ -0,0 +1,36 @@
+Test to ensure that a media file blocked by a beforeload handler generates an error and does not block the document's 'load' event.
+
+*** Test initial state ***
+EXPECTED (video.networkState == '0') OK
+EXPECTED (video.error == 'null') OK
+
+*** Test blocking the 'src' attribute ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of 'src'
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+EXPECTED (video.error != 'null') OK
+EXPECTED (video.error.code == '4') OK
+EXPECTED (video.networkState == '3') OK
+
+*** Test using the element ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of first element
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+allowing load of second element
+
+EVENT('loadstart')
+
+EVENT('loadedmetadata')
+
+END OF TEST
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90260] trunk/Source/WebCore
Title: [90260] trunk/Source/WebCore Revision 90260 Author vange...@chromium.org Date 2011-07-01 12:24:59 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Vangelis Kokkevis Reviewed by James Robinson. [chromium] Reserve all tile textures at layer update time to guarantee that they will be available at draw time. https://bugs.webkit.org/show_bug.cgi?id=63760 In addition, this patch unreserves textures used by RenderSurface's right after the RenderSurface has been used to free up memory for subsequent RenderSurfaces. This patch also "fixes" the pages that display a blue background when running out of texture memory as the root layer tiles get reserved first and are guaranteed to get textures. * platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::ContentLayerChromium): (WebCore::ContentLayerChromium::visibleLayerRect): (WebCore::ContentLayerChromium::setIsMask): * platform/graphics/chromium/ContentLayerChromium.h: * platform/graphics/chromium/ImageLayerChromium.cpp: (WebCore::ImageLayerChromium::paintContentsIfDirty): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::paintLayerContents): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedObjects): * platform/graphics/chromium/LayerTexture.cpp: (WebCore::LayerTexture::unreserve): * platform/graphics/chromium/LayerTexture.h: * platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::prepareToUpdate): (WebCore::LayerTilerChromium::updateRect): (WebCore::LayerTilerChromium::drawTiles): * platform/graphics/chromium/RenderSurfaceChromium.cpp: (WebCore::RenderSurfaceChromium::releaseContentsTexture): * platform/graphics/chromium/RenderSurfaceChromium.h: * platform/graphics/chromium/TextureManager.cpp: (WebCore::TextureManager::unprotectTexture): * platform/graphics/chromium/TextureManager.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerTexture.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerTexture.h trunk/Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp trunk/Source/WebCore/platform/graphics/chromium/TextureManager.h Diff Modified: trunk/Source/WebCore/ChangeLog (90259 => 90260) --- trunk/Source/WebCore/ChangeLog 2011-07-01 19:23:21 UTC (rev 90259) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 19:24:59 UTC (rev 90260) @@ -1,3 +1,44 @@ +2011-07-01 Vangelis Kokkevis + +Reviewed by James Robinson. + +[chromium] Reserve all tile textures at layer update time to guarantee +that they will be available at draw time. +https://bugs.webkit.org/show_bug.cgi?id=63760 + +In addition, this patch unreserves textures used by RenderSurface's +right after the RenderSurface has been used to free up memory for +subsequent RenderSurfaces. + +This patch also "fixes" the pages that display a blue background when +running out of texture memory as the root layer tiles get reserved first +and are guaranteed to get textures. + +* platform/graphics/chromium/ContentLayerChromium.cpp: +(WebCore::ContentLayerChromium::ContentLayerChromium): +(WebCore::ContentLayerChromium::visibleLayerRect): +(WebCore::ContentLayerChromium::setIsMask): +* platform/graphics/chromium/ContentLayerChromium.h: +* platform/graphics/chromium/ImageLayerChromium.cpp: +(WebCore::ImageLayerChromium::paintContentsIfDirty): +* platform/graphics/chromium/LayerRendererChromium.cpp: +(WebCore::LayerRendererChromium::paintLayerContents): +(WebCore::LayerRendererChromium::drawLayer): +(WebCore::LayerRendererChromium::initializeSharedObjects): +* platform/graphics/chromium/LayerTexture.cpp: +(WebCore::LayerTexture::unreserve): +* platform/graphics/chromium/LayerTexture.h: +* platform/graphics/chromium/LayerTilerChromium.cpp: +(WebCore::LayerTilerChromium::prepareToUpdate): +(WebCore::LayerTilerChromium::updateRect): +(WebCore::LayerTilerChromium::drawTiles): +* platform/graphics/chromium/RenderSu
[webkit-changes] [90258] trunk/LayoutTests
Title: [90258] trunk/LayoutTests
Revision 90258
Author kbal...@webkit.org
Date 2011-07-01 12:14:38 -0700 (Fri, 01 Jul 2011)
Log Message
Reviewed by Andreas Kling.
[Qt][WK2] netscape-dom-access.html needs new result
https://bugs.webkit.org/show_bug.cgi?id=63454
* platform/qt-wk2/Skipped:
* platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
Added Paths
trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90257 => 90258)
--- trunk/LayoutTests/ChangeLog 2011-07-01 19:10:54 UTC (rev 90257)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 19:14:38 UTC (rev 90258)
@@ -112,6 +112,16 @@
Reviewed by Andreas Kling.
+[Qt][WK2] netscape-dom-access.html needs new result
+https://bugs.webkit.org/show_bug.cgi?id=63454
+
+* platform/qt-wk2/Skipped:
+* platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
+
+2011-07-01 Balazs Kelemen
+
+Reviewed by Andreas Kling.
+
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (90257 => 90258)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 19:10:54 UTC (rev 90257)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 19:14:38 UTC (rev 90258)
@@ -353,7 +353,6 @@
# Unexplained plugin failures
plugins/embed-prefers-plugins-for-images.html
-plugins/netscape-dom-access.html
plugins/npp-set-window-called-during-destruction.html
plugins/reloadplugins-and-pages.html
Added: trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt (0 => 90258)
--- trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt 2011-07-01 19:14:38 UTC (rev 90258)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x44
+RenderText {#text} at (0,0) size 769x44
+ text run at (0,0) width 537: "This page tests whether Netscape plug-ins can access their own DOM elements. "
+ text run at (537,0) width 232: "The plug-in should have a 3px red"
+ text run at (0,22) width 51: "border."
+ RenderBlock (anonymous) at (0,60) size 784x206
+RenderEmbeddedObject {EMBED} at (0,0) size 206x206 [border: (3px solid #FF)]
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90257] trunk/LayoutTests
Title: [90257] trunk/LayoutTests
Revision 90257
Author kbal...@webkit.org
Date 2011-07-01 12:10:54 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Sheriff Bot
Unreviewed, rolling out r90254.
http://trac.webkit.org/changeset/90254
https://bugs.webkit.org/show_bug.cgi?id=63825
"committed with a totally broken changelog" (Requested by
kbalazs on #webkit).
* platform/qt-wk2/Skipped:
* platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
Removed Paths
trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90256 => 90257)
--- trunk/LayoutTests/ChangeLog 2011-07-01 18:55:38 UTC (rev 90256)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 19:10:54 UTC (rev 90257)
@@ -1,3 +1,15 @@
+2011-07-01 Sheriff Bot
+
+Unreviewed, rolling out r90254.
+http://trac.webkit.org/changeset/90254
+https://bugs.webkit.org/show_bug.cgi?id=63825
+
+"committed with a totally broken changelog" (Requested by
+kbalazs on #webkit).
+
+* platform/qt-wk2/Skipped:
+* platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Removed.
+
2011-07-01 Hans Wennborg
Reviewed by Tony Chang.
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (90256 => 90257)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 18:55:38 UTC (rev 90256)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 19:10:54 UTC (rev 90257)
@@ -353,6 +353,7 @@
# Unexplained plugin failures
plugins/embed-prefers-plugins-for-images.html
+plugins/netscape-dom-access.html
plugins/npp-set-window-called-during-destruction.html
plugins/reloadplugins-and-pages.html
Deleted: trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt (90256 => 90257)
--- trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt 2011-07-01 18:55:38 UTC (rev 90256)
+++ trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt 2011-07-01 19:10:54 UTC (rev 90257)
@@ -1,13 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {P} at (0,0) size 784x44
-RenderText {#text} at (0,0) size 769x44
- text run at (0,0) width 537: "This page tests whether Netscape plug-ins can access their own DOM elements. "
- text run at (537,0) width 232: "The plug-in should have a 3px red"
- text run at (0,22) width 51: "border."
- RenderBlock (anonymous) at (0,60) size 784x206
-RenderEmbeddedObject {EMBED} at (0,0) size 206x206 [border: (3px solid #FF)]
-RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90256] tags/Safari-534.50.2/Source
Title: [90256] tags/Safari-534.50.2/Source Revision 90256 Author lforsch...@apple.com Date 2011-07-01 11:55:38 -0700 (Fri, 01 Jul 2011) Log Message Versioning. Modified Paths tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig (90255 => 90256) --- tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-01 18:54:08 UTC (rev 90255) +++ tags/Safari-534.50.2/Source/_javascript_Core/Configurations/Version.xcconfig 2011-07-01 18:55:38 UTC (rev 90256) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig (90255 => 90256) --- tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-01 18:54:08 UTC (rev 90255) +++ tags/Safari-534.50.2/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-07-01 18:55:38 UTC (rev 90256) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig (90255 => 90256) --- tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig 2011-07-01 18:54:08 UTC (rev 90255) +++ tags/Safari-534.50.2/Source/WebCore/Configurations/Version.xcconfig 2011-07-01 18:55:38 UTC (rev 90256) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig (90255 => 90256) --- tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-01 18:54:08 UTC (rev 90255) +++ tags/Safari-534.50.2/Source/WebKit/mac/Configurations/Version.xcconfig 2011-07-01 18:55:38 UTC (rev 90256) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig (90255 => 90256) --- tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig 2011-07-01 18:54:08 UTC (rev 90255) +++ tags/Safari-534.50.2/Source/WebKit2/Configurations/Version.xcconfig 2011-07-01 18:55:38 UTC (rev 90256) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 50; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90255] tags/Safari-534.50.2/
Title: [90255] tags/Safari-534.50.2/ Revision 90255 Author lforsch...@apple.com Date 2011-07-01 11:54:08 -0700 (Fri, 01 Jul 2011) Log Message New tag. Added Paths tags/Safari-534.50.2/ Diff Property changes: tags/Safari-534.50.2 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90254] trunk/LayoutTests
Title: [90254] trunk/LayoutTests
Revision 90254
Author kbal...@webkit.org
Date 2011-07-01 11:53:56 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Hans Wennborg
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-wk2/Skipped
Added Paths
trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90253 => 90254)
--- trunk/LayoutTests/ChangeLog 2011-07-01 18:50:29 UTC (rev 90253)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 18:53:56 UTC (rev 90254)
@@ -90,6 +90,16 @@
Reviewed by Andreas Kling.
+[Qt][WK2] netscape-dom-access.html needs new result
+https://bugs.webkit.org/show_bug.cgi?id=63454
+
+* platform/qt-wk2/Skipped:
+* platform/qt-wk2/plugins/netscape-dom-access-expected.txt: Added.
+
+2011-07-01 Balazs Kelemen
+
+Reviewed by Andreas Kling.
+
[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239
Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (90253 => 90254)
--- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 18:50:29 UTC (rev 90253)
+++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 18:53:56 UTC (rev 90254)
@@ -353,7 +353,6 @@
# Unexplained plugin failures
plugins/embed-prefers-plugins-for-images.html
-plugins/netscape-dom-access.html
plugins/npp-set-window-called-during-destruction.html
plugins/reloadplugins-and-pages.html
Added: trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt (0 => 90254)
--- trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt 2011-07-01 18:53:56 UTC (rev 90254)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x44
+RenderText {#text} at (0,0) size 769x44
+ text run at (0,0) width 537: "This page tests whether Netscape plug-ins can access their own DOM elements. "
+ text run at (537,0) width 232: "The plug-in should have a 3px red"
+ text run at (0,22) width 51: "border."
+ RenderBlock (anonymous) at (0,60) size 784x206
+RenderEmbeddedObject {EMBED} at (0,0) size 206x206 [border: (3px solid #FF)]
+RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90253] trunk/Source/WebCore
Title: [90253] trunk/Source/WebCore Revision 90253 Author t...@chromium.org Date 2011-07-01 11:50:29 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Tony Chang Reviewed by Ojan Vafai. rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData https://bugs.webkit.org/show_bug.cgi?id=63773 We will have a similar struct to hold CSS3 flexible box data, so this makes way for the new class. I will rename the member variable in RenderStyle.h in a follow up change. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.order: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * rendering/style/RenderStyle.h: * rendering/style/StyleAllInOne.cpp: * rendering/style/StyleDeprecatedFlexibleBoxData.cpp: (WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): (WebCore::StyleDeprecatedFlexibleBoxData::operator==): * rendering/style/StyleDeprecatedFlexibleBoxData.h: (WebCore::StyleDeprecatedFlexibleBoxData::create): (WebCore::StyleDeprecatedFlexibleBoxData::copy): (WebCore::StyleDeprecatedFlexibleBoxData::operator!=): * rendering/style/StyleRareNonInheritedData.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleAllInOne.cpp trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h Added Paths trunk/Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp trunk/Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h Removed Paths trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp trunk/Source/WebCore/rendering/style/StyleFlexibleBoxData.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (90252 => 90253) --- trunk/Source/WebCore/CMakeLists.txt 2011-07-01 18:40:18 UTC (rev 90252) +++ trunk/Source/WebCore/CMakeLists.txt 2011-07-01 18:50:29 UTC (rev 90253) @@ -1277,7 +1277,7 @@ rendering/style/StyleBackgroundData.cpp rendering/style/StyleBoxData.cpp rendering/style/StyleCachedImage.cpp -rendering/style/StyleFlexibleBoxData.cpp +rendering/style/StyleDeprecatedFlexibleBoxData.cpp rendering/style/StyleGeneratedImage.cpp rendering/style/StyleInheritedData.cpp rendering/style/StyleMarqueeData.cpp Modified: trunk/Source/WebCore/ChangeLog (90252 => 90253) --- trunk/Source/WebCore/ChangeLog 2011-07-01 18:40:18 UTC (rev 90252) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:50:29 UTC (rev 90253) @@ -1,3 +1,33 @@ +2011-07-01 Tony Chang + +Reviewed by Ojan Vafai. + +rename StyleFlexibleBoxData to StyleDeprecatedFlexibleBoxData +https://bugs.webkit.org/show_bug.cgi?id=63773 + +We will have a similar struct to hold CSS3 flexible box data, so +this makes way for the new class. +I will rename the member variable in RenderStyle.h in a follow up +change. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.order: +* WebCore.pro: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* rendering/style/RenderStyle.h: +* rendering/style/StyleAllInOne.cpp: +* rendering/style/StyleDeprecatedFlexibleBoxData.cpp: +(WebCore::StyleDeprecatedFlexibleBoxData::StyleDeprecatedFlexibleBoxData): +(WebCore::StyleDeprecatedFlexibleBoxData::operator==): +* rendering/style/StyleDeprecatedFlexibleBoxData.h: +(WebCore::StyleDeprecatedFlexibleBoxData::create): +(WebCore::StyleDeprecatedFlexibleBoxData::copy): +(WebCore::StyleDeprecatedFlexibleBoxData::operator!=): +* rendering/style/StyleRareNonInheritedData.h: + 2011-07-01 Hans Wennborg Reviewed by Tony Chang. Modified: trunk/Source/WebCore/GNUmakefile.list.am (90252 => 90253) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-07-01 18:40:18 UTC (rev 90252) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-07-01 18:50:29 UTC (rev 90253) @@ -3110,8 +3110,8 @@ Source/WebCore/rendering/style/StyleCachedImage.cpp \ Source/WebCore/rendering/style/StyleCachedImage.h \ Source/WebCore/rendering/style/StyleDashboardRegion.h \ - Source/WebCore/rendering/style/StyleFlexibleBoxData.cpp \ - Source/WebCore/rendering/style/StyleFlexibleBoxData.h \ + Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.cpp \ + Source/WebCore/rendering/style/StyleDeprecatedFlexibleBoxData.h \ Source/WebCore/rendering/style/StyleGeneratedImage.cpp \ Sour
[webkit-changes] [90252] trunk
Title: [90252] trunk
Revision 90252
Author h...@chromium.org
Date 2011-07-01 11:40:18 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Hans Wennborg
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Update layout tests to use the right values for
webkitIDBTransaction.READ_WRITE/READ_ONLY.
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/constants.html:
2011-07-01 Hans Wennborg
Reviewed by Tony Chang.
IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
https://bugs.webkit.org/show_bug.cgi?id=63754
Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
constants. Douglas Stockwell pointed out that these were reverse
of what the spec says.
* storage/IDBTransaction.h:
* storage/IDBTransaction.idl:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/constants-expected.txt
trunk/LayoutTests/storage/indexeddb/constants.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBTransaction.h
trunk/Source/WebCore/storage/IDBTransaction.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (90251 => 90252)
--- trunk/LayoutTests/ChangeLog 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 18:40:18 UTC (rev 90252)
@@ -1,3 +1,16 @@
+2011-07-01 Hans Wennborg
+
+Reviewed by Tony Chang.
+
+IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
+https://bugs.webkit.org/show_bug.cgi?id=63754
+
+Update layout tests to use the right values for
+webkitIDBTransaction.READ_WRITE/READ_ONLY.
+
+* storage/indexeddb/constants-expected.txt:
+* storage/indexeddb/constants.html:
+
2011-07-01 Gavin Barraclough
Reviewed by Sam Weinig.
Modified: trunk/LayoutTests/storage/indexeddb/constants-expected.txt (90251 => 90252)
--- trunk/LayoutTests/storage/indexeddb/constants-expected.txt 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/storage/indexeddb/constants-expected.txt 2011-07-01 18:40:18 UTC (rev 90252)
@@ -20,8 +20,8 @@
PASS webkitIDBCursor.NEXT_NO_DUPLICATE is 1
PASS webkitIDBCursor.PREV is 2
PASS webkitIDBCursor.PREV_NO_DUPLICATE is 3
-PASS webkitIDBTransaction.READ_WRITE is 0
-PASS webkitIDBTransaction.READ_ONLY is 1
+PASS webkitIDBTransaction.READ_ONLY is 0
+PASS webkitIDBTransaction.READ_WRITE is 1
PASS webkitIDBTransaction.VERSION_CHANGE is 2
PASS successfullyParsed is true
Modified: trunk/LayoutTests/storage/indexeddb/constants.html (90251 => 90252)
--- trunk/LayoutTests/storage/indexeddb/constants.html 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/LayoutTests/storage/indexeddb/constants.html 2011-07-01 18:40:18 UTC (rev 90252)
@@ -36,8 +36,8 @@
shouldBe("webkitIDBCursor.PREV", "2");
shouldBe("webkitIDBCursor.PREV_NO_DUPLICATE", "3");
-shouldBe("webkitIDBTransaction.READ_WRITE", "0");
-shouldBe("webkitIDBTransaction.READ_ONLY", "1");
+shouldBe("webkitIDBTransaction.READ_ONLY", "0");
+shouldBe("webkitIDBTransaction.READ_WRITE", "1");
shouldBe("webkitIDBTransaction.VERSION_CHANGE", "2");
}
Modified: trunk/Source/WebCore/ChangeLog (90251 => 90252)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:40:18 UTC (rev 90252)
@@ -1,3 +1,17 @@
+2011-07-01 Hans Wennborg
+
+Reviewed by Tony Chang.
+
+IndexedDB: Fix constants for webkitIDBTransaction.READ_WRITE/READ_ONLY
+https://bugs.webkit.org/show_bug.cgi?id=63754
+
+Fix values for the webkitIDBTransaction.READ_WRITE/READ_ONLY
+constants. Douglas Stockwell pointed out that these were reverse
+of what the spec says.
+
+* storage/IDBTransaction.h:
+* storage/IDBTransaction.idl:
+
2011-07-01 Levi Weintraub
Reviewed by Eric Seidel.
Modified: trunk/Source/WebCore/storage/IDBTransaction.h (90251 => 90252)
--- trunk/Source/WebCore/storage/IDBTransaction.h 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/storage/IDBTransaction.h 2011-07-01 18:40:18 UTC (rev 90252)
@@ -49,8 +49,8 @@
virtual ~IDBTransaction();
enum Mode {
-READ_WRITE = 0,
-READ_ONLY = 1,
+READ_ONLY = 0,
+READ_WRITE = 1,
VERSION_CHANGE = 2
};
Modified: trunk/Source/WebCore/storage/IDBTransaction.idl (90251 => 90252)
--- trunk/Source/WebCore/storage/IDBTransaction.idl 2011-07-01 18:39:33 UTC (rev 90251)
+++ trunk/Source/WebCore/storage/IDBTransaction.idl 2011-07-01 18:40:18 UTC (rev 90252)
@@ -33,8 +33,8 @@
EventTarget
] IDBTransaction {
// Modes
-const unsigned short READ_WRITE = 0;
-const unsigned short READ_ONLY = 1;
+const unsigned short READ_ONLY = 0;
+const unsigned sho
[webkit-changes] [90251] trunk
Title: [90251] trunk
Revision 90251
Author par...@webkit.org
Date 2011-07-01 11:39:33 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Patrick Gansterer
Reviewed by Daniel Bates.
[CMake] Add cpu detection for MIPS
https://bugs.webkit.org/show_bug.cgi?id=63693
* Source/CMakeLists.txt:
Modified Paths
trunk/ChangeLog
trunk/Source/CMakeLists.txt
Diff
Modified: trunk/ChangeLog (90250 => 90251)
--- trunk/ChangeLog 2011-07-01 18:33:25 UTC (rev 90250)
+++ trunk/ChangeLog 2011-07-01 18:39:33 UTC (rev 90251)
@@ -1,3 +1,12 @@
+2011-07-01 Patrick Gansterer
+
+Reviewed by Daniel Bates.
+
+[CMake] Add cpu detection for MIPS
+https://bugs.webkit.org/show_bug.cgi?id=63693
+
+* Source/CMakeLists.txt:
+
2011-07-01 Joone Hur
Reviewed by Martin Robinson.
Modified: trunk/Source/CMakeLists.txt (90250 => 90251)
--- trunk/Source/CMakeLists.txt 2011-07-01 18:33:25 UTC (rev 90250)
+++ trunk/Source/CMakeLists.txt 2011-07-01 18:39:33 UTC (rev 90251)
@@ -60,6 +60,8 @@
STRING(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
IF (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
SET(WTF_CPU_ARM 1)
+ELSEIF (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
+SET(WTF_CPU_MIPS 1)
ELSEIF (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(x86_64)")
SET(WTF_CPU_X86_64 1)
ELSEIF (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(i[3-6]86|x86)")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90250] trunk/Source/WebCore
Title: [90250] trunk/Source/WebCore Revision 90250 Author le...@chromium.org Date 2011-07-01 11:33:25 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Levi Weintraub Reviewed by Eric Seidel. Switch positionForPoint to new layout types https://bugs.webkit.org/show_bug.cgi?id=63774 Switching positionForPoint functions to new layout unit abstraction. No new tests, no functionality changes. * rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint): * rendering/RenderBR.h: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint): * rendering/RenderBox.h: * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::positionForPoint): * rendering/RenderFileUploadControl.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::positionForPoint): * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint): * rendering/RenderReplaced.h: * rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): * rendering/RenderText.h: * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): * rendering/RenderTextControlSingleLine.h: * rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint): * rendering/svg/RenderSVGInlineText.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint): * rendering/svg/RenderSVGText.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBR.cpp trunk/Source/WebCore/rendering/RenderBR.h trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderFileUploadControl.cpp trunk/Source/WebCore/rendering/RenderFileUploadControl.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderReplaced.cpp trunk/Source/WebCore/rendering/RenderReplaced.h trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebCore/rendering/RenderText.h trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInlineText.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h Diff Modified: trunk/Source/WebCore/ChangeLog (90249 => 90250) --- trunk/Source/WebCore/ChangeLog 2011-07-01 18:30:08 UTC (rev 90249) +++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:33:25 UTC (rev 90250) @@ -1,3 +1,47 @@ +2011-07-01 Levi Weintraub + +Reviewed by Eric Seidel. + +Switch positionForPoint to new layout types +https://bugs.webkit.org/show_bug.cgi?id=63774 + +Switching positionForPoint functions to new layout unit abstraction. + +No new tests, no functionality changes. + +* rendering/RenderBR.cpp: +(WebCore::RenderBR::positionForPoint): +* rendering/RenderBR.h: +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::positionForPoint): +* rendering/RenderBlock.h: +* rendering/RenderBox.cpp: +(WebCore::RenderBox::positionForPoint): +* rendering/RenderBox.h: +* rendering/RenderFileUploadControl.cpp: +(WebCore::RenderFileUploadControl::positionForPoint): +* rendering/RenderFileUploadControl.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::positionForPoint): +* rendering/RenderInline.h: +* rendering/RenderObject.cpp: +(WebCore::RenderObject::positionForPoint): +* rendering/RenderReplaced.cpp: +(WebCore::RenderReplaced::positionForPoint): +* rendering/RenderReplaced.h: +* rendering/RenderText.cpp: +(WebCore::RenderText::positionForPoint): +* rendering/RenderText.h: +* rendering/RenderTextControlSingleLine.cpp: +(WebCore::RenderTextControlInnerBlock::positionForPoint): +* rendering/RenderTextControlSingleLine.h: +* rendering/svg/RenderSVGInlineText.cpp: +(WebCore::RenderSVGInlineText::positionForPoint): +* rendering/svg/RenderSVGInlineText.h: +* rendering/svg/RenderSVGText.cpp: +(WebCore::RenderSVGText::positionForPoint): +* rendering/svg/RenderSVGText.h: + 2011-07-01
[webkit-changes] [90249] trunk/Source
Title: [90249] trunk/Source
Revision 90249
Author scher...@chromium.org
Date 2011-07-01 11:30:08 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Andrew Scherkus
Reviewed by Darin Fisher.
Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783
* features.gypi:
2011-07-01 Andrew Scherkus
Reviewed by Darin Fisher.
Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
https://bugs.webkit.org/show_bug.cgi?id=63783
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (90248 => 90249)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 18:19:50 UTC (rev 90248)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:30:08 UTC (rev 90249)
@@ -1,3 +1,12 @@
+2011-07-01 Andrew Scherkus
+
+Reviewed by Darin Fisher.
+
+Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
+https://bugs.webkit.org/show_bug.cgi?id=63783
+
+* WebCore.gyp/WebCore.gyp:
+
2011-07-01 Patrick Gansterer
Reviewed by Daniel Bates.
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (90248 => 90249)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-01 18:19:50 UTC (rev 90248)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-01 18:30:08 UTC (rev 90249)
@@ -1228,7 +1228,7 @@
# This directory needs to be on the include path for multiple sub-targets of webcore.
'direct_dependent_settings': {
'include_dirs': [
- '<(chromium_src_dir)/third_party/ffmpeg/patched-ffmpeg-mt',
+ '<(chromium_src_dir)/third_party/ffmpeg/patched-ffmpeg',
],
},
'dependencies': [
Modified: trunk/Source/WebKit/chromium/ChangeLog (90248 => 90249)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 18:19:50 UTC (rev 90248)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 18:30:08 UTC (rev 90249)
@@ -1,3 +1,12 @@
+2011-07-01 Andrew Scherkus
+
+Reviewed by Darin Fisher.
+
+Re-enable WTF_USE_WEBAUDIO_FFMPEG for Chromium
+https://bugs.webkit.org/show_bug.cgi?id=63783
+
+* features.gypi:
+
2011-07-01 Tony Chang
Fix the chromium build. sql is a new top level directory.
Modified: trunk/Source/WebKit/chromium/features.gypi (90248 => 90249)
--- trunk/Source/WebKit/chromium/features.gypi 2011-07-01 18:19:50 UTC (rev 90248)
+++ trunk/Source/WebKit/chromium/features.gypi 2011-07-01 18:30:08 UTC (rev 90249)
@@ -140,8 +140,7 @@
# Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg.
['OS!="mac"', {
'feature_defines': [
- # TODO(scherkus): temporarily disabled due to FFmpeg update.
- 'WTF_USE_WEBAUDIO_FFMPEG=0',
+ 'WTF_USE_WEBAUDIO_FFMPEG=1',
],
'use_skia%': 1,
}],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90247] trunk
Title: [90247] trunk
Revision 90247
Author barraclo...@apple.com
Date 2011-07-01 11:19:17 -0700 (Fri, 01 Jul 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=63819
Escaping of forwardslashes in strings incorrect if multiple exist.
Reviewed by Sam Weinig.
Source/_javascript_Core:
The bug is in the parameters passed to a substring - should be
start & length, but we're passing start & end indices!
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
LayoutTests:
Add tests with multiple forward slashes.
* fast/regex/script-tests/toString.js:
* fast/regex/toString-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regex/script-tests/toString.js
trunk/LayoutTests/fast/regex/toString-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (90246 => 90247)
--- trunk/LayoutTests/ChangeLog 2011-07-01 18:14:37 UTC (rev 90246)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 18:19:17 UTC (rev 90247)
@@ -1,3 +1,15 @@
+2011-07-01 Gavin Barraclough
+
+Reviewed by Sam Weinig.
+
+https://bugs.webkit.org/show_bug.cgi?id=63819
+Escaping of forwardslashes in strings incorrect if multiple exist.
+
+Add tests with multiple forward slashes.
+
+* fast/regex/script-tests/toString.js:
+* fast/regex/toString-expected.txt:
+
2011-07-01 Mihai Parparita
Add failing test expectations for Chromium media tests on Windows 7 and
Modified: trunk/LayoutTests/fast/regex/script-tests/toString.js (90246 => 90247)
--- trunk/LayoutTests/fast/regex/script-tests/toString.js 2011-07-01 18:14:37 UTC (rev 90246)
+++ trunk/LayoutTests/fast/regex/script-tests/toString.js 2011-07-01 18:19:17 UTC (rev 90247)
@@ -29,6 +29,11 @@
// These strings match two backslashes (the second with the '/' escaped).
shouldBeTrue('testForwardSlash("^/$", "/");');
shouldBeTrue('testForwardSlash("^\\/$", "/");');
+// Test that nothing goes wrongif there are multiple forward slashes!
+shouldBeTrue('testForwardSlash("x/x/x", "x\\/x\\/x");');
+shouldBeTrue('testForwardSlash("x\\/x/x", "x\\/x\\/x");');
+shouldBeTrue('testForwardSlash("x/x\\/x", "x\\/x\\/x");');
+shouldBeTrue('testForwardSlash("x\\/x\\/x", "x\\/x\\/x");');
var successfullyParsed = true;
Modified: trunk/LayoutTests/fast/regex/toString-expected.txt (90246 => 90247)
--- trunk/LayoutTests/fast/regex/toString-expected.txt 2011-07-01 18:14:37 UTC (rev 90246)
+++ trunk/LayoutTests/fast/regex/toString-expected.txt 2011-07-01 18:19:17 UTC (rev 90247)
@@ -16,6 +16,10 @@
PASS testForwardSlash("^\\\/$", "\/"); is true
PASS testForwardSlash("^/$", "\\/"); is true
PASS testForwardSlash("^\/$", "\\/"); is true
+PASS testForwardSlash("x/x/x", "x\/x\/x"); is true
+PASS testForwardSlash("x\/x/x", "x\/x\/x"); is true
+PASS testForwardSlash("x/x\/x", "x\/x\/x"); is true
+PASS testForwardSlash("x\/x\/x", "x\/x\/x"); is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/_javascript_Core/ChangeLog (90246 => 90247)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 18:14:37 UTC (rev 90246)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 18:19:17 UTC (rev 90247)
@@ -1,3 +1,16 @@
+2011-07-01 Gavin Barraclough
+
+Reviewed by Sam Weinig.
+
+https://bugs.webkit.org/show_bug.cgi?id=63819
+Escaping of forwardslashes in strings incorrect if multiple exist.
+
+The bug is in the parameters passed to a substring - should be
+start & length, but we're passing start & end indices!
+
+* runtime/RegExpObject.cpp:
+(JSC::regExpObjectSource):
+
2011-07-01 Adam Roben
Roll out r90194
Modified: trunk/Source/_javascript_Core/runtime/RegExpObject.cpp (90246 => 90247)
--- trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2011-07-01 18:14:37 UTC (rev 90246)
+++ trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2011-07-01 18:19:17 UTC (rev 90247)
@@ -134,9 +134,9 @@
// if odd, the forwards slash is already escaped, so we mustn't
// double escape it.
if ((forwardSlashPosition - slashesPosition) & 1)
-result.append(pattern.substringSharingImpl(completed, forwardSlashPosition + 1));
+result.append(pattern.substringSharingImpl(completed, forwardSlashPosition - completed + 1));
else {
-result.append(pattern.substringSharingImpl(completed, forwardSlashPosition));
+result.append(pattern.substringSharingImpl(completed, forwardSlashPosition - completed));
result.append("\\/");
}
completed = forwardSlashPosition + 1;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90248] trunk/Source/WebCore
Title: [90248] trunk/Source/WebCore
Revision 90248
Author par...@webkit.org
Date 2011-07-01 11:19:50 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Patrick Gansterer
Reviewed by Daniel Bates.
[CMake] Don't compile unused bindings
https://bugs.webkit.org/show_bug.cgi?id=63741
* UseJSC.cmake: Added IF (ENABLE_XXX) around files.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/UseJSC.cmake
Diff
Modified: trunk/Source/WebCore/ChangeLog (90247 => 90248)
--- trunk/Source/WebCore/ChangeLog 2011-07-01 18:19:17 UTC (rev 90247)
+++ trunk/Source/WebCore/ChangeLog 2011-07-01 18:19:50 UTC (rev 90248)
@@ -1,3 +1,12 @@
+2011-07-01 Patrick Gansterer
+
+Reviewed by Daniel Bates.
+
+[CMake] Don't compile unused bindings
+https://bugs.webkit.org/show_bug.cgi?id=63741
+
+* UseJSC.cmake: Added IF (ENABLE_XXX) around files.
+
2011-07-01 Joone Hur
Reviewed by Martin Robinson.
Modified: trunk/Source/WebCore/UseJSC.cmake (90247 => 90248)
--- trunk/Source/WebCore/UseJSC.cmake 2011-07-01 18:19:17 UTC (rev 90247)
+++ trunk/Source/WebCore/UseJSC.cmake 2011-07-01 18:19:50 UTC (rev 90248)
@@ -11,7 +11,6 @@
bindings/js/DOMObjectHashTableMap.cpp
bindings/js/DOMWrapperWorld.cpp
bindings/js/GCController.cpp
-bindings/js/IDBBindingUtilities.cpp
bindings/js/JSAttrCustom.cpp
bindings/js/JSArrayBufferCustom.cpp
bindings/js/JSDataViewCustom.cpp
@@ -31,10 +30,7 @@
bindings/js/JSClipboardCustom.cpp
bindings/js/JSConsoleCustom.cpp
bindings/js/JSCoordinatesCustom.cpp
-bindings/js/JSCustomSQLStatementErrorCallback.cpp
bindings/js/JSCustomVoidCallback.cpp
-bindings/js/JSCustomXPathNSResolver.cpp
-bindings/js/JSDOMApplicationCacheCustom.cpp
bindings/js/JSDOMBinding.cpp
bindings/js/JSDOMFormDataCustom.cpp
bindings/js/JSDOMGlobalObject.cpp
@@ -59,7 +55,6 @@
bindings/js/JSEventSourceCustom.cpp
bindings/js/JSEventTarget.cpp
bindings/js/JSExceptionBase.cpp
-bindings/js/JSFileReaderCustom.cpp
bindings/js/JSFloat32ArrayCustom.cpp
bindings/js/JSFloat64ArrayCustom.cpp
bindings/js/JSGeolocationCustom.cpp
@@ -81,8 +76,6 @@
bindings/js/JSHTMLSelectElementCustom.cpp
bindings/js/JSHTMLStyleElementCustom.cpp
bindings/js/JSHistoryCustom.cpp
-bindings/js/JSIDBAnyCustom.cpp
-bindings/js/JSIDBKeyCustom.cpp
bindings/js/JSImageConstructor.cpp
bindings/js/JSImageDataCustom.cpp
bindings/js/JSInt16ArrayCustom.cpp
@@ -110,12 +103,8 @@
bindings/js/JSOptionConstructor.cpp
bindings/js/JSPluginElementFunctions.cpp
bindings/js/JSProcessingInstructionCustom.cpp
-bindings/js/JSSQLResultSetRowListCustom.cpp
-bindings/js/JSSQLTransactionCustom.cpp
-bindings/js/JSSQLTransactionSyncCustom.cpp
bindings/js/JSScriptProfileNodeCustom.cpp
bindings/js/JSSharedWorkerCustom.cpp
-bindings/js/JSStorageCustom.cpp
bindings/js/JSStyleSheetCustom.cpp
bindings/js/JSStyleSheetListCustom.cpp
bindings/js/JSTextCustom.cpp
@@ -131,14 +120,12 @@
bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp
bindings/js/JSWebKitCSSMatrixCustom.cpp
bindings/js/JSWebKitPointCustom.cpp
-bindings/js/JSWebSocketCustom.cpp
bindings/js/JSWorkerContextBase.cpp
bindings/js/JSWorkerContextCustom.cpp
bindings/js/JSWorkerCustom.cpp
bindings/js/JSXMLHttpRequestCustom.cpp
bindings/js/JSXMLHttpRequestUploadCustom.cpp
bindings/js/JSXSLTProcessorCustom.cpp
-bindings/js/JSXPathResultCustom.cpp
bindings/js/_javascript_CallFrame.cpp
bindings/js/PageScriptDebugServer.cpp
bindings/js/ScheduledAction.cpp
@@ -175,6 +162,56 @@
bridge/jsc/BridgeJSC.cpp
)
+
+IF (ENABLE_BLOB)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSFileReaderCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_DATABASE)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSCustomSQLStatementErrorCallback.cpp
+bindings/js/JSSQLResultSetRowListCustom.cpp
+bindings/js/JSSQLTransactionCustom.cpp
+bindings/js/JSSQLTransactionSyncCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_DOM_STORAGE)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSStorageCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_INDEXED_DATABASE)
+LIST(APPEND WebCore_SOURCES
+bindings/js/IDBBindingUtilities.cpp
+bindings/js/JSIDBAnyCustom.cpp
+bindings/js/JSIDBKeyCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_WEB_SOCKETS)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSWebSocketCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_OFFLINE_WEB_APPLICATIONS)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSDOMApplicationCacheCustom.cpp
+)
+ENDIF ()
+
+IF (ENABLE_XPATH)
+LIST(APPEND WebCore_SOURCES
+bindings/js/JSCustomXPathNSResolver.cpp
+bindings/js/JSXPathResultCustom.cpp
+)
+ENDIF ()
+
+
LIST(APPEND SCRIPTS_BINDINGS
${WEBCORE_DIR}/binding
[webkit-changes] [90246] trunk/Tools
Title: [90246] trunk/Tools
Revision 90246
Author aba...@webkit.org
Date 2011-07-01 11:14:37 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Barth
Reviewed by Darin Adler.
ReportCrash destabilizes new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=63795
ReportCrash chews up too many system resources that it destablizes
tests run concurrently. This patch causes us to spin down all the
worker processes when ReportCrash is running.
Also, this patch causes the master process to tell the user we're
waiting for the crash reporter rather than having that be the worker's
job. This stops the user from getting spammed with too many "waiting
for crash reporter" messages and also cleans up some minor UI issues
with the meter.
* Scripts/webkitpy/layout_tests/layout_package/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/server_process.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/server_process.py
Diff
Modified: trunk/Tools/ChangeLog (90245 => 90246)
--- trunk/Tools/ChangeLog 2011-07-01 17:57:37 UTC (rev 90245)
+++ trunk/Tools/ChangeLog 2011-07-01 18:14:37 UTC (rev 90246)
@@ -1,3 +1,25 @@
+2011-07-01 Adam Barth
+
+Reviewed by Darin Adler.
+
+ReportCrash destabilizes new-run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=63795
+
+ReportCrash chews up too many system resources that it destablizes
+tests run concurrently. This patch causes us to spin down all the
+worker processes when ReportCrash is running.
+
+Also, this patch causes the master process to tell the user we're
+waiting for the crash reporter rather than having that be the worker's
+job. This stops the user from getting spammed with too many "waiting
+for crash reporter" messages and also cleans up some minor UI issues
+with the meter.
+
+* Scripts/webkitpy/layout_tests/layout_package/manager.py:
+* Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
+* Scripts/webkitpy/layout_tests/port/base.py:
+* Scripts/webkitpy/layout_tests/port/server_process.py:
+
2011-07-01 Adam Roben
Teach webkitpy about the new format of our ChangeLog template
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py (90245 => 90246)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 17:57:37 UTC (rev 90245)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py 2011-07-01 18:14:37 UTC (rev 90246)
@@ -668,7 +668,9 @@
try:
while not self.is_done():
-# FIXME: Do we need to run in a loop anymore?
+if self._port.executive().running_pids(self._port.is_crash_reporter):
+self._printer.print_update("Waiting for crash reporter ...")
+self._port.executive().wait_newest(self._port.is_crash_reporter)
manager_connection.run_message_loop(delay_secs=1.0)
# Make sure all of the workers have shut down (if possible).
@@ -782,9 +784,7 @@
start_time = time.time()
-interrupted, keyboard_interrupted, thread_timings, test_timings, \
-individual_test_timings = (
-self._run_tests(self._test_files_list, result_summary))
+interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_files_list, result_summary)
# We exclude the crashes from the list of results to retry, because
# we want to treat even a potentially flaky crash as an error.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py (90245 => 90246)
--- trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 17:57:37 UTC (rev 90245)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py 2011-07-01 18:14:37 UTC (rev 90246)
@@ -125,6 +125,11 @@
return self._run_compare_test()
def _run_compare_test(self):
+# Before running the test, we wait for any crash reporters to finish
+# running. On Mac, ReportCrash chews up a bunch of resources and
+# causes the tests to become unstable, so we don't want to run in
+# parallel with ReportCrash.
+self._port.executive().wait_newest(self._port.is_crash_reporter)
driver_output = self._driver.run_test(self._driver_input())
expected_driver_output = se
[webkit-changes] [90245] trunk/Source/WebKit/chromium
Title: [90245] trunk/Source/WebKit/chromium
Revision 90245
Author t...@chromium.org
Date 2011-07-01 10:57:37 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Tony Chang
Fix the chromium build. sql is a new top level directory.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (90244 => 90245)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 17:36:17 UTC (rev 90244)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 17:57:37 UTC (rev 90245)
@@ -1,3 +1,9 @@
+2011-07-01 Tony Chang
+
+Fix the chromium build. sql is a new top level directory.
+
+* DEPS:
+
2011-07-01 Ryosuke Niwa
Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/DEPS (90244 => 90245)
--- trunk/Source/WebKit/chromium/DEPS 2011-07-01 17:36:17 UTC (rev 90244)
+++ trunk/Source/WebKit/chromium/DEPS 2011-07-01 17:57:37 UTC (rev 90245)
@@ -101,6 +101,8 @@
Var('chromium_svn')+'/printing@'+Var('chromium_rev'),
'ppapi':
Var('chromium_svn')+'/ppapi@'+Var('chromium_rev'),
+ 'sql':
+Var('chromium_svn')+'/sql@'+Var('chromium_rev'),
'third_party/angle': # needed by the gpu process
From('chromium_deps', 'src/third_party/angle'),
'third_party/libvpx': # needed by webkit/media
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90244] trunk/Source/WebKit/chromium
Title: [90244] trunk/Source/WebKit/chromium
Revision 90244
Author rn...@webkit.org
Date 2011-07-01 10:36:17 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Ryosuke Niwa
Rolled DEPS.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (90243 => 90244)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 17:29:09 UTC (rev 90243)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-01 17:36:17 UTC (rev 90244)
@@ -1,3 +1,9 @@
+2011-07-01 Ryosuke Niwa
+
+Rolled DEPS.
+
+* DEPS:
+
2011-06-30 Noel Gordon
Reviewed by Hajime Morita.
Modified: trunk/Source/WebKit/chromium/DEPS (90243 => 90244)
--- trunk/Source/WebKit/chromium/DEPS 2011-07-01 17:29:09 UTC (rev 90243)
+++ trunk/Source/WebKit/chromium/DEPS 2011-07-01 17:36:17 UTC (rev 90244)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '91051'
+ 'chromium_rev': '91300'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90243] trunk/LayoutTests
Title: [90243] trunk/LayoutTests Revision 90243 Author mih...@chromium.org Date 2011-07-01 10:29:09 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Mihai Parparita Add failing test expectations for Chromium media tests on Windows 7 and Vista. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90242 => 90243) --- trunk/LayoutTests/ChangeLog 2011-07-01 16:56:42 UTC (rev 90242) +++ trunk/LayoutTests/ChangeLog 2011-07-01 17:29:09 UTC (rev 90243) @@ -1,3 +1,10 @@ +2011-07-01 Mihai Parparita + +Add failing test expectations for Chromium media tests on Windows 7 and +Vista. + +* platform/chromium/test_expectations.txt: + 2011-07-01 Balazs Kelemen Reviewed by Andreas Kling. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90242 => 90243) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 16:56:42 UTC (rev 90242) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-01 17:29:09 UTC (rev 90243) @@ -824,7 +824,7 @@ BUGCR78376 : http/tests/media/video-play-stall-seek.html = TIMEOUT // canplaythrough event is sent too early. -BUGCR73609 : http/tests/media/video-play-stall.html = TEXT +BUGCR73609 MAC XP LINUX : http/tests/media/video-play-stall.html = TEXT // video.buffered multiple TimeRanges support. BUGCR49165 SKIP : http/tests/media/video-buffered.html = PASS @@ -4031,3 +4031,28 @@ // Added in http://trac.webkit.org/changeset/90148, null-derefing in TestNetscapgePlugin. BUGJAPHET : platform/gtk/plugins/invalidate-rect-with-null-npp-argument.html = CRASH + +// Caused by an ffmpeg roll +BUGCR88197 VISTA WIN7 : http/tests/appcache/video.html = TEXT +BUGCR88197 VISTA WIN7 : http/tests/media/video-referer.html = TEXT +BUGCR88197 VISTA WIN7 : http/tests/media/video-served-as-text.html = TEXT +BUGCR88197 VISTA WIN7 : fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/canvas/webgl/origin-clean-conformance.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/media-can-load-when-hidden.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/reload-after-dialog.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/remove-while-loading.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-cancel-load.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-cookie.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-error-abort.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-load-twice.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-play-progress.html = TIMEOUT +BUGCR88197 VISTA WIN7 : http/tests/media/video-play-stall.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-constructor-preload.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-constructor-src.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-constructor.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-controls-do-not-fade-out.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-controls-rendering.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-delete-while-slider-thumb-clicked.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-only-video-intrinsic-size.html = TIMEOUT +BUGCR88197 VISTA WIN7 : media/audio-play-event.html = TIMEOUT PASS +BUGCR88197 VISTA WIN7 : media/audio-repaint.html = TIMEOUT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90241] trunk/Source/JavaScriptCore
Title: [90241] trunk/Source/_javascript_Core
Revision 90241
Author aro...@apple.com
Date 2011-07-01 09:56:33 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Adam Roben
Roll out r90194
http://trac.webkit.org/changeset/90194
https://bugs.webkit.org/show_bug.cgi?id=63778
Fixes REGRESSION (r90194): Multiple tests intermittently failing
assertions in WriteBarrierBase::get
* runtime/JSCell.h:
(JSC::JSCell::JSCell::~JSCell):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCell.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90240 => 90241)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:56:20 UTC (rev 90240)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:56:33 UTC (rev 90241)
@@ -1,3 +1,15 @@
+2011-07-01 Adam Roben
+
+Roll out r90194
+http://trac.webkit.org/changeset/90194
+https://bugs.webkit.org/show_bug.cgi?id=63778
+
+Fixes REGRESSION (r90194): Multiple tests intermittently failing
+assertions in WriteBarrierBase::get
+
+* runtime/JSCell.h:
+(JSC::JSCell::JSCell::~JSCell):
+
2011-06-30 Oliver Hunt
Reviewed by Gavin Barraclough.
Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (90240 => 90241)
--- trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-01 16:56:20 UTC (rev 90240)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h 2011-07-01 16:56:33 UTC (rev 90241)
@@ -186,9 +186,6 @@
inline JSCell::~JSCell()
{
-#if ENABLE(GC_VALIDATION)
-m_structure.clear();
-#endif
}
inline Structure* JSCell::structure() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90239] trunk/Tools
Title: [90239] trunk/Tools
Revision 90239
Author aro...@apple.com
Date 2011-07-01 09:54:26 -0700 (Fri, 01 Jul 2011)
Log Message
Teach webkitpy about the new format of our ChangeLog template
r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
template. But webkitpy didn't know this, so the various rollout-related commands were
leaving that line in the ChangeLog.
Fixes REGRESSION (r90229): webkit-patch rollout and sheriffbot
rollout are broken
Reviewed by Dan Bates.
* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
description and bug URL" line instead of the "Reviewed by" line as the first line of the
ChangeLog template.
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
generates.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py
trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90238 => 90239)
--- trunk/Tools/ChangeLog 2011-07-01 16:51:24 UTC (rev 90238)
+++ trunk/Tools/ChangeLog 2011-07-01 16:54:26 UTC (rev 90239)
@@ -1,5 +1,27 @@
2011-07-01 Adam Roben
+Teach webkitpy about the new format of our ChangeLog template
+
+r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
+template. But webkitpy didn't know this, so the various rollout-related commands were
+leaving that line in the ChangeLog.
+
+Fixes REGRESSION (r90229): webkit-patch rollout and sheriffbot
+rollout are broken
+
+Reviewed by Dan Bates.
+
+* Scripts/webkitpy/common/checkout/changelog.py:
+(ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
+description and bug URL" line instead of the "Reviewed by" line as the first line of the
+ChangeLog template.
+
+* Scripts/webkitpy/common/checkout/changelog_unittest.py:
+(ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
+generates.
+
+2011-07-01 Adam Roben
+
Make TestFailures stop loading old builds once we've explained all current failures
We used to do this, but some refactoring in r90165 broke this logic.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py (90238 => 90239)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2011-07-01 16:51:24 UTC (rev 90238)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py 2011-07-01 16:54:26 UTC (rev 90239)
@@ -179,16 +179,16 @@
return "\n".join(lines)
def update_with_unreviewed_message(self, message):
-reviewed_by_regexp = re.compile(
-"%sReviewed by NOBODY \(OOPS!\)\." % self._changelog_indent)
+first_boilerplate_line_regexp = re.compile(
+"%sNeed a short description and bug URL \(OOPS!\)" % self._changelog_indent)
removing_boilerplate = False
# inplace=1 creates a backup file and re-directs stdout to the file
for line in fileinput.FileInput(self.path, inplace=1):
-if reviewed_by_regexp.search(line):
+if first_boilerplate_line_regexp.search(line):
message_lines = self._wrap_lines(message)
-print reviewed_by_regexp.sub(message_lines, line),
-# Remove all the ChangeLog boilerplate between the Reviewed by
-# line and the first changed file.
+print first_boilerplate_line_regexp.sub(message_lines, line),
+# Remove all the ChangeLog boilerplate before the first changed
+# file.
removing_boilerplate = True
elif removing_boilerplate:
if line.find('*') >= 0: # each changed file is preceded by a *
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py (90238 => 90239)
--- trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-07-01 16:51:24 UTC (rev 90238)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/changelog_unittest.py 2011-07-01 16:54:26 UTC (rev 90239)
@@ -183,12 +183,13 @@
with codecs.open(file_path, "r", encoding) as file:
return file.read()
+# FIXME: We really should be getting this from prepare-ChangeLog itself.
_new_entry_boilerplate = '''2009-08-19 Eric Seidel
+Need a short description and bug URL (OOPS!)
+
Reviewed by NOBODY (OOPS!).
-Need a short description and bug URL (OOPS!)
-
* Scripts/bugzilla-tool:
'''
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90238] trunk
Title: [90238] trunk
Revision 90238
Author bweinst...@apple.com
Date 2011-07-01 09:51:24 -0700 (Fri, 01 Jul 2011)
Log Message
WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
cancelled by willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=63753
Reviewed by Darin Adler.
Source/WebKit2:
When deciding a policy for a null request, call the callback that was passed
to WebKit2 and say that we used the loader.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
LayoutTests:
Unskip WebKit2 tests that now pass.
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (90237 => 90238)
--- trunk/LayoutTests/ChangeLog 2011-07-01 16:33:46 UTC (rev 90237)
+++ trunk/LayoutTests/ChangeLog 2011-07-01 16:51:24 UTC (rev 90238)
@@ -1,3 +1,15 @@
+2011-06-30 Brian Weinstein
+
+Reviewed by Darin Adler.
+
+WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
+cancelled by willSendRequest
+https://bugs.webkit.org/show_bug.cgi?id=63753
+
+Unskip WebKit2 tests that now pass.
+
+* platform/wk2/Skipped:
+
2011-07-01 Adam Roben
Skip one asserting and one timing-out test on Windows
Modified: trunk/LayoutTests/platform/wk2/Skipped (90237 => 90238)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-07-01 16:33:46 UTC (rev 90237)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-01 16:51:24 UTC (rev 90238)
@@ -2048,10 +2048,6 @@
# Mysterious failure after enabling paste tests
platform/mac/editing/pasteboard/text-precomposed.html
-# Unexplained failures after implementing willSendRequestReturnsNull
-fast/loader/onload-willSendRequest-null-for-frame.html
-plugins/plugin-document-willSendRequest-null.html
-
# An empty layer is missing.
platform/mac/fast/forms/input-appearance-spinbutton-up.html
Modified: trunk/Source/WebKit2/ChangeLog (90237 => 90238)
--- trunk/Source/WebKit2/ChangeLog 2011-07-01 16:33:46 UTC (rev 90237)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-01 16:51:24 UTC (rev 90238)
@@ -1,3 +1,17 @@
+2011-06-30 Brian Weinstein
+
+Reviewed by Darin Adler.
+
+WebKit2: DidFinishLoadForFrame is never called on iframes when loads are
+cancelled by willSendRequest
+https://bugs.webkit.org/show_bug.cgi?id=63753
+
+When deciding a policy for a null request, call the callback that was passed
+to WebKit2 and say that we used the loader.
+
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
+
2011-07-01 Balazs Kelemen
Reviewed by Andreas Kling.
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (90237 => 90238)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-07-01 16:33:46 UTC (rev 90237)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2011-07-01 16:51:24 UTC (rev 90238)
@@ -601,8 +601,10 @@
if (!webPage)
return;
-if (!request.url().string())
+if (!request.url().string()) {
+(m_frame->coreFrame()->loader()->policyChecker()->*function)(PolicyUse);
return;
+}
RefPtr userData;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90237] trunk/Source/JavaScriptCore
Title: [90237] trunk/Source/_javascript_Core Revision 90237 Author oli...@apple.com Date 2011-07-01 09:33:46 -0700 (Fri, 01 Jul 2011) Log Message 2011-06-30 Oliver Hunt Reviewed by Gavin Barraclough. Add optimised paths for a few maths functions https://bugs.webkit.org/show_bug.cgi?id=63757 Relanding as a Mac only patch. This adds specialised thunks for Math.abs, Math.round, Math.ceil, Math.floor, Math.log, and Math.exp as they are apparently more important in real web content than we thought, which is somewhat mind-boggling. On average doubles the performance of the common cases (eg. actually passing numbers in). They're not as efficient as they could be, but this way gives them the most portability. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::supportsDoubleBitops): (JSC::MacroAssemblerARM::andnotDouble): * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::supportsDoubleBitops): (JSC::MacroAssemblerARMv7::andnotDouble): * assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::andnotDouble): (JSC::MacroAssemblerMIPS::supportsDoubleBitops): * assembler/MacroAssemblerSH4.h: (JSC::MacroAssemblerSH4::supportsDoubleBitops): (JSC::MacroAssemblerSH4::andnotDouble): * assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::supportsDoubleBitops): * assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::andnotDouble): * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::supportsDoubleBitops): * assembler/X86Assembler.h: (JSC::X86Assembler::andnpd_rr): * create_hash_table: * jit/SpecializedThunkJIT.h: (JSC::SpecializedThunkJIT::finalize): (JSC::SpecializedThunkJIT::callDoubleToDouble): * jit/ThunkGenerators.cpp: (JSC::floorThunkGenerator): (JSC::ceilThunkGenerator): (JSC::roundThunkGenerator): (JSC::expThunkGenerator): (JSC::logThunkGenerator): (JSC::absThunkGenerator): * jit/ThunkGenerators.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h trunk/Source/_javascript_Core/assembler/X86Assembler.h trunk/Source/_javascript_Core/create_hash_table trunk/Source/_javascript_Core/jit/JSInterfaceJIT.h trunk/Source/_javascript_Core/jit/SpecializedThunkJIT.h trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp trunk/Source/_javascript_Core/jit/ThunkGenerators.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (90236 => 90237) --- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:22:09 UTC (rev 90236) +++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:33:46 UTC (rev 90237) @@ -1,3 +1,52 @@ +2011-06-30 Oliver Hunt + +Reviewed by Gavin Barraclough. + +Add optimised paths for a few maths functions +https://bugs.webkit.org/show_bug.cgi?id=63757 + +Relanding as a Mac only patch. + +This adds specialised thunks for Math.abs, Math.round, Math.ceil, +Math.floor, Math.log, and Math.exp as they are apparently more +important in real web content than we thought, which is somewhat +mind-boggling. On average doubles the performance of the common +cases (eg. actually passing numbers in). They're not as efficient +as they could be, but this way gives them the most portability. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::supportsDoubleBitops): +(JSC::MacroAssemblerARM::andnotDouble): +* assembler/MacroAssemblerARMv7.h: +(JSC::MacroAssemblerARMv7::supportsDoubleBitops): +(JSC::MacroAssemblerARMv7::andnotDouble): +* assembler/MacroAssemblerMIPS.h: +(JSC::MacroAssemblerMIPS::andnotDouble): +(JSC::MacroAssemblerMIPS::supportsDoubleBitops): +* assembler/MacroAssemblerSH4.h: +(JSC::MacroAssemblerSH4::supportsDoubleBitops): +(JSC::MacroAssemblerSH4::andnotDouble): +* assembler/MacroAssemblerX86.h: +(JSC::MacroAssemblerX86::supportsDoubleBitops): +* assembler/MacroAssemblerX86Common.h: +(JSC::MacroAssemblerX86Common::andnotDouble): +* assembler/MacroAssemblerX86_64.h: +(JSC::MacroAssemblerX86_64::supportsDoubleBitops): +* assembler/X86Assembler.h: +(JSC::X86Assembler::andnpd_rr): +* create_hash_table: +* jit/SpecializedThun
[webkit-changes] [90236] trunk/LayoutTests
Title: [90236] trunk/LayoutTests Revision 90236 Author aro...@apple.com Date 2011-07-01 09:22:09 -0700 (Fri, 01 Jul 2011) Log Message Skip one asserting and one timing-out test on Windows Failures are tracked by and . * platform/win/Skipped: Added http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and fast/loader/create-frame-in-DOMContentLoaded.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90235 => 90236) --- trunk/LayoutTests/ChangeLog 2011-07-01 16:21:59 UTC (rev 90235) +++ trunk/LayoutTests/ChangeLog 2011-07-01 16:22:09 UTC (rev 90236) @@ -1,5 +1,15 @@ 2011-07-01 Adam Roben +Skip one asserting and one timing-out test on Windows + +Failures are tracked by and . + +* platform/win/Skipped: Added +http/tests/cache/history-only-cached-subresource-loads-max-age-https.html and +fast/loader/create-frame-in-DOMContentLoaded.html. + +2011-07-01 Adam Roben + Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html The failure is tracked by . Modified: trunk/LayoutTests/platform/win/Skipped (90235 => 90236) --- trunk/LayoutTests/platform/win/Skipped 2011-07-01 16:21:59 UTC (rev 90235) +++ trunk/LayoutTests/platform/win/Skipped 2011-07-01 16:22:09 UTC (rev 90236) @@ -441,6 +441,12 @@ # Flaky http://webkit.org/b/62569 animations/play-state-paused.html +# Times out http://webkit.org/b/63806 +http/tests/cache/history-only-cached-subresource-loads-max-age-https.html + +# Asserts in FrameLoader::loadWithDocumentLoader http://webkit.org/b/63807 +fast/loader/create-frame-in-DOMContentLoaded.html + ### No bugs filed about the below yet### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90235] trunk/LayoutTests
Title: [90235] trunk/LayoutTests Revision 90235 Author aro...@apple.com Date 2011-07-01 09:21:59 -0700 (Fri, 01 Jul 2011) Log Message Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html The failure is tracked by . * platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/fast/events/panScroll-click-hyperlink-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90234 => 90235) --- trunk/LayoutTests/ChangeLog 2011-07-01 16:21:49 UTC (rev 90234) +++ trunk/LayoutTests/ChangeLog 2011-07-01 16:21:59 UTC (rev 90235) @@ -1,5 +1,13 @@ 2011-07-01 Adam Roben +Land Windows expected failure results for fast/events/panScroll-click-hyperlink.html + +The failure is tracked by . + +* platform/win/fast/events/panScroll-click-hyperlink-expected.txt: + +2011-07-01 Adam Roben + Land new expected (failure?) results for an accessibility test on Windows The failure is tracked by . Modified: trunk/LayoutTests/platform/win/fast/events/panScroll-click-hyperlink-expected.txt (90234 => 90235) --- trunk/LayoutTests/platform/win/fast/events/panScroll-click-hyperlink-expected.txt 2011-07-01 16:21:49 UTC (rev 90234) +++ trunk/LayoutTests/platform/win/fast/events/panScroll-click-hyperlink-expected.txt 2011-07-01 16:21:59 UTC (rev 90235) @@ -4,7 +4,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS Link 1 wasn't clicked. +FAIL either pan scrolling is disabled or this platform doesn't support pan scrolling. TEST COMPLETE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90234] trunk/LayoutTests
Title: [90234] trunk/LayoutTests Revision 90234 Author aro...@apple.com Date 2011-07-01 09:21:49 -0700 (Fri, 01 Jul 2011) Log Message Land new expected (failure?) results for an accessibility test on Windows The failure is tracked by . * platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90233 => 90234) --- trunk/LayoutTests/ChangeLog 2011-07-01 16:21:39 UTC (rev 90233) +++ trunk/LayoutTests/ChangeLog 2011-07-01 16:21:49 UTC (rev 90234) @@ -1,5 +1,13 @@ 2011-07-01 Adam Roben +Land new expected (failure?) results for an accessibility test on Windows + +The failure is tracked by . + +* platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: + +2011-07-01 Adam Roben + Update expected results after r90159 Fixes REGRESSION (r90159): fast/events/window-onerror5.html Modified: trunk/LayoutTests/platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt (90233 => 90234) --- trunk/LayoutTests/platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt 2011-07-01 16:21:39 UTC (rev 90233) +++ trunk/LayoutTests/platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt 2011-07-01 16:21:49 UTC (rev 90234) @@ -5,8 +5,8 @@ usingNone.description: [] usingLabel.title: [Beta] usingLabel.description: [Description: Gamma] -usingLabelledby.title: [Epsilon] +usingLabelledby.title: [Delta] usingLabelledby.description: [Description: Epsilon] -usingLabeledby.title: [Theta] +usingLabeledby.title: [Eta] usingLabeledby.description: [Description: Theta] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90233] trunk/LayoutTests
Title: [90233] trunk/LayoutTests Revision 90233 Author aro...@apple.com Date 2011-07-01 09:21:39 -0700 (Fri, 01 Jul 2011) Log Message Update expected results after r90159 Fixes REGRESSION (r90159): fast/events/window-onerror5.html failing * fast/events/window-onerror5-expected.txt: Updated for progression. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/events/window-onerror5-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90232 => 90233) --- trunk/LayoutTests/ChangeLog 2011-07-01 16:18:48 UTC (rev 90232) +++ trunk/LayoutTests/ChangeLog 2011-07-01 16:21:39 UTC (rev 90233) @@ -1,3 +1,12 @@ +2011-07-01 Adam Roben + +Update expected results after r90159 + +Fixes REGRESSION (r90159): fast/events/window-onerror5.html +failing + +* fast/events/window-onerror5-expected.txt: Updated for progression. + 2011-07-01 Balazs Kelemen Reviewed by Andreas Kling. Modified: trunk/LayoutTests/fast/events/window-onerror5-expected.txt (90232 => 90233) --- trunk/LayoutTests/fast/events/window-onerror5-expected.txt 2011-07-01 16:18:48 UTC (rev 90232) +++ trunk/LayoutTests/fast/events/window-onerror5-expected.txt 2011-07-01 16:21:39 UTC (rev 90233) @@ -1,4 +1,4 @@ Test that window.onerror is invoked for syntax error in eval. You should see a log record if window.onerror is working properly for this test.Bug 8519. -Error caught successfully: SyntaxError: Unexpected EOF File: undefined Line: 1 +Error caught successfully: SyntaxError: Unexpected EOF File: window-onerror5.html Line: 16 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90232] trunk/Source/JavaScriptCore
Title: [90232] trunk/Source/_javascript_Core
Revision 90232
Author ddkil...@apple.com
Date 2011-07-01 09:18:48 -0700 (Fri, 01 Jul 2011)
Log Message
Fix clang build error in JITOpcodes32_64.cpp
Fixes the following build error in clang:
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
~~ ^
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' _expression_ to silence this warning [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
^
( )
fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' _expression_ to evaluate it first [3]
map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
^~
1 error generated.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
tertiary _expression_ evaluate first.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90231 => 90232)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-01 16:18:48 UTC (rev 90232)
@@ -1,3 +1,27 @@
+2011-07-01 David Kilzer
+
+ Fix clang build error in JITOpcodes32_64.cpp
+
+Fixes the following build error in clang:
+
+_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+ ~~ ^
+_javascript_Core/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' _expression_ to silence this warning [3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+^
+ ( )
+fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"("
+fix-it:"_javascript_Core/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")"
+_javascript_Core/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' _expression_ to evaluate it first [3]
+ map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+^~
+1 error generated.
+
+* jit/JITOpcodes32_64.cpp:
+(JSC::JIT::emit_op_resolve_global): Add parenthesis to make the
+tertiary _expression_ evaluate first.
+
2011-07-01 Sheriff Bot
Unreviewed, rolling out r90177 and r90179.
Modified: trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp (90231 => 90232)
--- trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp 2011-07-01 16:17:44 UTC (rev 90231)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp 2011-07-01 16:18:48 UTC (rev 90232)
@@ -738,7 +738,7 @@
load32(BaseIndex(regT2, regT3, TimesEight, OBJECT_OFFSETOF(JSValue, u.asBits.payload)), regT0); // payload
load32(BaseIndex(regT2, regT3, TimesEight, OBJECT_OFFSETOF(JSValue, u.asBits.tag)), regT1); // tag
emitStore(dst, regT1, regT0);
-map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0);
+map(m_bytecodeOffset + (dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global)), dst, regT1, regT0);
}
void JIT::emitSlow_op_resolve_global(Instruction* currentInstruction, Vector::iterator& iter)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90231] trunk
Title: [90231] trunk Revision 90231 Author kbal...@webkit.org Date 2011-07-01 09:17:44 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Balazs Kelemen Reviewed by Andreas Kling. [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation https://bugs.webkit.org/show_bug.cgi?id=63239 * platform/qt-wk2/Skipped: 2011-07-01 Balazs Kelemen Reviewed by Andreas Kling. [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation https://bugs.webkit.org/show_bug.cgi?id=63239 * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Revert the return value of NPP_HandleEvent because the plugin function returns with 0 if it handled the event. (WebKit::NetscapePlugin::platformHandleMouseEvent): (WebKit::NetscapePlugin::platformHandleWheelEvent): (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): (WebKit::NetscapePlugin::platformHandleKeyboardEvent): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp Diff Modified: trunk/LayoutTests/ChangeLog (90230 => 90231) --- trunk/LayoutTests/ChangeLog 2011-07-01 15:55:37 UTC (rev 90230) +++ trunk/LayoutTests/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231) @@ -1,3 +1,12 @@ +2011-07-01 Balazs Kelemen + +Reviewed by Andreas Kling. + +[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation +https://bugs.webkit.org/show_bug.cgi?id=63239 + +* platform/qt-wk2/Skipped: + 2011-07-01 Alice Boxhall Reviewed by Adam Roben. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (90230 => 90231) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 15:55:37 UTC (rev 90230) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-07-01 16:17:44 UTC (rev 90231) @@ -1491,7 +1491,6 @@ # Unexplained plugin failures plugins/embed-prefers-plugins-for-images.html -plugins/mouse-events-fixedpos.html plugins/netscape-dom-access.html plugins/npp-set-window-called-during-destruction.html plugins/reloadplugins-and-pages.html Modified: trunk/Source/WebKit2/ChangeLog (90230 => 90231) --- trunk/Source/WebKit2/ChangeLog 2011-07-01 15:55:37 UTC (rev 90230) +++ trunk/Source/WebKit2/ChangeLog 2011-07-01 16:17:44 UTC (rev 90231) @@ -1,3 +1,19 @@ +2011-07-01 Balazs Kelemen + +Reviewed by Andreas Kling. + +[X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation +https://bugs.webkit.org/show_bug.cgi?id=63239 + +* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: +Revert the return value of NPP_HandleEvent because the plugin function +returns with 0 if it handled the event. +(WebKit::NetscapePlugin::platformHandleMouseEvent): +(WebKit::NetscapePlugin::platformHandleWheelEvent): +(WebKit::NetscapePlugin::platformHandleMouseEnterEvent): +(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): +(WebKit::NetscapePlugin::platformHandleKeyboardEvent): + 2011-07-01 Mark Rowe Unreviewed due to fixing of a broken world. Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (90230 => 90231) --- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-07-01 15:55:37 UTC (rev 90230) +++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-07-01 16:17:44 UTC (rev 90231) @@ -434,7 +434,7 @@ return false; } -return NPP_HandleEvent(&xEvent); +return !NPP_HandleEvent(&xEvent); } // We undefine these constants in npruntime_internal.h to avoid collision @@ -453,7 +453,7 @@ initializeXEvent(xEvent); setXButtonEventFieldsByWebWheelEvent(xEvent, event, m_frameRect.location()); -return NPP_HandleEvent(&xEvent); +return !NPP_HandleEvent(&xEvent); } void NetscapePlugin::platformSetFocus(bool focusIn) @@ -480,7 +480,7 @@ initializeXEvent(xEvent); setXCrossingEventFields(xEvent, event, m_frameRect.location(), EnterNotify); -return NPP_HandleEvent(&xEvent); +return !NPP_HandleEvent(&xEvent); } bool NetscapePlugin::platformHandleMouseLeaveEvent(const WebMouseEvent& event) @@ -492,7 +492,7 @@ initializeXEvent(xEvent); setXCrossingEventFields(xEvent, event, m_frameRect.location(), LeaveNotify); -return NPP_HandleEvent(&xEvent); +return !NPP_HandleEvent(&xEvent); } static inline void setXKeyEventFields(XEvent& xEvent, const WebKeyboardEvent& webEvent) @@ -524,7 +524,7 @@ initializeXEvent(xEvent); setXKeyEventFields(xEvent, event); -return NPP_HandleEvent(&xEvent); +return !NPP_HandleEvent(&xEvent); } } //
[webkit-changes] [90230] trunk/Tools
Title: [90230] trunk/Tools
Revision 90230
Author aro...@apple.com
Date 2011-07-01 08:55:37 -0700 (Fri, 01 Jul 2011)
Log Message
Make TestFailures stop loading old builds once we've explained all current failures
We used to do this, but some refactoring in r90165 broke this logic.
Fixes REGRESSION (r90165): TestFailures page always loads all
builds back to the beginning of time
Reviewed by Dan Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
all current failures have been explained.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js (90229 => 90230)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js 2011-07-01 15:21:02 UTC (rev 90229)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js 2011-07-01 15:55:37 UTC (rev 90230)
@@ -97,6 +97,9 @@
if (callbackRequestedStop)
return;
+if (!callAgain)
+return;
+
if (analyzedAllBuilds) {
if (analyzedAllBuildsCallback)
analyzedAllBuildsCallback();
Modified: trunk/Tools/ChangeLog (90229 => 90230)
--- trunk/Tools/ChangeLog 2011-07-01 15:21:02 UTC (rev 90229)
+++ trunk/Tools/ChangeLog 2011-07-01 15:55:37 UTC (rev 90230)
@@ -1,5 +1,20 @@
2011-07-01 Adam Roben
+Make TestFailures stop loading old builds once we've explained all current failures
+
+We used to do this, but some refactoring in r90165 broke this logic.
+
+Fixes REGRESSION (r90165): TestFailures page always loads all
+builds back to the beginning of time
+
+Reviewed by Dan Bates.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
+(LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
+all current failures have been explained.
+
+2011-07-01 Adam Roben
+
commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90229] trunk/Tools
Title: [90229] trunk/Tools
Revision 90229
Author aro...@apple.com
Date 2011-07-01 08:21:02 -0700 (Fri, 01 Jul 2011)
Log Message
commit-log-editor reorders ChangeLog entries in unexpected ways
https://bugs.webkit.org/show_bug.cgi?id=63804
Reviewed by Darin Adler.
commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
commit message in order to make git-based tools, which expect the first line of the commit
message to be a summary of the change, to work better. But this reordering of the ChangeLog
entry was unpredictable and unexpected.
I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
try to move them.
* Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
line and try to move it down below the bug title and URL. The order of the text in the
ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
by" line in cases where the committer and author are not the same person.
* Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/commit-log-editor
trunk/Tools/Scripts/prepare-ChangeLog
Diff
Modified: trunk/Tools/ChangeLog (90228 => 90229)
--- trunk/Tools/ChangeLog 2011-07-01 14:51:31 UTC (rev 90228)
+++ trunk/Tools/ChangeLog 2011-07-01 15:21:02 UTC (rev 90229)
@@ -1,3 +1,26 @@
+2011-07-01 Adam Roben
+
+commit-log-editor reorders ChangeLog entries in unexpected ways
+https://bugs.webkit.org/show_bug.cgi?id=63804
+
+Reviewed by Darin Adler.
+
+commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
+commit message in order to make git-based tools, which expect the first line of the commit
+message to be a summary of the change, to work better. But this reordering of the ChangeLog
+entry was unpredictable and unexpected.
+
+I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
+so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
+try to move them.
+
+* Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
+line and try to move it down below the bug title and URL. The order of the text in the
+ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
+by" line in cases where the committer and author are not the same person.
+
+* Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
+
2011-07-01 Mihnea Ovidenie
Reviewed by Adam Roben.
Modified: trunk/Tools/Scripts/commit-log-editor (90228 => 90229)
--- trunk/Tools/Scripts/commit-log-editor 2011-07-01 14:51:31 UTC (rev 90228)
+++ trunk/Tools/Scripts/commit-log-editor 2011-07-01 15:21:02 UTC (rev 90229)
@@ -152,7 +152,6 @@
open CHANGELOG, $changeLog or die "Can't open $changeLog";
my $contents = "";
my $blankLines = "";
-my $reviewedByLine = "";
my $lineCount = 0;
my $date = "";
my $author = "";
@@ -163,20 +162,14 @@
last if $contents;
}
if (/\S/) {
-my $previousLineWasBlank = 1 unless $blankLines eq "";
-my $line = $_;
-my $currentLineBlankLines = $blankLines;
+$contents .= $blankLines if $contents;
$blankLines = "";
+my $line = $_;
+
# Remove indentation spaces
$line =~ s/^ {8}//;
-# Save the reviewed / rubber stamped by line.
-if ($line =~ m/^Reviewed by .*/ || $line =~ m/^Rubber[ \-]?stamped by .*/) {
-$reviewedByLine = $line;
-next;
-}
-
# Grab the author and the date line
if ($line =~ m/^([0-9]{4}-[0-9]{2}-[0-9]{2})\s+(.*[^\s])\s+<(.*)>/ && $lineCount == 0) {
$date = $1;
@@ -186,10 +179,8 @@
next;
}
-$contents .= $currentLineBlankLines if $contents;
-
-# Attempt to insert the "patch by" line, after the first blank line.
-if ($previousLineWasBlank && $hasAuthorInfoToWrite && $lineCount > 0) {
+if ($line =~ m/^Reviewed by .*/ || $line =~ m/^Rubber[ \-]?stamped by .*/) {
+# Insert the "Patch by" line just above the "Reviewed by" line, if needed.
my $committerEmail = changeLogEmailAddress();
my $authorAndCommitterAreSamePerson = $email eq $committerEmail;
if (!$authorAndCommitterAreSamePerson) {
@@ -198,11 +189,6 @@
}
}
-# Attempt to insert the "reviewed by" line, after the first blank line.
-if
[webkit-changes] [90228] trunk/Tools
Title: [90228] trunk/Tools
Revision 90228
Author commit-qu...@webkit.org
Date 2011-07-01 07:51:31 -0700 (Fri, 01 Jul 2011)
Log Message
2011-07-01 Mihnea Ovidenie
Reviewed by Adam Roben.
[CSSRegions] Add build slave
https://bugs.webkit.org/show_bug.cgi?id=62372
* BuildSlaveSupport/build.webkit.org-config/config.json:
Add an entry for a release build of Mac.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (90227 => 90228)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-07-01 14:29:12 UTC (rev 90227)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-07-01 14:51:31 UTC (rev 90228)
@@ -67,7 +67,9 @@
{ "name": "wince-1", "platform": "wince" },
-{ "name": "efl-linux-slave-1", "platform": "efl" }
+{ "name": "efl-linux-slave-1", "platform": "efl" },
+
+{ "name": "adobe-mac-slave1", "platform": "mac-snowleopard" }
],
"builders": [ { "name": "Leopard Intel Release (Build)", "type": "Build", "builddir": "leopard-intel-release",
@@ -244,6 +246,10 @@
"name": "EFL Linux Release (Build)", "type": "Build", "builddir": "efl-linux-release",
"platform": "efl", "configuration": "release", "architectures": ["i386"],
"slavenames": ["efl-linux-slave-1"]
+},
+{ "name": "CSSRegions SnowLeopard Intel Release (Build)", "type": "Build", "builddir": "cssregions-snowleopard-intel-release",
+ "platform": "mac-snowleopard", "configuration": "release", "architectures": ["x86_64"],
+ "slavenames": ["adobe-mac-slave1"]
}
],
@@ -259,7 +265,8 @@
"builderNames": ["Leopard Intel Release (Build)", "Leopard Intel Debug (Build)", "Leopard Intel Release (NRWT)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "mac-snowleopard", "branch": "trunk", "treeStableTimer": 45.0,
- "builderNames": ["SnowLeopard Intel Release (Build)", "SnowLeopard Intel Leaks", "SnowLeopard Intel Release (NRWT)", "SnowLeopard Intel Debug (Build)"]
+ "builderNames": ["SnowLeopard Intel Release (Build)", "SnowLeopard Intel Leaks", "SnowLeopard Intel Release (NRWT)", "SnowLeopard Intel Debug (Build)",
+ "CSSRegions SnowLeopard Intel Release (Build)"]
},
{ "type": "PlatformSpecificScheduler", "platform": "win", "branch": "trunk", "treeStableTimer": 45.0,
"builderNames": ["Windows Release (Build)", "Windows Debug (Build)"]
Modified: trunk/Tools/ChangeLog (90227 => 90228)
--- trunk/Tools/ChangeLog 2011-07-01 14:29:12 UTC (rev 90227)
+++ trunk/Tools/ChangeLog 2011-07-01 14:51:31 UTC (rev 90228)
@@ -1,3 +1,13 @@
+2011-07-01 Mihnea Ovidenie
+
+Reviewed by Adam Roben.
+
+[CSSRegions] Add build slave
+https://bugs.webkit.org/show_bug.cgi?id=62372
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+Add an entry for a release build of Mac.
+
2011-07-01 Sheriff Bot
Unreviewed, rolling out r90213.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90227] trunk/Source/WebKit/qt
Title: [90227] trunk/Source/WebKit/qt Revision 90227 Author commit-qu...@webkit.org Date 2011-07-01 07:29:12 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Jade Han Reviewed by Laszlo Gombos. [Qt][Symbian] Update .def file for Symbian https://bugs.webkit.org/show_bug.cgi?id=61200 Add newly introduced symbols to fix the Symbian build. * symbian/eabi/QtWebKitu.def: Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def Diff Modified: trunk/Source/WebKit/qt/ChangeLog (90226 => 90227) --- trunk/Source/WebKit/qt/ChangeLog 2011-07-01 14:18:41 UTC (rev 90226) +++ trunk/Source/WebKit/qt/ChangeLog 2011-07-01 14:29:12 UTC (rev 90227) @@ -1,3 +1,14 @@ +2011-07-01 Jade Han + +Reviewed by Laszlo Gombos. + +[Qt][Symbian] Update .def file for Symbian +https://bugs.webkit.org/show_bug.cgi?id=61200 + +Add newly introduced symbols to fix the Symbian build. + +* symbian/eabi/QtWebKitu.def: + 2011-06-30 Rafael Brandao Reviewed by Benjamin Poulain. Modified: trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def (90226 => 90227) --- trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-07-01 14:18:41 UTC (rev 90226) +++ trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-07-01 14:29:12 UTC (rev 90227) @@ -812,7 +812,7 @@ _ZN8QWebPage25requestPermissionFromUserEP9QWebFrameNS_16PermissionDomainE @ 811 NONAME ABSENT _ZN8QWebPage27cancelRequestsForPermissionEP9QWebFrameNS_16PermissionDomainE @ 812 NONAME ABSENT _ZNK16QGraphicsWebView10deviceSizeEv @ 813 NONAME ABSENT - _ZN23DumpRenderTreeSupportQt14viewportAsTextEP8QWebPageRK5QSize @ 814 NONAME + _ZN23DumpRenderTreeSupportQt14viewportAsTextEP8QWebPageRK5QSize @ 814 NONAME ABSENT _ZN23DumpRenderTreeSupportQt32simulateDesktopNotificationClickERK7QString @ 815 NONAME _ZN8QWebPage23viewportChangeRequestedEv @ 816 NONAME _ZNK8QWebPage28viewportConfigurationForSizeERK5QSize @ 817 NONAME ABSENT @@ -839,9 +839,10 @@ _ZN23DumpRenderTreeSupportQt23setMockGeolocationErrorEP8QWebPageiRK7QString @ 838 NONAME _ZN23DumpRenderTreeSupportQt26setMockGeolocationPositionEP8QWebPageddd @ 839 NONAME _ZN23DumpRenderTreeSupportQt14viewportAsTextEP8QWebPageiRK5QSizeS4_ @ 840 NONAME - _ZN23DumpRenderTreeSupportQt13nodesFromRectERK11QWebElementiib @ 841 NONAME - _ZN23DumpRenderTreeSupportQt9plainTextERK8QVariant @ 842 NONAME - _ZN23DumpRenderTreeSupportQt26mediaContentUrlByElementIdEP9QWebFrameRK7QString @ 843 NONAME - _ZNK8QWebPage12hasSelectionEv @ 844 NONAME - _ZNK8QWebPage12selectedHtmlEv @ 845 NONAME - _ZN11QWebElement6renderEP8QPainterRK5QRect @ 846 NONAME + _ZN23DumpRenderTreeSupportQt26mediaContentUrlByElementIdEP9QWebFrameRK7QString @ 841 NONAME + _ZNK8QWebPage12hasSelectionEv @ 842 NONAME + _ZNK8QWebPage12selectedHtmlEv @ 843 NONAME + _ZN11QWebElement6renderEP8QPainterRK5QRect @ 844 NONAME + _ZN16QGraphicsWebView13setRenderHintEN8QPainter10RenderHintEb @ 845 NONAME + _ZN16QGraphicsWebView14setRenderHintsE6QFlagsIN8QPainter10RenderHintEE @ 846 NONAME + _ZNK16QGraphicsWebView11renderHintsEv @ 847 NONAME ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90226] trunk/LayoutTests
Title: [90226] trunk/LayoutTests Revision 90226 Author commit-qu...@webkit.org Date 2011-07-01 07:18:41 -0700 (Fri, 01 Jul 2011) Log Message 2011-07-01 Alice Boxhall Reviewed by Adam Roben. accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added https://bugs.webkit.org/show_bug.cgi?id=63191 * accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed. * accessibility/aria-labelledby-overrides-aria-label.html: * platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added. * platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label.html trunk/LayoutTests/platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt Added Paths trunk/LayoutTests/platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt Removed Paths trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90225 => 90226) --- trunk/LayoutTests/ChangeLog 2011-07-01 13:58:18 UTC (rev 90225) +++ trunk/LayoutTests/ChangeLog 2011-07-01 14:18:41 UTC (rev 90226) @@ -1,3 +1,15 @@ +2011-07-01 Alice Boxhall + +Reviewed by Adam Roben. + +accessibility/aria-labelledby-overrides-aria-label.html failing on Windows since it was added +https://bugs.webkit.org/show_bug.cgi?id=63191 + +* accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed. +* accessibility/aria-labelledby-overrides-aria-label.html: +* platform/mac/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added. +* platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt: + 2011-07-01 Kentaro Hara Reviewed by Kent Tamura. Deleted: trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt (90225 => 90226) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt 2011-07-01 13:58:18 UTC (rev 90225) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt 2011-07-01 14:18:41 UTC (rev 90226) @@ -1,18 +0,0 @@ -Alpha Beta Delta Eta Epsilon Theta -This tests that if aria-labelledby is used, then aria-label attributes are not used. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS usingNone.title is "AXTitle: Alpha" -PASS usingNone.description is "AXDescription: " -PASS usingLabel.title is "AXTitle: Beta" -PASS usingLabel.description is "AXDescription: Gamma" -PASS usingLabelledby.title is "AXTitle: Delta" -PASS usingLabelledby.description is "AXDescription: Epsilon" -PASS usingLabeledby.title is "AXTitle: Eta" -PASS usingLabeledby.description is "AXDescription: Theta" -PASS successfullyParsed is true - -TEST COMPLETE - Modified: trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label.html (90225 => 90226) --- trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label.html 2011-07-01 13:58:18 UTC (rev 90225) +++ trunk/LayoutTests/accessibility/aria-labelledby-overrides-aria-label.html 2011-07-01 14:18:41 UTC (rev 90226) @@ -1,13 +1,9 @@ - -var successfullyParsed = false; - - +This tests that if aria-labelledby is used, then aria-label attributes are not used.
@@ -16,53 +12,46 @@ Epsilon Theta- -+
+