[webkit-changes] [90335] trunk/LayoutTests

2011-07-02 Thread mihaip 
Title: [90335] trunk/LayoutTests








Revision 90335
Author mih...@chromium.org
Date 2011-07-02 21:02:24 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  

Remove failing expectation for fast/events/panScroll-click-hyperlink.html
(Chromium still doesn't pass the test, since it doesn't have pan
scrolling enabled, but r90235 added failing expectations for the Windows
port, which Chromium Win and Linux pick up)

Also remove flaky expectations for some tests that have not failed as
far back as the flakiness dashboard has data for.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90334 => 90335)

--- trunk/LayoutTests/ChangeLog	2011-07-03 02:26:43 UTC (rev 90334)
+++ trunk/LayoutTests/ChangeLog	2011-07-03 04:02:24 UTC (rev 90335)
@@ -1,3 +1,15 @@
+2011-07-02  Mihai Parparita  
+
+Remove failing expectation for fast/events/panScroll-click-hyperlink.html
+(Chromium still doesn't pass the test, since it doesn't have pan
+scrolling enabled, but r90235 added failing expectations for the Windows
+port, which Chromium Win and Linux pick up)
+
+Also remove flaky expectations for some tests that have not failed as
+far back as the flakiness dashboard has data for.
+
+* platform/chromium/test_expectations.txt:
+
 2011-07-02  Anders Carlsson  
 
 Update skipped list.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90334 => 90335)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-03 02:26:43 UTC (rev 90334)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-03 04:02:24 UTC (rev 90335)
@@ -305,6 +305,7 @@
 WONTFIX : platform/qt = FAIL PASS
 WONTFIX SKIP : platform/qt/plugins/qt-qwidget-plugin.html = FAIL
 WONTFIX SKIP : platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html = PASS
+WONTFIX SKIP : platform/qt/fast/forms = PASS FAIL CRASH TIMEOUT
 
 WONTFIX MAC WIN : platform/chromium-linux = FAIL
 WONTFIX SKIP LINUX MAC : platform/win = FAIL CRASH PASS
@@ -1467,8 +1468,7 @@
 
 // Flakey. Not clear when it started, but it was before 3/9/09.
 // This test also started failing with the merge of March 25th 2009
-BUGCR10441 WIN : transitions/transition-end-event-transform.html = TEXT PASS
-BUGCR10441 MAC RELEASE : transitions/transition-end-event-transform.html = TEXT PASS
+BUGCR10441 MAC WIN : transitions/transition-end-event-transform.html = TEXT PASS
 
 // Merge 41768:41807
 // Perhaps just needs new baseline?
@@ -3527,9 +3527,7 @@
 BUGCASEQ WIN LINUX : fast/forms/input-text-drag-down.html = IMAGE+TEXT
 BUGCASEQ LEOPARD : fast/canvas/image-object-in-canvas.html = IMAGE
 
-
 BUGDPRANKE MAC DEBUG : transitions/cancel-transition.html = TEXT PASS
-
 BUGDPRANKE LINUX DEBUG : fast/dom/Node/mutation-blur.html = CRASH PASS
 
 // flakiness
@@ -3595,39 +3593,15 @@
 // broke in r84742 - just needs a new baseline?
 BUGWK60121 : http/tests/misc/will-send-request-returns-null-on-redirect.html = TEXT
 
-BUGWK62761 WIN : fast/events/panScroll-click-hyperlink.html = PASS TEXT
-BUGWK62761 LINUX : fast/events/panScroll-click-hyperlink.html = TEXT
 BUGCR86337 : fast/files/domurl-script-execution-context-crash.html = CRASH PASS
 BUGCR86338 : fast/loader/file-protocol-fragment.html = TEXT
 BUGCR86340 : fast/filesystem/file-writer-write-overlapped.html = CRASH PASS TEXT
 
 // flakiness on deps bots (noted ~ r83108)
-BUGDPRANKE WIN CPU DEBUG : editing/selection/select-line.html = PASS CRASH
 BUGDPRANKE WIN CPU DEBUG : fast/css/last-of-type-pseudo-class.html = PASS TEXT
-BUGDPRANKE WIN CPU DEBUG : http/tests/local/stylesheet-and-script-load-order-media-print.html = PASS CRASH
-BUGDPRANKE WIN CPU DEBUG : svg/text/select-textLength-spacingAndGlyphs-squeeze-3.svg = PASS CRASH
-BUGDPRANKE MAC CPU DEBUG : fast/block/float/overhanging-tall-block.html = PASS CRASH
-BUGDPRANKE MAC CPU DEBUG : fast/css/import_with_baseurl.html = PASS CRASH
 BUGDPRANKE WIN CPU DEBUG : http/tests/eventsource/eventsource-reconnect.html = PASS TEXT
 BUGDPRANKE WIN : http/tests/navigation/ping-same-origin.html = PASS TIMEOUT TEXT
-BUGDPRANKE WIN CPU DEBUG : svg/custom/getscreenctm-in-scrollable-div-area-nested.xhtml = PASS CRASH
-
-// flakiness on canaries (noted ~ r85006)
-BUGDPRANKE CPU : svg/hixie/rendering-model/003.xhtml = IMAGE+TEXT PASS
-BUGDPRANKE CPU : fast/dom/HTMLFormElement/document-deactivation-callback-crash.html = PASS TEXT
-BUGDPRANKE LINUX DEBUG CPU : svg/custom/font-platformDestroy-crash.svg = PASS CRASH
-BUGDPRANKE CPU : fast/dom/HTMLObjectElement/object-as-frame.html = PASS TEXT
-BUGDPRANKE CPU LINUX DEBUG : editing/pasteboard/drop-text-events.html = PASS CRASH
-BUGDPRANKE MAC DEBUG :   transitions/transition-end-event-transform.html = TEXT PASS
-
-// start skipping platform tests
-BU

[webkit-changes] [90334] trunk/PerformanceTests/SunSpider

2011-07-02 Thread mjs 
Title: [90334] trunk/PerformanceTests/SunSpider








Revision 90334
Author m...@apple.com
Date 2011-07-02 19:26:43 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Maciej Stachowiak  

Update SunSpider versioning to 1.0
https://bugs.webkit.org/show_bug.cgi?id=63870

Reviewed by Dan Bernstein.

* hosted/sunspider.html:
* hosted/versions.html:
* resources/driver-TEMPLATE.html:
* resources/results-TEMPLATE.html:
* sunspider:

Modified Paths

trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/hosted/sunspider.html
trunk/PerformanceTests/SunSpider/hosted/versions.html
trunk/PerformanceTests/SunSpider/resources/driver-TEMPLATE.html
trunk/PerformanceTests/SunSpider/resources/results-TEMPLATE.html
trunk/PerformanceTests/SunSpider/sunspider




Diff

Modified: trunk/PerformanceTests/SunSpider/ChangeLog (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-03 02:26:43 UTC (rev 90334)
@@ -1,5 +1,18 @@
 2011-07-02  Maciej Stachowiak  
 
+Update SunSpider versioning to 1.0
+https://bugs.webkit.org/show_bug.cgi?id=63870
+
+Reviewed by Dan Bernstein.
+
+* hosted/sunspider.html:
+* hosted/versions.html:
+* resources/driver-TEMPLATE.html:
+* resources/results-TEMPLATE.html:
+* sunspider:
+
+2011-07-02  Maciej Stachowiak  
+
 Sunspider 0.9.1 harness doesn't actually close() its test documents
 https://bugs.webkit.org/show_bug.cgi?id=47045
 


Modified: trunk/PerformanceTests/SunSpider/hosted/sunspider.html (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/hosted/sunspider.html	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/hosted/sunspider.html	2011-07-03 02:26:43 UTC (rev 90334)
@@ -28,13 +28,13 @@
  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 -->
-SunSpider 0.9.1 _javascript_ Benchmark
+SunSpider 1.0 _javascript_ Benchmark
  
 
 
 
-☀SunSpider 0.9.1 _javascript_ Benchmark
+☀SunSpider 1.0 _javascript_ Benchmark
 
 This is SunSpider, a _javascript_ benchmark. This benchmark tests the
 core _javascript_ language only, not the DOM or other browser APIs. It
@@ -70,7 +70,7 @@
 
 
 
-Current version - sunspider-0.9.1: 
+Current version - sunspider-1.0: 
 (When you run the benchmark, be patient - it loops through all of the
 test cases five times and can take a minute or longer to complete.)
 


Modified: trunk/PerformanceTests/SunSpider/hosted/versions.html (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/hosted/versions.html	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/hosted/versions.html	2011-07-03 02:26:43 UTC (rev 90334)
@@ -29,20 +29,20 @@
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 -->
 
-SunSpider 0.9.1 _javascript_ Benchmark
+SunSpider 1.0 _javascript_ Benchmark
  
 
 
 
-☀SunSpider 0.9.1 _javascript_ Benchmark
+☀SunSpider 1.0 _javascript_ Benchmark
 
 This is SunSpider, a _javascript_ benchmark. This benchmark tests the
 core _javascript_ language only, not the DOM or other browser APIs. It
 is designed to compare different versions of the same browser, and
 different browsers to each other.
 
-This version of the harness is 0.9.1. This page lists all versions
+This version of the harness is 1.0. This page lists all versions
 of the test content:
 
 


Modified: trunk/PerformanceTests/SunSpider/resources/driver-TEMPLATE.html (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/resources/driver-TEMPLATE.html	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/resources/driver-TEMPLATE.html	2011-07-03 02:26:43 UTC (rev 90334)
@@ -29,7 +29,7 @@
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 -->
 
-SunSpider 0.9.1 _javascript_ Benchmark (@SUITE@ test suite - In Progress...)
+SunSpider 1.0 _javascript_ Benchmark (@SUITE@ test suite - In Progress...)
  
 


Modified: trunk/PerformanceTests/SunSpider/resources/results-TEMPLATE.html (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/resources/results-TEMPLATE.html	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/resources/results-TEMPLATE.html	2011-07-03 02:26:43 UTC (rev 90334)
@@ -29,12 +29,12 @@
  OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 -->
 
-SunSpider 0.9.1 _javascript_ Benchmark Results (@SUITE@ test suite)
+SunSpider 1.0 _javascript_ Benchmark Results (@SUITE@ test suite)
  
 
 
-☀SunSpider 0.9.1 _javascript_ Benchmark Results
+☀SunSpider 1.0 _javascript_ Benchmark Results
 
 Content Version: @SUITE@
 


Modified: trunk/PerformanceTests/SunSpider/sunspider (90333 => 90334)

--- trunk/PerformanceTests/SunSpider/sunspider	2011-07-03 01:35:32 UTC (rev 90333)
+++ trunk/PerformanceTests/SunSpider/sunspider	20

[webkit-changes] [90332] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90332] trunk/Source/WebKit2








Revision 90332
Author ander...@apple.com
Date 2011-07-02 18:19:24 -0700 (Sat, 02 Jul 2011)


Log Message
Have another go at fixing the Windows build.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90331 => 90332)

--- trunk/Source/WebKit2/ChangeLog	2011-07-03 01:15:49 UTC (rev 90331)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-03 01:19:24 UTC (rev 90332)
@@ -1,5 +1,15 @@
 2011-07-02  Anders Carlsson  
 
+Have another go at fixing the Windows build.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
+(WebKit::NetscapePlugin::containingWindow):
+(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
+(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
+
+2011-07-02  Anders Carlsson  
+
 Null out the plug-in controller after destroying the plug-in.
 https://bugs.webkit.org/show_bug.cgi?id=63869
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (90331 => 90332)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2011-07-03 01:15:49 UTC (rev 90331)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2011-07-03 01:19:24 UTC (rev 90332)
@@ -70,7 +70,7 @@
 #endif
 
 #elif PLATFORM(WIN)
-HWND containingWindow() const;
+HWND containingWindow();
 #endif
 
 PluginQuirks quirks() const { return m_pluginModule->pluginQuirks(); }


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp (90331 => 90332)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-03 01:15:49 UTC (rev 90331)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-03 01:19:24 UTC (rev 90332)
@@ -82,7 +82,7 @@
 ::RegisterClassW(&windowClass);
 }
 
-HWND NetscapePlugin::containingWindow() const
+HWND NetscapePlugin::containingWindow()
 {
 return controller()->nativeParentWindow();
 }
@@ -322,7 +322,7 @@
 if (m_isWindowed)
 return false;
 
-pluginController()->willSendEventToPlugin();
+controller()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);
@@ -336,7 +336,7 @@
 if (m_isWindowed)
 return false;
 
-pluginController()->willSendEventToPlugin();
+controller()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90331] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90331] trunk/Source/WebKit2








Revision 90331
Author ander...@apple.com
Date 2011-07-02 18:15:49 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Anders Carlsson  

Null out the plug-in controller after destroying the plug-in.
https://bugs.webkit.org/show_bug.cgi?id=63869

Reviewed by Maciej Stachowiak.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::destroy):
Call destroyPlugin.

* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::destroyPlugin):
Call destroy and null out the plug-in controller.

* WebProcess/Plugins/Plugin.h:
Add destroyPlugin, make destroy private.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::~PluginView):
Call destroyPlugin.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90330 => 90331)

--- trunk/Source/WebKit2/ChangeLog	2011-07-03 00:57:27 UTC (rev 90330)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-03 01:15:49 UTC (rev 90331)
@@ -1,5 +1,27 @@
 2011-07-02  Anders Carlsson  
 
+Null out the plug-in controller after destroying the plug-in.
+https://bugs.webkit.org/show_bug.cgi?id=63869
+
+Reviewed by Maciej Stachowiak.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::destroy):
+Call destroyPlugin.
+
+* WebProcess/Plugins/Plugin.cpp:
+(WebKit::Plugin::destroyPlugin):
+Call destroy and null out the plug-in controller.
+
+* WebProcess/Plugins/Plugin.h:
+Add destroyPlugin, make destroy private.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::~PluginView):
+Call destroyPlugin.
+
+2011-07-02  Anders Carlsson  
+
 Fix Windows build for real.
 
 * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:


Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (90330 => 90331)

--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2011-07-03 00:57:27 UTC (rev 90330)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp	2011-07-03 01:15:49 UTC (rev 90331)
@@ -137,7 +137,7 @@
 // used as an identifier so it's OK to just get a weak reference.
 Plugin* plugin = m_plugin.get();
 
-m_plugin->destroy();
+m_plugin->destroyPlugin();
 m_plugin = 0;
 
 platformDestroy();


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp (90330 => 90331)

--- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp	2011-07-03 00:57:27 UTC (rev 90330)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp	2011-07-03 01:15:49 UTC (rev 90331)
@@ -91,4 +91,11 @@
 return initialize(parameters);
 }
 
+void Plugin::destroyPlugin()
+{
+destroy();
+
+m_pluginController = 0;
+}
+
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h (90330 => 90331)

--- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h	2011-07-03 00:57:27 UTC (rev 90330)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h	2011-07-03 01:15:49 UTC (rev 90331)
@@ -75,6 +75,9 @@
 // Sets the active plug-in controller and initializes the plug-in.
 bool initialize(PluginController*, const Parameters&);
 
+// Destroys the plug-in.
+void destroyPlugin();
+
 // Returns the plug-in controller for this plug-in.
 PluginController* controller() { return m_pluginController; }
 
@@ -86,11 +89,11 @@
 // This is only called by the other initialize overload so it can be made private.
 virtual bool initialize(const Parameters&) = 0;
 
-public:
-
 // Destroys the plug-in.
 virtual void destroy() = 0;
 
+public:
+
 // Tells the plug-in to paint itself into the given graphics context. The passed-in context and
 // dirty rect are in window coordinates. The context is saved/restored by the caller.
 virtual void paint(WebCore::GraphicsContext*, const WebCore::IntRect& dirtyRect) = 0;


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (90330 => 90331)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-07-03 00:57:27 UTC (rev 90330)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2011-07-03 01:15:49 UTC (rev 90331)
@@ -284,7 +284,7 @@
 
 if (m_plugin && m_isInitialized) {
 m_isBeingDestroyed = true;
-m_plugin->destroy();
+m_plugin->destroyPlugin();
 m_isBeingDestroyed = false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90330] trunk/LayoutTests

2011-07-02 Thread andersca 
Title: [90330] trunk/LayoutTests








Revision 90330
Author ander...@apple.com
Date 2011-07-02 17:57:27 -0700 (Sat, 02 Jul 2011)


Log Message
Update skipped list.

* platform/wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (90329 => 90330)

--- trunk/LayoutTests/ChangeLog	2011-07-03 00:51:25 UTC (rev 90329)
+++ trunk/LayoutTests/ChangeLog	2011-07-03 00:57:27 UTC (rev 90330)
@@ -1,3 +1,9 @@
+2011-07-02  Anders Carlsson  
+
+Update skipped list.
+
+* platform/wk2/Skipped:
+
 2011-07-02  Mihai Parparita  
 
 Remove Chromium Leopard failing expectations for two tests (fast/dom/


Modified: trunk/LayoutTests/platform/wk2/Skipped (90329 => 90330)

--- trunk/LayoutTests/platform/wk2/Skipped	2011-07-03 00:51:25 UTC (rev 90329)
+++ trunk/LayoutTests/platform/wk2/Skipped	2011-07-03 00:57:27 UTC (rev 90330)
@@ -1432,6 +1432,7 @@
 editing/selection/rtl-move-selection-right-left.html
 editing/selection/5195166-1.html
 editing/selection/context-menu-text-selection.html
+editing/selection/directionality-after-undo-replace.html
 editing/execCommand/query-command-state.html
 editing/execCommand/query-text-alignment.html
 editing/execCommand/toggle-compound-styles.html
@@ -1827,11 +1828,12 @@
 
 # eventSender.keyDown is unimplemented
 # https://bugs.webkit.org/show_bug.cgi?id=57515
+fast/dom/shadow/shadow-host-transfer-focus.html
 fast/dom/shadow/tab-order-iframe-and-shadow.html
-fast/dom/shadow/shadow-host-transfer-focus.html
 fast/events/onchange-setvalue.html
+fast/forms/focus-with-display-block.html
 fast/forms/radio-group-keyboard-change-event.html
-fast/forms/focus-with-display-block.html
+fast/forms/search-disabled-readonly.html
 fast/forms/ValidityState-valueMissing-002.html
 svg/custom/focus-event-handling-keyboard.xhtml
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90329] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90329] trunk/Source/WebKit2








Revision 90329
Author ander...@apple.com
Date 2011-07-02 17:51:25 -0700 (Sat, 02 Jul 2011)


Log Message
Fix Windows build for real.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90328 => 90329)

--- trunk/Source/WebKit2/ChangeLog	2011-07-02 23:55:54 UTC (rev 90328)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-03 00:51:25 UTC (rev 90329)
@@ -1,5 +1,15 @@
 2011-07-02  Anders Carlsson  
 
+Fix Windows build for real.
+
+* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
+(WebKit::NetscapePlugin::containingWindow):
+(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
+(WebKit::NetscapePlugin::platformPaint):
+(WebKit::NetscapePlugin::platformHandleMouseEvent):
+
+2011-07-02  Anders Carlsson  
+
 Implement NPN_PluginThreadAsyncCall
 https://bugs.webkit.org/show_bug.cgi?id=63868
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp (90328 => 90329)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-02 23:55:54 UTC (rev 90328)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-03 00:51:25 UTC (rev 90329)
@@ -84,7 +84,7 @@
 
 HWND NetscapePlugin::containingWindow() const
 {
-return pluginController()->nativeParentWindow();
+return controller()->nativeParentWindow();
 }
 
 bool NetscapePlugin::platformPostInitialize()
@@ -167,11 +167,11 @@
 
 WindowGeometry geometry;
 geometry.window = m_window;
-geometry.visible = pluginController()->isPluginVisible();
+geometry.visible = controller()->isPluginVisible();
 geometry.frame = m_frameRect;
 geometry.clipRect = clipRectInPluginWindowCoordinates;
 
-pluginController()->scheduleWindowedPluginGeometryUpdate(geometry);
+controller()->scheduleWindowedPluginGeometryUpdate(geometry);
 }
 
 void NetscapePlugin::platformPaint(GraphicsContext* context, const IntRect& dirtyRect, bool)
@@ -185,7 +185,7 @@
 return;
 }
 
-pluginController()->willSendEventToPlugin();
+controller()->willSendEventToPlugin();
 
 LocalWindowsContext windowsContext(context, dirtyRect, m_isTransparent);
 
@@ -293,7 +293,7 @@
 if (m_isWindowed)
 return false;
 
-pluginController()->willSendEventToPlugin();
+controller()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90328] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90328] trunk/Source/WebKit2








Revision 90328
Author ander...@apple.com
Date 2011-07-02 16:55:54 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Anders Carlsson  

Implement NPN_PluginThreadAsyncCall
https://bugs.webkit.org/show_bug.cgi?id=63868

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_PluginThreadAsyncCall):
Call NetscapePlugin::pluginThreadAsyncCall.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
Schedule a work item to call the function on the main run loop.

(WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
If the plug-in is still running, run the function.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add new member function.

* WebProcess/Plugins/Plugin.h:
Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially
ref the plug-in from other threads.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90327 => 90328)

--- trunk/Source/WebKit2/ChangeLog	2011-07-02 23:41:26 UTC (rev 90327)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-02 23:55:54 UTC (rev 90328)
@@ -1,5 +1,30 @@
 2011-07-02  Anders Carlsson  
 
+Implement NPN_PluginThreadAsyncCall
+https://bugs.webkit.org/show_bug.cgi?id=63868
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
+(WebKit::NPN_PluginThreadAsyncCall):
+Call NetscapePlugin::pluginThreadAsyncCall.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::pluginThreadAsyncCall):
+Schedule a work item to call the function on the main run loop.
+
+(WebKit::NetscapePlugin::handlePluginThreadAsyncCall):
+If the plug-in is still running, run the function.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+Add new member function.
+
+* WebProcess/Plugins/Plugin.h:
+Make plug-in inherit from ThreadSafeRefCounted since plug-ins can potentially
+ref the plug-in from other threads.
+
+2011-07-02  Anders Carlsson  
+
 Fix Windows build.
 
 * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp (90327 => 90328)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp	2011-07-02 23:41:26 UTC (rev 90327)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp	2011-07-02 23:55:54 UTC (rev 90328)
@@ -797,9 +797,11 @@
 return false;
 }
 
-static void NPN_PluginThreadAsyncCall(NPP instance, void (*func) (void*), void* userData)
+static void NPN_PluginThreadAsyncCall(NPP npp, void (*function)(void*), void* userData)
 {
-notImplemented();
+RefPtr plugin = NetscapePlugin::fromNPP(npp);
+
+plugin->pluginThreadAsyncCall(function, userData);
 }
 
 static bool NPN_Construct(NPP npp, NPObject* npObject, const NPVariant* arguments, uint32_t argumentCount, NPVariant* result)


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (90327 => 90328)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp	2011-07-02 23:41:26 UTC (rev 90327)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp	2011-07-02 23:55:54 UTC (rev 90328)
@@ -31,6 +31,7 @@
 #include "NetscapePluginStream.h"
 #include "PluginController.h"
 #include "ShareableBitmap.h"
+#include "WorkItem.h"
 #include 
 #include 
 #include 
@@ -289,6 +290,19 @@
 m_popupEnabledStates.removeLast();
 }
 
+void NetscapePlugin::pluginThreadAsyncCall(void (*function)(void*), void* userData)
+{
+RunLoop::main()->scheduleWork(WorkItem::create(this, &NetscapePlugin::handlePluginThreadAsyncCall, function, userData));
+}
+
+void NetscapePlugin::handlePluginThreadAsyncCall(void (*function)(void*), void* userData)
+{
+if (!m_isStarted)
+return;
+
+function(userData);
+}
+
 String NetscapePlugin::proxiesForURL(const String& urlString)
 {
 return controller()->proxiesForURL(urlString);


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (90327 => 90328)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2011-07-02 23:41:26 UTC (rev 90327)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h	2011-07-02 23:55:54 UTC (rev 90328)
@@ -101,6 +101,11 @@
 void pushPopupsEnabledState(bool enabled);
 void popPopupsEnabledState();
 
+void pluginThreadAsyncCall(void (*function)(void*), void* userData

[webkit-changes] [90327] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90327] trunk/Source/WebKit2








Revision 90327
Author ander...@apple.com
Date 2011-07-02 16:41:26 -0700 (Sat, 02 Jul 2011)


Log Message
Fix Windows build.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::containingWindow):
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90326 => 90327)

--- trunk/Source/WebKit2/ChangeLog	2011-07-02 23:40:31 UTC (rev 90326)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-02 23:41:26 UTC (rev 90327)
@@ -1,5 +1,17 @@
 2011-07-02  Anders Carlsson  
 
+Fix Windows build.
+
+* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
+(WebKit::NetscapePlugin::containingWindow):
+(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
+(WebKit::NetscapePlugin::platformPaint):
+(WebKit::NetscapePlugin::platformHandleMouseEvent):
+(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
+(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
+
+2011-07-02  Anders Carlsson  
+
 Move the plug-in controller member variable up to the shared Plugin base class
 https://bugs.webkit.org/show_bug.cgi?id=63867
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp (90326 => 90327)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-02 23:40:31 UTC (rev 90326)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp	2011-07-02 23:41:26 UTC (rev 90327)
@@ -84,7 +84,7 @@
 
 HWND NetscapePlugin::containingWindow() const
 {
-return m_pluginController->nativeParentWindow();
+return pluginController()->nativeParentWindow();
 }
 
 bool NetscapePlugin::platformPostInitialize()
@@ -167,11 +167,11 @@
 
 WindowGeometry geometry;
 geometry.window = m_window;
-geometry.visible = m_pluginController->isPluginVisible();
+geometry.visible = pluginController()->isPluginVisible();
 geometry.frame = m_frameRect;
 geometry.clipRect = clipRectInPluginWindowCoordinates;
 
-m_pluginController->scheduleWindowedPluginGeometryUpdate(geometry);
+pluginController()->scheduleWindowedPluginGeometryUpdate(geometry);
 }
 
 void NetscapePlugin::platformPaint(GraphicsContext* context, const IntRect& dirtyRect, bool)
@@ -185,7 +185,7 @@
 return;
 }
 
-m_pluginController->willSendEventToPlugin();
+pluginController()->willSendEventToPlugin();
 
 LocalWindowsContext windowsContext(context, dirtyRect, m_isTransparent);
 
@@ -293,7 +293,7 @@
 if (m_isWindowed)
 return false;
 
-m_pluginController->willSendEventToPlugin();
+pluginController()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);
@@ -322,7 +322,7 @@
 if (m_isWindowed)
 return false;
 
-m_pluginController->willSendEventToPlugin();
+pluginController()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);
@@ -336,7 +336,7 @@
 if (m_isWindowed)
 return false;
 
-m_pluginController->willSendEventToPlugin();
+pluginController()->willSendEventToPlugin();
 
 NPEvent npEvent = toNP(event);
 NPP_HandleEvent(&npEvent);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90326] trunk/Source/WebKit2

2011-07-02 Thread andersca 
Title: [90326] trunk/Source/WebKit2








Revision 90326
Author ander...@apple.com
Date 2011-07-02 16:40:31 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Anders Carlsson  

Move the plug-in controller member variable up to the shared Plugin base class
https://bugs.webkit.org/show_bug.cgi?id=63867

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Remove m_pluginController.

(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::userAgent):
(WebKit::NetscapePlugin::loadURL):
(WebKit::NetscapePlugin::setStatusbarText):
(WebKit::NetscapePlugin::evaluate):
(WebKit::NetscapePlugin::isPrivateBrowsingEnabled):
(WebKit::NetscapePlugin::windowScriptNPObject):
(WebKit::NetscapePlugin::pluginElementNPObject):
(WebKit::NetscapePlugin::tryToShortCircuitInvoke):
(WebKit::NetscapePlugin::cancelStreamLoad):
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
(WebKit::NetscapePlugin::proxiesForURL):
(WebKit::NetscapePlugin::cookiesForURL):
(WebKit::NetscapePlugin::setCookiesForURL):
(WebKit::NetscapePlugin::getAuthenticationInfo):
Use controller() instead of m_pluginController.

(WebKit::NetscapePlugin::initialize):
This doesn't take a PluginController parameter anymore.

(WebKit::NetscapePlugin::destroy):
No need to null out the plug-in controller.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Remove m_pluginController member variable.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::compositingRenderServerPort):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
Use controller() instead of m_pluginController.

* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Plugin):
Initialize m_pluginController.

(WebKit::Plugin::initialize):
New function that initializes the plug-in controller and then calls the real
virtual initialize member function.

* WebProcess/Plugins/Plugin.h:
Add m_pluginController member variable and a new initialize virtual member function that doesn't take a
PluginController parameter. Make the "old" initialize member function set up the plug-in controller.

(WebKit::Plugin::controller):
This is now a simple getter.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::PluginProxy):
Remove m_pluginController.

(WebKit::PluginProxy::pluginProcessCrashed):
Use controller(), remove a bogus null check.

(WebKit::PluginProxy::initialize):
This doesn't take a PluginController parameter now.

(WebKit::PluginProxy::destroy):
No need to null out the plug-in controller member variable.

(WebKit::PluginProxy::loadURL):
(WebKit::PluginProxy::proxiesForURL):
(WebKit::PluginProxy::cookiesForURL):
(WebKit::PluginProxy::setCookiesForURL):
(WebKit::PluginProxy::getAuthenticationInfo):
(WebKit::PluginProxy::windowNPObjectID):
(WebKit::PluginProxy::getPluginElementNPObject):
(WebKit::PluginProxy::evaluate):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):
(WebKit::PluginProxy::setComplexTextInputEnabled):
(WebKit::PluginProxy::update):
Use controller() instead of m_pluginController.

* WebProcess/Plugins/PluginProxy.h:
Remove m_pluginController.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (90325 => 90326)

--- trunk/Source/WebKit2/ChangeLog	2011-07-02 23:20:11 UTC (rev 90325)
+++ trunk/Source/WebKit2/ChangeLog	2011-07-02 23:40:31 UTC (rev 90326)
@@ -1,3 +1,92 @@
+2011-07-02  Anders Carlsson  
+
+Move the plug-in controller member variable up to the shared Plugin base class
+https://bugs.webkit.org/show_bug.cgi?id=63867
+
+Reviewed by Sam Weinig.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::NetscapePlugin):
+Remove m_pluginController.
+
+(WebKit::NetscapePlugin::invalidate):
+(WebKit::NetscapePlugin::userAgent):
+(WebKit::NetscapePlugin::loadURL):
+

[webkit-changes] [90325] trunk/LayoutTests

2011-07-02 Thread mihaip 
Title: [90325] trunk/LayoutTests








Revision 90325
Author mih...@chromium.org
Date 2011-07-02 16:20:11 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  

Remove Chromium Leopard failing expectations for two tests (fast/dom/
HTMLMeterElement/meter-writing-mode.html and fast/images/
imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90324 => 90325)

--- trunk/LayoutTests/ChangeLog	2011-07-02 23:08:23 UTC (rev 90324)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 23:20:11 UTC (rev 90325)
@@ -1,5 +1,13 @@
 2011-07-02  Mihai Parparita  
 
+Remove Chromium Leopard failing expectations for two tests (fast/dom/
+HTMLMeterElement/meter-writing-mode.html and fast/images/
+imagemap-focus-ring-zoom.html) sice they pass now. Fix bug links.
+
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  
+
 Meant to actually remove expectations in r90322, not just comment them
 out.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90324 => 90325)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 23:08:23 UTC (rev 90324)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 23:20:11 UTC (rev 90325)
@@ -2552,15 +2552,14 @@
 // FIXME: Need to add tooling support for V8 bugs.
 BUGV8_953 : fast/regex/pcre-test-1.html = TIMEOUT
 
-BUGCR50282 MAC : fast/images/imagemap-case.html = IMAGE
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-zoom.html = IMAGE
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE
-BUGCR50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color.html = IMAGE+TEXT
-BUGCR50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color.html = IMAGE
+BUGWK50282 MAC : fast/images/imagemap-case.html = IMAGE
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE
+BUGWK50282 WIN LINUX : fast/images/imagemap-focus-ring-outline-color.html = IMAGE+TEXT
+BUGWK50282 LEOPARD : fast/images/imagemap-focus-ring-outline-color.html = IMAGE
 
 // Selection is wrong.
 BUGCR64938 : editing/selection/5354455-1.html = TEXT
@@ -3943,8 +3942,6 @@
 // Has been flaky/crashy for a while
 BUGCR86359 WIN : fast/dom/DeviceOrientation/add-listener-from-callback.html = CRASH PASS
 
-BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
-
 // Broken because Chromium disables compositing for RTL pages
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow-scrolled.html = TEXT
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90324] trunk/Source/JavaScriptCore

2011-07-02 Thread barraclough 
Title: [90324] trunk/Source/_javascript_Core








Revision 90324
Author barraclo...@apple.com
Date 2011-07-02 16:08:23 -0700 (Sat, 02 Jul 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=63866
DFG JIT - implement instanceof

Reviewed by Sam Weinig.

Add ops CheckHasInstance & InstanceOf to implement bytecodes
op_check_has_instance & op_instanceof. This is an initial
functional implementation, performance is a wash. We can
follow up with changes to fuse the InstanceOf node with
a subsequant branch, as we do with other comparisons.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (90323 => 90324)

--- trunk/Source/_javascript_Core/ChangeLog	2011-07-02 21:59:17 UTC (rev 90323)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-02 23:08:23 UTC (rev 90324)
@@ -1,3 +1,30 @@
+2011-07-02  Gavin Barraclough  
+
+https://bugs.webkit.org/show_bug.cgi?id=63866
+DFG JIT - implement instanceof
+
+Reviewed by Sam Weinig.
+
+Add ops CheckHasInstance & InstanceOf to implement bytecodes
+op_check_has_instance & op_instanceof. This is an initial
+functional implementation, performance is a wash. We can
+follow up with changes to fuse the InstanceOf node with
+a subsequant branch, as we do with other comparisons.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::jitAssertIsCell):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::jitAssertIsCell):
+* dfg/DFGNode.h:
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::compile):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2011-07-01  Oliver Hunt  
 
 IE Web Workers demo crashes in JSC::SlotVisitor::visitChildren()


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (90323 => 90324)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-07-02 21:59:17 UTC (rev 90323)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-07-02 23:08:23 UTC (rev 90324)
@@ -701,6 +701,18 @@
 NEXT_OPCODE(op_mov);
 }
 
+case op_check_has_instance:
+addToGraph(CheckHasInstance, get(currentInstruction[1].u.operand));
+NEXT_OPCODE(op_check_has_instance);
+
+case op_instanceof: {
+NodeIndex value = get(currentInstruction[2].u.operand);
+NodeIndex baseValue = get(currentInstruction[3].u.operand);
+NodeIndex prototype = get(currentInstruction[4].u.operand);
+set(currentInstruction[1].u.operand, addToGraph(InstanceOf, value, baseValue, prototype));
+NEXT_OPCODE(op_instanceof);
+}
+
 case op_not: {
 ARITHMETIC_OP();
 NodeIndex value = get(currentInstruction[2].u.operand);


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (90323 => 90324)

--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp	2011-07-02 21:59:17 UTC (rev 90323)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp	2011-07-02 23:08:23 UTC (rev 90324)
@@ -439,6 +439,13 @@
 breakpoint();
 checkJSNumber.link(this);
 }
+
+void JITCompiler::jitAssertIsCell(GPRReg gpr)
+{
+Jump checkCell = branchTestPtr(MacroAssembler::Zero, gpr, GPRInfo::tagMaskRegister);
+breakpoint();
+checkCell.link(this);
+}
 #endif
 
 #if ENABLE(SAMPLING_COUNTERS) && CPU(X86_64) // Or any other 64-bit platform!


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h (90323 => 90324)

--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h	2011-07-02 21:59:17 UTC (rev 90323)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h	2011-07-02 23:08:23 UTC (rev 90324)
@@ -216,11 +216,13 @@
 void jitAssertIsJSInt32(GPRReg);
 void jitAssertIsJSNumber(GPRReg);
 void jitAssertIsJSDouble(GPRReg);
+void jitAssertIsCell(GPRReg);
 #else
 void jitAssertIsInt32(GPRReg) {}
 void jitAssertIsJSInt32(GPRReg

[webkit-changes] [90323] trunk/LayoutTests

2011-07-02 Thread mihaip 
Title: [90323] trunk/LayoutTests








Revision 90323
Author mih...@chromium.org
Date 2011-07-02 14:59:17 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  

Meant to actually remove expectations in r90322, not just comment them
out.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90322 => 90323)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:57:46 UTC (rev 90322)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:59:17 UTC (rev 90323)
@@ -1,5 +1,12 @@
 2011-07-02  Mihai Parparita  
 
+Meant to actually remove expectations in r90322, not just comment them
+out.
+
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  
+
 Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
 since the regular Mac baselines can't be used due to single-pixel
 differences in character rendering (presumably caused by 32-bit vs.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90322 => 90323)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:57:46 UTC (rev 90322)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:59:17 UTC (rev 90323)
@@ -3945,16 +3945,6 @@
 
 BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
 
-// These tests are rebaselined using images on the bots but are still failing.
-// BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-br.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-p.html = IMAGE PASS
-// BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html = IMAGE PASS
-
 // Broken because Chromium disables compositing for RTL pages
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow-scrolled.html = TEXT
 BUGWK56591 GPU : compositing/rtl/rtl-absolute-overflow.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90322] trunk/LayoutTests

2011-07-02 Thread mihaip 
Title: [90322] trunk/LayoutTests








Revision 90322
Author mih...@chromium.org
Date 2011-07-02 14:57:46 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  

Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
since the regular Mac baselines can't be used due to single-pixel
differences in character rendering (presumably caused by 32-bit vs.
64-bit binaries).

* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png
trunk/LayoutTests/platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (90321 => 90322)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:12:27 UTC (rev 90321)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:57:46 UTC (rev 90322)
@@ -1,5 +1,22 @@
 2011-07-02  Mihai Parparita  
 
+Add Chromium Mac Snow Leopard baselines for editing/selection/vertical*
+since the regular Mac baselines can't be used due to single-pixel
+differences in character rendering (presumably caused by 32-bit vs.
+64-bit binaries).
+
+* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
+* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
+2011-07-02  Mihai Parparita  
+
 Chromium expectations update:
 - Add failing expectation for fast/css/last-of-type-pseudo-class.html,
   which fails in debug only.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90321 => 90322)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:12:27 UTC (rev 90321)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:57:46 UTC (rev 90322)
@@ -3946,14 +3946,14 @@
 BUGWK62858 LEOPARD : fast/dom/HTMLMeterElement/meter-writing-mode.html = IMAGE
 
 // These tests are rebaselined using images on the bots but are still failing.
-BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-lr-ltr-extend-line-forward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-br.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-p.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html = IMAGE PASS
-BUGRNIWA MAC : editing/selection/vertica

[webkit-changes] [90321] trunk/PerformanceTests/SunSpider

2011-07-02 Thread mjs 
Title: [90321] trunk/PerformanceTests/SunSpider








Revision 90321
Author m...@apple.com
Date 2011-07-02 14:12:27 -0700 (Sat, 02 Jul 2011)


Log Message
Not Reviewed. 

Fix obviou typo in previous commit.

* tests/sunspider-1.0/bitops-bitwise-and.js:

Modified Paths

trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js




Diff

Modified: trunk/PerformanceTests/SunSpider/ChangeLog (90320 => 90321)

--- trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 21:11:54 UTC (rev 90320)
+++ trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 21:12:27 UTC (rev 90321)
@@ -1,5 +1,13 @@
 2011-07-02  Maciej Stachowiak  
 
+Not Reviewed. 
+
+Fix obviou typo in previous commit.
+
+* tests/sunspider-1.0/bitops-bitwise-and.js:
+
+2011-07-02  Maciej Stachowiak  
+
 Reviewed by Anders Carlsson.
 
 SunSpider: all four bitops benchmarks can be replaced with NOP


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js (90320 => 90321)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js	2011-07-02 21:11:54 UTC (rev 90320)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js	2011-07-02 21:12:27 UTC (rev 90321)
@@ -27,4 +27,4 @@
 for (var i = 0; i < 60; i++)
 bitwiseAndValue = bitwiseAndValue & i;
 
-var result = butwiseAndValue;
+var result = bitwiseAndValue;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90320] trunk/LayoutTests

2011-07-02 Thread mihaip 
Title: [90320] trunk/LayoutTests








Revision 90320
Author mih...@chromium.org
Date 2011-07-02 14:11:54 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Mihai Parparita  

Chromium expectations update:
- Add failing expectation for fast/css/last-of-type-pseudo-class.html,
  which fails in debug only.
- Remove Chromium-specific baselines for fast/js/reserved-words.html,
  the test now passes with the regular baselines.

* platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
* platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/js/reserved-words-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/js/reserved-words-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (90319 => 90320)

--- trunk/LayoutTests/ChangeLog	2011-07-02 21:09:43 UTC (rev 90319)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 21:11:54 UTC (rev 90320)
@@ -1,3 +1,15 @@
+2011-07-02  Mihai Parparita  
+
+Chromium expectations update:
+- Add failing expectation for fast/css/last-of-type-pseudo-class.html,
+  which fails in debug only.
+- Remove Chromium-specific baselines for fast/js/reserved-words.html,
+  the test now passes with the regular baselines.
+
+* platform/chromium-mac/fast/js/reserved-words-expected.txt: Removed.
+* platform/chromium-win/fast/js/reserved-words-expected.txt: Removed.
+* platform/chromium/test_expectations.txt:
+
 2011-07-02  Kent Tamura  
 
 [GTK] Update expectation of fast/forms/input-file-re-render.html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90319 => 90320)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:09:43 UTC (rev 90319)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-07-02 21:11:54 UTC (rev 90320)
@@ -1279,7 +1279,7 @@
 
 BUGCR26253 SLOW WIN RELEASE : http/tests/navigation/reload-subframe-object.html = PASS
 BUGCR9798 WIN RELEASE : http/tests/navigation/no-referrer-reset.html = TIMEOUT PASS
-// Regressions from r67349? 
+// Regressions from r67349?
 BUGCR10364 MAC : http/tests/navigation/reload-subframe-object.html = FAIL
 
 // Text declared as "monospace" with no size is bigger in Chromium
@@ -2279,7 +2279,7 @@
 BUGCR53131 LINUX : fast/js/array-iterate-backwards.html = CRASH PASS
 
 // new or failing since WebKit rev. 65740:65800
-// This test causes the DRT to crash. 
+// This test causes the DRT to crash.
 BUGCR53073 DEBUG SKIP : storage/change-version.html = CRASH PASS
 BUGCR53073 LINUX : svg/custom/clip-path-units-changes.svg = TEXT PASS
 
@@ -2807,11 +2807,11 @@
 BUGWK53527 DEBUG : fast/frames/iframe-reparenting-new-page.html = CRASH PASS
 
 // It is failing since r77459.
-// Fix miscalculation of the overhang area used for painting. We were 
-// not correctly accounting for scrollbars resulting in an non-negative 
-// overhang even when we weren't over the edge. 
-// * platform/ScrollView.cpp: 
-//   (WebCore::ScrollView::calculateOverhangAreasForPainting): 
+// Fix miscalculation of the overhang area used for painting. We were
+// not correctly accounting for scrollbars resulting in an non-negative
+// overhang even when we weren't over the edge.
+// * platform/ScrollView.cpp:
+//   (WebCore::ScrollView::calculateOverhangAreasForPainting):
 BUGCR71783 : scrollbars/custom-scrollbar-with-incomplete-style.html = IMAGE
 
 //
@@ -3776,7 +3776,7 @@
 // Started crashing after seemingly unrelated r85786
 BUGCR83325 MAC DEBUG : canvas/philip/tests/2d.imageData.put.created.html = CRASH PASS
 
-// Appears to be a configuration error in the Mac 10.6 deps 
+// Appears to be a configuration error in the Mac 10.6 deps
 // Has been going on for at least a few weeks (as of 20/5/2011)
 BUGCR83426 MAC : fast/borders/svg-as-border-image-2.html = IMAGE PASS
 BUGCR83426 MAC : fast/borders/svg-as-border-image.html = IMAGE PASS
@@ -3981,12 +3981,6 @@
 // Strange scrollbar.
 BUGWK63115 : fast/css/font-face-in-shadow-DOM.html = PASS IMAGE+TEXT
 
-// The following two tests started to fail since V8 3.4.5.1 roll.
-// This needs rebaselining because "native" is no longer a reserved word.
-BUGCR87070 : fast/js/reserved-words.html = TEXT
-// Sounds like a real regression.
-BUGCR87070 WIN DEBUG : http/tests/security/_javascript_URL/xss-DENIED-to-_javascript_-url-in-foreign-domain-subframe.html = CRASH PASS
-
 BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT
 
 // We now follow the ES5 spec with regards to the semantics of the receiver
@@ -4017,3 +4011,5 @@
 
 // Quota enforcement not yet implemented for LevelDB back-end.
 BUGCR83652 : storage/indexeddb/database-quota.html = TEXT
+
+BUGCR88311 MAC DEBUG : fast/css/last-of-type-pseudo

[webkit-changes] [90319] trunk/PerformanceTests/SunSpider

2011-07-02 Thread mjs 
Title: [90319] trunk/PerformanceTests/SunSpider








Revision 90319
Author m...@apple.com
Date 2011-07-02 14:09:43 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Maciej Stachowiak  

Reviewed by Anders Carlsson.

SunSpider: all four bitops benchmarks can be replaced with NOP
https://bugs.webkit.org/show_bug.cgi?id=38446

* tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
(TimeFunc): Save the result.
* tests/sunspider-1.0/bitops-bits-in-byte.js:
(TimeFunc): Save the result.
* tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly
save the results.
* tests/sunspider-1.0/bitops-nsieve-bits.js:
(sieve): Save the result.

Modified Paths

trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-3bit-bits-in-byte.js
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bits-in-byte.js
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-nsieve-bits.js




Diff

Modified: trunk/PerformanceTests/SunSpider/ChangeLog (90318 => 90319)

--- trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 20:57:40 UTC (rev 90318)
+++ trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 21:09:43 UTC (rev 90319)
@@ -1,5 +1,21 @@
 2011-07-02  Maciej Stachowiak  
 
+Reviewed by Anders Carlsson.
+
+SunSpider: all four bitops benchmarks can be replaced with NOP
+https://bugs.webkit.org/show_bug.cgi?id=38446
+
+* tests/sunspider-1.0/bitops-3bit-bits-in-byte.js:
+(TimeFunc): Save the result.
+* tests/sunspider-1.0/bitops-bits-in-byte.js:
+(TimeFunc): Save the result.
+* tests/sunspider-1.0/bitops-bitwise-and.js: More explicitly
+save the results.
+* tests/sunspider-1.0/bitops-nsieve-bits.js:
+(sieve): Save the result.
+
+2011-07-02  Maciej Stachowiak  
+
 SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
 https://bugs.webkit.org/show_bug.cgi?id=60937
 


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-3bit-bits-in-byte.js (90318 => 90319)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-3bit-bits-in-byte.js	2011-07-02 20:57:40 UTC (rev 90318)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-3bit-bits-in-byte.js	2011-07-02 21:09:43 UTC (rev 90319)
@@ -1,5 +1,7 @@
 // Copyright (c) 2004 by Arthur Langereis (arthur_ext at domain xfinitegames, tld com
 
+var result = 0;
+
 // 1 op = 6 ANDs, 3 SHRs, 3 SHLs, 4 assigns, 2 ADDs
 // O(1)
 function fast3bitlookup(b) {
@@ -25,8 +27,10 @@
 
 function TimeFunc(func) {
 var x, y, t;
+var sum = 0;
 for(var x=0; x<500; x++)
-for(var y=0; y<256; y++) func(y);
+for(var y=0; y<256; y++) sum += func(y);
+return sum;
 }
 
-TimeFunc(fast3bitlookup);
+sum = TimeFunc(fast3bitlookup);


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bits-in-byte.js (90318 => 90319)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bits-in-byte.js	2011-07-02 20:57:40 UTC (rev 90318)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bits-in-byte.js	2011-07-02 21:09:43 UTC (rev 90319)
@@ -1,6 +1,8 @@
 // Copyright (c) 2004 by Arthur Langereis (arthur_ext at domain xfinitegames, tld com)
 
 
+var result = 0;
+
 // 1 op = 2 assigns, 16 compare/branches, 8 ANDs, (0-8) ADDs, 8 SHLs
 // O(n)
 function bitsinbyte(b) {
@@ -14,8 +16,10 @@
 
 function TimeFunc(func) {
 var x, y, t;
+var sum = 0;
 for(var x=0; x<350; x++)
-for(var y=0; y<256; y++) func(y);
+for(var y=0; y<256; y++) sum += func(y);
+return sum;
 }
 
-TimeFunc(bitsinbyte);
+result = TimeFunc(bitsinbyte);


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js (90318 => 90319)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js	2011-07-02 20:57:40 UTC (rev 90318)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-bitwise-and.js	2011-07-02 21:09:43 UTC (rev 90319)
@@ -26,3 +26,5 @@
 bitwiseAndValue = 4294967296;
 for (var i = 0; i < 60; i++)
 bitwiseAndValue = bitwiseAndValue & i;
+
+var result = butwiseAndValue;


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-nsieve-bits.js (90318 => 90319)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-nsieve-bits.js	2011-07-02 20:57:40 UTC (rev 90318)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/bitops-nsieve-bits.js	2011-07-02 21:09:43 UTC (rev 90319)
@@ -27,6 +27,7 @@
 var isPrime = new Array((1<>5);
 primes(isPrime, i);
 }
+return isPrime;
 }
 
-sieve();
+var result = sieve();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90318] trunk/PerformanceTests/SunSpider

2011-07-02 Thread mjs 
Title: [90318] trunk/PerformanceTests/SunSpider








Revision 90318
Author m...@apple.com
Date 2011-07-02 13:57:40 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Maciej Stachowiak  

SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
https://bugs.webkit.org/show_bug.cgi?id=60937

Reviewed by Dan Bernstein.

* tests/sunspider-1.0/string-validate-input.js:
(doTest): Rename the variable to username

Modified Paths

trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/string-validate-input.js




Diff

Modified: trunk/PerformanceTests/SunSpider/ChangeLog (90317 => 90318)

--- trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 20:45:55 UTC (rev 90317)
+++ trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 20:57:40 UTC (rev 90318)
@@ -1,5 +1,15 @@
 2011-07-02  Maciej Stachowiak  
 
+SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API
+https://bugs.webkit.org/show_bug.cgi?id=60937
+
+Reviewed by Dan Bernstein.
+
+* tests/sunspider-1.0/string-validate-input.js:
+(doTest): Rename the variable to username
+
+2011-07-02  Maciej Stachowiak  
+
 Reviewed by Darin Adler.
 
 SunSpider: The main function of math-cordic is dead code


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/string-validate-input.js (90317 => 90318)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/string-validate-input.js	2011-07-02 20:45:55 UTC (rev 90317)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/string-validate-input.js	2011-07-02 20:57:40 UTC (rev 90318)
@@ -11,8 +11,8 @@
// make up email address
for (var k=0;k<4000;k++)
{
-  name = makeName(6);
-  (k%2)?email=name+"@mac.com":email=name+"(at)mac.com";
+  username = makeName(6);
+  (k%2)?email=username+"@mac.com":email=username+"(at)mac.com";
 
   // validate the email address
   var pattern = /^[a-zA-Z0-9\-\._]+@[a-zA-Z0-9\-_]+(\.?[a-zA-Z0-9\-_]*)\.[a-zA-Z]{2,3}$/;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90317] trunk/PerformanceTests/SunSpider

2011-07-02 Thread mjs 
Title: [90317] trunk/PerformanceTests/SunSpider








Revision 90317
Author m...@apple.com
Date 2011-07-02 13:45:55 -0700 (Sat, 02 Jul 2011)


Log Message
2011-07-02  Maciej Stachowiak  

Reviewed by Darin Adler.

SunSpider: The main function of math-cordic is dead code
https://bugs.webkit.org/show_bug.cgi?id=63863

Try to prevent math-cordic from being eliminated as dead code or
compiled down to a constant.

* tests/sunspider-1.0/math-cordic.js:
(cordicsincos):
(cordic):

Modified Paths

trunk/PerformanceTests/SunSpider/ChangeLog
trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/math-cordic.js




Diff

Modified: trunk/PerformanceTests/SunSpider/ChangeLog (90316 => 90317)

--- trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 17:26:21 UTC (rev 90316)
+++ trunk/PerformanceTests/SunSpider/ChangeLog	2011-07-02 20:45:55 UTC (rev 90317)
@@ -1,3 +1,17 @@
+2011-07-02  Maciej Stachowiak  
+
+Reviewed by Darin Adler.
+
+SunSpider: The main function of math-cordic is dead code
+https://bugs.webkit.org/show_bug.cgi?id=63863
+
+Try to prevent math-cordic from being eliminated as dead code or
+compiled down to a constant.
+
+* tests/sunspider-1.0/math-cordic.js:
+(cordicsincos):
+(cordic):
+
 2011-06-30  Maciej Stachowiak  
 
 Reviewed by Adam Barth.


Modified: trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/math-cordic.js (90316 => 90317)

--- trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/math-cordic.js	2011-07-02 17:26:21 UTC (rev 90316)
+++ trunk/PerformanceTests/SunSpider/tests/sunspider-1.0/math-cordic.js	2011-07-02 20:45:55 UTC (rev 90317)
@@ -49,8 +49,9 @@
   FIXED(0.027977) 
   ];
 
+var Target = 28.027;
 
-function cordicsincos() {
+function cordicsincos(Target) {
 var X;
 var Y;
 var TargetAngle;
@@ -60,7 +61,7 @@
 X = FIXED(AG_CONST); /* AG_CONST * cos(0) */
 Y = 0;   /* AG_CONST * sin(0) */
 
-TargetAngle = FIXED(28.027);
+TargetAngle = FIXED(Target);
 CurrAngle = 0;
 for (Step = 0; Step < 12; Step++) {
 var NewX;
@@ -76,15 +77,19 @@
 CurrAngle -= Angles[Step];
 }
 }
+
+return FLOAT(X) * FLOAT(Y);
 }
 
 / End CORDIC
 
+var total = 0;
+
 function cordic( runs ) {
   var start = new Date();
 
   for ( var i = 0 ; i < runs ; i++ ) {
-  cordicsincos();
+  total += cordicsincos(Target);
   }
 
   var end = new Date();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90316] trunk/WebKitLibraries

2011-07-02 Thread mrowe 
Title: [90316] trunk/WebKitLibraries








Revision 90316
Author mr...@apple.com
Date 2011-07-02 10:26:21 -0700 (Sat, 02 Jul 2011)


Log Message
Update the header file too.

* WebKitSystemInterface.h:

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/WebKitSystemInterface.h




Diff

Modified: trunk/WebKitLibraries/ChangeLog (90315 => 90316)

--- trunk/WebKitLibraries/ChangeLog	2011-07-02 16:25:39 UTC (rev 90315)
+++ trunk/WebKitLibraries/ChangeLog	2011-07-02 17:26:21 UTC (rev 90316)
@@ -1,5 +1,11 @@
 2011-07-02  Mark Rowe  
 
+Update the header file too.
+
+* WebKitSystemInterface.h:
+
+2011-07-02  Mark Rowe  
+
 Update WebKitSystemInterface binaries.
 
 * libWebKitSystemInterfaceLeopard.a:


Modified: trunk/WebKitLibraries/WebKitSystemInterface.h (90315 => 90316)

--- trunk/WebKitLibraries/WebKitSystemInterface.h	2011-07-02 16:25:39 UTC (rev 90315)
+++ trunk/WebKitLibraries/WebKitSystemInterface.h	2011-07-02 17:26:21 UTC (rev 90316)
@@ -8,9 +8,9 @@
 #import 
 #import 
 
+@class AVAsset;
 @class QTMovie;
 @class QTMovieView;
-@class AVAsset;
 
 #ifdef __cplusplus
 extern "C" {
@@ -389,6 +389,7 @@
 void WKSetCFURLResponseMIMEType(CFURLResponseRef, CFStringRef mimeType);
 
 #if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+
 typedef enum {
 WKSandboxExtensionTypeReadOnly,
 WKSandboxExtensionTypeWriteOnly,
@@ -439,6 +440,7 @@
 void WKSetPainterForPainterController(WKScrollbarPainterControllerRef, WKScrollbarPainterRef, bool isHorizontal);
 WKScrollbarPainterRef WKVerticalScrollbarPainterForController(WKScrollbarPainterControllerRef);
 WKScrollbarPainterRef WKHorizontalScrollbarPainterForController(WKScrollbarPainterControllerRef);
+int WKScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef);
 void WKSetScrollbarPainterControllerStyle(WKScrollbarPainterControllerRef, int newStyle);
 void WKContentAreaScrolled(WKScrollbarPainterControllerRef);
 void WKContentAreaWillPaint(WKScrollbarPainterControllerRef);
@@ -461,7 +463,12 @@
 void WKShowWordDefinitionWindow(NSAttributedString *term, NSPoint screenPoint, NSDictionary *options);
 void WKHideWordDefinitionWindow(void);
 
+CFStringRef WKCopyDefaultSearchProviderDisplayName(void);
+
 NSURL* WKAVAssetResolvedURL(AVAsset*);
+
+NSCursor *WKCursor(const char *name);
+
 #endif
 
 #ifdef __cplusplus






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90315] trunk/WebKitLibraries

2011-07-02 Thread mrowe 
Title: [90315] trunk/WebKitLibraries








Revision 90315
Author mr...@apple.com
Date 2011-07-02 09:25:39 -0700 (Sat, 02 Jul 2011)


Log Message
Update WebKitSystemInterface binaries.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a: Added.
* libWebKitSystemInterfaceSnowLeopard.a:

Modified Paths

trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a
trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a


Added Paths

trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a




Diff

Modified: trunk/WebKitLibraries/ChangeLog (90314 => 90315)

--- trunk/WebKitLibraries/ChangeLog	2011-07-02 10:46:31 UTC (rev 90314)
+++ trunk/WebKitLibraries/ChangeLog	2011-07-02 16:25:39 UTC (rev 90315)
@@ -1,3 +1,11 @@
+2011-07-02  Mark Rowe  
+
+Update WebKitSystemInterface binaries.
+
+* libWebKitSystemInterfaceLeopard.a:
+* libWebKitSystemInterfaceLion.a: Added.
+* libWebKitSystemInterfaceSnowLeopard.a:
+
 2011-06-28  Brent Fulgham  
 
 Unreviewed build correction.  Link to correct library for


Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a

(Binary files differ)


Added: trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a

(Binary files differ)

Property changes on: trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a
___

Added: svn:mime-type

Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [90314] trunk/LayoutTests

2011-07-02 Thread tkent 
Title: [90314] trunk/LayoutTests








Revision 90314
Author tk...@chromium.org
Date 2011-07-02 03:46:31 -0700 (Sat, 02 Jul 2011)


Log Message
[GTK] Update expectation of fast/forms/input-file-re-render.html
https://bugs.webkit.org/show_bug.cgi?id=49245

* platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
* platform/gtk/fast/forms/input-file-re-render-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt


Removed Paths

trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (90313 => 90314)

--- trunk/LayoutTests/ChangeLog	2011-07-02 06:00:50 UTC (rev 90313)
+++ trunk/LayoutTests/ChangeLog	2011-07-02 10:46:31 UTC (rev 90314)
@@ -1,3 +1,11 @@
+2011-07-02  Kent Tamura  
+
+[GTK] Update expectation of fast/forms/input-file-re-render.html
+https://bugs.webkit.org/show_bug.cgi?id=49245
+
+* platform/gtk/fast/forms/input-file-re-render-expected.png: Remove a stale image.
+* platform/gtk/fast/forms/input-file-re-render-expected.txt:
+
 2011-07-01  Kent Tamura  
 
 [Chromium] Rebaseline for fast/forms/input-file-re-render.html


Deleted: trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt (90313 => 90314)

--- trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt	2011-07-02 06:00:50 UTC (rev 90313)
+++ trunk/LayoutTests/platform/gtk/fast/forms/input-file-re-render-expected.txt	2011-07-02 10:46:31 UTC (rev 90314)
@@ -5,10 +5,10 @@
 RenderBody {BODY} at (8,8) size 784x67
   RenderBlock {FORM} at (0,0) size 784x32
 RenderFileUploadControl {INPUT} at (2,2) size 306x28 "2 files"
-  RenderButton {INPUT} at (0,0) size 103x28 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
-RenderBlock (anonymous) at (8,4) size 87x19
-  RenderText at (0,0) size 87x19
-text run at (0,0) width 87: "Choose File"
+  RenderButton {INPUT} at (0,0) size 111x28 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
+RenderBlock (anonymous) at (8,4) size 95x19
+  RenderText at (0,0) size 95x19
+text run at (0,0) width 95: "Choose Files"
 RenderText {#text} at (0,0) size 0x0
   RenderBlock {P} at (0,48) size 784x19
 RenderText {#text} at (0,0) size 442x19






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes