[webkit-changes] [90542] trunk/Tools
Title: [90542] trunk/Tools
Revision 90542
Author aba...@webkit.org
Date 2011-07-06 23:19:21 -0700 (Wed, 06 Jul 2011)
Log Message
2011-07-06 Adam Barth aba...@webkit.org
Wean rebaseline-server off unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=64063
Reviewed by Eric Seidel.
In the process of changing this code to use full_results.json, I
noticed that the code was broken (because it wasn't tested). This
patch also adds test coverage for the broken code.
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py
trunk/Tools/Scripts/webkitpy/tool/servers/rebaselineserver.py
trunk/Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90541 => 90542)
--- trunk/Tools/ChangeLog 2011-07-07 05:36:13 UTC (rev 90541)
+++ trunk/Tools/ChangeLog 2011-07-07 06:19:21 UTC (rev 90542)
@@ -1,5 +1,20 @@
2011-07-06 Adam Barth aba...@webkit.org
+Wean rebaseline-server off unexpected_results.json
+https://bugs.webkit.org/show_bug.cgi?id=64063
+
+Reviewed by Eric Seidel.
+
+In the process of changing this code to use full_results.json, I
+noticed that the code was broken (because it wasn't tested). This
+patch also adds test coverage for the broken code.
+
+* Scripts/webkitpy/tool/commands/rebaselineserver.py:
+* Scripts/webkitpy/tool/servers/rebaselineserver.py:
+* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
+
+2011-07-06 Adam Barth aba...@webkit.org
+
Wean resultsjsonparser off unexpected_results.json
https://bugs.webkit.org/show_bug.cgi?id=64061
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py (90541 => 90542)
--- trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py 2011-07-07 05:36:13 UTC (rev 90541)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py 2011-07-07 06:19:21 UTC (rev 90542)
@@ -34,11 +34,11 @@
import os.path
from webkitpy.common import system
-from webkitpy.common.net import resultsjsonparser
+from webkitpy.common.net.resultsjsonparser import for_each_test, JSONTestResult
from webkitpy.layout_tests.layout_package import json_results_generator
from webkitpy.layout_tests.port import factory
from webkitpy.tool.commands.abstractlocalservercommand import AbstractLocalServerCommand
-from webkitpy.tool.servers.rebaselineserver import RebaselineHTTPServer, STATE_NEEDS_REBASELINE
+from webkitpy.tool.servers.rebaselineserver import get_test_baselines, RebaselineHTTPServer, STATE_NEEDS_REBASELINE
class TestConfig(object):
@@ -58,36 +58,42 @@
server = RebaselineHTTPServer
+def _gather_baselines(self, results_json):
+# Rebaseline server and it's associated _javascript_ expected the tests subtree to
+# be key-value pairs instead of hierarchical.
+# FIXME: make the rebaseline server use the hierarchical tree.
+new_tests_subtree = {}
+
+def gather_baselines_for_test(test_name, result_dict):
+result = JSONTestResult(test_name, result_dict)
+if result.did_pass_or_run_as_expected():
+return
+result_dict['state'] = STATE_NEEDS_REBASELINE
+result_dict['baselines'] = get_test_baselines(test_name, self._test_config)
+new_tests_subtree[test_name] = result_dict
+
+for_each_test(results_json['tests'], gather_baselines_for_test)
+results_json['tests'] = new_tests_subtree
+
def _prepare_config(self, options, args, tool):
results_directory = args[0]
filesystem = system.filesystem.FileSystem()
scm = self._tool.scm()
print 'Parsing unexpected_results.json...'
-results_json_path = filesystem.join(results_directory, 'unexpected_results.json')
+results_json_path = filesystem.join(results_directory, 'full_results.json')
results_json = json_results_generator.load_json(filesystem, results_json_path)
port = factory.get()
layout_tests_directory = port.layout_tests_dir()
platforms = filesystem.listdir(filesystem.join(layout_tests_directory, 'platform'))
-test_config = TestConfig(port, layout_tests_directory, results_directory, platforms, filesystem, scm)
+self._test_config = TestConfig(port, layout_tests_directory, results_directory, platforms, filesystem, scm)
print 'Gathering current baselines...'
-# Rebaseline server and it's associated _javascript_ expected the tests subtree to
-# be key-value pairs instead of hierarchical.
-# FIXME: make the rebaseline server use the hierarchical tree.
-new_tests_subtree = {}
[webkit-changes] [90544] trunk/Source/WebCore
Title: [90544] trunk/Source/WebCore
Revision 90544
Author commit-qu...@webkit.org
Date 2011-07-07 00:07:59 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Oleg Romashin rom...@gmail.com
Fix InspectorInstrumentation compilation.
https://bugs.webkit.org/show_bug.cgi?id=64033
Reviewed by Yury Semikhatsky.
No new tests. just compile fix.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90543 => 90544)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 06:56:45 UTC (rev 90543)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 07:07:59 UTC (rev 90544)
@@ -1,3 +1,15 @@
+2011-07-07 Oleg Romashin rom...@gmail.com
+
+Fix InspectorInstrumentation compilation.
+https://bugs.webkit.org/show_bug.cgi?id=64033
+
+Reviewed by Yury Semikhatsky.
+
+No new tests. just compile fix.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl):
+
2011-07-06 Mihnea Ovidenie mih...@adobe.com
Reviewed by David Hyatt.
Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (90543 => 90544)
--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2011-07-07 06:56:45 UTC (rev 90543)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp 2011-07-07 07:07:59 UTC (rev 90544)
@@ -162,8 +162,10 @@
{
if (InspectorDOMAgent* domAgent = instrumentingAgents-inspectorDOMAgent())
domAgent-didInvalidateStyleAttr(node);
+#if ENABLE(_javascript__DEBUGGER)
if (InspectorDOMDebuggerAgent* domDebuggerAgent = instrumentingAgents-inspectorDOMDebuggerAgent())
domDebuggerAgent-didInvalidateStyleAttr(node);
+#endif
}
void InspectorInstrumentation::frameWindowDiscardedImpl(InstrumentingAgents* instrumentingAgents, DOMWindow* window)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90547] trunk/Tools
Title: [90547] trunk/Tools Revision 90547 Author e...@webkit.org Date 2011-07-07 00:26:52 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Eric Seidel e...@webkit.org Unreviewed. Add more debug logging about which test expectations we're using. * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/layout_tests/port/webkit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py Diff Modified: trunk/Tools/ChangeLog (90546 => 90547) --- trunk/Tools/ChangeLog 2011-07-07 07:25:18 UTC (rev 90546) +++ trunk/Tools/ChangeLog 2011-07-07 07:26:52 UTC (rev 90547) @@ -1,3 +1,10 @@ +2011-07-07 Eric Seidel e...@webkit.org + +Unreviewed. Add more debug logging about which test expectations we're using. + +* Scripts/webkitpy/layout_tests/models/test_expectations.py: +* Scripts/webkitpy/layout_tests/port/webkit.py: + 2011-07-06 Adam Barth aba...@webkit.org Remove unexpected_results.json Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (90546 => 90547) --- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-07-07 07:25:18 UTC (rev 90546) +++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-07-07 07:26:52 UTC (rev 90547) @@ -531,16 +531,14 @@ 'or a non-numeric bug identifier.', test_list_path) if not has_bug and not has_wontfix: -self._log_non_fatal_error(lineno, 'Test lacks BUG modifier.', - test_list_path) +self._log_non_fatal_error(lineno, 'Test lacks BUG modifier.', test_list_path) if self._is_lint_mode and 'rebaseline' in options: self._add_error(lineno, 'REBASELINE should only be used for running rebaseline.py. ' 'Cannot be checked in.', test_list_path) -def _check_options_against_expectations(self, options, expectations, -lineno, test_list_path): +def _check_options_against_expectations(self, options, expectations, lineno, test_list_path): if 'slow' in options and TIMEOUT in expectations: self._add_error(lineno, 'A test can not be both SLOW and TIMEOUT. If it times out ' @@ -548,15 +546,14 @@ def _check_path_does_not_exist(self, lineno, test_list_path): # WebKit's way of skipping tests is to add a -disabled suffix. -# So we should consider the path existing if the path or the +# So we should consider the path existing if the path or the # -disabled version exists. if (not self._port.test_exists(test_list_path) and not self._port.test_exists(test_list_path + '-disabled')): # Log a non fatal error here since you hit this case any # time you update test_expectations.txt without syncing # the LayoutTests directory -self._log_non_fatal_error(lineno, 'Path does not exist.', - test_list_path) +self._log_non_fatal_error(lineno, 'Path does not exist.', test_list_path) return True return False Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (90546 => 90547) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-07-07 07:25:18 UTC (rev 90546) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-07-07 07:26:52 UTC (rev 90547) @@ -302,6 +302,7 @@ if not self._filesystem.exists(filename): _log.warn(Failed to open Skipped file: %s % filename) continue +_log.debug(Using Skipped file: %s % filename) skipped_file_contents = self._filesystem.read_text_file(filename) tests_to_skip.extend(self._tests_from_skipped_file_contents(skipped_file_contents)) return tests_to_skip @@ -311,6 +312,7 @@ expectations = self._skipped_list_as_expectations() expectations_path = self.path_to_test_expectations_file() if self._filesystem.exists(expectations_path): +_log.debug(Using test_expectations.txt: %s % expectations_path) expectations = self._filesystem.read_text_file(expectations_path) + expectations return expectations ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90548] trunk/Tools
Title: [90548] trunk/Tools Revision 90548 Author e...@webkit.org Date 2011-07-07 00:44:42 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Eric Seidel e...@webkit.org Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=64056 Unreviewed. I had written this unittest prior to landing my change, but had named it qt_unitest.py, so it wasn't running (nor was it added to my git repo). Once I fixe the name of the unittest file, it was very easy to fix the error in webkit.py (which already had a FIXME). * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added. * Scripts/webkitpy/layout_tests/port/webkit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py Added Paths trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py Diff Modified: trunk/Tools/ChangeLog (90547 => 90548) --- trunk/Tools/ChangeLog 2011-07-07 07:26:52 UTC (rev 90547) +++ trunk/Tools/ChangeLog 2011-07-07 07:44:42 UTC (rev 90548) @@ -1,5 +1,22 @@ 2011-07-07 Eric Seidel e...@webkit.org +Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests +https://bugs.webkit.org/show_bug.cgi?id=64056 + +Unreviewed. + +I had written this unittest prior to landing my change, but +had named it qt_unitest.py, so it wasn't running (nor was +it added to my git repo). + +Once I fixe the name of the unittest file, it was very easy +to fix the error in webkit.py (which already had a FIXME). + +* Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added. +* Scripts/webkitpy/layout_tests/port/webkit.py: + +2011-07-07 Eric Seidel e...@webkit.org + Unreviewed. Add more debug logging about which test expectations we're using. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py (0 => 90548) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py (rev 0) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt_unittest.py 2011-07-07 07:44:42 UTC (rev 90548) @@ -0,0 +1,58 @@ +# Copyright (C) 2010 Google Inc. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions are +# met: +# +#* Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +#* Redistributions in binary form must reproduce the above +# copyright notice, this list of conditions and the following disclaimer +# in the documentation and/or other materials provided with the +# distribution. +#* Neither the name of Google Inc. nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +import unittest + +from webkitpy.common.system.filesystem_mock import MockFileSystem +from webkitpy.layout_tests.port.qt import QtPort +from webkitpy.tool.mocktool import MockOptions, MockUser, MockExecutive + + +class QtPortTest(unittest.TestCase): +def _assert_search_path(self, search_paths, sys_platform, use_webkit2=False): +# FIXME: Port constructors should not parse the port name, but +# rather be passed components (directly or via setters). Once +# we fix that, this method will need a re-write. +port = QtPort(sys_platform=sys_platform, +options=MockOptions(webkit_test_runner=use_webkit2), +filesystem=MockFileSystem(), +user=MockUser(), +executive=MockExecutive()) +absolute_search_paths = map(port._webkit_baseline_path, search_paths) +self.assertEquals(port.baseline_search_path(), absolute_search_paths) + +def test_baseline_search_path(self): +self._assert_search_path(['qt-mac', 'qt'], 'darwin') +self._assert_search_path(['qt-win', 'qt'], 'win32') +
[webkit-changes] [90550] trunk/Source/WebKit2
Title: [90550] trunk/Source/WebKit2 Revision 90550 Author commit-qu...@webkit.org Date 2011-07-07 02:06:37 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Benjamin Poulain benja...@webkit.org [Qt] [WK2] Improve the handling of touch events to use them as main input https://bugs.webkit.org/show_bug.cgi?id=63991 Reviewed by Kenneth Rohde Christiansen. Promote touch event for use as primary input. The touch events now use the responsiveness timer like the other input events. The touch events also have a callback to the UI signaling if the event was used or not: PageClient::doneWithTouchEvent(). This is similar to what is done with key events (PageClient::doneWithKeyEvent()). * Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::nativeEvent): * Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::NativeWebTouchEvent): * Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent): * Shared/qt/WebEventFactoryQt.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): (WebKit::WebPageProxy::didReceiveEvent): * UIProcess/WebPageProxy.h: * UIProcess/qt/qdesktopwebpageproxy.cpp: (QDesktopWebPageProxy::doneWithTouchEvent): * UIProcess/qt/qdesktopwebpageproxy.h: * UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::doneWithTouchEvent): (QTouchWebPageProxy::touchEvent): * UIProcess/qt/qtouchwebpageproxy.h: * WebKit2.pro: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.h trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.h trunk/Source/WebKit2/WebKit2.pro Added Paths trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h trunk/Source/WebKit2/Shared/qt/NativeWebTouchEventQt.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (90549 => 90550) --- trunk/Source/WebKit2/ChangeLog 2011-07-07 08:03:58 UTC (rev 90549) +++ trunk/Source/WebKit2/ChangeLog 2011-07-07 09:06:37 UTC (rev 90550) @@ -1,3 +1,40 @@ +2011-07-07 Benjamin Poulain benja...@webkit.org + +[Qt] [WK2] Improve the handling of touch events to use them as main input +https://bugs.webkit.org/show_bug.cgi?id=63991 + +Reviewed by Kenneth Rohde Christiansen. + +Promote touch event for use as primary input. + +The touch events now use the responsiveness timer like the other input events. + +The touch events also have a callback to the UI signaling if the event was used +or not: PageClient::doneWithTouchEvent(). +This is similar to what is done with key events (PageClient::doneWithKeyEvent()). + +* Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. +(WebKit::NativeWebTouchEvent::nativeEvent): +* Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. +(WebKit::NativeWebTouchEvent::NativeWebTouchEvent): +* Shared/qt/WebEventFactoryQt.cpp: +(WebKit::webEventTypeForEvent): +(WebKit::WebEventFactory::createWebTouchEvent): +* Shared/qt/WebEventFactoryQt.h: +* UIProcess/PageClient.h: +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::handleTouchEvent): +(WebKit::WebPageProxy::didReceiveEvent): +* UIProcess/WebPageProxy.h: +* UIProcess/qt/qdesktopwebpageproxy.cpp: +(QDesktopWebPageProxy::doneWithTouchEvent): +* UIProcess/qt/qdesktopwebpageproxy.h: +* UIProcess/qt/qtouchwebpageproxy.cpp: +(QTouchWebPageProxy::doneWithTouchEvent): +(QTouchWebPageProxy::touchEvent): +* UIProcess/qt/qtouchwebpageproxy.h: +* WebKit2.pro: + 2011-07-06 Andreas Kling kl...@webkit.org [Qt][WK2] Split Qt API into two different web views (touch and desktop) Copied: trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h (from rev 90549, trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.h) (0 => 90550) --- trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h (rev 0) +++ trunk/Source/WebKit2/Shared/NativeWebTouchEvent.h 2011-07-07 09:06:37 UTC (rev 90550) @@ -0,0 +1,55 @@ +/* + * Copyright (C) 2011 Benjamin Poulain benja...@webkit.org + * + * Redistribution and use in source and
[webkit-changes] [90551] trunk/Tools
Title: [90551] trunk/Tools
Revision 90551
Author carlo...@webkit.org
Date 2011-07-07 03:29:19 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Carlos Garcia Campos cgar...@igalia.com
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=63988
Reviewed by Martin Robinson.
* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed):
(decidePolicyForNavigationAction): Ignore the action if a link is
clicked with the middle buttonm and open the link in a new window.
(browserWindowPolicyClientInit):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c
Diff
Modified: trunk/Tools/ChangeLog (90550 => 90551)
--- trunk/Tools/ChangeLog 2011-07-07 09:06:37 UTC (rev 90550)
+++ trunk/Tools/ChangeLog 2011-07-07 10:29:19 UTC (rev 90551)
@@ -1,3 +1,16 @@
+2011-07-07 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
+https://bugs.webkit.org/show_bug.cgi?id=63988
+
+Reviewed by Martin Robinson.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowConstructed):
+(decidePolicyForNavigationAction): Ignore the action if a link is
+clicked with the middle buttonm and open the link in a new window.
+(browserWindowPolicyClientInit):
+
2011-07-07 Adam Barth aba...@webkit.org
Remove style_references.py
Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (90550 => 90551)
--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2011-07-07 09:06:37 UTC (rev 90550)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c 2011-07-07 10:29:19 UTC (rev 90551)
@@ -56,6 +56,7 @@
static void browserWindowLoaderClientInit(BrowserWindow*);
static void browserWindowUIClientInit(BrowserWindow*);
+static void browserWindowPolicyClientInit(BrowserWindow*);
static gint windowCount = 0;
@@ -183,6 +184,7 @@
browserWindowLoaderClientInit(window);
browserWindowUIClientInit(window);
+browserWindowPolicyClientInit(window);
}
static void browser_window_class_init(BrowserWindowClass* klass)
@@ -654,6 +656,37 @@
WKPageSetPageUIClient(WKViewGetPage(window-webView), uiClient);
}
+static void decidePolicyForNavigationAction(WKPageRef page, WKFrameRef frame, WKFrameNavigationType navigationType, WKEventModifiers modifiers, WKEventMouseButton mouseButton, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
+{
+if (navigationType != kWKFrameNavigationTypeLinkClicked || mouseButton != kWKEventMouseButtonMiddleButton) {
+WKFramePolicyListenerUse(listener);
+return;
+}
+
+WKViewRef webView = WKViewCreate(WKPageGetContext(page), 0);
+GtkWidget *window = browser_window_new(webView);
+WKURLRef url = ""
+WKPageLoadURL(WKViewGetPage(webView), url);
+WKRelease(url);
+gtk_widget_grab_focus(GTK_WIDGET(webView));
+gtk_widget_show(window);
+
+WKFramePolicyListenerIgnore(listener);
+}
+
+static void browserWindowPolicyClientInit(BrowserWindow* window)
+{
+WKPagePolicyClient policyClient = {
+kWKPagePolicyClientCurrentVersion,
+window, /* clientInfo */
+decidePolicyForNavigationAction,
+0, /* decidePolicyForNewWindowAction */
+0, /* decidePolicyForResponse */
+0 /* unableToImplementPolicy */
+};
+WKPageSetPagePolicyClient(WKViewGetPage(window-webView), policyClient);
+}
+
// Public API.
GtkWidget* browser_window_new(WKViewRef view)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90553] trunk
Title: [90553] trunk Revision 90553 Author vse...@chromium.org Date 2011-07-07 03:47:03 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Vsevolod Vlasov vse...@chromium.org Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Added clear cache and cookies tests. Since no port currently supports this functionality, the tests are disabled. Reviewed by Pavel Feldman. * http/tests/inspector/network/network-clear-cache-expected.txt: Added. * http/tests/inspector/network/network-clear-cache.html-disabled: Added. * http/tests/inspector/network/network-clear-cookies-expected.txt: Added. * http/tests/inspector/network/network-clear-cookies.html-disabled: Added. * http/tests/inspector/network/resources/random-cached.php: Added. * http/tests/inspector/network/resources/set-cookie.php: Added. 2011-07-07 Vsevolod Vlasov vse...@chromium.org Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Reviewed by Pavel Feldman. * English.lproj/localizedStrings.js: * inspector/Inspector.json: * inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies): * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent): * inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies): * inspector/front-end/Settings.js: 2011-07-07 Vsevolod Vlasov vse...@chromium.org Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Reviewed by Pavel Feldman. * public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies): * src/InspectorClientImpl.h: * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies): * src/WebDevToolsAgentImpl.h: Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorClient.h trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorResourceAgent.cpp trunk/Source/WebCore/inspector/InspectorResourceAgent.h trunk/Source/WebCore/inspector/front-end/NetworkPanel.js trunk/Source/WebCore/inspector/front-end/Settings.js trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebDevToolsAgentClient.h trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorClientImpl.h trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h Added Paths trunk/LayoutTests/http/tests/inspector/network/network-clear-cache-expected.txt trunk/LayoutTests/http/tests/inspector/network/network-clear-cache.html-disabled trunk/LayoutTests/http/tests/inspector/network/network-clear-cookies-expected.txt trunk/LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled trunk/LayoutTests/http/tests/inspector/network/resources/random-cached.php trunk/LayoutTests/http/tests/inspector/network/resources/set-cookie.php Diff Modified: trunk/LayoutTests/ChangeLog (90552 => 90553) --- trunk/LayoutTests/ChangeLog 2011-07-07 10:37:41 UTC (rev 90552) +++ trunk/LayoutTests/ChangeLog 2011-07-07 10:47:03 UTC (rev 90553) @@ -1,3 +1,20 @@ +2011-07-07 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: Add support for clearing cache and cookies from network panel. +https://bugs.webkit.org/show_bug.cgi?id=63999 + +Added clear cache and cookies tests. Since no port currently supports +this functionality, the tests are disabled. + +Reviewed by Pavel Feldman. + +* http/tests/inspector/network/network-clear-cache-expected.txt: Added. +*
[webkit-changes] [90554] trunk/LayoutTests
Title: [90554] trunk/LayoutTests
Revision 90554
Author ph...@webkit.org
Date 2011-07-07 04:18:01 -0700 (Thu, 07 Jul 2011)
Log Message
Reviewed by Eric Carlson.
GTK: media/video-src-invalid-poster.html Failed
https://bugs.webkit.org/show_bug.cgi?id=61160
Wait for loadstart event to check the poster dimensions and avoid a
potential timeout of the test.
* media/video-src-invalid-poster-expected.txt:
* media/video-src-invalid-poster.html:
* platform/gtk/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-src-invalid-poster-expected.txt
trunk/LayoutTests/media/video-src-invalid-poster.html
trunk/LayoutTests/platform/gtk/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (90553 => 90554)
--- trunk/LayoutTests/ChangeLog 2011-07-07 10:47:03 UTC (rev 90553)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 11:18:01 UTC (rev 90554)
@@ -1,3 +1,17 @@
+2011-07-07 Philippe Normand pnorm...@igalia.com
+
+Reviewed by Eric Carlson.
+
+GTK: media/video-src-invalid-poster.html Failed
+https://bugs.webkit.org/show_bug.cgi?id=61160
+
+Wait for loadstart event to check the poster dimensions and avoid a
+potential timeout of the test.
+
+* media/video-src-invalid-poster-expected.txt:
+* media/video-src-invalid-poster.html:
+* platform/gtk/Skipped:
+
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Add support for clearing cache and cookies from network panel.
Modified: trunk/LayoutTests/media/video-src-invalid-poster-expected.txt (90553 => 90554)
--- trunk/LayoutTests/media/video-src-invalid-poster-expected.txt 2011-07-07 10:47:03 UTC (rev 90553)
+++ trunk/LayoutTests/media/video-src-invalid-poster-expected.txt 2011-07-07 11:18:01 UTC (rev 90554)
@@ -1,3 +1,5 @@
+RUN(video.load())
+EVENT(loadstart)
EXPECTED (video.clientWidth == '76') OK
EXPECTED (video.clientHeight == '103') OK
END OF TEST
Modified: trunk/LayoutTests/media/video-src-invalid-poster.html (90553 => 90554)
--- trunk/LayoutTests/media/video-src-invalid-poster.html 2011-07-07 10:47:03 UTC (rev 90553)
+++ trunk/LayoutTests/media/video-src-invalid-poster.html 2011-07-07 11:18:01 UTC (rev 90554)
@@ -21,6 +21,8 @@
endTest();
}
-listenForWidthAndHeight(76, 103, expected);
-failTestIn(1000);
+run(video.load());
+waitForEvent(loadstart, function () {
+listenForWidthAndHeight(76, 103, expected);
+});
/script
Modified: trunk/LayoutTests/platform/gtk/Skipped (90553 => 90554)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 10:47:03 UTC (rev 90553)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 11:18:01 UTC (rev 90554)
@@ -1518,9 +1518,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=61122
http/tests/navigation/post-307-response.html
-# https://bugs.webkit.org/show_bug.cgi?id=61160
-media/video-src-invalid-poster.html
-
# https://bugs.webkit.org/show_bug.cgi?id=61523
http/tests/eventsource/workers/eventsource-simple.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90555] trunk
Title: [90555] trunk
Revision 90555
Author vse...@chromium.org
Date 2011-07-07 04:33:41 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
https://bugs.webkit.org/show_bug.cgi?id=63936
Reviewed by Pavel Feldman.
* http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
* http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
* http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
* http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added.
(body):
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
https://bugs.webkit.org/show_bug.cgi?id=63936
Reviewed by Pavel Feldman.
Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.appendResource):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
Added Paths
trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt
trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
trunk/LayoutTests/http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html
trunk/LayoutTests/http/tests/inspector/resource-tree/resources/styles-non-unique-url.css
Diff
Modified: trunk/LayoutTests/ChangeLog (90554 => 90555)
--- trunk/LayoutTests/ChangeLog 2011-07-07 11:18:01 UTC (rev 90554)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 11:33:41 UTC (rev 90555)
@@ -1,3 +1,18 @@
+2011-07-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
+https://bugs.webkit.org/show_bug.cgi?id=63936
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added.
+* http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added.
+* http/tests/inspector/resource-tree/resource-tree-test.js:
+(initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree):
+* http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added.
+* http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added.
+(body):
+
2011-07-07 Philippe Normand pnorm...@igalia.com
Reviewed by Eric Carlson.
Added: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt (0 => 90555)
--- trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt 2011-07-07 11:33:41 UTC (rev 90555)
@@ -0,0 +1,18 @@
+Tests resources panel shows several resources with the same url if they were loaded with inspector already opened.
+
+
+Resources Tree:
+Frames
+(resource-tree-non-unique-url.html)
+(resource-tree-non-unique-url-iframe.html)
+Images
+styles-non-unique-url.css
+Stylesheets
+styles-non-unique-url.css
+resource-tree-non-unique-url-iframe.html
+Scripts
+inspector-test.js
+resource-tree-test.js
+resources-test.js
+resource-tree-non-unique-url.html
+
Property changes on: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url.html (0 => 90555)
--- trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-non-unique-url.html 2011-07-07 11:33:41 UTC (rev 90555)
@@ -0,0 +1,38 @@
+html
+head
+script src=""
+script src=""
+script src=""
+script
+function loadIframe()
+{
+var iframe = document.createElement(iframe);
+document.body.appendChild(iframe);
+iframe.src = ""
+}
+
+function test()
+{
+InspectorTest.addSniffer(WebInspector.ResourcesPanel.prototype, _resourceAdded, onResource, true);
+WebInspector.panels.resources.show();
[webkit-changes] [90557] trunk/LayoutTests
Title: [90557] trunk/LayoutTests
Revision 90557
Author vse...@chromium.org
Date 2011-07-07 06:12:26 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing.
https://bugs.webkit.org/show_bug.cgi?id=64078
Reviewed by Pavel Feldman.
* http/tests/inspector/network-test.js:
(initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep):
(initialize_NetworkTest.InspectorTest.resetInspectorResourcesData):
(resetInspectorResourcesData):
* http/tests/inspector/network/network-clear-cache-expected.txt:
* http/tests/inspector/network/network-clear-cache.html-disabled:
* http/tests/inspector/network/network-clear-cookies-expected.txt:
* http/tests/inspector/network/network-clear-cookies.html-disabled:
* http/tests/inspector/network/network-embed-expected.txt:
* http/tests/inspector/network/network-embed.html:
* http/tests/inspector/network/network-xhr-async-expected.txt:
* http/tests/inspector/network/network-xhr-async.html:
* http/tests/inspector/network/network-xhr-sync-expected.txt:
* http/tests/inspector/network/network-xhr-sync.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/network/network-clear-cache-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-clear-cache.html-disabled
trunk/LayoutTests/http/tests/inspector/network/network-clear-cookies-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled
trunk/LayoutTests/http/tests/inspector/network/network-embed-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-embed.html
trunk/LayoutTests/http/tests/inspector/network/network-xhr-async-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-xhr-async.html
trunk/LayoutTests/http/tests/inspector/network/network-xhr-sync-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-xhr-sync.html
trunk/LayoutTests/http/tests/inspector/network-test.js
Diff
Modified: trunk/LayoutTests/ChangeLog (90556 => 90557)
--- trunk/LayoutTests/ChangeLog 2011-07-07 12:06:29 UTC (rev 90556)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 13:12:26 UTC (rev 90557)
@@ -1,5 +1,27 @@
2011-07-07 Vsevolod Vlasov vse...@chromium.org
+Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing.
+https://bugs.webkit.org/show_bug.cgi?id=64078
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network-test.js:
+(initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep):
+(initialize_NetworkTest.InspectorTest.resetInspectorResourcesData):
+(resetInspectorResourcesData):
+* http/tests/inspector/network/network-clear-cache-expected.txt:
+* http/tests/inspector/network/network-clear-cache.html-disabled:
+* http/tests/inspector/network/network-clear-cookies-expected.txt:
+* http/tests/inspector/network/network-clear-cookies.html-disabled:
+* http/tests/inspector/network/network-embed-expected.txt:
+* http/tests/inspector/network/network-embed.html:
+* http/tests/inspector/network/network-xhr-async-expected.txt:
+* http/tests/inspector/network/network-xhr-async.html:
+* http/tests/inspector/network/network-xhr-sync-expected.txt:
+* http/tests/inspector/network/network-xhr-sync.html:
+
+2011-07-07 Vsevolod Vlasov vse...@chromium.org
+
Web Inspector: Resources panel shows only one resource when multiple resources have the same url.
https://bugs.webkit.org/show_bug.cgi?id=63936
Modified: trunk/LayoutTests/http/tests/inspector/network/network-clear-cache-expected.txt (90556 => 90557)
--- trunk/LayoutTests/http/tests/inspector/network/network-clear-cache-expected.txt 2011-07-07 12:06:29 UTC (rev 90556)
+++ trunk/LayoutTests/http/tests/inspector/network/network-clear-cache-expected.txt 2011-07-07 13:12:26 UTC (rev 90557)
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: line 21: First XHR loaded.
-CONSOLE MESSAGE: line 36: Done.
+CONSOLE MESSAGE: line 13: First XHR loaded.
+CONSOLE MESSAGE: line 28: Done.
Tests clearing browser cache from inspector.
http://127.0.0.1:8000/inspector/network/resources/random-cached.php
Modified: trunk/LayoutTests/http/tests/inspector/network/network-clear-cache.html-disabled (90556 => 90557)
--- trunk/LayoutTests/http/tests/inspector/network/network-clear-cache.html-disabled 2011-07-07 12:06:29 UTC (rev 90556)
+++ trunk/LayoutTests/http/tests/inspector/network/network-clear-cache.html-disabled 2011-07-07 13:12:26 UTC (rev 90557)
@@ -5,14 +5,6 @@
script
function loadData()
{
-if (!window.internals) {
-console.log(This test can not be run as window.internals is not available.);
-
[webkit-changes] [90558] trunk/Source/WebCore
Title: [90558] trunk/Source/WebCore
Revision 90558
Author loi...@chromium.org
Date 2011-07-07 06:44:55 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: Protocol: pointers to optional in parameters passing to the
backend methods should be NULL if they are not specified in the message.
https://bugs.webkit.org/show_bug.cgi?id=64083
Reviewed by Pavel Feldman.
* inspector/CodeGeneratorInspector.pm:
(generateBackendFunction):
(generateArgumentGetters):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getStylesForNode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm
trunk/Source/WebCore/inspector/InspectorCSSAgent.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90557 => 90558)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 13:12:26 UTC (rev 90557)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 13:44:55 UTC (rev 90558)
@@ -1,5 +1,19 @@
2011-07-07 Ilya Tikhonovsky loi...@chromium.org
+Web Inspector: Protocol: pointers to optional in parameters passing to the
+backend methods should be NULL if they are not specified in the message.
+https://bugs.webkit.org/show_bug.cgi?id=64083
+
+Reviewed by Pavel Feldman.
+
+* inspector/CodeGeneratorInspector.pm:
+(generateBackendFunction):
+(generateArgumentGetters):
+* inspector/InspectorCSSAgent.cpp:
+(WebCore::InspectorCSSAgent::getStylesForNode):
+
+2011-07-07 Ilya Tikhonovsky loi...@chromium.org
+
Web Inspector: Searching on the Network panel doesn't do anything?
https://bugs.webkit.org/show_bug.cgi?id=55489
Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm (90557 => 90558)
--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-07-07 13:12:26 UTC (rev 90557)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.pm 2011-07-07 13:44:55 UTC (rev 90558)
@@ -464,17 +464,22 @@
my $name = $parameter-name;
my $type = $parameter-type;
my $typeString = camelCase($parameter-type);
-my $optional = $parameter-extendedAttributes-{optional} ? true : false;
-push(@function, . typeTraits($type, variable) . in_$name = get$typeString(paramsContainerPtr, \$name\, $optional, protocolErrorsPtr););
+my $optionalFlagArgument = 0;
+if ($parameter-extendedAttributes-{optional}) {
+push(@function, bool ${name}_valueFound = false;);
+$optionalFlagArgument = ${name}_valueFound;
+}
+push(@function, . typeTraits($type, variable) . in_$name = get$typeString(paramsContainerPtr, \$name\, $optionalFlagArgument, protocolErrorsPtr););
}
push(@function, );
$indent = ;
}
-
my $args = join(, ,
(error,
- map(($_-extendedAttributes-{optional} ? : ) . in_ . $_-name, @inArgs),
+ map(($_-extendedAttributes-{optional} ?
+ $_-name . _valueFound ? in_ . $_-name . : 0 :
+ in_ . $_-name), @inArgs),
map(out_ . $_-name, @outArgs)));
push(@function, $indentif (!protocolErrors-length()));
@@ -580,26 +585,32 @@
my $return = typeTraits($type, return) ? typeTraits($type, return) : typeTraits($type, param);
my $typeString = camelCase($type);
-push(@backendConstantDeclarations, static $return get$typeString(InspectorObject* object, const String name, bool optional, InspectorArray* protocolErrors););
+push(@backendConstantDeclarations, static $return get$typeString(InspectorObject* object, const String name, bool* valueFound, InspectorArray* protocolErrors););
my $getterBody = EOF;
-$return InspectorBackendDispatcher::get$typeString(InspectorObject* object, const String name, bool optional, InspectorArray* protocolErrors)
+$return InspectorBackendDispatcher::get$typeString(InspectorObject* object, const String name, bool* valueFound, InspectorArray* protocolErrors)
{
ASSERT(object);
ASSERT(protocolErrors);
+if (valueFound)
+*valueFound = false;
+
$variable value = $defaultValue;
InspectorObject::const_iterator end = object-end();
InspectorObject::const_iterator valueIterator = object-find(name);
if (valueIterator == end) {
-if (!optional)
+if (!valueFound)
protocolErrors-pushString(String::format(Parameter '\%s' with type '$json' was not found., name.utf8().data()));
return value;
}
if (!valueIterator-second-as$json(value))
protocolErrors-pushString(String::format(Parameter '\%s' has wrong type. It should be '$json'., name.utf8().data()));
+else
+if (valueFound)
+
[webkit-changes] [90561] trunk/Source/WebCore
Title: [90561] trunk/Source/WebCore
Revision 90561
Author pfeld...@chromium.org
Date 2011-07-07 09:20:12 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Pavel Feldman pfeld...@chromium.org
Web Inspector: prevent default action during drag'n'drop in the Elements panel.
https://bugs.webkit.org/show_bug.cgi?id=64081
Reviewed by Yury Semikhatsky.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._ondragstart):
(WebInspector.ElementsTreeOutline.prototype._ondragover):
(WebInspector.ElementsTreeOutline.prototype._ondragend):
* inspector/front-end/treeoutline.js:
(TreeOutline.prototype.treeElementFromPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/treeoutline.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (90560 => 90561)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 14:18:01 UTC (rev 90560)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 16:20:12 UTC (rev 90561)
@@ -1,3 +1,18 @@
+2011-07-07 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: prevent default action during drag'n'drop in the Elements panel.
+https://bugs.webkit.org/show_bug.cgi?id=64081
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeOutline):
+(WebInspector.ElementsTreeOutline.prototype._ondragstart):
+(WebInspector.ElementsTreeOutline.prototype._ondragover):
+(WebInspector.ElementsTreeOutline.prototype._ondragend):
+* inspector/front-end/treeoutline.js:
+(TreeOutline.prototype.treeElementFromPoint):
+
2011-07-07 Nikolas Zimmermann nzimmerm...@rim.com
Move remaining enums out of SVG*Element classes
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (90560 => 90561)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2011-07-07 14:18:01 UTC (rev 90560)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2011-07-07 16:20:12 UTC (rev 90561)
@@ -36,6 +36,7 @@
this.element.addEventListener(dragstart, this._ondragstart.bind(this), false);
this.element.addEventListener(dragover, this._ondragover.bind(this), false);
this.element.addEventListener(dragleave, this._ondragleave.bind(this), false);
+this.element.addEventListener(drop, this._ondrop.bind(this), false);
this.element.addEventListener(dragend, this._ondragend.bind(this), false);
TreeOutline.call(this, this.element);
@@ -275,7 +276,7 @@
return false;
event.dataTransfer.setData(text/plain, treeElement.listItemElement.textContent);
-event.dataTransfer.effectAllowed = copy;
+event.dataTransfer.effectAllowed = copyMove;
this._nodeBeingDragged = treeElement.representedObject;
WebInspector.highlightDOMNode(0);
@@ -285,48 +286,33 @@
_ondragover: function(event)
{
-this._clearDragOverTreeElementMarker();
-
if (!this._nodeBeingDragged)
-return;
+return false;
var treeElement = this._treeElementFromEvent(event);
if (!this._isValidDragSourceOrTarget(treeElement))
-return;
+return false;
var node = treeElement.representedObject;
while (node) {
if (node === this._nodeBeingDragged)
-return;
+return false;
node = node.parentNode;
}
treeElement.updateSelection();
treeElement.listItemElement.addStyleClass(elements-drag-over);
this._dragOverTreeElement = treeElement;
+event.preventDefault();
+event.dataTransfer.dropEffect = 'move';
+return false;
},
_ondragleave: function(event)
{
this._clearDragOverTreeElementMarker();
-
-if (!this._nodeBeingDragged)
-return;
-
-var treeElement = this._treeElementFromEvent(event);
-if (!this._isValidDragSourceOrTarget(treeElement))
-return false;
-
-var node = treeElement.representedObject;
-while (node) {
-if (node === this._nodeBeingDragged)
-return;
-node = node.parentNode;
-}
-
-treeElement.updateSelection();
-treeElement.listItemElement.addStyleClass(elements-drag-over);
-this._dragOverTreeElement = treeElement;
+event.preventDefault();
+return false;
},
_isValidDragSourceOrTarget: function(treeElement)
@@ -347,17 +333,19 @@
return true;
},
-_ondragend: function(event)
+_ondrop: function(event)
{
-if (this._nodeBeingDragged this._dragOverTreeElement) {
+event.preventDefault();
+var treeElement =
[webkit-changes] [90562] trunk/Tools
Title: [90562] trunk/Tools
Revision 90562
Author aro...@apple.com
Date 2011-07-07 09:35:33 -0700 (Thu, 07 Jul 2011)
Log Message
Extract commit-log-editor's commit-message-generation code into a separate function
As a bonus, we now skip a bunch of work in the case where we are generating a commit message
for staged git changes.
Prep work for fixing http://webkit.org/b/26755 webkit-patch's commit messages are less
readable than commit-log-editor's
Reviewed by David Kilzer.
* Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
file so that it will be defined even if we aren't operating on an existing log message.
Moved a bunch of top-level code to generate the commit message from here...
(createCommitMessage): ...to here.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/commit-log-editor
Diff
Modified: trunk/Tools/ChangeLog (90561 => 90562)
--- trunk/Tools/ChangeLog 2011-07-07 16:20:12 UTC (rev 90561)
+++ trunk/Tools/ChangeLog 2011-07-07 16:35:33 UTC (rev 90562)
@@ -1,3 +1,20 @@
+2011-07-07 Adam Roben aro...@apple.com
+
+Extract commit-log-editor's commit-message-generation code into a separate function
+
+As a bonus, we now skip a bunch of work in the case where we are generating a commit message
+for staged git changes.
+
+Prep work for fixing http://webkit.org/b/26755 webkit-patch's commit messages are less
+readable than commit-log-editor's
+
+Reviewed by David Kilzer.
+
+* Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
+file so that it will be defined even if we aren't operating on an existing log message.
+Moved a bunch of top-level code to generate the commit message from here...
+(createCommitMessage): ...to here.
+
2011-07-07 Carlos Garcia Campos cgar...@igalia.com
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser
Modified: trunk/Tools/Scripts/commit-log-editor (90561 => 90562)
--- trunk/Tools/Scripts/commit-log-editor 2011-07-07 16:20:12 UTC (rev 90561)
+++ trunk/Tools/Scripts/commit-log-editor 2011-07-07 16:35:33 UTC (rev 90562)
@@ -38,11 +38,14 @@
use VCSUtils;
use webkitdirs;
+sub createCommitMessage(@);
sub fixEnvironment();
sub normalizeLineEndings($$);
sub removeLongestCommonPrefixEndingInDoubleNewline(\%);
sub isCommitLogEditor($);
+my $endl = \n;
+
sub usage
{
print Usage: [--help] [--regenerate-log] log file\n;
@@ -129,7 +132,6 @@
# We want to match the line endings of the existing log file in case they're
# different from perl's line endings.
-my $endl = \n;
$endl = $1 if $logContents =~ /(\r?\n)/;
my $keepExistingLog = 1;
@@ -144,81 +146,9 @@
# Don't change anything if there's already a log message (as can happen with git-commit --amend).
exec (@editor, @ARGV) if $existingLog $keepExistingLog;
-my $topLevel = determineVCSRoot();
-
-my %changeLogSort;
-my %changeLogContents;
-for my $changeLog (@changeLogs) {
-open CHANGELOG, $changeLog or die Can't open $changeLog;
-my $contents = ;
-my $blankLines = ;
-my $lineCount = 0;
-my $date = ;
-my $author = ;
-my $email = ;
-my $hasAuthorInfoToWrite = 0;
-while (CHANGELOG) {
-if (/^\S/) {
-last if $contents;
-}
-if (/\S/) {
-$contents .= $blankLines if $contents;
-$blankLines = ;
-
-my $line = $_;
-
-# Remove indentation spaces
-$line =~ s/^ {8}//;
-
-# Grab the author and the date line
-if ($line =~ m/^([0-9]{4}-[0-9]{2}-[0-9]{2})\s+(.*[^\s])\s+(.*)/ $lineCount == 0) {
-$date = $1;
-$author = $2;
-$email = $3;
-$hasAuthorInfoToWrite = 1;
-next;
-}
-
-if ($line =~ m/^Reviewed by .*/ || $line =~ m/^Rubber[ \-]?stamped by .*/) {
-# Insert the Patch by line just above the Reviewed by line, if needed.
-my $committerEmail = changeLogEmailAddress();
-my $authorAndCommitterAreSamePerson = $email eq $committerEmail;
-if (!$authorAndCommitterAreSamePerson) {
-$contents .= Patch by $author $email on $date\n;
-$hasAuthorInfoToWrite = 0;
-}
-}
-
-
-$lineCount++;
-$contents .= $line;
-} else {
-$blankLines .= $_;
-}
-}
-close CHANGELOG;
-
-$changeLog = File::Spec-abs2rel(File::Spec-rel2abs($changeLog), $topLevel);
-
-my $label = dirname($changeLog);
-$label = top level unless length $label;
-
-my $sortKey = lc $label;
-if ($label eq top level) {
-$sortKey = ;
-} elsif ($label eq LayoutTests) {
-$sortKey = lc ~, LayoutTests last;
-}
-
-$changeLogSort{$sortKey} = $label;
-
[webkit-changes] [90563] trunk/Tools
Title: [90563] trunk/Tools
Revision 90563
Author aro...@apple.com
Date 2011-07-07 09:36:23 -0700 (Thu, 07 Jul 2011)
Log Message
Add a --print-log option to commit-log-editor
When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
generates a commit message from those ChangeLogs, prints it to stdout, and exits.
Prep work for fixing http://webkit.org/b/26755 webkit-patch's commit messages are less
readable than commit-log-editor's
Reviewed by David Kilzer.
* Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
option, which calls through to createCommitMessage, prints the result, and exits.
(printUsageAndExit): Renamed from usage for clarity. Beefed up the usage statement to
explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/commit-log-editor
Diff
Modified: trunk/Tools/ChangeLog (90562 => 90563)
--- trunk/Tools/ChangeLog 2011-07-07 16:35:33 UTC (rev 90562)
+++ trunk/Tools/ChangeLog 2011-07-07 16:36:23 UTC (rev 90563)
@@ -1,5 +1,22 @@
2011-07-07 Adam Roben aro...@apple.com
+Add a --print-log option to commit-log-editor
+
+When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
+generates a commit message from those ChangeLogs, prints it to stdout, and exits.
+
+Prep work for fixing http://webkit.org/b/26755 webkit-patch's commit messages are less
+readable than commit-log-editor's
+
+Reviewed by David Kilzer.
+
+* Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
+option, which calls through to createCommitMessage, prints the result, and exits.
+(printUsageAndExit): Renamed from usage for clarity. Beefed up the usage statement to
+explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
+
+2011-07-07 Adam Roben aro...@apple.com
+
Extract commit-log-editor's commit-message-generation code into a separate function
As a bonus, we now skip a bunch of work in the case where we are generating a commit message
Modified: trunk/Tools/Scripts/commit-log-editor (90562 => 90563)
--- trunk/Tools/Scripts/commit-log-editor 2011-07-07 16:35:33 UTC (rev 90562)
+++ trunk/Tools/Scripts/commit-log-editor 2011-07-07 16:36:23 UTC (rev 90563)
@@ -30,6 +30,7 @@
# Script to put change log comments in as default check-in comment.
use strict;
+use Getopt::Long;
use File::Basename;
use File::Spec;
use FindBin;
@@ -46,21 +47,42 @@
my $endl = \n;
-sub usage
+sub printUsageAndExit
{
-print Usage: [--help] [--regenerate-log] log file\n;
+my $programName = basename($0);
+print STDERR EOF;
+Usage: $programName [--regenerate-log] log file
+ $programName --print-log ChangeLog file [ChangeLog file...]
+ $programName --help
+EOF
exit 1;
}
-my $help = checkForArgumentAndRemoveFromARGV(--help);
-if ($help) {
-usage();
+my $help = 0;
+my $printLog = 0;
+my $regenerateLog = 0;
+
+my $getOptionsResult = GetOptions(
+'help' = \$help,
+'print-log' = \$printLog,
+'regenerate-log' = \$regenerateLog,
+);
+
+if (!$getOptionsResult || $help) {
+printUsageAndExit();
}
-my $regenerateLog = checkForArgumentAndRemoveFromARGV(--regenerate-log);
+die Can't specify both --print-log and --regenerate-log\n if $printLog $regenerateLog;
+
+if ($printLog) {
+printUsageAndExit() unless @ARGV;
+print createCommitMessage(@ARGV);
+exit 0;
+}
+
my $log = $ARGV[0];
if (!$log) {
-usage();
+printUsageAndExit();
}
fixEnvironment();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90564] trunk/Tools
Title: [90564] trunk/Tools
Revision 90564
Author aro...@apple.com
Date 2011-07-07 09:36:32 -0700 (Thu, 07 Jul 2011)
Log Message
Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
Fixes http://webkit.org/b/26755 webkit-patch's commit messages are less readable than
commit-log-editor's
Reviewed by David Kilzer.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
the modified ChangeLogs, to generate the commit message, rather than trying to generate one
ourselves.
* Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
to match commit-log-editor's format.
(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
directories so we can see how the various entries get labeled in the commit message.
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
instance that knows how to find commit-log-editor and pass it to our Checkout instance.
Don't bother capturing output, since there shouldn't be any.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90563 => 90564)
--- trunk/Tools/ChangeLog 2011-07-07 16:36:23 UTC (rev 90563)
+++ trunk/Tools/ChangeLog 2011-07-07 16:36:32 UTC (rev 90564)
@@ -1,5 +1,27 @@
2011-07-07 Adam Roben aro...@apple.com
+Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
+
+Fixes http://webkit.org/b/26755 webkit-patch's commit messages are less readable than
+commit-log-editor's
+
+Reviewed by David Kilzer.
+
+* Scripts/webkitpy/common/checkout/checkout.py:
+(Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
+the modified ChangeLogs, to generate the commit message, rather than trying to generate one
+ourselves.
+
+* Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
+to match commit-log-editor's format.
+(CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
+directories so we can see how the various entries get labeled in the commit message.
+(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
+instance that knows how to find commit-log-editor and pass it to our Checkout instance.
+Don't bother capturing output, since there shouldn't be any.
+
+2011-07-07 Adam Roben aro...@apple.com
+
Add a --print-log option to commit-log-editor
When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py (90563 => 90564)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2011-07-07 16:36:23 UTC (rev 90563)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2011-07-07 16:36:32 UTC (rev 90564)
@@ -120,17 +120,9 @@
raise ScriptError(message=Found no modified ChangeLogs, cannot create a commit message.\n
All changes require a ChangeLog. See:\n %s % urls.contribution_guidelines)
-changelog_messages = []
-for changelog_path in changelog_paths:
-log(Parsing ChangeLog: %s % changelog_path)
-changelog_entry = ChangeLog(changelog_path).latest_entry()
-if not changelog_entry:
-raise ScriptError(message=Failed to parse ChangeLog: %s % os.path.abspath(changelog_path))
-changelog_messages.append(changelog_entry.contents())
+message_text = Executive().run_command([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
+return CommitMessage(message_text.splitlines())
-# FIXME: We should sort and label the ChangeLog messages like commit-log-editor does.
-return CommitMessage(.join(changelog_messages).splitlines())
-
def recent_commit_infos_for_files(self, paths):
revisions = set(sum(map(self._scm.revisions_changing_file, paths), []))
return set(map(self.commit_info_for_revision, revisions))
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (90563 => 90564)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 16:36:23 UTC (rev 90563)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 16:36:32 UTC (rev 90564)
@@ -37,7 +37,6 @@
from .checkout import Checkout
from .changelog import ChangeLogEntry
from .scm import detect_scm_system, CommitMessage
-from webkitpy.common.system.outputcapture import OutputCapture
from webkitpy.common.system.executive import ScriptError
from webkitpy.thirdparty.mock
[webkit-changes] [90566] trunk/LayoutTests
Title: [90566] trunk/LayoutTests Revision 90566 Author abe...@webkit.org Date 2011-07-07 09:52:27 -0700 (Thu, 07 Jul 2011) Log Message REGRESSION(90557) http/tests/inspector/network/network-embed.html fails https://bugs.webkit.org/show_bug.cgi?id=64103 Unreviewed gardening. * platform/qt/Skipped: Skip test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90565 => 90566) --- trunk/LayoutTests/ChangeLog 2011-07-07 16:48:27 UTC (rev 90565) +++ trunk/LayoutTests/ChangeLog 2011-07-07 16:52:27 UTC (rev 90566) @@ -1,3 +1,12 @@ +2011-07-07 Andras Becsi abe...@webkit.org + +REGRESSION(90557) http/tests/inspector/network/network-embed.html fails +https://bugs.webkit.org/show_bug.cgi?id=64103 + +Unreviewed gardening. + +* platform/qt/Skipped: Skip test. + 2011-07-07 Xan Lopez xlo...@igalia.com Unreviewed. Modified: trunk/LayoutTests/platform/qt/Skipped (90565 => 90566) --- trunk/LayoutTests/platform/qt/Skipped 2011-07-07 16:48:27 UTC (rev 90565) +++ trunk/LayoutTests/platform/qt/Skipped 2011-07-07 16:52:27 UTC (rev 90566) @@ -293,6 +293,10 @@ # Failing HTTP tests. # # === # +# REGRESSION(90557) http/tests/inspector/network/network-embed.html fails +# https://bugs.webkit.org/show_bug.cgi?id=64103 +http/tests/inspector/network/network-embed.html + # no expected results http/tests/misc/favicon-as-image.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90567] trunk
Title: [90567] trunk
Revision 90567
Author vse...@chromium.org
Date 2011-07-07 09:53:51 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: URL links in styles open new tab instead of showing resources panel.
https://bugs.webkit.org/show_bug.cgi?id=64090
Reviewed by Pavel Feldman.
* inspector/styles/styles-url-linkify-expected.txt:
* inspector/styles/styles-url-linkify.html:
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: URL links in styles open new tab instead of showing resources panel.
https://bugs.webkit.org/show_bug.cgi?id=64090
Reviewed by Pavel Feldman.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt
trunk/LayoutTests/inspector/styles/styles-url-linkify.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/LayoutTests/ChangeLog (90566 => 90567)
--- trunk/LayoutTests/ChangeLog 2011-07-07 16:52:27 UTC (rev 90566)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 16:53:51 UTC (rev 90567)
@@ -1,3 +1,13 @@
+2011-07-07 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: URL links in styles open new tab instead of showing resources panel.
+https://bugs.webkit.org/show_bug.cgi?id=64090
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/styles-url-linkify-expected.txt:
+* inspector/styles/styles-url-linkify.html:
+
2011-07-07 Andras Becsi abe...@webkit.org
REGRESSION(90557) http/tests/inspector/network/network-embed.html fails
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt (90566 => 90567)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2011-07-07 16:52:27 UTC (rev 90566)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify-expected.txt 2011-07-07 16:53:51 UTC (rev 90567)
@@ -14,7 +14,7 @@
http://example.com/foo?a=b
data:image/png;base64,iVBORw0KGgoNSUhEUgAAAEIAAABCAgMAAACeOuh7BGdBTUEAAK/INwWK6QlQTFRFfu+PTwF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8ASUVORK5CYII=
Link for a URI from CSS document:
-inspector/styles/resources/fromcss.png
+webkit-html-resource-link inspector/styles/resources/fromcss.png
Link for a URI from iframe inline stylesheet:
inspector/styles/resources/iframed.png
Modified: trunk/LayoutTests/inspector/styles/styles-url-linkify.html (90566 => 90567)
--- trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2011-07-07 16:52:27 UTC (rev 90566)
+++ trunk/LayoutTests/inspector/styles/styles-url-linkify.html 2011-07-07 16:53:51 UTC (rev 90567)
@@ -28,25 +28,36 @@
const dataURL = data:image/png;base64,iVBORw0KGgoNSUhEUgAAAEIAAABCAgMAAACeOuh7BGdBTUEAAK/INwWK6QlQTFRFfu+PTwF0Uk5TAEDm2GYAAACHSURBVDjLxdLbDYAgDAVQGELn0R3oEHYf2KGdUqtE46OFRCP3oyTng1xCnWsaD5JRRtCkQ2YmkBkHRXqWJBn0j0TICbrsWVoWhRShCdcGyZCtHxMaUnVPRZ9KSbmBJdsX2vJVnwqRD0Rb4rpzgIbE/AI5NTnWAMvy5l0dXrfuLh5OCe5BmmYGXhTUxlQ5xJ8ASUVORK5CYII=;
completeURL(https://example.com/foo, dataURL);
-function dumpHref()
+function dumpHref(dumpLinkClass)
{
-var href;
+var hrefNode;
var valueChildNodes = WebInspector.panels.elements.sidebarPanes.styles.sections[0][2].propertiesTreeOutline.children[0].valueElement.childNodes;
for (var i = 0; i valueChildNodes.length; ++i) {
if (valueChildNodes[i].href) {
-href = ""
+hrefNode = valueChildNodes[i];
break;
}
}
-if (!href) {
+if (!hrefNode) {
InspectorTest.addResult(href property not found);
return;
}
+
+var styleClass = ;
+if (dumpLinkClass) {
+if (hrefNode.hasStyleClass(webkit-html-resource-link))
+styleClass += webkit-html-resource-link ;
+if (hrefNode.hasStyleClass(webkit-html-external-link))
+styleClass += webkit-html-external-link ;
+}
+
+var href = ""
var segments = href.split(/);
var output = [];
for (var i = segments.length - 1, minSegment = i - 3; i = 0 i = minSegment; --i)
output.unshift(segments[i]);
-InspectorTest.addResult(output.join(/));
+
+InspectorTest.addResult(styleClass + output.join(/));
}
InspectorTest.selectNodeAndWaitForStyles(local, step1);
@@ -54,7 +65,7 @@
function step1()
{
InspectorTest.addResult(Link for a URI from CSS document:);
-dumpHref();
+
[webkit-changes] [90568] trunk
Title: [90568] trunk
Revision 90568
Author jchaffr...@webkit.org
Date 2011-07-07 10:05:25 -0700 (Thu, 07 Jul 2011)
Log Message
Patch by Julien Chaffraix jchaffr...@webkit.org on 2011-07-07
Reviewed by David Hyatt.
Partial layout when a flex-box has visibility: collapse
https://bugs.webkit.org/show_bug.cgi?id=63776
Source/WebCore:
Tests: fast/flexbox/crash-button-input-autofocus.html
fast/flexbox/crash-button-keygen.html
fast/flexbox/crash-button-relayout.html
The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed.
However if one of the child is anonymous, it may wrap some other child that would be skipped.
Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted
as expected.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may
be real content hiding below.
LayoutTests:
Those tests checks some variation of the same underlying issue.
* fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
* fast/flexbox/crash-button-input-autofocus.html: Added.
* fast/flexbox/crash-button-keygen-expected.txt: Added.
* fast/flexbox/crash-button-keygen.html: Added.
* fast/flexbox/crash-button-relayout-expected.txt: Added.
* fast/flexbox/crash-button-relayout.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
Added Paths
trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus-expected.txt
trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus.html
trunk/LayoutTests/fast/flexbox/crash-button-keygen-expected.txt
trunk/LayoutTests/fast/flexbox/crash-button-keygen.html
trunk/LayoutTests/fast/flexbox/crash-button-relayout-expected.txt
trunk/LayoutTests/fast/flexbox/crash-button-relayout.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90567 => 90568)
--- trunk/LayoutTests/ChangeLog 2011-07-07 16:53:51 UTC (rev 90567)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 17:05:25 UTC (rev 90568)
@@ -1,3 +1,19 @@
+2011-07-07 Julien Chaffraix jchaffr...@webkit.org
+
+Reviewed by David Hyatt.
+
+Partial layout when a flex-box has visibility: collapse
+https://bugs.webkit.org/show_bug.cgi?id=63776
+
+Those tests checks some variation of the same underlying issue.
+
+* fast/flexbox/crash-button-input-autofocus-expected.txt: Added.
+* fast/flexbox/crash-button-input-autofocus.html: Added.
+* fast/flexbox/crash-button-keygen-expected.txt: Added.
+* fast/flexbox/crash-button-keygen.html: Added.
+* fast/flexbox/crash-button-relayout-expected.txt: Added.
+* fast/flexbox/crash-button-relayout.html: Added.
+
2011-07-07 Vsevolod Vlasov vse...@chromium.org
Web Inspector: URL links in styles open new tab instead of showing resources panel.
Added: trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus-expected.txt (0 => 90568)
--- trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus-expected.txt 2011-07-07 17:05:25 UTC (rev 90568)
@@ -0,0 +1,3 @@
+Test for bug 63776: Partial layout when a flex-box has visibility: collapse
+
+This test PASSES if it does not CRASH.
Added: trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus.html (0 => 90568)
--- trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus.html (rev 0)
+++ trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus.html 2011-07-07 17:05:25 UTC (rev 90568)
@@ -0,0 +1,14 @@
+html
+body
+p style=visibility: collapse;buttoninput autofocusinput id=test/input/button/p
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+document.body.offsetTop;
+document.getElementById('test').parentNode.removeChild(document.getElementById('test'));
+document.body.offsetTop;
+/script
+pTest for bug a href="" Partial layout when a flex-box has visibility: collapse/p
+pThis test PASSES if it does not CRASH./p
+/body
+/html
Property changes on: trunk/LayoutTests/fast/flexbox/crash-button-input-autofocus.html
___
Added: svn:executable
Added: trunk/LayoutTests/fast/flexbox/crash-button-keygen-expected.txt (0 => 90568)
--- trunk/LayoutTests/fast/flexbox/crash-button-keygen-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/flexbox/crash-button-keygen-expected.txt 2011-07-07 17:05:25 UTC (rev 90568)
@@ -0,0 +1,3 @@
+Test for bug 63776: Partial layout when a flex-box has visibility: collapse
+
+This test PASSES if it does not CRASH.
Added: trunk/LayoutTests/fast/flexbox/crash-button-keygen.html (0 => 90568)
--- trunk/LayoutTests/fast/flexbox/crash-button-keygen.html (rev 0)
+++
[webkit-changes] [90569] trunk/Source/WebCore
Title: [90569] trunk/Source/WebCore
Revision 90569
Author ca...@chromium.org
Date 2011-07-07 10:15:20 -0700 (Thu, 07 Jul 2011)
Log Message
Web Inspector: visual regressions in network panel
https://bugs.webkit.org/show_bug.cgi?id=64089
Reviewed by Pavel Feldman.
* inspector/front-end/networkPanel.css:
(.data-grid.network-log-grid tr.filler td):
(.network.panel .sidebar):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/networkPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (90568 => 90569)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 17:05:25 UTC (rev 90568)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 17:15:20 UTC (rev 90569)
@@ -1,3 +1,14 @@
+2011-07-07 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: visual regressions in network panel
+https://bugs.webkit.org/show_bug.cgi?id=64089
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/networkPanel.css:
+(.data-grid.network-log-grid tr.filler td):
+(.network.panel .sidebar):
+
2011-07-07 Julien Chaffraix jchaffr...@webkit.org
Reviewed by David Hyatt.
Modified: trunk/Source/WebCore/inspector/front-end/networkPanel.css (90568 => 90569)
--- trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-07-07 17:05:25 UTC (rev 90568)
+++ trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-07-07 17:15:20 UTC (rev 90569)
@@ -496,7 +496,7 @@
/* Summary */
-.network-timeline-grid tr.filler td {
+.data-grid.network-log-grid tr.filler td {
padding-bottom: 20px !important;
}
@@ -626,6 +626,7 @@
right: 0;
width: auto;
border: none;
+background: inherit;
}
.network.panel:not(.viewing-resource) .sidebar-resizer-vertical {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90570] trunk/LayoutTests
Title: [90570] trunk/LayoutTests Revision 90570 Author abe...@webkit.org Date 2011-07-07 10:17:18 -0700 (Thu, 07 Jul 2011) Log Message [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt https://bugs.webkit.org/show_bug.cgi?id=63255 Unreviewed gardening. * platform/qt/Skipped: Skip tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90569 => 90570) --- trunk/LayoutTests/ChangeLog 2011-07-07 17:15:20 UTC (rev 90569) +++ trunk/LayoutTests/ChangeLog 2011-07-07 17:17:18 UTC (rev 90570) @@ -1,3 +1,12 @@ +2011-07-07 Andras Becsi abe...@webkit.org + +[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt +https://bugs.webkit.org/show_bug.cgi?id=63255 + +Unreviewed gardening. + +* platform/qt/Skipped: Skip tests. + 2011-07-07 Julien Chaffraix jchaffr...@webkit.org Reviewed by David Hyatt. Modified: trunk/LayoutTests/platform/qt/Skipped (90569 => 90570) --- trunk/LayoutTests/platform/qt/Skipped 2011-07-07 17:15:20 UTC (rev 90569) +++ trunk/LayoutTests/platform/qt/Skipped 2011-07-07 17:17:18 UTC (rev 90570) @@ -2151,6 +2151,13 @@ # https://bugs.webkit.org/show_bug.cgi?id=53868 fast/notifications/notifications-document-close-crash.html +# [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt +# https://bugs.webkit.org/show_bug.cgi?id=63255 +fast/notifications/notifications-no-icon.html +fast/notifications/notifications-double-show.html +fast/notifications/notifications-with-permission.html +fast/notifications/notifications-without-permission.html + # [Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html # https://bugs.webkit.org/show_bug.cgi?id=54725 editing/selection/mixed-editability-10.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90571] trunk/Tools
Title: [90571] trunk/Tools
Revision 90571
Author commit-qu...@webkit.org
Date 2011-07-07 10:18:09 -0700 (Thu, 07 Jul 2011)
Log Message
Completely ignore too-many-failures builds in TestFailures in most circumstances
Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
really use them to perform regression analysis. The only time we want to pay attention to
too-many-failures builds is when we're trying to explain when the current bout of
too-many-failures started.
Fixes http://webkit.org/b/64106 TestFailures page sometimes claims a test started failing
in a build that didn't even run it (because it exited early due to too many failues)
Patch by Adam Roben aro...@apple.com on 2011-07-07
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
too-many-failures handling that would cause us to blame builds that didn't even run a given
test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
build was itself a too-many-failures build.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js (90570 => 90571)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js 2011-07-07 17:17:18 UTC (rev 90570)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js 2011-07-07 17:18:09 UTC (rev 90571)
@@ -118,6 +118,20 @@
var self = this;
self._loader.start(nextBuildName, function(tests, tooManyFailures) {
+if (tooManyFailures) {
+var firstBuildName = Object.keys(self._history)[0];
+// If the first (i.e., current or most recent) build exited early due to too many
+// failures, we want to process other too-many-failures builds normally to try to
+// figure out when the too-many-failures started occurring. If the first/current
+// build did not exit due to too many failures, then too-many-failures builds will
+// only confuse our analysis (since they run a semi-arbitrary subset of tests), so
+// we should just skip them entirely.
+if (firstBuildName !self._history[firstBuildName].tooManyFailures) {
+callback(true);
+return;
+}
+}
+
++self._testRunsSinceLastInterestingChange;
var historyItem = {
@@ -150,16 +164,6 @@
historyItem.tests[testName] = tests[testName];
}
-if (tooManyFailures previousHistoryItem) {
-// Not all tests were run due to too many failures. Just assume that all the tests
-// that failed in the last build would still have failed in this build had they been
-// run.
-for (var testName in previousHistoryItem.tests) {
-historyItem.tests[testName] = previousHistoryItem.tests[testName];
-delete previousHistoryItem.tests[testName];
-}
-}
-
var previousUnexplainedFailuresCount = previousBuildName ? Object.keys(self._history[previousBuildName].tests).length : 0;
var unexplainedFailuresCount = Object.keys(self._history[nextBuildName].tests).length;
Modified: trunk/Tools/ChangeLog (90570 => 90571)
--- trunk/Tools/ChangeLog 2011-07-07 17:17:18 UTC (rev 90570)
+++ trunk/Tools/ChangeLog 2011-07-07 17:18:09 UTC (rev 90571)
@@ -1,5 +1,25 @@
2011-07-07 Adam Roben aro...@apple.com
+Completely ignore too-many-failures builds in TestFailures in most circumstances
+
+Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
+really use them to perform regression analysis. The only time we want to pay attention to
+too-many-failures builds is when we're trying to explain when the current bout of
+too-many-failures started.
+
+Fixes http://webkit.org/b/64106 TestFailures page sometimes claims a test started failing
+in a build that didn't even run it (because it exited early due to too many failues)
+
+Reviewed by David Kilzer.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
+(LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
+too-many-failures handling that would cause us to blame builds that didn't even run a given
+test for breaking it. Instead, skip over all too-many-failures builds unless the most
[webkit-changes] [90572] trunk/Source/WebKit2
Title: [90572] trunk/Source/WebKit2
Revision 90572
Author andreas.kl...@nokia.com
Date 2011-07-07 10:27:33 -0700 (Thu, 07 Jul 2011)
Log Message
[Qt][WK2] Views should know about WebProcess crash/relaunch.
https://bugs.webkit.org/show_bug.cgi?id=64093
Reviewed by Benjamin Poulain.
Add processDidCrash() and didRelaunchProcess() to ViewInterface.
QDesktopWebView now displays a simple sad smiley :( when the
web process crashes.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
(paintCrashedPage):
(QDesktopWebView::paint):
(QDesktopWebViewPrivate::processDidCrash):
(QDesktopWebViewPrivate::didRelaunchProcess):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::didRelaunchProcess):
(QtWebPageProxy::processDidCrash):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::showContextMenu):
(WebKit::TouchViewInterface::hideContextMenu):
(WebKit::TouchViewInterface::processDidCrash):
(WebKit::TouchViewInterface::didRelaunchProcess):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/ViewInterface.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (90571 => 90572)
--- trunk/Source/WebKit2/ChangeLog 2011-07-07 17:18:09 UTC (rev 90571)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-07 17:27:33 UTC (rev 90572)
@@ -1,3 +1,35 @@
+2011-07-07 Andreas Kling kl...@webkit.org
+
+[Qt][WK2] Views should know about WebProcess crash/relaunch.
+https://bugs.webkit.org/show_bug.cgi?id=64093
+
+Reviewed by Benjamin Poulain.
+
+Add processDidCrash() and didRelaunchProcess() to ViewInterface.
+
+QDesktopWebView now displays a simple sad smiley :( when the
+web process crashes.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::QDesktopWebViewPrivate):
+(paintCrashedPage):
+(QDesktopWebView::paint):
+(QDesktopWebViewPrivate::processDidCrash):
+(QDesktopWebViewPrivate::didRelaunchProcess):
+* UIProcess/API/qt/qdesktopwebview_p.h:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::QtWebPageProxy):
+(QtWebPageProxy::didRelaunchProcess):
+(QtWebPageProxy::processDidCrash):
+* UIProcess/qt/QtWebPageProxy.h:
+* UIProcess/qt/TouchViewInterface.cpp:
+(WebKit::TouchViewInterface::showContextMenu):
+(WebKit::TouchViewInterface::hideContextMenu):
+(WebKit::TouchViewInterface::processDidCrash):
+(WebKit::TouchViewInterface::didRelaunchProcess):
+* UIProcess/qt/TouchViewInterface.h:
+* UIProcess/qt/ViewInterface.h:
+
2011-07-07 Benjamin Poulain benja...@webkit.org
[Qt] [WK2] Improve the handling of touch events to use them as main input
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp (90571 => 90572)
--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp 2011-07-07 17:18:09 UTC (rev 90571)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp 2011-07-07 17:27:33 UTC (rev 90572)
@@ -30,6 +30,7 @@
QDesktopWebViewPrivate::QDesktopWebViewPrivate(QDesktopWebView* q, WKContextRef contextRef, WKPageGroupRef pageGroupRef)
: q(q)
, page(this, contextRef ? new QWKContext(contextRef) : defaultWKContext(), pageGroupRef)
+, isCrashed(false)
{
}
@@ -189,8 +190,19 @@
QGraphicsWidget::resizeEvent(ev);
}
+static void paintCrashedPage(QPainter* painter, const QStyleOptionGraphicsItem* option)
+{
+painter-fillRect(option-rect, Qt::gray);
+painter-drawText(option-rect, Qt::AlignCenter, QLatin1String(:());
+}
+
void QDesktopWebView::paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget*)
{
+if (d-isCrashed) {
+paintCrashedPage(painter, option);
+return;
+}
+
d-page.paint(painter, option-exposedRect.toAlignedRect());
}
@@ -205,3 +217,15 @@
{
return d-page.pageRef();
}
+
+void QDesktopWebViewPrivate::processDidCrash()
+{
+isCrashed = true;
+q-update();
+}
+
+void QDesktopWebViewPrivate::didRelaunchProcess()
+{
+isCrashed = false;
+q-update();
+}
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h (90571 => 90572)
--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-07-07 17:18:09 UTC (rev 90571)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-07-07 17:27:33 UTC (rev 90572)
@@ -36,6 +36,8 @@
QDesktopWebView* q;
QDesktopWebPageProxy page;
[webkit-changes] [90573] trunk
Title: [90573] trunk
Revision 90573
Author m...@apple.com
Date 2011-07-07 10:27:46 -0700 (Thu, 07 Jul 2011)
Log Message
rdar://problem/9737435 Re-enable -webkit-column-break-inside: avoid
https://bugs.webkit.org/show_bug.cgi?id=64102
Reviewed by Simon Fraser.
Source/WebCore:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
'-webkit-column-break-inside: avoid' was specified.
LayoutTests:
* fast/multicol/break-properties-expected.txt:
* fast/multicol/break-properties.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/multicol/break-properties-expected.txt
trunk/LayoutTests/fast/multicol/break-properties.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (90572 => 90573)
--- trunk/LayoutTests/ChangeLog 2011-07-07 17:27:33 UTC (rev 90572)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 17:27:46 UTC (rev 90573)
@@ -1,3 +1,13 @@
+2011-07-07 Dan Bernstein m...@apple.com
+
+rdar://problem/9737435 Re-enable -webkit-column-break-inside: avoid
+https://bugs.webkit.org/show_bug.cgi?id=64102
+
+Reviewed by Simon Fraser.
+
+* fast/multicol/break-properties-expected.txt:
+* fast/multicol/break-properties.html:
+
2011-07-07 Andras Becsi abe...@webkit.org
[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
Modified: trunk/LayoutTests/fast/multicol/break-properties-expected.txt (90572 => 90573)
--- trunk/LayoutTests/fast/multicol/break-properties-expected.txt 2011-07-07 17:27:33 UTC (rev 90572)
+++ trunk/LayoutTests/fast/multicol/break-properties-expected.txt 2011-07-07 17:27:46 UTC (rev 90573)
@@ -1,3 +1,4 @@
PASS: 'break-before' is at (218, 8)
PASS: 'after-break' is at (428, 8)
+PASS: 'no-break' is at (533, 8)
Modified: trunk/LayoutTests/fast/multicol/break-properties.html (90572 => 90573)
--- trunk/LayoutTests/fast/multicol/break-properties.html 2011-07-07 17:27:33 UTC (rev 90572)
+++ trunk/LayoutTests/fast/multicol/break-properties.html 2011-07-07 17:27:46 UTC (rev 90573)
@@ -32,4 +32,5 @@
testBoxPosition(break-before, 218, 8);
testBoxPosition(after-break, 428, 8);
+testBoxPosition(no-break, 533, 8);
/script
Modified: trunk/Source/WebCore/ChangeLog (90572 => 90573)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 17:27:33 UTC (rev 90572)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 17:27:46 UTC (rev 90573)
@@ -1,3 +1,14 @@
+2011-07-07 Dan Bernstein m...@apple.com
+
+rdar://problem/9737435 Re-enable -webkit-column-break-inside: avoid
+https://bugs.webkit.org/show_bug.cgi?id=64102
+
+Reviewed by Simon Fraser.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if
+'-webkit-column-break-inside: avoid' was specified.
+
2011-07-07 Andrey Kosyakov ca...@chromium.org
Web Inspector: visual regressions in network panel
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (90572 => 90573)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-07 17:27:33 UTC (rev 90572)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-07 17:27:46 UTC (rev 90573)
@@ -6038,7 +6038,7 @@
int RenderBlock::adjustForUnsplittableChild(RenderBox* child, int logicalOffset, bool includeMargins)
{
-bool isUnsplittable = child-isReplaced() || child-scrollsOverflow();
+bool isUnsplittable = child-isReplaced() || child-scrollsOverflow() || child-style()-columnBreakInside() == PBAVOID;
if (!isUnsplittable)
return logicalOffset;
int childLogicalHeight = logicalHeightForChild(child) + (includeMargins ? marginBeforeForChild(child) + marginAfterForChild(child) : 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90574] trunk/Source/WebCore
Title: [90574] trunk/Source/WebCore Revision 90574 Author commit-qu...@webkit.org Date 2011-07-07 10:29:20 -0700 (Thu, 07 Jul 2011) Log Message The return value of SharedBuffer::createWithContentsOfFile must have valid m_size. https://bugs.webkit.org/show_bug.cgi?id=63313 Patch by Kyusun Kim maniag...@company100.net on 2011-07-07 Reviewed by Eric Seidel. * platform/posix/SharedBufferPOSIX.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (90573 => 90574) --- trunk/Source/WebCore/ChangeLog 2011-07-07 17:27:46 UTC (rev 90573) +++ trunk/Source/WebCore/ChangeLog 2011-07-07 17:29:20 UTC (rev 90574) @@ -1,3 +1,13 @@ +2011-07-07 Kyusun Kim maniag...@company100.net + +The return value of SharedBuffer::createWithContentsOfFile must have valid m_size. +https://bugs.webkit.org/show_bug.cgi?id=63313 + +Reviewed by Eric Seidel. + +* platform/posix/SharedBufferPOSIX.cpp: +(WebCore::SharedBuffer::createWithContentsOfFile): + 2011-07-07 Dan Bernstein m...@apple.com rdar://problem/9737435 Re-enable -webkit-column-break-inside: avoid Modified: trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp (90573 => 90574) --- trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp 2011-07-07 17:27:46 UTC (rev 90573) +++ trunk/Source/WebCore/platform/posix/SharedBufferPOSIX.cpp 2011-07-07 17:29:20 UTC (rev 90574) @@ -57,17 +57,16 @@ return 0; } -RefPtrSharedBuffer result = create(); -result-m_buffer.grow(bytesToRead); +Vectorchar buffer(bytesToRead); size_t totalBytesRead = 0; ssize_t bytesRead; -while ((bytesRead = read(fd, result-m_buffer.data() + totalBytesRead, bytesToRead - totalBytesRead)) 0) +while ((bytesRead = read(fd, buffer.data() + totalBytesRead, bytesToRead - totalBytesRead)) 0) totalBytesRead += bytesRead; close(fd); -return totalBytesRead == bytesToRead ? result.release() : 0; +return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0; } } // namespace WebCore ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90575] trunk/Source/WebCore/ChangeLog
Title: [90575] trunk/Source/WebCore/ChangeLog Revision 90575 Author m...@apple.com Date 2011-07-07 10:33:06 -0700 (Thu, 07 Jul 2011) Log Message Updated change log Modified Paths trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/ChangeLog (90574 => 90575) --- trunk/Source/WebCore/ChangeLog 2011-07-07 17:29:20 UTC (rev 90574) +++ trunk/Source/WebCore/ChangeLog 2011-07-07 17:33:06 UTC (rev 90575) @@ -15,6 +15,9 @@ Reviewed by Simon Fraser. +-webkit-column-break-inside: avoid was disabled in r62632 along with page-break-inside: avoid. +The latter remains disabled. + * rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustForUnsplittableChild): Treat the child as unsplittable if '-webkit-column-break-inside: avoid' was specified. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90576] trunk/LayoutTests
Title: [90576] trunk/LayoutTests Revision 90576 Author aro...@apple.com Date 2011-07-07 10:39:56 -0700 (Thu, 07 Jul 2011) Log Message Skip another test that uses beginDragWithFiles on Windows * platform/win/Skipped: Added fast/forms/file-input-change-event.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90575 => 90576) --- trunk/LayoutTests/ChangeLog 2011-07-07 17:33:06 UTC (rev 90575) +++ trunk/LayoutTests/ChangeLog 2011-07-07 17:39:56 UTC (rev 90576) @@ -1,3 +1,9 @@ +2011-07-07 Adam Roben aro...@apple.com + +Skip another test that uses beginDragWithFiles on Windows + +* platform/win/Skipped: Added fast/forms/file-input-change-event.html. + 2011-07-07 Dan Bernstein m...@apple.com rdar://problem/9737435 Re-enable -webkit-column-break-inside: avoid Modified: trunk/LayoutTests/platform/win/Skipped (90575 => 90576) --- trunk/LayoutTests/platform/win/Skipped 2011-07-07 17:33:06 UTC (rev 90575) +++ trunk/LayoutTests/platform/win/Skipped 2011-07-07 17:39:56 UTC (rev 90576) @@ -208,6 +208,7 @@ editing/pasteboard/file-input-files-access.html fast/events/drag-to-navigate.html fast/events/prevent-drag-to-navigate.html +fast/forms/file-input-change-event.html fast/forms/get-file-upload.html fast/forms/input-file-re-render.html http/tests/security/clipboard/clipboard-file-access.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90577] trunk
Title: [90577] trunk Revision 90577 Author andreas.kl...@nokia.com Date 2011-07-07 10:43:30 -0700 (Thu, 07 Jul 2011) Log Message [Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations. https://bugs.webkit.org/show_bug.cgi?id=64099 Reviewed by Benjamin Poulain. Source/WebKit2: * Shared/qt/WebEventFactoryQt.cpp: (WebKit::WebEventFactory::createWebWheelEvent): * UIProcess/API/qt/qdesktopwebview_p.h: * UIProcess/qt/QtWebPageProxy.cpp: (QtWebPageProxy::QtWebPageProxy): (QtWebPageProxy::setCursor): (QtWebPageProxy::registerEditCommand): (QtWebPageProxy::clearAllEditCommands): (QtWebPageProxy::canUndoRedo): (QtWebPageProxy::executeUndoRedo): (QtWebPageProxy::updateAction): (QtWebPageProxy::webActionTriggered): (QtWebPageProxy::triggerAction): (QtWebPageProxy::action): * UIProcess/qt/QtWebPageProxy.h: * UIProcess/qt/TouchViewInterface.cpp: (WebKit::TouchViewInterface::didChangeCursor): * UIProcess/qt/TouchViewInterface.h: * UIProcess/qt/ViewInterface.h: * UIProcess/qt/WebUndoCommandQt.cpp: (WebUndoCommandQt::WebUndoCommandQt): * UIProcess/qt/WebUndoCommandQt.h: * WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: (WebKit::WebDragClient::startDrag): Tools: * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::openFile): (BrowserWindow::screenshot): (BrowserWindow::loadURLListFromFile): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h trunk/Source/WebKit2/UIProcess/qt/ViewInterface.h trunk/Source/WebKit2/UIProcess/qt/WebUndoCommandQt.cpp trunk/Source/WebKit2/UIProcess/qt/WebUndoCommandQt.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (90576 => 90577) --- trunk/Source/WebKit2/ChangeLog 2011-07-07 17:39:56 UTC (rev 90576) +++ trunk/Source/WebKit2/ChangeLog 2011-07-07 17:43:30 UTC (rev 90577) @@ -1,5 +1,37 @@ 2011-07-07 Andreas Kling kl...@webkit.org +[Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations. +https://bugs.webkit.org/show_bug.cgi?id=64099 + +Reviewed by Benjamin Poulain. + +* Shared/qt/WebEventFactoryQt.cpp: +(WebKit::WebEventFactory::createWebWheelEvent): +* UIProcess/API/qt/qdesktopwebview_p.h: +* UIProcess/qt/QtWebPageProxy.cpp: +(QtWebPageProxy::QtWebPageProxy): +(QtWebPageProxy::setCursor): +(QtWebPageProxy::registerEditCommand): +(QtWebPageProxy::clearAllEditCommands): +(QtWebPageProxy::canUndoRedo): +(QtWebPageProxy::executeUndoRedo): +(QtWebPageProxy::updateAction): +(QtWebPageProxy::webActionTriggered): +(QtWebPageProxy::triggerAction): +(QtWebPageProxy::action): +* UIProcess/qt/QtWebPageProxy.h: +* UIProcess/qt/TouchViewInterface.cpp: +(WebKit::TouchViewInterface::didChangeCursor): +* UIProcess/qt/TouchViewInterface.h: +* UIProcess/qt/ViewInterface.h: +* UIProcess/qt/WebUndoCommandQt.cpp: +(WebUndoCommandQt::WebUndoCommandQt): +* UIProcess/qt/WebUndoCommandQt.h: +* WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: +(WebKit::WebDragClient::startDrag): + +2011-07-07 Andreas Kling kl...@webkit.org + [Qt][WK2] Views should know about WebProcess crash/relaunch. https://bugs.webkit.org/show_bug.cgi?id=64093 Modified: trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp (90576 => 90577) --- trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp 2011-07-07 17:39:56 UTC (rev 90576) +++ trunk/Source/WebKit2/Shared/qt/WebEventFactoryQt.cpp 2011-07-07 17:43:30 UTC (rev 90577) @@ -135,10 +135,8 @@ // Use the same single scroll step as QTextEdit // (in QTextEditPrivate::init [h,v]bar-setSingleStep) static const float cDefaultQtScrollStep = 20.f; -#ifndef QT_NO_WHEELEVENT deltaX *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; deltaY *= (fullTick) ? QApplication::wheelScrollLines() * cDefaultQtScrollStep : 1; -#endif return WebWheelEvent(WebEvent::Wheel, e-pos().toPoint(), e-screenPos(), FloatSize(deltaX, deltaY), FloatSize(wheelTicksX, wheelTicksY), granularity, modifiers, timestamp); } Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h (90576 => 90577) --- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-07-07 17:39:56 UTC (rev 90576) +++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h 2011-07-07 17:43:30 UTC (rev 90577) @@ -55,9 +55,7 @@ virtual void didChangeTitle(const QString); virtual void didChangeToolTip(const QString); virtual void
[webkit-changes] [90578] trunk
Title: [90578] trunk
Revision 90578
Author andreas.kl...@nokia.com
Date 2011-07-07 10:45:32 -0700 (Thu, 07 Jul 2011)
Log Message
[Qt][WK2] Remove Symbian code.
https://bugs.webkit.org/show_bug.cgi?id=64101
Reviewed by Benjamin Poulain.
Source/WebKit2:
* DerivedSources.pro:
* Platform/CoreIPC/Attachment.h:
* Platform/CoreIPC/Connection.h:
* Platform/SharedMemory.h:
* Platform/qt/SharedMemorySymbian.cpp: Removed.
* UIProcess/API/qt/tests/tests.pri:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* WebKit2.pri:
* WebKit2.pro:
* WebProcess.pro:
* config.h:
Tools:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.pro
trunk/Source/WebKit2/Platform/CoreIPC/Attachment.h
trunk/Source/WebKit2/Platform/CoreIPC/Connection.h
trunk/Source/WebKit2/Platform/SharedMemory.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/tests.pri
trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp
trunk/Source/WebKit2/WebKit2.pri
trunk/Source/WebKit2/WebKit2.pro
trunk/Source/WebKit2/WebProcess.pro
trunk/Source/WebKit2/config.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/MiniBrowser.pro
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h
Removed Paths
trunk/Source/WebKit2/Platform/qt/SharedMemorySymbian.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (90577 => 90578)
--- trunk/Source/WebKit2/ChangeLog 2011-07-07 17:43:30 UTC (rev 90577)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-07 17:45:32 UTC (rev 90578)
@@ -1,5 +1,24 @@
2011-07-07 Andreas Kling kl...@webkit.org
+[Qt][WK2] Remove Symbian code.
+https://bugs.webkit.org/show_bug.cgi?id=64101
+
+Reviewed by Benjamin Poulain.
+
+* DerivedSources.pro:
+* Platform/CoreIPC/Attachment.h:
+* Platform/CoreIPC/Connection.h:
+* Platform/SharedMemory.h:
+* Platform/qt/SharedMemorySymbian.cpp: Removed.
+* UIProcess/API/qt/tests/tests.pri:
+* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
+* WebKit2.pri:
+* WebKit2.pro:
+* WebProcess.pro:
+* config.h:
+
+2011-07-07 Andreas Kling kl...@webkit.org
+
[Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
https://bugs.webkit.org/show_bug.cgi?id=64099
Modified: trunk/Source/WebKit2/DerivedSources.pro (90577 => 90578)
--- trunk/Source/WebKit2/DerivedSources.pro 2011-07-07 17:43:30 UTC (rev 90577)
+++ trunk/Source/WebKit2/DerivedSources.pro 2011-07-07 17:45:32 UTC (rev 90578)
@@ -23,7 +23,7 @@
QUOTE =
DOUBLE_ESCAPED_QUOTE =
ESCAPE =
-win32-msvc*|symbian {
+win32-msvc* {
ESCAPE = ^
} else:win32-g++*:isEmpty(QMAKE_SH) {
# MinGW's make will run makefile commands using sh, even if make
Modified: trunk/Source/WebKit2/Platform/CoreIPC/Attachment.h (90577 => 90578)
--- trunk/Source/WebKit2/Platform/CoreIPC/Attachment.h 2011-07-07 17:43:30 UTC (rev 90577)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Attachment.h 2011-07-07 17:45:32 UTC (rev 90578)
@@ -40,7 +40,7 @@
#if PLATFORM(MAC)
MachPortType,
MachOOLMemoryType,
-#elif USE(UNIX_DOMAIN_SOCKETS) || OS(SYMBIAN)
+#elif USE(UNIX_DOMAIN_SOCKETS)
MappedMemory
#endif
};
@@ -48,7 +48,7 @@
#if PLATFORM(MAC)
Attachment(mach_port_name_t port, mach_msg_type_name_t disposition);
Attachment(void* address, mach_msg_size_t size, mach_msg_copy_options_t copyOptions, bool deallocate);
-#elif USE(UNIX_DOMAIN_SOCKETS) || OS(SYMBIAN)
+#elif USE(UNIX_DOMAIN_SOCKETS)
Attachment(int fileDescriptor, size_t);
#endif
@@ -66,7 +66,7 @@
mach_msg_size_t size() const { ASSERT(m_type == MachOOLMemoryType); return m_oolMemory.size; }
mach_msg_copy_options_t copyOptions() const { ASSERT(m_type == MachOOLMemoryType); return m_oolMemory.copyOptions; }
bool deallocate() const { ASSERT(m_type == MachOOLMemoryType); return m_oolMemory.deallocate; }
-#elif USE(UNIX_DOMAIN_SOCKETS) || OS(SYMBIAN)
+#elif USE(UNIX_DOMAIN_SOCKETS)
size_t size() const { return m_size; }
int releaseFileDescriptor() { int temp = m_fileDescriptor; m_fileDescriptor = -1; return temp; }
@@ -94,7 +94,7 @@
bool deallocate;
} m_oolMemory;
};
-#elif USE(UNIX_DOMAIN_SOCKETS) || OS(SYMBIAN)
+#elif USE(UNIX_DOMAIN_SOCKETS)
int m_fileDescriptor;
size_t m_size;
#endif
Modified: trunk/Source/WebKit2/Platform/CoreIPC/Connection.h (90577 => 90578)
--- trunk/Source/WebKit2/Platform/CoreIPC/Connection.h 2011-07-07 17:43:30 UTC (rev 90577)
+++ trunk/Source/WebKit2/Platform/CoreIPC/Connection.h 2011-07-07 17:45:32 UTC (rev 90578)
@@ -108,7 +108,7 @@
#elif PLATFORM(WIN)
typedef HANDLE Identifier;
static bool createServerAndClientIdentifiers(Identifier serverIdentifier,
[webkit-changes] [90579] trunk/Tools
Title: [90579] trunk/Tools Revision 90579 Author aro...@apple.com Date 2011-07-07 11:02:03 -0700 (Thu, 07 Jul 2011) Log Message Keep testing that commit messages containing Unicode are handled properly by webkitpy Fixes http://webkit.org/b/64109 REGRESSION (r90571): test-webkitpy no longer tests that we correctly handle Unicode in commit messages Reviewed by Eric Seidel. * Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in places in the ChangeLog that will end up being included in the commit message. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py Diff Modified: trunk/Tools/ChangeLog (90578 => 90579) --- trunk/Tools/ChangeLog 2011-07-07 17:45:32 UTC (rev 90578) +++ trunk/Tools/ChangeLog 2011-07-07 18:02:03 UTC (rev 90579) @@ -1,3 +1,15 @@ +2011-07-07 Adam Roben aro...@apple.com + +Keep testing that commit messages containing Unicode are handled properly by webkitpy + +Fixes http://webkit.org/b/64109 REGRESSION (r90571): test-webkitpy no longer tests that we +correctly handle Unicode in commit messages + +Reviewed by Eric Seidel. + +* Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in +places in the ChangeLog that will end up being included in the commit message. + 2011-07-07 Andreas Kling kl...@webkit.org [Qt][WK2] Remove Symbian code. Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (90578 => 90579) --- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 17:45:32 UTC (rev 90578) +++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 18:02:03 UTC (rev 90579) @@ -70,7 +70,7 @@ Unreviewed build fix to un-break webkit-patch land. -Second part of this complicated change. +Second part of this complicated change by me, Tor Arne Vestb\u00f8! * Path/To/Complicated/File: Added. @@ -93,7 +93,7 @@ LayoutTests: -Second part of this complicated change. +Second part of this complicated change by me, Tor Arne Vestb\u00f8! * Path/To/Complicated/File: Added. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90580] trunk/LayoutTests
Title: [90580] trunk/LayoutTests Revision 90580 Author k...@webkit.org Date 2011-07-07 11:15:06 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Gustavo Noronha Silva g...@gnome.org Unreviewed. Re-skip the inspector tests, they are still timing out on the release bot for some reason. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90579 => 90580) --- trunk/LayoutTests/ChangeLog 2011-07-07 18:02:03 UTC (rev 90579) +++ trunk/LayoutTests/ChangeLog 2011-07-07 18:15:06 UTC (rev 90580) @@ -1,3 +1,12 @@ +2011-07-07 Gustavo Noronha Silva g...@gnome.org + +Unreviewed. + +Re-skip the inspector tests, they are still timing out on the +release bot for some reason. + +* platform/gtk/Skipped: + 2011-07-07 Adam Roben aro...@apple.com Skip another test that uses beginDragWithFiles on Windows Modified: trunk/LayoutTests/platform/gtk/Skipped (90579 => 90580) --- trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 18:02:03 UTC (rev 90579) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-07-07 18:15:06 UTC (rev 90580) @@ -1548,3 +1548,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=64085 http/tests/misc/iframe-reparenting-id-collision.html + +# NWRT. Skip inspector/ and http/tests/inspector while we figure out +# what happens to them in the bots; the debug bots are failing only a +# few tests, but the release bot is getting timeouts in pretty much +# all of them. +http/tests/inspector +http/tests/inspector-enabled +inspector/ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90581] trunk/Source/WebCore
Title: [90581] trunk/Source/WebCore
Revision 90581
Author ca...@chromium.org
Date 2011-07-07 11:38:18 -0700 (Thu, 07 Jul 2011)
Log Message
2011-07-07 Andrey Kosyakov ca...@chromium.org
Web Inspector: secure access to extensions API
https://bugs.webkit.org/show_bug.cgi?id=64080
Reviewed by Pavel Feldman.
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
(WebInspector.ExtensionServer.prototype._expandResourcePath):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (90580 => 90581)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 18:15:06 UTC (rev 90580)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 18:38:18 UTC (rev 90581)
@@ -1,3 +1,24 @@
+2011-07-07 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: secure access to extensions API
+https://bugs.webkit.org/show_bug.cgi?id=64080
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ExtensionAPI.js:
+(WebInspector.injectedExtensionAPI.Panels.prototype.create):
+(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
+* inspector/front-end/ExtensionPanel.js:
+(WebInspector.ExtensionPanel):
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer):
+(WebInspector.ExtensionServer.prototype._onCreatePanel):
+(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
+(WebInspector.ExtensionServer.prototype._addExtensions):
+(WebInspector.ExtensionServer.prototype._onWindowMessage):
+(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
+(WebInspector.ExtensionServer.prototype._expandResourcePath):
+
2011-07-07 Kyusun Kim maniag...@company100.net
The return value of SharedBuffer::createWithContentsOfFile must have valid m_size.
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (90580 => 90581)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-07 18:15:06 UTC (rev 90580)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-07 18:38:18 UTC (rev 90581)
@@ -167,15 +167,15 @@
}
Panels.prototype = {
-create: function(title, iconURL, pageURL, callback)
+create: function(title, icon, page, callback)
{
var id = extension-panel- + extensionServer.nextObjectId();
var request = {
command: createPanel,
id: id,
title: title,
-icon: expandURL(iconURL),
-url: expandURL(pageURL)
+icon: icon,
+page: page
};
extensionServer.sendRequest(request, callback bind(callback, this, new ExtensionPanel(id)));
}
@@ -248,9 +248,9 @@
extensionServer.sendRequest({ command: setSidebarContent, id: this._id, _expression_: jsonObject, rootTitle: rootTitle });
},
-setPage: function(url)
+setPage: function(page)
{
-extensionServer.sendRequest({ command: setSidebarPage, id: this._id, url: expandURL(url) });
+extensionServer.sendRequest({ command: setSidebarPage, id: this._id, page: page });
}
}
@@ -440,18 +440,6 @@
}
}
-function expandURL(url)
-{
-if (!url)
-return url;
-if (/^[^/]+:/.exec(url)) // See if url has schema.
-return url;
-var baseURL = location.protocol + // + location.hostname + location.port;
-if (/^\//.exec(url))
-return baseURL + url;
-return baseURL + location.pathname.replace(/\/[^/]*$/,/) + url;
-}
-
function bind(func, thisObject)
{
var args = Array.prototype.slice.call(arguments, 2);
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js (90580 => 90581)
--- trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2011-07-07 18:15:06 UTC (rev 90580)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2011-07-07 18:38:18 UTC (rev 90581)
@@ -31,7 +31,8 @@
WebInspector.ExtensionPanel = function(id, label, iconURL, options)
{
this.toolbarItemLabel = label;
-this._addStyleRule(.toolbar-item. + id +
[webkit-changes] [90582] trunk
Title: [90582] trunk
Revision 90582
Author k...@webkit.org
Date 2011-07-07 11:43:44 -0700 (Thu, 07 Jul 2011)
Log Message
Reviewed by Rob Buis.
Source/WebCore:
SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865
Added fallback to 'to' animation for 'by' animated SVGAnimatedPathAnimator.
Clenup of SVGAnimateElement. Removed all switches since we support all AnimatedTypes
with the exception of AnimatedEnumeration. AnimatedEnumeration gets animated as AnimatedString at the moment.
Test: svg/animations/svgpath-animation-1.html
* svg/SVGAnimateElement.cpp:
(WebCore::getPropertyValue):
(WebCore::inheritsFromProperty):
(WebCore::attributeValueIsCurrentColor):
(WebCore::SVGAnimateElement::adjustForCurrentColor):
(WebCore::SVGAnimateElement::determineAnimatedAttributeType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::calculateFromAndToValues):
(WebCore::SVGAnimateElement::calculateFromAndByValues):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::applyResultsToTarget):
(WebCore::SVGAnimateElement::calculateDistance):
* svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::calculateFromAndByValues):
LayoutTests:
SVGAnimatedPath needs fallback for 'by' animation
https://bugs.webkit.org/show_bug.cgi?id=63865
Test fallback to 'to' animation for 'by' animated SVGPath.
* svg/animations/script-tests/svgpath-animation-1.js: Added.
(sample1):
(sample2):
(sample3):
(executeTest):
* svg/animations/svgpath-animation-1-expected.txt: Added.
* svg/animations/svgpath-animation-1.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGAnimateElement.cpp
trunk/Source/WebCore/svg/SVGAnimatedPath.cpp
Added Paths
trunk/LayoutTests/svg/animations/script-tests/svgpath-animation-1.js
trunk/LayoutTests/svg/animations/svgpath-animation-1-expected.txt
trunk/LayoutTests/svg/animations/svgpath-animation-1.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90581 => 90582)
--- trunk/LayoutTests/ChangeLog 2011-07-07 18:38:18 UTC (rev 90581)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 18:43:44 UTC (rev 90582)
@@ -1,3 +1,20 @@
+2011-07-07 Dirk Schulze k...@webkit.org
+
+Reviewed by Rob Buis.
+
+SVGAnimatedPath needs fallback for 'by' animation
+https://bugs.webkit.org/show_bug.cgi?id=63865
+
+Test fallback to 'to' animation for 'by' animated SVGPath.
+
+* svg/animations/script-tests/svgpath-animation-1.js: Added.
+(sample1):
+(sample2):
+(sample3):
+(executeTest):
+* svg/animations/svgpath-animation-1-expected.txt: Added.
+* svg/animations/svgpath-animation-1.html: Added.
+
2011-07-07 Gustavo Noronha Silva g...@gnome.org
Unreviewed.
Modified: trunk/LayoutTests/platform/wk2/Skipped (90581 => 90582)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-07-07 18:38:18 UTC (rev 90581)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-07 18:43:44 UTC (rev 90582)
@@ -488,6 +488,7 @@
svg/animations/svgnumberoptionalnumber-animation-2.html
svg/animations/svgnumberoptionalnumber-animation-3.html
svg/animations/svgnumberoptionalnumber-animation-4.html
+svg/animations/svgpath-animation-1.html
svg/animations/svgpointlist-animation-1.html
svg/animations/svgpointlist-animation-2.html
svg/animations/svgPreserveAspectRatio-animation-1.html
Added: trunk/LayoutTests/svg/animations/script-tests/svgpath-animation-1.js (0 => 90582)
--- trunk/LayoutTests/svg/animations/script-tests/svgpath-animation-1.js (rev 0)
+++ trunk/LayoutTests/svg/animations/script-tests/svgpath-animation-1.js 2011-07-07 18:43:44 UTC (rev 90582)
@@ -0,0 +1,53 @@
+description(Test fallback to 'to' animation if user specifies 'by' animation on path. You should see a green 100x100 path and only PASS messages);
+createSVGTestCase();
+// FIXME: We should move to animatePathSegList, once it is implemented.
+
+// Setup test document
+var path = createSVGElement(path);
+path.setAttribute(id, path);
+path.setAttribute(d, M 40 40 L 60 40 L 60 60 L 40 60 z);
+path.setAttribute(fill, green);
+path.setAttribute(onclick, executeTest());
+
+var animate = createSVGElement(animate);
+animate.setAttribute(id, animation);
+animate.setAttribute(attributeName, d);
+animate.setAttribute(from, M 40 40 L 60 40 L 60 60 L 40 60 z);
+animate.setAttribute(by, M 0 0 L 100 0 L 100 100 L 0 100 z);
+animate.setAttribute(begin, click);
+animate.setAttribute(dur, 4s);
+path.appendChild(animate);
+rootSVGElement.appendChild(path);
+
+// Setup animation test
+function sample1() {
+// Check initial/end conditions
+shouldBe(path.pathSegList.getItem(0).x, 40);
+shouldBe(path.pathSegList.getItem(0).y, 40);
+}
+
+function sample2() {
+shouldBeCloseEnough(path.pathSegList.getItem(0).x, 20, 0.01);
+
[webkit-changes] [90583] trunk/Tools
Title: [90583] trunk/Tools
Revision 90583
Author aro...@apple.com
Date 2011-07-07 11:47:22 -0700 (Thu, 07 Jul 2011)
Log Message
Make Term/ReadKey.pm an optional dependency of commit-log-editor
When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
Fixes http://webkit.org/b/64113 REGRESSION (r90564):
webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
Term/ReadKey.pm module
Reviewed by Xan Lopez.
* Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
that existing commit messages will be preserved. (Users can manually remove existing commit
messages using git-reset.)
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/commit-log-editor
Diff
Modified: trunk/Tools/ChangeLog (90582 => 90583)
--- trunk/Tools/ChangeLog 2011-07-07 18:43:44 UTC (rev 90582)
+++ trunk/Tools/ChangeLog 2011-07-07 18:47:22 UTC (rev 90583)
@@ -1,5 +1,22 @@
2011-07-07 Adam Roben aro...@apple.com
+Make Term/ReadKey.pm an optional dependency of commit-log-editor
+
+When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
+
+Fixes http://webkit.org/b/64113 REGRESSION (r90564):
+webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
+Term/ReadKey.pm module
+
+Reviewed by Xan Lopez.
+
+* Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
+Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
+that existing commit messages will be preserved. (Users can manually remove existing commit
+messages using git-reset.)
+
+2011-07-07 Adam Roben aro...@apple.com
+
Keep testing that commit messages containing Unicode are handled properly by webkitpy
Fixes http://webkit.org/b/64109 REGRESSION (r90571): test-webkitpy no longer tests that we
Modified: trunk/Tools/Scripts/commit-log-editor (90582 => 90583)
--- trunk/Tools/Scripts/commit-log-editor 2011-07-07 18:43:44 UTC (rev 90582)
+++ trunk/Tools/Scripts/commit-log-editor 2011-07-07 18:47:22 UTC (rev 90583)
@@ -34,8 +34,8 @@
use File::Basename;
use File::Spec;
use FindBin;
+use Module::Load::Conditional qw(can_load);
use lib $FindBin::Bin;
-use Term::ReadKey;
use VCSUtils;
use webkitdirs;
@@ -157,11 +157,11 @@
$endl = $1 if $logContents =~ /(\r?\n)/;
my $keepExistingLog = 1;
-if ($regenerateLog $existingLog scalar(@changeLogs) 0) {
+if ($regenerateLog $existingLog scalar(@changeLogs) 0 can_load(modules={ 'Term::ReadKey'=undef })) {
print Existing log message detected, Use 'r' to regenerate log message from ChangeLogs, or any other key to keep the existing message.\n;
-ReadMode('cbreak');
-my $key = ReadKey(0);
-ReadMode('normal');
+Term::ReadKey::ReadMode('cbreak');
+my $key = Term::ReadKey::ReadKey(0);
+Term::ReadKey::ReadMode('normal');
$keepExistingLog = 0 if ($key eq r);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90584] trunk/Tools
Title: [90584] trunk/Tools
Revision 90584
Author aro...@apple.com
Date 2011-07-07 12:13:46 -0700 (Thu, 07 Jul 2011)
Log Message
Make Checkout use SCM's Executive instead of conjuring up its own
This will improve integration with the rest of webkitpy, particularly when invoked via
webkit-patch.
Fixes http://webkit.org/b/64115 REGRESSION (r90564): webkitpy's Checkout class uses
Executive inappropriately
Reviewed by Adam Barth.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
our own use. SCM might have some super-special Executive that it uses under the covers, and
we want to use it, too!
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
method to call through to Executive.run_command.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py
trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90583 => 90584)
--- trunk/Tools/ChangeLog 2011-07-07 18:47:22 UTC (rev 90583)
+++ trunk/Tools/ChangeLog 2011-07-07 19:13:46 UTC (rev 90584)
@@ -1,5 +1,26 @@
2011-07-07 Adam Roben aro...@apple.com
+Make Checkout use SCM's Executive instead of conjuring up its own
+
+This will improve integration with the rest of webkitpy, particularly when invoked via
+webkit-patch.
+
+Fixes http://webkit.org/b/64115 REGRESSION (r90564): webkitpy's Checkout class uses
+Executive inappropriately
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/checkout/checkout.py:
+(Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
+our own use. SCM might have some super-special Executive that it uses under the covers, and
+we want to use it, too!
+
+* Scripts/webkitpy/common/checkout/checkout_unittest.py:
+(CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
+method to call through to Executive.run_command.
+
+2011-07-07 Adam Roben aro...@apple.com
+
Make Term/ReadKey.pm an optional dependency of commit-log-editor
When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py (90583 => 90584)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2011-07-07 18:47:22 UTC (rev 90583)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout.py 2011-07-07 19:13:46 UTC (rev 90584)
@@ -35,7 +35,7 @@
from webkitpy.common.checkout.scm import CommitMessage
from webkitpy.common.checkout.deps import DEPS
from webkitpy.common.memoized import memoized
-from webkitpy.common.system.executive import Executive, run_command, ScriptError
+from webkitpy.common.system.executive import run_command, ScriptError
from webkitpy.common.system.deprecated_logging import log
@@ -120,7 +120,7 @@
raise ScriptError(message=Found no modified ChangeLogs, cannot create a commit message.\n
All changes require a ChangeLog. See:\n %s % urls.contribution_guidelines)
-message_text = Executive().run_command([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
+message_text = self._scm.run([self._scm.script_path('commit-log-editor'), '--print-log'] + changelog_paths, return_stderr=False)
return CommitMessage(message_text.splitlines())
def recent_commit_infos_for_files(self, paths):
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py (90583 => 90584)
--- trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 18:47:22 UTC (rev 90583)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py 2011-07-07 19:13:46 UTC (rev 90584)
@@ -37,7 +37,7 @@
from .checkout import Checkout
from .changelog import ChangeLogEntry
from .scm import detect_scm_system, CommitMessage
-from webkitpy.common.system.executive import ScriptError
+from webkitpy.common.system.executive import Executive, ScriptError
from webkitpy.thirdparty.mock import Mock
@@ -121,9 +121,15 @@
def test_commit_message_for_this_commit(self):
scm = Mock()
+def mock_run(*args, **kwargs):
+# Note that we use a real Executive here, not a MockExecutive, so we can test that we're
+# invoking commit-log-editor correctly.
+return Executive().run_command(*args, **kwargs)
+
def mock_script_path(script):
return os.path.abspath(os.path.join(os.path.dirname(__file__), '..', '..', '..', script))
+scm.run = mock_run
scm.script_path = mock_script_path
checkout = Checkout(scm)
___
webkit-changes mailing
[webkit-changes] [90585] trunk/Source/WebCore
Title: [90585] trunk/Source/WebCore Revision 90585 Author k...@webkit.org Date 2011-07-07 13:17:00 -0700 (Thu, 07 Jul 2011) Log Message 2011-07-07 Dirk Schulze k...@webkit.org SVGAnimateTransform does not support calcMode=discrete https://bugs.webkit.org/show_bug.cgi?id=63914 Reviewed by Rob Buis. CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation. Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation, we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on all other animations as well as on other SVG viewers. Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104. * manual-tests/svg-animateTransform-calcMode-discrete.svg: Added. * svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::calculateAnimatedValue): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp Added Paths trunk/Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg Diff Modified: trunk/Source/WebCore/ChangeLog (90584 => 90585) --- trunk/Source/WebCore/ChangeLog 2011-07-07 19:13:46 UTC (rev 90584) +++ trunk/Source/WebCore/ChangeLog 2011-07-07 20:17:00 UTC (rev 90585) @@ -1,7 +1,25 @@ 2011-07-07 Dirk Schulze k...@webkit.org +SVGAnimateTransform does not support calcMode=discrete +https://bugs.webkit.org/show_bug.cgi?id=63914 + Reviewed by Rob Buis. +CalcMode discrete specifies that the animation function will jump from one value to the next without any interpolation. +Implemented calcMode discrete by checking current progress of animation. If we are in the first half of the animation, +we use the start value of the aniamtion, end value for the second half of the animation. The key time at 50% is used on +all other animations as well as on other SVG viewers. + +Added a manual test. DRT crashes on an automated test with the SVG animation API. Opened a new bug report: 64104. + +* manual-tests/svg-animateTransform-calcMode-discrete.svg: Added. +* svg/SVGAnimateTransformElement.cpp: +(WebCore::SVGAnimateTransformElement::calculateAnimatedValue): + +2011-07-07 Dirk Schulze k...@webkit.org + +Reviewed by Rob Buis. + SVGAnimatedPath needs fallback for 'by' animation https://bugs.webkit.org/show_bug.cgi?id=63865 Added: trunk/Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg (0 => 90585) --- trunk/Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg (rev 0) +++ trunk/Source/WebCore/manual-tests/svg-animateTransform-calcMode-discrete.svg 2011-07-07 20:17:00 UTC (rev 90585) @@ -0,0 +1,6 @@ +svg xmlns=http://www.w3.org/2000/svg +text x=10 y=20Testing calcMode=discrete for lt;animateTransformgt;. The rect should jump by 100px at 2s./text +rect y=30 width=100px height=100px fill=green +animateTransform attributeName=transform type=translate from=0,0 to=100,0 calcMode=discrete fill=freeze dur=4s/ +/rect +/svg Modified: trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp (90584 => 90585) --- trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp 2011-07-07 19:13:46 UTC (rev 90584) +++ trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp 2011-07-07 20:17:00 UTC (rev 90585) @@ -158,6 +158,9 @@ return; SVGTransformList* transformList = transformListFor(targetElement); ASSERT(transformList); + +if (calcMode() == CalcModeDiscrete) +percentage = percentage 0.5 ? 0 : 1; if (!isAdditive()) transformList-clear(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90587] trunk/Source/WebCore
Title: [90587] trunk/Source/WebCore
Revision 90587
Author e...@google.com
Date 2011-07-07 13:37:44 -0700 (Thu, 07 Jul 2011)
Log Message
[chromium] Fix crash when compositing gets disabled mid-paint
https://bugs.webkit.org/show_bug.cgi?id=64119
Reviewed by James Robinson.
WebKit paint can disable compositing and call setRootLayer(0). Adding
a check for this in drawLayers prevents a null pointer deref.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayers):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90586 => 90587)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 20:26:19 UTC (rev 90586)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 20:37:44 UTC (rev 90587)
@@ -1,3 +1,16 @@
+2011-07-07 Adrienne Walker e...@google.com
+
+[chromium] Fix crash when compositing gets disabled mid-paint
+https://bugs.webkit.org/show_bug.cgi?id=64119
+
+Reviewed by James Robinson.
+
+WebKit paint can disable compositing and call setRootLayer(0). Adding
+a check for this in drawLayers prevents a null pointer deref.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::drawLayers):
+
2011-07-07 Dirk Schulze k...@webkit.org
SVGAnimateTransform does not support calcMode=discrete
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (90586 => 90587)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-07 20:26:19 UTC (rev 90586)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-07 20:37:44 UTC (rev 90587)
@@ -480,7 +480,7 @@
void LayerRendererChromium::drawLayers(const LayerList renderSurfaceLayerList)
{
-if (m_viewportVisibleRect.isEmpty())
+if (m_viewportVisibleRect.isEmpty() || !m_rootLayer)
return;
TRACE_EVENT(LayerRendererChromium::drawLayers, this, 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90588] trunk/Source/WebCore
Title: [90588] trunk/Source/WebCore
Revision 90588
Author commit-qu...@webkit.org
Date 2011-07-07 13:45:10 -0700 (Thu, 07 Jul 2011)
Log Message
Unreviewed, rolling out r90581.
http://trac.webkit.org/changeset/90581
https://bugs.webkit.org/show_bug.cgi?id=64124
Broke a bunch of inspector tests (Requested by ojan on
#webkit).
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.Panels.prototype.create):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
(WebInspector.injectedExtensionAPI.expandURL):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
(WebInspector.ExtensionServer.prototype._addExtensions):
(WebInspector.ExtensionServer.prototype._onWindowMessage):
(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (90587 => 90588)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 20:37:44 UTC (rev 90587)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 20:45:10 UTC (rev 90588)
@@ -1,3 +1,26 @@
+2011-07-07 Adam Barth aba...@webkit.org
+
+Unreviewed, rolling out r90581.
+http://trac.webkit.org/changeset/90581
+https://bugs.webkit.org/show_bug.cgi?id=64124
+
+Broke a bunch of inspector tests (Requested by ojan on
+#webkit).
+
+* inspector/front-end/ExtensionAPI.js:
+(WebInspector.injectedExtensionAPI.Panels.prototype.create):
+(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setPage):
+(WebInspector.injectedExtensionAPI.expandURL):
+* inspector/front-end/ExtensionPanel.js:
+(WebInspector.ExtensionPanel):
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer):
+(WebInspector.ExtensionServer.prototype._onCreatePanel):
+(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
+(WebInspector.ExtensionServer.prototype._addExtensions):
+(WebInspector.ExtensionServer.prototype._onWindowMessage):
+(WebInspector.ExtensionServer.prototype._registerSubscriptionHandler):
+
2011-07-07 Adrienne Walker e...@google.com
[chromium] Fix crash when compositing gets disabled mid-paint
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (90587 => 90588)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-07 20:37:44 UTC (rev 90587)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2011-07-07 20:45:10 UTC (rev 90588)
@@ -167,15 +167,15 @@
}
Panels.prototype = {
-create: function(title, icon, page, callback)
+create: function(title, iconURL, pageURL, callback)
{
var id = extension-panel- + extensionServer.nextObjectId();
var request = {
command: createPanel,
id: id,
title: title,
-icon: icon,
-page: page
+icon: expandURL(iconURL),
+url: expandURL(pageURL)
};
extensionServer.sendRequest(request, callback bind(callback, this, new ExtensionPanel(id)));
}
@@ -248,9 +248,9 @@
extensionServer.sendRequest({ command: setSidebarContent, id: this._id, _expression_: jsonObject, rootTitle: rootTitle });
},
-setPage: function(page)
+setPage: function(url)
{
-extensionServer.sendRequest({ command: setSidebarPage, id: this._id, page: page });
+extensionServer.sendRequest({ command: setSidebarPage, id: this._id, url: expandURL(url) });
}
}
@@ -440,6 +440,18 @@
}
}
+function expandURL(url)
+{
+if (!url)
+return url;
+if (/^[^/]+:/.exec(url)) // See if url has schema.
+return url;
+var baseURL = location.protocol + // + location.hostname + location.port;
+if (/^\//.exec(url))
+return baseURL + url;
+return baseURL + location.pathname.replace(/\/[^/]*$/,/) + url;
+}
+
function bind(func, thisObject)
{
var args = Array.prototype.slice.call(arguments, 2);
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js (90587 => 90588)
--- trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2011-07-07 20:37:44 UTC (rev 90587)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js 2011-07-07 20:45:10 UTC (rev 90588)
@@ -31,8 +31,7 @@
WebInspector.ExtensionPanel = function(id, label, iconURL, options)
{
this.toolbarItemLabel = label;
-if (iconURL)
-this._addStyleRule(.toolbar-item. + id + .toolbar-icon, background-image: url( + iconURL + ););
+
[webkit-changes] [90589] trunk/Source/WebCore
Title: [90589] trunk/Source/WebCore
Revision 90589
Author e...@google.com
Date 2011-07-07 14:06:58 -0700 (Thu, 07 Jul 2011)
Log Message
[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
https://bugs.webkit.org/show_bug.cgi?id=64052
Reviewed by James Robinson.
Layers and surfaces that are entirely transparent are now skipped.
Parent scissor rects are now applied to the content rect of surfaces
so that offscreen surfaces can be skipped.
Landing this for vange...@chromium.org.
Covered by existing tests.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::calculateVisibleRect):
(WebCore::calculateVisibleLayerRect):
(WebCore::LayerRendererChromium::paintLayerContents):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
(WebCore::LayerRendererChromium::updateCompositorResources):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90588 => 90589)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 20:45:10 UTC (rev 90588)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 21:06:58 UTC (rev 90589)
@@ -1,3 +1,29 @@
+2011-07-06 Adrienne Walker e...@google.com
+
+[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
+https://bugs.webkit.org/show_bug.cgi?id=64052
+
+Reviewed by James Robinson.
+
+Layers and surfaces that are entirely transparent are now skipped.
+Parent scissor rects are now applied to the content rect of surfaces
+so that offscreen surfaces can be skipped.
+
+Landing this for vange...@chromium.org.
+
+Covered by existing tests.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::calculateVisibleRect):
+(WebCore::calculateVisibleLayerRect):
+(WebCore::LayerRendererChromium::paintLayerContents):
+(WebCore::LayerRendererChromium::drawLayers):
+(WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
+(WebCore::LayerRendererChromium::updateCompositorResources):
+(WebCore::LayerRendererChromium::drawLayer):
+* platform/graphics/chromium/RenderSurfaceChromium.cpp:
+(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
+
2011-07-07 Adam Barth aba...@webkit.org
Unreviewed, rolling out r90581.
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (90588 => 90589)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-07 20:45:10 UTC (rev 90588)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-07-07 21:06:58 UTC (rev 90589)
@@ -373,18 +373,8 @@
updateCompositorResources(renderSurfaceLayerList);
}
-static IntRect calculateVisibleLayerRect(const IntRect targetSurfaceRect, const IntSize bounds, const IntSize contentBounds, const TransformationMatrix tilingTransform)
+static IntRect calculateVisibleRect(const IntRect targetSurfaceRect, const IntRect layerBoundRect, const TransformationMatrix transform)
{
-if (targetSurfaceRect.isEmpty() || contentBounds.isEmpty())
-return targetSurfaceRect;
-
-const IntRect layerBoundRect = IntRect(IntPoint(), contentBounds);
-TransformationMatrix transform = tilingTransform;
-
-transform.scaleNonUniform(bounds.width() / static_castdouble(contentBounds.width()),
- bounds.height() / static_castdouble(contentBounds.height()));
-transform.translate(-contentBounds.width() / 2.0, -contentBounds.height() / 2.0);
-
// Is this layer fully contained within the target surface?
IntRect layerInSurfaceSpace = transform.mapRect(layerBoundRect);
if (targetSurfaceRect.contains(layerInSurfaceSpace))
@@ -406,6 +396,21 @@
return layerRect;
}
+static IntRect calculateVisibleLayerRect(const IntRect targetSurfaceRect, const IntSize bounds, const IntSize contentBounds, const TransformationMatrix tilingTransform)
+{
+if (targetSurfaceRect.isEmpty() || contentBounds.isEmpty())
+return targetSurfaceRect;
+
+const IntRect layerBoundRect = IntRect(IntPoint(), contentBounds);
+TransformationMatrix transform = tilingTransform;
+
+transform.scaleNonUniform(bounds.width() / static_castdouble(contentBounds.width()),
+ bounds.height() / static_castdouble(contentBounds.height()));
+transform.translate(-contentBounds.width() / 2.0, -contentBounds.height() / 2.0);
+
+return calculateVisibleRect(targetSurfaceRect, layerBoundRect, transform);
+}
+
static void
[webkit-changes] [90590] trunk/Source/WebCore
Title: [90590] trunk/Source/WebCore
Revision 90590
Author e...@chromium.org
Date 2011-07-07 14:16:15 -0700 (Thu, 07 Jul 2011)
Log Message
Switch addFocusRingRects to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64114
Reviewed by Eric Seidel.
No new tests, no functionality changes.
* rendering/LayoutTypes.h:
(WebCore::flooredLayoutPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addFocusRingRects):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::addFocusRingRects):
* rendering/RenderBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addFocusRingRects):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
* rendering/RenderListBox.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::addFocusRingRects):
* rendering/RenderTextControl.h:
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addFocusRingRects):
* rendering/svg/RenderSVGContainer.h:
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::addFocusRingRects):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::addFocusRingRects):
* rendering/svg/RenderSVGPath.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/LayoutTypes.h
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderTextControl.cpp
trunk/Source/WebCore/rendering/RenderTextControl.h
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGContainer.h
trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGImage.h
trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGPath.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (90589 => 90590)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 21:06:58 UTC (rev 90589)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 21:16:15 UTC (rev 90590)
@@ -1,3 +1,41 @@
+2011-07-07 Emil A Eklund e...@chromium.org
+
+Switch addFocusRingRects to to new layout types
+https://bugs.webkit.org/show_bug.cgi?id=64114
+
+Reviewed by Eric Seidel.
+
+No new tests, no functionality changes.
+
+* rendering/LayoutTypes.h:
+(WebCore::flooredLayoutPoint):
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::addFocusRingRects):
+* rendering/RenderBlock.h:
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::addFocusRingRects):
+* rendering/RenderBox.h:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::addFocusRingRects):
+* rendering/RenderInline.h:
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::addFocusRingRects):
+* rendering/RenderListBox.h:
+* rendering/RenderObject.h:
+(WebCore::RenderObject::addFocusRingRects):
+* rendering/RenderTextControl.cpp:
+(WebCore::RenderTextControl::addFocusRingRects):
+* rendering/RenderTextControl.h:
+* rendering/svg/RenderSVGContainer.cpp:
+(WebCore::RenderSVGContainer::addFocusRingRects):
+* rendering/svg/RenderSVGContainer.h:
+* rendering/svg/RenderSVGImage.cpp:
+(WebCore::RenderSVGImage::addFocusRingRects):
+* rendering/svg/RenderSVGImage.h:
+* rendering/svg/RenderSVGPath.cpp:
+(WebCore::RenderSVGPath::addFocusRingRects):
+* rendering/svg/RenderSVGPath.h:
+
2011-07-06 Adrienne Walker e...@google.com
[chromium] Reduce compositor texture memory by skipping layers and clipping surfaces
Modified: trunk/Source/WebCore/rendering/LayoutTypes.h (90589 => 90590)
--- trunk/Source/WebCore/rendering/LayoutTypes.h 2011-07-07 21:06:58 UTC (rev 90589)
+++ trunk/Source/WebCore/rendering/LayoutTypes.h 2011-07-07 21:16:15 UTC (rev 90590)
@@ -62,6 +62,11 @@
return flooredIntPoint(p);
}
+inline LayoutPoint flooredLayoutPoint(const FloatSize s)
+{
+return flooredIntPoint(s);
+}
+
inline LayoutUnit roundedLayoutUnit(float value)
{
return lroundf(value);
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (90589 => 90590)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-07 21:06:58 UTC (rev 90589)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-07 21:16:15 UTC (rev 90590)
@@ -5884,7 +5884,7 @@
return IntRect(x, y, caretWidth, height);
}
-void RenderBlock::addFocusRingRects(VectorIntRect rects, const
[webkit-changes] [90593] trunk/LayoutTests
Title: [90593] trunk/LayoutTests Revision 90593 Author o...@chromium.org Date 2011-07-07 15:09:50 -0700 (Thu, 07 Jul 2011) Log Message Patch by Jeff Timanus t...@chromium.org on 2011-07-07 Reviewed by Stephen White. Mark layout tests as failing in Chromium after skia roll r1799:r1814 https://bugs.webkit.org/show_bug.cgi?id=64121 * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90592 => 90593) --- trunk/LayoutTests/ChangeLog 2011-07-07 22:09:36 UTC (rev 90592) +++ trunk/LayoutTests/ChangeLog 2011-07-07 22:09:50 UTC (rev 90593) @@ -1,3 +1,12 @@ +2011-07-07 Jeff Timanus t...@chromium.org + +Reviewed by Stephen White. + +Mark layout tests as failing in Chromium after skia roll r1799:r1814 +https://bugs.webkit.org/show_bug.cgi?id=64121 + +* platform/chromium/test_expectations.txt: + 2011-07-07 Dirk Schulze k...@webkit.org Reviewed by Rob Buis. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90592 => 90593) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-07 22:09:36 UTC (rev 90592) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-07 22:09:50 UTC (rev 90593) @@ -1054,6 +1054,10 @@ BUGCR87292 DEBUG GPU : fast/canvas/canvas-large-dimensions.html = CRASH TIMEOUT +// Started failing in skia roll r1799:r1814 +BUGCR88681 WIN LINUX GPU : fast/canvas/canvas-empty-image-pattern.html = IMAGE + + // - // Other failures // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90592] trunk/Source/WebCore
Title: [90592] trunk/Source/WebCore
Revision 90592
Author commit-qu...@webkit.org
Date 2011-07-07 15:09:36 -0700 (Thu, 07 Jul 2011)
Log Message
Patch by James Robinson jam...@chromium.org on 2011-07-07
Reviewed by Kenneth Russell.
Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=42912
This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
garbage collection heuristics can account for the memory held by these objects. On the new test page, this
reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to 300MB.
Test: WebCore/manual-tests/array-buffer-memory.html
* html/canvas/ArrayBuffer.cpp:
(WebCore::ArrayBuffer::~ArrayBuffer):
(WebCore::ArrayBuffer::tryAllocate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp
Added Paths
trunk/Source/WebCore/manual-tests/array-buffer-memory.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (90591 => 90592)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 21:37:26 UTC (rev 90591)
+++ trunk/Source/WebCore/ChangeLog 2011-07-07 22:09:36 UTC (rev 90592)
@@ -1,3 +1,20 @@
+2011-07-07 James Robinson jam...@chromium.org
+
+Reviewed by Kenneth Russell.
+
+Use v8::AdjustAmountOfExternalAllocatedMemory for ArrayBuffers
+https://bugs.webkit.org/show_bug.cgi?id=42912
+
+This calls v8's AdjustAmountOfExternalAllocatedMemory when ArrayBuffers are allocated/deallocated so that V8's
+garbage collection heuristics can account for the memory held by these objects. On the new test page, this
+reduces the peak memory use from 5BG+ (or a crash in 32-bit systems) to 300MB.
+
+Test: WebCore/manual-tests/array-buffer-memory.html
+
+* html/canvas/ArrayBuffer.cpp:
+(WebCore::ArrayBuffer::~ArrayBuffer):
+(WebCore::ArrayBuffer::tryAllocate):
+
2011-07-07 Ryosuke Niwa rn...@webkit.org
Move all code related to cachedSelection to HTMLTextFormControlElement
Modified: trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp (90591 => 90592)
--- trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp 2011-07-07 21:37:26 UTC (rev 90591)
+++ trunk/Source/WebCore/html/canvas/ArrayBuffer.cpp 2011-07-07 22:09:36 UTC (rev 90592)
@@ -26,6 +26,10 @@
#include config.h
#include ArrayBuffer.h
+#if USE(V8)
+#include V8Binding.h
+#endif
+
#include wtf/RefPtr.h
namespace WebCore {
@@ -76,6 +80,9 @@
ArrayBuffer::~ArrayBuffer()
{
+#if USE(V8)
+v8::V8::AdjustAmountOfExternalAllocatedMemory(-m_sizeInBytes);
+#endif
WTF::fastFree(m_data);
}
@@ -91,8 +98,12 @@
if (totalSize / numElements != elementByteSize)
return 0;
}
-if (WTF::tryFastCalloc(numElements, elementByteSize).getValue(result))
+if (WTF::tryFastCalloc(numElements, elementByteSize).getValue(result)) {
+#if USE(V8)
+v8::V8::AdjustAmountOfExternalAllocatedMemory(numElements * elementByteSize);
+#endif
return result;
+}
return 0;
}
Added: trunk/Source/WebCore/manual-tests/array-buffer-memory.html (0 => 90592)
--- trunk/Source/WebCore/manual-tests/array-buffer-memory.html (rev 0)
+++ trunk/Source/WebCore/manual-tests/array-buffer-memory.html 2011-07-07 22:09:36 UTC (rev 90592)
@@ -0,0 +1,18 @@
+html
+head
+titleArrayBuffer memory test/title
+/head
+body
+Test creating many ArrayBuffers. The page should fully load without crashing and without using more than ~300mb of ram.
+script
+
+function allocateLargeBuffer() {
+var arrayBuffer = new ArrayBuffer(64*1024*1024);
+}
+
+for (var i=0; i96; ++i)
+allocateLargeBuffer();
+/script
+
+/body
+/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90594] trunk/Tools
Title: [90594] trunk/Tools
Revision 90594
Author aro...@apple.com
Date 2011-07-07 15:20:21 -0700 (Thu, 07 Jul 2011)
Log Message
Update TestFailures's title and header immediately upon navigation
Fixes http://webkit.org/b/64125 TestFailures page seems slow to react on link clicks
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
title.
(ViewController.prototype._displayBuilder): Set the page's title and clear out any old
content immediately instead of waiting for the first set of results for the history
analyzer. As we receive new results from the analyzer we'll just clear out the main content
area and replace it with the new info.
(ViewController.prototype._displayTesters): Set the page's title and clear out any old
content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
in a little use of our removeAllChildren helper, too.
(ViewController.prototype._setTitle): Added. Set's the page's title and the header text.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (90593 => 90594)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-07 22:09:50 UTC (rev 90593)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-07 22:20:21 UTC (rev 90594)
@@ -36,6 +36,8 @@
ViewController.prototype = {
loaded: function() {
+this._header = document.createElement('h1');
+document.body.appendChild(this._header);
this._mainContentElement = document.createElement('div');
document.body.appendChild(this._mainContentElement);
document.body.appendChild(this._domForAuxiliaryUIElements());
@@ -54,7 +56,11 @@
},
_displayBuilder: function(builder) {
+this._setTitle(builder.name);
+this._mainContentElement.removeAllChildren();
+
var navigationID = this._navigationID;
+
var self = this;
(new LayoutTestHistoryAnalyzer(builder)).start(function(data, stillFetchingData) {
if (self._navigationID !== navigationID) {
@@ -99,11 +105,7 @@
item.appendChild(self._domForNewAndExistingBugs(builder, buildName, passingBuildName, failingTestNames));
});
-var header = document.createElement('h1');
-header.appendChild(document.createTextNode(builder.name));
-self._mainContentElement.innerHTML = '';
-document.title = builder.name;
-self._mainContentElement.appendChild(header);
+self._mainContentElement.removeAllChildren();
self._mainContentElement.appendChild(list);
self._mainContentElement.appendChild(self._domForPossiblyFlakyTests(builder, data.possiblyFlaky));
@@ -115,15 +117,18 @@
},
_displayTesters: function() {
-var navigationID = this._navigationID;
+this._setTitle('Testers');
+this._mainContentElement.removeAllChildren();
var list = document.createElement('ul');
+this._mainContentElement.appendChild(list);
+
var latestBuildInfos = [];
+var navigationID = this._navigationID;
function updateList() {
latestBuildInfos.sort(function(a, b) { return a.tester.name.localeCompare(b.tester.name) });
-while (list.firstChild)
-list.removeChild(list.firstChild);
+list.removeAllChildren();
latestBuildInfos.forEach(function(buildInfo) {
var link = document.createElement('a');
link.href = '' + buildInfo.tester.name;
@@ -161,10 +166,6 @@
});
});
});
-
-self._mainContentElement.innerHTML = '';
-document.title = 'Testers';
-self._mainContentElement.appendChild(list);
});
},
@@ -520,4 +521,9 @@
return result;
},
+
+_setTitle: function(title) {
+document.title = title;
+this._header.textContent = title;
+},
};
Modified: trunk/Tools/ChangeLog (90593 => 90594)
--- trunk/Tools/ChangeLog 2011-07-07 22:09:50 UTC (rev 90593)
+++ trunk/Tools/ChangeLog 2011-07-07 22:20:21 UTC (rev 90594)
@@ -1,5 +1,25 @@
2011-07-07 Adam Roben aro...@apple.com
+Update TestFailures's title and header immediately upon navigation
+
+Fixes http://webkit.org/b/64125 TestFailures page seems slow to react on link clicks
+
+Reviewed by Daniel Bates.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+(ViewController.prototype.loaded):
[webkit-changes] [90595] trunk
Title: [90595] trunk
Revision 90595
Author gav...@chromium.org
Date 2011-07-07 15:29:57 -0700 (Thu, 07 Jul 2011)
Log Message
Reviewed by Alexey Proskuryakov.
fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
https://bugs.webkit.org/show_bug.cgi?id=60097
The culprit was that CachedResource:stopLoading() was using *this
after a call to checkNotify(), which isn't kosher. This patch
uses a CachedResourceHandle to keep the CachedResource alive.
Source/WebCore:
The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
Test: fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::stopLoading):
LayoutTests:
The test is a very close copy of the eponymous
link-and-subresource-test.html, only substituting invalid
resources for the valid ones in that test. The reproduction is
timing related, and happens much more consistantly with an invalid
resource for whatever reason.
* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp
Added Paths
trunk/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html
trunk/LayoutTests/platform/chromium-linux/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (90594 => 90595)
--- trunk/LayoutTests/ChangeLog 2011-07-07 22:20:21 UTC (rev 90594)
+++ trunk/LayoutTests/ChangeLog 2011-07-07 22:29:57 UTC (rev 90595)
@@ -1,3 +1,27 @@
+2011-07-07 Gavin Peters gav...@chromium.org
+
+Reviewed by Alexey Proskuryakov.
+
+fast/dom/HTMLLinkElement/link-and-subresource-test.html is flaky on chromium debug bots
+https://bugs.webkit.org/show_bug.cgi?id=60097
+
+The culprit was that CachedResource:stopLoading() was using *this
+after a call to checkNotify(), which isn't kosher. This patch
+uses a CachedResourceHandle to keep the CachedResource alive.
+
+The test is a very close copy of the eponymous
+link-and-subresource-test.html, only substituting invalid
+resources for the valid ones in that test. The reproduction is
+timing related, and happens much more consistantly with an invalid
+resource for whatever reason.
+
+* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt: Added.
+* fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html: Added.
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+
2011-07-07 Jeff Timanus t...@chromium.org
Reviewed by Stephen White.
Added: trunk/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html (0 => 90595)
--- trunk/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html 2011-07-07 22:29:57 UTC (rev 90595)
@@ -0,0 +1,39 @@
+html
+body
+script
+function log(message)
+{
+var item = document.createElement(li);
+item.appendChild(document.createTextNode(message));
+document.getElementById(console).appendChild(item);
+}
+
+dne_error_count = 0
+
+function dne_onerror()
+{
+log(DNE_ONERROR called);
+++dne_error_count;
+if (dne_error_count == 2) {
+log(SUCCESS. Two errors.);
+layoutTestController.notifyDone();
+}
+}
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+layoutTestController.dumpResourceResponseMIMETypes();
+}
+/script
+pThis test verifies that an image which is prefetched, and which is also contained as a
+subresource of the current document can be loaded correctly as a subresource, even if the URI
+doesn't exist.
+
+pWhen this test succeeds, you will see nothing. When this test fails, you will crash or have another error.
+link rel=prefetch href="" _onerror_=dne_onerror() /
+img src="" _onerror_=dne_onerror() /
+hr
+pol id=console/ol/p
+/body/html
+
Added: trunk/LayoutTests/platform/chromium-linux/fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent-expected.txt (0 => 90595)
---
[webkit-changes] [90597] trunk/LayoutTests
Title: [90597] trunk/LayoutTests Revision 90597 Author jam...@google.com Date 2011-07-07 15:45:29 -0700 (Thu, 07 Jul 2011) Log Message [chromium] Add text baseline for spanOverlapsCanvas * platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (90596 => 90597) --- trunk/LayoutTests/ChangeLog 2011-07-07 22:37:55 UTC (rev 90596) +++ trunk/LayoutTests/ChangeLog 2011-07-07 22:45:29 UTC (rev 90597) @@ -1,3 +1,10 @@ +2011-07-07 James Robinson jam...@chromium.org + +[chromium] Add text baseline for spanOverlapsCanvas + +* platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added. +* platform/chromium/test_expectations.txt: + 2011-07-07 Gavin Peters gav...@chromium.org Reviewed by Alexey Proskuryakov. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90596 => 90597) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-07 22:37:55 UTC (rev 90596) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-07 22:45:29 UTC (rev 90597) @@ -3887,8 +3887,6 @@ // Strange scrollbar. BUGWK63115 : fast/css/font-face-in-shadow-DOM.html = PASS IMAGE+TEXT -BUGCR87217 WIN LINUX GPU : compositing/layer-creation/spanOverlapsCanvas.html = TEXT - // We now follow the ES5 spec with regards to the semantics of the receiver // given through eval to builtins (undefined). Test assumes that the global // object is given as receiver. Added: trunk/LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt (0 => 90597) --- trunk/LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt 2011-07-07 22:45:29 UTC (rev 90597) @@ -0,0 +1,20 @@ +(GraphicsLayer + (bounds 800.00 600.00) + (children 1 +(GraphicsLayer + (bounds 800.00 600.00) + (children 2 +(GraphicsLayer + (position 8.00 8.00) + (bounds 100.00 50.00) +) +(GraphicsLayer + (position 8.00 8.00) + (bounds 100.00 50.00) + (drawsContent 1) +) + ) +) + ) +) + Property changes on: trunk/LayoutTests/platform/chromium-gpu-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt ___ Added: svn:eol-style ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90601] trunk/Source/JavaScriptCore
Title: [90601] trunk/Source/_javascript_Core
Revision 90601
Author commit-qu...@webkit.org
Date 2011-07-07 16:48:39 -0700 (Thu, 07 Jul 2011)
Log Message
DFG JIT does not implement get_by_id prototype caching.
https://bugs.webkit.org/show_bug.cgi?id=64077
Patch by Filip Pizlo fpi...@apple.com on 2011-07-07
Reviewed by Gavin Barraclough.
* dfg/DFGRepatch.cpp:
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::tryCacheGetByID):
* runtime/JSObject.h:
(JSC::JSObject::addressOfPropertyAtOffset):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90600 => 90601)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-07 23:17:55 UTC (rev 90600)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-07 23:48:39 UTC (rev 90601)
@@ -1,5 +1,19 @@
2011-07-07 Filip Pizlo fpi...@apple.com
+DFG JIT does not implement get_by_id prototype caching.
+https://bugs.webkit.org/show_bug.cgi?id=64077
+
+Reviewed by Gavin Barraclough.
+
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::emitRestoreScratch):
+(JSC::DFG::linkRestoreScratch):
+(JSC::DFG::tryCacheGetByID):
+* runtime/JSObject.h:
+(JSC::JSObject::addressOfPropertyAtOffset):
+
+2011-07-07 Filip Pizlo fpi...@apple.com
+
DFG JIT method_check implementation does not link to optimized get_by_id
slow path.
https://bugs.webkit.org/show_bug.cgi?id=64073
Modified: trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp (90600 => 90601)
--- trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp 2011-07-07 23:17:55 UTC (rev 90600)
+++ trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp 2011-07-07 23:48:39 UTC (rev 90601)
@@ -56,6 +56,44 @@
repatchBuffer.repatch(stubInfo.callReturnLocation.dataLabel32AtOffset(stubInfo.u.unset.deltaCallToLoadOrStore), sizeof(JSValue) * offset);
}
+static void emitRestoreScratch(MacroAssembler stubJit, bool needToRestoreScratch, GPRReg scratchGPR, MacroAssembler::Jump success, MacroAssembler::Jump fail, MacroAssembler::Jump failureCase1, MacroAssembler::Jump failureCase2)
+{
+if (needToRestoreScratch) {
+stubJit.pop(scratchGPR);
+
+success = stubJit.jump();
+
+// link failure cases here, so we can pop scratchGPR, and then jump back.
+failureCase1.link(stubJit);
+failureCase2.link(stubJit);
+
+stubJit.pop(scratchGPR);
+
+fail = stubJit.jump();
+return;
+}
+
+success = stubJit.jump();
+}
+
+static void linkRestoreScratch(LinkBuffer patchBuffer, bool needToRestoreScratch, StructureStubInfo stubInfo, MacroAssembler::Jump success, MacroAssembler::Jump fail, MacroAssembler::Jump failureCase1, MacroAssembler::Jump failureCase2)
+{
+CodeLocationLabel slowCaseBegin = stubInfo.callReturnLocation.labelAtOffset(stubInfo.deltaCallToSlowCase);
+
+patchBuffer.link(success, stubInfo.callReturnLocation.labelAtOffset(stubInfo.deltaCallToDone));
+
+patchBuffer.link(success, stubInfo.callReturnLocation.labelAtOffset(stubInfo.deltaCallToDone));
+
+if (needToRestoreScratch) {
+patchBuffer.link(fail, slowCaseBegin);
+return;
+}
+
+// link failure cases directly back to normal path
+patchBuffer.link(failureCase1, slowCaseBegin);
+patchBuffer.link(failureCase2, slowCaseBegin);
+}
+
static bool tryCacheGetByID(ExecState* exec, JSValue baseValue, const Identifier propertyName, const PropertySlot slot, StructureStubInfo stubInfo)
{
// FIXME: Write a test that proves we need to check for recursion here just
@@ -88,35 +126,12 @@
MacroAssembler::Jump success, fail;
-if (needToRestoreScratch) {
-stubJit.pop(scratchGPR);
-
-success = stubJit.jump();
-
-// link failure cases here, so we can pop scratchGPR, and then jump back.
-failureCase1.link(stubJit);
-failureCase2.link(stubJit);
-
-stubJit.pop(scratchGPR);
-
-fail = stubJit.jump();
-} else
-success = stubJit.jump();
+emitRestoreScratch(stubJit, needToRestoreScratch, scratchGPR, success, fail, failureCase1, failureCase2);
LinkBuffer patchBuffer(*globalData, stubJit, codeBlock-executablePool());
-CodeLocationLabel slowCaseBegin = stubInfo.callReturnLocation.labelAtOffset(stubInfo.deltaCallToSlowCase);
+linkRestoreScratch(patchBuffer, needToRestoreScratch, stubInfo, success, fail, failureCase1, failureCase2);
-patchBuffer.link(success, stubInfo.callReturnLocation.labelAtOffset(stubInfo.deltaCallToDone));
-
-if (needToRestoreScratch)
-patchBuffer.link(fail, slowCaseBegin);
-
[webkit-changes] [90602] trunk/Source/JavaScriptCore
Title: [90602] trunk/Source/_javascript_Core
Revision 90602
Author commit-qu...@webkit.org
Date 2011-07-07 16:54:57 -0700 (Thu, 07 Jul 2011)
Log Message
DFG JIT does not implement op_construct.
https://bugs.webkit.org/show_bug.cgi?id=64066
Patch by Filip Pizlo fpi...@apple.com on 2011-07-07
Reviewed by Gavin Barraclough.
* dfg/DFGAliasTracker.h:
(JSC::DFG::AliasTracker::recordConstruct):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* dfg/DFGRepatch.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAliasTracker.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
trunk/Source/_javascript_Core/dfg/DFGRepatch.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90601 => 90602)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-07 23:48:39 UTC (rev 90601)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-07 23:54:57 UTC (rev 90602)
@@ -1,5 +1,30 @@
2011-07-07 Filip Pizlo fpi...@apple.com
+DFG JIT does not implement op_construct.
+https://bugs.webkit.org/show_bug.cgi?id=64066
+
+Reviewed by Gavin Barraclough.
+
+* dfg/DFGAliasTracker.h:
+(JSC::DFG::AliasTracker::recordConstruct):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::addCall):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::emitCall):
+* dfg/DFGNode.h:
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::compile):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::dfgLinkFor):
+* dfg/DFGRepatch.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
+2011-07-07 Filip Pizlo fpi...@apple.com
+
DFG JIT does not implement get_by_id prototype caching.
https://bugs.webkit.org/show_bug.cgi?id=64077
Modified: trunk/Source/_javascript_Core/dfg/DFGAliasTracker.h (90601 => 90602)
--- trunk/Source/_javascript_Core/dfg/DFGAliasTracker.h 2011-07-07 23:48:39 UTC (rev 90601)
+++ trunk/Source/_javascript_Core/dfg/DFGAliasTracker.h 2011-07-07 23:54:57 UTC (rev 90602)
@@ -107,6 +107,12 @@
m_candidateAliasGetByVal = NoNode;
}
+void recordConstruct(NodeIndex construct)
+{
+ASSERT_UNUSED(construct, m_graph[construct].op == Construct);
+m_candidateAliasGetByVal = NoNode;
+}
+
private:
// This method returns true for arguments:
// - (X, X)
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (90601 => 90602)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-07-07 23:48:39 UTC (rev 90601)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-07-07 23:54:57 UTC (rev 90602)
@@ -411,6 +411,23 @@
m_graph.m_varArgChildren.append(child);
m_numPassedVarArgs++;
}
+
+NodeIndex addCall(Interpreter* interpreter, Instruction* currentInstruction, NodeType op)
+{
+addVarArgChild(get(currentInstruction[1].u.operand));
+int argCount = currentInstruction[2].u.operand;
+int registerOffset = currentInstruction[3].u.operand;
+int firstArg = registerOffset - argCount - RegisterFile::CallFrameHeaderSize;
+for (int argIdx = firstArg; argIdx firstArg + argCount; argIdx++)
+addVarArgChild(get(argIdx));
+NodeIndex call = addToGraph(Node::VarArg, op);
+Instruction* putInstruction = currentInstruction + OPCODE_LENGTH(op_call);
+if (interpreter-getOpcodeID(putInstruction-u.opcode) == op_call_put_result)
+set(putInstruction[1].u.operand, call);
+if (RegisterFile::CallFrameHeaderSize + (unsigned)argCount m_parameterSlots)
+m_parameterSlots = RegisterFile::CallFrameHeaderSize + argCount;
+return call;
+}
void predictArray(NodeIndex nodeIndex)
{
@@ -1101,27 +1118,18 @@
}
case op_call: {
-addVarArgChild(get(currentInstruction[1].u.operand));
-int argCount = currentInstruction[2].u.operand;
-int registerOffset = currentInstruction[3].u.operand;
-
[webkit-changes] [90603] trunk/Source/WebCore
Title: [90603] trunk/Source/WebCore
Revision 90603
Author e...@chromium.org
Date 2011-07-07 17:17:24 -0700 (Thu, 07 Jul 2011)
Log Message
Switch HitTestResult to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=64131
Reviewed by Eric Seidel.
No new tests, no functionality changes.
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::localPoint):
* page/MouseEventWithHitTestResults.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::rectForPoint):
* rendering/HitTestResult.h:
(WebCore::HitTestResult::point):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setPoint):
(WebCore::HitTestResult::setLocalPoint):
(WebCore::HitTestResult::rectForPoint):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/MouseEventWithHitTestResults.cpp
trunk/Source/WebCore/page/MouseEventWithHitTestResults.h
trunk/Source/WebCore/rendering/HitTestResult.cpp
trunk/Source/WebCore/rendering/HitTestResult.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (90602 => 90603)
--- trunk/Source/WebCore/ChangeLog 2011-07-07 23:54:57 UTC (rev 90602)
+++ trunk/Source/WebCore/ChangeLog 2011-07-08 00:17:24 UTC (rev 90603)
@@ -1,3 +1,26 @@
+2011-07-07 Emil A Eklund e...@chromium.org
+
+Switch HitTestResult to to new layout types
+https://bugs.webkit.org/show_bug.cgi?id=64131
+
+Reviewed by Eric Seidel.
+
+No new tests, no functionality changes.
+
+* page/MouseEventWithHitTestResults.cpp:
+(WebCore::MouseEventWithHitTestResults::localPoint):
+* page/MouseEventWithHitTestResults.h:
+* rendering/HitTestResult.cpp:
+(WebCore::HitTestResult::HitTestResult):
+(WebCore::HitTestResult::addNodeToRectBasedTestResult):
+(WebCore::HitTestResult::rectForPoint):
+* rendering/HitTestResult.h:
+(WebCore::HitTestResult::point):
+(WebCore::HitTestResult::localPoint):
+(WebCore::HitTestResult::setPoint):
+(WebCore::HitTestResult::setLocalPoint):
+(WebCore::HitTestResult::rectForPoint):
+
2011-07-07 Levi Weintraub le...@chromium.org
Switch remaining paint functions to new layout types
Modified: trunk/Source/WebCore/page/MouseEventWithHitTestResults.cpp (90602 => 90603)
--- trunk/Source/WebCore/page/MouseEventWithHitTestResults.cpp 2011-07-07 23:54:57 UTC (rev 90602)
+++ trunk/Source/WebCore/page/MouseEventWithHitTestResults.cpp 2011-07-08 00:17:24 UTC (rev 90603)
@@ -33,7 +33,7 @@
{
}
-const IntPoint MouseEventWithHitTestResults::localPoint() const
+const LayoutPoint MouseEventWithHitTestResults::localPoint() const
{
return m_hitTestResult.localPoint();
}
Modified: trunk/Source/WebCore/page/MouseEventWithHitTestResults.h (90602 => 90603)
--- trunk/Source/WebCore/page/MouseEventWithHitTestResults.h 2011-07-07 23:54:57 UTC (rev 90602)
+++ trunk/Source/WebCore/page/MouseEventWithHitTestResults.h 2011-07-08 00:17:24 UTC (rev 90603)
@@ -34,7 +34,7 @@
const PlatformMouseEvent event() const { return m_event; }
const HitTestResult hitTestResult() const { return m_hitTestResult; }
-const IntPoint localPoint() const;
+const LayoutPoint localPoint() const;
Scrollbar* scrollbar() const;
bool isOverLink() const;
bool isOverWidget() const { return m_hitTestResult.isOverWidget(); }
Modified: trunk/Source/WebCore/rendering/HitTestResult.cpp (90602 => 90603)
--- trunk/Source/WebCore/rendering/HitTestResult.cpp 2011-07-07 23:54:57 UTC (rev 90602)
+++ trunk/Source/WebCore/rendering/HitTestResult.cpp 2011-07-08 00:17:24 UTC (rev 90603)
@@ -55,7 +55,7 @@
{
}
-HitTestResult::HitTestResult(const IntPoint point)
+HitTestResult::HitTestResult(const LayoutPoint point)
: m_point(point)
, m_isOverWidget(false)
, m_isRectBased(false)
@@ -66,7 +66,7 @@
{
}
-HitTestResult::HitTestResult(const IntPoint centerPoint, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
+HitTestResult::HitTestResult(const LayoutPoint centerPoint, unsigned topPadding, unsigned rightPadding, unsigned bottomPadding, unsigned leftPadding)
: m_point(centerPoint)
, m_isOverWidget(false)
, m_topPadding(topPadding)
@@ -508,7 +508,7 @@
return m_innerNonSharedNode-rendererIsEditable();
}
-bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const IntPoint pointInContainer, const IntRect rect)
+bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const LayoutPoint pointInContainer, const LayoutRect rect)
{
// If it is not a rect-based hit test, this method has to be no-op.
// Return false, so the hit test stops.
@@ -539,7 +539,7 @@
return !rect.contains(rectForPoint(pointInContainer));
}
-bool HitTestResult::addNodeToRectBasedTestResult(Node* node, const IntPoint pointInContainer, const FloatRect rect)
+bool
[webkit-changes] [90604] trunk/LayoutTests
Title: [90604] trunk/LayoutTests
Revision 90604
Author yu...@chromium.org
Date 2011-07-07 17:49:40 -0700 (Thu, 07 Jul 2011)
Log Message
WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl
https://bugs.webkit.org/show_bug.cgi?id=64087
Reviewed by Kent Tamura.
* http/tests/websocket/tests/hixie76/httponly-cookie.pl:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/hixie76/httponly-cookie.pl
Diff
Modified: trunk/LayoutTests/ChangeLog (90603 => 90604)
--- trunk/LayoutTests/ChangeLog 2011-07-08 00:17:24 UTC (rev 90603)
+++ trunk/LayoutTests/ChangeLog 2011-07-08 00:49:40 UTC (rev 90604)
@@ -1,3 +1,12 @@
+2011-07-07 Yuta Kitamura yu...@chromium.org
+
+WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl
+https://bugs.webkit.org/show_bug.cgi?id=64087
+
+Reviewed by Kent Tamura.
+
+* http/tests/websocket/tests/hixie76/httponly-cookie.pl:
+
2011-07-07 James Robinson jam...@chromium.org
[chromium] Add text baseline for spanOverlapsCanvas
Modified: trunk/LayoutTests/http/tests/websocket/tests/hixie76/httponly-cookie.pl (90603 => 90604)
--- trunk/LayoutTests/http/tests/websocket/tests/hixie76/httponly-cookie.pl 2011-07-08 00:17:24 UTC (rev 90603)
+++ trunk/LayoutTests/http/tests/websocket/tests/hixie76/httponly-cookie.pl 2011-07-08 00:49:40 UTC (rev 90604)
@@ -9,17 +9,13 @@
html
head
script src=""
-script src=""
/head
body
pTest WebSocket sends HttpOnly cookies./p
pOn success, you will see a series of PASS messages, followed by TEST COMPLETE./p
div id=console/div
script
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
+window.jsTestIsAsync = true;
var cookie;
@@ -30,15 +26,6 @@
return cookie.split('; ').sort().join('; ');
}
-function endTest()
-{
-cookie = normalizeCookie(cookie);
-shouldBe(cookie, 'WK-websocket-test-httponly=1; WK-websocket-test=1');
-isSuccessfullyParsed();
-if (window.layoutTestController)
- layoutTestController.notifyDone();
-}
-
var ws = new WebSocket(ws://127.0.0.1:8880/websocket/tests/hixie76/echo-cookie);
ws._onopen_ = function() {
debug(WebSocket open);
@@ -49,11 +36,14 @@
};
ws._onclose_ = function() {
debug(WebSocket closed);
-endTest();
+cookie = normalizeCookie(cookie);
+shouldBe(cookie, 'WK-websocket-test-httponly=1; WK-websocket-test=1');
+finishJSTest();
};
var successfullyParsed = true;
/script
+script src=""
/body
/html
HTML
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90605] trunk/Tools
Title: [90605] trunk/Tools Revision 90605 Author commit-qu...@webkit.org Date 2011-07-07 18:16:07 -0700 (Thu, 07 Jul 2011) Log Message [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing https://bugs.webkit.org/show_bug.cgi?id=64107 Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-07-07 Reviewed by Kent Tamura. The pointer is later managed by BitmapContext, but it was being de-refed and deleted earlier by our RefPtr, causing crashes in all pixel tests. We now call leakRef() to make sure it is not removed when our createBitmapContextFromWebView goes out of context. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: (createBitmapContextFromWebView): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp Diff Modified: trunk/Tools/ChangeLog (90604 => 90605) --- trunk/Tools/ChangeLog 2011-07-08 00:49:40 UTC (rev 90604) +++ trunk/Tools/ChangeLog 2011-07-08 01:16:07 UTC (rev 90605) @@ -1,3 +1,20 @@ +2011-07-07 Raphael Kubo da Costa k...@profusion.mobi + +[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing +https://bugs.webkit.org/show_bug.cgi?id=64107 + +Reviewed by Kent Tamura. + +The pointer is later managed by BitmapContext, but it was being +de-refed and deleted earlier by our RefPtr, causing crashes in all +pixel tests. + +We now call leakRef() to make sure it is not removed when our +createBitmapContextFromWebView goes out of context. + +* DumpRenderTree/efl/PixelDumpSupportEfl.cpp: +(createBitmapContextFromWebView): + 2011-07-07 Adam Roben aro...@apple.com Update TestFailures's title and header immediately upon navigation Modified: trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp (90604 => 90605) --- trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp 2011-07-08 00:49:40 UTC (rev 90604) +++ trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp 2011-07-08 01:16:07 UTC (rev 90605) @@ -63,5 +63,5 @@ } } -return BitmapContext::createByAdoptingBitmapAndContext(0, context.get()); +return BitmapContext::createByAdoptingBitmapAndContext(0, context.release().leakRef()); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90606] trunk/Tools
Title: [90606] trunk/Tools
Revision 90606
Author commit-qu...@webkit.org
Date 2011-07-07 19:13:05 -0700 (Thu, 07 Jul 2011)
Log Message
[ImageDiff] Calculate/print difference right after reading baseline image.
https://bugs.webkit.org/show_bug.cgi?id=64117
Patch by Leandro Pereira lean...@profusion.mobi on 2011-07-07
Reviewed by Kent Tamura.
Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
it. Whichever happens first.
* DumpRenderTree/efl/ImageDiff.cpp:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp
Diff
Modified: trunk/Tools/ChangeLog (90605 => 90606)
--- trunk/Tools/ChangeLog 2011-07-08 01:16:07 UTC (rev 90605)
+++ trunk/Tools/ChangeLog 2011-07-08 02:13:05 UTC (rev 90606)
@@ -1,3 +1,16 @@
+2011-07-07 Leandro Pereira lean...@profusion.mobi
+
+[ImageDiff] Calculate/print difference right after reading baseline image.
+https://bugs.webkit.org/show_bug.cgi?id=64117
+
+Reviewed by Kent Tamura.
+
+Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
+it. Whichever happens first.
+
+* DumpRenderTree/efl/ImageDiff.cpp:
+(main):
+
2011-07-07 Raphael Kubo da Costa k...@profusion.mobi
[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
Modified: trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp (90605 => 90606)
--- trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-07-08 01:16:07 UTC (rev 90605)
+++ trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-07-08 02:13:05 UTC (rev 90606)
@@ -330,9 +330,9 @@
if (!actualImage)
actualImage = readImageFromStdin(evas, imageSize);
-else if (!baselineImage)
+else if (!baselineImage) {
baselineImage = readImageFromStdin(evas, imageSize);
-else {
+
printImageDifferences(baselineImage.get(), actualImage.get());
actualImage.clear();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90608] trunk/LayoutTests
Title: [90608] trunk/LayoutTests Revision 90608 Author morr...@google.com Date 2011-07-07 19:46:38 -0700 (Thu, 07 Jul 2011) Log Message dump-as-markup.js should support shadow tree https://bugs.webkit.org/show_bug.cgi?id=62447 Reviewed by Ryosuke Niwa. - Added shadow support to Markup._get() - Updated expectations caused by this change. - Added explanatory test cases for shadows. * editing/inserting/5607069-2-expected.txt: * editing/inserting/5607069-3-expected.txt: * editing/pasteboard/copy-null-characters-expected.txt: * editing/selection/dump-as-markup-expected.txt: * editing/selection/dump-as-markup-form-text-expected.txt: * fast/parser/object-with-textarea-fallback-expected.txt: * fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added. * fast/dom/HTMLMeterElement/meter-element-markup.html: Added. * fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: Added. * fast/dom/HTMLProgressElement/progress-element-markup.html: Added. * fast/dom/HTMLMeterElement/meter-element-markup.html: * fast/dom/HTMLProgressElement/progress-element-markup.html: * resources/dump-as-markup.js: (Markup._get): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/inserting/5607069-2-expected.txt trunk/LayoutTests/editing/inserting/5607069-3-expected.txt trunk/LayoutTests/editing/pasteboard/copy-null-characters-expected.txt trunk/LayoutTests/editing/selection/dump-as-markup-expected.txt trunk/LayoutTests/editing/selection/dump-as-markup-form-text-expected.txt trunk/LayoutTests/fast/parser/object-with-textarea-fallback-expected.txt trunk/LayoutTests/resources/dump-as-markup.js Added Paths trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup.html trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup-expected.txt trunk/LayoutTests/fast/dom/HTMLProgressElement/progress-element-markup.html Diff Modified: trunk/LayoutTests/ChangeLog (90607 => 90608) --- trunk/LayoutTests/ChangeLog 2011-07-08 02:22:39 UTC (rev 90607) +++ trunk/LayoutTests/ChangeLog 2011-07-08 02:46:38 UTC (rev 90608) @@ -1,3 +1,29 @@ +2011-07-07 MORITA Hajime morr...@google.com + +dump-as-markup.js should support shadow tree +https://bugs.webkit.org/show_bug.cgi?id=62447 + +Reviewed by Ryosuke Niwa. + +- Added shadow support to Markup._get() +- Updated expectations caused by this change. +- Added explanatory test cases for shadows. + +* editing/inserting/5607069-2-expected.txt: +* editing/inserting/5607069-3-expected.txt: +* editing/pasteboard/copy-null-characters-expected.txt: +* editing/selection/dump-as-markup-expected.txt: +* editing/selection/dump-as-markup-form-text-expected.txt: +* fast/parser/object-with-textarea-fallback-expected.txt: +* fast/dom/HTMLMeterElement/meter-element-markup-expected.txt: Added. +* fast/dom/HTMLMeterElement/meter-element-markup.html: Added. +* fast/dom/HTMLProgressElement/progress-element-markup-expected.txt: Added. +* fast/dom/HTMLProgressElement/progress-element-markup.html: Added. +* fast/dom/HTMLMeterElement/meter-element-markup.html: +* fast/dom/HTMLProgressElement/progress-element-markup.html: +* resources/dump-as-markup.js: +(Markup._get): + 2011-07-07 Yuta Kitamura yu...@chromium.org WebSocket: Use jsTestIsAsync and finishJSTest() in httponly-cookie.pl Modified: trunk/LayoutTests/editing/inserting/5607069-2-expected.txt (90607 => 90608) --- trunk/LayoutTests/editing/inserting/5607069-2-expected.txt 2011-07-08 02:22:39 UTC (rev 90607) +++ trunk/LayoutTests/editing/inserting/5607069-2-expected.txt 2011-07-08 02:46:38 UTC (rev 90608) @@ -2,7 +2,11 @@ | input | type=text | this.value= +| shadow:root +| div | br | input | type=text | this.value= +| shadow:root +| div Modified: trunk/LayoutTests/editing/inserting/5607069-3-expected.txt (90607 => 90608) --- trunk/LayoutTests/editing/inserting/5607069-3-expected.txt 2011-07-08 02:22:39 UTC (rev 90607) +++ trunk/LayoutTests/editing/inserting/5607069-3-expected.txt 2011-07-08 02:46:38 UTC (rev 90608) @@ -4,9 +4,13 @@ | input | type=text | this.value= +| shadow:root +| div | x | br | #selection-caretx | input | type=text | this.value= +| shadow:root +| div Modified: trunk/LayoutTests/editing/pasteboard/copy-null-characters-expected.txt (90607 => 90608) --- trunk/LayoutTests/editing/pasteboard/copy-null-characters-expected.txt 2011-07-08 02:22:39 UTC (rev 90607) +++ trunk/LayoutTests/editing/pasteboard/copy-null-characters-expected.txt 2011-07-08 02:46:38 UTC (rev 90608) @@ -40,6 +40,12 @@ Copy paste me green +| shadow:root +| div +| Copy paste mebold + +Copy paste me +green | | div Modified:
[webkit-changes] [90610] trunk/Tools
Title: [90610] trunk/Tools Revision 90610 Author kev...@webkit.org Date 2011-07-07 21:53:29 -0700 (Thu, 07 Jul 2011) Log Message [wx] Unreviewed build fix, more fixes for install name issues. Modified Paths trunk/Tools/ChangeLog trunk/Tools/wx/packaging/build-mac-installer.py Diff Modified: trunk/Tools/ChangeLog (90609 => 90610) --- trunk/Tools/ChangeLog 2011-07-08 03:53:39 UTC (rev 90609) +++ trunk/Tools/ChangeLog 2011-07-08 04:53:29 UTC (rev 90610) @@ -1,3 +1,9 @@ +2011-07-07 Kevin Ollivier kev...@theolliviers.com + +[wx] Unreviewed build fix, more fixes for install name issues. + +* wx/packaging/build-mac-installer.py: + 2011-07-07 Dirk Pranke dpra...@chromium.org test-webkitpy fails on chromium win Modified: trunk/Tools/wx/packaging/build-mac-installer.py (90609 => 90610) --- trunk/Tools/wx/packaging/build-mac-installer.py 2011-07-08 03:53:39 UTC (rev 90609) +++ trunk/Tools/wx/packaging/build-mac-installer.py 2011-07-08 04:53:29 UTC (rev 90610) @@ -92,17 +92,18 @@ output = commands.getoutput(otool -L %s % dylib).strip() for line in output.split(\n): copy = should_copy +change = True filename = line.split(()[0].strip() +filedir, basename = os.path.split(filename) +dest_filename = os.path.join(prefix, basename) if os.path.exists(filename): for sys_prefix in system_prefixes: if filename.startswith(sys_prefix): copy = False +change = False if copy: copydir = os.path.dirname(dylib) - -filedir, basename = os.path.split(filename) -dest_filename = os.path.join(prefix, basename) copyname = os.path.join(copydir, basename) if not os.path.exists(copyname): shutil.copy(filename, copydir) @@ -110,6 +111,7 @@ if result != 0: print Changing ID failed. Stopping release. sys.exit(result) +if change: print changing %s to %s % (filename, dest_filename) result = os.system(install_name_tool -change %s %s %s % (filename, dest_filename, dylib)) if result != 0: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
