[webkit-changes] [90723] trunk
Title: [90723] trunk
Revision 90723
Author commit-qu...@webkit.org
Date 2011-07-11 00:06:26 -0700 (Mon, 11 Jul 2011)
Log Message
Patch by Mustafizur Rahaman mustaf.h...@gmail.com on 2011-07-11
Reviewed by James Robinson.
Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48292
and
Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html
https://bugs.webkit.org/show_bug.cgi?id=48302
Source/WebCore:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::shouldDisplayTransparencyElsewhere): Added CompositeDestinationAtop
to draw transparency elsewhere for destination-atop
LayoutTests:
* canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt: Added
a trailing line
* fast/canvas/canvas-composite-alpha.html: Rebaselined for destination-atop test case
* platform/chromium/test_expectations.txt: Removed passing test case
* platform/gtk/Skipped: Ditto
* platform/mac/Skipped: Ditto
* platform/qt/Skipped: Ditto
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt
trunk/LayoutTests/fast/canvas/canvas-composite-alpha.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (90722 => 90723)
--- trunk/LayoutTests/ChangeLog 2011-07-11 07:03:24 UTC (rev 90722)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 07:06:26 UTC (rev 90723)
@@ -1,3 +1,23 @@
+2011-07-11 Mustafizur Rahaman mustaf.h...@gmail.com
+
+Reviewed by James Robinson.
+
+Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html
+https://bugs.webkit.org/show_bug.cgi?id=48292
+
+and
+
+Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html
+https://bugs.webkit.org/show_bug.cgi?id=48302
+
+* canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt: Added
+a trailing line
+* fast/canvas/canvas-composite-alpha.html: Rebaselined for destination-atop test case
+* platform/chromium/test_expectations.txt: Removed passing test case
+* platform/gtk/Skipped: Ditto
+* platform/mac/Skipped: Ditto
+* platform/qt/Skipped: Ditto
+
2011-07-11 James Robinson jam...@chromium.org
[chromium] Update win/linux pixel expectations for r90701 (part 9/??).
Modified: trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt (90722 => 90723)
--- trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt 2011-07-11 07:03:24 UTC (rev 90722)
+++ trunk/LayoutTests/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop-expected.txt 2011-07-11 07:06:26 UTC (rev 90723)
@@ -1 +1,2 @@
Passed
+
Modified: trunk/LayoutTests/fast/canvas/canvas-composite-alpha.html (90722 => 90723)
--- trunk/LayoutTests/fast/canvas/canvas-composite-alpha.html 2011-07-11 07:03:24 UTC (rev 90722)
+++ trunk/LayoutTests/fast/canvas/canvas-composite-alpha.html 2011-07-11 07:06:26 UTC (rev 90723)
@@ -151,21 +151,21 @@
{ source: [0, 0, 0, 0], composition: [0, 255, 255, 32], destination: [0, 255, 255, 127] }
],
[
- { source: [255, 0, 0, 255], composition: [0, 255, 0, 255], destination: [0, 255, 0, 255] },
+ { source: [255, 0, 0, 255], composition: [0, 255, 0, 255], destination: [0,0,0,0] },
{ source: [255, 0, 0, 255], composition: [255, 0, 0, 255], destination: [0, 0, 0, 0] },
- { source: [255, 0, 0, 255], composition: [254, 1, 0, 255], destination: [0, 255, 0, 1] },
- { source: [0, 0, 0, 0], composition: [0, 0, 0, 0], destination: [255, 0, 0, 255] },
- { source: [0, 255, 0, 1], composition: [255, 0, 0, 1], destination: [255, 0, 0, 255] },
- { source: [0, 0, 0, 0], composition: [0, 0, 0, 0], destination: [0, 255, 0, 255] },
- { source: [255, 0, 0, 127], composition: [126, 126, 0, 127], destination: [0, 255, 0, 127] },
- { source: [255, 0, 0, 255], composition: [128, 127, 0, 255], destination: [0, 255, 0, 127] },
- { source: [255, 0, 0, 127], composition: [0, 255, 0, 127], destination: [0, 255, 0, 255] },
- { source: [127, 0, 0, 255], composition: [63, 63, 0, 255], destination: [0, 126, 0, 127] },
- { source: [126, 0, 0, 127], composition: [0, 126, 0, 127], destination: [0, 127, 0, 255] },
- { source: [255, 0, 0, 127], composition: [255, 0, 0, 127], destination: [255, 0, 0, 63] },
-
[webkit-changes] [90728] trunk
Title: [90728] trunk Revision 90728 Author ba...@chromium.org Date 2011-07-11 01:56:20 -0700 (Mon, 11 Jul 2011) Log Message Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files https://bugs.webkit.org/show_bug.cgi?id=64248 Tools: Patch by Kenichi Ishibashi ba...@chromium.org on 2011-07-11 Reviewed by Kent Tamura. * DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto. * GNUmakefile.am: Ditto. LayoutTests: Updates test_expectations. Patch by Kenichi Ishibashi ba...@chromium.org on 2011-07-11 Reviewed by Kent Tamura. * platform/chromium/test_expectations.txt: Removed SKIP from plugins/form-value.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.gypi trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro trunk/Tools/GNUmakefile.am Diff Modified: trunk/LayoutTests/ChangeLog (90727 => 90728) --- trunk/LayoutTests/ChangeLog 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/LayoutTests/ChangeLog 2011-07-11 08:56:20 UTC (rev 90728) @@ -1,3 +1,14 @@ +2011-07-11 Kenichi Ishibashi ba...@chromium.org + +Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files +https://bugs.webkit.org/show_bug.cgi?id=64248 + +Updates test_expectations. + +Reviewed by Kent Tamura. + +* platform/chromium/test_expectations.txt: Removed SKIP from plugins/form-value.html. + 2011-07-11 James Robinson jam...@chromium.org [chromium] Update win/linux pixel expectations for r90701 (part 12/12). Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90727 => 90728) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 08:56:20 UTC (rev 90728) @@ -3977,4 +3977,4 @@ BUGWK61388 MAC GPU : platform/chromium/compositing/perpendicular-layer-sorting.html = IMAGE // Getting form value is not implemented yet. -BUGWK13061 SKIP : plugins/form-value.html = TEXT +BUGWK13061 : plugins/form-value.html = TEXT Modified: trunk/Tools/ChangeLog (90727 => 90728) --- trunk/Tools/ChangeLog 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/Tools/ChangeLog 2011-07-11 08:56:20 UTC (rev 90728) @@ -1,3 +1,15 @@ +2011-07-11 Kenichi Ishibashi ba...@chromium.org + +Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files +https://bugs.webkit.org/show_bug.cgi?id=64248 + +Reviewed by Kent Tamura. + +* DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp. +* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto. +* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto. +* GNUmakefile.am: Ditto. + 2011-07-10 Kenichi Ishibashi ba...@chromium.org Let plugins participate in form submission Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gypi (90727 => 90728) --- trunk/Tools/DumpRenderTree/DumpRenderTree.gypi 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.gypi 2011-07-11 08:56:20 UTC (rev 90728) @@ -54,6 +54,7 @@ 'TestNetscapePlugIn/TestObject.h', 'TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp', 'TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp', +'TestNetscapePlugIn/Tests/FormValue.cpp', 'TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp', 'TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp', 'TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp', Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj (90727 => 90728) --- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj 2011-07-11 08:56:20 UTC (rev 90728) @@ -402,6 +402,10 @@ /File File +RelativePath=..\Tests\FormValue.cpp + + /File + File RelativePath=..\Tests\GetURLNotifyWithURLThatFailsToLoad.cpp /File Modified: trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro (90727 => 90728) --- trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro 2011-07-11 08:11:44 UTC (rev 90727) +++ trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro 2011-07-11 08:56:20 UTC (rev 90728) @@ -31,6 +31,7 @@ main.cpp \ Tests/DocumentOpenInDestroyStream.cpp \ Tests/EvaluateJSAfterRemovingPluginElement.cpp \ + Tests/FormValue.cpp \
[webkit-changes] [90729] trunk/LayoutTests
Title: [90729] trunk/LayoutTests Revision 90729 Author abe...@webkit.org Date 2011-07-11 02:06:36 -0700 (Mon, 11 Jul 2011) Log Message [Qt] http/tests/plugins/get-url.html is crashing on the bot https://bugs.webkit.org/show_bug.cgi?id=64168 Rubber-stamped by Csaba Osztrogonác. * platform/qt/test_expectations.txt: Do not expect the test to crash any more. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90728 => 90729) --- trunk/LayoutTests/ChangeLog 2011-07-11 08:56:20 UTC (rev 90728) +++ trunk/LayoutTests/ChangeLog 2011-07-11 09:06:36 UTC (rev 90729) @@ -1,3 +1,12 @@ +2011-07-11 Andras Becsi abe...@webkit.org + +[Qt] http/tests/plugins/get-url.html is crashing on the bot +https://bugs.webkit.org/show_bug.cgi?id=64168 + +Rubber-stamped by Csaba Osztrogonác. + +* platform/qt/test_expectations.txt: Do not expect the test to crash any more. + 2011-07-11 Kenichi Ishibashi ba...@chromium.org Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (90728 => 90729) --- trunk/LayoutTests/platform/qt/test_expectations.txt 2011-07-11 08:56:20 UTC (rev 90728) +++ trunk/LayoutTests/platform/qt/test_expectations.txt 2011-07-11 09:06:36 UTC (rev 90729) @@ -71,5 +71,3 @@ BUGWK64002 : fast/workers/worker-lifecycle.html = TEXT PASS BUGWK64002 : fast/selectors/unqualified-hover-strict.html = TEXT PASS - -BUGWK64168 : http/tests/plugins/get-url.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90730] trunk/LayoutTests
Title: [90730] trunk/LayoutTests Revision 90730 Author yu...@chromium.org Date 2011-07-11 02:33:07 -0700 (Mon, 11 Jul 2011) Log Message 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90729 => 90730) --- trunk/LayoutTests/ChangeLog 2011-07-11 09:06:36 UTC (rev 90729) +++ trunk/LayoutTests/ChangeLog 2011-07-11 09:33:07 UTC (rev 90730) @@ -1,3 +1,9 @@ +2011-07-11 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update Chromium test expectations. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Andras Becsi abe...@webkit.org [Qt] http/tests/plugins/get-url.html is crashing on the bot Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90729 => 90730) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 09:06:36 UTC (rev 90729) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 09:33:07 UTC (rev 90730) @@ -3978,3 +3978,7 @@ // Getting form value is not implemented yet. BUGWK13061 : plugins/form-value.html = TEXT + +BUGCR88894 WIN SLOW : http/tests/cache/subresource-expiration-1.html = PASS +BUGCR88894 WIN SLOW : http/tests/cache/subresource-expiration-2.html = PASS +BUGWK64255 WIN : http/tests/inspector/resource-tree/resource-tree-document-url.html = PASS TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90731] trunk/Source/JavaScriptCore
Title: [90731] trunk/Source/_javascript_Core
Revision 90731
Author l...@webkit.org
Date 2011-07-11 03:31:20 -0700 (Mon, 11 Jul 2011)
Log Message
Signed arithmetic bug in dataTransfer32.
https://bugs.webkit.org/show_bug.cgi?id=64257
Reviewed by Zoltan Herczeg.
An arithmetic bug is fixed. If the offset of dataTransfer is half of the
addressable memory space on a 32-bit machine (-2147483648 = 0x8000)
a load instruction is emitted with a wrong zero offset.
Inspired by Jacob Bramley's patch from JaegerMonkey.
* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/ARMAssembler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90730 => 90731)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-11 09:33:07 UTC (rev 90730)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-11 10:31:20 UTC (rev 90731)
@@ -1,3 +1,19 @@
+2011-07-11 Gabor Loki l...@webkit.org
+
+Signed arithmetic bug in dataTransfer32.
+https://bugs.webkit.org/show_bug.cgi?id=64257
+
+Reviewed by Zoltan Herczeg.
+
+An arithmetic bug is fixed. If the offset of dataTransfer is half of the
+addressable memory space on a 32-bit machine (-2147483648 = 0x8000)
+a load instruction is emitted with a wrong zero offset.
+
+Inspired by Jacob Bramley's patch from JaegerMonkey.
+
+* assembler/ARMAssembler.cpp:
+(JSC::ARMAssembler::dataTransfer32):
+
2011-07-09 Thouraya Andolsi thouraya.ando...@st.com
Fix unaligned userspace access for SH4 platforms.
Modified: trunk/Source/_javascript_Core/assembler/ARMAssembler.cpp (90730 => 90731)
--- trunk/Source/_javascript_Core/assembler/ARMAssembler.cpp 2011-07-11 09:33:07 UTC (rev 90730)
+++ trunk/Source/_javascript_Core/assembler/ARMAssembler.cpp 2011-07-11 10:31:20 UTC (rev 90731)
@@ -276,15 +276,14 @@
dtr_ur(isLoad, srcDst, base, ARMRegisters::S0 | transferFlag);
}
} else {
-offset = -offset;
-if (offset = 0xfff)
-dtr_d(isLoad, srcDst, base, offset | transferFlag);
-else if (offset = 0xf) {
-sub_r(ARMRegisters::S0, base, OP2_IMM | (offset 12) | (10 8));
-dtr_d(isLoad, srcDst, ARMRegisters::S0, (offset 0xfff) | transferFlag);
+if (offset = -0xfff)
+dtr_d(isLoad, srcDst, base, -offset | transferFlag);
+else if (offset = -0xf) {
+sub_r(ARMRegisters::S0, base, OP2_IMM | (-offset 12) | (10 8));
+dtr_d(isLoad, srcDst, ARMRegisters::S0, (-offset 0xfff) | transferFlag);
} else {
moveImm(offset, ARMRegisters::S0);
-dtr_dr(isLoad, srcDst, base, ARMRegisters::S0 | transferFlag);
+dtr_ur(isLoad, srcDst, base, ARMRegisters::S0 | transferFlag);
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90732] trunk/LayoutTests
Title: [90732] trunk/LayoutTests Revision 90732 Author o...@webkit.org Date 2011-07-11 04:09:25 -0700 (Mon, 11 Jul 2011) Log Message [Qt][Mac] Unreviewed gardening. * platform/qt-mac/Skipped: - Remove non-existent editing tests. - Remove fast/selectors/unqualified-hover-strict.html, because it is in test_expectations.txt too. - Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it is in test_expectations.txt too. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90731 => 90732) --- trunk/LayoutTests/ChangeLog 2011-07-11 10:31:20 UTC (rev 90731) +++ trunk/LayoutTests/ChangeLog 2011-07-11 11:09:25 UTC (rev 90732) @@ -1,5 +1,14 @@ +2011-07-11 Csaba Osztrogonác o...@webkit.org + +[Qt][Mac] Unreviewed gardening. + +* platform/qt-mac/Skipped: + - Remove non-existent editing tests. + - Remove fast/selectors/unqualified-hover-strict.html, because it is in test_expectations.txt too. + - Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it is in test_expectations.txt too. + 2011-07-11 Yury Semikhatsky yu...@chromium.org - + Unreviewed. Update Chromium test expectations. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/qt-mac/Skipped (90731 => 90732) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-07-11 10:31:20 UTC (rev 90731) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-07-11 11:09:25 UTC (rev 90732) @@ -568,17 +568,12 @@ css3/css3-modsel-35.html css3/css3-modsel-36.html css3/css3-modsel-37.html -editing/deleting/4845371.html editing/deleting/4922367.html -editing/deleting/5026848-1.html -editing/deleting/5026848-2.html -editing/deleting/5026848-3.html editing/deleting/5032066.html editing/deleting/5099303.html editing/deleting/5115601.html editing/deleting/5126166.html editing/deleting/5144139-2.html -editing/deleting/5156801-2.html editing/deleting/5206311-1.html editing/deleting/5206311-2.html editing/deleting/5272440.html @@ -2366,7 +2361,6 @@ fast/selectors/lang-vs-xml-lang.html fast/selectors/nondeterministic-combinators.html fast/selectors/unqualified-hover-quirks.html -fast/selectors/unqualified-hover-strict.html fast/spatial-navigation/snav-multiple-select-focusring.html fast/spatial-navigation/snav-radio-group.html fast/spatial-navigation/snav-radio.html @@ -4586,7 +4580,6 @@ svg/custom/linking-uri-01-b.svg svg/text/text-overflow-ellipsis-svgfont.html svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm -http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm # Qt specific results committed in r90007, but fail on Qt-Mac platform svg/W3C-SVG-1.1-SE/text-tref-03-b.svg ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90733] trunk/LayoutTests
Title: [90733] trunk/LayoutTests Revision 90733 Author yu...@chromium.org Date 2011-07-11 04:17:53 -0700 (Mon, 11 Jul 2011) Log Message 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations after r90698. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90732 => 90733) --- trunk/LayoutTests/ChangeLog 2011-07-11 11:09:25 UTC (rev 90732) +++ trunk/LayoutTests/ChangeLog 2011-07-11 11:17:53 UTC (rev 90733) @@ -1,3 +1,9 @@ +2011-07-11 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update Chromium test expectations after r90698. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Csaba Osztrogonác o...@webkit.org [Qt][Mac] Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90732 => 90733) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 11:09:25 UTC (rev 90732) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 11:17:53 UTC (rev 90733) @@ -3981,4 +3981,16 @@ BUGCR88894 WIN SLOW : http/tests/cache/subresource-expiration-1.html = PASS BUGCR88894 WIN SLOW : http/tests/cache/subresource-expiration-2.html = PASS -BUGWK64255 WIN : http/tests/inspector/resource-tree/resource-tree-document-url.html = PASS TIMEOUT + +BUGCR88911 MAC : fast/css/stylesheet-candidate-nodes-crash.xhtml = PASS TEXT +BUGCR88911 MAC : fast/dom/getElementsByClassName/011.xml = PASS TEXT +BUGCR88911 MAC : fast/forms/input-number-unacceptable-style.html = PASS TEXT +BUGCR88911 MAC : fast/parser/external-entities.xml = PASS TEXT +BUGCR88911 MAC : fast/text/find-kana.html = PASS TEXT +BUGCR88911 MAC : fast/xsl/mozilla-tests.xml,svg/custom/use-invalid-pattern.svg = PASS TEXT +BUGCR88911 MAC : svg/custom/use-invalid-style.svg = PASS TEXT +BUGCR88911 MAC : fast/text/atsui-multiple-renderers.html = PASS TEXT +BUGCR88911 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = PASS TEXT +BUGCR88911 MAC : fast/invalid/missing-end-tag.xhtml = PASS TEXT +BUGCR88911 MAC : fast/parser/xhtml-alternate-entities.xml = PASS TEXT +BUGCR88911 MAC : fast/xsl/xslt-extra-content-at-end.xml = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90734] trunk/Source/WebCore
Title: [90734] trunk/Source/WebCore Revision 90734 Author pfeld...@chromium.org Date 2011-07-11 04:55:04 -0700 (Mon, 11 Jul 2011) Log Message Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location. https://bugs.webkit.org/show_bug.cgi?id=63982 Rolling out 89760, 89756, 89754, 89753 for breaking inspector highlight. Reviewed by Yury Semikhatsky. * WebCore.exp.in: * inspector/DOMNodeHighlighter.cpp: (WebCore::DOMNodeHighlighter::drawNodeHighlight): * page/FrameView.cpp: * page/FrameView.h: * platform/ScrollView.h: * platform/Widget.cpp: * platform/Widget.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): * rendering/RenderBox.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad): * rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): * rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): * rendering/RenderView.h: * rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer): * rendering/svg/RenderSVGForeignObject.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer): * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): * rendering/svg/RenderSVGText.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer): * rendering/svg/SVGRenderSupport.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/FrameView.h trunk/Source/WebCore/platform/ScrollView.h trunk/Source/WebCore/platform/Widget.cpp trunk/Source/WebCore/platform/Widget.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/RenderView.h trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInline.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp trunk/Source/WebCore/rendering/svg/SVGRenderSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (90733 => 90734) --- trunk/Source/WebCore/ChangeLog 2011-07-11 11:17:53 UTC (rev 90733) +++ trunk/Source/WebCore/ChangeLog 2011-07-11 11:55:04 UTC (rev 90734) @@ -1,3 +1,53 @@ +2011-07-11 Pavel Feldman pfeld...@google.com + +Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location. +https://bugs.webkit.org/show_bug.cgi?id=63982 + +Rolling out 89760, 89756, 89754, 89753 for breaking inspector highlight. + +Reviewed by Yury Semikhatsky. + +* WebCore.exp.in: +* inspector/DOMNodeHighlighter.cpp: +(WebCore::DOMNodeHighlighter::drawNodeHighlight): +* page/FrameView.cpp: +* page/FrameView.h: +* platform/ScrollView.h: +* platform/Widget.cpp: +* platform/Widget.h: +* rendering/RenderBox.cpp: +(WebCore::RenderBox::mapLocalToContainer): +* rendering/RenderBox.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::mapLocalToContainer): +* rendering/RenderInline.h: +* rendering/RenderObject.cpp: +(WebCore::RenderObject::mapLocalToContainer): +(WebCore::RenderObject::localToContainerQuad): +* rendering/RenderObject.h: +(WebCore::RenderObject::localToAbsoluteQuad): +* rendering/RenderView.cpp: +(WebCore::RenderView::mapLocalToContainer): +* rendering/RenderView.h: +* rendering/svg/RenderSVGForeignObject.cpp: +(WebCore::RenderSVGForeignObject::mapLocalToContainer): +* rendering/svg/RenderSVGForeignObject.h: +* rendering/svg/RenderSVGInline.cpp: +(WebCore::RenderSVGInline::mapLocalToContainer): +*
[webkit-changes] [90735] trunk/Source/WebCore
Title: [90735] trunk/Source/WebCore
Revision 90735
Author mnaga...@chromium.org
Date 2011-07-11 04:58:56 -0700 (Mon, 11 Jul 2011)
Log Message
Web Inspector: Fix resizing of sidebar pane in Timeline and Profile panels.
https://bugs.webkit.org/show_bug.cgi?id=64161
Reviewed by Pavel Feldman.
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (90734 => 90735)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 11:55:04 UTC (rev 90734)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 11:58:56 UTC (rev 90735)
@@ -1,3 +1,15 @@
+2011-07-08 Mikhail Naganov mnaga...@chromium.org
+
+Web Inspector: Fix resizing of sidebar pane in Timeline and Profile panels.
+https://bugs.webkit.org/show_bug.cgi?id=64161
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ProfilesPanel.js:
+(WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
+* inspector/front-end/TimelineOverviewPane.js:
+(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
+
2011-07-11 Pavel Feldman pfeld...@google.com
Web Inspector: [REGRESSION r89753-89754] highlight does not respect scroller location.
Modified: trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js (90734 => 90735)
--- trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-07-11 11:55:04 UTC (rev 90734)
+++ trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js 2011-07-11 11:58:56 UTC (rev 90735)
@@ -641,7 +641,8 @@
{
this.welcomeView.element.style.left = width + px;
this.profileViews.style.left = width + px;
-this.profileViewStatusBarItemsContainer.style.left = Math.max(155, width) + px;
+// Min width = number of buttons on the left * 31
+this.profileViewStatusBarItemsContainer.style.left = Math.max(6 * 31, width) + px;
this.resize();
},
Modified: trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js (90734 => 90735)
--- trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2011-07-11 11:55:04 UTC (rev 90734)
+++ trunk/Source/WebCore/inspector/front-end/TimelineOverviewPane.js 2011-07-11 11:58:56 UTC (rev 90735)
@@ -202,7 +202,8 @@
updateMainViewWidth: function(width, records)
{
this._overviewGrid.element.style.left = width + px;
-this.statusBarFilters.style.left = Math.max(155, width) + px;
+// Min width = number of buttons on the left * 31
+this.statusBarFilters.style.left = Math.max(7 * 31, width) + px;
},
reset: function()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90737] trunk/Source/WebCore
Title: [90737] trunk/Source/WebCore
Revision 90737
Author commit-qu...@webkit.org
Date 2011-07-11 05:29:38 -0700 (Mon, 11 Jul 2011)
Log Message
Added accessibility notification when value is changed.
https://bugs.webkit.org/show_bug.cgi?id=64256
Notifies the value change of range input when accessibility is enabled.
Patch by Shinya Kawanaka shin...@google.com on 2011-07-11
Reviewed by Kent Tamura.
Covered by existing tests.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
Added accessibility notification when value is changed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/RangeInputType.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90736 => 90737)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 12:21:50 UTC (rev 90736)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 12:29:38 UTC (rev 90737)
@@ -1,3 +1,18 @@
+2011-07-11 Shinya Kawanaka shin...@google.com
+
+Added accessibility notification when value is changed.
+https://bugs.webkit.org/show_bug.cgi?id=64256
+
+Notifies the value change of range input when accessibility is enabled.
+
+Reviewed by Kent Tamura.
+
+Covered by existing tests.
+
+* html/RangeInputType.cpp:
+(WebCore::RangeInputType::handleKeydownEvent):
+ Added accessibility notification when value is changed.
+
2011-07-08 Mikhail Naganov mnaga...@chromium.org
Web Inspector: Fix resizing of sidebar pane in Timeline and Profile panels.
Modified: trunk/Source/WebCore/html/RangeInputType.cpp (90736 => 90737)
--- trunk/Source/WebCore/html/RangeInputType.cpp 2011-07-11 12:21:50 UTC (rev 90736)
+++ trunk/Source/WebCore/html/RangeInputType.cpp 2011-07-11 12:29:38 UTC (rev 90737)
@@ -32,6 +32,7 @@
#include config.h
#include RangeInputType.h
+#include AXObjectCache.h
#include HTMLDivElement.h
#include HTMLInputElement.h
#include HTMLNames.h
@@ -216,6 +217,9 @@
if (newValue != current) {
ExceptionCode ec;
setValueAsNumber(newValue, ec);
+
+if (AXObjectCache::accessibilityEnabled())
+element()-document()-axObjectCache()-postNotification(element()-renderer(), AXObjectCache::AXValueChanged, true);
element()-dispatchFormControlChangeEvent();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90741] trunk/LayoutTests
Title: [90741] trunk/LayoutTests
Revision 90741
Author yael.aha...@nokia.com
Date 2011-07-11 06:54:21 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
https://bugs.webkit.org/show_bug.cgi?id=63255
Reviewed by Csaba Osztrogonác.
Modify the tests to wait until the icon loading is finished.
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* platform/qt/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/notifications/notifications-double-show.html
trunk/LayoutTests/fast/notifications/notifications-with-permission.html
trunk/LayoutTests/platform/qt/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (90740 => 90741)
--- trunk/LayoutTests/ChangeLog 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 13:54:21 UTC (rev 90741)
@@ -1,3 +1,16 @@
+2011-07-11 Yael Aharon yael.aha...@nokia.com
+
+[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
+https://bugs.webkit.org/show_bug.cgi?id=63255
+
+Reviewed by Csaba Osztrogonác.
+
+Modify the tests to wait until the icon loading is finished.
+
+* fast/notifications/notifications-double-show.html:
+* fast/notifications/notifications-with-permission.html:
+* platform/qt/Skipped:
+
2011-07-11 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/notifications/notifications-double-show.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-double-show.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission(file://);
layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -19,6 +20,7 @@
}
var N = window.webkitNotifications.createNotification(http://localhost/my_icon.png, New E-mail, Meet me tonight at 8!);
+N._ondisplay_ = function() { layoutTestController.notifyDone(); }
N.show();
N.show();
}
Modified: trunk/LayoutTests/fast/notifications/notifications-with-permission.html (90740 => 90741)
--- trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/fast/notifications/notifications-with-permission.html 2011-07-11 13:54:21 UTC (rev 90741)
@@ -12,6 +12,7 @@
if (window.layoutTestController) {
layoutTestController.grantDesktopNotificationPermission(file://);
layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
}
if (!window.webkitNotifications) {
@@ -22,6 +23,7 @@
N.show();
var M = window.webkitNotifications.createNotification(http://localhost/my_icon.png, New E-mail, Meet me tonight at 8!);
+M._ondisplay_ = function() { layoutTestController.notifyDone(); }
M.show();
}
/script
Modified: trunk/LayoutTests/platform/qt/Skipped (90740 => 90741)
--- trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:52:22 UTC (rev 90740)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-07-11 13:54:21 UTC (rev 90741)
@@ -2156,13 +2156,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=53868
fast/notifications/notifications-document-close-crash.html
-# [Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
-# https://bugs.webkit.org/show_bug.cgi?id=63255
-fast/notifications/notifications-no-icon.html
-fast/notifications/notifications-double-show.html
-fast/notifications/notifications-with-permission.html
-fast/notifications/notifications-without-permission.html
-
# [Qt]REGRESSION(r78846): editing/selection/mixed-editability-10.html
# https://bugs.webkit.org/show_bug.cgi?id=54725
editing/selection/mixed-editability-10.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90743] trunk
Title: [90743] trunk
Revision 90743
Author podivi...@chromium.org
Date 2011-07-11 07:08:57 -0700 (Mon, 11 Jul 2011)
Log Message
Web Inspector: make SourceFrame a View.
https://bugs.webkit.org/show_bug.cgi?id=64274
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.createSearchRegex):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype._beforeTextChanged):
(WebInspector.SourceFrame.prototype._afterTextChanged):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype._suggestedFileName):
(WebInspector.SourceFrame.prototype._doubleClick):
(WebInspector.SourceFrame.prototype._cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewerDelegate.prototype.populateLineGutterContextMenu):
Modified Paths
trunk/LayoutTests/inspector/debugger/live-edit.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js
Diff
Modified: trunk/LayoutTests/inspector/debugger/live-edit.html (90742 => 90743)
--- trunk/LayoutTests/inspector/debugger/live-edit.html 2011-07-11 14:03:44 UTC (rev 90742)
+++ trunk/LayoutTests/inspector/debugger/live-edit.html 2011-07-11 14:08:57 UTC (rev 90743)
@@ -112,7 +112,7 @@
{
InspectorTest.addSniffer(WebInspector.debuggerModel, _didEditScriptSource, callback);
sourceFrame._textViewer._mainPanel.readOnly = false;
-sourceFrame.beforeTextChanged();
+sourceFrame._beforeTextChanged();
var oldRange, newRange;
var lines = sourceFrame._textModel._lines;
for (var i = 0; i lines.length; ++i) {
@@ -126,7 +126,7 @@
newRange = new WebInspector.TextRange(i, column, i + lineEndings.length - 1, lastLineLength);
break;
}
-sourceFrame.afterTextChanged(oldRange, newRange);
+sourceFrame._afterTextChanged(oldRange, newRange);
sourceFrame._textViewer._commitEditing();
}
};
Modified: trunk/Source/WebCore/ChangeLog (90742 => 90743)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 14:03:44 UTC (rev 90742)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 14:08:57 UTC (rev 90743)
@@ -1,3 +1,36 @@
+2011-07-11 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: make SourceFrame a View.
+https://bugs.webkit.org/show_bug.cgi?id=64274
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame):
+(WebInspector.SourceFrame.createSearchRegex):
+(WebInspector.SourceFrame.prototype.show):
+(WebInspector.SourceFrame.prototype.hide):
+(WebInspector.SourceFrame.prototype._beforeTextChanged):
+(WebInspector.SourceFrame.prototype._afterTextChanged):
+(WebInspector.SourceFrame.prototype._initializeTextViewer):
+(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
+(WebInspector.SourceFrame.prototype.performSearch):
+(WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):
+(WebInspector.SourceFrame.prototype._suggestedFileName):
+(WebInspector.SourceFrame.prototype._doubleClick):
+(WebInspector.SourceFrame.prototype._cancelEditing):
+(WebInspector.TextViewerDelegateForSourceFrame):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
+
[webkit-changes] [90747] trunk/Tools
Title: [90747] trunk/Tools
Revision 90747
Author aro...@apple.com
Date 2011-07-11 08:27:05 -0700 (Mon, 11 Jul 2011)
Log Message
Teach TestFailures that ORWT's results.html file might be missing due to all tests passing
There are three reasons why we might fail to fetch ORWT's results.html:
- All tests passed, so no results.html was generated
- Some error during the test run caused results.html not to be generated (e.g., ORWT
timed out)
- Some network error occurred when fetching results.html
We were failing to account for the first possibility in some cases. For test runs before
r89610, we first check build.webkit.org/json to determine how many tests failed and whether
ORWT exited early due to too many failures; if all tests passed then we don't fetch
results.html at all. r89610 changed ORWT to put information in results.html about exiting
early due to too many failures, so we no longer needed to check build.webkit.org/json to get
that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
still needed to check build.webkit.org/json to find out if all tests passed!
Now, for test runs after r89610, we check results.html first, and then check
build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
tests passing and the error cases.
Fixes http://webkit.org/b/64280 TestFailures page can't pinpoint that r90699 caused 13
tests to fail on Windows 7 Release (WebKit2 Tests)
Reviewed by David Kilzer.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
(LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
cached data will get evicted. We were marking builds where all tests passed as errors!
(LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
parameters to the fetchAndParseResultsHTML helper function, and added a similar
fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
from later in the function). For test runs before r89610, we first check
build.webkit.org/json then check results.html. For builds after r89610, we first check
results.html and then check build.webkit.org/json if we couldn't fetch results.html.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js (90746 => 90747)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js 2011-07-11 15:15:28 UTC (rev 90746)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js 2011-07-11 15:27:05 UTC (rev 90747)
@@ -30,7 +30,7 @@
LayoutTestResultsLoader.prototype = {
start: function(buildName, callback, errorCallback) {
var cacheKey = 'LayoutTestResultsLoader.' + this._builder.name + '.' + buildName;
-const currentCachedDataVersion = 3;
+const currentCachedDataVersion = 4;
if (PersistentCache.contains(cacheKey)) {
var cachedData = PersistentCache.get(cacheKey);
if (cachedData.version === currentCachedDataVersion) {
@@ -82,35 +82,54 @@
var self = this;
-function fetchAndParseResultsHTMLAndCallCallback() {
+function fetchAndParseResultsHTML(successCallback, errorCallback) {
getResource(self._builder.resultsPageURL(buildName), function(xhr) {
var parseResult = (new ORWTResultsParser()).parse(xhr.responseText);
result.tests = parseResult.tests;
if (resultsHTMLSupportsTooManyFailuresInfo)
result.tooManyFailures = parseResult.tooManyFailures;
-
-successCallback(result);
+successCallback();
},
function(xhr) {
-// We failed to fetch results.html. run-webkit-tests must have aborted early.
+// We failed to fetch results.html.
errorCallback();
});
}
+function fetchNumberOfFailingTests(successCallback, errorCallback) {
+self._builder.getNumberOfFailingTests(parsedBuildName.buildNumber, function(failingTestCount, tooManyFailures) {
+result.tooManyFailures = tooManyFailures;
+
+if (failingTestCount 0) {
+// The number of failing tests couldn't be determined.
+errorCallback();
+return;
+}
+
+successCallback(failingTestCount);
+});
+}
+
if (resultsHTMLSupportsTooManyFailuresInfo) {
-fetchAndParseResultsHTMLAndCallCallback();
+fetchAndParseResultsHTML(function() {
+successCallback(result);
+
[webkit-changes] [90749] trunk/LayoutTests
Title: [90749] trunk/LayoutTests Revision 90749 Author yu...@chromium.org Date 2011-07-11 08:44:10 -0700 (Mon, 11 Jul 2011) Log Message 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90748 => 90749) --- trunk/LayoutTests/ChangeLog 2011-07-11 15:38:58 UTC (rev 90748) +++ trunk/LayoutTests/ChangeLog 2011-07-11 15:44:10 UTC (rev 90749) @@ -1,3 +1,9 @@ +2011-07-11 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update Chromium test expectations. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Jessie Berlin jber...@apple.com WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90748 => 90749) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 15:38:58 UTC (rev 90748) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 15:44:10 UTC (rev 90749) @@ -3990,7 +3990,8 @@ BUGCR88911 MAC : fast/forms/input-number-unacceptable-style.html = PASS TEXT BUGCR88911 MAC : fast/parser/external-entities.xml = PASS TEXT BUGCR88911 MAC : fast/text/find-kana.html = PASS TEXT -BUGCR88911 MAC : fast/xsl/mozilla-tests.xml,svg/custom/use-invalid-pattern.svg = PASS TEXT +BUGCR88911 MAC : fast/xsl/mozilla-tests.xml = PASS TEXT +BUGCR88911 MAC : svg/custom/use-invalid-pattern.svg = PASS TEXT BUGCR88911 MAC : svg/custom/use-invalid-style.svg = PASS TEXT BUGCR88911 MAC : fast/text/atsui-multiple-renderers.html = PASS TEXT BUGCR88911 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = PASS TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90750] trunk/Source/WebKit2
Title: [90750] trunk/Source/WebKit2 Revision 90750 Author commit-qu...@webkit.org Date 2011-07-11 08:53:47 -0700 (Mon, 11 Jul 2011) Log Message [Qt][WK2] Forward the viewport visible area from the view instead of inferring it from the TiledDrawingAreaProxy https://bugs.webkit.org/show_bug.cgi?id=64275 Patch by Benjamin Poulain benja...@webkit.org on 2011-07-11 Reviewed by Simon Hausmann. This patch refactors the way the viewport visible area is handled. Previously, the TiledDrawingAreaProxy would ask for the visible rect when painting or updating. This is reversed with this patch, and the viewport informs the page of any change in the view area. With this change, the TiledDrawingAreaProxy does not need to know about QTouchWebPage, and can use the TouchViewInterface directly. * UIProcess/API/qt/qtouchwebpage.cpp: (QTouchWebPagePrivate::setViewportRect): * UIProcess/API/qt/qtouchwebpage.h: * UIProcess/API/qt/qtouchwebpage_p.h: * UIProcess/API/qt/qtouchwebview.cpp: (QTouchWebViewPrivate::scroll): (QTouchWebViewPrivate::viewportRectUpdated): (QTouchWebView::resizeEvent): * UIProcess/API/qt/qtouchwebview.h: * UIProcess/API/qt/qtouchwebview_p.h: * UIProcess/PageClient.h: * UIProcess/TiledDrawingAreaProxy.cpp: (WebKit::TiledDrawingAreaProxy::invalidate): (WebKit::TiledDrawingAreaProxy::paint): (WebKit::TiledDrawingAreaProxy::setVisibleArea): (WebKit::TiledDrawingAreaProxy::createTiles): * UIProcess/TiledDrawingAreaProxy.h: * UIProcess/WebPageProxy.h: * UIProcess/qt/QtWebPageProxy.cpp: * UIProcess/qt/QtWebPageProxy.h: * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: (WebKit::TiledDrawingAreaProxy::updateWebView): * UIProcess/qt/TouchViewInterface.cpp: (WebKit::TouchViewInterface::contentSizeChanged): * UIProcess/qt/TouchViewInterface.h: * UIProcess/qt/WebPageProxyQt.cpp: * UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::createDrawingAreaProxy): (QTouchWebPageProxy::setVisibleArea): * UIProcess/qt/qtouchwebpageproxy.h: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview.h trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebview_p.h trunk/Source/WebKit2/UIProcess/PageClient.h trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaProxyQt.cpp trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h trunk/Source/WebKit2/UIProcess/qt/WebPageProxyQt.cpp trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.h Diff Modified: trunk/Source/WebKit2/ChangeLog (90749 => 90750) --- trunk/Source/WebKit2/ChangeLog 2011-07-11 15:44:10 UTC (rev 90749) +++ trunk/Source/WebKit2/ChangeLog 2011-07-11 15:53:47 UTC (rev 90750) @@ -1,3 +1,49 @@ +2011-07-11 Benjamin Poulain benja...@webkit.org + +[Qt][WK2] Forward the viewport visible area from the view instead of inferring it from the TiledDrawingAreaProxy +https://bugs.webkit.org/show_bug.cgi?id=64275 + +Reviewed by Simon Hausmann. + +This patch refactors the way the viewport visible area is handled. +Previously, the TiledDrawingAreaProxy would ask for the visible rect +when painting or updating. This is reversed with this patch, and the viewport +informs the page of any change in the view area. + +With this change, the TiledDrawingAreaProxy does not need to know about QTouchWebPage, +and can use the TouchViewInterface directly. + +* UIProcess/API/qt/qtouchwebpage.cpp: +(QTouchWebPagePrivate::setViewportRect): +* UIProcess/API/qt/qtouchwebpage.h: +* UIProcess/API/qt/qtouchwebpage_p.h: +* UIProcess/API/qt/qtouchwebview.cpp: +(QTouchWebViewPrivate::scroll): +(QTouchWebViewPrivate::viewportRectUpdated): +(QTouchWebView::resizeEvent): +* UIProcess/API/qt/qtouchwebview.h: +* UIProcess/API/qt/qtouchwebview_p.h: +* UIProcess/PageClient.h: +* UIProcess/TiledDrawingAreaProxy.cpp: +(WebKit::TiledDrawingAreaProxy::invalidate): +(WebKit::TiledDrawingAreaProxy::paint): +(WebKit::TiledDrawingAreaProxy::setVisibleArea): +(WebKit::TiledDrawingAreaProxy::createTiles): +* UIProcess/TiledDrawingAreaProxy.h: +* UIProcess/WebPageProxy.h: +* UIProcess/qt/QtWebPageProxy.cpp: +* UIProcess/qt/QtWebPageProxy.h: +* UIProcess/qt/TiledDrawingAreaProxyQt.cpp: +(WebKit::TiledDrawingAreaProxy::updateWebView): +*
[webkit-changes] [90751] trunk/LayoutTests
Title: [90751] trunk/LayoutTests Revision 90751 Author yu...@chromium.org Date 2011-07-11 08:55:31 -0700 (Mon, 11 Jul 2011) Log Message 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90750 => 90751) --- trunk/LayoutTests/ChangeLog 2011-07-11 15:53:47 UTC (rev 90750) +++ trunk/LayoutTests/ChangeLog 2011-07-11 15:55:31 UTC (rev 90751) @@ -4,6 +4,12 @@ * platform/chromium/test_expectations.txt: +2011-07-11 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update Chromium test expectations. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Jessie Berlin jber...@apple.com WebKitTestRunner needs an implementation of eventSender.beginDragWithFiles. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90750 => 90751) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 15:53:47 UTC (rev 90750) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 15:55:31 UTC (rev 90751) @@ -3993,5 +3993,5 @@ BUGCR88911 MAC : fast/xsl/mozilla-tests.xml = PASS TEXT BUGCR88911 MAC : svg/custom/use-invalid-pattern.svg = PASS TEXT BUGCR88911 MAC : svg/custom/use-invalid-style.svg = PASS TEXT -BUGCR88911 MAC : fast/text/atsui-multiple-renderers.html = PASS TEXT -BUGCR88911 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = PASS TEXT +BUGCR88911 MAC : fast/text/atsui-multiple-renderers.html = IMAGE +BUGCR88911 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90752] trunk/Tools
Title: [90752] trunk/Tools
Revision 90752
Author o...@webkit.org
Date 2011-07-11 08:58:44 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt][Mac] Unreviewed fix after r90746.
* Scripts/run-webkit-tests:
(useNewRunWebKitTests): Really disable NRWT for qt-mac platform.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
Diff
Modified: trunk/Tools/ChangeLog (90751 => 90752)
--- trunk/Tools/ChangeLog 2011-07-11 15:55:31 UTC (rev 90751)
+++ trunk/Tools/ChangeLog 2011-07-11 15:58:44 UTC (rev 90752)
@@ -1,3 +1,10 @@
+2011-07-11 Csaba Osztrogonác o...@webkit.org
+
+[Qt][Mac] Unreviewed fix after r90746.
+
+* Scripts/run-webkit-tests:
+(useNewRunWebKitTests): Really disable NRWT for qt-mac platform.
+
2011-07-11 Adam Roben aro...@apple.com
Teach TestFailures that ORWT's results.html file might be missing due to all tests passing
Modified: trunk/Tools/Scripts/run-webkit-tests (90751 => 90752)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-11 15:55:31 UTC (rev 90751)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-11 15:58:44 UTC (rev 90752)
@@ -85,7 +85,11 @@
# NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756
# NRWT doesn't support qt-mac, qt-arm and qt-4.8 platforms now: https://bugs.webkit.org/show_bug.cgi?id=64071 and https://bugs.webkit.org/show_bug.cgi?id=64086
-return ((isLeopard() or isSnowLeopard() or (isQt() and !isDarwin() and !isARM() and (getQtVersion() ne 4.8)) or isGtk()) and !usingWebKit2() and !usingLeaks());
+if (isQt()) {
+return (!usingWebKit2() and !isDarwin() and !isARM() and (getQtVersion() ne 4.8));
+}
+
+return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2() and !usingLeaks());
}
my $harnessName = old-run-webkit-tests;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90753] trunk/LayoutTests
Title: [90753] trunk/LayoutTests Revision 90753 Author o...@webkit.org Date 2011-07-11 09:09:16 -0700 (Mon, 11 Jul 2011) Log Message [Qt][Mac] Unreviewed gardening. * platform/qt-mac/Skipped: Remove non-existent editing/pasteboard/do-not-copy-body-color.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90752 => 90753) --- trunk/LayoutTests/ChangeLog 2011-07-11 15:58:44 UTC (rev 90752) +++ trunk/LayoutTests/ChangeLog 2011-07-11 16:09:16 UTC (rev 90753) @@ -1,3 +1,9 @@ +2011-07-11 Csaba Osztrogonác o...@webkit.org + +[Qt][Mac] Unreviewed gardening. + +* platform/qt-mac/Skipped: Remove non-existent editing/pasteboard/do-not-copy-body-color.html. + 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. Modified: trunk/LayoutTests/platform/qt-mac/Skipped (90752 => 90753) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-07-11 15:58:44 UTC (rev 90752) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-07-11 16:09:16 UTC (rev 90753) @@ -830,7 +830,6 @@ editing/pasteboard/displaced-generic-placeholder.html editing/pasteboard/displaced-placeholder.html editing/pasteboard/display-block-on-spans.html -editing/pasteboard/do-not-copy-body-color.html editing/pasteboard/emacs-cntl-y-001.html editing/pasteboard/innerText-inline-table.html editing/pasteboard/interchange-newline-1.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90757] trunk/LayoutTests
Title: [90757] trunk/LayoutTests Revision 90757 Author yu...@chromium.org Date 2011-07-11 09:37:01 -0700 (Mon, 11 Jul 2011) Log Message 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90756 => 90757) --- trunk/LayoutTests/ChangeLog 2011-07-11 16:36:06 UTC (rev 90756) +++ trunk/LayoutTests/ChangeLog 2011-07-11 16:37:01 UTC (rev 90757) @@ -1,3 +1,9 @@ +2011-07-11 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update Chromium test expectations. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Csaba Osztrogonác o...@webkit.org [Qt][Mac] Unreviewed gardening. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90756 => 90757) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 16:36:06 UTC (rev 90756) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 16:37:01 UTC (rev 90757) @@ -3995,3 +3995,6 @@ BUGCR88911 MAC : svg/custom/use-invalid-style.svg = PASS TEXT BUGCR88911 MAC : fast/text/atsui-multiple-renderers.html = IMAGE BUGCR88911 MAC : svg/W3C-SVG-1.1/struct-image-10-t.svg = IMAGE + +// V8 now follows spec on toisostring, test needs to be fixed. +BUG88936 : fast/js/date-toisostring.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90758] trunk/Source/WebCore
Title: [90758] trunk/Source/WebCore
Revision 90758
Author andreas.kl...@nokia.com
Date 2011-07-11 09:47:48 -0700 (Mon, 11 Jul 2011)
Log Message
Reviewed by Oliver Hunt.
Canvas: Use fast, approximate dirty rects for stroke()
https://bugs.webkit.org/show_bug.cgi?id=59764
No new tests, this is an optimization.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stroke): Instead of using
Path::strokeBoundingRect() to calculate the exact bounding rect
for a path stroke, get the Path::boundingRect() and inflate it by
miterLimit + lineWidth to get a slightly oversized dirty rect
in a fraction of the time.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90757 => 90758)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 16:37:01 UTC (rev 90757)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 16:47:48 UTC (rev 90758)
@@ -1,3 +1,19 @@
+2011-07-11 Andreas Kling kl...@webkit.org
+
+Reviewed by Oliver Hunt.
+
+Canvas: Use fast, approximate dirty rects for stroke()
+https://bugs.webkit.org/show_bug.cgi?id=59764
+
+No new tests, this is an optimization.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::stroke): Instead of using
+Path::strokeBoundingRect() to calculate the exact bounding rect
+for a path stroke, get the Path::boundingRect() and inflate it by
+miterLimit + lineWidth to get a slightly oversized dirty rect
+in a fraction of the time.
+
2011-07-11 Andrey Kosyakov ca...@chromium.org
Reviewed by Pavel Feldman.
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (90757 => 90758)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-07-11 16:37:01 UTC (rev 90757)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-07-11 16:47:48 UTC (rev 90758)
@@ -975,17 +975,17 @@
if (!m_path.isEmpty()) {
#if PLATFORM(QT)
+FloatRect dirtyRect = m_path.platformPath().controlPointRect();
+#else
+FloatRect dirtyRect = m_path.boundingRect();
+#endif
// Fast approximation of the stroke's bounding rect.
// This yields a slightly oversized rect but is very fast
// compared to Path::strokeBoundingRect().
-FloatRect boundingRect = m_path.platformPath().controlPointRect();
-boundingRect.inflate(state().m_miterLimit + state().m_lineWidth);
-#else
-CanvasStrokeStyleApplier strokeApplier(this);
-FloatRect boundingRect = m_path.strokeBoundingRect(strokeApplier);
-#endif
+dirtyRect.inflate(state().m_miterLimit + state().m_lineWidth);
+
c-strokePath(m_path);
-didDraw(boundingRect);
+didDraw(dirtyRect);
}
#if ENABLE(DASHBOARD_SUPPORT)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90759] trunk/LayoutTests
Title: [90759] trunk/LayoutTests Revision 90759 Author jber...@webkit.org Date 2011-07-11 09:52:02 -0700 (Mon, 11 Jul 2011) Log Message http/tests/cache/history-only-cached-subresource-loads-max-age-https.html timing out on Windows and WebKit2 since it was added. https://bugs.webkit.org/show_bug.cgi?id=63806 Add the test to the WK2 Skipped list to get the bots green. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90758 => 90759) --- trunk/LayoutTests/ChangeLog 2011-07-11 16:47:48 UTC (rev 90758) +++ trunk/LayoutTests/ChangeLog 2011-07-11 16:52:02 UTC (rev 90759) @@ -1,3 +1,13 @@ +2011-07-11 Jessie Berlin jber...@apple.com + +http/tests/cache/history-only-cached-subresource-loads-max-age-https.html timing out on +Windows and WebKit2 since it was added. +https://bugs.webkit.org/show_bug.cgi?id=63806 + +Add the test to the WK2 Skipped list to get the bots green. + +* platform/wk2/Skipped: + 2011-07-11 Yury Semikhatsky yu...@chromium.org Unreviewed. Update Chromium test expectations. Modified: trunk/LayoutTests/platform/wk2/Skipped (90758 => 90759) --- trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 16:47:48 UTC (rev 90758) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 16:52:02 UTC (rev 90759) @@ -1616,6 +1616,10 @@ # Skipped until new WebSocket protocol is implemented. http://webkit.org/b/50099 http/tests/websocket/tests/hybi/ +# Times out +# https://bugs.webkit.org/show_bug.cgi?id=63806 +http/tests/cache/history-only-cached-subresource-loads-max-age-https.html + ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90762] trunk/Tools
Title: [90762] trunk/Tools
Revision 90762
Author aba...@webkit.org
Date 2011-07-11 10:51:04 -0700 (Mon, 11 Jul 2011)
Log Message
garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=64185
Reviewed by Eric Seidel.
This gardening server API is simply a binding to the rollout machinery
already present in webkit-patch.
* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
Added Paths
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (90761 => 90762)
--- trunk/Tools/ChangeLog 2011-07-11 17:35:51 UTC (rev 90761)
+++ trunk/Tools/ChangeLog 2011-07-11 17:51:04 UTC (rev 90762)
@@ -1,3 +1,17 @@
+2011-07-11 Adam Barth aba...@webkit.org
+
+garden-o-matic should be able to roll out patches
+https://bugs.webkit.org/show_bug.cgi?id=64185
+
+Reviewed by Eric Seidel.
+
+This gardening server API is simply a binding to the rollout machinery
+already present in webkit-patch.
+
+* Scripts/webkitpy/tool/commands/gardenomatic.py:
+* Scripts/webkitpy/tool/servers/gardeningserver.py:
+* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
+
2011-07-11 Csaba Osztrogonác o...@webkit.org
[Qt][Mac] Unreviewed fix after r90746.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py (90761 => 90762)
--- trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py 2011-07-11 17:35:51 UTC (rev 90761)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py 2011-07-11 17:51:04 UTC (rev 90762)
@@ -31,3 +31,8 @@
help_text = Experimental command for gardening the WebKit tree.
server = GardeningHTTPServer
+
+def _prepare_config(self, options, args, tool):
+return {
+'tool': tool,
+}
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (90761 => 90762)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-07-11 17:35:51 UTC (rev 90761)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2011-07-11 17:51:04 UTC (rev 90762)
@@ -30,7 +30,8 @@
class GardeningHTTPServer(BaseHTTPServer.HTTPServer):
def __init__(self, httpd_port, config):
-server_name =
+server_name = ''
+self.tool = config['tool']
BaseHTTPServer.HTTPServer.__init__(self, (server_name, httpd_port), GardeningHTTPRequestHandler)
@@ -47,3 +48,17 @@
])
STATIC_FILE_DIRECTORY = os.path.join(os.path.dirname(__file__), data, gardeningserver)
+
+def _run_webkit_patch(self, args):
+return self.server.tool.executive.run_command([self.server.tool.path()] + args)
+
+def rollout(self):
+revision = self.query['revision'][0]
+reason = self.query['reason'][0]
+self._run_webkit_patch([
+'rollout',
+'--force-clean',
+'--non-interactive',
+revision,
+reason,
+])
Added: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (0 => 90762)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2011-07-11 17:51:04 UTC (rev 90762)
@@ -0,0 +1,58 @@
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#* Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#* Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+#* Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
[webkit-changes] [90764] trunk
Title: [90764] trunk
Revision 90764
Author ander...@apple.com
Date 2011-07-11 11:14:01 -0700 (Mon, 11 Jul 2011)
Log Message
Implement getFormValue for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=64294
rdar://problem/3964087
Source/WebKit2:
Reviewed by Kevin Decker.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::getFormValue):
Call Plugin::getFormValue.
* PluginProcess/PluginControllerProxy.messages.in:
Add new GetFormValue message.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::getFormValue):
Get the form value and convert it to a String.
* WebProcess/Plugins/Plugin.h:
Add getFormValue pure virtual member function.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::getFormValue):
Send a GetFormValue message to the plug-in process.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::getFormValue):
Call Plugin::getFormValue.
LayoutTests:
Remove now passing test.
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.messages.in
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h
Diff
Modified: trunk/LayoutTests/ChangeLog (90763 => 90764)
--- trunk/LayoutTests/ChangeLog 2011-07-11 17:55:26 UTC (rev 90763)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 18:14:01 UTC (rev 90764)
@@ -1,3 +1,13 @@
+2011-07-11 Anders Carlsson ander...@apple.com
+
+Implement getFormValue for WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=64294
+rdar://problem/3964087
+
+Remove now passing test.
+
+* platform/wk2/Skipped:
+
2011-07-11 Ojan Vafai o...@chromium.org
Fix syntax error from r90757.
Modified: trunk/LayoutTests/platform/wk2/Skipped (90763 => 90764)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 17:55:26 UTC (rev 90763)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 18:14:01 UTC (rev 90764)
@@ -1852,9 +1852,6 @@
# missing window.internals.createShadowContentElement
fast/dom/shadow/create-content-element.html
-# Need to implement getFormValue().
-plugins/form-value.html
-
### END OF (2) Classified failures without bug reports (yet)
Modified: trunk/Source/WebKit2/ChangeLog (90763 => 90764)
--- trunk/Source/WebKit2/ChangeLog 2011-07-11 17:55:26 UTC (rev 90763)
+++ trunk/Source/WebKit2/ChangeLog 2011-07-11 18:14:01 UTC (rev 90764)
@@ -1,3 +1,33 @@
+2011-07-11 Anders Carlsson ander...@apple.com
+
+Implement getFormValue for WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=64294
+rdar://problem/3964087
+
+Reviewed by Kevin Decker.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::getFormValue):
+Call Plugin::getFormValue.
+
+* PluginProcess/PluginControllerProxy.messages.in:
+Add new GetFormValue message.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::getFormValue):
+Get the form value and convert it to a String.
+
+* WebProcess/Plugins/Plugin.h:
+Add getFormValue pure virtual member function.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::getFormValue):
+Send a GetFormValue message to the plug-in process.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::getFormValue):
+Call Plugin::getFormValue.
+
2011-07-11 Ada Chan adac...@apple.com
The original request should be accessible from WebNavigationData.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (90763 => 90764)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-07-11 17:55:26 UTC (rev 90763)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-07-11 18:14:01 UTC (rev 90764)
@@ -593,6 +593,11 @@
m_plugin-privateBrowsingStateChanged(isPrivateBrowsingEnabled);
}
+void PluginControllerProxy::getFormValue(bool returnValue, String formValue)
+{
+returnValue = m_plugin-getFormValue(formValue);
+}
+
bool PluginControllerProxy::tryToShortCircuitEvaluate(NPObject* npObject, const String scriptString, NPVariant* result)
{
// Only try to short circuit evaluate for plug-ins that have the quirk specified.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (90763 => 90764)
---
[webkit-changes] [90765] trunk
Title: [90765] trunk
Revision 90765
Author commit-qu...@webkit.org
Date 2011-07-11 11:20:23 -0700 (Mon, 11 Jul 2011)
Log Message
Patch by Young Han Lee joy...@company100.net on 2011-07-11
Reviewed by Simon Fraser.
Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
https://bugs.webkit.org/show_bug.cgi?id=63859
The existing code to set the m_startTime haven't worked because
the animation is not the right state to accept the start event.
This patch just sets the values directly instead of using event.
Source/WebCore:
Test: transitions/delay.html
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::freezeAtTime):
LayoutTests:
* transitions/delay-expected.txt: Added.
* transitions/delay.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/animation/AnimationBase.cpp
Added Paths
trunk/LayoutTests/transitions/delay-expected.txt
trunk/LayoutTests/transitions/delay.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90764 => 90765)
--- trunk/LayoutTests/ChangeLog 2011-07-11 18:14:01 UTC (rev 90764)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 18:20:23 UTC (rev 90765)
@@ -1,3 +1,17 @@
+2011-07-11 Young Han Lee joy...@company100.net
+
+Reviewed by Simon Fraser.
+
+Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
+https://bugs.webkit.org/show_bug.cgi?id=63859
+
+The existing code to set the m_startTime haven't worked because
+the animation is not the right state to accept the start event.
+This patch just sets the values directly instead of using event.
+
+* transitions/delay-expected.txt: Added.
+* transitions/delay.html: Added.
+
2011-07-11 Anders Carlsson ander...@apple.com
Implement getFormValue for WebKit2
Added: trunk/LayoutTests/transitions/delay-expected.txt (0 => 90765)
--- trunk/LayoutTests/transitions/delay-expected.txt (rev 0)
+++ trunk/LayoutTests/transitions/delay-expected.txt 2011-07-11 18:20:23 UTC (rev 90765)
@@ -0,0 +1,2 @@
+PASS - left property for target element at 2s saw something close to: 100
+
Added: trunk/LayoutTests/transitions/delay.html (0 => 90765)
--- trunk/LayoutTests/transitions/delay.html (rev 0)
+++ trunk/LayoutTests/transitions/delay.html 2011-07-11 18:20:23 UTC (rev 90765)
@@ -0,0 +1,36 @@
+html
+head
+ style
+#target {
+ position: relative;
+ left: 0px;
+ height: 50px;
+ width: 50px;
+ background-color: green;
+ -webkit-transition: left 4s linear 1s;
+}
+
+#target.moved {
+ left: 400px;
+}
+ /style
+ script src=""
+ script
+ const expectedValues = [
+ // [time, element-id, property, expected-value, tolerance]
+ [2, target, left, 100, 4],
+ ];
+
+ function setupTest()
+ {
+ document.getElementById(target).className = moved;
+ }
+
+ runTransitionTest(expectedValues, setupTest, usePauseAPI);
+ /script
+/head
+body
+ div id=target/div
+ div id=result/div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (90764 => 90765)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 18:14:01 UTC (rev 90764)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 18:20:23 UTC (rev 90765)
@@ -1,3 +1,19 @@
+2011-07-11 Young Han Lee joy...@company100.net
+
+Reviewed by Simon Fraser.
+
+Transition LayoutTest using pause API shows wrong result if it tries to pause a transition after its delay time.
+https://bugs.webkit.org/show_bug.cgi?id=63859
+
+The existing code to set the m_startTime haven't worked because
+the animation is not the right state to accept the start event.
+This patch just sets the values directly instead of using event.
+
+Test: transitions/delay.html
+
+* page/animation/AnimationBase.cpp:
+(WebCore::AnimationBase::freezeAtTime):
+
2011-07-11 Ryosuke Niwa rn...@webkit.org
Move selection related code from RenderTextControl to HTMLTextFormControlElement
Modified: trunk/Source/WebCore/page/animation/AnimationBase.cpp (90764 => 90765)
--- trunk/Source/WebCore/page/animation/AnimationBase.cpp 2011-07-11 18:14:01 UTC (rev 90764)
+++ trunk/Source/WebCore/page/animation/AnimationBase.cpp 2011-07-11 18:20:23 UTC (rev 90765)
@@ -1443,8 +1443,9 @@
return;
if (!m_startTime) {
-// If we haven't started yet, just generate the start event now
-m_compAnim-animationController()-receivedStartTimeResponse(currentTime());
+// If we haven't started yet, make it as if we started.
+m_animState = AnimationStateStartWaitResponse;
+onAnimationStartResponse(currentTime());
}
ASSERT(m_startTime);// if m_startTime is zero, we haven't started yet, so we'll get a bad pause time.
[webkit-changes] [90768] trunk/Source/JavaScriptCore
Title: [90768] trunk/Source/_javascript_Core
Revision 90768
Author commit-qu...@webkit.org
Date 2011-07-11 11:39:14 -0700 (Mon, 11 Jul 2011)
Log Message
DFG Speculative JIT does not always insert speculation checks when speculating
arrays.
https://bugs.webkit.org/show_bug.cgi?id=64254
Patch by Filip Pizlo fpi...@apple.com on 2011-07-11
Reviewed by Gavin Barraclough.
Changed the SetLocal instruction to always validate that the value being stored
into the local variable is an array, if that variable was marked PredictArray.
This is necessary since uses of arrays assume that if a PredictArray value is
in a local variable then the speculation check validating that the value is an
array was already performed.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90767 => 90768)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-11 18:39:11 UTC (rev 90767)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-11 18:39:14 UTC (rev 90768)
@@ -1,3 +1,20 @@
+2011-07-11 Filip Pizlo fpi...@apple.com
+
+DFG Speculative JIT does not always insert speculation checks when speculating
+arrays.
+https://bugs.webkit.org/show_bug.cgi?id=64254
+
+Reviewed by Gavin Barraclough.
+
+Changed the SetLocal instruction to always validate that the value being stored
+into the local variable is an array, if that variable was marked PredictArray.
+This is necessary since uses of arrays assume that if a PredictArray value is
+in a local variable then the speculation check validating that the value is an
+array was already performed.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2011-07-11 Gabor Loki l...@webkit.org
Fix the condition of the optimized code in doubleTransfer
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (90767 => 90768)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-07-11 18:39:11 UTC (rev 90767)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-07-11 18:39:14 UTC (rev 90768)
@@ -491,7 +491,9 @@
}
case PredictArray: {
SpeculateCellOperand cell(this, node.child1());
-m_jit.storePtr(cell.gpr(), JITCompiler::addressFor(node.local()));
+GPRReg cellGPR = cell.gpr();
+speculationCheck(m_jit.branchPtr(MacroAssembler::NotEqual, MacroAssembler::Address(cellGPR), MacroAssembler::TrustedImmPtr(m_jit.globalData()-jsArrayVPtr)));
+m_jit.storePtr(cellGPR, JITCompiler::addressFor(node.local()));
noResult(m_compileIndex);
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90767] trunk/Source/WebCore
Title: [90767] trunk/Source/WebCore Revision 90767 Author commit-qu...@webkit.org Date 2011-07-11 11:39:11 -0700 (Mon, 11 Jul 2011) Log Message [skia] remove platform helpers for gradients and patterns https://bugs.webkit.org/show_bug.cgi?id=64281 Patch by Mike Reed r...@google.com on 2011-07-11 Reviewed by Stephen White. No new tests. fixes canvas/philip/tests/2d.gradient.object.update.html Remove (now empty) platform helpers for fill/stroke gradients/patterns. We now pickup the platformGradient and platformPattern fresh when they're needed, so we can see any edits that have occurred to them 2d.gradient.object.update.html sets the fillgradient, and then edits the gradient object. This CL allows us to see that edit. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokePattern): (WebCore::GraphicsContext::setFillPattern): (WebCore::GraphicsContext::setStrokeGradient): (WebCore::GraphicsContext::setFillGradient): * platform/graphics/GraphicsContext.h: * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::platformInit): * platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::State::~State): (WebCore::PlatformContextSkia::PlatformContextSkia): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setupShader): (WebCore::PlatformContextSkia::setupPaintForFilling): (WebCore::PlatformContextSkia::setupPaintForStroking): (WebCore::PlatformContextSkia::setFillColor): (WebCore::PlatformContextSkia::setStrokeColor): (WebCore::PlatformContextSkia::canAccelerate): * platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::setGraphicsContext): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp trunk/Source/WebCore/platform/graphics/GraphicsContext.h trunk/Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h Diff Modified: trunk/Source/WebCore/ChangeLog (90766 => 90767) --- trunk/Source/WebCore/ChangeLog 2011-07-11 18:22:17 UTC (rev 90766) +++ trunk/Source/WebCore/ChangeLog 2011-07-11 18:39:11 UTC (rev 90767) @@ -1,3 +1,39 @@ +2011-07-11 Mike Reed r...@google.com + +[skia] remove platform helpers for gradients and patterns +https://bugs.webkit.org/show_bug.cgi?id=64281 + +Reviewed by Stephen White. + +No new tests. fixes canvas/philip/tests/2d.gradient.object.update.html + +Remove (now empty) platform helpers for fill/stroke gradients/patterns. We now pickup the platformGradient +and platformPattern fresh when they're needed, so we can see any edits that have occurred to them +2d.gradient.object.update.html sets the fillgradient, and then edits the gradient object. This CL allows +us to see that edit. + +* platform/graphics/GraphicsContext.cpp: +(WebCore::GraphicsContext::setStrokePattern): +(WebCore::GraphicsContext::setFillPattern): +(WebCore::GraphicsContext::setStrokeGradient): +(WebCore::GraphicsContext::setFillGradient): +* platform/graphics/GraphicsContext.h: +* platform/graphics/skia/GraphicsContextSkia.cpp: +(WebCore::GraphicsContext::platformInit): +* platform/graphics/skia/PlatformContextSkia.cpp: +(WebCore::PlatformContextSkia::State::State): +(WebCore::PlatformContextSkia::State::~State): +(WebCore::PlatformContextSkia::PlatformContextSkia): +(WebCore::PlatformContextSkia::drawRect): +(WebCore::PlatformContextSkia::setupShader): +(WebCore::PlatformContextSkia::setupPaintForFilling): +(WebCore::PlatformContextSkia::setupPaintForStroking): +(WebCore::PlatformContextSkia::setFillColor): +(WebCore::PlatformContextSkia::setStrokeColor): +(WebCore::PlatformContextSkia::canAccelerate): +* platform/graphics/skia/PlatformContextSkia.h: +(WebCore::PlatformContextSkia::setGraphicsContext): + 2011-07-11 Young Han Lee joy...@company100.net Reviewed by Simon Fraser. Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp (90766 => 90767) --- trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2011-07-11 18:22:17 UTC (rev 90766) +++ trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp 2011-07-11 18:39:11 UTC (rev 90767) @@ -265,7 +265,6 @@ } m_state.strokeGradient.clear(); m_state.strokePattern = pattern; -setPlatformStrokePattern(m_state.strokePattern.get()); } void GraphicsContext::setFillPattern(PassRefPtrPattern pattern) @@ -277,7 +276,6 @@ } m_state.fillGradient.clear(); m_state.fillPattern = pattern; -setPlatformFillPattern(m_state.fillPattern.get()); } void GraphicsContext::setStrokeGradient(PassRefPtrGradient gradient) @@ -289,7
[webkit-changes] [90769] trunk/Source/WebCore
Title: [90769] trunk/Source/WebCore
Revision 90769
Author jap...@chromium.org
Date 2011-07-11 11:48:34 -0700 (Mon, 11 Jul 2011)
Log Message
[Chromium] Ensure we don't crash when an
HTMLSelectElement mouse release event removes
the element from the DOM.
https://bugs.webkit.org/show_bug.cgi?id=64295
Reviewed by Dimitri Glazkov.
Manual test only because the crash requires a
real popup menu, which DRT doesn't provide.
* manual-tests/chromium/popup-menu-crash.html: Added.
* platform/chromium/PopupMenuChromium.cpp:
(WebCore::PopupContainer::handleMouseReleaseEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PopupMenuChromium.cpp
Added Paths
trunk/Source/WebCore/manual-tests/chromium/popup-menu-crash.html
Diff
Modified: trunk/Source/WebCore/ChangeLog (90768 => 90769)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 18:39:14 UTC (rev 90768)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 18:48:34 UTC (rev 90769)
@@ -1,3 +1,19 @@
+2011-07-11 Nate Chapin jap...@chromium.org
+
+[Chromium] Ensure we don't crash when an
+HTMLSelectElement mouse release event removes
+the element from the DOM.
+https://bugs.webkit.org/show_bug.cgi?id=64295
+
+Reviewed by Dimitri Glazkov.
+
+Manual test only because the crash requires a
+real popup menu, which DRT doesn't provide.
+
+* manual-tests/chromium/popup-menu-crash.html: Added.
+* platform/chromium/PopupMenuChromium.cpp:
+(WebCore::PopupContainer::handleMouseReleaseEvent):
+
2011-07-11 Mike Reed r...@google.com
[skia] remove platform helpers for gradients and patterns
Added: trunk/Source/WebCore/manual-tests/chromium/popup-menu-crash.html (0 => 90769)
--- trunk/Source/WebCore/manual-tests/chromium/popup-menu-crash.html (rev 0)
+++ trunk/Source/WebCore/manual-tests/chromium/popup-menu-crash.html 2011-07-11 18:48:34 UTC (rev 90769)
@@ -0,0 +1,24 @@
+body id=body
+This is a test for https://bugs.webkit.org/show_bug.cgi?id=64295. Chromium sometimes crashes in a mouse event on an HTMLSelectElement if the event handler removes the element from the DOM.
+This test is manual because it requires a real select popup menu, which DRT doesn't provide.br
+To run, click on the select below, then select Click me! on the dropdown menu. We pass if the HTMLSelectElement disappears and we don't crash.
+script
+function handleClick(e) {
+if (e.target.selectedIndex != 1)
+return;
+
+document.getElementById(body).removeChild(document.getElementById(formDiv));
+var xhr = new XMLHttpRequest();
+xhr.open('GET', '', true);
+xhr.send(null);
+}
+/script
+div id=formDiv
+form
+select _onmouseup_=handleClick(event);
+option/option
+optionClick me!/option
+/select
+/form
+/div
+/body
Modified: trunk/Source/WebCore/platform/chromium/PopupMenuChromium.cpp (90768 => 90769)
--- trunk/Source/WebCore/platform/chromium/PopupMenuChromium.cpp 2011-07-11 18:39:14 UTC (rev 90768)
+++ trunk/Source/WebCore/platform/chromium/PopupMenuChromium.cpp 2011-07-11 18:48:34 UTC (rev 90769)
@@ -496,6 +496,7 @@
bool PopupContainer::handleMouseReleaseEvent(const PlatformMouseEvent event)
{
+RefPtrPopupContainer protect(this);
UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
return m_listBox-handleMouseReleaseEvent(
constructRelativeMouseEvent(event, this, m_listBox.get()));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90770] trunk/Tools
Title: [90770] trunk/Tools
Revision 90770
Author aba...@webkit.org
Date 2011-07-11 11:51:13 -0700 (Mon, 11 Jul 2011)
Log Message
Add a webkit-patch command for rebaselining an individual test
https://bugs.webkit.org/show_bug.cgi?id=64246
Reviewed by Eric Seidel.
This patch introduces a command that's able to rebaseline a single
test. Currently, the command works only with the build.chromium.org
buildbots, but extending it to work with the build.webkit.org bots
shouldn't be that hard.
A complete rebaseling tool should also include an optimize baselines
command (which moves/deletes baselines in order to reduce the number of
expected results files), but that will come in a future patch.
Really BuilderToPort should be merged into builders.py, but I'm going
to save that for a future patch as well. (We need to stop shaving yaks
at some point.)
* Scripts/webkitpy/tool/commands/rebaseline.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host.py
trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/builders.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/builders_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
trunk/Tools/Scripts/webkitpy/tool/mocktool.py
Added Paths
trunk/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py
trunk/Tools/Scripts/webkitpy/common/net/web.py
Diff
Modified: trunk/Tools/ChangeLog (90769 => 90770)
--- trunk/Tools/ChangeLog 2011-07-11 18:48:34 UTC (rev 90769)
+++ trunk/Tools/ChangeLog 2011-07-11 18:51:13 UTC (rev 90770)
@@ -1,5 +1,27 @@
2011-07-11 Adam Barth aba...@webkit.org
+Add a webkit-patch command for rebaselining an individual test
+https://bugs.webkit.org/show_bug.cgi?id=64246
+
+Reviewed by Eric Seidel.
+
+This patch introduces a command that's able to rebaseline a single
+test. Currently, the command works only with the build.chromium.org
+buildbots, but extending it to work with the build.webkit.org bots
+shouldn't be that hard.
+
+A complete rebaseling tool should also include an optimize baselines
+command (which moves/deletes baselines in order to reduce the number of
+expected results files), but that will come in a future patch.
+
+Really BuilderToPort should be merged into builders.py, but I'm going
+to save that for a future patch as well. (We need to stop shaving yaks
+at some point.)
+
+* Scripts/webkitpy/tool/commands/rebaseline.py:
+
+2011-07-11 Adam Barth aba...@webkit.org
+
garden-o-matic should be able to roll out patches
https://bugs.webkit.org/show_bug.cgi?id=64185
Modified: trunk/Tools/Scripts/webkitpy/common/host.py (90769 => 90770)
--- trunk/Tools/Scripts/webkitpy/common/host.py 2011-07-11 18:48:34 UTC (rev 90769)
+++ trunk/Tools/Scripts/webkitpy/common/host.py 2011-07-11 18:51:13 UTC (rev 90770)
@@ -31,7 +31,7 @@
from webkitpy.common.checkout import Checkout
from webkitpy.common.checkout.scm import default_scm
from webkitpy.common.config.ports import WebKitPort
-from webkitpy.common.net import bugzilla, buildbot, statusserver
+from webkitpy.common.net import bugzilla, buildbot, statusserver, web
from webkitpy.common.net.irc import ircproxy
from webkitpy.common.system import executive, filesystem, platforminfo, user, workspace
from webkitpy.layout_tests import port
@@ -42,6 +42,7 @@
self.bugs = bugzilla.Bugzilla()
self.buildbot = buildbot.BuildBot()
self.executive = executive.Executive()
+self.web = web.Web()
self._irc = None
self.filesystem = filesystem.FileSystem()
self.workspace = workspace.Workspace(self.filesystem, self.executive)
Modified: trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py (90769 => 90770)
--- trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2011-07-11 18:48:34 UTC (rev 90769)
+++ trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py 2011-07-11 18:51:13 UTC (rev 90770)
@@ -69,6 +69,11 @@
def results_url(self):
return %s/results/%s % (self._buildbot.buildbot_url, self.url_encoded_name())
+# In addition to per-build results, the build.chromium.org builders also
+# keep a directory that accumulates test results over many runs.
+def accumulated_results_url(self):
+return None
+
def url_encoded_name(self):
return urllib.quote(self._name)
@@ -280,8 +285,11 @@
class BuildBot(object):
-def __init__(self, url=""
-self.buildbot_url = url
+_builder_factory = Builder
+_default_url = config_urls.buildbot_url
+
+def __init__(self, url=""
+self.buildbot_url = url if url else self._default_url
self._builder_by_name = {}
# If any core builder is red we should not be landing patches. Other
@@ -440,7
[webkit-changes] [90771] trunk/Tools
Title: [90771] trunk/Tools
Revision 90771
Author aba...@webkit.org
Date 2011-07-11 11:54:13 -0700 (Mon, 11 Jul 2011)
Log Message
garden-o-matic should be able to determine which revisions caused a given failure
https://bugs.webkit.org/show_bug.cgi?id=64189
Reviewed by Adam Roben.
Walking the failure history looking for failures turns out to be
slightly tricky because the network requests are asynchronous.
Currently we do all the fetches serially and our cache is unbounded.
We'll probably optimize both those parameters eventually.
This patch also generalizes some functionality in the unit testing
framework to make testing this sort of code easier.
* Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js
Diff
Modified: trunk/Tools/ChangeLog (90770 => 90771)
--- trunk/Tools/ChangeLog 2011-07-11 18:51:13 UTC (rev 90770)
+++ trunk/Tools/ChangeLog 2011-07-11 18:54:13 UTC (rev 90771)
@@ -1,5 +1,24 @@
2011-07-11 Adam Barth aba...@webkit.org
+garden-o-matic should be able to determine which revisions caused a given failure
+https://bugs.webkit.org/show_bug.cgi?id=64189
+
+Reviewed by Adam Roben.
+
+Walking the failure history looking for failures turns out to be
+slightly tricky because the network requests are asynchronous.
+Currently we do all the fetches serially and our cache is unbounded.
+We'll probably optimize both those parameters eventually.
+
+This patch also generalizes some functionality in the unit testing
+framework to make testing this sort of code easier.
+
+* Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
+
+2011-07-11 Adam Barth aba...@webkit.org
+
Add a webkit-patch command for rebaselining an individual test
https://bugs.webkit.org/show_bug.cgi?id=64246
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js (90770 => 90771)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js 2011-07-11 18:51:13 UTC (rev 90770)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js 2011-07-11 18:54:13 UTC (rev 90771)
@@ -64,4 +64,15 @@
document.head.appendChild(scriptElement);
};
+// jQuery makes jsonp requests somewhat ugly (which is fair given that they're
+// terrible for security). We use this wrapper to make our lives slightly easier.
+base.jsonp = function(url, onsuccess)
+{
+$.ajax({
+url: url,
+dataType: 'jsonp',
+success: onsuccess
+});
+};
+
})();
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (90770 => 90771)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-11 18:51:13 UTC (rev 90770)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-11 18:54:13 UTC (rev 90771)
@@ -3,6 +3,7 @@
(function() {
var kTestResultsServer = 'http://test-results.appspot.com/';
+var kTestResultsQuery = kTestResultsServer + 'testfile?'
var kTestType = 'layout-tests';
var kResultsName = 'full_results.json';
var kMasterName = 'ChromiumWebkit';
@@ -57,6 +58,57 @@
return result === PASS;
}
+function resultsParameters(builderName, testName)
+{
+return {
+builder: builderName,
+master: kMasterName,
+testtype: kTestType,
+name: name,
+};
+}
+
+function resultsSummaryURL(builderName, testName)
+{
+return kTestResultsQuery + $.param(resultsParameters(builderName, testName));
+}
+
+function directoryOfResultsSummaryURL(builderName, testName)
+{
+var parameters = resultsParameters(builderName, testName);
+parameters['dir'] = 1;
+return kTestResultsQuery + $.param(parameters);
+}
+
+function ResultsCache()
+{
+this._cache = {};
+}
+
+ResultsCache.prototype._fetch = function(key, callback)
+{
+var self = this;
+
+var url = "" + 'testfile?key=' + key;
+base.jsonp(url, function (resultsTree) {
+self._cache[key] = resultsTree;
+callback(resultsTree);
+});
+};
+
+// Warning! This function can call callback either synchronously or asynchronously.
+// FIXME: Consider using setTimeout to make this method always asynchronous.
+ResultsCache.prototype.get = function(key, callback)
+{
+if (key in this._cache) {
+callback(this._cache[key]);
+return;
+}
+this._fetch(key, callback);
+};
+
+var
[webkit-changes] [90772] trunk/Tools
Title: [90772] trunk/Tools
Revision 90772
Author aba...@webkit.org
Date 2011-07-11 11:58:39 -0700 (Mon, 11 Jul 2011)
Log Message
Add some basic UI for showing regression ranges
https://bugs.webkit.org/show_bug.cgi?id=64243
Reviewed by Eric Seidel.
This UI is all temporary. It exists mostly just to have some buttons
to click to exercise the code.
* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js
trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js
Diff
Modified: trunk/Tools/ChangeLog (90771 => 90772)
--- trunk/Tools/ChangeLog 2011-07-11 18:54:13 UTC (rev 90771)
+++ trunk/Tools/ChangeLog 2011-07-11 18:58:39 UTC (rev 90772)
@@ -1,5 +1,21 @@
2011-07-11 Adam Barth aba...@webkit.org
+Add some basic UI for showing regression ranges
+https://bugs.webkit.org/show_bug.cgi?id=64243
+
+Reviewed by Eric Seidel.
+
+This UI is all temporary. It exists mostly just to have some buttons
+to click to exercise the code.
+
+* Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
+* Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
+
+2011-07-11 Adam Barth aba...@webkit.org
+
garden-o-matic should be able to determine which revisions caused a given failure
https://bugs.webkit.org/show_bug.cgi?id=64189
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90771 => 90772)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-11 18:54:13 UTC (rev 90771)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-11 18:58:39 UTC (rev 90772)
@@ -29,9 +29,10 @@
setIconState($('.failures').length);
}
-function expandResults()
+function showResults()
{
-var resultsSummary = $(this);
+// FIXME: This is fragile.
+var resultsSummary = $(this).parent().parent().parent();
var testName = $('.testName', resultsSummary).text();
$('.builderName', resultsSummary).each(function() {
var builderName = $(this).text();
@@ -41,9 +42,25 @@
});
}
+function findRegressionRange()
+{
+// FIXME: This is fragile!
+var builderName = $('.builderName', $(this).parent()).text();
+var testName = $('.testName', $(this).parent().parent().parent()).text();
+results.regressionRangeForFailure(builderName, testName, function(oldestFailingRevision, newestPassingRevision) {
+var tracURLs = [];
+for (var i = newestPassingRevision + 1; i = oldestFailingRevision; ++i) {
+tracURLs.push('a href="" + i + '' + i + '/a');
+}
+$('.butterbar .status').html('Regression range: ' + tracURLs.join(' '));
+$('.butterbar').fadeIn();
+});
+}
+
$('.hide').live('click', hide);
$('.quit').live('click', quit);
-$('.results-summary .test').live('click', expandResults);
+$('.show-results').live('click', showResults);
+$('.regression-range').live('click', findRegressionRange);
$(document).ready(function() {
fetchResults(function() {
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (90771 => 90772)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-11 18:54:13 UTC (rev 90771)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-11 18:58:39 UTC (rev 90772)
@@ -203,7 +203,10 @@
++self._indexOfNextKeyToFetch;
g_resultsCache.get(key, function(resultsTree) {
var resultNode = results.resultNodeForTest(resultsTree, self._testName);
-callback(resultsTree['revision'], resultNode);
+var revision = parseInt(resultsTree['revision'])
+if (isNaN(revision))
+revision = 0;
+callback(revision, resultNode);
});
};
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js (90771 => 90772)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-11 18:54:13 UTC (rev 90771)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-11
[webkit-changes] [90773] trunk/Source/WebCore
Title: [90773] trunk/Source/WebCore
Revision 90773
Author t...@chromium.org
Date 2011-07-11 12:02:17 -0700 (Mon, 11 Jul 2011)
Log Message
rename RenderObject::isFlexibleBox to isDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=64217
Reviewed by Ojan Vafai.
This is to make way for the new flexbox needing a similar method.
RenderObject also has isFlexingChildren() and isStretchingChildren(),
but we may be able to use those for the new flexbox as well so I
didn't rename them.
No new tests, just refactoring.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
(WebCore::shouldCheckLines):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderDeprecatedFlexibleBox.h:
(WebCore::RenderDeprecatedFlexibleBox::isDeprecatedFlexibleBox):
* rendering/RenderObject.h:
(WebCore::RenderObject::isDeprecatedFlexibleBox):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (90772 => 90773)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 18:58:39 UTC (rev 90772)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 19:02:17 UTC (rev 90773)
@@ -1,3 +1,33 @@
+2011-07-11 Tony Chang t...@chromium.org
+
+rename RenderObject::isFlexibleBox to isDeprecatedFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=64217
+
+Reviewed by Ojan Vafai.
+
+This is to make way for the new flexbox needing a similar method.
+RenderObject also has isFlexingChildren() and isStretchingChildren(),
+but we may be able to use those for the new flexbox as well so I
+didn't rename them.
+
+No new tests, just refactoring.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::removeChild):
+(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
+(WebCore::shouldCheckLines):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):
+(WebCore::RenderBox::computeLogicalWidth):
+(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
+(WebCore::RenderBox::computeLogicalHeight):
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
+* rendering/RenderDeprecatedFlexibleBox.h:
+(WebCore::RenderDeprecatedFlexibleBox::isDeprecatedFlexibleBox):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::isDeprecatedFlexibleBox):
+
2011-07-11 Nate Chapin jap...@chromium.org
[Chromium] Ensure we don't crash when an
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (90772 => 90773)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-11 18:58:39 UTC (rev 90772)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-07-11 19:02:17 UTC (rev 90773)
@@ -1045,7 +1045,7 @@
RenderBox::removeChild(oldChild);
RenderObject* child = prev ? prev : next;
-if (canMergeAnonymousBlocks child !child-previousSibling() !child-nextSibling() !isFlexibleBox()) {
+if (canMergeAnonymousBlocks child !child-previousSibling() !child-nextSibling() !isDeprecatedFlexibleBox()) {
// The removal has knocked us down to containing only a single anonymous
// box. We can go ahead and pull the content right back up into our
// box.
@@ -1452,7 +1452,7 @@
bool RenderBlock::expandsToEncloseOverhangingFloats() const
{
-return isInlineBlockOrInlineTable() || isFloatingOrPositioned() || hasOverflowClip() || (parent() parent()-isFlexibleBox())
+return isInlineBlockOrInlineTable() || isFloatingOrPositioned() || hasOverflowClip() || (parent() parent()-isDeprecatedFlexibleBox())
|| hasColumns() || isTableCell() || isFieldset() || isWritingModeRoot() || isRoot();
}
@@ -5508,7 +5508,7 @@
{
return !obj-isFloatingOrPositioned() !obj-isRunIn()
obj-isBlockFlow() obj-style()-height().isAuto()
-(!obj-isFlexibleBox() || obj-style()-boxOrient() == VERTICAL);
+(!obj-isDeprecatedFlexibleBox() || obj-style()-boxOrient() == VERTICAL);
}
static RootInlineBox* getLineAtIndex(RenderBlock* block, int i, int count)
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (90772 => 90773)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2011-07-11 18:58:39 UTC (rev 90772)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp
[webkit-changes] [90777] trunk/LayoutTests
Title: [90777] trunk/LayoutTests Revision 90777 Author senorbla...@chromium.org Date 2011-07-11 12:14:36 -0700 (Mon, 11 Jul 2011) Log Message Unreviewed; chromium test expectations update. Mark 2d.gradient.object.update as passing after r90767. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90776 => 90777) --- trunk/LayoutTests/ChangeLog 2011-07-11 19:10:40 UTC (rev 90776) +++ trunk/LayoutTests/ChangeLog 2011-07-11 19:14:36 UTC (rev 90777) @@ -1,3 +1,11 @@ +2011-07-11 Stephen White senorbla...@chromium.org + +Unreviewed; chromium test expectations update. + +Mark 2d.gradient.object.update as passing after r90767. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Young Han Lee joy...@company100.net Reviewed by Simon Fraser. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90776 => 90777) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 19:10:40 UTC (rev 90776) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 19:14:36 UTC (rev 90777) @@ -1991,7 +1991,6 @@ BUGWK45991 : canvas/philip/tests/2d.text.measure.width.space.html = TEXT // These tests fail everywhere we use skia and are most likely skia bugs -BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.object.update.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.cone.behind.html = TEXT BUGWK45991 LINUX WIN : canvas/philip/tests/2d.gradient.radial.cone.beside.html = TEXT BUGWK45991 WIN : canvas/philip/tests/2d.gradient.radial.cone.cylinder.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90778] trunk/Tools
Title: [90778] trunk/Tools
Revision 90778
Author aro...@apple.com
Date 2011-07-11 12:20:49 -0700 (Mon, 11 Jul 2011)
Log Message
Don't count leaks as test failures on TestFailures's front page
As a bonus, this patch adds our first unit test.
Fixes http://webkit.org/b/64303 REGRESSION (r90489): TestFailures page says far more tests
are failing on the Leaks bot than actually are
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Exclude lines containing leak when summing
failure counts.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
Added. Contains a simple test to show that leaks aren't counted as test failures.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
Added. This is the test harness.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js (90777 => 90778)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-07-11 19:14:36 UTC (rev 90777)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js 2011-07-11 19:20:49 UTC (rev 90778)
@@ -142,8 +142,8 @@
var match = /^(\d+)/.exec(outputLine);
if (!match)
return sum;
-// Don't count new tests or passes as failures.
-if (outputLine.contains('were new') || outputLine.contains('new passes'))
+// Don't count leaks, new tests, or passes as failures.
+if (outputLine.contains('leak') || outputLine.contains('were new') || outputLine.contains('new passes'))
return sum;
return sum + parseInt(match[1], 10);
}, 0);
Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js (0 => 90778)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js (rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js 2011-07-11 19:20:49 UTC (rev 90778)
@@ -0,0 +1,50 @@
+module(Builder);
+
+test(getNumberOfFailingTests from Leaks bot, 4, function() {
+var mockBuildbot = {};
+mockBuildbot.baseURL = 'http://example.com/';
+
+var builder = new Builder('test builder', mockBuildbot);
+
+var realGetResource = window.getResource;
+window.getResource = function(url, successCallback, errorCallback) {
+var mockXHR = {};
+mockXHR.responseText = JSON.stringify({
+steps: [
+{
+name: 'layout-test',
+isStarted: true,
+results: [
+2,
+[
+2178 total leaks found!,
+2 test cases (1%) had incorrect layout,
+2 test cases (1%) crashed,
+],
+],
+},
+],
+});
+
+successCallback(mockXHR);
+};
+
+// FIXME: It's lame to be modifying singletons like this. We should get rid
+// of our singleton usage entirely!
+var realPersistentCache = window.PersistentCache;
+window.PersistentCache = {
+contains: function() { return false; },
+set: function() { },
+get: function() { },
+};
+
+builder.getNumberOfFailingTests(1, function(failureCount, tooManyFailures) {
+equals(failureCount, 4);
+equals(tooManyFailures, false);
+});
+
+window.getResource = realGetResource;
+equals(window.getResource, realGetResource);
+window.PersistentCache = realPersistentCache;
+equals(window.PersistentCache, realPersistentCache);
+});
Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html (0 => 90778)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html (rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html 2011-07-11 19:20:49 UTC (rev 90778)
@@ -0,0 +1,19 @@
+!DOCTYPE html
+html
+head
+link rel=stylesheet href=""
+script src=""
+script src=""
+/head
+body
+h1 id=qunit-headerTestFailures _javascript_ Unit Tests/h1
+h2 id=qunit-banner/h2
+div id=qunit-testrunner-toolbar/div
+h2 id=qunit-userAgent/h2
+ol id=qunit-tests/ol
+script src=""
+
[webkit-changes] [90779] trunk
Title: [90779] trunk
Revision 90779
Author yi.4.s...@nokia.com
Date 2011-07-11 12:33:32 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
https://bugs.webkit.org/show_bug.cgi?id=62808
Source/WebCore:
Reviewed by Benjamin Poulain.
The assertion in ResourceHandle::setDefersLoading assumes asynchronous
content delivery -- To resume a page, first, its main resource loader
calls setDefersLoading to resume loading the main content; then all the
sub-resource loaders calls setDefersLoading to resume sub-contents.
However, since QNetworkReplyHandler delivers content synchronously,
some new sub-resource loaders get created as soon as the main resource
loader resumed, and all these new sub-resource loaders set their
defersLoading flag to false. Then, the assertion fails for these new
sub-resource loaders when calling setDefersLoading on them. As a fix,
this path makes QNetworkReplyHandler deliver content asynchronously.
Test: loader/load-defer-resume-crash.html
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
* platform/network/qt/QNetworkReplyHandler.h:
LayoutTests:
Added a test for the crash occurs when load deferring is turned off.
Reviewed by Benjamin Poulain.
* loader/load-defer-resume-crash-expected.txt: Added.
* loader/load-defer-resume-crash.html: Added.
* loader/resources/images.html: Added.
* platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp
trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.h
Added Paths
trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt
trunk/LayoutTests/loader/load-defer-resume-crash.html
trunk/LayoutTests/loader/resources/images.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90778 => 90779)
--- trunk/LayoutTests/ChangeLog 2011-07-11 19:20:49 UTC (rev 90778)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 19:33:32 UTC (rev 90779)
@@ -1,3 +1,17 @@
+2011-07-11 Yi Shen yi.4.s...@nokia.com
+
+[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
+https://bugs.webkit.org/show_bug.cgi?id=62808
+
+Added a test for the crash occurs when load deferring is turned off.
+
+Reviewed by Benjamin Poulain.
+
+* loader/load-defer-resume-crash-expected.txt: Added.
+* loader/load-defer-resume-crash.html: Added.
+* loader/resources/images.html: Added.
+* platform/chromium/test_expectations.txt: Skip this test since the LayoutTestController::setDefersLoading is not implemented for chromium.
+
2011-07-11 Stephen White senorbla...@chromium.org
Unreviewed; chromium test expectations update.
Added: trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt (0 => 90779)
--- trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt 2011-07-11 19:33:32 UTC (rev 90779)
@@ -0,0 +1,3 @@
+For the test to pass there should be no crash.
+
+
Added: trunk/LayoutTests/loader/load-defer-resume-crash.html (0 => 90779)
--- trunk/LayoutTests/loader/load-defer-resume-crash.html (rev 0)
+++ trunk/LayoutTests/loader/load-defer-resume-crash.html 2011-07-11 19:33:32 UTC (rev 90779)
@@ -0,0 +1,24 @@
+html
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function run() {
+var frameElement = document.createElement('iframe')
+frameElement.setAttribute(src, resources/images.html);
+document.getElementById(frameDiv).appendChild(frameElement);
+if (window.layoutTestController) {
+layoutTestController.setDefersLoading(true);
+setTimeout(layoutTestController.setDefersLoading(false);layoutTestController.notifyDone();,1000);
+} else
+alert(Deferring loads);
+}
+
+/script
+body _onload_='run()'
+pFor the test to pass there should be no crash./p
+div id=frameDiv/div
+/body
+/html
Added: trunk/LayoutTests/loader/resources/images.html (0 => 90779)
--- trunk/LayoutTests/loader/resources/images.html (rev 0)
+++ trunk/LayoutTests/loader/resources/images.html 2011-07-11 19:33:32 UTC (rev 90779)
@@ -0,0 +1,6 @@
+html
+body
+img border=0 src=""
+img border=0 src=""
+/body
+/html
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90778 => 90779)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 19:20:49 UTC (rev 90778)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 19:33:32 UTC (rev 90779)
@@ -212,6 +212,7 @@
// Unskip after implementing
[webkit-changes] [90780] trunk/Source/WebCore
Title: [90780] trunk/Source/WebCore
Revision 90780
Author da...@chromium.org
Date 2011-07-11 12:55:25 -0700 (Mon, 11 Jul 2011)
Log Message
2011-07-11 Bradley Nelson bradnel...@chromium.org
Reviewed by Darin Fisher.
Split webcore_dom off webcore_remaining to reduce its size for
whole program optimization builds.
https://bugs.webkit.org/show_bug.cgi?id=64299
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/WebCore/ChangeLog (90779 => 90780)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 19:33:32 UTC (rev 90779)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 19:55:25 UTC (rev 90780)
@@ -1,3 +1,14 @@
+2011-07-11 Bradley Nelson bradnel...@chromium.org
+
+Reviewed by Darin Fisher.
+
+Split webcore_dom off webcore_remaining to reduce its size for
+whole program optimization builds.
+
+https://bugs.webkit.org/show_bug.cgi?id=64299
+
+* WebCore.gyp/WebCore.gyp:
+
2011-07-11 Yi Shen yi.4.s...@nokia.com
[Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (90779 => 90780)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-11 19:33:32 UTC (rev 90779)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-07-11 19:55:25 UTC (rev 90780)
@@ -1253,6 +1253,30 @@
],
},
{
+ 'target_name': 'webcore_dom',
+ 'type': 'static_library',
+ 'dependencies': [
+'webcore_prerequisites',
+ ],
+ 'sources': [
+'@(webcore_privateheader_files)',
+'@(webcore_files)',
+ ],
+ 'sources/': [
+# Start by excluding everything then include dom files only.
+['exclude', '.*'],
+['include', 'dom/'],
+
+# FIXME: Figure out how to store these patterns in a variable.
+['exclude', '(android|brew|cairo|ca|cf|cg|curl|efl|freetype|gstreamer|gtk|haiku|linux|mac|opengl|openvg|opentype|pango|posix|qt|soup|svg|symbian|texmap|iphone|win|wince|wx)/'],
+['exclude', '(?!Chromium)(Android|Cairo|CF|CG|Curl|Gtk|JSC|Linux|Mac|OpenType|POSIX|Posix|Qt|Safari|Soup|Symbian|Win|WinCE|Wx)\\.(cpp|mm?)$'],
+
+['exclude', 'AllInOne\\.cpp$'],
+['exclude', 'dom/StaticStringList\\.cpp$'],
+['exclude', 'dom/default/PlatformMessagePortChannel\\.(cpp|h)$'],
+ ],
+},
+{
'target_name': 'webcore_html',
'type': 'static_library',
'dependencies': [
@@ -1614,6 +1638,7 @@
'@(webcore_files)',
],
'sources/': [
+['exclude', 'dom/'],
['exclude', 'html/'],
['exclude', 'platform/'],
['exclude', 'rendering/'],
@@ -1636,8 +1661,6 @@
['exclude', 'AllInOne\\.cpp$'],
-['exclude', 'dom/StaticStringList\\.cpp$'],
-['exclude', 'dom/default/PlatformMessagePortChannel\\.(cpp|h)$'],
['exclude', 'fileapi/LocalFileSystem\\.cpp$'],
['exclude', 'inspector/InspectorFrontendClientLocal\\.cpp$'],
['exclude', 'inspector/_javascript_[^/]*\\.cpp$'],
@@ -1741,6 +1764,7 @@
'type': 'none',
'dependencies': [
'webcore_arm_neon',
+'webcore_dom',
'webcore_html',
'webcore_platform',
'webcore_remaining',
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90782] trunk/LayoutTests
Title: [90782] trunk/LayoutTests Revision 90782 Author jber...@webkit.org Date 2011-07-11 13:28:34 -0700 (Mon, 11 Jul 2011) Log Message WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading. https://bugs.webkit.org/show_bug.cgi?id=64313 Add loader/load-defer-resume-crash.html to the WK2 Skipped list in order to get the bots green. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90781 => 90782) --- trunk/LayoutTests/ChangeLog 2011-07-11 20:23:37 UTC (rev 90781) +++ trunk/LayoutTests/ChangeLog 2011-07-11 20:28:34 UTC (rev 90782) @@ -1,3 +1,13 @@ +2011-07-11 Jessie Berlin jber...@apple.com + +WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading. +https://bugs.webkit.org/show_bug.cgi?id=64313 + +Add loader/load-defer-resume-crash.html to the WK2 Skipped list in order to get the bots +green. + +* platform/wk2/Skipped: + 2011-07-11 Yi Shen yi.4.s...@nokia.com [Qt] ASSERTION FAILED in ResourceHandle::setDefersLoading causes crash Modified: trunk/LayoutTests/platform/wk2/Skipped (90781 => 90782) --- trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 20:23:37 UTC (rev 90781) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-11 20:28:34 UTC (rev 90782) @@ -1620,6 +1620,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=63806 http/tests/cache/history-only-cached-subresource-loads-max-age-https.html +# WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading +# https://bugs.webkit.org/show_bug.cgi?id=64313 +loader/load-defer-resume-crash.html + ### END OF (1) Classified failures with bug reports ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90783] S60/
Title: [90783] S60/ Revision 90783 Author aba...@webkit.org Date 2011-07-11 14:52:14 -0700 (Mon, 11 Jul 2011) Log Message Delete top-level S60 directory. This directory hasn't been touched in four years. r=smfr Removed Paths S60/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90784] trunk
Title: [90784] trunk
Revision 90784
Author yi.4.s...@nokia.com
Date 2011-07-11 15:00:11 -0700 (Mon, 11 Jul 2011)
Log Message
[Qt] Unreviewed rollout 90779 which may fail the layout-test.
Source/WebCore:
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
* platform/network/qt/QNetworkReplyHandler.h:
LayoutTests:
* loader/load-defer-resume-crash-expected.txt: Removed.
* loader/load-defer-resume-crash.html: Removed.
* loader/resources/images.html: Removed.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp
trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.h
Removed Paths
trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt
trunk/LayoutTests/loader/load-defer-resume-crash.html
trunk/LayoutTests/loader/resources/images.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90783 => 90784)
--- trunk/LayoutTests/ChangeLog 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 22:00:11 UTC (rev 90784)
@@ -1,3 +1,12 @@
+2011-07-11 Yi Shen yi.4.s...@nokia.com
+
+[Qt] Unreviewed rollout 90779 which may fail the layout-test.
+
+* loader/load-defer-resume-crash-expected.txt: Removed.
+* loader/load-defer-resume-crash.html: Removed.
+* loader/resources/images.html: Removed.
+* platform/chromium/test_expectations.txt:
+
2011-07-11 Jessie Berlin jber...@apple.com
WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading.
Deleted: trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt (90783 => 90784)
--- trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/LayoutTests/loader/load-defer-resume-crash-expected.txt 2011-07-11 22:00:11 UTC (rev 90784)
@@ -1,3 +0,0 @@
-For the test to pass there should be no crash.
-
-
Deleted: trunk/LayoutTests/loader/load-defer-resume-crash.html (90783 => 90784)
--- trunk/LayoutTests/loader/load-defer-resume-crash.html 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/LayoutTests/loader/load-defer-resume-crash.html 2011-07-11 22:00:11 UTC (rev 90784)
@@ -1,24 +0,0 @@
-html
-script
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-layoutTestController.waitUntilDone();
-}
-
-function run() {
-var frameElement = document.createElement('iframe')
-frameElement.setAttribute(src, resources/images.html);
-document.getElementById(frameDiv).appendChild(frameElement);
-if (window.layoutTestController) {
-layoutTestController.setDefersLoading(true);
-setTimeout(layoutTestController.setDefersLoading(false);layoutTestController.notifyDone();,1000);
-} else
-alert(Deferring loads);
-}
-
-/script
-body _onload_='run()'
-pFor the test to pass there should be no crash./p
-div id=frameDiv/div
-/body
-/html
Deleted: trunk/LayoutTests/loader/resources/images.html (90783 => 90784)
--- trunk/LayoutTests/loader/resources/images.html 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/LayoutTests/loader/resources/images.html 2011-07-11 22:00:11 UTC (rev 90784)
@@ -1,6 +0,0 @@
-html
-body
-img border=0 src=""
-img border=0 src=""
-/body
-/html
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90783 => 90784)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 22:00:11 UTC (rev 90784)
@@ -212,7 +212,6 @@
// Unskip after implementing LayoutTestController::setDefersLoading and ::goBack.
BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL
-BUGWK60877 SKIP : loader/load-defer-resume-crash.html = FAIL
// Skipped until new WebSocket protocol is implemented.
BUGWK50099 SKIP : http/tests/websocket/tests/hybi/ = PASS FAIL TIMEOUT
Modified: trunk/Source/WebCore/ChangeLog (90783 => 90784)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 22:00:11 UTC (rev 90784)
@@ -1,3 +1,11 @@
+2011-07-11 Yi Shen yi.4.s...@nokia.com
+
+[Qt] Unreviewed rollout 90779 which may fail the layout-test.
+
+* platform/network/qt/QNetworkReplyHandler.cpp:
+(WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
+* platform/network/qt/QNetworkReplyHandler.h:
+
2011-07-11 Bradley Nelson bradnel...@chromium.org
Reviewed by Darin Fisher.
Modified: trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp (90783 => 90784)
--- trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp 2011-07-11 21:52:14 UTC (rev 90783)
+++ trunk/Source/WebCore/platform/network/qt/QNetworkReplyHandler.cpp 2011-07-11 22:00:11 UTC (rev 90784)
@@ -181,7 +181,7
[webkit-changes] [90785] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [90785] trunk/Tools/Scripts/webkitpy/common/config/committers.py Revision 90785 Author dslo...@google.com Date 2011-07-11 15:24:34 -0700 (Mon, 11 Jul 2011) Log Message Unreviewed, adding myself as a committer Modified Paths trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (90784 => 90785) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-11 22:00:11 UTC (rev 90784) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-07-11 22:24:34 UTC (rev 90785) @@ -139,6 +139,7 @@ Committer(David Smith, [catfish@gmail.com, dsm...@webkit.org], catfishman), Committer(Dean Jackson, d...@apple.com, dino), Committer(Diego Gonzalez, [diego...@webkit.org, diego.gonza...@openbossa.org], diegohcg), +Committer(Dmitry Lomov, [dslo...@google.com, dslo...@chromium.org], dslomov), Committer(Dominic Cooney, domin...@chromium.org, dominicc), Committer(Drew Wilson, atwil...@chromium.org, atwilson), Committer(Eli Fidler, e...@staikos.net, QBin), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90786] trunk/Tools
Title: [90786] trunk/Tools
Revision 90786
Author mrobin...@webkit.org
Date 2011-07-11 15:29:21 -0700 (Mon, 11 Jul 2011)
Log Message
[GTK] [NRWT] Pixel tests do not work
https://bugs.webkit.org/show_bug.cgi?id=64091
Reviewed by Eric Seidel.
Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
path to the ImageDiff binary.
* Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py
Diff
Modified: trunk/Tools/ChangeLog (90785 => 90786)
--- trunk/Tools/ChangeLog 2011-07-11 22:24:34 UTC (rev 90785)
+++ trunk/Tools/ChangeLog 2011-07-11 22:29:21 UTC (rev 90786)
@@ -1,3 +1,15 @@
+2011-07-11 Martin Robinson mrobin...@igalia.com
+
+[GTK] [NRWT] Pixel tests do not work
+https://bugs.webkit.org/show_bug.cgi?id=64091
+
+Reviewed by Eric Seidel.
+
+Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
+path to the ImageDiff binary.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
+
2011-07-11 Dirk Pranke dpra...@chromium.org
Fix hang on win32 in a multiprocessing test that shouldn't have been running.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90785 => 90786)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-11 22:24:34 UTC (rev 90785)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-11 22:29:21 UTC (rev 90786)
@@ -77,6 +77,9 @@
def _path_to_driver(self):
return self._build_path('Programs', self.driver_name())
+def _path_to_image_diff(self):
+return self._build_path('Programs', 'ImageDiff')
+
def check_build(self, needs_http):
return self._check_driver()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90787] trunk/LayoutTests
Title: [90787] trunk/LayoutTests Revision 90787 Author dpra...@chromium.org Date 2011-07-11 15:30:48 -0700 (Mon, 11 Jul 2011) Log Message Skip plugins/evaluate-js-after-removing-plugin-element.html on Chromium Vista. https://bugs.webkit.org/show_bug.cgi?id=64319 Unreviewed, expectations change. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90786 => 90787) --- trunk/LayoutTests/ChangeLog 2011-07-11 22:29:21 UTC (rev 90786) +++ trunk/LayoutTests/ChangeLog 2011-07-11 22:30:48 UTC (rev 90787) @@ -1,3 +1,13 @@ +2011-07-11 Dirk Pranke dpra...@chromium.org + +Skip plugins/evaluate-js-after-removing-plugin-element.html on Chromium Vista. + +https://bugs.webkit.org/show_bug.cgi?id=64319 + +Unreviewed, expectations change. + +* platform/chromium/test_expectations.txt: + 2011-07-11 Yi Shen yi.4.s...@nokia.com [Qt] Unreviewed rollout 90779 which may fail the layout-test. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90786 => 90787) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 22:29:21 UTC (rev 90786) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 22:30:48 UTC (rev 90787) @@ -765,7 +765,9 @@ // Plugin tests // - BUGCR21841 MAC WIN DEBUG : plugins/destroy-during-npp-new.html = CRASH PASS -BUGCR61799 : plugins/evaluate-js-after-removing-plugin-element.html = CRASH TEXT TIMEOUT + +// This test seems to hang on Vista, in addition to the other problems. +BUGWK64319 BUGCR61799 SKIP : plugins/evaluate-js-after-removing-plugin-element.html = CRASH TEXT TIMEOUT BUGCR37962 MAC : plugins/iframe-shims.html = TEXT PASS TIMEOUT BUGCR10351 MAC : plugins/inner-html-display-none.html = FAIL BUGWK48164 MAC LINUX WIN : plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90788] trunk/Source/WebCore
Title: [90788] trunk/Source/WebCore Revision 90788 Author mrobin...@webkit.org Date 2011-07-11 15:43:00 -0700 (Mon, 11 Jul 2011) Log Message Reviewed by Daniel Bates. [GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering https://bugs.webkit.org/show_bug.cgi?id=62752 Instead of offsetting the cursor blit by the hotspot, just pass the hotspot arguments to the GdkCursor constructor. No new tests. This is covered by manual-tests/cursor.html. * platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/CursorGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (90787 => 90788) --- trunk/Source/WebCore/ChangeLog 2011-07-11 22:30:48 UTC (rev 90787) +++ trunk/Source/WebCore/ChangeLog 2011-07-11 22:43:00 UTC (rev 90788) @@ -1,3 +1,18 @@ +2011-07-11 Martin Robinson mrobin...@igalia.com + +Reviewed by Daniel Bates. + +[GTK] Transition to Mozilla named cursors have incorrect hotspot and rendering +https://bugs.webkit.org/show_bug.cgi?id=62752 + +Instead of offsetting the cursor blit by the hotspot, just pass the hotspot +arguments to the GdkCursor constructor. + +No new tests. This is covered by manual-tests/cursor.html. + +* platform/gtk/CursorGtk.cpp: +(WebCore::createNamedCursor): + 2011-07-11 Yi Shen yi.4.s...@nokia.com [Qt] Unreviewed rollout 90779 which may fail the layout-test. Modified: trunk/Source/WebCore/platform/gtk/CursorGtk.cpp (90787 => 90788) --- trunk/Source/WebCore/platform/gtk/CursorGtk.cpp 2011-07-11 22:30:48 UTC (rev 90787) +++ trunk/Source/WebCore/platform/gtk/CursorGtk.cpp 2011-07-11 22:43:00 UTC (rev 90788) @@ -52,11 +52,11 @@ RefPtrcairo_surface_t surface = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_A1, 32, 32)); RefPtrcairo_t cr = adoptRef(cairo_create(surface.get())); -cairo_set_source_surface(cr.get(), source.get(), cursor.hot_x, cursor.hot_y); -cairo_mask_surface(cr.get(), mask.get(), cursor.hot_x, cursor.hot_y); +cairo_set_source_surface(cr.get(), source.get(), 0, 0); +cairo_mask_surface(cr.get(), mask.get(), 0, 0); GRefPtrGdkPixbuf pixbuf = adoptGRef(gdk_pixbuf_get_from_surface(surface.get(), 0, 0, 32, 32)); -return adoptGRef(gdk_cursor_new_from_pixbuf(gdk_display_get_default(), pixbuf.get(), 0, 0)); +return adoptGRef(gdk_cursor_new_from_pixbuf(gdk_display_get_default(), pixbuf.get(), cursor.hot_x, cursor.hot_y)); } static GRefPtrGdkCursor createCustomCursor(Image* image, const IntPoint hotSpot) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90790] trunk/Source/WebKit/chromium
Title: [90790] trunk/Source/WebKit/chromium
Revision 90790
Author rn...@webkit.org
Date 2011-07-11 16:23:58 -0700 (Mon, 11 Jul 2011)
Log Message
Rolled Chromium DEPS.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (90789 => 90790)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-07-11 22:48:15 UTC (rev 90789)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-07-11 23:23:58 UTC (rev 90790)
@@ -1,3 +1,9 @@
+2011-07-11 Ryosuke Niwa rn...@webkit.org
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-07-08 Nate Chapin jap...@chromium.org
Check activeDocumentLoader() in
Modified: trunk/Source/WebKit/chromium/DEPS (90789 => 90790)
--- trunk/Source/WebKit/chromium/DEPS 2011-07-11 22:48:15 UTC (rev 90789)
+++ trunk/Source/WebKit/chromium/DEPS 2011-07-11 23:23:58 UTC (rev 90790)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '91661'
+ 'chromium_rev': '92015'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90792] trunk/LayoutTests
Title: [90792] trunk/LayoutTests Revision 90792 Author dpra...@chromium.org Date 2011-07-11 16:33:11 -0700 (Mon, 11 Jul 2011) Log Message update the boilerplate documentation in the test_expectations.txt files https://bugs.webkit.org/show_bug.cgi?id=64221 Reviewed by Eric Seidel. The test expectations files either had documentation for the Chromium port's version of the file (which was also incorrect), or were undocumented. This adds a comment with a link to the documentation for the file to each. * platform/chromium/test_expectations.txt: * platform/gtk/test_expectations.txt: * platform/mac/test_expectations.txt: * platform/qt/test_expectations.txt: * platform/win/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/gtk/test_expectations.txt trunk/LayoutTests/platform/mac/test_expectations.txt trunk/LayoutTests/platform/qt/test_expectations.txt trunk/LayoutTests/platform/win/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90791 => 90792) --- trunk/LayoutTests/ChangeLog 2011-07-11 23:31:19 UTC (rev 90791) +++ trunk/LayoutTests/ChangeLog 2011-07-11 23:33:11 UTC (rev 90792) @@ -1,5 +1,23 @@ 2011-07-11 Dirk Pranke dpra...@chromium.org +update the boilerplate documentation in the test_expectations.txt files +https://bugs.webkit.org/show_bug.cgi?id=64221 + +Reviewed by Eric Seidel. + +The test expectations files either had documentation for the +Chromium port's version of the file (which was also incorrect), +or were undocumented. This adds a comment with a link to the +documentation for the file to each. + +* platform/chromium/test_expectations.txt: +* platform/gtk/test_expectations.txt: +* platform/mac/test_expectations.txt: +* platform/qt/test_expectations.txt: +* platform/win/test_expectations.txt: + +2011-07-11 Dirk Pranke dpra...@chromium.org + Skip plugins/evaluate-js-after-removing-plugin-element.html on Chromium Vista. https://bugs.webkit.org/show_bug.cgi?id=64319 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90791 => 90792) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:31:19 UTC (rev 90791) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:33:11 UTC (rev 90792) @@ -1,60 +1,6 @@ -// This file consists of lines with specifications of what -// to expect from layout test cases. The test cases can be directories -// in which case the expectations apply to all test cases in that -// directory and any subdirectory. The format of the file is along the -// lines of: +// These are the layout test expectations for the Chromium port(s) of WebKit. // -// fast/js/fixme.js = FAIL -// fast/js/flaky.js = FAIL PASS -// fast/js/crash.js = CRASH TIMEOUT FAIL PASS -// -// The format of a test line is as follows: -// METADATA : relative/path/to/test.html = EXPECTATIONS -// -// Valid values for METADATA: -// -// BUG(CR|WK|V8_)[0-9]+: See this chromium/webkit/v8 bug for more information. -// Every test that isn't marked WONTFIX should have the -// appropriate BUG annotation. -// SKIP: Doesn't run the test. -// SLOW: The test takes a long time to run, but does not timeout indefinitely. -// WONTFIX: For tests that we never intend to pass on a given platform. -// DEBUG: Expectations apply only to the debug build. -// RELEASE: Expectations apply only to release build. -// LINUX/WIN/XP/VISTA/MAC: Expectations apply only to these platforms. -// GPU/CPU: Expectations only apply to a particular compositor. Default: both. -// -// Valid values for EXPECTATIONS: -// -// PASS: Test should pass -// CRASH: Test should crash -// TIMEOUT: Test should timeout -// IMAGE: Test will produce an incorrect image dump -// TEXT: Test will produce incorrect text output (either full or simplified) -// IMAGE+TEXT: Test will produce both incorrect text and images -// FAIL: Test will produce either incorrect text, images, or both -// -// If a line contains multiple expectations, it is considered flakey, -// because it means that we're not producing consistent, reliable results. -// -// For example, -// LINUX : media = PASS FAIL -// -// The above means that all the media tests are flaky, but only on Linux. -// -// Other examples: -// -// SKIP : fast/js/no-good.js = TIMEOUT PASS -// DEBUG : fast/js/no-good.js = TIMEOUT PASS -// DEBUG SKIP : fast/js/no-good.js = TIMEOUT PASS -// LINUX DEBUG SKIP : fast/js/no-good.js = TIMEOUT PASS -// BUGCR1234 DEBUG MAC : fast/js/no-good.js = TIMEOUT PASS -// -// Notes: -// -A test cannot be both SLOW and TIMEOUT -// -A test can be included twice, but not via the same path. -// -If a test is included twice, then the more precise path wins. -// -CRASH tests cannot be WONTFIX +// See http://trac.webkit.org/wiki/TestExpectations for more
[webkit-changes] [90793] trunk/Tools
Title: [90793] trunk/Tools Revision 90793 Author rn...@webkit.org Date 2011-07-11 16:35:13 -0700 (Mon, 11 Jul 2011) Log Message webkit-patch roll-chromium-deps no longer works https://bugs.webkit.org/show_bug.cgi?id=64324 Reviewed by James Robinson. Lower the minimum commit message length to 10. * Scripts/webkitpy/tool/steps/commit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/steps/commit.py Diff Modified: trunk/Tools/ChangeLog (90792 => 90793) --- trunk/Tools/ChangeLog 2011-07-11 23:33:11 UTC (rev 90792) +++ trunk/Tools/ChangeLog 2011-07-11 23:35:13 UTC (rev 90793) @@ -1,3 +1,14 @@ +2011-07-11 Ryosuke Niwa rn...@webkit.org + +webkit-patch roll-chromium-deps no longer works +https://bugs.webkit.org/show_bug.cgi?id=64324 + +Reviewed by James Robinson. + +Lower the minimum commit message length to 10. + +* Scripts/webkitpy/tool/steps/commit.py: + 2011-07-11 Alice Boxhall aboxh...@chromium.org Convert json_results_generator.py to output version 4 JSON. Modified: trunk/Tools/Scripts/webkitpy/tool/steps/commit.py (90792 => 90793) --- trunk/Tools/Scripts/webkitpy/tool/steps/commit.py 2011-07-11 23:33:11 UTC (rev 90792) +++ trunk/Tools/Scripts/webkitpy/tool/steps/commit.py 2011-07-11 23:35:13 UTC (rev 90793) @@ -44,8 +44,8 @@ def run(self, state): self._commit_message = self._tool.checkout().commit_message_for_this_commit(self._options.git_commit).message() -if len(self._commit_message) 50: -raise Exception(Attempted to commit with a commit message shorter than 50 characters. Either your patch is missing a ChangeLog or webkit-patch may have a bug.) +if len(self._commit_message) 10: +raise Exception(Attempted to commit with a commit message shorter than 10 characters. Either your patch is missing a ChangeLog or webkit-patch may have a bug.) self._state = state ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90794] trunk/LayoutTests
Title: [90794] trunk/LayoutTests Revision 90794 Author o...@chromium.org Date 2011-07-11 16:49:30 -0700 (Mon, 11 Jul 2011) Log Message Update expectation that was missed because the WIN7 bot was down for a long time. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (90793 => 90794) --- trunk/LayoutTests/ChangeLog 2011-07-11 23:35:13 UTC (rev 90793) +++ trunk/LayoutTests/ChangeLog 2011-07-11 23:49:30 UTC (rev 90794) @@ -1,3 +1,8 @@ +2011-07-11 Ojan Vafai o...@chromium.org + +Update expectation that was missed because the WIN7 bot was down for a long time. +* platform/chromium/test_expectations.txt: + 2011-07-11 Dirk Pranke dpra...@chromium.org update the boilerplate documentation in the test_expectations.txt files Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90793 => 90794) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:35:13 UTC (rev 90793) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:49:30 UTC (rev 90794) @@ -3856,7 +3856,7 @@ BUGWK64028 WIN LINUX : media/adopt-node-crash.html = CRASH PASS BUGCR88594 WIN7 : fast/loader/recursive-before-unload-crash.html = TIMEOUT -BUGCR88594 WIN7 : fast/storage/storage-detached-iframe.html = TIMEOUT +BUGCR88594 BUGWK61326 WIN7 : fast/storage/storage-detached-iframe.html = CRASH TIMEOUT BUGCR88594 WIN7 : http/tests/appcache/access-via-redirect.php = TIMEOUT BUGCR88594 WIN7 : http/tests/appcache/crash-when-navigating-away-then-back.html = TIMEOUT BUGCR88594 WIN7 : http/tests/appcache/credential-url.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90795] trunk/LayoutTests
Title: [90795] trunk/LayoutTests Revision 90795 Author o...@chromium.org Date 2011-07-11 16:55:16 -0700 (Mon, 11 Jul 2011) Log Message Win7 rebaselines after http://trac.webkit.org/changeset/90701. Should have been part of http://trac.webkit.org/changeset/90716/, but the Win7 bot was down at that time. * platform/chromium-win/http/tests/loading/simple-subframe-expected.png: * platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png: * platform/chromium-win/http/tests/misc/acid2-pixel-expected.png: * platform/chromium-win/http/tests/misc/iframe404-expected.png: * platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png: * platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png: * platform/chromium-win/http/tests/navigation/_javascript_link-frames-expected.png: * platform/chromium/test_expectations.txt: Removing useless duplicated comment line. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/http/tests/loading/simple-subframe-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/misc/acid2-pixel-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/misc/iframe404-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png trunk/LayoutTests/platform/chromium-win/http/tests/navigation/_javascript_link-frames-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (90794 => 90795) --- trunk/LayoutTests/ChangeLog 2011-07-11 23:49:30 UTC (rev 90794) +++ trunk/LayoutTests/ChangeLog 2011-07-11 23:55:16 UTC (rev 90795) @@ -1,5 +1,21 @@ 2011-07-11 Ojan Vafai o...@chromium.org +Win7 rebaselines after http://trac.webkit.org/changeset/90701. +Should have been part of http://trac.webkit.org/changeset/90716/, +but the Win7 bot was down at that time. + +* platform/chromium-win/http/tests/loading/simple-subframe-expected.png: +* platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png: +* platform/chromium-win/http/tests/misc/acid2-pixel-expected.png: +* platform/chromium-win/http/tests/misc/iframe404-expected.png: +* platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png: +* platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png: +* platform/chromium-win/http/tests/navigation/_javascript_link-frames-expected.png: +* platform/chromium/test_expectations.txt: +Removing useless duplicated comment line. + +2011-07-11 Ojan Vafai o...@chromium.org + Update expectation that was missed because the WIN7 bot was down for a long time. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (90794 => 90795) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:49:30 UTC (rev 90794) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-07-11 23:55:16 UTC (rev 90795) @@ -20,7 +20,6 @@ BUGCR24182 WIN RELEASE : http/tests/loading/redirect-methods.html = PASS TIMEOUT BUGCR24182 SLOW MAC RELEASE : dom/html/level2/html/HTMLImageElement01.html = PASS -//BUGCR24182 SLOW WIN RELEASE : http/tests/local/file-url-sent-as-referer.html = PASS BUGCR24182 SLOW LINUX DEBUG : fast/xpath/4XPath/Borrowed/cz_20030217.html = PASS //BUGCR24852 started failing since webkit 49583 BUGCR24182 SLOW WIN : http/tests/security/xssAuditor/meta-tag-http-refresh-_javascript_-url.html = PASS Modified: trunk/LayoutTests/platform/chromium-win/http/tests/loading/simple-subframe-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/local/file-url-sent-as-referer-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/misc/acid2-pixel-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/misc/iframe404-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/multipart/invalid-image-data-standalone-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/http/tests/navigation/_javascript_link-frames-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90796] trunk/Tools
Title: [90796] trunk/Tools Revision 90796 Author dpra...@chromium.org Date 2011-07-11 17:10:19 -0700 (Mon, 11 Jul 2011) Log Message nrwt: linting fixes https://bugs.webkit.org/show_bug.cgi?id=64225 Reviewed by Eric Siedel. Miscellaneous linting fixes. The most notable change is that we add public attributes for user, executive, filesystem, and options on the Port object, so we don't have to refer to the protected versions all over the place. * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: * Scripts/webkitpy/layout_tests/controllers/message_broker.py: * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: * Scripts/webkitpy/layout_tests/controllers/worker.py: * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/controllers/worker.py trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py Diff Modified: trunk/Tools/ChangeLog (90795 => 90796) --- trunk/Tools/ChangeLog 2011-07-11 23:55:16 UTC (rev 90795) +++ trunk/Tools/ChangeLog 2011-07-12 00:10:19 UTC (rev 90796) @@ -1,3 +1,23 @@ +2011-07-08 Dirk Pranke dpra...@chromium.org + +nrwt: linting fixes +https://bugs.webkit.org/show_bug.cgi?id=64225 + +Reviewed by Eric Siedel. + +Miscellaneous linting fixes. The most notable change is that +we add public attributes for user, executive, filesystem, and +options on the Port object, so we don't have to refer to the +protected versions all over the place. + +* Scripts/webkitpy/layout_tests/controllers/manager.py: +* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: +* Scripts/webkitpy/layout_tests/controllers/message_broker.py: +* Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: +* Scripts/webkitpy/layout_tests/controllers/worker.py: +* Scripts/webkitpy/layout_tests/port/base.py: +* Scripts/webkitpy/layout_tests/run_webkit_tests.py: + 2011-07-11 Ryosuke Niwa rn...@webkit.org webkit-patch roll-chromium-deps no longer works Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (90795 => 90796) --- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-07-11 23:55:16 UTC (rev 90795) +++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-07-12 00:10:19 UTC (rev 90796) @@ -37,7 +37,6 @@ from __future__ import with_statement -import copy import errno import logging import math @@ -53,7 +52,6 @@ from webkitpy.layout_tests.controllers import worker from webkitpy.layout_tests.layout_package import json_layout_results_generator from webkitpy.layout_tests.layout_package import json_results_generator -from webkitpy.layout_tests.layout_package import test_results_uploader from webkitpy.layout_tests.models import test_expectations from webkitpy.layout_tests.models import test_failures from webkitpy.layout_tests.models import test_results @@ -61,7 +59,6 @@ from webkitpy.layout_tests.models.result_summary import ResultSummary from webkitpy.layout_tests.views import printing -from webkitpy.thirdparty import simplejson from webkitpy.tool import grammar _log = logging.getLogger(__name__) @@ -223,6 +220,7 @@ class TestRunInterruptedException(Exception): Raised when a test run should be stopped immediately. def __init__(self, reason): +Exception.__init__(self) self.reason = reason self.msg = reason @@ -269,10 +267,11 @@ printer: a Printer object to record updates to. self._port = port -self._fs = port._filesystem +self._fs = port.filesystem self._options = options self._printer = printer self._message_broker = None +self._expectations = None self.HTTP_SUBDIR = port.TEST_PATH_SEPARATOR + 'http' + port.TEST_PATH_SEPARATOR self.WEBSOCKET_SUBDIR = port.TEST_PATH_SEPARATOR + 'websocket' + port.TEST_PATH_SEPARATOR @@ -322,7 +321,7 @@ if path.startswith(self.LAYOUT_TESTS_DIRECTORY + self._port.TEST_PATH_SEPARATOR): return path[len(self.LAYOUT_TESTS_DIRECTORY + self._port.TEST_PATH_SEPARATOR):] if path.startswith(self.LAYOUT_TESTS_DIRECTORY + self._fs.sep): -return path[len(self.LAYOUT_TEST_DIRECTORY + self._fs.sep):] +return path[len(self.LAYOUT_TESTS_DIRECTORY + self._fs.sep):] return path def lint(self): @@
[webkit-changes] [90797] trunk/Source/WebCore
Title: [90797] trunk/Source/WebCore
Revision 90797
Author jer.no...@apple.com
Date 2011-07-11 17:30:54 -0700 (Mon, 11 Jul 2011)
Log Message
HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
https://bugs.webkit.org/show_bug.cgi?id=64327
Reviewed by Darin Adler.
No new tests; no change in functionality, so covered by existing tests.
Make the rules from fullscreenQuickTime.css !important so they are not overridden
by page authors.
* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/fullscreenQuickTime.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (90796 => 90797)
--- trunk/Source/WebCore/ChangeLog 2011-07-12 00:10:19 UTC (rev 90796)
+++ trunk/Source/WebCore/ChangeLog 2011-07-12 00:30:54 UTC (rev 90797)
@@ -1,3 +1,18 @@
+2011-07-11 Jer Noble jer.no...@apple.com
+
+HTML5 video controller in fullscreen is partly off-screen (at least on youtube) using ClickToFlash
+https://bugs.webkit.org/show_bug.cgi?id=64327
+
+Reviewed by Darin Adler.
+
+No new tests; no change in functionality, so covered by existing tests.
+
+Make the rules from fullscreenQuickTime.css !important so they are not overridden
+by page authors.
+
+* css/fullscreenQuickTime.css:
+(video:-webkit-full-screen::-webkit-media-controls-panel):
+
2011-07-11 Levi Weintraub le...@chromium.org
Switch lineTop and lineBottom to new layout types
Modified: trunk/Source/WebCore/css/fullscreenQuickTime.css (90796 => 90797)
--- trunk/Source/WebCore/css/fullscreenQuickTime.css 2011-07-12 00:10:19 UTC (rev 90796)
+++ trunk/Source/WebCore/css/fullscreenQuickTime.css 2011-07-12 00:30:54 UTC (rev 90797)
@@ -25,16 +25,16 @@
/* alternate media controls - Extend fullscreen.css */
video:-webkit-full-screen::-webkit-media-controls-panel {
--webkit-box-align: start;
--webkit-box-pack: end;
--webkit-appearance: none;
+-webkit-box-align: start !important;
+-webkit-box-pack: end !important;
+-webkit-appearance: none !important;
-bottom: 50px;
-left: 50%;
-margin-left: -220px;
-padding: 12px 0 0 10px;
-width: 430px;
-height: 48px;
+bottom: 50px !important;
+left: 50% !important;
+margin-left: -220px !important;
+padding: 12px 0 0 10px !important;
+width: 430px !important;
+height: 48px !important;
background-image: -webkit-gradient(
linear,
@@ -46,16 +46,16 @@
color-stop(0.366, rgba(25, 25, 25, .97)),
color-stop(0.366, rgba(12, 12, 12, .97)),
color-stop(1, rgba(19, 19, 19, .97))
-);
+) !important;
-webkit-box-shadow:
inset 0 -1px 1px rgba(0, 0, 0, 0.5),
inset 0 1px 0 0px rgba(255, 255, 255, 0.15),
inset 0 -1px 0 0px rgba(202, 202, 202, 0.09),
0 0 0 1px rgba(0, 0, 0, 0.5);
--webkit-border-radius: 8px;
+-webkit-border-radius: 8px !important;
--webkit-transition: opacity 0.3s linear;
+-webkit-transition: opacity 0.3s linear !important;
}
video:-webkit-animating-full-screen-transition::-webkit-media-controls-panel {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90799] trunk/Source/JavaScriptCore
Title: [90799] trunk/Source/_javascript_Core
Revision 90799
Author commit-qu...@webkit.org
Date 2011-07-11 18:10:07 -0700 (Mon, 11 Jul 2011)
Log Message
DFG speculative JIT does not guard itself against floating point speculation
failures on non-floating-point constants.
https://bugs.webkit.org/show_bug.cgi?id=64330
Patch by Filip Pizlo fpi...@apple.com on 2011-07-11
Reviewed by Gavin Barraclough.
Made fillSpeculateDouble immediate invoke terminateSpeculativeExecution() as
soon as it notices that it's speculating on something that is a non-numeric
JSConstant.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (90798 => 90799)
--- trunk/Source/_javascript_Core/ChangeLog 2011-07-12 00:39:46 UTC (rev 90798)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-07-12 01:10:07 UTC (rev 90799)
@@ -1,5 +1,20 @@
2011-07-11 Filip Pizlo fpi...@apple.com
+DFG speculative JIT does not guard itself against floating point speculation
+failures on non-floating-point constants.
+https://bugs.webkit.org/show_bug.cgi?id=64330
+
+Reviewed by Gavin Barraclough.
+
+Made fillSpeculateDouble immediate invoke terminateSpeculativeExecution() as
+soon as it notices that it's speculating on something that is a non-numeric
+JSConstant.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
+
+2011-07-11 Filip Pizlo fpi...@apple.com
+
DFG Speculative JIT does not always insert speculation checks when speculating
arrays.
https://bugs.webkit.org/show_bug.cgi?id=64254
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (90798 => 90799)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-07-12 00:39:46 UTC (rev 90798)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-07-12 01:10:07 UTC (rev 90799)
@@ -206,12 +206,8 @@
info.fillDouble(fpr);
return fpr;
}
-ASSERT(isJSConstant(nodeIndex));
-JSValue jsValue = valueOfJSConstant(nodeIndex);
-m_jit.move(MacroAssembler::ImmPtr(JSValue::encode(jsValue)), gpr);
-m_gprs.retain(gpr, virtualRegister, SpillOrderConstant);
-info.fillJSValue(gpr, DataFormatJS);
-unlock(gpr);
+terminateSpeculativeExecution();
+return fprAllocate();
} else {
DataFormat spillFormat = info.spillFormat();
ASSERT(spillFormat DataFormatJS);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90800] trunk
Title: [90800] trunk
Revision 90800
Author rn...@webkit.org
Date 2011-07-11 18:10:32 -0700 (Mon, 11 Jul 2011)
Log Message
positionForPoint is broken when a block is positioned relatively inside the parent
https://bugs.webkit.org/show_bug.cgi?id=64298
Reviewed by Simon Fraser.
Source/WebCore:
The bug was caused by positionForPointRespectingEditingBoundaries's not taking relativePositionOffset
into account when computing the point in child coordinates. Fixed the bug by adding the offset to
childLocation as needed.
Test: fast/block/positioning/hittest-on-relative-positioned-children.html
* rendering/RenderBlock.cpp:
(WebCore::positionForPointRespectingEditingBoundaries): Fixed the bug; also replaced all instances of
IntPoint by LayoutPoint.
LayoutTests:
Added a test for hit testing on relatively positioned children.
* fast/block/positioning/hittest-on-relative-positioned-children-expected.txt: Added.
* fast/block/positioning/hittest-on-relative-positioned-children.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children-expected.txt
trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children.html
Diff
Modified: trunk/LayoutTests/ChangeLog (90799 => 90800)
--- trunk/LayoutTests/ChangeLog 2011-07-12 01:10:07 UTC (rev 90799)
+++ trunk/LayoutTests/ChangeLog 2011-07-12 01:10:32 UTC (rev 90800)
@@ -1,3 +1,15 @@
+2011-07-11 Ryosuke Niwa rn...@webkit.org
+
+positionForPoint is broken when a block is positioned relatively inside the parent
+https://bugs.webkit.org/show_bug.cgi?id=64298
+
+Reviewed by Simon Fraser.
+
+Added a test for hit testing on relatively positioned children.
+
+* fast/block/positioning/hittest-on-relative-positioned-children-expected.txt: Added.
+* fast/block/positioning/hittest-on-relative-positioned-children.html: Added.
+
2011-07-11 Dan Bernstein m...@apple.com
Excessive expansion of justified text when rounding hacks are enabled
Added: trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children-expected.txt (0 => 90800)
--- trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children-expected.txt 2011-07-12 01:10:32 UTC (rev 90800)
@@ -0,0 +1,16 @@
+This tests hit testing on relative positioned children. To manually test, select text by a mouse drag starting in the blue box but outside red boxes and ending inside a red box.
+
+PASS Selecting line 1 of box 1 selected first line
+PASS Selecting line 2 of box 1 selected second line
+PASS Selecting line 3 of box 1 selected third line
+PASS Selecting line 1 of box 2 selected first line
+PASS Selecting line 2 of box 2 selected second line
+PASS Selecting line 3 of box 2 selected third line
+PASS Selecting line 1 of box 3 selected first line
+PASS Selecting line 2 of box 3 selected second line
+PASS Selecting line 3 of box 3 selected third line
+PASS Selecting line 1 of box 4 selected first line
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children.html (0 => 90800)
--- trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children.html (rev 0)
+++ trunk/LayoutTests/fast/block/positioning/hittest-on-relative-positioned-children.html 2011-07-12 01:10:32 UTC (rev 90800)
@@ -0,0 +1,77 @@
+!DOCTYPE html
+html
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=descriptionThis tests hit testing on relative positioned children. To manually test, select text by a mouse drag
+starting in the blue box but outside red boxes and ending inside a red box./p
+div id=tests style=margin-bottom: 200px; width: 300px; border: solid 5px #ccf;
+div style=position: relative; left: 50px; width: 200px; border: solid 5px #f66;
+first linebr
+second linebr
+third linebr
+/div
+div style=position: relative; left: 300px; width: 200px; border: solid 5px #f66;
+first linebr
+second linebr
+third linebr
+/div
+div style=position: relative; left: 250px; width: 200px; border: solid 5px #f66;
+first linebr
+second linebr
+third linebr
+/div
+div class=testVerticalSelection style=position: relative; top: 4em; width: 200px; border: solid 5px #f66;
+first linebr
+second linebr
+third linebr
+/div
+/div
+div id=console/div
+script
+
+function runTest(boxName, testDiv) {
+var testVerticalSelection = testDiv.className == 'testVerticalSelection';
+
+var expectedString = [null, first line, second line, third line];
+for (var line = 1; line = 3; line++) {
+var y = testDiv.offsetTop + testDiv.offsetHeight * (line - 1) / 3 + 5;
+if (testVerticalSelection)
+
[webkit-changes] [90801] trunk/LayoutTests
Title: [90801] trunk/LayoutTests Revision 90801 Author yu...@chromium.org Date 2011-07-11 18:26:12 -0700 (Mon, 11 Jul 2011) Log Message WebSocket: Remove WebSocket tests that do not apply to hybi protocol https://bugs.webkit.org/show_bug.cgi?id=64288 Reviewed by Kent Tamura. Remove tests from http/tests/websocket/tests/hybi that are not meaningful in terms of the hybi protocol. The most recent WebSocket protocol draft is available at http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-10, and referred as hybi-10 here. * http/tests/websocket/tests/hybi/error-detect-expected.txt: Removed. * http/tests/websocket/tests/hybi/error-detect.html: Removed. Hybi protocol has a completely different scheme of representing frame types. Additionally, hybi-10 no longer fires error events (which invoke onerror handler). * http/tests/websocket/tests/hybi/fixed-origin_wsh.py: Removed. * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt: Removed. * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html: Removed. Variable-length encoding (which is used to represent frame length in hixie-76) is no longer used in hybi-10. * http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py: Removed. * http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt: Removed. * http/tests/websocket/tests/hybi/frame-length-overflow.html: Removed. Ditto. * http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py: Removed. * http/tests/websocket/tests/hybi/frame-length-skip-expected.txt: Removed. * http/tests/websocket/tests/hybi/frame-length-skip.html: Removed. There are two ways to indicate the length of a frame in hixie-76 protocol, but hybi-10 has only one method (length-prefixed frames). Skipping unwanted frames will be covered by other tests that will be added in a later patch. * http/tests/websocket/tests/hybi/frame-length-skip_wsh.py: Removed. * http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt: Removed. * http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html: Removed. In hybi-10, servers no longer returns Origin header in handshake response, and clients are not required to validate this value. * http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt: Removed. * http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html: Removed. In hybi-10, clients are not required to (and must not) compare the values of subprotocols in client's request and server's response. * http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py: Removed. * http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt: Removed. * http/tests/websocket/tests/hybi/url-with-query-for-no-query.html: Removed. In hybi-10, servers do not provide Sec-WebSocket-Location header, and clients are not required to validate this value. * http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt: Removed. * http/tests/websocket/tests/hybi/websocket-protocol-ignored.html: Removed. Same as handshake-fail-by-sub-protocol-mismatch.html. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/http/tests/websocket/tests/hybi/error-detect-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/error-detect.html trunk/LayoutTests/http/tests/websocket/tests/hybi/fixed-origin_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-longer-than-buffer-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-longer-than-buffer.html trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-longer-than-buffer_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-overflow-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-overflow.html trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-overflow_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-skip-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-skip.html trunk/LayoutTests/http/tests/websocket/tests/hybi/frame-length-skip_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-cross-origin.html trunk/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/handshake-fail-by-sub-protocol-mismatch.html trunk/LayoutTests/http/tests/websocket/tests/hybi/unknown-frame-type_wsh.py trunk/LayoutTests/http/tests/websocket/tests/hybi/url-with-query-for-no-query-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/url-with-query-for-no-query.html trunk/LayoutTests/http/tests/websocket/tests/hybi/websocket-protocol-ignored-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/websocket-protocol-ignored.html Diff Modified: trunk/LayoutTests/ChangeLog (90800 => 90801)
[webkit-changes] [90802] trunk/LayoutTests
Title: [90802] trunk/LayoutTests Revision 90802 Author rn...@webkit.org Date 2011-07-11 18:56:40 -0700 (Mon, 11 Jul 2011) Log Message Skip hittest-on-relative-positioned-children.html in WebKit2. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (90801 => 90802) --- trunk/LayoutTests/ChangeLog 2011-07-12 01:26:12 UTC (rev 90801) +++ trunk/LayoutTests/ChangeLog 2011-07-12 01:56:40 UTC (rev 90802) @@ -1,3 +1,9 @@ +2011-07-11 Ryosuke Niwa rn...@webkit.org + +Skip hittest-on-relative-positioned-children.html in WebKit2. + +* platform/wk2/Skipped: + 2011-07-11 Yuta Kitamura yu...@chromium.org WebSocket: Remove WebSocket tests that do not apply to hybi protocol Modified: trunk/LayoutTests/platform/wk2/Skipped (90801 => 90802) --- trunk/LayoutTests/platform/wk2/Skipped 2011-07-12 01:26:12 UTC (rev 90801) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-12 01:56:40 UTC (rev 90802) @@ -177,6 +177,7 @@ editing/undo/undo-deleteWord.html editing/undo/undo-smart-delete-reversed-selection.html editing/undo/undo-smart-delete-word.html +fast/block/positioning/hittest-on-relative-positioned-children.html fast/blockflow/horizontal-bt-replaced-selection.html fast/blockflow/japanese-lr-selection.html fast/blockflow/japanese-rl-selection.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90803] trunk/Tools
Title: [90803] trunk/Tools
Revision 90803
Author commit-qu...@webkit.org
Date 2011-07-11 19:11:28 -0700 (Mon, 11 Jul 2011)
Log Message
[EFL] DRT: Add code related to font management.
https://bugs.webkit.org/show_bug.cgi?id=63989
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-07-11
Reviewed by Kent Tamura.
The added files are responsible for managing fontconfig and adding the
fonts required by some layout tests to fontconfig's path.
* DumpRenderTree/efl/FontManagement.cpp: Added.
(getFontDirectories):
(getFontFiles):
(addFontDirectories):
(addFontFiles):
(addFontsToEnvironment):
* DumpRenderTree/efl/FontManagement.h: Added.
Modified Paths
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/DumpRenderTree/efl/FontManagement.cpp
trunk/Tools/DumpRenderTree/efl/FontManagement.h
Diff
Modified: trunk/Tools/ChangeLog (90802 => 90803)
--- trunk/Tools/ChangeLog 2011-07-12 01:56:40 UTC (rev 90802)
+++ trunk/Tools/ChangeLog 2011-07-12 02:11:28 UTC (rev 90803)
@@ -1,3 +1,21 @@
+2011-07-11 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] DRT: Add code related to font management.
+https://bugs.webkit.org/show_bug.cgi?id=63989
+
+Reviewed by Kent Tamura.
+
+The added files are responsible for managing fontconfig and adding the
+fonts required by some layout tests to fontconfig's path.
+
+* DumpRenderTree/efl/FontManagement.cpp: Added.
+(getFontDirectories):
+(getFontFiles):
+(addFontDirectories):
+(addFontFiles):
+(addFontsToEnvironment):
+* DumpRenderTree/efl/FontManagement.h: Added.
+
2011-07-08 Dirk Pranke dpra...@chromium.org
nrwt: linting fixes
Added: trunk/Tools/DumpRenderTree/efl/FontManagement.cpp (0 => 90803)
--- trunk/Tools/DumpRenderTree/efl/FontManagement.cpp (rev 0)
+++ trunk/Tools/DumpRenderTree/efl/FontManagement.cpp 2011-07-12 02:11:28 UTC (rev 90803)
@@ -0,0 +1,132 @@
+/*
+ * Copyright (C) 2011 ProFUSION Embedded Systems
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include FontManagement.h
+
+#include Ecore_File.h
+#include cstdio
+#include fontconfig/fontconfig.h
+#include wtf/Vector.h
+#include wtf/text/CString.h
+#include wtf/text/WTFString.h
+
+static VectorString getFontDirectories()
+{
+VectorString fontDirPaths;
+
+fontDirPaths.append(String(/usr/share/fonts/TTF/));
+fontDirPaths.append(String(/usr/share/fonts/truetype/ttf-liberation/));
+fontDirPaths.append(String(/usr/share/fonts/liberation/));
+fontDirPaths.append(String(/usr/share/fonts/truetype/ttf-dejavu/));
+fontDirPaths.append(String(/usr/share/fonts/dejavu/));
+fontDirPaths.append(String(/usr/share/fonts/OTF/)); // MathML
+fontDirPaths.append(String(/usr/share/fonts/opentype/stix/)); // MathML
+fontDirPaths.append(String(/usr/share/fonts/stix/)); // MathML
+
+return fontDirPaths;
+}
+
+static VectorString getFontFiles()
+{
+VectorString fontFilePaths;
+
+// Ahem is used by many layout tests.
+fontFilePaths.append(String(FONTS_CONF_DIR /AHEM.TTF));
+// A font with no valid Fontconfig encoding to test https://bugs.webkit.org/show_bug.cgi?id=47452
+fontFilePaths.append(String(FONTS_CONF_DIR /FontWithNoValidEncoding.fon));
+
+for (int i = 1; i = 9; i++) {
+char fontPath[PATH_MAX];
+snprintf(fontPath, PATH_MAX - 1,
+ FONTS_CONF_DIR /../../fonts/WebKitWeightWatcher%i00.ttf, i);
+
+fontFilePaths.append(String(fontPath));
+}
+
+return fontFilePaths;
+}
+
+static size_t addFontDirectories(const VectorString fontDirectories, FcConfig* config)
+{
+
[webkit-changes] [90805] trunk/Tools
Title: [90805] trunk/Tools Revision 90805 Author commit-qu...@webkit.org Date 2011-07-11 19:20:09 -0700 (Mon, 11 Jul 2011) Log Message [EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time. https://bugs.webkit.org/show_bug.cgi?id=64293 Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-07-11 Reviewed by Kent Tamura. gEcoreEvas was being destroyed after shutdownEfl() was called, so the call to ecore_evas_free() failed. We now shut it down manually before shutdownEfl() is called. * DumpRenderTree/efl/ImageDiff.cpp: (main): Destroy gEcoreEvas before shutting down the EFL. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp Diff Modified: trunk/Tools/ChangeLog (90804 => 90805) --- trunk/Tools/ChangeLog 2011-07-12 02:17:34 UTC (rev 90804) +++ trunk/Tools/ChangeLog 2011-07-12 02:20:09 UTC (rev 90805) @@ -1,3 +1,18 @@ +2011-07-11 Raphael Kubo da Costa k...@profusion.mobi + +[EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time. +https://bugs.webkit.org/show_bug.cgi?id=64293 + +Reviewed by Kent Tamura. + +gEcoreEvas was being destroyed after shutdownEfl() was called, so the +call to ecore_evas_free() failed. + +We now shut it down manually before shutdownEfl() is called. + +* DumpRenderTree/efl/ImageDiff.cpp: +(main): Destroy gEcoreEvas before shutting down the EFL. + 2011-07-11 Ryosuke Niwa rn...@webkit.org Make Chromium Mac and Linux tests bot core builders Modified: trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp (90804 => 90805) --- trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-07-12 02:17:34 UTC (rev 90804) +++ trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-07-12 02:20:09 UTC (rev 90805) @@ -343,6 +343,8 @@ fflush(stdout); } +gEcoreEvas.clear(); // Make sure ecore_evas_free is called before the EFL are shut down + shutdownEfl(); return EXIT_SUCCESS; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [90806] trunk
Title: [90806] trunk Revision 90806 Author hb...@chromium.org Date 2011-07-11 19:51:39 -0700 (Mon, 11 Jul 2011) Log Message Reviewed by Adam Roben. Implement layoutTestController.setTextDirection for WebKit2 and Windows. https://bugs.webkit.org/show_bug.cgi?id=61931 This change implements layoutTextController.setTextDirection for WebKit2 and Windows so we can run a layout test added by r87770 on them. Each implementation adds a wrapper function for Editor::setBaseWritingDirection() so LayoutTestController can call it. Source/WebKit/win: * Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow LayoutTestController to change the text direction. * WebFrame.cpp: ditto. (WebFrame::setTextDirection): * WebFrame.h: ditto. Source/WebKit2: * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Added WKBundleFrameSetTextDirection to allow LayoutTestController to change the text direction. (WKBundleFrameSetTextDirection): * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: ditto. * WebProcess/WebPage/WebFrame.cpp: Added setTextDirection to allow WKBundleFrame to change the text direction. (WebKit::WebFrame::setTextDirection): * WebProcess/WebPage/WebFrame.h: ditto. Tools: * DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTextDirection): Implemented the binding function for layoutTestController.setTextDirection (Windows). * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added a binding function for layoutTestController.setTextDirection (WebKit2). * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto. (WTR::LayoutTestController::setTextDirection): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto. LayoutTests: * platform/mac-wk2/Skipped: Removed set-text-direction.html. * platform/win/Skipped: ditto. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit/win/ChangeLog trunk/Source/WebKit/win/Interfaces/IWebFramePrivate.idl trunk/Source/WebKit/win/WebFrame.cpp trunk/Source/WebKit/win/WebFrame.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h Diff Modified: trunk/LayoutTests/ChangeLog (90805 => 90806) --- trunk/LayoutTests/ChangeLog 2011-07-12 02:20:09 UTC (rev 90805) +++ trunk/LayoutTests/ChangeLog 2011-07-12 02:51:39 UTC (rev 90806) @@ -1,3 +1,18 @@ +2011-07-11 Hironori Bono hb...@chromium.org + +Reviewed by Adam Roben. + +Implement layoutTestController.setTextDirection for WebKit2 and Windows. +https://bugs.webkit.org/show_bug.cgi?id=61931 + +This change implements layoutTextController.setTextDirection for WebKit2 +and Windows so we can run a layout test added by r87770 on them. Each +implementation adds a wrapper function for Editor::setBaseWritingDirection() +so LayoutTestController can call it. + +* platform/mac-wk2/Skipped: Removed set-text-direction.html. +* platform/win/Skipped: ditto. + 2011-07-11 Ryosuke Niwa rn...@webkit.org Skip hittest-on-relative-positioned-children.html in WebKit2. Modified: trunk/LayoutTests/platform/win/Skipped (90805 => 90806) --- trunk/LayoutTests/platform/win/Skipped 2011-07-12 02:20:09 UTC (rev 90805) +++ trunk/LayoutTests/platform/win/Skipped 2011-07-12 02:51:39 UTC (rev 90806) @@ -1007,9 +1007,6 @@ # EditorClient::requestCheckingOfString() is not implemented editing/spelling/spellcheck-paste.html -# layoutTestController::setTextDirection() is not implemented -fast/html/set-text-direction.html - # IndexedDB is not yet enabled. storage/indexeddb Modified: trunk/LayoutTests/platform/wk2/Skipped (90805 => 90806) --- trunk/LayoutTests/platform/wk2/Skipped 2011-07-12 02:20:09 UTC (rev 90805) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-07-12 02:51:39 UTC (rev 90806) @@ -411,10 +411,6 @@ scrollbars/scrollbar-miss-mousemove-disabled.html scrollbars/scrollevent-iframe-no-scrolling-wheel.html -# WebKitTestRunner needs an implementation of setTextDirection. -# https://bugs.webkit.org/show_bug.cgi?id=61931 -fast/html/set-text-direction.html - # CONSOLE MESSAGE: line 0: SVG animation pause API missing! # [WK2] SVG animation pause API missing # https://bugs.webkit.org/show_bug.cgi?id=63396 Modified: trunk/Source/WebKit/win/ChangeLog (90805 => 90806) --- trunk/Source/WebKit/win/ChangeLog 2011-07-12 02:20:09 UTC (rev 90805) +++ trunk/Source/WebKit/win/ChangeLog
[webkit-changes] [90808] trunk/Source/WebKit/efl
Title: [90808] trunk/Source/WebKit/efl
Revision 90808
Author commit-qu...@webkit.org
Date 2011-07-11 22:58:21 -0700 (Mon, 11 Jul 2011)
Log Message
Patch by Jaehun Lim ljaehun@samsung.com on 2011-07-11
Reviewed by Ryosuke Niwa.
[EFL] Supports to execute redo command.
https://bugs.webkit.org/show_bug.cgi?id=62536
Implements basic functions for redo command.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::registerCommandForUndo):
(WebCore::EditorClientEfl::registerCommandForRedo):
(WebCore::EditorClientEfl::clearUndoRedoOperations):
(WebCore::EditorClientEfl::canRedo):
(WebCore::EditorClientEfl::undo):
(WebCore::EditorClientEfl::redo):
(WebCore::EditorClientEfl::EditorClientEfl):
* WebCoreSupport/EditorClientEfl.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (90807 => 90808)
--- trunk/Source/WebKit/efl/ChangeLog 2011-07-12 04:54:54 UTC (rev 90807)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-07-12 05:58:21 UTC (rev 90808)
@@ -1,3 +1,22 @@
+2011-07-11 Jaehun Lim ljaehun@samsung.com
+
+Reviewed by Ryosuke Niwa.
+
+[EFL] Supports to execute redo command.
+https://bugs.webkit.org/show_bug.cgi?id=62536
+
+Implements basic functions for redo command.
+
+* WebCoreSupport/EditorClientEfl.cpp:
+(WebCore::EditorClientEfl::registerCommandForUndo):
+(WebCore::EditorClientEfl::registerCommandForRedo):
+(WebCore::EditorClientEfl::clearUndoRedoOperations):
+(WebCore::EditorClientEfl::canRedo):
+(WebCore::EditorClientEfl::undo):
+(WebCore::EditorClientEfl::redo):
+(WebCore::EditorClientEfl::EditorClientEfl):
+* WebCoreSupport/EditorClientEfl.h:
+
2011-06-29 Kangil Han kangil@samsung.com
Reviewed by Kenneth Rohde Christiansen.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (90807 => 90808)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-07-12 04:54:54 UTC (rev 90807)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp 2011-07-12 05:58:21 UTC (rev 90808)
@@ -163,17 +163,20 @@
void EditorClientEfl::registerCommandForUndo(WTF::PassRefPtrEditCommand command)
{
-undoStack.append(command);
+if (!m_isInRedo)
+redoStack.clear();
+undoStack.prepend(command);
}
-void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtrEditCommand)
+void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtrEditCommand command)
{
-notImplemented();
+redoStack.prepend(command);
}
void EditorClientEfl::clearUndoRedoOperations()
{
undoStack.clear();
+redoStack.clear();
}
bool EditorClientEfl::canCopyCut(Frame*, bool defaultValue) const
@@ -193,20 +196,27 @@
bool EditorClientEfl::canRedo() const
{
-notImplemented();
-return false;
+return !redoStack.isEmpty();
}
void EditorClientEfl::undo()
{
-RefPtrWebCore::EditCommand command(*(--undoStack.end()));
-undoStack.remove(--undoStack.end());
-command-unapply();
+if (canUndo()) {
+RefPtrWebCore::EditCommand command = undoStack.takeFirst();
+command-unapply();
+}
}
void EditorClientEfl::redo()
{
-notImplemented();
+if (canRedo()) {
+RefPtrWebCore::EditCommand command = redoStack.takeFirst();
+
+ASSERT(!m_isInRedo);
+m_isInRedo = true;
+command-reapply();
+m_isInRedo = false;
+}
}
bool EditorClientEfl::shouldInsertNode(Node*, Range*, EditorInsertAction)
@@ -425,8 +435,9 @@
{
}
-EditorClientEfl::EditorClientEfl(Evas_Object *view)
-: m_view(view)
+EditorClientEfl::EditorClientEfl(Evas_Object* view)
+: m_isInRedo(false)
+, m_view(view)
{
notImplemented();
}
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (90807 => 90808)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-07-12 04:54:54 UTC (rev 90807)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2011-07-12 05:58:21 UTC (rev 90808)
@@ -46,7 +46,9 @@
class EditorClientEfl : public EditorClient, public TextCheckerClient {
protected:
+bool m_isInRedo;
WTF::DequeWTF::RefPtrWebCore::EditCommand undoStack;
+WTF::DequeWTF::RefPtrWebCore::EditCommand redoStack;
public:
EditorClientEfl(Evas_Object *view);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
