[webkit-changes] [92452] trunk/LayoutTests
Title: [92452] trunk/LayoutTests Revision 92452 Author rn...@webkit.org Date 2011-08-04 23:58:13 -0700 (Thu, 04 Aug 2011) Log Message Chromium test expectation update after r92341. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92451 => 92452) --- trunk/LayoutTests/ChangeLog 2011-08-05 06:26:20 UTC (rev 92451) +++ trunk/LayoutTests/ChangeLog 2011-08-05 06:58:13 UTC (rev 92452) @@ -1,3 +1,9 @@ +2011-08-04 Ryosuke Niwa + +Chromium test expectation update after r92341. + +* platform/chromium/test_expectations.txt: + 2011-08-04 Scott Graham Bad interaction between document destruction and unload events Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92451 => 92452) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-05 06:26:20 UTC (rev 92451) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-05 06:58:13 UTC (rev 92452) @@ -3215,9 +3215,6 @@ // Introduced in r84443 BUGWK59063 : fast/images/animated-gif-restored-from-bfcache.html = TEXT -// Introduced in r84454 -BUGWK60126 : fast/transforms/selection-bounds-in-transformed-view.html = TEXT - // more failures for triaging, fails on deps bots at least? BUGWK60123 LINUX DEBUG : editing/pasteboard/merge-end-2.html = PASS CRASH BUGDPRANKE DEBUG : animations/keyframes-out-of-order.html = PASS TEXT @@ -3622,7 +3619,7 @@ // WebKit roll 80564:80631: rendering on Leopard is shifted to the top right // started at some point at or after WK r80582 (Dave Hyatt's vertical text change - a very likely candidate) //BUGCR75424 LEOPARD : fast/blockflow/broken-ideograph-small-caps.html = IMAGE -//BUGCR75424 LEOPARD : fast/blockflow/japanese-rl-text-with-broken-font.html = IMAGE +BUGCR75424 LEOPARD : fast/blockflow/japanese-rl-text-with-broken-font.html = IMAGE BUGCR89673 : fast/js/object-prototype-properties.html = TEXT @@ -3661,7 +3658,7 @@ BUGWK65124 LINUX WIN : fast/repaint/japanese-rl-selection-clear.html = IMAGE+TEXT BUGWK65124 WIN : fast/repaint/japanese-rl-selection-repaint.html = IMAGE+TEXT BUGWK65124 WIN : fast/blockflow/japanese-lr-text.html = IMAGE+TEXT -BUGWK65124 : fast/blockflow/japanese-rl-text-with-broken-font.html = FAIL +BUGWK65124 WIN : fast/blockflow/japanese-rl-text-with-broken-font.html = IMAGE+TEXT BUGWK65124 WIN : fast/blockflow/japanese-rl-text.html = IMAGE+TEXT BUGWK65199 : fast/blockflow/broken-ideograph-small-caps.html = PASS FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92451] trunk/Source/WebCore
Title: [92451] trunk/Source/WebCore
Revision 92451
Author rn...@webkit.org
Date 2011-08-04 23:26:20 -0700 (Thu, 04 Aug 2011)
Log Message
Use RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=65647
Reviewed by Hajime Morita.
Encapsulated the use of getInlineBoxAndOffset in Editor.cpp and AccessibilityObject.cpp by RenderedPosition.
Also added rendererFromPosition that returns the renderer of deprecatedNode but using a proper Position interface.
* accessibility/AccessibilityObject.cpp:
(WebCore::updateAXLineStartForVisiblePosition):
* editing/Editor.cpp:
(WebCore::Editor::firstRectForRange):
* editing/RenderedPosition.cpp:
(WebCore::rendererFromPosition):
(WebCore::RenderedPosition::RenderedPosition):
(WebCore::RenderedPosition::absoluteRect):
* editing/RenderedPosition.h:
(WebCore::RenderedPosition::absoluteRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/RenderedPosition.cpp
trunk/Source/WebCore/editing/RenderedPosition.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92450 => 92451)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 06:14:11 UTC (rev 92450)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 06:26:20 UTC (rev 92451)
@@ -1,3 +1,25 @@
+2011-08-04 Ryosuke Niwa
+
+Use RenderedPosition instead of getInlineBoxAndOffset in Editor and AccessibilityObject
+https://bugs.webkit.org/show_bug.cgi?id=65647
+
+Reviewed by Hajime Morita.
+
+Encapsulated the use of getInlineBoxAndOffset in Editor.cpp and AccessibilityObject.cpp by RenderedPosition.
+
+Also added rendererFromPosition that returns the renderer of deprecatedNode but using a proper Position interface.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::updateAXLineStartForVisiblePosition):
+* editing/Editor.cpp:
+(WebCore::Editor::firstRectForRange):
+* editing/RenderedPosition.cpp:
+(WebCore::rendererFromPosition):
+(WebCore::RenderedPosition::RenderedPosition):
+(WebCore::RenderedPosition::absoluteRect):
+* editing/RenderedPosition.h:
+(WebCore::RenderedPosition::absoluteRect):
+
2011-08-04 Hayato Ito
Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.cpp (92450 => 92451)
--- trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2011-08-05 06:14:11 UTC (rev 92450)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.cpp 2011-08-05 06:26:20 UTC (rev 92451)
@@ -49,6 +49,7 @@
#include "RenderTheme.h"
#include "RenderView.h"
#include "RenderWidget.h"
+#include "RenderedPosition.h"
#include "TextCheckerClient.h"
#include "TextIterator.h"
#include "htmlediting.h"
@@ -289,22 +290,15 @@
// So let's update the position to include that.
VisiblePosition tempPosition;
VisiblePosition startPosition = visiblePosition;
-Position p;
-RenderObject* renderer;
while (true) {
tempPosition = startPosition.previous();
-if (tempPosition.isNull())
+if (tempPosition.isNull() || tempPosition.isNull())
break;
-p = tempPosition.deepEquivalent();
-if (!p.deprecatedNode())
-break;
-renderer = p.deprecatedNode()->renderer();
+Position p = tempPosition.deepEquivalent();
+RenderObject* renderer = p.deprecatedNode()->renderer();
if (!renderer || (renderer->isRenderBlock() && !p.deprecatedEditingOffset()))
break;
-InlineBox* box;
-int ignoredCaretOffset;
-p.getInlineBoxAndOffset(tempPosition.affinity(), box, ignoredCaretOffset);
-if (box)
+if (!RenderedPosition(tempPosition).isNull())
break;
startPosition = tempPosition;
}
Modified: trunk/Source/WebCore/editing/Editor.cpp (92450 => 92451)
--- trunk/Source/WebCore/editing/Editor.cpp 2011-08-05 06:14:11 UTC (rev 92450)
+++ trunk/Source/WebCore/editing/Editor.cpp 2011-08-05 06:26:20 UTC (rev 92451)
@@ -71,6 +71,7 @@
#include "RenderBlock.h"
#include "RenderPart.h"
#include "RenderTextControl.h"
+#include "RenderedPosition.h"
#include "ReplaceSelectionCommand.h"
#include "Settings.h"
#include "Sound.h"
@@ -2733,32 +2734,14 @@
ASSERT(range->startContainer());
ASSERT(range->endContainer());
-InlineBox* startInlineBox;
-int startCaretOffset;
-Position startPosition = VisiblePosition(range->startPosition()).deepEquivalent();
-if (startPosition.isNull())
+LayoutRect startCaretRect = RenderedPosition(VisiblePosition(range->startPosition()).deepEquivalent(), DOWNSTREAM).absoluteRect(extraWidthToEndOfLine);
+if (startCaretRect == LayoutRect())
return IntRect();
-startPosition.getInlineBoxAndOffset(DOWNSTREAM, startIn
[webkit-changes] [92450] trunk/Source/WebCore
Title: [92450] trunk/Source/WebCore
Revision 92450
Author hay...@chromium.org
Date 2011-08-04 23:14:11 -0700 (Thu, 04 Aug 2011)
Log Message
Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
https://bugs.webkit.org/show_bug.cgi?id=65613
Reviewed by Dimitri Glazkov.
No changes to functionality so no new tests.
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchScopedEvent):
* dom/EventDispatcher.h:
* dom/Node.cpp:
(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchScopedEventDispatchMediator):
* dom/Node.h:
* dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEventDispatchMediator):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):
* dom/ScopedEventQueue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Event.h
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/ScopedEventQueue.cpp
trunk/Source/WebCore/dom/ScopedEventQueue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92449 => 92450)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 06:05:51 UTC (rev 92449)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 06:14:11 UTC (rev 92450)
@@ -1,3 +1,27 @@
+2011-08-04 Hayato Ito
+
+Make ScopedEventQueue enqueue an EventDispatchMediator, instead of an Event.
+https://bugs.webkit.org/show_bug.cgi?id=65613
+
+Reviewed by Dimitri Glazkov.
+
+No changes to functionality so no new tests.
+
+* dom/Event.h:
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::dispatchScopedEvent):
+* dom/EventDispatcher.h:
+* dom/Node.cpp:
+(WebCore::Node::dispatchScopedEvent):
+(WebCore::Node::dispatchScopedEventDispatchMediator):
+* dom/Node.h:
+* dom/ScopedEventQueue.cpp:
+(WebCore::ScopedEventQueue::~ScopedEventQueue):
+(WebCore::ScopedEventQueue::enqueueEventDispatchMediator):
+(WebCore::ScopedEventQueue::dispatchAllEvents):
+(WebCore::ScopedEventQueue::dispatchEvent):
+* dom/ScopedEventQueue.h:
+
2011-08-04 James Robinson
Unreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.
Modified: trunk/Source/WebCore/dom/Event.h (92449 => 92450)
--- trunk/Source/WebCore/dom/Event.h 2011-08-05 06:05:51 UTC (rev 92449)
+++ trunk/Source/WebCore/dom/Event.h 2011-08-05 06:14:11 UTC (rev 92450)
@@ -205,12 +205,11 @@
virtual ~EventDispatchMediator();
virtual bool dispatchEvent(EventDispatcher*) const;
+Event* event() const;
protected:
explicit EventDispatchMediator(PassRefPtr);
EventDispatchMediator();
-
-Event* event() const;
void setEvent(PassRefPtr);
private:
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (92449 => 92450)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-05 06:05:51 UTC (rev 92449)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2011-08-05 06:14:11 UTC (rev 92450)
@@ -84,12 +84,11 @@
return referenceNode->isSVGElement() ? findElementInstance(referenceNode) : referenceNode;
}
-void EventDispatcher::dispatchScopedEvent(Node* node, PassRefPtr event)
+void EventDispatcher::dispatchScopedEvent(Node* node, PassRefPtr mediator)
{
// We need to set the target here because it can go away by the time we actually fire the event.
-event->setTarget(eventTargetRespectingSVGTargetRules(node));
-
-ScopedEventQueue::instance()->enqueueEvent(event);
+mediator->event()->setTarget(eventTargetRespectingSVGTargetRules(node));
+ScopedEventQueue::instance()->enqueueEventDispatchMediator(mediator);
}
void EventDispatcher::dispatchSimulatedClick(Node* node, PassRefPtr underlyingEvent, bool sendMouseEvents, bool showPressedLook)
Modified: trunk/Source/WebCore/dom/EventDispatcher.h (92449 => 92450)
--- trunk/Source/WebCore/dom/EventDispatcher.h 2011-08-05 06:05:51 UTC (rev 92449)
+++ trunk/Source/WebCore/dom/EventDispatcher.h 2011-08-05 06:14:11 UTC (rev 92450)
@@ -49,7 +49,7 @@
class EventDispatcher {
public:
static bool dispatchEvent(Node*, PassRefPtr);
-static void dispatchScopedEvent(Node*, PassRefPtr);
+static void dispatchScopedEvent(Node*, PassRefPtr);
static void dispatchSimulatedClick(Node*, PassRefPtr underlyingEvent, bool sendMouseEvents, bool showPressedLook);
Modified: trunk/Source/WebCore/dom/Node.cpp (92449 => 92450)
--- trunk/Source/WebCore/dom/Node.cpp 2011-08-05 06:05:51 UTC (rev 92449)
+++ trunk/Source/WebCore/dom/Node.cpp 2011-08-05 06:14:11 UTC (rev 92450)
@@ -2709,9 +2709,14 @@
void Node::dispatchScopedEvent(PassRefPtr event)
{
-EventDispatcher::dispatchScopedEvent(this, event);
+dispatchScopedEventDispatchMediator(EventDispatchMediator::create(event));
[webkit-changes] [92449] trunk/Source/WebCore
Title: [92449] trunk/Source/WebCore
Revision 92449
Author jam...@google.com
Date 2011-08-04 23:05:51 -0700 (Thu, 04 Aug 2011)
Log Message
Unreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92448 => 92449)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 06:04:52 UTC (rev 92448)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 06:05:51 UTC (rev 92449)
@@ -1,3 +1,11 @@
+2011-08-04 James Robinson
+
+Unreviewed build fix. gcc 4.5 can't figure out that the 'data' variables are always initialized in these functions.
+
+* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+(WebCore::jsArrayToFloatArray):
+(WebCore::jsArrayToIntArray):
+
2011-08-05 Roland Steiner
Improve const-correctness in CSS code: type information methods
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (92448 => 92449)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2011-08-05 06:04:52 UTC (rev 92448)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2011-08-05 06:05:51 UTC (rev 92449)
@@ -74,7 +74,7 @@
static float* jsArrayToFloatArray(v8::Handle array, uint32_t len)
{
// Convert the data element-by-element.
-float* data;
+float* data = ""
if (len > std::numeric_limits::max() / sizeof(float)
|| !tryFastMalloc(len * sizeof(float)).getValue(data))
return 0;
@@ -94,7 +94,7 @@
static int* jsArrayToIntArray(v8::Handle array, uint32_t len)
{
// Convert the data element-by-element.
-int* data;
+int* data = ""
if (len > std::numeric_limits::max() / sizeof(int)
|| !tryFastMalloc(len * sizeof(int)).getValue(data))
return 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92448] trunk/Source/WebCore
Title: [92448] trunk/Source/WebCore
Revision 92448
Author rolandstei...@chromium.org
Date 2011-08-04 23:04:52 -0700 (Thu, 04 Aug 2011)
Log Message
Improve const-correctness in CSS code: type information methods
https://bugs.webkit.org/show_bug.cgi?id=65506
Reviewed by Simon Fraser.
Make "is...()" functions (e.g., "isStyleRule()") const.
Also, change CSSRule's type() function to return CSSRuleType.
No new tests. (no change in semantics)
* css/CSSCharsetRule.h:
(WebCore::CSSCharsetRule::isCharsetRule):
(WebCore::CSSCharsetRule::type):
* css/CSSFontFaceRule.h:
(WebCore::CSSFontFaceRule::isFontFaceRule):
(WebCore::CSSFontFaceRule::type):
* css/CSSImportRule.h:
(WebCore::CSSImportRule::isImportRule):
(WebCore::CSSImportRule::type):
* css/CSSMediaRule.h:
(WebCore::CSSMediaRule::isMediaRule):
(WebCore::CSSMediaRule::type):
* css/CSSPageRule.h:
(WebCore::CSSPageRule::isPageRule):
(WebCore::CSSPageRule::type):
* css/CSSRule.h:
(WebCore::CSSRule::isRule):
* css/CSSStyleRule.h:
(WebCore::CSSStyleRule::isStyleRule):
(WebCore::CSSStyleRule::type):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::type):
* css/StyleBase.h:
(WebCore::StyleBase::isCharsetRule):
(WebCore::StyleBase::isFontFaceRule):
(WebCore::StyleBase::isImportRule):
(WebCore::StyleBase::isKeyframeRule):
(WebCore::StyleBase::isKeyframesRule):
(WebCore::StyleBase::isMediaRule):
(WebCore::StyleBase::isPageRule):
(WebCore::StyleBase::isRule):
(WebCore::StyleBase::isStyleRule):
* css/WebKitCSSKeyframeRule.h:
(WebCore::WebKitCSSKeyframeRule::isKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::type):
* css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::isKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::type):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCharsetRule.h
trunk/Source/WebCore/css/CSSFontFaceRule.h
trunk/Source/WebCore/css/CSSImportRule.h
trunk/Source/WebCore/css/CSSMediaRule.h
trunk/Source/WebCore/css/CSSPageRule.h
trunk/Source/WebCore/css/CSSRule.h
trunk/Source/WebCore/css/CSSStyleRule.h
trunk/Source/WebCore/css/CSSUnknownRule.h
trunk/Source/WebCore/css/StyleBase.h
trunk/Source/WebCore/css/WebKitCSSKeyframeRule.h
trunk/Source/WebCore/css/WebKitCSSKeyframesRule.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92447 => 92448)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 05:42:19 UTC (rev 92447)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 06:04:52 UTC (rev 92448)
@@ -1,3 +1,54 @@
+2011-08-05 Roland Steiner
+
+Improve const-correctness in CSS code: type information methods
+https://bugs.webkit.org/show_bug.cgi?id=65506
+
+Reviewed by Simon Fraser.
+
+Make "is...()" functions (e.g., "isStyleRule()") const.
+Also, change CSSRule's type() function to return CSSRuleType.
+
+No new tests. (no change in semantics)
+
+* css/CSSCharsetRule.h:
+(WebCore::CSSCharsetRule::isCharsetRule):
+(WebCore::CSSCharsetRule::type):
+* css/CSSFontFaceRule.h:
+(WebCore::CSSFontFaceRule::isFontFaceRule):
+(WebCore::CSSFontFaceRule::type):
+* css/CSSImportRule.h:
+(WebCore::CSSImportRule::isImportRule):
+(WebCore::CSSImportRule::type):
+* css/CSSMediaRule.h:
+(WebCore::CSSMediaRule::isMediaRule):
+(WebCore::CSSMediaRule::type):
+* css/CSSPageRule.h:
+(WebCore::CSSPageRule::isPageRule):
+(WebCore::CSSPageRule::type):
+* css/CSSRule.h:
+(WebCore::CSSRule::isRule):
+* css/CSSStyleRule.h:
+(WebCore::CSSStyleRule::isStyleRule):
+(WebCore::CSSStyleRule::type):
+* css/CSSUnknownRule.h:
+(WebCore::CSSUnknownRule::type):
+* css/StyleBase.h:
+(WebCore::StyleBase::isCharsetRule):
+(WebCore::StyleBase::isFontFaceRule):
+(WebCore::StyleBase::isImportRule):
+(WebCore::StyleBase::isKeyframeRule):
+(WebCore::StyleBase::isKeyframesRule):
+(WebCore::StyleBase::isMediaRule):
+(WebCore::StyleBase::isPageRule):
+(WebCore::StyleBase::isRule):
+(WebCore::StyleBase::isStyleRule):
+* css/WebKitCSSKeyframeRule.h:
+(WebCore::WebKitCSSKeyframeRule::isKeyframeRule):
+(WebCore::WebKitCSSKeyframeRule::type):
+* css/WebKitCSSKeyframesRule.h:
+(WebCore::WebKitCSSKeyframesRule::isKeyframesRule):
+(WebCore::WebKitCSSKeyframesRule::type):
+
2011-08-04 Mark Pilgrim
Remove LegacyDefaultOptionalArguments flag from plugin IDL files
Modified: trunk/Source/WebCore/css/CSSCharsetRule.h (92447 => 92448)
--- trunk/Source/WebCore/css/CSSCharsetRule.h 2011-08-05 05:42:19 UTC (rev 92447)
+++ trunk/Source/WebCore/css/CSSCharsetRule.h 2011-08-05 06:04:52 UTC (rev 92448)
@@ -44,10 +44,9 @@
private:
CSSCharsetRule(CSSStyleSheet* parent, const String& encoding);
-virtual bool isCharsetRule() { return true; }
-
+virtual bool isCharsetRule() const { return true; }
// from CSSRule
[webkit-changes] [92447] trunk/Source/WebCore
Title: [92447] trunk/Source/WebCore
Revision 92447
Author commit-qu...@webkit.org
Date 2011-08-04 22:42:19 -0700 (Thu, 04 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from plugin IDL files
https://bugs.webkit.org/show_bug.cgi?id=65745
Patch by Mark Pilgrim on 2011-08-04
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl
trunk/Source/WebCore/plugins/DOMPlugin.idl
trunk/Source/WebCore/plugins/DOMPluginArray.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92446 => 92447)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 05:37:24 UTC (rev 92446)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 05:42:19 UTC (rev 92447)
@@ -1,5 +1,18 @@
2011-08-04 Mark Pilgrim
+Remove LegacyDefaultOptionalArguments flag from plugin IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65745
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* plugins/DOMMimeTypeArray.idl:
+* plugins/DOMPlugin.idl:
+* plugins/DOMPluginArray.idl:
+
+2011-08-04 Mark Pilgrim
+
Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
https://bugs.webkit.org/show_bug.cgi?id=65740
Modified: trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl (92446 => 92447)
--- trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2011-08-05 05:37:24 UTC (rev 92446)
+++ trunk/Source/WebCore/plugins/DOMMimeTypeArray.idl 2011-08-05 05:42:19 UTC (rev 92447)
@@ -21,14 +21,13 @@
module window {
interface [
-LegacyDefaultOptionalArguments,
GenerateIsReachable=ImplFrame,
HasNameGetter,
HasIndexGetter
] DOMMimeTypeArray {
readonly attribute unsigned long length;
-DOMMimeType item(in unsigned long index);
-DOMMimeType namedItem(in DOMString name);
+DOMMimeType item(in [Optional=CallWithDefaultValue] unsigned long index);
+DOMMimeType namedItem(in [Optional=CallWithDefaultValue] DOMString name);
};
}
Modified: trunk/Source/WebCore/plugins/DOMPlugin.idl (92446 => 92447)
--- trunk/Source/WebCore/plugins/DOMPlugin.idl 2011-08-05 05:37:24 UTC (rev 92446)
+++ trunk/Source/WebCore/plugins/DOMPlugin.idl 2011-08-05 05:42:19 UTC (rev 92447)
@@ -21,7 +21,6 @@
module window {
interface [
-LegacyDefaultOptionalArguments,
HasNameGetter,
HasIndexGetter
] DOMPlugin {
@@ -29,8 +28,8 @@
readonly attribute DOMString filename;
readonly attribute DOMString description;
readonly attribute unsigned long length;
-DOMMimeType item(in unsigned long index);
-DOMMimeType namedItem(in DOMString name);
+DOMMimeType item(in [Optional=CallWithDefaultValue] unsigned long index);
+DOMMimeType namedItem(in [Optional=CallWithDefaultValue] DOMString name);
};
}
Modified: trunk/Source/WebCore/plugins/DOMPluginArray.idl (92446 => 92447)
--- trunk/Source/WebCore/plugins/DOMPluginArray.idl 2011-08-05 05:37:24 UTC (rev 92446)
+++ trunk/Source/WebCore/plugins/DOMPluginArray.idl 2011-08-05 05:42:19 UTC (rev 92447)
@@ -21,15 +21,14 @@
module window {
interface [
-LegacyDefaultOptionalArguments,
GenerateIsReachable=ImplFrame,
HasNameGetter,
HasIndexGetter
] DOMPluginArray {
readonly attribute unsigned long length;
-DOMPlugin item(in unsigned long index);
-DOMPlugin namedItem(in DOMString name);
-void refresh(in boolean reload);
+DOMPlugin item(in [Optional=CallWithDefaultValue] unsigned long index);
+DOMPlugin namedItem(in [Optional=CallWithDefaultValue] DOMString name);
+void refresh(in [Optional=CallWithDefaultValue] boolean reload);
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92446] trunk/Source/WebCore
Title: [92446] trunk/Source/WebCore
Revision 92446
Author commit-qu...@webkit.org
Date 2011-08-04 22:37:24 -0700 (Thu, 04 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
https://bugs.webkit.org/show_bug.cgi?id=65740
Patch by Mark Pilgrim on 2011-08-04
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* xml/DOMParser.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathNSResolver.idl:
* xml/XPathResult.idl:
* xml/XSLTProcessor.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/DOMParser.idl
trunk/Source/WebCore/xml/XMLSerializer.idl
trunk/Source/WebCore/xml/XPathEvaluator.idl
trunk/Source/WebCore/xml/XPathExpression.idl
trunk/Source/WebCore/xml/XPathNSResolver.idl
trunk/Source/WebCore/xml/XPathResult.idl
trunk/Source/WebCore/xml/XSLTProcessor.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92445 => 92446)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 05:27:38 UTC (rev 92445)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 05:37:24 UTC (rev 92446)
@@ -1,5 +1,22 @@
2011-08-04 Mark Pilgrim
+Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65740
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* xml/DOMParser.idl:
+* xml/XMLSerializer.idl:
+* xml/XPathEvaluator.idl:
+* xml/XPathExpression.idl:
+* xml/XPathNSResolver.idl:
+* xml/XPathResult.idl:
+* xml/XSLTProcessor.idl:
+
+2011-08-04 Mark Pilgrim
+
Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737
Modified: trunk/Source/WebCore/xml/DOMParser.idl (92445 => 92446)
--- trunk/Source/WebCore/xml/DOMParser.idl 2011-08-05 05:27:38 UTC (rev 92445)
+++ trunk/Source/WebCore/xml/DOMParser.idl 2011-08-05 05:37:24 UTC (rev 92446)
@@ -19,9 +19,9 @@
module xpath {
interface [
-LegacyDefaultOptionalArguments,
CanBeConstructed
] DOMParser {
-Document parseFromString(in DOMString str, in DOMString contentType);
+Document parseFromString(in [Optional=CallWithDefaultValue] DOMString str,
+ in [Optional=CallWithDefaultValue] DOMString contentType);
};
}
Modified: trunk/Source/WebCore/xml/XMLSerializer.idl (92445 => 92446)
--- trunk/Source/WebCore/xml/XMLSerializer.idl 2011-08-05 05:27:38 UTC (rev 92445)
+++ trunk/Source/WebCore/xml/XMLSerializer.idl 2011-08-05 05:37:24 UTC (rev 92446)
@@ -21,10 +21,9 @@
module xpath {
interface [
-LegacyDefaultOptionalArguments,
CanBeConstructed
] XMLSerializer {
-DOMString serializeToString(in Node node)
+DOMString serializeToString(in [Optional=CallWithDefaultValue] Node node)
raises(DOMException);
};
Modified: trunk/Source/WebCore/xml/XPathEvaluator.idl (92445 => 92446)
--- trunk/Source/WebCore/xml/XPathEvaluator.idl 2011-08-05 05:27:38 UTC (rev 92445)
+++ trunk/Source/WebCore/xml/XPathEvaluator.idl 2011-08-05 05:37:24 UTC (rev 92446)
@@ -19,21 +19,20 @@
module xpath {
interface [
-LegacyDefaultOptionalArguments,
CanBeConstructed,
Conditional=XPATH
] XPathEvaluator {
-XPathExpression createExpression(in DOMString _expression_,
- in XPathNSResolver resolver)
+XPathExpression createExpression(in [Optional=CallWithDefaultValue] DOMString _expression_,
+ in [Optional=CallWithDefaultValue] XPathNSResolver resolver)
raises(DOMException);
-XPathNSResolver createNSResolver(in Node nodeResolver);
+XPathNSResolver createNSResolver(in [Optional=CallWithDefaultValue] Node nodeResolver);
-XPathResult evaluate(in DOMString _expression_,
- in Node contextNode,
- in XPathNSResolver resolver,
- in unsigned short type,
- in XPathResult inResult)
+XPathResult evaluate(in [Optional=CallWithDefaultValue] DOMString _expression_,
+ in [Optional=CallWithDefaultValue] Node contextNode,
+ in [Optional=CallWithDefaultValue] XPathNSResolver resolver,
+ in [Optional=CallWithDefaultValue] unsigned short type,
+ in [Optional=CallWithDefaultValue] XPathResult inResult)
raises(DOMException);
};
}
Modified: trunk/Source/WebCore/xml/XPathExpression.idl (92445 => 92446)
--- trunk/Source/WebCore/xml/XPathExpression.idl 2011-08-05 05:27:38 UTC (rev 92445)
+++ trunk/Source/WebCore/xml/XPathExpression.idl 2011-08-05 05:37:24 UTC (rev 92446)
@@ -22,12 +22,11 @@
interface [
-LegacyDefaultOptional
[webkit-changes] [92445] trunk/Source/WebKit/chromium
Title: [92445] trunk/Source/WebKit/chromium
Revision 92445
Author commit-qu...@webkit.org
Date 2011-08-04 22:27:38 -0700 (Thu, 04 Aug 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by James Robinson on 2011-08-04
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (92444 => 92445)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-05 04:51:00 UTC (rev 92444)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-05 05:27:38 UTC (rev 92445)
@@ -1,3 +1,9 @@
+2011-08-04 James Robinson
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-08-04 David Levin
CStringBuffer should have thread safety checks turned on.
Modified: trunk/Source/WebKit/chromium/DEPS (92444 => 92445)
--- trunk/Source/WebKit/chromium/DEPS 2011-08-05 04:51:00 UTC (rev 92444)
+++ trunk/Source/WebKit/chromium/DEPS 2011-08-05 05:27:38 UTC (rev 92445)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '95533'
+ 'chromium_rev': '95576'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92444] trunk/PerformanceTests
Title: [92444] trunk/PerformanceTests
Revision 92444
Author commit-qu...@webkit.org
Date 2011-08-04 21:51:00 -0700 (Thu, 04 Aug 2011)
Log Message
Add a performance test for floating elements layout algorithm
https://bugs.webkit.org/show_bug.cgi?id=65741
The test creating lots of small floats and randomly changes
the width of one element at a time. It measures how often it can do that.
Patch by Alexandru Chiculita on 2011-08-04
Reviewed by Adam Barth.
* Layout/floats.html: Added.
Modified Paths
trunk/PerformanceTests/ChangeLog
Added Paths
trunk/PerformanceTests/Layout/
trunk/PerformanceTests/Layout/floats.html
Diff
Modified: trunk/PerformanceTests/ChangeLog (92443 => 92444)
--- trunk/PerformanceTests/ChangeLog 2011-08-05 03:50:17 UTC (rev 92443)
+++ trunk/PerformanceTests/ChangeLog 2011-08-05 04:51:00 UTC (rev 92444)
@@ -1,3 +1,15 @@
+2011-08-04 Alexandru Chiculita
+
+Add a performance test for floating elements layout algorithm
+https://bugs.webkit.org/show_bug.cgi?id=65741
+
+The test creating lots of small floats and randomly changes
+the width of one element at a time. It measures how often it can do that.
+
+Reviewed by Adam Barth.
+
+* Layout/floats.html: Added.
+
2011-05-30 Daniel Bates
Reviewed by Adam Barth.
Added: trunk/PerformanceTests/Layout/floats.html (0 => 92444)
--- trunk/PerformanceTests/Layout/floats.html (rev 0)
+++ trunk/PerformanceTests/Layout/floats.html 2011-08-05 04:51:00 UTC (rev 92444)
@@ -0,0 +1,96 @@
+
+
+
+Floats layout performance tester
+
+.float {
+float: left;
+width: 5px;
+height: 5px;
+border: 1px solid green;
+}
+.big {
+width: 10px;
+}
+.float-end {
+clear:left;
+}
+
+#framerate_panel {
+display: none;
+}
+
+
+function createElement(tag, parent, className, id)
+{
+var el = document.createElement(tag);
+el.className = className;
+el.id = id;
+parent.appendChild(el);
+return el;
+}
+
+function createSet(width, height)
+{
+var container = createElement("div", document.body, "container");
+for (var y = 0; y < height; ++y) {
+for (var x = 0; x < width; ++x)
+createElement("div", container, "float", "float" + x + "_" + y);
+createElement("div", container, "float-end", "end" + x)
+}
+}
+
+function toggle(str, str1, str2)
+{
+if (str == str1)
+return str2;
+return str1;
+}
+
+function test(width, height)
+{
+document.getElementById("test_panel").style.display = "none";
+document.getElementById("framerate_panel").style.display = "block";
+
+createSet(width, height);
+var updates = 0;
+var startTime = new Date();
+
+function updateTimer()
+{
+++updates;
+
+var newTime = new Date();
+var deltaTime = newTime - startTime;
+
+if ((deltaTime > 0 && updates > 100) || deltaTime > 1000) {
+var fps = updates * 100 / deltaTime;
+document.getElementById("fps").innerHTML = fps;
+updates = 0;
+startTime = newTime;
+}
+}
+
+function update()
+{
+var x = Math.floor(Math.random() * width);
+var y = Math.floor(Math.random() * height);
+var el = document.getElementById("float" + x + "_" + y);
+el.className = toggle(el.className, "float", "float big");
+updateTimer();
+}
+setInterval(update, 0);
+}
+
+
+
+Framerate: calculating... fps
+
+Choose the size of the test:
+2 by 100
+20 by 100
+50 by 100
+100 by 100
+
+
+
\ No newline at end of file
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92443] trunk/Source/WebCore
Title: [92443] trunk/Source/WebCore
Revision 92443
Author commit-qu...@webkit.org
Date 2011-08-04 20:50:17 -0700 (Thu, 04 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from canvas IDL files
https://bugs.webkit.org/show_bug.cgi?id=65737
Patch by Mark Pilgrim on 2011-08-04
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* html/canvas/CanvasGradient.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasGradient.idl
trunk/Source/WebCore/html/canvas/Float32Array.idl
trunk/Source/WebCore/html/canvas/Float64Array.idl
trunk/Source/WebCore/html/canvas/Int16Array.idl
trunk/Source/WebCore/html/canvas/Int32Array.idl
trunk/Source/WebCore/html/canvas/Int8Array.idl
trunk/Source/WebCore/html/canvas/OESVertexArrayObject.idl
trunk/Source/WebCore/html/canvas/Uint16Array.idl
trunk/Source/WebCore/html/canvas/Uint32Array.idl
trunk/Source/WebCore/html/canvas/Uint8Array.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92442 => 92443)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 03:26:02 UTC (rev 92442)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 03:50:17 UTC (rev 92443)
@@ -1,3 +1,23 @@
+2011-08-04 Mark Pilgrim
+
+Remove LegacyDefaultOptionalArguments flag from canvas IDL files
+https://bugs.webkit.org/show_bug.cgi?id=65737
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* html/canvas/CanvasGradient.idl:
+* html/canvas/Float32Array.idl:
+* html/canvas/Float64Array.idl:
+* html/canvas/Int16Array.idl:
+* html/canvas/Int32Array.idl:
+* html/canvas/Int8Array.idl:
+* html/canvas/OESVertexArrayObject.idl:
+* html/canvas/Uint16Array.idl:
+* html/canvas/Uint32Array.idl:
+* html/canvas/Uint8Array.idl:
+
2011-08-04 MORITA Hajime
Reviewed by Ryosuke Niwa.
Modified: trunk/Source/WebCore/html/canvas/CanvasGradient.idl (92442 => 92443)
--- trunk/Source/WebCore/html/canvas/CanvasGradient.idl 2011-08-05 03:26:02 UTC (rev 92442)
+++ trunk/Source/WebCore/html/canvas/CanvasGradient.idl 2011-08-05 03:50:17 UTC (rev 92443)
@@ -26,12 +26,12 @@
module html {
interface [
-LegacyDefaultOptionalArguments,
InterfaceUUID=bb1108ea-6b8c-4a08-894a-218628630cdb,
ImplementationUUID=a2942ae6-2731-4286-98cc-9d5e79e20de1
] CanvasGradient {
-void addColorStop(in float offset, in DOMString color)
+void addColorStop(in [Optional=CallWithDefaultValue] float offset,
+ in [Optional=CallWithDefaultValue] DOMString color)
raises (DOMException);
};
Modified: trunk/Source/WebCore/html/canvas/Float32Array.idl (92442 => 92443)
--- trunk/Source/WebCore/html/canvas/Float32Array.idl 2011-08-05 03:26:02 UTC (rev 92442)
+++ trunk/Source/WebCore/html/canvas/Float32Array.idl 2011-08-05 03:50:17 UTC (rev 92443)
@@ -26,7 +26,6 @@
module html {
interface [
-LegacyDefaultOptionalArguments,
CanBeConstructed,
CustomConstructFunction,
V8CustomConstructor,
@@ -40,7 +39,8 @@
const unsigned int BYTES_PER_ELEMENT = 4;
readonly attribute unsigned long length;
-Float32Array subarray(in long start, in [Optional] long end);
+Float32Array subarray(in [Optional=CallWithDefaultValue] long start,
+ in [Optional] long end);
// void set(in Float32Array array, [Optional] in unsigned long offset);
// void set(in sequence array, [Optional] in unsigned long offset);
Modified: trunk/Source/WebCore/html/canvas/Float64Array.idl (92442 => 92443)
--- trunk/Source/WebCore/html/canvas/Float64Array.idl 2011-08-05 03:26:02 UTC (rev 92442)
+++ trunk/Source/WebCore/html/canvas/Float64Array.idl 2011-08-05 03:50:17 UTC (rev 92443)
@@ -26,7 +26,6 @@
module html {
interface [
-LegacyDefaultOptionalArguments,
CanBeConstructed,
CustomConstructFunction,
V8CustomConstructor,
@@ -40,7 +39,8 @@
const unsigned int BYTES_PER_ELEMENT = 8;
readonly attribute unsigned long length;
-Float64Array subarray(in long start, in [Optional] long end);
+Float64Array subarray(in [Optional=CallWithDefaultValue] long start,
+ in [Optional] long end);
// void set(in Float64Array array, [Optional] in unsigned long offset);
// void set(in sequence array, [Optional] in unsigned long offset);
Modified: trunk/Source/WebCore/html/canvas/Int16Array.idl (92442 => 92443)
--- trunk/Source/WebCore/html/canvas/Int16Array.idl 2011-08-05 03:26:02 UTC (rev 92442)
+++ tru
[webkit-changes] [92442] trunk/Tools
Title: [92442] trunk/Tools Revision 92442 Author aba...@webkit.org Date 2011-08-04 20:26:02 -0700 (Thu, 04 Aug 2011) Log Message model.js needs some unit testing https://bugs.webkit.org/show_bug.cgi?id=65730 Reviewed by Dimitri Glazkov. These tests do not cover all the functions exported by the model module. We'll need to add the remaining ones in the future. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html trunk/Tools/ChangeLog Added Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js Diff Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js (0 => 92442) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js (rev 0) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js 2011-08-05 03:26:02 UTC (rev 92442) @@ -0,0 +1,180 @@ +/* + * Copyright (C) 2011 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +(function () { + +module("model"); + +var kExampleCommitDataXML = +'\n\n' + +'\n\n' + +' \n\n' + +'\n\n' + +' \n\n' + +'Revisions of /trunk\n\n' + +'http://trac.webkit.org/log/trunk?rev=92362\n\n' + +'Trac Log - Revisions of /trunk\n\n' + +'en-US\n\n' + +'Trac 0.11.7\n\n' + +'\n\n' + +' WebKit\n\n' + +' http://trac.webkit.org/chrome/site/icon.png\n\n' + +' http://trac.webkit.org/log/trunk?rev=92362\n\n' + +'\n\n' + +'\n' + +' commit-qu...@webkit.org\n' + +' Wed, 03 Aug 2011 04:26:52 GMT\n' + +' Revision 92259: Unreviewed, rolling out r92256.\n' + +'http://trac.webkit.org/changeset/92256 ...\n' + +' http://trac.webkit.org/changeset/92259/trunk\n' + +' http://trac.webkit.org/changeset/92259/trunk\n' + +'http://trac.webkit.org/changeset/92256\n' + +' https://bugs.webkit.org/show_bug.cgi?id=65593\n' + +'\n' + +'\n' + +'Unreviewed, rolling out r92256.\n' + +'
\n' + +'Causing tons of crashes on the chromium win bots (Requested by\n' + +'jamesr on #webkit).\n' + +'
\n' + +'\n' + +'Patch by Sheriff Bot < webkit.review@gmail.com> on 2011-08-02\n' + +'
\n' + +'\n' + +'* dom/Event.cpp:\n' + +'* dom/Event.h:\n' + +'* dom/EventDispatcher.cpp:\n' + +'(WebCore::EventDispatcher::dispatchEvent):\n' + +'* dom/EventDispatcher.h:\n' + +'* dom/KeyboardEvent.cpp:\n' + +'* dom/KeyboardEvent.h:\n' + +'* dom/MouseEvent.cpp:\n' + +'* dom/MouseEvent.h:\n' + +'* dom/Node.cpp:\n' + +'(WebCore::Node::dispatchEvent):\n' + +'(WebCore::Node::dispatchKeyEvent):\n' + +'(WebCore::Node::dispatchMouseEvent):\n' + +'(WebCore::Node::dispatchWheelEvent):\n' + +'* dom/WheelEvent.cpp:\n' + +'* dom/WheelEvent.h:\n' + +'
\n' + +'\n' + +' Log\n' + +'\n' + +' macpher...@chromium.org\n\n' + +' Thu, 04 Aug 2011 02:09:19 GMT\n\n' + +' Revision 92256: Support cast between CSSPrimitiveVa
[webkit-changes] [92441] trunk/Source/WebCore
Title: [92441] trunk/Source/WebCore Revision 92441 Author morr...@google.com Date 2011-08-04 20:25:53 -0700 (Thu, 04 Aug 2011) Log Message Reviewed by Ryosuke Niwa. DocumentMarker: Type specific details should be separately held by other object. https://bugs.webkit.org/show_bug.cgi?id=59855 - Introduced DocumentMarkerDetails abstract class and two its subclasses DocumentMarkerDescription and DocumentMarkerActiveMatch, - Replacing DocumentMarker::m_description and DocumentMarker::m_activeMatch with these new details classes. No new tests. No behavior change. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * dom/DOMAllInOne.cpp: * dom/DocumentMarker.cpp: Added. (WebCore::emptyDescription): (WebCore::DocumentMarkerDetails::DocumentMarkerDetails): (WebCore::DocumentMarkerDetails::~DocumentMarkerDetails): (WebCore::DocumentMarkerDescription::description): (WebCore::DocumentMarkerDescription::isDescription): (WebCore::DocumentMarkerDescription::DocumentMarkerDescription): (WebCore::DocumentMarkerDescription::createUnlessEmpty): (WebCore::DocumentMarkerDescription::compatibleTypes): (WebCore::DocumentMarkerTextMatch::activeMatch): (WebCore::DocumentMarkerTextMatch::isTextMatch): (WebCore::DocumentMarkerTextMatch::DocumentMarkerTextMatch): (WebCore::DocumentMarkerTextMatch::instanceFor): (WebCore::DocumentMarkerTextMatch::compatibleTypes): (WebCore::DocumentMarker::DocumentMarker): (WebCore::DocumentMarker::shiftOffsets): (WebCore::DocumentMarker::setActiveMatch): (WebCore::DocumentMarker::description): (WebCore::DocumentMarker::activeMatch): * dom/DocumentMarker.h: (WebCore::DocumentMarker::details): (WebCore::DocumentMarker::clearDetails): (WebCore::DocumentMarkerDetails::isDescription): (WebCore::DocumentMarkerDetails::isTextMatch): (WebCore::DocumentMarkerDetails::isAllowedFor): * dom/DocumentMarkerController.cpp: (WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange): * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/DOMAllInOne.cpp trunk/Source/WebCore/dom/DocumentMarker.h trunk/Source/WebCore/dom/DocumentMarkerController.cpp trunk/Source/WebCore/editing/CompositeEditCommand.cpp Added Paths trunk/Source/WebCore/dom/DocumentMarker.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (92440 => 92441) --- trunk/Source/WebCore/CMakeLists.txt 2011-08-05 01:45:39 UTC (rev 92440) +++ trunk/Source/WebCore/CMakeLists.txt 2011-08-05 03:25:53 UTC (rev 92441) @@ -515,6 +515,7 @@ dom/DeviceOrientationEvent.cpp dom/Document.cpp dom/DocumentMarkerController.cpp +dom/DocumentMarker.cpp dom/DocumentFragment.cpp dom/DocumentParser.cpp dom/DocumentOrderedMap.cpp Modified: trunk/Source/WebCore/ChangeLog (92440 => 92441) --- trunk/Source/WebCore/ChangeLog 2011-08-05 01:45:39 UTC (rev 92440) +++ trunk/Source/WebCore/ChangeLog 2011-08-05 03:25:53 UTC (rev 92441) @@ -1,3 +1,55 @@ +2011-08-04 MORITA Hajime + +Reviewed by Ryosuke Niwa. + +DocumentMarker: Type specific details should be separately held by other object. +https://bugs.webkit.org/show_bug.cgi?id=59855 + +- Introduced DocumentMarkerDetails abstract class and two its subclasses + DocumentMarkerDescription and DocumentMarkerActiveMatch, + +- Replacing DocumentMarker::m_description and + DocumentMarker::m_activeMatch with these new details classes. + +No new tests. No behavior change. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.pro: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* dom/DOMAllInOne.cpp: +* dom/DocumentMarker.cpp: Added. +(WebCore::emptyDescription): +(WebCore::DocumentMarkerDetails::DocumentMarkerDetails): +(WebCore::DocumentMarkerDetails::~DocumentMarkerDetails): +(WebCore::DocumentMarkerDescription::description): +(WebCore::DocumentMarkerDescription::isDescription): +(WebCore::DocumentMarkerDescription::DocumentMarkerDescription): +(WebCore::DocumentMarkerDescription::createUnlessEmpty): +(WebCore::DocumentMarkerDescription::compatibleTypes): +(WebCore::DocumentMarkerTextMatch::activeMatch): +(WebCore::DocumentMarkerTextMatch::isTextMatch): +(WebCore::DocumentMarkerTextMatch::DocumentMarkerTextMatch): +(WebCore::DocumentMarkerTextMatch::instanceFor): +(WebCore::DocumentMarkerTextMatch::compa
[webkit-changes] [92440] trunk/Tools
Title: [92440] trunk/Tools Revision 92440 Author aba...@webkit.org Date 2011-08-04 18:45:39 -0700 (Thu, 04 Aug 2011) Log Message Another speculative fix for the "svn revision on Windows" problem. * Scripts/webkitpy/common/checkout/scm/git.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py Diff Modified: trunk/Tools/ChangeLog (92439 => 92440) --- trunk/Tools/ChangeLog 2011-08-05 01:32:24 UTC (rev 92439) +++ trunk/Tools/ChangeLog 2011-08-05 01:45:39 UTC (rev 92440) @@ -1,3 +1,9 @@ +2011-08-04 Adam Barth + +Another speculative fix for the "svn revision on Windows" problem. + +* Scripts/webkitpy/common/checkout/scm/git.py: + 2011-08-04 Mark Rowe Future-proof Xcode configuration settings. Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py (92439 => 92440) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2011-08-05 01:32:24 UTC (rev 92439) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py 2011-08-05 01:45:39 UTC (rev 92440) @@ -99,8 +99,12 @@ @classmethod def in_working_directory(cls, path): -# FIXME: This should use an Executive. -return run_command(['git', 'rev-parse', '--is-inside-work-tree'], cwd=path, error_handler=Executive.ignore_error).rstrip() == "true" +try: +# FIXME: This should use an Executive. +return run_command(['git', 'rev-parse', '--is-inside-work-tree'], cwd=path, error_handler=Executive.ignore_error).rstrip() == "true" +except OSError, e: +# The Windows bots seem to through a WindowsError when git isn't installed. +return False @classmethod def find_checkout_root(cls, path): ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92439] trunk
Title: [92439] trunk
Revision 92439
Author commit-qu...@webkit.org
Date 2011-08-04 18:32:24 -0700 (Thu, 04 Aug 2011)
Log Message
Bad interaction between document destruction and unload events
https://bugs.webkit.org/show_bug.cgi?id=64741
Patch by Scott Graham on 2011-08-04
Reviewed by Adam Barth.
Source/WebCore:
Three different errors triggered by this test case. The case to
consider is a subdocument with an onunload on an element, that
destroys the parent document during the onunload. One fix was a
lifetime issue fixed by a protecting RefPtr, and another was an
additional cancel of event triggers. The main fix was that during the
transition to commited state, the documentLoader is being replaced by
the provisionalDocumentLoader. But, because during firing events in
the subdocument the parent is destroyed, that subevent caused the
provisionalDocumentLoader to be detached from its frame. By marking
the page as being in committed state before the parent documentLoader
is set, this is avoided.
Test: loader/document-destruction-within-unload.html
* dom/Document.cpp:
(WebCore::Document::implicitOpen):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::detachChildren):
LayoutTests:
* loader/document-destruction-within-unload-expected.txt: Added.
* loader/document-destruction-within-unload.html: Added.
* loader/resources/document-destruction-within-unload-iframe.html: Added.
* loader/resources/document-destruction-within-unload.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
Added Paths
trunk/LayoutTests/loader/document-destruction-within-unload-expected.txt
trunk/LayoutTests/loader/document-destruction-within-unload.html
trunk/LayoutTests/loader/resources/document-destruction-within-unload-iframe.html
trunk/LayoutTests/loader/resources/document-destruction-within-unload.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (92438 => 92439)
--- trunk/LayoutTests/ChangeLog 2011-08-05 01:07:04 UTC (rev 92438)
+++ trunk/LayoutTests/ChangeLog 2011-08-05 01:32:24 UTC (rev 92439)
@@ -1,3 +1,15 @@
+2011-08-04 Scott Graham
+
+Bad interaction between document destruction and unload events
+https://bugs.webkit.org/show_bug.cgi?id=64741
+
+Reviewed by Adam Barth.
+
+* loader/document-destruction-within-unload-expected.txt: Added.
+* loader/document-destruction-within-unload.html: Added.
+* loader/resources/document-destruction-within-unload-iframe.html: Added.
+* loader/resources/document-destruction-within-unload.svg: Added.
+
2011-08-04 Kent Tamura
Move tests to fast/forms/week/
Added: trunk/LayoutTests/loader/document-destruction-within-unload-expected.txt (0 => 92439)
--- trunk/LayoutTests/loader/document-destruction-within-unload-expected.txt (rev 0)
+++ trunk/LayoutTests/loader/document-destruction-within-unload-expected.txt 2011-08-05 01:32:24 UTC (rev 92439)
@@ -0,0 +1,2 @@
+
+For the test to pass there should be no crash.
Added: trunk/LayoutTests/loader/document-destruction-within-unload.html (0 => 92439)
--- trunk/LayoutTests/loader/document-destruction-within-unload.html (rev 0)
+++ trunk/LayoutTests/loader/document-destruction-within-unload.html 2011-08-05 01:32:24 UTC (rev 92439)
@@ -0,0 +1,20 @@
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+
+For the test to pass there should be no crash.
+
+function done() {
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+
+
+
Property changes on: trunk/LayoutTests/loader/document-destruction-within-unload.html
___
Added: svn:executable
Added: trunk/LayoutTests/loader/resources/document-destruction-within-unload-iframe.html (0 => 92439)
--- trunk/LayoutTests/loader/resources/document-destruction-within-unload-iframe.html (rev 0)
+++ trunk/LayoutTests/loader/resources/document-destruction-within-unload-iframe.html 2011-08-05 01:32:24 UTC (rev 92439)
@@ -0,0 +1,16 @@
+
+
+
+function runTest() {
+var test = document.getElementById('root').contentDocument;
+test.firstChild.setAttribute('onunload', "parent.clearUs();");
+location.reload();
+}
+function clearUs() {
+document.write();
+}
+
+
+
+
Property changes on: trunk/LayoutTests/loader/resources/document-destruction-within-unload-iframe.html
___
Adde
[webkit-changes] [92438] trunk/Source/WebCore
Title: [92438] trunk/Source/WebCore Revision 92438 Author simon.fra...@apple.com Date 2011-08-04 18:07:04 -0700 (Thu, 04 Aug 2011) Log Message 2011-08-04 Simon Fraser Add code to determine whether a Range in inside fixed position content https://bugs.webkit.org/show_bug.cgi?id=65720 Reviewed by Sam Weinig. Propagate the 'wasFixed' flag out from various methods that are used when computing the collection of rects or quads for a range. Use the flag in Range to computer whether the Range is entirely within, partially within, or outside of fixed-position content. * WebCore.exp.in: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::boundingBoxRect): * dom/Range.cpp: (WebCore::Range::textRects): (WebCore::Range::textQuads): * dom/Range.h: * rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteQuads): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteQuads): * rendering/RenderBox.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteQuads): * rendering/RenderInline.h: * rendering/RenderObject.h: (WebCore::RenderObject::absoluteQuads): * rendering/RenderText.cpp: (WebCore::RenderText::absoluteRectsForRange): (WebCore::RenderText::absoluteQuads): (WebCore::RenderText::absoluteQuadsForRange): * rendering/RenderText.h: * rendering/RenderView.cpp: (WebCore::RenderView::absoluteQuads): * rendering/RenderView.h: * rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteQuads): * rendering/svg/RenderSVGHiddenContainer.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteQuads): * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteQuads): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteQuads): * rendering/svg/RenderSVGText.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/dom/Range.cpp trunk/Source/WebCore/dom/Range.h trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderBlock.h trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderText.cpp trunk/Source/WebCore/rendering/RenderText.h trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/RenderView.h trunk/Source/WebCore/rendering/svg/RenderSVGHiddenContainer.cpp trunk/Source/WebCore/rendering/svg/RenderSVGHiddenContainer.h trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInline.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h Diff Modified: trunk/Source/WebCore/ChangeLog (92437 => 92438) --- trunk/Source/WebCore/ChangeLog 2011-08-05 00:51:19 UTC (rev 92437) +++ trunk/Source/WebCore/ChangeLog 2011-08-05 01:07:04 UTC (rev 92438) @@ -1,3 +1,55 @@ +2011-08-04 Simon Fraser + +Add code to determine whether a Range in inside fixed position content +https://bugs.webkit.org/show_bug.cgi?id=65720 + +Reviewed by Sam Weinig. + +Propagate the 'wasFixed' flag out from various methods that +are used when computing the collection of rects or quads +for a range. Use the flag in Range to computer whether +the Range is entirely within, partially within, or outside +of fixed-position content. + +* WebCore.exp.in: +* accessibility/AccessibilityRenderObject.cpp: +(WebCore::AccessibilityRenderObject::boundingBoxRect): +* dom/Range.cpp: +(WebCore::Range::textRects): +(WebCore::Range::textQuads): +* dom/Range.h: +* rendering/RenderBlock.cpp: +(WebCore::RenderBlock::absoluteQuads): +* rendering/RenderBlock.h: +* rendering/RenderBox.cpp: +(WebCore::RenderBox::absoluteQuads): +* rendering/RenderBox.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::absoluteQuads): +* rendering/RenderInline.h: +* rendering/RenderObject.h: +(WebCore::RenderObject::absoluteQuads): +* rendering/RenderText.cpp: +(WebCore::RenderText::absoluteRectsForRa
[webkit-changes] [92437] trunk/Source
Title: [92437] trunk/Source
Revision 92437
Author le...@chromium.org
Date 2011-08-04 17:51:19 -0700 (Thu, 04 Aug 2011)
Log Message
CStringBuffer should have thread safety checks turned on.
https://bugs.webkit.org/show_bug.cgi?id=58093
Reviewed by Dmitry Titov.
Source/_javascript_Core:
* wtf/text/CString.h:
(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
turned this off for Chromium.
Source/WebKit/chromium:
* DEPS: Roll far enough to pick up the latest WebKit::initialize
fix for Linux.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/CString.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92436 => 92437)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-05 00:39:28 UTC (rev 92436)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-05 00:51:19 UTC (rev 92437)
@@ -1,3 +1,14 @@
+2011-08-04 David Levin
+
+CStringBuffer should have thread safety checks turned on.
+https://bugs.webkit.org/show_bug.cgi?id=58093
+
+Reviewed by Dmitry Titov.
+
+* wtf/text/CString.h:
+(WTF::CStringBuffer::CStringBuffer): Removed the ifdef that
+turned this off for Chromium.
+
2011-08-04 Mark Rowe
Future-proof Xcode configuration settings.
Modified: trunk/Source/_javascript_Core/wtf/text/CString.h (92436 => 92437)
--- trunk/Source/_javascript_Core/wtf/text/CString.h 2011-08-05 00:39:28 UTC (rev 92436)
+++ trunk/Source/_javascript_Core/wtf/text/CString.h 2011-08-05 00:51:19 UTC (rev 92437)
@@ -41,14 +41,7 @@
friend class CString;
static PassRefPtr create(size_t length) { return adoptRef(new CStringBuffer(length)); }
-CStringBuffer(size_t length) : m_vector(length)
-{
-#if PLATFORM(CHROMIUM)
-// FIXME: Need to fix some start-up code in Chromium Linux and some test code for
-// Chromium OS X in order to remove this.
-deprecatedTurnOffVerifier();
-#endif
-}
+CStringBuffer(size_t length) : m_vector(length) { }
char* mutableData() { return m_vector.data(); }
Vector m_vector;
Modified: trunk/Source/WebKit/chromium/ChangeLog (92436 => 92437)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-05 00:39:28 UTC (rev 92436)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-05 00:51:19 UTC (rev 92437)
@@ -1,3 +1,13 @@
+2011-08-04 David Levin
+
+CStringBuffer should have thread safety checks turned on.
+https://bugs.webkit.org/show_bug.cgi?id=58093
+
+Reviewed by Dmitry Titov.
+
+* DEPS: Roll far enough to pick up the latest WebKit::initialize
+fix for Linux.
+
2011-08-04 Sheriff Bot
Unreviewed, rolling out r92415.
Modified: trunk/Source/WebKit/chromium/DEPS (92436 => 92437)
--- trunk/Source/WebKit/chromium/DEPS 2011-08-05 00:39:28 UTC (rev 92436)
+++ trunk/Source/WebKit/chromium/DEPS 2011-08-05 00:51:19 UTC (rev 92437)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '94850'
+ 'chromium_rev': '95533'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92436] trunk/Source/WebCore
Title: [92436] trunk/Source/WebCore
Revision 92436
Author commit-qu...@webkit.org
Date 2011-08-04 17:39:28 -0700 (Thu, 04 Aug 2011)
Log Message
Remove LegacyDefaultOptionalArguments flag from Document.idl
https://bugs.webkit.org/show_bug.cgi?id=65717
Patch by Mark Pilgrim on 2011-08-04
Reviewed by Adam Barth.
No new tests, all existing tests pass.
* dom/Document.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (92435 => 92436)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 00:26:51 UTC (rev 92435)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 00:39:28 UTC (rev 92436)
@@ -1,3 +1,14 @@
+2011-08-04 Mark Pilgrim
+
+Remove LegacyDefaultOptionalArguments flag from Document.idl
+https://bugs.webkit.org/show_bug.cgi?id=65717
+
+Reviewed by Adam Barth.
+
+No new tests, all existing tests pass.
+
+* dom/Document.idl:
+
2011-08-04 Simon Fraser
Fix release build failure with last commit.
Modified: trunk/Source/WebCore/dom/Document.idl (92435 => 92436)
--- trunk/Source/WebCore/dom/Document.idl 2011-08-05 00:26:51 UTC (rev 92435)
+++ trunk/Source/WebCore/dom/Document.idl 2011-08-05 00:39:28 UTC (rev 92436)
@@ -21,7 +21,6 @@
module core {
interface [
-LegacyDefaultOptionalArguments,
CustomToJS,
GenerateNativeConverter,
InlineGetOwnPropertySlot
@@ -32,36 +31,36 @@
readonly attribute DOMImplementation implementation;
readonly attribute Element documentElement;
-[ReturnsNew] Element createElement(in [ConvertNullToNullString] DOMString tagName)
+[ReturnsNew] Element createElement(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString tagName)
raises (DOMException);
DocumentFragment createDocumentFragment();
-[ReturnsNew] Text createTextNode(in DOMString data);
-[ReturnsNew] Comment createComment(in DOMString data);
-[ReturnsNew] CDATASection createCDATASection(in DOMString data)
+[ReturnsNew] Text createTextNode(in [Optional=CallWithDefaultValue] DOMString data);
+[ReturnsNew] Comment createComment(in [Optional=CallWithDefaultValue] DOMString data);
+[ReturnsNew] CDATASection createCDATASection(in [Optional=CallWithDefaultValue] DOMString data)
raises(DOMException);
-[OldStyleObjC, ReturnsNew] ProcessingInstruction createProcessingInstruction(in DOMString target,
- in DOMString data)
+[OldStyleObjC, ReturnsNew] ProcessingInstruction createProcessingInstruction(in [Optional=CallWithDefaultValue] DOMString target,
+ in [Optional=CallWithDefaultValue] DOMString data)
raises (DOMException);
-[ReturnsNew] Attr createAttribute(in DOMString name)
+[ReturnsNew] Attr createAttribute(in [Optional=CallWithDefaultValue] DOMString name)
raises (DOMException);
-[ReturnsNew] EntityReference createEntityReference(in DOMString name)
+[ReturnsNew] EntityReference createEntityReference(in [Optional=CallWithDefaultValue] DOMString name)
raises(DOMException);
-NodeList getElementsByTagName(in DOMString tagname);
+NodeList getElementsByTagName(in [Optional=CallWithDefaultValue] DOMString tagname);
// Introduced in DOM Level 2:
-[OldStyleObjC, ReturnsNew] Node importNode(in Node importedNode,
- in boolean deep)
+[OldStyleObjC, ReturnsNew] Node importNode(in [Optional=CallWithDefaultValue] Node importedNode,
+ in [Optional=CallWithDefaultValue] boolean deep)
raises (DOMException);
-[OldStyleObjC, ReturnsNew] Element createElementNS(in [ConvertNullToNullString] DOMString namespaceURI,
- in [ConvertNullToNullString] DOMString qualifiedName)
+[OldStyleObjC, ReturnsNew] Element createElementNS(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
+ in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString qualifiedName)
raises (DOMException);
-[OldStyleObjC, ReturnsNew] Attr createAttributeNS(in [ConvertNullToNullString] DOMString namespaceURI,
- in [ConvertNullToNullString] DOMString qualifiedName)
+[OldStyleObjC, ReturnsNew] Attr createAttributeNS(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString namespaceURI,
+ in [ConvertNullToNullString,Optional=CallWithDe
[webkit-changes] [92435] trunk/Source/WebCore
Title: [92435] trunk/Source/WebCore
Revision 92435
Author simon.fra...@apple.com
Date 2011-08-04 17:26:51 -0700 (Thu, 04 Aug 2011)
Log Message
2011-08-04 Simon Fraser
Fix release build failure with last commit.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92434 => 92435)
--- trunk/Source/WebCore/ChangeLog 2011-08-05 00:19:41 UTC (rev 92434)
+++ trunk/Source/WebCore/ChangeLog 2011-08-05 00:26:51 UTC (rev 92435)
@@ -1,5 +1,12 @@
2011-08-04 Simon Fraser
+Fix release build failure with last commit.
+
+* rendering/RenderView.cpp:
+(WebCore::RenderView::mapLocalToContainer):
+
+2011-08-04 Simon Fraser
+
Add code to determine whether a Range in inside fixed position content
https://bugs.webkit.org/show_bug.cgi?id=65720
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (92434 => 92435)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2011-08-05 00:19:41 UTC (rev 92434)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2011-08-05 00:26:51 UTC (rev 92435)
@@ -142,8 +142,7 @@
// If a container was specified, and was not 0 or the RenderView,
// then we should have found it by now.
ASSERT_ARG(repaintContainer, !repaintContainer || repaintContainer == this);
-ASSERT(!wasFixed || *wasFixed == fixed);
-UNUSED_PARAM(fixed);
+ASSERT_UNUSED(wasFixed, !wasFixed || *wasFixed == fixed);
if (!repaintContainer && useTransforms && shouldUseTransformFromContainer(0)) {
TransformationMatrix t;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92434] trunk/Source/WebCore
Title: [92434] trunk/Source/WebCore Revision 92434 Author simon.fra...@apple.com Date 2011-08-04 17:19:41 -0700 (Thu, 04 Aug 2011) Log Message 2011-08-04 Simon Fraser Add code to determine whether a Range in inside fixed position content https://bugs.webkit.org/show_bug.cgi?id=65720 Reviewed by Dan Bernstein. Add an out param for various coordinate mapping functions that tells us whether the point or rectangle being mapped is inside fixed-position content. This brings back some of the changes from r89754. No behavior changes, so no tests. * rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): * rendering/RenderBox.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::mapLocalToContainer): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::mapLocalToContainer): (WebCore::RenderObject::localToContainerQuad): * rendering/RenderObject.h: (WebCore::RenderObject::localToAbsoluteQuad): * rendering/RenderView.cpp: (WebCore::RenderView::mapLocalToContainer): * rendering/RenderView.h: * rendering/svg/RenderSVGForeignObject.cpp: (WebCore::RenderSVGForeignObject::mapLocalToContainer): * rendering/svg/RenderSVGForeignObject.h: * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::mapLocalToContainer): * rendering/svg/RenderSVGInline.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::mapLocalToContainer): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): * rendering/svg/RenderSVGText.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::mapLocalToContainer): * rendering/svg/SVGRenderSupport.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderInline.h trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderView.cpp trunk/Source/WebCore/rendering/RenderView.h trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGForeignObject.h trunk/Source/WebCore/rendering/svg/RenderSVGInline.cpp trunk/Source/WebCore/rendering/svg/RenderSVGInline.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h trunk/Source/WebCore/rendering/svg/RenderSVGText.cpp trunk/Source/WebCore/rendering/svg/RenderSVGText.h trunk/Source/WebCore/rendering/svg/SVGRenderSupport.cpp trunk/Source/WebCore/rendering/svg/SVGRenderSupport.h Diff Modified: trunk/Source/WebCore/ChangeLog (92433 => 92434) --- trunk/Source/WebCore/ChangeLog 2011-08-05 00:03:14 UTC (rev 92433) +++ trunk/Source/WebCore/ChangeLog 2011-08-05 00:19:41 UTC (rev 92434) @@ -1,3 +1,51 @@ +2011-08-04 Simon Fraser + +Add code to determine whether a Range in inside fixed position content +https://bugs.webkit.org/show_bug.cgi?id=65720 + +Reviewed by Dan Bernstein. + +Add an out param for various coordinate mapping functions +that tells us whether the point or rectangle being +mapped is inside fixed-position content. + +This brings back some of the changes from r89754. + +No behavior changes, so no tests. + +* rendering/RenderBox.cpp: +(WebCore::RenderBox::mapLocalToContainer): +* rendering/RenderBox.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::mapLocalToContainer): +* rendering/RenderInline.h: +* rendering/RenderObject.cpp: +(WebCore::RenderObject::mapLocalToContainer): +(WebCore::RenderObject::localToContainerQuad): +* rendering/RenderObject.h: +(WebCore::RenderObject::localToAbsoluteQuad): +* rendering/RenderView.cpp: +(WebCore::RenderView::mapLocalToContainer): +* rendering/RenderView.h: +* rendering/svg/RenderSVGForeignObject.cpp: +(WebCore::RenderSVGForeignObject::mapLocalToContainer): +* rendering/svg/RenderSVGForeignObject.h: +* rendering/svg/RenderSVGInline.cpp: +(WebCore::RenderSVGInline::mapLocalToContainer): +* rendering/svg/RenderSVGInline.h: +* rendering/svg/RenderSVGModelObject.cpp: +(WebCore::RenderSVGModelObject::mapLocalToContainer): +
[webkit-changes] [92431] trunk/Source/WebCore
Title: [92431] trunk/Source/WebCore
Revision 92431
Author commit-qu...@webkit.org
Date 2011-08-04 16:56:24 -0700 (Thu, 04 Aug 2011)
Log Message
A few purely stylistic modifications to visible_units.cpp
https://bugs.webkit.org/show_bug.cgi?id=65723
Patch by Van Lam on 2011-08-04
Reviewed by Ryosuke Niwa.
Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox
to positionIsInBoxButNotOnBoundary (to avoid confusion with
positionIsInBox, which is just a getInlineBoxAndOffset check).
Removed use of invalidOffset as an error value in greatestOffsetUnder
and smallestOffsetAbove since semantically it should only be used to
check if it makes sense to compare offsets in a single box.
* editing/visible_units.cpp:
(WebCore::greatestOffsetUnder):
(WebCore::smallestOffsetAbove):
(WebCore::positionIsInBoxButNotOnBoundary):
(WebCore::leftWordPositionAcrossBoundary):
(WebCore::rightWordPositionAcrossBoundary):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92430 => 92431)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 23:46:59 UTC (rev 92430)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 23:56:24 UTC (rev 92431)
@@ -1,3 +1,24 @@
+2011-08-04 Van Lam
+
+A few purely stylistic modifications to visible_units.cpp
+https://bugs.webkit.org/show_bug.cgi?id=65723
+
+Reviewed by Ryosuke Niwa.
+
+Renamed greatestValueUnder to greatestOffsetUnder, positionIsInsideBox
+to positionIsInBoxButNotOnBoundary (to avoid confusion with
+positionIsInBox, which is just a getInlineBoxAndOffset check).
+Removed use of invalidOffset as an error value in greatestOffsetUnder
+and smallestOffsetAbove since semantically it should only be used to
+check if it makes sense to compare offsets in a single box.
+
+* editing/visible_units.cpp:
+(WebCore::greatestOffsetUnder):
+(WebCore::smallestOffsetAbove):
+(WebCore::positionIsInBoxButNotOnBoundary):
+(WebCore::leftWordPositionAcrossBoundary):
+(WebCore::rightWordPositionAcrossBoundary):
+
2011-08-04 James Robinson
[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
Modified: trunk/Source/WebCore/editing/visible_units.cpp (92430 => 92431)
--- trunk/Source/WebCore/editing/visible_units.cpp 2011-08-04 23:46:59 UTC (rev 92430)
+++ trunk/Source/WebCore/editing/visible_units.cpp 2011-08-04 23:56:24 UTC (rev 92431)
@@ -1444,42 +1444,42 @@
return VisiblePosition();
}
-static int greatestValueUnder(int offset, bool boxAndBlockAreInSameDirection, const WordBoundaryVector& orderedWordBoundaries)
+static int greatestOffsetUnder(int offset, bool boxAndBlockAreInSameDirection, const WordBoundaryVector& orderedWordBoundaries)
{
if (!orderedWordBoundaries.size())
-return invalidOffset;
+return -1;
// FIXME: binary search.
if (boxAndBlockAreInSameDirection) {
for (unsigned i = 0; i < orderedWordBoundaries.size(); ++i) {
if (orderedWordBoundaries[i].offsetInInlineBox < offset)
return i;
}
-return invalidOffset;
+return -1;
}
for (int i = orderedWordBoundaries.size() - 1; i >= 0; --i) {
if (orderedWordBoundaries[i].offsetInInlineBox < offset)
return i;
}
-return invalidOffset;
+return -1;
}
static int smallestOffsetAbove(int offset, bool boxAndBlockAreInSameDirection, const WordBoundaryVector& orderedWordBoundaries)
{
if (!orderedWordBoundaries.size())
-return invalidOffset;
+return -1;
// FIXME: binary search.
if (boxAndBlockAreInSameDirection) {
for (int i = orderedWordBoundaries.size() - 1; i >= 0; --i) {
if (orderedWordBoundaries[i].offsetInInlineBox > offset)
return i;
}
-return invalidOffset;
+return -1;
}
for (unsigned i = 0; i < orderedWordBoundaries.size(); ++i) {
if (orderedWordBoundaries[i].offsetInInlineBox > offset)
return i;
}
-return invalidOffset;
+return -1;
}
static const RenderBlock* blockWithPreviousLineBox(const RenderBlock* startingBlock)
@@ -1599,7 +1599,7 @@
return VisiblePosition();
}
-static bool positionIsInsideBox(const VisiblePosition& wordBreak, const InlineBox* box)
+static bool positionIsInBoxButNotOnBoundary(const VisiblePosition& wordBreak, const InlineBox* box)
{
int offsetOfWordBreak;
return positionIsInBox(wordBreak, box, offsetOfWordBreak)
@@ -1633,15 +1633,15 @@
else
wordBreak = nextBoundary(visiblePosition, nextWordPositionBoundary);
}
-if (wordBreak.isNotNull() && positionIsInsideBox(wordBreak, box))
+if (wordBreak.isNotNull() && positionIsInBoxButNotOnBoundary(wordBreak, box))
[webkit-changes] [92430] trunk/Source/WebCore
Title: [92430] trunk/Source/WebCore
Revision 92430
Author commit-qu...@webkit.org
Date 2011-08-04 16:46:59 -0700 (Thu, 04 Aug 2011)
Log Message
[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
https://bugs.webkit.org/show_bug.cgi?id=65655
Patch by James Robinson on 2011-08-04
Reviewed by Kenneth Russell.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::setResourceLimit):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp
trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92429 => 92430)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 23:25:41 UTC (rev 92429)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 23:46:59 UTC (rev 92430)
@@ -1,3 +1,16 @@
+2011-08-04 James Robinson
+
+[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
+https://bugs.webkit.org/show_bug.cgi?id=65655
+
+Reviewed by Kenneth Russell.
+
+* platform/graphics/gpu/DrawingBuffer.cpp:
+(WebCore::DrawingBuffer::setResourceLimit):
+(WebCore::DrawingBuffer::clear):
+(WebCore::DrawingBuffer::reset):
+* platform/graphics/gpu/DrawingBuffer.h:
+
2011-08-04 Kenichi Ishibashi
[Chromium] Reduce memory consumption of HarfbuzzFace
Modified: trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp (92429 => 92430)
--- trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2011-08-04 23:25:41 UTC (rev 92429)
+++ trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.cpp 2011-08-04 23:46:59 UTC (rev 92430)
@@ -38,6 +38,16 @@
namespace WebCore {
+// Global resource ceiling (expressed in terms of pixels) for DrawingBuffer creation and resize.
+// When this limit is set, DrawingBuffer::create() and DrawingBuffer::reset() calls that would
+// exceed the global cap will instead clear the buffer.
+#if PLATFORM(CHROMIUM) // Currently, this cap only exists for chromium.
+static int s_maximumResourceUsePixels = 16 * 1024 * 1024;
+#else
+static int s_maximumResourceUsePixels = 0;
+#endif
+static int s_currentResourceUsePixels = 0;
+
PassRefPtr DrawingBuffer::create(GraphicsContext3D* context, const IntSize& size)
{
Extensions3D* extensions = context->getExtensions();
@@ -60,6 +70,8 @@
return;
m_context->makeContextCurrent();
+if (!m_size.isEmpty())
+s_currentResourceUsePixels -= m_size.width() * m_size.height();
if (m_colorBuffer) {
m_context->deleteTexture(m_colorBuffer);
@@ -202,10 +214,20 @@
int maxTextureSize = 0;
m_context->getIntegerv(GraphicsContext3D::MAX_TEXTURE_SIZE, &maxTextureSize);
if (newSize.height() > maxTextureSize || newSize.width() > maxTextureSize) {
- clear();
- return false;
+clear();
+return false;
}
+int pixelDelta = newSize.width() * newSize.height();
+if (!m_size.isEmpty())
+pixelDelta -= m_size.width() * m_size.height();
+
+if (s_maximumResourceUsePixels && (s_currentResourceUsePixels + pixelDelta) > s_maximumResourceUsePixels) {
+clear();
+return false;
+}
+s_currentResourceUsePixels += pixelDelta;
+
const GraphicsContext3D::Attributes& attributes = m_context->getContextAttributes();
if (newSize != m_size) {
Modified: trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h (92429 => 92430)
--- trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h 2011-08-04 23:25:41 UTC (rev 92429)
+++ trunk/Source/WebCore/platform/graphics/gpu/DrawingBuffer.h 2011-08-04 23:46:59 UTC (rev 92430)
@@ -58,7 +58,7 @@
class DrawingBuffer : public RefCounted {
public:
friend class GraphicsContext3D;
-
+
~DrawingBuffer();
void clearFramebuffer();
@@ -114,7 +114,7 @@
static PassRefPtr create(GraphicsContext3D*, const IntSize&);
DrawingBuffer(GraphicsContext3D*, const IntSize&, bool multisampleExtensionSupported, bool packedDepthStencilExtensionSupported);
-
+
// Platform specific function called after reset() so each platform can do extra work if needed
void didReset();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92429] trunk/Tools
Title: [92429] trunk/Tools
Revision 92429
Author aba...@webkit.org
Date 2011-08-04 16:25:41 -0700 (Thu, 04 Aug 2011)
Log Message
Fancier debug logging.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
Diff
Modified: trunk/Tools/ChangeLog (92428 => 92429)
--- trunk/Tools/ChangeLog 2011-08-04 23:20:31 UTC (rev 92428)
+++ trunk/Tools/ChangeLog 2011-08-04 23:25:41 UTC (rev 92429)
@@ -1,3 +1,9 @@
+2011-08-04 Adam Barth
+
+Fancier debug logging.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+
2011-08-04 David Levin
[chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (92428 => 92429)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-08-04 23:20:31 UTC (rev 92428)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-08-04 23:25:41 UTC (rev 92429)
@@ -217,8 +217,9 @@
# Once we fix detect_scm_system to use the mock file system we can add this log back.
#_log.warn("Failed to determine svn revision for checkout (cwd: %s, webkit_base: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj._filesystem.getcwd(), port_obj.path_from_webkit_base(), e))
# Handle cases where we're running outside of version control.
-_log.debug('Failed to learn head_svn_revision:')
-_log.debug(e)
+import traceback
+_log.debug('Failed to learn head svn revision:')
+_log.debug(traceback.format_exc())
results['revision'] = ""
return results
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92428] trunk/Websites/webkit.org
Title: [92428] trunk/Websites/webkit.org Revision 92428 Author m...@apple.com Date 2011-08-04 16:20:31 -0700 (Thu, 04 Aug 2011) Log Message Fixed a typo. * coding/contributing.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/coding/contributing.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (92427 => 92428) --- trunk/Websites/webkit.org/ChangeLog 2011-08-04 23:17:44 UTC (rev 92427) +++ trunk/Websites/webkit.org/ChangeLog 2011-08-04 23:20:31 UTC (rev 92428) @@ -1,3 +1,9 @@ +2011-08-04 Dan Bernstein + +Fixed a typo. + +* coding/contributing.html: + 2011-08-04 Nico Weber Update the contributors page to recommend webkit-patch instead of many manual steps Modified: trunk/Websites/webkit.org/coding/contributing.html (92427 => 92428) --- trunk/Websites/webkit.org/coding/contributing.html 2011-08-04 23:17:44 UTC (rev 92427) +++ trunk/Websites/webkit.org/coding/contributing.html 2011-08-04 23:20:31 UTC (rev 92428) @@ -131,7 +131,7 @@ There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The prepare-ChangeLog script will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (, note that you can use --bug flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.) -The "No new tests. (OOPS!)" line appears if webkit-path did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), remove this line and explain why you didn't write tests. Otherwise all changes require test cases which should be mentioned in the ChangeLog. If you keep this line in your ChangeLog entry, your patch will be rejected by the commit bot. +The "No new tests. (OOPS!)" line appears if webkit-patch did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), remove this line and explain why you didn't write tests. Otherwise all changes require test cases which should be mentioned in the ChangeLog. If you keep this line in your ChangeLog entry, your patch will be rejected by the commit bot. Respond to reviewers ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92426] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [92426] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Revision 92426
Author timothy_hor...@apple.com
Date 2011-08-04 15:54:11 -0700 (Thu, 04 Aug 2011)
Log Message
Move Tim Horton to committers section of committers.py
No review necessary.
Modified Paths
trunk/Tools/Scripts/webkitpy/common/config/committers.py
Diff
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (92425 => 92426)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-04 22:53:35 UTC (rev 92425)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-08-04 22:54:11 UTC (rev 92426)
@@ -86,7 +86,6 @@
Contributor("John Bauman", ["jbau...@chromium.org", "jbau...@google.com"], "jbauman"),
Contributor("Pierre Rossi", "pierre.ro...@gmail.com", "elproxy"),
Contributor("Tab Atkins", ["tabatk...@google.com", "jackalm...@gmail.com"], "tabatkins"),
-Contributor("Tim Horton", "timothy_hor...@apple.com", "thorton"),
Contributor("Wyatt Carss", "wca...@chromium.org", "wcarss"),
]
@@ -250,6 +249,7 @@
Committer("Scott Violet", "s...@chromium.org", "sky"),
Committer("Sergio Villar Senin", ["svil...@igalia.com", "ser...@webkit.org"], "svillar"),
Committer("Steve Lacey", "s...@chromium.org", "stevela"),
+Committer("Tim Horton", "timothy_hor...@apple.com", "thorton"),
Committer("Trey Matteson", "t...@usa.net", "trey"),
Committer("Tristan O'Tierney", ["tris...@otierney.net", "tris...@apple.com"]),
Committer("Vangelis Kokkevis", "vange...@chromium.org", "vangelis"),
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92425] trunk/Source/WebCore
Title: [92425] trunk/Source/WebCore
Revision 92425
Author ba...@chromium.org
Date 2011-08-04 15:53:35 -0700 (Thu, 04 Aug 2011)
Log Message
[Chromium] Reduce memory consumption of HarfbuzzFace
https://bugs.webkit.org/show_bug.cgi?id=65688
Adds a cache for HB_FaceRec to eliminate multiple allocation for the same font.
Patch by Kenichi Ishibashi on 2011-08-04
Reviewed by Tony Chang.
No new tests since there is no behavior change.
* platform/graphics/chromium/HarfbuzzSkia.cpp:
(WebCore::getCachedHarfbuzzFace): Added.
(WebCore::releaseCachedHarfbuzzFace): Ditto.
(WebCore::HarfbuzzFace::HarfbuzzFace): Calls getCachedHarfbuzzFace() instead of allocating HB_FaceRec.
(WebCore::HarfbuzzFace::~HarfbuzzFace): Calls releaseCachedHarfbuzzFace() to release the onership of the cache.
* platform/graphics/chromium/HarfbuzzSkia.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp
trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92424 => 92425)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 22:51:04 UTC (rev 92424)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 22:53:35 UTC (rev 92425)
@@ -1,3 +1,21 @@
+2011-08-04 Kenichi Ishibashi
+
+[Chromium] Reduce memory consumption of HarfbuzzFace
+https://bugs.webkit.org/show_bug.cgi?id=65688
+
+Adds a cache for HB_FaceRec to eliminate multiple allocation for the same font.
+
+Reviewed by Tony Chang.
+
+No new tests since there is no behavior change.
+
+* platform/graphics/chromium/HarfbuzzSkia.cpp:
+(WebCore::getCachedHarfbuzzFace): Added.
+(WebCore::releaseCachedHarfbuzzFace): Ditto.
+(WebCore::HarfbuzzFace::HarfbuzzFace): Calls getCachedHarfbuzzFace() instead of allocating HB_FaceRec.
+(WebCore::HarfbuzzFace::~HarfbuzzFace): Calls releaseCachedHarfbuzzFace() to release the onership of the cache.
+* platform/graphics/chromium/HarfbuzzSkia.h:
+
2011-08-04 Sheriff Bot
Unreviewed, rolling out r92415.
Modified: trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp (92424 => 92425)
--- trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp 2011-08-04 22:51:04 UTC (rev 92424)
+++ trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.cpp 2011-08-04 22:53:35 UTC (rev 92425)
@@ -31,7 +31,8 @@
#include "config.h"
#include "FontPlatformData.h"
-#include "wtf/OwnArrayPtr.h"
+#include
+#include
#include "SkFontHost.h"
#include "SkPaint.h"
@@ -226,14 +227,47 @@
return HB_Err_Ok;
}
+typedef pair FaceCacheEntry;
+typedef HashMap, WTF::UnsignedWithZeroKeyHashTraits > HarfbuzzFaceCache;
+static HarfbuzzFaceCache* gHarfbuzzFaceCache = 0;
+
+static HB_FaceRec_* getCachedHarfbuzzFace(FontPlatformData* platformData)
+{
+if (!gHarfbuzzFaceCache)
+gHarfbuzzFaceCache = new HarfbuzzFaceCache;
+SkFontID uniqueID = platformData->uniqueID();
+HarfbuzzFaceCache::iterator result = gHarfbuzzFaceCache->find(uniqueID);
+if (result == gHarfbuzzFaceCache->end()) {
+FaceCacheEntry entry(HB_NewFace(platformData, harfbuzzSkiaGetTable), 1);
+gHarfbuzzFaceCache->set(uniqueID, entry);
+return entry.first;
+}
+++(result.get()->second.second);
+return result.get()->second.first;
+}
+
+static void releaseCachedHarfbuzzFace(FontPlatformData* platformData)
+{
+SkFontID uniqueID = platformData->uniqueID();
+HarfbuzzFaceCache::iterator result = gHarfbuzzFaceCache->find(uniqueID);
+ASSERT(result != gHarfbuzzFaceCache->end());
+ASSERT(result.get()->second.second > 0);
+--(result.get()->second.second);
+if (!(result.get()->second.second)) {
+HB_FreeFace(result.get()->second.first);
+gHarfbuzzFaceCache->remove(uniqueID);
+}
+}
+
HarfbuzzFace::HarfbuzzFace(FontPlatformData* platformData)
+: m_platformData(platformData)
{
-m_harfbuzzFace = HB_NewFace(platformData, harfbuzzSkiaGetTable);
+m_harfbuzzFace = getCachedHarfbuzzFace(m_platformData);
}
HarfbuzzFace::~HarfbuzzFace()
{
-HB_FreeFace(m_harfbuzzFace);
+releaseCachedHarfbuzzFace(m_platformData);
}
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h (92424 => 92425)
--- trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h 2011-08-04 22:51:04 UTC (rev 92424)
+++ trunk/Source/WebCore/platform/graphics/chromium/HarfbuzzSkia.h 2011-08-04 22:53:35 UTC (rev 92425)
@@ -55,6 +55,7 @@
private:
explicit HarfbuzzFace(FontPlatformData*);
+FontPlatformData* m_platformData;
HB_FaceRec_* m_harfbuzzFace;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92424] trunk/Source
Title: [92424] trunk/Source
Revision 92424
Author commit-qu...@webkit.org
Date 2011-08-04 15:51:04 -0700 (Thu, 04 Aug 2011)
Log Message
Unreviewed, rolling out r92415.
http://trac.webkit.org/changeset/92415
https://bugs.webkit.org/show_bug.cgi?id=65728
Causes many DEBUG crashes (Requested by abarth on #webkit).
Patch by Sheriff Bot on 2011-08-04
Source/WebCore:
* platform/network/chromium/ResourceRequest.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit/chromium:
* public/WebURLRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebURLRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92423 => 92424)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 22:46:30 UTC (rev 92423)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 22:51:04 UTC (rev 92424)
@@ -1,3 +1,15 @@
+2011-08-04 Sheriff Bot
+
+Unreviewed, rolling out r92415.
+http://trac.webkit.org/changeset/92415
+https://bugs.webkit.org/show_bug.cgi?id=65728
+
+Causes many DEBUG crashes (Requested by abarth on #webkit).
+
+* platform/network/chromium/ResourceRequest.h:
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::createRequest):
+
2011-08-04 Tim Horton
Reviewed by Nikolas Zimmerman.
Modified: trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h (92423 => 92424)
--- trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h 2011-08-04 22:46:30 UTC (rev 92423)
+++ trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h 2011-08-04 22:51:04 UTC (rev 92424)
@@ -55,7 +55,6 @@
TargetIsPrefetch,
TargetIsPrerender,
TargetIsFavicon,
-TargetIsXHR,
};
class ExtraData : public RefCounted {
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (92423 => 92424)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2011-08-04 22:46:30 UTC (rev 92423)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2011-08-04 22:51:04 UTC (rev 92424)
@@ -636,9 +636,6 @@
ResourceRequest request(m_url);
request.setHTTPMethod(m_method);
-#if PLATFORM(CHROMIUM)
-request.setTargetType(ResourceRequest::TargetIsXHR);
-#endif
if (m_requestEntityBody) {
ASSERT(m_method != "GET");
Modified: trunk/Source/WebKit/chromium/ChangeLog (92423 => 92424)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-04 22:46:30 UTC (rev 92423)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-04 22:51:04 UTC (rev 92424)
@@ -1,3 +1,13 @@
+2011-08-04 Sheriff Bot
+
+Unreviewed, rolling out r92415.
+http://trac.webkit.org/changeset/92415
+https://bugs.webkit.org/show_bug.cgi?id=65728
+
+Causes many DEBUG crashes (Requested by abarth on #webkit).
+
+* public/WebURLRequest.h:
+
2011-08-04 Jochen Eisinger
Introduce a new ResourceRequest::TargetType for XHRs
Modified: trunk/Source/WebKit/chromium/public/WebURLRequest.h (92423 => 92424)
--- trunk/Source/WebKit/chromium/public/WebURLRequest.h 2011-08-04 22:46:30 UTC (rev 92423)
+++ trunk/Source/WebKit/chromium/public/WebURLRequest.h 2011-08-04 22:51:04 UTC (rev 92424)
@@ -36,8 +36,6 @@
#if defined(WEBKIT_IMPLEMENTATION)
namespace WebCore { class ResourceRequest; }
-#else
-#define WEBKIT_HAS_TARGET_IS_XHR
#endif
namespace WebKit {
@@ -73,7 +71,6 @@
TargetIsPrefetch = 11,
TargetIsPrerender = 12,
TargetIsFavicon = 13,
-TargetIsXHR = 14,
};
class ExtraData {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92421] trunk/Websites/webkit.org
Title: [92421] trunk/Websites/webkit.org Revision 92421 Author tha...@chromium.org Date 2011-08-04 15:41:52 -0700 (Thu, 04 Aug 2011) Log Message Update the contributors page to recommend webkit-patch instead of many manual steps https://bugs.webkit.org/show_bug.cgi?id=65714 Reviewed by Adam Barth. asvitkine followed the contributing instructions for his first patch, and got the ChangeLog entry wrong: https://bugs.webkit.org/show_bug.cgi?id=65707 webkit-patch prevents errors like this and more. * coding/contributing.html: Modified Paths trunk/Websites/webkit.org/ChangeLog trunk/Websites/webkit.org/coding/contributing.html Diff Modified: trunk/Websites/webkit.org/ChangeLog (92420 => 92421) --- trunk/Websites/webkit.org/ChangeLog 2011-08-04 22:39:48 UTC (rev 92420) +++ trunk/Websites/webkit.org/ChangeLog 2011-08-04 22:41:52 UTC (rev 92421) @@ -1,3 +1,16 @@ +2011-08-04 Nico Weber + +Update the contributors page to recommend webkit-patch instead of many manual steps +https://bugs.webkit.org/show_bug.cgi?id=65714 + +Reviewed by Adam Barth. + +asvitkine followed the contributing instructions for his first patch, and got +the ChangeLog entry wrong: https://bugs.webkit.org/show_bug.cgi?id=65707 +webkit-patch prevents errors like this and more. + +* coding/contributing.html: + 2011-07-21 Jon Lee Create a new survey page that showcases form and interactive elements for quick reference and comparison. Modified: trunk/Websites/webkit.org/coding/contributing.html (92420 => 92421) --- trunk/Websites/webkit.org/coding/contributing.html 2011-08-04 22:39:48 UTC (rev 92420) +++ trunk/Websites/webkit.org/coding/contributing.html 2011-08-04 22:41:52 UTC (rev 92421) @@ -72,8 +72,8 @@ work. Below are sample copyright lines for an individual contributor and a company: -Copyright (C) 2010 John Smith (jsm...@example.com) -Copyright (C) 2010 Company Inc. All rights reserved. +Copyright (C) 2011 John Smith (jsm...@example.com) +Copyright (C) 2011 Company Inc. All rights reserved. In addition, make sure that any new source code and script files you introduce contain license text at the beginning of the file. @@ -91,6 +91,9 @@ to comply with the current guidelines. An exception is legacy components, which should not be cleaned up. +Your patch will be automatically checked for style compliance when you +upload it to the bug tracker. + Regression tests Once you have made your changes, you need to run the regression tests, which is done via the run-webkit-tests script. All tests must pass. Patches will not be landed in the tree if they break existing layout tests. @@ -115,54 +118,22 @@ Version Control with Subversion and by using the svn help command. -ChangeLog files -ChangeLogs are simple text files which provide historical documentation for all changes to the WebKit project. All patches require an entry to the ChangeLog. The prepare-ChangeLog script will create a basic entry containing a list of all files that have been changed. The first line contains the date, your full name, and your email address. Use this to write up a brief summary of the changes you've made. Don't worry about the "Reviewed by NOBODY (OOPS!)" line, the person landing your patch will fill this in. - -There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The prepare-ChangeLog script will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (, note that you can use --bug flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.) - -The "No new tests. (OOPS!)" line appears if prepare-ChangeLog did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), you should include a line stating such. Otherwise all changes require test cases which should be mentioned in the ChangeLog. - Create the patch -WebKit uses svn-create-patch to create patches. The -svn-create-patch script is a small wrapper around Subversion's -diff command that better handles moved, added, and deleted files. -This command is best run from the top level of your checkout -to make sure no changes are left out of your patch. It is not necessary to -break a patch into multiple files. -The svn-create-patch script does not create a file automatically. -You need to redirect the output yourself using something like: -svn-create-patch > MyExcellentPatch.txt +The easiest way to create a patch is to run +Tools/Scripts/webkit-patch upload. This will upload your current +Subversion diff (or Git diff if you +) to the +issue tracking system and mark it as ready for review. -Submit your patch -Submit your patch by clicking the "Add an attachment" link in the - you chose for your contribution. +ChangeLog files +ChangeLogs are simple t
[webkit-changes] [92420] trunk/Tools
Title: [92420] trunk/Tools
Revision 92420
Author le...@chromium.org
Date 2011-08-04 15:39:48 -0700 (Thu, 04 Aug 2011)
Log Message
[chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
https://bugs.webkit.org/show_bug.cgi?id=65685
Reviewed by Dmitry Titov.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::WebViewHost): Intialize WTF threading before
anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
but in some cases code may use WTF without creating WebViewImpl and
WTF code functionality may call WTF::currentThread, which requires
this initialization now.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
Diff
Modified: trunk/Tools/ChangeLog (92419 => 92420)
--- trunk/Tools/ChangeLog 2011-08-04 22:15:45 UTC (rev 92419)
+++ trunk/Tools/ChangeLog 2011-08-04 22:39:48 UTC (rev 92420)
@@ -1,3 +1,17 @@
+2011-08-04 David Levin
+
+[chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
+https://bugs.webkit.org/show_bug.cgi?id=65685
+
+Reviewed by Dmitry Titov.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::WebViewHost): Intialize WTF threading before
+anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
+but in some cases code may use WTF without creating WebViewImpl and
+WTF code functionality may call WTF::currentThread, which requires
+this initialization now.
+
2011-08-04 Adam Barth
An educated guess at causing the Windows bots on build.webkit.org to
Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (92419 => 92420)
--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2011-08-04 22:15:45 UTC (rev 92419)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2011-08-04 22:39:48 UTC (rev 92420)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010 Google Inc. All rights reserved.
+ * Copyright (C) 2010, 2011 Google Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
@@ -62,8 +62,10 @@
#include "WebWindowFeatures.h"
#include "skia/ext/platform_canvas.h"
#include "webkit/support/webkit_support.h"
+
#include
#include
+#include
#include
using namespace WebCore;
@@ -1158,6 +1160,7 @@
, m_webWidget(0)
, m_lastRequestedTextCheckingCompletion(0)
{
+WTF::initializeThreading();
reset();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92418] trunk/Tools
Title: [92418] trunk/Tools
Revision 92418
Author aba...@webkit.org
Date 2011-08-04 15:03:59 -0700 (Thu, 04 Aug 2011)
Log Message
An educated guess at causing the Windows bots on build.webkit.org to
find the SVN revision number.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/port/base.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
Diff
Modified: trunk/Tools/ChangeLog (92417 => 92418)
--- trunk/Tools/ChangeLog 2011-08-04 22:00:19 UTC (rev 92417)
+++ trunk/Tools/ChangeLog 2011-08-04 22:03:59 UTC (rev 92418)
@@ -1,5 +1,13 @@
2011-08-04 Adam Barth
+An educated guess at causing the Windows bots on build.webkit.org to
+find the SVN revision number.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+* Scripts/webkitpy/layout_tests/port/base.py:
+
+2011-08-04 Adam Barth
+
More logging to help debug the "no SVN rev on Chromium Windows bots"
bug. My current theory is that we're trying to detect the SCM system
in the wrong directory.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (92417 => 92418)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-08-04 22:00:19 UTC (rev 92417)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-08-04 22:03:59 UTC (rev 92418)
@@ -46,8 +46,7 @@
import sys
import time
-from webkitpy.common.checkout import scm
-
+from webkitpy.common.checkout.scm import default_scm
from webkitpy.layout_tests.controllers import manager_worker_broker
from webkitpy.layout_tests.controllers import worker
from webkitpy.layout_tests.layout_package import json_layout_results_generator
@@ -209,7 +208,7 @@
results['has_wdiff'] = port_obj.wdiff_available()
results['has_pretty_patch'] = port_obj.pretty_patch_available()
try:
-results['revision'] = port_obj.webkit_source_scm().head_svn_revision()
+results['revision'] = default_scm().head_svn_revision()
except Exception, e:
# FIXME: We would like to warn here, but that would cause all passing_run integration tests
# to fail, since they assert that we have no logging output.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (92417 => 92418)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-08-04 22:00:19 UTC (rev 92417)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-08-04 22:03:59 UTC (rev 92418)
@@ -621,22 +621,6 @@
WebKit source tree and the list of path components in |*comps|."""
return self._config.path_from_webkit_base(*comps)
-@memoized
-def webkit_source_scm(self):
-# On the chromium bots, the cwd is the root of the chromium checkout.
-# self._config.webkit_base_dir() knows where the webkit root is, no other
-# object in NRWT seems to keep an SCM around. (Unlike webkit-patch
-# where it's on the Tool/Host object.)
-# FIXME: We should be able to get the SCM from somewhere else.
-# FIXME: Due to Chromium's insane DEPS system, the root of the WebKit
-# checkout isn't actually from svn.webkit.org. Instead, we detect the
-# scm from the Source directory, which really does map to svn.webkit.org.
-path = self.path_from_webkit_base('Source')
-_log.debug('---webkit_source_scm---')
-_log.debug(path)
-_log.debug(os.getcwd())
-return detect_scm_system(path)
-
def path_to_test_expectations_file(self):
"""Update the test expectations to the passed-in string.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92417] trunk
Title: [92417] trunk
Revision 92417
Author fsam...@chromium.org
Date 2011-08-04 15:00:19 -0700 (Thu, 04 Aug 2011)
Log Message
Source/WebCore: Background Does Not Scale Correctly with Page
https://bugs.webkit.org/show_bug.cgi?id=65690
Reviewed by Simon Fraser.
Test: fast/repaint/background-scaling.html
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
* rendering/RenderView.cpp:
(WebCore::RenderView::unscaledDocumentRect):
(WebCore::RenderView::documentRect):
* rendering/RenderView.h:
LayoutTests: Background Does Not Scale Correctly with Page
Scaling is applied twice to the background (the paint area is doubly scaled).
This patch fixes this issue by passing the unscaled document rect to paintFillLayers
in paintRootBoxFillLayers.
https://bugs.webkit.org/show_bug.cgi?id=65690
Reviewed by Simon Fraser.
* fast/repaint/background-scaling-expected.png: Added.
* fast/repaint/background-scaling-expected.txt: Added.
* fast/repaint/background-scaling.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Added Paths
trunk/LayoutTests/fast/repaint/background-scaling-expected.png
trunk/LayoutTests/fast/repaint/background-scaling-expected.txt
trunk/LayoutTests/fast/repaint/background-scaling.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92416 => 92417)
--- trunk/LayoutTests/ChangeLog 2011-08-04 21:50:51 UTC (rev 92416)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 22:00:19 UTC (rev 92417)
@@ -1,3 +1,19 @@
+2011-08-04 Fady Samuel
+
+Background Does Not Scale Correctly with Page
+
+Scaling is applied twice to the background (the paint area is doubly scaled).
+This patch fixes this issue by passing the unscaled document rect to paintFillLayers
+in paintRootBoxFillLayers.
+
+https://bugs.webkit.org/show_bug.cgi?id=65690
+
+Reviewed by Simon Fraser.
+
+* fast/repaint/background-scaling-expected.png: Added.
+* fast/repaint/background-scaling-expected.txt: Added.
+* fast/repaint/background-scaling.html: Added.
+
2011-08-04 Yael Aharon
[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375
Added: trunk/LayoutTests/fast/repaint/background-scaling-expected.png (0 => 92417)
--- trunk/LayoutTests/fast/repaint/background-scaling-expected.png (rev 0)
+++ trunk/LayoutTests/fast/repaint/background-scaling-expected.png 2011-08-04 22:00:19 UTC (rev 92417)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 9250f617b5236f7db936c57cc622c30a\x8A\x90\x85
+\xB6IDATx\x9C\xED\xD8\xD1 \x800Ac\xE3\xDA\xF9\xB3\x89\x85@\x9C\xA9\xE0>\x97[\xD7{q\xB0yf\xF7 \xF8\x9D{\xF7 \x80\xD3, \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88\xAD\x99Ù½ \xE0( , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x9
[webkit-changes] [92416] trunk/LayoutTests
Title: [92416] trunk/LayoutTests Revision 92416 Author yael.aha...@nokia.com Date 2011-08-04 14:50:51 -0700 (Thu, 04 Aug 2011) Log Message [Qt] 69 tests failing after http://trac.webkit.org/changeset/92375 https://bugs.webkit.org/show_bug.cgi?id=65721 Unreviewed. Skipping tests until rebaseline. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92415 => 92416) --- trunk/LayoutTests/ChangeLog 2011-08-04 21:50:03 UTC (rev 92415) +++ trunk/LayoutTests/ChangeLog 2011-08-04 21:50:51 UTC (rev 92416) @@ -1,3 +1,14 @@ +2011-08-04 Yael Aharon + +[Qt] 69 tests failing after http://trac.webkit.org/changeset/92375 +https://bugs.webkit.org/show_bug.cgi?id=65721 + +Unreviewed. + +Skipping tests until rebaseline. + +* platform/qt/Skipped: + 2011-08-04 Sergey Glazunov Fix integer overflow in custom bindings for WebGLRenderingContext Modified: trunk/LayoutTests/platform/qt/Skipped (92415 => 92416) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-04 21:50:03 UTC (rev 92415) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-04 21:50:51 UTC (rev 92416) @@ -2250,3 +2250,76 @@ # This test tickles another crasher on Qt. fast/loader/reload-zero-byte-plugin.html + +# Failing after http://trac.webkit.org/changeset/92375 +# https://bugs.webkit.org/show_bug.cgi?id=65721 +http/tests/navigation/_javascript_link-frames.html +tables/mozilla/bugs/bug28928.html +fast/forms/button-sizes.html +fast/forms/control-restrict-line-height.html +fast/forms/select-baseline.html +tables/mozilla/bugs/bug2479-3.html +tables/mozilla/bugs/bug1318.html +fast/replaced/table-percent-height.html +tables/mozilla/bugs/bug26178.html +svg/custom/inline-svg-in-xhtml.xml +fast/forms/button-text-transform.html +fast/forms/button-style-color.html +tables/mozilla/bugs/bug46368-2.html +editing/selection/4397952.html +editing/selection/3690719.html +fast/replaced/replaced-breaking.html +fast/block/positioning/inline-block-relposition.html +fast/forms/formmove3.html +fast/html/details-replace-text.html +fast/forms/basic-buttons.html +fast/forms/input-button-sizes.html +fast/forms/button-cannot-be-nested.html +tables/mozilla/bugs/bug51037.html +fast/forms/control-clip-overflow.html +tables/mozilla/bugs/bug39209.html +fast/css/margin-top-bottom-dynamic.html +tables/mozilla_expected_failures/bugs/bug58402-2.html +fast/forms/button-table-styles.html +tables/mozilla/bugs/bug1188.html +tables/mozilla_expected_failures/bugs/bug1725.html +tables/mozilla/collapsing_borders/bug41262-4.html +fast/html/details-replace-summary-child.html +svg/custom/foreign-object-skew.svg +tables/mozilla/bugs/bug68912.html +fast/text/textIteratorNilRenderer.html +tables/mozilla/bugs/bug138725.html +fast/forms/targeted-frame-submission.html +editing/selection/3690703-2.html +fast/block/float/float-avoidance.html +fast/forms/button-generated-content.html +tables/mozilla/bugs/bug44505.html +tables/mozilla/bugs/bug92647-2.html +tables/mozilla/bugs/bug60749.html +fast/dom/HTMLTableColElement/resize-table-using-col-width.html +tables/mozilla/other/move_row.html +fast/replaced/width100percent-button.html +fast/table/remove-td-display-none.html +tables/mozilla/bugs/bug33855.html +tables/mozilla/bugs/bug7342.html +fast/dynamic/positioned-movement-with-positioned-children.html +fast/selectors/064.html +fast/forms/button-inner-block-reuse.html +tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html +fast/forms/blankbuttons.html +tables/mozilla/dom/tableDom.html +fast/forms/button-positioned.html +editing/selection/3690703.html +fast/forms/button-align.html +tables/mozilla/bugs/bug51727.html +tables/mozilla/bugs/bug52506.html +fast/table/append-cells2.html +platform/qt/fast/forms/button-line-break.html +editing/selection/5240265.html +fast/css/continuationCrash.html +tables/mozilla/bugs/bug18359.html +tables/mozilla/bugs/bug46368-1.html +tables/mozilla/bugs/bug4429.html +tables/mozilla/bugs/bug52505.html +tables/mozilla_expected_failures/collapsing_borders/bug41262-6.html + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92415] trunk/Source
Title: [92415] trunk/Source
Revision 92415
Author joc...@chromium.org
Date 2011-08-04 14:50:03 -0700 (Thu, 04 Aug 2011)
Log Message
Introduce a new ResourceRequest::TargetType for XHRs
https://bugs.webkit.org/show_bug.cgi?id=65544
Reviewed by Darin Fisher.
Source/WebCore:
* platform/network/chromium/ResourceRequest.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit/chromium:
* public/WebURLRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebURLRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92414 => 92415)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 21:40:42 UTC (rev 92414)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 21:50:03 UTC (rev 92415)
@@ -1,3 +1,14 @@
+2011-08-04 Jochen Eisinger
+
+Introduce a new ResourceRequest::TargetType for XHRs
+https://bugs.webkit.org/show_bug.cgi?id=65544
+
+Reviewed by Darin Fisher.
+
+* platform/network/chromium/ResourceRequest.h:
+* xml/XMLHttpRequest.cpp:
+(WebCore::XMLHttpRequest::createRequest):
+
2011-08-04 Sergey Glazunov
Fix integer overflow in custom bindings for WebGLRenderingContext
Modified: trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h (92414 => 92415)
--- trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h 2011-08-04 21:40:42 UTC (rev 92414)
+++ trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h 2011-08-04 21:50:03 UTC (rev 92415)
@@ -55,6 +55,7 @@
TargetIsPrefetch,
TargetIsPrerender,
TargetIsFavicon,
+TargetIsXHR,
};
class ExtraData : public RefCounted {
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (92414 => 92415)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2011-08-04 21:40:42 UTC (rev 92414)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2011-08-04 21:50:03 UTC (rev 92415)
@@ -636,6 +636,9 @@
ResourceRequest request(m_url);
request.setHTTPMethod(m_method);
+#if PLATFORM(CHROMIUM)
+request.setTargetType(ResourceRequest::TargetIsXHR);
+#endif
if (m_requestEntityBody) {
ASSERT(m_method != "GET");
Modified: trunk/Source/WebKit/chromium/ChangeLog (92414 => 92415)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-04 21:40:42 UTC (rev 92414)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-04 21:50:03 UTC (rev 92415)
@@ -1,5 +1,14 @@
2011-08-04 Jochen Eisinger
+Introduce a new ResourceRequest::TargetType for XHRs
+https://bugs.webkit.org/show_bug.cgi?id=65544
+
+Reviewed by Darin Fisher.
+
+* public/WebURLRequest.h:
+
+2011-08-04 Jochen Eisinger
+
Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=48483
Modified: trunk/Source/WebKit/chromium/public/WebURLRequest.h (92414 => 92415)
--- trunk/Source/WebKit/chromium/public/WebURLRequest.h 2011-08-04 21:40:42 UTC (rev 92414)
+++ trunk/Source/WebKit/chromium/public/WebURLRequest.h 2011-08-04 21:50:03 UTC (rev 92415)
@@ -36,6 +36,8 @@
#if defined(WEBKIT_IMPLEMENTATION)
namespace WebCore { class ResourceRequest; }
+#else
+#define WEBKIT_HAS_TARGET_IS_XHR
#endif
namespace WebKit {
@@ -71,6 +73,7 @@
TargetIsPrefetch = 11,
TargetIsPrerender = 12,
TargetIsFavicon = 13,
+TargetIsXHR = 14,
};
class ExtraData {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92414] trunk/Source/WebKit/win
Title: [92414] trunk/Source/WebKit/win
Revision 92414
Author je...@apple.com
Date 2011-08-04 14:40:42 -0700 (Thu, 04 Aug 2011)
Log Message
Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718
Reviewed by Adam Roben.
* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.
* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
* WebView.cpp:
(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl
trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/win/WebPreferences.cpp
trunk/Source/WebKit/win/WebPreferences.h
trunk/Source/WebKit/win/WebView.cpp
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (92413 => 92414)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-04 21:40:42 UTC (rev 92414)
@@ -1,3 +1,23 @@
+2011-08-04 Jeff Miller
+
+Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
+https://bugs.webkit.org/show_bug.cgi?id=65718
+
+Reviewed by Adam Roben.
+
+* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
+
+* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
+
+* WebPreferences.cpp:
+(WebPreferences::avFoundationEnabled): Added.
+(WebPreferences::setAVFoundationEnabled): Added.
+
+* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
+
+* WebView.cpp:
+(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
+
2011-08-03 Kent Tamura
[Windows] Fix build without ENABLE_VIDEO.
Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl (92413 => 92414)
--- trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl 2011-08-04 21:40:42 UTC (rev 92414)
@@ -202,4 +202,7 @@
HRESULT pictographFontFamily([out, retval] BSTR* family);
HRESULT setPictographFontFamily([in] BSTR family);
+
+HRESULT setAVFoundationEnabled(BOOL avFoundationEnabled);
+HRESULT avFoundationEnabled(BOOL *avFoundationEnabled);
}
Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (92413 => 92414)
--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h 2011-08-04 21:40:42 UTC (rev 92414)
@@ -160,3 +160,4 @@
#define WebKitMediaPlaybackAllowsInlinePreferenceKey "WebKitMediaPlaybackAllowsInline"
+#define WebKitAVFoundationEnabledPreferenceKey "WebKitAVFoundationEnabled"
Modified: trunk/Source/WebKit/win/WebPreferences.cpp (92413 => 92414)
--- trunk/Source/WebKit/win/WebPreferences.cpp 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferences.cpp 2011-08-04 21:40:42 UTC (rev 92414)
@@ -1612,6 +1612,29 @@
#endif
}
+HRESULT WebPreferences::avFoundationEnabled(BOOL* enabled)
+{
+#if USE(AVFOUNDATION)
+if (!enabled)
+return E_POINTER;
+
+*enabled = boolValueForKey(CFSTR(WebKitAVFoundationEnabledPreferenceKey));
+return S_OK;
+#else
+return E_NOTIMPL;
+#endif
+}
+
+HRESULT WebPreferences::setAVFoundationEnabled(BOOL enabled)
+{
+#if USE(AVFOUNDATION)
+setBoolValue(CFSTR(WebKitAVFoundationEnabledPreferenceKey), enabled);
+return S_OK;
+#else
+return E_NOTIMPL;
+#endif
+}
+
void WebPreferences::willAddToWebView()
{
++m_numWebViews;
Modified: trunk/Source/WebKit/win/WebPreferences.h (92413 => 92414)
--- trunk/Source/WebKit/win/WebPreferences.h 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebPreferences.h 2011-08-04 21:40:42 UTC (rev 92414)
@@ -292,6 +292,12 @@
virtual HRESULT STDMETHODCALLTYPE shouldPaintCustomScrollbars(
/* [retval][out] */ BOOL *shouldPaint);
+virtual HRESULT STDMETHODCALLTYPE setAVFoundationEnabled(
+/* [in] */ BOOL);
+
+virtual HRESULT STDMETHODCALLTYPE avFoundationEnabled(
+/* [retval][out] */ BOOL*);
+
// IWebPreferencesPrivate
virtual HRESULT STDMETHODCALLTYPE setDeveloperExtrasEnabled(
/* [in] */ BOOL);
Modified: trunk/Source/WebKit/win/WebView.cpp (92413 => 92414)
--- trunk/Source/WebKit/win/WebView.cpp 2011-08-04 21:37:03 UTC (rev 92413)
+++ trunk/Source/WebKit/win/WebView.cpp 2011-08-04 21:40:42 UTC (rev 92414)
@@ -4727,6 +4727,13 @@
return hr;
settings->setFontRenderingMode(smoothingType != FontSmoothingTypeWindows ? No
[webkit-changes] [92413] trunk
Title: [92413] trunk
Revision 92413
Author commit-qu...@webkit.org
Date 2011-08-04 14:37:03 -0700 (Thu, 04 Aug 2011)
Log Message
Fix integer overflow in custom bindings for WebGLRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=65646
Patch by Sergey Glazunov on 2011-08-04
Reviewed by Kenneth Russell.
Source/WebCore:
Test: fast/canvas/webgl/uniform-array-length-overflow.html
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toVector): Don't crash if allocation fails.
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::jsArrayToFloatArray):
(WebCore::jsArrayToIntArray):
LayoutTests:
* fast/canvas/webgl/resources/floatArrayUniformShader.vert: Added.
* fast/canvas/webgl/resources/intArrayUniformShader2.vert: Added.
* fast/canvas/webgl/uniform-array-length-overflow-expected.txt: Added.
* fast/canvas/webgl/uniform-array-length-overflow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
Added Paths
trunk/LayoutTests/fast/canvas/webgl/resources/floatArrayUniformShader.vert
trunk/LayoutTests/fast/canvas/webgl/resources/intArrayUniformShader2.vert
trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow-expected.txt
trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92412 => 92413)
--- trunk/LayoutTests/ChangeLog 2011-08-04 21:29:08 UTC (rev 92412)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 21:37:03 UTC (rev 92413)
@@ -1,3 +1,15 @@
+2011-08-04 Sergey Glazunov
+
+Fix integer overflow in custom bindings for WebGLRenderingContext
+https://bugs.webkit.org/show_bug.cgi?id=65646
+
+Reviewed by Kenneth Russell.
+
+* fast/canvas/webgl/resources/floatArrayUniformShader.vert: Added.
+* fast/canvas/webgl/resources/intArrayUniformShader2.vert: Added.
+* fast/canvas/webgl/uniform-array-length-overflow-expected.txt: Added.
+* fast/canvas/webgl/uniform-array-length-overflow.html: Added.
+
2011-08-04 Adam Barth
Refine some test expectations to account for flakiness.
Added: trunk/LayoutTests/fast/canvas/webgl/resources/floatArrayUniformShader.vert (0 => 92413)
--- trunk/LayoutTests/fast/canvas/webgl/resources/floatArrayUniformShader.vert (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/resources/floatArrayUniformShader.vert 2011-08-04 21:37:03 UTC (rev 92413)
@@ -0,0 +1,7 @@
+uniform float u_floats[4];
+
+void main()
+{
+ float sum = u_floats[0] + u_floats[1] + u_floats[2] + u_floats[3];
+ gl_Position = vec4(sum, 0.0, 0.0, 1.0);
+}
\ No newline at end of file
Added: trunk/LayoutTests/fast/canvas/webgl/resources/intArrayUniformShader2.vert (0 => 92413)
--- trunk/LayoutTests/fast/canvas/webgl/resources/intArrayUniformShader2.vert (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/resources/intArrayUniformShader2.vert 2011-08-04 21:37:03 UTC (rev 92413)
@@ -0,0 +1,7 @@
+uniform int u_ints[4];
+
+void main()
+{
+ int sum = u_ints[0] + u_ints[1] + u_ints[2] + u_ints[3];
+ gl_Position = vec4(sum, 0.0, 0.0, 1.0);
+}
\ No newline at end of file
Added: trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow-expected.txt (0 => 92413)
--- trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow-expected.txt 2011-08-04 21:37:03 UTC (rev 92413)
@@ -0,0 +1,8 @@
+Verifies that the array conversion code for WebGLRenderingContext.uniform* does not crash.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow.html (0 => 92413)
--- trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/uniform-array-length-overflow.html 2011-08-04 21:37:03 UTC (rev 92413)
@@ -0,0 +1,40 @@
+
+
+
+
+
+
+
+
+description("Verifies that the array conversion code for WebGLRenderingContext.uniform* does not crash.");
+
+array = [ ];
+for (var i = 0; i < 1 << 15; ++i)
+array[i] = 0x0c0c0c0c;
+array.length = 0x8000;
+
+context = create3DContext();
+intProgram = loadProgram(context, "resources/intArrayUniformShader2.vert", "resources/noopUniformShader.frag");
+floatProgram = loadProgram(context, "resources/floatArrayUniformShader.vert", "resources/noopUniformShader.frag");
+intLocation = context.getUniformLocation(intProgram, "u_ints");
+floatLocation = context.getUniformLocation(floatProgram, "u_floats");
+
+context.useProgram(intProgram);
+try {
+context.uniform4iv(intLocation, array);
+} catch (e) { }
+
+context.useProgram(floatProgram);
+try {
+context.uni
[webkit-changes] [92412] tags/Safari-534.49.1/Source
Title: [92412] tags/Safari-534.49.1/Source
Revision 92412
Author lforsch...@apple.com
Date 2011-08-04 14:29:08 -0700 (Thu, 04 Aug 2011)
Log Message
Merge r90705.
Modified Paths
tags/Safari-534.49.1/Source/WebCore/ChangeLog
tags/Safari-534.49.1/Source/WebCore/platform/mac/CursorMac.mm
tags/Safari-534.49.1/Source/WebKit2/ChangeLog
tags/Safari-534.49.1/Source/WebKit2/Shared/WebCoreArgumentCoders.h
Diff
Modified: tags/Safari-534.49.1/Source/WebCore/ChangeLog (92411 => 92412)
--- tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 21:13:11 UTC (rev 92411)
+++ tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 21:29:08 UTC (rev 92412)
@@ -1,5 +1,27 @@
2011-08-04 Lucas Forschler
+Merged 90705.
+
+2011-07-10 Anders Carlsson
+
+WebKit2 is leaking NSCursors created by leakNamedCursor
+https://bugs.webkit.org/show_bug.cgi?id=64241
+
+
+Reviewed by Oliver Hunt.
+
+* platform/mac/CursorMac.mm:
+(WebCore::createNamedCursor):
+Rename this from leakNamedCursor to createNamedCursor and make it return a
+RetainPtr instead of a raw pointer.
+
+(WebCore::Cursor::ensurePlatformCursor):
+Don't leak cursors here. We still won't deallocate cursors during shutdown (which leakNamedCursor
+was said to prevent) because the cursor singletons are all allocated from the heap and are never destroyed
+anyway.
+
+2011-08-04 Lucas Forschler
+
Merged 89214.
2011-06-19 Michael Saboff
Modified: tags/Safari-534.49.1/Source/WebCore/platform/mac/CursorMac.mm (92411 => 92412)
--- tags/Safari-534.49.1/Source/WebCore/platform/mac/CursorMac.mm 2011-08-04 21:13:11 UTC (rev 92411)
+++ tags/Safari-534.49.1/Source/WebCore/platform/mac/CursorMac.mm 2011-08-04 21:29:08 UTC (rev 92412)
@@ -52,21 +52,17 @@
return 0;
}
-// Leak these cursors intentionally, that way we won't waste time trying to clean them
-// up at process exit time.
-static NSCursor* leakNamedCursor(const char* name, int x, int y)
+static RetainPtr createNamedCursor(const char* name, int x, int y)
{
BEGIN_BLOCK_OBJC_EXCEPTIONS;
-NSString* resourceName = [[NSString alloc] initWithUTF8String:name];
-NSImage* cursorImage = [[NSImage alloc] initWithContentsOfFile:
-[[NSBundle bundleForClass:[WebCoreCursorBundle class]]
-pathForResource:resourceName ofType:@"png"]];
-[resourceName release];
-NSCursor* cursor = 0;
+RetainPtr resourceName(AdoptNS, [[NSString alloc] initWithUTF8String:name]);
+RetainPtr cursorImage(AdoptNS, [[NSImage alloc] initWithContentsOfFile:[[NSBundle bundleForClass:[WebCoreCursorBundle class]] pathForResource:resourceName.get() ofType:@"png"]]);
+
+RetainPtr cursor;
+
if (cursorImage) {
NSPoint hotSpotPoint = {x, y}; // workaround for 4213314
-cursor = [[NSCursor alloc] initWithImage:cursorImage hotSpot:hotSpotPoint];
-[cursorImage release];
+cursor.adoptNS([[NSCursor alloc] initWithImage:cursorImage.get() hotSpot:hotSpotPoint]);
}
return cursor;
END_BLOCK_OBJC_EXCEPTIONS;
@@ -83,67 +79,67 @@
m_platformCursor = [NSCursor arrowCursor];
break;
case Cursor::Cross:
-m_platformCursor = leakNamedCursor("crossHairCursor", 11, 11);
+m_platformCursor = createNamedCursor("crossHairCursor", 11, 11);
break;
case Cursor::Hand:
-m_platformCursor = leakNamedCursor("linkCursor", 6, 1);
+m_platformCursor = createNamedCursor("linkCursor", 6, 1);
break;
case Cursor::IBeam:
m_platformCursor = [NSCursor IBeamCursor];
break;
case Cursor::Wait:
-m_platformCursor = leakNamedCursor("waitCursor", 7, 7);
+m_platformCursor = createNamedCursor("waitCursor", 7, 7);
break;
case Cursor::Help:
-m_platformCursor = leakNamedCursor("helpCursor", 8, 8);
+m_platformCursor = createNamedCursor("helpCursor", 8, 8);
break;
case Cursor::Move:
case Cursor::MiddlePanning:
-m_platformCursor = leakNamedCursor("moveCursor", 7, 7);
+m_platformCursor = createNamedCursor("moveCursor", 7, 7);
break;
case Cursor::EastResize:
case Cursor::EastPanning:
-m_platformCursor = leakNamedCursor("eastResizeCursor", 14, 7);
+m_platformCursor = createNamedCursor("eastResizeCursor", 14, 7);
break;
case Cursor::NorthResize:
case Cursor::NorthPanning:
-m_platformCursor = leakNamedCursor("northResizeCursor", 7, 1);
+m_platformCursor = createNamedCursor("northResizeCursor", 7, 1);
break;
case Cursor::NorthEastResize:
case Cursor::NorthEastPanning:
-m_platformCursor = leakNamedCursor("northEastResizeCursor", 14, 1);
+m_platformCursor = createNamedCursor("northEastResizeCursor", 14, 1);
break;
case Cursor::NorthWestResize:
case Cursor::NorthWestPanning:
-m_plat
[webkit-changes] [92411] tags/Safari-534.49.1/Source/WebCore
Title: [92411] tags/Safari-534.49.1/Source/WebCore
Revision 92411
Author lforsch...@apple.com
Date 2011-08-04 14:13:11 -0700 (Thu, 04 Aug 2011)
Log Message
Merge r89214.
Modified Paths
tags/Safari-534.49.1/Source/WebCore/ChangeLog
tags/Safari-534.49.1/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
Diff
Modified: tags/Safari-534.49.1/Source/WebCore/ChangeLog (92410 => 92411)
--- tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 21:12:38 UTC (rev 92410)
+++ tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 21:13:11 UTC (rev 92411)
@@ -1,5 +1,24 @@
2011-08-04 Lucas Forschler
+Merged 89214.
+
+2011-06-19 Michael Saboff
+
+Reviewed by Darin Adler.
+
+Add notify handler to trigger MemoryPressureHandler in all builds
+https://bugs.webkit.org/show_bug.cgi?id=62679
+
+Removed SIGUSR2 trigger and added a notify trigger for the
+MemoryPressureHandler. The notify trigger is enabled for all builds.
+
+No test added as only added new memory pressure trigger.
+
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::install):
+
+2011-08-04 Lucas Forschler
+
Merged 92231.
2011-08-01 Michael Saboff
Modified: tags/Safari-534.49.1/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (92410 => 92411)
--- tags/Safari-534.49.1/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-08-04 21:12:38 UTC (rev 92410)
+++ tags/Safari-534.49.1/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-08-04 21:13:11 UTC (rev 92411)
@@ -34,6 +34,7 @@
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
#import
+#import
#ifndef DISPATCH_SOURCE_TYPE_VM
#define DISPATCH_SOURCE_TYPE_VM (&_dispatch_source_type_vm)
@@ -53,12 +54,11 @@
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
static dispatch_source_t _cache_event_source = 0;
-#ifndef NDEBUG
-static dispatch_source_t _cache_event_source2 = 0;
-#endif
void MemoryPressureHandler::install()
{
+static int notifyToken;
+
if (m_installed)
return;
@@ -71,17 +71,8 @@
}
});
-#ifndef NDEBUG
-dispatch_async(dispatch_get_main_queue(), ^{
-_cache_event_source2 = dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGUSR2, 0, dispatch_get_main_queue());
-if (_cache_event_source2) {
-dispatch_set_context(_cache_event_source2, this);
-dispatch_source_set_event_handler(_cache_event_source2, ^{ memoryPressureHandler().respondToMemoryPressure();});
-dispatch_resume(_cache_event_source2);
-signal((int)SIGUSR2, SIG_IGN);
-}
-});
-#endif
+notify_register_dispatch("org.WebKit.lowMemory", ¬ifyToken,
+ dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();});
m_installed = true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92410] trunk/Source/WebCore
Title: [92410] trunk/Source/WebCore Revision 92410 Author psola...@apple.com Date 2011-08-04 14:12:38 -0700 (Thu, 04 Aug 2011) Log Message Implement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork https://bugs.webkit.org/show_bug.cgi?id=65704 Reviewed by Oliver Hunt. Implement support for client side certificate authentication in the CFNetwork based loader. * platform/network/cf/AuthenticationCF.cpp: (WebCore::createCF): (WebCore::core): Also fix leak of password string. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/cf/AuthenticationCF.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (92409 => 92410) --- trunk/Source/WebCore/ChangeLog 2011-08-04 21:11:11 UTC (rev 92409) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 21:12:38 UTC (rev 92410) @@ -1,3 +1,17 @@ +2011-08-04 Pratik Solanki + +Implement CERTIFICATE_CREDENTIALS_SUPPORTED for CFNetwork +https://bugs.webkit.org/show_bug.cgi?id=65704 + + +Reviewed by Oliver Hunt. + +Implement support for client side certificate authentication in the CFNetwork based loader. + +* platform/network/cf/AuthenticationCF.cpp: +(WebCore::createCF): +(WebCore::core): Also fix leak of password string. + 2011-08-04 Chris Rogers Make sure that AudioArray is 16-byte aligned Modified: trunk/Source/WebCore/platform/network/cf/AuthenticationCF.cpp (92409 => 92410) --- trunk/Source/WebCore/platform/network/cf/AuthenticationCF.cpp 2011-08-04 21:11:11 UTC (rev 92409) +++ trunk/Source/WebCore/platform/network/cf/AuthenticationCF.cpp 2011-08-04 21:12:38 UTC (rev 92410) @@ -114,6 +114,11 @@ ASSERT_NOT_REACHED(); } +#if CERTIFICATE_CREDENTIALS_SUPPORTED +if (coreCredential.type() == CredentialTypeClientCertificate) +return CFURLCredentialCreateWithIdentityAndCertificateArray(kCFAllocatorDefault, coreCredential.identity(), coreCredential.certificates(), persistence); +#endif + CFStringRef user = coreCredential.user().createCFString(); CFStringRef password = coreCredential.password().createCFString(); CFURLCredentialRef result = CFURLCredentialCreate(0, user, password, 0, persistence); @@ -214,8 +219,15 @@ default: ASSERT_NOT_REACHED(); } - -return Credential(CFURLCredentialGetUsername(cfCredential), CFURLCredentialCopyPassword(cfCredential), persistence); + +#if CERTIFICATE_CREDENTIALS_SUPPORTED +SecIdentityRef identity = CFURLCredentialGetCertificateIdentity(cfCredential); +if (identity) +return Credential(identity, CFURLCredentialGetCertificateArray(cfCredential), persistence); +#endif + +RetainPtr password(AdoptCF, CFURLCredentialCopyPassword(cfCredential)); +return Credential(CFURLCredentialGetUsername(cfCredential), password.get(), persistence); } ProtectionSpace core(CFURLProtectionSpaceRef cfSpace) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92409] trunk/LayoutTests
Title: [92409] trunk/LayoutTests Revision 92409 Author aba...@webkit.org Date 2011-08-04 14:11:11 -0700 (Thu, 04 Aug 2011) Log Message Refine some test expectations to account for flakiness. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92408 => 92409) --- trunk/LayoutTests/ChangeLog 2011-08-04 21:07:22 UTC (rev 92408) +++ trunk/LayoutTests/ChangeLog 2011-08-04 21:11:11 UTC (rev 92409) @@ -1,3 +1,9 @@ +2011-08-04 Adam Barth + +Refine some test expectations to account for flakiness. + +* platform/chromium/test_expectations.txt: + 2011-08-04 Anders Carlsson Make fast/css/import-and-insert-rule-no-update.html less flaky Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92408 => 92409) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 21:07:22 UTC (rev 92408) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 21:11:11 UTC (rev 92409) @@ -891,7 +891,7 @@ BUGWK62974 MAC : svg/wicd/test-rightsizing-b.xhtml = IMAGE BUGWK62974 WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE BUGWK62974 : svg/custom/svg-fonts-in-html.html = IMAGE -BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE +BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE IMAGE+TEXT BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE // - @@ -2165,7 +2165,7 @@ // These tests are consistently failing on Linux, and the latter test is flaky on Win. BUGCR53554 LINUX : svg/W3C-SVG-1.1/fonts-elem-07-b.svg = IMAGE BUGCR53554 WIN : svg/custom/svg-fonts-without-missing-glyph.xhtml = PASS IMAGE -BUGCR53554 LINUX : svg/custom/svg-fonts-without-missing-glyph.xhtml = IMAGE +BUGCR53554 LINUX : svg/custom/svg-fonts-without-missing-glyph.xhtml = IMAGE IMAGE+TEXT // New test, need to verify if it's safe to rebaseline. BUGWK44770 LINUX WIN : svg/repaint/filter-repaint.svg = CRASH IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92408] trunk/Source/WebCore
Title: [92408] trunk/Source/WebCore
Revision 92408
Author crog...@google.com
Date 2011-08-04 14:07:22 -0700 (Thu, 04 Aug 2011)
Log Message
Make sure that AudioArray is 16-byte aligned
https://bugs.webkit.org/show_bug.cgi?id=65651
Reviewed by Kenneth Russell.
No new tests - this does not change _javascript_ API.
* platform/audio/AudioArray.h:
(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::size):
(WebCore::AudioArray::at):
(WebCore::AudioArray::operator[]):
(WebCore::AudioArray::alignedAddress):
* platform/audio/Biquad.cpp:
(WebCore::Biquad::Biquad):
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
* webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):
* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::setFftSize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioArray.h
trunk/Source/WebCore/platform/audio/Biquad.cpp
trunk/Source/WebCore/platform/audio/ReverbConvolverStage.cpp
trunk/Source/WebCore/webaudio/DelayDSPKernel.cpp
trunk/Source/WebCore/webaudio/RealtimeAnalyser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92407 => 92408)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 20:38:37 UTC (rev 92407)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 21:07:22 UTC (rev 92408)
@@ -1,3 +1,30 @@
+2011-08-04 Chris Rogers
+
+Make sure that AudioArray is 16-byte aligned
+https://bugs.webkit.org/show_bug.cgi?id=65651
+
+Reviewed by Kenneth Russell.
+
+No new tests - this does not change _javascript_ API.
+
+* platform/audio/AudioArray.h:
+(WebCore::AudioArray::AudioArray):
+(WebCore::AudioArray::~AudioArray):
+(WebCore::AudioArray::allocate):
+(WebCore::AudioArray::data):
+(WebCore::AudioArray::size):
+(WebCore::AudioArray::at):
+(WebCore::AudioArray::operator[]):
+(WebCore::AudioArray::alignedAddress):
+* platform/audio/Biquad.cpp:
+(WebCore::Biquad::Biquad):
+* platform/audio/ReverbConvolverStage.cpp:
+(WebCore::ReverbConvolverStage::ReverbConvolverStage):
+* webaudio/DelayDSPKernel.cpp:
+(WebCore::DelayDSPKernel::DelayDSPKernel):
+* webaudio/RealtimeAnalyser.cpp:
+(WebCore::RealtimeAnalyser::setFftSize):
+
2011-08-04 Brady Eidson
, , and https://bugs.webkit.org/show_bug.cgi?id=65712
Modified: trunk/Source/WebCore/platform/audio/AudioArray.h (92407 => 92408)
--- trunk/Source/WebCore/platform/audio/AudioArray.h 2011-08-04 20:38:37 UTC (rev 92407)
+++ trunk/Source/WebCore/platform/audio/AudioArray.h 2011-08-04 21:07:22 UTC (rev 92408)
@@ -30,16 +30,70 @@
#define AudioArray_h
#include
+#include
#include
namespace WebCore {
template
-class AudioArray : public Vector {
+class AudioArray {
public:
-AudioArray() : Vector(0) { }
-explicit AudioArray(size_t n) : Vector(n, 0) { }
+AudioArray() : m_allocation(0), m_alignedData(0), m_size(0) { }
+explicit AudioArray(size_t n) : m_allocation(0), m_alignedData(0), m_size(0)
+{
+allocate(n);
+}
+~AudioArray()
+{
+fastFree(m_allocation);
+}
+
+// It's OK to call allocate() multiple times, but data will *not* be copied from an initial allocation
+// if re-allocated. Allocations are zero-initialized.
+void allocate(size_t n)
+{
+// 16-byte alignment for 128bit SIMD.
+const size_t alignment = 16;
+
+if (m_allocation)
+fastFree(m_allocation);
+
+bool isAllocationGood = false;
+
+while (!isAllocationGood) {
+// Initially we try to allocate the exact size, but if it's not aligned
+// then we'll have to reallocate and from then on allocate extra.
+static size_t extraAllocationBytes = 0;
+
+T* allocation = static_cast(fastMalloc(sizeof(T) * n + extraAllocationBytes));
+T* alignedData = alignedAddress(allocation, alignment);
+
+if (alignedData == allocation || extraAllocationBytes == alignment) {
+m_allocation = allocation;
+m_alignedData = alignedData;
+m_size = n;
+isAllocationGood = true;
+zero();
+} else {
+extraAllocationBytes = alignment; // always allocate extra after the first alignment failure.
+fastFree(allocation);
+}
+}
+}
+
+T* data() { return m_alignedData; }
+const T* data() const { return m_alignedData; }
+size_t size() const { return m_size; }
+
+T& at(size_t i)
+{
+ASSERT(i < size());
+return data()[i];
+}
+
+T& operator[](size_t i) { return at(i); }
+
void zero() { memset(this->data(), 0, sizeof(T) * this->size()); }
void
[webkit-changes] [92407] trunk/Tools
Title: [92407] trunk/Tools
Revision 92407
Author aba...@webkit.org
Date 2011-08-04 13:38:37 -0700 (Thu, 04 Aug 2011)
Log Message
More logging to help debug the "no SVN rev on Chromium Windows bots"
bug. My current theory is that we're trying to detect the SCM system
in the wrong directory.
* Scripts/webkitpy/layout_tests/port/base.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
Diff
Modified: trunk/Tools/ChangeLog (92406 => 92407)
--- trunk/Tools/ChangeLog 2011-08-04 20:14:37 UTC (rev 92406)
+++ trunk/Tools/ChangeLog 2011-08-04 20:38:37 UTC (rev 92407)
@@ -1,3 +1,11 @@
+2011-08-04 Adam Barth
+
+More logging to help debug the "no SVN rev on Chromium Windows bots"
+bug. My current theory is that we're trying to detect the SCM system
+in the wrong directory.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+
2011-08-04 Dimitri Glazkov
Speed up webkit-patch optimize-expectations significantly by not collecting test files.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (92406 => 92407)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-08-04 20:14:37 UTC (rev 92406)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-08-04 20:38:37 UTC (rev 92407)
@@ -631,7 +631,11 @@
# FIXME: Due to Chromium's insane DEPS system, the root of the WebKit
# checkout isn't actually from svn.webkit.org. Instead, we detect the
# scm from the Source directory, which really does map to svn.webkit.org.
-return detect_scm_system(self.path_from_webkit_base('Source'))
+path = self.path_from_webkit_base('Source')
+_log.debug('---webkit_source_scm---')
+_log.debug(path)
+_log.debug(os.getcwd())
+return detect_scm_system(path)
def path_to_test_expectations_file(self):
"""Update the test expectations to the passed-in string.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92406] trunk/Source/WebCore
Title: [92406] trunk/Source/WebCore
Revision 92406
Author beid...@apple.com
Date 2011-08-04 13:14:37 -0700 (Thu, 04 Aug 2011)
Log Message
, , and https://bugs.webkit.org/show_bug.cgi?id=65712
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.
Reviewed by Darin Adler.
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a
whole bunch of stuff that might need to check it.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageTracker.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92405 => 92406)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 20:09:18 UTC (rev 92405)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 20:14:37 UTC (rev 92406)
@@ -1,3 +1,14 @@
+2011-08-04 Brady Eidson
+
+, , and https://bugs.webkit.org/show_bug.cgi?id=65712
+REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.
+
+Reviewed by Darin Adler.
+
+* storage/StorageTracker.cpp:
+(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a
+ whole bunch of stuff that might need to check it.
+
2011-08-04 Jeff Miller
Adopt AVCF media back end on Windows
Modified: trunk/Source/WebCore/storage/StorageTracker.cpp (92405 => 92406)
--- trunk/Source/WebCore/storage/StorageTracker.cpp 2011-08-04 20:09:18 UTC (rev 92405)
+++ trunk/Source/WebCore/storage/StorageTracker.cpp 2011-08-04 20:14:37 UTC (rev 92406)
@@ -62,6 +62,8 @@
void StorageTracker::internalInitialize()
{
+m_needsInitialization = false;
+
ASSERT(isMainThread());
// Make sure text encoding maps have been built on the main thread, as the StorageTracker thread might try to do it there instead.
@@ -72,8 +74,6 @@
storageTracker->setIsActive(true);
storageTracker->m_thread->start();
storageTracker->importOriginIdentifiers();
-
-m_needsInitialization = false;
}
StorageTracker& StorageTracker::tracker()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92405] trunk/LayoutTests
Title: [92405] trunk/LayoutTests
Revision 92405
Author ander...@apple.com
Date 2011-08-04 13:09:18 -0700 (Thu, 04 Aug 2011)
Log Message
Make fast/css/import-and-insert-rule-no-update.html less flaky
https://bugs.webkit.org/show_bug.cgi?id=65713
Reviewed by Dan Bernstein.
Wait until the @imported style sheet has finished loading before running the test.
* fast/css/import-and-insert-rule-no-update.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/import-and-insert-rule-no-update.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92404 => 92405)
--- trunk/LayoutTests/ChangeLog 2011-08-04 20:06:48 UTC (rev 92404)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 20:09:18 UTC (rev 92405)
@@ -1,5 +1,16 @@
2011-08-04 Anders Carlsson
+Make fast/css/import-and-insert-rule-no-update.html less flaky
+https://bugs.webkit.org/show_bug.cgi?id=65713
+
+Reviewed by Dan Bernstein.
+
+Wait until the @imported style sheet has finished loading before running the test.
+
+* fast/css/import-and-insert-rule-no-update.html:
+
+2011-08-04 Anders Carlsson
+
Add more failing tests to the skipped list.
* platform/mac-lion/Skipped:
Modified: trunk/LayoutTests/fast/css/import-and-insert-rule-no-update.html (92404 => 92405)
--- trunk/LayoutTests/fast/css/import-and-insert-rule-no-update.html 2011-08-04 20:06:48 UTC (rev 92404)
+++ trunk/LayoutTests/fast/css/import-and-insert-rule-no-update.html 2011-08-04 20:09:18 UTC (rev 92405)
@@ -33,10 +33,21 @@
layoutTestController.notifyDone();
}
+function waitForSheetToFinishLoading()
+{
+if (document.styleSheets.length && document.styleSheets[0].rules[1].styleSheet) {
+test();
+return;
+}
+
+window.setTimeout(waitForSheetToFinishLoading, 10)
+}
+
window._onload_ = function() {
document.styleSheets[0].insertRule('@import "green.css";', 1);
+
// We need to wait some time to let the stylesheet load before testing.
-window.setTimeout(test, 25);
+window.setTimeout(waitForSheetToFinishLoading, 10);
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92403] trunk/Tools
Title: [92403] trunk/Tools
Revision 92403
Author dglaz...@chromium.org
Date 2011-08-04 13:04:03 -0700 (Thu, 04 Aug 2011)
Log Message
Speed up webkit-patch optimize-expectations significantly by not collecting test files.
https://bugs.webkit.org/show_bug.cgi?id=65697
I neglected to realize that collecting test names is not necessary for this operation.
Reviewed by Adam Barth.
* Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py
Diff
Modified: trunk/Tools/ChangeLog (92402 => 92403)
--- trunk/Tools/ChangeLog 2011-08-04 19:42:31 UTC (rev 92402)
+++ trunk/Tools/ChangeLog 2011-08-04 20:04:03 UTC (rev 92403)
@@ -1,3 +1,14 @@
+2011-08-04 Dimitri Glazkov
+
+Speed up webkit-patch optimize-expectations significantly by not collecting test files.
+https://bugs.webkit.org/show_bug.cgi?id=65697
+
+I neglected to realize that collecting test names is not necessary for this operation.
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
+
2011-08-04 Adam Barth
checkout_unittest.js should have better coverage of checkout.js
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py (92402 => 92403)
--- trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py 2011-08-04 19:42:31 UTC (rev 92402)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/expectations.py 2011-08-04 20:04:03 UTC (rev 92403)
@@ -39,7 +39,7 @@
def execute(self, options, args, tool):
port = factory.get("chromium-win-win7") # FIXME: This should be selectable.
expectation_lines = TestExpectationParser.tokenize_list(port.test_expectations())
-parser = TestExpectationParser(port, port.tests(["."]), allow_rebaseline_modifier=False)
+parser = TestExpectationParser(port, [], allow_rebaseline_modifier=False)
for expectation_line in expectation_lines:
parser.parse(expectation_line)
converter = TestConfigurationConverter(port.all_test_configurations(), port.configuration_specifier_macros())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92402] tags/Safari-534.49.1/Source
Title: [92402] tags/Safari-534.49.1/Source
Revision 92402
Author lforsch...@apple.com
Date 2011-08-04 12:42:31 -0700 (Thu, 04 Aug 2011)
Log Message
Merge r92231.
Modified Paths
tags/Safari-534.49.1/Source/_javascript_Core/ChangeLog
tags/Safari-534.49.1/Source/_javascript_Core/wtf/TCSystemAlloc.cpp
tags/Safari-534.49.1/Source/WebCore/ChangeLog
tags/Safari-534.49.1/Source/WebCore/platform/mac/PurgeableBufferMac.cpp
tags/Safari-534.49.1/Source/WebKit2/ChangeLog
tags/Safari-534.49.1/Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp
Diff
Modified: tags/Safari-534.49.1/Source/_javascript_Core/ChangeLog (92401 => 92402)
--- tags/Safari-534.49.1/Source/_javascript_Core/ChangeLog 2011-08-04 19:35:35 UTC (rev 92401)
+++ tags/Safari-534.49.1/Source/_javascript_Core/ChangeLog 2011-08-04 19:42:31 UTC (rev 92402)
@@ -1,3 +1,20 @@
+2011-08-04 Lucas Forschler
+
+Merged 92231.
+
+2011-08-01 Michael Saboff
+
+Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
+https://bugs.webkit.org/show_bug.cgi?id=65502
+
+Reviewed by Anders Carlsson.
+
+With the fix of the issues causing madvise MADV_FREE_REUSABLE to fail,
+added an assert to the return code of madvise to catch any regressions.
+
+* wtf/TCSystemAlloc.cpp:
+(TCMalloc_SystemRelease):
+
2011-06-20 Lucas Forschler
Merged 89281.
Modified: tags/Safari-534.49.1/Source/_javascript_Core/wtf/TCSystemAlloc.cpp (92401 => 92402)
--- tags/Safari-534.49.1/Source/_javascript_Core/wtf/TCSystemAlloc.cpp 2011-08-04 19:35:35 UTC (rev 92401)
+++ tags/Safari-534.49.1/Source/_javascript_Core/wtf/TCSystemAlloc.cpp 2011-08-04 19:42:31 UTC (rev 92402)
@@ -392,7 +392,12 @@
void TCMalloc_SystemRelease(void* start, size_t length)
{
-while (madvise(start, length, MADV_FREE_REUSABLE) == -1 && errno == EAGAIN) { }
+int madviseResult;
+
+while ((madviseResult = madvise(start, length, MADV_FREE_REUSABLE)) == -1 && errno == EAGAIN) { }
+
+// Although really advisory, if madvise fail, we want to know about it.
+ASSERT_UNUSED(madviseResult, madviseResult != -1);
}
#elif HAVE(MADV_FREE) || HAVE(MADV_DONTNEED)
Modified: tags/Safari-534.49.1/Source/WebCore/ChangeLog (92401 => 92402)
--- tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 19:35:35 UTC (rev 92401)
+++ tags/Safari-534.49.1/Source/WebCore/ChangeLog 2011-08-04 19:42:31 UTC (rev 92402)
@@ -1,3 +1,24 @@
+2011-08-04 Lucas Forschler
+
+Merged 92231.
+
+2011-08-01 Michael Saboff
+
+Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
+https://bugs.webkit.org/show_bug.cgi?id=65502
+
+Reviewed by Anders Carlsson.
+
+Change the vm_copy in PurgeableBuffer::create to be a memcpy. The
+vm_copy causes the process to have additional references to the same
+memory region. These additional reference caused madvise(MADV_FREE_REUSABLE)
+to fail when it encountered such pages.
+
+No tests added this is a resource defect and not a functional issue.
+
+* platform/mac/PurgeableBufferMac.cpp:
+(WebCore::PurgeableBuffer::create):
+
2011-06-14 Lucas Forschler
Rolled out 89080.
Modified: tags/Safari-534.49.1/Source/WebCore/platform/mac/PurgeableBufferMac.cpp (92401 => 92402)
--- tags/Safari-534.49.1/Source/WebCore/platform/mac/PurgeableBufferMac.cpp 2011-08-04 19:35:35 UTC (rev 92401)
+++ tags/Safari-534.49.1/Source/WebCore/platform/mac/PurgeableBufferMac.cpp 2011-08-04 19:42:31 UTC (rev 92402)
@@ -64,14 +64,8 @@
if (ret != KERN_SUCCESS)
return nullptr;
-ret = vm_copy(mach_task_self(), reinterpret_cast(data), size, buffer);
+memcpy(reinterpret_cast(buffer), data, size);
-ASSERT(ret == KERN_SUCCESS);
-if (ret != KERN_SUCCESS) {
-vm_deallocate(mach_task_self(), buffer, size);
-return nullptr;
-}
-
return adoptPtr(new PurgeableBuffer(reinterpret_cast(buffer), size));
}
Modified: tags/Safari-534.49.1/Source/WebKit2/ChangeLog (92401 => 92402)
--- tags/Safari-534.49.1/Source/WebKit2/ChangeLog 2011-08-04 19:35:35 UTC (rev 92401)
+++ tags/Safari-534.49.1/Source/WebKit2/ChangeLog 2011-08-04 19:42:31 UTC (rev 92402)
@@ -1,3 +1,22 @@
+2011-08-02 Lucas Forschler
+
+Merged 92231.
+
+2011-08-01 Michael Saboff
+
+Virtual copying of FastMalloc allocated memory causes madvise MADV_FREE_REUSABLE errors
+https://bugs.webkit.org/show_bug.cgi?id=65502
+
+Reviewed by Anders Carlsson.
+
+Changed OOL message to use MACH_MSG_PHYSICAL_COPY flag instead of virtual flag
+so that the original memory region isn't referenced by the message and ultimately
+the receiving process. The additional reference caused madvise(MADV_FREE_REUSABLE)
+to fail when it encountered such pages.
+
+* Platform/CoreIPC/mac/ConnectionMac.cpp:
+(CoreIPC::Co
[webkit-changes] [92401] tags/Safari-534.49.1/Source
Title: [92401] tags/Safari-534.49.1/Source Revision 92401 Author lforsch...@apple.com Date 2011-08-04 12:35:35 -0700 (Thu, 04 Aug 2011) Log Message Versioning. Modified Paths tags/Safari-534.49.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-534.49.1/Source/_javascript_Glue/Configurations/Version.xcconfig tags/Safari-534.49.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-534.49.1/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-534.49.1/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-534.49.1/Source/_javascript_Core/Configurations/Version.xcconfig (92400 => 92401) --- tags/Safari-534.49.1/Source/_javascript_Core/Configurations/Version.xcconfig 2011-08-04 19:33:09 UTC (rev 92400) +++ tags/Safari-534.49.1/Source/_javascript_Core/Configurations/Version.xcconfig 2011-08-04 19:35:35 UTC (rev 92401) @@ -23,8 +23,8 @@ MAJOR_VERSION = 534; MINOR_VERSION = 49; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-534.49.1/Source/_javascript_Glue/Configurations/Version.xcconfig (92400 => 92401) --- tags/Safari-534.49.1/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-08-04 19:33:09 UTC (rev 92400) +++ tags/Safari-534.49.1/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-08-04 19:35:35 UTC (rev 92401) @@ -23,8 +23,8 @@ MAJOR_VERSION = 534; MINOR_VERSION = 49; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-534.49.1/Source/WebCore/Configurations/Version.xcconfig (92400 => 92401) --- tags/Safari-534.49.1/Source/WebCore/Configurations/Version.xcconfig 2011-08-04 19:33:09 UTC (rev 92400) +++ tags/Safari-534.49.1/Source/WebCore/Configurations/Version.xcconfig 2011-08-04 19:35:35 UTC (rev 92401) @@ -23,8 +23,8 @@ MAJOR_VERSION = 534; MINOR_VERSION = 49; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-534.49.1/Source/WebKit/mac/Configurations/Version.xcconfig (92400 => 92401) --- tags/Safari-534.49.1/Source/WebKit/mac/Configurations/Version.xcconfig 2011-08-04 19:33:09 UTC (rev 92400) +++ tags/Safari-534.49.1/Source/WebKit/mac/Configurations/Version.xcconfig 2011-08-04 19:35:35 UTC (rev 92401) @@ -23,8 +23,8 @@ MAJOR_VERSION = 534; MINOR_VERSION = 49; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-534.49.1/Source/WebKit2/Configurations/Version.xcconfig (92400 => 92401) --- tags/Safari-534.49.1/Source/WebKit2/Configurations/Version.xcconfig 2011-08-04 19:33:09 UTC (rev 92400) +++ tags/Safari-534.49.1/Source/WebKit2/Configurations/Version.xcconfig 2011-08-04 19:35:35 UTC (rev 92401) @@ -23,8 +23,8 @@ MAJOR_VERSION = 534; MINOR_VERSION = 49; -TINY_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); +TINY_VERSION = 1; +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92400] tags/Safari-534.49.1/
Title: [92400] tags/Safari-534.49.1/ Revision 92400 Author lforsch...@apple.com Date 2011-08-04 12:33:09 -0700 (Thu, 04 Aug 2011) Log Message New tag. Added Paths tags/Safari-534.49.1/ Diff Property changes: tags/Safari-534.49.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92399] trunk/Source
Title: [92399] trunk/Source Revision 92399 Author joc...@chromium.org Date 2011-08-04 12:23:27 -0700 (Thu, 04 Aug 2011) Log Message Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest. https://bugs.webkit.org/show_bug.cgi?id=48483 Reviewed by Alexey Proskuryakov. Source/WebCore: * loader/PingLoader.cpp: (WebCore::PingLoader::loadImage): (WebCore::PingLoader::sendPing): (WebCore::PingLoader::reportContentSecurityPolicyViolation): * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::load): * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: (webKitWebSrcStart): * platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): * platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::ResourceRequestBase): * platform/network/chromium/ResourceRequest.cpp: (WebCore::ResourceRequest::doPlatformCopyData): (WebCore::ResourceRequest::doPlatformAdopt): * platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::setTargetType): * workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::load): * workers/Worker.cpp: (WebCore::Worker::create): * workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts): * workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::WorkerScriptLoader): (WebCore::WorkerScriptLoader::createResourceRequest): * workers/WorkerScriptLoader.h: (WebCore::WorkerScriptLoader::create): (WebCore::WorkerScriptLoader::setTargetType): Source/WebKit/chromium: * src/SharedWorkerRepository.cpp: (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/PingLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp trunk/Source/WebCore/platform/network/ResourceRequestBase.h trunk/Source/WebCore/platform/network/chromium/ResourceRequest.cpp trunk/Source/WebCore/platform/network/chromium/ResourceRequest.h trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/WorkerContext.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/SharedWorkerRepository.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (92398 => 92399) --- trunk/Source/WebCore/ChangeLog 2011-08-04 19:21:55 UTC (rev 92398) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 19:23:27 UTC (rev 92399) @@ -1,3 +1,43 @@ +2011-08-04 Jochen Eisinger + +Get rid of ResourceRequestBase::m_targetType. Move it to chromium's ResourceRequest. +https://bugs.webkit.org/show_bug.cgi?id=48483 + +Reviewed by Alexey Proskuryakov. + +* loader/PingLoader.cpp: +(WebCore::PingLoader::loadImage): +(WebCore::PingLoader::sendPing): +(WebCore::PingLoader::reportContentSecurityPolicyViolation): +* loader/cache/CachedResourceRequest.cpp: +(WebCore::CachedResourceRequest::load): +* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: +(webKitWebSrcStart): +* platform/network/ResourceRequestBase.cpp: +(WebCore::ResourceRequestBase::adopt): +(WebCore::ResourceRequestBase::copyData): +* platform/network/ResourceRequestBase.h: +(WebCore::ResourceRequestBase::ResourceRequestBase): +* platform/network/chromium/ResourceRequest.cpp: +(WebCore::ResourceRequest::doPlatformCopyData): +(WebCore::ResourceRequest::doPlatformAdopt): +* platform/network/chromium/ResourceRequest.h: +(WebCore::ResourceRequest::ResourceRequest): +(WebCore::ResourceRequest::targetType): +(WebCore::ResourceRequest::setTargetType): +* workers/DefaultSharedWorkerRepository.cpp: +(WebCore::SharedWorkerScriptLoader::load): +* workers/Worker.cpp: +(WebCore::Worker::create): +* workers/WorkerContext.cpp: +(WebCore::WorkerContext::importScripts): +* workers/WorkerScriptLoader.cpp: +(WebCore::WorkerScriptLoader::WorkerScriptLoader): +(WebCore::WorkerScriptLoader::createResourceRequest): +* workers/WorkerScriptLoader.h: +(WebCore::WorkerScriptLoader::create): +(WebCore::WorkerScriptLoader::setTargetType): + 2011-08-04 Jeff Miller Fix WinCE build after r92308. Modified: trunk/Source/WebCore/loader/PingLoader.cpp (92398 => 92399) --- trunk/Source/WebCore/loader/PingLoader.cpp 2011-08-04 19:21:55 UTC (rev 92398) +++ trunk/Source/WebCore/loader/PingLoader.cpp 2011-08-04 19:23:27 UTC (rev 92399) @@ -55,7 +55,9 @@ }
[webkit-changes] [92398] trunk/Source/WebCore
Title: [92398] trunk/Source/WebCore Revision 92398 Author je...@apple.com Date 2011-08-04 12:21:55 -0700 (Thu, 04 Aug 2011) Log Message Fix WinCE build after r92308. * config.h: Don't try to include WebCoreHeaderDetection.h for WinCE. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/config.h Diff Modified: trunk/Source/WebCore/ChangeLog (92397 => 92398) --- trunk/Source/WebCore/ChangeLog 2011-08-04 19:20:18 UTC (rev 92397) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 19:21:55 UTC (rev 92398) @@ -1,3 +1,9 @@ +2011-08-04 Jeff Miller + +Fix WinCE build after r92308. + +* config.h: Don't try to include WebCoreHeaderDetection.h for WinCE. + 2011-08-04 Darin Fisher webkitRequestAnimationFrame's element argument needs to be marked optional Modified: trunk/Source/WebCore/config.h (92397 => 92398) --- trunk/Source/WebCore/config.h 2011-08-04 19:20:18 UTC (rev 92397) +++ trunk/Source/WebCore/config.h 2011-08-04 19:21:55 UTC (rev 92398) @@ -29,7 +29,7 @@ #include -#if OS(WINDOWS) && !PLATFORM(QT) && !PLATFORM(CHROMIUM) +#if OS(WINDOWS) && !OS(WINCE) && !PLATFORM(QT) && !PLATFORM(CHROMIUM) #include #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92397] trunk/LayoutTests
Title: [92397] trunk/LayoutTests Revision 92397 Author ander...@apple.com Date 2011-08-04 12:20:18 -0700 (Thu, 04 Aug 2011) Log Message Add more failing tests to the skipped list. * platform/mac-lion/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-lion/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92396 => 92397) --- trunk/LayoutTests/ChangeLog 2011-08-04 19:19:23 UTC (rev 92396) +++ trunk/LayoutTests/ChangeLog 2011-08-04 19:20:18 UTC (rev 92397) @@ -1,3 +1,9 @@ +2011-08-04 Anders Carlsson + +Add more failing tests to the skipped list. + +* platform/mac-lion/Skipped: + 2011-08-03 Adam Roben Test that a 2^25x2^25 pixel layer doesn't cause a crash Modified: trunk/LayoutTests/platform/mac-lion/Skipped (92396 => 92397) --- trunk/LayoutTests/platform/mac-lion/Skipped 2011-08-04 19:19:23 UTC (rev 92396) +++ trunk/LayoutTests/platform/mac-lion/Skipped 2011-08-04 19:20:18 UTC (rev 92397) @@ -1,3 +1,5 @@ +# --- Canvas --- + # Failing due to minor differences between accelerated canvas and CG # canvas/philip/tests/2d.gradient.interpolate.colouralpha.html @@ -11,5 +13,30 @@ # canvas/philip/tests/2d.strokeRect.zero.5.html -# Unknown test failures +# +fast/canvas/canvas-createPattern-fillRect-shadow.html + +# +fast/canvas/canvas-fillRect-gradient-shadow.html + +# These canvas tests are faulty, need to be fixed +# +fast/canvas/canvas-scale-shadowBlur.html + +# +fast/canvas/canvas-strokeRect-gradient-shadow.html + +# +fast/canvas/set-colors.html + +# Unknown canvas test failures canvas/philip/tests/2d.text.draw.baseline.ideographic.html +fast/canvas/canvas-draw-canvas-on-canvas-shadow.html +fast/canvas/canvas-scale-strokePath-shadow.html +fast/canvas/canvas-strokePath-gradient-shadow.html +fast/canvas/canvas-strokeRect-alpha-shadow.html + +# --- WebGL --- + +# Currently failing WebGL tests +fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92396] trunk/Tools
Title: [92396] trunk/Tools
Revision 92396
Author aba...@webkit.org
Date 2011-08-04 12:19:23 -0700 (Thu, 04 Aug 2011)
Log Message
checkout_unittest.js should have better coverage of checkout.js
https://bugs.webkit.org/show_bug.cgi?id=65671
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
- Remove unused functions.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
- Test remaining public functions in the checkout module.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92395 => 92396)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js 2011-08-04 19:11:13 UTC (rev 92395)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js 2011-08-04 19:19:23 UTC (rev 92396)
@@ -29,30 +29,11 @@
var kWebKitTrunk = 'http://svn.webkit.org/repository/webkit/trunk/';
-function subversionURLAtRevision(subversionURL, revision)
-{
-return subversionURL + '?r=' + revision;
-}
-
checkout.subversionURLForTest = function(testName)
{
return kWebKitTrunk + 'LayoutTests/' + testName;
}
-checkout.existsAtRevision = function(subversionURL, revision, callback)
-{
-net.ajax({
-method: 'HEAD',
-url: subversionURLAtRevision(subversionURL, revision),
-success: function() {
-callback(true);
-},
-error: function() {
-callback(false);
-}
-});
-};
-
checkout.updateExpectations = function(failureInfoList, callback)
{
net.post('/updateexpectations', JSON.stringify(failureInfoList), function() {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js (92395 => 92396)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js 2011-08-04 19:11:13 UTC (rev 92395)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js 2011-08-04 19:19:23 UTC (rev 92396)
@@ -31,4 +31,77 @@
equals(checkout.subversionURLForTest("path/to/test.html"), "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/path/to/test.html");
});
+test("updateExpectations", 4, function() {
+var simulator = new NetworkSimulator();
+simulator.post = function(url, data, callback)
+{
+equals(url, '/updateexpectations');
+equals(data, '[{"builderName":"WebKit Linux","testName":"another/test.svg","failureTypeList":["IMAGE"]}]');
+simulator.scheduleCallback(callback);
+};
+
+simulator.runTest(function() {
+checkout.updateExpectations([{
+'builderName': 'WebKit Linux',
+'testName': 'another/test.svg',
+'failureTypeList': ['IMAGE'],
+}], function() {
+ok(true);
+});
+});
+});
+
+test("optimizeBaselines", 3, function() {
+var simulator = new NetworkSimulator();
+simulator.post = function(url, callback)
+{
+equals(url, '/optimizebaselines?test=another%2Ftest.svg');
+simulator.scheduleCallback(callback);
+};
+
+simulator.runTest(function() {
+checkout.optimizeBaselines('another/test.svg', function() {
+ok(true);
+});
+});
+});
+
+test("rebaseline", 3, function() {
+var simulator = new NetworkSimulator();
+
+var requestedURLs = [];
+simulator.post = function(url, callback)
+{
+requestedURLs.push(url);
+simulator.scheduleCallback(callback);
+};
+
+simulator.runTest(function() {
+checkout.rebaseline([{
+'builderName': 'WebKit Linux',
+'testName': 'another/test.svg',
+'failureTypeList': ['IMAGE'],
+}, {
+'builderName': 'WebKit Mac10.6',
+'testName': 'another/test.svg',
+'failureTypeList': ['IMAGE+TEXT'],
+}, {
+'builderName': 'Webkit Vista',
+'testName': 'fast/test.html',
+'failureTypeList': ['TEXT'],
+}], function() {
+ok(true);
+});
+});
+
+deepEqual(requestedURLs, [
+"/rebaseline?builder=WebKit+Linux&test=another%2Ftest.svg&extension=png",
+"/rebaseline?builder=WebKit+Mac10.6&test=another%2Ftest.svg&extension=txt",
+"/rebaseline?builder=WebKit+Mac10.6&test=another%2Ftest.svg&extension=png",
+"/rebaseline?builder=Webkit+Vista&test=fast%2Ftest.html&extension=txt",
+"/optimizebaselines?test=another%2Ftest.svg",
+"/optimizebaselines?test=fast%2Ftest.html"
+]);
+});
+
})();
Modified: trunk/Tools/ChangeLog (92
[webkit-changes] [92395] branches/safari-534.51-branch/Source
Title: [92395] branches/safari-534.51-branch/Source Revision 92395 Author lforsch...@apple.com Date 2011-08-04 12:11:13 -0700 (Thu, 04 Aug 2011) Log Message Versioning. Modified Paths branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (92394 => 92395) --- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-08-04 19:09:44 UTC (rev 92394) +++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-08-04 19:11:13 UTC (rev 92395) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (92394 => 92395) --- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-08-04 19:09:44 UTC (rev 92394) +++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-08-04 19:11:13 UTC (rev 92395) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (92394 => 92395) --- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-08-04 19:09:44 UTC (rev 92394) +++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-08-04 19:11:13 UTC (rev 92395) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (92394 => 92395) --- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-08-04 19:09:44 UTC (rev 92394) +++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-08-04 19:11:13 UTC (rev 92395) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (92394 => 92395) --- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-08-04 19:09:44 UTC (rev 92394) +++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-08-04 19:11:13 UTC (rev 92395) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 6; +TINY_VERSION = 7; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92394] tags/Safari-534.51.6/
Title: [92394] tags/Safari-534.51.6/ Revision 92394 Author lforsch...@apple.com Date 2011-08-04 12:09:44 -0700 (Thu, 04 Aug 2011) Log Message New tag. Added Paths tags/Safari-534.51.6/ Diff Property changes: tags/Safari-534.51.6 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92393] trunk/Source/JavaScriptCore
Title: [92393] trunk/Source/_javascript_Core Revision 92393 Author commit-qu...@webkit.org Date 2011-08-04 11:26:30 -0700 (Thu, 04 Aug 2011) Log Message Interpreter can potentially GC in the middle of initializing a structure chain https://bugs.webkit.org/show_bug.cgi?id=65638 Patch by Mark Hahnenberg on 2011-08-04 Reviewed by Oliver Hunt. Moved the allocation of a prototype StructureChain before the initialization of the structure chain within the interpreter that was causing intermittent GC crashes. * interpreter/Interpreter.cpp: (JSC::Interpreter::tryCachePutByID): * wtf/Platform.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/interpreter/Interpreter.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (92392 => 92393) --- trunk/Source/_javascript_Core/ChangeLog 2011-08-04 18:19:43 UTC (rev 92392) +++ trunk/Source/_javascript_Core/ChangeLog 2011-08-04 18:26:30 UTC (rev 92393) @@ -1,3 +1,17 @@ +2011-08-04 Mark Hahnenberg + +Interpreter can potentially GC in the middle of initializing a structure chain +https://bugs.webkit.org/show_bug.cgi?id=65638 + +Reviewed by Oliver Hunt. + +Moved the allocation of a prototype StructureChain before the initialization of +the structure chain within the interpreter that was causing intermittent GC crashes. + +* interpreter/Interpreter.cpp: +(JSC::Interpreter::tryCachePutByID): +* wtf/Platform.h: + 2011-08-04 Filip Pizlo Eval handling attempts literal parsing even when the eval Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (92392 => 92393) --- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-08-04 18:19:43 UTC (rev 92392) +++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-08-04 18:26:30 UTC (rev 92393) @@ -1394,10 +1394,14 @@ normalizePrototypeChain(callFrame, baseCell); JSCell* owner = codeBlock->ownerExecutable(); JSGlobalData& globalData = callFrame->globalData(); +// Get the prototype here because the call to prototypeChain could cause a +// GC allocation, which we don't want to happen while we're in the middle of +// initializing the union. +StructureChain* prototypeChain = structure->prototypeChain(callFrame); vPC[0] = getOpcode(op_put_by_id_transition); vPC[4].u.structure.set(globalData, owner, structure->previousID()); vPC[5].u.structure.set(globalData, owner, structure); -vPC[6].u.structureChain.set(callFrame->globalData(), codeBlock->ownerExecutable(), structure->prototypeChain(callFrame)); +vPC[6].u.structureChain.set(callFrame->globalData(), codeBlock->ownerExecutable(), prototypeChain); ASSERT(vPC[6].u.structureChain); vPC[7] = slot.cachedOffset(); return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92392] trunk/Source/WebCore
Title: [92392] trunk/Source/WebCore Revision 92392 Author da...@chromium.org Date 2011-08-04 11:19:43 -0700 (Thu, 04 Aug 2011) Log Message webkitRequestAnimationFrame's element argument needs to be marked optional https://bugs.webkit.org/show_bug.cgi?id=65698 Reviewed by James Robinson. * page/DOMWindow.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/DOMWindow.idl Diff Modified: trunk/Source/WebCore/ChangeLog (92391 => 92392) --- trunk/Source/WebCore/ChangeLog 2011-08-04 18:17:11 UTC (rev 92391) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 18:19:43 UTC (rev 92392) @@ -1,3 +1,12 @@ +2011-08-04 Darin Fisher + +webkitRequestAnimationFrame's element argument needs to be marked optional +https://bugs.webkit.org/show_bug.cgi?id=65698 + +Reviewed by James Robinson. + +* page/DOMWindow.idl: + 2011-08-04 Adam Roben Delete some unused code from platform/graphics/win Modified: trunk/Source/WebCore/page/DOMWindow.idl (92391 => 92392) --- trunk/Source/WebCore/page/DOMWindow.idl 2011-08-04 18:17:11 UTC (rev 92391) +++ trunk/Source/WebCore/page/DOMWindow.idl 2011-08-04 18:19:43 UTC (rev 92392) @@ -238,7 +238,7 @@ #if defined(ENABLE_REQUEST_ANIMATION_FRAME) // WebKit animation extensions -long webkitRequestAnimationFrame(in [Callback] RequestAnimationFrameCallback callback, in Element element); +long webkitRequestAnimationFrame(in [Callback] RequestAnimationFrameCallback callback, in [Optional=CallWithDefaultValue] Element element); void webkitCancelRequestAnimationFrame(in long id); #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92391] trunk/Tools
Title: [92391] trunk/Tools
Revision 92391
Author dslo...@google.com
Date 2011-08-04 11:17:11 -0700 (Thu, 04 Aug 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=65706
Run run-unit-tests on release mode test bots.
Reenabling after 61812 is fixed.
Reviewed by Adam Roben.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (92390 => 92391)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-04 18:11:57 UTC (rev 92390)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-08-04 18:17:11 UTC (rev 92391)
@@ -626,8 +626,7 @@
self.addStep(trigger.Trigger, schedulerNames=triggers)
def unitTestsSupported(configuration, platform):
-# FIXME: Only running in debug mode due to https://bugs.webkit.org/show_bug.cgi?id=61812
-return configuration == 'debug' and (platform == 'win' or (platform.startswith('mac') and platform != 'mac-leopard'))
+return platform == 'win' or (platform.startswith('mac') and platform != 'mac-leopard')
class TestFactory(Factory):
TestClass = RunWebKitTests
Modified: trunk/Tools/ChangeLog (92390 => 92391)
--- trunk/Tools/ChangeLog 2011-08-04 18:11:57 UTC (rev 92390)
+++ trunk/Tools/ChangeLog 2011-08-04 18:17:11 UTC (rev 92391)
@@ -1,3 +1,13 @@
+2011-08-04 Dmitry Lomov
+
+https://bugs.webkit.org/show_bug.cgi?id=65706
+Run run-unit-tests on release mode test bots.
+Reenabling after 61812 is fixed.
+
+Reviewed by Adam Roben.
+
+* BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
2011-08-04 Adam Barth
builders.js needs unit tests
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92389] trunk
Title: [92389] trunk Revision 92389 Author aro...@apple.com Date 2011-08-04 11:11:22 -0700 (Thu, 04 Aug 2011) Log Message Detect and handle overflow in PlatformCALayerWinInternal::constrainedSize Google Maps sometimes requests very large (i.e., 2^50 pixels or greater) layers when zooming. PlatformCALayerWinInternal has code to limit tiled layers to 2^27 pixels, but it was not correctly handling overflow. In some cases, this would lead to creating a tiled layer with 0 tiles, which was the cause of this crash. Fixes Crash beneath PlatformCALayerWinInternal::updateTiles when zooming on Google Maps Reviewed by Sam Weinig. Source/WebCore: * platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: (PlatformCALayerWinInternal::constrainedSize): Check for overflow before seeing if the number of required tiles is larger than the maximum number of allowed tiles. (PlatformCALayerWinInternal::updateTiles): Added an assertion to catch cases where we have a non-empty tiled layer that contains 0 tiles, which would cause the crash in this bug report. LayoutTests: Test that a 2^25x2^25 pixel layer doesn't cause a crash * compositing/tiling/crash-huge-layer-expected.txt: Added. * compositing/tiling/crash-huge-layer.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp Added Paths trunk/LayoutTests/compositing/tiling/crash-huge-layer-expected.txt trunk/LayoutTests/compositing/tiling/crash-huge-layer.html Diff Modified: trunk/LayoutTests/ChangeLog (92388 => 92389) --- trunk/LayoutTests/ChangeLog 2011-08-04 18:00:41 UTC (rev 92388) +++ trunk/LayoutTests/ChangeLog 2011-08-04 18:11:22 UTC (rev 92389) @@ -1,3 +1,15 @@ +2011-08-03 Adam Roben + +Test that a 2^25x2^25 pixel layer doesn't cause a crash + +Test for Crash beneath +PlatformCALayerWinInternal::updateTiles when zooming on Google Maps + +Reviewed by Sam Weinig. + +* compositing/tiling/crash-huge-layer-expected.txt: Added. +* compositing/tiling/crash-huge-layer.html: Added. + 2011-08-04 Jian Li Unreviewed, mark gain.html as flaky on Linux chromium. Added: trunk/LayoutTests/compositing/tiling/crash-huge-layer-expected.txt (0 => 92389) --- trunk/LayoutTests/compositing/tiling/crash-huge-layer-expected.txt (rev 0) +++ trunk/LayoutTests/compositing/tiling/crash-huge-layer-expected.txt 2011-08-04 18:11:22 UTC (rev 92389) @@ -0,0 +1,3 @@ +This is a test for Bug 65637: Crash beneath PlatformCALayerWinInternal::updateTiles when zooming on Google Maps. The test passes if the browser does not crash. + +Did you crash? Added: trunk/LayoutTests/compositing/tiling/crash-huge-layer.html (0 => 92389) --- trunk/LayoutTests/compositing/tiling/crash-huge-layer.html (rev 0) +++ trunk/LayoutTests/compositing/tiling/crash-huge-layer.html 2011-08-04 18:11:22 UTC (rev 92389) @@ -0,0 +1,7 @@ + + +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +This is a test for . The test passes if the browser does not crash. +Did you crash? Modified: trunk/Source/WebCore/ChangeLog (92388 => 92389) --- trunk/Source/WebCore/ChangeLog 2011-08-04 18:00:41 UTC (rev 92388) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 18:11:22 UTC (rev 92389) @@ -1,3 +1,25 @@ +2011-08-03 Adam Roben + +Detect and handle overflow in PlatformCALayerWinInternal::constrainedSize + +Google Maps sometimes requests very large (i.e., 2^50 pixels or greater) layers when +zooming. PlatformCALayerWinInternal has code to limit tiled layers to 2^27 pixels, but it +was not correctly handling overflow. In some cases, this would lead to creating a tiled +layer with 0 tiles, which was the cause of this crash. + +Fixes Crash beneath +PlatformCALayerWinInternal::updateTiles when zooming on Google Maps + +Reviewed by Sam Weinig. + +Test: compositing/tiling/crash-huge-layer.html + +* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: +(PlatformCALayerWinInternal::constrainedSize): Check for overflow before seeing if the +number of required tiles is larger than the maximum number of allowed tiles. +(PlatformCALayerWinInternal::updateTiles): Added an assertion to catch cases where we have a +non-empty tiled layer that contains 0 tiles, which would cause the crash in this bug report. + 2011-08-04 Stephen White Set graphics context current before canvas.toDataURL(). Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp (92388 => 92389) --- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2011-08-04 18:00:41 UTC (rev 92388) +++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2011-08-04 18:11:22 UTC (rev 92389) @@ -350,13 +350,14 @@
[webkit-changes] [92388] trunk/Source/WebCore
Title: [92388] trunk/Source/WebCore
Revision 92388
Author senorbla...@chromium.org
Date 2011-08-04 11:00:41 -0700 (Thu, 04 Aug 2011)
Log Message
Set graphics context current before canvas.toDataURL().
https://bugs.webkit.org/show_bug.cgi?id=65700
Reviewed by James Robinson.
No new tests, unfortunately. The test infrastucture doesn't seem
to be conducive to writing multiple-context tests.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92387 => 92388)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 17:52:20 UTC (rev 92387)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 18:00:41 UTC (rev 92388)
@@ -1,3 +1,16 @@
+2011-08-04 Stephen White
+
+Set graphics context current before canvas.toDataURL().
+https://bugs.webkit.org/show_bug.cgi?id=65700
+
+Reviewed by James Robinson.
+
+No new tests, unfortunately. The test infrastucture doesn't seem
+to be conducive to writing multiple-context tests.
+
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::toDataURL):
+
2011-08-01 Brian Weinstein
WebKit2: Web Inspector always starts in undocked mode
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (92387 => 92388)
--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-04 17:52:20 UTC (rev 92387)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-08-04 18:00:41 UTC (rev 92388)
@@ -361,20 +361,9 @@
String ImageBuffer::toDataURL(const String& mimeType, const double* quality) const
{
+m_context->platformContext()->makeGrContextCurrent();
SkDevice* device = context()->platformContext()->canvas()->getDevice();
-SkBitmap bitmap = device->accessBitmap(false);
-
-// if we can't see the pixels directly, call readPixels() to get a copy.
-// this could happen if the device is backed by a GPU.
-bitmap.lockPixels(); // balanced by our destructor, or explicitly if getPixels() fails
-if (!bitmap.getPixels()) {
-bitmap.unlockPixels();
-SkIRect bounds = SkIRect::MakeWH(device->width(), device->height());
-if (!device->readPixels(bounds, &bitmap))
-return "data:,";
-}
-
-return ImageToDataURL(bitmap, mimeType, quality);
+return ImageToDataURL(device->accessBitmap(false), mimeType, quality);
}
String ImageDataToDataURL(const ImageData& source, const String& mimeType, const double* quality)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92387] trunk/Source/ThirdParty
Title: [92387] trunk/Source/ThirdParty
Revision 92387
Author dslo...@google.com
Date 2011-08-04 10:52:20 -0700 (Thu, 04 Aug 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=61812
TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc
Disable fast malloc for offending class (::std::strstream) in gtest.
This looks like the most non-intrusive solution.
Reviewed by David Levin.
Modified Paths
trunk/Source/ThirdParty/ChangeLog
trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
Diff
Modified: trunk/Source/ThirdParty/ChangeLog (92386 => 92387)
--- trunk/Source/ThirdParty/ChangeLog 2011-08-04 17:48:40 UTC (rev 92386)
+++ trunk/Source/ThirdParty/ChangeLog 2011-08-04 17:52:20 UTC (rev 92387)
@@ -1,3 +1,19 @@
+2011-08-03 Dmitry Lomov
+
+https://bugs.webkit.org/show_bug.cgi?id=61812
+TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc
+
+Disable fast malloc for offending class (::std::strstream) in gtest.
+This looks like the most non-intrusive solution.
+
+Reviewed by David Levin.
+
+* gtest/include/gtest/internal/gtest-port.h:
+(testing::internal::StrStream::operator new):
+(testing::internal::StrStream::operator new[]):
+(testing::internal::StrStream::operator delete):
+(testing::internal::StrStream::operator delete[]):
+
2011-07-05 Adam Barth
Import qunit _javascript_ unit testing framework
Modified: trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h (92386 => 92387)
--- trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h 2011-08-04 17:48:40 UTC (rev 92386)
+++ trunk/Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h 2011-08-04 17:52:20 UTC (rev 92387)
@@ -609,8 +609,30 @@
class String;
-typedef ::std::stringstream StrStream;
+class StrStream : public ::std::stringstream {
+ public:
+ void* operator new(size_t, void* p) { return p; }
+ void* operator new[](size_t, void* p) { return p; }
+ void* operator new(size_t size) {
+return malloc(size);
+ }
+
+ void operator delete(void* p) {
+free(p);
+ }
+
+ void* operator new[](size_t size) {
+return malloc(size);
+ }
+
+ void operator delete[](void* p) {
+free(p);
+ }
+};
+
+
+
// A helper for suppressing warnings on constant condition. It just
// returns 'condition'.
GTEST_API_ bool IsTrue(bool condition);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92386] trunk/Source/JavaScriptCore
Title: [92386] trunk/Source/_javascript_Core
Revision 92386
Author fpi...@apple.com
Date 2011-08-04 10:48:40 -0700 (Thu, 04 Aug 2011)
Log Message
Eval handling attempts literal parsing even when the eval
string is in the cache
https://bugs.webkit.org/show_bug.cgi?id=65675
Reviewed by Oliver Hunt.
This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
in SunSpider. It's neutral on V8.
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (92385 => 92386)
--- trunk/Source/_javascript_Core/ChangeLog 2011-08-04 17:48:06 UTC (rev 92385)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-08-04 17:48:40 UTC (rev 92386)
@@ -1,3 +1,21 @@
+2011-08-04 Filip Pizlo
+
+Eval handling attempts literal parsing even when the eval
+string is in the cache
+https://bugs.webkit.org/show_bug.cgi?id=65675
+
+Reviewed by Oliver Hunt.
+
+This is a 25% speed-up on date-format-tofte and a 1.5% speed-up overall
+in SunSpider. It's neutral on V8.
+
+* bytecode/EvalCodeCache.h:
+(JSC::EvalCodeCache::tryGet):
+(JSC::EvalCodeCache::getSlow):
+(JSC::EvalCodeCache::get):
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::callEval):
+
2011-08-03 Mark Rowe
Bring some order to FeatureDefines.xcconfig to make it easier to follow.
Modified: trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h (92385 => 92386)
--- trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2011-08-04 17:48:06 UTC (rev 92385)
+++ trunk/Source/_javascript_Core/bytecode/EvalCodeCache.h 2011-08-04 17:48:40 UTC (rev 92386)
@@ -45,23 +45,33 @@
class EvalCodeCache {
public:
+EvalExecutable* tryGet(bool inStrictContext, const UString& evalSource, ScopeChainNode* scopeChain)
+{
+if (!inStrictContext && evalSource.length() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject())
+return m_cacheMap.get(evalSource.impl()).get();
+return 0;
+}
+
+EvalExecutable* getSlow(ExecState* exec, ScriptExecutable* owner, bool inStrictContext, const UString& evalSource, ScopeChainNode* scopeChain, JSValue& exceptionValue)
+{
+EvalExecutable* evalExecutable = EvalExecutable::create(exec, makeSource(evalSource), inStrictContext);
+exceptionValue = evalExecutable->compile(exec, scopeChain);
+if (exceptionValue)
+return 0;
+
+if (!inStrictContext && evalSource.length() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject() && m_cacheMap.size() < maxCacheEntries)
+m_cacheMap.set(evalSource.impl(), WriteBarrier(exec->globalData(), owner, evalExecutable));
+
+return evalExecutable;
+}
+
EvalExecutable* get(ExecState* exec, ScriptExecutable* owner, bool inStrictContext, const UString& evalSource, ScopeChainNode* scopeChain, JSValue& exceptionValue)
{
-EvalExecutable* evalExecutable = 0;
+EvalExecutable* evalExecutable = tryGet(inStrictContext, evalSource, scopeChain);
-if (!inStrictContext && evalSource.length() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject())
-evalExecutable = m_cacheMap.get(evalSource.impl()).get();
+if (!evalExecutable)
+evalExecutable = getSlow(exec, owner, inStrictContext, evalSource, scopeChain, exceptionValue);
-if (!evalExecutable) {
-evalExecutable = EvalExecutable::create(exec, makeSource(evalSource), inStrictContext);
-exceptionValue = evalExecutable->compile(exec, scopeChain);
-if (exceptionValue)
-return 0;
-
-if (!inStrictContext && evalSource.length() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject() && m_cacheMap.size() < maxCacheEntries)
-m_cacheMap.set(evalSource.impl(), WriteBarrier(exec->globalData(), owner, evalExecutable));
-}
-
return evalExecutable;
}
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (92385 => 92386)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-08-04 17:48:06 UTC (rev 92385)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-08-04 17:48:40 UTC (rev 92386)
@@ -437,22 +437,27 @@
return JSValue();
CodeBlock* codeBlock = callFrame->codeBlock();
-if (!codeBlock->isStrictMode()) {
-// FIXME: We can
[webkit-changes] [92385] trunk/LayoutTests
Title: [92385] trunk/LayoutTests Revision 92385 Author jia...@chromium.org Date 2011-08-04 10:48:06 -0700 (Thu, 04 Aug 2011) Log Message Unreviewed, mark gain.html as flaky on Linux chromium. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92384 => 92385) --- trunk/LayoutTests/ChangeLog 2011-08-04 17:45:31 UTC (rev 92384) +++ trunk/LayoutTests/ChangeLog 2011-08-04 17:48:06 UTC (rev 92385) @@ -1,3 +1,9 @@ +2011-08-04 Jian Li + +Unreviewed, mark gain.html as flaky on Linux chromium. + +* platform/chromium/test_expectations.txt: + 2011-08-04 Philippe Normand Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92384 => 92385) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 17:45:31 UTC (rev 92384) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 17:48:06 UTC (rev 92385) @@ -3667,7 +3667,7 @@ BUGWK65199 : fast/blockflow/broken-ideograph-small-caps.html = PASS FAIL BUGWK65219 WIN : webaudio/test-basic.html = PASS CRASH -BUGWK65219 WIN : webaudio/gain.html = PASS CRASH +BUGWK65219 WIN LINUX : webaudio/gain.html = PASS CRASH BUGWK65219 WIN : webaudio/audionode.html = PASS CRASH // Needs new baseline for slight pixel value changes due to changes in ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92384] trunk/Source
Title: [92384] trunk/Source Revision 92384 Author bweinst...@apple.com Date 2011-08-04 10:45:31 -0700 (Thu, 04 Aug 2011) Log Message Source/WebCore: WebKit2: Web Inspector always starts in undocked mode https://bugs.webkit.org/show_bug.cgi?id=65493 Reviewed by Adam Roben. Expose some methods on InspectorFrontendClient through the InspectorController so WebKit2 can request the inspector be docked, or ask whether or not it can be docked. * WebCore.exp.in: Export needed methods. * inspector/InspectorController.cpp: (WebCore::InspectorController::requestAttachWindow): Call through to InspectorFrontendClient. (WebCore::InspectorController::canAttachWindow): Ditto. * inspector/InspectorController.h: * inspector/InspectorFrontendClient.h: * inspector/InspectorFrontendClientLocal.h: Source/WebKit/chromium: WebKit2: Web Inspector always starts in undocked mode https://bugs.webkit.org/show_bug.cgi?id=65493 Reviewed by Adam Roben. Add a stub method for Chromium. * src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::canAttachWindow): * src/InspectorFrontendClientImpl.h: Source/WebKit2: WebKit2: Web Inspector always starts in undocked mode https://bugs.webkit.org/show_bug.cgi?id=65493 Reviewed by Adam Roben. When opening the inspector, the web process tells the UI process that the inspector page has loaded, but now will pass another bit of data, whether the inspector can start attached, so the UI process doesn't need to ask the web process to do another calculation on whether or not it can be attached. If the user prefers the inspector to start docked (this defaults to true), and there is room for the window, we send a message to the web process to try and attach the inspector. This makes sure that the inspector knows it is docked (in the web process). * UIProcess/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::attach): Update the user's docked/undocked preference if the inspector is visible when it was attached. (WebKit::WebInspectorProxy::detach): Ditto (but when it was detached). (WebKit::WebInspectorProxy::didLoadInspectorPage): If we can start docked, and the user prefers to start docked, then request the inspector be attached to the window. * UIProcess/WebInspectorProxy.h: * UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformOpen): Only show the window if we are going to start undocked. * UIProcess/win/WebInspectorProxyWin.cpp: (WebKit::WebInspectorProxy::platformOpen): Ditto. * WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::didLoadInspectorPage): Pass whether or not we can attach the window. (WebKit::WebInspector::requestAttachWindow): Call through to the InspectorController to attach the inspector. (WebKit::WebInspector::canAttachWindow): Ask the InspectorController if we can attach the inspector. * WebProcess/WebPage/WebInspector.h: * Shared/WebPreferencesStore.h: Add a new preference for whether or not the inspector should start attached. * UIProcess/WebInspectorProxy.messages.in: When the inspector page is loaded, tell the UI Process whether we can attach the inspector without needing another message. * WebProcess/WebPage/WebInspector.messages.in: Add a new message for RequestAttachWindow Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorController.h trunk/Source/WebCore/inspector/InspectorFrontendClient.h trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesStore.h trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h trunk/Source/WebKit2/UIProcess/WebInspectorProxy.messages.in trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm trunk/Source/WebKit2/UIProcess/qt/WebInspectorProxyQt.cpp trunk/Source/WebKit2/UIProcess/win/WebInspectorProxyWin.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.messages.in Diff Modified: trunk/Source/WebCore/ChangeLog (92383 => 92384) --- trunk/Source/WebCore/ChangeLog 2011-08-04 17:25:02 UTC (rev 92383) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 17:45:31 UTC (rev 92384) @@ -1,3 +1,22 @@ +2011-08-01 Brian Weinstein + +WebKit2: Web Inspector always starts in undocked mode +https://bugs.webkit.org/show_bug.cgi?id=65493 + + +Reviewed by Adam Roben. + +Expose some methods on InspectorFrontendClient through the InspectorController so WebKit2 +can request the inspector be docked, or ask whether or not it c
[webkit-changes] [92383] trunk/LayoutTests
Title: [92383] trunk/LayoutTests Revision 92383 Author ph...@webkit.org Date 2011-08-04 10:25:02 -0700 (Thu, 04 Aug 2011) Log Message Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92382 => 92383) --- trunk/LayoutTests/ChangeLog 2011-08-04 16:51:48 UTC (rev 92382) +++ trunk/LayoutTests/ChangeLog 2011-08-04 17:25:02 UTC (rev 92383) @@ -1,5 +1,11 @@ 2011-08-04 Philippe Normand +Unreviewed, skip 2 crashing tests on GTK. See bug 65699 and 65702. + +* platform/gtk/Skipped: + +2011-08-04 Philippe Normand + Unreviewed, skip some svg tests on GTK, likely affected by bug 39022. * platform/gtk/Skipped: Modified: trunk/LayoutTests/platform/gtk/Skipped (92382 => 92383) --- trunk/LayoutTests/platform/gtk/Skipped 2011-08-04 16:51:48 UTC (rev 92382) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-08-04 17:25:02 UTC (rev 92383) @@ -255,6 +255,12 @@ # https://bugs.webkit.org/show_bug.cgi?id=64530 editing/selection/editable-html-element.html +# https://bugs.webkit.org/show_bug.cgi?id=65699 +fast/loader/reload-zero-byte-plugin.html + +# https://bugs.webkit.org/show_bug.cgi?id=65702 +editing/undo/replace-text-in-node-preserving-markers-crash.html + ### # EXPECTED FAILURES ### ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92382] trunk/Tools
Title: [92382] trunk/Tools
Revision 92382
Author aba...@webkit.org
Date 2011-08-04 09:51:48 -0700 (Thu, 04 Aug 2011)
Log Message
builders.js needs unit tests
https://bugs.webkit.org/show_bug.cgi?id=65670
Reviewed by Dimitri Glazkov.
This test requires somewhat large test fixtures, but using real
examples seemed better than trimming them down too much.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
- Note: trac_unittests.js doesn't exist (yet!).
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js (92381 => 92382)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js 2011-08-04 16:41:23 UTC (rev 92381)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js 2011-08-04 16:51:48 UTC (rev 92382)
@@ -61,6 +61,20 @@
return buildInfo.steps.filter(isStepRequredForTestCoverage).filter(didFail).length > 0;
}
+function mostRecentCompletedBuildNumber(individualBuilderStatus)
+{
+if (!individualBuilderStatus)
+return null;
+
+for (var i = individualBuilderStatus.cachedBuilds.length - 1; i >= 0; --i) {
+var buildNumber = individualBuilderStatus.cachedBuilds[i];
+if (individualBuilderStatus.currentBuilds.indexOf(buildNumber) == -1)
+return buildNumber;
+}
+
+return null;
+}
+
var g_buildInfoCache = new base.AsynchronousCache(function(key, callback) {
var explodedKey = key.split('\n');
net.get(urlForBuildInfo(explodedKey[0], explodedKey[1]), callback);
@@ -72,7 +86,12 @@
var requestTracker = new base.RequestTracker(config.kBuilders.length, callback, [buildInfoByBuilder]);
net.get(kChromiumBuildBotURL + '/json/builders', function(builderStatus) {
$.each(config.kBuilders, function(index, builderName) {
-var buildNumber = builderStatus[builderName].cachedBuilds.pop();
+var buildNumber = mostRecentCompletedBuildNumber(builderStatus[builderName]);
+if (!buildNumber) {
+buildInfoByBuilder[builderName] = null;
+requestTracker.requestComplete();
+return;
+}
g_buildInfoCache.get(builderName + '\n' + buildNumber, function(buildInfo) {
buildInfoByBuilder[builderName] = buildInfo;
@@ -87,6 +106,8 @@
fetchMostRecentBuildInfoByBuilder(function(buildInfoByBuilder) {
var builderNameList = [];
$.each(buildInfoByBuilder, function(builderName, buildInfo) {
+if (!buildInfo)
+return;
if (didFailStepRequredForTestCoverage(buildInfo))
builderNameList.push(builderName);
});
Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js (0 => 92382)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js (rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js 2011-08-04 16:51:48 UTC (rev 92382)
@@ -0,0 +1,350 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISI
[webkit-changes] [92381] trunk/LayoutTests
Title: [92381] trunk/LayoutTests Revision 92381 Author ph...@webkit.org Date 2011-08-04 09:41:23 -0700 (Thu, 04 Aug 2011) Log Message Unreviewed, skip some svg tests on GTK, likely affected by bug 39022. * platform/gtk/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92380 => 92381) --- trunk/LayoutTests/ChangeLog 2011-08-04 16:33:05 UTC (rev 92380) +++ trunk/LayoutTests/ChangeLog 2011-08-04 16:41:23 UTC (rev 92381) @@ -1,5 +1,11 @@ 2011-08-04 Philippe Normand +Unreviewed, skip some svg tests on GTK, likely affected by bug 39022. + +* platform/gtk/Skipped: + +2011-08-04 Philippe Normand + Unreviewed, GTK rebaseline and test_expectations update (2 tests now passing). Modified: trunk/LayoutTests/platform/gtk/Skipped (92380 => 92381) --- trunk/LayoutTests/platform/gtk/Skipped 2011-08-04 16:33:05 UTC (rev 92380) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-08-04 16:41:23 UTC (rev 92381) @@ -978,6 +978,13 @@ # Different results on 32-bit and 64-bit bots because of signed zero values # https://bugs.webkit.org/show_bug.cgi?id=62003 svg/custom/embedding-external-svgs.xhtml +svg/W3C-SVG-1.1-SE/linking-uri-01-b.svg +svg/W3C-SVG-1.1-SE/struct-dom-11-f.svg +svg/W3C-SVG-1.1-SE/struct-use-11-f.svg +svg/animations/svginteger-animation-1.html +svg/custom/linking-uri-01-b.svg +svg/custom/svg-fonts-word-spacing.html +svg/custom/animation-currentColor.svg # https://bugs.webkit.org/show_bug.cgi?id=57346 fast/text/justify-ideograph-leading-expansion.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92380] trunk/LayoutTests
Title: [92380] trunk/LayoutTests
Revision 92380
Author ph...@webkit.org
Date 2011-08-04 09:33:05 -0700 (Thu, 04 Aug 2011)
Log Message
Unreviewed, GTK rebaseline and test_expectations update (2 tests
now passing).
* platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
* platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/gtk/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt
trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt
trunk/LayoutTests/platform/gtk/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (92379 => 92380)
--- trunk/LayoutTests/ChangeLog 2011-08-04 16:22:56 UTC (rev 92379)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 16:33:05 UTC (rev 92380)
@@ -1,3 +1,12 @@
+2011-08-04 Philippe Normand
+
+Unreviewed, GTK rebaseline and test_expectations update (2 tests
+now passing).
+
+* platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt:
+* platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
+* platform/gtk/test_expectations.txt:
+
2011-08-04 Dimitri Glazkov
[Chromium] Normalize test_expectations.txt file.
Modified: trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt (92379 => 92380)
--- trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt 2011-08-04 16:22:56 UTC (rev 92379)
+++ trunk/LayoutTests/platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt 2011-08-04 16:33:05 UTC (rev 92380)
@@ -6,26 +6,26 @@
RenderBlock {DIV} at (0,0) size 784x19
RenderText {#text} at (0,0) size 510x19
text run at (0,0) width 510: "This tests proper handling of unicode-bidi: plaintext. You should not see any red."
-layer at (8,27) size 101x400
- RenderBlock (positioned) {DIV} at (0,0) size 101x400
-RenderBlock {DIV} at (0,0) size 101x76 [color=#FF]
+layer at (8,27) size 103x400
+ RenderBlock (positioned) {DIV} at (0,0) size 103x400
+RenderBlock {DIV} at (0,0) size 103x76 [color=#FF]
RenderText {#text} at (0,0) size 44x19
text run at (0,0) width 44: "!hello. "
RenderBR {BR} at (44,0) size 0x19
- RenderText {#text} at (0,19) size 48x19
-text run at (0,19) width 48 RTL: "!\x{5E9}\x{5DC}\x{5D5}\x{5DD}. "
+ RenderText {#text} at (0,19) size 50x19
+text run at (0,19) width 50 RTL: "!\x{5E9}\x{5DC}\x{5D5}\x{5DD}. "
RenderBR {BR} at (0,19) size 0x19
- RenderText {#text} at (0,38) size 65x19
+ RenderText {#text} at (0,38) size 66x19
text run at (0,38) width 39: "hello, "
-text run at (39,38) width 17 RTL: "\x{5DC}\x{5D5}\x{5D9}"
-text run at (56,38) width 9: "! "
- RenderBR {BR} at (65,38) size 0x19
- RenderText {#text} at (0,57) size 98x19
+text run at (39,38) width 18 RTL: "\x{5DC}\x{5D5}\x{5D9}"
+text run at (57,38) width 9: "! "
+ RenderBR {BR} at (66,38) size 0x19
+ RenderText {#text} at (0,57) size 100x19
text run at (0,57) width 5 RTL: "!"
text run at (5,57) width 50: "WebKit"
-text run at (55,57) width 43 RTL: "\x{5E9}\x{5DC}\x{5D5}\x{5DD}, "
-RenderBlock {PRE} at (0,76) size 101x75 [color=#FF]
- RenderText {#text} at (0,0) size 101x75
+text run at (55,57) width 45 RTL: "\x{5E9}\x{5DC}\x{5D5}\x{5DD}, "
+RenderBlock {PRE} at (0,76) size 103x75 [color=#FF]
+ RenderText {#text} at (0,0) size 103x75
text run at (0,0) width 8: "a"
text run at (8,0) width 0: " "
text run at (0,15) width 8: "("
@@ -33,47 +33,47 @@
text run at (0,30) width 0 RTL: " "
text run at (0,30) width 8 RTL: "!"
text run at (8,30) width 48: "WebKit"
-text run at (56,30) width 45 RTL: "\x{5E9}\x{5DC}\x{5D5}\x{5DD}, "
+text run at (56,30) width 47 RTL: "\x{5E9}\x{5DC}\x{5D5}\x{5DD}, "
text run at (0,45) width 56: "hello, "
-text run at (56,45) width 14 RTL: "\x{5DC}\x{5D5}\x{5D9}"
-text run at (70,45) width 8: "!"
-text run at (78,45) width 0: " "
+text run at (56,45) width 16 RTL: "\x{5DC}\x{5D5}\x{5D9}"
+text run at (72,45) width 8: "!"
+text run at (80,45) width 0: " "
text run at (0,60) width 8: ")"
text run at (8,60) width 0: " "
-layer at (8,27) size 101x400
- RenderBlock (positioned) {DIV} at (0,0) size 101x400 [color=#008000]
-RenderBlock (anonymous) at (0,0) size 101x76
+layer at (8,27) size 103x400
+ RenderBlock (positioned) {DIV} at (0,0) size 103x400 [color=#008000]
+RenderBlock (anonymous) at (0,0) size 103x76
RenderText {#text} at (0,0) size 40x19
text run a
[webkit-changes] [92378] trunk/Source/WebCore
Title: [92378] trunk/Source/WebCore
Revision 92378
Author macpher...@chromium.org
Date 2011-08-04 09:10:06 -0700 (Thu, 04 Aug 2011)
Log Message
Support cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
https://bugs.webkit.org/show_bug.cgi?id=65665
Reviewed by Simon Fraser.
No new tests / refactoring only.
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Support cast from EBorderFit.
(WebCore::CSSPrimitiveValue::operator EBorderFit):
Support cast to EBorderFit.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Use new cast to allow use of appropriate macro.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (92377 => 92378)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 16:09:00 UTC (rev 92377)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 16:10:06 UTC (rev 92378)
@@ -1,3 +1,21 @@
+2011-08-04 Luke Macpherson
+
+Support cast between CSSPrimitiveValue and EborderFit, use in CSSStyleSelector.
+https://bugs.webkit.org/show_bug.cgi?id=65665
+
+Reviewed by Simon Fraser.
+
+No new tests / refactoring only.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+Support cast from EBorderFit.
+(WebCore::CSSPrimitiveValue::operator EBorderFit):
+Support cast to EBorderFit.
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+Use new cast to allow use of appropriate macro.
+
2011-08-04 Pavel Feldman
Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (92377 => 92378)
--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-08-04 16:09:00 UTC (rev 92377)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h 2011-08-04 16:10:06 UTC (rev 92378)
@@ -3030,6 +3030,33 @@
}
}
+template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EBorderFit e)
+: m_type(CSS_IDENT)
+, m_hasCachedCSSText(false)
+{
+switch (e) {
+case BorderFitBorder:
+m_value.ident = CSSValueBorder;
+break;
+case BorderFitLines:
+m_value.ident = CSSValueLines;
+break;
+}
+}
+
+template<> inline CSSPrimitiveValue::operator EBorderFit() const
+{
+switch (m_value.ident) {
+case CSSValueBorder:
+return BorderFitBorder;
+case CSSValueLines:
+return BorderFitLines;
+default:
+ASSERT_NOT_REACHED();
+return BorderFitLines;
+}
+}
+
template<> inline CSSPrimitiveValue::CSSPrimitiveValue(EImageRendering e)
: m_type(CSS_IDENT)
, m_hasCachedCSSText(false)
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92377 => 92378)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-04 16:09:00 UTC (rev 92377)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-08-04 16:10:06 UTC (rev 92378)
@@ -4787,14 +4787,9 @@
m_fontDirty = true;
return;
}
-case CSSPropertyWebkitBorderFit: {
-HANDLE_INHERIT_AND_INITIAL(borderFit, BorderFit);
-if (primitiveValue->getIdent() == CSSValueBorder)
-m_style->setBorderFit(BorderFitBorder);
-else
-m_style->setBorderFit(BorderFitLines);
+case CSSPropertyWebkitBorderFit:
+HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE(borderFit, BorderFit);
return;
-}
case CSSPropertyWebkitTextSizeAdjust: {
HANDLE_INHERIT_AND_INITIAL(textSizeAdjust, TextSizeAdjust)
if (!primitiveValue || !primitiveValue->getIdent()) return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92377] trunk/Source/WebCore
Title: [92377] trunk/Source/WebCore
Revision 92377
Author pfeld...@chromium.org
Date 2011-08-04 09:09:00 -0700 (Thu, 04 Aug 2011)
Log Message
Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
https://bugs.webkit.org/show_bug.cgi?id=65687
Reviewed by Yury Semikhatsky.
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):
* inspector/InspectorRuntimeAgent.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScript.cpp
trunk/Source/WebCore/inspector/InjectedScript.h
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92376 => 92377)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 15:41:49 UTC (rev 92376)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 16:09:00 UTC (rev 92377)
@@ -1,3 +1,21 @@
+2011-08-04 Pavel Feldman
+
+Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.
+https://bugs.webkit.org/show_bug.cgi?id=65687
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/InjectedScript.cpp:
+(WebCore::InjectedScript::evaluate):
+(WebCore::InjectedScript::callFunctionOn):
+* inspector/InjectedScript.h:
+* inspector/InjectedScriptSource.js:
+* inspector/Inspector.json:
+* inspector/InspectorRuntimeAgent.cpp:
+(WebCore::InspectorRuntimeAgent::evaluate):
+(WebCore::InspectorRuntimeAgent::callFunctionOn):
+* inspector/InspectorRuntimeAgent.h:
+
2011-08-04 Matt Falkenhagen
Use -webkit-locale for font selection.
Modified: trunk/Source/WebCore/inspector/InjectedScript.cpp (92376 => 92377)
--- trunk/Source/WebCore/inspector/InjectedScript.cpp 2011-08-04 15:41:49 UTC (rev 92376)
+++ trunk/Source/WebCore/inspector/InjectedScript.cpp 2011-08-04 16:09:00 UTC (rev 92377)
@@ -54,23 +54,23 @@
{
}
-void InjectedScript::evaluate(ErrorString* errorString, const String& _expression_, const String& objectGroup, bool includeCommandLineAPI, bool sendResultByValue, RefPtr* result, bool* wasThrown)
+void InjectedScript::evaluate(ErrorString* errorString, const String& _expression_, const String& objectGroup, bool includeCommandLineAPI, bool returnByValue, RefPtr* result, bool* wasThrown)
{
ScriptFunctionCall function(m_injectedScriptObject, "evaluate");
function.appendArgument(_expression_);
function.appendArgument(objectGroup);
function.appendArgument(includeCommandLineAPI);
-function.appendArgument(sendResultByValue);
+function.appendArgument(returnByValue);
makeEvalCall(errorString, function, result, wasThrown);
}
-void InjectedScript::callFunctionOn(ErrorString* errorString, const String& objectId, const String& _expression_, const String& arguments, bool sendResultByValue, RefPtr* result, bool* wasThrown)
+void InjectedScript::callFunctionOn(ErrorString* errorString, const String& objectId, const String& _expression_, const String& arguments, bool returnByValue, RefPtr* result, bool* wasThrown)
{
ScriptFunctionCall function(m_injectedScriptObject, "callFunctionOn");
function.appendArgument(objectId);
function.appendArgument(_expression_);
function.appendArgument(arguments);
-function.appendArgument(sendResultByValue);
+function.appendArgument(returnByValue);
makeEvalCall(errorString, function, result, wasThrown);
}
Modified: trunk/Source/WebCore/inspector/InjectedScript.h (92376 => 92377)
--- trunk/Source/WebCore/inspector/InjectedScript.h 2011-08-04 15:41:49 UTC (rev 92376)
+++ trunk/Source/WebCore/inspector/InjectedScript.h 2011-08-04 16:09:00 UTC (rev 92377)
@@ -59,14 +59,14 @@
const String& _expression_,
const String& objectGroup,
bool includeCommandLineAPI,
- bool sendResultByValue,
+ bool returnByValue,
RefPtr* result,
bool* wasThrown);
void callFunctionOn(ErrorString*,
const String& objectId,
const String& _expression_,
const String& arguments,
-bool sendResultByValue,
+bool returnByValue,
RefPtr* result,
bool* wasThrown);
void evaluateOnCallFrame(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, const String& _expression_, const String& objectGroup, bool includeCommandLineAPI, RefPtr* result, bool* wasThrown);
Mod
[webkit-changes] [92376] trunk/Source/WebKit2
Title: [92376] trunk/Source/WebKit2 Revision 92376 Author jocelyn.turco...@nokia.com Date 2011-08-04 08:41:49 -0700 (Thu, 04 Aug 2011) Log Message [Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using imperative painting. https://bugs.webkit.org/show_bug.cgi?id=65528 Reviewed by Benjamin Poulain. Converts QTouchWebPage from QSGPaintedItem to a straight QSGItem. - A SGTileNode is created and added to the scene graph for each tile, positioning them relatively to the page. It's basically a QSGSimpleTextureNode with support for specifying a source rect plus for owning the QSGTexture for proper destruction on shutdown by the rendering thread. - Scale nodes are used as parent of tile nodes to revert the scaling set on the QTouchWebPage and allow us to keep using integer coordinates. - The SGAgent class is introduced to carry scene graph update request up to the updatePaintNode call of the item, which may be on the scene graph rendering thread. * UIProcess/API/qt/qtouchwebpage.cpp: (QTouchWebPage::QTouchWebPage): (QTouchWebPage::updatePaintNode): Delegate scene graph updates to the SGAgent which received update requests from the tiled drawing area. (QTouchWebPage::event): (QTouchWebPage::geometryChanged): (QTouchWebPagePrivate::QTouchWebPagePrivate): * UIProcess/API/qt/qtouchwebpage.h: * UIProcess/API/qt/qtouchwebpage_p.h: * UIProcess/TiledDrawingAreaProxy.cpp: Manage the scale node in the TileSet, it will be the parent node of Tile nodes. (WebKit::TiledDrawingAreaTileSet::sgNodeID): (WebKit::TiledDrawingAreaTileSet::TiledDrawingAreaTileSet): (WebKit::TiledDrawingAreaTileSet::~TiledDrawingAreaTileSet): (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy): (WebKit::TiledDrawingAreaProxy::setContentsScale): (WebKit::TiledDrawingAreaProxy::createTiles): (WebKit::TiledDrawingAreaProxy::removeAllTiles): * UIProcess/TiledDrawingAreaTile.h: (WebKit::TiledDrawingAreaTile::create): * UIProcess/qt/SGAgent.cpp: Added. * UIProcess/qt/SGAgent.h: Added. * UIProcess/qt/SGTileNode.cpp: Added. * UIProcess/qt/SGTileNode.h: Added. * UIProcess/qt/TiledDrawingAreaProxyQt.cpp: Disable the paint call and update the scene graph on incorporateUpdate through the SGAgent. (WebKit::TiledDrawingAreaProxy::updateWebView): * UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::~TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::paint): (WebKit::TiledDrawingAreaTile::incorporateUpdate): (WebKit::TiledDrawingAreaTile::disableUpdates): (WebKit::TiledDrawingAreaTile::setParentNodeID): * UIProcess/qt/TouchViewInterface.cpp: (WebKit::TouchViewInterface::sceneGraphAgent): (WebKit::TouchViewInterface::setViewNeedsDisplay): * UIProcess/qt/TouchViewInterface.h: * WebKit2.pro: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h trunk/Source/WebKit2/UIProcess/TiledDrawingAreaProxy.cpp trunk/Source/WebKit2/UIProcess/TiledDrawingAreaTile.h trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaProxyQt.cpp trunk/Source/WebKit2/UIProcess/qt/TiledDrawingAreaTileQt.cpp trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h trunk/Source/WebKit2/WebKit2.pro Added Paths trunk/Source/WebKit2/UIProcess/qt/SGAgent.cpp trunk/Source/WebKit2/UIProcess/qt/SGAgent.h trunk/Source/WebKit2/UIProcess/qt/SGTileNode.cpp trunk/Source/WebKit2/UIProcess/qt/SGTileNode.h Diff Modified: trunk/Source/WebKit2/ChangeLog (92375 => 92376) --- trunk/Source/WebKit2/ChangeLog 2011-08-04 15:22:05 UTC (rev 92375) +++ trunk/Source/WebKit2/ChangeLog 2011-08-04 15:41:49 UTC (rev 92376) @@ -1,3 +1,63 @@ +2011-08-02 Jocelyn Turcotte + +[Qt][WK2] Create scene graph nodes for tiles in QTouchWebView instead of using imperative painting. +https://bugs.webkit.org/show_bug.cgi?id=65528 + +Reviewed by Benjamin Poulain. + +Converts QTouchWebPage from QSGPaintedItem to a straight QSGItem. +- A SGTileNode is created and added to the scene graph for each tile, + positioning them relatively to the page. + It's basically a QSGSimpleTextureNode with support for specifying a + source rect plus for owning the QSGTexture for proper destruction on + shutdown by the rendering thread. +- Scale nodes are used as parent of tile nodes to revert the scaling set on the + QTouchWebPage and allow us to keep using integer coordinates. +- The SGAgent class is introduced to carry scene graph update request up to the + updatePaintNode call of the item, which may be on the scene graph rendering thread. + +* UIProcess/API/qt/qtouchwebpage.cpp: +(QTouchWebPage
[webkit-changes] [92375] trunk/Source/WebCore
Title: [92375] trunk/Source/WebCore Revision 92375 Author commit-qu...@webkit.org Date 2011-08-04 08:22:05 -0700 (Thu, 04 Aug 2011) Log Message Use -webkit-locale for font selection. https://bugs.webkit.org/show_bug.cgi?id=10874 Patch by Matt Falkenhagen on 2011-08-04 Reviewed by Dan Bernstein. Infer a script from -webkit-locale to use to choose a font for generic font families and the default unstyled font. The font is retrieved from per-script font settings (see bug 20797). Since these settings have not changed there should be no visible effect yet. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gyp/WebCore.gyp: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSFontSelector.cpp: Use script when getting font from Settings (WebCore::fontDataForGenericFamily): (WebCore::CSSFontSelector::getFontData): * css/CSSPropertyNames.in: Increase priority of -webkit-locale since it affects font * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForDocument): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): Set script in font based on -webkit-locale * page/Settings.cpp: (WebCore::getGenericFontFamilyForScript): Fallback to USCRIPT_COMMON * platform/graphics/FontDescription.h: Add m_script (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::script): (WebCore::FontDescription::setScript): (WebCore::FontDescription::operator==): * platform/text/LocaleToScriptMapping.h: Added. * platform/text/LocaleToScriptMappingDefault.cpp: Added. (WebCore::localeToScriptCodeForFontSelection): (WebCore::LocaleScript::if): (WebCore::LocaleScript::while): * platform/text/LocaleToScriptMappingICU.cpp: Added. (WebCore::scriptCodeForFontSelection): (WebCore::localeToScriptCodeForFontSelection): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gyp/WebCore.gyp trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSFontSelector.cpp trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/platform/graphics/FontDescription.h Added Paths trunk/Source/WebCore/platform/text/LocaleToScriptMapping.h trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp trunk/Source/WebCore/platform/text/LocaleToScriptMappingICU.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (92374 => 92375) --- trunk/Source/WebCore/CMakeLists.txt 2011-08-04 15:04:20 UTC (rev 92374) +++ trunk/Source/WebCore/CMakeLists.txt 2011-08-04 15:22:05 UTC (rev 92375) @@ -1154,6 +1154,7 @@ platform/text/BidiContext.cpp platform/text/Hyphenation.cpp platform/text/LineEnding.cpp +platform/text/LocaleToScriptMappingDefault.cpp platform/text/LocalizedDateNone.cpp platform/text/LocalizedNumberNone.cpp platform/text/QuotedPrintable.cpp Modified: trunk/Source/WebCore/ChangeLog (92374 => 92375) --- trunk/Source/WebCore/ChangeLog 2011-08-04 15:04:20 UTC (rev 92374) +++ trunk/Source/WebCore/ChangeLog 2011-08-04 15:22:05 UTC (rev 92375) @@ -1,3 +1,46 @@ +2011-08-04 Matt Falkenhagen + +Use -webkit-locale for font selection. +https://bugs.webkit.org/show_bug.cgi?id=10874 + +Reviewed by Dan Bernstein. + +Infer a script from -webkit-locale to use to choose a font for generic +font families and the default unstyled font. The font is retrieved +from per-script font settings (see bug 20797). Since these settings +have not changed there should be no visible effect yet. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.gyp/WebCore.gyp: +* WebCore.gypi: +* WebCore.pro: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* css/CSSFontSelector.cpp: Use script when getting font from Settings +(WebCore::fontDataForGenericFamily): +(WebCore::CSSFontSelector::getFontData): +* css/CSSPropertyNames.in: Increase priority of -webkit-locale since it affects font +* css/CSSStyleSelector.cpp: +(WebCore::CSSStyleSelector::styleForDocument): +(WebCore::CSSStyleSelector::applyDeclarations): +(WebCore::CSSStyleSelector::applyProperty): Set script in font based on -webkit-locale +* page/Settings.cpp: +(WebCore::getGenericFontFamilyForScript): Fallback to USCRIPT_COMMON +* platform/graphics/FontDescription.h: Add m_script +(WebCore::FontDescription::FontDescription): +(WebCore::FontDescription::script): +(WebCore::FontDescription::setScript): +(WebCore::FontDescription::operator==): +* platform/text/LocaleToScriptM
[webkit-changes] [92373] trunk
Title: [92373] trunk Revision 92373 Author alexis.men...@openbossa.org Date 2011-08-04 07:57:04 -0700 (Thu, 04 Aug 2011) Log Message [Qt] Make navigation actions properly usable in QML. https://bugs.webkit.org/show_bug.cgi?id=65624 Source/WebKit2: Add a new class that is exposed in QML to control the navigation like reload/stop/back/forward. Enums are not very QML friendly, it not possible to use enums that are not declared in the same class than the object exposed in QML, therefore it makes hard the sharing between the desktop and the touch views. In addition namespaced enums are even harder to support in QML. QWebNavigationController is not really meant to be used in C++ but it is exported for convenience reason (tests and MiniBrowser) so its API is not meant to be public but exposed in QML through properties and convenience slots. The QML code to use the navigation action in QML will look like "desktopView.navigation.reload();" or "if (desktopView.navigation.reloadAction.enabled) ...". Reviewed by Benjamin Poulain. * UIProcess/API/qt/WKView.h: To get the forward header generated * UIProcess/API/qt/qdesktopwebview.cpp: (QDesktopWebViewPrivate::QDesktopWebViewPrivate): (QDesktopWebView::navigationController): * UIProcess/API/qt/qdesktopwebview.h: * UIProcess/API/qt/qdesktopwebview_p.h: * UIProcess/API/qt/qmlplugin/plugin.cpp: (WebKit2QmlPlugin::registerTypes): * UIProcess/API/qt/qtouchwebpage.cpp: (QTouchWebPage::navigationController): (QTouchWebPagePrivate::QTouchWebPagePrivate): * UIProcess/API/qt/qtouchwebpage.h: * UIProcess/API/qt/qtouchwebpage_p.h: * UIProcess/API/qt/qwebnavigationcontroller.cpp: Added. (QWebNavigationControllerPrivate::QWebNavigationControllerPrivate): (QWebNavigationController::QWebNavigationController): (QWebNavigationController::~QWebNavigationController): (QWebNavigationController::backAction): (QWebNavigationController::forwardAction): (QWebNavigationController::stopAction): (QWebNavigationController::reloadAction): (QWebNavigationController::navigationAction): (QWebNavigationController::back): (QWebNavigationController::forward): (QWebNavigationController::stop): (QWebNavigationController::reload): * UIProcess/API/qt/qwebnavigationcontroller.h: Added. * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: (WebViewAbstraction::triggerNavigationAction): * UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: (tst_QDesktopWebView::navigationActionsStatusAtStartup): (LoadStartedCatcher::onLoadStarted): (tst_QDesktopWebView::stopActionEnabledAfterLoadStarted): * UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: (tst_QTouchWebView::navigationActionsStatusAtStartup): * WebKit2API.pri: Tools: Fix compilation after the introduction of QWebNavigationController. Reviewed by Benjamin Poulain. * MiniBrowser/qt/BrowserView.cpp: (BrowserView::navigationAction): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/WKView.h trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h trunk/Source/WebKit2/UIProcess/API/qt/qmlplugin/plugin.cpp trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h trunk/Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp trunk/Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp trunk/Source/WebKit2/UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp trunk/Source/WebKit2/WebKit2API.pri trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/BrowserView.cpp Added Paths trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.cpp trunk/Source/WebKit2/UIProcess/API/qt/qwebnavigationcontroller.h Diff Modified: trunk/Source/WebKit2/ChangeLog (92372 => 92373) --- trunk/Source/WebKit2/ChangeLog 2011-08-04 14:39:16 UTC (rev 92372) +++ trunk/Source/WebKit2/ChangeLog 2011-08-04 14:57:04 UTC (rev 92373) @@ -1,3 +1,59 @@ +2011-08-04 Alexis Menard + +[Qt] Make navigation actions properly usable in QML. +https://bugs.webkit.org/show_bug.cgi?id=65624 + +Add a new class that is exposed in QML to control the navigation +like reload/stop/back/forward. Enums are not very QML friendly, +it not possible to use enums that are not declared in the same class +than the object exposed in QML, therefore it makes hard the sharing +between the desktop and the touch views. In addition namespaced enums are +even harder to support in QML. QWebNavigationController is +not really meant to be used in C++ but it is exported for convenience +reason (tests and MiniBrowser) so its API is not meant to be public but +exposed in QML through properties and convenience slots. The QML code to use +the navigation action in QML will look like "deskto
[webkit-changes] [92372] trunk
Title: [92372] trunk
Revision 92372
Author vse...@chromium.org
Date 2011-08-04 07:39:16 -0700 (Thu, 04 Aug 2011)
Log Message
Web Inspector: Pretty print JSONP in network panel preview tab.
https://bugs.webkit.org/show_bug.cgi?id=65559
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/network/network-preview-json.html
* inspector/front-end/ResourceJSONView.js:
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
(WebInspector.ResourceJSONView.parseJSON.WebInspector.ParsedJSON):
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype._createPreviewView):
LayoutTests:
* http/tests/inspector/network/network-preview-json-expected.txt: Added.
* http/tests/inspector/network/network-preview-json.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourceJSONView.js
trunk/Source/WebCore/inspector/front-end/ResourcePreviewView.js
Added Paths
trunk/LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-preview-json.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92371 => 92372)
--- trunk/LayoutTests/ChangeLog 2011-08-04 13:54:18 UTC (rev 92371)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 14:39:16 UTC (rev 92372)
@@ -1,3 +1,13 @@
+2011-08-04 Vsevolod Vlasov
+
+Web Inspector: Pretty print JSONP in network panel preview tab.
+https://bugs.webkit.org/show_bug.cgi?id=65559
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network/network-preview-json-expected.txt: Added.
+* http/tests/inspector/network/network-preview-json.html: Added.
+
2011-08-04 Pavel Feldman
Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
Added: trunk/LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt (0 => 92372)
--- trunk/LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt 2011-08-04 14:39:16 UTC (rev 92372)
@@ -0,0 +1,3 @@
+Tests ResourceJSONView ability to parse JSON passed in XHR, JSONP
+
+Bug 65559
Property changes on: trunk/LayoutTests/http/tests/inspector/network/network-preview-json-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/network/network-preview-json.html (0 => 92372)
--- trunk/LayoutTests/http/tests/inspector/network/network-preview-json.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/network-preview-json.html 2011-08-04 14:39:16 UTC (rev 92372)
@@ -0,0 +1,54 @@
+
+
+
+
+function test()
+{
+var testData;
+
+testData = "while(1);";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSON(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "{\"name\": \"value\"";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSON(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "{\"name\": \"value\"}";
+var parsedJSON = WebInspector.ResourceJSONView.parseJSON(testData);
+InspectorTest.assertEquals(parsedJSON.prefix, "");
+InspectorTest.assertEquals(parsedJSON.data.name, "value");
+InspectorTest.assertEquals(parsedJSON.suffix, "");
+
+testData = "while(1); {\"name\": \"value\"}";
+parsedJSON = WebInspector.ResourceJSONView.parseJSON(testData);
+InspectorTest.assertEquals(parsedJSON.prefix, "while(1); ");
+InspectorTest.assertEquals(parsedJSON.data.name, "value");
+InspectorTest.assertEquals(parsedJSON.suffix, "");
+
+testData = "func({)";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSONP(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "func){(";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSONP(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "func({\"name\": \"value\"}";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSONP(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "func{\"name\": \"value\"})";
+InspectorTest.assertTrue(!WebInspector.ResourceJSONView.parseJSONP(testData), "Should not be able to parse \"" + testData + "\".");
+
+testData = "func({\"name\": \"value\"})";
+var parsedJSONP = WebInspector.ResourceJSONView.parseJSONP(testData);
+InspectorTest.assertEquals(parsedJSONP.prefix, "func(");
+InspectorTest.assertEquals(parsedJSONP.data.name, "value");
+InspectorTest.assertEquals(parsedJSONP.suffix, ")");
+
+InspectorTest.completeTest();
+}
+
+
+
+Tests ResourceJSONView
[webkit-changes] [92371] trunk
Title: [92371] trunk
Revision 92371
Author pfeld...@chromium.org
Date 2011-08-04 06:54:18 -0700 (Thu, 04 Aug 2011)
Log Message
Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
https://bugs.webkit.org/show_bug.cgi?id=65684
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
LayoutTests:
* inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
* inspector/debugger/debugger-set-breakpoint-regex.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex-expected.txt
trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
Diff
Modified: trunk/LayoutTests/ChangeLog (92370 => 92371)
--- trunk/LayoutTests/ChangeLog 2011-08-04 13:42:54 UTC (rev 92370)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 13:54:18 UTC (rev 92371)
@@ -1,5 +1,15 @@
2011-08-04 Pavel Feldman
+Web Inspector: replace isRegex with urlRegex in setBreakpointByUrl
+https://bugs.webkit.org/show_bug.cgi?id=65684
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/debugger-set-breakpoint-regex-expected.txt:
+* inspector/debugger/debugger-set-breakpoint-regex.html:
+
+2011-08-04 Pavel Feldman
+
Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
https://bugs.webkit.org/show_bug.cgi?id=65682
Modified: trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex-expected.txt (92370 => 92371)
--- trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex-expected.txt 2011-08-04 13:42:54 UTC (rev 92370)
+++ trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex-expected.txt 2011-08-04 13:54:18 UTC (rev 92371)
@@ -1,6 +1,20 @@
Tests Debugger.setBreakpointByUrl with isRegex set to true.
Debugger was enabled.
+
+Running: testSetNoneOfURLAndRegex
+{
+code : -32000
+message : "Either url or urlRegex must be specified."
+}
+
+Running: testSetBothURLAndRegex
+{
+code : -32000
+message : "Either url or urlRegex must be specified."
+}
+
+Running: testSetByRegex
Set timer for test function.
Script execution paused.
Call stack:
Modified: trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex.html (92370 => 92371)
--- trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex.html 2011-08-04 13:42:54 UTC (rev 92370)
+++ trunk/LayoutTests/inspector/debugger/debugger-set-breakpoint-regex.html 2011-08-04 13:54:18 UTC (rev 92371)
@@ -15,26 +15,53 @@
function test()
{
-InspectorTest.startDebuggerTest(step1);
+InspectorTest.runDebuggerTestSuite([
+function testSetNoneOfURLAndRegex(next)
+{
+var url = ""
+var urlRegex = "debugger-set-breakpoint.*";
+DebuggerAgent.setBreakpointByUrl(undefined, undefined, 1, step2);
-function step1()
-{
-var columnNumber = undefined;
-var condition = undefined;
-var isRegex = true;
-DebuggerAgent.setBreakpointByUrl("debugger-set-breakpoint.*", 8, columnNumber, condition, isRegex, step2);
-}
+function step2(result)
+{
+InspectorTest.dump(result);
+next();
+}
+},
-function step2()
-{
-InspectorTest.runTestFunctionAndWaitUntilPaused(step3);
-}
+function testSetBothURLAndRegex(next)
+{
+var url = ""
+var urlRegex = "debugger-set-breakpoint.*";
+DebuggerAgent.setBreakpointByUrl(url, urlRegex, 1, step2);
-function step3(callFrames)
-{
-InspectorTest.captureStackTrace(callFrames);
-InspectorTest.completeDebuggerTest();
-}
+function step2(result)
+{
+InspectorTest.dump(result);
+next();
+}
+},
+
+function testSetByRegex(next)
+{
+var url = ""
+var urlRegex = "debugger-set-breakpoint.*";
+var columnNumber = undefined;
+var condition = undefined;
+DebuggerAgent.setBreakpointByUrl(url, urlRegex, 8, columnNumber, condition, step2);
+
+function step2(result)
+{
+InspectorTest.runTestFunctionAndWaitUntilPaused(step3);
+}
+
+function step3(callFrames)
+{
+InspectorTest.captureStackTrace(callFrames);
+next();
+}
+}
[webkit-changes] [92370] trunk/Source/WebCore
Title: [92370] trunk/Source/WebCore
Revision 92370
Author ph...@webkit.org
Date 2011-08-04 06:42:54 -0700 (Thu, 04 Aug 2011)
Log Message
[GTK] fullscreen/video-controls-override.html fails
https://bugs.webkit.org/show_bug.cgi?id=65618
Reviewed by Martin Robinson.
Implement extraFullScreenStyleSheet() and provide the QuickTime
stylesheet for now, later we might want our own stylesheet.
* GNUmakefile.am:
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::extraFullScreenStyleSheet):
* platform/gtk/RenderThemeGtk.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (92369 => 92370)
--- trunk/Source/WebCore/ChangeLog 2011-08-04 13:07:29 UTC (rev 92369)
+++ trunk/Source/WebCore/ChangeLog 2011-08-04 13:42:54 UTC (rev 92370)
@@ -1,3 +1,18 @@
+2011-08-03 Philippe Normand
+
+[GTK] fullscreen/video-controls-override.html fails
+https://bugs.webkit.org/show_bug.cgi?id=65618
+
+Reviewed by Martin Robinson.
+
+Implement extraFullScreenStyleSheet() and provide the QuickTime
+stylesheet for now, later we might want our own stylesheet.
+
+* GNUmakefile.am:
+* platform/gtk/RenderThemeGtk.cpp:
+(WebCore::RenderThemeGtk::extraFullScreenStyleSheet):
+* platform/gtk/RenderThemeGtk.h:
+
2011-08-04 Pavel Feldman
Web Inspector: Rename sourceId -> scriptId in the protocol and the source code.
Modified: trunk/Source/WebCore/GNUmakefile.am (92369 => 92370)
--- trunk/Source/WebCore/GNUmakefile.am 2011-08-04 13:07:29 UTC (rev 92369)
+++ trunk/Source/WebCore/GNUmakefile.am 2011-08-04 13:42:54 UTC (rev 92370)
@@ -674,7 +674,8 @@
$(WebCore)/css/svg.css \
$(WebCore)/css/mediaControls.css \
$(WebCore)/css/mediaControlsGtk.css \
- $(WebCore)/css/fullscreen.css
+ $(WebCore)/css/fullscreen.css \
+ $(WebCore)/css/fullscreenQuickTime.css
# new-style _javascript_ bindings
SCRIPTS_BINDINGS = \
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp (92369 => 92370)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2011-08-04 13:07:29 UTC (rev 92369)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.cpp 2011-08-04 13:42:54 UTC (rev 92370)
@@ -478,6 +478,13 @@
return String(mediaControlsGtkUserAgentStyleSheet, sizeof(mediaControlsGtkUserAgentStyleSheet));
}
+#if ENABLE(FULLSCREEN_API)
+String RenderThemeGtk::extraFullScreenStyleSheet()
+{
+return String(fullscreenQuickTimeUserAgentStyleSheet, sizeof(fullscreenQuickTimeUserAgentStyleSheet));
+}
+#endif
+
void RenderThemeGtk::adjustMediaSliderThumbSize(RenderStyle* style) const
{
ASSERT(style->appearance() == MediaSliderThumbPart);
Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h (92369 => 92370)
--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2011-08-04 13:07:29 UTC (rev 92369)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h 2011-08-04 13:42:54 UTC (rev 92370)
@@ -87,6 +87,10 @@
virtual String formatMediaControlsCurrentTime(float currentTime, float duration) const;
#endif
+#if ENABLE(FULLSCREEN_API)
+virtual String extraFullScreenStyleSheet();
+#endif
+
#ifdef GTK_API_VERSION_2
GtkWidget* gtkContainer() const;
GtkWidget* gtkEntry() const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92367] trunk/LayoutTests
Title: [92367] trunk/LayoutTests Revision 92367 Author ham...@chromium.org Date 2011-08-04 04:24:36 -0700 (Thu, 04 Aug 2011) Log Message [Chromium] Needs eventSender.scalePageBy() https://bugs.webkit.org/show_bug.cgi?id=58013 Unreviewed chromium test_expectations.txt update * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92366 => 92367) --- trunk/LayoutTests/ChangeLog 2011-08-04 11:04:14 UTC (rev 92366) +++ trunk/LayoutTests/ChangeLog 2011-08-04 11:24:36 UTC (rev 92367) @@ -1,3 +1,12 @@ +2011-08-04 Shinichiro Hamaji + +[Chromium] Needs eventSender.scalePageBy() +https://bugs.webkit.org/show_bug.cgi?id=58013 + +Unreviewed chromium test_expectations.txt update + +* platform/chromium/test_expectations.txt: + 2011-08-02 Hans Wennborg IndexedDB: Fix index data invalidation bugs. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92366 => 92367) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 11:04:14 UTC (rev 92366) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 11:24:36 UTC (rev 92367) @@ -3687,3 +3687,7 @@ BUGZMO SKIP : fast/loader/reload-zero-byte-plugin.html = FAIL BUGWK65666 WIN LINUX : fast/box-shadow/box-shadow-clipped-slices.html = IMAGE + +// This test fails with GPU +BUGWK58013 MAC GPU : compositing/scaling/tiled-layer-recursion.html = CRASH +BUGWK58013 LINUX GPU : compositing/scaling/tiled-layer-recursion.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92366] branches/chromium/835/Source/WebCore/inspector/front-end/ DetailedHeapshotView.js
Title: [92366] branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
Revision 92366
Author vse...@chromium.org
Date 2011-08-04 04:04:14 -0700 (Thu, 04 Aug 2011)
Log Message
Merge 91829 - Web Inspector: [Chromium] REGRESSION: Uncaught TypeError: Cannot read property 'isTracingToWindowObjects' of undefined
https://bugs.webkit.org/show_bug.cgi?id=65213
Reviewed by Pavel Feldman.
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotRetainingPathsList.prototype.refresh):
TBR=mnaga...@chromium.org
BUG=91535
Review URL: http://codereview.chromium.org/7575008
Modified Paths
branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
Diff
Modified: branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (92365 => 92366)
--- branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2011-08-04 10:07:10 UTC (rev 92365)
+++ branches/chromium/835/Source/WebCore/inspector/front-end/DetailedHeapshotView.js 2011-08-04 11:04:14 UTC (rev 92366)
@@ -451,7 +451,8 @@
refresh: function()
{
-this._resetPaths();
+if (this.snapshotView)
+this._resetPaths();
},
reset: function()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92364] trunk
Title: [92364] trunk
Revision 92364
Author h...@chromium.org
Date 2011-08-04 02:32:25 -0700 (Thu, 04 Aug 2011)
Log Message
IndexedDB: Fix index data invalidation bugs.
https://bugs.webkit.org/show_bug.cgi?id=65547
Reviewed by Tony Chang.
Source/WebCore:
The function that checks whether a key exists in an index failed
to check whether that key was still valid or not.
Deleting a record from an object store must also delete its exists
entry, thus invalidating index keys pointing to that record.
Test: storage/indexeddb/index-unique.html
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::deleteObjectStoreRecord):
(WebCore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::CursorOptions::IndexKeyCursorImpl::loadCurrentRow):
LayoutTests:
Add layout test to verify that update object store data causes old
index data to be invalidated.
* storage/indexeddb/index-unique.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/objectstore-basics-expected.txt
trunk/LayoutTests/storage/indexeddb/objectstore-basics.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt
trunk/LayoutTests/storage/indexeddb/index-unique.html
Diff
Modified: trunk/LayoutTests/ChangeLog (92363 => 92364)
--- trunk/LayoutTests/ChangeLog 2011-08-04 09:10:31 UTC (rev 92363)
+++ trunk/LayoutTests/ChangeLog 2011-08-04 09:32:25 UTC (rev 92364)
@@ -1,3 +1,15 @@
+2011-08-02 Hans Wennborg
+
+IndexedDB: Fix index data invalidation bugs.
+https://bugs.webkit.org/show_bug.cgi?id=65547
+
+Reviewed by Tony Chang.
+
+Add layout test to verify that update object store data causes old
+index data to be invalidated.
+
+* storage/indexeddb/index-unique.html: Added.
+
2011-08-04 Shinichiro Hamaji
Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing
Added: trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt (0 => 92364)
--- trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt 2011-08-04 09:32:25 UTC (rev 92364)
@@ -0,0 +1,40 @@
+Test features of IndexedDB's unique indices.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+webkitIndexedDB.open('index-unique')
+db = event.target.result
+db.setVersion('new version')
+deleteExisting():
+trans = event.target.result
+PASS trans !== null is true
+Deleted all object stores.
+db.createObjectStore('store')
+store.createIndex('index', 'x', {unique: true})
+setVersionCompleted():
+transaction = db.transaction([], webkitIDBTransaction.READ_WRITE)
+transaction.objectStore('store').put({x: 1}, 'foo')
+addMoreData():
+transaction.objectStore('store').put({x: 1}, 'bar')
+addMoreDataFailed():
+event.preventDefault()
+PASS event.target.errorCode is webkitIDBDatabaseException.CONSTRAINT_ERR
+transaction.objectStore('store').put({x: 0}, 'foo')
+changeDataSuccess():
+transaction.objectStore('store').index('index').openCursor(webkitIDBKeyRange.lowerBound(1))
+cursorSuccess():
+PASS event.target.result is null
+transaction.objectStore('store').index('index').openKeyCursor(webkitIDBKeyRange.lowerBound(1))
+keyCursorSuccess():
+PASS event.target.result is null
+transaction.objectStore('store').put({x: 1}, 'bar')
+addMoreDataSucces():
+transaction.objectStore('store').delete('bar')
+deleteSuccess():
+transaction.objectStore('store').put({x: 1}, 'baz')
+finalAddSuccess():
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/storage/indexeddb/index-unique-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/storage/indexeddb/index-unique.html (0 => 92364)
--- trunk/LayoutTests/storage/indexeddb/index-unique.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/index-unique.html 2011-08-04 09:32:25 UTC (rev 92364)
@@ -0,0 +1,147 @@
+
+
+
+
+
+
+
+
+description("Test features of IndexedDB's unique indices.");
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function test()
+{
+request = evalAndLog("webkitIndexedDB.open('index-unique')");
+request._onsuccess_ = setVersion;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function setVersion()
+{
+db = evalAndLog("db = event.target.result");
+
+request = evalAndLog("db.setVersion('new version')");
+request._onsuccess_ = deleteExisting;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function deleteExisting()
+{
+debug("deleteExisting():");
+var trans = evalAndLog("trans = event.target.result");
+shouldBeTrue(
[webkit-changes] [92362] trunk/LayoutTests
Title: [92362] trunk/LayoutTests Revision 92362 Author ham...@chromium.org Date 2011-08-04 01:52:58 -0700 (Thu, 04 Aug 2011) Log Message Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing https://bugs.webkit.org/show_bug.cgi?id=65666 Chromium test_expectations.txt update * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (92361 => 92362) --- trunk/LayoutTests/ChangeLog 2011-08-04 08:39:30 UTC (rev 92361) +++ trunk/LayoutTests/ChangeLog 2011-08-04 08:52:58 UTC (rev 92362) @@ -1,5 +1,14 @@ 2011-08-04 Shinichiro Hamaji +Layout Test fast/box-shadow/box-shadow-clipped-slices.html is failing +https://bugs.webkit.org/show_bug.cgi?id=65666 + +Chromium test_expectations.txt update + +* platform/chromium/test_expectations.txt: + +2011-08-04 Shinichiro Hamaji + [Chromium] Needs eventSender.scalePageBy() https://bugs.webkit.org/show_bug.cgi?id=58013 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92361 => 92362) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 08:39:30 UTC (rev 92361) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 08:52:58 UTC (rev 92362) @@ -3686,3 +3686,4 @@ // Introduced in r92298, which might cause another test crashing. BUGZMO SKIP : fast/loader/reload-zero-byte-plugin.html = FAIL +BUGWK65666 WIN LINUX : fast/box-shadow/box-shadow-clipped-slices.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92361] trunk/LayoutTests
Title: [92361] trunk/LayoutTests Revision 92361 Author ham...@chromium.org Date 2011-08-04 01:39:30 -0700 (Thu, 04 Aug 2011) Log Message [Chromium] Needs eventSender.scalePageBy() https://bugs.webkit.org/show_bug.cgi?id=58013 Chromium test rebaselining * platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added. * platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Added. * platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added. * platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-gpu-win/compositing/scaling/ trunk/LayoutTests/platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png trunk/LayoutTests/platform/chromium-mac/compositing/scaling/ trunk/LayoutTests/platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/compositing/ trunk/LayoutTests/platform/chromium-mac-leopard/compositing/scaling/ trunk/LayoutTests/platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png trunk/LayoutTests/platform/chromium-win/compositing/scaling/ trunk/LayoutTests/platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (92360 => 92361) --- trunk/LayoutTests/ChangeLog 2011-08-04 07:56:34 UTC (rev 92360) +++ trunk/LayoutTests/ChangeLog 2011-08-04 08:39:30 UTC (rev 92361) @@ -1,3 +1,16 @@ +2011-08-04 Shinichiro Hamaji + +[Chromium] Needs eventSender.scalePageBy() +https://bugs.webkit.org/show_bug.cgi?id=58013 + +Chromium test rebaselining + +* platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png: Added. +* platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png: Added. +* platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Added. +* platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-08-04 Adam Barth Test progression after . Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92360 => 92361) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 07:56:34 UTC (rev 92360) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-08-04 08:39:30 UTC (rev 92361) @@ -596,7 +596,6 @@ // Needs eventSender.scalePageBy(). // These failures are going to be removed as a rebase line after the patch for bug 58013 is landed. BUGWK58013 WIN MAC : fast/repaint/scale-page-shrink.html = IMAGE+TEXT -BUGWK58013 WIN MAC : compositing/scaling/tiled-layer-recursion.html = FAIL // - // Inspector tests Added: trunk/LayoutTests/platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-gpu-win/compositing/scaling/tiled-layer-recursion-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/compositing/scaling/tiled-layer-recursion-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/compositing/scaling/tiled-layer-recursion-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92360] trunk/Tools
Title: [92360] trunk/Tools
Revision 92360
Author aba...@webkit.org
Date 2011-08-04 00:56:34 -0700 (Thu, 04 Aug 2011)
Log Message
Another subtle bug due to lack of testing in main.js. :(
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92359 => 92360)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-04 07:52:12 UTC (rev 92359)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-04 07:56:34 UTC (rev 92360)
@@ -164,7 +164,7 @@
function failureInfoFromResultsDetail()
{
-var failureDetails = $('.failure-details', $(this).parents('.results-detail'));
+var failureDetails = $('.results-detail .failure-details');
return {
'builderName': failureDetails.attr(config.kBuilderNameAttr),
'testName': failureDetails.attr(config.kTestNameAttr),
Modified: trunk/Tools/ChangeLog (92359 => 92360)
--- trunk/Tools/ChangeLog 2011-08-04 07:52:12 UTC (rev 92359)
+++ trunk/Tools/ChangeLog 2011-08-04 07:56:34 UTC (rev 92360)
@@ -1,5 +1,11 @@
2011-08-04 Adam Barth
+Another subtle bug due to lack of testing in main.js. :(
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
+
+2011-08-04 Adam Barth
+
Fix types. Sadly, main.js has no test coverage. (I need to think
about how to test this part of the code.)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92359] trunk/LayoutTests
Title: [92359] trunk/LayoutTests Revision 92359 Author aba...@webkit.org Date 2011-08-04 00:52:12 -0700 (Thu, 04 Aug 2011) Log Message Test progression after . * platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: * platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt trunk/LayoutTests/platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (92358 => 92359) --- trunk/LayoutTests/ChangeLog 2011-08-04 07:49:12 UTC (rev 92358) +++ trunk/LayoutTests/ChangeLog 2011-08-04 07:52:12 UTC (rev 92359) @@ -1,5 +1,12 @@ 2011-08-04 Adam Barth +Test progression after . + +* platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: +* platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: + +2011-08-04 Adam Barth + Update baselines after . * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: Modified: trunk/LayoutTests/platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt (92358 => 92359) --- trunk/LayoutTests/platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt 2011-08-04 07:49:12 UTC (rev 92358) +++ trunk/LayoutTests/platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt 2011-08-04 07:52:12 UTC (rev 92359) @@ -1,2 +1 @@ -CONSOLE MESSAGE: line 12: Uncaught TypeError: Object [object Object] has no method 'scalePageBy' -This test must be run via DumpRenderTree. +Pass Modified: trunk/LayoutTests/platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt (92358 => 92359) --- trunk/LayoutTests/platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt 2011-08-04 07:49:12 UTC (rev 92358) +++ trunk/LayoutTests/platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt 2011-08-04 07:52:12 UTC (rev 92359) @@ -1,2 +1 @@ -CONSOLE MESSAGE: line 15: Uncaught TypeError: Object [object Object] has no method 'scalePageBy' -This test must be run via DumpRenderTree. +Pass ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92358] trunk/LayoutTests
Title: [92358] trunk/LayoutTests Revision 92358 Author aba...@webkit.org Date 2011-08-04 00:49:12 -0700 (Thu, 04 Aug 2011) Log Message Update baselines after . * platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: * platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: * platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (92357 => 92358) --- trunk/LayoutTests/ChangeLog 2011-08-04 07:41:57 UTC (rev 92357) +++ trunk/LayoutTests/ChangeLog 2011-08-04 07:49:12 UTC (rev 92358) @@ -1,5 +1,15 @@ 2011-08-04 Adam Barth +Update baselines after . + +* platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png: +* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: +* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: +* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: +* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: + +2011-08-04 Adam Barth + This test triggers a crasher on some ports. The crasher is filed already. * platform/qt/Skipped: Modified: trunk/LayoutTests/platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92357] trunk/Tools
Title: [92357] trunk/Tools
Revision 92357
Author aba...@webkit.org
Date 2011-08-04 00:41:57 -0700 (Thu, 04 Aug 2011)
Log Message
Fix types. Sadly, main.js has no test coverage. (I need to think
about how to test this part of the code.)
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92356 => 92357)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-04 07:14:58 UTC (rev 92356)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-04 07:41:57 UTC (rev 92357)
@@ -222,7 +222,8 @@
function showSelectedFailures()
{
-g_resultsDetailsIterator = new base.CallbackIterator(showResultsDetail, selectedFailures());
+var listOfArgumentArrays = selectedFailures().map(function(failureInfo) { return [failureInfo]; });
+g_resultsDetailsIterator = new base.CallbackIterator(showResultsDetail, listOfArgumentArrays);
g_resultsDetailsIterator.callNext();
}
Modified: trunk/Tools/ChangeLog (92356 => 92357)
--- trunk/Tools/ChangeLog 2011-08-04 07:14:58 UTC (rev 92356)
+++ trunk/Tools/ChangeLog 2011-08-04 07:41:57 UTC (rev 92357)
@@ -1,5 +1,12 @@
2011-08-04 Adam Barth
+Fix types. Sadly, main.js has no test coverage. (I need to think
+about how to test this part of the code.)
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
+
+2011-08-04 Adam Barth
+
bugzilla.js is missing unit tests
https://bugs.webkit.org/show_bug.cgi?id=65656
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [92356] trunk/Tools
Title: [92356] trunk/Tools Revision 92356 Author aba...@webkit.org Date 2011-08-04 00:14:58 -0700 (Thu, 04 Aug 2011) Log Message bugzilla.js is missing unit tests https://bugs.webkit.org/show_bug.cgi?id=65656 Reviewed by Adam Roben. Testing makes perfect. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: (NetworkSimulator.prototype.runTest.get if): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html trunk/Tools/ChangeLog Added Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js Diff Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js (0 => 92356) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js (rev 0) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js 2011-08-04 07:14:58 UTC (rev 92356) @@ -0,0 +1,233 @@ +/* + * Copyright (C) 2011 Google Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ + +(function () { + +module("bugzilla"); + +var kExampleResponseXML = +'' + +'' + +' Bugzilla Bugs' + +' 2011-08-04T00:22:49Z' + +' https://bugs.webkit.org/buglist.cgi?bug_status=REOPENED&bug_status=NEW&bug_status=ASSIGNED&bug_status=UNCONFIRMED&ctype=atom&field-1-0-0=bug_status&field0-0-0=product&field0-0-1=component&field0-0-2=short_desc&field0-0-3=status_whiteboard&field0-0-4=longdesc&query_format=advanced&remaction=&type-1-0-0=anyexact&type0-0-0=substring&type0-0-1=substring&type0-0-2=substring&type0-0-3=substring&type0-0-4=substring&value-1-0-0=REOPENED%2CNEW%2CASSIGNED%2CUNCONFIRMED&value0-0-0=garden-o-matic&value0-0-1=garden-o-matic&value0-0-2=garden-o-matic&value0-0-3=garden-o-matic&value0-0-4=garden-o-matic' + +'' + +' ' + +'[Bug 65654] Add missing license blocks to garden-o-matic' + +'https://bugs.webkit.org/show_bug.cgi?id=65654' + +'' + +' Adam Barth' + +'' + +'2011-08-04T00:22:26Z ' + +'' + +' ' + +'' + +'
' + +' Field Value ' + +'' + +' Product ' + +'WebKit ' + +'' + +' Component ' + +'New Bugs ' + +'' + +' Assignee ' + +'Adam Barth ' + +'' + +' Reporter ' + +'Adam Barth ' + +'' + +' Status ' + +'NEW ' + +'' + +' Resolution ' + +'' + +' ' + +' Priority ' + +'P2 ' + +'' + +' Severity ' + +'Normal ' + +'' + +' Opened ' + +'16:21:52 ' + +'' + +'
[webkit-changes] [92355] trunk/Tools
Title: [92355] trunk/Tools Revision 92355 Author aba...@webkit.org Date 2011-08-04 00:14:24 -0700 (Thu, 04 Aug 2011) Log Message Add missing license blocks to garden-o-matic https://bugs.webkit.org/show_bug.cgi?id=65654 Reviewed by Dimitri Glazkov. This patch is entirely boilerplate. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js trunk/Tools/ChangeLog Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css (92354 => 92355) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-08-04 07:13:56 UTC (rev 92354) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-08-04 07:14:24 UTC (rev 92355) @@ -1,3 +1,28 @@ +/* + * Copyright (C) 2011 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS
[webkit-changes] [92354] trunk/Tools
Title: [92354] trunk/Tools Revision 92354 Author aba...@webkit.org Date 2011-08-04 00:13:56 -0700 (Thu, 04 Aug 2011) Log Message garden-o-matic needs a way to mock out the network https://bugs.webkit.org/show_bug.cgi?id=65653 Reviewed by Dimitri Glazkov. This patch introduces the net module, which is a useful mock point for abstracting away the network. Future patches will use this infrastructure to test some currently untested code. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added. (NetworkSimulator): (NetworkSimulator.prototype.scheduleCallback): (NetworkSimulator.prototype.runTest): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: * Scripts/webkitpy/tool/servers/gardeningserver.py: Modified Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py Added Paths trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js Diff Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js (92353 => 92354) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js 2011-08-04 07:10:25 UTC (rev 92353) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js 2011-08-04 07:13:56 UTC (rev 92354) @@ -41,7 +41,7 @@ quicksearch: query, }); -$.get(url, function(responseXML) { +net.get(url, function(responseXML) { var entries = responseXML.getElementsByTagName('entry'); var results = Array.prototype.map.call(entries, function(entry) { var container = document.createElement('div'); Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js (92353 => 92354) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-08-04 07:10:25 UTC (rev 92353) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-08-04 07:13:56 UTC (rev 92354) @@ -122,7 +122,7 @@ var url = "" startRevision, endRevision, true, true); -$.get(url, function(commitData) { +net.get(url, function(commitData) { callback(parseCommitData(commitData)); }); }); @@ -155,7 +155,7 @@ 'limit': limit, }); -$.get(url, function(commitData) { +net.get(url, function(commitData) { callback(parseCommitData(commitData)); }); }; Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js (92353 => 92354) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js 2011-08-04 07:10:25 UTC (rev 92353) +++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js 2011-08-04 07:13:56 UTC (rev 92354) @@ -81,34 +81,6 @@ return filteredTree; }; -base.probe = function(url, options) -{ -var scriptElement = document.createElement('script'); -scriptElement.addEventListener('load', function() { -$(scriptElement).detach(); -if (optio
[webkit-changes] [92353] trunk/LayoutTests
Title: [92353] trunk/LayoutTests Revision 92353 Author aba...@webkit.org Date 2011-08-04 00:10:25 -0700 (Thu, 04 Aug 2011) Log Message This test triggers a crasher on some ports. The crasher is filed already. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (92352 => 92353) --- trunk/LayoutTests/ChangeLog 2011-08-04 06:35:56 UTC (rev 92352) +++ trunk/LayoutTests/ChangeLog 2011-08-04 07:10:25 UTC (rev 92353) @@ -1,3 +1,9 @@ +2011-08-04 Adam Barth + +This test triggers a crasher on some ports. The crasher is filed already. + +* platform/qt/Skipped: + 2011-08-03 Alice Boxhall An element with role=textbox should have settable AXValue unless read-only Modified: trunk/LayoutTests/platform/qt/Skipped (92352 => 92353) --- trunk/LayoutTests/platform/qt/Skipped 2011-08-04 06:35:56 UTC (rev 92352) +++ trunk/LayoutTests/platform/qt/Skipped 2011-08-04 07:10:25 UTC (rev 92353) @@ -2247,3 +2247,6 @@ # [Qt]REGRESSION(r92224): It made editing/text-iterator/basic-iteration.html timeout # https://bugs.webkit.org/show_bug.cgi?id=65605 editing/text-iterator/basic-iteration.html + +# This test tickles another crasher on Qt. +fast/loader/reload-zero-byte-plugin.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
