date:20110809

[webkit-changes] [92693] trunk/Source/WebCore

2011-08-09 Thread steveblock

Title: [92693] trunk/Source/WebCore








Revision 92693
Author stevebl...@google.com
Date 2011-08-09 11:36:47 -0700 (Tue, 09 Aug 2011)


Log Message
JavaString is not needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65909

Removes the JavaString wrapper class, moves the JSC implementation
to JavaStringJSC.h and removes the V8 implementation.

Reviewed by Alexey Proskuryakov.

No new tests, refactoring only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaString.h: Removed.
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jsc/JavaFieldJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaMethodJSC.h:
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::init):
* bridge/jni/v8/JavaStringV8.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bridge/jni/jni_jsobject.mm
trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.h
trunk/Source/WebCore/bridge/jni/jsc/JavaInstanceJSC.cpp
trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.h
trunk/Source/WebCore/bridge/jni/jsc/JavaStringJSC.h


Removed Paths

trunk/Source/WebCore/bridge/jni/JavaString.h
trunk/Source/WebCore/bridge/jni/v8/JavaStringV8.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92692 => 92693)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 18:18:36 UTC (rev 92692)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 18:36:47 UTC (rev 92693)
@@ -1,3 +1,29 @@
+2011-08-09  Steve Block  stevebl...@google.com
+
+JavaString is not needed by V8
+https://bugs.webkit.org/show_bug.cgi?id=65909
+
+Removes the JavaString wrapper class, moves the JSC implementation
+to JavaStringJSC.h and removes the V8 implementation.
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, refactoring only.
+
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.xcodeproj/project.pbxproj:
+* bridge/jni/JavaString.h: Removed.
+* bridge/jni/jni_jsobject.mm:
+* bridge/jni/jsc/JavaFieldJSC.h:
+* bridge/jni/jsc/JavaInstanceJSC.cpp:
+* bridge/jni/jsc/JavaMethodJSC.h:
+* bridge/jni/jsc/JavaStringJSC.h:
+(JSC::Bindings::JavaString::JavaString):
+(JSC::Bindings::JavaString::~JavaString):
+(JSC::Bindings::JavaString::init):
+* bridge/jni/v8/JavaStringV8.h: Removed.
+
 2011-08-09  Abhishek Arya  infe...@chromium.org
 
 Regression(83075): Fix updateAlwaysCreateLineBoxes on information 


Modified: trunk/Source/WebCore/GNUmakefile.list.am (92692 => 92693)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 18:18:36 UTC (rev 92692)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 18:36:47 UTC (rev 92693)
@@ -884,7 +884,6 @@
 	Source/WebCore/bridge/IdentifierRep.cpp \
 	Source/WebCore/bridge/IdentifierRep.h \
 	Source/WebCore/bridge/jni/JNIUtility.h \
-	Source/WebCore/bridge/jni/JavaString.h \
 	Source/WebCore/bridge/jni/JavaType.h \
 	Source/WebCore/bridge/jni/jni_jsobject.h \
 	Source/WebCore/bridge/jni/jsc/JavaArrayJSC.h \


Modified: trunk/Source/WebCore/WebCore.gypi (92692 => 92693)

--- trunk/Source/WebCore/WebCore.gypi	2011-08-09 18:18:36 UTC (rev 92692)
+++ trunk/Source/WebCore/WebCore.gypi	2011-08-09 18:36:47 UTC (rev 92693)
@@ -2232,7 +2232,6 @@
 'bridge/c/c_utility.cpp',
 'bridge/c/c_utility.h',
 'bridge/jni/JNIUtility.cpp',
-'bridge/jni/JavaString.h',
 'bridge/jni/JavaType.h',
 'bridge/jni/JobjectWrapper.cpp',
 'bridge/jni/JobjectWrapper.h',
@@ -2261,7 +2260,6 @@
 'bridge/jni/v8/JavaMethodV8.h',
 'bridge/jni/v8/JavaNPObjectV8.cpp',
 'bridge/jni/v8/JavaNPObjectV8.h',
-'bridge/jni/v8/JavaStringV8.h',
 'bridge/jni/v8/JavaValueV8.h',
 'bridge/jsc/BridgeJSC.cpp',
 'bridge/npruntime.cpp',


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (92692 => 92693)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-08-09 18:18:36 UTC (rev 92692)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-08-09 18:36:47 UTC (rev 92693)
@@ -1503,7 +1503,6 @@
 		5913A24213D49EBA00F5B05C /* IdentifiersFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 5913A24013D49EBA00F5B05C /* IdentifiersFactory.h */; };
 		59309AF4AE5800250603 /* DeviceOrientationClientMock.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 59309A1011F4AE5800250603 /* DeviceOrientationClientMock.cpp */; };
 		59309A1311F4AE6A00250603 /* DeviceOrientationClientMock.h in Headers */ = {isa = PBXBuildFile; fileRef = 59309A1211F4AE6A00250603 /* DeviceOrientationClientMock.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		593D3EB1132532950057E7EE /* JavaString.h in

[webkit-changes] [92694] trunk/Source

2011-08-09 Thread dslomov

Title: [92694] trunk/Source








Revision 92694
Author dslo...@google.com
Date 2011-08-09 12:01:05 -0700 (Tue, 09 Aug 2011)


Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by Dmitry Titov.

Covered by existing tests.

* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/V8GCController.cpp:
(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by Dmitry Titov.

* src/BoundObject.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8GCController.cpp
trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp
trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h
trunk/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
trunk/Source/WebCore/bindings/v8/V8NPObject.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.h
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.h
trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/BoundObject.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92693 => 92694)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 18:36:47 UTC (rev 92693)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 19:01:05 UTC (rev 92694)
@@ -1,3 +1,44 @@
+2011-08-09  Dmitry Lomov  dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=65778
+[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.
+
+Reviewed by Dmitry Titov.
+
+Covered by existing tests.
+
+* bindings/v8/V8Binding.cpp:
+(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
+(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
+(WebCore::V8BindingPerIsolateData::globalHandleMap):
+(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
+(WebCore::AllowAllocation::~AllowAllocation):
+(WebCore::AllowAllocation::current):
+(WebCore::SafeAllocation::newInstance):
+* bindings/v8/V8GCController.cpp:
+(WebCore::currentGlobalHandleMap):
+(WebCore::enumerateGlobalHandles):
+(WebCore::V8GCController::registerGlobalHandle):
+(WebCore::V8GCController::unregisterGlobalHandle):
+* bindings/v8/V8HiddenPropertyName.cpp:
+(WebCore::V8HiddenPropertyName::createString):
+* bindings/v8/V8HiddenPropertyName.h:
+(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
+* bindings/v8/V8LazyEventListener.cpp:
+(WebCore::V8LazyEventListener::prepareListenerObject):
+* bindings/v8/V8NPObject.cpp:
+* bindings/v8/V8Proxy.cpp:
+(WebCore::V8Proxy::checkNewLegal):
+* bindings/v8/V8Utilities.h:
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
+(WebCore::WorkerContextExecutionProxy::initIsolate):
+* bindings/v8/WorkerContextExecutionProxy.h:
+* bindings/v8/WorkerScriptController.cpp:
+

[webkit-changes] [92697] trunk

2011-08-09 Thread enne

Title: [92697] trunk








Revision 92697
Author e...@google.com
Date 2011-08-09 12:27:24 -0700 (Tue, 09 Aug 2011)


Log Message
Add testing for --force-compositing-mode to windows.internal
https://bugs.webkit.org/show_bug.cgi?id=65777

Reviewed by Adam Barth.

.:

Add exports for Document::settings().

* Source/autotools/symbols.filter:

Source/WebCore:

Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html

Move initial initialization to settings caching function so that RLC
picks up changes to the force compositing mode flag.

* WebCore.exp.in:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* testing/Internals.cpp:
(WebCore::Internals::setForceCompositingMode):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Add exports for Document::settings().

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Add empty page to test that the root gets a graphics layer.

* platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter


Added Paths

trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt
trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html




Diff

Modified: trunk/ChangeLog (92696 => 92697)

--- trunk/ChangeLog	2011-08-09 19:13:45 UTC (rev 92696)
+++ trunk/ChangeLog	2011-08-09 19:27:24 UTC (rev 92697)
@@ -1,3 +1,14 @@
+2011-08-08  Adrienne Walker  e...@google.com
+
+Add testing for --force-compositing-mode to windows.internal
+https://bugs.webkit.org/show_bug.cgi?id=65777
+
+Reviewed by Adam Barth.
+
+Add exports for Document::settings().
+
+* Source/autotools/symbols.filter:
+
 2011-08-09  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r92683.


Modified: trunk/LayoutTests/ChangeLog (92696 => 92697)

--- trunk/LayoutTests/ChangeLog	2011-08-09 19:13:45 UTC (rev 92696)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 19:27:24 UTC (rev 92697)
@@ -1,3 +1,15 @@
+2011-08-08  Adrienne Walker  e...@google.com
+
+Add testing for --force-compositing-mode to windows.internal
+https://bugs.webkit.org/show_bug.cgi?id=65777
+
+Reviewed by Adam Barth.
+
+Add empty page to test that the root gets a graphics layer.
+
+* platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
+* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.
+
 2011-08-08  Ryosuke Niwa  rn...@webkit.org
 
 Repeated copy and paste result in nested style elements such as b and font


Added: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt (0 => 92697)

--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt	2011-08-09 19:27:24 UTC (rev 92697)
@@ -0,0 +1,9 @@
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+)
+  )
+)
+
Property changes on: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html (0 => 92697)

--- trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html	(rev 0)
+++ trunk/LayoutTests/platform/chromium/compositing/force-compositing-mode/force-composite-empty.html	2011-08-09 19:27:24 UTC (rev 92697)
@@ -0,0 +1,19 @@
+html
+  head
+script
+  if (window.internals)
+window.internals.setForceCompositingMode(document, true);
+  function doTest() {
+if (window.layoutTestController) {
+  document.getElementById(layertree).innerText = layoutTestController.layerTreeAsText();
+  layoutTestController.dumpAsText();
+}
+

[webkit-changes] [92698] trunk

2011-08-09 Thread vsevik

Title: [92698] trunk








Revision 92698
Author vse...@chromium.org
Date 2011-08-09 12:29:21 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: XHRs end up in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60321

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-no-xhrs.html

* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):

LayoutTests:

* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
* http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js


Added Paths

trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt
trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92697 => 92698)

--- trunk/LayoutTests/ChangeLog	2011-08-09 19:27:24 UTC (rev 92697)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 19:29:21 UTC (rev 92698)
@@ -1,3 +1,14 @@
+2011-08-09  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: XHRs end up in the resources panel.
+https://bugs.webkit.org/show_bug.cgi?id=60321
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/console-xhr-logging-expected.txt:
+* http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
+* http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.
+
 2011-08-08  Adrienne Walker  e...@google.com
 
 Add testing for --force-compositing-mode to windows.internal


Modified: trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt (92697 => 92698)

--- trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt	2011-08-09 19:27:24 UTC (rev 92697)
+++ trunk/LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt	2011-08-09 19:29:21 UTC (rev 92698)
@@ -13,7 +13,7 @@
 console-xhr-logging.html:10sending a GET request to resources/xhr-exists.html
 XHR finished loading: http://127.0.0.1:8000/inspector/resources/xhr-exists.html.
 console-xhr-logging.html:10sending a GET request to resources/xhr-does-not-exist.html
-xhr-does-not-exist.htmlGET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
+resources/xhr-does-not-exist.htmlGET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
 XHR finished loading: http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html.
 console-xhr-logging.html:10sending a POST request to resources/post-target.cgi
 XHR finished loading: http://127.0.0.1:8000/inspector/resources/post-target.cgi.
@@ -21,7 +21,7 @@
 XMLHttpRequest cannot load http://localhost:8000/inspector/resources/xhr-exists.html. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 console-xhr-logging.html:10sending a GET request to resources/xhr-exists.html
 console-xhr-logging.html:10sending a GET request to resources/xhr-does-not-exist.html
-xhr-does-not-exist.htmlGET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
+resources/xhr-does-not-exist.htmlGET http://127.0.0.1:8000/inspector/resources/xhr-does-not-exist.html 404 (Not Found)
 console-xhr-logging.html:10sending a POST request to resources/post-target.cgi
 console-xhr-logging.html:10sending a GET request to http://localhost:8000/inspector/resources/xhr-exists.html
 XMLHttpRequest cannot load http://localhost:8000/inspector/resources/xhr-exists.html. Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.


Added: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt (0 => 92698)

--- trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt	2011-08-09 19:29:21 UTC (rev 92698)
@@ -0,0 +1,4 @@
+CONSOLE MESSAGE: line 13: Done.
+Tests that XHRs are not added to resourceTreeModel.
+
+Bug 60321


Added: trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs.html (0 => 92698)

--- trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs.html	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-no-xhrs.html	2011-08-09 19:29:21 UTC (rev 92698)
@@ -0,0 +1,34 @@
+html
+head
+script src=""
+script src=""
+script
+function sendXHR()
+{
+doXHR(GET, resources/resource.php, false, resourceLoaded);
+}
+
+function resourceLoaded()
+{
+

[webkit-changes] [92699] trunk/Source

2011-08-09 Thread commit-queue

Title: [92699] trunk/Source








Revision 92699
Author commit-qu...@webkit.org
Date 2011-08-09 12:42:26 -0700 (Tue, 09 Aug 2011)


Log Message
[Chromium] Enable rubber banding when scrolling.

https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine asvitk...@chromium.org on 2011-08-09
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

* features.gypi:
* public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
* public/mac/WebInputEventFactory.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebInputEventConversion.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
* src/mac/WebInputEventFactory.mm:
(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformWheelEvent.h
trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/public/WebInputEvent.h
trunk/Source/WebKit/chromium/public/mac/WebInputEventFactory.h
trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp
trunk/Source/WebKit/chromium/src/WebInputEventConversion.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (92698 => 92699)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 19:29:21 UTC (rev 92698)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 19:42:26 UTC (rev 92699)
@@ -1,3 +1,18 @@
+2011-08-09  Alexei Svitkine  asvitk...@chromium.org
+
+[Chromium] Enable rubber banding when scrolling.
+
+https://bugs.webkit.org/show_bug.cgi?id=65707
+
+Reviewed by Dimitri Glazkov.
+
+No new tests since this is just syncing changes to chromium platform.
+
+* platform/PlatformWheelEvent.h:
+(WebCore::PlatformWheelEvent::PlatformWheelEvent):
+* platform/chromium/ScrollAnimatorChromiumMac.mm:
+(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):
+
 2011-08-09  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: XHRs end up in the resources panel.


Modified: trunk/Source/WebCore/platform/PlatformWheelEvent.h (92698 => 92699)

--- trunk/Source/WebCore/platform/PlatformWheelEvent.h	2011-08-09 19:29:21 UTC (rev 92698)
+++ trunk/Source/WebCore/platform/PlatformWheelEvent.h	2011-08-09 19:42:26 UTC (rev 92699)
@@ -73,7 +73,7 @@
 ScrollByPixelWheelEvent
 };
 
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM)  OS(DARWIN))
 enum PlatformWheelEventPhase {
 PlatformWheelEventPhaseNone= 0,
 PlatformWheelEventPhaseBegan   = 1  1,
@@ -97,7 +97,7 @@
 , m_ctrlKey(false)
 , m_altKey(false)
 , m_metaKey(false)
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM)  OS(DARWIN))
 , m_hasPreciseScrollingDeltas(false)
 , m_phase(PlatformWheelEventPhaseNone)
 , m_momentumPhase(PlatformWheelEventPhaseNone)
@@ -119,7 +119,7 @@
 , m_ctrlKey(ctrlKey)
 , m_altKey(altKey)
 , m_metaKey(metaKey)
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM)  OS(DARWIN))
 , m_hasPreciseScrollingDeltas(false)
 , m_phase(PlatformWheelEventPhaseNone)
 , m_momentumPhase(PlatformWheelEventPhaseNone)
@@ -174,7 +174,9 @@
 #if defined(__OBJC__)
 PlatformWheelEvent(NSEvent *, NSView *windowView);
 #endif
+#endif
 
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM)  OS(DARWIN))
 PlatformWheelEventPhase phase() const { return m_phase; }
 PlatformWheelEventPhase momentumPhase() const { return m_momentumPhase; }
 bool hasPreciseScrollingDeltas() const { return m_hasPreciseScrollingDeltas; }
@@ -213,7 +215,7 @@
 bool m_ctrlKey;
 bool m_altKey;
 bool m_metaKey;
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || (PLATFORM(CHROMIUM)  OS(DARWIN))
 bool

[webkit-changes] [92701] branches/safari-534.51-branch/Source

2011-08-09 Thread lforschler

Title: [92701] branches/safari-534.51-branch/Source








Revision 92701
Author lforsch...@apple.com
Date 2011-08-09 12:47:54 -0700 (Tue, 09 Aug 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (92700 => 92701)

--- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-09 19:46:31 UTC (rev 92700)
+++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-08-09 19:47:54 UTC (rev 92701)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 10;
+TINY_VERSION = 11;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (92700 => 92701)

--- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-09 19:46:31 UTC (rev 92700)
+++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-08-09 19:47:54 UTC (rev 92701)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 10;
+TINY_VERSION = 11;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (92700 => 92701)

--- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-09 19:46:31 UTC (rev 92700)
+++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig	2011-08-09 19:47:54 UTC (rev 92701)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 10;
+TINY_VERSION = 11;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (92700 => 92701)

--- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-09 19:46:31 UTC (rev 92700)
+++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-08-09 19:47:54 UTC (rev 92701)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 10;
+TINY_VERSION = 11;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (92700 => 92701)

--- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-09 19:46:31 UTC (rev 92700)
+++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-08-09 19:47:54 UTC (rev 92701)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 51;
-TINY_VERSION = 10;
+TINY_VERSION = 11;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92704] trunk/LayoutTests

2011-08-09 Thread crogers

Title: [92704] trunk/LayoutTests








Revision 92704
Author crog...@google.com
Date 2011-08-09 13:26:15 -0700 (Tue, 09 Aug 2011)


Log Message
Add more Web Audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65786

Reviewed by Kenneth Russell.

* webaudio/audiobuffersource-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate.html: Added.
* webaudio/audiobuffersource.html: Added.
* webaudio/mixing-expected.wav: Added.
* webaudio/mixing.html: Added.
* webaudio/resources/hyper-reality: Added.
* webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
* webaudio/resources/hyper-reality/laughter.wav: Added.
* webaudio/sample-accurate-scheduling-expected.txt: Added.
* webaudio/sample-accurate-scheduling.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/webaudio/audiobuffersource-expected.wav
trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav
trunk/LayoutTests/webaudio/audiobuffersource-playbackrate.html
trunk/LayoutTests/webaudio/audiobuffersource.html
trunk/LayoutTests/webaudio/mixing-expected.wav
trunk/LayoutTests/webaudio/mixing.html
trunk/LayoutTests/webaudio/resources/hyper-reality/
trunk/LayoutTests/webaudio/resources/hyper-reality/br-jam-loop.wav
trunk/LayoutTests/webaudio/resources/hyper-reality/laughter.wav
trunk/LayoutTests/webaudio/sample-accurate-scheduling-expected.txt
trunk/LayoutTests/webaudio/sample-accurate-scheduling.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92703 => 92704)

--- trunk/LayoutTests/ChangeLog	2011-08-09 20:18:05 UTC (rev 92703)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 20:26:15 UTC (rev 92704)
@@ -1,3 +1,22 @@
+2011-08-09  Chris Rogers  crog...@google.com
+
+Add more Web Audio layout tests
+https://bugs.webkit.org/show_bug.cgi?id=65786
+
+Reviewed by Kenneth Russell.
+
+* webaudio/audiobuffersource-expected.wav: Added.
+* webaudio/audiobuffersource-playbackrate-expected.wav: Added.
+* webaudio/audiobuffersource-playbackrate.html: Added.
+* webaudio/audiobuffersource.html: Added.
+* webaudio/mixing-expected.wav: Added.
+* webaudio/mixing.html: Added.
+* webaudio/resources/hyper-reality: Added.
+* webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
+* webaudio/resources/hyper-reality/laughter.wav: Added.
+* webaudio/sample-accurate-scheduling-expected.txt: Added.
+* webaudio/sample-accurate-scheduling.html: Added.
+
 2011-08-09  Anders Carlsson  ander...@apple.com
 
 More Lion skipped list goodness.


Added: trunk/LayoutTests/webaudio/audiobuffersource-expected.wav

(Binary files differ)

Property changes on: trunk/LayoutTests/webaudio/audiobuffersource-expected.wav
___

Added: svn:mime-type

Added: trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav

(Binary files differ)

Property changes on: trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav
___

Added: svn:mime-type

Added: trunk/LayoutTests/webaudio/audiobuffersource-playbackrate.html (0 => 92704)

--- trunk/LayoutTests/webaudio/audiobuffersource-playbackrate.html	(rev 0)
+++ trunk/LayoutTests/webaudio/audiobuffersource-playbackrate.html	2011-08-09 20:26:15 UTC (rev 92704)
@@ -0,0 +1,101 @@
+!DOCTYPE html
+
+!--
+Tests that AudioBufferSourceNode can playback at different rates properly.
+Render 72 notes over a 6 octave range.
+--
+
+html
+head
+script type=text/_javascript_ src=""
+script type=text/_javascript_ src=""
+
+/head
+body
+
+script
+
+window._onload_ = init;
+
+var sampleRate = 44100.0;
+var numberOfNotes = 72; // play over a 6 octave range
+var noteDuration = 0.050;
+var noteSpacing = noteDuration + 0.005; // leave 5ms of silence between each note
+var lengthInSeconds = numberOfNotes * noteSpacing;
+
+var context = 0;
+var sinWaveBuffer = 0;
+
+function createOneCycleSinWaveBuffer(frequency, sampleRate) {
+var duration = 1 / frequency;
+var sampleFrameLength = duration * sampleRate;
+
+var audioBuffer = context.createBuffer(2, sampleFrameLength, sampleRate);
+
+var n = audioBuffer.length;
+var channelL = audioBuffer.getChannelData(0);
+var channelR = audioBuffer.getChannelData(1);
+
+for (var i = 0; i  n; ++i) {
+channelL[i] = Math.sin(frequency * 2.0*Math.PI * i / sampleRate);
+channelR[i] = channelL[i];
+}
+
+return audioBuffer;
+}
+
+function playNote(time, duration, playbackRate) {
+var source = context.createBufferSource();
+source.buffer = sinWaveBuffer;
+source.playbackRate.value = playbackRate;
+
+var gainNode = context.createGainNode();
+source.connect(gainNode);
+gainNode.connect(context.destination);
+
+// Loop and play for the given duration.
+

[webkit-changes] [92705] trunk/LayoutTests

2011-08-09 Thread andersca

Title: [92705] trunk/LayoutTests








Revision 92705
Author ander...@apple.com
Date 2011-08-09 13:41:12 -0700 (Tue, 09 Aug 2011)


Log Message
Add updated media test results for Lion.

* platform/mac-snowleopard/media: Added.
* platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png.
* platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt.
* platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png.
* platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt.
* platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png.
* platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt.
* platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png.
* platform/mac-snowleopard/media/video-layer-crash-expected.txt: Copied from platform/mac/media/video-layer-crash-expected.txt.
* platform/mac-snowleopard/media/video-no-audio-expected.png: Copied from platform/mac/media/video-no-audio-expected.png.
* platform/mac-snowleopard/media/video-no-audio-expected.txt: Copied from platform/mac/media/video-no-audio-expected.txt.
* platform/mac/media/controls-strict-expected.png:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.png:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.png:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-layer-crash-expected.png:
* platform/mac/media/video-no-audio-expected.png:
* platform/mac/media/video-no-audio-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/media/controls-strict-expected.png
trunk/LayoutTests/platform/mac/media/controls-strict-expected.txt
trunk/LayoutTests/platform/mac/media/video-controls-rendering-expected.png
trunk/LayoutTests/platform/mac/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/mac/media/video-display-toggle-expected.png
trunk/LayoutTests/platform/mac/media/video-display-toggle-expected.txt
trunk/LayoutTests/platform/mac/media/video-layer-crash-expected.png
trunk/LayoutTests/platform/mac/media/video-no-audio-expected.png
trunk/LayoutTests/platform/mac/media/video-no-audio-expected.txt


Added Paths

trunk/LayoutTests/platform/mac-snowleopard/media/
trunk/LayoutTests/platform/mac-snowleopard/media/controls-strict-expected.png
trunk/LayoutTests/platform/mac-snowleopard/media/controls-strict-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/media/video-controls-rendering-expected.png
trunk/LayoutTests/platform/mac-snowleopard/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/media/video-display-toggle-expected.png
trunk/LayoutTests/platform/mac-snowleopard/media/video-display-toggle-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/media/video-layer-crash-expected.png
trunk/LayoutTests/platform/mac-snowleopard/media/video-layer-crash-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/media/video-no-audio-expected.png
trunk/LayoutTests/platform/mac-snowleopard/media/video-no-audio-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92704 => 92705)

--- trunk/LayoutTests/ChangeLog	2011-08-09 20:26:15 UTC (rev 92704)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 20:41:12 UTC (rev 92705)
@@ -1,3 +1,28 @@
+2011-08-09  Anders Carlsson  ander...@apple.com
+
+Add updated media test results for Lion.
+
+* platform/mac-snowleopard/media: Added.
+* platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png.
+* platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt.
+* platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png.
+* platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt.
+* platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png.
+* platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt.
+* platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png.
+* platform/mac-snowleopard/media/video-layer-crash-expected.txt:

[webkit-changes] [92707] trunk/Tools

2011-08-09 Thread abarth

Title: [92707] trunk/Tools








Revision 92707
Author aba...@webkit.org
Date 2011-08-09 14:17:42 -0700 (Tue, 09 Aug 2011)


Log Message
Enable CORS for garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=65936

Reviewed by Dimitri Glazkov.

This patch will allow the hosted instance of garden-o-matic to
communicate with the local server.

* Scripts/webkitpy/tool/servers/gardeningserver.py:
* Scripts/webkitpy/tool/servers/reflectionhandler.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py




Diff

Modified: trunk/Tools/ChangeLog (92706 => 92707)

--- trunk/Tools/ChangeLog	2011-08-09 20:46:17 UTC (rev 92706)
+++ trunk/Tools/ChangeLog	2011-08-09 21:17:42 UTC (rev 92707)
@@ -1,5 +1,18 @@
 2011-08-09  Adam Barth  aba...@webkit.org
 
+Enable CORS for garden-o-matic
+https://bugs.webkit.org/show_bug.cgi?id=65936
+
+Reviewed by Dimitri Glazkov.
+
+This patch will allow the hosted instance of garden-o-matic to
+communicate with the local server.
+
+* Scripts/webkitpy/tool/servers/gardeningserver.py:
+* Scripts/webkitpy/tool/servers/reflectionhandler.py:
+
+2011-08-09  Adam Barth  aba...@webkit.org
+
 Upgrade jquery in TestFailures
 https://bugs.webkit.org/show_bug.cgi?id=65935
 


Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (92706 => 92707)

--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2011-08-09 20:46:17 UTC (rev 92706)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2011-08-09 21:17:42 UTC (rev 92707)
@@ -103,6 +103,8 @@
 public_html,
 TestFailures)
 
+allow_cross_origin_requests = True
+
 def _run_webkit_patch(self, args):
 return self.server.tool.executive.run_command([self.server.tool.path()] + args, cwd=self.server.tool.scm().checkout_root)
 


Modified: trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py (92706 => 92707)

--- trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py	2011-08-09 20:46:17 UTC (rev 92706)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py	2011-08-09 21:17:42 UTC (rev 92707)
@@ -55,6 +55,11 @@
 STATIC_FILE_NAMES = None
 STATIC_FILE_DIRECTORY = None
 
+# Setting this flag to True causes the server to send
+#   Access-Control-Allow-Origin: *
+# with every response.
+allow_cross_origin_requests = False
+
 def do_GET(self):
 self._handle_request()
 
@@ -100,14 +105,20 @@
 # otherwise there's a deadlock
 threading.Thread(target=lambda: self.server.shutdown()).start()
 
+def _send_access_control_header(self):
+if self.allow_cross_origin_requests:
+self.send_header('Access-Control-Allow-Origin', '*')
+
 def _serve_text(self, text):
 self.send_response(200)
+self._send_access_control_header()
 self.send_header(Content-type, text/plain)
 self.end_headers()
 self.wfile.write(text)
 
 def _serve_json(self, json_object):
 self.send_response(200)
+self._send_access_control_header()
 self.send_header('Content-type', 'application/json')
 self.end_headers()
 json.dump(json_object, self.wfile)
@@ -118,6 +129,7 @@
 return
 with codecs.open(file_path, rb) as static_file:
 self.send_response(200)
+self._send_access_control_header()
 self.send_header(Content-Length, os.path.getsize(file_path))
 mime_type, encoding = mimetypes.guess_type(file_path)
 if mime_type:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92708] trunk/Tools

2011-08-09 Thread abarth

Title: [92708] trunk/Tools








Revision 92708
Author aba...@webkit.org
Date 2011-08-09 14:21:20 -0700 (Tue, 09 Aug 2011)


Log Message
Teach build.webkit.org's garden-o-matic how to talk to the local server
https://bugs.webkit.org/show_bug.cgi?id=65940

Reviewed by Dimitri Glazkov.

After this patch, the version of garden-o-matic on build.webkit.org is
fully functional.  It can interact with the local server via CORS.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92707 => 92708)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-09 21:17:42 UTC (rev 92707)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-09 21:21:20 UTC (rev 92708)
@@ -32,18 +32,31 @@
 checkout.subversionURLForTest = function(testName)
 {
 return kWebKitTrunk + 'LayoutTests/' + testName;
-}
+};
 
+checkout.isAvailable = function(callback)
+{
+net.ajax({
+url: config.kLocalServerURL + '/ping',
+success: function() {
+callback(true);
+},
+error: function() {
+callback(false);
+},
+});
+};
+
 checkout.updateExpectations = function(failureInfoList, callback)
 {
-net.post('/updateexpectations', JSON.stringify(failureInfoList), function() {
+net.post(config.kLocalServerURL + '/updateexpectations', JSON.stringify(failureInfoList), function() {
 callback();
 });
 };
 
 checkout.optimizeBaselines = function(testName, callback)
 {
-net.post('/optimizebaselines?' + $.param({
+net.post(config.kLocalServerURL + '/optimizebaselines?' + $.param({
 'test': testName,
 }), function() {
 callback();
@@ -55,7 +68,7 @@
 base.callInSequence(function(failureInfo, callback) {
 var extensionList = Array.prototype.concat.apply([], failureInfo.failureTypeList.map(results.failureTypeToExtensionList));
 base.callInSequence(function(extension, callback) {
-net.post('/rebaseline?' + $.param({
+net.post('config.kLocalServerURL + /rebaseline?' + $.param({
 'builder': failureInfo.builderName,
 'test': failureInfo.testName,
 'extension': extension


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js (92707 => 92708)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js	2011-08-09 21:17:42 UTC (rev 92707)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js	2011-08-09 21:21:20 UTC (rev 92708)
@@ -56,6 +56,7 @@
 
 config.kTracURL = 'http://trac.webkit.org';
 config.kBugzillaURL = 'https://bugs.webkit.org';
+config.kLocalServerURL = 'http://127.0.0.1:8127';
 
 config.kRevisionAttr = 'data-revision';
 config.kTestNameAttr = 'data-test-name';


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92707 => 92708)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-09 21:17:42 UTC (rev 92707)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js	2011-08-09 21:21:20 UTC (rev 92708)
@@ -36,6 +36,7 @@
 function dismissButterbar()
 {
 $('.butterbar').fadeOut('fast');
+checkForLocalServer();
 }
 
 function displayOnButterbar(message)
@@ -284,6 +285,14 @@
 hideInfobarIfOfType(kBuildFailedInfobarType);
 }
 
+function checkForLocalServer()
+{
+checkout.isAvailable(function(available) {
+if (!available)
+displayOnButterbar('Run webkit-patch garden-o-matic to enable rebaseline features.')
+});
+}
+
 function update()
 {
 displayOnButterbar('Loading...');
@@ -293,6 +302,7 @@
 showBuilderProgress();
 model.analyzeUnexpectedFailures(showUnexpectedFailure);
 dismissButterbar();
+checkForLocalServer();
 });
 }
 


Modified: trunk/Tools/ChangeLog (92707 => 92708)

--- trunk/Tools/ChangeLog	2011-08-09 21:17:42 UTC (rev 92707)
+++ trunk/Tools/ChangeLog	2011-08-09 21:21:20 UTC (rev 92708)
@@ -1,5 +1,21 @@
 2011-08-09  Adam

[webkit-changes] [92709] trunk/Source/WebCore

2011-08-09 Thread jpfau

Title: [92709] trunk/Source/WebCore








Revision 92709
Author jp...@apple.com
Date 2011-08-09 14:32:04 -0700 (Tue, 09 Aug 2011)


Log Message
Initial pass at a new XML tree builder
https://bugs.webkit.org/show_bug.cgi?id=65803

Reviewed by Adam Barth.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::~NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::append):
(WebCore::NewXMLDocumentParser::finish):
(WebCore::NewXMLDocumentParser::finishWasCalled):
* xml/parser/NewXMLDocumentParser.h:
* xml/parser/XMLTreeBuilder.cpp: Added.
(WebCore::XMLTreeBuilder::XMLTreeBuilder):
(WebCore::XMLTreeBuilder::processToken):
(WebCore::XMLTreeBuilder::pushCurrentNode):
(WebCore::XMLTreeBuilder::popCurrentNode):
(WebCore::XMLTreeBuilder::processProcessingInstruction):
(WebCore::XMLTreeBuilder::processXMLDeclaration):
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::processEndTag):
(WebCore::XMLTreeBuilder::processCharacter):
(WebCore::XMLTreeBuilder::processCDATA):
(WebCore::XMLTreeBuilder::processComment):
(WebCore::XMLTreeBuilder::processEntity):
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
(WebCore::XMLTreeBuilder::processXMLEntity):
(WebCore::XMLTreeBuilder::processHTMLEntity):
(WebCore::XMLTreeBuilder::add):
(WebCore::XMLTreeBuilder::appendToText):
(WebCore::XMLTreeBuilder::enterText):
(WebCore::XMLTreeBuilder::exitText):
(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
(WebCore::XMLTreeBuilder::NodeStackItem::hasNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceForPrefix):
* xml/parser/XMLTreeBuilder.h: Added.
(WebCore::XMLTreeBuilder::create):
(WebCore::XMLTreeBuilder::NodeStackItem::namespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::setNamespaceURI):
(WebCore::XMLTreeBuilder::NodeStackItem::node):
(WebCore::XMLTreeBuilder::NodeStackItem::setNode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.cpp
trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.h


Added Paths

trunk/Source/WebCore/xml/parser/XMLTreeBuilder.cpp
trunk/Source/WebCore/xml/parser/XMLTreeBuilder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92708 => 92709)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 21:21:20 UTC (rev 92708)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 21:32:04 UTC (rev 92709)
@@ -1,3 +1,56 @@
+2011-08-09  Jeffrey Pfau  jp...@apple.com
+
+Initial pass at a new XML tree builder
+https://bugs.webkit.org/show_bug.cgi?id=65803
+
+Reviewed by Adam Barth.
+
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.pro:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* xml/parser/NewXMLDocumentParser.cpp:
+(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
+(WebCore::NewXMLDocumentParser::~NewXMLDocumentParser):
+(WebCore::NewXMLDocumentParser::append):
+(WebCore::NewXMLDocumentParser::finish):
+(WebCore::NewXMLDocumentParser::finishWasCalled):
+* xml/parser/NewXMLDocumentParser.h:
+* xml/parser/XMLTreeBuilder.cpp: Added.
+(WebCore::XMLTreeBuilder::XMLTreeBuilder):
+(WebCore::XMLTreeBuilder::processToken):
+(WebCore::XMLTreeBuilder::pushCurrentNode):
+(WebCore::XMLTreeBuilder::popCurrentNode):
+(WebCore::XMLTreeBuilder::processProcessingInstruction):
+(WebCore::XMLTreeBuilder::processXMLDeclaration):
+(WebCore::XMLTreeBuilder::processDOCTYPE):
+(WebCore::XMLTreeBuilder::processStartTag):
+(WebCore::XMLTreeBuilder::processEndTag):
+(WebCore::XMLTreeBuilder::processCharacter):
+(WebCore::XMLTreeBuilder::processCDATA):
+(WebCore::XMLTreeBuilder::processComment):
+(WebCore::XMLTreeBuilder::processEntity):
+(WebCore::XMLTreeBuilder::processNamespaces):
+(WebCore::XMLTreeBuilder::processAttributes):
+(WebCore::XMLTreeBuilder::processXMLEntity):
+(WebCore::XMLTreeBuilder::processHTMLEntity):
+(WebCore::XMLTreeBuilder::add):
+(WebCore::XMLTreeBuilder::appendToText):
+(WebCore::XMLTreeBuilder::enterText):
+(WebCore::XMLTreeBuilder::exitText):
+(WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):
+(WebCore::XMLTreeBuilder::NodeStackItem::hasNamespaceURI):
+

[webkit-changes] [92712] trunk/Source/WebCore

2011-08-09 Thread eae

Title: [92712] trunk/Source/WebCore








Revision 92712
Author e...@chromium.org
Date 2011-08-09 14:52:39 -0700 (Tue, 09 Aug 2011)


Log Message
Switch RenderBlock to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65396

Reviewed by Eric Seidel.

No new tests, no new functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::adjustFloatingBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::RenderBlock::isPointInOverflowControl):
(WebCore::RenderBlock::hitTestFloats):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92711 => 92712)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 21:45:54 UTC (rev 92711)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 21:52:39 UTC (rev 92712)
@@ -1,3 +1,41 @@
+2011-08-09  Emil A Eklund  e...@chromium.org
+
+Switch RenderBlock to to new layout types
+https://bugs.webkit.org/show_bug.cgi?id=65396
+
+Reviewed by Eric Seidel.
+
+No new tests, no new functionality.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::MarginInfo::MarginInfo):
+(WebCore::RenderBlock::layoutBlock):
+(WebCore::RenderBlock::addOverflowFromChildren):
+(WebCore::RenderBlock::computeOverflow):
+(WebCore::RenderBlock::adjustPositionedBlock):
+(WebCore::RenderBlock::adjustFloatingBlock):
+(WebCore::RenderBlock::collapseMargins):
+(WebCore::RenderBlock::clearFloatsIfNeeded):
+(WebCore::RenderBlock::estimateLogicalTopPosition):
+(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
+(WebCore::RenderBlock::setLogicalLeftForChild):
+(WebCore::RenderBlock::setLogicalTopForChild):
+(WebCore::RenderBlock::layoutBlockChildren):
+(WebCore::RenderBlock::layoutBlockChild):
+(WebCore::RenderBlock::flipFloatForWritingMode):
+(WebCore::RenderBlock::isPointInOverflowControl):
+(WebCore::RenderBlock::hitTestFloats):
+* rendering/RenderBlock.h:
+(WebCore::RenderBlock::logicalTopForFloat):
+(WebCore::RenderBlock::logicalBottomForFloat):
+(WebCore::RenderBlock::logicalLeftForFloat):
+(WebCore::RenderBlock::logicalRightForFloat):
+(WebCore::RenderBlock::logicalWidthForFloat):
+(WebCore::RenderBlock::setLogicalTopForFloat):
+(WebCore::RenderBlock::setLogicalLeftForFloat):
+(WebCore::RenderBlock::setLogicalHeightForFloat):
+(WebCore::RenderBlock::setLogicalWidthForFloat):
+
 2011-08-09  Jeffrey Pfau  jp...@apple.com
 
 Initial pass at a new XML tree builder


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (92711 => 92712)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-08-09 21:45:54 UTC (rev 92711)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-08-09 21:52:39 UTC (rev 92712)
@@ -81,7 +81,7 @@
 bool RenderBlock::s_canPropagateFloatIntoSibling = false;
 
 // Our MarginInfo state used when laying out block children.
-RenderBlock::MarginInfo::MarginInfo(RenderBlock* block, int beforeBorderPadding, int afterBorderPadding)
+RenderBlock::MarginInfo::MarginInfo(RenderBlock* block, LayoutUnit beforeBorderPadding, LayoutUnit afterBorderPadding)
 : m_atBeforeSideOfBlock(true)
 , m_atAfterSideOfBlock(false)
 , m_marginBeforeQuirk(false)
@@ -1166,7 +1166,7 @@
 clearLayoutOverflow();
 }
 
-void RenderBlock::layoutBlock(bool relayoutChildren, int pageLogicalHeight, BlockLayoutPass layoutPass)
+void RenderBlock::layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight, BlockLayoutPass layoutPass)
 {
 ASSERT(needsLayout());
 
@@ -1178,8 +1178,8 @@
 
 LayoutRepainter repainter(*this, m_everHadLayout  checkForRepaintDuringLayout());
 
-int oldWidth = logicalWidth();
-int oldColumnWidth =

[webkit-changes] [92713] trunk/Source/WebKit2

2011-08-09 Thread andersca

Title: [92713] trunk/Source/WebKit2








Revision 92713
Author ander...@apple.com
Date 2011-08-09 14:52:55 -0700 (Tue, 09 Aug 2011)


Log Message
Add a user default to disable the plug-in process message timeout
https://bugs.webkit.org/show_bug.cgi?id=65945

Reviewed by Adam Roben.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Add a disablePluginProcessMessageTimeout member variable.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):
Initialize the disablePluginProcessMessageTimeout member variable from the 
DisablePluginProcessMessageTimeout user default.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::defaultSyncMessageTimeout):
Return NoTimeout if WebProcess::disablePluginProcessMessageTimeout returns true.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
Initialize m_disablePluginProcessMessageTimeout.

* WebProcess/WebProcess.h:
(WebKit::WebProcess::disablePluginProcessMessageTimeout):
Add getter.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92712 => 92713)

--- trunk/Source/WebKit2/ChangeLog	2011-08-09 21:52:39 UTC (rev 92712)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-09 21:52:55 UTC (rev 92713)
@@ -1,3 +1,34 @@
+2011-08-09  Anders Carlsson  ander...@apple.com
+
+Add a user default to disable the plug-in process message timeout
+https://bugs.webkit.org/show_bug.cgi?id=65945
+
+Reviewed by Adam Roben.
+
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::encode):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+Add a disablePluginProcessMessageTimeout member variable.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformInitializeWebProcess):
+Initialize the disablePluginProcessMessageTimeout member variable from the 
+DisablePluginProcessMessageTimeout user default.
+
+* WebProcess/Plugins/PluginProcessConnection.cpp:
+(WebKit::defaultSyncMessageTimeout):
+Return NoTimeout if WebProcess::disablePluginProcessMessageTimeout returns true.
+
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::WebProcess):
+(WebKit::WebProcess::initializeWebProcess):
+Initialize m_disablePluginProcessMessageTimeout.
+
+* WebProcess/WebProcess.h:
+(WebKit::WebProcess::disablePluginProcessMessageTimeout):
+Add getter.
+
 2011-08-09  Mark Hahnenberg  mhahnenb...@apple.com
 
 Add ParentClass typedef in all JSC classes


Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (92712 => 92713)

--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2011-08-09 21:52:39 UTC (rev 92712)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp	2011-08-09 21:52:55 UTC (rev 92713)
@@ -61,6 +61,9 @@
 encoder-encode(shouldTrackVisitedLinks);
 encoder-encode(shouldAlwaysUseComplexTextCodePath);
 encoder-encode(iconDatabaseEnabled);
+#if ENABLE(PLUGIN_PROCESS)
+encoder-encode(disablePluginProcessMessageTimeout);
+#endif
 encoder-encode(languageCode);
 encoder-encode(textCheckerState);
 encoder-encode(defaultRequestTimeoutInterval);
@@ -118,6 +121,11 @@
 return false;
 if (!decoder-decode(parameters.iconDatabaseEnabled))
 return false;
+#if ENABLE(PLUGIN_PROCESS)
+if (!decoder-decode(parameters.disablePluginProcessMessageTimeout))
+return false;
+#endif
+
 if (!decoder-decode(parameters.languageCode))
 return false;
 if (!decoder-decode(parameters.textCheckerState))


Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h (92712 => 92713)

--- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2011-08-09 21:52:39 UTC (rev 92712)
+++ trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h	2011-08-09 21:52:55 UTC (rev 92713)
@@ -70,6 +70,10 @@
 
 bool iconDatabaseEnabled;
 
+#if ENABLE(PLUGIN_PROCESS)
+bool disablePluginProcessMessageTimeout;
+#endif
+
 String languageCode;
 
 TextCheckerState textCheckerState;


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (92712 => 92713)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-08-09 21:52:39 UTC (rev 92712)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-08-09 21:52:55 UTC (rev 92713)
@@ -86,6 +86,10

[webkit-changes] [92714] trunk/LayoutTests

2011-08-09 Thread andersca

Title: [92714] trunk/LayoutTests








Revision 92714
Author ander...@apple.com
Date 2011-08-09 14:53:59 -0700 (Tue, 09 Aug 2011)


Log Message
Tweak an expected result.

* platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92713 => 92714)

--- trunk/LayoutTests/ChangeLog	2011-08-09 21:52:55 UTC (rev 92713)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 21:53:59 UTC (rev 92714)
@@ -1,3 +1,9 @@
+2011-08-09  Anders Carlsson  ander...@apple.com
+
+Tweak an expected result.
+
+* platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:
+
 2011-08-09  Filip Pizlo  fpi...@apple.com
 
 DFG JIT failure loading web site


Modified: trunk/LayoutTests/platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt (92713 => 92714)

--- trunk/LayoutTests/platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt	2011-08-09 21:52:55 UTC (rev 92713)
+++ trunk/LayoutTests/platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt	2011-08-09 21:53:59 UTC (rev 92714)
@@ -54,7 +54,7 @@
 example-dlyan.dlyan has MIME type text/plain
 example-dmg.dmg has MIME type application/x-diskcopy
 example-dms.dms has MIME type application/octet-stream
-example-dng.dng has MIME type image/x-adobe-dng
+example-dng.dng has MIME type application/octet-stream
 example-doc.doc has MIME type application/msword
 example-docm.docm has MIME type application/vnd.ms-word.document.macroenabled.12
 example-docx.docx has MIME type application/vnd.openxmlformats-officedocument.wordprocessingml.document






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92715] trunk/Source/ThirdParty

2011-08-09 Thread mrowe

Title: [92715] trunk/Source/ThirdParty








Revision 92715
Author mr...@apple.com
Date 2011-08-09 15:09:07 -0700 (Tue, 09 Aug 2011)


Log Message
Fix gtest to compile in the release configuration with clang.

This change was made upstream in r443.

* gtest/src/gtest.cc:

Modified Paths

trunk/Source/ThirdParty/ChangeLog
trunk/Source/ThirdParty/gtest/src/gtest.cc




Diff

Modified: trunk/Source/ThirdParty/ChangeLog (92714 => 92715)

--- trunk/Source/ThirdParty/ChangeLog	2011-08-09 21:53:59 UTC (rev 92714)
+++ trunk/Source/ThirdParty/ChangeLog	2011-08-09 22:09:07 UTC (rev 92715)
@@ -1,3 +1,11 @@
+2011-08-09  Mark Rowe  mr...@apple.com
+
+Fix gtest to compile in the release configuration with clang.
+
+This change was made upstream in r443.
+
+* gtest/src/gtest.cc:
+
 2011-08-04  Mark Rowe  mr...@apple.com
 
 Future-proof Xcode configuration settings.


Modified: trunk/Source/ThirdParty/gtest/src/gtest.cc (92714 => 92715)

--- trunk/Source/ThirdParty/gtest/src/gtest.cc	2011-08-09 21:53:59 UTC (rev 92714)
+++ trunk/Source/ThirdParty/gtest/src/gtest.cc	2011-08-09 22:09:07 UTC (rev 92715)
@@ -3602,7 +3602,7 @@
   // the --gtest_catch_exceptions flags are specified.
   DebugBreak();
 #else
-  *static_castint*(NULL) = 1;
+  *static_castvolatile int*(NULL) = 1;
 #endif  // GTEST_OS_WINDOWS
 } else if (GTEST_FLAG(throw_on_failure)) {
 #if GTEST_HAS_EXCEPTIONS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92716] trunk/Source/WebKit2

2011-08-09 Thread andersca

Title: [92716] trunk/Source/WebKit2








Revision 92716
Author ander...@apple.com
Date 2011-08-09 15:10:27 -0700 (Tue, 09 Aug 2011)


Log Message
Add a WebKit prefix to the user default.

Reviewed by Dan Bernstein.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92715 => 92716)

--- trunk/Source/WebKit2/ChangeLog	2011-08-09 22:09:07 UTC (rev 92715)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-09 22:10:27 UTC (rev 92716)
@@ -1,5 +1,14 @@
 2011-08-09  Anders Carlsson  ander...@apple.com
 
+Add a WebKit prefix to the user default.
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/mac/WebContextMac.mm:
+(WebKit::WebContext::platformInitializeWebProcess):
+
+2011-08-09  Anders Carlsson  ander...@apple.com
+
 Add a user default to disable the plug-in process message timeout
 https://bugs.webkit.org/show_bug.cgi?id=65945
 


Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm (92715 => 92716)

--- trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-08-09 22:09:07 UTC (rev 92715)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm	2011-08-09 22:10:27 UTC (rev 92716)
@@ -87,7 +87,7 @@
 ASSERT(!parameters.nsURLCachePath.isEmpty());
 
 #if ENABLE(PLUGIN_PROCESS)
-parameters.disablePluginProcessMessageTimeout = [[NSUserDefaults standardUserDefaults] boolForKey:@DisablePluginProcessMessageTimeout];
+parameters.disablePluginProcessMessageTimeout = [[NSUserDefaults standardUserDefaults] boolForKey:@WebKitDisablePluginProcessMessageTimeout];
 #endif
 
 #if USE(ACCELERATED_COMPOSITING)  HAVE(HOSTED_CORE_ANIMATION)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92717] trunk/Tools

2011-08-09 Thread eric

Title: [92717] trunk/Tools








Revision 92717
Author e...@webkit.org
Date 2011-08-09 15:12:01 -0700 (Tue, 09 Aug 2011)


Log Message
new-run-webkit-test's WinPort has no fallback logic
https://bugs.webkit.org/show_bug.cgi?id=64486

Reviewed by Adam Roben.

I've tried to write a patch for bug 64439 twice now, and both times
I've ended up re-writing half the port system.  So I'm breaking
things up into smaller pieces, this being the first.

WinPort still does not have any port_name parsing, so when instantiated
with the name win-xp (i.e. by the rebaseline server) it will just behave as the 'win' port.
I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.

Otherwise this should just work for windows.  I've not been able to test the
version detection on my mac, but the unit tests show the code behaving as designed.

* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92716 => 92717)

--- trunk/Tools/ChangeLog	2011-08-09 22:10:27 UTC (rev 92716)
+++ trunk/Tools/ChangeLog	2011-08-09 22:12:01 UTC (rev 92717)
@@ -1,3 +1,24 @@
+2011-07-13  Eric Seidel  e...@webkit.org
+
+new-run-webkit-test's WinPort has no fallback logic
+https://bugs.webkit.org/show_bug.cgi?id=64486
+
+Reviewed by Adam Roben.
+
+I've tried to write a patch for bug 64439 twice now, and both times
+I've ended up re-writing half the port system.  So I'm breaking
+things up into smaller pieces, this being the first.
+
+WinPort still does not have any port_name parsing, so when instantiated
+with the name win-xp (i.e. by the rebaseline server) it will just behave as the 'win' port.
+I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
+
+Otherwise this should just work for windows.  I've not been able to test the
+version detection on my mac, but the unit tests show the code behaving as designed.
+
+* Scripts/webkitpy/layout_tests/port/win.py:
+* Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
+
 2011-08-09  Adam Barth  aba...@webkit.org
 
 Teach build.webkit.org's garden-o-matic how to talk to the local server


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py (92716 => 92717)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py	2011-08-09 22:10:27 UTC (rev 92716)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_configuration.py	2011-08-09 22:12:01 UTC (rev 92717)
@@ -30,6 +30,7 @@
 
 class TestConfiguration(object):
 def __init__(self, port=None, version=None, architecture=None, build_type=None, graphics_type=None):
+# FIXME: TestConfiguration() fails due to port == None.
 self.version = version or port.version()
 self.architecture = architecture or port.architecture()
 self.build_type = build_type or port.options.configuration.lower()


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (92716 => 92717)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2011-08-09 22:10:27 UTC (rev 92716)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py	2011-08-09 22:12:01 UTC (rev 92717)
@@ -521,8 +521,7 @@
 has_base64 = False
 
 uri = self._port.test_to_uri(driver_input.test_name)
-cmd = self._test_shell_command(uri, driver_input.timeout,
-   driver_input.image_hash)
+cmd = self._test_shell_command(uri, driver_input.timeout, driver_input.image_hash)
 (line, crash) = self._write_command_and_read_line(input=cmd)
 
 while not crash and line.rstrip() != #EOF:


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py (92716 => 92717)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py	2011-08-09 22:10:27 UTC (rev 92716)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/win.py	2011-08-09 22:12:01 UTC (rev 92717)
@@ -26,11 +26,12 @@
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-WebKit Win implementation of the Port interface.
-
 import logging
+import re
+import sys
 
 from webkitpy.layout_tests.models.test_configuration import TestConfiguration
+from webkitpy.common.system.executive import ScriptError
 from webkitpy.layout_tests.port.webkit import WebKitPort
 
 
@@ -40,23 +41,61 @@
 class WinPort(WebKitPort):
 port_name = win
 
-FALLBACK_PATHS = {
-'win7': [
-win,
-mac-snowleopard,
-mac,
-],
-

[webkit-changes] [92719] trunk/LayoutTests

2011-08-09 Thread andersca

Title: [92719] trunk/LayoutTests








Revision 92719
Author ander...@apple.com
Date 2011-08-09 15:31:14 -0700 (Tue, 09 Aug 2011)


Log Message
Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's
possible to have a pixel test result in a different platform directory from a text result.

* platform/mac-snowleopard/svg/W3C-I18N: Added.
* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt


Added Paths

trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-I18N/
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92718 => 92719)

--- trunk/LayoutTests/ChangeLog	2011-08-09 22:23:09 UTC (rev 92718)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 22:31:14 UTC (rev 92719)
@@ -1,5 +1,14 @@
 2011-08-09  Anders Carlsson  ander...@apple.com
 
+Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's
+possible to have a pixel test result in a different platform directory from a text result.
+
+* platform/mac-snowleopard/svg/W3C-I18N: Added.
+* platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
+* platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
+
+2011-08-09  Anders Carlsson  ander...@apple.com
+
 Tweak an expected result.
 
 * platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt:


Modified: trunk/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt (92718 => 92719)

--- trunk/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt	2011-08-09 22:23:09 UTC (rev 92718)
+++ trunk/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt	2011-08-09 22:31:14 UTC (rev 92719)
@@ -9,9 +9,9 @@
   RenderSVGText {text} at (78,185) size 152x13 contains 1 chunk(s)
 RenderSVGInlineText {#text} at (0,0) size 152x13
   chunk 1 (end anchor) text run 1 at (78.80,195.00) startOffset 0 endOffset 31 width 151.20 RTL: \x{5DC}\x{5D9}\x{5E6}\x{5D5}\x{5E8} \x{5DE}\x{5D4}\x{5E8}\x{5E9}\x{5EA} \x{5E8}\x{5E9}\x{5EA} \x{5DB}\x{5DC}\x{5DC} \x{5E2}\x{5D5}\x{5DC}\x{5DE}\x{5D9}\x{5EA} \x{5D1}\x{5D0}\x{5DE}\x{5EA}
-  RenderSVGText {text} at (110,225) size 120x13 contains 1 chunk(s)
-RenderSVGInlineText {#text} at (0,0) size 120x13
-  chunk 1 (end anchor) text run 1 at (110.60,235.00) startOffset 0 endOffset 38 width 119.40 RTL: \x{62C}\x{639}\x{644} \x{634}\x{628}\x{643}\x{629} \x{627}\x{644}\x{648}\x{64A}\x{628} \x{627}\x{644}\x{639}\x{627}\x{644}\x{645}\x{64A}\x{651}\x{629} \x{639}\x{627}\x{644}\x{645}\x{64A}\x{651}\x{629} \x{62D}\x{642}\x{64B}\x{651}\x{627}
+  RenderSVGText {text} at (111,225) size 119x13 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 119x13
+  chunk 1 (end anchor) text run 1 at (111.20,235.00) startOffset 0 endOffset 38 width 118.80 RTL: \x{62C}\x{639}\x{644} \x{634}\x{628}\x{643}\x{629} \x{627}\x{644}\x{648}\x{64A}\x{628} \x{627}\x{644}\x{639}\x{627}\x{644}\x{645}\x{64A}\x{651}\x{629} \x{639}\x{627}\x{644}\x{645}\x{64A}\x{651}\x{629} \x{62D}\x{642}\x{64B}\x{651}\x{627}
   RenderSVGImage {image} at (280,183) size 214x44
 RenderSVGContainer {g} at (16,556) size 76x14
   RenderSVGText {text} at (10,334) size 45x8 contains 1 chunk(s)


Copied: trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt (from rev 92704, trunk/LayoutTests/platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt) (0 => 92719)

--- trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt	2011-08-09 22:31:14 UTC (rev 92719)
@@ -0,0 +1,25 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderSVGRoot {svg} at (0,0) size 800x600
+RenderSVGContainer {g} at (60,183) size 434x214
+  RenderSVGText {text} at (36,150) size 194x13 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 194x13
+  chunk 1 (end anchor) text run 1 at (36.20,160.00) startOffset 0 endOffset 42 width 193.80: Making the world wide web truly world wide
+  RenderSVGText {text} at (78,185) size 152x13 contains 1 chunk(s)
+RenderSVGInlineText {#text} at (0,0) size 152x13
+  chunk 1 (end anchor) text run 1 at (78.80,195.00) startOffset 0 endOffset

[webkit-changes] [92720] trunk/Websites/webkit.org

2011-08-09 Thread andersca

Title: [92720] trunk/Websites/webkit.org








Revision 92720
Author ander...@apple.com
Date 2011-08-09 15:39:09 -0700 (Tue, 09 Aug 2011)


Log Message
Broken link to LICENSE on contributing code page
https://bugs.webkit.org/show_bug.cgi?id=65947

Reviewed by Ryosuke Niwa.

* coding/contributing.html:

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/coding/contributing.html




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (92719 => 92720)

--- trunk/Websites/webkit.org/ChangeLog	2011-08-09 22:31:14 UTC (rev 92719)
+++ trunk/Websites/webkit.org/ChangeLog	2011-08-09 22:39:09 UTC (rev 92720)
@@ -1,3 +1,12 @@
+2011-08-09  Anders Carlsson  ander...@apple.com
+
+Broken link to LICENSE on contributing code page
+https://bugs.webkit.org/show_bug.cgi?id=65947
+
+Reviewed by Ryosuke Niwa.
+
+* coding/contributing.html:
+
 2011-08-04  Dan Bernstein  m...@apple.com
 
 Fixed a typo.


Modified: trunk/Websites/webkit.org/coding/contributing.html (92719 => 92720)

--- trunk/Websites/webkit.org/coding/contributing.html	2011-08-09 22:31:14 UTC (rev 92719)
+++ trunk/Websites/webkit.org/coding/contributing.html	2011-08-09 22:39:09 UTC (rev 92720)
@@ -79,7 +79,7 @@
 you introduce contain license text at the beginning of the file.
 If you are the author of a new file, preferred license text to include
 can be found here:
-a href=""
+a href=""
 (The Original Format link at the bottom of the page contains text
 that can be cut and pasted more easily.) Simply replace the copyright
 line with your own information, for example as suggested above.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92721] trunk/LayoutTests

2011-08-09 Thread aestes

Title: [92721] trunk/LayoutTests








Revision 92721
Author aes...@apple.com
Date 2011-08-09 15:45:55 -0700 (Tue, 09 Aug 2011)


Log Message
Add a Radar number to a skipped test.

* platform/mac-lion/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-lion/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92720 => 92721)

--- trunk/LayoutTests/ChangeLog	2011-08-09 22:39:09 UTC (rev 92720)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 22:45:55 UTC (rev 92721)
@@ -1,3 +1,9 @@
+2011-08-09  Andy Estes  aes...@apple.com
+
+Add a Radar number to a skipped test.
+
+* platform/mac-lion/Skipped:
+
 2011-08-09  Anders Carlsson  ander...@apple.com
 
 Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's


Modified: trunk/LayoutTests/platform/mac-lion/Skipped (92720 => 92721)

--- trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-09 22:39:09 UTC (rev 92720)
+++ trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-09 22:45:55 UTC (rev 92721)
@@ -29,10 +29,12 @@
 # rdar://problem/9348555
 fast/canvas/set-colors.html
 
+# rdar://problem/9924676
+fast/canvas/canvas-scale-strokePath-shadow.html
+
 # Unknown canvas test failures
 canvas/philip/tests/2d.text.draw.baseline.ideographic.html
 fast/canvas/canvas-draw-canvas-on-canvas-shadow.html
-fast/canvas/canvas-scale-strokePath-shadow.html
 fast/canvas/canvas-strokePath-gradient-shadow.html
 fast/canvas/canvas-strokeRect-alpha-shadow.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92723] tags/Safari-534.51.11/

2011-08-09 Thread lforschler

Title: [92723] tags/Safari-534.51.11/








Revision 92723
Author lforsch...@apple.com
Date 2011-08-09 16:01:38 -0700 (Tue, 09 Aug 2011)


Log Message
New tag.

Added Paths

tags/Safari-534.51.11/




Diff

Property changes: tags/Safari-534.51.11



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92724] trunk/LayoutTests

2011-08-09 Thread andersca

Title: [92724] trunk/LayoutTests








Revision 92724
Author ander...@apple.com
Date 2011-08-09 16:18:02 -0700 (Tue, 09 Aug 2011)


Log Message
Skip a couple of SVG tests that are missing parts of the content for some odd reason.

* platform/mac-lion/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-lion/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92723 => 92724)

--- trunk/LayoutTests/ChangeLog	2011-08-09 23:01:38 UTC (rev 92723)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 23:18:02 UTC (rev 92724)
@@ -1,5 +1,11 @@
 2011-08-09  Anders Carlsson  ander...@apple.com
 
+Skip a couple of SVG tests that are missing parts of the content for some odd reason.
+
+* platform/mac-lion/Skipped:
+
+2011-08-09  Anders Carlsson  ander...@apple.com
+
 Add Lion tests results for a couple of bidi SVG tests.
 
 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.


Modified: trunk/LayoutTests/platform/mac-lion/Skipped (92723 => 92724)

--- trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-09 23:01:38 UTC (rev 92723)
+++ trunk/LayoutTests/platform/mac-lion/Skipped	2011-08-09 23:18:02 UTC (rev 92724)
@@ -118,6 +118,20 @@
 # WebKit1 OOP plug-ins: Exceptions aren't thrown on invoke failure.
 plugins/npruntime/invoke-failure.html
 
+# --- SVG ---
+
+# Missing some of the content.
+svg/W3C-SVG-1.1/coords-viewattr-01-b.svg
+svg/W3C-SVG-1.1/coords-viewattr-02-b.svg
+svg/custom/preserve-aspect-ratio-syntax.svg
+svg/custom/viewbox-syntax.svg
+svg/zoom/page/zoom-coords-viewattr-01-b.svg
+svg/zoom/text/zoom-coords-viewattr-01-b.svg
+svg/W3C-SVG-1.1/render-elems-03-t.svg
+
+# Has text chunked differently from Snow Leopard.
+svg/W3C-SVG-1.1-SE/types-dom-01-b.svg
+
 # --- Misc failures that need investigation ---
 
 # These fail in DRT but look correct in Safari.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92725] trunk/LayoutTests

2011-08-09 Thread andersca

Title: [92725] trunk/LayoutTests








Revision 92725
Author ander...@apple.com
Date 2011-08-09 16:25:45 -0700 (Tue, 09 Aug 2011)


Log Message
Add the final batch of Lion specific SVG test results.

* platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
* platform/mac-snowleopard/svg/text: Added.
* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png.
* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt.
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.png:
* platform/mac/svg/text/text-intro-05-t-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt
trunk/LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt


Added Paths

trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt
trunk/LayoutTests/platform/mac-snowleopard/svg/text/
trunk/LayoutTests/platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92724 => 92725)

--- trunk/LayoutTests/ChangeLog	2011-08-09 23:18:02 UTC (rev 92724)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 23:25:45 UTC (rev 92725)
@@ -1,5 +1,24 @@
 2011-08-09  Anders Carlsson  ander...@apple.com
 
+Add the final batch of Lion specific SVG test results.
+
+* platform/mac-snowleopard/svg/W3C-SVG-1.1: Added.
+* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
+* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
+* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
+* platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
+* platform/mac-snowleopard/svg/text: Added.
+* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png.
+* platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt.
+* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
+* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
+* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
+* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
+* platform/mac/svg/text/text-intro-05-t-expected.png:
+* platform/mac/svg/text/text-intro-05-t-expected.txt:
+
+2011-08-09  Anders Carlsson  ander...@apple.com
+
 Skip a couple of SVG tests that are missing parts of the content for some odd reason.
 
 * platform/mac-lion/Skipped:


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt (92724 => 92725)

--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt	2011-08-09 23:18:02 UTC (rev 92724)
+++

[webkit-changes] [92726] branches/chromium/835/Source

2011-08-09 Thread vangelis

Title: [92726] branches/chromium/835/Source








Revision 92726
Author vange...@chromium.org
Date 2011-08-09 16:39:37 -0700 (Tue, 09 Aug 2011)


Log Message
Merge 92002 - Scroll animation refinements.
https://bugs.webkit.org/show_bug.cgi?id=65154

Patch by Scott Byer scottb...@chromium.org on 2011-07-29
Reviewed by Adam Barth.

Fix scroll animation bugs when scrolling to the ends of a document. Smooth over slow event repeat rates
better. Fix tests to allow for unit testing of scrolling up and not just down.

Source/WebCore:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::Parameters::Parameters):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::scroll):
* platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

Additional unit tests added to ScrollAnimatorNoneTest:
ScrollQuadraticSmoothed, ScrollLotsQuadraticSmoothed, ScrollDownToBumper, ScrollUpToBumper

* tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::reset):
(ScrollAnimatorNoneTest::updateDataFromParameters):
(ScrollAnimatorNoneTest::animateScroll):
(ScrollAnimatorNoneTest::checkDesiredPosition):
(ScrollAnimatorNoneTest::checkSoftLanding):

TBR=commit-qu...@webkit.org
Review URL: http://codereview.chromium.org/7590014

Modified Paths

branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp
branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.h
branches/chromium/835/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp (92725 => 92726)

--- branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp	2011-08-09 23:25:45 UTC (rev 92725)
+++ branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp	2011-08-09 23:39:37 UTC (rev 92726)
@@ -44,6 +44,8 @@
 #include wtf/CurrentTime.h
 #include wtf/PassOwnPtr.h
 
+using namespace std;
+
 namespace WebCore {
 
 static double kTickTime = .0166;
@@ -63,9 +65,10 @@
 {
 }
 
-ScrollAnimatorNone::Parameters::Parameters(bool isEnabled, double animationTime, Curve attackCurve, double attackTime, Curve releaseCurve, double releaseTime)
+ScrollAnimatorNone::Parameters::Parameters(bool isEnabled, double animationTime, double repeatMinimumSustainTime, Curve attackCurve, double attackTime, Curve releaseCurve, double releaseTime)
 : m_isEnabled(isEnabled)
 , m_animationTime(animationTime)
+, m_repeatMinimumSustainTime(repeatMinimumSustainTime)
 , m_attackCurve(attackCurve)
 , m_attackTime(attackTime)
 , m_releaseCurve(releaseCurve)
@@ -159,7 +162,8 @@
 
 bool ScrollAnimatorNone::PerAxisData::updateDataFromParameters(ScrollbarOrientation orientation, float step, float multiplier, float scrollableSize, double currentTime, Parameters* parameters)
 {
-m_animationTime = parameters-m_animationTime;
+if (parameters-m_animationTime  m_animationTime)
+m_animationTime = parameters-m_animationTime;
 m_attackTime = parameters-m_attackTime;
 m_releaseTime = parameters-m_releaseTime;
 m_attackCurve = parameters-m_attackCurve;
@@ -174,12 +178,12 @@
 
 m_orientation = orientation;
 
-if (!m_desiredPosition)
+if (!m_startTime)
 m_desiredPosition = *m_currentPosition;
 float newPosition = m_desiredPosition + (step * multiplier);
 
 if (newPosition  0 || newPosition  scrollableSize)
-newPosition = std::max(std::min(newPosition, scrollableSize), 0.0f);
+newPosition = max(min(newPosition, scrollableSize), 0.0f);
 
 if (newPosition == m_desiredPosition)
 return false;
@@ -199,15 +203,17 @@
 double attackAreaLeft = 0;
 
 double deltaTime = m_lastAnimationTime - m_startTime;
+double attackTimeLeft = max(0., m_attackTime - deltaTime);
 double timeLeft = m_animationTime - deltaTime;
-if (timeLeft  m_releaseTime) {
-m_animationTime = deltaTime + m_releaseTime;
-timeLeft = m_releaseTime;
+double minTimeLeft = m_releaseTime + min(parameters-m_repeatMinimumSustainTime, m_animationTime - m_releaseTime - attackTimeLeft);
+if (timeLeft  minTimeLeft) {
+m_animationTime = deltaTime + minTimeLeft;
+timeLeft = minTimeLeft;
 }
-double releaseTimeLeft = std::min(timeLeft, m_releaseTime);
-double attackTimeLeft = std::max(0., m_attackTime - deltaTime);
-double sustainTimeLeft = std::max(0., timeLeft - releaseTimeLeft - attackTimeLeft);
 
+double releaseTimeLeft = min(timeLeft, m_releaseTime);
+double sustainTimeLeft = max(0., timeLeft - releaseTimeLeft - attackTimeLeft);
+
 if (attackTimeLeft) {
 double attackSpot = deltaTime / m_attackTime;
 attackAreaLeft = attackTimeLeft / (curveDerivativeAt(m_attackCurve, 1) - curveDerivativeAt(m_attackCurve, attackSpot));
@@ -289,13 +295,13 @@
 case

[webkit-changes] [92727] branches/chromium/835/Source

2011-08-09 Thread vangelis

Title: [92727] branches/chromium/835/Source








Revision 92727
Author vange...@chromium.org
Date 2011-08-09 16:54:21 -0700 (Tue, 09 Aug 2011)


Log Message
Merge 92639 - Scroll animator changes to nail the framerate
https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer scottb...@chromium.org on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):
* platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

* tests/ScrollAnimatorNoneTest.cpp:
(TEST):

TBR=commit-qu...@webkit.org
Review URL: http://codereview.chromium.org/7604015

Modified Paths

branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp
branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.h
branches/chromium/835/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp (92726 => 92727)

--- branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp	2011-08-09 23:39:37 UTC (rev 92726)
+++ branches/chromium/835/Source/WebCore/platform/ScrollAnimatorNone.cpp	2011-08-09 23:54:21 UTC (rev 92727)
@@ -48,11 +48,10 @@
 
 namespace WebCore {
 
-static double kTickTime = .0166;
+static double kFrameRate = 60;
+static double kTickTime = 1 / kFrameRate;
+static double kMinimumTimerInterval = .001;
 
-// This is used to set the timer delay - it needs to be slightly smaller than the tick count to leave some overhead.
-static double kAnimationTimerDelay = 0.015;
-
 PassOwnPtrScrollAnimator ScrollAnimator::create(ScrollableArea* scrollableArea)
 {
 if (scrollableArea  scrollableArea-scrollAnimatorEnabled())
@@ -131,7 +130,6 @@
 
 ScrollAnimatorNone::PerAxisData::PerAxisData(ScrollAnimatorNone* parent, float* currentPosition)
 : m_currentPosition(currentPosition)
-, m_animationTimer(parent, ScrollAnimatorNone::animationTimerFired)
 {
 reset();
 }
@@ -194,7 +192,7 @@
 // FIXME: This should be the time from the event that got us here.
 m_startTime = currentTime - kTickTime / 2;
 m_startPosition = *m_currentPosition;
-m_lastAnimationTime = currentTime;
+m_lastAnimationTime = m_startTime;
 }
 m_startVelocity = m_currentVelocity;
 
@@ -240,8 +238,10 @@
 // FIXME: Add in jank detection trace events into this function.
 bool ScrollAnimatorNone::PerAxisData::animateScroll(double currentTime)
 {
-// Get the current time; grabbing the current time once helps keep a consistent heartbeat.
 double lastScrollInterval = currentTime - m_lastAnimationTime;
+if (lastScrollInterval  kMinimumTimerInterval)
+return true;
+
 m_lastAnimationTime = currentTime;
 
 double deltaTime = currentTime - m_startTime;
@@ -274,13 +274,13 @@
 : ScrollAnimator(scrollableArea)
 , m_horizontalData(this, m_currentPosX)
 , m_verticalData(this, m_currentPosY)
+, m_animationTimer(this, ScrollAnimatorNone::animationTimerFired)
 {
 }
 
 ScrollAnimatorNone::~ScrollAnimatorNone()
 {
-stopAnimationTimerIfNeeded(m_horizontalData);
-stopAnimationTimerIfNeeded(m_verticalData);
+stopAnimationTimerIfNeeded();
 }
 
 bool ScrollAnimatorNone::scroll(ScrollbarOrientation orientation, ScrollGranularity granularity, float step, float multiplier)
@@ -311,24 +311,21 @@
 if (!parameters.m_isEnabled)
 return ScrollAnimator::scroll(orientation, granularity, step, multiplier);
 
-// This is an animatable scroll. Calculate the scroll delta.
-PerAxisData* data = "" == VerticalScrollbar) ? m_verticalData : m_horizontalData;
+// This is an animatable scroll. Set the animation in motion using the appropriate parameters.
+float scrollableSize = static_castfloat(m_scrollableArea-scrollSize(orientation));
 
-float scrollableSize = static_castfloat(m_scrollableArea-scrollSize(orientation));
-bool result = data-updateDataFromParameters(orientation, step, multiplier, scrollableSize, WTF::currentTime(), parameters);
-if (!data-m_animationTimer.isActive()) {
-result = data-animateScroll(WTF::currentTime());
-if (result)
-data-m_animationTimer.startOneShot(kAnimationTimerDelay);
+PerAxisData data = "" == VerticalScrollbar) ? m_verticalData : m_horizontalData;
+bool needToScroll = data.updateDataFromParameters(orientation, step, multiplier, scrollableSize, WTF::monotonicallyIncreasingTime(), parameters);
+if (needToScroll

[webkit-changes] [92729] trunk/Source/WebKit2

2011-08-09 Thread sullivan

Title: [92729] trunk/Source/WebKit2








Revision 92729
Author sulli...@apple.com
Date 2011-08-09 17:09:08 -0700 (Tue, 09 Aug 2011)


Log Message
WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
https://bugs.webkit.org/show_bug.cgi?id=65950
rdar://problem/9925931

Reviewed by Anders Carlsson.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call clearPendingAPIRequestURL() if the policy decision is PolicyIgnore.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92728 => 92729)

--- trunk/Source/WebKit2/ChangeLog	2011-08-10 00:05:38 UTC (rev 92728)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-10 00:09:08 UTC (rev 92729)
@@ -1,3 +1,15 @@
+2011-08-09  John Sullivan  sulli...@apple.com
+
+WKPageCopyPendingAPIRequestURL returns stale result if policy decision set to Ignore
+https://bugs.webkit.org/show_bug.cgi?id=65950
+rdar://problem/9925931
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::receivedPolicyDecision):
+Call clearPendingAPIRequestURL() if the policy decision is PolicyIgnore.
+
 2011-08-09  Anders Carlsson  ander...@apple.com
 
 Add a WebKit prefix to the user default.


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (92728 => 92729)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-10 00:05:38 UTC (rev 92728)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-10 00:09:08 UTC (rev 92729)
@@ -1021,6 +1021,9 @@
 {
 if (!isValid())
 return;
+
+if (action == PolicyIgnore)
+clearPendingAPIRequestURL();
 
 uint64_t downloadID = 0;
 if (action == PolicyDownload) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92730] trunk/LayoutTests

2011-08-09 Thread jianli

Title: [92730] trunk/LayoutTests








Revision 92730
Author jia...@chromium.org
Date 2011-08-09 17:28:46 -0700 (Tue, 09 Aug 2011)


Log Message
Unreviewed, mark 2 webaudio tests as failed on chromium win.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92729 => 92730)

--- trunk/LayoutTests/ChangeLog	2011-08-10 00:09:08 UTC (rev 92729)
+++ trunk/LayoutTests/ChangeLog	2011-08-10 00:28:46 UTC (rev 92730)
@@ -1,3 +1,9 @@
+2011-08-09  Jian Li  jia...@chromium.org
+
+Unreviewed, mark 2 webaudio tests as failed on chromium win.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-09  Kent Tamura  tk...@chromium.org
 
 Move input type=month tests to fast/forms/month/


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92729 => 92730)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-10 00:09:08 UTC (rev 92729)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-10 00:28:46 UTC (rev 92730)
@@ -3705,3 +3705,7 @@
 
 // Caused by r92618
 BUGWK65874 : fast/js/preventExtensions.html = TEXT
+
+// Caused by r92704
+BUGWK65951 WIN DEBUG : webaudio/audiobuffersource.html = CRASH
+BUGWK65951 WIN DEBUG : webaudio/mixing.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92731] trunk/Source/JavaScriptCore

2011-08-09 Thread commit-queue

Title: [92731] trunk/Source/_javascript_Core








Revision 92731
Author commit-qu...@webkit.org
Date 2011-08-09 17:28:48 -0700 (Tue, 09 Aug 2011)


Log Message
Fix one MIPS instruction to call JITStubThunked_##op
https://bugs.webkit.org/show_bug.cgi?id=65942

Patch by Chao-ying Fu f...@mips.com on 2011-08-09
Reviewed by Gavin Barraclough.

Changed bal to jalr for a possible processor mode change from
MIPS32 to MIPS16.

* jit/JITStubs.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITStubs.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92730 => 92731)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:28:46 UTC (rev 92730)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:28:48 UTC (rev 92731)
@@ -1,3 +1,15 @@
+2011-08-09  Chao-ying Fu  f...@mips.com
+
+Fix one MIPS instruction to call JITStubThunked_##op
+https://bugs.webkit.org/show_bug.cgi?id=65942
+
+Reviewed by Gavin Barraclough.
+
+Changed bal to jalr for a possible processor mode change from
+MIPS32 to MIPS16.
+
+* jit/JITStubs.cpp:
+
 2011-08-09  Filip Pizlo  fpi...@apple.com
 
 DFG JIT failure loading web site


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (92730 => 92731)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-08-10 00:28:46 UTC (rev 92730)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-08-10 00:28:48 UTC (rev 92731)
@@ -1087,7 +1087,8 @@
 .set macro \n \
 la$25, SYMBOL_STRING(JITStubThunked_##op) \n \
 .set nomacro \n \
-bal  SYMBOL_STRING(JITStubThunked_##op) \n \
+.reloc 1f,R_MIPS_JALR, SYMBOL_STRING(JITStubThunked_##op) \n \
+1: jalr $25 \n \
 nop \n \
 lw$31, STRINGIZE_VALUE_OF(THUNK_RETURN_ADDRESS_OFFSET) ($29) \n \
 jr$31 \n \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92732] trunk/Source/JavaScriptCore

2011-08-09 Thread fpizlo

Title: [92732] trunk/Source/_javascript_Core








Revision 92732
Author fpi...@apple.com
Date 2011-08-09 17:30:50 -0700 (Tue, 09 Aug 2011)


Log Message
DFG JIT passes the this argument to constructors even though
it's not necessary
https://bugs.webkit.org/show_bug.cgi?id=65943

Reviewed by Gavin Barraclough.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::emitCall):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92731 => 92732)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:28:48 UTC (rev 92731)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:30:50 UTC (rev 92732)
@@ -1,3 +1,14 @@
+2011-08-09  Filip Pizlo  fpi...@apple.com
+
+DFG JIT passes the this argument to constructors even though
+it's not necessary
+https://bugs.webkit.org/show_bug.cgi?id=65943
+
+Reviewed by Gavin Barraclough.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::emitCall):
+
 2011-08-09  Chao-ying Fu  f...@mips.com
 
 Fix one MIPS instruction to call JITStubThunked_##op


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (92731 => 92732)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-08-10 00:28:48 UTC (rev 92731)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-08-10 00:30:50 UTC (rev 92732)
@@ -999,7 +999,7 @@
 m_jit.storePtr(MacroAssembler::TrustedImmPtr(JSValue::encode(jsNumber(numArgs))), addressOfCallData(RegisterFile::ArgumentCount));
 m_jit.storePtr(GPRInfo::callFrameRegister, addressOfCallData(RegisterFile::CallerFrame));
 
-for (int argIdx = 0; argIdx  numArgs; argIdx++) {
+for (int argIdx = (node.op == Call ? 0 : 1); argIdx  numArgs; argIdx++) {
 NodeIndex argNodeIndex = m_jit.graph().m_varArgChildren[node.firstChild() + 1 + argIdx];
 JSValueOperand arg(this, argNodeIndex);
 GPRReg argGPR = arg.gpr();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92733] trunk/LayoutTests

2011-08-09 Thread tkent

Title: [92733] trunk/LayoutTests








Revision 92733
Author tk...@chromium.org
Date 2011-08-09 17:36:19 -0700 (Tue, 09 Aug 2011)


Log Message
Add a missing /script for r92728.

* fast/forms/month/ValidityState-stepMismatch-month.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92732 => 92733)

--- trunk/LayoutTests/ChangeLog	2011-08-10 00:30:50 UTC (rev 92732)
+++ trunk/LayoutTests/ChangeLog	2011-08-10 00:36:19 UTC (rev 92733)
@@ -1,3 +1,9 @@
+2011-08-09  Kent Tamura  tk...@chromium.org
+
+Add a missing /script for r92728.
+
+* fast/forms/month/ValidityState-stepMismatch-month.html:
+
 2011-08-09  Jian Li  jia...@chromium.org
 
 Unreviewed, mark 2 webaudio tests as failed on chromium win.


Modified: trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html (92732 => 92733)

--- trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html	2011-08-10 00:30:50 UTC (rev 92732)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month.html	2011-08-10 00:36:19 UTC (rev 92733)
@@ -52,6 +52,7 @@
 
 debug('');
 var successfullyParsed = true;
+/script
 script src=""
 /body
 /html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92734] trunk/Source/JavaScriptCore

2011-08-09 Thread fpizlo

Title: [92734] trunk/Source/_javascript_Core








Revision 92734
Author fpi...@apple.com
Date 2011-08-09 17:51:11 -0700 (Tue, 09 Aug 2011)


Log Message
DFG JIT has no way of propagating predictions to loads and calls
https://bugs.webkit.org/show_bug.cgi?id=65883

Reviewed by Gavin Barraclough.

This introduces the capability to store predictions on graph
nodes.  To save space while being somewhat consistent, the
prediction is always stored in the second OpInfo slot (since
a GetById will use the first one for the identifier).  This
change is a natural extension of r92593 (global variable
prediction).

This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
win on V8 in the geometric mean.  It is neutral on SunSpider
and Kraken.  Interestingly, on V8 it regresses crypto by 3%
while progressing deltablue and richards by 2.6% and 4.3%,
respectively.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGNode.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasPrediction):
(JSC::DFG::Node::getPrediction):
(JSC::DFG::Node::predict):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92733 => 92734)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:36:19 UTC (rev 92733)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:51:11 UTC (rev 92734)
@@ -1,5 +1,46 @@
 2011-08-09  Filip Pizlo  fpi...@apple.com
 
+DFG JIT has no way of propagating predictions to loads and calls
+https://bugs.webkit.org/show_bug.cgi?id=65883
+
+Reviewed by Gavin Barraclough.
+
+This introduces the capability to store predictions on graph
+nodes.  To save space while being somewhat consistent, the
+prediction is always stored in the second OpInfo slot (since
+a GetById will use the first one for the identifier).  This
+change is a natural extension of r92593 (global variable
+prediction).
+
+This is a 1.5% win on V8 in the arithmetic mean, and a 0.6%
+win on V8 in the geometric mean.  It is neutral on SunSpider
+and Kraken.  Interestingly, on V8 it regresses crypto by 3%
+while progressing deltablue and richards by 2.6% and 4.3%,
+respectively.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::addToGraph):
+(JSC::DFG::ByteCodeParser::addCall):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::predict):
+(JSC::DFG::Graph::getPrediction):
+* dfg/DFGNode.h:
+(JSC::DFG::isCellPrediction):
+(JSC::DFG::isArrayPrediction):
+(JSC::DFG::isInt32Prediction):
+(JSC::DFG::isDoublePrediction):
+(JSC::DFG::isNumberPrediction):
+(JSC::DFG::predictionToString):
+(JSC::DFG::Node::Node):
+(JSC::DFG::Node::hasPrediction):
+(JSC::DFG::Node::getPrediction):
+(JSC::DFG::Node::predict):
+
+2011-08-09  Filip Pizlo  fpi...@apple.com
+
 DFG JIT passes the this argument to constructors even though
 it's not necessary
 https://bugs.webkit.org/show_bug.cgi?id=65943


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (92733 => 92734)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-08-10 00:36:19 UTC (rev 92733)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-08-10 00:51:11 UTC (rev 92734)
@@ -394,10 +394,10 @@
 return resultIndex;
 }
 
-NodeIndex addToGraph(Node::VarArgTag, NodeType op)
+NodeIndex addToGraph(Node::VarArgTag, NodeType op, OpInfo info1, OpInfo info2)
 {
 NodeIndex resultIndex = (NodeIndex)m_graph.size();
-m_graph.append(Node(Node::VarArg, op, m_currentIndex, m_graph.m_varArgChildren.size() - m_numPassedVarArgs, m_numPassedVarArgs));
+m_graph.append(Node(Node::VarArg, op, m_currentIndex, info1, info2, m_graph.m_varArgChildren.size() - m_numPassedVarArgs, m_numPassedVarArgs));
 
 m_numPassedVarArgs = 0;
 
@@ -419,7 +419,7 @@
 int firstArg = registerOffset - argCount - RegisterFile::CallFrameHeaderSize;
 for (int argIdx = firstArg; argIdx  firstArg + argCount; argIdx++)
 addVarArgChild(get(argIdx));
-NodeIndex call =

[webkit-changes] [92736] trunk/Source/JavaScriptCore

2011-08-09 Thread fpizlo

Title: [92736] trunk/Source/_javascript_Core








Revision 92736
Author fpi...@apple.com
Date 2011-08-09 18:12:28 -0700 (Tue, 09 Aug 2011)


Log Message
DFG JIT does not speculative integers as aggressively as it should
https://bugs.webkit.org/show_bug.cgi?id=65949

Reviewed by Gavin Barraclough.

Added a tree walk to propagate integer predictions through arithmetic
expressions.

This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
translates to a 19% speed-up on Kraken overall.  It's neutral on
other benchmarks.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::predictInt32):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (92735 => 92736)

--- trunk/Source/_javascript_Core/ChangeLog	2011-08-10 00:59:41 UTC (rev 92735)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-08-10 01:12:28 UTC (rev 92736)
@@ -1,5 +1,22 @@
 2011-08-09  Filip Pizlo  fpi...@apple.com
 
+DFG JIT does not speculative integers as aggressively as it should
+https://bugs.webkit.org/show_bug.cgi?id=65949
+
+Reviewed by Gavin Barraclough.
+
+Added a tree walk to propagate integer predictions through arithmetic
+expressions.
+
+This is a 71% speed-up on Kraken's imaging-gaussian-blur, which
+translates to a 19% speed-up on Kraken overall.  It's neutral on
+other benchmarks.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::predictInt32):
+
+2011-08-09  Filip Pizlo  fpi...@apple.com
+
 DFG JIT has no way of propagating predictions to loads and calls
 https://bugs.webkit.org/show_bug.cgi?id=65883
 


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (92735 => 92736)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-08-10 00:59:41 UTC (rev 92735)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2011-08-10 01:12:28 UTC (rev 92736)
@@ -435,15 +435,32 @@
 
 void predictInt32(NodeIndex nodeIndex)
 {
-Node* nodePtr = m_graph[nodeIndex];
-
-if (nodePtr-op == ValueToNumber)
-nodePtr = m_graph[nodePtr-child1()];
-
-if (nodePtr-op == ValueToInt32)
-nodePtr = m_graph[nodePtr-child1()];
+ASSERT(m_reusableNodeStack.isEmpty());
+m_reusableNodeStack.append(m_graph[nodeIndex]);
 
-m_graph.predict(*nodePtr, PredictInt32);
+do {
+Node* nodePtr = m_reusableNodeStack.last();
+m_reusableNodeStack.removeLast();
+
+if (nodePtr-op == ValueToNumber)
+nodePtr = m_graph[nodePtr-child1()];
+
+if (nodePtr-op == ValueToInt32)
+nodePtr = m_graph[nodePtr-child1()];
+
+switch (nodePtr-op) {
+case ArithAdd:
+case ArithSub:
+case ArithMul:
+case ValueAdd:
+m_reusableNodeStack.append(m_graph[nodePtr-child1()]);
+m_reusableNodeStack.append(m_graph[nodePtr-child2()]);
+break;
+default:
+m_graph.predict(*nodePtr, PredictInt32);
+break;
+}
+} while (!m_reusableNodeStack.isEmpty());
 }
 
 JSGlobalData* m_globalData;
@@ -516,6 +533,8 @@
 };
 VectorPhiStackEntry, 16 m_argumentPhiStack;
 VectorPhiStackEntry, 16 m_localPhiStack;
+
+VectorNode*, 16 m_reusableNodeStack;
 };
 
 #define NEXT_OPCODE(name) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92739] branches/chromium/835/Source

2011-08-09 Thread cevans

Title: [92739] branches/chromium/835/Source








Revision 92739
Author cev...@google.com
Date 2011-08-09 18:35:54 -0700 (Tue, 09 Aug 2011)


Log Message
Merge 92347
BUG=91093
Review URL: http://codereview.chromium.org/7497054

Modified Paths

branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp
branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp
branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp
branches/chromium/835/Source/WebCore/page/FrameView.cpp
branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp
branches/chromium/835/Source/WebCore/platform/gtk/RenderThemeGtk.cpp
branches/chromium/835/Source/WebCore/rendering/RenderThemeMac.mm
branches/chromium/835/Source/WebCore/rendering/RenderThemeWinCE.cpp
branches/chromium/835/Source/WebKit/mac/WebView/WebFullScreenController.mm
branches/chromium/835/Source/WebKit/win/WebView.cpp




Diff

Modified: branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp (92738 => 92739)

--- branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/HTMLSourceElement.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,13 +57,15 @@
 void HTMLSourceElement::insertedIntoTree(bool deep)
 {
 HTMLElement::insertedIntoTree(deep);
-if (parentNode()  (parentNode()-hasTagName(audioTag) || parentNode()-hasTagName(videoTag)))
+Element* parent = parentElement();
+if (parent  parent-isMediaElement())
 static_castHTMLMediaElement*(parentNode())-sourceWasAdded(this);
 }
 
 void HTMLSourceElement::willRemove()
 {
-if (parentNode()  (parentNode()-hasTagName(audioTag) || parentNode()-hasTagName(videoTag)))
+Element* parent = parentElement();
+if (parent  parent-isMediaElement())
 static_castHTMLMediaElement*(parentNode())-sourceWillBeRemoved(this);
 HTMLElement::willRemove();
 }


Modified: branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp (92738 => 92739)

--- branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/HTMLTrackElement.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,7 +57,8 @@
 void HTMLTrackElement::insertedIntoTree(bool deep)
 {
 HTMLElement::insertedIntoTree(deep);
-if (parentNode()  (parentNode()-hasTagName(audioTag) || parentNode()-hasTagName(videoTag))) {
+Element* parent = parentElement();
+if (parent  parent-isMediaElement()) {
 // TODO(annacc):
 // static_castHTMLMediaElement*(parentNode())-trackWasAdded(this);
 }
@@ -65,7 +66,8 @@
 
 void HTMLTrackElement::willRemove()
 {
-if (parentNode()  (parentNode()-hasTagName(audioTag) || parentNode()-hasTagName(videoTag))) {
+Element* parent = parentElement();
+if (parent  parent-isMediaElement()) {
 // TODO(annacc):
 // static_castHTMLMediaElement*(parentNode())-trackWillBeRemoved(this);
 }


Modified: branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp (92738 => 92739)

--- branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/html/shadow/MediaControlElements.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -57,7 +57,7 @@
 HTMLMediaElement* toParentMediaElement(Node* node)
 {
 Node* mediaNode = node ? node-shadowAncestorNode() : 0;
-if (!mediaNode || (!mediaNode-hasTagName(HTMLNames::videoTag)  !mediaNode-hasTagName(HTMLNames::audioTag)))
+if (!mediaNode || !mediaNode-isElementNode() || !static_castElement*(mediaNode)-isMediaElement())
 return 0;
 
 return static_castHTMLMediaElement*(mediaNode);


Modified: branches/chromium/835/Source/WebCore/page/FrameView.cpp (92738 => 92739)

--- branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/page/FrameView.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -2003,7 +2003,7 @@
 static_castHTMLPlugInImageElement*(ownerElement)-updateWidget(CreateAnyWidgetType);
 // FIXME: It is not clear that Media elements need or want this updateWidget() call.
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
-else if (ownerElement-hasTagName(videoTag) || ownerElement-hasTagName(audioTag))
+else if (ownerElement-isMediaElement())
 static_castHTMLMediaElement*(ownerElement)-updateWidget(CreateAnyWidgetType);
 #endif
 else


Modified: branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp (92738 => 92739)

--- branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-08-10 01:34:18 UTC (rev 92738)
+++ branches/chromium/835/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-08-10 01:35:54 UTC (rev 92739)
@@ -1160,7 +1160,7 @@
 bool RenderThemeEfl::paintMediaMuteButton(RenderObject* object, const PaintInfo info, const IntRect rect)
 {
 Node* mediaNode = object-node() ?

[webkit-changes] [92741] trunk/LayoutTests

2011-08-09 Thread tkent

Title: [92741] trunk/LayoutTests








Revision 92741
Author tk...@chromium.org
Date 2011-08-09 18:40:10 -0700 (Tue, 09 Aug 2011)


Log Message
Another follow-up for r92728.
https://bugs.webkit.org/show_bug.cgi?id=65916

* fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92740 => 92741)

--- trunk/LayoutTests/ChangeLog	2011-08-10 01:40:01 UTC (rev 92740)
+++ trunk/LayoutTests/ChangeLog	2011-08-10 01:40:10 UTC (rev 92741)
@@ -1,5 +1,12 @@
 2011-08-09  Kent Tamura  tk...@chromium.org
 
+Another follow-up for r92728.
+https://bugs.webkit.org/show_bug.cgi?id=65916
+
+* fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated.
+
+2011-08-09  Kent Tamura  tk...@chromium.org
+
 Add a missing /script for r92728.
 
 * fast/forms/month/ValidityState-stepMismatch-month.html:


Modified: trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt (92740 => 92741)

--- trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt	2011-08-10 01:40:01 UTC (rev 92740)
+++ trunk/LayoutTests/fast/forms/month/ValidityState-stepMismatch-month-expected.txt	2011-08-10 01:40:10 UTC (rev 92741)
@@ -1,2 +1,37 @@
-CONSOLE MESSAGE: line 55: SyntaxError: Unexpected token ''
+Check stepMismatch results for type=month.
 
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Empty values
+PASS stepMismatchFor(, null, null) is false
+PASS stepMismatchFor(, 2, 1969-12) is false
+Normal step values
+PASS stepMismatchFor(2010-03, 2, 2010-02) is true
+PASS stepMismatchFor(2010-02, 2, 2010-02) is false
+PASS stepMismatchFor(2010-04, 2, 2010-02) is false
+PASS stepMismatchFor(1800-11, 3, 1800-09) is true
+PASS stepMismatchFor(1800-09, 3, 1800-09) is false
+PASS stepMismatchFor(1800-12, 3, 1800-09) is false
+PASS stepMismatchFor(275760-09, 3, 275760-08) is true
+PASS stepMismatchFor(275760-09, 2, 275760-09) is false
+Implicit step base
+PASS stepMismatchFor(1970-02, 2, null) is true
+PASS stepMismatchFor(1970-03, 2, null) is false
+Fractional step values
+PASS stepMismatchFor(2010-03, 0.1, 2010-02) is false
+PASS stepMismatchFor(2010-03, 1.1, 2010-02) is false
+PASS stepMismatchFor(2010-03, 1.9, 2010-02) is true
+Invalid or no step values
+PASS stepMismatchFor(2010-03, null, 2010-02) is false
+PASS stepMismatchFor(2010-03, -1, 2010-02) is false
+PASS stepMismatchFor(2010-03, foo, 2010-02) is false
+Special step value
+PASS stepMismatchFor(2010-03, any, 2010-02) is false
+Disabled
+PASS stepMismatchFor(2010-03, 2, 2010-02, true) is false
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92745] branches/chromium/835

2011-08-09 Thread cevans

Title: [92745] branches/chromium/835








Revision 92745
Author cev...@google.com
Date 2011-08-09 19:10:11 -0700 (Tue, 09 Aug 2011)


Log Message
Merge 92744
BUG=88670
Review URL: http://codereview.chromium.org/7497055

Modified Paths

branches/chromium/835/LayoutTests/platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png
branches/chromium/835/LayoutTests/platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png
branches/chromium/835/Source/WebCore/rendering/RenderObjectChildList.cpp




Diff

Modified: branches/chromium/835/LayoutTests/platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png

(Binary files differ)


Modified: branches/chromium/835/LayoutTests/platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png

(Binary files differ)


Modified: branches/chromium/835/Source/WebCore/rendering/RenderObjectChildList.cpp (92744 => 92745)

--- branches/chromium/835/Source/WebCore/rendering/RenderObjectChildList.cpp	2011-08-10 02:04:06 UTC (rev 92744)
+++ branches/chromium/835/Source/WebCore/rendering/RenderObjectChildList.cpp	2011-08-10 02:10:11 UTC (rev 92745)
@@ -258,7 +258,7 @@
 RenderObject* beforeAfterParent = object;
 while (beforeAfterParent  !(beforeAfterParent-isText() || beforeAfterParent-isImage()))
 beforeAfterParent = beforeAfterParent-firstChild();
-return beforeAfterParent;
+return beforeAfterParent ? beforeAfterParent-parent() : 0;
 }
 
 RenderObject* RenderObjectChildList::beforePseudoElementRenderer(const RenderObject* owner) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92747] trunk

2011-08-09 Thread dominicc

Title: [92747] trunk








Revision 92747
Author domin...@chromium.org
Date 2011-08-09 21:51:50 -0700 (Tue, 09 Aug 2011)


Log Message
[V8] The prototype property of DOM constructors should be read-only.
https://bugs.webkit.org/show_bug.cgi?id=39655

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/dom/prototype-property.html

* bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
* bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):

LayoutTests:

* platform/chromium/test_expectations.txt: Unskip test for prototypes.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (92746 => 92747)

--- trunk/LayoutTests/ChangeLog	2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/LayoutTests/ChangeLog	2011-08-10 04:51:50 UTC (rev 92747)
@@ -1,3 +1,12 @@
+2011-08-09  Dominic Cooney  domin...@chromium.org
+
+[V8] The prototype property of DOM constructors should be read-only.
+https://bugs.webkit.org/show_bug.cgi?id=39655
+
+Reviewed by Dimitri Glazkov.
+
+* platform/chromium/test_expectations.txt: Unskip test for prototypes.
+
 2011-08-09  Kent Tamura  tk...@chromium.org
 
 Move input type=time tests to fast/forms/time/


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92746 => 92747)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-10 04:51:50 UTC (rev 92747)
@@ -1955,8 +1955,6 @@
 BUGCR62301 MAC : canvas/philip/tests/2d.shadow.enable.y.html = TEXT
 BUGCR62301 MAC : canvas/philip/tests/2d.strokeRect.zero.4.html = TEXT
 
-BUGWK39655 : fast/dom/prototype-property.html = FAIL
-
 // These SVG tests have been flaky on Win from quite some time.
 // Hard to pin down which roll introduced the flakiness.
 BUGCR45106 WIN : svg/clip-path/clip-path-evenodd-nonzero.svg = PASS CRASH


Modified: trunk/Source/WebCore/ChangeLog (92746 => 92747)

--- trunk/Source/WebCore/ChangeLog	2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/ChangeLog	2011-08-10 04:51:50 UTC (rev 92747)
@@ -1,3 +1,22 @@
+2011-08-09  Dominic Cooney  domin...@chromium.org
+
+[V8] The prototype property of DOM constructors should be read-only.
+https://bugs.webkit.org/show_bug.cgi?id=39655
+
+Reviewed by Dimitri Glazkov.
+
+Test: fast/dom/prototype-property.html
+
+* bindings/scripts/CodeGeneratorV8.pm: Make prototypes read-only.
+* bindings/scripts/test/V8/V8TestInterface.cpp: Update expectations.
+(WebCore::ConfigureV8TestInterfaceTemplate):
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
+(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::ConfigureV8TestObjTemplate):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
+
 2011-08-09  Abhishek Arya  infe...@chromium.org
 
 Style change not propagating for before, after content


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (92746 => 92747)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-10 04:51:50 UTC (rev 92747)
@@ -2015,6 +2015,8 @@
 push(@implContent,  END);
 static v8::Persistentv8::FunctionTemplate Configure${className}Template(v8::Persistentv8::FunctionTemplate desc)
 {
+desc-ReadOnlyPrototype();
+
 v8::Localv8::Signature defaultSignature = configureTemplate(desc, \${visibleInterfaceName}\, $parentClassTemplate, V8${interfaceName}::internalFieldCount,
 END
 # Set up our attributes if we have them


Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp (92746 => 92747)

--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp	2011-08-10 04:43:59 UTC (rev 92746)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp	2011-08-10 04:51:50 UTC (rev 92747)
@@ -48,6 +48,8 @@
 }

[webkit-changes] [92748] trunk/Tools

2011-08-09 Thread abarth

Title: [92748] trunk/Tools








Revision 92748
Author aba...@webkit.org
Date 2011-08-09 22:28:19 -0700 (Tue, 09 Aug 2011)


Log Message
Move the quote mark to the right place.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92747 => 92748)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-10 04:51:50 UTC (rev 92747)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js	2011-08-10 05:28:19 UTC (rev 92748)
@@ -68,7 +68,7 @@
 base.callInSequence(function(failureInfo, callback) {
 var extensionList = Array.prototype.concat.apply([], failureInfo.failureTypeList.map(results.failureTypeToExtensionList));
 base.callInSequence(function(extension, callback) {
-net.post('config.kLocalServerURL + /rebaseline?' + $.param({
+net.post(config.kLocalServerURL + '/rebaseline?' + $.param({
 'builder': failureInfo.builderName,
 'test': failureInfo.testName,
 'extension': extension


Modified: trunk/Tools/ChangeLog (92747 => 92748)

--- trunk/Tools/ChangeLog	2011-08-10 04:51:50 UTC (rev 92747)
+++ trunk/Tools/ChangeLog	2011-08-10 05:28:19 UTC (rev 92748)
@@ -1,5 +1,11 @@
 2011-08-09  Adam Barth  aba...@webkit.org
 
+Move the quote mark to the right place.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
+
+2011-08-09  Adam Barth  aba...@webkit.org
+
 garden-o-matic should use huerstics to narrow regression range
 https://bugs.webkit.org/show_bug.cgi?id=65948
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92749] trunk/Source/WebCore

2011-08-09 Thread macpherson

Title: [92749] trunk/Source/WebCore








Revision 92749
Author macpher...@chromium.org
Date 2011-08-09 22:35:28 -0700 (Tue, 09 Aug 2011)


Log Message
Use setFontDescription helper to set m_fontDirty.
https://bugs.webkit.org/show_bug.cgi?id=65956

Reviewed by Dan Bernstein.

No new tests / trivial cleanup.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92748 => 92749)

--- trunk/Source/WebCore/ChangeLog	2011-08-10 05:28:19 UTC (rev 92748)
+++ trunk/Source/WebCore/ChangeLog	2011-08-10 05:35:28 UTC (rev 92749)
@@ -1,3 +1,15 @@
+2011-08-09  Luke Macpherson   macpher...@chromium.org
+
+Use setFontDescription helper to set m_fontDirty.
+https://bugs.webkit.org/show_bug.cgi?id=65956
+
+Reviewed by Dan Bernstein.
+
+No new tests / trivial cleanup.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty):
+
 2011-08-09  Dominic Cooney  domin...@chromium.org
 
 [V8] The prototype property of DOM constructors should be read-only.


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (92748 => 92749)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-10 05:28:19 UTC (rev 92748)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-08-10 05:35:28 UTC (rev 92749)
@@ -4768,8 +4768,7 @@
 m_style-setLocale(primitiveValue-getStringValue());
 FontDescription fontDescription = m_style-fontDescription();
 fontDescription.setScript(localeToScriptCodeForFontSelection(m_style-locale()));
-if (m_style-setFontDescription(fontDescription))
-m_fontDirty = true;
+setFontDescription(fontDescription);
 return;
 }
 case CSSPropertyWebkitBorderFit:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92665] trunk/Source/WebCore/ChangeLog

2011-08-09 Thread zimmermann

Title: [92665] trunk/Source/WebCore/ChangeLog








Revision 92665
Author zimmerm...@webkit.org
Date 2011-08-09 00:14:24 -0700 (Tue, 09 Aug 2011)


Log Message
Forgot to add the ChangeLog for r92545. Fixed.

Modified Paths

trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (92664 => 92665)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 04:08:08 UTC (rev 92664)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 07:14:24 UTC (rev 92665)
@@ -1046,6 +1046,88 @@
 (WebCore::CSSParser::parseColorFromValue):
 (WebCore::CSSParser::parseFontFeatureTag):
 
+2011-08-06  Nikolas Zimmermann  nzimmerm...@rim.com
+
+REGRESSION(87526): ASSERT(!needsLayout()) followed by graphical glitches on google charts (svg loaded in iframe)
+https://bugs.webkit.org/show_bug.cgi?id=64974
+
+svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
+https://bugs.webkit.org/show_bug.cgi?id=63186
+
+Reviewed by Zoltan Herczeg.
+
+Fix host - embedded document size negotiation race. The currently implemented solution relied on a specific
+order of paint/layout calls, which is broken. Consider rendering a document containing an object/iframe/embed
+referencing an external SVG file. When FrameView::layout() is called (associated with the outermost RenderView
+of the host document), it lays out the whole document, and afterwards performPostLayoutTasks() is called.
+This method then asks the Frames contentRenderer to update its widget positions. This triggers a call
+of the embedded documents FrameView::layout() method, which now lays out the embedded SVG documents tree
+through RenderSVGRoot::layout.
+
+And here's the bug: The size of the object/iframe replaced element, which hosts the embedded document
+may depend on the intrinsic size of the SVG. We tried to mark the embedded documents _ownerRenderer_ (the RenderPart)
+as needs layout and pref width recalc right from RenderSVGRoot::layout() and hoped that this would cause the whole
+document to be laid out again, now that the size of the embedded SVG document is known.
+
+As soon as the SVG document is laid out, the host document will be painted (flush deferred repaints) and an assertion
+ASSERTS(!needsLayout()) will be fired, as we modified the setNeedsLayout() state after the host document layout finished,
+right before painting.
+
+A proper fix is to only keep track in RenderSVGRoot whether it needs to negotiate the size with the host document, but
+not modify the layout state of the host document in any way. Let FrameView handle the size negotiation right in
+FrameView::layout().
+
+Consider following document:
+bodyiframe src=""
+
+After initial loading  parsing of the document, a FrameView exists for the main frame, and a sub-FrameView
+for the iframe. The external SVG document, may not be loaded yet at this point. That means when RenderIFrame::layout()
+tries to figure out its size (computeLogicalWidth/Height) - the RenderSVGRoot renderer of the external document hasn't
+been created yet (as the external document hasn't received data yet) - so it falls back to eg. 300x150 CSS default size
+(in the simplest case, where width/height are both auto).
+
+Suppose the external document now finished loading, the RenderSVGRoot is created and a global relayout is triggered
+starting from the main FrameView. As we already laid out the document once, needsLayout() is false for the main FrameView,
+so _only_ the child frame view that contains the RenderSVGRoot is now laid out, for the first time.
+
+After layout is done, the SVG document is fully laid out, though the RenderPart which embedded the SVG does NOT notice
+the SVG has been laid out, so it still carries the default 300x150 size (and needsLayout=false!).
+
+The fix is to retrigger layout of the parent frame view by marking the owner renderer of the frame view as needs layout
+and pref widths recalc and immediatiely performing a synchronous update of the layout. It's important to do it sync,
+as scripts depend on the result of the size negotiation (covered extensively with the new tests in svg/as-object).
+
+Reenable svg/zoom/page/zoom-svg-through-object* tests to see whether the flakiness is gone.
+
+Tests: svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html
+   svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
+   svg/as-object/embedded-svg-immediate-offsetWidth-query.html
+   svg/as-object/embedded-svg-size-changes-no-layout-triggers.html
+   svg/as-object/embedded-svg-size-changes.html
+   svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html
+

[webkit-changes] [92666] trunk/LayoutTests

2011-08-09 Thread reni

Title: [92666] trunk/LayoutTests








Revision 92666
Author r...@webkit.org
Date 2011-08-09 00:49:14 -0700 (Tue, 09 Aug 2011)


Log Message
[Qt]REGRESSION(r22030): It made one test failed.

Unreviewed gardening.

* platform/qt-4.8/Skipped: Skip the failed test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-4.8/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92665 => 92666)

--- trunk/LayoutTests/ChangeLog	2011-08-09 07:14:24 UTC (rev 92665)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 07:49:14 UTC (rev 92666)
@@ -1,3 +1,11 @@
+2011-08-09  Renata Hodovan  r...@webkit.org
+
+[Qt]REGRESSION(r22030): It made one test failed.
+
+Unreviewed gardening.
+
+* platform/qt-4.8/Skipped: Skip the failed test.
+
 2011-08-08  Kent Tamura  tk...@chromium.org
 
 [Chromium] Update baseline files for r92585.


Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (92665 => 92666)

--- trunk/LayoutTests/platform/qt-4.8/Skipped	2011-08-09 07:14:24 UTC (rev 92665)
+++ trunk/LayoutTests/platform/qt-4.8/Skipped	2011-08-09 07:49:14 UTC (rev 92666)
@@ -7,3 +7,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=64527
 svg/text/lengthAdjust-text-metrics.html
 http/tests/security/cross-frame-access-put.html
+
+# Regression after r22030
+http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92667] trunk/LayoutTests

2011-08-09 Thread reni

Title: [92667] trunk/LayoutTests








Revision 92667
Author r...@webkit.org
Date 2011-08-09 01:27:45 -0700 (Tue, 09 Aug 2011)


Log Message
Accidentally added build number as revision number in r92666.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-4.8/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92666 => 92667)

--- trunk/LayoutTests/ChangeLog	2011-08-09 07:49:14 UTC (rev 92666)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 08:27:45 UTC (rev 92667)
@@ -1,6 +1,6 @@
 2011-08-09  Renata Hodovan  r...@webkit.org
 
-[Qt]REGRESSION(r22030): It made one test failed.
+[Qt]REGRESSION(r92554): It made one test failed.
 
 Unreviewed gardening.
 


Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (92666 => 92667)

--- trunk/LayoutTests/platform/qt-4.8/Skipped	2011-08-09 07:49:14 UTC (rev 92666)
+++ trunk/LayoutTests/platform/qt-4.8/Skipped	2011-08-09 08:27:45 UTC (rev 92667)
@@ -8,5 +8,5 @@
 svg/text/lengthAdjust-text-metrics.html
 http/tests/security/cross-frame-access-put.html
 
-# Regression after r22030
+# Regression after r92554
 http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92668] trunk/LayoutTests

2011-08-09 Thread zimmermann

Title: [92668] trunk/LayoutTests








Revision 92668
Author zimmerm...@webkit.org
Date 2011-08-09 01:34:02 -0700 (Tue, 09 Aug 2011)


Log Message
2011-08-09  Nikolas Zimmermann  nzimmerm...@rim.com

svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
https://bugs.webkit.org/show_bug.cgi?id=63186

Not reviewed. More gtk/win gardening.

* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline, same result on both gtk 32 bit debug/release and 64bit.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Taken from Win7 bot, WinXP still seems to have a problem.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
* platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt
trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt


Added Paths

trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt


Removed Paths

trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92667 => 92668)

--- trunk/LayoutTests/ChangeLog	2011-08-09 08:27:45 UTC (rev 92667)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 08:34:02 UTC (rev 92668)
@@ -1,3 +1,15 @@
+2011-08-09  Nikolas Zimmermann  nzimmerm...@rim.com
+
+svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
+https://bugs.webkit.org/show_bug.cgi?id=63186
+
+Not reviewed. More gtk/win gardening.
+
+* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline, same result on both gtk 32 bit debug/release and 64bit.
+* platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Taken from Win7 bot, WinXP still seems to have a problem.
+* platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
+* platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.
+
 2011-08-09  Renata Hodovan  r...@webkit.org
 
 [Qt]REGRESSION(r92554): It made one test failed.


Modified: trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt (92667 => 92668)

--- trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	2011-08-09 08:27:45 UTC (rev 92667)
+++ trunk/LayoutTests/platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt	2011-08-09 08:34:02 UTC (rev 92668)
@@ -54,9 +54,9 @@
 RenderSVGPath {path} at (13,4) size 61x14 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]
   RenderBlock (floating) {P} at (1,373) size 115x7
 RenderEmbeddedObject {OBJECT} at (7,0) size 101x36 [bgcolor=#FF] [border: (7px solid #FF)]
-  layer at (0,0) size 106x30
-RenderView at (0,0) size 106x30
-  layer at (0,0) size 106x30
-RenderSVGRoot {svg} at (0,0) size 106x28
-  RenderSVGPath {rect} at (0,0) size 106x28 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
-  RenderSVGPath {path} at (15,5) size 76x17 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]
+  layer at (0,0) size 87x22
+RenderView at (0,0) size 87x22
+  layer at (0,0) size 87x22
+RenderSVGRoot {svg} at (0,0) size 87x22
+  RenderSVGPath {rect} at (0,0) size 87x22 [stroke={[type=SOLID] [color=#008000] [stroke width=12.00]}] [fill={[type=SOLID] [color=#00FF00]}] [x=0.00] [y=0.00] [width=1000.00] [height=250.00]
+  RenderSVGPath {path} at (13,4) size 61x14 [fill={[type=SOLID] [color=#008000]}] [data="" 500 50 L 150 200 L 850 200 Z]


Modified: trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt (92667 => 92668)

--- trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt	2011-08-09 08:27:45 UTC (rev 92667)
+++ trunk/LayoutTests/platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt	2011-08-09 08:34:02 UTC (rev 92668)
@@ -25,7 +25,7 @@
 RenderTableCell {td} at (1,90) size 243x82 [r=2 c=0 rs=1 cs=1]
   RenderEmbeddedObject {object} at (100,5) size 138x69
 layer at (0,0) size 138x69
-  RenderView at (0,0) size 123x54
+  RenderView at (0,0) size 138x69
 layer at (0,0) size 138x69
   RenderSVGRoot

[webkit-changes] [92669] trunk/Tools

2011-08-09 Thread abarth

Title: [92669] trunk/Tools








Revision 92669
Author aba...@webkit.org
Date 2011-08-09 01:38:45 -0700 (Tue, 09 Aug 2011)


Log Message
BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=65891

Reviewed by Eric Seidel.

The problem was that platform/chromium contained a bogus expectation
file that needed to be removed, but by the time we got around to
removing it, we'd already moved the correct baseline into its place.
After this patch, we copy the gold results into memory before
reshuffling things on disk (and we delete bad things before adding good
things).

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py
trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (92668 => 92669)

--- trunk/Tools/ChangeLog	2011-08-09 08:34:02 UTC (rev 92668)
+++ trunk/Tools/ChangeLog	2011-08-09 08:38:45 UTC (rev 92669)
@@ -1,3 +1,20 @@
+2011-08-09  Adam Barth  aba...@webkit.org
+
+BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
+https://bugs.webkit.org/show_bug.cgi?id=65891
+
+Reviewed by Eric Seidel.
+
+The problem was that platform/chromium contained a bogus expectation
+file that needed to be removed, but by the time we got around to
+removing it, we'd already moved the correct baseline into its place.
+After this patch, we copy the gold results into memory before
+reshuffling things on disk (and we delete bad things before adding good
+things).
+
+* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
+* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
+
 2011-08-08  Adam Barth  aba...@webkit.org
 
 Chromium Windows bots can't figure out what SVN revision they're running


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py (92668 => 92669)

--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py	2011-08-09 08:34:02 UTC (rev 92668)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer.py	2011-08-09 08:38:45 UTC (rev 92669)
@@ -132,24 +132,24 @@
 return results_by_directory, new_results_by_directory
 
 def _move_baselines(self, baseline_name, results_by_directory, new_results_by_directory):
-source_directory_for_result = {}
+data_for_result = {}
 for directory, result in results_by_directory.items():
-source_directory_for_result[result] = directory
+if not result in data_for_result:
+source = self._filesystem.join(self._scm.checkout_root, directory, baseline_name)
+data_for_result[result] = self._filesystem.read_binary_file(source)
 
+for directory, result in results_by_directory.items():
+if new_results_by_directory.get(directory) != result:
+file_name = self._filesystem.join(self._scm.checkout_root, directory, baseline_name)
+self._scm.delete(file_name)
+
 for directory, result in new_results_by_directory.items():
 if results_by_directory.get(directory) != result:
-source = self._filesystem.join(self._scm.checkout_root, source_directory_for_result[result], baseline_name)
 destination = self._filesystem.join(self._scm.checkout_root, directory, baseline_name)
 self._filesystem.maybe_make_directory(self._filesystem.split(destination)[0])
-self._filesystem.copyfile(source, destination)
+self._filesystem.write_binary_file(destination, data_for_result[result])
 self._scm.add(destination)
 
-for directory, result in results_by_directory.items():
-if new_results_by_directory.get(directory) != result:
-file_name = self._filesystem.join(self._scm.checkout_root, directory, baseline_name)
-self._scm.delete(file_name)
-# FIXME: Check for empty directories and remove them as well.
-
 def optimize(self, baseline_name):
 results_by_directory, new_results_by_directory = self._find_optimal_result_placement(baseline_name)
 if self._results_by_port_name(results_by_directory) != self._results_by_port_name(new_results_by_directory):


Modified: trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py (92668 => 92669)

--- trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py	2011-08-09 08:34:02 UTC (rev 92668)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py	2011-08-09 08:38:45 UTC (rev 92669)
@@ -50,6 +50,21 @@
 _, new_results_by_directory = baseline_optimizer._find_optimal_result_placement('mock-baseline.png')

[webkit-changes] [92670] trunk

2011-08-09 Thread pfeldman

Title: [92670] trunk








Revision 92670
Author pfeld...@chromium.org
Date 2011-08-09 02:05:16 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):
* inspector/front-end/inspector.css:
(.section .properties .dimmed):

LayoutTests:

* inspector/protocol/runtime-agent-expected.txt:
* inspector/runtime/runtime-getProperties-expected.txt:
* inspector/runtime/runtime-getProperties.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt
trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt
trunk/LayoutTests/inspector/runtime/runtime-getProperties.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScript.cpp
trunk/Source/WebCore/inspector/InjectedScript.h
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/RemoteObject.js
trunk/Source/WebCore/inspector/front-end/inspector.css


Removed Paths

trunk/LayoutTests/platform/chromium/inspector/runtime/runtime-getProperties-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92669 => 92670)

--- trunk/LayoutTests/ChangeLog	2011-08-09 08:38:45 UTC (rev 92669)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 09:05:16 UTC (rev 92670)
@@ -1,3 +1,14 @@
+2011-08-09  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
+https://bugs.webkit.org/show_bug.cgi?id=65518
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/protocol/runtime-agent-expected.txt:
+* inspector/runtime/runtime-getProperties-expected.txt:
+* inspector/runtime/runtime-getProperties.html:
+
 2011-08-09  Nikolas Zimmermann  nzimmerm...@rim.com
 
 svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky


Modified: trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt (92669 => 92670)

--- trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt	2011-08-09 08:38:45 UTC (rev 92669)
+++ trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt	2011-08-09 09:05:16 UTC (rev 92670)
@@ -167,7 +167,7 @@
 method : Runtime.getProperties
 params : {
 objectId : string
-ignoreHasOwnProperty : false
+ownProperties : false
 }
 id : number
 }
@@ -177,30 +177,27 @@
 result : {
 result : [
 {
-name : assignedByCallFunctionOn
 value : {
 type : string
 value : callFunctionOn function works fine
 }
+writable : true
+enumerable : true
+configurable : true
+name : assignedByCallFunctionOn
 }
 {
-name : self
 value : {
 type : object
 objectId : string
 className : string
 description : TestObject
 }
+writable : true
+enumerable : true
+configurable : true
+name : self
 }
-{
-name : __proto__
-value : {
-type : object
-objectId : string
-className : string
-description : TestObject
-}
-}
 ]
 }
 id : number


Modified: trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt (92669 => 92670)

--- trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt	2011-08-09 08:38:45 UTC (rev 92669)
+++ trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt	2011-08-09 09:05:16 UTC (rev 92670)
@@ -9,14 +9,20 @@
 value : {
 type : function
 description : function () { return 1; }
+objectId : string
 }
+

[webkit-changes] [92671] trunk

2011-08-09 Thread commit-queue

Title: [92671] trunk








Revision 92671
Author commit-qu...@webkit.org
Date 2011-08-09 03:26:02 -0700 (Tue, 09 Aug 2011)


Log Message
Unreviewed, rolling out r92670.
http://trac.webkit.org/changeset/92670
https://bugs.webkit.org/show_bug.cgi?id=65905

It broke 3 inspector tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-08-09

Source/WebCore:

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype._getProperties.remoteObjectBinder):
(WebInspector.RemoteObject.prototype._getProperties):
(WebInspector.RemoteObjectProperty):
* inspector/front-end/inspector.css:
(.section .properties .value.dimmed):

LayoutTests:

* inspector/protocol/runtime-agent-expected.txt:
* inspector/runtime/runtime-getProperties-expected.txt:
* inspector/runtime/runtime-getProperties.html:
* platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt
trunk/LayoutTests/inspector/runtime/runtime-getProperties-expected.txt
trunk/LayoutTests/inspector/runtime/runtime-getProperties.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InjectedScript.cpp
trunk/Source/WebCore/inspector/InjectedScript.h
trunk/Source/WebCore/inspector/InjectedScriptSource.js
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/RemoteObject.js
trunk/Source/WebCore/inspector/front-end/inspector.css


Added Paths

trunk/LayoutTests/platform/chromium/inspector/runtime/runtime-getProperties-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92670 => 92671)

--- trunk/LayoutTests/ChangeLog	2011-08-09 09:05:16 UTC (rev 92670)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 10:26:02 UTC (rev 92671)
@@ -1,3 +1,16 @@
+2011-08-09  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r92670.
+http://trac.webkit.org/changeset/92670
+https://bugs.webkit.org/show_bug.cgi?id=65905
+
+It broke 3 inspector tests (Requested by Ossy on #webkit).
+
+* inspector/protocol/runtime-agent-expected.txt:
+* inspector/runtime/runtime-getProperties-expected.txt:
+* inspector/runtime/runtime-getProperties.html:
+* platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Added.
+
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.


Modified: trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt (92670 => 92671)

--- trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt	2011-08-09 09:05:16 UTC (rev 92670)
+++ trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt	2011-08-09 10:26:02 UTC (rev 92671)
@@ -167,7 +167,7 @@
 method : Runtime.getProperties
 params : {
 objectId : string
-ownProperties : false
+ignoreHasOwnProperty : false
 }
 id : number
 }
@@ -177,27 +177,30 @@
 result : {
 result : [
 {
+name : assignedByCallFunctionOn
 value : {
 type : string
 value : callFunctionOn function works fine
 }
-writable : true
-enumerable : true
-configurable : true
-name : assignedByCallFunctionOn
 }
 {
+name : self
 value : {
 type : object
 objectId : string
 className : string
 description : TestObject
 }
-writable : true
-enumerable : true
-configurable : true
-name : self
 }
+{
+name : __proto__
+value : {
+type : object
+objectId : string
+className : string
+description : TestObject
+}
+}
 ]
 }
 id : number


Modified:

[webkit-changes] [92672] trunk

2011-08-09 Thread vsevik

Title: [92672] trunk








Revision 92672
Author vse...@chromium.org
Date 2011-08-09 03:33:54 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: Resources panel does not show main resource cookies.
https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

* inspector/InspectorPageAgent.cpp:
(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

* http/tests/inspector/resource-main-cookies-expected.txt: Added.
* http/tests/inspector/resource-main-cookies.php: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp


Added Paths

trunk/LayoutTests/http/tests/inspector/resource-main-cookies-expected.txt
trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php




Diff

Modified: trunk/LayoutTests/ChangeLog (92671 => 92672)

--- trunk/LayoutTests/ChangeLog	2011-08-09 10:26:02 UTC (rev 92671)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 10:33:54 UTC (rev 92672)
@@ -1,3 +1,14 @@
+2011-08-09  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Resources panel does not show main resource cookies.
+https://bugs.webkit.org/show_bug.cgi?id=65770
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/resource-main-cookies-expected.txt: Added.
+* http/tests/inspector/resource-main-cookies.php: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-08-09  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r92670.


Added: trunk/LayoutTests/http/tests/inspector/resource-main-cookies-expected.txt (0 => 92672)

--- trunk/LayoutTests/http/tests/inspector/resource-main-cookies-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-main-cookies-expected.txt	2011-08-09 10:33:54 UTC (rev 92672)
@@ -0,0 +1,6 @@
+This tests that the cookie set by main resource is shown in resources panel.
+
+bug 65770.
+Page reloaded.
+Cookie: cookieName=cookieValue.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/resource-main-cookies-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php (0 => 92672)

--- trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php	(rev 0)
+++ trunk/LayoutTests/http/tests/inspector/resource-main-cookies.php	2011-08-09 10:33:54 UTC (rev 92672)
@@ -0,0 +1,51 @@
+?php
+if (!$_COOKIE[cookieName])
+setcookie(cookieName, cookieValue);
+?
+html
+head
+script src=""
+script
+
+function test()
+{
+var cookieName = cookieName;
+var cookieDomain = 127.0.0.1;
+// Ensure cookie is deleted before testing.
+PageAgent.deleteCookie(cookieName, cookieDomain, step1);
+
+function step1()
+{
+InspectorTest.reloadPage(step2);
+}
+
+function step2()
+{
+WebInspector.Cookies.getCookiesAsync(step3);
+}
+
+function step3(allCookies, isAdvanced)
+{
+for (var i = 0; i  allCookies.length; i++) {
+  var cookie = allCookies[i];
+if (cookie.name === cookieName  cookie.domain == cookieDomain) {
+InspectorTest.addResult(Cookie:  + cookie.name + = + cookie.value + .);
+}
+}
+// Ensure cookie is deleted after testing.
+PageAgent.deleteCookie(cookieName, cookieDomain, step4);
+}
+
+function step4()
+{
+InspectorTest.completeTest();
+}
+}
+
+/script
+/head
+body _onload_=runTest()
+pThis tests that the cookie set by main resource is shown in resources panel./p
+a href="" 65770/a.
+/body
+/html


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92671 => 92672)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-09 10:26:02 UTC (rev 92671)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-09 10:33:54 UTC (rev 92672)
@@ -637,6 +637,9 @@
 BUGWK56602 SKIP : http/tests/inspector/network/network-size-chunked.html = FAIL
 BUGWK56602 SKIP : http/tests/inspector/network/network-size-sync.html = FAIL
 
+// PageAgent can not getCookies from DumpRenderTree.
+BUGWK65770 SKIP : http/tests/inspector/resource-main-cookies.php = FAIL
+
 BUGWK60110 WIN RELEASE : http/tests/inspector/resource-tree/resource-tree-reload.html = PASS TEXT
 BUGWK60110 SLOW WIN DEBUG : http/tests/inspector/resource-tree/resource-tree-reload.html = PASS TEXT
 BUGWK60110 SLOW LINUX : http/tests/inspector/resource-tree/resource-tree-reload.html = PASS TEXT


Modified: trunk/Source/WebCore/ChangeLog (92671 => 92672)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 10:26:02 UTC (rev 92671)
+++

[webkit-changes] [92673] trunk/LayoutTests

2011-08-09 Thread andreip

Title: [92673] trunk/LayoutTests








Revision 92673
Author andr...@google.com
Date 2011-08-09 03:34:54 -0700 (Tue, 09 Aug 2011)


Log Message
2011-08-09  Andrei Popescu  andr...@google.com

[Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (92672 => 92673)

--- trunk/LayoutTests/ChangeLog	2011-08-09 10:33:54 UTC (rev 92672)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 10:34:54 UTC (rev 92673)
@@ -1,3 +1,11 @@
+2011-08-09  Andrei Popescu  andr...@google.com
+
+[Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+
 2011-08-09  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Resources panel does not show main resource cookies.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (92672 => 92673)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-09 10:33:54 UTC (rev 92672)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-08-09 10:34:54 UTC (rev 92673)
@@ -3591,7 +3591,7 @@
 // WebKit roll 80564:80631: rendering on Leopard is shifted to the top right
 // started at some point at or after WK r80582 (Dave Hyatt's vertical text change - a very likely candidate)
 //BUGCR75424 LEOPARD : fast/writing-mode/broken-ideograph-small-caps.html = IMAGE
-BUGCR75424 LEOPARD : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE
+BUGCR75424 LEOPARD : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE IMAGE+TEXT
 
 BUGCR89673 : fast/js/object-prototype-properties.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92674] trunk/Source/WebCore

2011-08-09 Thread vsevik

Title: [92674] trunk/Source/WebCore








Revision 92674
Author vse...@chromium.org
Date 2011-08-09 03:39:27 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: Add Refresh to context menu of resources panel cookies view.
https://bugs.webkit.org/show_bug.cgi?id=65854

Reviewed by Pavel Feldman.

* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
(WebInspector.CookieItemsView.prototype._contextMenu):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.get refreshCallback):
(WebInspector.DataGrid.prototype.set refreshCallback):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CookieItemsView.js
trunk/Source/WebCore/inspector/front-end/CookiesTable.js
trunk/Source/WebCore/inspector/front-end/DataGrid.js
trunk/Source/WebCore/inspector/front-end/ResourceCookiesView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (92673 => 92674)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 10:34:54 UTC (rev 92673)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 10:39:27 UTC (rev 92674)
@@ -1,5 +1,26 @@
 2011-08-09  Vsevolod Vlasov  vse...@chromium.org
 
+Web Inspector: Add Refresh to context menu of resources panel cookies view.
+https://bugs.webkit.org/show_bug.cgi?id=65854
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/CookieItemsView.js:
+(WebInspector.CookieItemsView):
+(WebInspector.CookieItemsView.prototype._updateWithCookies):
+(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
+(WebInspector.CookieItemsView.prototype._contextMenu):
+* inspector/front-end/CookiesTable.js:
+(WebInspector.CookiesTable):
+* inspector/front-end/DataGrid.js:
+(WebInspector.DataGrid.prototype.get refreshCallback):
+(WebInspector.DataGrid.prototype.set refreshCallback):
+(WebInspector.DataGrid.prototype._contextMenuInDataTable):
+* inspector/front-end/ResourceCookiesView.js:
+(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):
+
+2011-08-09  Vsevolod Vlasov  vse...@chromium.org
+
 Web Inspector: Resources panel does not show main resource cookies.
 https://bugs.webkit.org/show_bug.cgi?id=65770
 


Modified: trunk/Source/WebCore/inspector/front-end/CookieItemsView.js (92673 => 92674)

--- trunk/Source/WebCore/inspector/front-end/CookieItemsView.js	2011-08-09 10:34:54 UTC (rev 92673)
+++ trunk/Source/WebCore/inspector/front-end/CookieItemsView.js	2011-08-09 10:39:27 UTC (rev 92674)
@@ -45,6 +45,8 @@
 
 this._emptyView = new WebInspector.EmptyView(WebInspector.UIString(This site has no cookies.));
 this._emptyView.show(this.element);
+
+this.element.addEventListener(contextmenu, this._contextMenu.bind(this), true);
 }
 
 WebInspector.CookieItemsView.prototype = {
@@ -90,7 +92,7 @@
 }
 
 if (!this._cookiesTable) {
-this._cookiesTable = isAdvanced ? new WebInspector.CookiesTable(this._cookieDomain, false, this._deleteCookie.bind(this)) : new WebInspector.SimpleCookiesTable();
+this._cookiesTable = isAdvanced ? new WebInspector.CookiesTable(this._cookieDomain, false, this._deleteCookie.bind(this), this._update.bind(this)) : new WebInspector.SimpleCookiesTable();
 this.element.appendChild(this._cookiesTable.element);
 }
 
@@ -151,6 +153,15 @@
 _refreshButtonClicked: function(event)
 {
 this._update();
+},
+
+_contextMenu: function()
+{
+if (!this._cookies.length) {
+var contextMenu = new WebInspector.ContextMenu();
+contextMenu.appendItem(WebInspector.UIString(Refresh), this._update.bind(this));
+contextMenu.show(event);
+}
 }
 }
 


Modified: trunk/Source/WebCore/inspector/front-end/CookiesTable.js (92673 => 92674)

--- trunk/Source/WebCore/inspector/front-end/CookiesTable.js	2011-08-09 10:34:54 UTC (rev 92673)
+++ trunk/Source/WebCore/inspector/front-end/CookiesTable.js	2011-08-09 10:39:27 UTC (rev 92674)
@@ -28,7 +28,7 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-WebInspector.CookiesTable = function(cookieDomain, expandable, deleteCallback)
+WebInspector.CookiesTable = function(cookieDomain, expandable, deleteCallback, refreshCallback)
 {
 this._cookieDomain = cookieDomain;
 
@@ -64,6 +64,7 @@
 
 this._dataGrid = new WebInspector.DataGrid(columns, null, deleteCallback ? this._onDeleteFromGrid.bind(this) : null);
 this._dataGrid.addEventListener(sorting changed, this._rebuildTable, this);
+

[webkit-changes] [92675] trunk/Source/WebKit/chromium

2011-08-09 Thread jochen

Title: [92675] trunk/Source/WebKit/chromium








Revision 92675
Author joc...@chromium.org
Date 2011-08-09 05:17:06 -0700 (Tue, 09 Aug 2011)


Log Message
Unreviewed.  Rolled DEPS.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (92674 => 92675)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-09 10:39:27 UTC (rev 92674)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-09 12:17:06 UTC (rev 92675)
@@ -1,3 +1,9 @@
+2011-08-09  Jochen Eisinger  joc...@chromium.org
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2011-08-08  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r92619.


Modified: trunk/Source/WebKit/chromium/DEPS (92674 => 92675)

--- trunk/Source/WebKit/chromium/DEPS	2011-08-09 10:39:27 UTC (rev 92674)
+++ trunk/Source/WebKit/chromium/DEPS	2011-08-09 12:17:06 UTC (rev 92675)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '95783'
+  'chromium_rev': '95813'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92676] trunk/LayoutTests

2011-08-09 Thread vsevik

Title: [92676] trunk/LayoutTests








Revision 92676
Author vse...@chromium.org
Date 2011-08-09 05:26:28 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=65911

Unreviewed. Skipped test failing on qt.

* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (92675 => 92676)

--- trunk/LayoutTests/ChangeLog	2011-08-09 12:17:06 UTC (rev 92675)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 12:26:28 UTC (rev 92676)
@@ -1,3 +1,12 @@
+2011-08-09  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release
+https://bugs.webkit.org/show_bug.cgi?id=65911
+
+Unreviewed. Skipped test failing on qt.
+
+* platform/qt/Skipped:
+
 2011-08-09  Andrei Popescu  andr...@google.com
 
 [Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html


Modified: trunk/LayoutTests/platform/qt/Skipped (92675 => 92676)

--- trunk/LayoutTests/platform/qt/Skipped	2011-08-09 12:17:06 UTC (rev 92675)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-08-09 12:26:28 UTC (rev 92676)
@@ -1867,6 +1867,9 @@
 http/tests/inspector/network/network-disable-cache-xhrs.html
 http/tests/inspector/network/disabled-cache-crash.html
 
+# https://bugs.webkit.org/show_bug.cgi?id=65911
+http/tests/inspector/resource-main-cookies.php
+
 # [Qt] media/video-playbackrate.html fails
 # https://bugs.webkit.org/show_bug.cgi?id=57476
 media/video-playbackrate.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92677] trunk/Source/WebCore

2011-08-09 Thread yurys

Title: [92677] trunk/Source/WebCore








Revision 92677
Author yu...@chromium.org
Date 2011-08-09 06:03:20 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
https://bugs.webkit.org/show_bug.cgi?id=54678

Added two functions for retrieving InstrumentingAgents from Page and WorkerContext.

Reviewed by Pavel Feldman.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
* inspector/InspectorInstrumentation.h:
* inspector/InstrumentingAgents.cpp: Copied from Source/WebCore/inspector/WorkerInspectorController.h.
(WebCore::instrumentationForPage):
(WebCore::instrumentationForWorkerContext):
* inspector/InstrumentingAgents.h:
* inspector/WorkerInspectorController.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorController.h
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InstrumentingAgents.h
trunk/Source/WebCore/inspector/WorkerInspectorController.h


Added Paths

trunk/Source/WebCore/inspector/InstrumentingAgents.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (92676 => 92677)

--- trunk/Source/WebCore/CMakeLists.txt	2011-08-09 12:26:28 UTC (rev 92676)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-08-09 13:03:20 UTC (rev 92677)
@@ -884,6 +884,7 @@
 inspector/InspectorTimelineAgent.cpp
 inspector/InspectorValues.cpp
 inspector/InspectorWorkerAgent.cpp
+inspector/InstrumentingAgents.cpp
 inspector/NetworkResourcesData.cpp
 inspector/PageDebuggerAgent.cpp
 inspector/ScriptArguments.cpp


Modified: trunk/Source/WebCore/ChangeLog (92676 => 92677)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 12:26:28 UTC (rev 92676)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 13:03:20 UTC (rev 92677)
@@ -1,3 +1,31 @@
+2011-08-09  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
+https://bugs.webkit.org/show_bug.cgi?id=54678
+
+Added two functions for retrieving InstrumentingAgents from Page and WorkerContext.
+
+Reviewed by Pavel Feldman.
+
+* CMakeLists.txt:
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.pro:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* inspector/InspectorController.cpp:
+(WebCore::InspectorController::InspectorController):
+(WebCore::InspectorController::inspectedPageDestroyed):
+* inspector/InspectorController.h:
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
+* inspector/InspectorInstrumentation.h:
+* inspector/InstrumentingAgents.cpp: Copied from Source/WebCore/inspector/WorkerInspectorController.h.
+(WebCore::instrumentationForPage):
+(WebCore::instrumentationForWorkerContext):
+* inspector/InstrumentingAgents.h:
+* inspector/WorkerInspectorController.h:
+
 2011-08-09  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Add Refresh to context menu of resources panel cookies view.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (92676 => 92677)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 12:26:28 UTC (rev 92676)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 13:03:20 UTC (rev 92677)
@@ -2027,6 +2027,7 @@
 	Source/WebCore/inspector/InspectorWorkerAgent.cpp \
 	Source/WebCore/inspector/InspectorWorkerAgent.h \
 	Source/WebCore/inspector/InspectorWorkerResource.h \
+	Source/WebCore/inspector/InstrumentingAgents.cpp \
 	Source/WebCore/inspector/InstrumentingAgents.h \
 	Source/WebCore/inspector/NetworkResourcesData.cpp \
 	Source/WebCore/inspector/NetworkResourcesData.h \


Modified: trunk/Source/WebCore/WebCore.gypi (92676 => 92677)

--- trunk/Source/WebCore/WebCore.gypi	2011-08-09 12:26:28 UTC (rev 92676)
+++ trunk/Source/WebCore/WebCore.gypi	2011-08-09 13:03:20 UTC (rev 92677)
@@ -2713,6 +2713,7 @@
 'inspector/InspectorWorkerResource.h',
 'inspector/InspectorWorkerAgent.cpp',
 'inspector/InspectorWorkerAgent.h',
+'inspector/InstrumentingAgents.cpp',

[webkit-changes] [92678] trunk/Source/WebCore

2011-08-09 Thread caseq

Title: [92678] trunk/Source/WebCore








Revision 92678
Author ca...@chromium.org
Date 2011-08-09 06:24:21 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92677 => 92678)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 13:03:20 UTC (rev 92677)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 13:24:21 UTC (rev 92678)
@@ -1,3 +1,13 @@
+2011-08-09  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
+https://bugs.webkit.org/show_bug.cgi?id=65912
+
+Reviewed by Pavel Feldman.
+
+* inspector/InspectorDOMStorageAgent.cpp:
+(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
+
 2011-08-09  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map


Modified: trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp (92677 => 92678)

--- trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp	2011-08-09 13:03:20 UTC (rev 92677)
+++ trunk/Source/WebCore/inspector/InspectorDOMStorageAgent.cpp	2011-08-09 13:24:21 UTC (rev 92678)
@@ -181,7 +181,7 @@
 m_resources.set(resource-id(), resource);
 
 // Resources are only bound while visible.
-if (m_frontend)
+if (m_enabled)
 resource-bind(m_frontend);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92679] trunk/Source/WebKit/chromium

2011-08-09 Thread jochen

Title: [92679] trunk/Source/WebKit/chromium








Revision 92679
Author joc...@chromium.org
Date 2011-08-09 06:32:29 -0700 (Tue, 09 Aug 2011)


Log Message
[chromium] remove temporary #define from WebURLRequest.h
https://bugs.webkit.org/show_bug.cgi?id=65813

Reviewed by Darin Fisher.

* public/WebURLRequest.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebURLRequest.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (92678 => 92679)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-08-09 13:24:21 UTC (rev 92678)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-08-09 13:32:29 UTC (rev 92679)
@@ -1,5 +1,14 @@
 2011-08-09  Jochen Eisinger  joc...@chromium.org
 
+[chromium] remove temporary #define from WebURLRequest.h
+https://bugs.webkit.org/show_bug.cgi?id=65813
+
+Reviewed by Darin Fisher.
+
+* public/WebURLRequest.h:
+
+2011-08-09  Jochen Eisinger  joc...@chromium.org
+
 Unreviewed.  Rolled DEPS.
 
 * DEPS:


Modified: trunk/Source/WebKit/chromium/public/WebURLRequest.h (92678 => 92679)

--- trunk/Source/WebKit/chromium/public/WebURLRequest.h	2011-08-09 13:24:21 UTC (rev 92678)
+++ trunk/Source/WebKit/chromium/public/WebURLRequest.h	2011-08-09 13:32:29 UTC (rev 92679)
@@ -38,9 +38,6 @@
 namespace WebCore { class ResourceRequest; }
 #endif
 
-// FIXME: remove #define once the Chromium side has updated.
-#define WEBKIT_HAS_TARGET_IS_XHR
-
 namespace WebKit {
 
 class WebCString;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92680] trunk/Source/WebKit2

2011-08-09 Thread kenneth

Title: [92680] trunk/Source/WebKit2








Revision 92680
Author kenn...@webkit.org
Date 2011-08-09 07:10:57 -0700 (Tue, 09 Aug 2011)


Log Message
[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
https://bugs.webkit.org/show_bug.cgi?id=65907

Reviewed by Andreas Kling.

This is upstreaming of the algorithm we are currently using on the N9 browser
and this also fixes a bug with not considering the frame positions when finding
a zoomable area.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFindZoomableArea):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::didFindZoomableArea):
* UIProcess/qt/qdesktopwebpageproxy.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::didFindZoomableArea):
* UIProcess/qt/qtouchwebpageproxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/PageClient.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp
trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.h
trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp
trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92679 => 92680)

--- trunk/Source/WebKit2/ChangeLog	2011-08-09 13:32:29 UTC (rev 92679)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-09 14:10:57 UTC (rev 92680)
@@ -1,3 +1,28 @@
+2011-08-09  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
+https://bugs.webkit.org/show_bug.cgi?id=65907
+
+Reviewed by Andreas Kling.
+
+This is upstreaming of the algorithm we are currently using on the N9 browser
+and this also fixes a bug with not considering the frame positions when finding
+a zoomable area.
+
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didFindZoomableArea):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* UIProcess/qt/qdesktopwebpageproxy.cpp:
+(QDesktopWebPageProxy::didFindZoomableArea):
+* UIProcess/qt/qdesktopwebpageproxy.h:
+* UIProcess/qt/qtouchwebpageproxy.cpp:
+(QTouchWebPageProxy::didFindZoomableArea):
+* UIProcess/qt/qtouchwebpageproxy.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::findZoomableAreaForPoint):
+
 2011-08-08  Chris Marrin  cmar...@apple.com
 
 Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState


Modified: trunk/Source/WebKit2/UIProcess/PageClient.h (92679 => 92680)

--- trunk/Source/WebKit2/UIProcess/PageClient.h	2011-08-09 13:32:29 UTC (rev 92679)
+++ trunk/Source/WebKit2/UIProcess/PageClient.h	2011-08-09 14:10:57 UTC (rev 92680)
@@ -104,7 +104,7 @@
 #endif
 #if PLATFORM(QT)
 virtual void didChangeContentsSize(const WebCore::IntSize) = 0;
-virtual void didFindZoomableArea(const WebCore::IntRect) = 0;
+virtual void didFindZoomableArea(const WebCore::IntPoint, const WebCore::IntRect) = 0;
 
 virtual void startDrag(const WebCore::DragData, PassRefPtrShareableBitmap dragImage) = 0;
 #endif


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (92679 => 92680)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-09 13:32:29 UTC (rev 92679)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2011-08-09 14:10:57 UTC (rev 92680)
@@ -2202,9 +2202,9 @@
 m_pageClient-didChangeContentsSize(size);
 }
 
-void WebPageProxy::didFindZoomableArea(const IntRect area)
+void WebPageProxy::didFindZoomableArea(const IntPoint target, const IntRect area)
 {
-m_pageClient-didFindZoomableArea(area);
+m_pageClient-didFindZoomableArea(target, area);
 }
 
 void WebPageProxy::findZoomableAreaForPoint(const IntPoint point)


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (92679 => 92680)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2011-08-09 13:32:29 UTC (rev 92679)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2011-08-09 14:10:57 UTC (rev 92680)
@@ -661,7 +661,7 @@
 
 #if PLATFORM(QT)
 void didChangeContentsSize(const WebCore::IntSize);
-void didFindZoomableArea(const WebCore::IntRect);
+void didFindZoomableArea(const WebCore::IntPoint, const WebCore::IntRect);
 #endif
 #if ENABLE(TOUCH_EVENTS)
 void needTouchEvents(bool);


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in (92679 => 92680)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in	2011-08-09 13:32:29 UTC (rev 92679)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in	2011-08-09 14:10:57

[webkit-changes] [92681] trunk/Source/WebCore

2011-08-09 Thread steveblock

Title: [92681] trunk/Source/WebCore








Revision 92681
Author stevebl...@google.com
Date 2011-08-09 07:18:53 -0700 (Tue, 09 Aug 2011)


Log Message
JavaMethodJobject is no longer needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65910

Reviewed by Tony Gentilcore.

Removes the JavaMethod interface and moves the JavaMethodJobject
implementation to bridge/jni/jsc/JavaMethodJSC.[cpp|h].

No new tests, refactoring only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaMethod.h: Removed.
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaFieldJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaMethodJSC.cpp: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.cpp.
(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):
* bridge/jni/jsc/JavaMethodJSC.h: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.h.
(JSC::Bindings::JavaMethod::name):
(JSC::Bindings::JavaMethod::returnTypeClassName):
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::returnType):
(JSC::Bindings::JavaMethod::isStatic):
(JSC::Bindings::JavaMethod::numParameters):
* bridge/jni/v8/JavaNPObjectV8.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bridge/jni/jsc/JavaClassJSC.cpp
trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.h
trunk/Source/WebCore/bridge/jni/jsc/JavaInstanceJSC.cpp
trunk/Source/WebCore/bridge/jni/v8/JavaNPObjectV8.cpp


Added Paths

trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp
trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.h


Removed Paths

trunk/Source/WebCore/bridge/jni/JavaMethod.h
trunk/Source/WebCore/bridge/jni/JavaMethodJobject.cpp
trunk/Source/WebCore/bridge/jni/JavaMethodJobject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92680 => 92681)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 14:10:57 UTC (rev 92680)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 14:18:53 UTC (rev 92681)
@@ -1,3 +1,37 @@
+2011-08-09  Steve Block  stevebl...@google.com
+
+JavaMethodJobject is no longer needed by V8
+https://bugs.webkit.org/show_bug.cgi?id=65910
+
+Reviewed by Tony Gentilcore.
+
+Removes the JavaMethod interface and moves the JavaMethodJobject
+implementation to bridge/jni/jsc/JavaMethodJSC.[cpp|h].
+
+No new tests, refactoring only.
+
+* GNUmakefile.list.am:
+* WebCore.gypi:
+* WebCore.xcodeproj/project.pbxproj:
+* bridge/jni/JavaMethod.h: Removed.
+* bridge/jni/jsc/JavaClassJSC.cpp:
+(JavaClass::JavaClass):
+* bridge/jni/jsc/JavaFieldJSC.h:
+* bridge/jni/jsc/JavaInstanceJSC.cpp:
+* bridge/jni/jsc/JavaMethodJSC.cpp: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.cpp.
+(JavaMethod::JavaMethod):
+(JavaMethod::~JavaMethod):
+(appendClassName):
+(JavaMethod::signature):
+* bridge/jni/jsc/JavaMethodJSC.h: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.h.
+(JSC::Bindings::JavaMethod::name):
+(JSC::Bindings::JavaMethod::returnTypeClassName):
+(JSC::Bindings::JavaMethod::parameterAt):
+(JSC::Bindings::JavaMethod::returnType):
+(JSC::Bindings::JavaMethod::isStatic):
+(JSC::Bindings::JavaMethod::numParameters):
+* bridge/jni/v8/JavaNPObjectV8.cpp:
+
 2011-08-09  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector


Modified: trunk/Source/WebCore/GNUmakefile.list.am (92680 => 92681)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 14:10:57 UTC (rev 92680)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-08-09 14:18:53 UTC (rev 92681)
@@ -884,9 +884,6 @@
 	Source/WebCore/bridge/IdentifierRep.cpp \
 	Source/WebCore/bridge/IdentifierRep.h \
 	Source/WebCore/bridge/jni/JNIUtility.h \
-	Source/WebCore/bridge/jni/JavaMethod.h \
-	Source/WebCore/bridge/jni/JavaMethodJobject.cpp \
-	Source/WebCore/bridge/jni/JavaMethodJobject.h \
 	Source/WebCore/bridge/jni/JavaString.h \
 	Source/WebCore/bridge/jni/JavaType.h \
 	Source/WebCore/bridge/jni/jni_jsobject.h \
@@ -894,6 +891,8 @@
 	Source/WebCore/bridge/jni/jsc/JavaClassJSC.h \
 	Source/WebCore/bridge/jni/jsc/JavaFieldJSC.h \
 	Source/WebCore/bridge/jni/jsc/JavaInstanceJSC.h \
+	Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp \
+	Source/WebCore/bridge/jni/jsc/JavaMethodJSC.h \
 	Source/WebCore/bridge/jsc/BridgeJSC.cpp \
 	Source/WebCore/bridge/jsc/BridgeJSC.h \
 	Source/WebCore/bridge/npapi.h \


Modified: trunk/Source/WebCore/WebCore.gypi (92680 => 92681)

--- trunk/Source/WebCore/WebCore.gypi	2011-08-09 14:10:57 UTC (rev 92680)
+++ trunk/Source/WebCore/WebCore.gypi	2011-08-09 14:18:53 UTC (rev 92681)
@@ -2232,9 +2232,6 @@

[webkit-changes] [92682] trunk

2011-08-09 Thread pfeldman

Title: [92682] trunk








Revision 92682
Author pfeld...@chromium.org
Date 2011-08-09 07:24:15 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: provide a way to hide user agent styles
https://bugs.webkit.org/show_bug.cgi?id=37766

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/show-user-agent-styles.html

* English.lproj/localizedStrings.js:
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):

LayoutTests:

* inspector/styles/show-user-agent-styles-expected.txt: Added.
* inspector/styles/show-user-agent-styles.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js


Added Paths

trunk/LayoutTests/inspector/styles/show-user-agent-styles-expected.txt
trunk/LayoutTests/inspector/styles/show-user-agent-styles.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92681 => 92682)

--- trunk/LayoutTests/ChangeLog	2011-08-09 14:18:53 UTC (rev 92681)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 14:24:15 UTC (rev 92682)
@@ -1,3 +1,13 @@
+2011-08-09  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: provide a way to hide user agent styles
+https://bugs.webkit.org/show_bug.cgi?id=37766
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/styles/show-user-agent-styles-expected.txt: Added.
+* inspector/styles/show-user-agent-styles.html: Added.
+
 2011-08-09  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release


Added: trunk/LayoutTests/inspector/styles/show-user-agent-styles-expected.txt (0 => 92682)

--- trunk/LayoutTests/inspector/styles/show-user-agent-styles-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/styles/show-user-agent-styles-expected.txt	2011-08-09 14:24:15 UTC (rev 92682)
@@ -0,0 +1,36 @@
+Tests that user agent styles are shown based on the setting: https://bugs.webkit.org/show_bug.cgi?id=37766.
+
+I'm red.
+
+I'm also red.
+
+
+Running: testShowUserAgentStyles
+WebInspector.settings.showUserAgentStyles = true
+[expanded] element.style { ()
+
+ Matched CSS Rules 
+[expanded] h1 { (show-user-agent-styles.html:5)
+background-color: red;
+
+[expanded] h1 { (user agent stylesheet)
+display: block;
+font-size: 2em;
+-webkit-margin-before: 0.67em;
+-webkit-margin-after: 0.67em;
+-webkit-margin-start: 0px;
+-webkit-margin-end: 0px;
+font-weight: bold;
+
+
+
+Running: testShowUserAgentStyles
+WebInspector.settings.showUserAgentStyles = false
+[expanded] element.style { ()
+
+ Matched CSS Rules 
+[expanded] h1 { (show-user-agent-styles.html:5)
+background-color: red;
+
+
+
Property changes on: trunk/LayoutTests/inspector/styles/show-user-agent-styles-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/styles/show-user-agent-styles.html (0 => 92682)

--- trunk/LayoutTests/inspector/styles/show-user-agent-styles.html	(rev 0)
+++ trunk/LayoutTests/inspector/styles/show-user-agent-styles.html	2011-08-09 14:24:15 UTC (rev 92682)
@@ -0,0 +1,57 @@
+html
+head
+
+style
+h1 {
+background-color: red;
+}
+/style
+
+script src=""
+script src=""
+script
+
+function test()
+{
+InspectorTest.runTestSuite([
+function testShowUserAgentStyles(next)
+{
+WebInspector.settings.showUserAgentStyles.set(true);
+selectNodeAndDumpStyles(inspected, next);
+},
+
+function testShowUserAgentStyles(next)
+{
+WebInspector.settings.showUserAgentStyles.set(false);
+selectNodeAndDumpStyles(other, next);
+}
+]);
+
+function selectNodeAndDumpStyles(nodeId, next)
+{
+InspectorTest.addResult(WebInspector.settings.showUserAgentStyles =  + WebInspector.settings.showUserAgentStyles.get());
+InspectorTest.selectNodeAndWaitForStyles(nodeId, step1);
+
+function step1()
+{
+InspectorTest.dumpSelectedElementStyles(true, false, true);
+next();
+}
+}
+}
+
+/script
+/head
+
+body _onload_=runTest()
+p
+Tests that user agent styles are shown based on the setting: https://bugs.webkit.org/show_bug.cgi?id=37766.
+/p
+h1 id=inspected
+I'm red.
+/h1
+h1 id=other
+I'm also red.
+/h1
+/body
+/html
Property

[webkit-changes] [92683] trunk

2011-08-09 Thread siddharth . mathur

Title: [92683] trunk








Revision 92683
Author siddharth.mat...@nokia.com
Date 2011-08-09 07:24:36 -0700 (Tue, 09 Aug 2011)


Log Message
[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
https://bugs.webkit.org/show_bug.cgi?id=65880

Reviewed by Andreas Kling.

.:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

* Source/WebKit.pri:

Source/WebKit/qt:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Tools:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.
* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
* QtTestBrowser/webpage.cpp:
(WebPage::openUrlInDefaultBrowser):

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/qt/Api/qwebsettings.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit.pri
trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/cookiejar.cpp
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/main.cpp
trunk/Tools/QtTestBrowser/webpage.cpp




Diff

Modified: trunk/ChangeLog (92682 => 92683)

--- trunk/ChangeLog	2011-08-09 14:24:15 UTC (rev 92682)
+++ trunk/ChangeLog	2011-08-09 14:24:36 UTC (rev 92683)
@@ -1,3 +1,15 @@
+2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
+
+[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
+https://bugs.webkit.org/show_bug.cgi?id=65880
+
+Reviewed by Andreas Kling.
+
+QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
+check for their feature flags. Assume that any reasonable Qt build provides them. 
+
+* Source/WebKit.pri:
+
 2011-08-06  Aron Rosenberg  arosenb...@logitech.com
 
 Reviewed by Benjamin Poulain.


Modified: trunk/Source/WebKit/qt/Api/qwebsettings.cpp (92682 => 92683)

--- trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2011-08-09 14:24:15 UTC (rev 92682)
+++ trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2011-08-09 14:24:36 UTC (rev 92683)
@@ -1136,7 +1136,6 @@
 */
 void QWebSettings::enablePersistentStorage(const QString path)
 {
-#ifndef QT_NO_DESKTOPSERVICES
 QString storagePath;
 
 if (path.isEmpty()) {
@@ -1169,7 +1168,6 @@
 WebCore::PluginDatabase::setPersistentMetadataCachePath(cachePath);
 }
 #endif
-#endif
 }
 
 /*!


Modified: trunk/Source/WebKit/qt/ChangeLog (92682 => 92683)

--- trunk/Source/WebKit/qt/ChangeLog	2011-08-09 14:24:15 UTC (rev 92682)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-08-09 14:24:36 UTC (rev 92683)
@@ -1,3 +1,16 @@
+2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
+
+[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
+https://bugs.webkit.org/show_bug.cgi?id=65880
+
+Reviewed by Andreas Kling.
+
+QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
+check for their feature flags. Assume that any reasonable Qt build provides them. 
+
+* Api/qwebsettings.cpp:
+(QWebSettings::enablePersistentStorage):
+
 2011-08-05  Dawit Alemayehu  ada...@kde.org
 
 Reviewed by Andreas Kling.


Modified: trunk/Source/WebKit.pri (92682 => 92683)

--- trunk/Source/WebKit.pri	2011-08-09 14:24:15 UTC (rev 92682)
+++ trunk/Source/WebKit.pri	2011-08-09 14:24:36 UTC (rev 92683)
@@ -169,7 +169,6 @@
 DEFINES *= QT_NO_CONCURRENT
 DEFINES *= QT_NO_CRASHHANDLER
 DEFINES *= QT_NO_CURSOR
-DEFINES *= QT_NO_DESKTOPSERVICES
 DEFINES *= QT_NO_FILEDIALOG
 DEFINES *= QT_NO_GRAPHICSEFFECT
 DEFINES *= QT_NO_IM


Modified: trunk/Tools/ChangeLog (92682 => 92683)

--- trunk/Tools/ChangeLog	2011-08-09 14:24:15 UTC (rev 92682)
+++ trunk/Tools/ChangeLog	2011-08-09 14:24:36 UTC (rev 92683)
@@ -1,3 +1,22 @@
+2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
+
+[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
+https://bugs.webkit.org/show_bug.cgi?id=65880
+
+Reviewed by Andreas Kling.
+
+QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
+check for their feature flags. Assume that any reasonable Qt build provides them. 
+* QtTestBrowser/cookiejar.cpp:
+(TestBrowserCookieJar::TestBrowserCookieJar):
+* QtTestBrowser/launcherwindow.cpp:
+(LauncherWindow::createChrome):
+(LauncherWindow::setDiskCache):
+*

[webkit-changes] [92684] trunk/Source/WebKit2

2011-08-09 Thread kenneth

Title: [92684] trunk/Source/WebKit2








Revision 92684
Author kenn...@webkit.org
Date 2011-08-09 07:28:38 -0700 (Tue, 09 Aug 2011)


Log Message
[Qt] Redirect didFindZoomableArea thru to the view
https://bugs.webkit.org/show_bug.cgi?id=65913

Reviewed by Andreas Kling.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didFindZoomableArea):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didFindZoomableArea):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::didFindZoomableArea):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::timerEvent):
* UIProcess/qt/qdesktopwebpageproxy.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setContentsScale):
* UIProcess/qt/qtouchwebpageproxy.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/ViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.cpp
trunk/Source/WebKit2/UIProcess/qt/qdesktopwebpageproxy.h
trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp
trunk/Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (92683 => 92684)

--- trunk/Source/WebKit2/ChangeLog	2011-08-09 14:24:36 UTC (rev 92683)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-09 14:28:38 UTC (rev 92684)
@@ -1,5 +1,29 @@
 2011-08-09  Kenneth Rohde Christiansen  kenn...@webkit.org
 
+[Qt] Redirect didFindZoomableArea thru to the view
+https://bugs.webkit.org/show_bug.cgi?id=65913
+
+Reviewed by Andreas Kling.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::didFindZoomableArea):
+* UIProcess/API/qt/qdesktopwebview_p.h:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::didFindZoomableArea):
+* UIProcess/qt/QtWebPageProxy.h:
+* UIProcess/qt/TouchViewInterface.cpp:
+(WebKit::TouchViewInterface::didFindZoomableArea):
+* UIProcess/qt/TouchViewInterface.h:
+* UIProcess/qt/ViewInterface.h:
+* UIProcess/qt/qdesktopwebpageproxy.cpp:
+(QDesktopWebPageProxy::timerEvent):
+* UIProcess/qt/qdesktopwebpageproxy.h:
+* UIProcess/qt/qtouchwebpageproxy.cpp:
+(QTouchWebPageProxy::setContentsScale):
+* UIProcess/qt/qtouchwebpageproxy.h:
+
+2011-08-09  Kenneth Rohde Christiansen  kenn...@webkit.org
+
 [Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
 https://bugs.webkit.org/show_bug.cgi?id=65907
 


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp (92683 => 92684)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-08-09 14:24:36 UTC (rev 92683)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp	2011-08-09 14:28:38 UTC (rev 92684)
@@ -89,6 +89,11 @@
 *clientPosition = widget-mapFromGlobal(*globalPosition);
 }
 
+void QDesktopWebViewPrivate::didFindZoomableArea(const QPoint, const QRect)
+{
+// This feature is only used by QTouchWebView.
+}
+
 void QDesktopWebViewPrivate::didChangeUrl(const QUrl url)
 {
 emit q-urlChanged(url);


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h (92683 => 92684)

--- trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h	2011-08-09 14:24:36 UTC (rev 92683)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h	2011-08-09 14:28:38 UTC (rev 92684)
@@ -52,6 +52,7 @@
 virtual bool isVisible();
 
 virtual void startDrag(Qt::DropActions supportedDropActions, const QImage dragImage, QMimeData*, QPoint* clientPosition, QPoint* globalPosition, Qt::DropAction* dropAction);
+virtual void didFindZoomableArea(const QPoint, const QRect);
 
 virtual void didChangeUrl(const QUrl);
 virtual void didChangeTitle(const QString);


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (92683 => 92684)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-08-09 14:24:36 UTC (rev 92683)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp	2011-08-09 14:28:38 UTC (rev 92684)
@@ -400,6 +400,11 @@
 return toAPI(m_webPageProxy.get());;
 }
 
+void QtWebPageProxy::didFindZoomableArea(const IntPoint target, const IntRect area)
+{
+m_viewInterface-didFindZoomableArea(QPoint(target), QRect(area));
+}
+
 void QtWebPageProxy::didChangeUrl(const QUrl url)
 {
 m_viewInterface-didChangeUrl(url);


Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h (92683 => 92684)

--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h

[webkit-changes] [92685] trunk/Source/WebKit/efl

2011-08-09 Thread commit-queue

Title: [92685] trunk/Source/WebKit/efl








Revision 92685
Author commit-qu...@webkit.org
Date 2011-08-09 07:55:56 -0700 (Tue, 09 Aug 2011)


Log Message
[EFL] Fix warning caused by undefined static api.
https://bugs.webkit.org/show_bug.cgi?id=65301

Both _ewk_tiled_backing_store_item_request_add and _ewk_tiled_backing_store_item_request_del
are declared, but their bodies are not defined and they are not referenced anywhere.
Therefore, I remove both two API's declaration in order to resolve warning message caused by them.

Patch by KwangHyuk Kim hyuki@samsung.com on 2011-08-09
Reviewed by Kenneth Rohde Christiansen.

* ewk/ewk_tiled_backing_store.c:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (92684 => 92685)

--- trunk/Source/WebKit/efl/ChangeLog	2011-08-09 14:28:38 UTC (rev 92684)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-08-09 14:55:56 UTC (rev 92685)
@@ -1,3 +1,16 @@
+2011-08-09  KwangHyuk Kim  hyuki@samsung.com
+
+[EFL] Fix warning caused by undefined static api.
+https://bugs.webkit.org/show_bug.cgi?id=65301
+
+Both _ewk_tiled_backing_store_item_request_add and _ewk_tiled_backing_store_item_request_del
+are declared, but their bodies are not defined and they are not referenced anywhere.
+Therefore, I remove both two API's declaration in order to resolve warning message caused by them.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* ewk/ewk_tiled_backing_store.c:
+
 2011-08-05  Grzegorz Czajkowski  g.czajkow...@samsung.com
 
 [EFL] Move API documentation of ewk files to the headers


Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c (92684 => 92685)

--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c	2011-08-09 14:28:38 UTC (rev 92684)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.c	2011-08-09 14:55:56 UTC (rev 92685)
@@ -133,8 +133,6 @@
 return __VA_ARGS__;  \
 }
 
-static inline void _ewk_tiled_backing_store_item_request_del(Ewk_Tiled_Backing_Store_Data *priv, Ewk_Tiled_Backing_Store_Item *it);
-static inline void _ewk_tiled_backing_store_item_request_add(Ewk_Tiled_Backing_Store_Data *priv, Ewk_Tiled_Backing_Store_Item *it, int m_col, int m_row, float zoom);
 static void _ewk_tiled_backing_store_fill_renderers(Ewk_Tiled_Backing_Store_Data *priv);
 static inline void _ewk_tiled_backing_store_view_dbg(const Ewk_Tiled_Backing_Store_Data *priv);
 static inline void _ewk_tiled_backing_store_changed(Ewk_Tiled_Backing_Store_Data *priv);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92686] trunk

2011-08-09 Thread commit-queue

Title: [92686] trunk








Revision 92686
Author commit-qu...@webkit.org
Date 2011-08-09 08:01:45 -0700 (Tue, 09 Aug 2011)


Log Message
Unreviewed, rolling out r92683.
http://trac.webkit.org/changeset/92683
https://bugs.webkit.org/show_bug.cgi?id=65921

 Breaks Qt --minimal build. Revert pending update of the Qt
minimal configuration (Requested by simathur on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-08-09

.:

* Source/WebKit.pri:

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Tools:

* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
* QtTestBrowser/webpage.cpp:
(WebPage::openUrlInDefaultBrowser):

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit/qt/Api/qwebsettings.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit.pri
trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/cookiejar.cpp
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/main.cpp
trunk/Tools/QtTestBrowser/webpage.cpp




Diff

Modified: trunk/ChangeLog (92685 => 92686)

--- trunk/ChangeLog	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/ChangeLog	2011-08-09 15:01:45 UTC (rev 92686)
@@ -1,3 +1,14 @@
+2011-08-09  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r92683.
+http://trac.webkit.org/changeset/92683
+https://bugs.webkit.org/show_bug.cgi?id=65921
+
+ Breaks Qt --minimal build. Revert pending update of the Qt
+minimal configuration (Requested by simathur on #webkit).
+
+* Source/WebKit.pri:
+
 2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
 
 [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE


Modified: trunk/Source/WebKit/qt/Api/qwebsettings.cpp (92685 => 92686)

--- trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/Source/WebKit/qt/Api/qwebsettings.cpp	2011-08-09 15:01:45 UTC (rev 92686)
@@ -1136,6 +1136,7 @@
 */
 void QWebSettings::enablePersistentStorage(const QString path)
 {
+#ifndef QT_NO_DESKTOPSERVICES
 QString storagePath;
 
 if (path.isEmpty()) {
@@ -1168,6 +1169,7 @@
 WebCore::PluginDatabase::setPersistentMetadataCachePath(cachePath);
 }
 #endif
+#endif
 }
 
 /*!


Modified: trunk/Source/WebKit/qt/ChangeLog (92685 => 92686)

--- trunk/Source/WebKit/qt/ChangeLog	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/Source/WebKit/qt/ChangeLog	2011-08-09 15:01:45 UTC (rev 92686)
@@ -1,3 +1,15 @@
+2011-08-09  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r92683.
+http://trac.webkit.org/changeset/92683
+https://bugs.webkit.org/show_bug.cgi?id=65921
+
+ Breaks Qt --minimal build. Revert pending update of the Qt
+minimal configuration (Requested by simathur on #webkit).
+
+* Api/qwebsettings.cpp:
+(QWebSettings::enablePersistentStorage):
+
 2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
 
 [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE


Modified: trunk/Source/WebKit.pri (92685 => 92686)

--- trunk/Source/WebKit.pri	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/Source/WebKit.pri	2011-08-09 15:01:45 UTC (rev 92686)
@@ -169,6 +169,7 @@
 DEFINES *= QT_NO_CONCURRENT
 DEFINES *= QT_NO_CRASHHANDLER
 DEFINES *= QT_NO_CURSOR
+DEFINES *= QT_NO_DESKTOPSERVICES
 DEFINES *= QT_NO_FILEDIALOG
 DEFINES *= QT_NO_GRAPHICSEFFECT
 DEFINES *= QT_NO_IM


Modified: trunk/Tools/ChangeLog (92685 => 92686)

--- trunk/Tools/ChangeLog	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/Tools/ChangeLog	2011-08-09 15:01:45 UTC (rev 92686)
@@ -1,3 +1,22 @@
+2011-08-09  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r92683.
+http://trac.webkit.org/changeset/92683
+https://bugs.webkit.org/show_bug.cgi?id=65921
+
+ Breaks Qt --minimal build. Revert pending update of the Qt
+minimal configuration (Requested by simathur on #webkit).
+
+* QtTestBrowser/cookiejar.cpp:
+(TestBrowserCookieJar::TestBrowserCookieJar):
+* QtTestBrowser/launcherwindow.cpp:
+(LauncherWindow::createChrome):
+(LauncherWindow::setDiskCache):
+* QtTestBrowser/main.cpp:
+(LauncherApplication::handleUserOptions):
+* QtTestBrowser/webpage.cpp:
+(WebPage::openUrlInDefaultBrowser):
+
 2011-08-09  Siddharth Mathur  siddharth.mat...@nokia.com
 
 [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE


Modified: trunk/Tools/QtTestBrowser/cookiejar.cpp (92685 => 92686)

--- trunk/Tools/QtTestBrowser/cookiejar.cpp	2011-08-09 14:55:56 UTC (rev 92685)
+++ trunk/Tools/QtTestBrowser/cookiejar.cpp	2011-08-09 15:01:45 UTC (rev 92686)
@@ -41,7 +41,12 @@

[webkit-changes] [92687] trunk/LayoutTests

2011-08-09 Thread pfeldman

Title: [92687] trunk/LayoutTests








Revision 92687
Author pfeld...@chromium.org
Date 2011-08-09 08:22:16 -0700 (Tue, 09 Aug 2011)


Log Message
2011-08-09  Pavel Feldman  pfeld...@google.com

Not reviewed: fix inspector tests

* inspector/styles/show-user-agent-styles.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/show-user-agent-styles.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92686 => 92687)

--- trunk/LayoutTests/ChangeLog	2011-08-09 15:01:45 UTC (rev 92686)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 15:22:16 UTC (rev 92687)
@@ -1,5 +1,11 @@
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
+Not reviewed: fix inspector tests
+
+* inspector/styles/show-user-agent-styles.html:
+
+2011-08-09  Pavel Feldman  pfeld...@google.com
+
 Web Inspector: provide a way to hide user agent styles
 https://bugs.webkit.org/show_bug.cgi?id=37766
 


Modified: trunk/LayoutTests/inspector/styles/show-user-agent-styles.html (92686 => 92687)

--- trunk/LayoutTests/inspector/styles/show-user-agent-styles.html	2011-08-09 15:01:45 UTC (rev 92686)
+++ trunk/LayoutTests/inspector/styles/show-user-agent-styles.html	2011-08-09 15:22:16 UTC (rev 92687)
@@ -35,6 +35,7 @@
 function step1()
 {
 InspectorTest.dumpSelectedElementStyles(true, false, true);
+WebInspector.settings.showUserAgentStyles.set(true);
 next();
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92688] trunk

2011-08-09 Thread pfeldman

Title: [92688] trunk








Revision 92688
Author pfeld...@chromium.org
Date 2011-08-09 09:09:00 -0700 (Tue, 09 Aug 2011)


Log Message
Web Inspector: files from different domains are mixed in the file selector in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=65601

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/inspector.css:
(select.status-bar-item):

LayoutTests:

* inspector/debugger/scripts-panel-expected.txt:
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/LayoutTests/ChangeLog (92687 => 92688)

--- trunk/LayoutTests/ChangeLog	2011-08-09 15:22:16 UTC (rev 92687)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 16:09:00 UTC (rev 92688)
@@ -1,5 +1,15 @@
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
+Web Inspector: files from different domains are mixed in the file selector in Scripts panel
+https://bugs.webkit.org/show_bug.cgi?id=65601
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/scripts-panel-expected.txt:
+* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:
+
+2011-08-09  Pavel Feldman  pfeld...@google.com
+
 Not reviewed: fix inspector tests
 
 * inspector/styles/show-user-agent-styles.html:


Modified: trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt (92687 => 92688)

--- trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-08-09 15:22:16 UTC (rev 92687)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-08-09 16:09:00 UTC (rev 92688)
@@ -10,18 +10,19 @@
 Page reloaded.
 
 Running: testFilesSelect
-text: ?a=b, tooltip: ?a=b
-text: ?a=b, tooltip: http://example.com/?a=b
-text: …oong_url, tooltip: very_long_url
+text: ?a=b, tooltip: ?a=b
+text: …oong_url, tooltip: very_long_url
+text: example.com, tooltip: 
+text: ?a=b, tooltip: http://example.com/?a=b
 text: LayoutTests/inspector/debugger/foo/bar, tooltip: 
-text: script.js, tooltip: root/foo/bar/script.js
-text: script.js?a=1, tooltip: root/foo/bar/script.js?a=1
-text: script.js?a=2, tooltip: root/foo/bar/script.js?a=2
+text: script.js, tooltip: root/foo/bar/script.js
+text: script.js?a=1, tooltip: root/foo/bar/script.js?a=1
+text: script.js?a=2, tooltip: root/foo/bar/script.js?a=2
 text: LayoutTests/inspector/debugger/foo/baz, tooltip: 
-text: script.js, tooltip: root/foo/baz/script.js
+text: script.js, tooltip: root/foo/baz/script.js
 text: Content scripts, tooltip: 
-text: contentScript.js?a=1, tooltip: root/foo/bar/contentScript.js?a=1
-text: contentScript.js?a=2, tooltip: root/foo/bar/contentScript.js?a=2
-text: contentScript2.js?a=1, tooltip: root/foo/bar/contentScript2.js?a=1
+text: contentScript.js?a=1, tooltip: root/foo/bar/contentScript.js?a=1
+text: contentScript.js?a=2, tooltip: root/foo/bar/contentScript.js?a=2
+text: contentScript2.js?a=1, tooltip: root/foo/bar/contentScript2.js?a=1
 Debugger was disabled.
 


Modified: trunk/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt (92687 => 92688)

--- trunk/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt	2011-08-09 15:22:16 UTC (rev 92687)
+++ trunk/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt	2011-08-09 16:09:00 UTC (rev 92688)
@@ -1,18 +1,19 @@
 Tests scripts sorting in the scripts panel.
 
 Debugger was enabled.
-*Non*URL*path
-block.js?block=foo
-ga.js
-lenta.ban?pg=4883ifr=1
-lenta.ban?pg=5309ifr=1
-top100.jcn?80674
-/_js/production
-motor.js?1308927432
-/i
-xgemius.js
-/i/js
-jquery-1.5.1.min.js
-jquery.cookie.js
+*Non*URL*path
+foo.com
+block.js?block=foo
+ga.js
+lenta.ban?pg=4883ifr=1
+lenta.ban?pg=5309ifr=1
+top100.jcn?80674
+/_js/production
+motor.js?1308927432
+/i
+xgemius.js
+/i/js
+jquery-1.5.1.min.js
+jquery.cookie.js
 Debugger was disabled.
 


Modified:

[webkit-changes] [92689] trunk/Source/WebCore

2011-08-09 Thread steveblock

Title: [92689] trunk/Source/WebCore








Revision 92689
Author stevebl...@google.com
Date 2011-08-09 10:00:03 -0700 (Tue, 09 Aug 2011)


Log Message
Java Bridge leaks local references
https://bugs.webkit.org/show_bug.cgi?id=64320

Reviewed by Alexey Proskuryakov.

No new tests as this is just an optimization.

* bridge/jni/jsc/JavaFieldJSC.cpp:
(JavaField::JavaField):
* bridge/jni/jsc/JavaMethodJSC.cpp:
(JavaMethod::JavaMethod):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.cpp
trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (92688 => 92689)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 16:09:00 UTC (rev 92688)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 17:00:03 UTC (rev 92689)
@@ -1,3 +1,17 @@
+2011-08-09  Steve Block  stevebl...@google.com
+
+Java Bridge leaks local references
+https://bugs.webkit.org/show_bug.cgi?id=64320
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests as this is just an optimization.
+
+* bridge/jni/jsc/JavaFieldJSC.cpp:
+(JavaField::JavaField):
+* bridge/jni/jsc/JavaMethodJSC.cpp:
+(JavaMethod::JavaMethod):
+
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: files from different domains are mixed in the file selector in Scripts panel


Modified: trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.cpp (92688 => 92689)

--- trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.cpp	2011-08-09 16:09:00 UTC (rev 92688)
+++ trunk/Source/WebCore/bridge/jni/jsc/JavaFieldJSC.cpp	2011-08-09 17:00:03 UTC (rev 92689)
@@ -44,19 +44,23 @@
 {
 // Get field type name
 jstring fieldTypeName = 0;
-if (jobject fieldType = callJNIMethodjobject(aField, getType, ()Ljava/lang/Class;))
+jclass fieldType = static_castjclass(callJNIMethodjobject(aField, getType, ()Ljava/lang/Class;));
+if (fieldType)
 fieldTypeName = static_castjstring(callJNIMethodjobject(fieldType, getName, ()Ljava/lang/String;));
 if (!fieldTypeName)
 fieldTypeName = env-NewStringUTF(Unknown);
 m_typeClassName = JavaString(env, fieldTypeName);
 
 m_type = javaTypeFromClassName(m_typeClassName.utf8());
+env-DeleteLocalRef(fieldType);
+env-DeleteLocalRef(fieldTypeName);
 
 // Get field name
 jstring fieldName = static_castjstring(callJNIMethodjobject(aField, getName, ()Ljava/lang/String;));
 if (!fieldName)
 fieldName = env-NewStringUTF(Unknown);
 m_name = JavaString(env, fieldName);
+env-DeleteLocalRef(fieldName);
 
 m_field = JobjectWrapper::create(aField);
 }


Modified: trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp (92688 => 92689)

--- trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp	2011-08-09 16:09:00 UTC (rev 92688)
+++ trunk/Source/WebCore/bridge/jni/jsc/JavaMethodJSC.cpp	2011-08-09 17:00:03 UTC (rev 92689)
@@ -41,7 +41,7 @@
 // Get return type name
 jstring returnTypeName = 0;
 if (jobject returnType = callJNIMethodjobject(aMethod, getReturnType, ()Ljava/lang/Class;)) {
-returnTypeName = static_castjstring(callJNIMethodjobject(returnType, getName, ()Ljava/lang/String;));
+returnTypeName = static_castjstring(callJNIMethodjobject(returnType, getName, ()Ljava/lang/String;));
 if (!returnTypeName)
 returnTypeName = env-NewStringUTF(Unknown);
 env-DeleteLocalRef(returnType);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92690] trunk/LayoutTests

2011-08-09 Thread pfeldman

Title: [92690] trunk/LayoutTests








Revision 92690
Author pfeld...@chromium.org
Date 2011-08-09 10:08:28 -0700 (Tue, 09 Aug 2011)


Log Message
2011-08-09  Pavel Feldman  pfeld...@google.com

Not reviewed: rebaselining inspector test.

* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/inspector/debugger/scripts-panel.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92689 => 92690)

--- trunk/LayoutTests/ChangeLog	2011-08-09 17:00:03 UTC (rev 92689)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 17:08:28 UTC (rev 92690)
@@ -1,5 +1,12 @@
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
+Not reviewed: rebaselining inspector test.
+
+* inspector/debugger/scripts-panel-expected.txt:
+* inspector/debugger/scripts-panel.html:
+
+2011-08-09  Pavel Feldman  pfeld...@google.com
+
 Web Inspector: files from different domains are mixed in the file selector in Scripts panel
 https://bugs.webkit.org/show_bug.cgi?id=65601
 


Modified: trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt (92689 => 92690)

--- trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-08-09 17:00:03 UTC (rev 92689)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-08-09 17:08:28 UTC (rev 92690)
@@ -14,6 +14,7 @@
 text: …oong_url, tooltip: very_long_url
 text: example.com, tooltip: 
 text: ?a=b, tooltip: http://example.com/?a=b
+text: localhost, tooltip: 
 text: LayoutTests/inspector/debugger/foo/bar, tooltip: 
 text: script.js, tooltip: root/foo/bar/script.js
 text: script.js?a=1, tooltip: root/foo/bar/script.js?a=1


Modified: trunk/LayoutTests/inspector/debugger/scripts-panel.html (92689 => 92690)

--- trunk/LayoutTests/inspector/debugger/scripts-panel.html	2011-08-09 17:00:03 UTC (rev 92689)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel.html	2011-08-09 17:08:28 UTC (rev 92690)
@@ -128,7 +128,7 @@
 function testFilesSelect(next)
 {
 var panel = new WebInspector.ScriptsPanel();
-var rootURL = WebInspector.mainResource.url.substring(0, WebInspector.mainResource.url.lastIndexOf(/) + 1);
+var rootURL = http://localhost:8080/LayoutTests/inspector/debugger/;
 var nextId = 0;
 function addOption(url, isContentScript)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [92691] trunk/Source/WebCore

2011-08-09 Thread japhet

Title: [92691] trunk/Source/WebCore








Revision 92691
Author jap...@chromium.org
Date 2011-08-09 11:05:30 -0700 (Tue, 09 Aug 2011)


Log Message
2011-08-09  Nate Chapin  jap...@chromium.org

Remove receivedCancellation() from SubresourceLoaderClient.

http://bugs.webkit.org/show_bug.cgi?id=65330

Reviewed by Alexey Proskuryakov.

No new tests, no change in functionality intended.

* loader/DocumentThreadableLoader.cpp:
* loader/DocumentThreadableLoader.h:
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.cpp:
* loader/WorkerThreadableLoader.h:
* notifications/Notification.cpp:
* notifications/Notification.h:  Remove receivedCancellation() since it's
   identical to didFail(), which is always called immediately after.
* workers/WorkerScriptLoader.cpp:
* workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's
   identical to didFail(), which is always called immediately after.
* xml/XMLHttpRequest.cpp:
* xml/XMLHttpRequest.h: Remove receivedCancellation().  All it does is
   set m_response, which is cleared in didFail() before it can be used.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/DocumentThreadableLoader.h
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/SubresourceLoaderClient.h
trunk/Source/WebCore/loader/ThreadableLoaderClient.h
trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp
trunk/Source/WebCore/loader/WorkerThreadableLoader.h
trunk/Source/WebCore/notifications/Notification.cpp
trunk/Source/WebCore/notifications/Notification.h
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.h
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (92690 => 92691)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 17:08:28 UTC (rev 92690)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 18:05:30 UTC (rev 92691)
@@ -1,3 +1,31 @@
+2011-08-09  Nate Chapin  jap...@chromium.org
+
+Remove receivedCancellation() from SubresourceLoaderClient.
+
+http://bugs.webkit.org/show_bug.cgi?id=65330
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests, no change in functionality intended.
+
+* loader/DocumentThreadableLoader.cpp:
+* loader/DocumentThreadableLoader.h:
+* loader/SubresourceLoader.cpp:
+* loader/SubresourceLoader.h:
+* loader/SubresourceLoaderClient.h:
+* loader/ThreadableLoaderClient.h:
+* loader/WorkerThreadableLoader.cpp:
+* loader/WorkerThreadableLoader.h:
+* notifications/Notification.cpp:
+* notifications/Notification.h:  Remove receivedCancellation() since it's
+   identical to didFail(), which is always called immediately after.
+* workers/WorkerScriptLoader.cpp:
+* workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's
+   identical to didFail(), which is always called immediately after.
+* xml/XMLHttpRequest.cpp:
+* xml/XMLHttpRequest.h: Remove receivedCancellation().  All it does is
+   set m_response, which is cleared in didFail() before it can be used.
+
 2011-08-09  Steve Block  stevebl...@google.com
 
 Java Bridge leaks local references


Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp (92690 => 92691)

--- trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2011-08-09 17:08:28 UTC (rev 92690)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp	2011-08-09 18:05:30 UTC (rev 92691)
@@ -316,13 +316,6 @@
 }
 }
 
-void DocumentThreadableLoader::receivedCancellation(SubresourceLoader* loader, const AuthenticationChallenge challenge)
-{
-ASSERT(m_client);
-ASSERT_UNUSED(loader, loader == m_loader);
-m_client-didReceiveAuthenticationCancellation(loader-identifier(), challenge.failureResponse());
-}
-
 void DocumentThreadableLoader::preflightSuccess()
 {
 OwnPtrResourceRequest actualRequest;


Modified: trunk/Source/WebCore/loader/DocumentThreadableLoader.h (92690 => 92691)

--- trunk/Source/WebCore/loader/DocumentThreadableLoader.h	2011-08-09 17:08:28 UTC (rev 92690)
+++ trunk/Source/WebCore/loader/DocumentThreadableLoader.h	2011-08-09 18:05:30 UTC (rev 92691)
@@ -84,7 +84,6 @@
 
 virtual bool getShouldUseCredentialStorage(SubresourceLoader*, bool shouldUseCredentialStorage);
 virtual void didReceiveAuthenticationChallenge(SubresourceLoader*, const AuthenticationChallenge);
-virtual void receivedCancellation(SubresourceLoader*, const

[webkit-changes] [92692] trunk

2011-08-09 Thread inferno

Title: [92692] trunk








Revision 92692
Author infe...@chromium.org
Date 2011-08-09 11:18:36 -0700 (Tue, 09 Aug 2011)


Log Message
Source/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information 
about full layout which is needed when dirtying lineboxes.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
* rendering/RenderInline.h:

LayoutTests: Tests that we do not crash when trying to dirty line boxes on
a RenderInline needing full relayout.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

* fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
* fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderInline.cpp
trunk/Source/WebCore/rendering/RenderInline.h


Added Paths

trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt
trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (92691 => 92692)

--- trunk/LayoutTests/ChangeLog	2011-08-09 18:05:30 UTC (rev 92691)
+++ trunk/LayoutTests/ChangeLog	2011-08-09 18:18:36 UTC (rev 92692)
@@ -1,3 +1,14 @@
+2011-08-09  Abhishek Arya  infe...@chromium.org
+
+Tests that we do not crash when trying to dirty line boxes on
+a RenderInline needing full relayout.
+https://bugs.webkit.org/show_bug.cgi?id=65924
+
+Reviewed by Dave Hyatt.
+
+* fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
+* fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.
+
 2011-08-09  Pavel Feldman  pfeld...@google.com
 
 Not reviewed: rebaselining inspector test.


Added: trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt (0 => 92692)

--- trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt	2011-08-09 18:18:36 UTC (rev 92692)
@@ -0,0 +1,2 @@
+PASS
+


Added: trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash.html (0 => 92692)

--- trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/inline/update-always-create-line-boxes-full-layout-crash.html	2011-08-09 18:18:36 UTC (rev 92692)
@@ -0,0 +1,27 @@
+!DOCTYPE HTML
+html
+style
+.table:nth-last-child(even) { line-height: 100%; }
+/style
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function runTest()
+{
+var test = document.getElementById('test');
+test.parentNode.removeChild(test);
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+setTimeout(runTest(), 0); 
+/script
+table class=table
+tdrtPASS/rt/junk/td
+tablespan id=test/table
+/table
+/html


Modified: trunk/Source/WebCore/ChangeLog (92691 => 92692)

--- trunk/Source/WebCore/ChangeLog	2011-08-09 18:05:30 UTC (rev 92691)
+++ trunk/Source/WebCore/ChangeLog	2011-08-09 18:18:36 UTC (rev 92692)
@@ -1,3 +1,19 @@
+2011-08-09  Abhishek Arya  infe...@chromium.org
+
+Regression(83075): Fix updateAlwaysCreateLineBoxes on information 
+about full layout which is needed when dirtying lineboxes.
+https://bugs.webkit.org/show_bug.cgi?id=65924
+
+Reviewed by Dave Hyatt.
+
+Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::RenderBlock::layoutInlineChildren):
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
+* rendering/RenderInline.h:
+
 2011-08-09  Nate Chapin  jap...@chromium.org
 
 Remove receivedCancellation() from SubresourceLoaderClient.


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (92691 => 92692)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2011-08-09 18:05:30 UTC (rev 92691)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2011-08-09 18:18:36 UTC (rev 92692)
@@ -1256,7 +1256,7 @@
 }
 } else if (o-isText() || (o-isRenderInline()  !walker.atEndOfInline())) {
 if (!o-isText())
-toRenderInline(o)-updateAlwaysCreateLineBoxes();
+

66 matches

Mail list logo