[webkit-changes] [94388] trunk/Tools
Title: [94388] trunk/Tools
Revision 94388
Author ph...@webkit.org
Date 2011-09-02 00:32:26 -0700 (Fri, 02 Sep 2011)
Log Message
[GTK] run-gtk-tests leaves a zombie Xvfb process
https://bugs.webkit.org/show_bug.cgi?id=67389
Reviewed by Martin Robinson.
* Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
child process instead of doing shell redirection.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Diff
Modified: trunk/Tools/ChangeLog (94387 => 94388)
--- trunk/Tools/ChangeLog 2011-09-02 06:33:52 UTC (rev 94387)
+++ trunk/Tools/ChangeLog 2011-09-02 07:32:26 UTC (rev 94388)
@@ -1,3 +1,13 @@
+2011-09-02 Philippe Normand pnorm...@igalia.com
+
+[GTK] run-gtk-tests leaves a zombie Xvfb process
+https://bugs.webkit.org/show_bug.cgi?id=67389
+
+Reviewed by Martin Robinson.
+
+* Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
+child process instead of doing shell redirection.
+
2011-09-01 Mark Rowe mr...@apple.com
Fix the build by adding some more missing return types.
Modified: trunk/Tools/Scripts/run-gtk-tests (94387 => 94388)
--- trunk/Tools/Scripts/run-gtk-tests 2011-09-02 06:33:52 UTC (rev 94387)
+++ trunk/Tools/Scripts/run-gtk-tests 2011-09-02 07:32:26 UTC (rev 94388)
@@ -35,7 +35,9 @@
my $pid = fork();
if ($pid == 0) {
-exec(Xvfb :31 -screen 0 800x600x24 -nolisten tcp /dev/null 21);
+close(STDOUT) or die Can't close STDOUT: $!\n;
+close(STDERR) or die Can't close STDERR: $!\n;
+exec(Xvfb :31 -screen 0 800x600x24 -nolisten tcp);
exit 1;
} elsif ($pid == -1) {
print Failed to fork Xvfb.;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94389] trunk/Source/WebCore
Title: [94389] trunk/Source/WebCore
Revision 94389
Author ph...@webkit.org
Date 2011-09-02 00:35:13 -0700 (Fri, 02 Sep 2011)
Log Message
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893
Reviewed by Kenneth Russell.
Build MediaAudioSourceNode only if VIDEO is enabled
* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioContext.cpp
trunk/Source/WebCore/webaudio/AudioContext.h
trunk/Source/WebCore/webaudio/AudioContext.idl
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (94388 => 94389)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 07:32:26 UTC (rev 94388)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 07:35:13 UTC (rev 94389)
@@ -1,3 +1,19 @@
+2011-09-02 Philippe Normand pnorm...@igalia.com
+
+[WebAudio] Undeclared dependency to VIDEO
+https://bugs.webkit.org/show_bug.cgi?id=66893
+
+Reviewed by Kenneth Russell.
+
+Build MediaAudioSourceNode only if VIDEO is enabled
+
+* webaudio/AudioContext.cpp:
+* webaudio/AudioContext.h:
+* webaudio/AudioContext.idl:
+* webaudio/MediaElementAudioSourceNode.cpp:
+* webaudio/MediaElementAudioSourceNode.h:
+* webaudio/MediaElementAudioSourceNode.idl:
+
2011-09-01 Takashi Toyoshima toyos...@chromium.org
[WebSocket] Implement WebSocket::close() code and reason handling.
Modified: trunk/Source/WebCore/webaudio/AudioContext.cpp (94388 => 94389)
--- trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 07:32:26 UTC (rev 94388)
+++ trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 07:35:13 UTC (rev 94389)
@@ -49,11 +49,9 @@
#include FFTFrame.h
#include HRTFDatabaseLoader.h
#include HRTFPanner.h
-#include HTMLMediaElement.h
#include HighPass2FilterNode.h
#include _javascript_AudioNode.h
#include LowPass2FilterNode.h
-#include MediaElementAudioSourceNode.h
#include OfflineAudioCompletionEvent.h
#include OfflineAudioDestinationNode.h
#include PlatformString.h
@@ -61,6 +59,11 @@
#include WaveShaperNode.h
#include ScriptCallStack.h
+#if ENABLE(VIDEO)
+#include HTMLMediaElement.h
+#include MediaElementAudioSourceNode.h
+#endif
+
#if DEBUG_AUDIONODE_REFERENCES
#include stdio.h
#endif
@@ -312,6 +315,7 @@
return node;
}
+#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode AudioContext::createMediaElementSource(HTMLMediaElement* mediaElement, ExceptionCode ec)
{
ASSERT(mediaElement);
@@ -336,6 +340,7 @@
refNode(node.get()); // context keeps reference until node is disconnected
return node;
}
+#endif
PassRefPtr_javascript_AudioNode AudioContext::createJavaScriptNode(size_t bufferSize)
{
Modified: trunk/Source/WebCore/webaudio/AudioContext.h (94388 => 94389)
--- trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 07:32:26 UTC (rev 94388)
+++ trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 07:35:13 UTC (rev 94389)
@@ -110,7 +110,9 @@
// The AudioNode create methods are called on the main thread (from _javascript_).
PassRefPtrAudioBufferSourceNode createBufferSource();
+#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode createMediaElementSource(HTMLMediaElement*, ExceptionCode);
+#endif
PassRefPtrAudioGainNode createGainNode();
PassRefPtrBiquadFilterNode createBiquadFilter();
PassRefPtrWaveShaperNode createWaveShaper();
Modified: trunk/Source/WebCore/webaudio/AudioContext.idl (94388 => 94389)
--- trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 07:32:26 UTC (rev 94388)
+++ trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 07:35:13 UTC (rev 94389)
@@ -59,9 +59,10 @@
// Sources
AudioBufferSourceNode createBufferSource();
+#if defined(ENABLE_VIDEO) ENABLE_VIDEO
MediaElementAudioSourceNode createMediaElementSource(in HTMLMediaElement mediaElement)
raises(DOMException);
-
+#endif
// Processing nodes
AudioGainNode createGainNode();
DelayNode createDelayNode();
Modified: trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp (94388 => 94389)
--- trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 07:32:26 UTC (rev 94388)
+++ trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 07:35:13 UTC (rev 94389)
@@ -24,7 +24,7 @@
#include config.h
-#if ENABLE(WEB_AUDIO)
+#if ENABLE(WEB_AUDIO) ENABLE(VIDEO)
#include MediaElementAudioSourceNode.h
Modified: trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h (94388 => 94389)
---
[webkit-changes] [94391] trunk/Source/WebCore
Title: [94391] trunk/Source/WebCore
Revision 94391
Author commit-qu...@webkit.org
Date 2011-09-02 00:58:05 -0700 (Fri, 02 Sep 2011)
Log Message
Unreviewed, rolling out r94389.
http://trac.webkit.org/changeset/94389
https://bugs.webkit.org/show_bug.cgi?id=67468
breaks mac build (Requested by philn-tp on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-02
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaElementSource):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioContext.cpp
trunk/Source/WebCore/webaudio/AudioContext.h
trunk/Source/WebCore/webaudio/AudioContext.idl
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (94390 => 94391)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 07:41:41 UTC (rev 94390)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 07:58:05 UTC (rev 94391)
@@ -1,3 +1,19 @@
+2011-09-02 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r94389.
+http://trac.webkit.org/changeset/94389
+https://bugs.webkit.org/show_bug.cgi?id=67468
+
+breaks mac build (Requested by philn-tp on #webkit).
+
+* webaudio/AudioContext.cpp:
+(WebCore::AudioContext::createMediaElementSource):
+* webaudio/AudioContext.h:
+* webaudio/AudioContext.idl:
+* webaudio/MediaElementAudioSourceNode.cpp:
+* webaudio/MediaElementAudioSourceNode.h:
+* webaudio/MediaElementAudioSourceNode.idl:
+
2011-09-02 Kentaro Hara hara...@google.com
Generate an EventSource constructor of V8 using the IDL 'Constructor' extended attribute
Modified: trunk/Source/WebCore/webaudio/AudioContext.cpp (94390 => 94391)
--- trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 07:41:41 UTC (rev 94390)
+++ trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 07:58:05 UTC (rev 94391)
@@ -49,9 +49,11 @@
#include FFTFrame.h
#include HRTFDatabaseLoader.h
#include HRTFPanner.h
+#include HTMLMediaElement.h
#include HighPass2FilterNode.h
#include _javascript_AudioNode.h
#include LowPass2FilterNode.h
+#include MediaElementAudioSourceNode.h
#include OfflineAudioCompletionEvent.h
#include OfflineAudioDestinationNode.h
#include PlatformString.h
@@ -59,11 +61,6 @@
#include WaveShaperNode.h
#include ScriptCallStack.h
-#if ENABLE(VIDEO)
-#include HTMLMediaElement.h
-#include MediaElementAudioSourceNode.h
-#endif
-
#if DEBUG_AUDIONODE_REFERENCES
#include stdio.h
#endif
@@ -315,7 +312,6 @@
return node;
}
-#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode AudioContext::createMediaElementSource(HTMLMediaElement* mediaElement, ExceptionCode ec)
{
ASSERT(mediaElement);
@@ -340,7 +336,6 @@
refNode(node.get()); // context keeps reference until node is disconnected
return node;
}
-#endif
PassRefPtr_javascript_AudioNode AudioContext::createJavaScriptNode(size_t bufferSize)
{
Modified: trunk/Source/WebCore/webaudio/AudioContext.h (94390 => 94391)
--- trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 07:41:41 UTC (rev 94390)
+++ trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 07:58:05 UTC (rev 94391)
@@ -110,9 +110,7 @@
// The AudioNode create methods are called on the main thread (from _javascript_).
PassRefPtrAudioBufferSourceNode createBufferSource();
-#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode createMediaElementSource(HTMLMediaElement*, ExceptionCode);
-#endif
PassRefPtrAudioGainNode createGainNode();
PassRefPtrBiquadFilterNode createBiquadFilter();
PassRefPtrWaveShaperNode createWaveShaper();
Modified: trunk/Source/WebCore/webaudio/AudioContext.idl (94390 => 94391)
--- trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 07:41:41 UTC (rev 94390)
+++ trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 07:58:05 UTC (rev 94391)
@@ -59,10 +59,9 @@
// Sources
AudioBufferSourceNode createBufferSource();
-#if defined(ENABLE_VIDEO) ENABLE_VIDEO
MediaElementAudioSourceNode createMediaElementSource(in HTMLMediaElement mediaElement)
raises(DOMException);
-#endif
+
// Processing nodes
AudioGainNode createGainNode();
DelayNode createDelayNode();
Modified: trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp (94390 => 94391)
--- trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 07:41:41 UTC (rev 94390)
+++ trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 07:58:05 UTC (rev 94391)
@@ -24,7 +24,7 @@
#include config.h
-#if ENABLE(WEB_AUDIO) ENABLE(VIDEO)
+#if
[webkit-changes] [94392] trunk/LayoutTests
Title: [94392] trunk/LayoutTests
Revision 94392
Author r...@webkit.org
Date 2011-09-02 01:25:12 -0700 (Fri, 02 Sep 2011)
Log Message
[Qt] Add Qt expecteds for new tests.
Unreviewed gardening.
* platform/qt/fast/borders/border-image-slices-expected.png: Added.
* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt
trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt
trunk/LayoutTests/platform/qt/svg/custom/pattern-rotate-gaps-expected.png
trunk/LayoutTests/platform/qt/svg/custom/pattern-rotate-gaps-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94391 => 94392)
--- trunk/LayoutTests/ChangeLog 2011-09-02 07:58:05 UTC (rev 94391)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 08:25:12 UTC (rev 94392)
@@ -1,3 +1,15 @@
+2011-09-02 Renata Hodovan r...@webkit.org
+
+[Qt] Add Qt expecteds for new tests.
+
+Unreviewed gardening.
+
+* platform/qt/fast/borders/border-image-slices-expected.png: Added.
+* platform/qt/fast/borders/border-image-slices-expected.txt: Added.
+* platform/qt/fast/text/fallback-traits-fixup-expected.txt: Added.
+* platform/qt/svg/custom/pattern-rotate-gaps-expected.png: Added.
+* platform/qt/svg/custom/pattern-rotate-gaps-expected.txt: Added.
+
2011-09-01 Takashi Toyoshima toyos...@chromium.org
[WebSocket] Implement WebSocket::close() code and reason handling.
Added: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt (0 => 94392)
--- trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/borders/border-image-slices-expected.txt 2011-09-02 08:25:12 UTC (rev 94392)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (10,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (146,130) size 4x22
+text run at (146,130) width 4:
+ RenderBlock {DIV} at (160,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (296,130) size 4x22
+text run at (296,130) width 4:
+ RenderBR {BR} at (0,0) size 0x0
+ RenderBlock {DIV} at (10,162) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (146,282) size 4x22
+text run at (146,282) width 4:
+ RenderBlock {DIV} at (160,162) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt (0 => 94392)
--- trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/fast/text/fallback-traits-fixup-expected.txt 2011-09-02 08:25:12 UTC (rev 94392)
@@ -0,0 +1,31 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x576
+ RenderBlock {P} at (0,0) size 784x22
+RenderText {#text} at (0,0) size 57x22
+ text run at (0,0) width 57: Test for
+RenderInline {I} at (0,0) size 519x22
+ RenderInline {A} at (0,0) size 154x22 [color=#EE]
+RenderText {#text} at (57,0) size 154x22
+ text run at (57,0) width 154: rdar://problem/9528843
+ RenderText {#text} at (211,0) size 365x22
+text run at (211,0) width 4:
+text run at (215,0) width 361: STIX glyphs not rendered on this stackoverflow answer
+RenderText {#text} at (576,0) size 4x22
+ text run at (576,0) width 4: .
+ RenderBlock {P} at (0,38) size 784x42
+RenderText {#text} at (0,15) size 102x22
+ text run at (0,15) width 102: A black circle:
+RenderInline {SPAN} at (0,0) size 8x42
+ RenderText {#text} at (102,0) size 8x42
+text run at (102,0) width 8: \x{26AB}
+
[webkit-changes] [94393] trunk/Source/WebCore
Title: [94393] trunk/Source/WebCore Revision 94393 Author o...@webkit.org Date 2011-09-02 01:26:19 -0700 (Fri, 02 Sep 2011) Log Message [Qt][WK2] Unreviewed speculative buildfix. * WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.pro Diff Modified: trunk/Source/WebCore/ChangeLog (94392 => 94393) --- trunk/Source/WebCore/ChangeLog 2011-09-02 08:25:12 UTC (rev 94392) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 08:26:19 UTC (rev 94393) @@ -1,3 +1,9 @@ +2011-09-02 Csaba Osztrogonác o...@webkit.org + +[Qt][WK2] Unreviewed speculative buildfix. + +* WebCore.pro: Add platform/graphics/GlyphPageTreeNode.cpp to SOURCES. + 2011-09-02 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94389. Modified: trunk/Source/WebCore/WebCore.pro (94392 => 94393) --- trunk/Source/WebCore/WebCore.pro 2011-09-02 08:25:12 UTC (rev 94392) +++ trunk/Source/WebCore/WebCore.pro 2011-09-02 08:26:19 UTC (rev 94393) @@ -983,6 +983,7 @@ platform/graphics/FontFallbackList.cpp \ platform/graphics/FontFamily.cpp \ platform/graphics/FontFeatureSettings.cpp \ +platform/graphics/GlyphPageTreeNode.cpp \ platform/graphics/BitmapImage.cpp \ platform/graphics/Color.cpp \ platform/graphics/FloatPoint3D.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94394] trunk/LayoutTests
Title: [94394] trunk/LayoutTests Revision 94394 Author r...@webkit.org Date 2011-09-02 01:49:24 -0700 (Fri, 02 Sep 2011) Log Message [Qt] Update Qt specific expected files after r94304. Unreviewed gardening. * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.png: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94393 => 94394) --- trunk/LayoutTests/ChangeLog 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/ChangeLog 2011-09-02 08:49:24 UTC (rev 94394) @@ -1,5 +1,16 @@ 2011-09-02 Renata Hodovan r...@webkit.org +[Qt] Update Qt specific expected files after r94304. + +Unreviewed gardening. + +* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: +* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.png: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: + +2011-09-02 Renata Hodovan r...@webkit.org + [Qt] Add Qt expecteds for new tests. Unreviewed gardening. Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (94393 => 94394) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 08:49:24 UTC (rev 94394) @@ -341,6 +341,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultStatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultstatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'description') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'descriptionQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'devicePixelRatio') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'document') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'encodeURI') is 'object' @@ -477,6 +478,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNonZero') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNull') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrue') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrueQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object' Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (94393 => 94394) --- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-02 08:26:19 UTC (rev 94393) +++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt 2011-09-02 08:49:24 UTC (rev 94394) @@ -40,12 +40,12 @@ PASS CSSStyleSheet from inner.document.forms.testForm.0.ownerDocument.styleSheets.0 PASS CSSStyleSheetConstructor from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.constructor PASS CSSStyleSheetPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.__proto__ -PASS CSSValue from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-line-box-contain) -PASS CSSValueConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-line-box-contain).constructor +PASS CSSValue from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(border-image-slice) +PASS CSSValueConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(border-image-slice).constructor PASS CSSValueList from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-transition-timing-function) PASS CSSValueListConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-position).constructor PASS CSSValueListPrototype from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(-webkit-transition-timing-function).__proto__ -PASS CSSValuePrototype
[webkit-changes] [94396] trunk/Tools
Title: [94396] trunk/Tools Revision 94396 Author abe...@webkit.org Date 2011-09-02 02:53:58 -0700 (Fri, 02 Sep 2011) Log Message Remove my old e-mail address and add my new one. Rubber-stamped by Tor Arne Vestbø. * Scripts/webkitpy/common/config/committers.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/ChangeLog (94395 => 94396) --- trunk/Tools/ChangeLog 2011-09-02 09:09:28 UTC (rev 94395) +++ trunk/Tools/ChangeLog 2011-09-02 09:53:58 UTC (rev 94396) @@ -1,3 +1,11 @@ +2011-09-02 Andras Becsi andras.be...@nokia.com + +Remove my old e-mail address and add my new one. + +Rubber-stamped by Tor Arne Vestbø. + +* Scripts/webkitpy/common/config/committers.py: + 2011-09-02 Philippe Normand pnorm...@igalia.com [GTK] run-gtk-tests leaves a zombie Xvfb process Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (94395 => 94396) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-09-02 09:09:28 UTC (rev 94395) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-09-02 09:53:58 UTC (rev 94396) @@ -123,7 +123,7 @@ Committer(Andrew Wellington, [and...@webkit.org, pro...@wiretapped.net], proton), Committer(Andrew Scherkus, scher...@chromium.org, scherkus), Committer(Andrey Kosyakov, ca...@chromium.org, caseq), -Committer(Andras Becsi, [abe...@webkit.org, abe...@inf.u-szeged.hu], bbandix), +Committer(Andras Becsi, [abe...@webkit.org, andras.be...@nokia.com], bbandix), Committer(Andy Estes, aes...@apple.com, estes), Committer(Anthony Ricaud, r...@webkit.org, rik), Committer(Anton D'Auria, adau...@apple.com, antonlefou), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94397] trunk/Source/WebCore
Title: [94397] trunk/Source/WebCore
Revision 94397
Author ph...@webkit.org
Date 2011-09-02 02:58:12 -0700 (Fri, 02 Sep 2011)
Log Message
[WebAudio] Undeclared dependency to VIDEO
https://bugs.webkit.org/show_bug.cgi?id=66893
Reviewed by Kenneth Russell.
Build MediaAudioSourceNode only if VIDEO is enabled
* webaudio/AudioContext.cpp:
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
* webaudio/MediaElementAudioSourceNode.cpp:
* webaudio/MediaElementAudioSourceNode.h:
* webaudio/MediaElementAudioSourceNode.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioContext.cpp
trunk/Source/WebCore/webaudio/AudioContext.h
trunk/Source/WebCore/webaudio/AudioContext.idl
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h
trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (94396 => 94397)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 09:53:58 UTC (rev 94396)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 09:58:12 UTC (rev 94397)
@@ -1,3 +1,19 @@
+2011-09-02 Philippe Normand pnorm...@igalia.com
+
+[WebAudio] Undeclared dependency to VIDEO
+https://bugs.webkit.org/show_bug.cgi?id=66893
+
+Reviewed by Kenneth Russell.
+
+Build MediaAudioSourceNode only if VIDEO is enabled
+
+* webaudio/AudioContext.cpp:
+* webaudio/AudioContext.h:
+* webaudio/AudioContext.idl:
+* webaudio/MediaElementAudioSourceNode.cpp:
+* webaudio/MediaElementAudioSourceNode.h:
+* webaudio/MediaElementAudioSourceNode.idl:
+
2011-09-02 Csaba Osztrogonác o...@webkit.org
[Qt][WK2] Unreviewed speculative buildfix.
Modified: trunk/Source/WebCore/webaudio/AudioContext.cpp (94396 => 94397)
--- trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 09:53:58 UTC (rev 94396)
+++ trunk/Source/WebCore/webaudio/AudioContext.cpp 2011-09-02 09:58:12 UTC (rev 94397)
@@ -49,11 +49,9 @@
#include FFTFrame.h
#include HRTFDatabaseLoader.h
#include HRTFPanner.h
-#include HTMLMediaElement.h
#include HighPass2FilterNode.h
#include _javascript_AudioNode.h
#include LowPass2FilterNode.h
-#include MediaElementAudioSourceNode.h
#include OfflineAudioCompletionEvent.h
#include OfflineAudioDestinationNode.h
#include PlatformString.h
@@ -61,6 +59,11 @@
#include WaveShaperNode.h
#include ScriptCallStack.h
+#if ENABLE(VIDEO)
+#include HTMLMediaElement.h
+#include MediaElementAudioSourceNode.h
+#endif
+
#if DEBUG_AUDIONODE_REFERENCES
#include stdio.h
#endif
@@ -312,6 +315,7 @@
return node;
}
+#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode AudioContext::createMediaElementSource(HTMLMediaElement* mediaElement, ExceptionCode ec)
{
ASSERT(mediaElement);
@@ -336,6 +340,7 @@
refNode(node.get()); // context keeps reference until node is disconnected
return node;
}
+#endif
PassRefPtr_javascript_AudioNode AudioContext::createJavaScriptNode(size_t bufferSize)
{
Modified: trunk/Source/WebCore/webaudio/AudioContext.h (94396 => 94397)
--- trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 09:53:58 UTC (rev 94396)
+++ trunk/Source/WebCore/webaudio/AudioContext.h 2011-09-02 09:58:12 UTC (rev 94397)
@@ -110,7 +110,9 @@
// The AudioNode create methods are called on the main thread (from _javascript_).
PassRefPtrAudioBufferSourceNode createBufferSource();
+#if ENABLE(VIDEO)
PassRefPtrMediaElementAudioSourceNode createMediaElementSource(HTMLMediaElement*, ExceptionCode);
+#endif
PassRefPtrAudioGainNode createGainNode();
PassRefPtrBiquadFilterNode createBiquadFilter();
PassRefPtrWaveShaperNode createWaveShaper();
Modified: trunk/Source/WebCore/webaudio/AudioContext.idl (94396 => 94397)
--- trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 09:53:58 UTC (rev 94396)
+++ trunk/Source/WebCore/webaudio/AudioContext.idl 2011-09-02 09:58:12 UTC (rev 94397)
@@ -59,9 +59,10 @@
// Sources
AudioBufferSourceNode createBufferSource();
+#if defined(ENABLE_VIDEO) ENABLE_VIDEO
MediaElementAudioSourceNode createMediaElementSource(in HTMLMediaElement mediaElement)
raises(DOMException);
-
+#endif
// Processing nodes
AudioGainNode createGainNode();
DelayNode createDelayNode();
Modified: trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp (94396 => 94397)
--- trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 09:53:58 UTC (rev 94396)
+++ trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.cpp 2011-09-02 09:58:12 UTC (rev 94397)
@@ -24,7 +24,7 @@
#include config.h
-#if ENABLE(WEB_AUDIO)
+#if ENABLE(WEB_AUDIO) ENABLE(VIDEO)
#include MediaElementAudioSourceNode.h
Modified: trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h (94396 => 94397)
--- trunk/Source/WebCore/webaudio/MediaElementAudioSourceNode.h 2011-09-02
[webkit-changes] [94398] trunk/Source/WebKit2
Title: [94398] trunk/Source/WebKit2
Revision 94398
Author mr...@apple.com
Date 2011-09-02 03:21:56 -0700 (Fri, 02 Sep 2011)
Log Message
http://webkit.org/b/67467 WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
leak the results of the APIs they wrap.
Reviewed by Dan Bernstein.
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
RetainPtr to ensure it gets released at the appropriate time.
(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94397 => 94398)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 09:58:12 UTC (rev 94397)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 10:21:56 UTC (rev 94398)
@@ -1,3 +1,15 @@
+2011-09-02 Mark Rowe mr...@apple.com
+
+http://webkit.org/b/67467 WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd
+leak the results of the APIs they wrap.
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/mac/WebProcessProxyMac.mm:
+(WebKit::WebProcessProxy::secItemCopyMatching): Adopt the result of SecItemCopyMatching in to a
+RetainPtr to ensure it gets released at the appropriate time.
+(WebKit::WebProcessProxy::secItemAdd): Ditto for SecItemAdd.
+
2011-09-01 Ada Chan adac...@apple.com
Cut down the ifdefs in WebKit::getWebCoreMemoryCacheStatistics() now that
Modified: trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm (94397 => 94398)
--- trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm 2011-09-02 09:58:12 UTC (rev 94397)
+++ trunk/Source/WebKit2/UIProcess/mac/WebProcessProxyMac.mm 2011-09-02 10:21:56 UTC (rev 94398)
@@ -37,23 +37,21 @@
void WebProcessProxy::secItemCopyMatching(const SecItemRequestData queryData, SecItemResponseData result)
{
CFDictionaryRef query = queryData.query();
-CFTypeRef resultObject;
-OSStatus resultCode;
+CFTypeRef resultObjectRef;
+OSStatus resultCode = SecItemCopyMatching(query, resultObjectRef);
-resultCode = SecItemCopyMatching(query, resultObject);
-
-result = SecItemResponseData(resultCode, resultObject);
+RetainPtrCFTypeRef resultObject(AdoptCF, resultObjectRef);
+result = SecItemResponseData(resultCode, resultObject.get());
}
void WebProcessProxy::secItemAdd(const SecItemRequestData queryData, SecItemResponseData result)
{
CFDictionaryRef query = queryData.query();
-CFTypeRef resultObject;
-OSStatus resultCode;
+CFTypeRef resultObjectRef;
+OSStatus resultCode = SecItemAdd(query, resultObjectRef);
-resultCode = SecItemAdd(query, resultObject);
-
-result = SecItemResponseData(resultCode, resultObject);
+RetainPtrCFTypeRef resultObject(AdoptCF, resultObjectRef);
+result = SecItemResponseData(resultCode, resultObject.get());
}
void WebProcessProxy::secItemUpdate(const SecItemRequestData queryData, SecItemResponseData result)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94400] trunk/Source/WebCore
Title: [94400] trunk/Source/WebCore Revision 94400 Author ba...@chromium.org Date 2011-09-02 03:38:57 -0700 (Fri, 02 Sep 2011) Log Message [Chromium] Webfonts display bold in Windows https://bugs.webkit.org/show_bug.cgi?id=67387 Uses font's default weight for webfonts by setting FW_DONTCARE. Reviewed by Kent Tamura. No new tests. We don't have fonts to test this change. * platform/graphics/skia/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94399 => 94400) --- trunk/Source/WebCore/ChangeLog 2011-09-02 10:36:43 UTC (rev 94399) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 10:38:57 UTC (rev 94400) @@ -1,3 +1,17 @@ +2011-09-02 Kenichi Ishibashi ba...@chromium.org + +[Chromium] Webfonts display bold in Windows +https://bugs.webkit.org/show_bug.cgi?id=67387 + +Uses font's default weight for webfonts by setting FW_DONTCARE. + +Reviewed by Kent Tamura. + +No new tests. We don't have fonts to test this change. + +* platform/graphics/skia/FontCustomPlatformData.cpp: +(WebCore::FontCustomPlatformData::fontPlatformData): Sets FW_DONTCARE to use default font weight. + 2011-09-02 Yuta Kitamura yu...@chromium.org WebSocket: Send Blob as WebSocket binary message Modified: trunk/Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp (94399 => 94400) --- trunk/Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp 2011-09-02 10:36:43 UTC (rev 94399) +++ trunk/Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp 2011-09-02 10:38:57 UTC (rev 94400) @@ -97,7 +97,7 @@ DEFAULT_QUALITY; // Honor user's desktop settings. logFont.lfPitchAndFamily = DEFAULT_PITCH | FF_DONTCARE; logFont.lfItalic = italic; -logFont.lfWeight = bold ? 700 : 400; +logFont.lfWeight = bold ? FW_BOLD : FW_DONTCARE; HFONT hfont = CreateFontIndirect(logFont); return FontPlatformData(hfont, size); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94401] trunk/Source/WebCore
Title: [94401] trunk/Source/WebCore Revision 94401 Author commit-qu...@webkit.org Date 2011-09-02 03:40:18 -0700 (Fri, 02 Sep 2011) Log Message Unreviewed, rolling out r94393. http://trac.webkit.org/changeset/94393 https://bugs.webkit.org/show_bug.cgi?id=67470 It broke Qt-SL build (Requested by ossy on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-02 * WebCore.pro: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.pro Diff Modified: trunk/Source/WebCore/ChangeLog (94400 => 94401) --- trunk/Source/WebCore/ChangeLog 2011-09-02 10:38:57 UTC (rev 94400) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 10:40:18 UTC (rev 94401) @@ -1,3 +1,13 @@ +2011-09-02 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r94393. +http://trac.webkit.org/changeset/94393 +https://bugs.webkit.org/show_bug.cgi?id=67470 + +It broke Qt-SL build (Requested by ossy on #webkit). + +* WebCore.pro: + 2011-09-02 Kenichi Ishibashi ba...@chromium.org [Chromium] Webfonts display bold in Windows Modified: trunk/Source/WebCore/WebCore.pro (94400 => 94401) --- trunk/Source/WebCore/WebCore.pro 2011-09-02 10:38:57 UTC (rev 94400) +++ trunk/Source/WebCore/WebCore.pro 2011-09-02 10:40:18 UTC (rev 94401) @@ -983,7 +983,6 @@ platform/graphics/FontFallbackList.cpp \ platform/graphics/FontFamily.cpp \ platform/graphics/FontFeatureSettings.cpp \ -platform/graphics/GlyphPageTreeNode.cpp \ platform/graphics/BitmapImage.cpp \ platform/graphics/Color.cpp \ platform/graphics/FloatPoint3D.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94403] trunk
Title: [94403] trunk Revision 94403 Author ba...@chromium.org Date 2011-09-02 03:54:05 -0700 (Fri, 02 Sep 2011) Log Message [chromium] editing/selection/regional-indicators.html timing out on Linux https://bugs.webkit.org/show_bug.cgi?id=66510 Reviewed by Kent Tamura. Source/WebCore: Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly. No new tests. editing/selection/regional-indicators.html should pass with this patch. * platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run. (WebCore::surrogatePairAwareFirstCharacter): Added. (WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData. LayoutTests: ComplexTextControllerLinux is now surrogate pairs aware, therefore; - editing/selection/regional-indicators.html should pass. - editing/deleting/regional-indicators.html should not timeout. - fast/text/regional-indicator-symbols.html should pass. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp Diff Modified: trunk/LayoutTests/ChangeLog (94402 => 94403) --- trunk/LayoutTests/ChangeLog 2011-09-02 10:51:49 UTC (rev 94402) +++ trunk/LayoutTests/ChangeLog 2011-09-02 10:54:05 UTC (rev 94403) @@ -1,3 +1,17 @@ +2011-09-02 Kenichi Ishibashi ba...@chromium.org + +[chromium] editing/selection/regional-indicators.html timing out on Linux +https://bugs.webkit.org/show_bug.cgi?id=66510 + +Reviewed by Kent Tamura. + +ComplexTextControllerLinux is now surrogate pairs aware, therefore; +- editing/selection/regional-indicators.html should pass. +- editing/deleting/regional-indicators.html should not timeout. +- fast/text/regional-indicator-symbols.html should pass. + +* platform/chromium/test_expectations.txt: + 2011-09-02 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94399. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94402 => 94403) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 10:51:49 UTC (rev 94402) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 10:54:05 UTC (rev 94403) @@ -3481,8 +3481,6 @@ BUGWK65366 : fast/js/parseInt.html = TEXT -BUGCR91061 LINUX DEBUG : fast/text/regional-indicator-symobls.html = TIMEOUT - BUGWK65453 MAC : fast/css/outline-auto-empty-rects.html = IMAGE BUGWK65462 VISTA : http/tests/cache/history-only-cached-subresource-loads-max-age-https.html = PASS TIMEOUT @@ -3597,8 +3595,7 @@ // New test in r93068 BUGWK66268 WIN MAC : editing/deleting/regional-indicators.html = TEXT -BUGWK66268 LINUX RELEASE : editing/deleting/regional-indicators.html = TEXT -BUGWK66268 LINUX DEBUG : editing/deleting/regional-indicators.html = TIMEOUT +BUGWK66268 LINUX : editing/deleting/regional-indicators.html = TEXT BUGWK66310 DEBUG : media/video-source-error.html = PASS TEXT BUGWK66310 : media/media-blocked-by-beforeload.html = PASS TEXT @@ -3615,8 +3612,6 @@ BUGWK66419 : http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html = TEXT BUGWK66419 : http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html = TEXT -BUGWK66510 LINUX DEBUG : editing/selection/regional-indicators.html = TIMEOUT - BUGWK67121 DEBUG SLOW : editing/selection/move-by-word-visually-multi-space.html = PASS BUGWK66569 WIN LINUX : http/tests/inspector/network/network-iframe-load-and-delete.html = TEXT TIMEOUT PASS Modified: trunk/Source/WebCore/ChangeLog (94402 => 94403) --- trunk/Source/WebCore/ChangeLog 2011-09-02 10:51:49 UTC (rev 94402) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 10:54:05 UTC (rev 94403) @@ -1,3 +1,19 @@ +2011-09-02 Kenichi Ishibashi ba...@chromium.org + +[chromium] editing/selection/regional-indicators.html timing out on Linux +https://bugs.webkit.org/show_bug.cgi?id=66510 + +Reviewed by Kent Tamura. + +Uses SurrogatePairAwareTextIerator in ComplexTextControllerLinux to handle surrogate pairs correctly. + +No new tests. editing/selection/regional-indicators.html should pass with this patch. + +* platform/graphics/chromium/ComplexTextControllerLinux.cpp: +(WebCore::ComplexTextController::nextScriptRun): Used SurrogatePairAwareTextIterator to split run. +(WebCore::surrogatePairAwareFirstCharacter): Added. +(WebCore::ComplexTextController::setupFontForScriptRun): Used surrogatePairAwareFirstCharacter() to get appropriate FontData. + 2011-09-02 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94399.
[webkit-changes] [94404] trunk/Source/WebCore
Title: [94404] trunk/Source/WebCore Revision 94404 Author par...@webkit.org Date 2011-09-02 04:10:49 -0700 (Fri, 02 Sep 2011) Log Message [GTK] Generate gobject bindings for Notification and NotificationCenter https://bugs.webkit.org/show_bug.cgi?id=67380 Reviewed by Philippe Normand. * bindings/gobject/GNUmakefile.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/gobject/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (94403 => 94404) --- trunk/Source/WebCore/ChangeLog 2011-09-02 10:54:05 UTC (rev 94403) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:10:49 UTC (rev 94404) @@ -1,3 +1,12 @@ +2011-09-02 Patrick Gansterer par...@webkit.org + +[GTK] Generate gobject bindings for Notification and NotificationCenter +https://bugs.webkit.org/show_bug.cgi?id=67380 + +Reviewed by Philippe Normand. + +* bindings/gobject/GNUmakefile.am: + 2011-09-02 Kenichi Ishibashi ba...@chromium.org [chromium] editing/selection/regional-indicators.html timing out on Linux Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (94403 => 94404) --- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-09-02 10:54:05 UTC (rev 94403) +++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-09-02 11:10:49 UTC (rev 94404) @@ -220,6 +220,10 @@ DerivedSources/webkit/WebKitDOMNodeList.cpp \ DerivedSources/webkit/WebKitDOMNodeListPrivate.h \ DerivedSources/webkit/WebKitDOMNodePrivate.h \ + DerivedSources/webkit/WebKitDOMNotification.cpp \ + DerivedSources/webkit/WebKitDOMNotificationPrivate.h \ + DerivedSources/webkit/WebKitDOMNotificationCenter.cpp \ + DerivedSources/webkit/WebKitDOMNotificationCenterPrivate.h \ DerivedSources/webkit/WebKitDOMProcessingInstruction.cpp \ DerivedSources/webkit/WebKitDOMProcessingInstructionPrivate.h \ DerivedSources/webkit/WebKitDOMRange.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94406] trunk/Source/WebCore
Title: [94406] trunk/Source/WebCore Revision 94406 Author an...@apple.com Date 2011-09-02 04:19:35 -0700 (Fri, 02 Sep 2011) Log Message De-virtualize recalcStyle() https://bugs.webkit.org/show_bug.cgi?id=67378 Reviewed by Dimitri Glazkov. Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will also make it possible to de-recursify it later. Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc. These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set. * dom/Document.cpp: (WebCore::Document::recalcStyle): * dom/Document.h: * dom/Element.cpp: (WebCore::Element::recalcStyle): * dom/Element.h: (WebCore::Element::willRecalcStyle): (WebCore::Element::didRecalcStyle): * dom/Node.h: (WebCore::Node::hasCustomWillOrDidRecalcStyle): (WebCore::Node::setHasCustomWillOrDidRecalcStyle): * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::recalcShadowTreeStyle): * dom/ShadowRoot.h: * dom/Text.cpp: (WebCore::Text::recalcTextStyle): * dom/Text.h: * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::didRecalcStyle): * html/HTMLFormControlElement.h: * html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::willRecalcStyle): * html/HTMLFrameSetElement.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::didRecalcStyle): * html/HTMLMediaElement.h: * html/HTMLNoScriptElement.cpp: (WebCore::HTMLNoScriptElement::HTMLNoScriptElement): (WebCore::HTMLNoScriptElement::willRecalcStyle): * html/HTMLNoScriptElement.h: * html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): (WebCore::HTMLPlugInImageElement::willRecalcStyle): * html/HTMLPlugInImageElement.h: * html/HTMLSelectElement.cpp: * html/HTMLSelectElement.h: * svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::SVGTRefElement): (WebCore::SVGShadowText::willRecalcStyle): * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::willRecalcStyle): (WebCore::SVGUseElement::didRecalcStyle): * svg/SVGUseElement.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/ShadowRoot.cpp trunk/Source/WebCore/dom/ShadowRoot.h trunk/Source/WebCore/dom/Text.cpp trunk/Source/WebCore/dom/Text.h trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLFormControlElement.h trunk/Source/WebCore/html/HTMLFrameSetElement.cpp trunk/Source/WebCore/html/HTMLFrameSetElement.h trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/html/HTMLNoScriptElement.cpp trunk/Source/WebCore/html/HTMLNoScriptElement.h trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/svg/SVGTRefElement.cpp trunk/Source/WebCore/svg/SVGUseElement.cpp trunk/Source/WebCore/svg/SVGUseElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (94405 => 94406) --- trunk/Source/WebCore/ChangeLog 2011-09-02 11:16:40 UTC (rev 94405) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:19:35 UTC (rev 94406) @@ -1,3 +1,64 @@ +2011-09-02 Antti Koivisto an...@apple.com + +De-virtualize recalcStyle() +https://bugs.webkit.org/show_bug.cgi?id=67378 + +Reviewed by Dimitri Glazkov. + +Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will +also make it possible to de-recursify it later. + +Added willRecalcStyle()/didRecalcStyle() virtual function for subclasses that need custom style recalc. +These are only invoked if hasCustomWillOrDidRecalcStyle() bit is set. + +* dom/Document.cpp: +(WebCore::Document::recalcStyle): +* dom/Document.h: +* dom/Element.cpp: +(WebCore::Element::recalcStyle): +* dom/Element.h: +(WebCore::Element::willRecalcStyle): +(WebCore::Element::didRecalcStyle): +* dom/Node.h: +(WebCore::Node::hasCustomWillOrDidRecalcStyle): +(WebCore::Node::setHasCustomWillOrDidRecalcStyle): +* dom/ShadowRoot.cpp: +(WebCore::ShadowRoot::recalcShadowTreeStyle): +* dom/ShadowRoot.h: +* dom/Text.cpp: +(WebCore::Text::recalcTextStyle): +* dom/Text.h: +* html/HTMLFormControlElement.cpp: +(WebCore::HTMLFormControlElement::HTMLFormControlElement): +(WebCore::HTMLFormControlElement::didRecalcStyle): +* html/HTMLFormControlElement.h: +* html/HTMLFrameSetElement.cpp: +
[webkit-changes] [94407] trunk/Tools
Title: [94407] trunk/Tools
Revision 94407
Author o...@webkit.org
Date 2011-09-02 04:36:40 -0700 (Fri, 02 Sep 2011)
Log Message
[Qt] Build dependency problems
https://bugs.webkit.org/show_bug.cgi?id=38054
Trivial fix after r94288.
Rubber-stamped by Andras Becsi.
* Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
(buildQMakeProject):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (94406 => 94407)
--- trunk/Tools/ChangeLog 2011-09-02 11:19:35 UTC (rev 94406)
+++ trunk/Tools/ChangeLog 2011-09-02 11:36:40 UTC (rev 94407)
@@ -1,3 +1,15 @@
+2011-09-02 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Build dependency problems
+https://bugs.webkit.org/show_bug.cgi?id=38054
+
+Trivial fix after r94288.
+
+Rubber-stamped by Andras Becsi.
+
+* Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
+(buildQMakeProject):
+
2011-09-02 Andras Becsi andras.be...@nokia.com
Remove my old e-mail address and add my new one.
Modified: trunk/Tools/Scripts/webkitdirs.pm (94406 => 94407)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-09-02 11:19:35 UTC (rev 94406)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-09-02 11:36:40 UTC (rev 94407)
@@ -1687,7 +1687,9 @@
my $pathToDefaultsTxt = File::Spec-catfile( $dir, defaults.txt );
my $defaultsTxt = ;
if(open DEFAULTS, $pathToDefaultsTxt){
-$defaultsTxt = DEFAULTS.DEFAULTS;
+while (DEFAULTS) {
+$defaultsTxt .= $_;
+}
close (DEFAULTS);
}
if(not($defaults eq $defaultsTxt)){
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94408] trunk/Source/WebCore
Title: [94408] trunk/Source/WebCore
Revision 94408
Author vse...@chromium.org
Date 2011-09-02 04:39:00 -0700 (Fri, 02 Sep 2011)
Log Message
Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.get redirectSource):
(WebInspector.Resource.prototype.set redirectSource):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/NetworkManager.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/Resource.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (94407 => 94408)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 11:36:40 UTC (rev 94407)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:39:00 UTC (rev 94408)
@@ -1,3 +1,19 @@
+2011-09-02 Vsevolod Vlasov vse...@chromium.org
+
+Web Inspector: Network: jump to initiator's record in case of redirect
+https://bugs.webkit.org/show_bug.cgi?id=67367
+
+Reviewed by Pavel Feldman.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/NetworkManager.js:
+(WebInspector.NetworkDispatcher.prototype._appendRedirect):
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
+* inspector/front-end/Resource.js:
+(WebInspector.Resource.prototype.get redirectSource):
+(WebInspector.Resource.prototype.set redirectSource):
+
2011-09-02 Antti Koivisto an...@apple.com
De-virtualize recalcStyle()
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/NetworkManager.js (94407 => 94408)
--- trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2011-09-02 11:36:40 UTC (rev 94407)
+++ trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2011-09-02 11:39:00 UTC (rev 94408)
@@ -317,6 +317,8 @@
var previousRedirects = originalResource.redirects || [];
originalResource.requestId = redirected: + requestId + . + previousRedirects.length;
delete originalResource.redirects;
+if (previousRedirects.length 0)
+originalResource.redirectSource = previousRedirects[previousRedirects.length - 1];
this._finishResource(originalResource, time);
var newResource = this._createResource(requestId, originalResource.frameId, originalResource.loaderId,
redirectURL, originalResource.documentURL, originalResource.initiator, originalResource.stackTrace);
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (94407 => 94408)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:36:40 UTC (rev 94407)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:39:00 UTC (rev 94408)
@@ -1992,13 +1992,18 @@
_refreshInitiatorCell: function()
{
var initiator = this._resource.initiator;
-if (!initiator || initiator.type === other) {
-this._initiatorCell.addStyleClass(network-dim-cell);
-this._initiatorCell.setTextAndTitle(WebInspector.UIString(Other));
-} else {
+if ((initiator initiator.type !== other) || this._resource.redirectSource) {
this._initiatorCell.removeStyleClass(network-dim-cell);
this._initiatorCell.removeChildren();
-if (initiator.type === script) {
+if (this._resource.redirectSource) {
+var redirectSource = this._resource.redirectSource;
+var anchor = WebInspector.linkifyURLAsNode(redirectSource.url, redirectSource.url, null, false);
+anchor.setAttribute(request_id, redirectSource.requestId);
+anchor.setAttribute(preferred_panel, network);
+this._initiatorCell.title = redirectSource.url;
+this._initiatorCell.appendChild(anchor);
+this._appendSubtitle(this._initiatorCell, WebInspector.UIString(Redirect));
+} else if (initiator.type === script) {
var topFrame = initiator.stackTrace[0];
// This could happen when resource loading was triggered by console.
if (!topFrame.url) {
@@ -2015,6 +2020,9 @@
this._initiatorCell.appendChild(WebInspector.linkifyResourceAsNode(initiator.url, initiator.lineNumber - 1));
this._appendSubtitle(this._initiatorCell, WebInspector.UIString(Parser));
}
+} else {
+
[webkit-changes] [94409] trunk/Source/WebCore
Title: [94409] trunk/Source/WebCore
Revision 94409
Author vse...@chromium.org
Date 2011-09-02 04:41:55 -0700 (Fri, 02 Sep 2011)
Log Message
Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411
Reviewed by Pavel Feldman.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkLogView.prototype._sortByTimeline):
(WebInspector.NetworkLogView.prototype._updateFilter):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (94408 => 94409)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 11:39:00 UTC (rev 94408)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:41:55 UTC (rev 94409)
@@ -1,5 +1,17 @@
2011-09-02 Vsevolod Vlasov vse...@chromium.org
+Web Inspector: Should remove resource highlight on sort/filter in network panel.
+https://bugs.webkit.org/show_bug.cgi?id=67411
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView.prototype._sortItems):
+(WebInspector.NetworkLogView.prototype._sortByTimeline):
+(WebInspector.NetworkLogView.prototype._updateFilter):
+
+2011-09-02 Vsevolod Vlasov vse...@chromium.org
+
Web Inspector: Network: jump to initiator's record in case of redirect
https://bugs.webkit.org/show_bug.cgi?id=67367
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (94408 => 94409)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:39:00 UTC (rev 94408)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:41:55 UTC (rev 94409)
@@ -282,6 +282,7 @@
_sortItems: function()
{
+this._removeAllNodeHighlights();
var columnIdentifier = this._dataGrid.sortColumnIdentifier;
if (columnIdentifier === timeline) {
this._sortByTimeline();
@@ -300,6 +301,7 @@
_sortByTimeline: function()
{
+this._removeAllNodeHighlights();
var selectedIndex = this._timelineSortSelector.selectedIndex;
if (!selectedIndex)
selectedIndex = 1; // Sort by start time by default.
@@ -426,6 +428,7 @@
_updateFilter: function(e)
{
+this._removeAllNodeHighlights();
var isMac = WebInspector.isMac();
var selectMultiple = false;
if (isMac e.metaKey !e.ctrlKey !e.altKey !e.shiftKey)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94410] trunk/Source/WebCore
Title: [94410] trunk/Source/WebCore
Revision 94410
Author vse...@chromium.org
Date 2011-09-02 04:49:36 -0700 (Fri, 02 Sep 2011)
Log Message
Web Inspector: Make it more clear when requests are loaded from cache on network panel.
https://bugs.webkit.org/show_bug.cgi?id=67396
Reviewed by Pavel Feldman.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
* inspector/front-end/networkPanel.css:
(.resource-headers-view .outline-disclosure li .status-from-cache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js
trunk/Source/WebCore/inspector/front-end/networkPanel.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (94409 => 94410)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 11:49:36 UTC (rev 94410)
@@ -1,5 +1,19 @@
2011-09-02 Vsevolod Vlasov vse...@chromium.org
+Web Inspector: Make it more clear when requests are loaded from cache on network panel.
+https://bugs.webkit.org/show_bug.cgi?id=67396
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
+* inspector/front-end/ResourceHeadersView.js:
+(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
+* inspector/front-end/networkPanel.css:
+(.resource-headers-view .outline-disclosure li .status-from-cache):
+
+2011-09-02 Vsevolod Vlasov vse...@chromium.org
+
Web Inspector: Should remove resource highlight on sort/filter in network panel.
https://bugs.webkit.org/show_bug.cgi?id=67411
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-02 11:49:36 UTC (rev 94410)
@@ -1962,11 +1962,12 @@
if (this._resource.statusCode) {
this._statusCell.appendChild(document.createTextNode(this._resource.statusCode));
-this._statusCell.removeStyleClass(network-dim-cell);
this._appendSubtitle(this._statusCell, this._resource.statusText);
this._statusCell.title = this._resource.statusCode + + this._resource.statusText;
if (this._resource.statusCode = 400)
this.element.addStyleClass(network-error-row);
+if (this._resource.cached)
+this._statusCell.addStyleClass(network-dim-cell);
} else {
if (!this._resource.isHttpFamily() this._resource.finished)
this._statusCell.setTextAndTitle(WebInspector.UIString(Success));
Modified: trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js 2011-09-02 11:49:36 UTC (rev 94410)
@@ -304,8 +304,12 @@
requestMethodElement.titleHTML = div class=\header-name\ + WebInspector.UIString(Request Method) + :/div +
div class=\header-value source-code\ + this._resource.requestMethod + /div;
+var fromCacheSpan = ;
+if (this._resource.cached)
+fromCacheSpan = + span class=\status-from-cache\ + WebInspector.UIString((from cache)).escapeHTML() + /span;
+
statusCodeElement.titleHTML = div class=\header-name\ + WebInspector.UIString(Status Code) + :/div +
-statusCodeImage + div class=\header-value source-code\ + statusTextEscaped + /div;
+statusCodeImage + div class=\header-value source-code\ + statusTextEscaped + fromCacheSpan + /div;
}
},
Modified: trunk/Source/WebCore/inspector/front-end/networkPanel.css (94409 => 94410)
--- trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-09-02 11:41:55 UTC (rev 94409)
+++ trunk/Source/WebCore/inspector/front-end/networkPanel.css 2011-09-02 11:49:36 UTC (rev 94410)
@@ -135,6 +135,10 @@
display: none;
}
+.resource-headers-view .outline-disclosure li .status-from-cache {
+color: gray;
+}
+
.resource-headers-view .outline-disclosure li.expanded .header-toggle {
display: inline;
margin-left: 30px;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94411] trunk/Source/WebKit2
Title: [94411] trunk/Source/WebKit2 Revision 94411 Author kbal...@webkit.org Date 2011-09-02 05:35:46 -0700 (Fri, 02 Sep 2011) Log Message [Qt][WK2] Cannot gathering glyph page statistics https://bugs.webkit.org/show_bug.cgi?id=67475 Rubber stamped by Csaba Osztrogonác. Fix Qt WK2 build without having QRAWFONT. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::getWebCoreStatistics): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (94410 => 94411) --- trunk/Source/WebKit2/ChangeLog 2011-09-02 11:49:36 UTC (rev 94410) +++ trunk/Source/WebKit2/ChangeLog 2011-09-02 12:35:46 UTC (rev 94411) @@ -1,3 +1,15 @@ +2011-09-02 Balazs Kelemen kbal...@webkit.org + +[Qt][WK2] Cannot gathering glyph page statistics +https://bugs.webkit.org/show_bug.cgi?id=67475 + +Rubber stamped by Csaba Osztrogonác. + +Fix Qt WK2 build without having QRAWFONT. + +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::getWebCoreStatistics): + 2011-09-02 Mark Rowe mr...@apple.com http://webkit.org/b/67467 WebProcessProxy::secItemCopyMatching / WebProcessProxy::secItemAdd Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (94410 => 94411) --- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-02 11:49:36 UTC (rev 94410) +++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-02 12:35:46 UTC (rev 94411) @@ -924,7 +924,9 @@ data.statisticsNumbers.set(CachedFontDataInactiveCount, fontCache()-inactiveFontDataCount()); // Gather glyph page statistics. +#if !(PLATFORM(QT) !HAVE(QRAWFONT)) // Qt doesn't use the glyph page tree currently. See: bug 63467. data.statisticsNumbers.set(GlyphPageCount, GlyphPageTreeNode::treeGlyphPageCount()); +#endif // Get WebCore memory cache statistics getWebCoreMemoryCacheStatistics(data.webCoreCacheStatistics); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94412] trunk/LayoutTests
Title: [94412] trunk/LayoutTests Revision 94412 Author apav...@chromium.org Date 2011-09-02 05:46:47 -0700 (Fri, 02 Sep 2011) Log Message [Chromium] Unreviewed, update test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94411 => 94412) --- trunk/LayoutTests/ChangeLog 2011-09-02 12:35:46 UTC (rev 94411) +++ trunk/LayoutTests/ChangeLog 2011-09-02 12:46:47 UTC (rev 94412) @@ -1,3 +1,9 @@ +2011-09-02 Alexander Pavlov apav...@chromium.org + +[Chromium] Unreviewed, update test expectations. + +* platform/chromium/test_expectations.txt: + 2011-09-02 Yuta Kitamura yu...@chromium.org WebSocket: Send Blob as WebSocket binary message Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94411 => 94412) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 12:35:46 UTC (rev 94411) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 12:46:47 UTC (rev 94412) @@ -3680,10 +3680,13 @@ BUGWK67433 WIN LINUX : svg/custom/pattern-rotate-gaps.svg = IMAGE -// Renders differently in 32 vs 64 bit mode -BUGJAMESR LINUX X86_64 : svg/transforms/text-with-pattern-with-svg-transform.svg = IMAGE +// Renders differently in 32 vs 64 bit mode and is flaky +BUGJAMESR LINUX : svg/transforms/text-with-pattern-with-svg-transform.svg = IMAGE PASS // We don't seem to load this glyph on windows BUGJAMESR WIN : fast/text/fallback-traits-fixup.html = IMAGE+TEXT BUGWK67359 : http/tests/loading/empty-urls.html = PASS TEXT + +// Failing after r94406. +BUGWK67480 : svg/batik/text/textStyles.svg = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94413] trunk/LayoutTests
Title: [94413] trunk/LayoutTests Revision 94413 Author r...@webkit.org Date 2011-09-02 06:09:02 -0700 (Fri, 02 Sep 2011) Log Message [Qt] Two tests are passing after r94324. They are unskipped: fast/events/document-elementFromPoint.html plugins/mouse-events-fixedpos.html Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94412 => 94413) --- trunk/LayoutTests/ChangeLog 2011-09-02 12:46:47 UTC (rev 94412) +++ trunk/LayoutTests/ChangeLog 2011-09-02 13:09:02 UTC (rev 94413) @@ -1,3 +1,13 @@ +2011-09-02 Renata Hodovan r...@webkit.org + +[Qt] Two tests are passing after r94324. They are unskipped: +fast/events/document-elementFromPoint.html +plugins/mouse-events-fixedpos.html + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-09-02 Alexander Pavlov apav...@chromium.org [Chromium] Unreviewed, update test expectations. Modified: trunk/LayoutTests/platform/qt/Skipped (94412 => 94413) --- trunk/LayoutTests/platform/qt/Skipped 2011-09-02 12:46:47 UTC (rev 94412) +++ trunk/LayoutTests/platform/qt/Skipped 2011-09-02 13:09:02 UTC (rev 94413) @@ -2413,7 +2413,3 @@ fast/multicol/positive-leading.html fast/multicol/overflow-unsplittable.html fast/multicol/overflow-across-columns.html - -# [Qt] Incorrect absolute mouse pointer results after r94259 -fast/events/document-elementFromPoint.html -plugins/mouse-events-fixedpos.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94414] trunk/Source/WebKit/efl
Title: [94414] trunk/Source/WebKit/efl
Revision 94414
Author lean...@webkit.org
Date 2011-09-02 06:22:45 -0700 (Fri, 02 Sep 2011)
Log Message
Unreviewed build fix after r67110.
* ewk/ewk_view.cpp:
(ewk_view_need_touch_events_get): Make the function signature match
its declaration.
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (94413 => 94414)
--- trunk/Source/WebKit/efl/ChangeLog 2011-09-02 13:09:02 UTC (rev 94413)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-09-02 13:22:45 UTC (rev 94414)
@@ -1,3 +1,11 @@
+2011-09-02 Leandro Pereira lean...@profusion.mobi
+
+Unreviewed build fix after r67110.
+
+* ewk/ewk_view.cpp:
+(ewk_view_need_touch_events_get): Make the function signature match
+its declaration.
+
2011-09-01 Gyuyoung Kim gyuyoung@samsung.com
[EFL] Allow controlling minimum DOMTimer interval on a per-page basis
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (94413 => 94414)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-09-02 13:09:02 UTC (rev 94413)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-09-02 13:22:45 UTC (rev 94414)
@@ -3642,7 +3642,7 @@
priv-flags.need_touch_events = needed;
}
-Eina_Bool ewk_view_need_touch_events_get(Evas_Object *o)
+Eina_Bool ewk_view_need_touch_events_get(const Evas_Object *o)
{
EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94415] trunk/LayoutTests
Title: [94415] trunk/LayoutTests Revision 94415 Author domin...@chromium.org Date 2011-09-02 07:02:57 -0700 (Fri, 02 Sep 2011) Log Message Unreviewed test fix. Sadly window-property-descriptors enumerates functions in the test harness. r94362 added a couple of functions, so these results need to be updated. * fast/dom/Window/window-property-descriptors-expected.txt: * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: * platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: * platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt trunk/LayoutTests/platform/win/fast/dom/Window/window-property-descriptors-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94414 => 94415) --- trunk/LayoutTests/ChangeLog 2011-09-02 13:22:45 UTC (rev 94414) +++ trunk/LayoutTests/ChangeLog 2011-09-02 14:02:57 UTC (rev 94415) @@ -1,3 +1,16 @@ +2011-09-02 Dominic Cooney domin...@chromium.org + +Unreviewed test fix. + +Sadly window-property-descriptors enumerates functions in the test +harness. r94362 added a couple of functions, so these results need +to be updated. + +* fast/dom/Window/window-property-descriptors-expected.txt: +* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt: +* platform/win/fast/dom/Window/window-property-descriptors-expected.txt: + 2011-09-02 Renata Hodovan r...@webkit.org [Qt] Two tests are passing after r94324. They are unskipped: Modified: trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt (94414 => 94415) --- trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 13:22:45 UTC (rev 94414) +++ trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 14:02:57 UTC (rev 94415) @@ -350,6 +350,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultStatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultstatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'description') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'descriptionQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'devicePixelRatio') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'document') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'encodeURI') is 'object' @@ -478,6 +479,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNonZero') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNull') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrue') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrueQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object' Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt (94414 => 94415) --- trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 13:22:45 UTC (rev 94414) +++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2011-09-02 14:02:57 UTC (rev 94415) @@ -351,6 +351,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultStatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'defaultstatus') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'description') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'descriptionQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'devicePixelRatio') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'document') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'encodeURI') is 'object' @@ -479,6 +480,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNonZero') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeNull') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrue') is 'object' +PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeTrueQuiet') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldBeUndefined') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldEvaluateTo') is 'object' PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is
[webkit-changes] [94416] trunk/LayoutTests
Title: [94416] trunk/LayoutTests Revision 94416 Author zol...@webkit.org Date 2011-09-02 07:05:43 -0700 (Fri, 02 Sep 2011) Log Message [Qt][WK2] 4 tests are failing, skip them https://bugs.webkit.org/show_bug.cgi?id=67485 Patch by Kristóf Kosztyó kkris...@inf.u-szeged.hu on 2011-09-02 * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94415 => 94416) --- trunk/LayoutTests/ChangeLog 2011-09-02 14:02:57 UTC (rev 94415) +++ trunk/LayoutTests/ChangeLog 2011-09-02 14:05:43 UTC (rev 94416) @@ -1,3 +1,10 @@ +2011-09-02 Kristóf Kosztyó kkris...@inf.u-szeged.hu + +[Qt][WK2] 4 tests are failing, skip them +https://bugs.webkit.org/show_bug.cgi?id=67485 + +* platform/qt-wk2/Skipped: + 2011-09-02 Dominic Cooney domin...@chromium.org Unreviewed test fix. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (94415 => 94416) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-09-02 14:02:57 UTC (rev 94415) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-09-02 14:05:43 UTC (rev 94416) @@ -1694,3 +1694,10 @@ # Missing layoutTestController.dumpResourceResponseMIMETypes() # https://bugs.webkit.org/show_bug.cgi?id=67392 fast/preloader/document-write-noscript.html + +# New failing tests +# https://bugs.webkit.org/show_bug.cgi?id=67485 +fast/dom/Window/window-properties.html +fast/text/complex-preferred-logical-widths.html +http/tests/loading/empty-urls.html +http/tests/loading/progress-finished-callback.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94417] trunk/Source/WebKit2
Title: [94417] trunk/Source/WebKit2
Revision 94417
Author commit-qu...@webkit.org
Date 2011-09-02 07:09:27 -0700 (Fri, 02 Sep 2011)
Log Message
[WK2] Anchor elements doesn't get focus on TAB key press.
https://bugs.webkit.org/show_bug.cgi?id=66949
Patch by Ravi Phaneendra Kasibhatla ravi.kasibha...@motorola.com on 2011-09-02
Reviewed by Adam Roben.
Setting the default property value of TabsToLinks to true
only for GTK platform since Win Mac platforms doesn't want
it to be set to true by default.
* Shared/WebPreferencesStore.h:
Set the default value of key TabsToLinks to true for GTK platform only.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94416 => 94417)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 14:05:43 UTC (rev 94416)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 14:09:27 UTC (rev 94417)
@@ -1,3 +1,17 @@
+2011-09-02 Ravi Phaneendra Kasibhatla ravi.kasibha...@motorola.com
+
+[WK2] Anchor elements doesn't get focus on TAB key press.
+https://bugs.webkit.org/show_bug.cgi?id=66949
+
+Reviewed by Adam Roben.
+
+Setting the default property value of TabsToLinks to true
+only for GTK platform since Win Mac platforms doesn't want
+it to be set to true by default.
+
+* Shared/WebPreferencesStore.h:
+Set the default value of key TabsToLinks to true for GTK platform only.
+
2011-09-02 Balazs Kelemen kbal...@webkit.org
[Qt][WK2] Cannot gathering glyph page statistics
Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (94416 => 94417)
--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2011-09-02 14:05:43 UTC (rev 94416)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h 2011-09-02 14:09:27 UTC (rev 94417)
@@ -42,6 +42,12 @@
#define DEFAULT_WEBKIT_AVFOUNDATION_ENABLED true
#endif
+#if PLATFORM(GTK)
+#define DEFAULT_WEBKIT_TABSTOLINKS_ENABLED true
+#else
+#define DEFAULT_WEBKIT_TABSTOLINKS_ENABLED false
+#endif
+
#define FOR_EACH_WEBKIT_BOOL_PREFERENCE(macro) \
macro(_javascript_Enabled, _javascript_Enabled, Bool, bool, true) \
macro(LoadsImagesAutomatically, loadsImagesAutomatically, Bool, bool, true) \
@@ -66,7 +72,7 @@
macro(CompositingRepaintCountersVisible, compositingRepaintCountersVisible, Bool, bool, false) \
macro(WebGLEnabled, webGLEnabled, Bool, bool, false) \
macro(ForceFTPDirectoryListings, forceFTPDirectoryListings, Bool, bool, false) \
-macro(TabsToLinks, tabsToLinks, Bool, bool, false) \
+macro(TabsToLinks, tabsToLinks, Bool, bool, DEFAULT_WEBKIT_TABSTOLINKS_ENABLED) \
macro(DNSPrefetchingEnabled, dnsPrefetchingEnabled, Bool, bool, false) \
macro(WebArchiveDebugModeEnabled, webArchiveDebugModeEnabled, Bool, bool, false) \
macro(LocalFileContentSniffingEnabled, localFileContentSniffingEnabled, Bool, bool, false) \
@@ -168,7 +174,7 @@
#define DECLARE_KEY_GETTERS(KeyUpper, KeyLower, TypeName, Type, DefaultValue) const String KeyLower##Key();
-FOR_EACH_WEBKIT_PREFERENCE(DECLARE_KEY_GETTERS)
+FOR_EACH_WEBKIT_PREFERENCE(DECLARE_KEY_GETTERS)
#undef DECLARE_KEY_GETTERS
@@ -177,7 +183,7 @@
struct WebPreferencesStore {
WebPreferencesStore();
-void encode(CoreIPC::ArgumentEncoder* encoder) const;
+void encode(CoreIPC::ArgumentEncoder*) const;
static bool decode(CoreIPC::ArgumentDecoder*, WebPreferencesStore);
// NOTE: The getters in this class have non-standard names to aid in the use of the preference macros.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94418] trunk
Title: [94418] trunk
Revision 94418
Author commit-qu...@webkit.org
Date 2011-09-02 08:35:44 -0700 (Fri, 02 Sep 2011)
Log Message
Source/WebCore: Resetting media controls when the src is changed from a valid url to an
invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880
Patch by Arko Saha ngh...@motorola.com on 2011-09-02
Reviewed by Eric Carlson.
Test: media/media-controls-invalid-url.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaLoadingFailed):
LayoutTests: Controls not reset when media element url changed from a valid url to an invalid url.
https://bugs.webkit.org/show_bug.cgi?id=64880
Patch by Arko Saha ngh...@motorola.com on 2011-09-02
Reviewed by Eric Carlson.
* media/media-controls-invalid-url-expected.txt: Added.
* media/media-controls-invalid-url.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/media/media-controls-invalid-url-expected.txt
trunk/LayoutTests/media/media-controls-invalid-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94417 => 94418)
--- trunk/LayoutTests/ChangeLog 2011-09-02 14:09:27 UTC (rev 94417)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 15:35:44 UTC (rev 94418)
@@ -1,3 +1,13 @@
+2011-09-02 Arko Saha ngh...@motorola.com
+
+Controls not reset when media element url changed from a valid url to an invalid url.
+https://bugs.webkit.org/show_bug.cgi?id=64880
+
+Reviewed by Eric Carlson.
+
+* media/media-controls-invalid-url-expected.txt: Added.
+* media/media-controls-invalid-url.html: Added.
+
2011-09-02 Kristóf Kosztyó kkris...@inf.u-szeged.hu
[Qt][WK2] 4 tests are failing, skip them
Added: trunk/LayoutTests/media/media-controls-invalid-url-expected.txt (0 => 94418)
--- trunk/LayoutTests/media/media-controls-invalid-url-expected.txt (rev 0)
+++ trunk/LayoutTests/media/media-controls-invalid-url-expected.txt 2011-09-02 15:35:44 UTC (rev 94418)
@@ -0,0 +1,12 @@
+This tests that media element controls are reset to their default state when the src is changed to an invalid url.
+
+This test only runs in DRT!
+
+EVENT(canplaythrough)
+EXPECTED (getTimeLineValue() == '0') OK
+EVENT(seeked)
+EXPECTED (getTimeLineValue() == '1') OK
+EVENT(error)
+EXPECTED (getTimeLineValue() == '0') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/media-controls-invalid-url.html (0 => 94418)
--- trunk/LayoutTests/media/media-controls-invalid-url.html (rev 0)
+++ trunk/LayoutTests/media/media-controls-invalid-url.html 2011-09-02 15:35:44 UTC (rev 94418)
@@ -0,0 +1,90 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script
+var video;
+
+function init()
+{
+video = document.getElementsByTagName(video)[0];
+video.src = "" content/test);
+
+waitForEvent(canplaythrough, start);
+waitForEvent(seeked, seeked);
+waitForEvent(error, error);
+}
+
+function getTimeLineValue()
+{
+var timelineContainer;
+var timelineValue;
+
+var controlsShadow = internals.shadowRoot(video).firstChild.firstChild;
+for (child = controlsShadow.firstChild; child; child = child.nextSibling)
+if (internals.shadowPseudoId(child) == -webkit-media-controls-timeline-container) {
+timelineContainer = child;
+break;
+}
+
+if(!timelineContainer)
+throw Faild to find -webkit-media-controls-timeline-container;
+
+for (child = timelineContainer.firstChild; child; child = child.nextSibling)
+if (internals.shadowPseudoId(child) == -webkit-media-controls-timeline) {
+timelineValue = child.value;
+break;
+}
+
+if(!timelineContainer)
+throw Faild to find -webkit-media-controls-timeline;
+
+return timelineValue;
+}
+
+function error()
+{
+try {
+testExpected(getTimeLineValue(), video.currentTime);
+endTest();
+} catch (exception) {
+failTest(exception.description);
+}
+}
+
+function seeked()
+{
+try {
+testExpected(getTimeLineValue(), video.currentTime);
+} catch (exception) {
+failTest(exception.description);
+}
+
+// Change video source to an invalid one
+video.src = ""
+}
+
+function start()
+{
+if
[webkit-changes] [94420] trunk
Title: [94420] trunk Revision 94420 Author hy...@apple.com Date 2011-09-02 09:00:23 -0700 (Fri, 02 Sep 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=67431 Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we handle border radius). Reviewed by Beth Dakin. Added fast/borders/border-image-repeat.html. Source/WebCore: * css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue): (WebCore::CSSBorderImageValue::cssText): * css/CSSBorderImageValue.h: (WebCore::CSSBorderImageValue::create): Modified the CSSBorderImageValue (you're living on borrowed time, my friend!) to have a CSSValue that contains a Pair. * css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForRepeatRule): (WebCore::valueForNinePieceImageRepeat): (WebCore::valueForNinePieceImage): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add support for the new properties. Break out the value retrieval for the image repeat rules into its own function, valueForNinePieceImageRepeat. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::BorderImageParseContext::BorderImageParseContext): (WebCore::BorderImageParseContext::allowRepeat): (WebCore::BorderImageParseContext::commitSlice): (WebCore::BorderImageParseContext::commitSlash): (WebCore::BorderImageParseContext::commitWidth): (WebCore::BorderImageParseContext::commitRepeat): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): Modified the parsing of border image to call into parseBorderImageRepeat for the repeat values. (WebCore::isBorderImageRepeatKeyword): (WebCore::CSSParser::parseBorderImageRepeat): The new parsing code for border-image-repeat is here. It will build up a CSSValue containing a Pair and return the result. * css/CSSParser.h: * css/CSSPropertyNames.in: Add the new properties. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapNinePieceImage): (WebCore::CSSStyleSelector::mapNinePieceImageRepeat): * css/CSSStyleSelector.h: The mapping into the front end is done the same way as border-image-slice. Factor out the image repeat rules portion into mapNinePieceImageRepeat. * platform/graphics/Image.cpp: (WebCore::Image::drawTiled): * platform/graphics/Image.h: Add the new 'space' value as a valid image tiling rule. It's not yet supported and, like the 'round' value, is just mapped to 'repeat' for now. * rendering/style/NinePieceImage.h: (WebCore::NinePieceImage::copyRepeatFrom): Helper for copying only the repeat rules from another NinePieceImage. LayoutTests: * fast/borders/border-image-repeat.html: Added. * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/mac/fast/borders/border-image-repeat-expected.png: Added. * platform/mac/fast/borders/border-image-repeat-expected.txt: Added. * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSBorderImageValue.cpp trunk/Source/WebCore/css/CSSBorderImageValue.h trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSParser.h trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSStyleSelector.h trunk/Source/WebCore/platform/graphics/Image.cpp trunk/Source/WebCore/platform/graphics/Image.h trunk/Source/WebCore/rendering/style/NinePieceImage.h Added Paths trunk/LayoutTests/fast/borders/border-image-repeat.html trunk/LayoutTests/platform/mac/fast/borders/border-image-repeat-expected.png trunk/LayoutTests/platform/mac/fast/borders/border-image-repeat-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94419 => 94420) --- trunk/LayoutTests/ChangeLog 2011-09-02 15:57:44 UTC (rev 94419) +++ trunk/LayoutTests/ChangeLog 2011-09-02 16:00:23 UTC (rev 94420) @@ -1,3 +1,22 @@ +2011-09-01 David Hyatt hy...@apple.com + +https://bugs.webkit.org/show_bug.cgi?id=67431 + +Implement border-image-repeat. Similar to how border-image-slice was implemented, the parsing of the two +repeat values has been moved into separate functions. The value is represented as a Pair (similar to how we +handle border radius). + +Reviewed by Beth Dakin. + +Added fast/borders/border-image-repeat.html. + +* fast/borders/border-image-repeat.html: Added. +* fast/css/getComputedStyle/computed-style-expected.txt: +*
[webkit-changes] [94422] trunk/Source/WebCore
Title: [94422] trunk/Source/WebCore Revision 94422 Author commit-qu...@webkit.org Date 2011-09-02 09:38:32 -0700 (Fri, 02 Sep 2011) Log Message Unreviewed, rolling out r94404. http://trac.webkit.org/changeset/94404 https://bugs.webkit.org/show_bug.cgi?id=67490 Patch is wrong, new API needs two reviewers, we are already working on how to add notifications elsewhere (Requested by xan_ on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-02 * bindings/gobject/GNUmakefile.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/gobject/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (94421 => 94422) --- trunk/Source/WebCore/ChangeLog 2011-09-02 16:13:01 UTC (rev 94421) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 16:38:32 UTC (rev 94422) @@ -1,3 +1,15 @@ +2011-09-02 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r94404. +http://trac.webkit.org/changeset/94404 +https://bugs.webkit.org/show_bug.cgi?id=67490 + +Patch is wrong, new API needs two reviewers, we are already +working on how to add notifications elsewhere (Requested by +xan_ on #webkit). + +* bindings/gobject/GNUmakefile.am: + 2011-09-02 Andreas Kling kl...@webkit.org Use fastGetAttribute() and fastHasAttribute() where appropriate. Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (94421 => 94422) --- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-09-02 16:13:01 UTC (rev 94421) +++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am 2011-09-02 16:38:32 UTC (rev 94422) @@ -220,10 +220,6 @@ DerivedSources/webkit/WebKitDOMNodeList.cpp \ DerivedSources/webkit/WebKitDOMNodeListPrivate.h \ DerivedSources/webkit/WebKitDOMNodePrivate.h \ - DerivedSources/webkit/WebKitDOMNotification.cpp \ - DerivedSources/webkit/WebKitDOMNotificationPrivate.h \ - DerivedSources/webkit/WebKitDOMNotificationCenter.cpp \ - DerivedSources/webkit/WebKitDOMNotificationCenterPrivate.h \ DerivedSources/webkit/WebKitDOMProcessingInstruction.cpp \ DerivedSources/webkit/WebKitDOMProcessingInstructionPrivate.h \ DerivedSources/webkit/WebKitDOMRange.cpp \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94423] trunk/Source/WebCore
Title: [94423] trunk/Source/WebCore Revision 94423 Author ant...@chromium.org Date 2011-09-02 09:50:44 -0700 (Fri, 02 Sep 2011) Log Message [v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap https://bugs.webkit.org/show_bug.cgi?id=67484 Reviewed by Yury Semikhatsky. No new tests, minor cleanup. * bindings/v8/custom/V8DOMStringMapCustom.cpp: (WebCore::V8DOMStringMap::namedPropertyEnumerator): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94422 => 94423) --- trunk/Source/WebCore/ChangeLog 2011-09-02 16:38:32 UTC (rev 94422) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 16:50:44 UTC (rev 94423) @@ -1,3 +1,15 @@ +2011-09-02 Anton Muhin ant...@chromium.org + +[v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap +https://bugs.webkit.org/show_bug.cgi?id=67484 + +Reviewed by Yury Semikhatsky. + +No new tests, minor cleanup. + +* bindings/v8/custom/V8DOMStringMapCustom.cpp: +(WebCore::V8DOMStringMap::namedPropertyEnumerator): + 2011-09-02 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94404. Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp (94422 => 94423) --- trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2011-09-02 16:38:32 UTC (rev 94422) +++ trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp 2011-09-02 16:50:44 UTC (rev 94423) @@ -58,7 +58,7 @@ VectorString names; V8DOMStringMap::toNative(info.Holder())-getNames(names); v8::Handlev8::Array properties = v8::Array::New(names.size()); -for (unsigned i = 0; i names.size(); ++i) +for (size_t i = 0; i names.size(); ++i) properties-Set(v8::Integer::New(i), v8String(names[i])); return properties; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94424] trunk
Title: [94424] trunk Revision 94424 Author rolandstei...@chromium.org Date 2011-09-02 09:59:56 -0700 (Fri, 02 Sep 2011) Log Message Implement the Event constructor for V8. https://bugs.webkit.org/show_bug.cgi?id=66756 Patch by Kentaro Hara hara...@google.com on 2011-09-02 Reviewed by Adam Barth. Source/WebCore: The spec of the Event constructor is here: http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor This patch implements the Event constructor for V8 in V8EventConstructors.cpp, similar to the implementation for JSC in JSEventConstructors.cpp. * WebCore.gypi: Added V8EventConstructors.cpp. * WebCore.pro: Ditto. * bindings/scripts/CodeGeneratorV8.pm: * bindings/v8/OptionsObject.cpp: (WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key. * bindings/v8/OptionsObject.h: (WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key. * bindings/v8/custom/V8EventConstructors.cpp: Added. (WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback(). * dom/Event.idl: Added |V8CustomConstructor|. LayoutTests: * platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/bindings/v8/OptionsObject.cpp trunk/Source/WebCore/bindings/v8/OptionsObject.h trunk/Source/WebCore/dom/Event.idl Added Paths trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp Diff Modified: trunk/LayoutTests/ChangeLog (94423 => 94424) --- trunk/LayoutTests/ChangeLog 2011-09-02 16:50:44 UTC (rev 94423) +++ trunk/LayoutTests/ChangeLog 2011-09-02 16:59:56 UTC (rev 94424) @@ -1,3 +1,12 @@ +2011-09-02 Kentaro Hara hara...@google.com + +Implement the Event constructor for V8. +https://bugs.webkit.org/show_bug.cgi?id=66756 + +Reviewed by Adam Barth. + +* platform/chromium/test_expectations.txt: Unskip fast/events/constructors/event-constructors.html. + 2011-09-01 David Hyatt hy...@apple.com https://bugs.webkit.org/show_bug.cgi?id=67431 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94423 => 94424) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 16:50:44 UTC (rev 94423) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 16:59:56 UTC (rev 94424) @@ -3664,9 +3664,6 @@ BUGWK67204 : fast/multicol/inherit-column-values.html = MISSING FAIL BUGWK67204 : fast/multicol/initial-column-values.html = MISSING FAIL -// Implement an Event constructor in V8. -BUGWK66756 : fast/events/constructors/event-constructors.html = TEXT - // Failing after r93982. BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT Modified: trunk/Source/WebCore/ChangeLog (94423 => 94424) --- trunk/Source/WebCore/ChangeLog 2011-09-02 16:50:44 UTC (rev 94423) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 16:59:56 UTC (rev 94424) @@ -1,3 +1,26 @@ +2011-09-02 Kentaro Hara hara...@google.com + +Implement the Event constructor for V8. +https://bugs.webkit.org/show_bug.cgi?id=66756 + +Reviewed by Adam Barth. + +The spec of the Event constructor is here: +http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#concept-event-constructor +This patch implements the Event constructor for V8 in V8EventConstructors.cpp, +similar to the implementation for JSC in JSEventConstructors.cpp. + +* WebCore.gypi: Added V8EventConstructors.cpp. +* WebCore.pro: Ditto. +* bindings/scripts/CodeGeneratorV8.pm: +* bindings/v8/OptionsObject.cpp: +(WebCore::OptionsObject::getKeyDouble): Returns a value of type double corresponding to a given key. +* bindings/v8/OptionsObject.h: +(WebCore::OptionsObject::getKeyValue): Returns a value corresponding to a given key. +* bindings/v8/custom/V8EventConstructors.cpp: Added. +(WebCore::constructV8Event): AllowAllocation::current() means that a DOM object created by WebCore is going to be just wrapped into a V8 object. In this case, we skip the code of constructorCallback(). +* dom/Event.idl: Added |V8CustomConstructor|. + 2011-09-02 Anton Muhin ant...@chromium.org [v8] Use size_t instead of unsigned when iterating over Vector in V8DOMStringMap Modified: trunk/Source/WebCore/WebCore.gypi (94423 => 94424) --- trunk/Source/WebCore/WebCore.gypi 2011-09-02 16:50:44 UTC (rev 94423) +++ trunk/Source/WebCore/WebCore.gypi 2011-09-02 16:59:56 UTC (rev 94424) @@ -2147,6 +2147,7 @@ 'bindings/v8/custom/V8ElementCustom.cpp',
[webkit-changes] [94425] trunk
Title: [94425] trunk
Revision 94425
Author commit-qu...@webkit.org
Date 2011-09-02 10:01:42 -0700 (Fri, 02 Sep 2011)
Log Message
BORDER attribute percent with the input image tag not working.
https://bugs.webkit.org/show_bug.cgi?id=66467
Patch by Mihnea Ovidenie mih...@adobe.com on 2011-09-02
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes 2 issues regarding the border attribute of an input image element.
1. The border attribute, if specified, is now taken into account and the border of the input image element is displayed.
2. If the border attribute contains percent, the border is displayed.
The value of the border attribute for input image element is now parsed according to the rules for parsing non-negative integers.
This implies that when percent is specified in the border attribute, parsing takes place and the percent is ignored.
If after parsing, the value of the border is greater than zero, the border of the input image element is displayed.
* html/HTMLElement.cpp:
(WebCore::parseBorderWidthAttribute):
(WebCore::HTMLElement::applyBorderAttribute):
* html/HTMLElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseMappedAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
LayoutTests:
Test border-width-percent was modified with tests for input image element.
Expected results for input-image-alt-test were regenerated since an image input element
takes border attribute into account.
Also, mark the test as failure for chromium.
* fast/borders/border-width-percent-expected.txt:
* fast/borders/border-width-percent.html:
* platform/chromium/test_expectations.txt:
* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/borders/border-width-percent-expected.txt
trunk/LayoutTests/fast/borders/border-width-percent.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png
trunk/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLElement.cpp
trunk/Source/WebCore/html/HTMLElement.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLObjectElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (94424 => 94425)
--- trunk/LayoutTests/ChangeLog 2011-09-02 16:59:56 UTC (rev 94424)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 17:01:42 UTC (rev 94425)
@@ -1,3 +1,21 @@
+2011-09-02 Mihnea Ovidenie mih...@adobe.com
+
+BORDER attribute percent with the input image tag not working.
+https://bugs.webkit.org/show_bug.cgi?id=66467
+
+Reviewed by Simon Fraser.
+
+Test border-width-percent was modified with tests for input image element.
+Expected results for input-image-alt-test were regenerated since an image input element
+takes border attribute into account.
+Also, mark the test as failure for chromium.
+
+* fast/borders/border-width-percent-expected.txt:
+* fast/borders/border-width-percent.html:
+* platform/chromium/test_expectations.txt:
+* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
+* platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
+
2011-09-02 Kentaro Hara hara...@google.com
Implement the Event constructor for V8.
Modified: trunk/LayoutTests/fast/borders/border-width-percent-expected.txt (94424 => 94425)
--- trunk/LayoutTests/fast/borders/border-width-percent-expected.txt 2011-09-02 16:59:56 UTC (rev 94424)
+++ trunk/LayoutTests/fast/borders/border-width-percent-expected.txt 2011-09-02 17:01:42 UTC (rev 94425)
@@ -10,6 +10,11 @@
PASS elementBorderWidth('object', ' +10%') is 10
PASS elementBorderWidth('object', 0, 'border-width: 10%') is 0
PASS elementBorderWidth('object', 0, 'border-width: -10%') is 0
+PASS inputElementBorderWidth('image', '10%') is 10
+PASS inputElementBorderWidth('image', '-10%') is 0
+PASS inputElementBorderWidth('image', ' +10%') is 10
+PASS inputElementBorderWidth('image', 0, 'border-width: 10%') is 0
+PASS inputElementBorderWidth('image', 0, 'border-width: -10%') is 0
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/borders/border-width-percent.html (94424 => 94425)
--- trunk/LayoutTests/fast/borders/border-width-percent.html 2011-09-02 16:59:56 UTC (rev 94424)
+++ trunk/LayoutTests/fast/borders/border-width-percent.html 2011-09-02 17:01:42 UTC (rev 94425)
@@ -21,6 +21,20 @@
return borderBoxWidth / 2;
}
+function inputElementBorderWidth(elementType, borderValue, style)
+{
+var inputElement =
[webkit-changes] [94426] trunk/Source/WebCore
Title: [94426] trunk/Source/WebCore
Revision 94426
Author a...@apple.com
Date 2011-09-02 10:02:59 -0700 (Fri, 02 Sep 2011)
Log Message
REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=67356
Reviewed by Darin Adler.
* platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
Don't enable old-style private browsing when using sessions - it would take precedence over
session cookie storage on Snow Leopard.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (94425 => 94426)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 17:01:42 UTC (rev 94425)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 17:02:59 UTC (rev 94426)
@@ -1,3 +1,14 @@
+2011-09-02 Alexey Proskuryakov a...@apple.com
+
+REGRESSION (r94093): Private browsing doesn't start with a clean state on Snow Leopard
+https://bugs.webkit.org/show_bug.cgi?id=67356
+
+Reviewed by Darin Adler.
+
+* platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
+Don't enable old-style private browsing when using sessions - it would take precedence over
+session cookie storage on Snow Leopard.
+
2011-09-02 Mihnea Ovidenie mih...@adobe.com
BORDER attribute percent with the input image tag not working.
Modified: trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm (94425 => 94426)
--- trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm 2011-09-02 17:01:42 UTC (rev 94425)
+++ trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm 2011-09-02 17:02:59 UTC (rev 94426)
@@ -25,6 +25,7 @@
#include config.h
#include CookieStorage.h
+#include CookieStorageCFNet.h
#import ResourceHandle.h
@@ -78,6 +79,15 @@
void setCookieStoragePrivateBrowsingEnabled(bool enabled)
{
+#if BUILDING_ON_SNOW_LEOPARD USE(CFURLSTORAGESESSIONS)
+// Don't call wkSetCookieStoragePrivateBrowsingEnabled() when cookie storage is set up via sessions.
+// That would make NSURLConnect use global private browsing cookie storage regardless of request session.
+// The global private cookie storage has different semantics - it makes new cookies non-persistent,
+// but doesn't start with a clean state.
+if (enabled currentCFHTTPCookieStorage())
+return;
+#endif
+
// FIXME: When Private Browsing is enabled, the Private Browsing Cookie Storage should be
// observed for changes, not the default Cookie Storage.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94428] trunk/Source/WebCore
Title: [94428] trunk/Source/WebCore
Revision 94428
Author a...@apple.com
Date 2011-09-02 10:09:55 -0700 (Fri, 02 Sep 2011)
Log Message
Build fix.
* platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (94427 => 94428)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 17:07:51 UTC (rev 94427)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 17:09:55 UTC (rev 94428)
@@ -1,3 +1,10 @@
+2011-09-02 Alexey Proskuryakov a...@apple.com
+
+Build fix.
+
+* platform/network/mac/CookieStorageMac.mm: (WebCore::setCookieStoragePrivateBrowsingEnabled):
+Can't use BUILDING_ON_SNOW_LEOPARD without defined() when not on Snow Leopard.
+
2011-09-02 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94421.
Modified: trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm (94427 => 94428)
--- trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm 2011-09-02 17:07:51 UTC (rev 94427)
+++ trunk/Source/WebCore/platform/network/mac/CookieStorageMac.mm 2011-09-02 17:09:55 UTC (rev 94428)
@@ -79,7 +79,7 @@
void setCookieStoragePrivateBrowsingEnabled(bool enabled)
{
-#if BUILDING_ON_SNOW_LEOPARD USE(CFURLSTORAGESESSIONS)
+#if defined(BUILDING_ON_SNOW_LEOPARD) USE(CFURLSTORAGESESSIONS)
// Don't call wkSetCookieStoragePrivateBrowsingEnabled() when cookie storage is set up via sessions.
// That would make NSURLConnect use global private browsing cookie storage regardless of request session.
// The global private cookie storage has different semantics - it makes new cookies non-persistent,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94430] trunk
Title: [94430] trunk
Revision 94430
Author ander...@apple.com
Date 2011-09-02 10:33:10 -0700 (Fri, 02 Sep 2011)
Log Message
Move private browsing test to a PluginTest subclass
https://bugs.webkit.org/show_bug.cgi?id=67498
Reviewed by Darin Adler.
Tools:
* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginGetProperty):
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
(PrivateBrowsing::PrivateBrowsing):
(PrivateBrowsing::privateBrowsingEnabled):
(PrivateBrowsing::cachedPrivateBrowsingEnabled):
(PrivateBrowsing::ScriptableObject::hasProperty):
(PrivateBrowsing::ScriptableObject::getProperty):
(PrivateBrowsing::ScriptableObject::pluginTest):
(PrivateBrowsing::NPP_New):
(PrivateBrowsing::NPP_GetValue):
(PrivateBrowsing::NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New):
(NPP_SetValue):
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* GNUmakefile.am:
LayoutTests:
Set the 'test' attribute to 'private-browsing'.
* plugins/private-browsing-mode-2.html:
* plugins/private-browsing-mode.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/plugins/private-browsing-mode-2.html
trunk/LayoutTests/plugins/private-browsing-mode.html
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.gypi
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj
trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
trunk/Tools/GNUmakefile.am
Added Paths
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (94429 => 94430)
--- trunk/LayoutTests/ChangeLog 2011-09-02 17:24:03 UTC (rev 94429)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 17:33:10 UTC (rev 94430)
@@ -1,3 +1,15 @@
+2011-09-02 Anders Carlsson ander...@apple.com
+
+Move private browsing test to a PluginTest subclass
+https://bugs.webkit.org/show_bug.cgi?id=67498
+
+Reviewed by Darin Adler.
+
+Set the 'test' attribute to 'private-browsing'.
+
+* plugins/private-browsing-mode-2.html:
+* plugins/private-browsing-mode.html:
+
2011-09-02 Alexander Pavlov apav...@chromium.org
[Chromium] Unreviewed, update expectations after r94420.
Modified: trunk/LayoutTests/plugins/private-browsing-mode-2.html (94429 => 94430)
--- trunk/LayoutTests/plugins/private-browsing-mode-2.html 2011-09-02 17:24:03 UTC (rev 94429)
+++ trunk/LayoutTests/plugins/private-browsing-mode-2.html 2011-09-02 17:33:10 UTC (rev 94430)
@@ -15,6 +15,7 @@
plugin1 = document.createElement(embed);
plugin1.type = application/x-webkit-test-netscape;
+plugin1.setAttribute('test', 'private-browsing');
document.body.appendChild(plugin1);
shouldBe(plugin1.privateBrowsingEnabled, false);
@@ -26,6 +27,7 @@
plugin2 = document.createElement(embed);
plugin2.type = application/x-webkit-test-netscape;
+plugin2.setAttribute('test', 'private-browsing');
document.body.appendChild(plugin2);
shouldBe(plugin2.privateBrowsingEnabled, true);
Modified: trunk/LayoutTests/plugins/private-browsing-mode.html (94429 => 94430)
--- trunk/LayoutTests/plugins/private-browsing-mode.html 2011-09-02 17:24:03 UTC (rev 94429)
+++ trunk/LayoutTests/plugins/private-browsing-mode.html 2011-09-02 17:33:10 UTC (rev 94430)
@@ -15,6 +15,7 @@
plugin1 = document.createElement(embed);
plugin1.type = application/x-webkit-test-netscape;
+plugin1.setAttribute('test', 'private-browsing');
document.body.appendChild(plugin1);
shouldBe(plugin1.privateBrowsingEnabled, false);
@@ -28,6 +29,7 @@
plugin2 = document.createElement(embed);
plugin2.type = application/x-webkit-test-netscape;
+plugin2.setAttribute('test', 'private-browsing');
document.body.appendChild(plugin2);
shouldBe(plugin2.privateBrowsingEnabled, true);
Modified: trunk/Tools/ChangeLog (94429 => 94430)
--- trunk/Tools/ChangeLog 2011-09-02 17:24:03 UTC (rev 94429)
+++ trunk/Tools/ChangeLog 2011-09-02 17:33:10 UTC (rev 94430)
@@ -1,3 +1,35 @@
+2011-09-02 Anders Carlsson ander...@apple.com
+
+Move private browsing test to a PluginTest subclass
+
[webkit-changes] [94431] trunk/Source
Title: [94431] trunk/Source Revision 94431 Author e...@google.com Date 2011-09-02 10:36:00 -0700 (Fri, 02 Sep 2011) Log Message [chromium] Remove LayerRendererChromium references from the LayerChromium tree https://bugs.webkit.org/show_bug.cgi?id=66430 Reviewed by James Robinson. Source/WebCore: Covered by existing tests. Replace references to LayerRendererChromium in the LayerChromium tree with references to LayerTreeHost. The LayerRendererChromium property is no longer synced and instead is set recursively on the CCLayerImpl tree during commit. WebGLLayerChromium's paintRenderedResultsToCanvas function is temporarily turned off for threaded compositing because it needs access to the compositor context. Previously, changing the layer renderer on a layer called cleanup resources on that layer. Now, call that explicitly clean up all resources explicitly from the proxy when the layer renderer gets created. This cleans up all of the ManagedTexture objects which may be hanging onto stale GraphicsContext3D pointers. * platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::cleanupResourcesRecursive): (WebCore::LayerChromium::setLayerTreeHost): (WebCore::LayerChromium::pushPropertiesTo): * platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::layerTreeHost): * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::paintLayerContents): * platform/graphics/chromium/RenderSurfaceChromium.cpp: * platform/graphics/chromium/RenderSurfaceChromium.h: * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::TiledLayerChromium): (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption): (WebCore::TiledLayerChromium::setLayerTreeHost): (WebCore::TiledLayerChromium::textureManager): * platform/graphics/chromium/TiledLayerChromium.h: * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::cleanupResources): (WebCore::VideoLayerChromium::setLayerTreeHost): (WebCore::VideoLayerChromium::reserveTextures): * platform/graphics/chromium/VideoLayerChromium.h: * platform/graphics/chromium/WebGLLayerChromium.cpp: (WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas): (WebCore::WebGLLayerChromium::setTextureUpdated): (WebCore::WebGLLayerChromium::layerRendererContext): * platform/graphics/chromium/WebGLLayerChromium.h: * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::setLayerRendererRecursive): * platform/graphics/chromium/cc/CCLayerImpl.h: * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::commitTo): (WebCore::CCLayerTreeHost::didRecreateGraphicsContext): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::initializeLayerRenderer): Source/WebKit/chromium: Change references to LayerRendererChromium to CCLayerTreeHost. * src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94430 => 94431) --- trunk/Source/WebCore/ChangeLog 2011-09-02 17:33:10 UTC (rev 94430) +++ trunk/Source/WebCore/ChangeLog 2011-09-02 17:36:00 UTC (rev 94431) @@ -1,3 +1,64 @@ +2011-09-02 Adrienne Walker e...@google.com + +[chromium] Remove LayerRendererChromium references from the LayerChromium tree +https://bugs.webkit.org/show_bug.cgi?id=66430 + +Reviewed by James Robinson. + +Covered by existing tests. + +Replace references to LayerRendererChromium in the LayerChromium tree +with references to LayerTreeHost. The LayerRendererChromium property +is no longer synced and instead is set recursively on the CCLayerImpl +
[webkit-changes] [94432] trunk/Tools
Title: [94432] trunk/Tools
Revision 94432
Author ander...@apple.com
Date 2011-09-02 10:41:08 -0700 (Fri, 02 Sep 2011)
Log Message
Build fix.
* DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
(PrivateBrowsing::ScriptableObject::pluginTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp
Diff
Modified: trunk/Tools/ChangeLog (94431 => 94432)
--- trunk/Tools/ChangeLog 2011-09-02 17:36:00 UTC (rev 94431)
+++ trunk/Tools/ChangeLog 2011-09-02 17:41:08 UTC (rev 94432)
@@ -1,5 +1,12 @@
2011-09-02 Anders Carlsson ander...@apple.com
+Build fix.
+
+* DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
+(PrivateBrowsing::ScriptableObject::pluginTest):
+
+2011-09-02 Anders Carlsson ander...@apple.com
+
Move private browsing test to a PluginTest subclass
https://bugs.webkit.org/show_bug.cgi?id=67498
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp (94431 => 94432)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp 2011-09-02 17:36:00 UTC (rev 94431)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp 2011-09-02 17:41:08 UTC (rev 94432)
@@ -70,7 +70,7 @@
}
private:
-PrivateBrowsing* pluginTest() const { return static_castPrivateBrowsing*(Object::pluginTest()); }
+PrivateBrowsing* pluginTest() const { return static_castPrivateBrowsing*(ObjectScriptableObject::pluginTest()); }
};
virtual NPError NPP_New(NPMIMEType pluginType, uint16_t mode, int16_t argc, char* argn[], char* argv[], NPSavedData *saved)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94435] trunk
Title: [94435] trunk
Revision 94435
Author ander...@apple.com
Date 2011-09-02 11:17:26 -0700 (Fri, 02 Sep 2011)
Log Message
The private browsing state isn't saved when it changes
https://bugs.webkit.org/show_bug.cgi?id=67508
Reviewed by Sam Weinig.
Source/WebKit2:
Store the new private browsing state so subsequent queries for it
will return the right value.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::privateBrowsingStateChanged):
LayoutTests:
Unskip private browsing plug-in tests, since WebKitTestRunner
now has layoutTestController.setPopupBlockingEnabled.
* platform/wk2/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/Skipped
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (94434 => 94435)
--- trunk/LayoutTests/ChangeLog 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1,3 +1,15 @@
+2011-09-02 Anders Carlsson ander...@apple.com
+
+The private browsing state isn't saved when it changes
+https://bugs.webkit.org/show_bug.cgi?id=67508
+
+Reviewed by Sam Weinig.
+
+Unskip private browsing plug-in tests, since WebKitTestRunner
+now has layoutTestController.setPopupBlockingEnabled.
+
+* platform/wk2/Skipped:
+
2011-09-01 Cary Clark carycl...@google.com
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Modified: trunk/LayoutTests/platform/wk2/Skipped (94434 => 94435)
--- trunk/LayoutTests/platform/wk2/Skipped 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/LayoutTests/platform/wk2/Skipped 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1568,11 +1568,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=59192
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html
-# WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
-# http://webkit.org/b/59857
-plugins/private-browsing-mode.html
-plugins/private-browsing-mode-2.html
-
# WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
# https://bugs.webkit.org/show_bug.cgi?id=63458
fast/events/popup-blocked-from-untrusted-click-event-on-anchor.html
@@ -1591,7 +1586,7 @@
fast/events/popup-blocking-timers.html
plugins/plugin-initiate-popup-window.html
-# WebKitTestRunner needs an implemenation of allowRoundingHacks
+# WebKitTestRunner needs an implementation of allowRoundingHacks
# http://webkit.org/b/63477
platform/mac/fast/text/rounding-hacks.html
platform/mac/fast/text/rounding-hacks-expansion.html
Modified: trunk/Source/WebKit2/ChangeLog (94434 => 94435)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 18:17:26 UTC (rev 94435)
@@ -1,3 +1,16 @@
+2011-09-02 Anders Carlsson ander...@apple.com
+
+The private browsing state isn't saved when it changes
+https://bugs.webkit.org/show_bug.cgi?id=67508
+
+Reviewed by Sam Weinig.
+
+Store the new private browsing state so subsequent queries for it
+will return the right value.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::privateBrowsingStateChanged):
+
2011-09-02 Ravi Phaneendra Kasibhatla ravi.kasibha...@motorola.com
[WK2] Anchor elements doesn't get focus on TAB key press.
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (94434 => 94435)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-09-02 18:02:44 UTC (rev 94434)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-09-02 18:17:26 UTC (rev 94435)
@@ -573,6 +573,8 @@
void PluginControllerProxy::privateBrowsingStateChanged(bool isPrivateBrowsingEnabled)
{
+m_isPrivateBrowsingEnabled = isPrivateBrowsingEnabled;
+
m_plugin-privateBrowsingStateChanged(isPrivateBrowsingEnabled);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94436] trunk/LayoutTests
Title: [94436] trunk/LayoutTests
Revision 94436
Author a...@apple.com
Date 2011-09-02 11:35:18 -0700 (Fri, 02 Sep 2011)
Log Message
Flaky Test: http/tests/appcache/origin-usage.html
https://bugs.webkit.org/show_bug.cgi?id=60928
Reviewed by Joseph Pecoraro.
Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.
* http/tests/appcache/origin-usage-expected.txt:
* http/tests/appcache/origin-usage.html:
Increase the range for success. It's OK because data is added in larger chunks anyway.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/appcache/origin-usage-expected.txt
trunk/LayoutTests/http/tests/appcache/origin-usage.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94435 => 94436)
--- trunk/LayoutTests/ChangeLog 2011-09-02 18:17:26 UTC (rev 94435)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 18:35:18 UTC (rev 94436)
@@ -1,3 +1,16 @@
+2011-09-02 Alexey Proskuryakov a...@apple.com
+
+Flaky Test: http/tests/appcache/origin-usage.html
+https://bugs.webkit.org/show_bug.cgi?id=60928
+
+Reviewed by Joseph Pecoraro.
+
+Not sure if it was actually flaky anywhere, but it's failing for me on Lion consistently.
+
+* http/tests/appcache/origin-usage-expected.txt:
+* http/tests/appcache/origin-usage.html:
+Increase the range for success. It's OK because data is added in larger chunks anyway.
+
2011-09-02 Anders Carlsson ander...@apple.com
The private browsing state isn't saved when it changes
Modified: trunk/LayoutTests/http/tests/appcache/origin-usage-expected.txt (94435 => 94436)
--- trunk/LayoutTests/http/tests/appcache/origin-usage-expected.txt 2011-09-02 18:17:26 UTC (rev 94435)
+++ trunk/LayoutTests/http/tests/appcache/origin-usage-expected.txt 2011-09-02 18:35:18 UTC (rev 94436)
@@ -4,7 +4,7 @@
PASS - cached iframe-1
Usage for http://127.0.0.1:8000 after first frame is between 15000 and 16000 bytes: true
PASS - cached iframe-2
-Usage for http://127.0.0.1:8000 after second frame is between 3 and 31000 bytes: true
+Usage for http://127.0.0.1:8000 after second frame is between 3 and 32000 bytes: true
Removing Application Cache for http://127.0.0.1:8000
Usage for http://127.0.0.1:8000: 0
Modified: trunk/LayoutTests/http/tests/appcache/origin-usage.html (94435 => 94436)
--- trunk/LayoutTests/http/tests/appcache/origin-usage.html 2011-09-02 18:17:26 UTC (rev 94435)
+++ trunk/LayoutTests/http/tests/appcache/origin-usage.html 2011-09-02 18:35:18 UTC (rev 94436)
@@ -52,7 +52,7 @@
addIFrameWithContinuation(resources/origin-usage-iframe-2.html, function(event) {
log(event.data);
var usage = layoutTestController.applicationCacheDiskUsageForOrigin(drtURL);
-log(Usage for + drtURL + after second frame is between 3 and 31000 bytes: + ((usage 3) (usage 31000)));
+log(Usage for + drtURL + after second frame is between 3 and 32000 bytes: + ((usage 3) (usage 32000)));
log(Removing Application Cache for + drtURL);
layoutTestController.clearApplicationCacheForOrigin(drtURL);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94437] trunk/Tools
Title: [94437] trunk/Tools
Revision 94437
Author bda...@apple.com
Date 2011-09-02 11:55:16 -0700 (Fri, 02 Sep 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=67451
Add a test for going back to a cached page after changing the device scale factor
Reviewed by Adam Roben.
New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
(TestWebKitAPI::DeviceScaleFactorOnBack::url):
(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
(TestWebKitAPI::TEST_F):
Added new function to WebKitAgnosticTest to goBack. Separated
waitForLoadToFinish() into its own function (instead of being a part of
loadAndWaitUntilFinished()) so that it can be called from goBack as
well. Also added initializeView() so we can set the cache model.
* TestWebKitAPI/mac/WebKitAgnosticTest.h:
(TestWebKitAPI::WebKitAgnosticTest::initializeView):
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
(TestWebKitAPI::WebKitAgnosticTest::loadURL):
(TestWebKitAPI::WebKitAgnosticTest::goBack):
(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h
trunk/Tools/TestWebKitAPI/mac/WebKitAgnosticTest.mm
Added Paths
trunk/Tools/TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm
Diff
Modified: trunk/Tools/ChangeLog (94436 => 94437)
--- trunk/Tools/ChangeLog 2011-09-02 18:35:18 UTC (rev 94436)
+++ trunk/Tools/ChangeLog 2011-09-02 18:55:16 UTC (rev 94437)
@@ -1,3 +1,34 @@
+2011-09-01 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67451
+Add a test for going back to a cached page after changing the device scale factor
+
+Reviewed by Adam Roben.
+
+New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
+(TestWebKitAPI::DeviceScaleFactorOnBack::url):
+(TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
+(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
+(TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
+(TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
+(TestWebKitAPI::TEST_F):
+
+Added new function to WebKitAgnosticTest to goBack. Separated
+waitForLoadToFinish() into its own function (instead of being a part of
+loadAndWaitUntilFinished()) so that it can be called from goBack as
+well. Also added initializeView() so we can set the cache model.
+* TestWebKitAPI/mac/WebKitAgnosticTest.h:
+(TestWebKitAPI::WebKitAgnosticTest::initializeView):
+* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
+(TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
+(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
+(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
+(TestWebKitAPI::WebKitAgnosticTest::loadURL):
+(TestWebKitAPI::WebKitAgnosticTest::goBack):
+(TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
+
2011-09-02 Anders Carlsson ander...@apple.com
Build fix.
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (94436 => 94437)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2011-09-02 18:35:18 UTC (rev 94436)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2011-09-02 18:55:16 UTC (rev 94437)
@@ -23,6 +23,7 @@
37DC6791140D7D7600ABCCDB /* DOMRangeOfString.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 37DC678F140D7D3A00ABCCDB /* DOMRangeOfString.html */; };
4BFDFFA71314776C0061F24B /* HitTestResultNodeHandle_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4BFDFFA61314776C0061F24B /* HitTestResultNodeHandle_Bundle.cpp */; };
4BFDFFA913140061F24B /* HitTestResultNodeHandle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4BFDFFA813140061F24B /* HitTestResultNodeHandle.cpp */; };
+ 939BA91714103412001A01BD /* DeviceScaleFactorOnBack.mm in Sources */ = {isa = PBXBuildFile; fileRef = 939BA91614103412001A01BD /* DeviceScaleFactorOnBack.mm */; };
A7A966DB140ECCC8005EF9B4 /* CheckedArithmeticOperations.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A7A966DA140ECCC8005EF9B4 /* CheckedArithmeticOperations.cpp */; };
BC131885117114B600B69727 /* PlatformUtilitiesMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC131884117114B600B69727 /*
[webkit-changes] [94438] trunk/Source/WebKit2
Title: [94438] trunk/Source/WebKit2 Revision 94438 Author ander...@apple.com Date 2011-09-02 12:19:41 -0700 (Fri, 02 Sep 2011) Log Message Assertion/crash when running netscape-plugin-property-access-exception.html test https://bugs.webkit.org/show_bug.cgi?id=67517 Reviewed by Adam Roben. Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty, but doesn't set the result NPVariant to anything. * Shared/Plugins/NPObjectMessageReceiver.cpp: (WebKit::NPObjectMessageReceiver::getProperty): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (94437 => 94438) --- trunk/Source/WebKit2/ChangeLog 2011-09-02 18:55:16 UTC (rev 94437) +++ trunk/Source/WebKit2/ChangeLog 2011-09-02 19:19:41 UTC (rev 94438) @@ -1,5 +1,18 @@ 2011-09-02 Anders Carlsson ander...@apple.com +Assertion/crash when running netscape-plugin-property-access-exception.html test +https://bugs.webkit.org/show_bug.cgi?id=67517 + +Reviewed by Adam Roben. + +Make sure to initialize the NPVariant in case the plug-in returns true from NP_GetProperty, +but doesn't set the result NPVariant to anything. + +* Shared/Plugins/NPObjectMessageReceiver.cpp: +(WebKit::NPObjectMessageReceiver::getProperty): + +2011-09-02 Anders Carlsson ander...@apple.com + The private browsing state isn't saved when it changes https://bugs.webkit.org/show_bug.cgi?id=67508 Modified: trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp (94437 => 94438) --- trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp 2011-09-02 18:55:16 UTC (rev 94437) +++ trunk/Source/WebKit2/Shared/Plugins/NPObjectMessageReceiver.cpp 2011-09-02 19:19:41 UTC (rev 94438) @@ -145,6 +145,8 @@ } NPVariant result; +VOID_TO_NPVARIANT(result); + returnValue = m_npObject-_class-getProperty(m_npObject, propertyNameData.createNPIdentifier(), result); if (!returnValue) return; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94439] trunk/Source/WebKit2
Title: [94439] trunk/Source/WebKit2 Revision 94439 Author ander...@apple.com Date 2011-09-02 12:27:04 -0700 (Fri, 02 Sep 2011) Log Message Remove plug-in paths from web process sandbox https://bugs.webkit.org/show_bug.cgi?id=67518 Reviewed by Adam Roben. Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile. * WebProcess/com.apple.WebProcess.sb: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb Diff Modified: trunk/Source/WebKit2/ChangeLog (94438 => 94439) --- trunk/Source/WebKit2/ChangeLog 2011-09-02 19:19:41 UTC (rev 94438) +++ trunk/Source/WebKit2/ChangeLog 2011-09-02 19:27:04 UTC (rev 94439) @@ -1,5 +1,16 @@ 2011-09-02 Anders Carlsson ander...@apple.com +Remove plug-in paths from web process sandbox +https://bugs.webkit.org/show_bug.cgi?id=67518 + +Reviewed by Adam Roben. + +Plug-ins are never accessed from the web process, so remove plug-in paths from the sandbox profile. + +* WebProcess/com.apple.WebProcess.sb: + +2011-09-02 Anders Carlsson ander...@apple.com + Assertion/crash when running netscape-plugin-property-access-exception.html test https://bugs.webkit.org/show_bug.cgi?id=67517 Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb (94438 => 94439) --- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb 2011-09-02 19:19:41 UTC (rev 94438) +++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb 2011-09-02 19:27:04 UTC (rev 94439) @@ -29,10 +29,6 @@ (subpath /private/var/db/DetachedSignatures) (regex #^/private/etc/(hosts|group|passwd)$) - ;; Plugins - (subpath /Library/Internet Plug-Ins) - (home-subpath /Library/Internet Plug-Ins) - ;; System and user preferences (literal /Library/Preferences/.GlobalPreferences.plist) (literal /Library/Preferences/com.apple.crypto.plist) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94441] trunk/Tools
Title: [94441] trunk/Tools Revision 94441 Author aba...@webkit.org Date 2011-09-02 12:48:43 -0700 (Fri, 02 Sep 2011) Log Message Enable testing on mac-ews https://bugs.webkit.org/show_bug.cgi?id=67505 Reviewed by Eric Seidel. This patch enables testing on the Mac EWS, which should help contributors not turn the Mac bots red. * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py Diff Modified: trunk/Tools/ChangeLog (94440 => 94441) --- trunk/Tools/ChangeLog 2011-09-02 19:40:11 UTC (rev 94440) +++ trunk/Tools/ChangeLog 2011-09-02 19:48:43 UTC (rev 94441) @@ -1,3 +1,15 @@ +2011-09-02 Adam Barth aba...@webkit.org + +Enable testing on mac-ews +https://bugs.webkit.org/show_bug.cgi?id=67505 + +Reviewed by Eric Seidel. + +This patch enables testing on the Mac EWS, which should help +contributors not turn the Mac bots red. + +* Scripts/webkitpy/tool/commands/earlywarningsystem.py: + 2011-09-01 Beth Dakin bda...@apple.com https://bugs.webkit.org/show_bug.cgi?id=67451 Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (94440 => 94441) --- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2011-09-02 19:40:11 UTC (rev 94440) +++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py 2011-09-02 19:48:43 UTC (rev 94441) @@ -207,3 +207,4 @@ class MacEWS(AbstractCommitterOnlyEWS): name = mac-ews port_name = mac +_run_tests = True ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94442] trunk/Source/WebKit/chromium
Title: [94442] trunk/Source/WebKit/chromium
Revision 94442
Author commit-qu...@webkit.org
Date 2011-09-02 12:55:47 -0700 (Fri, 02 Sep 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-02
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94441 => 94442)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-02 19:48:43 UTC (rev 94441)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-02 19:55:47 UTC (rev 94442)
@@ -1,3 +1,9 @@
+2011-09-02 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-09-02 Adrienne Walker e...@google.com
[chromium] Remove LayerRendererChromium references from the LayerChromium tree
Modified: trunk/Source/WebKit/chromium/DEPS (94441 => 94442)
--- trunk/Source/WebKit/chromium/DEPS 2011-09-02 19:48:43 UTC (rev 94441)
+++ trunk/Source/WebKit/chromium/DEPS 2011-09-02 19:55:47 UTC (rev 94442)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '99030'
+ 'chromium_rev': '99393'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94443] trunk/LayoutTests
Title: [94443] trunk/LayoutTests Revision 94443 Author jam...@google.com Date 2011-09-02 13:25:29 -0700 (Fri, 02 Sep 2011) Log Message [chromium] Update expectations for tests with animations and reflections * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94442 => 94443) --- trunk/LayoutTests/ChangeLog 2011-09-02 19:55:47 UTC (rev 94442) +++ trunk/LayoutTests/ChangeLog 2011-09-02 20:25:29 UTC (rev 94443) @@ -1,5 +1,11 @@ 2011-09-02 James Robinson jam...@chromium.org +[chromium] Update expectations for tests with animations and reflections + +* platform/chromium/test_expectations.txt: + +2011-09-02 James Robinson jam...@chromium.org + [chromium] Update some chromium gpu baselines * platform/chromium-gpu-cg-mac/compositing/images/content-image-change-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94442 => 94443) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 19:55:47 UTC (rev 94442) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-02 20:25:29 UTC (rev 94443) @@ -2582,9 +2582,8 @@ BUGWK47949 LINUX WIN GPU : compositing/reflections/reflection-opacity.html = IMAGE+TEXT BUGWK47949 MAC GPU : compositing/reflections/reflection-opacity.html = IMAGE -// Flaky in debug mode because this is a poorly written test -BUGWK54306 GPU DEBUG : compositing/reflections/animation-inside-reflection.html = PASS IMAGE+TEXT -// Flaky everywhere for the same reason +// Flaky because these are a poorly written tests. Need dino's new animation API +BUGWK54306 GPU : compositing/reflections/animation-inside-reflection.html = PASS IMAGE IMAGE+TEXT BUGWK54306 GPU : compositing/reflections/nested-reflection-animated.html = PASS IMAGE // These tests are too slow with our MESA backend. We can re-enable when we have ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94444] trunk/Tools
Title: [9] trunk/Tools Revision 9 Author da...@apple.com Date 2011-09-02 13:33:34 -0700 (Fri, 02 Sep 2011) Log Message Added Subversion ignore for .pyc generated files. * Scripts/webkitpy/layout_tests/models: Added property svn:ignore. * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore. * Scripts/webkitpy/tool/servers: Added property svn:ignore. Modified Paths trunk/Tools/ChangeLog Property Changed trunk/Tools/Scripts/webkitpy/layout_tests/models/ trunk/Tools/Scripts/webkitpy/layout_tests/servers/ trunk/Tools/Scripts/webkitpy/tool/servers/ Diff Modified: trunk/Tools/ChangeLog (94443 => 9) --- trunk/Tools/ChangeLog 2011-09-02 20:25:29 UTC (rev 94443) +++ trunk/Tools/ChangeLog 2011-09-02 20:33:34 UTC (rev 9) @@ -1,3 +1,11 @@ +2011-09-02 Darin Adler da...@apple.com + +Added Subversion ignore for .pyc generated files. + +* Scripts/webkitpy/layout_tests/models: Added property svn:ignore. +* Scripts/webkitpy/layout_tests/servers: Added property svn:ignore. +* Scripts/webkitpy/tool/servers: Added property svn:ignore. + 2011-09-02 Adam Barth aba...@webkit.org Enable testing on mac-ews Property changes: trunk/Tools/Scripts/webkitpy/layout_tests/models Added: svn:ignore Property changes: trunk/Tools/Scripts/webkitpy/layout_tests/servers Added: svn:ignore Property changes: trunk/Tools/Scripts/webkitpy/tool/servers Added: svn:ignore ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94445] trunk/Source/JavaScriptCore
Title: [94445] trunk/Source/_javascript_Core Revision 94445 Author oli...@apple.com Date 2011-09-02 13:41:59 -0700 (Fri, 02 Sep 2011) Log Message Use bump allocator for initial property storage https://bugs.webkit.org/show_bug.cgi?id=67494 Reviewed by Gavin Barraclough. Switch to a bump allocator for the initial out of line property storage. This gives us slightly faster allocation for short lived objects that need out of line storage at the cost of an additional memcpy when the object survives a GC pass. No performance impact. * _javascript_Core.exp: * heap/Heap.cpp: (JSC::Heap::collect): * heap/Heap.h: (JSC::Heap::allocatePropertyStorage): (JSC::Heap::inPropertyStorageNursary): * heap/NewSpace.cpp: (JSC::NewSpace::NewSpace): * heap/NewSpace.h: (JSC::NewSpace::resetPropertyStorageNursary): (JSC::NewSpace::allocatePropertyStorage): (JSC::NewSpace::inPropertyStorageNursary): * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/JSObject.cpp: (JSC::JSObject::allocatePropertyStorage): * runtime/JSObject.h: (JSC::JSObject::~JSObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSObject::transitionTo): (JSC::JSObject::visitChildrenDirect): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/_javascript_Core/heap/NewSpace.cpp trunk/Source/_javascript_Core/heap/NewSpace.h trunk/Source/_javascript_Core/jit/JITStubs.cpp trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (9 => 94445) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 20:33:34 UTC (rev 9) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 20:41:59 UTC (rev 94445) @@ -1,3 +1,42 @@ +2011-09-02 Oliver Hunt oli...@apple.com + +Use bump allocator for initial property storage +https://bugs.webkit.org/show_bug.cgi?id=67494 + +Reviewed by Gavin Barraclough. + +Switch to a bump allocator for the initial out of line +property storage. This gives us slightly faster allocation +for short lived objects that need out of line storage at +the cost of an additional memcpy when the object survives +a GC pass. + +No performance impact. + +* _javascript_Core.exp: +* heap/Heap.cpp: +(JSC::Heap::collect): +* heap/Heap.h: +(JSC::Heap::allocatePropertyStorage): +(JSC::Heap::inPropertyStorageNursary): +* heap/NewSpace.cpp: +(JSC::NewSpace::NewSpace): +* heap/NewSpace.h: +(JSC::NewSpace::resetPropertyStorageNursary): +(JSC::NewSpace::allocatePropertyStorage): +(JSC::NewSpace::inPropertyStorageNursary): +* jit/JITStubs.cpp: +(JSC::DEFINE_STUB_FUNCTION): +* runtime/JSObject.cpp: +(JSC::JSObject::allocatePropertyStorage): +* runtime/JSObject.h: +(JSC::JSObject::~JSObject): +(JSC::JSObject::putDirectInternal): +(JSC::JSObject::putDirectWithoutTransition): +(JSC::JSObject::putDirectFunctionWithoutTransition): +(JSC::JSObject::transitionTo): +(JSC::JSObject::visitChildrenDirect): + 2011-09-01 Mark Rowe mr...@apple.com Fix the build. Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (9 => 94445) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-02 20:33:34 UTC (rev 9) +++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-02 20:41:59 UTC (rev 94445) @@ -216,6 +216,7 @@ __ZN3JSC22globalMemoryStatisticsEv __ZN3JSC22objectConstructorTableE __ZN3JSC23AbstractSamplingCounter4dumpEv +__ZN3JSC23AbstractSamplingCounter30s_abstractSamplingCounterChainE __ZN3JSC23objectProtoFuncToStringEPNS_9ExecStateE __ZN3JSC23setUpStaticFunctionSlotEPNS_9ExecStateEPKNS_9HashEntryEPNS_8JSObjectERKNS_10IdentifierERNS_12PropertySlotE __ZN3JSC24DynamicGlobalObjectScopeC1ERNS_12JSGlobalDataEPNS_14JSGlobalObjectE @@ -322,7 +323,7 @@ __ZN3JSC8JSObject19getOwnPropertyNamesEPNS_9ExecStateERNS_17PropertyNameArrayENS_15EnumerationModeE __ZN3JSC8JSObject21getPropertyDescriptorEPNS_9ExecStateERKNS_10IdentifierERNS_18PropertyDescriptorE __ZN3JSC8JSObject22fillGetterPropertySlotERNS_12PropertySlotEPNS_16WriteBarrierBaseINS_7UnknownEEE -__ZN3JSC8JSObject23allocatePropertyStorageEmm +__ZN3JSC8JSObject23allocatePropertyStorageERNS_12JSGlobalDataEmm __ZN3JSC8JSObject24getOwnPropertyDescriptorEPNS_9ExecStateERKNS_10IdentifierERNS_18PropertyDescriptorE __ZN3JSC8JSObject3putEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueERNS_15PutPropertySlotE __ZN3JSC8JSObject3putEPNS_9ExecStateEjNS_7JSValueE Modified:
[webkit-changes] [94446] trunk/LayoutTests
Title: [94446] trunk/LayoutTests
Revision 94446
Author jer.no...@apple.com
Date 2011-09-02 13:48:32 -0700 (Fri, 02 Sep 2011)
Log Message
Some media layout tests fail because of ambiguous ordering of canplaythough event.
https://bugs.webkit.org/show_bug.cgi?id=67520
Reviewed by Eric Carlson.
The canplaythrough event can occur either before or after the playing event, causing layout tests
to fail for certain media engines (AVFoundation). The canplaythrough event check isn't adding anything
of value which isn't covered in other layout tests, so remove this event check.
* media/audio-play-event-expected.txt:
* media/audio-play-event.html:
* media/video-play-empty-events-expected.txt:
* media/video-play-empty-events.html:
* media/video-timeupdate-during-playback-expected.txt:
* media/video-timeupdate-during-playback.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/audio-play-event-expected.txt
trunk/LayoutTests/media/audio-play-event.html
trunk/LayoutTests/media/video-play-empty-events-expected.txt
trunk/LayoutTests/media/video-play-empty-events.html
trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt
trunk/LayoutTests/media/video-timeupdate-during-playback.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94445 => 94446)
--- trunk/LayoutTests/ChangeLog 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 20:48:32 UTC (rev 94446)
@@ -1,3 +1,21 @@
+2011-09-02 Jer Noble jer.no...@apple.com
+
+Some media layout tests fail because of ambiguous ordering of canplaythough event.
+https://bugs.webkit.org/show_bug.cgi?id=67520
+
+Reviewed by Eric Carlson.
+
+The canplaythrough event can occur either before or after the playing event, causing layout tests
+to fail for certain media engines (AVFoundation). The canplaythrough event check isn't adding anything
+of value which isn't covered in other layout tests, so remove this event check.
+
+* media/audio-play-event-expected.txt:
+* media/audio-play-event.html:
+* media/video-play-empty-events-expected.txt:
+* media/video-play-empty-events.html:
+* media/video-timeupdate-during-playback-expected.txt:
+* media/video-timeupdate-during-playback.html:
+
2011-09-02 James Robinson jam...@chromium.org
[chromium] Update expectations for tests with animations and reflections
Modified: trunk/LayoutTests/media/audio-play-event-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/audio-play-event-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/audio-play-event-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -6,7 +6,6 @@
EVENT(play)
EVENT(loadedmetadata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
END OF TEST
Modified: trunk/LayoutTests/media/audio-play-event.html (94445 => 94446)
--- trunk/LayoutTests/media/audio-play-event.html 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/audio-play-event.html 2011-09-02 20:48:32 UTC (rev 94446)
@@ -11,7 +11,6 @@
waitForEvent('error');
waitForEvent('loadedmetadata');
waitForEvent('canplay');
-waitForEvent('canplaythrough');
waitForEvent('play');
waitForEvent('playing', function() { endTest(); });
run(mediaElement.src = "" 'content/test'));
Modified: trunk/LayoutTests/media/video-play-empty-events-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/video-play-empty-events-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-play-empty-events-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -10,7 +10,6 @@
EVENT(loadedmetadata)
EVENT(loadeddata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
EXPECTED (video.paused == 'false') OK
END OF TEST
Modified: trunk/LayoutTests/media/video-play-empty-events.html (94445 => 94446)
--- trunk/LayoutTests/media/video-play-empty-events.html 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-play-empty-events.html 2011-09-02 20:48:32 UTC (rev 94446)
@@ -16,7 +16,6 @@
waitForEvent(loadedmetadata);
waitForEvent(loadeddata);
waitForEvent(canplay);
-waitForEvent(canplaythrough);
waitForEvent(play);
waitForEvent('playing', function () { testExpected(video.paused, false); endTest(); } );
Modified: trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt (94445 => 94446)
--- trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt 2011-09-02 20:41:59 UTC (rev 94445)
+++ trunk/LayoutTests/media/video-timeupdate-during-playback-expected.txt 2011-09-02 20:48:32 UTC (rev 94446)
@@ -9,7 +9,6 @@
EVENT(loadedmetadata)
EVENT(loadeddata)
EVENT(canplay)
-EVENT(canplaythrough)
EVENT(playing)
RUN(video.pause())
Modified:
[webkit-changes] [94447] branches/safari-534.51-branch/Source
Title: [94447] branches/safari-534.51-branch/Source Revision 94447 Author lforsch...@apple.com Date 2011-09-02 13:49:55 -0700 (Fri, 02 Sep 2011) Log Message Versioning. Modified Paths branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig (94446 => 94447) --- branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-09-02 20:48:32 UTC (rev 94446) +++ branches/safari-534.51-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-09-02 20:49:55 UTC (rev 94447) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 20; +TINY_VERSION = 21; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (94446 => 94447) --- branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-09-02 20:48:32 UTC (rev 94446) +++ branches/safari-534.51-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-09-02 20:49:55 UTC (rev 94447) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 20; +TINY_VERSION = 21; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig (94446 => 94447) --- branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-09-02 20:48:32 UTC (rev 94446) +++ branches/safari-534.51-branch/Source/WebCore/Configurations/Version.xcconfig 2011-09-02 20:49:55 UTC (rev 94447) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 20; +TINY_VERSION = 21; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig (94446 => 94447) --- branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-09-02 20:48:32 UTC (rev 94446) +++ branches/safari-534.51-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-09-02 20:49:55 UTC (rev 94447) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 20; +TINY_VERSION = 21; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig (94446 => 94447) --- branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-09-02 20:48:32 UTC (rev 94446) +++ branches/safari-534.51-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-09-02 20:49:55 UTC (rev 94447) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 51; -TINY_VERSION = 20; +TINY_VERSION = 21; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94449] trunk/Source/JavaScriptCore
Title: [94449] trunk/Source/_javascript_Core
Revision 94449
Author fpi...@apple.com
Date 2011-09-02 14:16:25 -0700 (Fri, 02 Sep 2011)
Log Message
DFG graph has no way of distinguishing or reconciling between static
and dynamic predictions
https://bugs.webkit.org/show_bug.cgi?id=67343
Reviewed by Gavin Barraclough.
PredictedType now stores the source of the prediction. Merging predictions,
which was previously done with a bitwise or, is now done via the
mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
functions, which correctly handle combinations of static and dynamic.
This is performance-neutral, since all predictions are currently static and
so the code has no visible effects.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::staticallyPredictArray):
(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
* dfg/DFGNode.h:
(JSC::DFG::isArrayPrediction):
(JSC::DFG::isInt32Prediction):
(JSC::DFG::isDoublePrediction):
(JSC::DFG::isDynamicPrediction):
(JSC::DFG::mergePredictions):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::predict):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGNode.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94448 => 94449)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 21:08:27 UTC (rev 94448)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 21:16:25 UTC (rev 94449)
@@ -1,3 +1,37 @@
+2011-09-02 Filip Pizlo fpi...@apple.com
+
+DFG graph has no way of distinguishing or reconciling between static
+and dynamic predictions
+https://bugs.webkit.org/show_bug.cgi?id=67343
+
+Reviewed by Gavin Barraclough.
+
+PredictedType now stores the source of the prediction. Merging predictions,
+which was previously done with a bitwise or, is now done via the
+mergePredictions (equivalent to |) and mergePrediction (equivalent to |=)
+functions, which correctly handle combinations of static and dynamic.
+
+This is performance-neutral, since all predictions are currently static and
+so the code has no visible effects.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::set):
+(JSC::DFG::ByteCodeParser::staticallyPredictArray):
+(JSC::DFG::ByteCodeParser::staticallyPredictInt32):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGGraph.h:
+(JSC::DFG::Graph::predict):
+(JSC::DFG::Graph::predictGlobalVar):
+* dfg/DFGNode.h:
+(JSC::DFG::isArrayPrediction):
+(JSC::DFG::isInt32Prediction):
+(JSC::DFG::isDoublePrediction):
+(JSC::DFG::isDynamicPrediction):
+(JSC::DFG::mergePredictions):
+(JSC::DFG::mergePrediction):
+(JSC::DFG::makePrediction):
+(JSC::DFG::Node::predict):
+
2011-09-02 Oliver Hunt oli...@apple.com
Fix 32bit build.
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (94448 => 94449)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-09-02 21:08:27 UTC (rev 94448)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-09-02 21:16:25 UTC (rev 94449)
@@ -102,9 +102,9 @@
// Must be a local.
return getLocal((unsigned)operand);
}
-void set(int operand, NodeIndex value, PredictedType prediction = PredictNone)
+void set(int operand, NodeIndex value, PredictedType staticPrediction = PredictNone)
{
-m_graph.predict(operand, prediction);
+m_graph.predict(operand, staticPrediction, StaticPrediction);
// Is this an argument?
if (operandIsArgument(operand)) {
@@ -428,12 +428,12 @@
return call;
}
-void predictArray(NodeIndex nodeIndex)
+void staticallyPredictArray(NodeIndex nodeIndex)
{
-m_graph.predict(m_graph[nodeIndex], PredictArray);
+m_graph.predict(m_graph[nodeIndex], PredictArray, StaticPrediction);
}
-void predictInt32(NodeIndex nodeIndex)
+void staticallyPredictInt32(NodeIndex nodeIndex)
{
ASSERT(m_reusableNodeStack.isEmpty());
m_reusableNodeStack.append(m_graph[nodeIndex]);
@@ -457,7 +457,7 @@
m_reusableNodeStack.append(m_graph[nodePtr-child2()]);
break;
default:
-m_graph.predict(*nodePtr, PredictInt32);
+m_graph.predict(*nodePtr, PredictInt32, StaticPrediction);
break;
}
} while (!m_reusableNodeStack.isEmpty());
@@ -587,8 +587,8 @@
case op_bitand: {
NodeIndex op1 = getToInt32(currentInstruction[2].u.operand);
[webkit-changes] [94450] trunk
Title: [94450] trunk Revision 94450 Author nd...@chromium.org Date 2011-09-02 14:35:56 -0700 (Fri, 02 Sep 2011) Log Message [chromium] Check for null context when reinitializing compositor https://bugs.webkit.org/show_bug.cgi?id=67507 Reviewed by James Robinson. * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::recreateContextIfNeeded): Modified Paths trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/public/WebView.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.h trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp Added Paths trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently-expected.png trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently-expected.txt trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently.html trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-twice-expected.png trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-twice-expected.txt trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-twice.html Diff Added: trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently-expected.png (0 => 94450) --- trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently-expected.png (rev 0) +++ trunk/LayoutTests/platform/chromium/compositing/lost-compositor-context-permanently-expected.png 2011-09-02 21:35:56 UTC (rev 94450) @@ -0,0 +1,8 @@ +\x89PNG + + +IHDR X ' )tEXtchecksum 6b0ecc73552409651fdf34f695a73063\xFDh\xB1E +\xC2IDATx\x9C\xED\xDC1\x83@A\x9F\xE5#^\xBE\x84D\xCEZ PUzɄ\xAD +n\xCD\xCC \x80\xCE\xF7\xEE o#\xB0 b \xB0 b \xB0 b \xF6\xFB\xF7\xB0\xF6u\xE5\x8EG\x9B\xCD_b \xC0\xC9 \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB6f\xE6\xEE
[webkit-changes] [94453] trunk/Tools
Title: [94453] trunk/Tools Revision 94453 Author e...@webkit.org Date 2011-09-02 15:19:59 -0700 (Fri, 02 Sep 2011) Log Message Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 Reviewed by Adam Barth. No functional change, just reshuffling code. * Scripts/webkitpy/layout_tests/port/webkit.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py Diff Modified: trunk/Tools/ChangeLog (94452 => 94453) --- trunk/Tools/ChangeLog 2011-09-02 22:09:34 UTC (rev 94452) +++ trunk/Tools/ChangeLog 2011-09-02 22:19:59 UTC (rev 94453) @@ -1,3 +1,14 @@ +2011-09-02 Eric Seidel e...@webkit.org + +Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately +https://bugs.webkit.org/show_bug.cgi?id=67530 + +Reviewed by Adam Barth. + +No functional change, just reshuffling code. + +* Scripts/webkitpy/layout_tests/port/webkit.py: + 2011-09-02 Darin Adler da...@apple.com Added Subversion ignore for .pyc generated files. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (94452 => 94453) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-02 22:09:34 UTC (rev 94452) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-02 22:19:59 UTC (rev 94453) @@ -509,44 +509,46 @@ crash=self.detected_crash(), test_time=time.time() - start_time, timeout=self._server_process.timed_out, error=error) +LENGTH_HEADER = 'Content-Length: ' +HASH_HEADER = 'ActualHash: ' +TYPE_HEADER = 'Content-Type: ' +ENCODING_HEADER = 'Content-Transfer-Encoding: ' + +def _read_line_until(self, deadline): +return self._server_process.read_line(deadline - time.time()) + def _read_block(self, deadline): -LENGTH_HEADER = 'Content-Length: ' -HASH_HEADER = 'ActualHash: ' -TYPE_HEADER = 'Content-Type: ' -ENCODING_HEADER = 'Content-Transfer-Encoding: ' content_type = None encoding = None content_hash = None content_length = None # Content is treated as binary data even though the text output is usually UTF-8. -content = '' -timeout = deadline - time.time() -line = self._server_process.read_line(timeout) +content = str() # FIXME: Should be bytearray() once we require Python 2.6. +line = self._read_line_until(deadline - time.time()) eof = False while (not self._server_process.timed_out and not self.detected_crash() and not eof): -chomped_line = line.rstrip() +chomped_line = line.rstrip() # FIXME: This will remove trailing lines from test output. Is that right? if chomped_line.endswith(#EOF): eof = True line = chomped_line[:-4] if line.startswith(TYPE_HEADER) and content_type is None: content_type = line.split()[1] -elif line.startswith(ENCODING_HEADER) and encoding is None: +elif line.startswith(self.ENCODING_HEADER) and encoding is None: encoding = line.split()[1] -elif line.startswith(LENGTH_HEADER) and content_length is None: -timeout = deadline - time.time() -content_length = int(line[len(LENGTH_HEADER):]) -# FIXME: Technically there should probably be another blank -# line here, but DRT doesn't write one. -content = self._server_process.read(timeout, content_length) -elif line.startswith(HASH_HEADER): +elif line.startswith(self.LENGTH_HEADER) and content_length is None: +content_length = int(line[len(self.LENGTH_HEADER):]) +# FIXME: In real HTTP there should probably be a blank line +# after headers before content, but DRT doesn't write one. +content = self._server_process.read(deadline - time.time(), content_length) +elif line.startswith(self.HASH_HEADER): content_hash = line.split()[1] elif line: content += line -if not eof: -line = self._server_process.read_line(timeout) -timeout = deadline - time.time() +if eof: +break +line = self._read_line_until(deadline) return ContentBlock(content_type, encoding, content_hash, content) def stop(self): ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94454] trunk/Source/WebKit2
Title: [94454] trunk/Source/WebKit2
Revision 94454
Author adac...@apple.com
Date 2011-09-02 15:21:07 -0700 (Fri, 02 Sep 2011)
Log Message
Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=67526
Reviewed by Darin Adler.
* UIProcess/API/C/WKContext.cpp:
(WKContextGarbageCollectJavaScriptObjects):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Source/WebKit2/WebProcess/WebProcess.messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94453 => 94454)
--- trunk/Source/WebKit2/ChangeLog 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-02 22:21:07 UTC (rev 94454)
@@ -1,3 +1,21 @@
+2011-09-02 Ada Chan adac...@apple.com
+
+Add WKContextGarbageCollectJavaScriptObjects() which does a garbage collection in the WebProcess
+https://bugs.webkit.org/show_bug.cgi?id=67526
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextGarbageCollectJavaScriptObjects):
+* UIProcess/API/C/WKContext.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::garbageCollectJavaScriptObjects): Send a message to WebProcess to garbage collect JS objects.
+* UIProcess/WebContext.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::garbageCollectJavaScriptObjects): Call GCController::garbageCollectNow().
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in: Add GarbageCollectJavaScriptObjects message.
+
2011-09-02 Anders Carlsson ander...@apple.com
Remove plug-in paths from web process sandbox
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (94453 => 94454)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-09-02 22:21:07 UTC (rev 94454)
@@ -237,3 +237,8 @@
toImpl(contextRef)-getWebCoreStatistics(DictionaryCallback::create(context, callback));
}
+void WKContextGarbageCollectJavaScriptObjects(WKContextRef contextRef)
+{
+toImpl(contextRef)-garbageCollectJavaScriptObjects();
+}
+
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (94453 => 94454)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2011-09-02 22:21:07 UTC (rev 94454)
@@ -140,6 +140,8 @@
typedef void (*WKContextGetStatisticsFunction)(WKDictionaryRef statistics, WKErrorRef error, void* functionContext);
WK_EXPORT void WKContextGetStatistics(WKContextRef context, void* functionContext, WKContextGetStatisticsFunction function);
+
+WK_EXPORT void WKContextGarbageCollectJavaScriptObjects(WKContextRef context);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (94453 => 94454)
--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-02 22:21:07 UTC (rev 94454)
@@ -829,4 +829,9 @@
callback-performCallbackWithReturnValue(statistics.get());
}
+void WebContext::garbageCollectJavaScriptObjects()
+{
+process()-send(Messages::WebProcess::GarbageCollectJavaScriptObjects(), 0);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (94453 => 94454)
--- trunk/Source/WebKit2/UIProcess/WebContext.h 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2011-09-02 22:21:07 UTC (rev 94454)
@@ -181,6 +181,7 @@
bool httpPipeliningEnabled();
void getWebCoreStatistics(PassRefPtrDictionaryCallback);
+void garbageCollectJavaScriptObjects();
private:
WebContext(ProcessModel, const String injectedBundlePath);
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (94453 => 94454)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-02 22:19:59 UTC (rev 94453)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-02 22:21:07 UTC (rev 94454)
@@ -934,6 +934,11 @@
m_connection-send(Messages::WebContext::DidGetWebCoreStatistics(data, callbackID), 0);
}
+void WebProcess::garbageCollectJavaScriptObjects()
+{
+
[webkit-changes] [94455] trunk
Title: [94455] trunk
Revision 94455
Author m...@apple.com
Date 2011-09-02 15:22:16 -0700 (Fri, 02 Sep 2011)
Log Message
rdar://problem/9755843 anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node
Reviewed by Darin Adler.
Source/WebCore:
Test: mathml/operator-hijacks-fenced-node.xhtml
* rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().
LayoutTests:
* mathml/operator-hijacks-fenced-node-expected.txt: Added.
* mathml/operator-hijacks-fenced-node.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp
Added Paths
trunk/LayoutTests/mathml/operator-hijacks-fenced-node-expected.txt
trunk/LayoutTests/mathml/operator-hijacks-fenced-node.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (94454 => 94455)
--- trunk/LayoutTests/ChangeLog 2011-09-02 22:21:07 UTC (rev 94454)
+++ trunk/LayoutTests/ChangeLog 2011-09-02 22:22:16 UTC (rev 94455)
@@ -1,3 +1,12 @@
+2011-09-02 Dan Bernstein m...@apple.com
+
+rdar://problem/9755843 anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node
+
+Reviewed by Darin Adler.
+
+* mathml/operator-hijacks-fenced-node-expected.txt: Added.
+* mathml/operator-hijacks-fenced-node.xhtml: Added.
+
2011-09-02 Tom Sepez tse...@chromium.org
Add LayoutTest for the case where long strings are processed by the XSSAuditor.
Added: trunk/LayoutTests/mathml/operator-hijacks-fenced-node-expected.txt (0 => 94455)
--- trunk/LayoutTests/mathml/operator-hijacks-fenced-node-expected.txt (rev 0)
+++ trunk/LayoutTests/mathml/operator-hijacks-fenced-node-expected.txt 2011-09-02 22:22:16 UTC (rev 94455)
@@ -0,0 +1,3 @@
+This tests that an anonymous operator created by mfenced does not set itself as the mfenced node’s renderer.
+
+The test passes if it does not crash or cause an assertion failure.
Added: trunk/LayoutTests/mathml/operator-hijacks-fenced-node.xhtml (0 => 94455)
--- trunk/LayoutTests/mathml/operator-hijacks-fenced-node.xhtml (rev 0)
+++ trunk/LayoutTests/mathml/operator-hijacks-fenced-node.xhtml 2011-09-02 22:22:16 UTC (rev 94455)
@@ -0,0 +1,24 @@
+?xml version=1.0 encoding=UTF-8?
+html xmlns=http://www.w3.org/1999/xhtml xmlns:m=http://www.w3.org/1998/Math/MathML
+body
+p
+This tests that an anonymous operator created by mfenced does not
+set itself as the mfenced node#x2019;s renderer.
+/p
+p
+The test passes if it does not crash or cause an assertion failure.
+/p
+div id=container
+m:mathspanm:mfenced id=targetm:mo/m:mo/m:mfenced/span/m:math
+/div
+script![CDATA[
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.body.offsetTop;
+document.getElementById(target).parentNode.insertBefore(document.createElement(div), document.getElementById(target));
+document.body.offsetTop;
+document.getElementById(container).style.display = none;
+]]/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (94454 => 94455)
--- trunk/Source/WebCore/ChangeLog 2011-09-02 22:21:07 UTC (rev 94454)
+++ trunk/Source/WebCore/ChangeLog 2011-09-02 22:22:16 UTC (rev 94455)
@@ -1,3 +1,15 @@
+2011-09-02 Dan Bernstein m...@apple.com
+
+rdar://problem/9755843 anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node
+
+Reviewed by Darin Adler.
+
+Test: mathml/operator-hijacks-fenced-node.xhtml
+
+* rendering/mathml/RenderMathMLOperator.cpp:
+(WebCore::RenderMathMLOperator::updateFromElement): Rather than unconditionally setting the
+node’s renderer to this, just restore it to whatever it was before calling destroyLeftoverChildren().
+
2011-09-02 Mark Hahnenberg mhahnenb...@apple.com
Incorporate newer, faster dtoa library
Modified: trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp (94454 => 94455)
--- trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp 2011-09-02 22:21:07 UTC (rev 94454)
+++ trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp 2011-09-02 22:22:16 UTC (rev 94455)
@@ -124,12 +124,14 @@
void RenderMathMLOperator::updateFromElement()
{
+RenderObject* savedRenderer = node()-renderer();
+
// Destroy our current children
children()-destroyLeftoverChildren();
-// Since we share a node with our children, destroying our children will set our node's
-// renderer to 0, so we need to re-set it back to this.
-node()-setRenderer(this);
+// Since we share a node with our children, destroying our children may set our node's
+// renderer to 0, so we
[webkit-changes] [94456] trunk/Source/WebKit2
Title: [94456] trunk/Source/WebKit2 Revision 94456 Author ander...@apple.com Date 2011-09-02 15:22:39 -0700 (Fri, 02 Sep 2011) Log Message NPN_SetException doesn't work with OOP plug-ins https://bugs.webkit.org/show_bug.cgi?id=67524 Reviewed by Sam Weinig. * DerivedSources.make: Add PluginProcessConnection.messages.in. * GNUmakefile.am: Add generated files. * Platform/CoreIPC/MessageID.h: Add MessageClassPluginProcessConnection. * PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::initialize): Set the set exception function. * PluginProcess/WebProcessConnection.cpp: (WebKit::ConnectionStack::current): (WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher): (WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher): Add a helper class for managing a stack of CoreIPC connections, along with a RAII object to push/pop connections onto it. (WebKit::connectionStack): Add getter. (WebKit::WebProcessConnection::setGlobalException): Get the current connection and send a PluginProcessConnection::SetException message to it. (WebKit::WebProcessConnection::didReceiveMessage): (WebKit::WebProcessConnection::didReceiveSyncMessage): Create connection pushers. * PluginProcess/WebProcessConnection.h: Add setGlobalException. * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: Add new files. * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::setSetExceptionFunction): New function for setting the 'setException' function. (WebKit::NetscapePlugin::setException): Call the 'setException' function. * WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::PluginProcessConnection::didReceiveSyncMessage): Call the message receiver function. (WebKit::PluginProcessConnection::setException): Call the NPRuntimeObjectMap. * WebProcess/Plugins/PluginProcessConnection.messages.in: Add new messages file. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): When not using the plug-in process, make sure to call NetscapePlugin::setSetExceptionFunction. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DerivedSources.make trunk/Source/WebKit2/GNUmakefile.am trunk/Source/WebKit2/Platform/CoreIPC/MessageID.h trunk/Source/WebKit2/PluginProcess/PluginProcess.cpp trunk/Source/WebKit2/PluginProcess/WebProcessConnection.cpp trunk/Source/WebKit2/PluginProcess/WebProcessConnection.h trunk/Source/WebKit2/WebKit2.pro trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Added Paths trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.messages.in Diff Modified: trunk/Source/WebKit2/ChangeLog (94455 => 94456) --- trunk/Source/WebKit2/ChangeLog 2011-09-02 22:22:16 UTC (rev 94455) +++ trunk/Source/WebKit2/ChangeLog 2011-09-02 22:22:39 UTC (rev 94456) @@ -1,3 +1,68 @@ +2011-09-02 Anders Carlsson ander...@apple.com + +NPN_SetException doesn't work with OOP plug-ins +https://bugs.webkit.org/show_bug.cgi?id=67524 + +Reviewed by Sam Weinig. + +* DerivedSources.make: +Add PluginProcessConnection.messages.in. + +* GNUmakefile.am: +Add generated files. + +* Platform/CoreIPC/MessageID.h: +Add MessageClassPluginProcessConnection. + +* PluginProcess/PluginProcess.cpp: +(WebKit::PluginProcess::initialize): +Set the set exception function. + +* PluginProcess/WebProcessConnection.cpp: +(WebKit::ConnectionStack::current): +(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher): +(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher): +Add a helper class for managing a stack of CoreIPC connections, along with a RAII +object to push/pop connections onto it. + +(WebKit::connectionStack): +Add getter. + +(WebKit::WebProcessConnection::setGlobalException): +Get the current connection and send a PluginProcessConnection::SetException message to it. + +(WebKit::WebProcessConnection::didReceiveMessage): +(WebKit::WebProcessConnection::didReceiveSyncMessage): +Create connection pushers. + +* PluginProcess/WebProcessConnection.h: +Add setGlobalException. + +* WebKit2.pro: +* WebKit2.xcodeproj/project.pbxproj: +Add new files. + +* WebProcess/Plugins/Netscape/NetscapePlugin.cpp: +(WebKit::NetscapePlugin::setSetExceptionFunction): +New function for setting the 'setException' function. + +(WebKit::NetscapePlugin::setException): +Call the 'setException' function. + +*
[webkit-changes] [94457] trunk
Title: [94457] trunk Revision 94457 Author mdela...@apple.com Date 2011-09-02 15:32:44 -0700 (Fri, 02 Sep 2011) Log Message Read out of bounds in sUnpremultiplyData_RGBA / ImageBufferData::getData https://bugs.webkit.org/show_bug.cgi?id=65352 Reviewed by Simon Fraser. New test: fast/canvas/canvas-getImageData-large-crash.html Source/_javascript_Core: This patch prevents overflows from happening in getImageData, createImageData, and canvas creation calls that specify widths and heights that end up overflowing the ints that we store those values in as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer arithmetic is detected via the use of the new Checked type that was introduced in r94207. The change to JSC is just to add a new helper method described below. * wtf/MathExtras.h: (isWithinIntRange): Reports if a float's value is within the range expressible by an int. Source/WebCore: This patch prevents overflows from happening in getImageData, createImageData, and canvas creation calls that specify widths and heights that end up overflowing the ints that we store those values in as well as derived values such as area and maxX / maxY of the bounding rects involved. Overflow of integer arithmetic is detected via the use of the new Checked type that was introduced in r94207. * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::convertLogicalToDevice): Removed dependency on ints, using FloatRects/Sizes instead. (WebCore::HTMLCanvasElement::createImageBuffer): Moved the check for max canvas area and dimensions here. Added in check that prevents us from having canvases of sizes that will cause overflows. (WebCore::HTMLCanvasElement::baseTransform): Updated use of convertLogicalToDevice. * html/HTMLCanvasElement.h: Updated method signatures. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::createEmptyImageData): Added in check to prevent creating ImageData objects that will cause overflow when computing their size. (WebCore::CanvasRenderingContext2D::createImageData): Avoid creating ImageData objects of size that will overflow later. (WebCore::CanvasRenderingContext2D::getImageData): Added in check to prevent trying to get ImageData objects that will cause overflow when computing their size. * platform/graphics/FloatRect.cpp: (WebCore::FloatRect::isExpressibleAsIntRect): New method that tests whether a FloatRect can become an IntRect without overflow or having to be clamped. * platform/graphics/FloatRect.h: * platform/graphics/FloatSize.cpp: (WebCore::FloatSize::isExpressibleAsIntSize): Same as FloatRect, but for FloatSize-IntSize. * platform/graphics/FloatSize.h: * platform/graphics/cg/ImageBufferCG.cpp: Added check for overflow. (WebCore::ImageBuffer::ImageBuffer): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/MathExtras.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLCanvasElement.cpp trunk/Source/WebCore/html/HTMLCanvasElement.h trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp trunk/Source/WebCore/platform/graphics/FloatRect.cpp trunk/Source/WebCore/platform/graphics/FloatRect.h trunk/Source/WebCore/platform/graphics/FloatSize.cpp trunk/Source/WebCore/platform/graphics/FloatSize.h trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp trunk/Source/WebCore/platform/graphics/cg/ImageBufferDataCG.h Added Paths trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash-expected.txt trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html Diff Added: trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash-expected.txt (0 => 94457) --- trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash-expected.txt 2011-09-02 22:32:44 UTC (rev 94457) @@ -0,0 +1 @@ +PASSED (If this page did not crash.) Added: trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html (0 => 94457) --- trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html (rev 0) +++ trunk/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html 2011-09-02 22:32:44 UTC (rev 94457) @@ -0,0 +1,14 @@ +html +head +script +if (window.layoutTestController) +layoutTestController.dumpAsText(false); + +var canvas = document.createElement(canvas); +canvas.getContext(2d).getImageData(10, 0x, 2147483647,10); +/script +/head +body +PASSED (If this page did not crash.) +/body +/html Modified: trunk/Source/_javascript_Core/ChangeLog (94456 => 94457) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 22:22:39 UTC (rev 94456) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 22:32:44 UTC (rev 94457) @@ -1,3 +1,21 @@ +2011-08-30 Matthew Delaney mdela...@apple.com + +Read out of bounds in sUnpremultiplyData_RGBA / ImageBufferData::getData +
[webkit-changes] [94458] trunk/Tools
Title: [94458] trunk/Tools Revision 94458 Author e...@webkit.org Date 2011-09-02 15:33:59 -0700 (Fri, 02 Sep 2011) Log Message Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 Unreviewed. Fixing typo from previous commit. Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block which exercises the code I previously made a typo in. * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (94457 => 94458) --- trunk/Tools/ChangeLog 2011-09-02 22:32:44 UTC (rev 94457) +++ trunk/Tools/ChangeLog 2011-09-02 22:33:59 UTC (rev 94458) @@ -3,6 +3,19 @@ Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 +Unreviewed. Fixing typo from previous commit. + +Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block +which exercises the code I previously made a typo in. + +* Scripts/webkitpy/layout_tests/port/webkit.py: +* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + +2011-09-02 Eric Seidel e...@webkit.org + +Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately +https://bugs.webkit.org/show_bug.cgi?id=67530 + Reviewed by Adam Barth. No functional change, just reshuffling code. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (94457 => 94458) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-02 22:32:44 UTC (rev 94457) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-02 22:33:59 UTC (rev 94458) @@ -533,7 +533,7 @@ eof = True line = chomped_line[:-4] -if line.startswith(TYPE_HEADER) and content_type is None: +if line.startswith(self.TYPE_HEADER) and content_type is None: content_type = line.split()[1] elif line.startswith(self.ENCODING_HEADER) and encoding is None: encoding = line.split()[1] Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (94457 => 94458) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-09-02 22:32:44 UTC (rev 94457) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-09-02 22:33:59 UTC (rev 94458) @@ -31,7 +31,7 @@ from webkitpy.common.system.outputcapture import OutputCapture from webkitpy.layout_tests.models.test_configuration import TestConfiguration -from webkitpy.layout_tests.port.webkit import WebKitPort +from webkitpy.layout_tests.port.webkit import WebKitPort, WebKitDriver from webkitpy.layout_tests.port import port_testcase from webkitpy.tool.mocktool import MockExecutive, MockOptions, MockUser @@ -197,3 +197,29 @@ # Mock out _apache_config_file_name_for_platform to ignore the passed sys.platform value. port._apache_config_file_name_for_platform = lambda platform: 'httpd.conf' self.assertEquals(port._path_to_apache_config_file(), '/mock-checkout/LayoutTests/http/conf/httpd.conf') + + +class MockServerProcess(object): +def __init__(self, lines=None): +self.timed_out = False +self.crashed = False +self.lines = lines or [] + +def read_line(self, timeout): +return self.lines.pop(0) + + +class WebKitDriverTest(unittest.TestCase): +def test_read_block(self): +port = TestWebKitPort() +driver = WebKitDriver(port, 0) +driver._server_process = MockServerProcess([ +'ActualHash: foobar', +'Content-Type: my_type', +'Content-Transfer-Encoding: none', +#EOF, +]) +content_block = driver._read_block(0) +self.assertEquals(content_block.content_type, 'my_type') +self.assertEquals(content_block.encoding, 'none') +self.assertEquals(content_block.content_hash, 'foobar') ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94459] trunk/Source/WebKit/chromium
Title: [94459] trunk/Source/WebKit/chromium
Revision 94459
Author commit-qu...@webkit.org
Date 2011-09-02 16:07:29 -0700 (Fri, 02 Sep 2011)
Log Message
Need API for getting surrounding text from webkit in chromium
https://bugs.webkit.org/show_bug.cgi?id=66681
Patch by Peng Huang penghu...@chromium.org on 2011-09-02
Reviewed by Ryosuke Niwa.
Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
WebViewImpl. This function is for supporting some input methods which
need input context around the edit caret.
* public/WebWidget.h:
(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
* src/WebViewImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94458 => 94459)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-02 22:33:59 UTC (rev 94458)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-02 23:07:29 UTC (rev 94459)
@@ -1,3 +1,20 @@
+2011-09-02 Peng Huang penghu...@chromium.org
+
+Need API for getting surrounding text from webkit in chromium
+https://bugs.webkit.org/show_bug.cgi?id=66681
+
+Reviewed by Ryosuke Niwa.
+
+Add getSelectionOffsetsAndTextInEditableContent() to Chromium's
+WebViewImpl. This function is for supporting some input methods which
+need input context around the edit caret.
+
+* public/WebWidget.h:
+(WebKit::WebWidget::getSelectionOffsetsAndTextInEditableContent):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
+* src/WebViewImpl.h:
+
2011-09-02 Sheriff Bot webkit.review@gmail.com
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (94458 => 94459)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2011-09-02 22:33:59 UTC (rev 94458)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2011-09-02 23:07:29 UTC (rev 94459)
@@ -147,6 +147,11 @@
// Returns the current text input type of this WebWidget.
virtual WebTextInputType textInputType() { return WebKit::WebTextInputTypeNone; }
+// Returns the plain text around the edit caret and the focus index in the
+// text. If selection exists, it will return the anchor index as well,
+// otherwise the anchor index will be the same value of the focus index.
+virtual bool getSelectionOffsetsAndTextInEditableContent(WebString, size_t focus, size_t anchor) const { return false; }
+
// Returns the current caret bounds of this WebWidget. The selection bounds
// will be returned if a selection range is available.
virtual WebRect caretOrSelectionBounds() { return WebRect(); }
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (94458 => 94459)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-02 22:33:59 UTC (rev 94458)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-09-02 23:07:29 UTC (rev 94459)
@@ -1508,6 +1508,36 @@
return WebTextInputTypeNone;
}
+bool WebViewImpl::getSelectionOffsetsAndTextInEditableContent(WebString text, size_t focus, size_t anchor) const
+{
+const Frame* frame = focusedWebCoreFrame();
+if (!frame)
+return false;
+
+const FrameSelection* selection = frame-selection();
+Element* element = selection-rootEditableElement();
+if (!element)
+return false;
+
+size_t location;
+size_t length;
+RefPtrRange range = selection-selection().firstRange();
+if (!range || !TextIterator::locationAndLengthFromRange(range.get(), location, length))
+return false;
+
+if (selection-selection().isBaseFirst()) {
+anchor = location;
+focus = location + length;
+} else {
+anchor = location;
+focus = location + length;
+}
+
+text = element-innerText();
+
+return true;
+}
+
WebRect WebViewImpl::caretOrSelectionBounds()
{
WebRect rect;
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.h (94458 => 94459)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-09-02 22:33:59 UTC (rev 94458)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.h 2011-09-02 23:07:29 UTC (rev 94459)
@@ -117,6 +117,7 @@
virtual bool confirmComposition(const WebString text);
virtual bool compositionRange(size_t* location, size_t* length);
virtual WebTextInputType textInputType();
+virtual bool getSelectionOffsetsAndTextInEditableContent(WebString, size_t focus, size_t anchor) const;
virtual WebRect caretOrSelectionBounds();
virtual bool selectionRange(WebPoint start, WebPoint end) const;
virtual bool caretOrSelectionRange(size_t* location, size_t* length);
___
webkit-changes mailing
[webkit-changes] [94460] trunk/Source/JavaScriptCore
Title: [94460] trunk/Source/_javascript_Core Revision 94460 Author jam...@google.com Date 2011-09-02 16:25:15 -0700 (Fri, 02 Sep 2011) Log Message Compile fix for mac build. * wtf/CheckedArithmetic.h: (WTF::operator+): (WTF::operator-): (WTF::operator*): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/CheckedArithmetic.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94459 => 94460) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:07:29 UTC (rev 94459) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:25:15 UTC (rev 94460) @@ -1,3 +1,12 @@ +2011-09-02 James Robinson jam...@chromium.org + +Compile fix for mac build. + +* wtf/CheckedArithmetic.h: +(WTF::operator+): +(WTF::operator-): +(WTF::operator*): + 2011-08-30 Matthew Delaney mdela...@apple.com Read out of bounds in sUnpremultiplyData_RGBA / ImageBufferData::getData Modified: trunk/Source/_javascript_Core/wtf/CheckedArithmetic.h (94459 => 94460) --- trunk/Source/_javascript_Core/wtf/CheckedArithmetic.h 2011-09-02 23:07:29 UTC (rev 94459) +++ trunk/Source/_javascript_Core/wtf/CheckedArithmetic.h 2011-09-02 23:25:15 UTC (rev 94460) @@ -623,7 +623,7 @@ U x = 0; V y = 0; bool overflowed = lhs.safeGet(x) || rhs.safeGet(y); -typename ResultU, V::ResultType result; +typename ResultU, V::ResultType result = 0; overflowed |= !safeAdd(x, y, result); if (overflowed) return ResultOverflowed; @@ -635,7 +635,7 @@ U x = 0; V y = 0; bool overflowed = lhs.safeGet(x) || rhs.safeGet(y); -typename ResultU, V::ResultType result; +typename ResultU, V::ResultType result = 0; overflowed |= !safeSub(x, y, result); if (overflowed) return ResultOverflowed; @@ -647,7 +647,7 @@ U x = 0; V y = 0; bool overflowed = lhs.safeGet(x) || rhs.safeGet(y); -typename ResultU, V::ResultType result; +typename ResultU, V::ResultType result = 0; overflowed |= !safeMultiply(x, y, result); if (overflowed) return ResultOverflowed; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94461] trunk/Source/JavaScriptCore
Title: [94461] trunk/Source/_javascript_Core Revision 94461 Author oli...@apple.com Date 2011-09-02 16:33:28 -0700 (Fri, 02 Sep 2011) Log Message Remove OldSpace classes https://bugs.webkit.org/show_bug.cgi?id=67533 Reviewed by Gavin Barraclough. Remove the unused OldSpace classes * CMakeLists.txt: * GNUmakefile.list.am: * _javascript_Core.gypi: * _javascript_Core.pro: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: * _javascript_Core.xcodeproj/project.pbxproj: * heap/Heap.cpp: (JSC::Heap::writeBarrierSlowCase): * heap/MarkedBlock.h: * heap/OldSpace.cpp: Removed. * heap/OldSpace.h: Removed. Modified Paths trunk/Source/_javascript_Core/CMakeLists.txt trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/GNUmakefile.list.am trunk/Source/_javascript_Core/_javascript_Core.gypi trunk/Source/_javascript_Core/_javascript_Core.pro trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/MarkedBlock.h Removed Paths trunk/Source/_javascript_Core/heap/OldSpace.cpp trunk/Source/_javascript_Core/heap/OldSpace.h Diff Modified: trunk/Source/_javascript_Core/CMakeLists.txt (94460 => 94461) --- trunk/Source/_javascript_Core/CMakeLists.txt 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/CMakeLists.txt 2011-09-02 23:33:28 UTC (rev 94461) @@ -48,7 +48,6 @@ heap/MachineStackMarker.cpp heap/MarkedBlock.cpp heap/NewSpace.cpp -heap/OldSpace.cpp heap/ConservativeRoots.cpp heap/MarkStack.cpp Modified: trunk/Source/_javascript_Core/ChangeLog (94460 => 94461) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:33:28 UTC (rev 94461) @@ -1,3 +1,24 @@ +2011-09-02 Oliver Hunt oli...@apple.com + +Remove OldSpace classes +https://bugs.webkit.org/show_bug.cgi?id=67533 + +Reviewed by Gavin Barraclough. + +Remove the unused OldSpace classes + +* CMakeLists.txt: +* GNUmakefile.list.am: +* _javascript_Core.gypi: +* _javascript_Core.pro: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj: +* _javascript_Core.xcodeproj/project.pbxproj: +* heap/Heap.cpp: +(JSC::Heap::writeBarrierSlowCase): +* heap/MarkedBlock.h: +* heap/OldSpace.cpp: Removed. +* heap/OldSpace.h: Removed. + 2011-09-02 James Robinson jam...@chromium.org Compile fix for mac build. Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (94460 => 94461) --- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-02 23:33:28 UTC (rev 94461) @@ -146,8 +146,6 @@ Source/_javascript_Core/heap/TinyBloomFilter.h \ Source/_javascript_Core/heap/NewSpace.cpp \ Source/_javascript_Core/heap/NewSpace.h \ - Source/_javascript_Core/heap/OldSpace.cpp \ - Source/_javascript_Core/heap/OldSpace.h \ Source/_javascript_Core/heap/Strong.h \ Source/_javascript_Core/heap/VTableSpectrum.cpp \ Source/_javascript_Core/heap/VTableSpectrum.h \ Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (94460 => 94461) --- trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/_javascript_Core.gypi 2011-09-02 23:33:28 UTC (rev 94461) @@ -339,8 +339,6 @@ 'heap/TinyBloomFilter.h', 'heap/NewSpace.cpp', 'heap/NewSpace.h', -'heap/OldSpace.cpp', -'heap/OldSpace.h', 'debugger/Debugger.cpp', 'debugger/DebuggerActivation.cpp', 'debugger/DebuggerCallFrame.cpp', Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (94460 => 94461) --- trunk/Source/_javascript_Core/_javascript_Core.pro 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/_javascript_Core.pro 2011-09-02 23:33:28 UTC (rev 94461) @@ -78,7 +78,6 @@ heap/MarkStack.cpp \ heap/MarkedBlock.cpp \ heap/NewSpace.cpp \ -heap/OldSpace.cpp \ heap/VTableSpectrum.cpp \ heap/WriteBarrierSupport.cpp \ debugger/DebuggerActivation.cpp \ Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj (94460 => 94461) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-09-02 23:25:15 UTC (rev 94460) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.vcproj 2011-09-02 23:33:28 UTC (rev 94461) @@ -1906,14 +1906,6 @@ /File File -
[webkit-changes] [94462] trunk/Source/WebKit/qt
Title: [94462] trunk/Source/WebKit/qt Revision 94462 Author commit-qu...@webkit.org Date 2011-09-02 16:39:16 -0700 (Fri, 02 Sep 2011) Log Message [Qt][Symbian] REGRESSION(93235) Missing .def update https://bugs.webkit.org/show_bug.cgi?id=67307 Patch by Jade Han jade@nokia.com on 2011-09-02 Reviewed by Laszlo Gombos. * symbian/eabi/QtWebKitu.def: Modified Paths trunk/Source/WebKit/qt/ChangeLog trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def Diff Modified: trunk/Source/WebKit/qt/ChangeLog (94461 => 94462) --- trunk/Source/WebKit/qt/ChangeLog 2011-09-02 23:33:28 UTC (rev 94461) +++ trunk/Source/WebKit/qt/ChangeLog 2011-09-02 23:39:16 UTC (rev 94462) @@ -1,3 +1,12 @@ +2011-09-02 Jade Han jade@nokia.com + +[Qt][Symbian] REGRESSION(93235) Missing .def update +https://bugs.webkit.org/show_bug.cgi?id=67307 + +Reviewed by Laszlo Gombos. + +* symbian/eabi/QtWebKitu.def: + 2011-09-01 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org [Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox Modified: trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def (94461 => 94462) --- trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-09-02 23:33:28 UTC (rev 94461) +++ trunk/Source/WebKit/qt/symbian/eabi/QtWebKitu.def 2011-09-02 23:39:16 UTC (rev 94462) @@ -878,3 +878,5 @@ _ZN8QDRTNodeD1Ev @ 877 NONAME _ZN8QDRTNodeD2Ev @ 878 NONAME _ZN8QDRTNodeaSERKS_ @ 879 NONAME + _ZN23DumpRenderTreeSupportQt21injectInternalsObjectEP9QWebFrame @ 880 NONAME + _ZN23DumpRenderTreeSupportQt20resetInternalsObjectEP9QWebFrame @ 881 NONAME ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94463] trunk/Source/JavaScriptCore
Title: [94463] trunk/Source/_javascript_Core
Revision 94463
Author commit-qu...@webkit.org
Date 2011-09-02 16:58:05 -0700 (Fri, 02 Sep 2011)
Log Message
Fix the broken build due to dtoa patch
https://bugs.webkit.org/show_bug.cgi?id=67534
Patch by Mark Hahnenberg mhahnenb...@apple.com on 2011-09-02
Reviewed by Oliver Hunt.
Fixing the build.
* GNUmakefile.list.am:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/utils.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/wtf/dtoa/bignum.cc
trunk/Source/_javascript_Core/wtf/dtoa/fast-dtoa.cc
trunk/Source/_javascript_Core/wtf/dtoa/utils.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94462 => 94463)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:39:16 UTC (rev 94462)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-02 23:58:05 UTC (rev 94463)
@@ -1,3 +1,17 @@
+2011-09-02 Mark Hahnenberg mhahnenb...@apple.com
+
+Fix the broken build due to dtoa patch
+https://bugs.webkit.org/show_bug.cgi?id=67534
+
+Reviewed by Oliver Hunt.
+
+Fixing the build.
+
+* GNUmakefile.list.am:
+* wtf/dtoa/bignum.cc:
+* wtf/dtoa/fast-dtoa.cc:
+* wtf/dtoa/utils.h:
+
2011-09-02 Oliver Hunt oli...@apple.com
Remove OldSpace classes
Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (94462 => 94463)
--- trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-02 23:39:16 UTC (rev 94462)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am 2011-09-02 23:58:05 UTC (rev 94463)
@@ -466,27 +466,27 @@
Source/_javascript_Core/wtf/CurrentTime.h \
Source/_javascript_Core/wtf/DateMath.cpp \
Source/_javascript_Core/wtf/DateMath.h \
-Source/_javascript_Core/wtf/DecimalNumber.cpp \
-Source/_javascript_Core/wtf/DecimalNumber.h \
-Source/_javascript_Core/wtf/dtoa/bignum-dtoa.cc \
-Source/_javascript_Core/wtf/dtoa/bignum.cc \
-Source/_javascript_Core/wtf/dtoa/cached-powers.cc \
-Source/_javascript_Core/wtf/dtoa/diy-fp.cc \
-Source/_javascript_Core/wtf/dtoa/double-conversion.cc \
-Source/_javascript_Core/wtf/dtoa/fast-dtoa.cc \
-Source/_javascript_Core/wtf/dtoa/fixed-dtoa.cc \
-Source/_javascript_Core/wtf/dtoa/strtod.cc \
-Source/_javascript_Core/wtf/dtoa/bignum-dtoa.h \
-Source/_javascript_Core/wtf/dtoa/bignum.h \
-Source/_javascript_Core/wtf/dtoa/cached-powers.h \
-Source/_javascript_Core/wtf/dtoa/diy-fp.h \
-Source/_javascript_Core/wtf/dtoa/double-conversion.h \
-Source/_javascript_Core/wtf/dtoa/double.h \
-Source/_javascript_Core/wtf/dtoa/fast-dtoa.h \
-Source/_javascript_Core/wtf/dtoa/fixed-dtoa.h \
-Source/_javascript_Core/wtf/dtoa/strtod.h \
-Source/_javascript_Core/wtf/dtoa/utils.h \
-Source/_javascript_Core/wtf/Decoder.h \
+ Source/_javascript_Core/wtf/DecimalNumber.cpp \
+ Source/_javascript_Core/wtf/DecimalNumber.h \
+ Source/_javascript_Core/wtf/dtoa/bignum-dtoa.cc \
+ Source/_javascript_Core/wtf/dtoa/bignum.cc \
+ Source/_javascript_Core/wtf/dtoa/cached-powers.cc \
+ Source/_javascript_Core/wtf/dtoa/diy-fp.cc \
+ Source/_javascript_Core/wtf/dtoa/double-conversion.cc \
+ Source/_javascript_Core/wtf/dtoa/fast-dtoa.cc \
+ Source/_javascript_Core/wtf/dtoa/fixed-dtoa.cc \
+ Source/_javascript_Core/wtf/dtoa/strtod.cc \
+ Source/_javascript_Core/wtf/dtoa/bignum-dtoa.h \
+ Source/_javascript_Core/wtf/dtoa/bignum.h \
+ Source/_javascript_Core/wtf/dtoa/cached-powers.h \
+ Source/_javascript_Core/wtf/dtoa/diy-fp.h \
+ Source/_javascript_Core/wtf/dtoa/double-conversion.h \
+ Source/_javascript_Core/wtf/dtoa/double.h \
+ Source/_javascript_Core/wtf/dtoa/fast-dtoa.h \
+ Source/_javascript_Core/wtf/dtoa/fixed-dtoa.h \
+ Source/_javascript_Core/wtf/dtoa/strtod.h \
+ Source/_javascript_Core/wtf/dtoa/utils.h \
+ Source/_javascript_Core/wtf/Decoder.h \
Source/_javascript_Core/wtf/Deque.h \
Source/_javascript_Core/wtf/DisallowCType.h \
Source/_javascript_Core/wtf/DoublyLinkedList.h \
Modified: trunk/Source/_javascript_Core/wtf/dtoa/bignum.cc (94462 => 94463)
--- trunk/Source/_javascript_Core/wtf/dtoa/bignum.cc 2011-09-02 23:39:16 UTC (rev 94462)
+++ trunk/Source/_javascript_Core/wtf/dtoa/bignum.cc 2011-09-02 23:58:05 UTC (rev 94463)
@@ -66,7 +66,7 @@
int needed_bigits = kUInt64Size / kBigitSize + 1;
EnsureCapacity(needed_bigits);
for (int i = 0; i needed_bigits; ++i) {
-bigits_[i] = value kBigitMask;
+bigits_[i] = (uint32_t)value kBigitMask;
value = value kBigitSize;
}
used_digits_ = needed_bigits;
@@ -265,7 +265,7 @@
}
while (carry != 0) {
EnsureCapacity(used_digits_ + 1);
-bigits_[used_digits_] = carry kBigitMask;
+bigits_[used_digits_] = (uint32_t)carry kBigitMask;
used_digits_++;
carry = kBigitSize;
}
@@
[webkit-changes] [94464] trunk
Title: [94464] trunk
Revision 94464
Author jchaffr...@webkit.org
Date 2011-09-02 17:07:44 -0700 (Fri, 02 Sep 2011)
Log Message
Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
https://bugs.webkit.org/show_bug.cgi?id=66901
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/layers/assert-RenderLayer-update-positions.html
Also covered by existing tests under the new ASSERT.
This change extends the range of callers making use of the cachedOffset optimization.
Most callers did not make use of cachedOffset as it did not work when called on a subtree.
This limitation is now gone thus we can enable it more widely.
The semantics of the optimization are changed a bit as we now return if it is enabled whereas
the old code would check if it was *disabled*. Also there were some renames done to match more
closely what was going on (s/cachedOffset/offsetFromRoot/ and s/cachedOffsetDisabled/hasLayerOffset/).
Note that this is an optimistic optimization: if cachedOffset is not used, then we have
done at least an extra traversal up to the root. I have found it to be a wash on file
cycler (alexa) but to be a nice improvement (~20%) on some table benchmarks (modifying
a cell, scrolling).
* page/FrameView.cpp:
(WebCore::FrameView::layout): Extended the use of cachedOffset to subtree layouts.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange): Forbid the use cachedOffset in this
case as we have only a single layer to update.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeOffsetFromRoot): Added this function to get the offset from the root
layer at a certain point in the RenderLayer's tree. It gets the root layer's checking if no layer
in between would prevent convertToLayerCoords to work and return the position relative to
this layer.
(WebCore::RenderLayer::updateLayerPositions): Added a new ASSERT to make sure our cachedOffset
is always fine. Also added a comment about calling convertToLayerCoords.
(WebCore::RenderLayer::removeOnlyThisLayer): Added cachedOffset here too as we may have to
update several layers. We save the offset prior to being removed from the hierarchy for
correctness.
(WebCore::RenderLayer::paintChildLayerIntoColumns): Added a comment here about calling convertToLayerCoords.
* rendering/RenderLayer.h: Swapped the argument in updateLayerPositions to make
cachedOffset a mandatory field. Patched all the callers.
(WebCore::RenderLayer::canUseConvertToLayerCoords): Added this helper method to know when a
renderer prevents convertToLayerCoords from working. Added some FIXME around suspicious use
of convertToLayerCoords.
LayoutTests:
* fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
* fast/layers/crash-RenderLayer-update-positions.html: Added.
Test that some changes in the layers does not cause an ASSERT failure.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
Added Paths
trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions-expected.txt
trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94463 => 94464)
--- trunk/LayoutTests/ChangeLog 2011-09-02 23:58:05 UTC (rev 94463)
+++ trunk/LayoutTests/ChangeLog 2011-09-03 00:07:44 UTC (rev 94464)
@@ -1,3 +1,14 @@
+2011-09-02 Julien Chaffraix jchaffr...@webkit.org
+
+Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
+https://bugs.webkit.org/show_bug.cgi?id=66901
+
+Reviewed by Simon Fraser.
+
+* fast/layers/crash-RenderLayer-update-positions-expected.txt: Added.
+* fast/layers/crash-RenderLayer-update-positions.html: Added.
+Test that some changes in the layers does not cause an ASSERT failure.
+
2011-09-02 Dan Bernstein m...@apple.com
rdar://problem/9755843 anonymous RenderMathMLOperator sets itself as the renderer of its parent mfenced node
Added: trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions-expected.txt (0 => 94464)
--- trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions-expected.txt 2011-09-03 00:07:44 UTC (rev 94464)
@@ -0,0 +1 @@
+Test for bug 66901. The test passes if it does not ASSERT.
Added: trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions.html (0 => 94464)
--- trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions.html (rev 0)
+++ trunk/LayoutTests/fast/layers/assert-RenderLayer-update-positions.html 2011-09-03 00:07:44 UTC (rev 94464)
@@ -0,0 +1,45 @@
+!DOCTYPE html
+html
+head
+style
+.no-js {
+position:
[webkit-changes] [94465] trunk/Source/WebCore
Title: [94465] trunk/Source/WebCore
Revision 94465
Author je...@apple.com
Date 2011-09-02 17:16:09 -0700 (Fri, 02 Sep 2011)
Log Message
Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
https://bugs.webkit.org/show_bug.cgi?id=67541
Reviewed by Simon Fraser.
No new tests, covered by existing media tests.
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94464 => 94465)
--- trunk/Source/WebCore/ChangeLog 2011-09-03 00:07:44 UTC (rev 94464)
+++ trunk/Source/WebCore/ChangeLog 2011-09-03 00:16:09 UTC (rev 94465)
@@ -1,3 +1,15 @@
+2011-09-02 Jeff Miller je...@apple.com
+
+Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=67541
+
+Reviewed by Simon Fraser.
+
+No new tests, covered by existing media tests.
+
+* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
+(PlatformCALayerWinInternal::displayCallback): Assert that is function is only called on the main thread.
+
2011-09-02 Julien Chaffraix jchaffr...@webkit.org
Enable RenderLayer::updateLayerPosition's cachedOffset optimization for more cases
Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp (94464 => 94465)
--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2011-09-03 00:07:44 UTC (rev 94464)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp 2011-09-03 00:16:09 UTC (rev 94465)
@@ -34,6 +34,7 @@
#include PlatformCALayer.h
#include TextRun.h
#include QuartzCore/CACFLayer.h
+#include wtf/MainThread.h
using namespace std;
using namespace WebCore;
@@ -62,6 +63,8 @@
void PlatformCALayerWinInternal::displayCallback(CACFLayerRef caLayer, CGContextRef context)
{
+ASSERT(isMainThread());
+
if (!owner() || !owner()-owner())
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94466] trunk/Source
Title: [94466] trunk/Source Revision 94466 Author commit-qu...@webkit.org Date 2011-09-02 17:17:39 -0700 (Fri, 02 Sep 2011) Log Message Source/WebCore: Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader, SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient, and ThreadableLoaderClient for the Chromium port only, so we can pass these notifications from our ResourceHandle implementation through the WebCore loader framework. https://bugs.webkit.org/show_bug.cgi?id=67229 Patch by Bill Budge bbu...@chromium.org on 2011-09-02 Reviewed by Darin Fisher. No new tests. Exposes no new functionality. * WebCore.gypi: * loader/DocumentThreadableLoader.h: * loader/ResourceLoader.h: * loader/SubresourceLoader.h: * loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didDownloadData): * loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didDownloadData): * loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didDownloadData): * loader/chromium: Added. * loader/chromium/DocumentThreadableLoaderChromium.cpp: Added. (WebCore::DocumentThreadableLoader::didDownloadData): * loader/chromium/ResourceLoaderChromium.cpp: Added. (WebCore::ResourceLoader::didDownloadData): * loader/chromium/SubresourceLoaderChromium.cpp: Added. (WebCore::SubresourceLoader::didDownloadData): * platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didDownloadData): Source/WebKit/chromium: Add a 'didDownloadData' method to ResourceHandleInternal and pass these notifications to WebURLLoaderClients. https://bugs.webkit.org/show_bug.cgi?id=67229 Patch by Bill Budge bbu...@chromium.org on 2011-09-02 Reviewed by Darin Fisher. * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter): (WebKit::AssociatedURLLoader::ClientAdapter::didDownloadData): (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading): * src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didDownloadData): * src/ResourceHandleInternal.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/loader/DocumentThreadableLoader.h trunk/Source/WebCore/loader/ResourceLoader.h trunk/Source/WebCore/loader/SubresourceLoader.h trunk/Source/WebCore/loader/SubresourceLoaderClient.h trunk/Source/WebCore/loader/ThreadableLoaderClient.h trunk/Source/WebCore/loader/ThreadableLoaderClientWrapper.h trunk/Source/WebCore/platform/network/ResourceHandleClient.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/AssociatedURLLoader.cpp trunk/Source/WebKit/chromium/src/ResourceHandle.cpp trunk/Source/WebKit/chromium/src/ResourceHandleInternal.h Added Paths trunk/Source/WebCore/loader/chromium/ trunk/Source/WebCore/loader/chromium/DocumentThreadableLoaderChromium.cpp trunk/Source/WebCore/loader/chromium/ResourceLoaderChromium.cpp trunk/Source/WebCore/loader/chromium/SubresourceLoaderChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (94465 => 94466) --- trunk/Source/WebCore/ChangeLog 2011-09-03 00:16:09 UTC (rev 94465) +++ trunk/Source/WebCore/ChangeLog 2011-09-03 00:17:39 UTC (rev 94466) @@ -1,3 +1,36 @@ +2011-09-02 Bill Budge bbu...@chromium.org + +Add a 'didDownloadData' method to ResourceLoader, SubresourceLoader, +SubresourceLoaderClient, DocumentThreadableLoader, ResourceHandleClient, +and ThreadableLoaderClient for the Chromium port only, so we can pass +these notifications from our ResourceHandle implementation through the +WebCore loader framework. +https://bugs.webkit.org/show_bug.cgi?id=67229 + +Reviewed by Darin Fisher. + +No new tests. Exposes no new functionality. + +* WebCore.gypi: +* loader/DocumentThreadableLoader.h: +* loader/ResourceLoader.h: +* loader/SubresourceLoader.h: +* loader/SubresourceLoaderClient.h: +(WebCore::SubresourceLoaderClient::didDownloadData): +* loader/ThreadableLoaderClient.h: +(WebCore::ThreadableLoaderClient::didDownloadData): +* loader/ThreadableLoaderClientWrapper.h: +(WebCore::ThreadableLoaderClientWrapper::didDownloadData): +* loader/chromium: Added. +* loader/chromium/DocumentThreadableLoaderChromium.cpp: Added. +(WebCore::DocumentThreadableLoader::didDownloadData): +* loader/chromium/ResourceLoaderChromium.cpp: Added. +(WebCore::ResourceLoader::didDownloadData): +* loader/chromium/SubresourceLoaderChromium.cpp: Added. +(WebCore::SubresourceLoader::didDownloadData): +* platform/network/ResourceHandleClient.h: +(WebCore::ResourceHandleClient::didDownloadData): + 2011-09-02 Jeff Miller je...@apple.com Assert that PlatformCALayerWinInternal::displayCallback() is only called on the main thread Modified:
[webkit-changes] [94468] trunk/Source/JavaScriptCore
Title: [94468] trunk/Source/_javascript_Core
Revision 94468
Author msab...@apple.com
Date 2011-09-02 17:20:43 -0700 (Fri, 02 Sep 2011)
Log Message
Add JSC:RegExp functional test data generator
https://bugs.webkit.org/show_bug.cgi?id=67519
Add a data generator for regular expressions. To enable, change the
#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
regular expressions. The resulting data will be in /tmp/RegExpTestsData.
Reviewed by Gavin Barraclough.
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::clearRegExp):
(JSC::RegExpFunctionalTestCollector::get):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
(JSC::RegExp::~RegExp):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::matchCompareWithInterpreter):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExp.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94467 => 94468)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-03 00:20:41 UTC (rev 94467)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-03 00:20:43 UTC (rev 94468)
@@ -1,3 +1,27 @@
+2011-09-02 Michael Saboff msab...@apple.com
+
+Add JSC:RegExp functional test data generator
+https://bugs.webkit.org/show_bug.cgi?id=67519
+
+Add a data generator for regular expressions. To enable, change the
+#undef REGEXP_FUNC_TEST_DATA_GEN to #define. Then compile and use
+regular expressions. The resulting data will be in /tmp/RegExpTestsData.
+
+Reviewed by Gavin Barraclough.
+
+* runtime/RegExp.cpp:
+(JSC::regExpFlags):
+(JSC::RegExpFunctionalTestCollector::clearRegExp):
+(JSC::RegExpFunctionalTestCollector::get):
+(JSC::RegExpFunctionalTestCollector::outputOneTest):
+(JSC::RegExpFunctionalTestCollector::RegExpFunctionalTestCollector):
+(JSC::RegExpFunctionalTestCollector::~RegExpFunctionalTestCollector):
+(JSC::RegExpFunctionalTestCollector::outputEscapedUString):
+(JSC::RegExp::~RegExp):
+(JSC::RegExp::compile):
+(JSC::RegExp::match):
+(JSC::RegExp::matchCompareWithInterpreter):
+
2011-09-02 Mark Hahnenberg mhahnenb...@apple.com
Fix the broken build due to dtoa patch
Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (94467 => 94468)
--- trunk/Source/_javascript_Core/runtime/RegExp.cpp 2011-09-03 00:20:41 UTC (rev 94467)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp 2011-09-03 00:20:43 UTC (rev 94468)
@@ -33,6 +33,9 @@
#include wtf/Assertions.h
#include wtf/OwnArrayPtr.h
+
+#define REGEXP_FUNC_TEST_DATA_GEN 0
+
namespace JSC {
const ClassInfo RegExp::s_info = { RegExp, 0, 0, 0 };
@@ -68,7 +71,152 @@
return flags;
}
-
+
+#if REGEXP_FUNC_TEST_DATA_GEN
+class RegExpFunctionalTestCollector {
+// This class is not thread safe.
+protected:
+static const char* const s_fileName;
+
+public:
+static RegExpFunctionalTestCollector* get();
+
+~RegExpFunctionalTestCollector();
+
+void outputOneTest(RegExp*, UString, int, int*, int);
+void clearRegExp(RegExp* regExp)
+{
+if (regExp == m_lastRegExp)
+m_lastRegExp = 0;
+}
+
+private:
+RegExpFunctionalTestCollector();
+
+void outputEscapedUString(const UString, bool escapeSlash = false);
+
+static RegExpFunctionalTestCollector* s_instance;
+FILE* m_file;
+RegExp* m_lastRegExp;
+};
+
+const char* const RegExpFunctionalTestCollector::s_fileName = /tmp/RegExpTestsData;
+RegExpFunctionalTestCollector* RegExpFunctionalTestCollector::s_instance = 0;
+
+RegExpFunctionalTestCollector* RegExpFunctionalTestCollector::get()
+{
+if (!s_instance)
+s_instance = new RegExpFunctionalTestCollector();
+
+return s_instance;
+}
+
+void RegExpFunctionalTestCollector::outputOneTest(RegExp* regExp, UString s, int startOffset, int* ovector, int result)
+{
+if ((!m_lastRegExp) || (m_lastRegExp != regExp)) {
+m_lastRegExp = regExp;
+fputc('/', m_file);
+outputEscapedUString(regExp-pattern(), true);
+fputc('/', m_file);
+if (regExp-global())
+fputc('g', m_file);
+if (regExp-ignoreCase())
+fputc('i', m_file);
+if (regExp-multiline())
+fputc('m', m_file);
+fprintf(m_file, \n);
+}
+
+fprintf(m_file, \);
+outputEscapedUString(s);
+fprintf(m_file, \, %d, %d, (, startOffset, result);
+for (unsigned i = 0; i = regExp-numSubpatterns(); i++) {
+int subPatternBegin = ovector[i * 2];
+int subPatternEnd = ovector[i * 2 + 1];
+if (subPatternBegin == -1)
+subPatternEnd = -1;
+fprintf(m_file, %d, %d, subPatternBegin,
[webkit-changes] [94472] trunk/Source/WebKit2
Title: [94472] trunk/Source/WebKit2 Revision 94472 Author msab...@apple.com Date 2011-09-02 18:01:35 -0700 (Fri, 02 Sep 2011) Log Message 2011-09-02 Michael Saboff msab...@apple.com Fixed release build by removing #ifndef NDEBUG to allow definition of gcController(). Rubber-stamp by Sam Weinig. * WebProcess/WebProcess.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (94471 => 94472) --- trunk/Source/WebKit2/ChangeLog 2011-09-03 00:42:36 UTC (rev 94471) +++ trunk/Source/WebKit2/ChangeLog 2011-09-03 01:01:35 UTC (rev 94472) @@ -1,3 +1,12 @@ +2011-09-02 Michael Saboff msab...@apple.com + +Fixed release build by removing #ifndef NDEBUG to +allow definition of gcController(). + +Rubber-stamp by Sam Weinig. + +* WebProcess/WebProcess.cpp: + 2011-09-02 Anders Carlsson ander...@apple.com NPN_SetException doesn't work with OOP plug-ins Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (94471 => 94472) --- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-03 00:42:36 UTC (rev 94471) +++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-03 01:01:35 UTC (rev 94472) @@ -59,6 +59,7 @@ #include WebCore/CrossOriginPreflightResultCache.h #include WebCore/Font.h #include WebCore/FontCache.h +#include WebCore/GCController.h #include WebCore/GlyphPageTreeNode.h #include WebCore/IconDatabase.h #include WebCore/JSDOMWindow.h @@ -78,10 +79,6 @@ #include wtf/PassRefPtr.h #include wtf/RandomNumber.h -#ifndef NDEBUG -#include WebCore/GCController.h -#endif - #if !OS(WINDOWS) #include unistd.h #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94475] trunk/Source/JavaScriptCore
Title: [94475] trunk/Source/_javascript_Core
Revision 94475
Author msab...@apple.com
Date 2011-09-02 18:08:10 -0700 (Fri, 02 Sep 2011)
Log Message
Replace local implementation of string equals() methods with UString versions
https://bugs.webkit.org/show_bug.cgi?id=67342
In preparation to allowing StringImpl to be backed by 8 bit
characters when appropriate, we need to eliminate or change the
usage of StringImpl::characters(). Change the uses of characters()
that are used to implement redundant equals() methods.
Reviewed by Gavin Barraclough.
* runtime/Identifier.cpp:
(JSC::Identifier::equal):
* runtime/Identifier.h:
(JSC::Identifier::equal):
* wtf/text/AtomicString.cpp:
(WTF::CStringTranslator::equal): Moved an optimized method to here.
(WTF::operator==):
* wtf/text/StringImpl.cpp:
(WTF::equal):
* wtf/text/StringImpl.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/runtime/Identifier.cpp
trunk/Source/_javascript_Core/runtime/Identifier.h
trunk/Source/_javascript_Core/wtf/text/AtomicString.cpp
trunk/Source/_javascript_Core/wtf/text/AtomicString.h
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94474 => 94475)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-03 01:06:27 UTC (rev 94474)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-03 01:08:10 UTC (rev 94475)
@@ -1,5 +1,28 @@
2011-09-02 Michael Saboff msab...@apple.com
+Replace local implementation of string equals() methods with UString versions
+https://bugs.webkit.org/show_bug.cgi?id=67342
+
+In preparation to allowing StringImpl to be backed by 8 bit
+characters when appropriate, we need to eliminate or change the
+usage of StringImpl::characters(). Change the uses of characters()
+that are used to implement redundant equals() methods.
+
+Reviewed by Gavin Barraclough.
+
+* runtime/Identifier.cpp:
+(JSC::Identifier::equal):
+* runtime/Identifier.h:
+(JSC::Identifier::equal):
+* wtf/text/AtomicString.cpp:
+(WTF::CStringTranslator::equal): Moved an optimized method to here.
+(WTF::operator==):
+* wtf/text/StringImpl.cpp:
+(WTF::equal):
+* wtf/text/StringImpl.h:
+
+2011-09-02 Michael Saboff msab...@apple.com
+
Add JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67339
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (94474 => 94475)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-03 01:06:27 UTC (rev 94474)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-09-03 01:08:10 UTC (rev 94475)
@@ -108,7 +108,6 @@
__ZN3JSC10Identifier3addEPNS_9ExecStateEPKc
__ZN3JSC10Identifier4fromEPNS_9ExecStateEi
__ZN3JSC10Identifier4fromEPNS_9ExecStateEj
-__ZN3JSC10Identifier5equalEPKN3WTF10StringImplEPKc
__ZN3JSC10Identifier8toUInt32ERKNS_7UStringERb
__ZN3JSC10JSFunction14finishCreationEPNS_9ExecStateEPNS_14JSGlobalObjectEPNS_18FunctionExecutableEPNS_14ScopeChainNodeE
__ZN3JSC10JSFunction14finishCreationEPNS_9ExecStateEPNS_14JSGlobalObjectEiRKNS_10IdentifierEPNS_14ExecutableBaseE
@@ -477,6 +476,7 @@
__ZN3WTF5MutexC1Ev
__ZN3WTF5MutexD1Ev
__ZN3WTF5equalEPKNS_10StringImplEPKc
+__ZN3WTF5equalEPKNS_10StringImplEPKtj
__ZN3WTF5equalEPKNS_10StringImplES2_
__ZN3WTF5yieldEv
__ZN3WTF6String26fromUTF8WithLatin1FallbackEPKcm
@@ -524,8 +524,6 @@
__ZN3WTF9dayInYearEdi
__ZN3WTF9emptyAtomE
__ZN3WTF9xmlnsAtomE
-__ZN3WTFeqERKNS_12AtomicStringEPKc
-__ZN3WTFeqERKNS_12AtomicStringERKNS_6VectorItLm0EEE
__ZN3WTFeqERKNS_7CStringES2_
__ZNK3JSC10JSFunction23isHostFunctionNonInlineEv
__ZNK3JSC11Interpreter14retrieveCallerEPNS_9ExecStateEPNS_10JSFunctionE
Modified: trunk/Source/_javascript_Core/runtime/Identifier.cpp (94474 => 94475)
--- trunk/Source/_javascript_Core/runtime/Identifier.cpp 2011-09-03 01:06:27 UTC (rev 94474)
+++ trunk/Source/_javascript_Core/runtime/Identifier.cpp 2011-09-03 01:08:10 UTC (rev 94475)
@@ -67,16 +67,6 @@
delete table;
}
-bool Identifier::equal(const StringImpl* r, const char* s)
-{
-int length = r-length();
-const UChar* d = r-characters();
-for (int i = 0; i != length; ++i)
-if (d[i] != (unsigned char)s[i])
-return false;
-return s[length] == 0;
-}
-
struct IdentifierCStringTranslator {
static unsigned hash(const char* c)
{
Modified: trunk/Source/_javascript_Core/runtime/Identifier.h (94474 => 94475)
--- trunk/Source/_javascript_Core/runtime/Identifier.h 2011-09-03 01:06:27 UTC (rev 94474)
+++ trunk/Source/_javascript_Core/runtime/Identifier.h 2011-09-03 01:08:10 UTC (rev 94475)
@@ -135,15 +135,14 @@
return !Identifier::equal(a, b);
}
+inline bool Identifier::equal(const StringImpl* r, const char* s)
+{
+return
[webkit-changes] [94476] trunk/Source/WebKit2
Title: [94476] trunk/Source/WebKit2
Revision 94476
Author commit-qu...@webkit.org
Date 2011-09-02 18:20:49 -0700 (Fri, 02 Sep 2011)
Log Message
Unreviewed, rolling out r94473.
http://trac.webkit.org/changeset/94473
https://bugs.webkit.org/show_bug.cgi?id=67547
Putting http://trac.webkit.org/changeset/94454 back in as
http://trac.webkit.org/changeset/94472 fixed the problem
(Requested by msaboff on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-02
* UIProcess/API/C/WKContext.cpp:
(WKContextGarbageCollectJavaScriptObjects):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::garbageCollectJavaScriptObjects):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::garbageCollectJavaScriptObjects):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h
trunk/Source/WebKit2/WebProcess/WebProcess.messages.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (94475 => 94476)
--- trunk/Source/WebKit2/ChangeLog 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/ChangeLog 2011-09-03 01:20:49 UTC (rev 94476)
@@ -1,5 +1,26 @@
2011-09-02 Sheriff Bot webkit.review@gmail.com
+Unreviewed, rolling out r94473.
+http://trac.webkit.org/changeset/94473
+https://bugs.webkit.org/show_bug.cgi?id=67547
+
+Putting http://trac.webkit.org/changeset/94454 back in as
+http://trac.webkit.org/changeset/94472 fixed the problem
+(Requested by msaboff on #webkit).
+
+* UIProcess/API/C/WKContext.cpp:
+(WKContextGarbageCollectJavaScriptObjects):
+* UIProcess/API/C/WKContext.h:
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::garbageCollectJavaScriptObjects):
+* UIProcess/WebContext.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::garbageCollectJavaScriptObjects):
+* WebProcess/WebProcess.h:
+* WebProcess/WebProcess.messages.in:
+
+2011-09-02 Sheriff Bot webkit.review@gmail.com
+
Unreviewed, rolling out r94454.
http://trac.webkit.org/changeset/94454
https://bugs.webkit.org/show_bug.cgi?id=67546
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (94475 => 94476)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-09-03 01:20:49 UTC (rev 94476)
@@ -237,3 +237,8 @@
toImpl(contextRef)-getWebCoreStatistics(DictionaryCallback::create(context, callback));
}
+void WKContextGarbageCollectJavaScriptObjects(WKContextRef contextRef)
+{
+toImpl(contextRef)-garbageCollectJavaScriptObjects();
+}
+
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (94475 => 94476)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2011-09-03 01:20:49 UTC (rev 94476)
@@ -140,6 +140,8 @@
typedef void (*WKContextGetStatisticsFunction)(WKDictionaryRef statistics, WKErrorRef error, void* functionContext);
WK_EXPORT void WKContextGetStatistics(WKContextRef context, void* functionContext, WKContextGetStatisticsFunction function);
+
+WK_EXPORT void WKContextGarbageCollectJavaScriptObjects(WKContextRef context);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (94475 => 94476)
--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2011-09-03 01:20:49 UTC (rev 94476)
@@ -829,4 +829,9 @@
callback-performCallbackWithReturnValue(statistics.get());
}
+void WebContext::garbageCollectJavaScriptObjects()
+{
+process()-send(Messages::WebProcess::GarbageCollectJavaScriptObjects(), 0);
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (94475 => 94476)
--- trunk/Source/WebKit2/UIProcess/WebContext.h 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2011-09-03 01:20:49 UTC (rev 94476)
@@ -181,6 +181,7 @@
bool httpPipeliningEnabled();
void getWebCoreStatistics(PassRefPtrDictionaryCallback);
+void garbageCollectJavaScriptObjects();
private:
WebContext(ProcessModel, const String injectedBundlePath);
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (94475 => 94476)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-03 01:08:10 UTC (rev 94475)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2011-09-03 01:20:49 UTC (rev 94476)
@@ -931,6 +931,11 @@
[webkit-changes] [94477] trunk/Source/JavaScriptCore
Title: [94477] trunk/Source/_javascript_Core Revision 94477 Author fpi...@apple.com Date 2011-09-02 22:14:04 -0700 (Fri, 02 Sep 2011) Log Message ValueProfile does not make it safe to introspect cell values after garbage collection https://bugs.webkit.org/show_bug.cgi?id=67354 Reviewed by Gavin Barraclough. ValueProfile buckets are now weak references, implemented using a light-weight weak reference mechanism that this patch also adds (the WeakReferenceHarvester). If a cell stored in a ValueProfile bucket is not marked, then the bucket is transformed into a Structure pointer. If the Structure is not marked either, then it is turned into a ClassInfo pointer. * _javascript_Core.xcodeproj/project.pbxproj: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::visitAggregate): (JSC::CodeBlock::visitWeakReferences): * bytecode/CodeBlock.h: * bytecode/ValueProfile.h: (JSC::ValueProfile::ValueProfile): (JSC::ValueProfile::classInfo): (JSC::ValueProfile::numberOfInt32s): (JSC::ValueProfile::numberOfDoubles): (JSC::ValueProfile::numberOfCells): (JSC::ValueProfile::numberOfArrays): (JSC::ValueProfile::probabilityOfArray): (JSC::ValueProfile::WeakBucket::WeakBucket): (JSC::ValueProfile::WeakBucket::operator!): (JSC::ValueProfile::WeakBucket::isEmpty): (JSC::ValueProfile::WeakBucket::isClassInfo): (JSC::ValueProfile::WeakBucket::isStructure): (JSC::ValueProfile::WeakBucket::asStructure): (JSC::ValueProfile::WeakBucket::asClassInfo): (JSC::ValueProfile::WeakBucket::getClassInfo): * heap/Heap.cpp: (JSC::Heap::harvestWeakReferences): (JSC::Heap::markRoots): * heap/Heap.h: * heap/MarkStack.cpp: (JSC::SlotVisitor::drain): (JSC::SlotVisitor::harvestWeakReferences): * heap/MarkStack.h: (JSC::MarkStack::addWeakReferenceHarvester): (JSC::MarkStack::MarkStack): (JSC::MarkStack::appendUnbarrieredPointer): * heap/SlotVisitor.h: * heap/WeakReferenceHarvester.h: Added. (JSC::WeakReferenceHarvester::WeakReferenceHarvester): (JSC::WeakReferenceHarvester::~WeakReferenceHarvester): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecode/ValueProfile.h trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/_javascript_Core/heap/MarkStack.cpp trunk/Source/_javascript_Core/heap/MarkStack.h trunk/Source/_javascript_Core/heap/SlotVisitor.h Added Paths trunk/Source/_javascript_Core/heap/WeakReferenceHarvester.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94476 => 94477) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-03 01:20:49 UTC (rev 94476) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-03 05:14:04 UTC (rev 94477) @@ -1,3 +1,56 @@ +2011-09-02 Filip Pizlo fpi...@apple.com + +ValueProfile does not make it safe to introspect cell values +after garbage collection +https://bugs.webkit.org/show_bug.cgi?id=67354 + +Reviewed by Gavin Barraclough. + +ValueProfile buckets are now weak references, implemented using a +light-weight weak reference mechanism that this patch also adds (the +WeakReferenceHarvester). If a cell stored in a ValueProfile bucket +is not marked, then the bucket is transformed into a Structure +pointer. If the Structure is not marked either, then it is turned +into a ClassInfo pointer. + +* _javascript_Core.xcodeproj/project.pbxproj: +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::~CodeBlock): +(JSC::CodeBlock::visitAggregate): +(JSC::CodeBlock::visitWeakReferences): +* bytecode/CodeBlock.h: +* bytecode/ValueProfile.h: +(JSC::ValueProfile::ValueProfile): +(JSC::ValueProfile::classInfo): +(JSC::ValueProfile::numberOfInt32s): +(JSC::ValueProfile::numberOfDoubles): +(JSC::ValueProfile::numberOfCells): +(JSC::ValueProfile::numberOfArrays): +(JSC::ValueProfile::probabilityOfArray): +(JSC::ValueProfile::WeakBucket::WeakBucket): +(JSC::ValueProfile::WeakBucket::operator!): +(JSC::ValueProfile::WeakBucket::isEmpty): +(JSC::ValueProfile::WeakBucket::isClassInfo): +(JSC::ValueProfile::WeakBucket::isStructure): +(JSC::ValueProfile::WeakBucket::asStructure): +(JSC::ValueProfile::WeakBucket::asClassInfo): +(JSC::ValueProfile::WeakBucket::getClassInfo): +* heap/Heap.cpp: +(JSC::Heap::harvestWeakReferences): +(JSC::Heap::markRoots): +* heap/Heap.h: +* heap/MarkStack.cpp: +(JSC::SlotVisitor::drain): +(JSC::SlotVisitor::harvestWeakReferences): +* heap/MarkStack.h: +(JSC::MarkStack::addWeakReferenceHarvester): +(JSC::MarkStack::MarkStack): +
[webkit-changes] [94478] trunk/Source/JavaScriptCore
Title: [94478] trunk/Source/_javascript_Core
Revision 94478
Author fpi...@apple.com
Date 2011-09-02 22:23:35 -0700 (Fri, 02 Sep 2011)
Log Message
DFG JIT speculation failure does recovery of additions in reverse and
doesn't rebox
https://bugs.webkit.org/show_bug.cgi?id=67551
Reviewed by Sam Weinig.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94477 => 94478)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-03 05:14:04 UTC (rev 94477)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-03 05:23:35 UTC (rev 94478)
@@ -1,5 +1,16 @@
2011-09-02 Filip Pizlo fpi...@apple.com
+DFG JIT speculation failure does recovery of additions in reverse and
+doesn't rebox
+https://bugs.webkit.org/show_bug.cgi?id=67551
+
+Reviewed by Sam Weinig.
+
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
+
+2011-09-02 Filip Pizlo fpi...@apple.com
+
ValueProfile does not make it safe to introspect cell values
after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=67354
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp (94477 => 94478)
--- trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-09-03 05:14:04 UTC (rev 94477)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp 2011-09-03 05:23:35 UTC (rev 94478)
@@ -495,8 +495,16 @@
if (recovery) {
// The only additional recovery we currently support is for integer add operation
ASSERT(recovery-type() == SpeculativeAdd);
+ASSERT(check.m_gprInfo[GPRInfo::toIndex(recovery-dest())].nodeIndex != NoNode);
// Revert the add.
sub32(recovery-src(), recovery-dest());
+
+// If recovery-dest() should have been boxed prior to the addition, then rebox
+// it.
+DataFormat format = check.m_gprInfo[GPRInfo::toIndex(recovery-dest())].format;
+ASSERT(format == DataFormatInteger || format == DataFormatJSInteger || format == DataFormatJS);
+if (format != DataFormatInteger)
+orPtr(GPRInfo::tagTypeNumberRegister, recovery-dest());
}
// First, we need a reverse mapping that tells us, for a NodeIndex, which register
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94479] trunk/Source/WebKit/chromium
Title: [94479] trunk/Source/WebKit/chromium
Revision 94479
Author aba...@webkit.org
Date 2011-09-02 22:45:08 -0700 (Fri, 02 Sep 2011)
Log Message
Remove WebKitClient.h
https://bugs.webkit.org/show_bug.cgi?id=67539
Reviewed by Sam Weinig.
This API no longer has any callers.
* WebKit.gyp:
* public/WebKit.h:
* public/WebKitClient.h: Removed.
* src/WebKit.cpp:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/public/WebKit.h
trunk/Source/WebKit/chromium/src/WebKit.cpp
Removed Paths
trunk/Source/WebKit/chromium/public/WebKitClient.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94478 => 94479)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-03 05:23:35 UTC (rev 94478)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-03 05:45:08 UTC (rev 94479)
@@ -1,3 +1,17 @@
+2011-09-02 Adam Barth aba...@webkit.org
+
+Remove WebKitClient.h
+https://bugs.webkit.org/show_bug.cgi?id=67539
+
+Reviewed by Sam Weinig.
+
+This API no longer has any callers.
+
+* WebKit.gyp:
+* public/WebKit.h:
+* public/WebKitClient.h: Removed.
+* src/WebKit.cpp:
+
2011-09-02 Bill Budge bbu...@chromium.org
Add a 'didDownloadData' method to ResourceHandleInternal and pass these
Modified: trunk/Source/WebKit/chromium/WebKit.gyp (94478 => 94479)
--- trunk/Source/WebKit/chromium/WebKit.gyp 2011-09-03 05:23:35 UTC (rev 94478)
+++ trunk/Source/WebKit/chromium/WebKit.gyp 2011-09-03 05:45:08 UTC (rev 94479)
@@ -207,7 +207,6 @@
'public/WebInputElement.h',
'public/WebInputEvent.h',
'public/WebKit.h',
-'public/WebKitClient.h',
'public/WebKitPlatformSupport.h',
'public/WebLabelElement.h',
'public/WebLocalizedString.h',
Modified: trunk/Source/WebKit/chromium/public/WebKit.h (94478 => 94479)
--- trunk/Source/WebKit/chromium/public/WebKit.h 2011-09-03 05:23:35 UTC (rev 94478)
+++ trunk/Source/WebKit/chromium/public/WebKit.h 2011-09-03 05:45:08 UTC (rev 94479)
@@ -51,10 +51,6 @@
// Returns the WebKitPlatformSupport instance passed to initialize.
WEBKIT_EXPORT WebKitPlatformSupport* webKitPlatformSupport();
-#ifndef WEBKIT_RENAME_WEBKIT_CLIENT
-WEBKIT_EXPORT WebKitPlatformSupport* webKitClient();
-#endif
-
// Alters the rendering of content to conform to a fixed set of rules.
WEBKIT_EXPORT void setLayoutTestMode(bool);
WEBKIT_EXPORT bool layoutTestMode();
Deleted: trunk/Source/WebKit/chromium/public/WebKitClient.h (94478 => 94479)
--- trunk/Source/WebKit/chromium/public/WebKitClient.h 2011-09-03 05:23:35 UTC (rev 94478)
+++ trunk/Source/WebKit/chromium/public/WebKitClient.h 2011-09-03 05:45:08 UTC (rev 94479)
@@ -1,45 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef WebKitClient_h
-#define WebKitClient_h
-
-// FIXME: Remove this file once we're done renaming WebKitClient to WebKitPlatformSupport.
-#ifndef WEBKIT_RENAME_WEBKIT_CLIENT
-
-#include WebKitPlatformSupport.h
-
-namespace WebKit {
-typedef WebKitPlatformSupport WebKitClient;
-}
-
-#endif
-
-#endif
Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (94478 => 94479)
--- trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-09-03 05:23:35 UTC (rev 94478)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp 2011-09-03 05:45:08 UTC (rev 94479)
@@ -103,13 +103,6 @@
