[webkit-changes] [94947] trunk
Title: [94947] trunk
Revision 94947
Author commit-qu...@webkit.org
Date 2011-09-12 00:14:38 -0700 (Mon, 12 Sep 2011)
Log Message
Characters beyond U+1 should be deleted by one pressing delete key.
https://bugs.webkit.org/show_bug.cgi?id=40351
Patch by Shinya Kawanaka shin...@google.com on 2011-09-12
Reviewed by Kent Tamura.
Source/WebCore:
If a character is the trail part of unicode surrogate pair, the lead part of it
should also be deleted. Also, If in MacOSX, the deletion should honor Mac's behavior.
Test: editing/deleting/delete-surrogatepair.html
* rendering/RenderText.cpp:
(WebCore::RenderText::previousOffsetForBackwardDeletion):
Added if-macro to support chromium on mac, and added trail part check for unicode character.
LayoutTests:
Added deletion tests.
* editing/deleting/delete-surrogatepair-expected.txt: Added.
* editing/deleting/delete-surrogatepair.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderText.cpp
Added Paths
trunk/LayoutTests/editing/deleting/delete-surrogatepair-expected.txt
trunk/LayoutTests/editing/deleting/delete-surrogatepair.html
Property Changed
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/LayoutTests/ChangeLog (94946 => 94947)
--- trunk/LayoutTests/ChangeLog 2011-09-12 05:46:44 UTC (rev 94946)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 07:14:38 UTC (rev 94947)
@@ -1,3 +1,15 @@
+2011-09-12 Shinya Kawanaka shin...@google.com
+
+Characters beyond U+1 should be deleted by one pressing delete key.
+https://bugs.webkit.org/show_bug.cgi?id=40351
+
+Reviewed by Kent Tamura.
+
+Added deletion tests.
+
+* editing/deleting/delete-surrogatepair-expected.txt: Added.
+* editing/deleting/delete-surrogatepair.html: Added.
+
2011-09-11 Kentaro Hara hara...@google.com
Implement a ProgressEvent constructor for V8
Property changes on: trunk/LayoutTests/ChangeLog
___
Deleted: svn:executable
Added: trunk/LayoutTests/editing/deleting/delete-surrogatepair-expected.txt (0 => 94947)
--- trunk/LayoutTests/editing/deleting/delete-surrogatepair-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-surrogatepair-expected.txt 2011-09-12 07:14:38 UTC (rev 94947)
@@ -0,0 +1,13 @@
+This test makes sure that a surrogate-pair character is deleted by one pressing delete key
+
+hoghoge
+hogehoge
+>
+a
+a
+>
+>a
+aa
+a>
+a>a
+a>a
Added: trunk/LayoutTests/editing/deleting/delete-surrogatepair.html (0 => 94947)
--- trunk/LayoutTests/editing/deleting/delete-surrogatepair.html (rev 0)
+++ trunk/LayoutTests/editing/deleting/delete-surrogatepair.html 2011-09-12 07:14:38 UTC (rev 94947)
@@ -0,0 +1,51 @@
+html
+head
+style
+.editing {
+border: 2px solid red;
+padding: 12px;
+font-size: 24px;
+}
+/style
+script src=""
+titleDelete Backward/title
+/head
+
+body
+
+pThis test makes sure that a surrogate-pair character is deleted by one pressing delete key/p
+div contenteditable id=root0 class=editinghogehoge/div
+div contenteditable id=root1 class=editing#x2003E;hogehoge/div
+div contenteditable id=root2 class=editinga#x2003E;/div
+div contenteditable id=root3 class=editinga#x2003E;/div
+div contenteditable id=root4 class=editing#x2003E;a/div
+div contenteditable id=root5 class=editing#x2003E;a/div
+div contenteditable id=root6 class=editinga#x2003E;a/div
+div contenteditable id=root7 class=editinga#x2003E;a/div
+div contenteditable id=root8 class=editinga#x2003E;a/div
+div contenteditable id=root9 class=editinga#x2003E;#x2003E;a/div
+div contenteditable id=root10 class=editinga#x2003E;#x2003E;a/div
+
+script
+if (window.layoutTestController) {
+var pos = [4, 1, 1, 2, 1, 2, 1, 2, 3, 2, 3];
+for (var i = 0; i 11; ++i) {
+var div = document.getElementById(root + i);
+
+div.focus();
+for (var j = 0; j pos[i]; ++j)
+layoutTestController.execCommand(MoveForward);
+
+layoutTestController.execCommand(DeleteBackward);
+}
+
+layoutTestController.dumpAsText();
+} else {
+document.write(This test requires layoutTestController.br);
+document.write(When doing manually, try to delete the above strings by hitting backspace key.);
+}
+
+/script
+
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (94946 => 94947)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 05:46:44 UTC (rev 94946)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 07:14:38 UTC (rev 94947)
@@ -1,3 +1,19 @@
+2011-09-12 Shinya Kawanaka shin...@google.com
+
+Characters beyond U+1 should be deleted by one pressing delete key.
+https://bugs.webkit.org/show_bug.cgi?id=40351
+
+Reviewed by Kent Tamura.
+
+If a character is the trail part of unicode surrogate pair, the lead part of it
+should also be deleted.
[webkit-changes] [94948] trunk/LayoutTests
Title: [94948] trunk/LayoutTests Revision 94948 Author u...@chromium.org Date 2011-09-12 00:21:32 -0700 (Mon, 12 Sep 2011) Log Message Unreviewed, update chromium test expectations. * platform/chromium/test_expectations.txt: perf/show-hide-table-rows.html slow to timeout Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94947 => 94948) --- trunk/LayoutTests/ChangeLog 2011-09-12 07:14:38 UTC (rev 94947) +++ trunk/LayoutTests/ChangeLog 2011-09-12 07:21:32 UTC (rev 94948) @@ -1,3 +1,9 @@ +2011-09-12 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations. + +* platform/chromium/test_expectations.txt: perf/show-hide-table-rows.html slow to timeout + 2011-09-12 Shinya Kawanaka shin...@google.com Characters beyond U+1 should be deleted by one pressing delete key. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94947 => 94948) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 07:14:38 UTC (rev 94947) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 07:21:32 UTC (rev 94948) @@ -40,8 +40,10 @@ BUGCR24182 SLOW LINUX WIN DEBUG : perf/array-reverse.html = PASS BUGWK67919 SLOW DEBUG : perf/document-contains.html = PASS -BUGWK67921 SLOW DEBUG : perf/show-hide-table-rows.html = PASS +// show-hide-table-rows.html on DEBUG takes more than 60s. (as of Sep 12, 2011) +BUGWK67921 DEBUG : perf/show-hide-table-rows.html = TIMEOUT + // - // TEMPORARILY SKIPPED TESTS // - ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94949] trunk/LayoutTests
Title: [94949] trunk/LayoutTests Revision 94949 Author u...@chromium.org Date 2011-09-12 01:09:07 -0700 (Mon, 12 Sep 2011) Log Message Unreviewed, update chromium test expectations. * platform/chromium/test_expectations.txt: add fast/events/constructors/progress-event-constructor.html Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94948 => 94949) --- trunk/LayoutTests/ChangeLog 2011-09-12 07:21:32 UTC (rev 94948) +++ trunk/LayoutTests/ChangeLog 2011-09-12 08:09:07 UTC (rev 94949) @@ -2,6 +2,12 @@ Unreviewed, update chromium test expectations. +* platform/chromium/test_expectations.txt: add fast/events/constructors/progress-event-constructor.html + +2011-09-12 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations. + * platform/chromium/test_expectations.txt: perf/show-hide-table-rows.html slow to timeout 2011-09-12 Shinya Kawanaka shin...@google.com Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94948 => 94949) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 07:21:32 UTC (rev 94948) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 08:09:07 UTC (rev 94949) @@ -3728,3 +3728,6 @@ // new test at r94897 BUGWK67917 MAC LEOPARD : svg/custom/simple-text-double-shadow.svg = IMAGE + +// Failing after r94946 +BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94950] trunk/LayoutTests
Title: [94950] trunk/LayoutTests Revision 94950 Author zol...@webkit.org Date 2011-09-12 01:45:22 -0700 (Mon, 12 Sep 2011) Log Message [Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing https://bugs.webkit.org/show_bug.cgi?id=67927 Skip it. * platform/qt-arm/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-arm/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (94949 => 94950) --- trunk/LayoutTests/ChangeLog 2011-09-12 08:09:07 UTC (rev 94949) +++ trunk/LayoutTests/ChangeLog 2011-09-12 08:45:22 UTC (rev 94950) @@ -1,3 +1,12 @@ +2011-09-12 Zoltan Horvath zol...@webkit.org + +[Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing +https://bugs.webkit.org/show_bug.cgi?id=67927 + +Skip it. + +* platform/qt-arm/Skipped: + 2011-09-12 Fumitoshi Ukai u...@chromium.org Unreviewed, update chromium test expectations. Modified: trunk/LayoutTests/platform/qt-arm/Skipped (94949 => 94950) --- trunk/LayoutTests/platform/qt-arm/Skipped 2011-09-12 08:09:07 UTC (rev 94949) +++ trunk/LayoutTests/platform/qt-arm/Skipped 2011-09-12 08:45:22 UTC (rev 94950) @@ -96,3 +96,7 @@ # [Qt][ARM]fast/dom/call-a-constructor-as-a-function.html fails # https://bugs.webkit.org/show_bug.cgi?id=67639 fast/dom/call-a-constructor-as-a-function.html + +# [Qt][ARMv5] fast/events/constructors/progress-event-constructor.html fails +# https://bugs.webkit.org/show_bug.cgi?id=67927 +fast/events/constructors/progress-event-constructor.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94951] trunk/Source/WebCore
Title: [94951] trunk/Source/WebCore
Revision 94951
Author commit-qu...@webkit.org
Date 2011-09-12 02:48:39 -0700 (Mon, 12 Sep 2011)
Log Message
Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
https://bugs.webkit.org/show_bug.cgi?id=67916
Patch by Andreas Kling kl...@webkit.org on 2011-09-12
Reviewed by Kenneth Rohde Christiansen.
* html/canvas/CanvasGradient.cpp:
(WebCore::CanvasGradient::CanvasGradient):
(WebCore::CanvasGradient::addColorStop):
* html/canvas/CanvasGradient.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasGradient.cpp
trunk/Source/WebCore/html/canvas/CanvasGradient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94950 => 94951)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 08:45:22 UTC (rev 94950)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 09:48:39 UTC (rev 94951)
@@ -1,3 +1,15 @@
+2011-09-12 Andreas Kling kl...@webkit.org
+
+Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
+https://bugs.webkit.org/show_bug.cgi?id=67916
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* html/canvas/CanvasGradient.cpp:
+(WebCore::CanvasGradient::CanvasGradient):
+(WebCore::CanvasGradient::addColorStop):
+* html/canvas/CanvasGradient.h:
+
2011-09-12 Shinya Kawanaka shin...@google.com
Characters beyond U+1 should be deleted by one pressing delete key.
Modified: trunk/Source/WebCore/html/canvas/CanvasGradient.cpp (94950 => 94951)
--- trunk/Source/WebCore/html/canvas/CanvasGradient.cpp 2011-09-12 08:45:22 UTC (rev 94950)
+++ trunk/Source/WebCore/html/canvas/CanvasGradient.cpp 2011-09-12 09:48:39 UTC (rev 94951)
@@ -36,13 +36,17 @@
CanvasGradient::CanvasGradient(const FloatPoint p0, const FloatPoint p1)
: m_gradient(Gradient::create(p0, p1))
+#if ENABLE(DASHBOARD_SUPPORT)
, m_dashbardCompatibilityMode(false)
+#endif
{
}
CanvasGradient::CanvasGradient(const FloatPoint p0, float r0, const FloatPoint p1, float r1)
: m_gradient(Gradient::create(p0, r0, p1, r1))
+#if ENABLE(DASHBOARD_SUPPORT)
, m_dashbardCompatibilityMode(false)
+#endif
{
}
@@ -55,8 +59,12 @@
RGBA32 rgba = 0;
if (!parseColorOrCurrentColor(rgba, color, 0 /*canvas*/)) {
+#if ENABLE(DASHBOARD_SUPPORT)
if (!m_dashbardCompatibilityMode)
ec = SYNTAX_ERR;
+#else
+ec = SYNTAX_ERR;
+#endif
return;
}
Modified: trunk/Source/WebCore/html/canvas/CanvasGradient.h (94950 => 94951)
--- trunk/Source/WebCore/html/canvas/CanvasGradient.h 2011-09-12 08:45:22 UTC (rev 94950)
+++ trunk/Source/WebCore/html/canvas/CanvasGradient.h 2011-09-12 09:48:39 UTC (rev 94951)
@@ -62,7 +62,9 @@
CanvasGradient(const FloatPoint p0, float r0, const FloatPoint p1, float r1);
RefPtrGradient m_gradient;
+#if ENABLE(DASHBOARD_SUPPORT)
bool m_dashbardCompatibilityMode;
+#endif
};
} //namespace
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94952] trunk/Source/JavaScriptCore
Title: [94952] trunk/Source/_javascript_Core
Revision 94952
Author par...@webkit.org
Date 2011-09-12 04:03:02 -0700 (Mon, 12 Sep 2011)
Log Message
Unreviewed build fix after r94871.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/FastMalloc.cpp:
* wtf/RefCountedLeakCounter.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp
trunk/Source/_javascript_Core/wtf/FastMalloc.cpp
trunk/Source/_javascript_Core/wtf/RefCountedLeakCounter.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94951 => 94952)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-12 09:48:39 UTC (rev 94951)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-12 11:03:02 UTC (rev 94952)
@@ -1,3 +1,12 @@
+2011-09-12 Patrick Gansterer par...@webkit.org
+
+Unreviewed build fix after r94871.
+
+* runtime/InitializeThreading.cpp:
+(JSC::initializeThreadingOnce):
+* wtf/FastMalloc.cpp:
+* wtf/RefCountedLeakCounter.h:
+
2011-09-11 Filip Pizlo fpi...@apple.com
DFGNode.h has macros that indicate the enabling of a feature, but
Modified: trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp (94951 => 94952)
--- trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2011-09-12 09:48:39 UTC (rev 94951)
+++ trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp 2011-09-12 11:03:02 UTC (rev 94952)
@@ -56,7 +56,9 @@
WriteBarrierCounters::initialize();
#endif
JSGlobalData::storeVPtrs();
+#if ENABLE(JIT) ENABLE(ASSEMBLER)
ExecutableAllocator::initializeAllocator();
+#endif
#if ENABLE(JSC_MULTIPLE_THREADS)
RegisterFile::initializeThreading();
#endif
Modified: trunk/Source/_javascript_Core/wtf/FastMalloc.cpp (94951 => 94952)
--- trunk/Source/_javascript_Core/wtf/FastMalloc.cpp 2011-09-12 09:48:39 UTC (rev 94951)
+++ trunk/Source/_javascript_Core/wtf/FastMalloc.cpp 2011-09-12 11:03:02 UTC (rev 94952)
@@ -80,11 +80,11 @@
#include Assertions.h
#include limits
#if ENABLE(WTF_MULTIPLE_THREADS)
-#if OS(WINDOWS) PLATFORM(CHROMIUM)
+#if OS(WINDOWS) PLATFORM(CHROMIUM) || OS(WINCE) PLATFORM(WIN)
#include windows.h
#else
#include pthread.h
-#endif // OS(WINDOWS)
+#endif // OS(WINDOWS) PLATFORM(CHROMIUM) || OS(WINCE) PLATFORM(WIN)
#endif
#include wtf/StdLibExtras.h
@@ -107,8 +107,13 @@
namespace WTF {
#if ENABLE(WTF_MULTIPLE_THREADS)
-#if OS(WINDOWS) PLATFORM(CHROMIUM)
+#if OS(WINDOWS) PLATFORM(CHROMIUM) || OS(WINCE) PLATFORM(WIN)
+// TLS_OUT_OF_INDEXES is not defined on WinCE.
+#ifndef TLS_OUT_OF_INDEXES
+#define TLS_OUT_OF_INDEXES 0x
+#endif
+
static DWORD isForibiddenTlsIndex = TLS_OUT_OF_INDEXES;
static const LPVOID kTlsAllowValue = reinterpret_castLPVOID(0); // Must be zero.
static const LPVOID kTlsForbiddenValue = reinterpret_castLPVOID(1);
@@ -165,7 +170,7 @@
pthread_once(isForbiddenKeyOnce, initializeIsForbiddenKey);
pthread_setspecific(isForbiddenKey, 0);
}
-#endif // OS(WINDOWS) PLATFORM(CHROMIUM)
+#endif // OS(WINDOWS) PLATFORM(CHROMIUM) || OS(WINCE) PLATFORM(WIN)
#else
static bool staticIsForbidden;
Modified: trunk/Source/_javascript_Core/wtf/RefCountedLeakCounter.h (94951 => 94952)
--- trunk/Source/_javascript_Core/wtf/RefCountedLeakCounter.h 2011-09-12 09:48:39 UTC (rev 94951)
+++ trunk/Source/_javascript_Core/wtf/RefCountedLeakCounter.h 2011-09-12 11:03:02 UTC (rev 94952)
@@ -38,7 +38,11 @@
#ifndef NDEBUG
private:
+#if COMPILER(MINGW) || COMPILER(MSVC7_OR_LOWER) || OS(WINCE)
+int m_count;
+#else
volatile int m_count;
+#endif
const char* m_description;
#endif
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94953] trunk
Title: [94953] trunk
Revision 94953
Author commit-qu...@webkit.org
Date 2011-09-12 04:09:55 -0700 (Mon, 12 Sep 2011)
Log Message
Implement a WebKitAnimationEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67922
Patch by Kentaro Hara hara...@google.com on 2011-09-12
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/webkit-animation-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
* dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.
LayoutTests:
Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
trunk/Source/WebCore/dom/WebKitAnimationEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (94952 => 94953)
--- trunk/LayoutTests/ChangeLog 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 11:09:55 UTC (rev 94953)
@@ -1,3 +1,14 @@
+2011-09-12 Kentaro Hara hara...@google.com
+
+Implement a WebKitAnimationEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=67922
+
+Reviewed by Adam Barth.
+
+Enabled webkit-animation-event-constructor.html, since now V8 has a WebKitAnimationEvent constructor.
+
+* platform/chromium/test_expectations.txt:
+
2011-09-12 Zoltan Horvath zol...@webkit.org
[Qt][ARMv5] fast/events/constructors/progress-event-constructor.html is failing
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94952 => 94953)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 11:09:55 UTC (rev 94953)
@@ -68,9 +68,6 @@
BUGWK60877 SKIP : loader/navigation-while-deferring-loads.html = FAIL
BUGWK60877 SKIP : loader/load-defer-resume-crash.html = FAIL
-// This will soon be fixed after implementing a WebKitAnimationEvent constructor for V8.
-BUGWK67825 : fast/events/constructors/webkit-animation-event-constructor.html = FAIL
-
// CSS3 Selectors3 test suite
BUGCR89468 : css3/selectors3 = PASS FAIL
Modified: trunk/Source/WebCore/ChangeLog (94952 => 94953)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 11:09:55 UTC (rev 94953)
@@ -1,3 +1,15 @@
+2011-09-12 Kentaro Hara hara...@google.com
+
+Implement a WebKitAnimationEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=67922
+
+Reviewed by Adam Barth.
+
+Test: fast/events/constructors/webkit-animation-event-constructor.html
+
+* bindings/v8/custom/V8EventConstructors.cpp: Added the WebKitAnimationEvent constructor.
+* dom/WebKitAnimationEvent.idl: Added a 'V8CustomConstructor' attribute.
+
2011-09-12 Andreas Kling kl...@webkit.org
Shrink CanvasGradient for builds without ENABLE(DASHBOARD_SUPPORT).
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (94952 => 94953)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-09-12 11:09:55 UTC (rev 94953)
@@ -36,6 +36,7 @@
#include DocumentFragment.h
#include Node.h
#include ProgressEvent.h
+#include WebKitAnimationEvent.h
#include OptionsObject.h
#include V8Binding.h
@@ -46,6 +47,7 @@
#include V8Node.h
#include V8ProgressEvent.h
#include V8Proxy.h
+#include V8WebKitAnimationEvent.h
#include wtf/RefPtr.h
@@ -102,6 +104,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CUSTOM_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PROGRESS_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_ANIMATION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/WebKitAnimationEvent.idl (94952 => 94953)
--- trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-09-12 11:03:02 UTC (rev 94952)
+++ trunk/Source/WebCore/dom/WebKitAnimationEvent.idl 2011-09-12 11:09:55 UTC (rev 94953)
@@ -27,7 +27,8 @@
interface [
CanBeConstructed,
-CustomConstructFunction
+CustomConstructFunction,
+V8CustomConstructor
] WebKitAnimationEvent : Event {
readonly attribute DOMString animationName;
readonly attribute double elapsedTime;
[webkit-changes] [94954] trunk/Source/JavaScriptCore
Title: [94954] trunk/Source/_javascript_Core
Revision 94954
Author abe...@webkit.org
Date 2011-09-12 06:33:56 -0700 (Mon, 12 Sep 2011)
Log Message
[Qt] Build fails after r94920 with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67928
Reviewed by Csaba Osztrogonác.
* wtf/RedBlackTree.h:
(WTF::RedBlackTree::insert): Remove dead variables updateStart and newSubTreeRoot.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/RedBlackTree.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94953 => 94954)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-12 11:09:55 UTC (rev 94953)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-12 13:33:56 UTC (rev 94954)
@@ -1,3 +1,13 @@
+2011-09-12 Andras Becsi andras.be...@nokia.com
+
+[Qt] Build fails after r94920 with strict compiler
+https://bugs.webkit.org/show_bug.cgi?id=67928
+
+Reviewed by Csaba Osztrogonác.
+
+* wtf/RedBlackTree.h:
+(WTF::RedBlackTree::insert): Remove dead variables updateStart and newSubTreeRoot.
+
2011-09-12 Patrick Gansterer par...@webkit.org
Unreviewed build fix after r94871.
Modified: trunk/Source/_javascript_Core/wtf/RedBlackTree.h (94953 => 94954)
--- trunk/Source/_javascript_Core/wtf/RedBlackTree.h 2011-09-12 11:09:55 UTC (rev 94953)
+++ trunk/Source/_javascript_Core/wtf/RedBlackTree.h 2011-09-12 13:33:56 UTC (rev 94954)
@@ -171,9 +171,6 @@
treeInsert(x);
x-setColor(Red);
-// The node from which to start propagating updates upwards.
-Node* updateStart = x-parent();
-
while (x != m_root x-parent()-color() == Red) {
if (x-parent() == x-parent()-parent()-left()) {
Node* y = x-parent()-parent()-right();
@@ -183,7 +180,6 @@
y-setColor(Black);
x-parent()-parent()-setColor(Red);
x = x-parent()-parent();
-updateStart = x-parent();
} else {
if (x == x-parent()-right()) {
// Case 2
@@ -193,8 +189,7 @@
// Case 3
x-parent()-setColor(Black);
x-parent()-parent()-setColor(Red);
-Node* newSubTreeRoot = rightRotate(x-parent()-parent());
-updateStart = newSubTreeRoot-parent();
+rightRotate(x-parent()-parent());
}
} else {
// Same as then clause with right and left exchanged.
@@ -205,7 +200,6 @@
y-setColor(Black);
x-parent()-parent()-setColor(Red);
x = x-parent()-parent();
-updateStart = x-parent();
} else {
if (x == x-parent()-left()) {
// Case 2
@@ -215,8 +209,7 @@
// Case 3
x-parent()-setColor(Black);
x-parent()-parent()-setColor(Red);
-Node* newSubTreeRoot = leftRotate(x-parent()-parent());
-updateStart = newSubTreeRoot-parent();
+leftRotate(x-parent()-parent());
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94955] trunk/Tools
Title: [94955] trunk/Tools
Revision 94955
Author kbal...@webkit.org
Date 2011-09-12 07:20:07 -0700 (Mon, 12 Sep 2011)
Log Message
[Qt][WK2] WebKitTestRunner does not produce crash logs
https://bugs.webkit.org/show_bug.cgi?id=67714
Added a simple way of generating backtrace on crash
to the web process. The implementation is similar what
we have in DRT. It depends on GNU libc functionality
so it is only enabled where we are running in such an environment.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::printBacktrace):
(WTR::crashHandler):
(WTR::InjectedBundle::platformInitialize):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (94954 => 94955)
--- trunk/Tools/ChangeLog 2011-09-12 13:33:56 UTC (rev 94954)
+++ trunk/Tools/ChangeLog 2011-09-12 14:20:07 UTC (rev 94955)
@@ -1,3 +1,18 @@
+2011-09-12 Balazs Kelemen kbal...@webkit.org
+
+[Qt][WK2] WebKitTestRunner does not produce crash logs
+https://bugs.webkit.org/show_bug.cgi?id=67714
+
+Added a simple way of generating backtrace on crash
+to the web process. The implementation is similar what
+we have in DRT. It depends on GNU libc functionality
+so it is only enabled where we are running in such an environment.
+
+* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
+(WTR::printBacktrace):
+(WTR::crashHandler):
+(WTR::InjectedBundle::platformInitialize):
+
2011-09-11 Filip Pizlo fpi...@apple.com
Added my IRC nick to the committers file.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp (94954 => 94955)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp 2011-09-12 13:33:56 UTC (rev 94954)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp 2011-09-12 14:20:07 UTC (rev 94955)
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2011 Apple Inc. All rights reserved.
+ * Copyright (C) 2011 University of Szeged. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -25,11 +26,62 @@
#include config.h
#include InjectedBundle.h
+#include stdio.h
+#include stdlib.h
+#include wtf/AlwaysInline.h
+#if HAVE(SIGNAL_H)
+#include signal.h
+#endif
+
+#if defined(__GLIBC__) !defined(__UCLIBC__)
+#include execinfo.h
+#endif
+
namespace WTR {
+static inline void printBacktrace()
+{
+#if defined(__GLIBC__) !defined(__UCLIBC__)
+void* frames[256];
+size_t size = backtrace(frames, 256);
+if (!size)
+return;
+
+char** symbols = backtrace_symbols(frames, size);
+if (!symbols)
+return;
+
+for (unsigned i = 0; i size; ++i)
+fprintf(stderr, %u: %s\n, i, symbols[i]);
+
+fflush(stderr);
+free(symbols);
+#endif
+}
+
+#if HAVE(SIGNAL_H)
+static NO_RETURN void crashHandler(int signal)
+{
+fprintf(stderr, %s\n, strsignal(signal));
+printBacktrace();
+exit(128 + signal);
+}
+#endif
+
void InjectedBundle::platformInitialize(WKTypeRef)
{
+#if HAVE(SIGNAL_H)
+signal(SIGILL, crashHandler);/* 4: illegal instruction (not reset when caught) */
+signal(SIGTRAP, crashHandler); /* 5: trace trap (not reset when caught) */
+signal(SIGFPE, crashHandler);/* 8: floating point exception */
+signal(SIGBUS, crashHandler);/* 10: bus error */
+signal(SIGSEGV, crashHandler); /* 11: segmentation violation */
+signal(SIGSYS, crashHandler);/* 12: bad argument to system call */
+signal(SIGPIPE, crashHandler); /* 13: write on a pipe with no reader */
+signal(SIGXCPU, crashHandler); /* 24: exceeded CPU time limit */
+signal(SIGXFSZ, crashHandler); /* 25: exceeded file size limit */
+#endif
}
} // namespace WTR
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94956] trunk/Tools/ChangeLog
Title: [94956] trunk/Tools/ChangeLog Revision 94956 Author kbal...@webkit.org Date 2011-09-12 07:54:30 -0700 (Mon, 12 Sep 2011) Log Message Oops. Missed the reviewer in my the previous commit. Modified Paths trunk/Tools/ChangeLog Diff Modified: trunk/Tools/ChangeLog (94955 => 94956) --- trunk/Tools/ChangeLog 2011-09-12 14:20:07 UTC (rev 94955) +++ trunk/Tools/ChangeLog 2011-09-12 14:54:30 UTC (rev 94956) @@ -3,6 +3,8 @@ [Qt][WK2] WebKitTestRunner does not produce crash logs https://bugs.webkit.org/show_bug.cgi?id=67714 +Reviewed by Chang Shu. + Added a simple way of generating backtrace on crash to the web process. The implementation is similar what we have in DRT. It depends on GNU libc functionality ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94957] trunk/Source/WebCore
Title: [94957] trunk/Source/WebCore
Revision 94957
Author pfeld...@chromium.org
Date 2011-09-12 08:22:32 -0700 (Mon, 12 Sep 2011)
Log Message
Web Inspector: event dividers do not update timeline boundaries.
https://bugs.webkit.org/show_bug.cgi?id=67932
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onLoadEventFired):
(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (94956 => 94957)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 14:54:30 UTC (rev 94956)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 15:22:32 UTC (rev 94957)
@@ -1,3 +1,14 @@
+2011-09-12 Pavel Feldman pfeld...@google.com
+
+Web Inspector: event dividers do not update timeline boundaries.
+https://bugs.webkit.org/show_bug.cgi?id=67932
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView.prototype._onLoadEventFired):
+(WebInspector.NetworkLogView.prototype._domContentLoadedEventFired):
+(WebInspector.NetworkLogView.prototype.refresh):
+(WebInspector.NetworkTimeCalculator.prototype.updateBoundariesForEventTime):
+
2011-09-12 Kentaro Hara hara...@google.com
Implement a WebKitAnimationEvent constructor for V8
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (94956 => 94957)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-12 14:54:30 UTC (rev 94956)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2011-09-12 15:22:32 UTC (rev 94957)
@@ -627,14 +627,15 @@
_onLoadEventFired: function(event)
{
this._mainResourceLoadTime = event.data || -1;
-// Update the dividers to draw the new line
-this._updateDividersIfNeeded(true);
+// Schedule refresh to update boundaries and draw the new line.
+this._scheduleRefresh(true);
},
_domContentLoadedEventFired: function(event)
{
this._mainResourceDOMContentTime = event.data || -1;
-this._updateDividersIfNeeded(true);
+// Schedule refresh to update boundaries and draw the new line.
+this._scheduleRefresh(true);
},
wasShown: function()
@@ -661,6 +662,10 @@
var wasScrolledToLastRow = this._dataGrid.isScrolledToLastRow();
var staleItemsLength = this._staleResources.length;
var boundariesChanged = false;
+if (this.calculator.updateBoundariesForEventTime) {
+boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceLoadTime) || boundariesChanged;
+boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged;
+}
for (var i = 0; i staleItemsLength; ++i) {
var resource = this._staleResources[i];
@@ -1670,6 +1675,18 @@
return 0;
},
+updateBoundariesForEventTime: function(eventTime)
+{
+if (eventTime === -1 || this.startAtZero)
+return false;
+
+if (typeof this.maximumBoundary === undefined || eventTime this.maximumBoundary) {
+this.maximumBoundary = eventTime;
+return true;
+}
+return false;
+},
+
computeBarGraphLabels: function(resource)
{
var rightLabel = ;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94959] trunk/LayoutTests
Title: [94959] trunk/LayoutTests Revision 94959 Author jap...@chromium.org Date 2011-09-12 09:46:16 -0700 (Mon, 12 Sep 2011) Log Message 2011-09-12 Nate Chapin jap...@chromium.org Add video-zoom-controls.html to chromium expectations for leopard gpu. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94958 => 94959) --- trunk/LayoutTests/ChangeLog 2011-09-12 15:24:53 UTC (rev 94958) +++ trunk/LayoutTests/ChangeLog 2011-09-12 16:46:16 UTC (rev 94959) @@ -1,3 +1,10 @@ +2011-09-12 Nate Chapin jap...@chromium.org + +Add video-zoom-controls.html to chromium expectations +for leopard gpu. + +* platform/chromium/test_expectations.txt: + 2011-09-12 Pavel Feldman pfeld...@google.com Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94958 => 94959) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 15:24:53 UTC (rev 94958) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 16:46:16 UTC (rev 94959) @@ -3722,6 +3722,8 @@ BUGCR96220 MAC : fast/borders/inline-mask-overlay-image-outset-vertical-rl.html = IMAGE BUGCR96220 WIN LINUX : fast/borders/inline-mask-overlay-image-outset.html = IMAGE+TEXT BUGCR96220 MAC : fast/borders/inline-mask-overlay-image-outset.html = IMAGE +// NOTE: This is expected to IMAGE fail. +BUGWK67913 LEOPARD GPU GPU-CG : media/video-zoom-controls.html = IMAGE+TEXT // new test at r94897 BUGWK67917 MAC LEOPARD : svg/custom/simple-text-double-shadow.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94960] trunk/Source/WebKit2
Title: [94960] trunk/Source/WebKit2 Revision 94960 Author alexis.men...@openbossa.org Date 2011-09-12 10:02:55 -0700 (Mon, 12 Sep 2011) Log Message [Qt]Style error fix. Reviewed by Andreas Kling. * UIProcess/qt/QtWebPageProxy.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (94959 => 94960) --- trunk/Source/WebKit2/ChangeLog 2011-09-12 16:46:16 UTC (rev 94959) +++ trunk/Source/WebKit2/ChangeLog 2011-09-12 17:02:55 UTC (rev 94960) @@ -1,3 +1,11 @@ +2011-09-12 Alexis Menard alexis.men...@openbossa.org + +[Qt]Style error fix. + +Reviewed by Andreas Kling. + +* UIProcess/qt/QtWebPageProxy.cpp: + 2011-09-11 Mark Rowe mr...@apple.com rdar://problem/9878268 Pressing caps lock after closing a showModalDialog window results in WebProcess exiting Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (94959 => 94960) --- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-09-12 16:46:16 UTC (rev 94959) +++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-09-12 17:02:55 UTC (rev 94960) @@ -26,12 +26,12 @@ #include ClientImpl.h #include qwkhistory.h #include qwkhistory_p.h -#include ViewInterface.h #include FindIndicator.h #include LocalizedStrings.h #include NativeWebKeyboardEvent.h #include NotImplemented.h #include PolicyInterface.h +#include ViewInterface.h #include WebBackForwardList.h #include WebContext.h #include WebContextMenuProxyQt.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94961] trunk/Source/WebCore
Title: [94961] trunk/Source/WebCore
Revision 94961
Author r...@google.com
Date 2011-09-12 10:31:05 -0700 (Mon, 12 Sep 2011)
Log Message
[skia] remove dead code, no functionality change
https://bugs.webkit.org/show_bug.cgi?id=67844
Reviewed by Kenneth Russell.
No new tests. just removing dead-code, existing tests apply
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94960 => 94961)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 17:02:55 UTC (rev 94960)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 17:31:05 UTC (rev 94961)
@@ -1,3 +1,15 @@
+2011-09-12 Mike Reed r...@google.com
+
+[skia] remove dead code, no functionality change
+https://bugs.webkit.org/show_bug.cgi?id=67844
+
+Reviewed by Kenneth Russell.
+
+No new tests. just removing dead-code, existing tests apply
+
+* platform/graphics/chromium/FontChromiumWin.cpp:
+(WebCore::Font::drawGlyphs):
+
2011-09-12 Pavel Feldman pfeld...@google.com
Web Inspector: Runtime.callFunctionOn does not accept arguments that evaluate to false.
Modified: trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp (94960 => 94961)
--- trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-09-12 17:02:55 UTC (rev 94960)
+++ trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-09-12 17:31:05 UTC (rev 94961)
@@ -39,172 +39,12 @@
#include PlatformContextSkia.h
#include SimpleFontData.h
#include SkiaFontWin.h
-#include SkiaUtils.h
-#include TransparencyWin.h
#include UniscribeHelperTextRun.h
-#include skia/ext/platform_canvas.h
-#include skia/ext/skia_utils_win.h // FIXME: remove this dependency.
-
#include windows.h
namespace WebCore {
-namespace {
-
-bool canvasHasMultipleLayers(const SkCanvas* canvas)
-{
-SkCanvas::LayerIter iter(const_castSkCanvas*(canvas), false);
-iter.next(); // There is always at least one layer.
-return !iter.done(); // There is 1 layer if the the iterator can stil advance.
-}
-
-class TransparencyAwareFontPainter {
-public:
-TransparencyAwareFontPainter(GraphicsContext*, const FloatPoint);
-
-protected:
-virtual IntRect estimateTextBounds() = 0;
-
-// Use the context from the transparency helper when drawing with GDI. It
-// may point to a temporary one.
-GraphicsContext* m_graphicsContext;
-PlatformGraphicsContext* m_platformContext;
-
-FloatPoint m_point;
-};
-
-TransparencyAwareFontPainter::TransparencyAwareFontPainter(GraphicsContext* context,
- const FloatPoint point)
-: m_graphicsContext(context)
-, m_platformContext(context-platformContext())
-, m_point(point)
-{
-}
-
-// Specialization for simple GlyphBuffer painting.
-class TransparencyAwareGlyphPainter : public TransparencyAwareFontPainter {
- public:
-TransparencyAwareGlyphPainter(GraphicsContext*,
- const SimpleFontData*,
- const GlyphBuffer,
- int from, int numGlyphs,
- const FloatPoint);
-
-// Draws the partial string of glyphs, starting at |startAdvance| to the
-// left of m_point.
-void drawGlyphs(int numGlyphs, const WORD* glyphs, const int* advances, float startAdvance) const;
-
- private:
-virtual IntRect estimateTextBounds();
-
-const SimpleFontData* m_font;
-const GlyphBuffer m_glyphBuffer;
-int m_from;
-int m_numGlyphs;
-};
-
-TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter(
-GraphicsContext* context,
-const SimpleFontData* font,
-const GlyphBuffer glyphBuffer,
-int from, int numGlyphs,
-const FloatPoint point)
-: TransparencyAwareFontPainter(context, point)
-, m_font(font)
-, m_glyphBuffer(glyphBuffer)
-, m_from(from)
-, m_numGlyphs(numGlyphs)
-{
-}
-
-// Estimates the bounding box of the given text. This is copied from
-// FontCGWin.cpp, it is possible, but a lot more work, to get the precide
-// bounds.
-IntRect TransparencyAwareGlyphPainter::estimateTextBounds()
-{
-int totalWidth = 0;
-for (int i = 0; i m_numGlyphs; i++)
-totalWidth += lroundf(m_glyphBuffer.advanceAt(m_from + i));
-
-const FontMetrics fontMetrics = m_font-fontMetrics();
-return IntRect(m_point.x() - (fontMetrics.ascent() + fontMetrics.descent()) / 2,
- m_point.y() - fontMetrics.ascent() - fontMetrics.lineGap(),
- totalWidth + fontMetrics.ascent() + fontMetrics.descent(),
- fontMetrics.lineSpacing());
-}
-
-void TransparencyAwareGlyphPainter::drawGlyphs(int numGlyphs,
- const WORD* glyphs,
-
[webkit-changes] [94962] trunk
Title: [94962] trunk
Revision 94962
Author commit-qu...@webkit.org
Date 2011-09-12 10:40:55 -0700 (Mon, 12 Sep 2011)
Log Message
Implement a HashChangeEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67924
Patch by Kentaro Hara hara...@google.com on 2011-09-12
Reviewed by Sam Weinig.
Source/WebCore:
The spec for the HashChangeEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#hashchangeevent
Test: fast/events/constructors/hash-change-event-constructor.html
* bindings/generic/EventConstructors.h: Added a definition for the HashChangeEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for HashChangeEvent.
* dom/HashChangeEvent.h: Added a definition for HashChangeEventInit.
(WebCore::HashChangeEventInit::HashChangeEventInit):
(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
* dom/HashChangeEvent.idl: Makes HashChangeEvent constructible.
LayoutTests:
hash-change-event-constructor.html checks the behavior of the HashChangeEvent constructor.
* fast/events/constructors/hash-change-event-constructor-expected.txt: Added.
* fast/events/constructors/hash-change-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped hash-change-event-constructor.html, since V8 does not yet have the HashChangeEvent constructor.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/EventConstructors.h
trunk/Source/WebCore/bindings/js/JSEventConstructors.cpp
trunk/Source/WebCore/dom/HashChangeEvent.h
trunk/Source/WebCore/dom/HashChangeEvent.idl
Added Paths
trunk/LayoutTests/fast/events/constructors/hash-change-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/hash-change-event-constructor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94961 => 94962)
--- trunk/LayoutTests/ChangeLog 2011-09-12 17:31:05 UTC (rev 94961)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 17:40:55 UTC (rev 94962)
@@ -1,3 +1,16 @@
+2011-09-12 Kentaro Hara hara...@google.com
+
+Implement a HashChangeEvent constructor for JSC
+https://bugs.webkit.org/show_bug.cgi?id=67924
+
+Reviewed by Sam Weinig.
+
+hash-change-event-constructor.html checks the behavior of the HashChangeEvent constructor.
+
+* fast/events/constructors/hash-change-event-constructor-expected.txt: Added.
+* fast/events/constructors/hash-change-event-constructor.html: Added.
+* platform/chromium/test_expectations.txt: Skipped hash-change-event-constructor.html, since V8 does not yet have the HashChangeEvent constructor.
+
2011-09-12 Nate Chapin jap...@chromium.org
Add video-zoom-controls.html to chromium expectations
Added: trunk/LayoutTests/fast/events/constructors/hash-change-event-constructor-expected.txt (0 => 94962)
--- trunk/LayoutTests/fast/events/constructors/hash-change-event-constructor-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/constructors/hash-change-event-constructor-expected.txt 2011-09-12 17:40:55 UTC (rev 94962)
@@ -0,0 +1,47 @@
+This tests the constructor for the HashChangeEvent DOM class.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS new HashChangeEvent('eventType').bubbles is false
+PASS new HashChangeEvent('eventType').cancelable is false
+PASS new HashChangeEvent('eventType').oldURL is
+PASS new HashChangeEvent('eventType').newURL is
+PASS new HashChangeEvent('eventType', { bubbles: false }).bubbles is false
+PASS new HashChangeEvent('eventType', { bubbles: true }).bubbles is true
+PASS new HashChangeEvent('eventType', { cancelable: false }).cancelable is false
+PASS new HashChangeEvent('eventType', { cancelable: true }).cancelable is true
+PASS new HashChangeEvent('eventType', { oldURL: 'doremi' }).oldURL is doremi
+PASS new HashChangeEvent('eventType', { oldURL: '' }).oldURL is
+PASS new HashChangeEvent('eventType', { oldURL: undefined }).oldURL is undefined
+PASS new HashChangeEvent('eventType', { oldURL: null }).oldURL is null
+PASS new HashChangeEvent('eventType', { oldURL: false }).oldURL is false
+PASS new HashChangeEvent('eventType', { oldURL: true }).oldURL is true
+PASS new HashChangeEvent('eventType', { oldURL: 12345 }).oldURL is 12345
+PASS new HashChangeEvent('eventType', { oldURL: 18446744073709551615 }).oldURL is 18446744073709552000
+PASS new HashChangeEvent('eventType', { oldURL: NaN }).oldURL is NaN
+PASS new HashChangeEvent('eventType', { oldURL: [] }).oldURL is
+PASS new HashChangeEvent('eventType', { oldURL: [1, 2, 3] }).oldURL is 1,2,3
+PASS new HashChangeEvent('eventType', { oldURL: {doremi: 12345} }).oldURL is [object Object]
+PASS new HashChangeEvent('eventType', { oldURL: {valueOf: function () { return 'doremi'; } } }).oldURL is [object Object]
+PASS new HashChangeEvent('eventType', { newURL: 'doremi'
[webkit-changes] [94963] trunk/LayoutTests
Title: [94963] trunk/LayoutTests Revision 94963 Author commit-qu...@webkit.org Date 2011-09-12 10:45:27 -0700 (Mon, 12 Sep 2011) Log Message Chromium shadow-buffer-partial test change. https://bugs.webkit.org/show_bug.cgi?id=67849 Patch by Ben Wagner bunge...@chromium.org on 2011-09-12 Reviewed by Kenneth Russell. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94962 => 94963) --- trunk/LayoutTests/ChangeLog 2011-09-12 17:40:55 UTC (rev 94962) +++ trunk/LayoutTests/ChangeLog 2011-09-12 17:45:27 UTC (rev 94963) @@ -1,3 +1,12 @@ +2011-09-12 Ben Wagner bunge...@chromium.org + +Chromium shadow-buffer-partial test change. +https://bugs.webkit.org/show_bug.cgi?id=67849 + +Reviewed by Kenneth Russell. + +* platform/chromium/test_expectations.txt: + 2011-09-12 Kentaro Hara hara...@google.com Implement a HashChangeEvent constructor for JSC Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94962 => 94963) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 17:40:55 UTC (rev 94962) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 17:45:27 UTC (rev 94963) @@ -92,7 +92,9 @@ BUGCR20404 : editing/execCommand/copy-without-selection.html = TEXT // Skia clipped blur change in progress. -BUGWK67724 SKIP : fast/box-shadow/shadow-buffer-partial.html = PASS FAIL +BUGWK67724 : fast/box-shadow/shadow-buffer-partial.html = PASS FAIL +BUGWK67849 : fast/box-shadow/inset-box-shadow-radius.html = PASS FAIL +BUGWK67849 : fast/box-shadow/inset-box-shadows.html = PASS FAIL // - // WONTFIX TESTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94964] trunk/Source/WebCore
Title: [94964] trunk/Source/WebCore
Revision 94964
Author jam...@google.com
Date 2011-09-12 10:52:51 -0700 (Mon, 12 Sep 2011)
Log Message
[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
https://bugs.webkit.org/show_bug.cgi?id=67816
Reviewed by Kenneth Russell.
We lack infrastructure to construct an automated test for this today. To test manually, open up a composited
page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the
memory use returns to the single tab level.
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
(WebCore::CCLayerTreeHost::setRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94963 => 94964)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 17:45:27 UTC (rev 94963)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 17:52:51 UTC (rev 94964)
@@ -1,3 +1,24 @@
+2011-09-12 James Robinson jam...@chromium.org
+
+[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
+https://bugs.webkit.org/show_bug.cgi?id=67816
+
+Reviewed by Kenneth Russell.
+
+We lack infrastructure to construct an automated test for this today. To test manually, open up a composited
+page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the
+memory use returns to the single tab level.
+
+* platform/graphics/chromium/LayerChromium.h:
+* platform/graphics/chromium/TiledLayerChromium.cpp:
+(WebCore::TiledLayerChromium::setLayerTreeHost):
+* platform/graphics/chromium/VideoLayerChromium.cpp:
+(WebCore::VideoLayerChromium::setLayerTreeHost):
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive):
+(WebCore::CCLayerTreeHost::setRootLayer):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+
2011-09-12 Kentaro Hara hara...@google.com
Implement a HashChangeEvent constructor for JSC
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (94963 => 94964)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-09-12 17:45:27 UTC (rev 94963)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-09-12 17:52:51 UTC (rev 94964)
@@ -207,7 +207,7 @@
bool descendantDrawsContent();
CCLayerTreeHost* layerTreeHost() const { return m_layerTreeHost.get(); }
-virtual void cleanupResourcesRecursive();
+void cleanupResourcesRecursive();
protected:
GraphicsLayerChromium* m_owner;
Modified: trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp (94963 => 94964)
--- trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2011-09-12 17:45:27 UTC (rev 94963)
+++ trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp 2011-09-12 17:52:51 UTC (rev 94964)
@@ -138,7 +138,7 @@
{
LayerChromium::setLayerTreeHost(host);
-if (m_tiler)
+if (m_tiler || !host)
return;
createTextureUpdater(host);
Modified: trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp (94963 => 94964)
--- trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp 2011-09-12 17:45:27 UTC (rev 94963)
+++ trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp 2011-09-12 17:52:51 UTC (rev 94964)
@@ -148,7 +148,7 @@
void VideoLayerChromium::setLayerTreeHost(CCLayerTreeHost* host)
{
-if (layerTreeHost() != host) {
+if (host layerTreeHost() != host) {
for (size_t i = 0; i 3; ++i) {
m_textures[i].m_visibleSize = IntSize();
m_textures[i].m_texture = ManagedTexture::create(host-contentsTextureManager());
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (94963 => 94964)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-09-12 17:45:27 UTC (rev 94963)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-09-12 17:52:51 UTC (rev 94964)
@@ -214,12 +214,32 @@
#endif
}
[webkit-changes] [94965] trunk/Source/WebKit/efl
Title: [94965] trunk/Source/WebKit/efl
Revision 94965
Author commit-qu...@webkit.org
Date 2011-09-12 10:54:33 -0700 (Mon, 12 Sep 2011)
Log Message
Patch by Flavio Ceolin flavio.ceo...@profusion.mobi on 2011-09-12
Reviewed by Martin Robinson.
[EFL] Add custom network resource handler
https://bugs.webkit.org/show_bug.cgi?id=44759
This patch adds support for handling user-specific protocols.
It allows browsers to intercept and handle non-standard url schemes (such as preferences://)
allowing to load some resource from non-http/file storage, like a tar/zip/eet.
* CMakeListsEfl.txt:
* ewk/ewk_protocol_handler.cpp: Added.
* ewk/ewk_protocol_handler.h: Added.
* ewk/ewk_protocol_handler_soup.cpp: Added.
* ewk/ewk_protocol_handler_soup.h: Added.
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(ewk_view_protocol_handler_set):
(ewk_view_protocol_handler_unset):
(ewk_view_protocol_handler_resource_get):
* ewk/ewk_view.h:
Modified Paths
trunk/Source/WebKit/efl/CMakeListsEfl.txt
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_private.h
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h
Added Paths
trunk/Source/WebKit/efl/ewk/ewk_protocol_handler.cpp
trunk/Source/WebKit/efl/ewk/ewk_protocol_handler.h
trunk/Source/WebKit/efl/ewk/ewk_protocol_handler_soup.cpp
trunk/Source/WebKit/efl/ewk/ewk_protocol_handler_soup.h
Diff
Modified: trunk/Source/WebKit/efl/CMakeListsEfl.txt (94964 => 94965)
--- trunk/Source/WebKit/efl/CMakeListsEfl.txt 2011-09-12 17:52:51 UTC (rev 94964)
+++ trunk/Source/WebKit/efl/CMakeListsEfl.txt 2011-09-12 17:54:33 UTC (rev 94965)
@@ -73,6 +73,7 @@
efl/ewk/ewk_main.cpp
efl/ewk/ewk_network.cpp
efl/ewk/ewk_settings.cpp
+efl/ewk/ewk_protocol_handler.cpp
efl/ewk/ewk_tiled_backing_store.c
efl/ewk/ewk_tiled_matrix.c
efl/ewk/ewk_tiled_model.c
@@ -115,6 +116,7 @@
LIST(APPEND WebKit_SOURCES
efl/ewk/ewk_auth.cpp
efl/ewk/ewk_auth_soup.cpp
+efl/ewk/ewk_protocol_handler_soup.cpp
)
ENDIF ()
@@ -235,6 +237,7 @@
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_logging.h
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_main.h
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_network.h
+${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_protocol_handler.h
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_settings.h
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_view.h
${CMAKE_CURRENT_SOURCE_DIR}/efl/ewk/ewk_window_features.h
Modified: trunk/Source/WebKit/efl/ChangeLog (94964 => 94965)
--- trunk/Source/WebKit/efl/ChangeLog 2011-09-12 17:52:51 UTC (rev 94964)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-09-12 17:54:33 UTC (rev 94965)
@@ -1,3 +1,26 @@
+2011-09-12 Flavio Ceolin flavio.ceo...@profusion.mobi
+
+Reviewed by Martin Robinson.
+
+[EFL] Add custom network resource handler
+https://bugs.webkit.org/show_bug.cgi?id=44759
+
+This patch adds support for handling user-specific protocols.
+It allows browsers to intercept and handle non-standard url schemes (such as preferences://)
+allowing to load some resource from non-http/file storage, like a tar/zip/eet.
+
+* CMakeListsEfl.txt:
+* ewk/ewk_protocol_handler.cpp: Added.
+* ewk/ewk_protocol_handler.h: Added.
+* ewk/ewk_protocol_handler_soup.cpp: Added.
+* ewk/ewk_protocol_handler_soup.h: Added.
+* ewk/ewk_private.h:
+* ewk/ewk_view.cpp:
+(ewk_view_protocol_handler_set):
+(ewk_view_protocol_handler_unset):
+(ewk_view_protocol_handler_resource_get):
+* ewk/ewk_view.h:
+
2011-09-04 Ryuan Choi ryuan.c...@samsung.com
[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
Modified: trunk/Source/WebKit/efl/ewk/ewk_private.h (94964 => 94965)
--- trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-09-12 17:52:51 UTC (rev 94964)
+++ trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-09-12 17:54:33 UTC (rev 94965)
@@ -134,6 +134,7 @@
void ewk_view_viewport_attributes_set(Evas_Object *o, const WebCore::ViewportArguments arguments);
void ewk_view_download_request(Evas_Object *o, Ewk_Download *download);
+void *ewk_view_protocol_handler_resource_get(Evas_Object *o, size_t *bytesRead, char **mime, const char *file);
void ewk_view_editor_client_contents_changed(Evas_Object *o);
void ewk_view_editor_client_selection_changed(Evas_Object *o);
Added: trunk/Source/WebKit/efl/ewk/ewk_protocol_handler.cpp (0 => 94965)
--- trunk/Source/WebKit/efl/ewk/ewk_protocol_handler.cpp (rev 0)
+++ trunk/Source/WebKit/efl/ewk/ewk_protocol_handler.cpp 2011-09-12 17:54:33 UTC (rev 94965)
@@ -0,0 +1,45 @@
+/*
+Copyright (C) 2011 ProFUSION embedded systems
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Library General Public
+License as published by the Free Software Foundation; either
+version 2 of the License, or (at your option) any later
[webkit-changes] [94966] trunk
Title: [94966] trunk Revision 94966 Author commit-qu...@webkit.org Date 2011-09-12 10:55:49 -0700 (Mon, 12 Sep 2011) Log Message Selectstart is not fired when selection was created by arrow keys. https://bugs.webkit.org/show_bug.cgi?id=60430 Patch by Arko Saha a...@motorola.com on 2011-09-12 Reviewed by Ryosuke Niwa. Source/WebCore: Fire selectstart when a user starts extending the selection using arrow key. Fixed by Arko Saha a...@motorola.com and Kaustubh Atrawalkar kaust...@motorola.com Tests: fast/events/selectstart-by-arrow-keys-prevent-default.html fast/events/selectstart-by-arrow-keys.html * editing/FrameSelection.cpp: (WebCore::FrameSelection::modify): (WebCore::FrameSelection::shouldChangeSelection): (WebCore::FrameSelection::dispatchSelectStart): * editing/FrameSelection.h: LayoutTests: * fast/events/selectstart-by-arrow-keys-expected.txt: Added. * fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added. * fast/events/selectstart-by-arrow-keys-prevent-default.html: Added. * fast/events/selectstart-by-arrow-keys.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/FrameSelection.cpp trunk/Source/WebCore/editing/FrameSelection.h Added Paths trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-expected.txt trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html trunk/LayoutTests/fast/events/selectstart-by-arrow-keys.html Diff Modified: trunk/LayoutTests/ChangeLog (94965 => 94966) --- trunk/LayoutTests/ChangeLog 2011-09-12 17:54:33 UTC (rev 94965) +++ trunk/LayoutTests/ChangeLog 2011-09-12 17:55:49 UTC (rev 94966) @@ -1,3 +1,15 @@ +2011-09-12 Arko Saha a...@motorola.com + +Selectstart is not fired when selection was created by arrow keys. +https://bugs.webkit.org/show_bug.cgi?id=60430 + +Reviewed by Ryosuke Niwa. + +* fast/events/selectstart-by-arrow-keys-expected.txt: Added. +* fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt: Added. +* fast/events/selectstart-by-arrow-keys-prevent-default.html: Added. +* fast/events/selectstart-by-arrow-keys.html: Added. + 2011-09-12 Ben Wagner bunge...@chromium.org Chromium shadow-buffer-partial test change. Added: trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-expected.txt (0 => 94966) --- trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-expected.txt 2011-09-12 17:55:49 UTC (rev 94966) @@ -0,0 +1,18 @@ +This test ensures selectstart is fired when selection is created by arrow keys. + +If running this test manually, click on div (Hello World) element and try to select the text using arrow keys. +Expected result : SelectStart event will fire when user starts extending selection. +Hello World +Initial state: PASS +Check (Right arrow): PASS +Check (Right arrow + Shift): PASS +Check (Right arrow + Shift + Control): PASS +Check (End + Shift): PASS +Check (Home + Shift): PASS +Check (End + Shift): PASS +Check (Left arrow): PASS +Check (LeftArrow + Shift + Control): PASS +Check (Left arrow + Shift): PASS +Check (Home + Shift): PASS +Check (Home + Control): PASS +Done. Added: trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt (0 => 94966) --- trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt (rev 0) +++ trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default-expected.txt 2011-09-12 17:55:49 UTC (rev 94966) @@ -0,0 +1,9 @@ +This test ensures selectstart event fires when selection is created by arrow key and script can prevent the selection change. + +If running this test manually, click on the div (Hello World) and try to select the text using arrow keys. +Expected result: SelectStart event will fire when user starts extending the selection, but due to script preventDefault it prevents the selection change. +Hello World +Check Right arrow + Shift: PASS +Check Right arrow + Shift + Control: PASS +Check End + Shift: PASS + Added: trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html (0 => 94966) --- trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html (rev 0) +++ trunk/LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html 2011-09-12 17:55:49 UTC (rev 94966) @@ -0,0 +1,43 @@ +!DOCTYPE html +html +body +pThis test ensures selectstart event fires when selection is created by arrow key and script can prevent the selection change./p +If running this test manually, click on the div (Hello World) and try to select the text using arrow keys.br +Expected result: SelectStart event will fire when user starts extending the selection, but due to script
[webkit-changes] [94968] trunk/Source/WebKit/qt
Title: [94968] trunk/Source/WebKit/qt
Revision 94968
Author o...@webkit.org
Date 2011-09-12 11:12:12 -0700 (Mon, 12 Sep 2011)
Log Message
[Qt] Fix Unmatched parentheses are deprecated. warnings
https://bugs.webkit.org/show_bug.cgi?id=67775
Reviewed by Zoltan Herczeg.
Modify function declarations to single line to make qmake happier.
* Api/qwebframe.h:
* Api/qwebpluginfactory.h:
* Api/qwebview.h:
Modified Paths
trunk/Source/WebKit/qt/Api/qwebframe.h
trunk/Source/WebKit/qt/Api/qwebpluginfactory.h
trunk/Source/WebKit/qt/Api/qwebview.h
trunk/Source/WebKit/qt/ChangeLog
Diff
Modified: trunk/Source/WebKit/qt/Api/qwebframe.h (94967 => 94968)
--- trunk/Source/WebKit/qt/Api/qwebframe.h 2011-09-12 18:00:11 UTC (rev 94967)
+++ trunk/Source/WebKit/qt/Api/qwebframe.h 2011-09-12 18:12:12 UTC (rev 94968)
@@ -124,9 +124,7 @@
QWebPage *page() const;
void load(const QUrl url);
-void load(const QNetworkRequest request,
- QNetworkAccessManager::Operation operation = QNetworkAccessManager::GetOperation,
- const QByteArray body = QByteArray());
+void load(const QNetworkRequest request, QNetworkAccessManager::Operation operation = QNetworkAccessManager::GetOperation, const QByteArray body = QByteArray());
void setHtml(const QString html, const QUrl baseUrl = QUrl());
void setContent(const QByteArray data, const QString mimeType = QString(), const QUrl baseUrl = QUrl());
Modified: trunk/Source/WebKit/qt/Api/qwebpluginfactory.h (94967 => 94968)
--- trunk/Source/WebKit/qt/Api/qwebpluginfactory.h 2011-09-12 18:00:11 UTC (rev 94967)
+++ trunk/Source/WebKit/qt/Api/qwebpluginfactory.h 2011-09-12 18:12:12 UTC (rev 94968)
@@ -54,10 +54,7 @@
virtual QListPlugin plugins() const = 0;
virtual void refreshPlugins();
-virtual QObject *create(const QString mimeType,
-const QUrl,
-const QStringList argumentNames,
-const QStringList argumentValues) const = 0;
+virtual QObject *create(const QString mimeType, const QUrl, const QStringList argumentNames, const QStringList argumentValues) const = 0;
enum Extension {
};
Modified: trunk/Source/WebKit/qt/Api/qwebview.h (94967 => 94968)
--- trunk/Source/WebKit/qt/Api/qwebview.h 2011-09-12 18:00:11 UTC (rev 94967)
+++ trunk/Source/WebKit/qt/Api/qwebview.h 2011-09-12 18:12:12 UTC (rev 94968)
@@ -61,9 +61,7 @@
void setPage(QWebPage* page);
void load(const QUrl url);
-void load(const QNetworkRequest request,
- QNetworkAccessManager::Operation operation = QNetworkAccessManager::GetOperation,
- const QByteArray body = QByteArray());
+void load(const QNetworkRequest request, QNetworkAccessManager::Operation operation = QNetworkAccessManager::GetOperation, const QByteArray body = QByteArray());
void setHtml(const QString html, const QUrl baseUrl = QUrl());
void setContent(const QByteArray data, const QString mimeType = QString(), const QUrl baseUrl = QUrl());
Modified: trunk/Source/WebKit/qt/ChangeLog (94967 => 94968)
--- trunk/Source/WebKit/qt/ChangeLog 2011-09-12 18:00:11 UTC (rev 94967)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-09-12 18:12:12 UTC (rev 94968)
@@ -1,3 +1,16 @@
+2011-09-12 Csaba Osztrogonác o...@webkit.org
+
+[Qt] Fix Unmatched parentheses are deprecated. warnings
+https://bugs.webkit.org/show_bug.cgi?id=67775
+
+Reviewed by Zoltan Herczeg.
+
+Modify function declarations to single line to make qmake happier.
+
+* Api/qwebframe.h:
+* Api/qwebpluginfactory.h:
+* Api/qwebview.h:
+
2011-09-10 Jarred Nicholls jar...@sencha.com
[Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows paths that contain drive letters
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94970] trunk/LayoutTests
Title: [94970] trunk/LayoutTests Revision 94970 Author e...@webkit.org Date 2011-09-12 12:50:41 -0700 (Mon, 12 Sep 2011) Log Message Implement a HashChangeEvent constructor for JSC https://bugs.webkit.org/show_bug.cgi?id=67924 Unreviewed. Updating results which were forgotten. * fast/dom/constructed-objects-prototypes-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (94969 => 94970) --- trunk/LayoutTests/ChangeLog 2011-09-12 18:55:07 UTC (rev 94969) +++ trunk/LayoutTests/ChangeLog 2011-09-12 19:50:41 UTC (rev 94970) @@ -1,3 +1,12 @@ +2011-09-12 Eric Seidel e...@webkit.org + +Implement a HashChangeEvent constructor for JSC +https://bugs.webkit.org/show_bug.cgi?id=67924 + +Unreviewed. Updating results which were forgotten. + +* fast/dom/constructed-objects-prototypes-expected.txt: + 2011-09-12 Chris Rogers crog...@google.com DelayNode delay buffer is not correctly wrapping around Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (94969 => 94970) --- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-12 18:55:07 UTC (rev 94969) +++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-09-12 19:50:41 UTC (rev 94970) @@ -13,6 +13,8 @@ PASS (new inner.Event()).constructor.isInner is true PASS (new inner.FormData()).isInner is true PASS (new inner.FormData()).constructor.isInner is true +PASS (new inner.HashChangeEvent()).isInner is true +PASS (new inner.HashChangeEvent()).constructor.isInner is true PASS (new inner.Image()).isInner is true PASS (new inner.Image()).constructor.isInner is true PASS (new inner.MessageChannel()).isInner is true ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94971] trunk/Source/WebKit/chromium
Title: [94971] trunk/Source/WebKit/chromium
Revision 94971
Author nd...@chromium.org
Date 2011-09-12 12:53:39 -0700 (Mon, 12 Sep 2011)
Log Message
[chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread
https://bugs.webkit.org/show_bug.cgi?id=67832
The compositor thread needs to create a GraphicsContext3D without
actually making it current. In previous attempts at doing this, we
modified all graphics3D creation to not make the contexts current, but
this prove to be shockingly fragile. Since this is a very
Chromium-specific behavior, this patch makes creationForAnotherThread a
method on the private GraphicsContext3D interface.
GraphicsContext3D::create behaves as usual.
Reviewed by Kenneth Russell.
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
(WebCore::GraphicsContext3D::create):
* src/GraphicsContext3DPrivate.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::graphicsContext3D):
* tests/MockGraphicsContext3DTest.cpp:
(TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/MockGraphicsContext3DTest.cpp
trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (94970 => 94971)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-12 19:50:41 UTC (rev 94970)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-12 19:53:39 UTC (rev 94971)
@@ -1,3 +1,29 @@
+2011-09-08 Nat Duca nd...@chromium.org
+
+[chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread
+https://bugs.webkit.org/show_bug.cgi?id=67832
+
+The compositor thread needs to create a GraphicsContext3D without
+actually making it current. In previous attempts at doing this, we
+modified all graphics3D creation to not make the contexts current, but
+this prove to be shockingly fragile. Since this is a very
+Chromium-specific behavior, this patch makes creationForAnotherThread a
+method on the private GraphicsContext3D interface.
+GraphicsContext3D::create behaves as usual.
+
+Reviewed by Kenneth Russell.
+
+* src/GraphicsContext3DChromium.cpp:
+(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
+(WebCore::GraphicsContext3DPrivate::createGraphicsContextForAnotherThread):
+(WebCore::GraphicsContext3D::create):
+* src/GraphicsContext3DPrivate.h:
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::createLayerTreeHostContext3D):
+(WebKit::WebViewImpl::graphicsContext3D):
+* tests/MockGraphicsContext3DTest.cpp:
+(TEST):
+
2011-09-11 Jeremy Moskovich jer...@chromium.org
[Chromium] Change OOP Font loading code to use CGFont*() APIs.
Modified: trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h (94970 => 94971)
--- trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-09-12 19:50:41 UTC (rev 94970)
+++ trunk/Source/WebKit/chromium/public/WebGraphicsContext3D.h 2011-09-12 19:53:39 UTC (rev 94971)
@@ -70,7 +70,12 @@
// GraphicsContext3D in order to implement WebGL. Nearly all of the
// methods exposed on this interface map directly to entry points in
// the OpenGL ES 2.0 API.
-
+//
+// Creating a WebGraphicsContext does not make it current, or guarantee
+// that the context has been created successfully. Use
+// makeContextCurrent() to complete initialization of the context, treating
+// a false return value as indication that the context could not be created
+// successfully.
class WebGraphicsContext3D : public WebNonCopyable {
public:
// Return value from getActiveUniform and getActiveAttrib.
Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (94970 => 94971)
--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp 2011-09-12 19:50:41 UTC (rev 94970)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp 2011-09-12 19:53:39 UTC (rev 94971)
@@ -119,11 +119,14 @@
return adoptPtr(new GraphicsContext3DPrivate(webViewImpl, webContext));
}
-PassRefPtrGraphicsContext3D GraphicsContext3DPrivate::createGraphicsContextFromWebContext(PassOwnPtrWebKit::WebGraphicsContext3D webContext, GraphicsContext3D::Attributes attrs, HostWindow* hostWindow, GraphicsContext3D::RenderStyle renderStyle)
+PassRefPtrGraphicsContext3D GraphicsContext3DPrivate::createGraphicsContextFromWebContext(PassOwnPtrWebKit::WebGraphicsContext3D webContext, GraphicsContext3D::Attributes attrs, HostWindow* hostWindow, GraphicsContext3D::RenderStyle renderStyle,
[webkit-changes] [94973] trunk/Tools
Title: [94973] trunk/Tools Revision 94973 Author e...@webkit.org Date 2011-09-12 13:06:40 -0700 (Mon, 12 Sep 2011) Log Message Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately https://bugs.webkit.org/show_bug.cgi?id=67530 Reviewed by Adam Barth. I believe I've fixed the bug in the original patch which prompted the rollout. The previous patch was using the wrong deadline for the initial read, subtracting time.time() twice from the deadline value. * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (94972 => 94973) --- trunk/Tools/ChangeLog 2011-09-12 20:05:52 UTC (rev 94972) +++ trunk/Tools/ChangeLog 2011-09-12 20:06:40 UTC (rev 94973) @@ -1,3 +1,17 @@ +2011-09-12 Eric Seidel e...@webkit.org + +Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately +https://bugs.webkit.org/show_bug.cgi?id=67530 + +Reviewed by Adam Barth. + +I believe I've fixed the bug in the original patch which prompted the rollout. +The previous patch was using the wrong deadline for the initial read, +subtracting time.time() twice from the deadline value. + +* Scripts/webkitpy/layout_tests/port/webkit.py: +* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + 2011-09-12 Balazs Kelemen kbal...@webkit.org [Qt][WK2] WebKitTestRunner does not produce crash logs Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (94972 => 94973) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-12 20:05:52 UTC (rev 94972) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-09-12 20:06:40 UTC (rev 94973) @@ -509,44 +509,46 @@ crash=self.detected_crash(), test_time=time.time() - start_time, timeout=self._server_process.timed_out, error=error) +LENGTH_HEADER = 'Content-Length: ' +HASH_HEADER = 'ActualHash: ' +TYPE_HEADER = 'Content-Type: ' +ENCODING_HEADER = 'Content-Transfer-Encoding: ' + +def _read_line_until(self, deadline): +return self._server_process.read_line(deadline - time.time()) + def _read_block(self, deadline): -LENGTH_HEADER = 'Content-Length: ' -HASH_HEADER = 'ActualHash: ' -TYPE_HEADER = 'Content-Type: ' -ENCODING_HEADER = 'Content-Transfer-Encoding: ' content_type = None encoding = None content_hash = None content_length = None # Content is treated as binary data even though the text output is usually UTF-8. -content = '' -timeout = deadline - time.time() -line = self._server_process.read_line(timeout) +content = str() # FIXME: Should be bytearray() once we require Python 2.6. +line = self._read_line_until(deadline) eof = False while (not self._server_process.timed_out and not self.detected_crash() and not eof): -chomped_line = line.rstrip() +chomped_line = line.rstrip() # FIXME: This will remove trailing lines from test output. Is that right? if chomped_line.endswith(#EOF): eof = True line = chomped_line[:-4] -if line.startswith(TYPE_HEADER) and content_type is None: +if line.startswith(self.TYPE_HEADER) and content_type is None: content_type = line.split()[1] -elif line.startswith(ENCODING_HEADER) and encoding is None: +elif line.startswith(self.ENCODING_HEADER) and encoding is None: encoding = line.split()[1] -elif line.startswith(LENGTH_HEADER) and content_length is None: -timeout = deadline - time.time() -content_length = int(line[len(LENGTH_HEADER):]) -# FIXME: Technically there should probably be another blank -# line here, but DRT doesn't write one. -content = self._server_process.read(timeout, content_length) -elif line.startswith(HASH_HEADER): +elif line.startswith(self.LENGTH_HEADER) and content_length is None: +content_length = int(line[len(self.LENGTH_HEADER):]) +# FIXME: In real HTTP there should probably be a blank line +# after headers before content, but DRT doesn't write one. +content = self._server_process.read(deadline - time.time(), content_length) +elif line.startswith(self.HASH_HEADER): content_hash = line.split()[1] elif line: content += line -if not eof: -line = self._server_process.read_line(timeout) -
[webkit-changes] [94974] trunk/LayoutTests
Title: [94974] trunk/LayoutTests Revision 94974 Author jap...@chromium.org Date 2011-09-12 13:15:34 -0700 (Mon, 12 Sep 2011) Log Message 2011-09-12 Nate Chapin jap...@chromium.org Fix up duplicate expectations and add expected failure for selectstart-by-arrow-keys.html for chromium mac. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94973 => 94974) --- trunk/LayoutTests/ChangeLog 2011-09-12 20:06:40 UTC (rev 94973) +++ trunk/LayoutTests/ChangeLog 2011-09-12 20:15:34 UTC (rev 94974) @@ -1,3 +1,10 @@ +2011-09-12 Nate Chapin jap...@chromium.org + +Fix up duplicate expectations and add expected failure +for selectstart-by-arrow-keys.html for chromium mac. + +* platform/chromium/test_expectations.txt: + 2011-09-12 David Reveman reve...@chromium.org Rebaseline for r94703. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94973 => 94974) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 20:06:40 UTC (rev 94973) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 20:15:34 UTC (rev 94974) @@ -3704,7 +3704,8 @@ // Failing after r94912. -BUGWK67913 : media/video-zoom-controls.html = TEXT +BUGWK67913 WIN LINUX SNOWLEOPARD : media/video-zoom-controls.html = TEXT +BUGWK67913 LEOPARD CPU CPU-CG : media/video-zoom-controls.html = TEXT BUGCR96220 : fast/borders/border-image-outset-split-inline-vertical-lr.html = IMAGE BUGCR96220 : fast/borders/border-image-outset-split-inline.html = IMAGE BUGCR96220 : fast/reflections/reflection-masks-outset.html = IMAGE @@ -3726,3 +3727,6 @@ // Failing after r94946 BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT + +// Failing after r94966. +BUGJAPHET MAC : fast/events/selectstart-by-arrow-keys.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94976] trunk/Tools
Title: [94976] trunk/Tools
Revision 94976
Author e...@webkit.org
Date 2011-09-12 13:54:21 -0700 (Mon, 12 Sep 2011)
Log Message
[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
https://bugs.webkit.org/show_bug.cgi?id=65781
Reviewed by Ryosuke Niwa.
Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
to resolve the passed in url relative to the absolute url for the test.
I believe this is a better approach than the on used in the Qt and Chromium DRT's
(which resolves the path relative to the built location of the DRT executable)
and we should move this new code into a shared location in a follow-up patch.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Diff
Modified: trunk/Tools/ChangeLog (94975 => 94976)
--- trunk/Tools/ChangeLog 2011-09-12 20:30:12 UTC (rev 94975)
+++ trunk/Tools/ChangeLog 2011-09-12 20:54:21 UTC (rev 94976)
@@ -1,5 +1,22 @@
2011-09-12 Eric Seidel e...@webkit.org
+[NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
+https://bugs.webkit.org/show_bug.cgi?id=65781
+
+Reviewed by Ryosuke Niwa.
+
+Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
+to resolve the passed in url relative to the absolute url for the test.
+
+I believe this is a better approach than the on used in the Qt and Chromium DRT's
+(which resolves the path relative to the built location of the DRT executable)
+and we should move this new code into a shared location in a follow-up patch.
+
+* DumpRenderTree/mac/LayoutTestControllerMac.mm:
+(LayoutTestController::pathToLocalResource):
+
+2011-09-12 Eric Seidel e...@webkit.org
+
Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
https://bugs.webkit.org/show_bug.cgi?id=67530
Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm (94975 => 94976)
--- trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm 2011-09-12 20:30:12 UTC (rev 94975)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm 2011-09-12 20:54:21 UTC (rev 94976)
@@ -355,9 +355,24 @@
m_waitToDump = false;
}
-JSStringRef LayoutTestController::pathToLocalResource(JSContextRef context, JSStringRef url)
+JSStringRef LayoutTestController::pathToLocalResource(JSContextRef context, JSStringRef localResourcePath)
{
-return JSStringRetain(url); // Do nothing on mac.
+// Use the absolute path for the test from m_testPathOrURL
+// to create an absolute path for the requested local resource.
+// FIXME: This code should work on all *nix platforms and can be moved into LayoutTestController.cpp.
+size_t maxBufferSize = JSStringGetMaximumUTF8CStringSize(localResourcePath);
+char* resourcePathAsUTF8 = new char[maxBufferSize];
+size_t resourcePathAsUTF8BufferSize = JSStringGetUTF8CString(localResourcePath, resourcePathAsUTF8, maxBufferSize);
+
+std::string resourcePathAsString(resourcePathAsUTF8, resourcePathAsUTF8BufferSize - 1); // Ignore the trailing \0 when creating the string.
+delete[] resourcePathAsUTF8;
+
+size_t resourceLayoutTestsIndex = resourcePathAsString.rfind(LayoutTests/);
+ASSERT(resourceLayoutTestsIndex); // Passed in paths must include LayoutTests/
+size_t testLayoutTestsIndex = m_testPathOrURL.rfind(LayoutTests/);
+std::string resolvedResourcePath = m_testPathOrURL.substr(0, testLayoutTestsIndex) + resourcePathAsString.substr(resourceLayoutTestsIndex);
+
+return JSStringCreateWithUTF8CString(resolvedResourcePath.c_str());
}
void LayoutTestController::queueLoad(JSStringRef url, JSStringRef target)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94977] trunk/LayoutTests
Title: [94977] trunk/LayoutTests
Revision 94977
Author rn...@webkit.org
Date 2011-09-12 14:05:29 -0700 (Mon, 12 Sep 2011)
Log Message
Fix a test added by r94966 to work on Mac.
* fast/events/selectstart-by-arrow-keys.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/selectstart-by-arrow-keys.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (94976 => 94977)
--- trunk/LayoutTests/ChangeLog 2011-09-12 20:54:21 UTC (rev 94976)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 21:05:29 UTC (rev 94977)
@@ -1,3 +1,10 @@
+2011-09-12 Ryosuke Niwa rn...@webkit.org
+
+Fix a test added by r94966 to work on Mac.
+
+* fast/events/selectstart-by-arrow-keys.html:
+* platform/chromium/test_expectations.txt:
+
2011-09-12 Nate Chapin jap...@chromium.org
Fix up duplicate expectations and add expected failure
Modified: trunk/LayoutTests/fast/events/selectstart-by-arrow-keys.html (94976 => 94977)
--- trunk/LayoutTests/fast/events/selectstart-by-arrow-keys.html 2011-09-12 20:54:21 UTC (rev 94976)
+++ trunk/LayoutTests/fast/events/selectstart-by-arrow-keys.html 2011-09-12 21:05:29 UTC (rev 94977)
@@ -22,7 +22,10 @@
eventSender.keyDown(rightArrow, [shiftKey]);
logResult('Check (Right arrow + Shift)', 1);
-eventSender.keyDown(rightArrow, [shiftKey], [ctrlKey]);
+if (navigator.platform.indexOf('Mac') == 0)
+eventSender.keyDown(rightArrow, [shiftKey], [altKey]);
+else
+eventSender.keyDown(rightArrow, [shiftKey], [ctrlKey]);
logResult('Check (Right arrow + Shift + Control)', 1);
eventSender.keyDown(end, [shiftKey]);
@@ -34,10 +37,17 @@
eventSender.keyDown(end, [shiftKey]);
logResult('Check (End + Shift)', 1);
+// On Mac, home/end doesn't move caret so manually select World.
+if (navigator.platform.indexOf('Mac') == 0)
+window.getSelection().setBaseAndExtent(div.firstChild, div.textContent.indexOf('World'), div.textContent.length);
+
eventSender.keyDown(leftArrow);
logResult('Check (Left arrow)', 1);
-eventSender.keyDown(leftArrow, [shiftKey], [ctrlKey]);
+if (navigator.platform.indexOf('Mac') == 0)
+eventSender.keyDown(leftArrow, [shiftKey], [altKey]);
+else
+eventSender.keyDown(leftArrow, [shiftKey], [ctrlKey]);
logResult('Check (LeftArrow + Shift + Control)', 2);
eventSender.keyDown(leftArrow, [shiftKey]);
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94976 => 94977)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 20:54:21 UTC (rev 94976)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-12 21:05:29 UTC (rev 94977)
@@ -3727,6 +3727,3 @@
// Failing after r94946
BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT
-
-// Failing after r94966.
-BUGJAPHET MAC : fast/events/selectstart-by-arrow-keys.html = TEXT
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94978] trunk/Tools
Title: [94978] trunk/Tools Revision 94978 Author e...@webkit.org Date 2011-09-12 14:11:32 -0700 (Mon, 12 Sep 2011) Log Message Rubber-stamped by Adam Barth. Remove the the tree is burning! warning previously shown when landing patches. It was a dream. But it's just noise now. Some bots will require a restart to notice the removal of the option so I've left the --ignore-builders option in for now. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/bot/patchanalysistask.py: * Scripts/webkitpy/tool/commands/download.py: * Scripts/webkitpy/tool/commands/download_unittest.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/steps/__init__.py: * Scripts/webkitpy/tool/steps/commit.py: * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed. * Scripts/webkitpy/tool/steps/postdiffforrevert.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py trunk/Tools/Scripts/webkitpy/tool/commands/download.py trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py trunk/Tools/Scripts/webkitpy/tool/steps/__init__.py trunk/Tools/Scripts/webkitpy/tool/steps/commit.py trunk/Tools/Scripts/webkitpy/tool/steps/options.py trunk/Tools/Scripts/webkitpy/tool/steps/postdiffforrevert.py Removed Paths trunk/Tools/Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py Diff Modified: trunk/Tools/ChangeLog (94977 => 94978) --- trunk/Tools/ChangeLog 2011-09-12 21:05:29 UTC (rev 94977) +++ trunk/Tools/ChangeLog 2011-09-12 21:11:32 UTC (rev 94978) @@ -1,5 +1,25 @@ 2011-09-12 Eric Seidel e...@webkit.org +Rubber-stamped by Adam Barth. + +Remove the the tree is burning! warning previously shown +when landing patches. It was a dream. But it's just noise now. + +Some bots will require a restart to notice the removal of the option +so I've left the --ignore-builders option in for now. + +* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: +* Scripts/webkitpy/tool/bot/patchanalysistask.py: +* Scripts/webkitpy/tool/commands/download.py: +* Scripts/webkitpy/tool/commands/download_unittest.py: +* Scripts/webkitpy/tool/commands/queues_unittest.py: +* Scripts/webkitpy/tool/steps/__init__.py: +* Scripts/webkitpy/tool/steps/commit.py: +* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed. +* Scripts/webkitpy/tool/steps/postdiffforrevert.py: + +2011-09-12 Eric Seidel e...@webkit.org + [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink https://bugs.webkit.org/show_bug.cgi?id=65781 Modified: trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py (94977 => 94978) --- trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py 2011-09-12 21:05:29 UTC (rev 94977) +++ trunk/Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py 2011-09-12 21:11:32 UTC (rev 94978) @@ -137,7 +137,7 @@ command_passed: success_message='Built patch' patch='197' run_webkit_patch: ['build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive'] command_passed: success_message='Passed tests' patch='197' -run_webkit_patch: ['land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 197] +run_webkit_patch: ['land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 197] command_passed: success_message='Landed patch' patch='197' self._run_through_task(commit_queue, expected_stderr) @@ -244,7 +244,7 @@ run_webkit_patch: ['build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive'] command_passed: success_message='Passed tests' patch='197' report_flaky_tests: patch='197' flaky_tests='[]' archive='mock-archive-197.zip' -run_webkit_patch: ['land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 197] +run_webkit_patch: ['land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 197] command_passed: success_message='Landed patch' patch='197' self._run_through_task(commit_queue, expected_stderr) @@ -273,7 +273,7 @@ command_failed: failure_message='Patch does not pass tests' script_error='MOCK tests failure' patch='197' run_webkit_patch: ['build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive'] command_passed: success_message='Passed tests' patch='197' -run_webkit_patch: ['land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 197] +run_webkit_patch: ['land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 197] command_passed: success_message='Landed patch' patch='197'
[webkit-changes] [94980] trunk
Title: [94980] trunk
Revision 94980
Author bda...@apple.com
Date 2011-09-12 14:52:01 -0700 (Mon, 12 Sep 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=67898
REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac
Reviewed by Simon Fraser.
Source/WebCore:
New function willPaintBrokenImage() returns true when there has been an error
loading the image and the broken image icon will be used in its place. This is
necessary since it is possible to have an error loading an image and to NOT use
the broken image icon.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::willPaintBrokenImage):
* loader/cache/CachedImage.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
LayoutTests:
* platform/mac/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/rendering/RenderImage.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (94979 => 94980)
--- trunk/LayoutTests/ChangeLog 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 21:52:01 UTC (rev 94980)
@@ -1,3 +1,12 @@
+2011-09-12 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67898
+REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac
+
+Reviewed by Simon Fraser.
+
+* platform/mac/Skipped:
+
2011-09-12 Ryosuke Niwa rn...@webkit.org
Fix a test added by r94966 to work on Mac.
Modified: trunk/LayoutTests/platform/mac/Skipped (94979 => 94980)
--- trunk/LayoutTests/platform/mac/Skipped 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/LayoutTests/platform/mac/Skipped 2011-09-12 21:52:01 UTC (rev 94980)
@@ -420,6 +420,3 @@
# https://bugs.webkit.org/show_bug.cgi?id=67716
media/media-controls-invalid-url.html
-
-# https://bugs.webkit.org/show_bug.cgi?id=67898
-fast/images/support-broken-image-delegate.html
Modified: trunk/Source/WebCore/ChangeLog (94979 => 94980)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 21:52:01 UTC (rev 94980)
@@ -1,3 +1,20 @@
+2011-09-12 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67898
+REGRESSION(r94900): fast/images/support-broken-image-delegate.html fails on Mac
+
+Reviewed by Simon Fraser.
+
+New function willPaintBrokenImage() returns true when there has been an error
+loading the image and the broken image icon will be used in its place. This is
+necessary since it is possible to have an error loading an image and to NOT use
+the broken image icon.
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::willPaintBrokenImage):
+* loader/cache/CachedImage.h:
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+
2011-09-12 James Robinson jam...@chromium.org
[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (94979 => 94980)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2011-09-12 21:52:01 UTC (rev 94980)
@@ -124,6 +124,11 @@
return brokenImageLoRes;
}
+bool CachedImage::willPaintBrokenImage() const
+{
+return errorOccurred() m_shouldPaintBrokenImage;
+}
+
Image* CachedImage::image() const
{
ASSERT(!isPurgeable());
Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (94979 => 94980)
--- trunk/Source/WebCore/loader/cache/CachedImage.h 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h 2011-09-12 21:52:01 UTC (rev 94980)
@@ -48,6 +48,7 @@
bool hasImage() const { return m_image.get(); }
Image* brokenImage(float deviceScaleFactor) const;
+bool willPaintBrokenImage() const;
bool canRender(float multiplier) const { return !errorOccurred() !imageSize(multiplier).isEmpty(); }
Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (94979 => 94980)
--- trunk/Source/WebCore/rendering/RenderImage.cpp 2011-09-12 21:41:06 UTC (rev 94979)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2011-09-12 21:52:01 UTC (rev 94980)
@@ -84,7 +84,11 @@
ASSERT_ARG(newImage, newImage);
ASSERT_ARG(newImage, newImage-image());
-Image* brokenImage = newImage-brokenImage(Page::deviceScaleFactor(frame()));
+Image* brokenImage;
+if (newImage-willPaintBrokenImage())
+brokenImage = newImage-brokenImage(Page::deviceScaleFactor(frame()));
+else
+brokenImage = newImage-image();
// imageSize() returns 0 for the error image. We need the true size of the
// error image, so we have to get it by grabbing image()
[webkit-changes] [94982] trunk/Source/WebCore
Title: [94982] trunk/Source/WebCore
Revision 94982
Author commit-qu...@webkit.org
Date 2011-09-12 15:19:37 -0700 (Mon, 12 Sep 2011)
Log Message
[chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
https://bugs.webkit.org/show_bug.cgi?id=67944
Patch by Jeff Timanus t...@chromium.org on 2011-09-12
Reviewed by Stephen White.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94981 => 94982)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 22:17:53 UTC (rev 94981)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 22:19:37 UTC (rev 94982)
@@ -1,3 +1,13 @@
+2011-09-12 Jeff Timanus t...@chromium.org
+
+[chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
+https://bugs.webkit.org/show_bug.cgi?id=67944
+
+Reviewed by Stephen White.
+
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::~ImageBuffer):
+
2011-09-12 Michael Saboff msab...@apple.com
Update RegExp and related classes to use 8 bit strings when available
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (94981 => 94982)
--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-09-12 22:17:53 UTC (rev 94981)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp 2011-09-12 22:19:37 UTC (rev 94982)
@@ -116,8 +116,10 @@
ImageBuffer::~ImageBuffer()
{
-// This is so that the SkGpuDevice destructor has the correct context.
-m_context-platformContext()-makeGrContextCurrent();
+if (m_context m_context-platformContext()) {
+// This is so that the SkGpuDevice destructor has the correct context.
+m_context-platformContext()-makeGrContextCurrent();
+}
}
GraphicsContext* ImageBuffer::context() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94983] trunk/Tools
Title: [94983] trunk/Tools
Revision 94983
Author commit-qu...@webkit.org
Date 2011-09-12 15:21:59 -0700 (Mon, 12 Sep 2011)
Log Message
Unreviewed, rolling out r94976.
http://trac.webkit.org/changeset/94976
https://bugs.webkit.org/show_bug.cgi?id=67953
Broke a bunch of security/load tests (Requested by rniwa on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-12
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::pathToLocalResource):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm
Diff
Modified: trunk/Tools/ChangeLog (94982 => 94983)
--- trunk/Tools/ChangeLog 2011-09-12 22:19:37 UTC (rev 94982)
+++ trunk/Tools/ChangeLog 2011-09-12 22:21:59 UTC (rev 94983)
@@ -1,3 +1,15 @@
+2011-09-12 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r94976.
+http://trac.webkit.org/changeset/94976
+https://bugs.webkit.org/show_bug.cgi?id=67953
+
+Broke a bunch of security/load tests (Requested by rniwa on
+#webkit).
+
+* DumpRenderTree/mac/LayoutTestControllerMac.mm:
+(LayoutTestController::pathToLocalResource):
+
2011-09-12 Eric Seidel e...@webkit.org
Rubber-stamped by Adam Barth.
Modified: trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm (94982 => 94983)
--- trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm 2011-09-12 22:19:37 UTC (rev 94982)
+++ trunk/Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm 2011-09-12 22:21:59 UTC (rev 94983)
@@ -355,24 +355,9 @@
m_waitToDump = false;
}
-JSStringRef LayoutTestController::pathToLocalResource(JSContextRef context, JSStringRef localResourcePath)
+JSStringRef LayoutTestController::pathToLocalResource(JSContextRef context, JSStringRef url)
{
-// Use the absolute path for the test from m_testPathOrURL
-// to create an absolute path for the requested local resource.
-// FIXME: This code should work on all *nix platforms and can be moved into LayoutTestController.cpp.
-size_t maxBufferSize = JSStringGetMaximumUTF8CStringSize(localResourcePath);
-char* resourcePathAsUTF8 = new char[maxBufferSize];
-size_t resourcePathAsUTF8BufferSize = JSStringGetUTF8CString(localResourcePath, resourcePathAsUTF8, maxBufferSize);
-
-std::string resourcePathAsString(resourcePathAsUTF8, resourcePathAsUTF8BufferSize - 1); // Ignore the trailing \0 when creating the string.
-delete[] resourcePathAsUTF8;
-
-size_t resourceLayoutTestsIndex = resourcePathAsString.rfind(LayoutTests/);
-ASSERT(resourceLayoutTestsIndex); // Passed in paths must include LayoutTests/
-size_t testLayoutTestsIndex = m_testPathOrURL.rfind(LayoutTests/);
-std::string resolvedResourcePath = m_testPathOrURL.substr(0, testLayoutTestsIndex) + resourcePathAsString.substr(resourceLayoutTestsIndex);
-
-return JSStringCreateWithUTF8CString(resolvedResourcePath.c_str());
+return JSStringRetain(url); // Do nothing on mac.
}
void LayoutTestController::queueLoad(JSStringRef url, JSStringRef target)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94984] trunk/Source/WebCore
Title: [94984] trunk/Source/WebCore
Revision 94984
Author crog...@google.com
Date 2011-09-12 15:43:00 -0700 (Mon, 12 Sep 2011)
Log Message
Address lifetime issues in OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=67949
Reviewed by Kenneth Russell.
No new tests. This does not change _javascript_ API.
* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (94983 => 94984)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 22:21:59 UTC (rev 94983)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 22:43:00 UTC (rev 94984)
@@ -1,3 +1,17 @@
+2011-09-12 Chris Rogers crog...@google.com
+
+Address lifetime issues in OfflineAudioDestinationNode
+https://bugs.webkit.org/show_bug.cgi?id=67949
+
+Reviewed by Kenneth Russell.
+
+No new tests. This does not change _javascript_ API.
+
+* webaudio/OfflineAudioDestinationNode.cpp:
+(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
+(WebCore::OfflineAudioDestinationNode::render):
+(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
+
2011-09-12 Jeff Timanus t...@chromium.org
[chromium] Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
Modified: trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (94983 => 94984)
--- trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp 2011-09-12 22:21:59 UTC (rev 94983)
+++ trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp 2011-09-12 22:43:00 UTC (rev 94984)
@@ -52,6 +52,9 @@
OfflineAudioDestinationNode::~OfflineAudioDestinationNode()
{
+if (m_renderThread)
+waitForThreadCompletion(m_renderThread, 0);
+
uninitialize();
}
@@ -143,6 +146,8 @@
}
// Our work is done. Let the AudioContext know.
+// See corresponding deref() call in notifyCompleteDispatch().
+ref();
callOnMainThread(notifyCompleteDispatch, this);
}
@@ -154,6 +159,7 @@
return;
destinationNode-notifyComplete();
+destinationNode-deref();
}
void OfflineAudioDestinationNode::notifyComplete()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94985] trunk/Source/JavaScriptCore
Title: [94985] trunk/Source/_javascript_Core Revision 94985 Author msab...@apple.com Date 2011-09-12 15:43:51 -0700 (Mon, 12 Sep 2011) Log Message Broken ARM build - missing semicolon in _javascript_Core/assembler/MacroAssemblerARM.h https://bugs.webkit.org/show_bug.cgi?id=67961 Added missing semicolon. Reviewed by Ryosuke Niwa. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch16): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94984 => 94985) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-12 22:43:00 UTC (rev 94984) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-12 22:43:51 UTC (rev 94985) @@ -1,5 +1,17 @@ 2011-09-12 Michael Saboff msab...@apple.com +Broken ARM build - missing semicolon in _javascript_Core/assembler/MacroAssemblerARM.h +https://bugs.webkit.org/show_bug.cgi?id=67961 + +Added missing semicolon. + +Reviewed by Ryosuke Niwa. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::branch16): + +2011-09-12 Michael Saboff msab...@apple.com + Update RegExp and related classes to use 8 bit strings when available https://bugs.webkit.org/show_bug.cgi?id=67337 Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (94984 => 94985) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-09-12 22:43:00 UTC (rev 94984) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-09-12 22:43:51 UTC (rev 94985) @@ -426,7 +426,7 @@ ASSERT(!(right.m_value 0x)); right.m_value = 16; m_assembler.mov_r(ARMRegisters::S1, left); -lshift32(16, ARMRegisters::S1) +lshift32(16, ARMRegisters::S1); return branch32(cond, ARMRegisters::S1, right); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94986] trunk/Source/WebCore
Title: [94986] trunk/Source/WebCore
Revision 94986
Author le...@chromium.org
Date 2011-09-12 15:48:38 -0700 (Mon, 12 Sep 2011)
Log Message
Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
https://bugs.webkit.org/show_bug.cgi?id=67947
Reviewed by Adam Barth.
The changes are tested by compiling and added compile asserts to do some verification as well.
* platform/CrossThreadCopier.cpp:
Added some compile asserts to verify various match and non-matches for CrossThreadCopier.
* platform/CrossThreadCopier.h:
Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
Added a compile assert to verify that only one of the typedefs did anything.
(CrossThreadCopierBasefalse, true, T::copy): Remove get as it is unnecessary.
It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/CrossThreadCopier.cpp
trunk/Source/WebCore/platform/CrossThreadCopier.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (94985 => 94986)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 22:43:51 UTC (rev 94985)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 22:48:38 UTC (rev 94986)
@@ -1,3 +1,21 @@
+2011-09-12 David Levin le...@chromium.org
+
+Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
+https://bugs.webkit.org/show_bug.cgi?id=67947
+
+Reviewed by Adam Barth.
+
+The changes are tested by compiling and added compile asserts to do some verification as well.
+
+* platform/CrossThreadCopier.cpp:
+Added some compile asserts to verify various match and non-matches for CrossThreadCopier.
+* platform/CrossThreadCopier.h:
+Added a typedef to convert T* to T, just like the typedef's to remove RefPtr and PassRefPtr.
+Added a compile assert to verify that only one of the typedef did anything.
+(CrossThreadCopierBasefalse, true, T::copy): Remove get as it is unnecessary.
+It shouldn't have been here (PassRefPtr and RefPtr easily and sometimes more efficiently
+convert to PassRefPtr without get). Also, a raw pointer doesn't have a get() method.
+
2011-09-12 Chris Rogers crog...@google.com
Address lifetime issues in OfflineAudioDestinationNode
Modified: trunk/Source/WebCore/platform/CrossThreadCopier.cpp (94985 => 94986)
--- trunk/Source/WebCore/platform/CrossThreadCopier.cpp 2011-09-12 22:43:51 UTC (rev 94985)
+++ trunk/Source/WebCore/platform/CrossThreadCopier.cpp 2011-09-12 22:48:38 UTC (rev 94986)
@@ -39,6 +39,8 @@
#include ResourceResponse.h
#include SerializedScriptValue.h
+#include wtf/Assertions.h
+
namespace WebCore {
CrossThreadCopierBasefalse, false, KURL::Type CrossThreadCopierBasefalse, false, KURL::copy(const KURL url)
@@ -66,4 +68,68 @@
return response.copyData();
}
+// Test CrossThreadCopier using COMPILE_ASSERT.
+
+// Verify that ThreadSafeRefCounted objects get handled correctly.
+class CopierThreadSafeRefCountedTest : public ThreadSafeRefCountedCopierThreadSafeRefCountedTest {
+};
+
+COMPILE_ASSERT((WTF::IsSameType
+ PassRefPtrCopierThreadSafeRefCountedTest,
+ CrossThreadCopierPassRefPtrCopierThreadSafeRefCountedTest ::Type
+ ::value),
+ PassRefPtrTest);
+COMPILE_ASSERT((WTF::IsSameType
+ PassRefPtrCopierThreadSafeRefCountedTest,
+ CrossThreadCopierRefPtrCopierThreadSafeRefCountedTest ::Type
+ ::value),
+ RefPtrTest);
+COMPILE_ASSERT((WTF::IsSameType
+ PassRefPtrCopierThreadSafeRefCountedTest,
+ CrossThreadCopierCopierThreadSafeRefCountedTest*::Type
+ ::value),
+ RawPointerTest);
+
+
+// Add a generic specialization which will let's us verify that no other template matches.
+templatetypename T struct CrossThreadCopierBasefalse, false, T {
+typedef int Type;
+};
+
+// Verify that RefCounted objects only match our generic template which exposes Type as int.
+class CopierRefCountedTest : public RefCountedCopierRefCountedTest {
+};
+
+COMPILE_ASSERT((WTF::IsSameType
+ int,
+ CrossThreadCopierPassRefPtrCopierRefCountedTest ::Type
+ ::value),
+ PassRefPtrRefCountedTest);
+
+COMPILE_ASSERT((WTF::IsSameType
+ int,
+ CrossThreadCopierRefPtrCopierRefCountedTest ::Type
+ ::value),
+ RefPtrRefCountedTest);
+
+COMPILE_ASSERT((WTF::IsSameType
+ int,
+ CrossThreadCopierCopierRefCountedTest*::Type
+ ::value),
+ RawPointerRefCountedTest);
+
+// Verify that PassOwnPtr gets passed through.
+COMPILE_ASSERT((WTF::IsSameType
+
[webkit-changes] [94987] trunk/Source/JavaScriptCore
Title: [94987] trunk/Source/_javascript_Core Revision 94987 Author msab...@apple.com Date 2011-09-12 16:14:30 -0700 (Mon, 12 Sep 2011) Log Message Broken Build for ARM - lshift32() needs TrustedImm32 arg https://bugs.webkit.org/show_bug.cgi?id=67965 Change lshift32(16, ARMRegisters::S1); to lshift32(TrustedImm32(16), ARMRegisters::S1); Reviewed by Anders Carlsson. * assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::branch16): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94986 => 94987) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-12 22:48:38 UTC (rev 94986) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-12 23:14:30 UTC (rev 94987) @@ -1,5 +1,17 @@ 2011-09-12 Michael Saboff msab...@apple.com +Broken Build for ARM - lshift32() needs TrustedImm32 arg +https://bugs.webkit.org/show_bug.cgi?id=67965 + +Change lshift32(16, ARMRegisters::S1); to lshift32(TrustedImm32(16), ARMRegisters::S1); + +Reviewed by Anders Carlsson. + +* assembler/MacroAssemblerARM.h: +(JSC::MacroAssemblerARM::branch16): + +2011-09-12 Michael Saboff msab...@apple.com + Broken ARM build - missing semicolon in _javascript_Core/assembler/MacroAssemblerARM.h https://bugs.webkit.org/show_bug.cgi?id=67961 Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (94986 => 94987) --- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-09-12 22:48:38 UTC (rev 94986) +++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2011-09-12 23:14:30 UTC (rev 94987) @@ -426,7 +426,7 @@ ASSERT(!(right.m_value 0x)); right.m_value = 16; m_assembler.mov_r(ARMRegisters::S1, left); -lshift32(16, ARMRegisters::S1); +lshift32(TrustedImm32(16), ARMRegisters::S1); return branch32(cond, ARMRegisters::S1, right); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94988] trunk
Title: [94988] trunk
Revision 94988
Author rn...@webkit.org
Date 2011-09-12 16:32:07 -0700 (Mon, 12 Sep 2011)
Log Message
REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).
Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.
Test: editing/selection/move-up-into-wrapped-line.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
LayoutTests:
Add a test to move caret upwards from an empty line below wrapped lines.
WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.
* editing/selection/move-up-into-wrapped-line-expected.txt: Added.
* editing/selection/move-up-into-wrapped-line.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp
Added Paths
trunk/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt
trunk/LayoutTests/editing/selection/move-up-into-wrapped-line.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94987 => 94988)
--- trunk/LayoutTests/ChangeLog 2011-09-12 23:14:30 UTC (rev 94987)
+++ trunk/LayoutTests/ChangeLog 2011-09-12 23:32:07 UTC (rev 94988)
@@ -1,3 +1,18 @@
+2011-09-12 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION: Moving up doesn't work in some cases
+https://bugs.webkit.org/show_bug.cgi?id=67522
+
+Reviewed by Eric Seidel.
+
+Add a test to move caret upwards from an empty line below wrapped lines.
+
+WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
+instead of before the last.
+
+* editing/selection/move-up-into-wrapped-line-expected.txt: Added.
+* editing/selection/move-up-into-wrapped-line.html: Added.
+
2011-09-12 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=67898
Added: trunk/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt (0 => 94988)
--- trunk/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt 2011-09-12 23:32:07 UTC (rev 94988)
@@ -0,0 +1,10 @@
+This test moves up caret into a wrapped line.
+i.e. the caret is moved from the empty line below hello world to before world.
+|
+
+| div
+| hello #selection-caretworld
+| div
+| br
+|
+
Added: trunk/LayoutTests/editing/selection/move-up-into-wrapped-line.html (0 => 94988)
--- trunk/LayoutTests/editing/selection/move-up-into-wrapped-line.html (rev 0)
+++ trunk/LayoutTests/editing/selection/move-up-into-wrapped-line.html 2011-09-12 23:32:07 UTC (rev 94988)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+body
+div style=width: 6ex; contenteditable=true
+divhello world/divdivbr/div
+/div
+script src=""
+script
+
+Markup.description('This test moves up caret into a wrapped line. \n'
+ + 'i.e. the caret is moved from the empty line below hello world to before world.');
+
+var div = document.getElementsByTagName('div')[0];
+div.focus();
+getSelection().setPosition(div, div.childNodes.length);
+getSelection().modify('move', 'backward', 'line');
+
+Markup.dump(div);
+
+/script
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (94987 => 94988)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 23:14:30 UTC (rev 94987)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 23:32:07 UTC (rev 94988)
@@ -1,3 +1,21 @@
+2011-09-12 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION: Moving up doesn't work in some cases
+https://bugs.webkit.org/show_bug.cgi?id=67522
+
+Reviewed by Eric Seidel.
+
+The bug was caused by previousLinePosition's attempting to obtain the last root line box using
+a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).
+
+Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
+use the positionBeforeNode for br elements.
+
+Test: editing/selection/move-up-into-wrapped-line.html
+
+* editing/visible_units.cpp:
+(WebCore::previousLinePosition):
+
2011-09-12 David Levin le...@chromium.org
Make the ThreadSafeRefCounted support in CrossThreadCopier work for T*.
Modified: trunk/Source/WebCore/editing/visible_units.cpp (94987 => 94988)
--- trunk/Source/WebCore/editing/visible_units.cpp 2011-09-12 23:14:30 UTC (rev 94987)
+++ trunk/Source/WebCore/editing/visible_units.cpp 2011-09-12 23:32:07 UTC (rev 94988)
@@ -533,7 +533,7 @@
while (n) {
if
[webkit-changes] [94989] trunk/Source/WebCore
Title: [94989] trunk/Source/WebCore
Revision 94989
Author hy...@apple.com
Date 2011-09-12 16:38:46 -0700 (Mon, 12 Sep 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=67970
Add unprefixed border-image property.
Reviewed by Beth Dakin.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSPropertyNames.in
Diff
Modified: trunk/Source/WebCore/ChangeLog (94988 => 94989)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 23:32:07 UTC (rev 94988)
+++ trunk/Source/WebCore/ChangeLog 2011-09-12 23:38:46 UTC (rev 94989)
@@ -1,3 +1,17 @@
+2011-09-12 David Hyatt hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67970
+
+Add unprefixed border-image property.
+
+Reviewed by Beth Dakin.
+
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parseValue):
+* css/CSSPropertyNames.in:
+
2011-09-12 Ryosuke Niwa rn...@webkit.org
REGRESSION: Moving up doesn't work in some cases
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (94988 => 94989)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2011-09-12 23:32:07 UTC (rev 94988)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2011-09-12 23:38:46 UTC (rev 94989)
@@ -1856,6 +1856,7 @@
case CSSPropertyBorderBottom:
case CSSPropertyBorderColor:
case CSSPropertyBorderLeft:
+case CSSPropertyBorderImage:
case CSSPropertyBorderRadius:
case CSSPropertyBorderRight:
case CSSPropertyBorderStyle:
Modified: trunk/Source/WebCore/css/CSSParser.cpp (94988 => 94989)
--- trunk/Source/WebCore/css/CSSParser.cpp 2011-09-12 23:32:07 UTC (rev 94988)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2011-09-12 23:38:46 UTC (rev 94989)
@@ -1442,6 +1442,7 @@
validPrimitive = true;
break;
+case CSSPropertyBorderImage:
case CSSPropertyWebkitBorderImage:
case CSSPropertyWebkitMaskBoxImage: {
RefPtrCSSValue result;
Modified: trunk/Source/WebCore/css/CSSPropertyNames.in (94988 => 94989)
--- trunk/Source/WebCore/css/CSSPropertyNames.in 2011-09-12 23:32:07 UTC (rev 94988)
+++ trunk/Source/WebCore/css/CSSPropertyNames.in 2011-09-12 23:38:46 UTC (rev 94989)
@@ -58,6 +58,7 @@
border-bottom-width
border-collapse
border-color
+border-image
border-image-outset
border-image-repeat
border-image-slice
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94990] trunk/Tools
Title: [94990] trunk/Tools Revision 94990 Author e...@webkit.org Date 2011-09-12 16:43:08 -0700 (Mon, 12 Sep 2011) Log Message sheriffbot whois should be smarter https://bugs.webkit.org/show_bug.cgi?id=67971 Reviewed by Adam Barth. This makes sheriffbot whois basically grep the committers list making it much easier to find a contributor by name. Unfortunately the current unittests depend on the real committers.py file, so as we add more eric's to the project, this unittest result will change. I think that's OK for now. We'll fix it when it breaks. * Scripts/webkitpy/common/config/committers.py: * Scripts/webkitpy/tool/bot/irc_command.py: * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/committers.py trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py trunk/Tools/Scripts/webkitpy/tool/bot/irc_command_unittest.py Diff Modified: trunk/Tools/ChangeLog (94989 => 94990) --- trunk/Tools/ChangeLog 2011-09-12 23:38:46 UTC (rev 94989) +++ trunk/Tools/ChangeLog 2011-09-12 23:43:08 UTC (rev 94990) @@ -1,3 +1,21 @@ +2011-09-12 Eric Seidel e...@webkit.org + +sheriffbot whois should be smarter +https://bugs.webkit.org/show_bug.cgi?id=67971 + +Reviewed by Adam Barth. + +This makes sheriffbot whois basically grep the committers list +making it much easier to find a contributor by name. + +Unfortunately the current unittests depend on the real committers.py +file, so as we add more eric's to the project, this unittest result will +change. I think that's OK for now. We'll fix it when it breaks. + +* Scripts/webkitpy/common/config/committers.py: +* Scripts/webkitpy/tool/bot/irc_command.py: +* Scripts/webkitpy/tool/bot/irc_command_unittest.py: + 2011-09-12 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r94976. Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (94989 => 94990) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-09-12 23:38:46 UTC (rev 94989) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-09-12 23:43:08 UTC (rev 94990) @@ -51,7 +51,17 @@ def __str__(self): return '%s %s' % (self.full_name, self.emails[0]) +def contains_string(self, string): +if string in self.full_name: +return True +if self.irc_nickname and string in self.irc_nickname: +return True +for email in self.emails: +if string in email: +return True +return False + class Committer(Contributor): def __init__(self, name, email_or_emails, irc_nickname=None): Contributor.__init__(self, name, email_or_emails, irc_nickname) @@ -450,6 +460,9 @@ return contributor return None +def contributors_by_search_string(self, string): +return filter(lambda contributor: contributor.contains_string(string), self.contributors()) + def contributor_by_email(self, email): return self._email_to_contributor_map().get(email) Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (94989 => 94990) --- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-09-12 23:38:46 UTC (rev 94989) +++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-09-12 23:43:08 UTC (rev 94990) @@ -172,17 +172,29 @@ class Whois(IRCCommand): +def _nick_or_full_record(self, contributor): +if contributor.irc_nickname: +return contributor.irc_nickname +return unicode(contributor) + def execute(self, nick, args, tool, sheriff): if len(args) != 1: -return %s: Usage: whois BUGZILLA_EMAIL % nick -email = args[0] +return %s: Usage: whois SEARCH_STRING % nick +search_string = args[0] # FIXME: We should get the ContributorList off the tool somewhere. -committer = CommitterList().contributor_by_email(email) -if not committer: -return %s: Sorry, I don't know %s. Maybe you could introduce me? % (nick, email) -if not committer.irc_nickname: -return %s: %s hasn't told me their nick. Boo hoo :-( % (nick, email) -return %s: %s is %s. Why do you ask? % (nick, email, committer.irc_nickname) +contributors = CommitterList().contributors_by_search_string(search_string) +if not contributors: +return %s: Sorry, I don't know any contributors matching '%s'. % (nick, search_string) +if len(contributors) 5: +return More than 5 contributors match '%s', can you be more specific? +if len(contributors) == 1: +contributor = contributors[0] +if not contributor.irc_nickname: +return %s: %s hasn't told me their nick. Boo hoo :-( % (nick, contributor) +return %s: %s is %s. Why do you ask? % (nick,
[webkit-changes] [94991] trunk
Title: [94991] trunk
Revision 94991
Author m...@apple.com
Date 2011-09-12 17:02:33 -0700 (Mon, 12 Sep 2011)
Log Message
rdar://problem/10054615 Floats in ruby text intrude into the base
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/ruby/float-overhang-from-ruby-text.html
* rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::avoidsFloats): Added. Returns true. This ensures that
RenderBlock::clearFloats() will not consider ruby text as having intruding floats.
* rendering/RenderRubyText.h:
LayoutTests:
* fast/ruby/float-overhang-from-ruby-text-expected.png: Added.
* fast/ruby/float-overhang-from-ruby-text-expected.txt: Added.
* fast/ruby/float-overhang-from-ruby-text.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderRubyText.cpp
trunk/Source/WebCore/rendering/RenderRubyText.h
Added Paths
trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.png
trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.txt
trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (94990 => 94991)
--- trunk/LayoutTests/ChangeLog 2011-09-12 23:43:08 UTC (rev 94990)
+++ trunk/LayoutTests/ChangeLog 2011-09-13 00:02:33 UTC (rev 94991)
@@ -1,3 +1,13 @@
+2011-09-12 Dan Bernstein m...@apple.com
+
+rdar://problem/10054615 Floats in ruby text intrude into the base
+
+Reviewed by Darin Adler.
+
+* fast/ruby/float-overhang-from-ruby-text-expected.png: Added.
+* fast/ruby/float-overhang-from-ruby-text-expected.txt: Added.
+* fast/ruby/float-overhang-from-ruby-text.html: Added.
+
2011-09-12 Ryosuke Niwa rn...@webkit.org
REGRESSION: Moving up doesn't work in some cases
Added: trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.txt (0 => 94991)
--- trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text-expected.txt 2011-09-13 00:02:33 UTC (rev 94991)
@@ -0,0 +1,23 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 784x75
+RenderRuby (inline) {RUBY} at (0,0) size 100x50
+ RenderRubyRun (anonymous) at (0,25) size 100x50
+RenderRubyText {RT} at (0,-25) size 100x25
+ RenderText {#text} at (50,0) size 25x25
+text run at (50,0) width 25: a
+ RenderBlock (floating) {DIV} at (0,0) size 50x50 [bgcolor=#ADD8E6]
+RenderRubyBase (anonymous) at (0,0) size 100x50
+ RenderText {#text} at (0,0) size 100x50
+text run at (0,0) width 100: aa
+RenderText {#text} at (0,0) size 0x0
+ RenderBlock {DIV} at (0,75) size 784x50
+RenderRuby (inline) {RUBY} at (0,0) size 100x50
+ RenderRubyRun (anonymous) at (0,0) size 100x50
+RenderRubyBase (anonymous) at (0,0) size 100x50
+ RenderText {#text} at (0,0) size 100x50
+text run at (0,0) width 100: aa
+RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text.html (0 => 94991)
--- trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text.html (rev 0)
+++ trunk/LayoutTests/fast/ruby/float-overhang-from-ruby-text.html 2011-09-13 00:02:33 UTC (rev 94991)
@@ -0,0 +1,15 @@
+style
+ruby { font-family: ahem; font-size: 50px; -webkit-font-smoothing: none; }
+.float { height: 50px; width: 50px; float: left; background-color: lightblue; }
+/style
+div
+rubyaartadiv class=float/div/rt/ruby
+/div
+div
+rubyaart id=targetadiv class=float/div/rt/ruby
+/div
+script
+document.body.offsetTop;
+var target = document.getElementById(target);
+target.parentNode.removeChild(target);
+/script
Modified: trunk/Source/WebCore/ChangeLog (94990 => 94991)
--- trunk/Source/WebCore/ChangeLog 2011-09-12 23:43:08 UTC (rev 94990)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 00:02:33 UTC (rev 94991)
@@ -1,3 +1,16 @@
+2011-09-12 Dan Bernstein m...@apple.com
+
+rdar://problem/10054615 Floats in ruby text intrude into the base
+
+Reviewed by Darin Adler.
+
+Test: fast/ruby/float-overhang-from-ruby-text.html
+
+* rendering/RenderRubyText.cpp:
+(WebCore::RenderRubyText::avoidsFloats): Added. Returns true. This ensures that
+RenderBlock::clearFloats() will not consider ruby text as having intruding floats.
+
[webkit-changes] [94992] trunk/Source/JavaScriptCore
Title: [94992] trunk/Source/_javascript_Core Revision 94992 Author gga...@apple.com Date 2011-09-12 17:06:28 -0700 (Mon, 12 Sep 2011) Log Message Re-enabled ENABLE(LAZY_BLOCK_FREEING). Reviewed by Stephanie Lewis. I accidentally disabled this in r94890, causing a big performance regression. * wtf/Platform.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (94991 => 94992) --- trunk/Source/_javascript_Core/ChangeLog 2011-09-13 00:02:33 UTC (rev 94991) +++ trunk/Source/_javascript_Core/ChangeLog 2011-09-13 00:06:28 UTC (rev 94992) @@ -1,3 +1,13 @@ +2011-09-12 Geoffrey Garen gga...@apple.com + +Re-enabled ENABLE(LAZY_BLOCK_FREEING). + +Reviewed by Stephanie Lewis. + +I accidentally disabled this in r94890, causing a big performance regression. + +* wtf/Platform.h: + 2011-09-12 Michael Saboff msab...@apple.com Broken Build for ARM - lshift32() needs TrustedImm32 arg Modified: trunk/Source/_javascript_Core/wtf/Platform.h (94991 => 94992) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-09-13 00:02:33 UTC (rev 94991) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-09-13 00:06:28 UTC (rev 94992) @@ -1063,6 +1063,12 @@ #endif #endif +#if !defined(ENABLE_LAZY_BLOCK_FREEING) +#if ENABLE(JSC_MULTIPLE_THREADS) +#define ENABLE_LAZY_BLOCK_FREEING 1 +#endif +#endif + #ifndef ENABLE_LARGE_HEAP #if CPU(X86) || CPU(X86_64) #define ENABLE_LARGE_HEAP 1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94994] branches/chromium/874
Title: [94994] branches/chromium/874
Revision 94994
Author rn...@webkit.org
Date 2011-09-12 17:26:50 -0700 (Mon, 12 Sep 2011)
Log Message
Merge 94988 - REGRESSION: Moving up doesn't work in some cases
https://bugs.webkit.org/show_bug.cgi?id=67522
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by previousLinePosition's attempting to obtain the last root line box using
a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines).
Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1),
use the positionBeforeNode for br elements.
Test: editing/selection/move-up-into-wrapped-line.html
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
LayoutTests:
Add a test to move caret upwards from an empty line below wrapped lines.
WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines
instead of before the last.
* editing/selection/move-up-into-wrapped-line-expected.txt: Added.
* editing/selection/move-up-into-wrapped-line.html: Added.
Review URL: http://codereview.chromium.org/7878009
Modified Paths
branches/chromium/874/Source/WebCore/editing/visible_units.cpp
Added Paths
branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt
branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line.html
Diff
Copied: branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt (from rev 94988, trunk/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt) (0 => 94994)
--- branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt 2011-09-13 00:26:50 UTC (rev 94994)
@@ -0,0 +1,10 @@
+This test moves up caret into a wrapped line.
+i.e. the caret is moved from the empty line below hello world to before world.
+|
+
+| div
+| hello #selection-caretworld
+| div
+| br
+|
+
Copied: branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line.html (from rev 94988, trunk/LayoutTests/editing/selection/move-up-into-wrapped-line.html) (0 => 94994)
--- branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line.html (rev 0)
+++ branches/chromium/874/LayoutTests/editing/selection/move-up-into-wrapped-line.html 2011-09-13 00:26:50 UTC (rev 94994)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+html
+body
+div style=width: 6ex; contenteditable=true
+divhello world/divdivbr/div
+/div
+script src=""
+script
+
+Markup.description('This test moves up caret into a wrapped line. \n'
+ + 'i.e. the caret is moved from the empty line below hello world to before world.');
+
+var div = document.getElementsByTagName('div')[0];
+div.focus();
+getSelection().setPosition(div, div.childNodes.length);
+getSelection().modify('move', 'backward', 'line');
+
+Markup.dump(div);
+
+/script
+/body
+/html
Modified: branches/chromium/874/Source/WebCore/editing/visible_units.cpp (94993 => 94994)
--- branches/chromium/874/Source/WebCore/editing/visible_units.cpp 2011-09-13 00:07:52 UTC (rev 94993)
+++ branches/chromium/874/Source/WebCore/editing/visible_units.cpp 2011-09-13 00:26:50 UTC (rev 94994)
@@ -533,7 +533,7 @@
while (n) {
if (highestEditableRoot(firstPositionInOrBeforeNode(n)) != highestRoot)
break;
-Position pos = createLegacyEditingPosition(n, caretMinOffset(n));
+Position pos = n-hasTagName(brTag) ? positionBeforeNode(n) : createLegacyEditingPosition(n, caretMaxOffset(n));
if (pos.isCandidate()) {
pos.getInlineBoxAndOffset(DOWNSTREAM, box, ignoredCaretOffset);
if (box) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94997] trunk/Source/JavaScriptCore
Title: [94997] trunk/Source/_javascript_Core
Revision 94997
Author jam...@google.com
Date 2011-09-12 18:57:00 -0700 (Mon, 12 Sep 2011)
Log Message
Unreviewed build fix for chromium.
Guard access to UString::latin1() with USE(JSC) since it is defined in _javascript_Core/runtime/UString.cpp, which
is currently only compiled in by ports that use _javascript_Core. This code is currently unreachable in builds so
no change in functionality.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::CharAccess::CharAccess):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (94996 => 94997)
--- trunk/Source/_javascript_Core/ChangeLog 2011-09-13 01:33:43 UTC (rev 94996)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-09-13 01:57:00 UTC (rev 94997)
@@ -1,3 +1,14 @@
+2011-09-12 James Robinson jam...@chromium.org
+
+Unreviewed build fix for chromium.
+
+Guard access to UString::latin1() with USE(JSC) since it is defined in _javascript_Core/runtime/UString.cpp, which
+is currently only compiled in by ports that use _javascript_Core. This code is currently unreachable in builds so
+no change in functionality.
+
+* yarr/YarrInterpreter.cpp:
+(JSC::Yarr::Interpreter::CharAccess::CharAccess):
+
2011-09-09 Filip Pizlo fpi...@apple.com
_javascript_Core does not have speculative-baseline OSR
Modified: trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp (94996 => 94997)
--- trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2011-09-13 01:33:43 UTC (rev 94996)
+++ trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp 2011-09-13 01:57:00 UTC (rev 94997)
@@ -176,10 +176,14 @@
: m_buffer(0)
{
if (s.is8Bit()) {
+#if USE(JSC)
m_charSize = Char8;
unsigned length = s.length();
m_ptr.ptr8 = m_buffer = static_castchar *(fastMalloc(length));
memcpy(m_buffer, s.latin1().data(), length);
+#else
+ASSERT_NOT_REACHED();
+#endif
} else {
m_charSize = Char16;
m_ptr.ptr16 = s.characters();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [94999] trunk/LayoutTests
Title: [94999] trunk/LayoutTests Revision 94999 Author u...@chromium.org Date 2011-09-12 19:43:44 -0700 (Mon, 12 Sep 2011) Log Message Unreviewred, update chromium test expectations. * platform/chromium/test_expectations.txt: fast/events/constructors/progress-event-constructor.html on mac Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (94998 => 94999) --- trunk/LayoutTests/ChangeLog 2011-09-13 02:25:56 UTC (rev 94998) +++ trunk/LayoutTests/ChangeLog 2011-09-13 02:43:44 UTC (rev 94999) @@ -1,3 +1,9 @@ +2011-09-12 Fumitoshi Ukai u...@chromium.org + +Unreviewred, update chromium test expectations. + +* platform/chromium/test_expectations.txt: fast/events/constructors/progress-event-constructor.html on mac + 2011-09-12 James Robinson jam...@chromium.org [chromium] Remove bad expectation that was causing us to run a compositing/ test on Leopard. Tsk tsk, Mike Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (94998 => 94999) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-13 02:25:56 UTC (rev 94998) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-09-13 02:43:44 UTC (rev 94999) @@ -3726,3 +3726,4 @@ // Failing after r94946 BUGWK67926 WIN : fast/events/constructors/progress-event-constructor.html = TEXT +BUGWK67980 MAC : fast/events/constructors/progress-event-constructor.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95001] trunk/Source/WebCore
Title: [95001] trunk/Source/WebCore
Revision 95001
Author commit-qu...@webkit.org
Date 2011-09-12 20:02:04 -0700 (Mon, 12 Sep 2011)
Log Message
Patch by Hyowon Kim hw1008@samsung.com on 2011-09-12
Reviewed by Eric Seidel.
[CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=62707
No change in fuctionality so no new tests.
Bug 62376 makes all ports use GraphicsContext3DOpenGL and
Extensions3DOpenGL when enabling WebGL.
However, some ports already have their own GC3D implementation.
In QT and chromium, for example, GC3D delegates to GC3DInternal.
So, it would be better to allow each port to decide whether or not
to include files in platform/graphics/opengl.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (95000 => 95001)
--- trunk/Source/WebCore/CMakeLists.txt 2011-09-13 02:59:50 UTC (rev 95000)
+++ trunk/Source/WebCore/CMakeLists.txt 2011-09-13 03:02:04 UTC (rev 95001)
@@ -2093,6 +2093,7 @@
${THIRDPARTY_DIR}/ANGLE/src
${THIRDPARTY_DIR}/ANGLE/include
${THIRDPARTY_DIR}/ANGLE/include/GLSLANG
+${WEBCORE_DIR}/platform/graphics/gpu
)
LIST(APPEND WebCore_LIBRARIES
${OPENGL_gl_LIBRARY}
@@ -2156,10 +2157,9 @@
html/canvas/WebKitLoseContext.cpp
platform/graphics/ANGLEWebKitBridge.cpp
+platform/graphics/GraphicsContext3D.cpp
+
platform/graphics/gpu/DrawingBuffer.cpp
-platform/graphics/GraphicsContext3D.cpp
-platform/graphics/opengl/Extensions3DOpenGL.cpp
-platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
)
ENDIF ()
Modified: trunk/Source/WebCore/ChangeLog (95000 => 95001)
--- trunk/Source/WebCore/ChangeLog 2011-09-13 02:59:50 UTC (rev 95000)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 03:02:04 UTC (rev 95001)
@@ -1,3 +1,21 @@
+2011-09-12 Hyowon Kim hw1008@samsung.com
+
+Reviewed by Eric Seidel.
+
+[CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt
+https://bugs.webkit.org/show_bug.cgi?id=62707
+
+No change in fuctionality so no new tests.
+
+Bug 62376 makes all ports use GraphicsContext3DOpenGL and
+Extensions3DOpenGL when enabling WebGL.
+However, some ports already have their own GC3D implementation.
+In QT and chromium, for example, GC3D delegates to GC3DInternal.
+So, it would be better to allow each port to decide whether or not
+to include files in platform/graphics/opengl.
+
+* CMakeLists.txt:
+
2011-09-12 Dan Bernstein m...@apple.com
rdar://problem/10054615 Floats in ruby text intrude into the base
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95002] trunk/Source/WebCore
Title: [95002] trunk/Source/WebCore Revision 95002 Author commit-qu...@webkit.org Date 2011-09-12 20:12:01 -0700 (Mon, 12 Sep 2011) Log Message Patch by Hyowon Kim hw1008@samsung.com on 2011-09-12 Reviewed by Eric Seidel. [EFL] Add GraphicsContext3DEfl for WebGL and accelerated compositing https://bugs.webkit.org/show_bug.cgi?id=62709 Add GraphicsContext3D implementation for EFL port. GraphicsContext3D delegates to GraphicsContext3DInternal. * platform/graphics/efl/GraphicsContext3DEfl.cpp: Added. (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformLayer): (WebCore::GraphicsContext3D::makeContextCurrent): (WebCore::GraphicsContext3D::isGLES2Compliant): (WebCore::GraphicsContext3D::activeTexture): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::blendColor): (WebCore::GraphicsContext3D::blendEquation): (WebCore::GraphicsContext3D::blendEquationSeparate): (WebCore::GraphicsContext3D::blendFunc): (WebCore::GraphicsContext3D::blendFuncSeparate): (WebCore::GraphicsContext3D::bufferData): (WebCore::GraphicsContext3D::bufferSubData): (WebCore::GraphicsContext3D::checkFramebufferStatus): (WebCore::GraphicsContext3D::clear): (WebCore::GraphicsContext3D::clearColor): (WebCore::GraphicsContext3D::clearDepth): (WebCore::GraphicsContext3D::clearStencil): (WebCore::GraphicsContext3D::colorMask): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::copyTexImage2D): (WebCore::GraphicsContext3D::copyTexSubImage2D): (WebCore::GraphicsContext3D::cullFace): (WebCore::GraphicsContext3D::depthFunc): (WebCore::GraphicsContext3D::depthMask): (WebCore::GraphicsContext3D::depthRange): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::disable): (WebCore::GraphicsContext3D::disableVertexAttribArray): (WebCore::GraphicsContext3D::drawArrays): (WebCore::GraphicsContext3D::drawElements): (WebCore::GraphicsContext3D::enable): (WebCore::GraphicsContext3D::enableVertexAttribArray): (WebCore::GraphicsContext3D::finish): (WebCore::GraphicsContext3D::flush): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::frontFace): (WebCore::GraphicsContext3D::generateMipmap): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::getBooleanv): (WebCore::GraphicsContext3D::getBufferParameteriv): (WebCore::GraphicsContext3D::getContextAttributes): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::getFloatv): (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv): (WebCore::GraphicsContext3D::getIntegerv): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getRenderbufferParameteriv): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getString): (WebCore::GraphicsContext3D::getTexParameterfv): (WebCore::GraphicsContext3D::getTexParameteriv): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation): (WebCore::GraphicsContext3D::getVertexAttribfv): (WebCore::GraphicsContext3D::getVertexAttribiv): (WebCore::GraphicsContext3D::getVertexAttribOffset): (WebCore::GraphicsContext3D::hint): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isEnabled): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::lineWidth): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::pixelStorei): (WebCore::GraphicsContext3D::polygonOffset): (WebCore::GraphicsContext3D::readPixels): (WebCore::GraphicsContext3D::releaseShaderCompiler): (WebCore::GraphicsContext3D::renderbufferStorage): (WebCore::GraphicsContext3D::sampleCoverage): (WebCore::GraphicsContext3D::scissor): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::stencilFunc): (WebCore::GraphicsContext3D::stencilFuncSeparate): (WebCore::GraphicsContext3D::stencilMask): (WebCore::GraphicsContext3D::stencilMaskSeparate): (WebCore::GraphicsContext3D::stencilOp): (WebCore::GraphicsContext3D::stencilOpSeparate): (WebCore::GraphicsContext3D::texImage2D):
[webkit-changes] [95003] trunk/LayoutTests
Title: [95003] trunk/LayoutTests Revision 95003 Author commit-qu...@webkit.org Date 2011-09-12 20:13:33 -0700 (Mon, 12 Sep 2011) Log Message Patch by Wyatt Carss wca...@chromium.org on 2011-09-12 Reviewed by Eric Seidel. convert editing/deleting/5390681-2.html to dump-as-markup https://bugs.webkit.org/show_bug.cgi?id=63293 Renamed editing/deleting/5390681* to editing/deleting/smart-delete-across-editable-boundaries, Added doctype/html/body to both tests, and converted smart-delete-across-editable-boundaries-2 to dump-as-markup test in the same style as the first. Also updated results. * editing/deleting/5390681.html: Removed. * editing/deleting/5390681-expected.txt: Removed. * editing/deleting/5390681-2.html: Removed. * editing/deleting/smart-delete-across-editable-boundaries.html: Added. * editing/deleting/smart-delete-across-editable-boundaries-expected.txt: Added. * editing/deleting/smart-delete-across-editable-boundaries-2.html: Added. * editing/deleting/smart-delete-across-editable-boundaries-2-expected.txt: Added. * platform/chromium-linux/editing/deleting/5390681-2-expected.png: Removed. * platform/chromium-win/editing/deleting/5390681-2-expected.png: Removed. * platform/chromium-win/editing/deleting/5390681-2-expected.txt: Removed. * platform/gtk/editing/deleting/5390681-2-expected.txt: Removed. * platform/mac-leopard/editing/deleting/5390681-2-expected.png: Removed. * platform/mac/editing/deleting/5390681-2-expected.png: Removed. * platform/mac/editing/deleting/5390681-2-expected.txt: Removed. * platform/qt/editing/deleting/5390681-2-expected.png: Removed. * platform/qt/editing/deleting/5390681-2-expected.txt: Removed. * platform/qt/editing/deleting/5390681-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2-expected.txt trunk/LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2.html trunk/LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-expected.txt trunk/LayoutTests/editing/deleting/smart-delete-across-editable-boundaries.html Removed Paths trunk/LayoutTests/editing/deleting/5390681-2.html trunk/LayoutTests/editing/deleting/5390681-expected.txt trunk/LayoutTests/editing/deleting/5390681.html trunk/LayoutTests/platform/chromium-linux/editing/deleting/5390681-2-expected.png trunk/LayoutTests/platform/chromium-win/editing/deleting/5390681-2-expected.png trunk/LayoutTests/platform/chromium-win/editing/deleting/5390681-2-expected.txt trunk/LayoutTests/platform/gtk/editing/deleting/5390681-2-expected.txt trunk/LayoutTests/platform/mac/editing/deleting/5390681-2-expected.png trunk/LayoutTests/platform/mac/editing/deleting/5390681-2-expected.txt trunk/LayoutTests/platform/mac-leopard/editing/deleting/5390681-2-expected.png trunk/LayoutTests/platform/qt/editing/deleting/5390681-2-expected.png trunk/LayoutTests/platform/qt/editing/deleting/5390681-2-expected.txt trunk/LayoutTests/platform/qt/editing/deleting/5390681-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (95002 => 95003) --- trunk/LayoutTests/ChangeLog 2011-09-13 03:12:01 UTC (rev 95002) +++ trunk/LayoutTests/ChangeLog 2011-09-13 03:13:33 UTC (rev 95003) @@ -1,3 +1,32 @@ +2011-09-12 Wyatt Carss wca...@chromium.org + +Reviewed by Eric Seidel. + +convert editing/deleting/5390681-2.html to dump-as-markup +https://bugs.webkit.org/show_bug.cgi?id=63293 + +Renamed editing/deleting/5390681* to editing/deleting/smart-delete-across-editable-boundaries, +Added doctype/html/body to both tests, and converted smart-delete-across-editable-boundaries-2 +to dump-as-markup test in the same style as the first. Also updated results. + +* editing/deleting/5390681.html: Removed. +* editing/deleting/5390681-expected.txt: Removed. +* editing/deleting/5390681-2.html: Removed. +* editing/deleting/smart-delete-across-editable-boundaries.html: Added. +* editing/deleting/smart-delete-across-editable-boundaries-expected.txt: Added. +* editing/deleting/smart-delete-across-editable-boundaries-2.html: Added. +* editing/deleting/smart-delete-across-editable-boundaries-2-expected.txt: Added. +* platform/chromium-linux/editing/deleting/5390681-2-expected.png: Removed. +* platform/chromium-win/editing/deleting/5390681-2-expected.png: Removed. +* platform/chromium-win/editing/deleting/5390681-2-expected.txt: Removed. +* platform/gtk/editing/deleting/5390681-2-expected.txt: Removed. +* platform/mac-leopard/editing/deleting/5390681-2-expected.png: Removed. +* platform/mac/editing/deleting/5390681-2-expected.png: Removed. +* platform/mac/editing/deleting/5390681-2-expected.txt: Removed. +* platform/qt/editing/deleting/5390681-2-expected.png: Removed. +* platform/qt/editing/deleting/5390681-2-expected.txt: Removed. +*
[webkit-changes] [95004] trunk/Source/WebCore
Title: [95004] trunk/Source/WebCore Revision 95004 Author commit-qu...@webkit.org Date 2011-09-12 20:24:33 -0700 (Mon, 12 Sep 2011) Log Message [EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl. https://bugs.webkit.org/show_bug.cgi?id=67038 Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-09-12 Reviewed by Kenneth Rohde Christiansen. Since most of the time it will return the same thing as text(), we initialize it the same way we initialize m_text. The other case (what would have been generated if no modifiers were pressed) should be covered by this as well. As this method is used when handling access keys, tests such as fast/events/access-key-self-destruct.html should now pass. No new tests, as this fixes a problem uncovered by the existing ones. * platform/efl/PlatformKeyboardEventEfl.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (95003 => 95004) --- trunk/Source/WebCore/ChangeLog 2011-09-13 03:13:33 UTC (rev 95003) +++ trunk/Source/WebCore/ChangeLog 2011-09-13 03:24:33 UTC (rev 95004) @@ -1,3 +1,23 @@ +2011-09-12 Raphael Kubo da Costa k...@profusion.mobi + +[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl. +https://bugs.webkit.org/show_bug.cgi?id=67038 + +Reviewed by Kenneth Rohde Christiansen. + +Since most of the time it will return the same thing as text(), we +initialize it the same way we initialize m_text. The other case (what +would have been generated if no modifiers were pressed) should be +covered by this as well. + +As this method is used when handling access keys, tests such as +fast/events/access-key-self-destruct.html should now pass. + +No new tests, as this fixes a problem uncovered by the existing ones. + +* platform/efl/PlatformKeyboardEventEfl.cpp: +(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): + 2011-09-12 Hyowon Kim hw1008@samsung.com Reviewed by Eric Seidel. Modified: trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp (95003 => 95004) --- trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2011-09-13 03:13:33 UTC (rev 95003) +++ trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2011-09-13 03:24:33 UTC (rev 95004) @@ -191,6 +191,7 @@ PlatformKeyboardEvent::PlatformKeyboardEvent(const Evas_Event_Key_Down* event) : m_type(KeyDown) , m_text(String::fromUTF8(event-string)) +, m_unmodifiedText(String::fromUTF8(event-string)) , m_shiftKey(evas_key_modifier_is_set(event-modifiers, Shift)) , m_ctrlKey(evas_key_modifier_is_set(event-modifiers, Control)) , m_altKey(evas_key_modifier_is_set(event-modifiers, Alt)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95006] trunk/Tools
Title: [95006] trunk/Tools Revision 95006 Author commit-qu...@webkit.org Date 2011-09-12 20:34:18 -0700 (Mon, 12 Sep 2011) Log Message [EFL] Send the right key names for PageUp and PageDown. https://bugs.webkit.org/show_bug.cgi?id=67044 Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-09-12 Reviewed by Kenneth Rohde Christiansen. PlatformKeyboardEventEfl uses Prior and Next to refer to PageUp and PageDown (which is close to the defines in WindowsKeyboardCodes.h). However, EventSender was sending Page_Up and Page_Down, so tests such as editing/input/page-up-down-scrolls.html were timing out due to the right key down events not being sent. * DumpRenderTree/efl/EventSender.cpp: (keyPadNameFromJSValue): (keyNameFromJSValue): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/EventSender.cpp Diff Modified: trunk/Tools/ChangeLog (95005 => 95006) --- trunk/Tools/ChangeLog 2011-09-13 03:30:43 UTC (rev 95005) +++ trunk/Tools/ChangeLog 2011-09-13 03:34:18 UTC (rev 95006) @@ -1,3 +1,20 @@ +2011-09-12 Raphael Kubo da Costa k...@profusion.mobi + +[EFL] Send the right key names for PageUp and PageDown. +https://bugs.webkit.org/show_bug.cgi?id=67044 + +Reviewed by Kenneth Rohde Christiansen. + +PlatformKeyboardEventEfl uses Prior and Next to refer to PageUp and +PageDown (which is close to the defines in WindowsKeyboardCodes.h). +However, EventSender was sending Page_Up and Page_Down, so tests +such as editing/input/page-up-down-scrolls.html were timing out due to +the right key down events not being sent. + +* DumpRenderTree/efl/EventSender.cpp: +(keyPadNameFromJSValue): +(keyNameFromJSValue): + 2011-09-12 Eric Seidel e...@webkit.org sheriffbot whois is case sensitive Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (95005 => 95006) --- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-09-13 03:30:43 UTC (rev 95005) +++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2011-09-13 03:34:18 UTC (rev 95006) @@ -315,9 +315,9 @@ if (equals(character, downArrow)) return KP_Down; if (equals(character, pageUp)) -return KP_Page_Up; +return KP_Prior; if (equals(character, pageDown)) -return KP_Page_Down; +return KP_Next; if (equals(character, home)) return KP_Home; if (equals(character, end)) @@ -344,9 +344,9 @@ if (equals(character, downArrow)) return Down; if (equals(character, pageUp)) -return Page_Up; +return Prior; if (equals(character, pageDown)) -return Page_Down; +return Next; if (equals(character, home)) return Home; if (equals(character, end)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95007] trunk/Tools
Title: [95007] trunk/Tools Revision 95007 Author commit-qu...@webkit.org Date 2011-09-12 20:38:22 -0700 (Mon, 12 Sep 2011) Log Message [EFL] DRT: Add DumpRenderTreeEfl.h https://bugs.webkit.org/show_bug.cgi?id=63993 Patch by Leandro Pereira lean...@profusion.mobi on 2011-09-12 Reviewed by Eric Seidel. This header contains some global variables used by EFL's DumpRenderTree implementation. * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when appropriate. * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/DumpRenderTree.h Added Paths trunk/Tools/DumpRenderTree/efl/DumpRenderTreeEfl.h Diff Modified: trunk/Tools/ChangeLog (95006 => 95007) --- trunk/Tools/ChangeLog 2011-09-13 03:34:18 UTC (rev 95006) +++ trunk/Tools/ChangeLog 2011-09-13 03:38:22 UTC (rev 95007) @@ -1,3 +1,17 @@ +2011-09-12 Leandro Pereira lean...@profusion.mobi + +[EFL] DRT: Add DumpRenderTreeEfl.h +https://bugs.webkit.org/show_bug.cgi?id=63993 + +Reviewed by Eric Seidel. + +This header contains some global variables used by EFL's +DumpRenderTree implementation. + +* DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when +appropriate. +* DumpRenderTree/efl/DumpRenderTreeEfl.h: Added. + 2011-09-12 Raphael Kubo da Costa k...@profusion.mobi [EFL] Send the right key names for PageUp and PageDown. Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.h (95006 => 95007) --- trunk/Tools/DumpRenderTree/DumpRenderTree.h 2011-09-13 03:34:18 UTC (rev 95006) +++ trunk/Tools/DumpRenderTree/DumpRenderTree.h 2011-09-13 03:38:22 UTC (rev 95007) @@ -42,6 +42,8 @@ #include DumpRenderTreeGtk.h #elif PLATFORM(WX) #include DumpRenderTreeWx.h +#elif PLATFORM(EFL) +#include DumpRenderTreeEfl.h #endif #include string Added: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeEfl.h (0 => 95007) --- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeEfl.h (rev 0) +++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeEfl.h 2011-09-13 03:38:22 UTC (rev 95007) @@ -0,0 +1,41 @@ +/* + * Copyright (C) 2011 ProFUSION Embedded Systems + * Copyright (C) 2011 Samsung Electronics + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Red istributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND ITS CONTRIBUTORS + * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A + * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT + * HOLDERS OR ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +#ifndef DumpRenderTreeEfl_h +#define DumpRenderTreeEfl_h + +#include Ecore.h +#include Evas.h +#include wtf/OwnPtr.h + +class DumpRenderTreeChrome; + +extern OwnPtrDumpRenderTreeChrome browser; +extern Evas_Object* topLoadingFrame; +extern bool waitForPolicy; +extern Ecore_Timer* waitToDumpWatchdog; + +#endif /* DumpRenderTreeEfl_h */ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95008] trunk/LayoutTests
Title: [95008] trunk/LayoutTests Revision 95008 Author commit-qu...@webkit.org Date 2011-09-12 20:44:39 -0700 (Mon, 12 Sep 2011) Log Message Add GTK Win expectations for two recently added accessibility layout tests. https://bugs.webkit.org/show_bug.cgi?id=67948 Patch by Dominic Mazzoni dmazz...@google.com on 2011-09-12 Reviewed by Chris Fleizach. * platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added. * platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Added. * platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added. * platform/win/accessibility/div-within-anchors-causes-crash-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt trunk/LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt trunk/LayoutTests/platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt trunk/LayoutTests/platform/win/accessibility/div-within-anchors-causes-crash-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (95007 => 95008) --- trunk/LayoutTests/ChangeLog 2011-09-13 03:38:22 UTC (rev 95007) +++ trunk/LayoutTests/ChangeLog 2011-09-13 03:44:39 UTC (rev 95008) @@ -1,3 +1,16 @@ +2011-09-12 Dominic Mazzoni dmazz...@google.com + +Add GTK Win expectations for two recently added +accessibility layout tests. +https://bugs.webkit.org/show_bug.cgi?id=67948 + +Reviewed by Chris Fleizach. + +* platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added. +* platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Added. +* platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added. +* platform/win/accessibility/div-within-anchors-causes-crash-expected.txt: Added. + 2011-09-12 Wyatt Carss wca...@chromium.org Reviewed by Eric Seidel. Added: trunk/LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (0 => 95008) --- trunk/LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt 2011-09-13 03:44:39 UTC (rev 95008) @@ -0,0 +1,18 @@ +x +y +z +End of test +Make sure that a debug assert is not triggered when constructing the accessibility tree for this page. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +AXRole: document frame +AXRole: section +AXRole: section +AXRole: paragraph +AXRole: paragraph +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt (0 => 95008) --- trunk/LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt 2011-09-13 03:44:39 UTC (rev 95008) @@ -0,0 +1,23 @@ +End of test +Before: +AXRole: document frame +AXRole: link +AXRole: section +AXRole: panel +AXRole: paragraph +AXRole: paragraph +After: +AXRole: document frame +AXRole: section +AXRole: panel +AXRole: paragraph +AXRole: paragraph +This can cause a crash. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (0 => 95008) --- trunk/LayoutTests/platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt (rev 0) +++ trunk/LayoutTests/platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt 2011-09-13 03:44:39 UTC (rev 95008) @@ -0,0 +1,28 @@ +x +y +z +End of test +Make sure that a debug assert is not triggered when constructing the accessibility tree for this page. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +client +editable text +grouping +editable text +editable text +grouping +editable text +grouping +editable text +grouping +editable text +editable text +editable text +editable text +editable text +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/platform/win/accessibility/div-within-anchors-causes-crash-expected.txt (0 => 95008) --- trunk/LayoutTests/platform/win/accessibility/div-within-anchors-causes-crash-expected.txt (rev 0) +++
[webkit-changes] [95009] trunk
Title: [95009] trunk
Revision 95009
Author commit-qu...@webkit.org
Date 2011-09-12 20:50:01 -0700 (Mon, 12 Sep 2011)
Log Message
Setting document.title doesn't affect contents of title tag of XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=57537
Patch by Jacky Jiang zhaji...@rim.com on 2011-09-12
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Update the contents of the title tag of XHTML documents when setting
document.title.
Test: fast/dom/title-content-set-innerText-get.xhtml
* dom/Document.cpp:
(WebCore::Document::setTitle):
LayoutTests:
* fast/dom/title-content-set-innerText-get-expected.txt: Added.
* fast/dom/title-content-set-innerText-get.xhtml: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Added Paths
trunk/LayoutTests/fast/dom/title-content-set-innerText-get-expected.txt
trunk/LayoutTests/fast/dom/title-content-set-innerText-get.xhtml
Diff
Modified: trunk/LayoutTests/ChangeLog (95008 => 95009)
--- trunk/LayoutTests/ChangeLog 2011-09-13 03:44:39 UTC (rev 95008)
+++ trunk/LayoutTests/ChangeLog 2011-09-13 03:50:01 UTC (rev 95009)
@@ -1,3 +1,13 @@
+2011-09-12 Jacky Jiang zhaji...@rim.com
+
+Setting document.title doesn't affect contents of title tag of XHTML documents
+https://bugs.webkit.org/show_bug.cgi?id=57537
+
+Reviewed by Alexey Proskuryakov.
+
+* fast/dom/title-content-set-innerText-get-expected.txt: Added.
+* fast/dom/title-content-set-innerText-get.xhtml: Added.
+
2011-09-12 Dominic Mazzoni dmazz...@google.com
Add GTK Win expectations for two recently added
Added: trunk/LayoutTests/fast/dom/title-content-set-innerText-get-expected.txt (0 => 95009)
--- trunk/LayoutTests/fast/dom/title-content-set-innerText-get-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/title-content-set-innerText-get-expected.txt 2011-09-13 03:50:01 UTC (rev 95009)
@@ -0,0 +1,10 @@
+This test ensures that we can update the contents of the title tag of the XHTML document when setting document.title
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById('t').innerText is 'This is the new title'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/title-content-set-innerText-get.xhtml (0 => 95009)
--- trunk/LayoutTests/fast/dom/title-content-set-innerText-get.xhtml (rev 0)
+++ trunk/LayoutTests/fast/dom/title-content-set-innerText-get.xhtml 2011-09-13 03:50:01 UTC (rev 95009)
@@ -0,0 +1,21 @@
+!DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.1//EN http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd
+html xmlns=http://www.w3.org/1999/xhtml
+head
+title id='t'Original Title/title
+link rel=stylesheet href="" /
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+description(This test ensures that we can update the contents of the title tag of the XHTML document when setting document.title);
+
+document.title = 'This is the new title';
+shouldBe(document.getElementById('t').innerText, 'This is the new title');
+
+var successfullyParsed = true;
+/script
+script src=""
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (95008 => 95009)
--- trunk/Source/WebCore/ChangeLog 2011-09-13 03:44:39 UTC (rev 95008)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 03:50:01 UTC (rev 95009)
@@ -1,3 +1,18 @@
+2011-09-12 Jacky Jiang zhaji...@rim.com
+
+Setting document.title doesn't affect contents of title tag of XHTML documents
+https://bugs.webkit.org/show_bug.cgi?id=57537
+
+Reviewed by Alexey Proskuryakov.
+
+Update the contents of the title tag of XHTML documents when setting
+document.title.
+
+Test: fast/dom/title-content-set-innerText-get.xhtml
+
+* dom/Document.cpp:
+(WebCore::Document::setTitle):
+
2011-09-12 Raphael Kubo da Costa k...@profusion.mobi
[EFL] Initialize m_unmodifiedText in PlatformKeyboardEventEfl.
Modified: trunk/Source/WebCore/dom/Document.cpp (95008 => 95009)
--- trunk/Source/WebCore/dom/Document.cpp 2011-09-13 03:44:39 UTC (rev 95008)
+++ trunk/Source/WebCore/dom/Document.cpp 2011-09-13 03:50:01 UTC (rev 95009)
@@ -1329,7 +1329,7 @@
{
// Title set by _javascript_ -- overrides any title elements.
m_titleSetExplicitly = true;
-if (!isHTMLDocument())
+if (!isHTMLDocument() !isXHTMLDocument())
m_titleElement = 0;
else if (!m_titleElement) {
if (HTMLElement* headElement = head()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95010] trunk/Source/WebCore
Title: [95010] trunk/Source/WebCore Revision 95010 Author ad...@chromium.org Date 2011-09-12 20:55:41 -0700 (Mon, 12 Sep 2011) Log Message Fix out-of-bounds access in Gradient::sortStopsIfNecessary https://bugs.webkit.org/show_bug.cgi?id=67958 Reviewed by Darin Adler. Reported by Valgrind in http://crbug.com/77049. The errant code was added as an optimization in r67804. This patch reverts that one, as all parties agree that the optimization doesn't seem worthwhile, and there clearly aren't any tests covering the special case. No new tests, as existing tests should cover the remaining call to |std::stable_sort|. * platform/graphics/Gradient.cpp: (WebCore::Gradient::sortStopsIfNecessary): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Gradient.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (95009 => 95010) --- trunk/Source/WebCore/ChangeLog 2011-09-13 03:50:01 UTC (rev 95009) +++ trunk/Source/WebCore/ChangeLog 2011-09-13 03:55:41 UTC (rev 95010) @@ -1,3 +1,23 @@ +2011-09-12 Adam Klein ad...@chromium.org + +Fix out-of-bounds access in Gradient::sortStopsIfNecessary +https://bugs.webkit.org/show_bug.cgi?id=67958 + +Reviewed by Darin Adler. + +Reported by Valgrind in http://crbug.com/77049. + +The errant code was added as an optimization in r67804. +This patch reverts that one, as all parties agree that the optimization +doesn't seem worthwhile, and there clearly aren't any tests covering +the special case. + +No new tests, as existing tests should cover the remaining call to +|std::stable_sort|. + +* platform/graphics/Gradient.cpp: +(WebCore::Gradient::sortStopsIfNecessary): + 2011-09-12 Jacky Jiang zhaji...@rim.com Setting document.title doesn't affect contents of title tag of XHTML documents Modified: trunk/Source/WebCore/platform/graphics/Gradient.cpp (95009 => 95010) --- trunk/Source/WebCore/platform/graphics/Gradient.cpp 2011-09-13 03:50:01 UTC (rev 95009) +++ trunk/Source/WebCore/platform/graphics/Gradient.cpp 2011-09-13 03:55:41 UTC (rev 95010) @@ -124,10 +124,6 @@ if (!m_stops.size()) return; -// Shortcut for the ideal case (ordered 2-stop gradient) -if (m_stops.size() == 2 compareStops(*m_stops.begin(), *m_stops.end())) -return; - std::stable_sort(m_stops.begin(), m_stops.end(), compareStops); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95012] trunk/Source/WebKit/chromium
Title: [95012] trunk/Source/WebKit/chromium
Revision 95012
Author le...@chromium.org
Date 2011-09-12 21:15:59 -0700 (Mon, 12 Sep 2011)
Log Message
[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943
Reviewed by Adam Barth.
* src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (95011 => 95012)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 04:01:59 UTC (rev 95011)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 04:15:59 UTC (rev 95012)
@@ -1,3 +1,26 @@
+2011-09-12 David Levin le...@chromium.org
+
+[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
+https://bugs.webkit.org/show_bug.cgi?id=67943
+
+Reviewed by Adam Barth.
+
+* src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
+allowing the automatic ref counting to work. This was previous needed when
+the ref counting wasn't working but that was fixed in r94986. Note that the
+design was to have ref counting since the methods take PassRefPtr and the
+class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
+adding in AllowCrossThreadAccess.)
+(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
+(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
+(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
+(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
+(WebKit::WorkerFileWriterCallbacksBridge::didFail):
+(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
+(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
+(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
+(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):
+
2011-09-08 Nat Duca nd...@chromium.org
[chromium] Add GraphicsContext3DPrivate:createGraphicsContextForAnotherThread
Modified: trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp (95011 => 95012)
--- trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp 2011-09-13 04:01:59 UTC (rev 95011)
+++ trunk/Source/WebKit/chromium/src/WorkerFileWriterCallbacksBridge.cpp 2011-09-13 04:15:59 UTC (rev 95012)
@@ -62,7 +62,7 @@
ASSERT(!m_operationInProgress);
m_operationInProgress = true;
dispatchTaskToMainThread(createCallbackTask(writeOnMainThread,
-AllowCrossThreadAccess(this), position, data));
+this, position, data));
}
void WorkerFileWriterCallbacksBridge::postTruncateToMainThread(long long length)
@@ -70,13 +70,13 @@
ASSERT(!m_operationInProgress);
m_operationInProgress = true;
dispatchTaskToMainThread(createCallbackTask(truncateOnMainThread,
-AllowCrossThreadAccess(this), length));
+this, length));
}
void WorkerFileWriterCallbacksBridge::postAbortToMainThread()
{
ASSERT(m_operationInProgress);
-dispatchTaskToMainThread(createCallbackTask(abortOnMainThread, AllowCrossThreadAccess(this)));
+dispatchTaskToMainThread(createCallbackTask(abortOnMainThread, this));
}
void WorkerFileWriterCallbacksBridge::postShutdownToMainThread(PassRefPtrWorkerFileWriterCallbacksBridge bridge)
@@ -115,17 +115,17 @@
void WorkerFileWriterCallbacksBridge::didWrite(long long bytes, bool complete)
{
-dispatchTaskToWorkerThread(createCallbackTask(didWriteOnWorkerThread, AllowCrossThreadAccess(this), bytes, complete));
+dispatchTaskToWorkerThread(createCallbackTask(didWriteOnWorkerThread, this, bytes, complete));
}
void WorkerFileWriterCallbacksBridge::didFail(WebFileError error)
{
-
[webkit-changes] [95013] trunk/Source/WebCore
Title: [95013] trunk/Source/WebCore
Revision 95013
Author joep...@webkit.org
Date 2011-09-12 21:41:42 -0700 (Mon, 12 Sep 2011)
Log Message
Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
https://bugs.webkit.org/show_bug.cgi?id=67957
Reviewed by Darin Adler.
The storageTracker singleton may already have been created
through StorageTracker::tracker before initializeTracker
gets called. Update the ASSERT in this case to check that
there is no client for the tracker.
No test, this depends on how the port initializes the tracker.
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageTracker.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (95012 => 95013)
--- trunk/Source/WebCore/ChangeLog 2011-09-13 04:15:59 UTC (rev 95012)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 04:41:42 UTC (rev 95013)
@@ -1,3 +1,20 @@
+2011-09-12 Joseph Pecoraro joep...@webkit.org
+
+Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
+https://bugs.webkit.org/show_bug.cgi?id=67957
+
+Reviewed by Darin Adler.
+
+The storageTracker singleton may already have been created
+through StorageTracker::tracker before initializeTracker
+gets called. Update the ASSERT in this case to check that
+there is no client for the tracker.
+
+No test, this depends on how the port initializes the tracker.
+
+* storage/StorageTracker.cpp:
+(WebCore::StorageTracker::initializeTracker):
+
2011-09-12 Adam Klein ad...@chromium.org
Fix out-of-bounds access in Gradient::sortStopsIfNecessary
Modified: trunk/Source/WebCore/storage/StorageTracker.cpp (95012 => 95013)
--- trunk/Source/WebCore/storage/StorageTracker.cpp 2011-09-13 04:15:59 UTC (rev 95012)
+++ trunk/Source/WebCore/storage/StorageTracker.cpp 2011-09-13 04:41:42 UTC (rev 95013)
@@ -51,7 +51,7 @@
void StorageTracker::initializeTracker(const String storagePath, StorageTrackerClient* client)
{
ASSERT(isMainThread());
-ASSERT(!storageTracker);
+ASSERT(!storageTracker || !storageTracker-m_client);
if (!storageTracker)
storageTracker = new StorageTracker(storagePath);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95015] trunk/Source/WebKit/chromium
Title: [95015] trunk/Source/WebKit/chromium
Revision 95015
Author commit-qu...@webkit.org
Date 2011-09-12 21:50:18 -0700 (Mon, 12 Sep 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-12
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (95014 => 95015)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 04:44:38 UTC (rev 95014)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-09-13 04:50:18 UTC (rev 95015)
@@ -1,3 +1,9 @@
+2011-09-12 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-09-12 David Levin le...@chromium.org
[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
Modified: trunk/Source/WebKit/chromium/DEPS (95014 => 95015)
--- trunk/Source/WebKit/chromium/DEPS 2011-09-13 04:44:38 UTC (rev 95014)
+++ trunk/Source/WebKit/chromium/DEPS 2011-09-13 04:50:18 UTC (rev 95015)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '99393'
+ 'chromium_rev': '100738'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [95017] trunk
Title: [95017] trunk
Revision 95017
Author commit-qu...@webkit.org
Date 2011-09-12 22:57:30 -0700 (Mon, 12 Sep 2011)
Log Message
Crashes in WebCore::InsertListCommand::unlistifyParagraph.
https://bugs.webkit.org/show_bug.cgi?id=67918
Patch by Shinya Kawanaka shin...@google.com on 2011-09-12
Reviewed by Ryosuke Niwa.
Source/WebCore:
execCommand(InsertUnorderedList) was crashing if the parent node of the target is
a kind of list element and it is not contenteditable.
This patch checks the parent node is contenteditable.
Test: editing/execCommand/insert-list-in-noneditable-list-parent.html
* editing/htmlediting.cpp:
(WebCore::enclosingListChild): Checks the parent node is contenteditable.
LayoutTests:
Added tests.
* editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt: Added.
* editing/execCommand/insert-list-in-noneditable-list-parent.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/htmlediting.cpp
Added Paths
trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt
trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html
Diff
Modified: trunk/LayoutTests/ChangeLog (95016 => 95017)
--- trunk/LayoutTests/ChangeLog 2011-09-13 05:35:53 UTC (rev 95016)
+++ trunk/LayoutTests/ChangeLog 2011-09-13 05:57:30 UTC (rev 95017)
@@ -1,3 +1,15 @@
+2011-09-12 Shinya Kawanaka shin...@google.com
+
+Crashes in WebCore::InsertListCommand::unlistifyParagraph.
+https://bugs.webkit.org/show_bug.cgi?id=67918
+
+Reviewed by Ryosuke Niwa.
+
+Added tests.
+
+* editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt: Added.
+* editing/execCommand/insert-list-in-noneditable-list-parent.html: Added.
+
2011-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94975.
Added: trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt (0 => 95017)
--- trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt 2011-09-13 05:57:30 UTC (rev 95017)
@@ -0,0 +1,32 @@
+execCommand(InsertUnorderedList) for contenteditable root element was crashing. The test has passed if it does not crash.
+PASS
+|
+
+| dl
+| div
+| contenteditable=true
+| id=div1
+| ul
+| li
+| br
+|
+
+| ul
+| div
+| contenteditable=true
+| id=div2
+| ul
+| li
+| br
+|
+
+| ol
+| div
+| contenteditable=true
+| id=div3
+| ul
+| li
+| #selection-caret
+| br
+|
+
Added: trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html (0 => 95017)
--- trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html (rev 0)
+++ trunk/LayoutTests/editing/execCommand/insert-list-in-noneditable-list-parent.html 2011-09-13 05:57:30 UTC (rev 95017)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+
+script src=""
+div id=div
+dldiv id=div1 contenteditable=true/div/dl
+uldiv id=div2 contenteditable=true/div/ul
+oldiv id=div3 contenteditable=true/div/ol
+/div
+
+script
+div1.focus();
+document.execCommand(InsertUnorderedList);
+
+div2.focus();
+document.execCommand(InsertUnorderedList);
+
+div3.focus();
+document.execCommand(InsertUnorderedList);
+
+Markup.description('execCommand(InsertUnorderedList) for contenteditable root element was crashing. The test has passed if it does not crash.\nPASS');
+Markup.dump(div);
+/script
Modified: trunk/Source/WebCore/ChangeLog (95016 => 95017)
--- trunk/Source/WebCore/ChangeLog 2011-09-13 05:35:53 UTC (rev 95016)
+++ trunk/Source/WebCore/ChangeLog 2011-09-13 05:57:30 UTC (rev 95017)
@@ -1,3 +1,19 @@
+2011-09-12 Shinya Kawanaka shin...@google.com
+
+Crashes in WebCore::InsertListCommand::unlistifyParagraph.
+https://bugs.webkit.org/show_bug.cgi?id=67918
+
+Reviewed by Ryosuke Niwa.
+
+execCommand(InsertUnorderedList) was crashing if the parent node of the target is
+a kind of list element and it is not contenteditable.
+This patch checks the parent node is contenteditable.
+
+Test: editing/execCommand/insert-list-in-noneditable-list-parent.html
+
+* editing/htmlediting.cpp:
+(WebCore::enclosingListChild): Checks the parent node is contenteditable.
+
2011-09-12 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r94975.
Modified: trunk/Source/WebCore/editing/htmlediting.cpp (95016 => 95017)
--- trunk/Source/WebCore/editing/htmlediting.cpp 2011-09-13 05:35:53 UTC (rev 95016)
+++ trunk/Source/WebCore/editing/htmlediting.cpp 2011-09-13 05:57:30 UTC (rev 95017)
@@ -666,7 +666,7 @@
// FIXME: This function is inappropriately named if
