[webkit-changes] [95174] trunk/Source/WebCore

[mdelaney]

Title: [95174] trunk/Source/WebCore








Revision 95174
Author mdela...@apple.com
Date 2011-09-14 23:55:46 -0700 (Wed, 14 Sep 2011)


Log Message
Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=68137

Reviewed by Simon Fraser.

No new tests. No change in behavior.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::isAccelerated): Have all just query the context directly.
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): just use isAccelerated directly
* platform/graphics/ImageBuffer.h:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer): Set isAcceleratedContext on the GraphicsContext instead of carrying the
bit around on the ImageBuffer itself.
(WebCore::ImageBuffer::copyNativeImage): Update the check. Same for all below...
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):
* platform/graphics/skia/ImageBufferSkia.cpp: Set isAcceleratedContext on the GraphicsContext instead of carrying the
bit around on the ImageBuffer itself.
(WebCore::ImageBuffer::ImageBuffer): Remove m_acceleratesRendering flag and getter.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95173 => 95174)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 06:09:05 UTC (rev 95173)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 06:55:46 UTC (rev 95174)
@@ -1,3 +1,29 @@
+2011-09-14  Matthew Delaney  
+
+Use isAcceleratedContext() on the GraphicsContext instead of flags in ImageBuffer
+https://bugs.webkit.org/show_bug.cgi?id=68137
+
+Reviewed by Simon Fraser.
+
+No new tests. No change in behavior.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::isAccelerated): Have all just query the context directly.
+(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere): just use isAccelerated directly
+* platform/graphics/ImageBuffer.h:
+* platform/graphics/cg/ImageBufferCG.cpp:
+(WebCore::ImageBuffer::ImageBuffer): Set isAcceleratedContext on the GraphicsContext instead of carrying the
+bit around on the ImageBuffer itself.
+(WebCore::ImageBuffer::copyNativeImage): Update the check. Same for all below...
+(WebCore::ImageBuffer::drawPattern):
+(WebCore::ImageBuffer::getUnmultipliedImageData):
+(WebCore::ImageBuffer::getPremultipliedImageData):
+(WebCore::ImageBuffer::putUnmultipliedImageData):
+(WebCore::ImageBuffer::putPremultipliedImageData):
+* platform/graphics/skia/ImageBufferSkia.cpp: Set isAcceleratedContext on the GraphicsContext instead of carrying the
+bit around on the ImageBuffer itself.
+(WebCore::ImageBuffer::ImageBuffer): Remove m_acceleratesRendering flag and getter.
+
 2011-09-14  Jeffrey Pfau  
 
 libxml2 fragment parser loses prefix namespaces


Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (95173 => 95174)

--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2011-09-15 06:09:05 UTC (rev 95173)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2011-09-15 06:55:46 UTC (rev 95174)
@@ -150,10 +150,7 @@
 
 bool CanvasRenderingContext2D::isAccelerated() const
 {
-#if USE(IOSURFACE_CANVAS_BACKING_STORE)
-ImageBuffer* buffer = canvas()->buffer();
-return buffer ? buffer->isAccelerated() : false;
-#elif ENABLE(ACCELERATED_2D_CANVAS)
+#if USE(IOSURFACE_CANVAS_BACKING_STORE) || ENABLE(ACCELERATED_2D_CANVAS)
 return canvas()->hasCreatedImageBuffer() && drawingContext() && drawingContext()->isAcceleratedContext();
 #else
 return false;
@@ -1511,7 +1508,7 @@
 IntRect bufferRect = enclosingIntRect(path.boundingRect());
 path.translate(FloatSize(-bufferRect.x(), -bufferRect.y()));
 
-RenderingMode renderMode = canvas()->buffer()->isAccelerated() ? Accelerated : Unaccelerated;
+RenderingMode renderMode = isAccelerated() ? Accelerated : Unaccelerated;
 OwnPtr buffer = ImageBuffer::create(bufferRect.size(), ColorSpaceDeviceRGB, renderMode);
 buffer->context()->setCompositeOperation(CompositeSourceOver);
 state().m_fillStyle->applyFillColor(buffer->context());


Modified: trunk/Source/WebCore/platform/graphics/ImageBuffer.h (95173 => 95174)

--- trunk/Source/WebCore/platform/graphics/ImageBuffer.h	2011-09-15 06:09:05 UTC (rev 95173)
+++ trunk/Source/WebCore/platform/graphics/ImageBuffer.h	2011-09-15 06:5

[webkit-changes] [95172] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95172] trunk/Source/_javascript_Core








Revision 95172
Author fpi...@apple.com
Date 2011-09-14 22:49:19 -0700 (Wed, 14 Sep 2011)


Log Message
DFG does not speculate aggressively enough on comparisons
https://bugs.webkit.org/show_bug.cgi?id=68138

Reviewed by Oliver Hunt.

This is a 75% speed-up on Kraken/ai-astar.  It's a 1% win on
V8 and an 8.5% win on Kraken.  Neutral on SunSpider.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compare):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95171 => 95172)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:48:47 UTC (rev 95171)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:49:19 UTC (rev 95172)
@@ -1,5 +1,26 @@
 2011-09-14  Filip Pizlo  
 
+DFG does not speculate aggressively enough on comparisons
+https://bugs.webkit.org/show_bug.cgi?id=68138
+
+Reviewed by Oliver Hunt.
+
+This is a 75% speed-up on Kraken/ai-astar.  It's a 1% win on
+V8 and an 8.5% win on Kraken.  Neutral on SunSpider.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
+(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
+(JSC::DFG::SpeculativeJIT::compileObjectEquality):
+(JSC::DFG::SpeculativeJIT::compare):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObject):
+(JSC::DFG::SpeculativeJIT::shouldSpeculateArray):
+(JSC::DFG::SpeculativeJIT::shouldSpeculateObject):
+(JSC::DFG::SpeculativeJIT::shouldSpeculateCell):
+
+2011-09-14  Filip Pizlo  
+
 DFG JIT does not leverage integer speculations on branches
 https://bugs.webkit.org/show_bug.cgi?id=68140
 


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (95171 => 95172)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-15 05:48:47 UTC (rev 95171)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-15 05:49:19 UTC (rev 95172)
@@ -33,6 +33,9 @@
 template
 GPRReg SpeculativeJIT::fillSpeculateIntInternal(NodeIndex nodeIndex, DataFormat& returnFormat)
 {
+#if ENABLE(DFG_DEBUG_VERBOSE)
+fprintf(stderr, "SpecInt@%d   ", nodeIndex);
+#endif
 Node& node = m_jit.graph()[nodeIndex];
 VirtualRegister virtualRegister = node.virtualRegister();
 GenerationInfo& info = m_generationInfo[virtualRegister];
@@ -254,6 +257,9 @@
 
 FPRReg SpeculativeJIT::fillSpeculateDouble(NodeIndex nodeIndex)
 {
+#if ENABLE(DFG_DEBUG_VERBOSE)
+fprintf(stderr, "SpecDouble@%d   ", nodeIndex);
+#endif
 Node& node = m_jit.graph()[nodeIndex];
 VirtualRegister virtualRegister = node.virtualRegister();
 GenerationInfo& info = m_generationInfo[virtualRegister];
@@ -374,6 +380,9 @@
 
 GPRReg SpeculativeJIT::fillSpeculateCell(NodeIndex nodeIndex)
 {
+#if ENABLE(DFG_DEBUG_VERBOSE)
+fprintf(stderr, "SpecCell@%d   ", nodeIndex);
+#endif
 Node& node = m_jit.graph()[nodeIndex];
 VirtualRegister virtualRegister = node.virtualRegister();
 GenerationInfo& info = m_generationInfo[virtualRegister];
@@ -436,6 +445,9 @@
 
 GPRReg SpeculativeJIT::fillSpeculateBoolean(NodeIndex nodeIndex)
 {
+#if ENABLE(DFG_DEBUG_VERBOSE)
+fprintf(stderr, "SpecBool@%d   ", nodeIndex);
+#endif
 Node& node = m_jit.graph()[nodeIndex];
 VirtualRegister virtualRegister = node.virtualRegister();
 GenerationInfo& info = m_generationInfo[virtualRegister];
@@ -555,84 +567,73 @@
 return notNumber;
 }
 
-void SpeculativeJIT::compilePeepHoleDoubleBranch(Node& node, NodeIndex branchNodeIndex, JITCompiler::DoubleCondition condition, Z_DFGOperation_EJJ operation)
+void SpeculativeJIT::compilePeepHoleDoubleBranch(Node& node, NodeIndex branchNodeIndex, JITCompiler::DoubleCondition condition)
 {
 Node& branchNode = m_jit.graph()[branchNodeIndex];
 BlockIndex taken = m_jit.graph().blockIndexForBytecodeOffset(branchNode.takenBytecodeOffset());
 BlockIndex notTaken = m_jit.graph().blockIndexForBytecodeOffset(branchNode.notTakenBytecodeOffset());
 
-bool op1Numeric = isKnownNumeric(node.child1());
-bool op2Numeric = isKnownNumeric(node.child2());
+SpeculateDoubleOperand op1(this, node.child1());
+SpeculateDoubleOperand op2(this, node.child2());
 
-if (op1Numeric && op2Numeric) {
-SpeculateDoubleOperand op1(this, node.child1());
-Specul

[webkit-changes] [95171] trunk/Source/WebKit/chromium

[commit-queue]

Title: [95171] trunk/Source/WebKit/chromium








Revision 95171
Author commit-qu...@webkit.org
Date 2011-09-14 22:48:47 -0700 (Wed, 14 Sep 2011)


Log Message
Remove some dependencies of DRT for Android.
https://bugs.webkit.org/show_bug.cgi?id=68126

Patch by Hao Zheng  on 2011-09-14
Reviewed by Tony Chang.

We don't need mesa and TestNetscapePlugIn on Android, so remove them.
As copy_TNPI depends on TNPI, adding copy_TNPI is enough.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95170 => 95171)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 05:44:07 UTC (rev 95170)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 05:48:47 UTC (rev 95171)
@@ -1,3 +1,15 @@
+2011-09-14  Hao Zheng  
+
+Remove some dependencies of DRT for Android.
+https://bugs.webkit.org/show_bug.cgi?id=68126
+
+Reviewed by Tony Chang.
+
+We don't need mesa and TestNetscapePlugIn on Android, so remove them.
+As copy_TNPI depends on TNPI, adding copy_TNPI is enough.
+
+* WebKit.gyp:
+
 2011-09-14  Peter Beverloo  
 
 [Chromium] Make WEB_AUDIO conditional and fix the build when disabled


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (95170 => 95171)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-09-15 05:44:07 UTC (rev 95170)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-09-15 05:48:47 UTC (rev 95171)
@@ -992,13 +992,10 @@
 'dependencies': [
 'ImageDiff',
 'inspector_resources',
-'TestNetscapePlugIn',
-'copy_TestNetscapePlugIn',
 'webkit',
 '../../_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp:wtf_config',
 '<(chromium_src_dir)/build/temp_gyp/googleurl.gyp:googleurl',
 '<(chromium_src_dir)/third_party/icu/icu.gyp:icuuc',
-'<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa',
 '<(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
 '<(chromium_src_dir)/webkit/support/webkit_support.gyp:blob',
 '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support',
@@ -1138,6 +1135,10 @@
 'sources/': [
 ['exclude', '(Android)\\.cpp$']
 ],
+'dependencies': [
+'copy_TestNetscapePlugIn',
+'<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa',
+],
 }],
 ['inside_chromium_build==1 and component=="shared_library"', {
 'sources': [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95170] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95170] trunk/Source/_javascript_Core








Revision 95170
Author fpi...@apple.com
Date 2011-09-14 22:44:07 -0700 (Wed, 14 Sep 2011)


Log Message
DFG JIT does not leverage integer speculations on branches
https://bugs.webkit.org/show_bug.cgi?id=68140

Reviewed by Oliver Hunt.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isStrictInt32):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95169 => 95170)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:26:45 UTC (rev 95169)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:44:07 UTC (rev 95170)
@@ -1,3 +1,16 @@
+2011-09-14  Filip Pizlo  
+
+DFG JIT does not leverage integer speculations on branches
+https://bugs.webkit.org/show_bug.cgi?id=68140
+
+Reviewed by Oliver Hunt.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::isStrictInt32):
+* dfg/DFGJITCodeGenerator.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
 2011-09-14  Gavin Barraclough  
 
 [n]stricteq code is bogus in JSValue32_64 JIT


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (95169 => 95170)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-15 05:26:45 UTC (rev 95169)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-15 05:44:07 UTC (rev 95170)
@@ -350,6 +350,17 @@
 }
 }
 
+bool JITCodeGenerator::isStrictInt32(NodeIndex nodeIndex)
+{
+if (isInt32Constant(nodeIndex))
+return true;
+
+Node& node = m_jit.graph()[nodeIndex];
+GenerationInfo& info = m_generationInfo[node.virtualRegister()];
+
+return info.registerFormat() == DataFormatInteger;
+}
+
 bool JITCodeGenerator::isKnownInteger(NodeIndex nodeIndex)
 {
 if (isInt32Constant(nodeIndex))


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (95169 => 95170)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-15 05:26:45 UTC (rev 95169)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-15 05:44:07 UTC (rev 95170)
@@ -408,6 +408,8 @@
 info.spill((DataFormat)(spillFormat | DataFormatJS));
 }
 
+bool isStrictInt32(NodeIndex);
+
 bool isKnownInteger(NodeIndex);
 bool isKnownNumeric(NodeIndex);
 bool isKnownCell(NodeIndex);


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (95169 => 95170)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-15 05:26:45 UTC (rev 95169)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-09-15 05:44:07 UTC (rev 95170)
@@ -1278,6 +1278,51 @@
 }
 
 case Branch:
+if (isStrictInt32(node.child1())) {
+SpeculateStrictInt32Operand op(this, node.child1());
+
+BlockIndex taken = m_jit.graph().blockIndexForBytecodeOffset(node.takenBytecodeOffset());
+BlockIndex notTaken = m_jit.graph().blockIndexForBytecodeOffset(node.notTakenBytecodeOffset());
+
+MacroAssembler::ResultCondition condition = MacroAssembler::NonZero;
+
+if (taken == (m_block + 1)) {
+condition = MacroAssembler::Zero;
+BlockIndex tmp = taken;
+taken = notTaken;
+notTaken = tmp;
+}
+
+addBranch(m_jit.branchTest32(condition, op.gpr()), taken);
+if (notTaken != (m_block + 1))
+addBranch(m_jit.jump(), notTaken);
+
+noResult(m_compileIndex);
+break;
+}
+if (shouldSpeculateInteger(node.child1())) {
+SpeculateIntegerOperand op(this, node.child1());
+
+BlockIndex taken = m_jit.graph().blockIndexForBytecodeOffset(node.takenBytecodeOffset());
+BlockIndex notTaken = m_jit.graph().blockIndexForBytecodeOffset(node.notTakenBytecodeOffset());
+
+MacroAssembler::RelationalCondition condition = MacroAssembler::NotEqual;
+
+if (taken == (m_block + 1)) {
+condition = MacroAssembler::Equal;
+BlockIndex tmp = taken;
+taken = notTaken;
+notTaken = tmp;
+}
+
+addBranch(m_jit.branchPtr(condition, op.gpr(), GPRInfo::tagTypeNumberRegister), taken);
+
+if (notTaken != (m_block + 1))
+addBranch(m_jit.jump(), notTaken);
+
+noResult(m_compileIndex);
+break;
+}
 emitBranch(node);
 break;
 






___
webk

[webkit-changes] [95169] trunk

[commit-queue]

Title: [95169] trunk








Revision 95169
Author commit-qu...@webkit.org
Date 2011-09-14 22:26:45 -0700 (Wed, 14 Sep 2011)


Log Message
libxml2 fragment parser loses prefix namespaces
https://bugs.webkit.org/show_bug.cgi?id=66423

Source/WebCore:

This makes the loop over the elements outside of the context actually update the element it's processing.

Patch by Jeffrey Pfau  on 2011-09-14
Reviewed by Eric Seidel.

Test: fast/parser/innerhtml-with-prefixed-elements.xhtml

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):

LayoutTests:

Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.

Patch by Jeffrey Pfau  on 2011-09-14
Reviewed by Eric Seidel.

* fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp


Added Paths

trunk/LayoutTests/fast/parser/innerhtml-with-prefixed-elements.xhtml
trunk/LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png
trunk/LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95168 => 95169)

--- trunk/LayoutTests/ChangeLog	2011-09-15 05:17:20 UTC (rev 95168)
+++ trunk/LayoutTests/ChangeLog	2011-09-15 05:26:45 UTC (rev 95169)
@@ -1,3 +1,16 @@
+2011-09-14  Jeffrey Pfau  
+
+libxml2 fragment parser loses prefix namespaces
+https://bugs.webkit.org/show_bug.cgi?id=66423
+
+Added a test to ensure that elements inserted when the prefix is already declared are inserted properly.
+
+Reviewed by Eric Seidel.
+
+* fast/parser/innerhtml-with-prefixed-elements.xhtml: Added.
+* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png: Added.
+* platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Added.
+
 2011-09-14  Keishi Hattori  
 
 [chromium] Add slow to debug version of styles-source-lines.html.


Added: trunk/LayoutTests/fast/parser/innerhtml-with-prefixed-elements.xhtml (0 => 95169)

--- trunk/LayoutTests/fast/parser/innerhtml-with-prefixed-elements.xhtml	(rev 0)
+++ trunk/LayoutTests/fast/parser/innerhtml-with-prefixed-elements.xhtml	2011-09-15 05:26:45 UTC (rev 95169)
@@ -0,0 +1,21 @@
+
+
+Namespace chaining
+
+
+
+TEST FAILED
+
+TEST FAILED";
+var rect = document.getElementById("r");
+if (rect.namespaceURI == "http://www.w3.org/2000/svg") {
+var defs = document.getElementById("defs");
+defs.parentNode.removeChild(defs);
+} else {
+console.log("Incorrect namespace:", rect.namespaceURI);
+}
+]]>
+
+


Added: trunk/LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png (0 => 95169)

--- trunk/LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/parser/innerhtml-with-prefixed-elements-expected.png	2011-09-15 05:26:45 UTC (rev 95169)
@@ -0,0 +1,45 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82p)tEXtchecksumc7440ff83cdfb889580860982591059bp\x8C\xD6iCCPICC Profilex
\x85T\xDFk\xD3P\xFE\xDAe\x9D\xB0\xE1\x8B:g	>h\x91ndStC\x9C\xB6kW\xBA\xCDZ\xEA6\xB7!H\x9B\xA6m\\x9A\xC6$\xED~\xB0ًo:\xC5w\xF1>\xF9كo{\x92
+\xC6a\xF8\xAC\x88"L\xF6"\xB3\x9E\x9B4M'S\xB9\xF7\xBB\xDF\xF9\xEE9'\xE7\xE4^\xA0\xF9qZ\xD3/USO\xC5\xC2\xFC\xC4\xE4\xDF\xF2
^C+\xFChM\x8B\x86J&G@Ӳy\xEF\xB3\xF3\xC6lt\xEEo߫\xFEc՚\x95\xF0 \xBE\x945\xC4"\xE1Y\xA0i\\xD4t\xE0։\xEF\x9D15\xC2\xCDLsX\xA7	g8oc\x81ግ#\x96f45@\x9A	\xC2\xC5B:K\xB8@8\x98i\xE0\xF3
+\xD8΁\xE4'&\xA9\x92.\x8B<\xABER/\xE5dE\xB2\xF6\xF0s\x83\xF2_\xB0\xA8\x94雭\xE7\x8Dm\x9AN\xD1|\x8A\xDE9}p\x8C\xE6\xD5\xC1?_\xBDA\xB8\x9DpX6\xE3\xA35~B\xCD$\xAE&\xBD\xE7\xEEti\x98\xEDe\x9A\x97Y)%$\xBCbT\xAE3li\xE6\x89\x9A\xE6\xD3\xED\xF4P\x92\xB0\x9F4\xBF43Y\xF3\xE3\xEDP\x95\xEB1\xC5\xF5\xF6KF\xF4\xBA\xBD\xD7ۑ\x93\xE35>\xA7)\xD6@\xFE\xBD\xF7\xF5r\x8A\xE5y\x92\xF0\xEB\xB4\x8D\xD5\xF4[\x92:V\xDB\xDB\xE4ͦ#\xC3\xC4wQ?HB\x82\x8Ed(\xE0\x91Ba\x9AcĪ\xF8L"J\xA4\xD2itTy\xB28\xD6;(\x93\x96\xEDGx\xC9_\xB8^\xF5[\xB2\xB8\xF6\xE0\xFB\x9E\xDD%׎\xBC\x85ŷ\xA3\xD8Q\x{DD41}麲\x9Aua\xA5\xA3n\xE17\xB9\xE5\x9Bm\xABQ\xFE\x8A\xE5\xB1H^e\xCAO\x82Q\xD7u6\xE6\x90S\x97\xFCu\xCF2\x94\xEE%vX\xBA\xAC\xF0

[webkit-changes] [95168] trunk/Source/JavaScriptCore

[barraclough]

Title: [95168] trunk/Source/_javascript_Core








Revision 95168
Author barraclo...@apple.com
Date 2011-09-14 22:17:20 -0700 (Wed, 14 Sep 2011)


Log Message
[n]stricteq code is bogus in JSValue32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=68141

Reviewed by Sam Weinig.

The code tries to check for both ints or cells, but this check also
catches cases where values that are undefined, null, etc (probably
was incorrectly assuming cell was the 2nd highest tag?).

Also, there is no need not to handle int on the fast path.
stricteq is just a case of comparing the payloads, if we:
* handle cases of differing tags on a slow path
* handle doubles a slow path
* handle both-are-string on a slow path

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95167 => 95168)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:15:16 UTC (rev 95167)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:17:20 UTC (rev 95168)
@@ -1,3 +1,25 @@
+2011-09-14  Gavin Barraclough  
+
+[n]stricteq code is bogus in JSValue32_64 JIT
+https://bugs.webkit.org/show_bug.cgi?id=68141
+
+Reviewed by Sam Weinig.
+
+The code tries to check for both ints or cells, but this check also
+catches cases where values that are undefined, null, etc (probably
+was incorrectly assuming cell was the 2nd highest tag?).
+
+Also, there is no need not to handle int on the fast path.
+stricteq is just a case of comparing the payloads, if we:
+* handle cases of differing tags on a slow path
+* handle doubles a slow path
+* handle both-are-string on a slow path
+
+* jit/JITOpcodes32_64.cpp:
+(JSC::JIT::compileOpStrictEq):
+(JSC::JIT::emitSlow_op_stricteq):
+(JSC::JIT::emitSlow_op_nstricteq):
+
 2011-09-14  Mark Hahnenberg  
 
 Make JSCell::toBoolean non-virtual


Modified: trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp (95167 => 95168)

--- trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp	2011-09-15 05:15:16 UTC (rev 95167)
+++ trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp	2011-09-15 05:17:20 UTC (rev 95168)
@@ -995,20 +995,24 @@
 unsigned src1 = currentInstruction[2].u.operand;
 unsigned src2 = currentInstruction[3].u.operand;
 
-emitLoadTag(src1, regT0);
-emitLoadTag(src2, regT1);
+emitLoad2(src1, regT1, regT0, src2, regT3, regT2);
 
-// Jump to a slow case if either operand is double, or if both operands are
-// cells and/or Int32s.
-move(regT0, regT2);
-and32(regT1, regT2);
-addSlowCase(branch32(Below, regT2, TrustedImm32(JSValue::LowestTag)));
-addSlowCase(branch32(AboveOrEqual, regT2, TrustedImm32(JSValue::CellTag)));
+// Bail if the tags differ, or are double.
+addSlowCase(branch32(NotEqual, regT1, regT3));
+addSlowCase(branch32(Below, regT1, TrustedImm32(JSValue::LowestTag)));
 
+// Jump to a slow case if both are strings.
+Jump notCell = branch32(NotEqual, regT1, TrustedImm32(JSValue::CellTag));
+Jump firstNotString = branchPtr(NotEqual, Address(regT0), TrustedImmPtr(m_globalData->jsStringVPtr));
+addSlowCase(branchPtr(Equal, Address(regT2), TrustedImmPtr(m_globalData->jsStringVPtr)));
+notCell.link(this);
+firstNotString.link(this);
+
+// Simply compare the payloads.
 if (type == OpStrictEq)
-compare32(Equal, regT0, regT1, regT0);
+compare32(Equal, regT0, regT2, regT0);
 else
-compare32(NotEqual, regT0, regT1, regT0);
+compare32(NotEqual, regT0, regT2, regT0);
 
 emitStoreBool(dst, regT0);
 }
@@ -1026,6 +1030,7 @@
 
 linkSlowCase(iter);
 linkSlowCase(iter);
+linkSlowCase(iter);
 
 JITStubCall stubCall(this, cti_op_stricteq);
 stubCall.addArgument(src1);
@@ -1046,6 +1051,7 @@
 
 linkSlowCase(iter);
 linkSlowCase(iter);
+linkSlowCase(iter);
 
 JITStubCall stubCall(this, cti_op_nstricteq);
 stubCall.addArgument(src1);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95167] trunk/Source/JavaScriptCore

[mhahnenberg]

Title: [95167] trunk/Source/_javascript_Core








Revision 95167
Author mhahnenb...@apple.com
Date 2011-09-14 22:15:16 -0700 (Wed, 14 Sep 2011)


Log Message
Make JSCell::toBoolean non-virtual
https://bugs.webkit.org/show_bug.cgi?id=67727

Reviewed by Sam Weinig.

JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where
before it was simply virtual and would crash if its implementation was called).
Its descendants in JSObject and JSString have also been made non-virtual.  JSCell now
explicitly covers all cases of toBoolean, so having a virtual implementation of
JSCell::toBoolean is no longer necessary.  This is part of a larger process of un-virtualizing JSCell.

* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.h:
* runtime/JSString.h:
(JSC::JSCell::toBoolean):
(JSC::JSValue::toBoolean):
* runtime/StringObjectThatMasqueradesAsUndefined.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp
trunk/Source/_javascript_Core/runtime/JSNotAnObject.h
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/StringObjectThatMasqueradesAsUndefined.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95166 => 95167)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:12:51 UTC (rev 95166)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 05:15:16 UTC (rev 95167)
@@ -1,3 +1,28 @@
+2011-09-14  Mark Hahnenberg  
+
+Make JSCell::toBoolean non-virtual
+https://bugs.webkit.org/show_bug.cgi?id=67727
+
+Reviewed by Sam Weinig.
+
+JSCell::toBoolean now manually performs the toBoolean check for objects and strings (where 
+before it was simply virtual and would crash if its implementation was called). 
+Its descendants in JSObject and JSString have also been made non-virtual.  JSCell now
+explicitly covers all cases of toBoolean, so having a virtual implementation of 
+JSCell::toBoolean is no longer necessary.  This is part of a larger process of un-virtualizing JSCell.
+
+* _javascript_Core.exp:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+* runtime/JSCell.cpp:
+* runtime/JSCell.h:
+* runtime/JSNotAnObject.cpp:
+* runtime/JSNotAnObject.h:
+* runtime/JSObject.h:
+* runtime/JSString.h:
+(JSC::JSCell::toBoolean):
+(JSC::JSValue::toBoolean):
+* runtime/StringObjectThatMasqueradesAsUndefined.h:
+
 2011-09-14  Alexis Menard  
 
 [Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (95166 => 95167)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-15 05:12:51 UTC (rev 95166)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-15 05:15:16 UTC (rev 95167)
@@ -563,7 +563,6 @@
 __ZNK3JSC6JSCell8toStringEPNS_9ExecStateE
 __ZNK3JSC6JSCell9getStringEPNS_9ExecStateE
 __ZNK3JSC6JSCell9getStringEPNS_9ExecStateERNS_7UStringE
-__ZNK3JSC6JSCell9toBooleanEPNS_9ExecStateE
 __ZNK3JSC7ArgList8getSliceEiRS0_
 __ZNK3JSC7JSArray12subclassDataEv
 __ZNK3JSC7JSValue16toNumberSlowCaseEPNS_9ExecStateE
@@ -585,6 +584,7 @@
 __ZNK3JSC8JSObject9classNameEv
 __ZNK3JSC8JSObject9toBooleanEPNS_9ExecStateE
 __ZNK3JSC8JSString11resolveRopeEPNS_9ExecStateE
+__ZNK3JSC8JSString9toBooleanEPNS_9ExecStateE
 __ZNK3JSC9HashTable11createTableEPNS_12JSGlobalDataE
 __ZNK3JSC9HashTable11deleteTableEv
 __ZNK3WTF12AtomicString5lowerEv


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (95166 => 95167)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-09-15 05:12:51 UTC (rev 95166)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-09-15 05:15:16 UTC (rev 95167)
@@ -347,9 +347,6 @@
 ?timedWait@ThreadCondition@WTF@@QAE_NAAVMutex@2@N@Z
 ?tlsKeyCount@WTF@@YAAAJXZ
 ?tlsKeys@WTF@@YAPAKXZ
-?toBoolean@JSCell@JSC@@UBE_NPAVExecState@2@@Z
-?toBoolean@JSObject@JSC@@UBE_NPAVExecState@2@@Z
-?toBoolean@JSString@JSC@@EBE_NPAVExecState@2@@Z
 ?toInt32@JSC@@YAHN@Z
 ?toInteger@JSValue@JSC@@QBENPAVExecState@2@@Z
 ?toNumber@JSCell@JSC@@UBENPAVExecState@2@@Z


Modified: trunk/Source/_javascript_Core/runtime/JSCell.cpp (95166 => 95167)

--- trunk/Source/_javascript_Core/runtime/JSCell.cpp	2011-09-15 05:12:51 UTC (rev 95166)
+++ trunk/Source/_javascript_Core/runtime

[webkit-changes] [95166] trunk/Source/WebCore

[japhet]

Title: [95166] trunk/Source/WebCore








Revision 95166
Author jap...@chromium.org
Date 2011-09-14 22:12:51 -0700 (Wed, 14 Sep 2011)


Log Message
[V8] Null-check the v8::Context in
V8DOMWindowShell:namedItemAdded() before using it.
Also, add some logging to figure out how we're getting
into this bad state.
https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

No new tests, no known repro.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95165 => 95166)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 04:46:29 UTC (rev 95165)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 05:12:51 UTC (rev 95166)
@@ -1,3 +1,18 @@
+2011-09-14  Nate Chapin  
+
+[V8] Null-check the v8::Context in 
+V8DOMWindowShell:namedItemAdded() before using it.
+Also, add some logging to figure out how we're getting
+into this bad state.
+https://bugs.webkit.org/show_bug.cgi?id=68099
+
+Reviewed by Adam Barth.
+
+No new tests, no known repro.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::namedItemAdded):
+
 2011-09-14  Patrick Gansterer  
 
 Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (95165 => 95166)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-15 04:46:29 UTC (rev 95165)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-15 05:12:51 UTC (rev 95166)
@@ -572,6 +572,23 @@
 {
 initContextIfNeeded();
 
+if (!isContextInitialized()) {
+#if PLATFORM(CHROMIUM)
+// FIXME: Temporary diagnostics as to why V8 sometimes crashes with a null context below.
+// See https://bugs.webkit.org/show_bug.cgi?id=68099.
+PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.initContextFailed");
+if (m_frame->settings() && !m_frame->settings()->isJavaScriptEnabled())
+PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.scriptBlockedByWebCoreSettings");
+
+if (!m_frame->script()->canExecuteScripts(NotAboutToExecuteScript))
+PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.scriptBlockedByScriptController");
+
+if (V8Proxy::handleOutOfMemory())
+PlatformSupport::incrementStatsCounter("V8Bindings.namedItemAdded.outOfMemory");
+#endif
+return;
+}
+
 v8::HandleScope handleScope;
 v8::Context::Scope contextScope(m_context);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95165] trunk/Source/WebCore

[paroga]

Title: [95165] trunk/Source/WebCore








Revision 95165
Author par...@webkit.org
Date 2011-09-14 21:46:29 -0700 (Wed, 14 Sep 2011)


Log Message
Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=64960

Reviewed by Ryosuke Niwa.

* xml/XMLHttpRequest.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/xml/XMLHttpRequest.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (95164 => 95165)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 04:43:16 UTC (rev 95164)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 04:46:29 UTC (rev 95165)
@@ -1,3 +1,12 @@
+2011-09-14  Patrick Gansterer  
+
+Replace ENABLE_XHR_RESPONSE_BLOB preprocessor statements in IDL files with Conditional attribute
+https://bugs.webkit.org/show_bug.cgi?id=64960
+
+Reviewed by Ryosuke Niwa.
+
+* xml/XMLHttpRequest.idl:
+
 2011-09-14  Alexei Svitkine  
 
 Chromium: Add a layer for rubber-band overhang painting to the hardware path.


Modified: trunk/Source/WebCore/xml/XMLHttpRequest.idl (95164 => 95165)

--- trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-09-15 04:43:16 UTC (rev 95164)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.idl	2011-09-15 04:46:29 UTC (rev 95165)
@@ -58,10 +58,8 @@
 readonly attribute unsigned short readyState;
 
 // request
-#if defined(ENABLE_XHR_RESPONSE_BLOB) && ENABLE_XHR_RESPONSE_BLOB
-attribute [EnabledAtRuntime] boolean asBlob
+attribute [Conditional=XHR_RESPONSE_BLOB, EnabledAtRuntime] boolean asBlob
 setter raises(DOMException);
-#endif
 
 attribute boolean withCredentials
 setter raises(DOMException);
@@ -92,10 +90,8 @@
 getter raises(DOMException);
 readonly attribute Document responseXML
 getter raises(DOMException);
-#if defined(ENABLE_XHR_RESPONSE_BLOB) && ENABLE_XHR_RESPONSE_BLOB
-readonly attribute [EnabledAtRuntime] Blob responseBlob
+readonly attribute [Conditional=XHR_RESPONSE_BLOB, EnabledAtRuntime] Blob responseBlob
 getter raises(DOMException);
-#endif
 
 attribute DOMString responseType
 setter raises(DOMException);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95164] trunk/LayoutTests

[keishi]

Title: [95164] trunk/LayoutTests








Revision 95164
Author kei...@webkit.org
Date 2011-09-14 21:43:16 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] Add slow to debug version of styles-source-lines.html.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95163 => 95164)

--- trunk/LayoutTests/ChangeLog	2011-09-15 04:33:16 UTC (rev 95163)
+++ trunk/LayoutTests/ChangeLog	2011-09-15 04:43:16 UTC (rev 95164)
@@ -1,3 +1,9 @@
+2011-09-14  Keishi Hattori  
+
+[chromium] Add slow to debug version of styles-source-lines.html.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-14  Tom Sepez  
 
 Fix tests made trivial by the bugfix to 27895, by removing leading punctuation


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95163 => 95164)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-15 04:33:16 UTC (rev 95163)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-15 04:43:16 UTC (rev 95164)
@@ -38,6 +38,7 @@
 BUGCR24182 SLOW DEBUG : jquery/traversing.html = PASS
 BUGCR24182 SLOW LINUX WIN DEBUG : perf/array-push-pop.html = PASS
 BUGCR24182 SLOW LINUX WIN DEBUG : perf/array-reverse.html = PASS
+BUGCR24182 BUGWK62309 SLOW WIN DEBUG : inspector/styles/styles-source-lines.html = PASS TEXT
 
 BUGWK67919 SLOW DEBUG : perf/document-contains.html = PASS
 
@@ -633,7 +634,7 @@
 BUGWK62309 WIN DEBUG : inspector/styles/styles-disable-then-change.html = PASS TIMEOUT
 BUGCR89372 DEBUG : inspector/styles/styles-iframe.html = PASS TIMEOUT
 BUGWK62309 LINUX WIN DEBUG : inspector/styles/parse-utf8-bom.html = PASS TIMEOUT
-BUGWK62309 WIN : inspector/styles/styles-source-lines.html = PASS TEXT
+BUGWK62309 RELEASE WIN : inspector/styles/styles-source-lines.html = PASS TEXT
 
 BUGPFELDMAN : inspector/debugger/debugger-activation-crash2.html = PASS TIMEOUT TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95163] trunk

[alexis . menard]

Title: [95163] trunk








Revision 95163
Author alexis.men...@openbossa.org
Date 2011-09-14 21:33:16 -0700 (Wed, 14 Sep 2011)


Log Message
[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
https://bugs.webkit.org/show_bug.cgi?id=68114

Reviewed by Kenneth Rohde Christiansen.

.:

Replace QT_GCC_X variables, they have been removed in Qt5. It was
actually wrong to use them because they tell about which GCC version
Qt has been compiled, not the current version of GCC use to build webkit.
I use gcc -dumpversion to get it.

* Source/WebKit.pri:

Source/_javascript_Core:

Use the new GCC_X variables defined in WebKit.pri to replace
the usage of QT_GCC_X.

* _javascript_Core.pro:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.pro
trunk/Source/WebKit.pri




Diff

Modified: trunk/ChangeLog (95162 => 95163)

--- trunk/ChangeLog	2011-09-15 04:27:17 UTC (rev 95162)
+++ trunk/ChangeLog	2011-09-15 04:33:16 UTC (rev 95163)
@@ -1,3 +1,17 @@
+2011-09-14  Alexis Menard  
+
+[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
+https://bugs.webkit.org/show_bug.cgi?id=68114
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Replace QT_GCC_X variables, they have been removed in Qt5. It was
+actually wrong to use them because they tell about which GCC version
+Qt has been compiled, not the current version of GCC use to build webkit.
+I use gcc -dumpversion to get it.
+
+* Source/WebKit.pri:
+
 2011-09-14  Ulan Degenbaev  
 
 [v8] Improve performance of typed array copy constructor taking Array


Modified: trunk/Source/_javascript_Core/ChangeLog (95162 => 95163)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 04:27:17 UTC (rev 95162)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 04:33:16 UTC (rev 95163)
@@ -1,3 +1,15 @@
+2011-09-14  Alexis Menard  
+
+[Qt] Replace QT_GCC_X as they don't exist in Qt5 anymore.
+https://bugs.webkit.org/show_bug.cgi?id=68114
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Use the new GCC_X variables defined in WebKit.pri to replace
+the usage of QT_GCC_X.
+
+* _javascript_Core.pro:
+
 2011-09-14  Sheriff Bot  
 
 Unreviewed, rolling out r95145.


Modified: trunk/Source/_javascript_Core/_javascript_Core.pro (95162 => 95163)

--- trunk/Source/_javascript_Core/_javascript_Core.pro	2011-09-15 04:27:17 UTC (rev 95162)
+++ trunk/Source/_javascript_Core/_javascript_Core.pro	2011-09-15 04:33:16 UTC (rev 95163)
@@ -33,7 +33,7 @@
 
 # Rules when JIT enabled (not disabled)
 !contains(DEFINES, ENABLE_JIT=0) {
-linux*-g++*:greaterThan(QT_GCC_MAJOR_VERSION,3):greaterThan(QT_GCC_MINOR_VERSION,0) {
+linux*-g++*:greaterThan(GCC_MAJOR_VERSION,3):greaterThan(GCC_MINOR_VERSION,0) {
 QMAKE_CXXFLAGS += -fno-stack-protector
 QMAKE_CFLAGS += -fno-stack-protector
 }
@@ -216,15 +216,15 @@
 QMAKE_CXXFLAGS.ARMCC += -OTime -O3
 }
 
-lessThan(QT_GCC_MAJOR_VERSION, 5) {
+lessThan(GCC_MAJOR_VERSION, 5) {
 # GCC 4.5 and before
-lessThan(QT_GCC_MINOR_VERSION, 6) {
+lessThan(GCC_MINOR_VERSION, 6) {
 # Disable C++0x mode in JSC for those who enabled it in their Qt's mkspec.
 *-g++*:QMAKE_CXXFLAGS -= -std=c++0x -std=gnu++0x
 }
 
 # GCC 4.6 and after.
-greaterThan(QT_GCC_MINOR_VERSION, 5) {
+greaterThan(GCC_MINOR_VERSION, 5) {
 if (!contains(QMAKE_CXXFLAGS, -std=c++0x) && !contains(QMAKE_CXXFLAGS, -std=gnu++0x)) {
 # We need to deactivate those warnings because some names conflicts with upcoming c++0x types (e.g.nullptr).
 QMAKE_CFLAGS_WARN_ON += -Wno-c++0x-compat


Modified: trunk/Source/WebKit.pri (95162 => 95163)

--- trunk/Source/WebKit.pri	2011-09-15 04:27:17 UTC (rev 95162)
+++ trunk/Source/WebKit.pri	2011-09-15 04:33:16 UTC (rev 95163)
@@ -95,8 +95,11 @@
 # Treat warnings as errors on x86/Linux/GCC
 linux-g++* {
 isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS += -Werror
-
-greaterThan(QT_GCC_MAJOR_VERSION, 3):greaterThan(QT_GCC_MINOR_VERSION, 5) {
+GCC_VERSION = $$system(gcc -dumpversion)
+GCC_VERSION = $$split(GCC_VERSION, ".")
+GCC_MAJOR_VERSION = $$first(GCC_VERSION)
+GCC_MINOR_VERSION = $$member(GCC_VERSION, 1)
+greaterThan(GCC_MAJOR_VERSION, 3):greaterThan(GCC_MINOR_VERSION, 5) {
 if (!contains(QMAKE_CXXFLAGS, -std=c++0x) && !contains(QMAKE_CXXFLAGS, -std=gnu++0x)) {
 # We need to deactivate those warnings because some names conflicts with upcoming c++0x types (e.g.nullptr).
 QMAKE_CFLAGS_WARN_ON += -Wno-c++0x-compat






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95162] trunk/Source/JavaScriptCore

[commit-queue]

Title: [95162] trunk/Source/_javascript_Core








Revision 95162
Author commit-qu...@webkit.org
Date 2011-09-14 21:27:17 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed, rolling out r95145.
http://trac.webkit.org/changeset/95145
https://bugs.webkit.org/show_bug.cgi?id=68139

The GTK+ build is working now, so revert this trial build fix.
(Requested by mrobinson on #webkit).

Patch by Sheriff Bot  on 2011-09-14

* GNUmakefile.list.am:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95161 => 95162)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 04:24:50 UTC (rev 95161)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 04:27:17 UTC (rev 95162)
@@ -1,3 +1,14 @@
+2011-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r95145.
+http://trac.webkit.org/changeset/95145
+https://bugs.webkit.org/show_bug.cgi?id=68139
+
+The GTK+ build is working now, so revert this trial build fix.
+(Requested by mrobinson on #webkit).
+
+* GNUmakefile.list.am:
+
 2011-09-14  Patrick Gansterer  
 
 Port MachineStackMarker to Windows ARM and MIPS


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (95161 => 95162)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-15 04:24:50 UTC (rev 95161)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-15 04:27:17 UTC (rev 95162)
@@ -611,6 +611,8 @@
 	Source/_javascript_Core/wtf/text/TextPosition.h \
 	Source/_javascript_Core/wtf/text/WTFString.cpp \
 	Source/_javascript_Core/wtf/text/WTFString.h \
+	Source/_javascript_Core/wtf/threads/BinarySemaphore.cpp \
+	Source/_javascript_Core/wtf/threads/BinarySemaphore.h \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.cpp \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.h \
 	Source/_javascript_Core/wtf/ThreadRestrictionVerifier.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95160] trunk/Source/WebKit/chromium

[commit-queue]

Title: [95160] trunk/Source/WebKit/chromium








Revision 95160
Author commit-qu...@webkit.org
Date 2011-09-14 21:15:52 -0700 (Wed, 14 Sep 2011)


Log Message
[Chromium] Make WEB_AUDIO conditional and fix the build when disabled
https://bugs.webkit.org/show_bug.cgi?id=68107

Patch by Peter Beverloo  on 2011-09-14
Reviewed by Kenneth Russell.

* features.gypi:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
* src/WebMediaPlayerClientImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95159 => 95160)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 04:08:41 UTC (rev 95159)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 04:15:52 UTC (rev 95160)
@@ -1,3 +1,15 @@
+2011-09-14  Peter Beverloo  
+
+[Chromium] Make WEB_AUDIO conditional and fix the build when disabled
+https://bugs.webkit.org/show_bug.cgi?id=68107
+
+Reviewed by Kenneth Russell.
+
+* features.gypi:
+* src/WebMediaPlayerClientImpl.cpp:
+(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
+* src/WebMediaPlayerClientImpl.h:
+
 2011-09-14  John Bauman  
 
 [chromium] Return correct value for getContextAttributes().preserveDrawingBuffer


Modified: trunk/Source/WebKit/chromium/features.gypi (95159 => 95160)

--- trunk/Source/WebKit/chromium/features.gypi	2011-09-15 04:08:41 UTC (rev 95159)
+++ trunk/Source/WebKit/chromium/features.gypi	2011-09-15 04:15:52 UTC (rev 95160)
@@ -85,7 +85,6 @@
   'ENABLE_TOUCH_ICON_LOADING=<(enable_touch_icon_loading)',
   'ENABLE_V8_SCRIPT_DEBUG_SERVER=1',
   'ENABLE_VIDEO=1',
-  'ENABLE_WEB_AUDIO=1',
   'ENABLE_WEB_SOCKETS=1',
   'ENABLE_WEB_TIMING=1',
   'ENABLE_WEBGL=1',
@@ -118,6 +117,15 @@
 'enable_touch_events%': '<(enable_touch_events)',
 'use_skia%': '<(use_skia)',
 'conditions': [
+  ['OS=="android"', {
+'feature_defines': [
+  'ENABLE_WEB_AUDIO=0',
+],
+  }, {
+'feature_defines': [
+  'ENABLE_WEB_AUDIO=1',
+],
+  }],
   ['use_accelerated_compositing==1', {
 'feature_defines': [
   'WTF_USE_ACCELERATED_COMPOSITING=1',


Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp (95159 => 95160)

--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	2011-09-15 04:08:41 UTC (rev 95159)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	2011-09-15 04:15:52 UTC (rev 95160)
@@ -556,11 +556,13 @@
 
 WebCore::AudioSourceProvider* WebMediaPlayerClientImpl::audioSourceProvider()
 {
+#if ENABLE(WEB_AUDIO)
 if (m_webMediaPlayer.get()) {
 // Wrap the WebAudioSourceProvider in the form of WebCore::AudioSourceProvider.
 m_audioSourceProvider.initialize(m_webMediaPlayer->audioSourceProvider());
 return &m_audioSourceProvider;
 }
+#endif
 return 0;
 }
 
@@ -663,6 +665,7 @@
 {
 }
 
+#if ENABLE(WEB_AUDIO)
 void WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput(WebCore::AudioBus* bus, size_t framesToProcess)
 {
 ASSERT(bus);
@@ -683,6 +686,7 @@
 
 m_webAudioSourceProvider->provideInput(webAudioData, framesToProcess);
 }
+#endif
 
 } // namespace WebKit
 


Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h (95159 => 95160)

--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h	2011-09-15 04:08:41 UTC (rev 95159)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h	2011-09-15 04:15:52 UTC (rev 95160)
@@ -165,6 +165,7 @@
 #endif
 static bool m_isEnabled;
 
+#if ENABLE(WEB_AUDIO)
 // AudioSourceProviderImpl wraps a WebAudioSourceProvider.
 
 class AudioSourceProviderImpl : public WebCore::AudioSourceProvider {
@@ -184,6 +185,7 @@
 };
 
 AudioSourceProviderImpl m_audioSourceProvider;
+#endif
 };
 
 } // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95159] trunk/Websites/bugs.webkit.org

[commit-queue]

Title: [95159] trunk/Websites/bugs.webkit.org








Revision 95159
Author commit-qu...@webkit.org
Date 2011-09-14 21:08:41 -0700 (Wed, 14 Sep 2011)


Log Message
PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
For details of these mechanisms, see the function emit_binary_diff_body
in the git source file diff.c (https://github.com/git/git/blob/master/diff.c).

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

When reconstructing the images from the patches, if we have a delta patch
we may download the previous revision from svn.webkit.org to get the image data.

Patch by Ben Wells  on 2011-09-14
Reviewed by Adam Roben.

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

Modified Paths

trunk/Websites/bugs.webkit.org/ChangeLog
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb
trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch_test.rb




Diff

Modified: trunk/Websites/bugs.webkit.org/ChangeLog (95158 => 95159)

--- trunk/Websites/bugs.webkit.org/ChangeLog	2011-09-15 04:06:49 UTC (rev 95158)
+++ trunk/Websites/bugs.webkit.org/ChangeLog	2011-09-15 04:08:41 UTC (rev 95159)
@@ -1,3 +1,23 @@
+2011-09-14  Ben Wells  
+
+PrettyPatch should handle "delta" patch mechanism in git binary patches
+https://bugs.webkit.org/show_bug.cgi?id=67628
+
+Git patches are encoded using two mechanisms - "literal" and "delta".
+For details of these mechanisms, see the function emit_binary_diff_body
+in the git source file diff.c (https://github.com/git/git/blob/master/diff.c).
+
+When determining if a binary file patch is an image or not we should accept
+both literal and delta patch encodings.
+
+When reconstructing the images from the patches, if we have a delta patch
+we may download the previous revision from svn.webkit.org to get the image data.
+
+Reviewed by Adam Roben.
+
+* PrettyPatch/PrettyPatch.rb:
+* PrettyPatch/PrettyPatch_test.rb:
+
 2011-09-06  Sheriff Bot  
 
 Unreviewed, rolling out r94554.


Modified: trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb (95158 => 95159)

--- trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2011-09-15 04:06:49 UTC (rev 95158)
+++ trunk/Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb	2011-09-15 04:08:41 UTC (rev 95159)
@@ -1,6 +1,7 @@
 require 'cgi'
 require 'diff'
 require 'open3'
+require 'open-uri'
 require 'pp'
 require 'set'
 require 'tempfile'
@@ -13,22 +14,24 @@
 
 def self.prettify(string)
 $last_prettify_file_count = -1
-$last_prettify_part_count = { "remove" => 0, "add" => 0, "shared" => 0 }
+$last_prettify_part_count = { "remove" => 0, "add" => 0, "shared" => 0, "binary" => 0, "extract-error" => 0 }
 string = normalize_line_ending(string)
-fileDiffs = FileDiff.parse(string)
-
 str = HEADER + "\n"
 
 # Just look at the first line to see if it is an SVN revision number as added
 # by webkit-patch for git checkouts.
+$svn_revision = 0
 string.each_line do |line|
 match = /^Subversion\ Revision: (\d*)$/.match(line)
 unless match.nil?
-  str += "" + match[1] + "\n"
+str += "" + match[1] + "\n"
+$svn_revision = match[1].to_i;
 end
 break
 end
 
+fileDiffs = FileDiff.parse(string)
+
 $last_prettify_file_count = fileDiffs.length
 str += fileDiffs.collect{ |diff| diff.to_html }.join
 end
@@ -65,8 +68,12 @@
 
 GIT_BINARY_FILE_MARKER_FORMAT = /^GIT binary patch$/
 
+GIT_BINARY_PATCH_FORMAT = /^(literal|delta) \d+$/
+
 GIT_LITERAL_FORMAT = /^literal \d+$/
 
+GIT_DELTA_FORMAT = /^delta \d+$/
+
 START_OF_BINARY_DATA_FORMAT = /^[0-9a-zA-Z\+\/=]{20,}/ # Assume 20 chars without a space is base64 binary data.
 
 START_OF_SECTION_FORMAT = /^@@ -(\d+)(?:,(\d+))? \+(\d+)(?:,(\d+))? @@\s*(.*)/
@@ -508,7 +515,7 @@
 @git_indexes = [$1, $2]
 when GIT_BINARY_FILE_MARKER_FORMAT
 @binary = true
-if (GIT_LITERAL_FORMAT.match(lines[i + 1]) and PrettyPatch.has_image_suffix(@filename)) then
+if (GIT_BINARY_PATCH_FORMAT.match(lines[i + 1]) and PrettyPatch.has_image_suffix(@filename)) then
 @git_image = true
 startOfSections = i + 1
 end
@@ -534,14 +541,20 @@
 
 raise "no binary chunks" unless chunks
 
-binary_contents = chunks.zip(@git_indexes).collect do |chunk, git_index|
-FileDiff.extract_contents_from_git_binary_chunk(chunk, git_index)
-end
+from_filepath

[webkit-changes] [95157] trunk

[commit-queue]

Title: [95157] trunk








Revision 95157
Author commit-qu...@webkit.org
Date 2011-09-14 20:28:43 -0700 (Wed, 14 Sep 2011)


Log Message
[v8] Improve performance of typed array copy constructor taking Array
https://bugs.webkit.org/show_bug.cgi?id=68015

Patch by Ulan Degenbaev  on 2011-09-14
Reviewed by Kenneth Russell.

Invoke the 'set' method of the constructed array instead of
copying the elements of the source array one by one.

Copy constructor tests already exist.

* ../../Source/WebCore/WebCore.gypi:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h


Added Paths

trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp




Diff

Modified: trunk/ChangeLog (95156 => 95157)

--- trunk/ChangeLog	2011-09-15 03:04:37 UTC (rev 95156)
+++ trunk/ChangeLog	2011-09-15 03:28:43 UTC (rev 95157)
@@ -1,3 +1,19 @@
+2011-09-14  Ulan Degenbaev  
+
+[v8] Improve performance of typed array copy constructor taking Array
+https://bugs.webkit.org/show_bug.cgi?id=68015
+
+Reviewed by Kenneth Russell.
+
+Invoke the 'set' method of the constructed array instead of
+copying the elements of the source array one by one.
+
+Copy constructor tests already exist.
+
+* ../../Source/WebCore/WebCore.gypi:
+* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp: Added.
+* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
+
 2011-09-14  Csaba Osztrogonác  
 
 [GTK] Unreviewed buildfix after r95107.


Modified: trunk/Source/WebCore/WebCore.gypi (95156 => 95157)

--- trunk/Source/WebCore/WebCore.gypi	2011-09-15 03:04:37 UTC (rev 95156)
+++ trunk/Source/WebCore/WebCore.gypi	2011-09-15 03:28:43 UTC (rev 95157)
@@ -2116,6 +2116,7 @@
 'bindings/v8/WorldContextHandle.h',
 'bindings/v8/WrapperTypeInfo.h',
 'bindings/v8/custom/V8ArrayBufferCustom.cpp',
+'bindings/v8/custom/V8ArrayBufferViewCustom.cpp',
 'bindings/v8/custom/V8ArrayBufferViewCustom.h',
 'bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp',
 'bindings/v8/custom/V8AudioContextCustom.cpp',


Added: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (0 => 95157)

--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	(rev 0)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	2011-09-15 03:28:43 UTC (rev 95157)
@@ -0,0 +1,41 @@
+
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1.  Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2.  Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "V8ArrayBufferViewCustom.h"
+
+#include 
+
+namespace WebCore {
+
+void copyElements(v8::Handle destArray, v8::Handle srcArray)
+{
+v8::Handle key = v8::String::New("set");
+v8::Handle set = destArray->Get(key).As();
+v8::Handle argument = srcArray;
+set->Call(destArray, 1, &argument);
+}
+
+}


Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (95156 => 95157)

--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h	2011-09-15 03:04:37 UTC (rev 95156)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h	2011-09-15 03:28:43 UTC (rev 95157)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2009 Google Inc. All rights reserved.
+ * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided t

[webkit-changes] [95156] trunk/Source/WebKit/chromium

[commit-queue]

Title: [95156] trunk/Source/WebKit/chromium








Revision 95156
Author commit-qu...@webkit.org
Date 2011-09-14 20:04:37 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] Return correct value for getContextAttributes().preserveDrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=68082

Patch by John Bauman  on 2011-09-14
Reviewed by Kenneth Russell.

WebKit::WebGraphicsContext3D::Attributes doesn't save
preserveDrawingBuffer, so that has to be saving in
GraphicsContext3DPrivate.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::create):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GraphicsContext3DPrivate::getContextAttributes):
* src/GraphicsContext3DPrivate.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95155 => 95156)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 03:01:22 UTC (rev 95155)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-15 03:04:37 UTC (rev 95156)
@@ -1,3 +1,21 @@
+2011-09-14  John Bauman  
+
+[chromium] Return correct value for getContextAttributes().preserveDrawingBuffer
+https://bugs.webkit.org/show_bug.cgi?id=68082
+
+Reviewed by Kenneth Russell.
+
+WebKit::WebGraphicsContext3D::Attributes doesn't save
+preserveDrawingBuffer, so that has to be saving in
+GraphicsContext3DPrivate.
+
+* src/GraphicsContext3DChromium.cpp:
+(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
+(WebCore::GraphicsContext3DPrivate::create):
+(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
+(WebCore::GraphicsContext3DPrivate::getContextAttributes):
+* src/GraphicsContext3DPrivate.h:
+
 2011-09-14  Antoine Labour  
 
 Remove the dependency on GraphicsLayer from CCLayerTreeHost.


Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp (95155 => 95156)

--- trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-09-15 03:01:22 UTC (rev 95155)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp	2011-09-15 03:04:37 UTC (rev 95156)
@@ -84,11 +84,12 @@
 //--
 // GraphicsContext3DPrivate
 
-GraphicsContext3DPrivate::GraphicsContext3DPrivate(WebKit::WebViewImpl* webViewImpl, PassOwnPtr webContext)
+GraphicsContext3DPrivate::GraphicsContext3DPrivate(WebKit::WebViewImpl* webViewImpl, PassOwnPtr webContext, GraphicsContext3D::Attributes attrs)
 : m_impl(webContext)
 , m_webViewImpl(webViewImpl)
 , m_initializedAvailableExtensions(false)
 , m_layerComposited(false)
+, m_preserveDrawingBuffer(attrs.preserveDrawingBuffer)
 , m_resourceSafety(ResourceSafetyUnknown)
 #if USE(SKIA)
 , m_grContext(0)
@@ -114,9 +115,9 @@
 }
 
 
-PassOwnPtr GraphicsContext3DPrivate::create(WebKit::WebViewImpl* webViewImpl, PassOwnPtr webContext)
+PassOwnPtr GraphicsContext3DPrivate::create(WebKit::WebViewImpl* webViewImpl, PassOwnPtr webContext, GraphicsContext3D::Attributes attrs)
 {
-return adoptPtr(new GraphicsContext3DPrivate(webViewImpl, webContext));
+return adoptPtr(new GraphicsContext3DPrivate(webViewImpl, webContext, attrs));
 }
 
 PassRefPtr GraphicsContext3DPrivate::createGraphicsContextFromWebContext(PassOwnPtr webContext, GraphicsContext3D::Attributes attrs, HostWindow* hostWindow, GraphicsContext3D::RenderStyle renderStyle, ThreadUsage threadUsage)
@@ -127,7 +128,7 @@
 if (threadUsage == ForUseOnThisThread && !webContext->makeContextCurrent())
 return 0;
 
-OwnPtr priv = GraphicsContext3DPrivate::create(webViewImpl, webContext);
+OwnPtr priv = GraphicsContext3DPrivate::create(webViewImpl, webContext, attrs);
 if (!priv)
 return 0;
 
@@ -600,6 +601,7 @@
 attributes.stencil = webAttributes.stencil;
 attributes.antialias = webAttributes.antialias;
 attributes.premultipliedAlpha = webAttributes.premultipliedAlpha;
+attributes.preserveDrawingBuffer = m_preserveDrawingBuffer;
 return attributes;
 }
 


Modified: trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h (95155 => 95156)

--- trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h	2011-09-15 03:01:22 UTC (rev 95155)
+++ trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h	2011-09-15 03:04:37 UTC (rev 95156)
@@ -55,7 +55,7 @@
 
 class GraphicsContext3DPrivate {
 public:
-static PassOwnPtr create(WebKit::WebViewImpl*, PassOwnPtr);
+static PassOwnPtr create(WebKit::WebViewImpl*, PassOwnPtr, GraphicsContext3D::Attributes);
 
 enum ThreadUsage {
 ForUseOnThisThread,
@@ -74,8 +74,6 @@
 
 ~GraphicsContext3DPrivate();
 
-bool initialize(GraphicsContext3D::Attributes, HostWindow

[webkit-changes] [95154] trunk/Source/WebKit2

[commit-queue]

Title: [95154] trunk/Source/WebKit2








Revision 95154
Author commit-qu...@webkit.org
Date 2011-09-14 19:53:13 -0700 (Wed, 14 Sep 2011)


Log Message
Eliminate WebKit2 compilation warnings.
https://bugs.webkit.org/show_bug.cgi?id=65025

Warnings found with gcc on linux.

Patch by Wajahat Siddiqui  on 2011-09-14
Reviewed by Sam Weinig.

* Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (95153 => 95154)

--- trunk/Source/WebKit2/ChangeLog	2011-09-15 02:40:46 UTC (rev 95153)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-15 02:53:13 UTC (rev 95154)
@@ -1,3 +1,17 @@
+2011-09-14  Wajahat Siddiqui  
+
+Eliminate WebKit2 compilation warnings.
+https://bugs.webkit.org/show_bug.cgi?id=65025
+
+Warnings found with gcc on linux.
+
+Reviewed by Sam Weinig.
+
+* Platform/CoreIPC/ArgumentEncoder.cpp:
+(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
+* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+(WebKit::WebFrameLoaderClient::createPlugin):
+
 2011-09-14  Ada Chan  
 
 Implement WKBundleFrameCopyWebArchive().


Modified: trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp (95153 => 95154)

--- trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp	2011-09-15 02:40:46 UTC (rev 95153)
+++ trunk/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp	2011-09-15 02:53:13 UTC (rev 95154)
@@ -54,7 +54,7 @@
 #if !USE(UNIX_DOMAIN_SOCKETS)
 // FIXME: We need to dispose of the attachments in cases of failure.
 #else
-for (int i = 0; i < m_attachments.size(); ++i)
+for (size_t i = 0; i < m_attachments.size(); ++i)
 m_attachments[i].dispose();
 #endif
 }


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (95153 => 95154)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2011-09-15 02:40:46 UTC (rev 95153)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2011-09-15 02:53:13 UTC (rev 95154)
@@ -1266,7 +1266,7 @@
 // Currently we don't support transparency and windowed mode.
 // Inject wmode=opaque to make Flash work in these conditions.
 size_t wmodeIndex = parameters.names.find("wmode");
-if (wmodeIndex == -1) {
+if (wmodeIndex == notFound) {
 parameters.names.append("wmode");
 parameters.values.append("opaque");
 } else if (equalIgnoringCase(parameters.values[wmodeIndex], "window"))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95153] trunk/Source/JavaScriptCore

[paroga]

Title: [95153] trunk/Source/_javascript_Core








Revision 95153
Author par...@webkit.org
Date 2011-09-14 19:40:46 -0700 (Wed, 14 Sep 2011)


Log Message
Port MachineStackMarker to Windows ARM and MIPS
https://bugs.webkit.org/show_bug.cgi?id=68068

Reviewed by Geoffrey Garen.

Use the correct memeber of the CONTEXT struct for the stackpointer for CPU(ARM) and CPU(MIPS).
Only query CONTEXT_INTEGER and CONTEXT_CONTROL, since CONTEXT_SEGMENTS isn't defined for
CPU(ARM) and CPU(MIPS) and the stackpointer is defined in the CONTEXT_CONTROL section for
CPU(ARM), CPU(X86) and CPU(X86_64) and in the CONTEXT_INTEGER section for CPU(MIPS).

* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95152 => 95153)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 02:34:02 UTC (rev 95152)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 02:40:46 UTC (rev 95153)
@@ -1,3 +1,19 @@
+2011-09-14  Patrick Gansterer  
+
+Port MachineStackMarker to Windows ARM and MIPS
+https://bugs.webkit.org/show_bug.cgi?id=68068
+
+Reviewed by Geoffrey Garen.
+
+Use the correct memeber of the CONTEXT struct for the stackpointer for CPU(ARM) and CPU(MIPS).
+Only query CONTEXT_INTEGER and CONTEXT_CONTROL, since CONTEXT_SEGMENTS isn't defined for
+CPU(ARM) and CPU(MIPS) and the stackpointer is defined in the CONTEXT_CONTROL section for
+CPU(ARM), CPU(X86) and CPU(X86_64) and in the CONTEXT_INTEGER section for CPU(MIPS).
+
+* heap/MachineStackMarker.cpp:
+(JSC::getPlatformThreadRegisters):
+(JSC::otherThreadStackPointer):
+
 2011-09-12  Filip Pizlo  
 
 DFG JIT always speculates that ValueAdd is a numeric addition


Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (95152 => 95153)

--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2011-09-15 02:34:02 UTC (rev 95152)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp	2011-09-15 02:40:46 UTC (rev 95153)
@@ -364,7 +364,7 @@
 // end OS(DARWIN)
 
 #elif OS(WINDOWS)
-regs.ContextFlags = CONTEXT_INTEGER | CONTEXT_CONTROL | CONTEXT_SEGMENTS;
+regs.ContextFlags = CONTEXT_INTEGER | CONTEXT_CONTROL;
 GetThreadContext(platformThread, ®s);
 return sizeof(CONTEXT);
 #elif USE(PTHREADS)
@@ -415,10 +415,20 @@
 #endif // __DARWIN_UNIX03
 
 // end OS(DARWIN)
-#elif CPU(X86) && OS(WINDOWS)
+#elif OS(WINDOWS)
+
+#if CPU(ARM)
+return reinterpret_cast((uintptr_t) regs.Sp);
+#elif CPU(MIPS)
+return reinterpret_cast((uintptr_t) regs.IntSp);
+#elif CPU(X86)
 return reinterpret_cast((uintptr_t) regs.Esp);
-#elif CPU(X86_64) && OS(WINDOWS)
+#elif CPU(X86_64)
 return reinterpret_cast((uintptr_t) regs.Rsp);
+#else
+#error Unknown Architecture
+#endif
+
 #elif USE(PTHREADS)
 void* stackBase = 0;
 size_t stackSize = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95152] trunk/Source

[jamesr]

Title: [95152] trunk/Source








Revision 95152
Author jam...@google.com
Date 2011-09-14 19:34:02 -0700 (Wed, 14 Sep 2011)


Log Message
Remove the dependency on GraphicsLayer from CCLayerTreeHost.
Move root layer management into the NonCompositedContentHost.
Have WebViewImpl create a NonCompositedContentHost explicitly.
https://bugs.webkit.org/show_bug.cgi?id=67883

Patch by Antoine Labour  on 2011-09-14
Reviewed by James Robinson.

Source/WebCore:

Covered by compositing/ layout tests.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setRootLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::setVisible):
(WebCore::NonCompositedContentHost::clearRenderSurfacesRecursive):
(WebCore::NonCompositedContentHost::invalidateRect):
* platform/graphics/chromium/NonCompositedContentHost.h:
(WebCore::NonCompositedContentHost::topLevelRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setViewport):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::rootLayer):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::invalidateRootLayerRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
(WebKit::WebViewImpl::setVisibilityState):
* src/WebViewImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (95151 => 95152)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 02:26:42 UTC (rev 95151)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 02:34:02 UTC (rev 95152)
@@ -1,3 +1,35 @@
+2011-09-14  Antoine Labour  
+
+Remove the dependency on GraphicsLayer from CCLayerTreeHost.
+Move root layer management into the NonCompositedContentHost.
+Have WebViewImpl create a NonCompositedContentHost explicitly.
+https://bugs.webkit.org/show_bug.cgi?id=67883
+
+Reviewed by James Robinson.
+
+Covered by compositing/ layout tests.
+
+* platform/graphics/chromium/NonCompositedContentHost.cpp:
+(WebCore::NonCompositedContentHost::setRootLayer):
+(WebCore::NonCompositedContentHost::setViewport):
+(WebCore::NonCompositedContentHost::setVisible):
+(WebCore::NonCompositedContentHost::clearRenderSurfacesRecursive):
+(WebCore::NonCompositedContentHost::invalidateRect):
+* platform/graphics/chromium/NonCompositedContentHost.h:
+(WebCore::NonCompositedContentHost::topLevelRootLayer):
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::create):
+(WebCore::CCLayerTreeHost::CCLayerTreeHost):
+(WebCore::CCLayerTreeHost::initialize):
+(WebCore::CCLayerTreeHost::commitTo):
+(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
+(WebCore::CCLayerTreeHost::setViewport):
+(WebCore::CCLayerTreeHost::setVisible):
+(WebCore::CCLayerTreeHost::updateLayers):
+(WebCore::CCLayerTreeHost::paintLayerContents):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCLayerTreeHost::rootLayer):
+
 2011-09-14  Henrik Grunell  
 
 MediaStream API: Change PeerConnection constructor name to webkitPeerConnection


Modified: trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp (95151 => 95152)

--- trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp	2011-09-15 02:26:42 UTC (rev 95151)
+++ trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp	2011-09-15 02:34:02 UTC (rev 95152)
@@ -49,19 +49,26 @@
 {
 }
 
-void NonCompositedContentHost::invalidateRect(const IntRect& rect)
+void NonCompositedContentHost::setRootLayer(GraphicsLayer* layer)
 {
-m_graphicsLayer->setNeedsDisplayInRect(FloatRect(rect));
+m_graphicsLayer->removeAllChildren();
+m_graphicsLayer->setNeedsDisplay();
+if (layer)
+m_graphicsLayer->addChild(layer);
+else
+m_graphicsLayer->platformLayer()->setLayerTreeHost(0);
 }
 
-void NonCompositedContentHost::invalidateEntireLayer()
+void

[webkit-changes] [95151] trunk

[commit-queue]

Title: [95151] trunk








Revision 95151
Author commit-qu...@webkit.org
Date 2011-09-14 19:26:42 -0700 (Wed, 14 Sep 2011)


Log Message
MediaStream API: Change PeerConnection constructor name to webkitPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=67843

Patch by Henrik Grunell  on 2011-09-14
Reviewed by Tony Gentilcore.

Tests for the MediaStream API will be provided by the bug 56587, pending enough landed code.

Source/WebCore:

* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPeerConnectionEnabled):
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/call-a-constructor-as-a-function.html:
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function.html
trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
trunk/Source/WebCore/page/DOMWindow.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (95150 => 95151)

--- trunk/LayoutTests/ChangeLog	2011-09-15 02:12:36 UTC (rev 95150)
+++ trunk/LayoutTests/ChangeLog	2011-09-15 02:26:42 UTC (rev 95151)
@@ -1,3 +1,15 @@
+2011-09-14  Henrik Grunell  
+
+MediaStream API: Change PeerConnection constructor name to webkitPeerConnection
+https://bugs.webkit.org/show_bug.cgi?id=67843
+
+Reviewed by Tony Gentilcore.
+
+Tests for the MediaStream API will be provided by the bug 56587, pending enough landed code.
+
+* fast/dom/call-a-constructor-as-a-function.html:
+* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
+
 2011-09-14  David Levin  
 
 [chromium] rebaselines due to r95096, r95121, and r95129.


Modified: trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function.html (95150 => 95151)

--- trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function.html	2011-09-15 02:12:36 UTC (rev 95150)
+++ trunk/LayoutTests/fast/dom/call-a-constructor-as-a-function.html	2011-09-15 02:26:42 UTC (rev 95151)
@@ -10,7 +10,7 @@
 
 
 

[webkit-changes] [95150] trunk/Source/WebCore

[commit-queue]

Title: [95150] trunk/Source/WebCore








Revision 95150
Author commit-qu...@webkit.org
Date 2011-09-14 19:12:36 -0700 (Wed, 14 Sep 2011)


Log Message
Make sure to GC decoded images that are only used with WebGL
https://bugs.webkit.org/show_bug.cgi?id=67899

Patch by John Bauman  on 2011-09-14
Reviewed by James Robinson.

Tell CachedImage that the WebGL image was drawn so WebGL-only
content will have decoded images collected.

* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95149 => 95150)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 01:46:16 UTC (rev 95149)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 02:12:36 UTC (rev 95150)
@@ -1,3 +1,16 @@
+2011-09-14  John Bauman  
+
+Make sure to GC decoded images that are only used with WebGL
+https://bugs.webkit.org/show_bug.cgi?id=67899
+
+Reviewed by James Robinson.
+
+Tell CachedImage that the WebGL image was drawn so WebGL-only
+content will have decoded images collected.
+
+* platform/graphics/GraphicsContext3D.cpp:
+(WebCore::GraphicsContext3D::extractImageData):
+
 2011-09-14  Antoine Labour  
 
 Added a pure virtual class CCLayerDelegate which helps to isolate


Modified: trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp (95149 => 95150)

--- trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp	2011-09-15 01:46:16 UTC (rev 95149)
+++ trunk/Source/WebCore/platform/graphics/GraphicsContext3D.cpp	2011-09-15 02:12:36 UTC (rev 95150)
@@ -36,6 +36,7 @@
 #include "Extensions3D.h"
 #include "Image.h"
 #include "ImageData.h"
+#include "ImageObserver.h"
 
 #include 
 #include 
@@ -189,6 +190,8 @@
componentsPerPixel * bytesPerComponent,
unpackAlignment);
 }
+if (ImageObserver *observer = image->imageObserver())
+observer->didDraw(image);
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95148] trunk/Source/WebCore

[jamesr]

Title: [95148] trunk/Source/WebCore








Revision 95148
Author jam...@google.com
Date 2011-09-14 18:32:18 -0700 (Wed, 14 Sep 2011)


Log Message
Added a pure virtual class CCLayerDelegate which helps to isolate
the chromium compositor from the rest of WebCore, and aids unit
testing by being easily mockable.  The compositor layers no longer
directly see instances of GraphicsLayerChromium, instead they use
this interface.
https://bugs.webkit.org/show_bug.cgi?id=67750

Patch by Antoine Labour  on 2011-09-14
Reviewed by James Robinson.

No new tests: changes already covered by existing compositing layout
tests.

* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::CanvasLayerChromium):
* platform/graphics/chromium/CanvasLayerChromium.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/ContentLayerChromium.h:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::getDrawsContent):
(WebCore::GraphicsLayerChromium::getPreserves3D):
(WebCore::GraphicsLayerChromium::paintingGoesToWindow):
(WebCore::GraphicsLayerChromium::doPaintGraphicsLayerContents):
(WebCore::GraphicsLayerChromium::notifySyncRequired):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::create):
(WebCore::ImageLayerChromium::ImageLayerChromium):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::create):
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::CCLayerDelegate::~CCLayerDelegate):
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::setOwner):
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::create):
(WebCore::PluginLayerChromium::PluginLayerChromium):
* platform/graphics/chromium/PluginLayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::create):
(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/VideoLayerChromium.h:
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::create):
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TiledLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/VideoLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (95147 => 95148)

--- trunk/Source/WebCore/ChangeLog	2011-09-15 01:24:39 UTC (rev 95147)
+++ trunk/Source/WebCore/ChangeLog	2011-09-15 01:32:18 UTC (rev 95148)
@@ -1,3 +1,63 @@
+2011-09-14  Antoine Labour  
+
+Added a pure virtual class CCLayerDelegate which helps to isolate
+the chromium compositor from the rest of WebCore, and aids unit
+testing by being easily mockable.  The compositor layers no longer
+directly see instances of GraphicsLayerChromium, instead they use
+this interface.
+https://bugs.webkit.org/show_bug.cgi?id=67750
+
+Reviewed by James Robinson.
+
+No new tests: changes already covered by existing compositing layout
+tests.
+
+* platform/graphics/chromium/CanvasLayerChromium.cpp:
+(WebCore:

[webkit-changes] [95147] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95147] trunk/Source/_javascript_Core








Revision 95147
Author fpi...@apple.com
Date 2011-09-14 18:24:39 -0700 (Wed, 14 Sep 2011)


Log Message
DFG JIT always speculates that ValueAdd is a numeric addition
https://bugs.webkit.org/show_bug.cgi?id=67956

Reviewed by Geoffrey Garen.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::basicArithOp):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95146 => 95147)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 01:22:47 UTC (rev 95146)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 01:24:39 UTC (rev 95147)
@@ -1,3 +1,23 @@
+2011-09-12  Filip Pizlo  
+
+DFG JIT always speculates that ValueAdd is a numeric addition
+https://bugs.webkit.org/show_bug.cgi?id=67956
+
+Reviewed by Geoffrey Garen.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::isKnownNotNumber):
+* dfg/DFGJITCodeGenerator.h:
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
+(JSC::DFG::NonSpeculativeJIT::basicArithOp):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::shouldSpeculateNumber):
+
 2011-09-14  Anders Carlsson  
 
 Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (95146 => 95147)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-15 01:22:47 UTC (rev 95146)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-15 01:24:39 UTC (rev 95147)
@@ -395,6 +395,16 @@
 || (node.isConstant() && !valueOfJSConstant(nodeIndex).isInt32());
 }
 
+bool JITCodeGenerator::isKnownNotNumber(NodeIndex nodeIndex)
+{
+Node& node = m_jit.graph()[nodeIndex];
+VirtualRegister virtualRegister = node.virtualRegister();
+GenerationInfo& info = m_generationInfo[virtualRegister];
+
+return (!info.isJSDouble() && !info.isJSInteger())
+|| (node.isConstant() && !isNumberConstant(nodeIndex));
+}
+
 bool JITCodeGenerator::isKnownBoolean(NodeIndex nodeIndex)
 {
 Node& node = m_jit.graph()[nodeIndex];


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (95146 => 95147)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-15 01:22:47 UTC (rev 95146)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-15 01:24:39 UTC (rev 95147)
@@ -413,6 +413,7 @@
 bool isKnownCell(NodeIndex);
 
 bool isKnownNotInteger(NodeIndex);
+bool isKnownNotNumber(NodeIndex);
 
 bool isKnownBoolean(NodeIndex);
 


Modified: trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp (95146 => 95147)

--- trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-15 01:22:47 UTC (rev 95146)
+++ trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-15 01:24:39 UTC (rev 95147)
@@ -240,7 +240,7 @@
 m_jit.move(MacroAssembler::ImmPtr(static_cast(JSValue::encode(jsNumber(imm, GPRInfo::argumentGPR2);
 }
 m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operationValueAdd);
+appendCallWithExceptionCheck(operationValueAddNotNumber);
 m_jit.move(GPRInfo::returnValueGPR, resultGPR);
 silentFillAllRegisters(resultGPR);
 
@@ -418,7 +418,7 @@
 silentSpillAllRegisters(resultGPR);
 setupStubArguments(arg1GPR, arg2GPR);
 m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operationValueAdd);
+appendCallWithExceptionCheck(operationValueAddNotNumber);
 m_jit.move(GPRInfo::returnValueGPR, resultGPR);
 silentFillAllRegisters(resultGPR);
 


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (95146 => 95147)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-09-15 01:22:47 UTC (rev 95146)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2011-09-15

[webkit-changes] [95146] trunk/LayoutTests

[levin]

Title: [95146] trunk/LayoutTests








Revision 95146
Author le...@chromium.org
Date 2011-09-14 18:22:47 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] rebaselines due to r95121, r95070, and r95099.

* platform/chromium-cg-mac-leopard/fast/borders/border-image-border-radius-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png:
* platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png:
* platform/chromium-cg-mac/fast/borders/bidi-002-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/bidi-009a-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/bidi-012-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/block-mask-overlay-image-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-color-inherit-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-image-border-radius-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-image-massive-scale-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-image-rotate-transform-expected.png:
* platform/chromium-cg-mac/fast/borders/border-image-scale-transform-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png:
* platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png:
* platform/chromium-cg-mac/fast/borders/inline-mask-overlay-image-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/outline-alpha-inline-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/rtl-border-01-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/rtl-border-02-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/rtl-border-03-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/rtl-border-04-expected.png: Added.
* platform/chromium-cg-mac/fast/borders/rtl-border-05-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/border-image-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-lr-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/border-image-vertical-rl-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
* platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Removed.
* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Removed.
* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Removed.
* platform/chromium-win/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-scrambled-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-rotate-transform-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-scaled-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-side-reduction-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/borders/border-image-rotate-transform-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/bidi-002-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/bidi-009a-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/bidi-012-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/block-mask-overlay-image-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-color-inherit-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-border-radius-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-massive-scale-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/border-image-scale-transform-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/inline-mask-overlay-image-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-block-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/borders/outline-alpha-inline-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/

[webkit-changes] [95145] trunk/Source/JavaScriptCore

[andersca]

Title: [95145] trunk/Source/_javascript_Core








Revision 95145
Author ander...@apple.com
Date 2011-09-14 17:50:48 -0700 (Wed, 14 Sep 2011)


Log Message
Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.

* GNUmakefile.list.am:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95144 => 95145)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:48:22 UTC (rev 95144)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:50:48 UTC (rev 95145)
@@ -1,5 +1,11 @@
 2011-09-14  Anders Carlsson  
 
+Stop building BinarySemaphore to see if that's what's breaking the GTK+ build.
+
+* GNUmakefile.list.am:
+
+2011-09-14  Anders Carlsson  
+
 This is getting old. Yet another build fix attempt.
 
 * _javascript_Core.vcproj/WTF/WTFCommon.vsprops:


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (95144 => 95145)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-15 00:48:22 UTC (rev 95144)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-15 00:50:48 UTC (rev 95145)
@@ -611,8 +611,6 @@
 	Source/_javascript_Core/wtf/text/TextPosition.h \
 	Source/_javascript_Core/wtf/text/WTFString.cpp \
 	Source/_javascript_Core/wtf/text/WTFString.h \
-	Source/_javascript_Core/wtf/threads/BinarySemaphore.cpp \
-	Source/_javascript_Core/wtf/threads/BinarySemaphore.h \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.cpp \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.h \
 	Source/_javascript_Core/wtf/ThreadRestrictionVerifier.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95144] trunk/Source/JavaScriptCore

[andersca]

Title: [95144] trunk/Source/_javascript_Core








Revision 95144
Author ander...@apple.com
Date 2011-09-14 17:48:22 -0700 (Wed, 14 Sep 2011)


Log Message
This is getting old. Yet another build fix attempt.

* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95143 => 95144)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:39:21 UTC (rev 95143)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:48:22 UTC (rev 95144)
@@ -1,5 +1,11 @@
 2011-09-14  Anders Carlsson  
 
+This is getting old. Yet another build fix attempt.
+
+* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:
+
+2011-09-14  Anders Carlsson  
+
 Yet another build fix attempt.
 
 * _javascript_Core.vcproj/_javascript_Core/copy-files.cmd:


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops (95143 => 95144)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:39:21 UTC (rev 95143)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:48:22 UTC (rev 95144)
@@ -7,7 +7,7 @@
 	>
 	 		Name="VCCLCompilerTool"
-		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;"../../wtf/threads;"../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
+		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;../../wtf/threads;../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
 		PreprocessorDefinitions="__STD_C"
 		ForcedIncludeFiles="ICUVersion.h"
 		ProgramDataBaseFileName="$(OutDir)\$(TargetName).vc80.pdb"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95143] trunk/Source/JavaScriptCore

[andersca]

Title: [95143] trunk/Source/_javascript_Core








Revision 95143
Author ander...@apple.com
Date 2011-09-14 17:39:21 -0700 (Wed, 14 Sep 2011)


Log Message
Yet another build fix attempt.

* _javascript_Core.vcproj/_javascript_Core/copy-files.cmd:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95142 => 95143)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:31:46 UTC (rev 95142)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:39:21 UTC (rev 95143)
@@ -1,5 +1,11 @@
 2011-09-14  Anders Carlsson  
 
+Yet another build fix attempt.
+
+* _javascript_Core.vcproj/_javascript_Core/copy-files.cmd:
+
+2011-09-14  Anders Carlsson  
+
 How I "love" Visual Studio...
 
 Try to fix build again.


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd (95142 => 95143)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd	2011-09-15 00:31:46 UTC (rev 95142)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd	2011-09-15 00:39:21 UTC (rev 95143)
@@ -49,6 +49,7 @@
 wtf
 wtf\dtoa
 wtf\text
+wtf\threads
 wtf\unicode
 wtf\unicode\icu
 yarr






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95142] trunk/Source/JavaScriptCore

[andersca]

Title: [95142] trunk/Source/_javascript_Core








Revision 95142
Author ander...@apple.com
Date 2011-09-14 17:31:46 -0700 (Wed, 14 Sep 2011)


Log Message
How I "love" Visual Studio...

Try to fix build again.

* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95141 => 95142)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:26:18 UTC (rev 95141)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:31:46 UTC (rev 95142)
@@ -1,5 +1,13 @@
 2011-09-14  Anders Carlsson  
 
+How I "love" Visual Studio...
+
+Try to fix build again.
+
+* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:
+
+2011-09-14  Anders Carlsson  
+
 Try to fix Windows build.
 
 * _javascript_Core.vcproj/WTF/WTFCommon.vsprops:


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops (95141 => 95142)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:26:18 UTC (rev 95141)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:31:46 UTC (rev 95142)
@@ -7,7 +7,7 @@
 	>
 	 		Name="VCCLCompilerTool"
-		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;../../wtf/threads;"../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
+		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;"../../wtf/threads;"../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
 		PreprocessorDefinitions="__STD_C"
 		ForcedIncludeFiles="ICUVersion.h"
 		ProgramDataBaseFileName="$(OutDir)\$(TargetName).vc80.pdb"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95141] trunk/Source/JavaScriptCore

[andersca]

Title: [95141] trunk/Source/_javascript_Core








Revision 95141
Author ander...@apple.com
Date 2011-09-14 17:26:18 -0700 (Wed, 14 Sep 2011)


Log Message
Try to fix Windows build.

* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95140 => 95141)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:15:11 UTC (rev 95140)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:26:18 UTC (rev 95141)
@@ -1,5 +1,11 @@
 2011-09-14  Anders Carlsson  
 
+Try to fix Windows build.
+
+* _javascript_Core.vcproj/WTF/WTFCommon.vsprops:
+
+2011-09-14  Anders Carlsson  
+
 Add BinarySemaphore class from WebKit2 to WTF
 https://bugs.webkit.org/show_bug.cgi?id=68132
 


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops (95140 => 95141)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:15:11 UTC (rev 95140)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTFCommon.vsprops	2011-09-15 00:26:18 UTC (rev 95141)
@@ -7,7 +7,7 @@
 	>
 	 		Name="VCCLCompilerTool"
-		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
+		AdditionalIncludeDirectories=""$(ConfigurationBuildDir)\obj\_javascript_Core\DerivedSources\";../../;"../../os-win32/";../../parser/;../../wtf/;../../wtf/threads;"../../wtf/unicode/;"$(ConfigurationBuildDir)\include\private";"$(WebKitLibrariesDir)\include";../../../icu/include;../../bindings;../../bindings/c;../../bindings/jni;"$(ConfigurationBuildDir)\include\_javascript_Core";"$(WebKitLibrariesDir)\include\pthreads""
 		PreprocessorDefinitions="__STD_C"
 		ForcedIncludeFiles="ICUVersion.h"
 		ProgramDataBaseFileName="$(OutDir)\$(TargetName).vc80.pdb"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95140] trunk/Source/JavaScriptCore

[andersca]

Title: [95140] trunk/Source/_javascript_Core








Revision 95140
Author ander...@apple.com
Date 2011-09-14 17:15:11 -0700 (Wed, 14 Sep 2011)


Log Message
Add BinarySemaphore class from WebKit2 to WTF
https://bugs.webkit.org/show_bug.cgi?id=68132

Reviewed by Sam Weinig.

* GNUmakefile.list.am:
* _javascript_Core.gypi:
* _javascript_Core.vcproj/WTF/WTF.vcproj:
* _javascript_Core.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
Update build systems.

* wtf/threads: Added.
* wtf/threads/BinarySemaphore.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
* wtf/threads/BinarySemaphore.h: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.h.
* wtf/threads/win: Added.
* wtf/threads/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/win/BinarySemaphoreWin.cpp.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/_javascript_Core/_javascript_Core.gypi
trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/wtf/CMakeLists.txt


Added Paths

trunk/Source/_javascript_Core/wtf/threads/BinarySemaphore.cpp
trunk/Source/_javascript_Core/wtf/threads/BinarySemaphore.h
trunk/Source/_javascript_Core/wtf/threads/win/BinarySemaphoreWin.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95139 => 95140)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:55:44 UTC (rev 95139)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-15 00:15:11 UTC (rev 95140)
@@ -1,3 +1,23 @@
+2011-09-14  Anders Carlsson  
+
+Add BinarySemaphore class from WebKit2 to WTF
+https://bugs.webkit.org/show_bug.cgi?id=68132
+
+Reviewed by Sam Weinig.
+
+* GNUmakefile.list.am:
+* _javascript_Core.gypi:
+* _javascript_Core.vcproj/WTF/WTF.vcproj:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+Update build systems.
+
+* wtf/threads: Added.
+* wtf/threads/BinarySemaphore.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.
+* wtf/threads/BinarySemaphore.h: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.h.
+* wtf/threads/win: Added.
+* wtf/threads/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/win/BinarySemaphoreWin.cpp.
+
 2011-09-14  Filip Pizlo  
 
 Unreviewed build fix for Interpreter.


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (95139 => 95140)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-14 23:55:44 UTC (rev 95139)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-09-15 00:15:11 UTC (rev 95140)
@@ -611,6 +611,8 @@
 	Source/_javascript_Core/wtf/text/TextPosition.h \
 	Source/_javascript_Core/wtf/text/WTFString.cpp \
 	Source/_javascript_Core/wtf/text/WTFString.h \
+	Source/_javascript_Core/wtf/threads/BinarySemaphore.cpp \
+	Source/_javascript_Core/wtf/threads/BinarySemaphore.h \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.cpp \
 	Source/_javascript_Core/wtf/ThreadIdentifierDataPthreads.h \
 	Source/_javascript_Core/wtf/ThreadRestrictionVerifier.h \


Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (95139 => 95140)

--- trunk/Source/_javascript_Core/_javascript_Core.gypi	2011-09-14 23:55:44 UTC (rev 95139)
+++ trunk/Source/_javascript_Core/_javascript_Core.gypi	2011-09-15 00:15:11 UTC (rev 95140)
@@ -241,6 +241,7 @@
 'wtf/text/StringOperators.h',
 'wtf/text/TextPosition.h',
 'wtf/text/WTFString.h',
+'wtf/threads/BinarySemaphore.h',
 'wtf/unicode/CharacterNames.h',
 'wtf/unicode/Collator.h',
 'wtf/unicode/UTF8.h',
@@ -666,6 +667,7 @@
 'wtf/text/StringImpl.cpp',
 'wtf/text/StringStatics.cpp',
 'wtf/text/WTFString.cpp',
+'wtf/threads/BinarySemaphore.cpp',
 'wtf/unicode/CollatorDefault.cpp',
 'wtf/unicode/ScriptCodesFromICU.h',
 'wtf/unicode/UTF8.cpp',


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj (95139 => 95140)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj	2011-09-14 23:55:44 UTC (rev 95139)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj	2011-09-15 00:15:11 UTC (rev 95140)
@@ -588,6 +588,26 @@
 >
 
 
+		
+		
+			
+			
+		
+			
+			
+			
+			
+		
 		 			RelativePath="..\..\wtf\Alignment.h"
 			>


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (95139 => 95140)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-09-14 23:55:44 UTC (rev 95139)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-09-15 00:15:11 UTC (rev 95140)
@@ -225,6

[webkit-changes] [95139] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95139] trunk/Source/_javascript_Core








Revision 95139
Author fpi...@apple.com
Date 2011-09-14 16:55:44 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed build fix for Interpreter.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95138 => 95139)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:44:05 UTC (rev 95138)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:55:44 UTC (rev 95139)
@@ -1,3 +1,10 @@
+2011-09-14  Filip Pizlo  
+
+Unreviewed build fix for Interpreter.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute):
+
 2011-09-14  Anders Carlsson  
 
 Add wtf/threads and wtf/threads/win, so we can be sure that the EWS


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (95138 => 95139)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-09-14 23:44:05 UTC (rev 95138)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-09-14 23:55:44 UTC (rev 95139)
@@ -3614,6 +3614,10 @@
 vPC += target;
 NEXT_INSTRUCTION();
 }
+DEFINE_OPCODE(op_loop_hint) {
+// This is a no-op unless we intend on doing OSR from the interpreter.
+NEXT_INSTRUCTION();
+}
 DEFINE_OPCODE(op_loop_if_true) {
 /* loop_if_true cond(r) target(offset)
  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95138] trunk/Source/WebCore

[andersca]

Title: [95138] trunk/Source/WebCore








Revision 95138
Author ander...@apple.com
Date 2011-09-14 16:44:05 -0700 (Wed, 14 Sep 2011)


Log Message
Try to fix GTK+ build.

* GNUmakefile.list.am:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (95137 => 95138)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 23:27:23 UTC (rev 95137)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 23:44:05 UTC (rev 95138)
@@ -1,3 +1,9 @@
+2011-09-14  Anders Carlsson  
+
+Try to fix GTK+ build.
+
+* GNUmakefile.list.am:
+
 2011-09-14  James Robinson  
 
 [chromium] LayerRendererChromium shouldn't be RefCounted


Modified: trunk/Source/WebCore/GNUmakefile.list.am (95137 => 95138)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-09-14 23:27:23 UTC (rev 95137)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-09-14 23:44:05 UTC (rev 95138)
@@ -9,8 +9,6 @@
 	DerivedSources/WebCore/CSSValueKeywords.h \
 	DerivedSources/WebCore/CSSValueKeywords.cpp \
 	DerivedSources/WebCore/ColorData.cpp \
-	DerivedSources/WebCore/DocTypeStrings.cpp \
-	DerivedSources/WebCore/HashTools.h \
 	DerivedSources/WebCore/HTMLElementFactory.cpp \
 	DerivedSources/WebCore/HTMLElementFactory.h \
 	DerivedSources/WebCore/HTMLEntityTable.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95137] trunk/Source/JavaScriptCore

[andersca]

Title: [95137] trunk/Source/_javascript_Core








Revision 95137
Author ander...@apple.com
Date 2011-09-14 16:27:23 -0700 (Wed, 14 Sep 2011)


Log Message
Add wtf/threads and wtf/threads/win, so we can be sure that the EWS
bots can correctly build the patch in https://bugs.webkit.org/show_bug.cgi?id=68132

Rubber-stamped by Sam Weinig.

* wtf/threads: Added.
* wtf/threads/win: Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog


Added Paths

trunk/Source/_javascript_Core/wtf/threads/
trunk/Source/_javascript_Core/wtf/threads/win/




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95136 => 95137)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:06:04 UTC (rev 95136)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:27:23 UTC (rev 95137)
@@ -1,3 +1,13 @@
+2011-09-14  Anders Carlsson  
+
+Add wtf/threads and wtf/threads/win, so we can be sure that the EWS
+bots can correctly build the patch in https://bugs.webkit.org/show_bug.cgi?id=68132
+
+Rubber-stamped by Sam Weinig.
+
+* wtf/threads: Added.
+* wtf/threads/win: Added.
+
 2011-09-14  Filip Pizlo  
 
 DFG JIT should not speculate integer if the value is always going to be






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95136] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95136] trunk/Source/_javascript_Core








Revision 95136
Author fpi...@apple.com
Date 2011-09-14 16:06:04 -0700 (Wed, 14 Sep 2011)


Log Message
DFG JIT should not speculate integer if the value is always going to be
used as a double anyway
https://bugs.webkit.org/show_bug.cgi?id=68127

Reviewed by Oliver Hunt.

Added a ValueToDouble node, which is a variant of ValueToNumber that
hints that it will only be used as a double and never as an integer.
Thus, it turns off integer speculation even if the value profiler
told us that the value source is an int. The logic for converting a
ValueToNumber into a ValueToDouble is found in Propagator.

This appears to be a 22% speed-up in imaging-darkroom.

* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::toDouble):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::fixup):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95135 => 95136)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:01:23 UTC (rev 95135)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 23:06:04 UTC (rev 95136)
@@ -1,5 +1,33 @@
 2011-09-14  Filip Pizlo  
 
+DFG JIT should not speculate integer if the value is always going to be
+used as a double anyway
+https://bugs.webkit.org/show_bug.cgi?id=68127
+
+Reviewed by Oliver Hunt.
+
+Added a ValueToDouble node, which is a variant of ValueToNumber that
+hints that it will only be used as a double and never as an integer.
+Thus, it turns off integer speculation even if the value profiler
+told us that the value source is an int. The logic for converting a
+ValueToNumber into a ValueToDouble is found in Propagator.
+
+This appears to be a 22% speed-up in imaging-darkroom.
+
+* dfg/DFGNode.h:
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::compile):
+* dfg/DFGPropagator.cpp:
+(JSC::DFG::Propagator::fixpoint):
+(JSC::DFG::Propagator::toDouble):
+(JSC::DFG::Propagator::fixupNode):
+(JSC::DFG::Propagator::fixup):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
+
+2011-09-14  Filip Pizlo  
+
 Tiered compilation heuristics do not account for value profile fullness
 https://bugs.webkit.org/show_bug.cgi?id=68116
 


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (95135 => 95136)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-14 23:01:23 UTC (rev 95135)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-14 23:06:04 UTC (rev 95136)
@@ -158,6 +158,9 @@
 /* Arithmetic operators call ToNumber on their operands. */\
 macro(ValueToNumber, NodeResultNumber | NodeMustGenerate) \
 \
+/* A variant of ValueToNumber, which a hint that the parents will always use this as a double. */\
+macro(ValueToDouble, NodeResultNumber | NodeMustGenerate) \
+\
 /* Add of values may either be arithmetic, or result in string concatenation. */\
 macro(ValueAdd, NodeResultJS | NodeMustGenerate) \
 \


Modified: trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp (95135 => 95136)

--- trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-14 23:01:23 UTC (rev 95135)
+++ trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-14 23:06:04 UTC (rev 95136)
@@ -595,7 +595,8 @@
 break;
 }
 
-case ValueToNumber: {
+case ValueToNumber:
+case ValueToDouble: {
 ASSERT(!isInt32Constant(node.child1()));
 ASSERT(!isNumberConstant(node.child1()));
 


Modified: trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp (95135 => 95136)

--- trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp	2011-09-14 23:01:23 UTC (rev 95135)
+++ trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp	2011-09-14 23:06:04 UTC (rev 95136)
@@ -85,6 +85,8 @@
 m_changed = false;
 propagateBackward();
 } while (m_changed);
+
+fixup();
 }
 
 private:
@@ -321,6 +323,80 @@
 propagateNode(m_graph[m_compileIndex]);
 }
 
+void toDouble(NodeIndex nodeIndex)
+{
+if (m_graph[nodeIndex].op == ValueToNumber) {
+#if ENABLE(DFG_DEBUG_VERBOSE)
+printf("  @%u -> ValueToDouble", nodeIndex);
+#endif
+m_graph[nodeIndex].op = ValueToDouble;
+}
+}
+
+void fixupN

[webkit-changes] [95133] trunk/LayoutTests

[eric . carlson]

Title: [95133] trunk/LayoutTests








Revision 95133
Author eric.carl...@apple.com
Date 2011-09-14 15:44:31 -0700 (Wed, 14 Sep 2011)


Log Message
Media element tests should look up controller element locations
https://bugs.webkit.org/show_bug.cgi?id=68038

Get the position of controller elements from the shadow DOM.

Reviewed by Darin Adler.

* media/audio-delete-while-slider-thumb-clicked.html:
* media/audio-delete-while-step-button-clicked.html:
* media/controls-drag-timebar.html:
* media/controls-right-click-on-timebar.html:
* media/video-controls-transformed.html:
* media/video-controls-visible-audio-only.html:
* media/video-controls-zoomed.html:
* media/video-volume-slider.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html
trunk/LayoutTests/media/audio-delete-while-step-button-clicked.html
trunk/LayoutTests/media/controls-drag-timebar.html
trunk/LayoutTests/media/controls-right-click-on-timebar.html
trunk/LayoutTests/media/video-controls-transformed.html
trunk/LayoutTests/media/video-controls-visible-audio-only.html
trunk/LayoutTests/media/video-controls-zoomed.html
trunk/LayoutTests/media/video-volume-slider.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95132 => 95133)

--- trunk/LayoutTests/ChangeLog	2011-09-14 22:42:46 UTC (rev 95132)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 22:44:31 UTC (rev 95133)
@@ -1,3 +1,21 @@
+2011-09-14  Eric Carlson  
+
+Media element tests should look up controller element locations.
+https://bugs.webkit.org/show_bug.cgi?id=68038
+
+Get the position of controller elements from the shadow DOM.
+
+Reviewed by Darin Adler.
+
+* media/audio-delete-while-slider-thumb-clicked.html:
+* media/audio-delete-while-step-button-clicked.html:
+* media/controls-drag-timebar.html:
+* media/controls-right-click-on-timebar.html:
+* media/video-controls-transformed.html:
+* media/video-controls-visible-audio-only.html:
+* media/video-controls-zoomed.html:
+* media/video-volume-slider.html:
+
 2011-09-14  David Levin  
 
 [chromium] Update baselines due to r95070 and r95099.


Modified: trunk/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html (95132 => 95133)

--- trunk/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html	2011-09-14 22:42:46 UTC (rev 95132)
+++ trunk/LayoutTests/media/audio-delete-while-slider-thumb-clicked.html	2011-09-14 22:44:31 UTC (rev 95133)
@@ -2,6 +2,8 @@
 
 
 

[webkit-changes] [95132] trunk/Source/WebKit/chromium

[tony]

Title: [95132] trunk/Source/WebKit/chromium








Revision 95132
Author t...@chromium.org
Date 2011-09-14 15:42:46 -0700 (Wed, 14 Sep 2011)


Log Message
Changed WebKit.gyp to use the new grit version of the scripts that handle
.pak files.
https://bugs.webkit.org/show_bug.cgi?id=68013

Patch by Nebojsa Ciric  on 2011-09-14
Reviewed by Tony Chang.

* DEPS:
* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95131 => 95132)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-14 22:37:49 UTC (rev 95131)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-14 22:42:46 UTC (rev 95132)
@@ -1,3 +1,14 @@
+2011-09-14  Nebojsa Ciric  
+
+Changed WebKit.gyp to use the new grit version of the scripts that handle
+.pak files.
+https://bugs.webkit.org/show_bug.cgi?id=68013
+
+Reviewed by Tony Chang.
+
+* DEPS:
+* WebKit.gyp:
+
 2011-09-14  Anders Carlsson  
 
 Fix Chromium build.


Modified: trunk/Source/WebKit/chromium/DEPS (95131 => 95132)

--- trunk/Source/WebKit/chromium/DEPS	2011-09-14 22:37:49 UTC (rev 95131)
+++ trunk/Source/WebKit/chromium/DEPS	2011-09-14 22:42:46 UTC (rev 95132)
@@ -42,8 +42,6 @@
   # build tools
   'build':
 Var('chromium_svn')+'/build@'+Var('chromium_rev'),
-  'tools/data_pack':
-Var('chromium_svn')+'/tools/data_pack@'+Var('chromium_rev'),
   'tools/gyp':
 From('chromium_deps', 'src/tools/gyp'),
 


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (95131 => 95132)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-09-14 22:37:49 UTC (rev 95131)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-09-14 22:42:46 UTC (rev 95132)
@@ -1058,7 +1058,7 @@
 {
 'action_name': 'repack_locale',
 'variables': {
-'repack_path': '<(chromium_src_dir)/tools/data_pack/repack.py',
+'repack_path': '<(chromium_src_dir)/tools/grit/grit/format/repack.py',
 'pak_inputs': [
 '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
 '<(SHARED_INTERMEDIATE_DIR)/ui/gfx/gfx_resources.pak',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95131] trunk/LayoutTests

[levin]

Title: [95131] trunk/LayoutTests








Revision 95131
Author le...@chromium.org
Date 2011-09-14 15:37:49 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] Update baselines due to r95070 and r95099.

* platform/chromium-cg-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
* platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
* platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt: Added.
* platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Added.
* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Added.
* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Added.
* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/fast/writing-mode/broken-ideographic-font-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt
trunk/LayoutTests/platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95130 => 95131)

--- trunk/LayoutTests/ChangeLog	2011-09-14 22:31:40 UTC (rev 95130)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 22:37:49 UTC (rev 95131)
@@ -1,3 +1,21 @@
+2011-09-14  David Levin  
+
+[chromium] Update baselines due to r95070 and r95099.
+
+* platform/chromium-cg-mac-leopard/fast/writing-mode/broken-ideographic-font-expected.png: Added.
+* platform/chromium-cg-mac/fast/writing-mode/broken-ideographic-font-expected.png: Added.
+* platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Added.
+* platform/chromium-cg-mac/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Added.
+* platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/chromium-linux-x86/fast/borders/border-image-scrambled-expected.txt: Added.
+* platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/chromium-linux/fast/borders/border-image-scrambled-expected.txt: Added.
+* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/chromium-win-vista/fast/borders/border-image-scrambled-expected.txt: Added.
+* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-09-14  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=52736


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95130 => 95131)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 22:31:40 UTC (rev 95130)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 22:37:49 UTC (rev 95131)
@@ -3723,7 +3723,3 @@
 // Failing after r95023
 BUGWK67999 WIN RELEASE : fast/borders/border-image-omit-right-slice.html = IMAGE+TEXT
 BUGWK67999 LINUX MAC RELEASE : fast/borders/border-image-omit-right-slice.html = TEXT
-
-// Failing after r95070
-BUGWK68065 MAC : fast/writing-mode/broken-ideographic-font.html = IMAGE
-BUGWK68065 SNOWLEOPARD RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE


Added: tr

[webkit-changes] [95130] trunk/Source

[andersca]

Title: [95130] trunk/Source








Revision 95130
Author ander...@apple.com
Date 2011-09-14 15:31:40 -0700 (Wed, 14 Sep 2011)


Log Message
Get rid of WebCoreViewFactory and its WebViewFactory subclass
https://bugs.webkit.org/show_bug.cgi?id=68124

Reviewed by Sam Weinig.

../WebCore: 

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* editing/mac/FrameSelectionMac.mm:
* page/mac/FrameMac.mm:
* page/mac/WebCoreViewFactory.h: Removed.
* page/mac/WebCoreViewFactory.m: Removed.

../WebKit: 

* WebKit.xcodeproj/project.pbxproj:

../WebKit/mac: 

* WebCoreSupport/WebContextMenuClient.mm:
* WebCoreSupport/WebViewFactory.h: Removed.
* WebCoreSupport/WebViewFactory.mm: Removed.
* WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/editing/mac/FrameSelectionMac.mm
trunk/Source/WebCore/page/mac/FrameMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm
trunk/Source/WebKit/mac/WebView/WebFrameView.mm


Removed Paths

trunk/Source/WebCore/page/mac/WebCoreViewFactory.h
trunk/Source/WebCore/page/mac/WebCoreViewFactory.m
trunk/Source/WebKit/mac/WebCoreSupport/WebViewFactory.h
trunk/Source/WebKit/mac/WebCoreSupport/WebViewFactory.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (95129 => 95130)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 22:24:23 UTC (rev 95129)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 22:31:40 UTC (rev 95130)
@@ -1,3 +1,17 @@
+2011-09-14  Anders Carlsson  
+
+Get rid of WebCoreViewFactory and its WebViewFactory subclass
+https://bugs.webkit.org/show_bug.cgi?id=68124
+
+Reviewed by Sam Weinig.
+
+* WebCore.exp.in:
+* WebCore.xcodeproj/project.pbxproj:
+* editing/mac/FrameSelectionMac.mm:
+* page/mac/FrameMac.mm:
+* page/mac/WebCoreViewFactory.h: Removed.
+* page/mac/WebCoreViewFactory.m: Removed.
+
 2011-09-14  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=52736


Modified: trunk/Source/WebCore/WebCore.exp.in (95129 => 95130)

--- trunk/Source/WebCore/WebCore.exp.in	2011-09-14 22:24:23 UTC (rev 95129)
+++ trunk/Source/WebCore/WebCore.exp.in	2011-09-14 22:31:40 UTC (rev 95130)
@@ -105,7 +105,6 @@
 .objc_class_name_DOMTreeWalker
 .objc_class_name_DOMUIEvent
 .objc_class_name_DOMWheelEvent
-.objc_class_name_WebCoreViewFactory
 .objc_class_name_WebFontCache
 .objc_class_name_WebHTMLConverter
 .objc_class_name_WebScriptObject


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (95129 => 95130)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-09-14 22:24:23 UTC (rev 95129)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-09-14 22:31:40 UTC (rev 95130)
@@ -3121,7 +3121,6 @@
 		93F1996308245E59001E9ABC /* SSLKeyGenerator.h in Headers */ = {isa = PBXBuildFile; fileRef = F587866202DE3B1101EA4122 /* SSLKeyGenerator.h */; };
 		93F1998C08245E59001E9ABC /* RenderTreeAsText.h in Headers */ = {isa = PBXBuildFile; fileRef = 93955A4103D72932008635CE /* RenderTreeAsText.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93F199A808245E59001E9ABC /* WebCoreFrameView.h in Headers */ = {isa = PBXBuildFile; fileRef = F587854C02DE375901EA4122 /* WebCoreFrameView.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		93F199B308245E59001E9ABC /* WebCoreViewFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = F587855402DE375901EA4122 /* WebCoreViewFactory.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93F199B808245E59001E9ABC /* Scrollbar.h in Headers */ = {isa = PBXBuildFile; fileRef = BC7B2AF80450824100A8000F /* Scrollbar.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93F199BB08245E59001E9ABC /* WebCoreKeyboardUIMode.h in Headers */ = {isa = PBXBuildFile; fileRef = BE983D95052A2E0A00892D85 /* WebCoreKeyboardUIMode.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93F199BE08245E59001E9ABC /* BlockExceptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 65A640F00533BB1F0085E777 /* BlockExceptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -3132,7 +3131,6 @@
 		93F199ED08245E59001E9ABC /* XSLTProcessor.h in Headers */ = {isa = PBXBuildFile; fileRef = BC06F24C06D18A7E004A6FA3 /* XSLTProcessor.h */; };
 		93F199F008245E59001E9ABC /* WebCoreView.h in Headers */ = {isa = PBXBuildFile; fileRef = BE855F7F0701E83500239769 /* WebCoreView.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		93F19A2608245E59001E9ABC /* CursorMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = F58784F002DE375901EA4122 /* CursorMac.mm */; };
-		93F19A5F08245E59001E9ABC /* WebCoreViewFactory.m in Sources */ = {isa = PBXBuildFile; fileRef = F587855502DE375901EA4122 /* WebCoreViewFactory.m */; };
 		93F19A9108245E59001E9ABC /* HTMLDocument.cpp in Sources */ = {isa = PBXBuildFile; f

[webkit-changes] [95129] trunk

[hyatt]

Title: [95129] trunk








Revision 95129
Author hy...@apple.com
Date 2011-09-14 15:24:23 -0700 (Wed, 14 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=52736

Tiles were not being properly centered within border image sides for the "repeat"
keyword. This patch fixes the buggy math behind the pattern tiling to actually get
the initial phases correct.

Source/WebCore: 

Reviewed by Sam Weinig.

Added new tests in fast/borders and updated broken existing tests.

* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):

LayoutTests: 

Reviewed by Sam Weinig.

* fast/borders/border-image-massive-scale.html: Added.
* fast/borders/border-image-scaled-gradient.html: Added.
* platform/mac/fast/borders/border-image-massive-scale-expected.png: Added.
* platform/mac/fast/borders/border-image-massive-scale-expected.txt: Added.
* platform/mac/fast/borders/border-image-outset-expected.png:
* platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
* platform/mac/fast/borders/border-image-outset-split-inline-expected.png:
* platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
* platform/mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
* platform/mac/fast/borders/border-image-scaled-gradient-expected.txt: Added.
* platform/mac/fast/borders/border-image-side-reduction-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/borders/border-image-outset-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-outset-split-inline-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-side-reduction-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Image.cpp


Added Paths

trunk/LayoutTests/fast/borders/border-image-massive-scale.html
trunk/LayoutTests/fast/borders/border-image-scaled-gradient.html
trunk/LayoutTests/platform/mac/fast/borders/border-image-massive-scale-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-massive-scale-expected.txt
trunk/LayoutTests/platform/mac/fast/borders/border-image-scaled-gradient-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-scaled-gradient-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95128 => 95129)

--- trunk/LayoutTests/ChangeLog	2011-09-14 22:14:33 UTC (rev 95128)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 22:24:23 UTC (rev 95129)
@@ -1,3 +1,25 @@
+2011-09-14  David Hyatt  
+
+https://bugs.webkit.org/show_bug.cgi?id=52736
+
+Tiles were not being properly centered within border image sides for the "repeat"
+keyword. This patch fixes the buggy math behind the pattern tiling to actually get
+the initial phases correct.
+
+Reviewed by Sam Weinig.
+
+* fast/borders/border-image-massive-scale.html: Added.
+* fast/borders/border-image-scaled-gradient.html: Added.
+* platform/mac/fast/borders/border-image-massive-scale-expected.png: Added.
+* platform/mac/fast/borders/border-image-massive-scale-expected.txt: Added.
+* platform/mac/fast/borders/border-image-outset-expected.png:
+* platform/mac/fast/borders/border-image-outset-in-shorthand-expected.png:
+* platform/mac/fast/borders/border-image-outset-split-inline-expected.png:
+* platform/mac/fast/borders/border-image-outset-split-inline-vertical-lr-expected.png:
+* platform/mac/fast/borders/border-image-scaled-gradient-expected.png: Added.
+* platform/mac/fast/borders/border-image-scaled-gradient-expected.txt: Added.
+* platform/mac/fast/borders/border-image-side-reduction-expected.png:
+
 2011-09-14  Jeremy Apthorp  
 
 Change mousedown events to keydown events, since eventSender.mouseDown


Added: trunk/LayoutTests/fast/borders/border-image-massive-scale.html (0 => 95129)

--- trunk/LayoutTests/fast/borders/border-image-massive-scale.html	(rev 0)
+++ trunk/LayoutTests/fast/borders/border-image-massive-scale.html	2011-09-14 22:24:23 UTC (rev 95129)
@@ -0,0 +1,36 @@
+
+
+
+div {
+border-width: 105px 150px 150px 105px;
+width: 75px;
+height: 75px;
+margin: 10px;
+display: inline-block;
+}
+
+div.rr {
+-webkit-border-image: url("resources/border-image.png") 21 30 30 21 repeat repeat;
+}
+
+div.rs {
+-webkit-border-image: url("resources/border-image.png") 21 30 30 21 repeat stretch;
+}
+
+div.sr {
+-webkit-border-image: url("resources/border-image.png") 21 30 30 21 stretch repeat;
+}
+
+div.ss {
+-webkit-border-image: url("resources/border-image.png") 21 30 30 21 stretch s

[webkit-changes] [95128] trunk/Source/WebCore

[andersca]

Title: [95128] trunk/Source/WebCore








Revision 95128
Author ander...@apple.com
Date 2011-09-14 15:14:33 -0700 (Wed, 14 Sep 2011)


Log Message
Remove DocTypeStrings.gperf
https://bugs.webkit.org/show_bug.cgi?id=68119

Reviewed by Sam Weinig.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DocTypeStrings.gperf: Removed.
* make-hash-tools.pl:
* platform/HashTools.h:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/CodeGenerators.pri
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/make-hash-tools.pl
trunk/Source/WebCore/platform/HashTools.h


Removed Paths

trunk/Source/WebCore/html/DocTypeStrings.gperf




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (95127 => 95128)

--- trunk/Source/WebCore/CMakeLists.txt	2011-09-14 22:04:50 UTC (rev 95127)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-09-14 22:14:33 UTC (rev 95128)
@@ -2228,10 +2228,6 @@
 LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/ColorData.cpp)
 
 
-MAKE_HASH_TOOLS(${WEBCORE_DIR}/html/DocTypeStrings)
-LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/DocTypeStrings.cpp)
-
-
 # Generate XMLViewerCSS.h
 ADD_CUSTOM_COMMAND(
 OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/XMLViewerCSS.h


Modified: trunk/Source/WebCore/ChangeLog (95127 => 95128)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 22:04:50 UTC (rev 95127)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 22:14:33 UTC (rev 95128)
@@ -1,3 +1,21 @@
+2011-09-14  Anders Carlsson  
+
+Remove DocTypeStrings.gperf
+https://bugs.webkit.org/show_bug.cgi?id=68119
+
+Reviewed by Sam Weinig.
+
+* CMakeLists.txt:
+* CodeGenerators.pri:
+* DerivedSources.make:
+* GNUmakefile.am:
+* WebCore.gyp/WebCore.gyp:
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* html/DocTypeStrings.gperf: Removed.
+* make-hash-tools.pl:
+* platform/HashTools.h:
+
 2011-09-14  Chris Rogers  
 
 Address lifetime issues in OfflineAudioDestinationNode (take 2)


Modified: trunk/Source/WebCore/CodeGenerators.pri (95127 => 95128)

--- trunk/Source/WebCore/CodeGenerators.pri	2011-09-14 22:04:50 UTC (rev 95127)
+++ trunk/Source/WebCore/CodeGenerators.pri	2011-09-14 22:14:33 UTC (rev 95128)
@@ -17,8 +17,6 @@
 
 TOKENIZER = $$PWD/css/tokenizer.flex
 
-DOCTYPESTRINGS_GPERF = $$PWD/html/DocTypeStrings.gperf
-
 CSSBISON = $$PWD/css/CSSGrammar.y
 
 contains(DEFINES, ENABLE_XSLT=1) {
@@ -782,15 +780,6 @@
 addExtraCompiler(entities)
 
 # GENERATOR 8-B:
-doctypestrings.output = $${WC_GENERATED_SOURCES_DIR}/DocTypeStrings.cpp
-doctypestrings.input = DOCTYPESTRINGS_GPERF
-doctypestrings.wkScript = $$PWD/make-hash-tools.pl
-doctypestrings.commands = perl $$doctypestrings.wkScript $${WC_GENERATED_SOURCES_DIR} $$DOCTYPESTRINGS_GPERF
-doctypestrings.clean = ${QMAKE_FILE_OUT}
-doctypestrings.depends = $$PWD/make-hash-tools.pl
-addExtraCompiler(doctypestrings)
-
-# GENERATOR 8-C:
 colordata.output = $${WC_GENERATED_SOURCES_DIR}/ColorData.cpp
 colordata.input = COLORDATA_GPERF
 colordata.wkScript = $$PWD/make-hash-tools.pl
@@ -801,7 +790,7 @@
 
 contains(DEFINES, ENABLE_XSLT=1) {
 contains(DEFINES, WTF_USE_LIBXML2=1) {
-# GENERATOR 8-D:
+# GENERATOR 8-C:
 xmlviewercss.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerCSS.h
 xmlviewercss.input = XMLVIEWER_CSS
 xmlviewercss.wkScript = $$PWD/inspector/xxd.pl
@@ -811,7 +800,7 @@
 xmlviewercss.wkAddOutputToSources = false
 addExtraCompiler(xmlviewercss)
 
-# GENERATOR 8-E:
+# GENERATOR 8-D:
 xmlviewerjs.output = $${WC_GENERATED_SOURCES_DIR}/XMLViewerJS.h
 xmlviewerjs.input = XMLVIEWER_JS
 xmlviewerjs.wkScript = $$PWD/inspector/xxd.pl


Modified: trunk/Source/WebCore/DerivedSources.make (95127 => 95128)

--- trunk/Source/WebCore/DerivedSources.make	2011-09-14 22:04:50 UTC (rev 95127)
+++ trunk/Source/WebCore/DerivedSources.make	2011-09-14 22:14:33 UTC (rev 95128)
@@ -591,7 +591,6 @@
 CSSPropertyNames.h \
 CSSValueKeywords.h \
 ColorData.cpp \
-DocTypeStrings.cpp \
 HTMLElementFactory.cpp \
 HTMLEntityTable.cpp \
 HTMLNames.cpp \
@@ -672,13 +671,6 @@
 
 # 
 
-# DOCTYPE strings
-
-DocTypeStrings.cpp : html/DocTypeStrings.gperf $(WebCore)/make-hash-tools.pl
-	perl $(WebCore)/make-hash-tools.pl . $(WebCore)/html/DocTypeStrings.gperf
-
-# 
-
 # XMLViewer CSS
 
 all : XMLViewerCSS.h


Modified: trunk/Source/WebCore/GNUmakefile.am (95127 => 95128)

--- trunk/Source/WebCore/GNUmakefile.am	2011-09-14 22:04:50 UTC (rev 95127)
+++ trunk/Source/WebCore/GNUmakefile.am	2011-09-14 22:14:33 UTC (rev 95128)
@@ -624,11 +624,6 @@
 	$(PERL) -I$(We

[webkit-changes] [95127] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95127] trunk/Source/_javascript_Core








Revision 95127
Author fpi...@apple.com
Date 2011-09-14 15:04:50 -0700 (Wed, 14 Sep 2011)


Log Message
DFG should not speculate that the child of LogicalNot is a boolean if
predictions tell us otherwise
https://bugs.webkit.org/show_bug.cgi?id=68118

Reviewed by Geoffrey Garen.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95126 => 95127)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 21:58:03 UTC (rev 95126)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 22:04:50 UTC (rev 95127)
@@ -1,5 +1,21 @@
 2011-09-14  Filip Pizlo  
 
+DFG should not speculate that the child of LogicalNot is a boolean if
+predictions tell us otherwise
+https://bugs.webkit.org/show_bug.cgi?id=68118
+
+Reviewed by Geoffrey Garen.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeLogicalNot):
+* dfg/DFGJITCodeGenerator.h:
+* dfg/DFGNonSpeculativeJIT.cpp:
+(JSC::DFG::NonSpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
+2011-09-14  Filip Pizlo  
+
 Unreviewed build fix.  Turn off tiered compilation.
 
 * wtf/Platform.h:


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (95126 => 95127)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-14 21:58:03 UTC (rev 95126)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-14 22:04:50 UTC (rev 95127)
@@ -1028,6 +1028,33 @@
 }
 }
 
+void JITCodeGenerator::nonSpeculativeLogicalNot(Node& node)
+{
+JSValueOperand arg1(this, node.child1());
+GPRTemporary result(this);
+
+GPRReg arg1GPR = arg1.gpr();
+GPRReg resultGPR = result.gpr();
+
+arg1.use();
+
+m_jit.move(arg1GPR, resultGPR);
+m_jit.xorPtr(TrustedImm32(static_cast(ValueFalse)), resultGPR);
+JITCompiler::Jump fastCase = m_jit.branchTestPtr(JITCompiler::Zero, resultGPR, TrustedImm32(static_cast(~1)));
+
+silentSpillAllRegisters(resultGPR);
+m_jit.move(arg1GPR, GPRInfo::argumentGPR1);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+appendCallWithExceptionCheck(dfgConvertJSValueToBoolean);
+m_jit.move(GPRInfo::returnValueGPR, resultGPR);
+silentFillAllRegisters(resultGPR);
+
+fastCase.link(&m_jit);
+
+m_jit.xorPtr(TrustedImm32(static_cast(ValueTrue)), resultGPR);
+jsValueResult(resultGPR, m_compileIndex, DataFormatJSBoolean, UseChildrenCalledExplicitly);
+}
+
 void JITCodeGenerator::emitCall(Node& node)
 {
 P_DFGOperation_E slowCallFunction;


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (95126 => 95127)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-14 21:58:03 UTC (rev 95126)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h	2011-09-14 22:04:50 UTC (rev 95127)
@@ -578,6 +578,8 @@
 
 void emitBranch(Node&);
 
+void nonSpeculativeLogicalNot(Node&);
+
 MacroAssembler::Address addressOfCallData(int idx)
 {
 return MacroAssembler::Address(GPRInfo::callFrameRegister, (m_jit.codeBlock()->m_numCalleeRegisters + idx) * static_cast(sizeof(Register)));


Modified: trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp (95126 => 95127)

--- trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-14 21:58:03 UTC (rev 95126)
+++ trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-09-14 22:04:50 UTC (rev 95127)
@@ -777,29 +777,7 @@
 }
 
 case LogicalNot: {
-JSValueOperand arg1(this, node.child1());
-GPRTemporary result(this);
-
-GPRReg arg1GPR = arg1.gpr();
-GPRReg resultGPR = result.gpr();
-
-arg1.use();
-
-m_jit.move(arg1GPR, resultGPR);
-m_jit.xorPtr(TrustedImm32(static_cast(ValueFalse)), resultGPR);
-JITCompiler::Jump fastCase = m_jit.branchTestPtr(JITCompiler::Zero, resultGPR, TrustedImm32(static_cast(~1)));
-
-silentSpillAllRegisters(resultGPR);
-m_jit.move(arg1GPR, GPRInfo::argumentGPR1);
-m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(dfgConvertJSValueToBoolean);
-m_jit.move(GPRInfo::returnValueGPR, resultGPR);
-silentFillAllRegisters(resultGPR);
-
-fastCase.link(&m_jit);
-
-   

[webkit-changes] [95126] trunk/LayoutTests

[rniwa]

Title: [95126] trunk/LayoutTests








Revision 95126
Author rn...@webkit.org
Date 2011-09-14 14:58:03 -0700 (Wed, 14 Sep 2011)


Log Message
Change mousedown events to keydown events, since eventSender.mouseDown
wasn't firing onmousedown events on Mac.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp  on 2011-09-14
Reviewed by Adam Barth.

* fullscreen/full-screen-remove-ancestor-during-transition.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95125 => 95126)

--- trunk/LayoutTests/ChangeLog	2011-09-14 21:39:43 UTC (rev 95125)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 21:58:03 UTC (rev 95126)
@@ -1,3 +1,13 @@
+2011-09-14  Jeremy Apthorp  
+
+Change mousedown events to keydown events, since eventSender.mouseDown
+wasn't firing onmousedown events on Mac.
+https://bugs.webkit.org/show_bug.cgi?id=67960
+
+Reviewed by Adam Barth.
+
+* fullscreen/full-screen-remove-ancestor-during-transition.html:
+
 2011-09-14  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=68103


Modified: trunk/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html (95125 => 95126)

--- trunk/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html	2011-09-14 21:39:43 UTC (rev 95125)
+++ trunk/LayoutTests/fullscreen/full-screen-remove-ancestor-during-transition.html	2011-09-14 21:58:03 UTC (rev 95126)
@@ -7,9 +7,9 @@
 
 function runWithKeyDown(fn)
 {
-document.addEventListener('mousedown', function() { fn(); }, false);
+document.addEventListener('keydown', function() { fn(); }, false);
 if (window.layoutTestController) {
-eventSender.mouseDown();
+eventSender.keyDown('a');
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95125] branches/chromium/874/Source/WebCore/platform/graphics/skia/ ImageBufferSkia.cpp

[senorblanco]

Title: [95125] branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp








Revision 95125
Author senorbla...@chromium.org
Date 2011-09-14 14:39:43 -0700 (Wed, 14 Sep 2011)


Log Message
Merge 94982 - [chromium]  Prevent a crash when tearing down an ImageBuffer that was not successfully initialized.
https://bugs.webkit.org/show_bug.cgi?id=67944

Patch by Jeff Timanus  on 2011-09-12
Reviewed by Stephen White.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):

TBR=t...@chromium.org
Review URL: http://codereview.chromium.org/7888057

Modified Paths

branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (95124 => 95125)

--- branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-09-14 21:39:34 UTC (rev 95124)
+++ branches/chromium/874/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-09-14 21:39:43 UTC (rev 95125)
@@ -116,8 +116,10 @@
 
 ImageBuffer::~ImageBuffer()
 {
-// This is so that the SkGpuDevice destructor has the correct context.
-m_context->platformContext()->makeGrContextCurrent();
+if (m_context && m_context->platformContext()) {
+// This is so that the SkGpuDevice destructor has the correct context.
+m_context->platformContext()->makeGrContextCurrent();
+}
 }
 
 GraphicsContext* ImageBuffer::context() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95124] trunk/Source/WebCore

[crogers]

Title: [95124] trunk/Source/WebCore








Revision 95124
Author crog...@google.com
Date 2011-09-14 14:39:34 -0700 (Wed, 14 Sep 2011)


Log Message
Address lifetime issues in OfflineAudioDestinationNode (take 2)
https://bugs.webkit.org/show_bug.cgi?id=68111

Reviewed by Kenneth Russell.

No new tests.  This fixes existing layout tests.

* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::render):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95123 => 95124)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 21:33:01 UTC (rev 95123)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 21:39:34 UTC (rev 95124)
@@ -1,3 +1,18 @@
+2011-09-14  Chris Rogers  
+
+Address lifetime issues in OfflineAudioDestinationNode (take 2)
+https://bugs.webkit.org/show_bug.cgi?id=68111
+
+Reviewed by Kenneth Russell.
+
+No new tests.  This fixes existing layout tests.
+
+* webaudio/OfflineAudioDestinationNode.cpp:
+(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
+(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
+(WebCore::OfflineAudioDestinationNode::startRendering):
+(WebCore::OfflineAudioDestinationNode::render):
+
 2011-09-14  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=68103


Modified: trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp (95123 => 95124)

--- trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp	2011-09-14 21:33:01 UTC (rev 95123)
+++ trunk/Source/WebCore/webaudio/OfflineAudioDestinationNode.cpp	2011-09-14 21:39:34 UTC (rev 95124)
@@ -43,6 +43,7 @@
 OfflineAudioDestinationNode::OfflineAudioDestinationNode(AudioContext* context, AudioBuffer* renderTarget)
 : AudioDestinationNode(context, renderTarget->sampleRate())
 , m_renderTarget(renderTarget)
+, m_renderThread(0)
 , m_startedRendering(false)
 {
 m_renderBus = adoptPtr(new AudioBus(renderTarget->numberOfChannels(), renderQuantumSize));
@@ -52,9 +53,6 @@
 
 OfflineAudioDestinationNode::~OfflineAudioDestinationNode()
 {
-if (m_renderThread)
-waitForThreadCompletion(m_renderThread, 0);
-
 uninitialize();
 }
 
@@ -83,6 +81,7 @@
 
 if (!m_startedRendering) {
 m_startedRendering = true;
+ref(); // See corresponding deref() call in notifyCompleteDispatch().
 m_renderThread = createThread(OfflineAudioDestinationNode::renderEntry, this, "offline renderer");
 }
 }
@@ -146,8 +145,6 @@
 }
 
 // Our work is done. Let the AudioContext know.
-// See corresponding deref() call in notifyCompleteDispatch().
-ref();
 callOnMainThread(notifyCompleteDispatch, this);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95123] trunk/Source/WebKit/chromium

[andersca]

Title: [95123] trunk/Source/WebKit/chromium








Revision 95123
Author ander...@apple.com
Date 2011-09-14 14:33:01 -0700 (Wed, 14 Sep 2011)


Log Message
Fix Chromium build.

* src/ResourceHandle.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ResourceHandle.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (95122 => 95123)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-09-14 21:29:41 UTC (rev 95122)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-09-14 21:33:01 UTC (rev 95123)
@@ -1,3 +1,9 @@
+2011-09-14  Anders Carlsson  
+
+Fix Chromium build.
+
+* src/ResourceHandle.cpp:
+
 2011-09-13  Eric Seidel  
 
 Remove ENABLE_SVG_USE as  is required by HTML5


Modified: trunk/Source/WebKit/chromium/src/ResourceHandle.cpp (95122 => 95123)

--- trunk/Source/WebKit/chromium/src/ResourceHandle.cpp	2011-09-14 21:29:41 UTC (rev 95122)
+++ trunk/Source/WebKit/chromium/src/ResourceHandle.cpp	2011-09-14 21:33:01 UTC (rev 95123)
@@ -243,23 +243,12 @@
 d->setOwner(0);
 }
 
-PassRefPtr ResourceHandle::bufferedData()
-{
-return 0;
-}
-
 bool ResourceHandle::loadsBlocked()
 {
 return false;  // This seems to be related to sync XMLHttpRequest...
 }
 
 // static
-bool ResourceHandle::supportsBufferedData()
-{
-return false;  // The loader will buffer manually if it needs to.
-}
-
-// static
 void ResourceHandle::loadResourceSynchronously(NetworkingContext* context,
const ResourceRequest& request,
StoredCredentials storedCredentials,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95122] trunk

[adachan]

Title: [95122] trunk








Revision 95122
Author adac...@apple.com
Date 2011-09-14 14:29:41 -0700 (Wed, 14 Sep 2011)


Log Message
Source/WebKit2: Implement WKBundleFrameCopyWebArchive().
http://bugs.webkit.org/show_bug.cgi?id=67857

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyWebArchive): Call WebFrame::webArchiveData() and create a WKDataRef from the returned CFDataRef.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::webArchiveData): Add WebFrame::webArchiveData().
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getWebArchiveOfFrame): Move the logic to WebFrame::webArchiveData() and call that method here.

Tools: Add test for WKBundleFrameCopyWebArchive().
https://bugs.webkit.org/show_bug.cgi?id=67857

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
the returned data is a valid webarchive.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
injected bundle for the webarchive and check the returned webarchive.
* TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
(TestWebKitAPI::WebArchiveTest::WebArchiveTest):
(TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
the web archive.

Add files to project.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebFrame.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKit2/WebArchive.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (95121 => 95122)

--- trunk/Source/WebKit2/ChangeLog	2011-09-14 21:15:56 UTC (rev 95121)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-14 21:29:41 UTC (rev 95122)
@@ -1,3 +1,19 @@
+2011-09-14  Ada Chan  
+
+Implement WKBundleFrameCopyWebArchive().
+http://bugs.webkit.org/show_bug.cgi?id=67857
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
+(WKBundleFrameCopyWebArchive): Call WebFrame::webArchiveData() and create a WKDataRef from the returned CFDataRef.
+* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
+* WebProcess/WebPage/WebFrame.cpp:
+(WebKit::WebFrame::webArchiveData): Add WebFrame::webArchiveData().
+* WebProcess/WebPage/WebFrame.h:
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::getWebArchiveOfFrame): Move the logic to WebFrame::webArchiveData() and call that method here.
+
 2011-09-14  Alexey Proskuryakov  
 
 Web Process doesn't need a permission to look up WebProcess service any more


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp (95121 => 95122)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2011-09-14 21:15:56 UTC (rev 95121)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp	2011-09-14 21:29:41 UTC (rev 95122)
@@ -29,6 +29,7 @@
 
 #include "WKAPICast.h"
 #include "WKBundleAPICast.h"
+#include "WKData.h"
 #include "WebFrame.h"
 #include 
 #include 
@@ -240,3 +241,14 @@
 {
 toImpl(frameRef)->setTextDirection(toImpl(directionRef)->string());
 }
+
+WKDataRef WKBundleFrameCopyWebArchive(WKBundleFrameRef frameRef)
+{
+#if PLATFORM(MAC) || PLATFORM(WIN)
+RetainPtr data = ""
+if (data)
+return WKDataCreate(CFDataGetBytePtr(data.get()), CFDataGetLength(data.get()));
+#endif
+
+return 0;
+}


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h (95121 => 95122)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h	2011-09-14 21:15:56 UTC (rev 95121)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.h	2011-09-14 21:29:41 UTC (rev 95122)
@@ -70,6 +70,8 @@
 
 WK_EXPORT WKStringRef WKBundleFrameCopySuggestedFilenameForResourceWithURL(WKBundleFrameRef frame, WKURLRef url);
 WK_EXPORT WKStringRef WKBundleFrameCopyMIMETypeForResourceWithURL(WKBundleFrameRef frame, WKURLRef url);
+
+WK_EXPORT WKDataRef WKBundleFrameCopyWebAr

[webkit-changes] [95120] trunk/Source/WebCore

[andersca]

Title: [95120] trunk/Source/WebCore








Revision 95120
Author ander...@apple.com
Date 2011-09-14 14:03:20 -0700 (Wed, 14 Sep 2011)


Log Message
Get rid of ResourceHandle::bufferedData()
https://bugs.webkit.org/show_bug.cgi?id=68112

Reviewed by David Hyatt.

ResourceHandle::bufferedData() was only implemented on Mac, and the support in the underlying
NSURLConnection class hasn't been there for several OS releases.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::resourceData):
(WebCore::ResourceLoader::addData):
* platform/network/ResourceHandle.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/network/curl/ResourceHandleCurl.cpp:
* platform/network/mac/ResourceHandleMac.mm:
* platform/network/qt/ResourceHandleQt.cpp:
* platform/network/soup/ResourceHandleSoup.cpp:
* platform/network/win/ResourceHandleWin.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.h
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm
trunk/Source/WebCore/platform/network/qt/ResourceHandleQt.cpp
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Source/WebCore/platform/network/win/ResourceHandleWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95119 => 95120)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 20:59:11 UTC (rev 95119)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 21:03:20 UTC (rev 95120)
@@ -1,3 +1,24 @@
+2011-09-14  Anders Carlsson  
+
+Get rid of ResourceHandle::bufferedData()
+https://bugs.webkit.org/show_bug.cgi?id=68112
+
+Reviewed by David Hyatt.
+
+ResourceHandle::bufferedData() was only implemented on Mac, and the support in the underlying
+NSURLConnection class hasn't been there for several OS releases.
+
+* loader/ResourceLoader.cpp:
+(WebCore::ResourceLoader::resourceData):
+(WebCore::ResourceLoader::addData):
+* platform/network/ResourceHandle.h:
+* platform/network/cf/ResourceHandleCFNet.cpp:
+* platform/network/curl/ResourceHandleCurl.cpp:
+* platform/network/mac/ResourceHandleMac.mm:
+* platform/network/qt/ResourceHandleQt.cpp:
+* platform/network/soup/ResourceHandleSoup.cpp:
+* platform/network/win/ResourceHandleWin.cpp:
+
 2011-09-14  Mark Hahnenberg  
 
 REGRESSION: r95108 broke Qt Linux tests


Modified: trunk/Source/WebCore/loader/ResourceLoader.cpp (95119 => 95120)

--- trunk/Source/WebCore/loader/ResourceLoader.cpp	2011-09-14 20:59:11 UTC (rev 95119)
+++ trunk/Source/WebCore/loader/ResourceLoader.cpp	2011-09-14 21:03:20 UTC (rev 95120)
@@ -49,13 +49,7 @@
 
 PassRefPtr ResourceLoader::resourceData()
 {
-if (m_resourceData)
-return m_resourceData;
-
-if (ResourceHandle::supportsBufferedData() && m_handle)
-return m_handle->bufferedData();
-
-return 0;
+return m_resourceData;
 }
 
 ResourceLoader::ResourceLoader(Frame* frame, ResourceLoaderOptions options)
@@ -202,16 +196,10 @@
 return;
 }
 
-if (ResourceHandle::supportsBufferedData()) {
-// Buffer data only if the connection has handed us the data because is has stopped buffering it.
-if (m_resourceData)
-m_resourceData->append(data, length);
-} else {
-if (!m_resourceData)
-m_resourceData = SharedBuffer::create(data, length);
-else
-m_resourceData->append(data, length);
-}
+if (!m_resourceData)
+m_resourceData = SharedBuffer::create(data, length);
+else
+m_resourceData->append(data, length);
 }
 
 void ResourceLoader::clearResourceData()


Modified: trunk/Source/WebCore/platform/network/ResourceHandle.h (95119 => 95120)

--- trunk/Source/WebCore/platform/network/ResourceHandle.h	2011-09-14 20:59:11 UTC (rev 95119)
+++ trunk/Source/WebCore/platform/network/ResourceHandle.h	2011-09-14 21:03:20 UTC (rev 95120)
@@ -158,9 +158,6 @@
 static void setClientCertificate(const String& host, CFDataRef);
 #endif
 
-PassRefPtr bufferedData();
-static bool supportsBufferedData();
-
 bool shouldContentSniff() const;
 static bool shouldContentSniffURL(const KURL&);
 


Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (95119 => 95120)

--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2011-09-14 20:59:11 UTC (rev 95119)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2011-09-14 21:03:20 UTC (rev 95120)
@@ -526,17 +526,6 @@
 }
 }
 
-PassRefPtr ResourceHandle::bufferedData()
-{
-ASSERT_NOT_REACHED();
-return 0;
-}
-
-bool ResourceHandle::supportsBufferedData()
-{
-return false;
-}
-
 void ResourceHandle::willSendRequest(ResourceRequest& request, const ResourceResponse& redirectResponse)
 {
 

[webkit-changes] [95119] trunk

[ossy]

Title: [95119] trunk








Revision 95119
Author o...@webkit.org
Date 2011-09-14 13:59:11 -0700 (Wed, 14 Sep 2011)


Log Message
[GTK] Unreviewed buildfix after r95107.

* configure.ac:

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (95118 => 95119)

--- trunk/ChangeLog	2011-09-14 20:58:45 UTC (rev 95118)
+++ trunk/ChangeLog	2011-09-14 20:59:11 UTC (rev 95119)
@@ -1,3 +1,9 @@
+2011-09-14  Csaba Osztrogonác  
+
+[GTK] Unreviewed buildfix after r95107.
+
+* configure.ac:
+
 2011-09-13  Eric Seidel  
 
 Remove ENABLE_SVG_USE as  is required by HTML5


Modified: trunk/configure.ac (95118 => 95119)

--- trunk/configure.ac	2011-09-14 20:58:45 UTC (rev 95118)
+++ trunk/configure.ac	2011-09-14 20:59:11 UTC (rev 95119)
@@ -741,7 +741,7 @@
 # check for SVG features, enabling SVG if necessary
 if test "$enable_svg_animation" = "yes" || \
test "$enable_svg_fonts" = "yes" || \
-   test "$enable_svg_as_image" = "yes" || \
+   test "$enable_svg_as_image" = "yes"; then
svg_flags=yes
if test "$enable_svg" = "no"; then
AC_MSG_WARN([SVG feature(s) requested but SVG is disabled.. Enabling SVG support])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95118] trunk/Tools

[rniwa]

Title: [95118] trunk/Tools








Revision 95118
Author rn...@webkit.org
Date 2011-09-14 13:58:45 -0700 (Wed, 14 Sep 2011)


Log Message
committers.py should support multiple IRC nicknames
https://bugs.webkit.org/show_bug.cgi?id=68110

Reviewed by Eric Seidel.

Add multiple IRC nickname support to committers.py

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/committers_unittest.py:
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriff.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py




Diff

Modified: trunk/Tools/ChangeLog (95117 => 95118)

--- trunk/Tools/ChangeLog	2011-09-14 20:51:02 UTC (rev 95117)
+++ trunk/Tools/ChangeLog	2011-09-14 20:58:45 UTC (rev 95118)
@@ -1,3 +1,17 @@
+2011-09-14  Ryosuke Niwa  
+
+committers.py should support multiple IRC nicknames
+https://bugs.webkit.org/show_bug.cgi?id=68110
+
+Reviewed by Eric Seidel.
+
+Add multiple IRC nickname support to committers.py
+
+* Scripts/webkitpy/common/config/committers.py:
+* Scripts/webkitpy/common/config/committers_unittest.py:
+* Scripts/webkitpy/tool/bot/irc_command.py:
+* Scripts/webkitpy/tool/bot/sheriff.py:
+
 2011-09-14  Jon Lee  
 
 Implement globalFlag for WebKitTestRunner


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (95117 => 95118)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-09-14 20:51:02 UTC (rev 95117)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-09-14 20:58:45 UTC (rev 95118)
@@ -29,9 +29,8 @@
 #
 # WebKit's Python module for committer and reviewer validation.
 
-
 class Contributor(object):
-def __init__(self, name, email_or_emails, irc_nickname=None):
+def __init__(self, name, email_or_emails, irc_nickname_or_nicknames=None):
 assert(name)
 assert(email_or_emails)
 self.full_name = name
@@ -39,7 +38,10 @@
 self.emails = [email_or_emails]
 else:
 self.emails = email_or_emails
-self.irc_nickname = irc_nickname
+if isinstance(irc_nickname_or_nicknames, str):
+self.irc_nicknames = [irc_nickname_or_nicknames]
+else:
+self.irc_nicknames = irc_nickname_or_nicknames
 self.can_commit = False
 self.can_review = False
 
@@ -55,8 +57,10 @@
 string = search_string.lower()
 if string in self.full_name.lower():
 return True
-if self.irc_nickname and string in self.irc_nickname.lower():
-return True
+if self.irc_nicknames:
+for nickname in self.irc_nicknames:
+if string in nickname.lower():
+return True
 for email in self.emails:
 if string in email.lower():
 return True
@@ -339,7 +343,7 @@
 Reviewer("Darin Adler", "da...@apple.com", "darin"),
 Reviewer("Darin Fisher", ["fi...@chromium.org", "da...@chromium.org"], "fishd"),
 Reviewer("David Harrison", "harri...@apple.com", "harrison"),
-Reviewer("David Hyatt", "hy...@apple.com", "hyatt"),
+Reviewer("David Hyatt", "hy...@apple.com", ["dhyatt", "hyatt"]),
 Reviewer("David Kilzer", ["ddkil...@webkit.org", "ddkil...@apple.com"], "ddkilzer"),
 Reviewer("David Levin", "le...@chromium.org", "dave_levin"),
 Reviewer("Dean Jackson", "d...@apple.com", "dino"),
@@ -367,7 +371,7 @@
 Reviewer("Joseph Pecoraro", ["joep...@webkit.org", "pecor...@apple.com"], "JoePeck"),
 Reviewer("Justin Garcia", "justin.gar...@apple.com", "justing"),
 Reviewer("Ken Kocienda", "kocie...@apple.com"),
-Reviewer("Kenneth Rohde Christiansen", ["kenn...@webkit.org", "kenneth.christian...@openbossa.org", "kenneth.christian...@gmail.com"], "kenne"),
+Reviewer("Kenneth Rohde Christiansen", ["kenn...@webkit.org", "kenneth.christian...@openbossa.org", "kenneth.christian...@gmail.com"], ["kenne", "kenneth"]),
 Reviewer("Kenneth Russell", "k...@google.com", "kbr_google"),
 Reviewer("Kent Tamura", "tk...@chromium.org", "tkent"),
 Reviewer("Kevin Decker", "kdec...@apple.com", "superkevin"),
@@ -380,13 +384,13 @@
 Reviewer("Mark Rowe", "mr...@apple.com", "bdash"),
 Reviewer("Martin Robinson", ["mrobin...@webkit.org", "mrobin...@igalia.com", "martin.james.robin...@gmail.com"], "mrobinson"),
 Reviewer("Mihai Parparita", "mih...@chromium.org", "mihaip"),
-Reviewer("Nate Chapin", "jap...@chromium.org", "japhet"),
+Reviewer("Nate Chapin", "jap...@chromium.org", ["japhet", "natechapin"]),
 Reviewer("Nikolas Zimmermann", ["zimmerm...@kde.org", "zimmerm...@physik.rwth-aachen.de", "zimmerm...@webkit.org"], "wildfox"),
 Reviewer("Noam Rosenthal", "noam.rosent...@nokia.com", "noamr

[webkit-changes] [95117] trunk/Source/WebCore

[ossy]

Title: [95117] trunk/Source/WebCore








Revision 95117
Author o...@webkit.org
Date 2011-09-14 13:51:02 -0700 (Wed, 14 Sep 2011)


Log Message
REGRESSION: r95108 broke Qt Linux tests
https://bugs.webkit.org/show_bug.cgi?id=68104

Patch by Mark Hahnenberg  on 2011-09-14
Reviewed by Csaba Osztrogonác.

No new tests.

Build fix for Qt tests broken in r95108.

* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
* bridge/qt/qt_runtime.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (95116 => 95117)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 20:48:43 UTC (rev 95116)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 20:51:02 UTC (rev 95117)
@@ -1,3 +1,20 @@
+2011-09-14  Mark Hahnenberg  
+
+REGRESSION: r95108 broke Qt Linux tests
+https://bugs.webkit.org/show_bug.cgi?id=68104
+
+Reviewed by Csaba Osztrogonác.
+
+No new tests.
+
+Build fix for Qt tests broken in r95108.
+
+* bridge/qt/qt_runtime.cpp:
+(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
+(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
+(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
+* bridge/qt/qt_runtime.h:
+
 2011-09-14  James Robinson  
 
 [skia] fast/canvas/setWidthResetAfterForcedRender is flaky


Modified: trunk/Source/WebCore/bridge/qt/qt_runtime.cpp (95116 => 95117)

--- trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2011-09-14 20:48:43 UTC (rev 95116)
+++ trunk/Source/WebCore/bridge/qt/qt_runtime.cpp	2011-09-14 20:51:02 UTC (rev 95117)
@@ -1006,7 +1006,7 @@
 
 const ClassInfo QtRuntimeMethod::s_info = { "QtRuntimeMethod", &InternalFunction::s_info, 0, 0 };
 
-QtRuntimeMethod::QtRuntimeMethod(QtRuntimeMethodData* dd, ExecState* exec, Structure* structure, const Identifier& identifier, PassRefPtr instance)
+QtRuntimeMethod::QtRuntimeMethod(QtRuntimeMethodData* dd, ExecState* exec, Structure* structure, const Identifier& identifier)
 : InternalFunction(exec->lexicalGlobalObject(), structure)
 , d_ptr(dd)
 {
@@ -1426,7 +1426,7 @@
 }
 
 QtRuntimeMetaMethod::QtRuntimeMetaMethod(ExecState* exec, Structure* structure, const Identifier& identifier, PassRefPtr instance, int index, const QByteArray& signature, bool allowPrivate)
-: QtRuntimeMethod (new QtRuntimeMetaMethodData(), exec, structure, identifier, instance)
+: QtRuntimeMethod (new QtRuntimeMetaMethodData(), exec, structure, identifier)
 {
 finishCreation(exec, identifier, instance, index, signature, allowPrivate);
 }
@@ -1576,7 +1576,7 @@
 QMultiMap QtRuntimeConnectionMethod::connections;
 
 QtRuntimeConnectionMethod::QtRuntimeConnectionMethod(ExecState* exec, Structure* structure, const Identifier& identifier, bool isConnect, PassRefPtr instance, int index, const QByteArray& signature)
-: QtRuntimeMethod (new QtRuntimeConnectionMethodData(), exec, structure, identifier, instance)
+: QtRuntimeMethod (new QtRuntimeConnectionMethodData(), exec, structure, identifier)
 {
 finishCreation(exec, identifier, isConnect, instance, index, signature);
 }


Modified: trunk/Source/WebCore/bridge/qt/qt_runtime.h (95116 => 95117)

--- trunk/Source/WebCore/bridge/qt/qt_runtime.h	2011-09-14 20:48:43 UTC (rev 95116)
+++ trunk/Source/WebCore/bridge/qt/qt_runtime.h	2011-09-14 20:51:02 UTC (rev 95117)
@@ -148,7 +148,7 @@
 static const unsigned StructureFlags = OverridesGetOwnPropertySlot | OverridesGetPropertyNames | InternalFunction::StructureFlags | OverridesVisitChildren;
 
 QtRuntimeMethodData *d_func() const {return d_ptr;}
-QtRuntimeMethod(QtRuntimeMethodData *dd, ExecState *, Structure*, const Identifier &name, PassRefPtr);
+QtRuntimeMethod(QtRuntimeMethodData *dd, ExecState *, Structure*, const Identifier &name);
 QtRuntimeMethodData *d_ptr;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95116] trunk/Source/JavaScriptCore

[fpizlo]

Title: [95116] trunk/Source/_javascript_Core








Revision 95116
Author fpi...@apple.com
Date 2011-09-14 13:48:43 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed build fix.  Turn off tiered compilation.

* wtf/Platform.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95115 => 95116)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 20:35:43 UTC (rev 95115)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 20:48:43 UTC (rev 95116)
@@ -1,3 +1,9 @@
+2011-09-14  Filip Pizlo  
+
+Unreviewed build fix.  Turn off tiered compilation.
+
+* wtf/Platform.h:
+
 2011-09-13  Filip Pizlo  
 
 Prediction tracking is not precise enough


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (95115 => 95116)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-14 20:35:43 UTC (rev 95115)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-14 20:48:43 UTC (rev 95116)
@@ -957,7 +957,7 @@
 #endif
 
 #if !defined(ENABLE_TIERED_COMPILATION)
-#define ENABLE_TIERED_COMPILATION 1
+#define ENABLE_TIERED_COMPILATION 0
 #endif
 
 /* Currently only implemented for JSVALUE64, only tested on PLATFORM(MAC) */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95114] trunk/Source/WebCore

[jamesr]

Title: [95114] trunk/Source/WebCore








Revision 95114
Author jam...@google.com
Date 2011-09-14 13:12:19 -0700 (Wed, 14 Sep 2011)


Log Message
[skia] fast/canvas/setWidthResetAfterForcedRender is flaky
https://bugs.webkit.org/show_bug.cgi?id=67955

Reviewed by Stephen White.

When destroying an ImageBuffer due to a canvas resize, we weren't clearing the texture ID on the layer,
resulting in future compositor draw calls binding an invalid texture.  This results in the test failing and
possibly drawing from a bad texture.

Covered by fast/canvas/setWidthResetAfterForcedRender.html in the GPU configuration.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::drawsContent)
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95113 => 95114)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 20:05:19 UTC (rev 95113)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 20:12:19 UTC (rev 95114)
@@ -1,3 +1,21 @@
+2011-09-14  James Robinson  
+
+[skia] fast/canvas/setWidthResetAfterForcedRender is flaky
+https://bugs.webkit.org/show_bug.cgi?id=67955
+
+Reviewed by Stephen White.
+
+When destroying an ImageBuffer due to a canvas resize, we weren't clearing the texture ID on the layer,
+resulting in future compositor draw calls binding an invalid texture.  This results in the test failing and
+possibly drawing from a bad texture.
+
+Covered by fast/canvas/setWidthResetAfterForcedRender.html in the GPU configuration.
+
+* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
+(WebCore::Canvas2DLayerChromium::drawsContent)
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::~ImageBuffer):
+
 2011-09-14  Eric Seidel  
 
 Remove ENABLE_SVG_USE as  is required by HTML5


Modified: trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp (95113 => 95114)

--- trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp	2011-09-14 20:05:19 UTC (rev 95113)
+++ trunk/Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp	2011-09-14 20:12:19 UTC (rev 95114)
@@ -60,7 +60,7 @@
 
 bool Canvas2DLayerChromium::drawsContent() const
 {
-return (m_context
+return m_textureId && (m_context
 && (m_context->getExtensions()->getGraphicsResetStatusARB() == GraphicsContext3D::NO_ERROR));
 }
 


Modified: trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp (95113 => 95114)

--- trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-09-14 20:05:19 UTC (rev 95113)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp	2011-09-14 20:12:19 UTC (rev 95114)
@@ -116,6 +116,10 @@
 
 ImageBuffer::~ImageBuffer()
 {
+#if USE(ACCELERATED_COMPOSITING)
+if (m_data.m_platformLayer)
+m_data.m_platformLayer->setTextureId(0);
+#endif
 if (m_context && m_context->platformContext()) {
 // This is so that the SkGpuDevice destructor has the correct context.
 m_context->platformContext()->makeGrContextCurrent();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95113] trunk/Source/WebKit2

[ap]

Title: [95113] trunk/Source/WebKit2








Revision 95113
Author a...@apple.com
Date 2011-09-14 13:05:19 -0700 (Wed, 14 Sep 2011)


Log Message
Web Process doesn't need a permission to look up WebProcess service any more
https://bugs.webkit.org/show_bug.cgi?id=68101

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb




Diff

Modified: trunk/Source/WebKit2/ChangeLog (95112 => 95113)

--- trunk/Source/WebKit2/ChangeLog	2011-09-14 20:02:55 UTC (rev 95112)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-14 20:05:19 UTC (rev 95113)
@@ -1,3 +1,12 @@
+2011-09-14  Alexey Proskuryakov  
+
+Web Process doesn't need a permission to look up WebProcess service any more
+https://bugs.webkit.org/show_bug.cgi?id=68101
+
+Reviewed by Anders Carlsson.
+
+* WebProcess/com.apple.WebProcess.sb:
+
 2011-09-14  Mark Hahnenberg  
 
 Unzip initialization lists and constructors in JSCell hierarchy (6/7)


Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb (95112 => 95113)

--- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-09-14 20:02:55 UTC (rev 95112)
+++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-09-14 20:05:19 UTC (rev 95113)
@@ -165,7 +165,6 @@
(global-name "com.apple.system.opendirectoryd.api")
(global-name "com.apple.window_proxies")
(global-name "com.apple.windowserver.active")
-   (global-name-regex #"^com\.apple\.WebKit\.WebProcess-")
 
;; FIXME: This should be removed when  is fixed.
(global-name "com.apple.metadata.mds"))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95112] trunk

[eric]

Title: [95112] trunk








Revision 95112
Author e...@webkit.org
Date 2011-09-14 13:02:55 -0700 (Wed, 14 Sep 2011)


Log Message
Remove ENABLE_SVG_USE as  is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019

Reviewed by Ryosuke Niwa.

I missed a couple uses of SVG_USE in my previous patch.

Source/WebCore:

* dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
* svg/SVGUseElement.h:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMImplementation.cpp
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.h
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops




Diff

Modified: trunk/Source/WebCore/ChangeLog (95111 => 95112)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 19:25:46 UTC (rev 95111)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 20:02:55 UTC (rev 95112)
@@ -1,3 +1,19 @@
+2011-09-14  Eric Seidel  
+
+Remove ENABLE_SVG_USE as  is required by HTML5
+https://bugs.webkit.org/show_bug.cgi?id=68019
+
+Reviewed by Ryosuke Niwa.
+
+I missed a couple uses of SVG_USE in my previous patch.
+
+* dom/DOMImplementation.cpp:
+(WebCore::isSVG10Feature):
+(WebCore::isSVG11Feature):
+* svg/SVGUseElement.cpp:
+(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
+* svg/SVGUseElement.h:
+
 2011-09-14  Mark Hahnenberg  
 
 Unzip initialization lists and constructors in JSCell hierarchy (6/7)


Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (95111 => 95112)

--- trunk/Source/WebCore/dom/DOMImplementation.cpp	2011-09-14 19:25:46 UTC (rev 95111)
+++ trunk/Source/WebCore/dom/DOMImplementation.cpp	2011-09-14 20:02:55 UTC (rev 95112)
@@ -72,7 +72,7 @@
 static bool initialized = false;
 DEFINE_STATIC_LOCAL(FeatureSet, svgFeatures, ());
 if (!initialized) {
-#if ENABLE(SVG_USE) && ENABLE(FILTERS) && ENABLE(SVG_FONTS)
+#if ENABLE(FILTERS) && ENABLE(SVG_FONTS)
 addString(svgFeatures, "svg");
 addString(svgFeatures, "svg.static");
 #endif
@@ -80,7 +80,7 @@
 //  addString(svgFeatures, "svg.dynamic");
 //  addString(svgFeatures, "svg.dom.animation");
 //  addString(svgFeatures, "svg.dom.dynamic");
-#if ENABLE(SVG_USE) && ENABLE(FILTERS) && ENABLE(SVG_FONTS)
+#if ENABLE(FILTERS) && ENABLE(SVG_FONTS)
 addString(svgFeatures, "dom");
 addString(svgFeatures, "dom.svg");
 addString(svgFeatures, "dom.svg.static");
@@ -100,7 +100,7 @@
 // Sadly, we cannot claim to implement any of the SVG 1.1 generic feature sets
 // lack of Font and Filter support.
 // http://bugs.webkit.org/show_bug.cgi?id=15480
-#if ENABLE(SVG_USE) && ENABLE(FILTERS) && ENABLE(SVG_FONTS)
+#if ENABLE(FILTERS) && ENABLE(SVG_FONTS)
 addString(svgFeatures, "SVG");
 addString(svgFeatures, "SVGDOM");
 addString(svgFeatures, "SVG-static");
@@ -113,10 +113,8 @@
 //  addString(svgFeatures, "SVG-dynamic);
 //  addString(svgFeatures, "SVGDOM-dynamic);
 addString(svgFeatures, "CoreAttribute");
-#if ENABLE(SVG_USE)
 addString(svgFeatures, "Structure");
 addString(svgFeatures, "BasicStructure");
-#endif
 addString(svgFeatures, "ContainerAttribute");
 addString(svgFeatures, "ConditionalProcessing");
 addString(svgFeatures, "Image");


Modified: trunk/Source/WebCore/svg/SVGUseElement.cpp (95111 => 95112)

--- trunk/Source/WebCore/svg/SVGUseElement.cpp	2011-09-14 19:25:46 UTC (rev 95111)
+++ trunk/Source/WebCore/svg/SVGUseElement.cpp	2011-09-14 20:02:55 UTC (rev 95112)
@@ -567,7 +567,6 @@
 // This also handles the special cases:  on ,  on .
 buildShadowTree(shadowRoot, target, m_targetElementInstance.get());
 
-#if ENABLE(SVG) && ENABLE(SVG_USE)
 // Expand all  elements in the shadow tree.
 // Expand means: replace the actual  element by what it references.
 expandUseElementsInShadowTree(shadowRoot);
@@ -575,7 +574,6 @@
 // Expand all  elements in the shadow tree.
 // Expand means: replace the actual  element by the  element.
 expandSymbolElementsInShadowTree(shadowRoot);
-#endif
 
 // Now that the shadow tree is completly expanded, we can associate
 // shadow tree elements <-> instances in the instance tree.
@@ -822,7 +820,6 @@
 ASSERT(!ec);
 }
 
-#if ENABLE(SVG) && ENABLE(SVG_USE)
 void SVGUseElement::expandUseElementsInShadowTree(Node* element)
 {
 // Why expand the  elements in the shadow tree here, and not just
@@ -936,8 +933,6 @@
 expandSymbolElementsInShadowTree(child.get());
 }
 
-#endif
-
 void SVGUseElement::transferEventListenersToShado

[webkit-changes] [95111] trunk/LayoutTests

[eric . carlson]

Title: [95111] trunk/LayoutTests








Revision 95111
Author eric.carl...@apple.com
Date 2011-09-14 12:25:46 -0700 (Wed, 14 Sep 2011)


Log Message
Update media-controls.js so it can find the timeline slider
https://bugs.webkit.org/show_bug.cgi?id=68034

Don't assume that all elements in the media controller shadow DOM pseudo
elements are siblings.

Reviewed by Darin Adler.

* media/media-controls.js:
(mediaConrolsElement):
(mediaControlsButtonCoordinates):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/media-controls.js




Diff

Modified: trunk/LayoutTests/ChangeLog (95110 => 95111)

--- trunk/LayoutTests/ChangeLog	2011-09-14 19:10:04 UTC (rev 95110)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 19:25:46 UTC (rev 95111)
@@ -1,3 +1,17 @@
+2011-09-14  Eric Carlson  
+
+Update media-controls.js so it can find the timeline slider
+https://bugs.webkit.org/show_bug.cgi?id=68034
+
+Don't assume that all elements in the media controller shadow DOM pseudo
+elements are siblings.
+
+Reviewed by Darin Adler.
+
+* media/media-controls.js:
+(mediaConrolsElement):
+(mediaControlsButtonCoordinates):
+
 2011-09-14  Cary Clark  
 
 Unreviewed; new baselines (Skia on Mac)


Modified: trunk/LayoutTests/media/media-controls.js (95110 => 95111)

--- trunk/LayoutTests/media/media-controls.js	2011-09-14 19:10:04 UTC (rev 95110)
+++ trunk/LayoutTests/media/media-controls.js	2011-09-14 19:25:46 UTC (rev 95111)
@@ -1,17 +1,31 @@
 
-function mediaControlsButtonCoordinates(element, id)
+function mediaControlsElement(first, id)
 {
-var button;
-var controlsShadow = internals.shadowRoot(element).firstChild.firstChild;
-for (child = controlsShadow.firstChild; child; child = child.nextSibling) {
-if (internals.shadowPseudoId(child) == "-webkit-media-controls-" + id) {
-button = child;
-break;
+var controlID = "-webkit-media-controls-" + id;
+for (var element = first; element; element = element.nextSibling) {
+
+// Not every element in the media controls has a shadow pseudo ID, eg. the
+// text nodes for the time values, so guard against exceptions.
+try {
+if (internals.shadowPseudoId(element) == controlID)
+return element;
+} catch (exception) { }
+
+if (element.firstChild) {
+var childElement = mediaControlsElement(element.firstChild, id);
+if (childElement)
+return childElement;
 }
 }
 
+return null;
+}
+
+function mediaControlsButtonCoordinates(element, id)
+{
+var button = mediaControlsElement(internals.shadowRoot(element).firstChild, id);
 if (!button)
-throw "Failed to find button " + id;
+throw "Failed to find media control element ID '" + id + "'";
 
 var buttonBoundingRect = button.getBoundingClientRect();
 var x = buttonBoundingRect.left + buttonBoundingRect.width / 2;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95110] trunk/Source/JavaScriptCore

[ossy]

Title: [95110] trunk/Source/_javascript_Core








Revision 95110
Author o...@webkit.org
Date 2011-09-14 12:10:04 -0700 (Wed, 14 Sep 2011)


Log Message
[Qt] Win32 builds with threads turned off
https://bugs.webkit.org/show_bug.cgi?id=67864

Reviewed by Geoffrey Garen.

* _javascript_Core.pri: Link pthread library on Windows platform.
* wtf/Platform.h: Enable multiple threads.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.pri
trunk/Source/_javascript_Core/wtf/Platform.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95109 => 95110)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 19:00:50 UTC (rev 95109)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 19:10:04 UTC (rev 95110)
@@ -1,3 +1,13 @@
+2011-09-14  Csaba Osztrogonác  
+
+[Qt] Win32 builds with threads turned off
+https://bugs.webkit.org/show_bug.cgi?id=67864
+
+Reviewed by Geoffrey Garen.
+
+* _javascript_Core.pri: Link pthread library on Windows platform.
+* wtf/Platform.h: Enable multiple threads.
+
 2011-09-14  Mark Hahnenberg  
 
 Unzip initialization lists and constructors in JSCell hierarchy (6/7)


Modified: trunk/Source/_javascript_Core/_javascript_Core.pri (95109 => 95110)

--- trunk/Source/_javascript_Core/_javascript_Core.pri	2011-09-14 19:00:50 UTC (rev 95109)
+++ trunk/Source/_javascript_Core/_javascript_Core.pri	2011-09-14 19:10:04 UTC (rev 95110)
@@ -51,6 +51,12 @@
 INCLUDEPATH *= $$MW_LAYER_SYSTEMINCLUDE
 }
 
+win32-g++* {
+LIBS += -lpthreadGC2
+} else:win32-msvc* {
+LIBS += -lpthreadVC2
+}
+
 win32-*: DEFINES += _HAS_TR1=0
 
 DEFINES += BUILDING_JavaScriptCore BUILDING_WTF


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (95109 => 95110)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-14 19:00:50 UTC (rev 95109)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-09-14 19:10:04 UTC (rev 95110)
@@ -509,21 +509,13 @@
 #define WTF_USE_PTHREAD_BASED_QT 1
 #endif
 
-/* FIXME: JSC multithreading currently only supports pthread.
-   Qt-Win cannot do multithreading because it is not pthread-based. */
 #if !defined(ENABLE_JSC_MULTIPLE_THREADS)
-#if !PLATFORM(QT) || USE(PTHREAD_BASED_QT)
 #define ENABLE_JSC_MULTIPLE_THREADS 1
 #endif
-#endif
 
-/* FIXME: JSC multithreading currently only supports pthread.
-   Qt-Win cannot do multithreading because it is not pthread-based. */
 #if !defined(ENABLE_WTF_MULTIPLE_THREADS)
-#if !PLATFORM(QT) || USE(PTHREAD_BASED_QT)
 #define ENABLE_WTF_MULTIPLE_THREADS 1
 #endif
-#endif
 
 /* On Windows, use QueryPerformanceCounter by default */
 #if OS(WINDOWS)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95109] trunk/Tools

[jonlee]

Title: [95109] trunk/Tools








Revision 95109
Author jon...@apple.com
Date 2011-09-14 12:00:50 -0700 (Wed, 14 Sep 2011)


Log Message
Implement globalFlag for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=68033


Reviewed by Sam Weinig.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
(WTR::LayoutTestController::globalFlag): simple getter
(WTR::LayoutTestController::setGlobalFlag): simple setter

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h




Diff

Modified: trunk/Tools/ChangeLog (95108 => 95109)

--- trunk/Tools/ChangeLog	2011-09-14 18:55:25 UTC (rev 95108)
+++ trunk/Tools/ChangeLog	2011-09-14 19:00:50 UTC (rev 95109)
@@ -1,3 +1,18 @@
+2011-09-14  Jon Lee  
+
+Implement globalFlag for WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=68033
+
+
+Reviewed by Sam Weinig.
+
+* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
+* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+(WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
+* WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
+(WTR::LayoutTestController::globalFlag): simple getter
+(WTR::LayoutTestController::setGlobalFlag): simple setter
+
 2011-09-13  Eric Seidel  
 
 Remove ENABLE_SVG_USE as  is required by HTML5


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl (95108 => 95109)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2011-09-14 18:55:25 UTC (rev 95108)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl	2011-09-14 19:00:50 UTC (rev 95109)
@@ -66,6 +66,9 @@
 DOMString markerTextForListItem(in object element);
 unsigned long windowCount();
 
+// Special DOM variables.
+attribute boolean globalFlag;
+
 // Repaint testing.
 void testRepaint();
 void repaintSweepHorizontally();


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (95108 => 95109)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2011-09-14 18:55:25 UTC (rev 95108)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp	2011-09-14 19:00:50 UTC (rev 95109)
@@ -106,6 +106,7 @@
 , m_willSendRequestReturnsNull(false)
 , m_policyDelegateEnabled(false)
 , m_policyDelegatePermissive(false)
+, m_globalFlag(false)
 {
 platformInitialize();
 }


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h (95108 => 95109)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2011-09-14 18:55:25 UTC (rev 95108)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h	2011-09-14 19:00:50 UTC (rev 95109)
@@ -169,6 +169,9 @@
 void setTextDirection(JSStringRef);
 
 void setShouldStayOnPageAfterHandlingBeforeUnload(bool);
+
+bool globalFlag() const { return m_globalFlag; }
+void setGlobalFlag(bool value) { m_globalFlag = value; }
 
 private:
 static const double waitToDumpWatchdogTimerInterval;
@@ -198,6 +201,8 @@
 
 bool m_policyDelegateEnabled;
 bool m_policyDelegatePermissive;
+
+bool m_globalFlag;
 
 PlatformTimerRef m_waitToDumpWatchdogTimer;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95107] trunk

[eric]

Title: [95107] trunk








Revision 95107
Author e...@webkit.org
Date 2011-09-14 11:49:16 -0700 (Wed, 14 Sep 2011)


Log Message
Remove ENABLE_SVG_USE as  is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019

Reviewed by Ryosuke Niwa.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* features.pri:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* waf/build/settings.py:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/features.pri
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsEfl.cmake
trunk/Source/cmake/OptionsWinCE.cmake
trunk/Source/cmakeconfig.h.cmake
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/waf/build/settings.py
trunk/WebKitLibraries/ChangeLog
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
trunk/WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (95106 => 95107)

--- trunk/ChangeLog	2011-09-14 18:47:34 UTC (rev 95106)
+++ trunk/ChangeLog	2011-09-14 18:49:16 UTC (rev 95107)
@@ -1,5 +1,17 @@
 2011-09-13  Eric Seidel  
 
+Remove ENABLE_SVG_USE as  is required by HTML5
+https://bugs.webkit.org/show_bug.cgi?id=68019
+
+Reviewed by Ryosuke Niwa.
+
+* Source/cmake/OptionsEfl.cmake:
+* Source/cmake/OptionsWinCE.cmake:
+* Source/cmakeconfig.h.cmake:
+* configure.ac:
+
+2011-09-13  Eric Seidel  
+
 Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
 https://bugs.webkit.org/show_bug.cgi?id=68018
 


Modified: trunk/Source/_javascript_Core/ChangeLog (95106 => 95107)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 18:47:34 UTC (rev 95106)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 18:49:16 UTC (rev 95107)
@@ -1,3 +1,12 @@
+2011-09-13  Eric Seidel  
+
+Remove ENABLE_SVG_USE as  is required by HTML5
+https://bugs.webkit.org/show_bug.cgi?id=68019
+
+Reviewed by Ryosuke Niwa.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2011-09-14  Iain Merrick  
 
 HashTraits.h should include template specialization for WTF::String


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (95106 => 95107)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-09-14 18:47:34 UTC (rev 95106)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2011-09-14 18:49:16 UTC (rev 95107)
@@ -87,7 +87,6 @@
 ENABLE_SVG_ANIMATION = ENABLE_SVG_ANIMATION;
 ENABLE_SVG_AS_IMAGE = ENABLE_SVG_AS_IMAGE;
 ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
-ENABLE_SVG_USE = ENABLE_SVG_USE;
 ENABLE_TOUCH_ICON_LOADING = ;
 ENABLE_VIDEO = ENABLE_VIDEO;
 ENABLE_VIDEO_TRACK = ;
@@ -100,4 +99,4 @@
 ENABLE_XPATH = ENABLE_XPATH;
 ENABLE_XSLT = ENABLE_XSLT;
 
-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_REGIONS) $(ENABLE_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_DOM_STORAGE) $(ENABLE_EVENTSOURCE) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_SVG_USE) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_S

[webkit-changes] [95106] trunk/LayoutTests

[caryclark]

Title: [95106] trunk/LayoutTests








Revision 95106
Author carycl...@google.com
Date 2011-09-14 11:47:34 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed; new baselines (Skia on Mac)
Updated reference images (missed this one on the prior land)

   * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (95105 => 95106)

--- trunk/LayoutTests/ChangeLog	2011-09-14 18:46:19 UTC (rev 95105)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 18:47:34 UTC (rev 95106)
@@ -1,6 +1,13 @@
 2011-09-14  Cary Clark  
 
 Unreviewed; new baselines (Skia on Mac)
+Updated reference images (missed this one on the prior land)
+
+   * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
+
+2011-09-14  Cary Clark  
+
+Unreviewed; new baselines (Skia on Mac)
 Updated reference images.
 
* platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.


Added: trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95105] trunk/LayoutTests

[caryclark]

Title: [95105] trunk/LayoutTests








Revision 95105
Author carycl...@google.com
Date 2011-09-14 11:46:19 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed; new baselines (Skia on Mac)
Updated reference images.

   * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.
   * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (95104 => 95105)

--- trunk/LayoutTests/ChangeLog	2011-09-14 18:41:32 UTC (rev 95104)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 18:46:19 UTC (rev 95105)
@@ -1,3 +1,11 @@
+2011-09-14  Cary Clark  
+
+Unreviewed; new baselines (Skia on Mac)
+Updated reference images.
+
+   * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.
+   * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
+
 2011-09-14  Eric Carlson  
 
 video-error-abort.html shouldn't be in Mac skipped list


Deleted: trunk/LayoutTests/platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95104] trunk/Source/WebCore

[eric . carlson]

Title: [95104] trunk/Source/WebCore








Revision 95104
Author eric.carl...@apple.com
Date 2011-09-14 11:41:32 -0700 (Wed, 14 Sep 2011)


Log Message
MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=68056

MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants
periodic callbacks, but because a time observer also fires whenever a seek completes. This is 
no longer necessary because it now uses but AVPlayerItem's 
-seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are
always notified.

Reviewed by Darin Adler.

No new tests, code removed is tested by existing tests.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (95103 => 95104)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 18:35:49 UTC (rev 95103)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 18:41:32 UTC (rev 95104)
@@ -1,3 +1,21 @@
+2011-09-14  Eric Carlson  
+
+MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
+https://bugs.webkit.org/show_bug.cgi?id=68056
+
+MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants
+periodic callbacks, but because a time observer also fires whenever a seek completes. This is 
+no longer necessary because it now uses but AVPlayerItem's 
+-seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are
+always notified.
+
+Reviewed by Darin Adler.
+
+No new tests, code removed is tested by existing tests.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
+
 2011-09-14  Beth Dakin  
 
 https://bugs.webkit.org/show_bug.cgi?id=68054


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (95103 => 95104)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2011-09-14 18:35:49 UTC (rev 95103)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2011-09-14 18:41:32 UTC (rev 95104)
@@ -105,7 +105,6 @@
 -(void)disconnect;
 -(void)playableKnown;
 -(void)metadataLoaded;
--(void)timeChanged:(double)time;
 -(void)seekCompleted:(BOOL)finished;
 -(void)didEnd:(NSNotification *)notification;
 -(void)observeValueForKeyPath:keyPath ofObject:(id)object change:(NSDictionary *)change context:(MediaPlayerAVFoundationObservationContext)context;
@@ -280,14 +279,6 @@
 m_avPlayer.adoptNS([[AVPlayer alloc] init]);
 [m_avPlayer.get() addObserver:m_objcObserver.get() forKeyPath:@"rate" options:nil context:(void *)MediaPlayerAVFoundationObservationContextPlayer];
 
-// Add a time observer, ask to be called infrequently because we don't really want periodic callbacks but
-// our observer will also be called whenever a seek happens.
-const double veryLongInterval = 60 * 60 * 24 * 30;
-WebCoreAVFMovieObserver *observer = m_objcObserver.get();
-m_timeObserver = [m_avPlayer.get() addPeriodicTimeObserverForInterval:CMTimeMakeWithSeconds(veryLongInterval, 10) queue:nil usingBlock:^(CMTime time){
-[observer timeChanged:CMTimeGetSeconds(time)];
-}];
-
 if (m_avPlayerItem)
 [m_avPlayer.get() replaceCurrentItemWithPlayerItem:m_avPlayerItem.get()];
 
@@ -842,14 +833,6 @@
 m_callback->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::AssetPlayabilityKnown);
 }
 
-- (void)timeChanged:(double)time
-{
-if (!m_callback)
-return;
-
-m_callback->scheduleMainThreadNotification(MediaPlayerPrivateAVFoundation::Notification::PlayerTimeChanged, time);
-}
-
 - (void)seekCompleted:(BOOL)finished
 {
 if (!m_callback)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95103] trunk/Source/WebCore

[bdakin]

Title: [95103] trunk/Source/WebCore








Revision 95103
Author bda...@apple.com
Date 2011-09-14 11:35:49 -0700 (Wed, 14 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=68054
Return an image scale factor as well as an Image* from CachedImage::brokenImage()

Reviewed by Darin Adler.

CachedImage::brokenImage() now returns a pair where the float 
represents the image's scale factor. This is important because currently, the 
broken image will either be only 1x or 2x, but a deviceScaleFactor could 
theoretically be something different (1.5, 3, etc). So it is not safe to assume 
that the image's scale factor is equivalent to the deviceScaleFactor, and 
hardcoding 2 for now is lame.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):
* loader/cache/CachedImage.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedImage.cpp
trunk/Source/WebCore/loader/cache/CachedImage.h
trunk/Source/WebCore/rendering/RenderImage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95102 => 95103)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 18:27:23 UTC (rev 95102)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 18:35:49 UTC (rev 95103)
@@ -1,3 +1,24 @@
+2011-09-14  Beth Dakin  
+
+https://bugs.webkit.org/show_bug.cgi?id=68054
+Return an image scale factor as well as an Image* from CachedImage::brokenImage()
+
+Reviewed by Darin Adler.
+
+CachedImage::brokenImage() now returns a pair where the float 
+represents the image's scale factor. This is important because currently, the 
+broken image will either be only 1x or 2x, but a deviceScaleFactor could 
+theoretically be something different (1.5, 3, etc). So it is not safe to assume 
+that the image's scale factor is equivalent to the deviceScaleFactor, and 
+hardcoding 2 for now is lame.
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::brokenImage):
+(WebCore::CachedImage::image):
+* loader/cache/CachedImage.h:
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+(WebCore::RenderImage::paintReplaced):
+
 2011-09-14  James Robinson  
 
 [chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost


Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (95102 => 95103)

--- trunk/Source/WebCore/loader/cache/CachedImage.cpp	2011-09-14 18:27:23 UTC (rev 95102)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp	2011-09-14 18:35:49 UTC (rev 95103)
@@ -113,15 +113,15 @@
 m_decodedDataDeletionTimer.startOneShot(interval);
 }
 
-Image* CachedImage::brokenImage(float deviceScaleFactor) const
+pair CachedImage::brokenImage(float deviceScaleFactor) const
 {
 if (deviceScaleFactor >= 2) {
 DEFINE_STATIC_LOCAL(Image*, brokenImageHiRes, (Image::loadPlatformResource("missingImage@2x").leakRef()));
-return brokenImageHiRes;
+return make_pair(brokenImageHiRes, 2);
 }
 
 DEFINE_STATIC_LOCAL(Image*, brokenImageLoRes, (Image::loadPlatformResource("missingImage").leakRef()));
-return brokenImageLoRes;
+return make_pair(brokenImageLoRes, 1);
 }
 
 bool CachedImage::willPaintBrokenImage() const
@@ -137,7 +137,7 @@
 // Returning the 1x broken image is non-ideal, but we cannot reliably access the appropriate
 // deviceScaleFactor from here. It is critical that callers use CachedImage::brokenImage() 
 // when they need the real, deviceScaleFactor-appropriate broken image icon. 
-return brokenImage(1);
+return brokenImage(1).first;
 }
 
 if (m_image)


Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (95102 => 95103)

--- trunk/Source/WebCore/loader/cache/CachedImage.h	2011-09-14 18:27:23 UTC (rev 95102)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h	2011-09-14 18:35:49 UTC (rev 95103)
@@ -47,7 +47,7 @@
 Image* image() const; // Returns the nullImage() if the image is not available yet.
 bool hasImage() const { return m_image.get(); }
 
-Image* brokenImage(float deviceScaleFactor) const;
+std::pair brokenImage(float deviceScaleFactor) const; // Returns an image and the image's resolution scale factor.
 bool willPaintBrokenImage() const; 
 
 bool canRender(float multiplier) const { return !errorOccurred() && !imageSize(multiplier).isEmpty(); }


Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (95102 => 95103)

--- trunk/Source/WebCore/rendering/RenderImage.cpp	2011-09-14 18:27:23 UTC (rev 95102)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp	2011-09-14 18:35:49 UTC (rev 95103)
@@ -87,16 +87,9 @@
 IntSize imageSize;
 if (newImage->willPaintBrokenImage()) {
 float deviceScaleFactor = Page::deviceScaleFactor(frame());
-imageSize

[webkit-changes] [95102] trunk/LayoutTests

[eric . carlson]

Title: [95102] trunk/LayoutTests








Revision 95102
Author eric.carl...@apple.com
Date 2011-09-14 11:27:23 -0700 (Wed, 14 Sep 2011)


Log Message
video-error-abort.html shouldn't be in Mac skipped list
https://bugs.webkit.org/show_bug.cgi?id=68053
 Test media/video-error-abort.html doesn't work

Reviewed by Darin Adler.

* platform/mac/Skipped: Remove http/tests/media/video-error-abort.html from the mac
skipped list.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (95101 => 95102)

--- trunk/LayoutTests/ChangeLog	2011-09-14 18:05:00 UTC (rev 95101)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 18:27:23 UTC (rev 95102)
@@ -1,3 +1,14 @@
+2011-09-14  Eric Carlson  
+
+video-error-abort.html shouldn't be in Mac skipped list
+https://bugs.webkit.org/show_bug.cgi?id=68053
+ Test media/video-error-abort.html doesn't work
+
+Reviewed by Darin Adler.
+
+* platform/mac/Skipped: Remove http/tests/media/video-error-abort.html from the mac
+skipped list.
+
 2011-09-14  Stephen White  
 
 [chromium] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/mac/Skipped (95101 => 95102)

--- trunk/LayoutTests/platform/mac/Skipped	2011-09-14 18:05:00 UTC (rev 95101)
+++ trunk/LayoutTests/platform/mac/Skipped	2011-09-14 18:27:23 UTC (rev 95102)
@@ -41,9 +41,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=21913 Repaint pixel test failure
 fast/repaint/body-background-image.html
 
-#  Test media/video-error-abort.html doesn't work
-http/tests/media/video-error-abort.html
-
 # This port doesn't support Notifications.
 fast/notifications
 http/tests/notifications






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95099] trunk

[hyatt]

Title: [95099] trunk








Revision 95099
Author hy...@apple.com
Date 2011-09-14 10:58:11 -0700 (Wed, 14 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=68040

Make sure border image sub-properties can be specified in any order.

Reviewed by Beth Dakin.

Source/WebCore: 

New tests in fast/borders.

* css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
* css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):

LayoutTests: 

* fast/borders/border-image-scrambled.html: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParserValues.h


Added Paths

trunk/LayoutTests/fast/borders/border-image-scrambled.html
trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.png
trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95098 => 95099)

--- trunk/LayoutTests/ChangeLog	2011-09-14 17:16:38 UTC (rev 95098)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 17:58:11 UTC (rev 95099)
@@ -1,3 +1,15 @@
+2011-09-14  David Hyatt  
+
+https://bugs.webkit.org/show_bug.cgi?id=68040
+
+Make sure border image sub-properties can be specified in any order.
+
+Reviewed by Beth Dakin.
+
+* fast/borders/border-image-scrambled.html: Added.
+* platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
+* platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.
+
 2011-09-13  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=68050


Added: trunk/LayoutTests/fast/borders/border-image-scrambled.html (0 => 95099)

--- trunk/LayoutTests/fast/borders/border-image-scrambled.html	(rev 0)
+++ trunk/LayoutTests/fast/borders/border-image-scrambled.html	2011-09-14 17:58:11 UTC (rev 95099)
@@ -0,0 +1,36 @@
+
+
+
+div {
+border-width: 21px 30px 30px 21px;
+width: 75px;
+height: 75px;
+margin: 10px;
+display: inline-block;
+}
+
+div.rr {
+-webkit-border-image: url("resources/border-image.png") 21 30 30 21 repeat repeat;
+}
+
+div.rs {
+-webkit-border-image: 21 30 30 21 url("resources/border-image.png") repeat stretch;
+}
+
+div.sr {
+-webkit-border-image: stretch repeat 21 30 30 21 url("resources/border-image.png");
+}
+
+div.ss {
+-webkit-border-image: url("resources/border-image.png") stretch stretch 21 30 30 21;
+}
+
+
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.txt (0 => 95099)

--- trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/fast/borders/border-image-scrambled-expected.txt	2011-09-14 17:58:11 UTC (rev 95099)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+  RenderBlock {DIV} at (10,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+  RenderText {#text} at (146,132) size 4x18
+text run at (146,132) width 4: " "
+  RenderBlock {DIV} at (160,10) size 126x126 [border: (21px none #00) (30px none #00) (21px none #00)]
+  RenderText {#text} at (296,132) size 4x18
+text run at (296,1

[webkit-changes] [95101] trunk/LayoutTests

[senorblanco]

Title: [95101] trunk/LayoutTests








Revision 95101
Author senorbla...@chromium.org
Date 2011-09-14 11:05:00 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] Unreviewed gardening.

Removing fast/canvas/setWidthResetAfterForcedRender.html from
test_expectations, since it has been passing on the Mesa bots 
(last failure was at r94962).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95100 => 95101)

--- trunk/LayoutTests/ChangeLog	2011-09-14 18:02:27 UTC (rev 95100)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 18:05:00 UTC (rev 95101)
@@ -1,3 +1,11 @@
+2011-09-14  Stephen White  
+
+[chromium] Unreviewed gardening.
+
+Removing fast/canvas/setWidthResetAfterForcedRender.html from
+test_expectations, since it has been passing on the Mesa bots 
+(last failure was at r94962).
+
 2011-09-14  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=68040


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95100 => 95101)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 18:02:27 UTC (rev 95100)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 18:05:00 UTC (rev 95101)
@@ -3667,9 +3667,6 @@
 // Failing after r93982.
 BUG_LEVIN MAC : canvas/philip/tests/2d.path.stroke.prune.arc.html = TEXT
 
-// Failing after r93988.
-BUGWK67144 GPU WIN LINUX : fast/canvas/setWidthResetAfterForcedRender.html = IMAGE
-
 // Failing after r94084. This looks like it may be a real regression.
 BUG_LEVIN : css2.1/t090204-display-change-01-b-ao.html = IMAGE+TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95098] trunk/Tools

[rniwa]

Title: [95098] trunk/Tools








Revision 95098
Author rn...@webkit.org
Date 2011-09-14 10:16:38 -0700 (Wed, 14 Sep 2011)


Log Message
Remove Jan Erik Hanssen (added in my r95078) from the list for now
since I can't confirm acceptable his committership.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (95097 => 95098)

--- trunk/Tools/ChangeLog	2011-09-14 17:04:12 UTC (rev 95097)
+++ trunk/Tools/ChangeLog	2011-09-14 17:16:38 UTC (rev 95098)
@@ -1,3 +1,10 @@
+2011-09-14  Ryosuke Niwa  
+
+Remove Jan Erik Hanssen (added in my r95078) from the list for now
+since I can't confirm acceptable his committership.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-09-14  Jochen Eisinger  
 
 [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (95097 => 95098)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-09-14 17:04:12 UTC (rev 95097)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-09-14 17:16:38 UTC (rev 95098)
@@ -197,7 +197,6 @@
 Committer("James Hawkins", ["jhawk...@chromium.org", "jhawk...@google.com"], "jhawkins"),
 Committer("James Kozianski", ["k...@chromium.org", "k...@google.com"], "koz"),
 Committer("James Simonsen", "simon...@chromium.org", "simonjam"),
-Committer("Jan Erik Hanssen", "jhans...@sencha.com", "jehanssen"),
 Committer("Jay Civelli", "jcive...@chromium.org", "jcivelli"),
 Committer("Jeff Miller", "je...@apple.com", "jeffm7"),
 Committer("Jeffrey Pfau", ["jeff...@endrift.com", "jp...@apple.com"], "jpfau"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95097] trunk/Source/WebCore

[reed]

Title: [95097] trunk/Source/WebCore








Revision 95097
Author r...@google.com
Date 2011-09-14 10:04:12 -0700 (Wed, 14 Sep 2011)


Log Message
query SystemParametersInfo for GDI font smoothing settings
https://bugs.webkit.org/show_bug.cgi?id=68080

Reviewed by Stephen White.

No new tests. fixes antialiasing issues based on User settings

* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95096 => 95097)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 16:45:23 UTC (rev 95096)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 17:04:12 UTC (rev 95097)
@@ -1,3 +1,16 @@
+2011-09-14  Mike Reed  
+
+query SystemParametersInfo for GDI font smoothing settings
+https://bugs.webkit.org/show_bug.cgi?id=68080
+
+Reviewed by Stephen White.
+
+No new tests. fixes antialiasing issues based on User settings
+
+* platform/graphics/skia/SkiaFontWin.cpp:
+(WebCore::getDefaultGDITextFlags):
+(WebCore::setupPaintForFont):
+
 2011-09-13  David Hyatt  
 
 https://bugs.webkit.org/show_bug.cgi?id=68050


Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (95096 => 95097)

--- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp	2011-09-14 16:45:23 UTC (rev 95096)
+++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp	2011-09-14 17:04:12 UTC (rev 95097)
@@ -99,6 +99,29 @@
|| skiaContext->isDrawingToImageBuffer();
 }
 
+// Lookup the current system settings for font smoothing.
+// We cache these values for performance, but if the browser has away to be
+// notified when these change, we could re-query them at that time.
+static uint32_t getDefaultGDITextFlags()
+{
+static bool gInited;
+static uint32_t gFlags;
+if (!gInited) {
+BOOL enabled;
+if (SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, &enabled, 0) && enabled) {
+gFlags |= SkPaint::kAntiAlias_Flag;
+
+UINT smoothType;
+if (SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, &smoothType, 0)) {
+if (FE_FONTSMOOTHINGCLEARTYPE == smoothType)
+gFlags |= SkPaint::kLCDRenderText_Flag;
+}
+}
+gInited = true;
+}
+return gFlags;
+}
+
 static void setupPaintForFont(HFONT hfont, SkPaint* paint, PlatformContextSkia* pcs)
 {
 //  FIXME:
@@ -118,24 +141,30 @@
 SkSafeUnref(face);
 
 uint32_t flags = paint->getFlags();
-// our defaults
-flags |= SkPaint::kAntiAlias_Flag;
-if (disableTextLCD(pcs))
-flags &= ~SkPaint::kLCDRenderText_Flag;
-else
-flags |= SkPaint::kLCDRenderText_Flag;
+// clear our flags initially, and then selectively set them
+// based on the LOGFONT quality
+flags &= SkPaint::kAntiAlias_Flag;
+flags &= SkPaint::kLCDRenderText_Flag;
 
 switch (info.lfQuality) {
 case NONANTIALIASED_QUALITY:
-flags &= ~SkPaint::kAntiAlias_Flag;
-flags &= ~SkPaint::kLCDRenderText_Flag;
 break;
 case ANTIALIASED_QUALITY:
-flags &= ~SkPaint::kLCDRenderText_Flag;
+flags |= SkPaint::kAntiAlias_Flag;
 break;
+case CLEARTYPE_QUALITY:
+flags |= SkPaint::kAntiAlias_Flag;
+flags |= SkPaint::kLCDRenderText_Flag;
+break;
 default:
+flags |= getDefaultGDITextFlags();
 break;
 }
+
+// do this check after our switch on lfQuality
+if (disableTextLCD(pcs))
+flags &= ~SkPaint::kLCDRenderText_Flag;
+
 paint->setFlags(flags);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95096] trunk

[hyatt]

Title: [95096] trunk








Revision 95096
Author hy...@apple.com
Date 2011-09-14 09:45:23 -0700 (Wed, 14 Sep 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=68050

Regressions in some layout tests from making border/mask/reflection nine-piece-image
parsing match the spec, which allows any of the pieces to be omitted and to also be
specifiable in any order.

When the higher level code suddenly allowed the image slices to be omitted, the fixup
for legacy compatibility for reflections and masks in the parseBorderImageSlice function
no longer happened because that function no longer got called.

The fix is to properly set the defaults to include the "fill" keyword, so the fixup is
applied to the NinePieceImages you create before you ever map anything in from the rules.

This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as
"0 fill" instead of just "0", which is the correct initial value for this property.

Reviewed by Adam Roben.

Source/WebCore: 

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageSlice):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleReflection.h:
(WebCore::StyleReflection::StyleReflection):

LayoutTests: 

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/rendering/style/NinePieceImage.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp
trunk/Source/WebCore/rendering/style/StyleReflection.h




Diff

Modified: trunk/LayoutTests/ChangeLog (95095 => 95096)

--- trunk/LayoutTests/ChangeLog	2011-09-14 16:27:27 UTC (rev 95095)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 16:45:23 UTC (rev 95096)
@@ -1,3 +1,27 @@
+2011-09-13  David Hyatt  
+
+https://bugs.webkit.org/show_bug.cgi?id=68050
+
+Regressions in some layout tests from making border/mask/reflection nine-piece-image
+parsing match the spec, which allows any of the pieces to be omitted and to also be
+specifiable in any order.
+
+When the higher level code suddenly allowed the image slices to be omitted, the fixup
+for legacy compatibility for reflections and masks in the parseBorderImageSlice function
+no longer happened because that function no longer got called.
+
+The fix is to properly set the defaults to include the "fill" keyword, so the fixup is
+applied to the NinePieceImages you create before you ever map anything in from the rules.
+
+This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as
+"0 fill" instead of just "0", which is the correct initial value for this property.
+
+Reviewed by Adam Roben.
+
+* fast/css/getComputedStyle/computed-style-expected.txt:
+* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* svg/css/getComputedStyle-basic-expected.txt:
+
 2011-09-14  Ilya Tikhonovsky  
 
 Unreviewed. timeline-animation-frame.html was marked as TEXT.


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (95095 => 95096)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2011-09-14 16:27:27 UTC (rev 95095)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2011-09-14 16:45:23 UTC (rev 95096)
@@ -162,7 +162,7 @@
 -webkit-mask-box-image: none;
 -webkit-mask-box-image-outset: 0px;
 -webkit-mask-box-image-repeat: stretch;
--webkit-mask-box-image-slice: 0;
+-webkit-mask-box-image-slice: 0 fill;
 -webkit-mask-box-image-source: none;
 -webkit-mask-box-image-width: auto;
 -webkit-mask-clip: border-box;


Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (95095 => 95096)

--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2011-09-14 16:27:27 UTC (rev 95095)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2011-09-14 16:45:23 UTC (rev 95096)
@@ -161,7 +161,7 @@
 -webkit-mask-box-image: none
 -webkit-mask-box-image-outset: 0px
 -webkit-mask-box-image-repeat: stretch
--webkit-mask-box-image-slice: 0
+-webkit-mask-box-image-slice: 0 fill
 -webkit-mask-box-image-source: none
 -webkit-mask-box-image-width: aut

[webkit-changes] [95095] trunk/LayoutTests

[loislo]

Title: [95095] trunk/LayoutTests








Revision 95095
Author loi...@chromium.org
Date 2011-09-14 09:27:27 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed. timeline-animation-frame.html was marked as TEXT.

* platform/qt/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95094 => 95095)

--- trunk/LayoutTests/ChangeLog	2011-09-14 15:54:08 UTC (rev 95094)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 16:27:27 UTC (rev 95095)
@@ -1,5 +1,11 @@
 2011-09-14  Ilya Tikhonovsky  
 
+Unreviewed. timeline-animation-frame.html was marked as TEXT.
+
+* platform/qt/test_expectations.txt:
+
+2011-09-14  Ilya Tikhonovsky  
+
 Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.
 
 * platform/qt/test_expectations.txt:


Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (95094 => 95095)

--- trunk/LayoutTests/platform/qt/test_expectations.txt	2011-09-14 15:54:08 UTC (rev 95094)
+++ trunk/LayoutTests/platform/qt/test_expectations.txt	2011-09-14 16:27:27 UTC (rev 95095)
@@ -27,4 +27,4 @@
 BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH
 BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH
 
-BUG_LOISLO : inspector/timeline/timeline-animation-frame.html = TIMEOUT
+BUG_LOISLO : inspector/timeline/timeline-animation-frame.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95094] trunk/LayoutTests

[loislo]

Title: [95094] trunk/LayoutTests








Revision 95094
Author loi...@chromium.org
Date 2011-09-14 08:54:08 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.

* platform/qt/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95093 => 95094)

--- trunk/LayoutTests/ChangeLog	2011-09-14 15:09:56 UTC (rev 95093)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 15:54:08 UTC (rev 95094)
@@ -1,5 +1,11 @@
 2011-09-14  Ilya Tikhonovsky  
 
+Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.
+
+* platform/qt/test_expectations.txt:
+
+2011-09-14  Ilya Tikhonovsky  
+
 Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
 https://bugs.webkit.org/show_bug.cgi?id=67986
 


Modified: trunk/LayoutTests/platform/qt/test_expectations.txt (95093 => 95094)

--- trunk/LayoutTests/platform/qt/test_expectations.txt	2011-09-14 15:09:56 UTC (rev 95093)
+++ trunk/LayoutTests/platform/qt/test_expectations.txt	2011-09-14 15:54:08 UTC (rev 95094)
@@ -26,3 +26,5 @@
 BUGWK67007 DEBUG : fast/ruby/after-table-doesnt-crash.html = CRASH
 BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH
 BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH
+
+BUG_LOISLO : inspector/timeline/timeline-animation-frame.html = TIMEOUT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95093] trunk/Source/WebCore

[pfeldman]

Title: [95093] trunk/Source/WebCore








Revision 95093
Author pfeld...@chromium.org
Date 2011-09-14 08:09:56 -0700 (Wed, 14 Sep 2011)


Log Message
2011-09-13  Pavel Feldman  

Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
https://bugs.webkit.org/show_bug.cgi?id=67997

We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.

This change wipes out frame binding from the inspector upon detach rather
than destroy.

Reviewed by Tony Gentilcore.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDetachedImpl):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameDetached):
* inspector/InspectorPageAgent.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::detachFromPage):
* page/Frame.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95092 => 95093)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 14:59:46 UTC (rev 95092)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 15:09:56 UTC (rev 95093)
@@ -1,3 +1,31 @@
+2011-09-13  Pavel Feldman  
+
+Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
+https://bugs.webkit.org/show_bug.cgi?id=67997
+
+We should not instrument frameDestroyed event from within Frame's destructor
+since frame's m_page pointer is likely to be 0 by that time and appropriate
+instrumenting agent won't be found. As a result, stale frame with its id
+end up in the inspector.
+
+This change wipes out frame binding from the inspector upon detach rather
+than destroy.
+
+Reviewed by Tony Gentilcore.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::frameDetachedImpl):
+* inspector/InspectorInstrumentation.h:
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::frameDetached):
+* inspector/InspectorPageAgent.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::detachFromParent):
+* page/Frame.cpp:
+(WebCore::Frame::~Frame):
+(WebCore::Frame::detachFromPage):
+* page/Frame.h:
+
 2011-09-14  Pavel Feldman  
 
 Not reviewed: rolling out r95089.


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (95092 => 95093)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 14:59:46 UTC (rev 95092)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 15:09:56 UTC (rev 95093)
@@ -660,12 +660,6 @@
 pageAgent->frameNavigated(loader);
 }
 
-void InspectorInstrumentation::frameDestroyedImpl(InstrumentingAgents* instrumentingAgents, Frame* frame)
-{
-if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())
-inspectorPageAgent->frameDestroyed(frame);
-}
-
 void InspectorInstrumentation::loaderDetachedFromFrameImpl(InstrumentingAgents* instrumentingAgents, DocumentLoader* loader)
 {
 if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (95092 => 95093)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2011-09-14 14:59:46 UTC (rev 95092)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2011-09-14 15:09:56 UTC (rev 95093)
@@ -142,7 +142,6 @@
 static void loadEventFired(Frame*, const KURL&);
 static void frameDetachedFromParent(Frame*);
 static void didCommitLoad(Frame*, DocumentLoader*);
-static void frameDestroyed(Frame*);
 static void loaderDetachedFromFrame(Frame*, DocumentLoader*);
 
 static InspectorInstrumentationCookie willWriteHTML(Document*, unsigned int length, unsigned int startLine);
@@ -277,7 +276,6 @@
 static void loadEventFiredImpl(InstrumentingAgents*, Frame*, const KURL&);
 static void frameDetachedFromParentImpl(InstrumentingAgents*, Frame*);
 static void didCommitLoadImpl(InstrumentingAgents*, Page*, DocumentLoader*);
-static void frameDestroyedImpl(InstrumentingAgents*, Frame*);
 static void loaderDetachedFromFrameImpl(InstrumentingAgents*, DocumentLoader*);
 
 static I

[webkit-changes] [95092] trunk/Source/WebCore

[pfeldman]

Title: [95092] trunk/Source/WebCore








Revision 95092
Author pfeld...@chromium.org
Date 2011-09-14 07:59:46 -0700 (Wed, 14 Sep 2011)


Log Message
2011-09-14  Pavel Feldman  

Not reviewed: rolling out r95089.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDestroyedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::didCommitLoad):
(WebCore::InspectorInstrumentation::frameDestroyed):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameDetached):
(WebCore::InspectorPageAgent::frameDestroyed):
* inspector/InspectorPageAgent.h:
* page/Frame.cpp:
(WebCore::Frame::~Frame):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95091 => 95092)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 14:34:32 UTC (rev 95091)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 14:59:46 UTC (rev 95092)
@@ -1,3 +1,23 @@
+2011-09-14  Pavel Feldman  
+
+Not reviewed: rolling out r95089.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::frameDestroyedImpl):
+(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
+* inspector/InspectorInstrumentation.h:
+(WebCore::InspectorInstrumentation::frameWindowDiscarded):
+(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
+(WebCore::InspectorInstrumentation::loadEventFired):
+(WebCore::InspectorInstrumentation::didCommitLoad):
+(WebCore::InspectorInstrumentation::frameDestroyed):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::frameDetached):
+(WebCore::InspectorPageAgent::frameDestroyed):
+* inspector/InspectorPageAgent.h:
+* page/Frame.cpp:
+(WebCore::Frame::~Frame):
+
 2011-09-14  Ilya Tikhonovsky  
 
 Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (95091 => 95092)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 14:34:32 UTC (rev 95091)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 14:59:46 UTC (rev 95092)
@@ -660,6 +660,12 @@
 pageAgent->frameNavigated(loader);
 }
 
+void InspectorInstrumentation::frameDestroyedImpl(InstrumentingAgents* instrumentingAgents, Frame* frame)
+{
+if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())
+inspectorPageAgent->frameDestroyed(frame);
+}
+
 void InspectorInstrumentation::loaderDetachedFromFrameImpl(InstrumentingAgents* instrumentingAgents, DocumentLoader* loader)
 {
 if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())
@@ -905,8 +911,6 @@
 
 InstrumentingAgents* InspectorInstrumentation::instrumentingAgentsForPage(Page* page)
 {
-// We should not be getting 0 page here, but we are not quite ready to remove the test below.
-ASSERT(page);
 if (!page)
 return 0;
 return instrumentationForPage(page);


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.h (95091 => 95092)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2011-09-14 14:34:32 UTC (rev 95091)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.h	2011-09-14 14:59:46 UTC (rev 95092)
@@ -142,6 +142,7 @@
 static void loadEventFired(Frame*, const KURL&);
 static void frameDetachedFromParent(Frame*);
 static void didCommitLoad(Frame*, DocumentLoader*);
+static void frameDestroyed(Frame*);
 static void loaderDetachedFromFrame(Frame*, DocumentLoader*);
 
 static InspectorInstrumentationCookie willWriteHTML(Document*, unsigned int length, unsigned int startLine);
@@ -276,6 +277,7 @@
 static void loadEventFiredImpl(InstrumentingAgents*, Frame*, const KURL&);
 static void frameDetachedFromParentImpl(InstrumentingAgents*, Frame*);
 static void didCommitLoadImpl(InstrumentingAgents*, Page*, DocumentLoader*);
+static void frameDestroyedImpl(InstrumentingAgents*, Frame*);
 static void loaderDetachedFromFrameImpl(InstrumentingAgents*, DocumentLoader*);
 
 static InspectorInstrumentationCookie willWriteHTMLImpl(InstrumentingAgents*, unsigned int length, unsigned int startLine);
@@ -416,10 +41

[webkit-changes] [95091] trunk

[loislo]

Title: [95091] trunk








Revision 95091
Author loi...@chromium.org
Date 2011-09-14 07:34:32 -0700 (Wed, 14 Sep 2011)


Log Message
Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-animation-frame.html

* English.lproj/localizedStrings.js:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::callFunctionWithoutFrame):
(WebCore::V8Proxy::instrumentedCallFunction):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

* inspector/timeline/timeline-animation-frame-expected.txt: Added.
* inspector/timeline/timeline-animation-frame.html: Added.
* inspector/timeline/timeline-enum-stability-expected.txt:
* platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.performActions.step2):
(initialize_Timeline.InspectorTest.performActions):
(initialize_Timeline.InspectorTest.performActionsAndPrint):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-enum-stability-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.h
trunk/Source/WebCore/bindings/v8/custom/V8CustomVoidCallback.cpp
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/inspector/InspectorTimelineAgent.h
trunk/Source/WebCore/inspector/TimelineRecordFactory.cpp
trunk/Source/WebCore/inspector/TimelineRecordFactory.h
trunk/Source/WebCore/inspector/front-end/TimelineAgent.js
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js


Added Paths

trunk/LayoutTests/inspector/timeline/timeline-animation-frame-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-animation-frame.html
trunk/LayoutTests/platform/chromium/inspector/timeline/timeline-animation-frame-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95090 => 95091)

--- trunk/LayoutTests/ChangeLog	2011-09-14 14:20:45 UTC (rev 95090)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 14:34:32 UTC (rev 95091)
@@ -1,3 +1,19 @@
+2011-09-14  Ilya Tikhonovsky  
+
+Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
+https://bugs.webkit.org/show_bug.cgi?id=67986
+
+Reviewed by Pavel Feldman.
+
+* inspector/timeline/timeline-animation-frame-expected.txt: Added.
+* inspector/timeline/timeline-animation-frame.html: Added.
+* inspector/timeline/timeline-enum-stability-expected.txt:
+* platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
+* inspector/timeline/timeline-test.js:
+

[webkit-changes] [95090] trunk/Source/JavaScriptCore

[steveblock]

Title: [95090] trunk/Source/_javascript_Core








Revision 95090
Author stevebl...@google.com
Date 2011-09-14 07:20:45 -0700 (Wed, 14 Sep 2011)


Log Message
HashTraits.h should include template specialization for WTF::String
https://bugs.webkit.org/show_bug.cgi?id=67851

Ensure that the template specialization for HashTraits is always
picked up. (Previously it was possible to include HashSet and String but
not the correct HashTraits, so you would get an inefficient template
instantiation.)

Patch by Iain Merrick  on 2011-09-14
Reviewed by Darin Adler.

* wtf/HashTraits.h:
* wtf/text/StringHash.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTraits.h
trunk/Source/_javascript_Core/wtf/text/StringHash.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (95089 => 95090)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-14 14:14:37 UTC (rev 95089)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-14 14:20:45 UTC (rev 95090)
@@ -1,3 +1,18 @@
+2011-09-14  Iain Merrick  
+
+HashTraits.h should include template specialization for WTF::String
+https://bugs.webkit.org/show_bug.cgi?id=67851
+
+Ensure that the template specialization for HashTraits is always
+picked up. (Previously it was possible to include HashSet and String but
+not the correct HashTraits, so you would get an inefficient template
+instantiation.)
+
+Reviewed by Darin Adler.
+
+* wtf/HashTraits.h:
+* wtf/text/StringHash.h:
+
 2011-09-13  Filip Pizlo  
 
 SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should


Modified: trunk/Source/_javascript_Core/wtf/HashTraits.h (95089 => 95090)

--- trunk/Source/_javascript_Core/wtf/HashTraits.h	2011-09-14 14:14:37 UTC (rev 95089)
+++ trunk/Source/_javascript_Core/wtf/HashTraits.h	2011-09-14 14:20:45 UTC (rev 95090)
@@ -28,6 +28,8 @@
 
 namespace WTF {
 
+class String;
+
 using std::pair;
 using std::make_pair;
 
@@ -89,6 +91,7 @@
 };
 
 template struct HashTraits > : SimpleClassHashTraits > { };
+template<> struct HashTraits : SimpleClassHashTraits { };
 
 // special traits for pairs, helpful for their use in HashMap implementation
 


Modified: trunk/Source/_javascript_Core/wtf/text/StringHash.h (95089 => 95090)

--- trunk/Source/_javascript_Core/wtf/text/StringHash.h	2011-09-14 14:14:37 UTC (rev 95089)
+++ trunk/Source/_javascript_Core/wtf/text/StringHash.h	2011-09-14 14:20:45 UTC (rev 95090)
@@ -179,8 +179,6 @@
 }
 };
 
-template<> struct HashTraits : SimpleClassHashTraits { };
-
 }
 
 using WTF::StringHash;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95089] trunk/Source/WebCore

[pfeldman]

Title: [95089] trunk/Source/WebCore








Revision 95089
Author pfeld...@chromium.org
Date 2011-09-14 07:14:37 -0700 (Wed, 14 Sep 2011)


Log Message
Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
https://bugs.webkit.org/show_bug.cgi?id=67997

We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.

This change wipes out frame binding from the inspector upon detach rather
than destroy + adds an assertion into the inspector agents lookup with 0 page.

Reviewed by Tony Gentilcore.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDetachedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetached):
(WebCore::InspectorInstrumentation::didCommitLoad):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameDetached):
* inspector/InspectorPageAgent.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::detachFromPage):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Frame.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/InspectorPageAgent.h
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (95088 => 95089)

--- trunk/Source/WebCore/ChangeLog	2011-09-14 13:52:30 UTC (rev 95088)
+++ trunk/Source/WebCore/ChangeLog	2011-09-14 14:14:37 UTC (rev 95089)
@@ -1,3 +1,38 @@
+2011-09-13  Pavel Feldman  
+
+Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
+https://bugs.webkit.org/show_bug.cgi?id=67997
+
+We should not instrument frameDestroyed event from within Frame's destructor
+since frame's m_page pointer is likely to be 0 by that time and appropriate
+instrumenting agent won't be found. As a result, stale frame with its id
+end up in the inspector.
+
+This change wipes out frame binding from the inspector upon detach rather
+than destroy + adds an assertion into the inspector agents lookup with 0 page.
+
+Reviewed by Tony Gentilcore.
+
+* inspector/InspectorInstrumentation.cpp:
+(WebCore::InspectorInstrumentation::frameDetachedImpl):
+(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
+* inspector/InspectorInstrumentation.h:
+(WebCore::InspectorInstrumentation::frameWindowDiscarded):
+(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
+(WebCore::InspectorInstrumentation::loadEventFired):
+(WebCore::InspectorInstrumentation::frameDetached):
+(WebCore::InspectorInstrumentation::didCommitLoad):
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::frameDetached):
+* inspector/InspectorPageAgent.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::detachFromParent):
+* page/Frame.cpp:
+(WebCore::Frame::~Frame):
+(WebCore::Frame::detachFromPage):
+(WebCore::Frame::transferChildFrameToNewDocument):
+* page/Frame.h:
+
 2011-09-14  Sheriff Bot  
 
 Unreviewed, rolling out r95080.


Modified: trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp (95088 => 95089)

--- trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 13:52:30 UTC (rev 95088)
+++ trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp	2011-09-14 14:14:37 UTC (rev 95089)
@@ -660,12 +660,6 @@
 pageAgent->frameNavigated(loader);
 }
 
-void InspectorInstrumentation::frameDestroyedImpl(InstrumentingAgents* instrumentingAgents, Frame* frame)
-{
-if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())
-inspectorPageAgent->frameDestroyed(frame);
-}
-
 void InspectorInstrumentation::loaderDetachedFromFrameImpl(InstrumentingAgents* instrumentingAgents, DocumentLoader* loader)
 {
 if (InspectorPageAgent* inspectorPageAgent = instrumentingAgents->inspectorPageAgent())
@@ -883,6 +877,8 @@
 
 InstrumentingAgents* InspectorInstrumentation::instrumentingAgentsForPage(Page* page)
 {
+// We should not be getting 0 page here, but we are not quite ready to remove the test below.
+ASSERT(page);
 if (!page)
 return 0;
 return instrumentationForPage(page);


Modified: trunk/Sou

[webkit-changes] [95088] trunk/Source/WebKit/efl

[commit-queue]

Title: [95088] trunk/Source/WebKit/efl








Revision 95088
Author commit-qu...@webkit.org
Date 2011-09-14 06:52:30 -0700 (Wed, 14 Sep 2011)


Log Message
[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
https://bugs.webkit.org/show_bug.cgi?id=64932

Patch by Grzegorz Czajkowski  on 2011-09-14
Reviewed by Eric Seidel.

It prevents the crash while allocating memory for the new window.

* ewk/ewk_view.cpp:
(ewk_view_window_create):
* ewk/ewk_window_features.cpp:
(ewk_window_features_new_from_core):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_window_features.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (95087 => 95088)

--- trunk/Source/WebKit/efl/ChangeLog	2011-09-14 13:41:42 UTC (rev 95087)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-09-14 13:52:30 UTC (rev 95088)
@@ -1,3 +1,17 @@
+2011-09-14  Grzegorz Czajkowski  
+
+[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
+https://bugs.webkit.org/show_bug.cgi?id=64932
+
+Reviewed by Eric Seidel.
+
+It prevents the crash while allocating memory for the new window.
+
+* ewk/ewk_view.cpp:
+(ewk_view_window_create):
+* ewk/ewk_window_features.cpp:
+(ewk_window_features_new_from_core):
+
 2011-09-13  Raphael Kubo da Costa  
 
 [EFL] Do not always return the cached frame name.


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (95087 => 95088)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-09-14 13:41:42 UTC (rev 95087)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-09-14 13:52:30 UTC (rev 95088)
@@ -2864,7 +2864,7 @@
  * NULL, it will be created a window with default features.
  *
  * @return New view, in case smart class implements the creation of new windows;
- * else, current view @param o.
+ * else, current view @param o or @c 0 on failure.
  *
  * @see ewk_window_features_ref().
  */
@@ -2876,6 +2876,9 @@
 return o;
 
 Ewk_Window_Features *window_features = ewk_window_features_new_from_core(coreFeatures);
+if (!window_features)
+return 0;
+
 Evas_Object* view = sd->api->window_create(sd, _javascript_, window_features);
 ewk_window_features_unref(window_features);
 


Modified: trunk/Source/WebKit/efl/ewk/ewk_window_features.cpp (95087 => 95088)

--- trunk/Source/WebKit/efl/ewk/ewk_window_features.cpp	2011-09-14 13:41:42 UTC (rev 95087)
+++ trunk/Source/WebKit/efl/ewk/ewk_window_features.cpp	2011-09-14 13:52:30 UTC (rev 95088)
@@ -105,11 +105,15 @@
  *
  * @param core if not @c 0 a new WebCore::WindowFeatures is allocated copying core features and
  * it is embedded inside the Ewk_Window_Features whose ref count is initialized, if core is @c 0 a new one is created with the default features.
- * @returns a new allocated the Ewk_Window_Features object
+ * @return a new allocated the Ewk_Window_Features object on sucess or @c 0 on failure
  */
 Ewk_Window_Features *ewk_window_features_new_from_core(const WebCore::WindowFeatures *core)
 {
 Ewk_Window_Features *window_features = static_cast(malloc(sizeof(*window_features)));
+if (!window_features) {
+CRITICAL("Could not allocate Ewk_Window_Features.");
+return 0;
+}
 
 if (core)
 window_features->core = new WebCore::WindowFeatures(*core);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95087] trunk/LayoutTests

[ukai]

Title: [95087] trunk/LayoutTests








Revision 95087
Author u...@chromium.org
Date 2011-09-14 06:41:42 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed, update chromium test expectations.

* platform/chromium/test_expectations.txt: fix lint-test-files error

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95086 => 95087)

--- trunk/LayoutTests/ChangeLog	2011-09-14 10:06:29 UTC (rev 95086)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 13:41:42 UTC (rev 95087)
@@ -1,3 +1,9 @@
+2011-09-14  Fumitoshi Ukai  
+
+Unreviewed, update chromium test expectations.
+
+* platform/chromium/test_expectations.txt: fix lint-test-files error
+
 2011-09-14  Kentaro Hara  
 
 page-transition-event-constructor-expected.txt is missing


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95086 => 95087)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 10:06:29 UTC (rev 95086)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 13:41:42 UTC (rev 95087)
@@ -3729,4 +3729,4 @@
 
 // Failing after r95070
 BUGWK68065 MAC : fast/writing-mode/broken-ideographic-font.html = IMAGE
-BUGWK68065 MAC : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE
+BUGWK68065 SNOWLEOPARD RELEASE : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95086] trunk/LayoutTests

[haraken]

Title: [95086] trunk/LayoutTests








Revision 95086
Author hara...@google.com
Date 2011-09-14 03:06:29 -0700 (Wed, 14 Sep 2011)


Log Message
page-transition-event-constructor-expected.txt is missing
https://bugs.webkit.org/show_bug.cgi?id=68069

Reviewed by Hajime Morita.

* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95085 => 95086)

--- trunk/LayoutTests/ChangeLog	2011-09-14 09:48:59 UTC (rev 95085)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 10:06:29 UTC (rev 95086)
@@ -1,3 +1,12 @@
+2011-09-14  Kentaro Hara  
+
+page-transition-event-constructor-expected.txt is missing
+https://bugs.webkit.org/show_bug.cgi?id=68069
+
+Reviewed by Hajime Morita.
+
+* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
+
 2011-09-14  Sheriff Bot  
 
 Unreviewed, rolling out r95080.


Added: trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor-expected.txt (0 => 95086)

--- trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor-expected.txt	2011-09-14 10:06:29 UTC (rev 95086)
@@ -0,0 +1,21 @@
+This tests the constructor for the PageTransitionEvent DOM class.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS new PageTransitionEvent('eventType').bubbles is false
+PASS new PageTransitionEvent('eventType').cancelable is false
+PASS new PageTransitionEvent('eventType').persisted is false
+PASS new PageTransitionEvent('eventType', { bubbles: false }).bubbles is false
+PASS new PageTransitionEvent('eventType', { bubbles: true }).bubbles is true
+PASS new PageTransitionEvent('eventType', { cancelable: false }).cancelable is false
+PASS new PageTransitionEvent('eventType', { cancelable: true }).cancelable is true
+PASS new PageTransitionEvent('eventType', { persisted: false }).persisted is false
+PASS new PageTransitionEvent('eventType', { persisted: true }).persisted is true
+PASS new PageTransitionEvent('eventType', { bubbles: true, cancelable: true, persisted: true }).bubbles is true
+PASS new PageTransitionEvent('eventType', { bubbles: true, cancelable: true, persisted: true }).cancelable is true
+PASS new PageTransitionEvent('eventType', { bubbles: true, cancelable: true, persisted: true }).persisted is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95085] trunk/Tools

[jochen]

Title: [95085] trunk/Tools








Revision 95085
Author joc...@chromium.org
Date 2011-09-14 02:48:59 -0700 (Wed, 14 Sep 2011)


Log Message
[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=68066

Reviewed by Adam Barth.

* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
trunk/Tools/DumpRenderTree/chromium/WebViewHost.h




Diff

Modified: trunk/Tools/ChangeLog (95084 => 95085)

--- trunk/Tools/ChangeLog	2011-09-14 09:41:41 UTC (rev 95084)
+++ trunk/Tools/ChangeLog	2011-09-14 09:48:59 UTC (rev 95085)
@@ -1,3 +1,13 @@
+2011-09-14  Jochen Eisinger  
+
+[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
+https://bugs.webkit.org/show_bug.cgi?id=68066
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/WebViewHost.cpp:
+* DumpRenderTree/chromium/WebViewHost.h:
+
 2011-09-13  Ryosuke Niwa  
 
 committers.py is missing some contributors


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (95084 => 95085)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2011-09-14 09:41:41 UTC (rev 95084)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp	2011-09-14 09:48:59 UTC (rev 95085)
@@ -794,16 +794,6 @@
 return webkit_support::CreateApplicationCacheHost(frame, client);
 }
 
-bool WebViewHost::allowPlugins(WebFrame* frame, bool enabledPerSettings)
-{
-return enabledPerSettings;
-}
-
-bool WebViewHost::allowImages(WebFrame* frame, bool enabledPerSettings)
-{
-return enabledPerSettings;
-}
-
 void WebViewHost::loadURLExternally(WebFrame* frame, const WebURLRequest& request, WebNavigationPolicy policy)
 {
 loadURLExternally(frame, request, policy, WebString());
@@ -1146,11 +1136,6 @@
 fputs("didRunInsecureContent\n", stdout);
 }
 
-bool WebViewHost::allowScript(WebFrame*, bool enabledPerSettings)
-{
-return enabledPerSettings;
-}
-
 void WebViewHost::openFileSystem(WebFrame* frame, WebFileSystem::Type type, long long size, bool create, WebFileSystemCallbacks* callbacks)
 {
 webkit_support::OpenFileSystem(frame, type, size, create, callbacks);


Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.h (95084 => 95085)

--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.h	2011-09-14 09:41:41 UTC (rev 95084)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.h	2011-09-14 09:48:59 UTC (rev 95085)
@@ -171,8 +171,6 @@
 virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebWorkerClient*);
 virtual WebKit::WebMediaPlayer* createMediaPlayer(WebKit::WebFrame*, WebKit::WebMediaPlayerClient*);
 virtual WebKit::WebApplicationCacheHost* createApplicationCacheHost(WebKit::WebFrame*, WebKit::WebApplicationCacheHostClient*);
- virtual bool allowPlugins(WebKit::WebFrame*, bool enabledPerSettings);
-virtual bool allowImages(WebKit::WebFrame*, bool enabledPerSettings);
 virtual void loadURLExternally(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationPolicy);
 virtual void loadURLExternally(WebKit::WebFrame*, const WebKit::WebURLRequest&, WebKit::WebNavigationPolicy, const WebKit::WebString& downloadName);
 virtual WebKit::WebNavigationPolicy decidePolicyForNavigation(
@@ -208,7 +206,6 @@
 virtual void didFailResourceLoad(WebKit::WebFrame*, unsigned identifier, const WebKit::WebURLError&);
 virtual void didDisplayInsecureContent(WebKit::WebFrame*);
 virtual void didRunInsecureContent(WebKit::WebFrame*, const WebKit::WebSecurityOrigin&, const WebKit::WebURL&);
-virtual bool allowScript(WebKit::WebFrame*, bool enabledPerSettings);
 virtual void openFileSystem(WebKit::WebFrame*, WebKit::WebFileSystem::Type, long long size, bool create, WebKit::WebFileSystemCallbacks*);
 
 WebKit::WebDeviceOrientationClientMock* deviceOrientationClientMock();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95084] trunk

[commit-queue]

Title: [95084] trunk








Revision 95084
Author commit-qu...@webkit.org
Date 2011-09-14 02:41:41 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed, rolling out r95080.
http://trac.webkit.org/changeset/95080
https://bugs.webkit.org/show_bug.cgi?id=68070

It caused some 2d.composite.uncovered tests fail (Requested by
rgabor on #webkit).

Patch by Sheriff Bot  on 2011-09-14

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

* fast/canvas/canvas-large-fills-expected.txt: Removed.
* fast/canvas/canvas-large-fills.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp


Removed Paths

trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt
trunk/LayoutTests/fast/canvas/canvas-large-fills.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95083 => 95084)

--- trunk/LayoutTests/ChangeLog	2011-09-14 09:29:31 UTC (rev 95083)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 09:41:41 UTC (rev 95084)
@@ -1,3 +1,15 @@
+2011-09-14  Sheriff Bot  
+
+Unreviewed, rolling out r95080.
+http://trac.webkit.org/changeset/95080
+https://bugs.webkit.org/show_bug.cgi?id=68070
+
+It caused some 2d.composite.uncovered tests fail (Requested by
+rgabor on #webkit).
+
+* fast/canvas/canvas-large-fills-expected.txt: Removed.
+* fast/canvas/canvas-large-fills.html: Removed.
+
 2011-09-13  Pavel Feldman  
 
 Web Inspector: [v8] building call frame info for location-less internal script function crashes.


Deleted: trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt (95083 => 95084)

--- trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt	2011-09-14 09:29:31 UTC (rev 95083)
+++ trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt	2011-09-14 09:41:41 UTC (rev 95084)
@@ -1,138 +0,0 @@
-Tests that using the different composite modes to fill large rects doesn't crash and works as expected.
-
-size == 1
-source-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-out
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-source-atop
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-destination-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-out
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-destination-atop
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-lighter
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 255 Expected: 255
-copy
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-xor
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-size == 5
-source-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-out
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-source-atop
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-destination-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-out
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-destination-atop
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-lighter
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 255 Expected: 255
-copy
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-xor
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-size == 10
-source-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-source-out
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-source-atop
-PASS Actual: 0 Expected: 0
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-destination-over
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-in
-PASS Actual: 0 Expected: 0
-PASS Actual: 255 Expected: 255
-PASS Actual: 0 Expected: 0
-destination-out
-P

[webkit-changes] [95083] trunk

[pfeldman]

Title: [95083] trunk








Revision 95083
Author pfeld...@chromium.org
Date 2011-09-14 02:29:31 -0700 (Wed, 14 Sep 2011)


Log Message
Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

* inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
* inspector/debugger/debugger-pause-in-internal.html: Added.
* inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
* platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DebuggerScript.js
trunk/Source/WebCore/bindings/v8/ScriptDebugServer.cpp


Added Paths

trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal-expected.txt
trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal.html
trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95082 => 95083)

--- trunk/LayoutTests/ChangeLog	2011-09-14 08:31:41 UTC (rev 95082)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 09:29:31 UTC (rev 95083)
@@ -1,3 +1,15 @@
+2011-09-13  Pavel Feldman  
+
+Web Inspector: [v8] building call frame info for location-less internal script function crashes.
+https://bugs.webkit.org/show_bug.cgi?id=67991
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
+* inspector/debugger/debugger-pause-in-internal.html: Added.
+* inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
+* platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
+
 2011-09-14  Fumitoshi Ukai  
 
 Unreviewed, update chromium test expecations.


Added: trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal-expected.txt (0 => 95083)

--- trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal-expected.txt	2011-09-14 09:29:31 UTC (rev 95083)
@@ -0,0 +1,12 @@
+CONSOLE MESSAGE: line 2: SyntaxError: Unexpected token ')'
+Tests that pause on exception in internal script does not crash.
+
+Debugger was enabled.
+Script source was shown.
+Script execution paused.
+Call stack:
+0) throwException (debugger-pause-in-internal.html:9)
+1) handleClick (debugger-pause-in-internal.html:14)
+Script execution resumed.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal.html (0 => 95083)

--- trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal.html	(rev 0)
+++ trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal.html	2011-09-14 09:29:31 UTC (rev 95083)
@@ -0,0 +1,50 @@
+
+
+
+
+function throwException()
+{
+new Function("return ()");
+}
+
+function handleClick()
+{
+throwException();
+}
+
+var test = function()
+{
+InspectorTest.startDebuggerTest(step1);
+
+function step1()
+{
+DebuggerAgent.setPauseOnExceptions(WebInspector.ScriptsPanel.PauseOnExceptionsState.PauseOnUncaughtExceptions);
+InspectorTest.showScriptSource("debugger-pause-in-internal.html", step2);
+}
+
+function step2()  
+{
+InspectorTest.addResult("Script source was shown.");
+InspectorTest.evaluateInPage("setTimeout(handleClick, 0)");
+InspectorTest.waitUntilPaused(step3);
+}
+
+function step3(callFrames)
+{
+InspectorTest.captureStackTrace(callFrames);
+InspectorTest.completeDebuggerTest();
+}
+}
+
+
+
+
+
+
+Tests that pause on exception in internal script does not crash.
+
+
+
+
Property changes on: trunk/LayoutTests/inspector/debugger/debugger-pause-in-internal.html
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt (0 => 95083)

--- trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt	2011-09-14 09:29:31 UTC (rev 95083)
@@ -0,0 +1,13 @@
+CONSOLE MESSAGE: line 2: Uncaught SyntaxError: Unexpected token )
+Tests that pause on exception in internal script does not crash.
+
+Debugger was 

[webkit-changes] [95082] trunk/LayoutTests

[ukai]

Title: [95082] trunk/LayoutTests








Revision 95082
Author u...@chromium.org
Date 2011-09-14 01:31:41 -0700 (Wed, 14 Sep 2011)


Log Message
Unreviewed, update chromium test expecations.

* platform/chromium/test_expectations.txt:
  - remove failure by r95058, which was reverted by r95077.
  - add failures by r95070

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95081 => 95082)

--- trunk/LayoutTests/ChangeLog	2011-09-14 08:25:20 UTC (rev 95081)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 08:31:41 UTC (rev 95082)
@@ -1,3 +1,11 @@
+2011-09-14  Fumitoshi Ukai  
+
+Unreviewed, update chromium test expecations.
+
+* platform/chromium/test_expectations.txt:
+  - remove failure by r95058, which was reverted by r95077.
+  - add failures by r95070
+
 2011-09-14  Gabor Rapcsanyi  
 
 [Qt] Unreviewed, update test expectations for


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (95081 => 95082)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 08:25:20 UTC (rev 95081)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-14 08:31:41 UTC (rev 95082)
@@ -3727,11 +3727,6 @@
 BUGWK67999 WIN RELEASE : fast/borders/border-image-omit-right-slice.html = IMAGE+TEXT
 BUGWK67999 LINUX MAC RELEASE : fast/borders/border-image-omit-right-slice.html = TEXT
 
-// new layout test at r95058
-BUGWK68049 : fast/borders/border-image-scrambled.html = IMAGE+TEXT
-// Failed after r95058
-BUGWK68050 : fast/css/transformed-mask.html = IMAGE
-BUGWK68050 : fast/reflections/reflection-masks.html = IMAGE
-BUGWK68050 : fast/css/getComputedStyle/computed-style-with-zoom.html = TEXT
-BUGWK68050 GPU : compositing/reflections/masked-reflection-on-composited.html = IMAGE
-BUGWK68051 : css3/calc/regression-62276.html = CRASH
+// Failing after r95070
+BUGWK68065 MAC : fast/writing-mode/broken-ideographic-font.html = IMAGE
+BUGWK68065 MAC : fast/writing-mode/japanese-rl-text-with-broken-font.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95081] trunk/LayoutTests

[rgabor]

Title: [95081] trunk/LayoutTests








Revision 95081
Author rga...@webkit.org
Date 2011-09-14 01:25:20 -0700 (Wed, 14 Sep 2011)


Log Message
[Qt] Unreviewed, update test expectations for
svg/custom/dynamic-svg-document-creation.svg after r95030

* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.png
trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (95080 => 95081)

--- trunk/LayoutTests/ChangeLog	2011-09-14 08:10:05 UTC (rev 95080)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 08:25:20 UTC (rev 95081)
@@ -1,3 +1,11 @@
+2011-09-14  Gabor Rapcsanyi  
+
+[Qt] Unreviewed, update test expectations for
+svg/custom/dynamic-svg-document-creation.svg after r95030
+
+* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
+* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:
+
 2011-09-14  Ben Wells  
 
 Large canvas fills should not crash or create unnecessarily large image buffers


Modified: trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt (95080 => 95081)

--- trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt	2011-09-14 08:10:05 UTC (rev 95080)
+++ trunk/LayoutTests/platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt	2011-09-14 08:25:20 UTC (rev 95081)
@@ -24,11 +24,11 @@
 RenderText {#text} at (0,0) size 668x22
   text run at (0,0) width 668: "SVGDocument's rootElement first child: [object SVGGElement] should be: [object SVGGElement]"
   RenderBlock {div} at (0,132) size 800x88
-RenderText {#text} at (0,0) size 798x88
+RenderText {#text} at (0,0) size 789x88
   text run at (0,0) width 786: "XMLSerializer.serializeToString returned: "
   text run at (0,22) width 675: "-  text run at (0,44) width 798: "stroke=\"#00C000\" d=\"M 250 130 C 185 130 150 80 150 80 S 115 25 50 25 m 0 105 c 65 0 100 -50 100 -50 s 35 -55 100 -"
-  text run at (0,66) width 112: "55\"/>"
+  text run at (0,44) width 789: "stroke=\"#00C000\" d=\"M 250 130 C 185 130 150 80 150 80 S 115 25 50 25 m 0 105 c 65 0 100 -50 100 -50 s 35 -55 100"
+  text run at (0,66) width 117: "-55\"/>"
   RenderBlock {div} at (0,220) size 800x22
 RenderText {#text} at (0,0) size 722x22
   text run at (0,0) width 722: "Imported the SVGGElement into our document: [object SVGGElement] should be: [object SVGGElement]"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [95080] trunk

[commit-queue]

Title: [95080] trunk








Revision 95080
Author commit-qu...@webkit.org
Date 2011-09-14 01:10:05 -0700 (Wed, 14 Sep 2011)


Log Message
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells  on 2011-09-14
Reviewed by Stephen White.

Test: fast/canvas/canvas-large-fills.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells  on 2011-09-14
Reviewed by Stephen White.

* fast/canvas/canvas-large-fills-expected.txt: Added.
* fast/canvas/canvas-large-fills.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp


Added Paths

trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt
trunk/LayoutTests/fast/canvas/canvas-large-fills.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95079 => 95080)

--- trunk/LayoutTests/ChangeLog	2011-09-14 07:40:25 UTC (rev 95079)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 08:10:05 UTC (rev 95080)
@@ -1,3 +1,13 @@
+2011-09-14  Ben Wells  
+
+Large canvas fills should not crash or create unnecessarily large image buffers
+https://bugs.webkit.org/show_bug.cgi?id=67988
+
+Reviewed by Stephen White.
+
+* fast/canvas/canvas-large-fills-expected.txt: Added.
+* fast/canvas/canvas-large-fills.html: Added.
+
 2011-09-14  Kentaro Hara  
 
 Implement a PageTransitionEvent constructor for JSC


Added: trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt (0 => 95080)

--- trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-large-fills-expected.txt	2011-09-14 08:10:05 UTC (rev 95080)
@@ -0,0 +1,138 @@
+Tests that using the different composite modes to fill large rects doesn't crash and works as expected.
+
+size == 1
+source-over
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-in
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-out
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+source-atop
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+destination-over
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+destination-in
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+destination-out
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+destination-atop
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+lighter
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 255 Expected: 255
+copy
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+xor
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+size == 5
+source-over
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-in
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-out
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+source-atop
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+destination-over
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+destination-in
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+destination-out
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+destination-atop
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 0 Expected: 0
+lighter
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+PASS Actual: 255 Expected: 255
+copy
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+xor
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+size == 10
+source-over
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-in
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+source-out
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+source-atop
+PASS Actual: 0 Expected: 0
+PASS Actual: 0 Expected: 0
+PASS Actual: 255 Expected: 255
+destination-over
+PASS Act

[webkit-changes] [95079] trunk

[haraken]

Title: [95079] trunk








Revision 95079
Author hara...@google.com
Date 2011-09-14 00:40:25 -0700 (Wed, 14 Sep 2011)


Log Message
Implement a PageTransitionEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68048

Reviewed by Sam Weinig.

Source/WebCore:

The spec for the PageTransitionEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent

Test: fast/events/constructors/page-transition-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the PageTransitionEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for PageTransitionEvent.
* dom/PageTransitionEvent.cpp:
(WebCore::PageTransitionEventInit::PageTransitionEventInit):
(WebCore::PageTransitionEvent::PageTransitionEvent):
(WebCore::PageTransitionEvent::initPageTransitionEvent):
* dom/PageTransitionEvent.h: Added a definition for PageTransitionEventInit.
(WebCore::PageTransitionEvent::create):
(WebCore::PageTransitionEvent::isPageTransitionEvent):
(WebCore::PageTransitionEvent::persisted):
* dom/PageTransitionEvent.idl: Makes PageTransitionEvent constructible.

LayoutTests:

page-transition-event-constructor.html checks the behavior of the PageTransitionEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Added PageTransitionEvent.
* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
* fast/events/constructors/page-transition-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped page-transition-event-constructor.html, since V8 does not yet have the PageTransitionEvent constructor.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/EventConstructors.h
trunk/Source/WebCore/bindings/js/JSEventConstructors.cpp
trunk/Source/WebCore/dom/PageTransitionEvent.cpp
trunk/Source/WebCore/dom/PageTransitionEvent.h
trunk/Source/WebCore/dom/PageTransitionEvent.idl


Added Paths

trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor.html




Diff

Modified: trunk/LayoutTests/ChangeLog (95078 => 95079)

--- trunk/LayoutTests/ChangeLog	2011-09-14 06:58:10 UTC (rev 95078)
+++ trunk/LayoutTests/ChangeLog	2011-09-14 07:40:25 UTC (rev 95079)
@@ -1,3 +1,17 @@
+2011-09-14  Kentaro Hara  
+
+Implement a PageTransitionEvent constructor for JSC
+https://bugs.webkit.org/show_bug.cgi?id=68048
+
+Reviewed by Sam Weinig.
+
+page-transition-event-constructor.html checks the behavior of the PageTransitionEvent constructor.
+
+* fast/dom/constructed-objects-prototypes-expected.txt: Added PageTransitionEvent.
+* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
+* fast/events/constructors/page-transition-event-constructor.html: Added.
+* platform/chromium/test_expectations.txt: Skipped page-transition-event-constructor.html, since V8 does not yet have the PageTransitionEvent constructor.
+
 2011-09-13  Sheriff Bot  
 
 Unreviewed, rolling out r95058.


Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (95078 => 95079)

--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt	2011-09-14 06:58:10 UTC (rev 95078)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt	2011-09-14 07:40:25 UTC (rev 95079)
@@ -21,6 +21,8 @@
 PASS (new inner.MessageChannel()).constructor.isInner is true
 PASS (new inner.Option()).isInner is true
 PASS (new inner.Option()).constructor.isInner is true
+PASS (new inner.PageTransitionEvent()).isInner is true
+PASS (new inner.PageTransitionEvent()).constructor.isInner is true
 PASS (new inner.ProgressEvent()).isInner is true
 PASS (new inner.ProgressEvent()).constructor.isInner is true
 PASS (new inner.WebKitAnimationEvent()).isInner is true


Added: trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor.html (0 => 95079)

--- trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor.html	(rev 0)
+++ trunk/LayoutTests/fast/events/constructors/page-transition-event-constructor.html	2011-09-14 07:40:25 UTC (rev 95079)
@@ -0,0 +1,40 @@
+
+
+
+
+
+
+
+
+
+description("This tests the constructor for the PageTransitionEvent DOM class.");
+
+// No initializer is passed.
+shouldBe("new PageTransitionEvent('eventType').bubbles", "false");
+shouldBe("new PageTransitionEvent('eventType').cancelable", "false");
+shouldBe("new PageTransitionEvent('eventType').persisted", "false");
+
+// bubbles is passed.
+shouldBe("new PageTransitionEvent('eventType', { bubbles: false }).bubbles", "false");
+shouldBe("new PageTransitionEvent('eventType', { bubbles: true }).bubbles", "true");
+
+// cancelable is passed.
+shouldBe("new PageTransitionEvent('eventTy