date:20110929

[webkit-changes] [96298] trunk/LayoutTests

2011-09-29 Thread rniwa

Title: [96298] trunk/LayoutTests








Revision 96298
Author rn...@webkit.org
Date 2011-09-28 23:01:34 -0700 (Wed, 28 Sep 2011)


Log Message
Update Chromium test expectation and also add back the expected result erroneously removed in r96284.

* platform/chromium/test_expectations.txt:
* platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
* platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-006-expected.txt
trunk/LayoutTests/platform/mac/editing/pasteboard/paste-text-006-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96297 => 96298)

--- trunk/LayoutTests/ChangeLog	2011-09-29 05:43:21 UTC (rev 96297)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:01:34 UTC (rev 96298)
@@ -1,5 +1,13 @@
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
+Update Chromium test expectation and also add back the expected result erroneously removed in r96284.
+
+* platform/chromium/test_expectations.txt:
+* platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
+* platform/mac/editing/pasteboard/paste-text-006-expected.txt: Added.
+
+2011-09-28  Ryosuke Niwa  rn...@webkit.org
+
 Chromium rebaselines for r96257 part 2.
 
 * editing/deleting/delete-line-011-expected.txt: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96297 => 96298)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 05:43:21 UTC (rev 96297)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:01:34 UTC (rev 96298)
@@ -3812,8 +3812,6 @@
 BUGWK62092 WIN LINUX : editing/style/typing-style-001.html = TEXT
 BUGWK62092 WIN LINUX : editing/style/typing-style-002.html = TEXT
 BUGWK62092 WIN LINUX : editing/undo/4063751.html = TEXT
-BUGWK62092 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE+TEXT
-BUGWK62092 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
 BUGWK62092 LINUX : editing/deleting/smart-delete-002.html = TEXT
 BUGWK62092 LINUX : editing/pasteboard/subframe-dragndrop-1.html = TEXT
 BUGWK62092 WIN : fast/events/updateLayoutForHitTest.html = IMAGE+TEXT
@@ -3823,3 +3821,6 @@
 BUGWK62092 MAC : editing/pasteboard/paste-text-006.html = IMAGE
 // Used to be just PASS IMAGE before r96257
 BUGWK63509 : editing/style/smoosh-styles-003.html = PASS FAIL
+
+BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
+BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE+TEXT


Added: trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-006-expected.txt (0 => 96298)

--- trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-006-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-text-006-expected.txt	2011-09-29 06:01:34 UTC (rev 96298)
@@ -0,0 +1,70 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY  HTML  #document to 10 of BODY  HTML  #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE:

[webkit-changes] [96299] trunk/Source

2011-09-29 Thread mrobinson

Title: [96299] trunk/Source








Revision 96299
Author mrobin...@webkit.org
Date 2011-09-28 23:02:57 -0700 (Wed, 28 Sep 2011)


Log Message
[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
https://bugs.webkit.org/show_bug.cgi?id=66890

Source/WebCore:

Added a GtkDragAndDropHelper class to hold all the logic that is common
between WebKit1 and WebKit2. This will allow greater code sharing between
the two ports.

Reviewed by Philippe Normand.

No new tests. This patch should not change behavior.

* GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
* platform/gtk/GtkDragAndDropHelper.cpp: Added.
* platform/gtk/GtkDragAndDropHelper.h: Added.

Source/WebKit/gtk:

Use the new GtkWidgetDragAndDropGlue class to hold the logic that will be
common between WebKit1 and WebKit2. Modify WebKitWebView to use this class.

Reviewed by Philippe Normand.

* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Inform the drag-and-drop glue about the drag.
* webkit/webkitwebview.cpp: Use GtkWidgetDragAndDropGlue wherever this class was
maintaining drag-and-drop state itself.
* webkit/webkitwebviewprivate.h: Swap out the drag-and-drop state for an instance
of the glue class.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebviewprivate.h


Added Paths

trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp
trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96298 => 96299)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 06:01:34 UTC (rev 96298)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 06:02:57 UTC (rev 96299)
@@ -1,3 +1,20 @@
+2011-09-28  Martin Robinson  mrobin...@igalia.com
+
+[GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=66890
+
+Added a GtkDragAndDropHelper class to hold all the logic that is common
+between WebKit1 and WebKit2. This will allow greater code sharing between
+the two ports.
+
+Reviewed by Philippe Normand.
+
+No new tests. This patch should not change behavior.
+
+* GNUmakefile.list.am: Added the GtkDragAndDropHelper to the sources list.
+* platform/gtk/GtkDragAndDropHelper.cpp: Added.
+* platform/gtk/GtkDragAndDropHelper.h: Added.
+
 2011-09-28  Dan Bernstein  m...@apple.com
 
 rdar://problem/10196497 first-letter after list marker not updated correctly


Modified: trunk/Source/WebCore/GNUmakefile.list.am (96298 => 96299)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-09-29 06:01:34 UTC (rev 96298)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-09-29 06:02:57 UTC (rev 96299)
@@ -3998,6 +3998,8 @@
 	Source/WebCore/platform/gtk/FileSystemGtk.cpp \
 	Source/WebCore/platform/gtk/GtkClickCounter.cpp \
 	Source/WebCore/platform/gtk/GtkClickCounter.h \
+	Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp \
+	Source/WebCore/platform/gtk/GtkDragAndDropHelper.h \
 	Source/WebCore/platform/gtk/GtkUtilities.cpp \
 	Source/WebCore/platform/gtk/GtkUtilities.h \
 	Source/WebCore/platform/gtk/GeolocationServiceGtk.cpp \


Added: trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp (0 => 96299)

--- trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp	2011-09-29 06:02:57 UTC (rev 96299)
@@ -0,0 +1,200 @@
+/*
+ * Copyright (C) 2011, Igalia S.L.
+ *
+ *  This library is free software; you can redistribute it and/or
+ *  modify it under the terms of the GNU Lesser General Public
+ *  License as published by the Free Software Foundation; either
+ *  version 2 of the License, or (at your option) any later version.
+ *
+ *  This library is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ *  Lesser General Public License for more details.
+ *
+ *  You should have received a copy of the GNU Lesser General Public
+ *  License along with this library; if not, write to the Free Software
+ *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include config.h
+#include GtkDragAndDropHelper.h
+
+#include ClipboardUtilitiesGtk.h
+#include DragData.h
+#include GtkUtilities.h
+#include PasteboardHelper.h
+#include gtk/gtk.h
+#include wtf/PassOwnPtr.h
+
+namespace WebCore {
+
+struct DroppingContext {
+DroppingContext(GdkDragContext* gdkContext, const IntPoint position)
+: gdkContext(gdkContext)
+, dataObject(DataObjectGtk::create())
+, lastMotionPosition(position)
+, dropHappened(false)
+, exitedCallback(0)
+

[webkit-changes] [96300] trunk/LayoutTests

2011-09-29 Thread ossy

Title: [96300] trunk/LayoutTests








Revision 96300
Author o...@webkit.org
Date 2011-09-28 23:03:12 -0700 (Wed, 28 Sep 2011)


Log Message
[Qt] Unreviewed gardening after r96257.

* platform/qt-4.8/editing/inserting/4278698-expected.png:
* platform/qt-4.8/editing/inserting/4278698-expected.txt:
* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.png
trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.txt
trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png
trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt
trunk/LayoutTests/platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png
trunk/LayoutTests/platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96299 => 96300)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:02:57 UTC (rev 96299)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:03:12 UTC (rev 96300)
@@ -1,3 +1,14 @@
+2011-09-28  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Unreviewed gardening after r96257.
+
+* platform/qt-4.8/editing/inserting/4278698-expected.png:
+* platform/qt-4.8/editing/inserting/4278698-expected.txt:
+* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png:
+* platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt:
+* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.png:
+* platform/qt-4.8/editing/pasteboard/paste-text-019-expected.txt:
+
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
 Update Chromium test expectation and also add back the expected result erroneously removed in r96284.


Modified: trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.txt (96299 => 96300)

--- trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.txt	2011-09-29 06:02:57 UTC (rev 96299)
+++ trunk/LayoutTests/platform/qt-4.8/editing/inserting/4278698-expected.txt	2011-09-29 06:03:12 UTC (rev 96300)
@@ -3,9 +3,8 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text  PRE  DIV  BODY  HTML  #document to 2 of #text  PRE  DIV  BODY  HTML  #document toDOMRange:range from 3 of #text  PRE  DIV  BODY  HTML  #document to 3 of #text  PRE  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 2 of #text  PRE  DIV  BODY  HTML  #document to 3 of #text  PRE  DIV  BODY  HTML  #document toDOMRange:range from 3 of #text  PRE  DIV  BODY  HTML  #document to 3 of #text  PRE  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600


Modified: trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt (96299 => 96300)

--- trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt	2011-09-29 06:02:57 UTC (rev 96299)
+++ trunk/LayoutTests/platform/qt-4.8/editing/inserting/paragraph-separator-03-expected.txt	2011-09-29 06:03:12 UTC (rev 96300)
@@ -3,9 +3,8 @@
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 3 of #text  PRE  DIV  BODY  HTML  #document to 3 of #text  PRE  DIV  BODY  HTML  #document toDOMRange:range from 0 of PRE  DIV  BODY  HTML  #document to 0 of PRE  DIV  BODY  HTML  #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of PRE  DIV  BODY  HTML  #document to 0 of PRE  DIV  BODY  HTML  #document

[webkit-changes] [96301] trunk/Source/WebCore

2011-09-29 Thread haraken

Title: [96301] trunk/Source/WebCore








Revision 96301
Author hara...@chromium.org
Date 2011-09-28 23:07:17 -0700 (Wed, 28 Sep 2011)


Log Message
ScriptValue arguments of PopStateEvent methods should be const ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=68984

Reviewed by Darin Adler.

Just a follow-up fix for the bug 68345. For performance,
ScriptValue arguments of PopStateEvent methods should be const ScriptValue.

Tests: fast/events/constructors/pop-state-event-constructor.html
   fast/events/fire-popstate-event.html

* dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):
* dom/PopStateEvent.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/PopStateEvent.cpp
trunk/Source/WebCore/dom/PopStateEvent.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96300 => 96301)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 06:03:12 UTC (rev 96300)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 06:07:17 UTC (rev 96301)
@@ -1,3 +1,22 @@
+2011-09-28  Kentaro Hara  hara...@chromium.org
+
+ScriptValue arguments of PopStateEvent methods should be const ScriptValue
+https://bugs.webkit.org/show_bug.cgi?id=68984
+
+Reviewed by Darin Adler.
+
+Just a follow-up fix for the bug 68345. For performance,
+ScriptValue arguments of PopStateEvent methods should be const ScriptValue.
+
+Tests: fast/events/constructors/pop-state-event-constructor.html
+   fast/events/fire-popstate-event.html
+
+* dom/PopStateEvent.cpp:
+(WebCore::PopStateEvent::PopStateEvent):
+(WebCore::PopStateEvent::create):
+(WebCore::PopStateEvent::initPopStateEvent):
+* dom/PopStateEvent.h:
+
 2011-09-28  Martin Robinson  mrobin...@igalia.com
 
 [GTK] Move drag-and-drop code which can be shared with WebKit2 to WebCore


Modified: trunk/Source/WebCore/dom/PopStateEvent.cpp (96300 => 96301)

--- trunk/Source/WebCore/dom/PopStateEvent.cpp	2011-09-29 06:03:12 UTC (rev 96300)
+++ trunk/Source/WebCore/dom/PopStateEvent.cpp	2011-09-29 06:07:17 UTC (rev 96301)
@@ -48,7 +48,7 @@
 {
 }
 
-PopStateEvent::PopStateEvent(ScriptValue state)
+PopStateEvent::PopStateEvent(const ScriptValue state)
 : Event(eventNames().popstateEvent, false, true)
 , m_state(state)
 , m_serializedState(0)
@@ -70,7 +70,7 @@
 return adoptRef(new PopStateEvent);
 }
 
-PassRefPtrPopStateEvent PopStateEvent::create(ScriptValue state)
+PassRefPtrPopStateEvent PopStateEvent::create(const ScriptValue state)
 {
 return adoptRef(new PopStateEvent(state));
 }
@@ -85,7 +85,7 @@
 return adoptRef(new PopStateEvent(type, initializer));
 }
 
-void PopStateEvent::initPopStateEvent(const AtomicString type, bool canBubble, bool cancelable, ScriptValue state)
+void PopStateEvent::initPopStateEvent(const AtomicString type, bool canBubble, bool cancelable, const ScriptValue state)
 {
 if (dispatched())
 return;


Modified: trunk/Source/WebCore/dom/PopStateEvent.h (96300 => 96301)

--- trunk/Source/WebCore/dom/PopStateEvent.h	2011-09-29 06:03:12 UTC (rev 96300)
+++ trunk/Source/WebCore/dom/PopStateEvent.h	2011-09-29 06:07:17 UTC (rev 96301)
@@ -43,10 +43,10 @@
 public:
 virtual ~PopStateEvent();
 static PassRefPtrPopStateEvent create();
-static PassRefPtrPopStateEvent create(ScriptValue);
+static PassRefPtrPopStateEvent create(const ScriptValue);
 static PassRefPtrPopStateEvent create(PassRefPtrSerializedScriptValue);
 static PassRefPtrPopStateEvent create(const AtomicString, const PopStateEventInit);
-void initPopStateEvent(const AtomicString type, bool canBubble, bool cancelable, ScriptValue);
+void initPopStateEvent(const AtomicString type, bool canBubble, bool cancelable, const ScriptValue);
 bool isPopStateEvent() const { return true; }
 
 SerializedScriptValue* serializedState() const { return m_serializedState.get(); }
@@ -55,7 +55,7 @@
 private:
 PopStateEvent();
 PopStateEvent(const AtomicString, const PopStateEventInit);
-explicit PopStateEvent(ScriptValue);
+explicit PopStateEvent(const ScriptValue);
 explicit PopStateEvent(PassRefPtrSerializedScriptValue);
 
 ScriptValue m_state;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96302] trunk/LayoutTests

2011-09-29 Thread rniwa

Title: [96302] trunk/LayoutTests








Revision 96302
Author rn...@webkit.org
Date 2011-09-28 23:11:04 -0700 (Wed, 28 Sep 2011)


Log Message
Yet another Chromium linux rebaseline after r96257.

* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96301 => 96302)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:07:17 UTC (rev 96301)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:11:04 UTC (rev 96302)
@@ -1,3 +1,10 @@
+2011-09-28  Ryosuke Niwa  rn...@webkit.org
+
+Yet another Chromium linux rebaseline after r96257.
+
+* platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:
+* platform/chromium/test_expectations.txt:
+
 2011-09-28  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening after r96257.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96301 => 96302)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:07:17 UTC (rev 96301)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:11:04 UTC (rev 96302)
@@ -3589,8 +3589,8 @@
 BUG_REED : fast/canvas/canvas-lineWidth.html = TEXT
 
 // Failing temporarily, rebase-line after skia rolls to WK
-BUG_BSALOMON WIN MAC LINUX GPU: fast/canvas/canvas-composite-transformclip.html = IMAGE
-BUG_BSALOMON WIN MAC LINUX GPU: fast/canvas/canvas-composite.html = IMAGE
+BUG_BSALOMON WIN MAC LINUX GPU : fast/canvas/canvas-composite-transformclip.html = IMAGE
+BUG_BSALOMON WIN MAC LINUX GPU : fast/canvas/canvas-composite.html = IMAGE
 
 BUG_ABARTH WIN : svg/as-background-image/svg-as-background-1.html = PASS IMAGE
 BUG_ABARTH WIN : svg/as-background-image/svg-as-background-3.html = PASS IMAGE
@@ -3813,7 +3813,7 @@
 BUGWK62092 WIN LINUX : editing/style/typing-style-002.html = TEXT
 BUGWK62092 WIN LINUX : editing/undo/4063751.html = TEXT
 BUGWK62092 LINUX : editing/deleting/smart-delete-002.html = TEXT
-BUGWK62092 LINUX : editing/pasteboard/subframe-dragndrop-1.html = TEXT
+//BUGWK62092 LINUX : editing/pasteboard/subframe-dragndrop-1.html = TEXT
 BUGWK62092 WIN : fast/events/updateLayoutForHitTest.html = IMAGE+TEXT
 BUGWK62092 MAC : editing/pasteboard/paste-xml.xhtml = TEXT
 BUGWK62092 WIN LINUX : editing/unsupported-content/table-type-after.html = TEXT
@@ -3824,3 +3824,4 @@
 
 BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
 BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE+TEXT
+


Modified: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96303] trunk/LayoutTests

2011-09-29 Thread rniwa

Title: [96303] trunk/LayoutTests








Revision 96303
Author rn...@webkit.org
Date 2011-09-28 23:24:19 -0700 (Wed, 28 Sep 2011)


Log Message
Chromium rebaseline after r96294.

* platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
* platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png
trunk/LayoutTests/platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96302 => 96303)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:11:04 UTC (rev 96302)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:24:19 UTC (rev 96303)
@@ -1,5 +1,14 @@
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
+Chromium rebaseline after r96294.
+
+* platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
+* platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
+* platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
+* platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png: Added.
+
+2011-09-28  Ryosuke Niwa  rn...@webkit.org
+
 Yet another Chromium linux rebaseline after r96257.
 
 * platform/chromium-linux/editing/pasteboard/subframe-dragndrop-1-expected.png:


Added: trunk/LayoutTests/platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/fast/dynamic/first-letter-after-list-marker-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/dynamic/first-letter-after-list-marker-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/dynamic/first-letter-after-list-marker-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/fast/dynamic/first-letter-after-list-marker-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96304] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96304] trunk/LayoutTests








Revision 96304
Author ham...@chromium.org
Date 2011-09-28 23:27:59 -0700 (Wed, 28 Sep 2011)


Log Message
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Chromium test_expectations update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96303 => 96304)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:24:19 UTC (rev 96303)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:27:59 UTC (rev 96304)
@@ -1,3 +1,12 @@
+2011-09-28  Shinichiro Hamaji  ham...@chromium.org
+
+[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=69062
+
+Chromium test_expectations update
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-28  Ryosuke Niwa  rn...@webkit.org
 
 Chromium rebaseline after r96294.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96303 => 96304)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:24:19 UTC (rev 96303)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:27:59 UTC (rev 96304)
@@ -3825,3 +3825,4 @@
 BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
 BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE+TEXT
 
+BUGWK69062 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96305] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96305] trunk/LayoutTests








Revision 96305
Author ham...@chromium.org
Date 2011-09-28 23:32:20 -0700 (Wed, 28 Sep 2011)


Log Message
Chromium test_expectations update for isindex-with-no-form.html

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96304 => 96305)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:27:59 UTC (rev 96304)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 06:32:20 UTC (rev 96305)
@@ -1,5 +1,11 @@
 2011-09-28  Shinichiro Hamaji  ham...@chromium.org
 
+Chromium test_expectations update for isindex-with-no-form.html
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-28  Shinichiro Hamaji  ham...@chromium.org
+
 [Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=69062
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96304 => 96305)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:27:59 UTC (rev 96304)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 06:32:20 UTC (rev 96305)
@@ -2089,7 +2089,8 @@
 BUGWK43912 LINUX WIN : svg/custom/absolute-sized-content-with-resources.xhtml = IMAGE
 
 // Times out frequently since the test was added
-BUGCR52017 LINUX MAC : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT
+BUGCR52017 LINUX MAC RELEASE : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT
+BUGCR52017 LINUX MAC DEBUG : http/tests/misc/isindex-with-no-form.html = PASS TIMEOUT CRASH
 
 // Flaky. Not sure when it started to fail.
 BUGCR52572 LINUX WIN DEBUG : http/tests/misc/image-blocked-src-change.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96306] trunk

2011-09-29 Thread fpizlo

Title: [96306] trunk








Revision 96306
Author fpi...@apple.com
Date 2011-09-29 00:12:10 -0700 (Thu, 29 Sep 2011)


Log Message
DFG checkArgumentTypes fails to check boolean predictions
https://bugs.webkit.org/show_bug.cgi?id=69059

Reviewed by Gavin Barraclough.

Source/_javascript_Core: 

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

LayoutTests: 

* fast/js/boolean-argument-prediction-expected.txt: Added.
* fast/js/boolean-argument-prediction.html: Added.
* fast/js/script-tests/boolean-argument-prediction.js: Added.
(predictBooleanArgument):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp


Added Paths

trunk/LayoutTests/fast/js/boolean-argument-prediction-expected.txt
trunk/LayoutTests/fast/js/boolean-argument-prediction.html
trunk/LayoutTests/fast/js/script-tests/boolean-argument-prediction.js




Diff

Modified: trunk/LayoutTests/ChangeLog (96305 => 96306)

--- trunk/LayoutTests/ChangeLog	2011-09-29 06:32:20 UTC (rev 96305)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 07:12:10 UTC (rev 96306)
@@ -1,3 +1,15 @@
+2011-09-28  Filip Pizlo  fpi...@apple.com
+
+DFG checkArgumentTypes fails to check boolean predictions
+https://bugs.webkit.org/show_bug.cgi?id=69059
+
+Reviewed by Gavin Barraclough.
+
+* fast/js/boolean-argument-prediction-expected.txt: Added.
+* fast/js/boolean-argument-prediction.html: Added.
+* fast/js/script-tests/boolean-argument-prediction.js: Added.
+(predictBooleanArgument):
+
 2011-09-28  Shinichiro Hamaji  ham...@chromium.org
 
 Chromium test_expectations update for isindex-with-no-form.html


Added: trunk/LayoutTests/fast/js/boolean-argument-prediction-expected.txt (0 => 96306)

--- trunk/LayoutTests/fast/js/boolean-argument-prediction-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/boolean-argument-prediction-expected.txt	2011-09-29 07:12:10 UTC (rev 96306)
@@ -0,0 +1,25 @@
+This tests that arguments predicted to be boolean are checked.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS predictBooleanArgument(true) is yes
+PASS predictBooleanArgument(false) is no
+PASS predictBooleanArgument(true) is yes
+PASS predictBooleanArgument(false) is no
+PASS predictBooleanArgument(0) is no
+PASS predictBooleanArgument(1) is yes
+PASS predictBooleanArgument(2) is yes
+PASS predictBooleanArgument(3) is yes
+PASS predictBooleanArgument(4) is yes
+PASS predictBooleanArgument(true) is yes
+PASS predictBooleanArgument(false) is no
+PASS predictBooleanArgument(0) is no
+PASS predictBooleanArgument(1) is yes
+PASS predictBooleanArgument(2) is yes
+PASS predictBooleanArgument(3) is yes
+PASS predictBooleanArgument(4) is yes
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/js/boolean-argument-prediction.html (0 => 96306)

--- trunk/LayoutTests/fast/js/boolean-argument-prediction.html	(rev 0)
+++ trunk/LayoutTests/fast/js/boolean-argument-prediction.html	2011-09-29 07:12:10 UTC (rev 96306)
@@ -0,0 +1,13 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script src=""
+script src=""
+/body
+/html


Added: trunk/LayoutTests/fast/js/script-tests/boolean-argument-prediction.js (0 => 96306)

--- trunk/LayoutTests/fast/js/script-tests/boolean-argument-prediction.js	(rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/boolean-argument-prediction.js	2011-09-29 07:12:10 UTC (rev 96306)
@@ -0,0 +1,47 @@
+description(
+This tests that arguments predicted to be boolean are checked.
+);
+
+function predictBooleanArgument(b) {
+if (b) {
+return yes;
+} else {
+return no;
+}
+}
+
+shouldBe(predictBooleanArgument(true), \yes\);
+shouldBe(predictBooleanArgument(false), \no\);
+
+for (var i = 0; i  1000; ++i) {
+predictBooleanArgument(true);
+predictBooleanArgument(false);
+}
+
+shouldBe(predictBooleanArgument(true), \yes\);
+shouldBe(predictBooleanArgument(false), \no\);
+
+shouldBe(predictBooleanArgument(0), \no\);
+shouldBe(predictBooleanArgument(1), \yes\);
+shouldBe(predictBooleanArgument(2), \yes\);
+shouldBe(predictBooleanArgument(3), \yes\);
+shouldBe(predictBooleanArgument(4), \yes\);
+
+for (var i = 0; i  1000; ++i) {
+predictBooleanArgument(0);
+predictBooleanArgument(1);
+predictBooleanArgument(2);
+predictBooleanArgument(3);
+predictBooleanArgument(4);
+}
+
+shouldBe(predictBooleanArgument(true), \yes\);
+shouldBe(predictBooleanArgument(false), \no\);
+
+shouldBe(predictBooleanArgument(0), \no\);
+shouldBe(predictBooleanArgument(1), \yes\);

[webkit-changes] [96308] trunk/LayoutTests

2011-09-29 Thread rniwa

Title: [96308] trunk/LayoutTests








Revision 96308
Author rn...@webkit.org
Date 2011-09-29 00:33:46 -0700 (Thu, 29 Sep 2011)


Log Message
Hopefully the last Chromium test expectation update for r96294.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96307 => 96308)

--- trunk/LayoutTests/ChangeLog	2011-09-29 07:23:08 UTC (rev 96307)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 07:33:46 UTC (rev 96308)
@@ -1,3 +1,9 @@
+2011-09-29  Ryosuke Niwa  rn...@webkit.org
+
+Hopefully the last Chromium test expectation update for r96294.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-29  Tim Horton  timothy_hor...@apple.com
 
 REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96307 => 96308)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 07:23:08 UTC (rev 96307)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 07:33:46 UTC (rev 96308)
@@ -3824,6 +3824,6 @@
 BUGWK63509 : editing/style/smoosh-styles-003.html = PASS FAIL
 
 BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
-BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE+TEXT
+BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE IMAGE+TEXT
 
 BUGWK69062 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96309] trunk/Source/JavaScriptCore

2011-09-29 Thread commit-queue

Title: [96309] trunk/Source/_javascript_Core








Revision 96309
Author commit-qu...@webkit.org
Date 2011-09-29 00:52:49 -0700 (Thu, 29 Sep 2011)


Log Message
JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
https://bugs.webkit.org/show_bug.cgi?id=69054

Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-09-29
Reviewed by Gavin Barraclough.

size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.

* dfg/DFGNode.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96308 => 96309)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 07:33:46 UTC (rev 96308)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 07:52:49 UTC (rev 96309)
@@ -1,3 +1,14 @@
+2011-09-29  Yuqiang Xian  yuqiang.x...@intel.com
+
+JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
+https://bugs.webkit.org/show_bug.cgi?id=69054
+
+Reviewed by Gavin Barraclough.
+
+size_t is equal to uint32_t on most 32-bit platforms, except for Mac OS.
+
+* dfg/DFGNode.h:
+
 2011-09-28  Filip Pizlo  fpi...@apple.com
 
 DFG checkArgumentTypes fails to check boolean predictions


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (96308 => 96309)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-29 07:33:46 UTC (rev 96308)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2011-09-29 07:52:49 UTC (rev 96309)
@@ -342,7 +342,9 @@
 struct OpInfo {
 explicit OpInfo(int32_t value) : m_value(static_castuintptr_t(value)) { }
 explicit OpInfo(uint32_t value) : m_value(static_castuintptr_t(value)) { }
+#if OS(DARWIN) || USE(JSVALUE64)
 explicit OpInfo(size_t value) : m_value(static_castuintptr_t(value)) { }
+#endif
 explicit OpInfo(void* value) : m_value(reinterpret_castuintptr_t(value)) { }
 uintptr_t m_value;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96310] trunk/Source/WebCore

2011-09-29 Thread philn

Title: [96310] trunk/Source/WebCore








Revision 96310
Author ph...@webkit.org
Date 2011-09-29 01:03:31 -0700 (Thu, 29 Sep 2011)


Log Message
[GStreamer] fullscreen video pause/play fails
https://bugs.webkit.org/show_bug.cgi?id=66936

Reviewed by Martin Robinson.

Don't use the identity element to avoid painting of the in-window
video. Instead simply make the sink aware of the fullscreen state
and ignore buffers if fullscreen and autovideosink are
active. Also fixed two deadlocks happening when a paused pipeline
is switched to fullscreen and when fullscreen is disabled for a
paused pipeline.

* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
(WebCore::GStreamerGWorld::isFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkit_video_sink_render):
(webkit_video_sink_new):
* platform/graphics/gstreamer/VideoSinkGStreamer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96309 => 96310)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 07:52:49 UTC (rev 96309)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 08:03:31 UTC (rev 96310)
@@ -1,3 +1,29 @@
+2011-09-29  Philippe Normand  pnorm...@igalia.com
+
+[GStreamer] fullscreen video pause/play fails
+https://bugs.webkit.org/show_bug.cgi?id=66936
+
+Reviewed by Martin Robinson.
+
+Don't use the identity element to avoid painting of the in-window
+video. Instead simply make the sink aware of the fullscreen state
+and ignore buffers if fullscreen and autovideosink are
+active. Also fixed two deadlocks happening when a paused pipeline
+is switched to fullscreen and when fullscreen is disabled for a
+paused pipeline.
+
+* platform/graphics/gstreamer/GStreamerGWorld.cpp:
+(WebCore::GStreamerGWorld::enterFullscreen):
+(WebCore::GStreamerGWorld::exitFullscreen):
+* platform/graphics/gstreamer/GStreamerGWorld.h:
+(WebCore::GStreamerGWorld::isFullscreen):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
+(webkit_video_sink_render):
+(webkit_video_sink_new):
+* platform/graphics/gstreamer/VideoSinkGStreamer.h:
+
 2011-09-29  Tim Horton  timothy_hor...@apple.com
 
 REGRESSION(87010): elements in ECMA-cloud neither filled nor blurred


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp (96309 => 96310)

--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp	2011-09-29 07:52:49 UTC (rev 96309)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp	2011-09-29 08:03:31 UTC (rev 96310)
@@ -89,10 +89,7 @@
 GOwnPtrGstElement videoSink;
 g_object_get(m_pipeline, video-sink, videoSink.outPtr(), NULL);
 GstElement* tee = gst_bin_get_by_name(GST_BIN(videoSink.get()), videoTee);
-GstElement* valve = gst_bin_get_by_name(GST_BIN(videoSink.get()), videoValve);
 
-g_object_set(valve, drop-probability, 1.0, NULL);
-
 // Add and link a queue, ffmpegcolorspace, videoscale and sink in the bin.
 gst_bin_add_many(GST_BIN(videoSink.get()), platformVideoSink, videoScale, colorspace, queue, NULL);
 
@@ -109,12 +106,17 @@
 
 m_dynamicPadName = gst_pad_get_name(srcPad);
 
-// Roll new elements to pipeline state.
-gst_element_sync_state_with_parent(queue);
-gst_element_sync_state_with_parent(colorspace);
-gst_element_sync_state_with_parent(videoScale);
-gst_element_sync_state_with_parent(platformVideoSink);
+// Synchronize the new elements with pipeline state. If it's
+// paused limit the state change to pre-rolling.
+GstState state;
+gst_element_get_state(m_pipeline, state, 0, 0);
+if (state  GST_STATE_PLAYING)
+state = GST_STATE_READY;
 
+gst_element_set_state(platformVideoSink, state);
+gst_element_set_state(videoScale, state);
+gst_element_set_state(colorspace, state);
+gst_element_set_state(queue, state);
 gst_object_unref(tee);
 
 // Query the current media segment informations and send them towards
@@ -160,30 +162,32 @@
 GstElement* colorspace = gst_bin_get_by_name(GST_BIN(videoSink.get()), colorspace);
 GstElement* videoScale =

[webkit-changes] [96311] trunk

2011-09-29 Thread philn

Title: [96311] trunk








Revision 96311
Author ph...@webkit.org
Date 2011-09-29 01:07:19 -0700 (Thu, 29 Sep 2011)


Log Message
[GStreamer] 2 flaky media tests
https://bugs.webkit.org/show_bug.cgi?id=67407

Reviewed by Martin Robinson.

Workaround for GStreamer bug#639941. In GStreamer
0.10.35 basesink reports wrong duration in case of EOS and
negative playback rate. This workaround fixes two media tests,
media/video-timeupdate-reverse-play.html and
media/video-reverse-play-duration.html.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):

Modified Paths

trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp




Diff

Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (96310 => 96311)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-09-29 08:03:31 UTC (rev 96310)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-09-29 08:07:19 UTC (rev 96311)
@@ -11,7 +11,6 @@
 
 BUGWK68536 : media/media-blocked-by-beforeload.html = PASS TEXT
 BUGWK68878 : media/video-playing-and-pause.html = PASS TEXT
-BUGWK67407 : media/video-timeupdate-reverse-play.html = PASS TEXT
 
 BUGWK68523 : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = PASS TEXT
 BUGWK68523 : svg/zoom/page/zoom-svg-through-object-with-override-size.html = PASS TEXT


Modified: trunk/Source/WebCore/ChangeLog (96310 => 96311)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 08:03:31 UTC (rev 96310)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 08:07:19 UTC (rev 96311)
@@ -1,5 +1,23 @@
 2011-09-29  Philippe Normand  pnorm...@igalia.com
 
+[GStreamer] 2 flaky media tests
+https://bugs.webkit.org/show_bug.cgi?id=67407
+
+Reviewed by Martin Robinson.
+
+Workaround for GStreamer bug#639941. In GStreamer
+0.10.35 basesink reports wrong duration in case of EOS and
+negative playback rate. This workaround fixes two media tests,
+media/video-timeupdate-reverse-play.html and
+media/video-reverse-play-duration.html.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
+(WebCore::MediaPlayerPrivateGStreamer::currentTime):
+(WebCore::MediaPlayerPrivateGStreamer::didEnd):
+
+2011-09-29  Philippe Normand  pnorm...@igalia.com
+
 [GStreamer] fullscreen video pause/play fails
 https://bugs.webkit.org/show_bug.cgi?id=66936
 


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (96310 => 96311)

--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2011-09-29 08:03:31 UTC (rev 96310)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp	2011-09-29 08:07:19 UTC (rev 96311)
@@ -354,6 +354,8 @@
 
 void MediaPlayerPrivateGStreamer::prepareToPlay()
 {
+m_isEndReached = false;
+
 if (m_delayingLoad) {
 m_delayingLoad = false;
 commitLoad();
@@ -412,6 +414,14 @@
 if (m_seeking)
 return m_seekTime;
 
+// Workaround for
+// https://bugzilla.gnome.org/show_bug.cgi?id=639941 In GStreamer
+// 0.10.35 basesink reports wrong duration in case of EOS and
+// negative playback rate. There's no upstream accepted patch for
+// this bug yet, hence this temporary workaround.
+if (m_isEndReached  m_playbackRate  0)
+return 0.0f;
+
 return playbackPosition();
 
 }
@@ -1325,6 +1335,8 @@
 m_player-durationChanged();
 }
 
+m_isEndReached = true;
+
 gst_element_set_state(m_playBin, GST_STATE_PAUSED);
 
 timeChanged();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96312] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96312] trunk/LayoutTests








Revision 96312
Author ham...@chromium.org
Date 2011-09-29 01:36:04 -0700 (Thu, 29 Sep 2011)


Log Message
[Chromium] Layout Test svg/filters/animate-fill.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=69070

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96311 => 96312)

--- trunk/LayoutTests/ChangeLog	2011-09-29 08:07:19 UTC (rev 96311)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 08:36:04 UTC (rev 96312)
@@ -1,3 +1,12 @@
+2011-09-29  Shinichiro Hamaji  ham...@chromium.org
+
+[Chromium] Layout Test svg/filters/animate-fill.svg is failing
+https://bugs.webkit.org/show_bug.cgi?id=69070
+
+Unreviewed test_expectations.txt update
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-29  Ryosuke Niwa  rn...@webkit.org
 
 Hopefully the last Chromium test expectation update for r96294.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96311 => 96312)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 08:07:19 UTC (rev 96311)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 08:36:04 UTC (rev 96312)
@@ -3827,3 +3827,5 @@
 BUGWK69060 WIN LINUX : editing/pasteboard/paste-text-006.html = IMAGE IMAGE+TEXT
 
 BUGWK69062 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE
+
+BUGWK69070 MAC CPU-CG : svg/filters/animate-fill.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96313] trunk

2011-09-29 Thread podivilov

Title: [96313] trunk








Revision 96313
Author podivi...@chromium.org
Date 2011-09-29 01:44:57 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
https://bugs.webkit.org/show_bug.cgi?id=69068

Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.
(WebInspector.RawSourceCode): Moved from SourceFile.js.
(WebInspector.UILocation): Moved from SourceFile.js.
* inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js
(WebInspector.ScriptContentProvider):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
(WebInspector.ResourceContentProvider):
(WebInspector.ResourceContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/inspector/front-end/WebKit.qrc
trunk/Source/WebCore/inspector/front-end/inspector.html


Added Paths

trunk/Source/WebCore/inspector/front-end/ContentProviders.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js


Removed Paths

trunk/LayoutTests/inspector/debugger/source-file-expected.txt
trunk/Source/WebCore/inspector/front-end/SourceFile.js




Diff

Deleted: trunk/LayoutTests/inspector/debugger/source-file-expected.txt (96312 => 96313)

--- trunk/LayoutTests/inspector/debugger/source-file-expected.txt	2011-09-29 08:36:04 UTC (rev 96312)
+++ trunk/LayoutTests/inspector/debugger/source-file-expected.txt	2011-09-29 08:44:57 UTC (rev 96313)
@@ -1,13 +0,0 @@
-Tests mapping between raw locations and ui locations.
-
-
-Running: testPlainConvertLocation
-
-Running: testConcatenatedConvertLocation
-
-Running: testFormattedConvertLocation
-
-Running: testConcatenatedFormattedConvertLocation
-
-Running: testUISourceCodeAdded
-


Modified: trunk/Source/WebCore/ChangeLog (96312 => 96313)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 08:36:04 UTC (rev 96312)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 08:44:57 UTC (rev 96313)
@@ -1,3 +1,29 @@
+2011-09-29  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.
+https://bugs.webkit.org/show_bug.cgi?id=69068
+
+Reviewed by Yury Semikhatsky.
+
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* inspector/front-end/RawSourceCode.js: Renamed from Source/WebCore/inspector/front-end/SourceFile.js.
+(WebInspector.RawSourceCode): Moved from SourceFile.js.
+(WebInspector.UILocation): Moved from SourceFile.js.
+* inspector/front-end/UISourceCodeContentProviders.js: Added. Moved ContentProvider implementations from SourceFile.js
+(WebInspector.ScriptContentProvider):
+(WebInspector.ScriptContentProvider.prototype.requestContent):
+(WebInspector.ConcatenatedScriptsContentProvider):
+(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
+(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
+(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
+(WebInspector.ResourceContentProvider):
+(WebInspector.ResourceContentProvider.prototype.requestContent):
+(WebInspector.StaticContentProvider):
+(WebInspector.StaticContentProvider.prototype.requestContent):
+* inspector/front-end/WebKit.qrc:
+* inspector/front-end/inspector.html:
+
 2011-09-29  Philippe Normand  pnorm...@igalia.com
 
 [GStreamer] 2 flaky media tests


Modified: trunk/Source/WebCore/WebCore.gypi (96312 => 96313)

--- trunk/Source/WebCore/WebCore.gypi	2011-09-29 08:36:04 UTC (rev 96312)
+++ trunk/Source/WebCore/WebCore.gypi	2011-09-29 08:44:57 UTC (rev 96313)
@@ -6225,6 +6225,7 @@
 'inspector/front-end/ConsolePanel.js',
 'inspector/front-end/ConsoleView.js',
 'inspector/front-end/_javascript_ContextManager.js',
+'inspector/front-end/ContentProviders.js',
 'inspector/front-end/ContextMenu.js',
 'inspector/front-end/CookieItemsView.js',
 'inspector/front-end/CookieParser.js',
@@ -6288,6 +6289,7 @@
 'inspector/front-end/ProfileView.js',

[webkit-changes] [96314] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96314] trunk/LayoutTests








Revision 96314
Author ham...@chromium.org
Date 2011-09-29 03:07:33 -0700 (Thu, 29 Sep 2011)


Log Message
[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69077

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96313 => 96314)

--- trunk/LayoutTests/ChangeLog	2011-09-29 08:44:57 UTC (rev 96313)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 10:07:33 UTC (rev 96314)
@@ -1,5 +1,14 @@
 2011-09-29  Shinichiro Hamaji  ham...@chromium.org
 
+[Chromium] Layout Test http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=69077
+
+Unreviewed test_expectations.txt update
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Shinichiro Hamaji  ham...@chromium.org
+
 [Chromium] Layout Test svg/filters/animate-fill.svg is failing
 https://bugs.webkit.org/show_bug.cgi?id=69070
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96313 => 96314)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 08:44:57 UTC (rev 96313)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 10:07:33 UTC (rev 96314)
@@ -3829,3 +3829,5 @@
 BUGWK69062 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE
 
 BUGWK69070 MAC CPU-CG : svg/filters/animate-fill.svg = IMAGE
+
+BUGWK69077 DEBUG : http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96316] trunk/LayoutTests

2011-09-29 Thread commit-queue

Title: [96316] trunk/LayoutTests








Revision 96316
Author commit-qu...@webkit.org
Date 2011-09-29 03:33:03 -0700 (Thu, 29 Sep 2011)


Log Message
LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=69067

Patch by Arun Patole bmf...@motorola.com on 2011-09-29
Reviewed by Philippe Normand.

Update expected test result for video-does-not-loop.html
as the 'pause' event should be fired at the end of playback.

* media/video-does-not-loop-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-does-not-loop-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96315 => 96316)

--- trunk/LayoutTests/ChangeLog	2011-09-29 10:30:20 UTC (rev 96315)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 10:33:03 UTC (rev 96316)
@@ -1,3 +1,15 @@
+2011-09-29  Arun Patole  bmf...@motorola.com
+
+LayoutTests: media/video-does-not-loop.html failing on Snow Leopard
+https://bugs.webkit.org/show_bug.cgi?id=69067
+
+Reviewed by Philippe Normand.
+
+Update expected test result for video-does-not-loop.html
+as the 'pause' event should be fired at the end of playback.
+
+* media/video-does-not-loop-expected.txt:
+
 2011-09-29  Shinichiro Hamaji  ham...@chromium.org
 
 [Chromium] some Layout Tests in editing/ is failing


Modified: trunk/LayoutTests/media/video-does-not-loop-expected.txt (96315 => 96316)

--- trunk/LayoutTests/media/video-does-not-loop-expected.txt	2011-09-29 10:30:20 UTC (rev 96315)
+++ trunk/LayoutTests/media/video-does-not-loop-expected.txt	2011-09-29 10:33:03 UTC (rev 96316)
@@ -13,6 +13,7 @@
 EXPECTED (video.ended == 'false') OK
 RUN(video.play())
 
+EVENT(pause)
 EVENT(ended)
 
 ++ played to end and stopped.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96317] trunk/Source/WebKit2

2011-09-29 Thread carlosgc

Title: [96317] trunk/Source/WebKit2








Revision 96317
Author carlo...@webkit.org
Date 2011-09-29 04:00:04 -0700 (Thu, 29 Sep 2011)


Log Message
[GTK] Explicitly call destructors for objects initialized with placement new syntax
https://bugs.webkit.org/show_bug.cgi?id=69079

Reviewed by Xan Lopez.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96316 => 96317)

--- trunk/Source/WebKit2/ChangeLog	2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-29 11:00:04 UTC (rev 96317)
@@ -1,3 +1,19 @@
+2011-09-29  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Explicitly call destructors for objects initialized with placement new syntax
+https://bugs.webkit.org/show_bug.cgi?id=69079
+
+Reviewed by Xan Lopez.
+
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
+* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
+(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
+(webkit_web_loader_client_class_init):
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
+(webkit_web_view_class_init):
+
 2011-09-28  Martin Robinson  mrobin...@igalia.com
 
 Fix the WebGL build on WebKit2 GTK+.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (96316 => 96317)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2011-09-29 11:00:04 UTC (rev 96317)
@@ -36,6 +36,10 @@
 
 WKRelease(context-priv-context);
 context-priv-context = 0;
+
+context-priv-~WebKitWebContextPrivate();
+
+G_OBJECT_CLASS(webkit_web_context_parent_class)-finalize(object);
 }
 
 static void webkit_web_context_init(WebKitWebContext* webContext)


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp (96316 => 96317)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp	2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp	2011-09-29 11:00:04 UTC (rev 96317)
@@ -182,6 +182,12 @@
 }
 }
 
+static void webkitWebLoaderClientFinalize(GObject* object)
+{
+WEBKIT_WEB_LOADER_CLIENT(object)-priv-~WebKitWebLoaderClientPrivate();
+G_OBJECT_CLASS(webkit_web_loader_client_parent_class)-finalize(object);
+}
+
 static void webkit_web_loader_client_init(WebKitWebLoaderClient* client)
 {
 WebKitWebLoaderClientPrivate* priv = G_TYPE_INSTANCE_GET_PRIVATE(client, WEBKIT_TYPE_WEB_LOADER_CLIENT, WebKitWebLoaderClientPrivate);
@@ -196,6 +202,7 @@
 objectClass-set_property = webkitWebLoaderClientSetProperty;
 objectClass-get_property = webkitWebLoaderClientGetProperty;
 objectClass-constructed = webkitWebLoaderClientConstructed;
+objectClass-finalize = webkitWebLoaderClientFinalize;
 
 /**
  * WebKitWebView:web-view:


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (96316 => 96317)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2011-09-29 10:33:03 UTC (rev 96316)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2011-09-29 11:00:04 UTC (rev 96317)
@@ -83,6 +83,12 @@
 }
 }
 
+static void webkitWebViewFinalize(GObject* object)
+{
+WEBKIT_WEB_VIEW(object)-priv-~WebKitWebViewPrivate();
+G_OBJECT_CLASS(webkit_web_view_parent_class)-finalize(object);
+}
+
 static void webkit_web_view_init(WebKitWebView* webView)
 {
 WebKitWebViewPrivate* priv = G_TYPE_INSTANCE_GET_PRIVATE(webView, WEBKIT_TYPE_WEB_VIEW, WebKitWebViewPrivate);
@@ -97,6 +103,7 @@
 gObjectClass-constructed = webkitWebViewConstructed;
 gObjectClass-set_property = webkitWebViewSetProperty;
 gObjectClass-get_property = webkitWebViewGetProperty;
+gObjectClass-finalize = webkitWebViewFinalize;
 
 g_type_class_add_private(webViewClass, sizeof(WebKitWebViewPrivate));
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96318] trunk/Source/WebCore

2011-09-29 Thread caseq

Title: [96318] trunk/Source/WebCore








Revision 96318
Author ca...@chromium.org
Date 2011-09-29 04:06:15 -0700 (Thu, 29 Sep 2011)


Log Message
2011-09-28  Andrey Kosyakov  ca...@chromium.org

Web Inspector: network log view refresh optimizations
https://bugs.webkit.org/show_bug.cgi?id=69010

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.refresh):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (96317 => 96318)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 11:00:04 UTC (rev 96317)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 11:06:15 UTC (rev 96318)
@@ -1,3 +1,13 @@
+2011-09-28  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: network log view refresh optimizations
+https://bugs.webkit.org/show_bug.cgi?id=69010
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView.prototype.refresh):
+
 2011-09-29  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: split SourceFile.js into RawSourceCode.js and UISourceCodeContentProviders.js.


Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (96317 => 96318)

--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-09-29 11:00:04 UTC (rev 96317)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-09-29 11:06:15 UTC (rev 96318)
@@ -696,9 +696,8 @@
 this._staleResources = [];
 this._sortItems();
 this._updateSummaryBar();
-this._updateOffscreenRows();
 this._dataGrid.updateWidths();
-
+// FIXME: evaluate performance impact of moving this before a call to sortItems()
 if (wasScrolledToLastRow)
 this._dataGrid.scrollToLastRow();
 },
@@ -1814,6 +1813,8 @@
 WebInspector.NetworkDataGridNode.prototype = {
 createCells: function()
 {
+// Out of sight, out of mind: create nodes offscreen to save on render tree update times when running updateOffscreenRows()
+this._element.addStyleClass(offscreen);
 this._nameCell = this._createDivInTD(name);
 this._methodCell = this._createDivInTD(method);
 this._statusCell = this._createDivInTD(status);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96319] trunk

2011-09-29 Thread pfeldman

Title: [96319] trunk








Revision 96319
Author pfeld...@chromium.org
Date 2011-09-29 04:39:11 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):

LayoutTests:

* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
* platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/LayoutTests/inspector/debugger/scripts-sorting-expected.txt
trunk/LayoutTests/inspector/debugger/scripts-sorting.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js


Removed Paths

trunk/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt
trunk/LayoutTests/platform/chromium-win/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/platform/mac/inspector/debugger/scripts-panel-expected.txt
trunk/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96318 => 96319)

--- trunk/LayoutTests/ChangeLog	2011-09-29 11:06:15 UTC (rev 96318)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 11:39:11 UTC (rev 96319)
@@ -1,3 +1,19 @@
+2011-09-27  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
+https://bugs.webkit.org/show_bug.cgi?id=68827
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/scripts-panel-expected.txt:
+* inspector/debugger/scripts-panel.html:
+* inspector/debugger/scripts-sorting-expected.txt:
+* inspector/debugger/scripts-sorting.html:
+* platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
+* platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
+* platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
+* platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
+
 2011-09-29  Arun Patole  bmf...@motorola.com
 
 LayoutTests: media/video-does-not-loop.html failing on Snow Leopard


Modified: trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt (96318 => 96319)

--- trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-09-29 11:06:15 UTC (rev 96318)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel-expected.txt	2011-09-29 11:39:11 UTC (rev 96319)
@@ -28,6 +28,7 @@
 LayoutTests/inspector/debugger/foo/baz
 script.js(root/foo/baz/script.js)
 — Content scripts —
+LayoutTests/inspector/debugger/foo/bar
 contentScript.js?a=1(root/foo/bar/contentScript.js?a=1)
 contentScript.js?a=2(root/foo/bar/contentScript.js?a=2)
 contentScript2.js?a=1(root/foo/bar/contentScript2.js?a=1)


Modified: trunk/LayoutTests/inspector/debugger/scripts-panel.html (96318 => 96319)

--- trunk/LayoutTests/inspector/debugger/scripts-panel.html	2011-09-29 11:06:15 UTC (rev 96318)
+++ trunk/LayoutTests/inspector/debugger/scripts-panel.html	2011-09-29 11:39:11 UTC (rev 96319)
@@ -6,6 +6,9 @@
 
 function test()
 {
+// Always use indentation in scripts drop box
+WebInspector._isMac = false;
+
 function createDebuggerPresentationModelMock()
 {
 var model = new WebInspector.Object();


Modified: trunk/LayoutTests/inspector/debugger/scripts-sorting-expected.txt (96318 => 96319)

--- trunk/LayoutTests/inspector/debugger/scripts-sorting-expected.txt	2011-09-29 11:06:15 UTC (rev 96318)
+++ trunk/LayoutTests/inspector/debugger/scripts-sorting-expected.txt	2011-09-29 11:39:11 UTC (rev 96319)
@@ -3,9 +3,81 @@
 Debugger was enabled.
 
 WebInspector.settings.showScriptFolders = true
+*Non*URL*path
+— bar.com —
+/foo/path
+bar.js?file=bar/zzz.js
+foo.js?file=bar/aaa.js
+— foo.com —
+block.js?block=foo
+ga.js
+lenta.ban?pg=4883ifr=1
+lenta.ban?pg=5309ifr=1
+top100.jcn?80674
+/_js/production
+motor.js?1308927432
+/foo/path
+bar.js?file=bar/zzz.js
+foo.js?file=bar/aaa.js
+/i
+xgemius.js
+/i/js
+jquery-1.5.1.min.js
+jquery.cookie.js
+— Content scripts —
+*Non*URL*path
+extension-name
+

[webkit-changes] [96320] trunk/Source/WebCore

2011-09-29 Thread pfeldman

Title: [96320] trunk/Source/WebCore








Revision 96320
Author pfeld...@chromium.org
Date 2011-09-29 04:49:53 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: make inspector protocol validation a part of the build process.
https://bugs.webkit.org/show_bug.cgi?id=68999

Since we'd like to commit to inspector protocol backwards compatibility, violating it
should be a build failure.

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/Inspector.draft-01.json:
* inspector/Inspector.json:
* inspector/generate-inspector-idl:
* inspector/generate-protocol-externs:
* inspector/validate-protocol-compatibility:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/CodeGenerators.pri
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/inspector/Inspector.draft-01.json
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/generate-inspector-idl
trunk/Source/WebCore/inspector/generate-protocol-externs
trunk/Source/WebCore/inspector/validate-protocol-compatibility




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (96319 => 96320)

--- trunk/Source/WebCore/CMakeLists.txt	2011-09-29 11:39:11 UTC (rev 96319)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-09-29 11:49:53 UTC (rev 96320)
@@ -2204,6 +2204,13 @@
 
 # All Web Inspector generated files are created with this one call to CodeGeneratorInspector.pm
 ADD_CUSTOM_COMMAND(
+OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/Inspector.json.validated
+MAIN_DEPENDENCY inspector/Inspector.json
+DEPENDS ${WEBCORE_DIR}/inspector/validate-protocol-compatibility ${WEBCORE_DIR}/inspector/Inspector.json
+COMMAND ${PYTHON_EXECUTABLE} ${WEBCORE_DIR}/inspector/validate-protocol-compatibility -o ${DERIVED_SOURCES_WEBCORE_DIR}/Inspector.json.validated ${WEBCORE_DIR}/inspector/Inspector.json
+VERBATIM)
+
+ADD_CUSTOM_COMMAND(
 OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/Inspector.idl
 MAIN_DEPENDENCY inspector/Inspector.json
 DEPENDS ${WEBCORE_DIR}/inspector/generate-inspector-idl ${WEBCORE_DIR}/inspector/Inspector.json


Modified: trunk/Source/WebCore/ChangeLog (96319 => 96320)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 11:39:11 UTC (rev 96319)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 11:49:53 UTC (rev 96320)
@@ -1,3 +1,24 @@
+2011-09-28  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: make inspector protocol validation a part of the build process.
+https://bugs.webkit.org/show_bug.cgi?id=68999
+
+Since we'd like to commit to inspector protocol backwards compatibility, violating it
+should be a build failure.
+
+Reviewed by Yury Semikhatsky.
+
+* CMakeLists.txt:
+* CodeGenerators.pri:
+* DerivedSources.make:
+* GNUmakefile.am:
+* WebCore.gyp/WebCore.gyp:
+* inspector/Inspector.draft-01.json:
+* inspector/Inspector.json:
+* inspector/generate-inspector-idl:
+* inspector/generate-protocol-externs:
+* inspector/validate-protocol-compatibility:
+
 2011-09-27  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: Scripts panel without folders causes errors when creating content scripts section.


Modified: trunk/Source/WebCore/CodeGenerators.pri (96319 => 96320)

--- trunk/Source/WebCore/CodeGenerators.pri	2011-09-29 11:39:11 UTC (rev 96319)
+++ trunk/Source/WebCore/CodeGenerators.pri	2011-09-29 11:49:53 UTC (rev 96320)
@@ -668,6 +668,14 @@
 addExtraCompiler(idl)
 
 # GENERATOR 2: inspector idl compiler
+inspectorValidate.output = $${WC_GENERATED_SOURCES_DIR}/Inspector.json.validated
+inspectorValidate.input = INSPECTOR_JSON
+inspectorValidate.wkScript = $$PWD/inspector/validate-protocol-compatibility
+inspectorValidate.commands = python $$inspectorValidate.wkScript -o $${WC_GENERATED_SOURCES_DIR}/Inspector.json.validated $$PWD/inspector/Inspector.json
+inspectorValidate.depends = $$PWD/inspector/validate-protocol-compatibility
+inspectorValidate.wkAddOutputToSources = false
+addExtraCompiler(inspectorValidate)
+
 inspectorJSON.output = $${WC_GENERATED_SOURCES_DIR}/Inspector.idl
 inspectorJSON.input = INSPECTOR_JSON
 inspectorJSON.wkScript = $$PWD/inspector/generate-inspector-idl


Modified: trunk/Source/WebCore/DerivedSources.make (96319 => 96320)

--- trunk/Source/WebCore/DerivedSources.make	2011-09-29 11:39:11 UTC (rev 96319)
+++ trunk/Source/WebCore/DerivedSources.make	2011-09-29 11:49:53 UTC (rev 96320)
@@ -888,6 +888,9 @@
 
 # Inspector interfaces generator
 
+Inspector.json.validated : Inspector.json inspector/validate-protocol-compatibility
+	python $(WebCore)/inspector/validate-protocol-compatibility -o Inspector.json.validated $(WebCore)/inspector/Inspector.json
+
 Inspector.idl : Inspector.json inspector/generate-inspector-idl
 	python

[webkit-changes] [96321] trunk/Source/WebCore

2011-09-29 Thread loislo

Title: [96321] trunk/Source/WebCore








Revision 96321
Author loi...@chromium.org
Date 2011-09-29 04:59:27 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
https://bugs.webkit.org/show_bug.cgi?id=69081

There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.

Reviewed by Pavel Feldman.

Test: inspector/performance/resources/network-append-30-requests.html

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (96320 => 96321)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 11:49:53 UTC (rev 96320)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 11:59:27 UTC (rev 96321)
@@ -1,3 +1,24 @@
+2011-09-29  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
+https://bugs.webkit.org/show_bug.cgi?id=69081
+
+There is a test with 30 requests.
+For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
+NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
+This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.
+
+Reviewed by Pavel Feldman.
+
+Test: inspector/performance/resources/network-append-30-requests.html
+
+* inspector/front-end/NetworkPanel.js:
+(WebInspector.NetworkLogView):
+(WebInspector.NetworkLogView.prototype._invalidateAllItems):
+(WebInspector.NetworkLogView.prototype.refresh):
+(WebInspector.NetworkLogView.prototype._reset):
+(WebInspector.NetworkLogView.prototype._refreshResource):
+
 2011-09-28  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: make inspector protocol validation a part of the build process.


Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (96320 => 96321)

--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-09-29 11:49:53 UTC (rev 96320)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-09-29 11:59:27 UTC (rev 96321)
@@ -42,7 +42,7 @@
 this._resources = [];
 this._resourcesById = {};
 this._resourcesByURL = {};
-this._staleResources = [];
+this._staleResources = {};
 this._resourceGridNodes = {};
 this._lastResourceGridNodeId = 0;
 this._mainResourceLoadTime = -1;
@@ -578,7 +578,10 @@
 
 _invalidateAllItems: function()
 {
-this._staleResources = this._resources.slice();
+for (var i = 0; i  this._resources.length; ++i) {
+var resource = this._resources[i];
+this._staleResources[resource.requestId] = resource;
+}
 },
 
 get calculator()
@@ -660,15 +663,14 @@
 
 this._removeAllNodeHighlights();
 var wasScrolledToLastRow = this._dataGrid.isScrolledToLastRow();
-var staleItemsLength = this._staleResources.length;
 var boundariesChanged = false;
 if (this.calculator.updateBoundariesForEventTime) {
 boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceLoadTime) || boundariesChanged;
 boundariesChanged = this.calculator.updateBoundariesForEventTime(this._mainResourceDOMContentTime) || boundariesChanged;
 }
 
-for (var i = 0; i  staleItemsLength; ++i) {
-var resource = this._staleResources[i];
+for (var resourceId in this._staleResources) {
+var resource = this._staleResources[resourceId];
 var node = this._resourceGridNode(resource);
 if (!node) {
 // Create the timeline tree element and graph.
@@ -687,13 +689,12 @@
 if (boundariesChanged) {
 // The boundaries changed, so all item graphs are stale.
 this._invalidateAllItems();
-staleItemsLength = this._staleResources.length;
 }
 
-for (var i = 0; i  staleItemsLength; ++i)
-this._resourceGridNode(this._staleResources[i]).refreshGraph(this.calculator);
+for (var resourceId in this._staleResources)
+

[webkit-changes] [96322] trunk

2011-09-29 Thread hans

Title: [96322] trunk








Revision 96322
Author h...@chromium.org
Date 2011-09-29 05:29:13 -0700 (Thu, 29 Sep 2011)


Log Message
IndexedDB: Use LevelDB also for in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=68903

Reviewed by Steve Block.

Source/WebCore:

Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
to create in-memory LevelDB databases.

Use this in IDBLeveLDBBackingStore::open() when the caller passes in
an empty file path.
This happens in Chromium's incognito mode, and when running layout
tests.

Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
files when passed in an empty file path, but uses the in-memory mode
instead.

Existing layout tests will all be run in-memory.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::~LevelDBDatabase):
(WebCore::openDB):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):
* platform/leveldb/LevelDBDatabase.h:
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):
* storage/IDBSQLiteBackingStore.cpp:
(WebCore::IDBSQLiteBackingStore::backingStoreExists):

Source/WebKit/chromium:

Don't fall back to SQLite or use a temporary dir for in-memory
databases (Incognito and layout tests); LevelDB supports in-memory
databases now.

* public/WebIDBFactory.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

Tools:

Remove the temporary dir that was necessary before LevelDB supported
in-memory databases.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
* DumpRenderTree/chromium/TestShell.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp
trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.h
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBSQLiteBackingStore.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebIDBFactory.h
trunk/Source/WebKit/chromium/src/WebIDBFactoryImpl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96321 => 96322)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 11:59:27 UTC (rev 96321)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 12:29:13 UTC (rev 96322)
@@ -1,3 +1,35 @@
+2011-09-29  Hans Wennborg  h...@chromium.org
+
+IndexedDB: Use LevelDB also for in-memory databases
+https://bugs.webkit.org/show_bug.cgi?id=68903
+
+Reviewed by Steve Block.
+
+Add LevelDBDatabase::openInMemory() which uses leveldb::NewMemEnv()
+to create in-memory LevelDB databases.
+
+Use this in IDBLeveLDBBackingStore::open() when the caller passes in
+an empty file path.
+This happens in Chromium's incognito mode, and when running layout
+tests.
+
+Fix IDBSQLiteBackingStore::backingStoreExists() so it doesn't create
+files when passed in an empty file path, but uses the in-memory mode
+instead.
+
+Existing layout tests will all be run in-memory.
+
+* platform/leveldb/LevelDBDatabase.cpp:
+(WebCore::LevelDBDatabase::~LevelDBDatabase):
+(WebCore::openDB):
+(WebCore::LevelDBDatabase::open):
+(WebCore::LevelDBDatabase::openInMemory):
+* platform/leveldb/LevelDBDatabase.h:
+* storage/IDBLevelDBBackingStore.cpp:
+(WebCore::IDBLevelDBBackingStore::open):
+* storage/IDBSQLiteBackingStore.cpp:
+(WebCore::IDBSQLiteBackingStore::backingStoreExists):
+
 2011-09-29  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: speed-up Network panel. Change _staleResources type from array to object.


Modified: trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp (96321 => 96322)

--- trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp	2011-09-29 11:59:27 UTC (rev 96321)
+++ trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp	2011-09-29 12:29:13 UTC (rev 96322)
@@ -33,8 +33,10 @@
 #include LevelDBSlice.h
 #include LevelDBWriteBatch.h
 #include Logging.h
+#include helpers/memenv/memenv.h
 #include leveldb/comparator.h
 #include leveldb/db.h
+#include leveldb/env.h
 #include leveldb/slice.h
 #include string
 #include wtf/PassOwnPtr.h
@@ -96,18 +98,26 @@
 // m_db's destructor uses m_comparatorAdapter; order of deletion is important.
 m_db.clear();
 m_comparatorAdapter.clear();
+m_env.clear();
 }
 
+static leveldb::Status openDB(leveldb::Comparator* comparator, leveldb::Env* env, const String path, leveldb::DB** db)
+{
+leveldb::Options options;
+options.comparator = comparator;
+options.create_if_missing = true;
+options.paranoid_checks = true;
+options.env = env;
+
+return leveldb::DB::Open(options, path.utf8().data(), db);
+}
+
 PassOwnPtrLevelDBDatabase LevelDBDatabase::open(const String fileName, const

[webkit-changes] [96323] trunk

2011-09-29 Thread vsevik

Title: [96323] trunk








Revision 96323
Author vse...@chromium.org
Date 2011-09-29 05:59:17 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: Make search-in-resource test simpler.
https://bugs.webkit.org/show_bug.cgi?id=69025

Source/WebCore:

Changed search-in-resource test.
Removed error parameter from content provider's searchInContent callback.

Reviewed by Pavel Feldman.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.searchInContent):

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector/search/search-in-resource-expected.txt:
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-resources.html:
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
(initialize_SearchTest):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/search/search-in-resource-expected.txt
trunk/LayoutTests/http/tests/inspector/search/search-in-resource.html
trunk/LayoutTests/http/tests/inspector/search/search-in-resources.html
trunk/LayoutTests/http/tests/inspector/search/search-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp
trunk/Source/WebCore/inspector/front-end/Resource.js




Diff

Modified: trunk/LayoutTests/ChangeLog (96322 => 96323)

--- trunk/LayoutTests/ChangeLog	2011-09-29 12:29:13 UTC (rev 96322)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 12:59:17 UTC (rev 96323)
@@ -1,3 +1,22 @@
+2011-09-29  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Make search-in-resource test simpler.
+https://bugs.webkit.org/show_bug.cgi?id=69025
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/search/search-in-resource-expected.txt:
+* http/tests/inspector/search/search-in-resource.html:
+* http/tests/inspector/search/search-in-resources.html:
+* http/tests/inspector/search/search-test.js:
+(initialize_SearchTest.InspectorTest.runAfterResourcesAreCreated):
+(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated):
+(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.maybeCallback):
+(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.addSniffer):
+(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.onResourceBind):
+(initialize_SearchTest.InspectorTest._runAfterResourcesAreCreated.visit):
+(initialize_SearchTest):
+
 2011-09-27  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: Scripts panel without folders causes errors when creating content scripts section.


Modified: trunk/LayoutTests/http/tests/inspector/search/search-in-resource-expected.txt (96322 => 96323)

--- trunk/LayoutTests/http/tests/inspector/search/search-in-resource-expected.txt	2011-09-29 12:29:13 UTC (rev 96322)
+++ trunk/LayoutTests/http/tests/inspector/search/search-in-resource-expected.txt	2011-09-29 12:59:17 UTC (rev 96323)
@@ -8,16 +8,4 @@
 lineNumber: 9, line: 'searchTestUniqueString();'
 lineNumber: 10, line: '// SEARCHTestUniqueString();'
 
-http://127.0.0.1:8000/inspector/search/resources/search.css
-Search matches: 
-lineNumber: 0, line: 'div.searchTestUniqueString {'
-lineNumber: 4, line: 'div.searchTestUniqueString:hover {'
-lineNumber: 5, line: '/* another searchTestUniqueString occurence */'
 
-http://127.0.0.1:8000/inspector/search/resources/search.html
-Search matches: 
-lineNumber: 5, line: 'divsearchTestUniqueString/div'
-lineNumber: 7, line: '!-- searchTestUniqueString --'
-lineNumber: 9, line: 'div id=searchTestUniqueStringdiv text/div'
-
-


Modified: trunk/LayoutTests/http/tests/inspector/search/search-in-resource.html (96322 => 96323)

--- trunk/LayoutTests/http/tests/inspector/search/search-in-resource.html	2011-09-29 12:29:13 UTC (rev 96322)
+++ trunk/LayoutTests/http/tests/inspector/search/search-in-resource.html	2011-09-29 12:59:17 UTC (rev 96323)
@@ -1,41 +1,24 @@
 html
 head
 script src=""
-script src=""
 script src=""
 script
 function test()
 {
 // This file should not match search query.
 var text = searchTest + UniqueString;
-InspectorTest.runAfterResourcesAreFinished([search.js, search.css, search.html], step2);
+InspectorTest.runAfterResourcesAreCreated([search.js], step2);
 
 function step2()
 {
 var resource =

[webkit-changes] [96324] trunk/Source/WebKit2

2011-09-29 Thread carlosgc

Title: [96324] trunk/Source/WebKit2








Revision 96324
Author carlo...@webkit.org
Date 2011-09-29 06:53:53 -0700 (Thu, 29 Sep 2011)


Log Message
[GTK] Force single header include in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69084

Reviewed by Martin Robinson.

Only webkit2/webkit2.h will be allowed for API users.

* GNUmakefile.am:
* UIProcess/API/gtk/WebKitError.h:
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/WebKitWebLoaderClient.h:
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewBase.h:
* UIProcess/API/gtk/webkit2.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitError.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.h
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96323 => 96324)

--- trunk/Source/WebKit2/ChangeLog	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-29 13:53:53 UTC (rev 96324)
@@ -1,5 +1,22 @@
 2011-09-29  Carlos Garcia Campos  cgar...@igalia.com
 
+[GTK] Force single header include in WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=69084
+
+Reviewed by Martin Robinson.
+
+Only webkit2/webkit2.h will be allowed for API users.
+
+* GNUmakefile.am:
+* UIProcess/API/gtk/WebKitError.h:
+* UIProcess/API/gtk/WebKitWebContext.h:
+* UIProcess/API/gtk/WebKitWebLoaderClient.h:
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/WebKitWebViewBase.h:
+* UIProcess/API/gtk/webkit2.h:
+
+2011-09-29  Carlos Garcia Campos  cgar...@igalia.com
+
 [GTK] Explicitly call destructors for objects initialized with placement new syntax
 https://bugs.webkit.org/show_bug.cgi?id=69079
 


Modified: trunk/Source/WebKit2/GNUmakefile.am (96323 => 96324)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-09-29 13:53:53 UTC (rev 96324)
@@ -879,6 +879,7 @@
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebCore \
 	-I$(top_builddir)/DerivedSources/WebKit2/include/WebKit2 \
 	-DLIBEXECDIR=\$(libexecdir)\ \
+	-DWEBKIT2_COMPILATION \
 	$(webcore_cppflags) \
 	$(webcoregtk_cppflags) \
 	$(_javascript_core_cppflags) \
@@ -1005,6 +1006,9 @@
 stamp-webkit2enumtypes: $(webkit2gtk_headers) $(WebKit2)/GNUmakefile.am
 	$(AM_V_GEN)mkdir -p $(GENSOURCES_WEBKIT2)/webkit2gtk/webkit2 \
 	 glib-mkenums \
+			--fhead #if !defined(__WEBKIT2_H_INSIDE__)  !defined(WEBKIT2_COMPILATION)\n \
+			--fhead #error \Only webkit2/webkit2.h can be included directly.\\n \
+			--fhead #endif\n\n \
 			--fhead #ifndef WEBKIT_ENUM_TYPES_H\n \
 			--fhead #define WEBKIT_ENUM_TYPES_H\n\n \
 			--fhead #include glib-object.h\n\n \


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitError.h (96323 => 96324)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitError.h	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitError.h	2011-09-29 13:53:53 UTC (rev 96324)
@@ -18,6 +18,10 @@
  * Boston, MA 02110-1301, USA.
  */
 
+#if !defined(__WEBKIT2_H_INSIDE__)  !defined(WEBKIT2_COMPILATION)
+#error Only webkit2/webkit2.h can be included directly.
+#endif
+
 #ifndef WebKitError_h
 #define WebKitError_h
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h (96323 => 96324)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h	2011-09-29 13:53:53 UTC (rev 96324)
@@ -17,6 +17,10 @@
  * Boston, MA 02110-1301, USA.
  */
 
+#if !defined(__WEBKIT2_H_INSIDE__)  !defined(WEBKIT2_COMPILATION)
+#error Only webkit2/webkit2.h can be included directly.
+#endif
+
 #ifndef WebKitWebContext_h
 #define WebKitWebContext_h
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h (96323 => 96324)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.h	2011-09-29 13:53:53 UTC (rev 96324)
@@ -17,6 +17,10 @@
  * Boston, MA 02110-1301, USA.
  */
 
+#if !defined(__WEBKIT2_H_INSIDE__)  !defined(WEBKIT2_COMPILATION)
+#error Only webkit2/webkit2.h can be included directly.
+#endif
+
 #ifndef WebKitWebLoaderClient_h
 #define WebKitWebLoaderClient_h
 


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h (96323 => 96324)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h	2011-09-29 12:59:17 UTC (rev 96323)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h	2011-09-29 13:53:53 UTC (rev 96324)
@@ -20,6 +20,10 @@
  * Boston, MA 02110-1301, USA.
  */
 
+#if !defined(__WEBKIT2_H_INSIDE__)

[webkit-changes] [96325] trunk

2011-09-29 Thread sergio

Title: [96325] trunk








Revision 96325
Author ser...@webkit.org
Date 2011-09-29 06:59:23 -0700 (Thu, 29 Sep 2011)


Log Message
[GTK] Bump version to 1.7.0
https://bugs.webkit.org/show_bug.cgi?id=69082

Reviewed by Martin Robinson.

Apart from bumping the library version to 1.7.0 this patch also
sets the libtool version to the same one we have for the stable
branch.

* configure.ac:

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (96324 => 96325)

--- trunk/ChangeLog	2011-09-29 13:53:53 UTC (rev 96324)
+++ trunk/ChangeLog	2011-09-29 13:59:23 UTC (rev 96325)
@@ -1,3 +1,16 @@
+2011-09-29  Sergio Villar Senin  svil...@igalia.com
+
+[GTK] Bump version to 1.7.0
+https://bugs.webkit.org/show_bug.cgi?id=69082
+
+Reviewed by Martin Robinson.
+
+Apart from bumping the library version to 1.7.0 this patch also
+sets the libtool version to the same one we have for the stable
+branch.
+
+* configure.ac:
+
 2011-09-28  Martin Robinson  mrobin...@igalia.com
 
 Fix the WebKit2 WebGL build.


Modified: trunk/configure.ac (96324 => 96325)

--- trunk/configure.ac	2011-09-29 13:53:53 UTC (rev 96324)
+++ trunk/configure.ac	2011-09-29 13:59:23 UTC (rev 96325)
@@ -1,8 +1,8 @@
 AC_PREREQ(2.59)
 
 m4_define([webkit_major_version], [1])
-m4_define([webkit_minor_version], [5])
-m4_define([webkit_micro_version], [90])
+m4_define([webkit_minor_version], [7])
+m4_define([webkit_micro_version], [0])
 
 # This is the version we'll be using as part of our User-Agent string
 # e.g., AppleWebKit/$(webkit_user_agent_version) ...
@@ -35,7 +35,7 @@
 
 dnl # Libtool library version, not to confuse with API version
 dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html
-LIBWEBKITGTK_VERSION=9:1:9
+LIBWEBKITGTK_VERSION=11:0:11
 AC_SUBST([LIBWEBKITGTK_VERSION])
 
 AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96326] trunk

2011-09-29 Thread loislo

Title: [96326] trunk








Revision 96326
Author loi...@chromium.org
Date 2011-09-29 07:30:38 -0700 (Thu, 29 Sep 2011)


Log Message
Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
https://bugs.webkit.org/show_bug.cgi?id=69087

The fix has the changes for the test and minor perf framework improvements.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._defaultRefreshDelay.500._scheduleRefresh):

LayoutTests:

* inspector/performance/resources/network-append-30-requests.html:
* inspector/performance/resources/performance-test.js:
(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):
(initialize_TimeTracker.InspectorTest.mark):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html
trunk/LayoutTests/inspector/performance/resources/performance-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/LayoutTests/ChangeLog (96325 => 96326)

--- trunk/LayoutTests/ChangeLog	2011-09-29 13:59:23 UTC (rev 96325)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 14:30:38 UTC (rev 96326)
@@ -1,3 +1,18 @@
+2011-09-29  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.
+https://bugs.webkit.org/show_bug.cgi?id=69087
+
+The fix has the changes for the test and minor perf framework improvements.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/performance/resources/network-append-30-requests.html:
+* inspector/performance/resources/performance-test.js:
+(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype.done):
+(initialize_TimeTracker.InspectorTest.runPerformanceTest):
+(initialize_TimeTracker.InspectorTest.mark):
+
 2011-09-29  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Make search-in-resource test simpler.


Modified: trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html (96325 => 96326)

--- trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html	2011-09-29 13:59:23 UTC (rev 96325)
+++ trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html	2011-09-29 14:30:38 UTC (rev 96326)
@@ -17,18 +17,22 @@
 {
 WebInspector.showPanel(network);
 
+var originalRefresh = InspectorTest.override(WebInspector.panels.network._networkLogView, refresh, timeTrackingRefresh, true);
+WebInspector.panels.network._networkLogView._defaultRefreshDelay = 30;
+function timeTrackingRefresh()
+{
+var cookie = InspectorTest.timer.start(network-append-30-requests);
+originalRefresh.call(this);
+InspectorTest.timer.finish(cookie);
+InspectorTest.timer.done();
+}
+
 function test(timer)
 {
 WebInspector.panels.network._networkLogView._reset();
-var cookie = timer.start(network-append-30-requests);
 InspectorTest.evaluateInPage(makeXHRRequests(30));
-function finish()
-{
-timer.finish(cookie);
-timer.done();
-}
-InspectorTest.addSniffer(WebInspector.panels.network._networkLogView, refresh, finish);
 }
+
 InspectorTest.runPerformanceTest(test, 15000);
 }
 


Modified: trunk/LayoutTests/inspector/performance/resources/performance-test.js (96325 => 96326)

--- trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-29 13:59:23 UTC (rev 96325)
+++ trunk/LayoutTests/inspector/performance/resources/performance-test.js	2011-09-29 14:30:38 UTC (rev 96326)
@@ -43,6 +43,10 @@
 if (time - this._testStartTime  executeTime)
 this._runTest();
 else {
+if (this._complete)
+return;
+this._complete = true;
+
 this._dump();
 if (this._callback)
 this._callback();
@@ -77,10 +81,22 @@
 
 }
 
-var timer = new Timer(perfTest, callback);
-timer._runTest();
+InspectorTest.timer = new Timer(perfTest, callback);
+InspectorTest.timer._runTest();
 }
 
+InspectorTest.mark = function(markerName)
+{
+var timer = InspectorTest.timer;
+if (!timer)
+return;
+
+if (InspectorTest.lastMarkCookie)
+timer.finish(InspectorTest.lastMarkCookie);
+
+InspectorTest.lastMarkCookie = markerName ? timer.start(markerName) : null;
+}
+
 InspectorTest.dumpTestStats = function(testName, samples, divider)
 {
 divider = divider || 1;


Modified: trunk/Source/WebCore/ChangeLog (96325 => 96326)

--- trunk/Source/WebCore/ChangeLog

[webkit-changes] [96327] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96327] trunk/LayoutTests








Revision 96327
Author aba...@webkit.org
Date 2011-09-29 08:32:02 -0700 (Thu, 29 Sep 2011)


Log Message
Update baselines.

* platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
* platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
* platform/chromium-mac-leopard/svg/text: Added.
* platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
* platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
* platform/mac/svg/text/selection-background-color-expected.txt: Removed.
* svg/text/selection-background-color-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/text/
trunk/LayoutTests/platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png
trunk/LayoutTests/svg/text/selection-background-color-expected.txt


Removed Paths

trunk/LayoutTests/platform/gtk/svg/text/selection-background-color-expected.txt
trunk/LayoutTests/platform/mac/svg/text/selection-background-color-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96326 => 96327)

--- trunk/LayoutTests/ChangeLog	2011-09-29 14:30:38 UTC (rev 96326)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 15:32:02 UTC (rev 96327)
@@ -1,3 +1,16 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+Update baselines.
+
+* platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.
+* platform/chromium-cg-mac/svg/text/selection-background-color-expected.png: Added.
+* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Added.
+* platform/chromium-mac-leopard/svg/text: Added.
+* platform/chromium-mac-leopard/svg/text/selection-background-color-expected.png: Added.
+* platform/gtk/svg/text/selection-background-color-expected.txt: Removed.
+* platform/mac/svg/text/selection-background-color-expected.txt: Removed.
+* svg/text/selection-background-color-expected.txt: Added.
+
 2011-09-29  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.


Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt (0 => 96327)

--- trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt	2011-09-29 15:32:02 UTC (rev 96327)
@@ -0,0 +1,21 @@
+layer at (0,0) size 608x240
+  RenderView at (0,0) size 360x240
+layer at (0,0) size 360x236
+  RenderBlock {html} at (0,0) size 360x236
+RenderBody {body} at (8,16) size 344x204
+  RenderBlock {p} at (0,0) size 344x204
+RenderSVGRoot {svg} at (8,26) size 247x57
+  RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+RenderSVGResourceLinearGradient {linearGradient} [id=gradient] [gradientUnits=objectBoundingBox] [gradientTransform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [start=(0,0)] [end=(1,0)]
+  RenderSVGGradientStop {stop} [offset=0.00] [color=#00]
+  RenderSVGGradientStop {stop} [offset=1.00] [color=#FF]
+  RenderSVGContainer {g} at (8,26) size 247x57
+RenderSVGText {text} at (0,12) size 245x23 contains 1 chunk(s)
+  RenderSVGInlineText {#text} at (0,0) size 245x23
+chunk 1 text run 1 at (0.00,30.00) startOffset 0 endOffset 28 width 245.00: Should have blue background.
+RenderSVGText {text} at (0,42) size 245x23 contains 1 chunk(s)
+  RenderSVGInlineText {#text} at (0,0) size 245x23
+chunk 1 text run 1 at (0.00,60.00) startOffset 0 endOffset 28 width 245.00: Should have blue background.
+RenderText {#text} at (0,0) size 0x0
+selection start: position 0 of child 0 {#text} of child 1 {text} of child 3 {g} of child 1 {svg} of child 1 {p} of body
+selection end:   position 28 of child 0 {#text} of child 3 {text} of child 3 {g} of child 1 {svg} of child 1 {p} of body


Added:

[webkit-changes] [96328] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96328] trunk/LayoutTests








Revision 96328
Author aba...@webkit.org
Date 2011-09-29 08:34:40 -0700 (Thu, 29 Sep 2011)


Log Message
Update baselines.  (Font rendering.)

* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
* platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt
trunk/LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png
trunk/LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96327 => 96328)

--- trunk/LayoutTests/ChangeLog	2011-09-29 15:32:02 UTC (rev 96327)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 15:34:40 UTC (rev 96328)
@@ -1,5 +1,14 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Update baselines.  (Font rendering.)
+
+* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.
+* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Added.
+* platform/chromium-mac/http/tests/misc/acid3-expected.png: Added.
+* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Update baselines.
 
 * platform/chromium-cg-mac-leopard/svg/text/selection-background-color-expected.png: Added.


Added: trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt (0 => 96328)

--- trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt	2011-09-29 15:34:40 UTC (rev 96328)
@@ -0,0 +1,245 @@
+
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (20,20) size 644x433
+  RenderBlock {HTML} at (20,20) size 644x433 [bgcolor=#C0C0C0] [border: none (4px solid #808080) none]
+RenderBody {BODY} at (-4,-4) size 644x433 [bgcolor=#FF] [border: (1px solid #00)]
+  RenderBlock {H1} at (41,41) size 562x120
+RenderText {#text} at (0,4) size 273x112
+  text run at (0,4) width 273: Acid3
+  RenderBlock {DIV} at (41,121) size 562x312
+RenderBlock {P} at (7,80) size 54x42 [bgcolor=#FF] [border: (1px solid #00)]
+RenderBlock {P} at (70,64) size 64x50 [bgcolor=#FFA500] [border: (1px solid #00)]
+RenderBlock {P} at (145,48) size 74x58 [bgcolor=#00] [border: (1px solid #00)]
+RenderBlock {P} at (231,32) size 86x66 [bgcolor=#00FF00] [border: (1px solid #00)]
+RenderBlock {P} at (330,16) size 96x74 [bgcolor=#FF] [border: (1px solid #00)]
+RenderBlock {P} at (441,0) size 106x82 [bgcolor=#C0C0C0] [border: (1px solid #00)]
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {P} at (41,214) size 568x120
+RenderInline {SPAN} at (0,0) size 112x112
+  RenderText {#text} at (260,4) size 112x112
+text run at (260,4) width 112: 92
+RenderInline {SPAN} at (0,0) size 28x112
+  RenderText {#text} at (372,4) size 28x112
+text run at (372,4) width 28: /
+RenderInline {SPAN} at (0,0) size 168x112
+  RenderText {#text} at (400,4) size 168x112
+text run at (400,4) width 168: 100
+  RenderBlock (anonymous) at (41,334) size 562x0
+RenderInline {MAP} at (0,0) size 0x0
+  RenderPartObject {IFRAME} at (0,0) size 0x0
+layer at (0,0) size 1x1
+  RenderView at (0,0) size 0x0
+layer at (0,0) size 0x1
+  RenderBlock {HTML} at (0,0) size 0x1
+RenderBody {BODY} at (0,0) size 0x1
+  RenderImage {IMG} at (0,0) size 1x1
+  RenderPartObject {IFRAME} at (0,0) size 0x0
+layer at (0,0) size 16x2166
+  RenderView at (0,0) size 0x0
+layer at (0,0) size 0x2166
+  RenderBlock {HTML} at (0,0) size 0x2166
+RenderBody {BODY} at (8,8) size 0x2145
+  RenderBlock {PRE} at (0,0) size 0x2145
+RenderText {#text} at (0,0) size 8x2145
+  text run at (0,0) width 8: 
+  text run at (0,15) width 8: !
+  text run at (0,30) width 8: D
+  text run at (0,45) width 8: O
+  text run at (0,60) width 8: C
+

[webkit-changes] [96329] trunk/Tools

2011-09-29 Thread abarth

Title: [96329] trunk/Tools








Revision 96329
Author aba...@webkit.org
Date 2011-09-29 08:46:55 -0700 (Thu, 29 Sep 2011)


Log Message
Unbreak the update expectatations button by using the existing
machinery to create the failureInfo objects.

Unbreak the close button on the progress dialog by using |this|
instead of the old name of the object.

Teach the controllers unit test not to talk to the actual network.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (96328 => 96329)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js	2011-09-29 15:34:40 UTC (rev 96328)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js	2011-09-29 15:46:55 UTC (rev 96329)
@@ -81,11 +81,8 @@
 {
 var testName = this._view.currentTestName();
 return Object.keys(this._resultsByTest[testName]).map(function(builderName) {
-return {
-'testName': testName,
-'builderName': builderName
-};
-});
+return results.failureInfoForTestAndBuilder(this._resultsByTest, testName, builderName);
+}.bind(this));
 },
 onRebaseline: function()
 {


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js (96328 => 96329)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js	2011-09-29 15:34:40 UTC (rev 96328)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js	2011-09-29 15:46:55 UTC (rev 96329)
@@ -31,39 +31,46 @@
 
 module(controllers);
 
-test(UnexpectedFailures, 2, function() {
-var mockView = {};
-var mockState = {
-resultsByBuilder: kExampleResultsByBuilder
+test(UnexpectedFailures, 3, function() {
+var simulator = new NetworkSimulator();
+
+simulator.probe = function() {
 };
-var expectedResultsByTest = null;
-var mockDelegate = {
-showResults: function(resultsView)
-{
-deepEqual(resultsView._resultsByTest, expectedResultsByTest);
+
+simulator.runTest(function() {
+var mockView = {};
+var mockState = {
+resultsByBuilder: kExampleResultsByBuilder
+};
+var expectedResultsByTest = null;
+var mockDelegate = {
+showResults: function(resultsView)
+{
+deepEqual(resultsView._resultsByTest, expectedResultsByTest);
+}
 }
-}
-var controller = controllers.UnexpectedFailures(mockState, mockView, mockDelegate);
+var controller = controllers.UnexpectedFailures(mockState, mockView, mockDelegate);
 
-var testNameList = null;
-var mockFailures = {
-testNameList: function() { return testNameList; }
-};
+var testNameList = null;
+var mockFailures = {
+testNameList: function() { return testNameList; }
+};
 
-testNameList = [scrollbars/custom-scrollbar-with-incomplete-style.html];
-expectedResultsByTest = {};
-controller.onExamine(mockFailures);
+testNameList = [scrollbars/custom-scrollbar-with-incomplete-style.html];
+expectedResultsByTest = {};
+controller.onExamine(mockFailures);
 
-testNameList = [userscripts/another-test.html];
-expectedResultsByTest = {
-  userscripts/another-test.html: {
-Mock Builder: {
-  expected: PASS,
-  actual: TEXT
-}
-  }
-};
-controller.onExamine(mockFailures);
+testNameList = [userscripts/another-test.html];
+expectedResultsByTest = {
+  userscripts/another-test.html: {
+Mock Builder: {
+  expected: PASS,
+  actual: TEXT
+}
+  }
+};
+controller.onExamine(mockFailures);
+});
 });
 
 })();


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js (96328 => 96329)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js	2011-09-29 15:34:40 UTC (rev 96328)
+++

[webkit-changes] [96330] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96330] trunk/LayoutTests








Revision 96330
Author aba...@webkit.org
Date 2011-09-29 09:09:23 -0700 (Thu, 29 Sep 2011)


Log Message
Add some expected failures on Leopard.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96329 => 96330)

--- trunk/LayoutTests/ChangeLog	2011-09-29 15:46:55 UTC (rev 96329)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 16:09:23 UTC (rev 96330)
@@ -1,5 +1,11 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Add some expected failures on Leopard.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Update baselines.  (Font rendering.)
 
 * platform/chromium-cg-mac/http/tests/misc/acid3-expected.png: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96329 => 96330)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 15:46:55 UTC (rev 96329)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 16:09:23 UTC (rev 96330)
@@ -3764,7 +3764,7 @@
 BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.quality.basic.html = TEXT
 
 BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH
-BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH
+BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH IMAGE
 
 BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT
 
@@ -3848,3 +3848,5 @@
 BUGWK69078 MAC CPU-CG : editing/undo/4063751.html = IMAGE
 BUGWK69078 MAC CPU-CG : editing/unsupported-content/table-type-after.html = IMAGE
 BUGWK69078 MAC CPU-CG : editing/unsupported-content/table-type-before.html = IMAGE
+
+BUGABARTH LEOPARD : svg/custom/pattern-excessive-malloc.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96331] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96331] trunk/LayoutTests








Revision 96331
Author aba...@webkit.org
Date 2011-09-29 09:20:12 -0700 (Thu, 29 Sep 2011)


Log Message
Update expected results on Leopard.  As far as I can tell, these are
progressions.

* platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
* platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (96330 => 96331)

--- trunk/LayoutTests/ChangeLog	2011-09-29 16:09:23 UTC (rev 96330)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 16:20:12 UTC (rev 96331)
@@ -1,5 +1,13 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Update expected results on Leopard.  As far as I can tell, these are
+progressions.
+
+* platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
+* platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png: Added.
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Add some expected failures on Leopard.
 
 * platform/chromium/test_expectations.txt:


Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/selection/node-removal-1-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96332] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96332] trunk/LayoutTests








Revision 96332
Author aba...@webkit.org
Date 2011-09-29 09:24:05 -0700 (Thu, 29 Sep 2011)


Log Message
This test can also time out.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96331 => 96332)

--- trunk/LayoutTests/ChangeLog	2011-09-29 16:20:12 UTC (rev 96331)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 16:24:05 UTC (rev 96332)
@@ -1,5 +1,11 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+This test can also time out.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Update expected results on Leopard.  As far as I can tell, these are
 progressions.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96331 => 96332)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 16:20:12 UTC (rev 96331)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 16:24:05 UTC (rev 96332)
@@ -918,7 +918,7 @@
 // or change the test upstream to specify explicitly what font to use.
 // The mask part of this test is totally wrong.
 BUGCR3244 LEOPARD LINUX WIN : svg/as-background-image/svg-as-background-6.html = FAIL
-BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = IMAGE
+BUGWK54322 SNOWLEOPARD : svg/as-background-image/svg-as-background-6.html = TIMEOUT IMAGE
 
 // Our gradients are wrong here.
 BUGCR19559 LINUX WIN : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96333] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96333] trunk/LayoutTests








Revision 96333
Author aba...@webkit.org
Date 2011-09-29 09:25:46 -0700 (Thu, 29 Sep 2011)


Log Message
Generalize expected result to all of MAC.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96332 => 96333)

--- trunk/LayoutTests/ChangeLog	2011-09-29 16:24:05 UTC (rev 96332)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 16:25:46 UTC (rev 96333)
@@ -1,5 +1,11 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Generalize expected result to all of MAC.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 This test can also time out.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96332 => 96333)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 16:24:05 UTC (rev 96332)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 16:25:46 UTC (rev 96333)
@@ -3469,7 +3469,7 @@
 BUGWK63186 LINUX WIN : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = IMAGE+TEXT
 BUGWK63186 MAC : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = PASS IMAGE+TEXT IMAGE
 BUGWK63186 LINUX WIN : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = IMAGE+TEXT
-BUGWK63186 SNOWLEOPARD : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = PASS IMAGE+TEXT
+BUGWK63186 MAC : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = PASS IMAGE+TEXT
 BUGWK63186 LINUX WIN : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = IMAGE+TEXT
 BUGWK63186 LEOPARD : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = PASS IMAGE+TEXT IMAGE
 BUGWK63186 SNOWLEOPARD : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = PASS IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96334] trunk/Tools

2011-09-29 Thread commit-queue

Title: [96334] trunk/Tools








Revision 96334
Author commit-qu...@webkit.org
Date 2011-09-29 09:32:49 -0700 (Thu, 29 Sep 2011)


Log Message
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235

Patch by Ravi Phaneendra Kasibhatla ravi.kasibha...@motorola.com on 2011-09-29
Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/gtk/BrowserWindow.c




Diff

Modified: trunk/Tools/ChangeLog (96333 => 96334)

--- trunk/Tools/ChangeLog	2011-09-29 16:25:46 UTC (rev 96333)
+++ trunk/Tools/ChangeLog	2011-09-29 16:32:49 UTC (rev 96334)
@@ -1,3 +1,13 @@
+2011-09-29  Ravi Phaneendra Kasibhatla  ravi.kasibha...@motorola.com
+
+Initial implementation of WebInspector for WebKit2 GTK port.
+https://bugs.webkit.org/show_bug.cgi?id=68235
+
+Reviewed by Martin Robinson.
+
+* MiniBrowser/gtk/BrowserWindow.c:
+(browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 Unbreak the update expectatations button by using the existing


Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (96333 => 96334)

--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2011-09-29 16:25:46 UTC (rev 96333)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2011-09-29 16:32:49 UTC (rev 96334)
@@ -185,6 +185,10 @@
 browserWindowLoaderClientInit(window);
 browserWindowUIClientInit(window);
 browserWindowPolicyClientInit(window);
+
+WKPageGroupRef groupRef = WKPageGetPageGroup(WKViewGetPage(window-webView));
+WKPreferencesRef preferencesRef = WKPageGroupGetPreferences(groupRef);
+WKPreferencesSetDeveloperExtrasEnabled(preferencesRef, true);
 }
 
 static void browser_window_class_init(BrowserWindowClass* klass)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96335] trunk/LayoutTests

2011-09-29 Thread dgrogan

Title: [96335] trunk/LayoutTests








Revision 96335
Author dgro...@chromium.org
Date 2011-09-29 09:42:48 -0700 (Thu, 29 Sep 2011)


Log Message
Layout test demonstrating IDBCursor inconsistency bug.
https://bugs.webkit.org/show_bug.cgi?id=69012

Reviewed by Nate Chapin.

* storage/indexeddb/cursor-inconsistency-expected.txt: Added.
* storage/indexeddb/cursor-inconsistency.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-inconsistency.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96334 => 96335)

--- trunk/LayoutTests/ChangeLog	2011-09-29 16:32:49 UTC (rev 96334)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 16:42:48 UTC (rev 96335)
@@ -1,3 +1,13 @@
+2011-09-29  David Grogan  dgro...@chromium.org
+
+Layout test demonstrating IDBCursor inconsistency bug.
+https://bugs.webkit.org/show_bug.cgi?id=69012
+
+Reviewed by Nate Chapin.
+
+* storage/indexeddb/cursor-inconsistency-expected.txt: Added.
+* storage/indexeddb/cursor-inconsistency.html: Added.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 Generalize expected result to all of MAC.


Added: trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt (0 => 96335)

--- trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-inconsistency-expected.txt	2011-09-29 16:42:48 UTC (rev 96335)
@@ -0,0 +1,62 @@
+Test consistency of IndexedDB's cursor objects.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+webkitIndexedDB.open('cursor-inconsistency')
+db = event.target.result
+db.setVersion('new version')
+setVersionSuccess():
+trans = event.target.result
+PASS trans !== null is true
+Deleted all object stores.
+objectStore = db.createObjectStore('basicStore')
+objectStore.add('someValue1', 'someKey1')._onerror_ = unexpectedErrorCallback
+objectStore.add('someValue2', 'someKey2')._onerror_ = unexpectedErrorCallback
+objectStore.add('someValue3', 'someKey3')._onerror_ = unexpectedErrorCallback
+objectStore.add('someValue4', 'someKey4')._onerror_ = unexpectedErrorCallback
+openBasicCursor()
+trans = db.transaction([], webkitIDBTransaction.READ_WRITE)
+trans.objectStore('basicStore')
+objectStore.openCursor(keyRange)
+
+checkCursor()
+storedCursor = event.target.result
+PASS storedCursor === event.target.result is true
+PASS storedCursor.key is someKey1
+PASS event.target.result.key is someKey1
+PASS storedCursor.value is someValue1
+PASS event.target.result.value is someValue1
+event.target.result.continue()
+
+checkCursor()
+FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor.key is someKey2
+PASS event.target.result.key is someKey2
+FAIL storedCursor.value should be someValue2. Was someValue1.
+PASS event.target.result.value is someValue2
+event.target.result.continue()
+
+checkCursor()
+FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor.key is someKey3
+PASS event.target.result.key is someKey3
+FAIL storedCursor.value should be someValue3. Was someValue1.
+PASS event.target.result.value is someValue3
+event.target.result.continue()
+
+checkCursor()
+FAIL storedCursor === event.target.result should be true. Was false.
+PASS storedCursor.key is someKey4
+PASS event.target.result.key is someKey4
+FAIL storedCursor.value should be someValue4. Was someValue1.
+PASS event.target.result.value is someValue4
+event.target.result.continue()
+
+checkCursor()
+PASS counter is 5
+transactionComplete()
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/cursor-inconsistency.html (0 => 96335)

--- trunk/LayoutTests/storage/indexeddb/cursor-inconsistency.html	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-inconsistency.html	2011-09-29 16:42:48 UTC (rev 96335)
@@ -0,0 +1,99 @@
+html
+head
+link rel=stylesheet href=""
+script src=""
+script src=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+
+description(Test consistency of IndexedDB's cursor objects.);
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+test();
+
+function test()
+{
+request = evalAndLog(webkitIndexedDB.open('cursor-inconsistency'));
+request._onsuccess_ = openSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function openSuccess()
+{
+var db = evalAndLog(db = event.target.result);
+
+request = evalAndLog(db.setVersion('new version'));
+request._onsuccess_ = setVersionSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function setVersionSuccess()
+{
+debug(setVersionSuccess():);
+window.trans = evalAndLog(trans = event.target.result);
+shouldBeTrue(trans !== null);
+trans._onabort_ = unexpectedAbortCallback;
+

[webkit-changes] [96337] trunk/Source

2011-09-29 Thread commit-queue

Title: [96337] trunk/Source








Revision 96337
Author commit-qu...@webkit.org
Date 2011-09-29 10:05:41 -0700 (Thu, 29 Sep 2011)


Log Message
Add unit test for CCLayerSorter
https://bugs.webkit.org/show_bug.cgi?id=68622

Source/WebCore:

Minor refactoring for testability:
- Made pointInTriangle public.
- Added LayerShape to decouple LayerIntersector and GraphNode.
- Added a public wrapper function for LayerIntersector.

Patch by Iain Merrick hu...@google.com on 2011-09-29
Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCLayerSorter.cpp:
(WebCore::CCLayerSorter::pointInTriangle):
(WebCore::CCLayerSorter::calculateZDiff):
(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
(WebCore::CCLayerSorter::LayerIntersector::go):
(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
(WebCore::CCLayerSorter::checkOverlap):
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::createGraphNodes):
* platform/graphics/chromium/cc/CCLayerSorter.h:
(WebCore::CCLayerSorter::LayerShape::LayerShape):
(WebCore::CCLayerSorter::GraphNode::GraphNode):

Source/WebKit/chromium:

Patch by Iain Merrick hu...@google.com on 2011-09-29
Reviewed by James Robinson.

* WebKit.gypi:
* tests/CCLayerSorterTest.cpp: Added.
(WebCore::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi


Added Paths

trunk/Source/WebKit/chromium/tests/CCLayerSorterTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96336 => 96337)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 17:04:20 UTC (rev 96336)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 17:05:41 UTC (rev 96337)
@@ -1,3 +1,29 @@
+2011-09-29  Iain Merrick  hu...@google.com
+
+Add unit test for CCLayerSorter
+https://bugs.webkit.org/show_bug.cgi?id=68622
+
+Minor refactoring for testability:
+- Made pointInTriangle public.
+- Added LayerShape to decouple LayerIntersector and GraphNode.
+- Added a public wrapper function for LayerIntersector.
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCLayerSorter.cpp:
+(WebCore::CCLayerSorter::pointInTriangle):
+(WebCore::CCLayerSorter::calculateZDiff):
+(WebCore::CCLayerSorter::LayerIntersector::LayerIntersector):
+(WebCore::CCLayerSorter::LayerIntersector::go):
+(WebCore::CCLayerSorter::LayerIntersector::checkZDiff):
+(WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint):
+(WebCore::CCLayerSorter::checkOverlap):
+(WebCore::CCLayerSorter::LayerShape::LayerShape):
+(WebCore::CCLayerSorter::createGraphNodes):
+* platform/graphics/chromium/cc/CCLayerSorter.h:
+(WebCore::CCLayerSorter::LayerShape::LayerShape):
+(WebCore::CCLayerSorter::GraphNode::GraphNode):
+
 2011-09-29  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: UI performance test for network panel is incorrect. The time is including a timeout between scheduled refresh and actual refresh.


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.cpp (96336 => 96337)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.cpp	2011-09-29 17:04:20 UTC (rev 96336)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.cpp	2011-09-29 17:05:41 UTC (rev 96337)
@@ -45,10 +45,10 @@
 
 namespace WebCore {
 
-static bool pointInTriangle(const FloatPoint point,
-const FloatPoint a,
-const FloatPoint b,
-const FloatPoint c)
+bool CCLayerSorter::pointInTriangle(const FloatPoint point,
+const FloatPoint a,
+const FloatPoint b,
+const FloatPoint c)
 {
 // Algorithm from http://www.blackpawn.com/texts/pointinpoly/default.html
 float x0 = c.x() - a.x();
@@ -143,9 +143,16 @@
 return true;
 }
 
-CCLayerSorter::LayerIntersector::LayerIntersector(GraphNode* nodeA, GraphNode* nodeB, float earlyExitThreshold)
-: nodeA(nodeA)
-, nodeB(nodeB)
+float CCLayerSorter::calculateZDiff(const LayerShape layerA, const LayerShape layerB, float earlyExitThreshold)
+{
+LayerIntersector intersector(layerA, layerB, earlyExitThreshold);
+intersector.go();
+return intersector.zDiff;
+}
+
+CCLayerSorter::LayerIntersector::LayerIntersector(const LayerShape layerA, const LayerShape layerB, float earlyExitThreshold)
+: layerA(layerA)
+, layerB(layerB)
 , zDiff(0)
 , earlyExitThreshold(earlyExitThreshold)
 {
@@ -153,13 +160,12 @@
 
 void CCLayerSorter::LayerIntersector::go()
 {
-(triangleTriangleTest(nodeA-c1, nodeA-c2,

[webkit-changes] [96339] trunk/Source/WebCore

2011-09-29 Thread commit-queue

Title: [96339] trunk/Source/WebCore








Revision 96339
Author commit-qu...@webkit.org
Date 2011-09-29 10:35:41 -0700 (Thu, 29 Sep 2011)


Log Message
[GTK] Dragging a selection does not produce a drag image
https://bugs.webkit.org/show_bug.cgi?id=69064

Patch by Martin Robinson mrobin...@igalia.com on 2011-09-29
Reviewed by Andreas Kling.

Moved Chromium's generic implementation of Frame::nodeImage and
Frame::dragImageForSeletion to Frame.cpp and simply excluded via
#ifdefs platforms that do not have their own implementation. Removed
all empty implementations of these functions and Qt's which was
functionally identical.

No new tests. Drag-and-drop drag image functionality changes
are incredibly difficult to test in a non-manual way.

* CMakeListsEfl.txt: Delist FrameEfl.cpp.
* GNUmakefile.list.am: Delist FrameGtk.cpp.
* WebCore.gypi: Delist removed Frame*.cpp.
* WebCore.pro: Delist FrameQt.cpp.
* page/Frame.cpp: Moved FrameChromium implementation here.
(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* page/chromium/FrameChromium.cpp: Removed.
* page/efl/FrameEfl.cpp: Removed.
* page/gtk/FrameGtk.cpp: Removed.
* page/qt/FrameQt.cpp: Removed.
* page/wx/FrameWx.cpp: Removed.
* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
the drag image for a node.

Modified Paths

trunk/Source/WebCore/CMakeListsEfl.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/platform/gtk/ClipboardGtk.cpp


Removed Paths

trunk/Source/WebCore/page/chromium/FrameChromium.cpp
trunk/Source/WebCore/page/efl/FrameEfl.cpp
trunk/Source/WebCore/page/gtk/FrameGtk.cpp
trunk/Source/WebCore/page/qt/FrameQt.cpp
trunk/Source/WebCore/page/wx/FrameWx.cpp




Diff

Modified: trunk/Source/WebCore/CMakeListsEfl.txt (96338 => 96339)

--- trunk/Source/WebCore/CMakeListsEfl.txt	2011-09-29 17:16:35 UTC (rev 96338)
+++ trunk/Source/WebCore/CMakeListsEfl.txt	2011-09-29 17:35:41 UTC (rev 96339)
@@ -20,7 +20,6 @@
   bindings/js/ScriptControllerEfl.cpp
   page/efl/DragControllerEfl.cpp
   page/efl/EventHandlerEfl.cpp
-  page/efl/FrameEfl.cpp
   platform/Cursor.cpp
   platform/efl/ClipboardEfl.cpp
   platform/efl/ContextMenuEfl.cpp


Modified: trunk/Source/WebCore/ChangeLog (96338 => 96339)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 17:16:35 UTC (rev 96338)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 17:35:41 UTC (rev 96339)
@@ -1,3 +1,37 @@
+2011-09-29  Martin Robinson  mrobin...@igalia.com
+
+[GTK] Dragging a selection does not produce a drag image
+https://bugs.webkit.org/show_bug.cgi?id=69064
+
+Reviewed by Andreas Kling.
+
+Moved Chromium's generic implementation of Frame::nodeImage and
+Frame::dragImageForSeletion to Frame.cpp and simply excluded via
+#ifdefs platforms that do not have their own implementation. Removed
+all empty implementations of these functions and Qt's which was
+functionally identical.
+
+No new tests. Drag-and-drop drag image functionality changes
+are incredibly difficult to test in a non-manual way.
+
+* CMakeListsEfl.txt: Delist FrameEfl.cpp.
+* GNUmakefile.list.am: Delist FrameGtk.cpp.
+* WebCore.gypi: Delist removed Frame*.cpp.
+* WebCore.pro: Delist FrameQt.cpp.
+* page/Frame.cpp: Moved FrameChromium implementation here.
+(WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
+(WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
+(WebCore::Frame::nodeImage):
+(WebCore::Frame::dragImageForSelection):
+* page/chromium/FrameChromium.cpp: Removed.
+* page/efl/FrameEfl.cpp: Removed.
+* page/gtk/FrameGtk.cpp: Removed.
+* page/qt/FrameQt.cpp: Removed.
+* page/wx/FrameWx.cpp: Removed.
+* platform/gtk/ClipboardGtk.cpp:
+(WebCore::ClipboardGtk::createDragImage): Call nodeImage to get
+the drag image for a node.
+
 2011-09-29  Noel Gordon  noel.gor...@gmail.com
 
 [chromium skia] PNGImageEncoder: hoist constants out of the encoding loop


Modified: trunk/Source/WebCore/GNUmakefile.list.am (96338 => 96339)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-09-29 17:16:35 UTC (rev 96338)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-09-29 17:35:41 UTC (rev 96339)
@@ -3954,7 +3954,6 @@
 	Source/WebCore/editing/gtk/FrameSelectionGtk.cpp \
 	Source/WebCore/page/gtk/DragControllerGtk.cpp \
 	Source/WebCore/page/gtk/EventHandlerGtk.cpp \
-	Source/WebCore/page/gtk/FrameGtk.cpp \
 	Source/WebCore/platform/cairo/WidgetBackingStore.h \
 	Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp \

[webkit-changes] [96340] trunk

2011-09-29 Thread cfleizach

Title: [96340] trunk








Revision 96340
Author cfleiz...@apple.com
Date 2011-09-29 10:46:14 -0700 (Thu, 29 Sep 2011)


Log Message
ARIA live regions don't trigger notifications for elements that aren't in the AX tree
https://bugs.webkit.org/show_bug.cgi?id=62289

Source/WebCore: 

If an ARIA Live region udpates an element that is not in the AX object cache, then the Live region
notification is not sent. To fix this, the childrenChanged() method needs to actually create
the appropriate objects, but since that method gets called during a render tree update, we've learned 
that it's generally not safe to create objects.

Instead a one shot timer can be fired that will update and create the necessary objects so that the
correct notification can be sent.

Reviewed by Darin Adler.

Test: platform/mac/accessibility/aria-liveregion-without-element-access.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenUpdateTimerFired):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):

LayoutTests: 

Reviewed by Darin Adler.

* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
* platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp
trunk/Source/WebCore/accessibility/AccessibilityMenuList.h
trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp
trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/rendering/RenderObject.cpp


Added Paths

trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96339 => 96340)

--- trunk/LayoutTests/ChangeLog	2011-09-29 17:35:41 UTC (rev 96339)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 17:46:14 UTC (rev 96340)
@@ -1,3 +1,13 @@
+2011-09-29  Chris Fleizach  cfleiz...@apple.com
+
+ARIA live regions don't trigger notifications for elements that aren't in the AX tree
+https://bugs.webkit.org/show_bug.cgi?id=62289
+
+Reviewed by Darin Adler.
+
+* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Added.
+* platform/mac/accessibility/aria-liveregion-without-element-access.html: Added.
+
 2011-09-29  David Reveman  reve...@chromium.org
 
 Rebaseline for r95870


Added: trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt (0 => 96340)

--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt	2011-09-29 17:46:14 UTC (rev 96340)
@@ -0,0 +1,14 @@
+ALERT: Successfully received AXLiveRegionChanged
+text
+
+added
+This tests that adding an element to a live region will trigger a notification even though the AX element was not created previously.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS addedNotification is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html (0 => 96340)

--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html	2011-09-29 17:46:14 UTC (rev 96340)
@@ -0,0 +1,54 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+div role=group

[webkit-changes] [96341] trunk

2011-09-29 Thread abarth

Title: [96341] trunk








Revision 96341
Author aba...@webkit.org
Date 2011-09-29 10:50:47 -0700 (Thu, 29 Sep 2011)


Log Message
We should ignore the return value of GetRealNamedProperty
https://bugs.webkit.org/show_bug.cgi?id=68840

Reviewed by Nate Chapin.

Source/WebCore:

Instead of skipping the lookup process by using the result of real
named property, we should just indiciate that it wasn't handled by the
interceptor.

Test: http/tests/security/window-named-valueOf.html

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):

LayoutTests:

* http/tests/security/window-named-valueOf-expected.txt: Added.
* http/tests/security/window-named-valueOf.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp


Added Paths

trunk/LayoutTests/http/tests/security/window-named-valueOf-expected.txt
trunk/LayoutTests/http/tests/security/window-named-valueOf.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96340 => 96341)

--- trunk/LayoutTests/ChangeLog	2011-09-29 17:46:14 UTC (rev 96340)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 17:50:47 UTC (rev 96341)
@@ -1,3 +1,13 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+We should ignore the return value of GetRealNamedProperty
+https://bugs.webkit.org/show_bug.cgi?id=68840
+
+Reviewed by Nate Chapin.
+
+* http/tests/security/window-named-valueOf-expected.txt: Added.
+* http/tests/security/window-named-valueOf.html: Added.
+
 2011-09-29  Chris Fleizach  cfleiz...@apple.com
 
 ARIA live regions don't trigger notifications for elements that aren't in the AX tree


Added: trunk/LayoutTests/http/tests/security/window-named-valueOf-expected.txt (0 => 96341)

--- trunk/LayoutTests/http/tests/security/window-named-valueOf-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/window-named-valueOf-expected.txt	2011-09-29 17:50:47 UTC (rev 96341)
@@ -0,0 +1 @@
+This passes if it doesn't alert the contents of innocent-victim.  


Added: trunk/LayoutTests/http/tests/security/window-named-valueOf.html (0 => 96341)

--- trunk/LayoutTests/http/tests/security/window-named-valueOf.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/window-named-valueOf.html	2011-09-29 17:50:47 UTC (rev 96341)
@@ -0,0 +1,32 @@
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+layoutTestController.setCanOpenWindows();
+layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+/script
+body
+This passes if it doesn't alert the contents of innocent-victim.
+script
+window._onload_ = function()
+{
+frame = document.body.appendChild(document.createElement(iframe));
+frame.src = ""
+frame._onload_ = function() {
+frame._onload_ = null;
+
+frame.contentWindow[0].location = data:text/html,script( + function() {
+try {
+window.name = valueOf;
+obj = window.open();
+obj.__proto__.__proto__ = parent;
+alert(obj.valueOf.constructor(return document.body.innerHTML)());
+} catch(ex) {
+}
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+} + )()/scr + ipt;
+}
+}
+/script


Modified: trunk/Source/WebCore/ChangeLog (96340 => 96341)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 17:46:14 UTC (rev 96340)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 17:50:47 UTC (rev 96341)
@@ -1,3 +1,19 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+We should ignore the return value of GetRealNamedProperty
+https://bugs.webkit.org/show_bug.cgi?id=68840
+
+Reviewed by Nate Chapin.
+
+Instead of skipping the lookup process by using the result of real
+named property, we should just indiciate that it wasn't handled by the
+interceptor.
+
+Test: http/tests/security/window-named-valueOf.html
+
+* bindings/v8/custom/V8DOMWindowCustom.cpp:
+(WebCore::V8DOMWindow::namedPropertyGetter):
+
 2011-09-29  Chris Fleizach  cfleiz...@apple.com
 
 ARIA live regions don't trigger notifications for elements that aren't in the AX tree


Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (96340 => 96341)

--- trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	2011-09-29 17:46:14 UTC (rev 96340)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	2011-09-29 17:50:47 UTC (rev 96341)
@@ -510,9 +510,8 @@
 return toV8(child-domWindow());
 
 // Search IDL functions defined in the prototype
-v8::Handlev8::Value result = info.Holder()-GetRealNamedProperty(name);
-if (!result.IsEmpty())
-return result;
+if (!info.Holder()-GetRealNamedProperty(name).IsEmpty())
+return

[webkit-changes] [96342] trunk/Source/WebCore

2011-09-29 Thread commit-queue

Title: [96342] trunk/Source/WebCore








Revision 96342
Author commit-qu...@webkit.org
Date 2011-09-29 11:04:21 -0700 (Thu, 29 Sep 2011)


Log Message
Shrink FontFallbackList.
https://bugs.webkit.org/show_bug.cgi?id=69093

Patch by Andreas Kling kl...@webkit.org on 2011-09-29
Reviewed by Antti Koivisto.

Reduce the size of FontFallbackList by one CPU word, decreasing memory
consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.

* platform/graphics/FontCache.h:
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::generation):

Store the FontCache generation as an ushort rather than uint.

* platform/graphics/FontFallbackList.cpp:
(WebCore::FontFallbackList::FontFallbackList):
* platform/graphics/FontFallbackList.h:

Pack enum and bool members in a bitfield.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.cpp
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/FontFallbackList.cpp
trunk/Source/WebCore/platform/graphics/FontFallbackList.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96341 => 96342)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 17:50:47 UTC (rev 96341)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 18:04:21 UTC (rev 96342)
@@ -1,3 +1,25 @@
+2011-09-29  Andreas Kling  kl...@webkit.org
+
+Shrink FontFallbackList.
+https://bugs.webkit.org/show_bug.cgi?id=69093
+
+Reviewed by Antti Koivisto.
+
+Reduce the size of FontFallbackList by one CPU word, decreasing memory
+consumption by 300 kB (on 64-bit) when loading the full HTML5 spec.
+
+* platform/graphics/FontCache.h:
+* platform/graphics/FontCache.cpp:
+(WebCore::FontCache::generation):
+
+Store the FontCache generation as an ushort rather than uint.
+
+* platform/graphics/FontFallbackList.cpp:
+(WebCore::FontFallbackList::FontFallbackList):
+* platform/graphics/FontFallbackList.h:
+
+Pack enum and bool members in a bitfield.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 We should ignore the return value of GetRealNamedProperty


Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (96341 => 96342)

--- trunk/Source/WebCore/platform/graphics/FontCache.cpp	2011-09-29 17:50:47 UTC (rev 96341)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp	2011-09-29 18:04:21 UTC (rev 96342)
@@ -463,9 +463,9 @@
 gClients-remove(client);
 }
 
-static unsigned gGeneration = 0;
+static unsigned short gGeneration = 0;
 
-unsigned FontCache::generation()
+unsigned short FontCache::generation()
 {
 return gGeneration;
 }


Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (96341 => 96342)

--- trunk/Source/WebCore/platform/graphics/FontCache.h	2011-09-29 17:50:47 UTC (rev 96341)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h	2011-09-29 18:04:21 UTC (rev 96342)
@@ -91,7 +91,7 @@
 void addClient(FontSelector*);
 void removeClient(FontSelector*);
 
-unsigned generation();
+unsigned short generation();
 void invalidate();
 
 size_t fontDataCount();


Modified: trunk/Source/WebCore/platform/graphics/FontFallbackList.cpp (96341 => 96342)

--- trunk/Source/WebCore/platform/graphics/FontFallbackList.cpp	2011-09-29 17:50:47 UTC (rev 96341)
+++ trunk/Source/WebCore/platform/graphics/FontFallbackList.cpp	2011-09-29 18:04:21 UTC (rev 96342)
@@ -40,9 +40,9 @@
 , m_cachedPrimarySimpleFontData(0)
 , m_fontSelector(0)
 , m_familyIndex(0)
+, m_generation(fontCache()-generation())
 , m_pitch(UnknownPitch)
 , m_loadingCustomFonts(false)
-, m_generation(fontCache()-generation())
 {
 }
 


Modified: trunk/Source/WebCore/platform/graphics/FontFallbackList.h (96341 => 96342)

--- trunk/Source/WebCore/platform/graphics/FontFallbackList.h	2011-09-29 17:50:47 UTC (rev 96341)
+++ trunk/Source/WebCore/platform/graphics/FontFallbackList.h	2011-09-29 18:04:21 UTC (rev 96342)
@@ -85,9 +85,9 @@
 mutable const SimpleFontData* m_cachedPrimarySimpleFontData;
 RefPtrFontSelector m_fontSelector;
 mutable int m_familyIndex;
-mutable Pitch m_pitch;
-mutable bool m_loadingCustomFonts;
-unsigned m_generation;
+unsigned short m_generation;
+mutable Pitch m_pitch : 3;
+mutable bool m_loadingCustomFonts : 1;
 
 friend class Font;
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96343] trunk

2011-09-29 Thread abarth

Title: [96343] trunk








Revision 96343
Author aba...@webkit.org
Date 2011-09-29 12:03:40 -0700 (Thu, 29 Sep 2011)


Log Message
Unreviewed, rolling out r96340.
http://trac.webkit.org/changeset/96340
https://bugs.webkit.org/show_bug.cgi?id=69098

Caused 10 tests to crash in Debug (Requested by
abarth|gardener on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-09-29

Source/WebCore: 

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AXObjectCache.h:
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::childrenChanged):
* accessibility/AccessibilityMenuList.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::childrenChanged):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::childrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::startOfContinuations):
(WebCore::AccessibilityRenderObject::updateAccessibilityRole):
(WebCore::AccessibilityRenderObject::childrenChanged):
* accessibility/AccessibilityRenderObject.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):

LayoutTests: 

* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
* platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityMenuList.cpp
trunk/Source/WebCore/accessibility/AccessibilityMenuList.h
trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.cpp
trunk/Source/WebCore/accessibility/AccessibilityMenuListPopup.h
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/rendering/RenderObject.cpp


Removed Paths

trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96342 => 96343)

--- trunk/LayoutTests/ChangeLog	2011-09-29 18:04:21 UTC (rev 96342)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 19:03:40 UTC (rev 96343)
@@ -1,3 +1,15 @@
+2011-09-29  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r96340.
+http://trac.webkit.org/changeset/96340
+https://bugs.webkit.org/show_bug.cgi?id=69098
+
+Caused 10 tests to crash in Debug (Requested by
+abarth|gardener on #webkit).
+
+* platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt: Removed.
+* platform/mac/accessibility/aria-liveregion-without-element-access.html: Removed.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 We should ignore the return value of GetRealNamedProperty


Deleted: trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt (96342 => 96343)

--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt	2011-09-29 18:04:21 UTC (rev 96342)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access-expected.txt	2011-09-29 19:03:40 UTC (rev 96343)
@@ -1,14 +0,0 @@
-ALERT: Successfully received AXLiveRegionChanged
-text
-
-added
-This tests that adding an element to a live region will trigger a notification even though the AX element was not created previously.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS addedNotification is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html (96342 => 96343)

--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html	2011-09-29 18:04:21 UTC (rev 96342)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregion-without-element-access.html	2011-09-29 19:03:40 UTC (rev 96343)
@@ -1,54 +0,0 @@
-!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
-html
-head
-link rel=stylesheet href=""
-script
-var successfullyParsed = false;
-/script
-script src=""
-/head
-body id=body
-
-div role=group tabindex=0 id=liveregion aria-live=polite aria-relevant=additions
-h3 id=innerlivetext/h3
-div role=group
-   div id=addregion/div
-/div
-/div
-
-p id=description/p
-div id=console/div
-
-script
-
-description(This tests that adding an element to a live region will trigger a notification even though the AX element was not created previously.);
-
-var liveRegion = 0;
-function ariaCallback(notification) {
-

[webkit-changes] [96344] trunk/Source/JavaScriptCore

2011-09-29 Thread commit-queue

Title: [96344] trunk/Source/_javascript_Core








Revision 96344
Author commit-qu...@webkit.org
Date 2011-09-29 12:07:41 -0700 (Thu, 29 Sep 2011)


Log Message
Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69075

Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-09-29
Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96343 => 96344)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 19:03:40 UTC (rev 96343)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 19:07:41 UTC (rev 96344)
@@ -1,5 +1,15 @@
 2011-09-29  Yuqiang Xian  yuqiang.x...@intel.com
 
+Bug fixes for CreateThis, NewObject and GetByOffset in JSVALUE32_64 DFG JIT
+https://bugs.webkit.org/show_bug.cgi?id=69075
+
+Reviewed by Gavin Barraclough.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
+2011-09-29  Yuqiang Xian  yuqiang.x...@intel.com
+
 JSVALUE32_64 DFG JIT failed to be built on 32-bit Linux due to incorrect overloaded OpInfo constructor
 https://bugs.webkit.org/show_bug.cgi?id=69054
 


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (96343 => 96344)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2011-09-29 19:03:40 UTC (rev 96343)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2011-09-29 19:07:41 UTC (rev 96344)
@@ -1674,8 +1674,9 @@
 slowPath.link(m_jit);
 
 silentSpillAllRegisters(resultGPR);
-m_jit.move(protoGPR, GPRInfo::argumentGPR1);
-m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+m_jit.push(TrustedImm32(JSValue::CellTag));
+m_jit.push(protoGPR);
+m_jit.push(GPRInfo::callFrameRegister);
 appendCallWithExceptionCheck(operationCreateThis);
 m_jit.move(GPRInfo::returnValueGPR, resultGPR);
 silentFillAllRegisters(resultGPR);
@@ -1702,7 +1703,7 @@
 slowPath.link(m_jit);
 
 silentSpillAllRegisters(resultGPR);
-m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+m_jit.push(GPRInfo::callFrameRegister);
 appendCallWithExceptionCheck(operationNewObject);
 m_jit.move(GPRInfo::returnValueGPR, resultGPR);
 silentFillAllRegisters(resultGPR);
@@ -1834,7 +1835,6 @@
 GPRReg resultTagGPR = resultTag.gpr();
 GPRReg resultPayloadGPR = resultPayload.gpr();
 
-storage.use();
 StorageAccessData storageAccessData = m_jit.graph().m_storageAccessData[node.storageAccessDataIndex()];
 
 m_jit.load32(JITCompiler::Address(storageGPR, storageAccessData.offset * sizeof(EncodedJSValue) + OBJECT_OFFSETOF(EncodedValueDescriptor, asBits.payload)), resultPayloadGPR);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96347] trunk/Source/JavaScriptCore

2011-09-29 Thread barraclough

Title: [96347] trunk/Source/_javascript_Core








Revision 96347
Author barraclo...@apple.com
Date 2011-09-29 12:37:53 -0700 (Thu, 29 Sep 2011)


Log Message
DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69058

Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-09-29
Reviewed by Gavin Barraclough.

Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux

* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96346 => 96347)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 19:37:09 UTC (rev 96346)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 19:37:53 UTC (rev 96347)
@@ -1,3 +1,15 @@
+2011-09-29  Yuqiang Xian  yuqiang.x...@intel.com
+
+DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT
+https://bugs.webkit.org/show_bug.cgi?id=69058
+
+Reviewed by Gavin Barraclough.
+
+Also Fixed the stdcall FunctionPtr constructors to make them compiled correctly on Linux
+
+* assembler/MacroAssemblerCodeRef.h:
+(JSC::FunctionPtr::FunctionPtr):
+
 2011-09-29  Mark Hahnenberg  mhahnenb...@apple.com
 
 De-virtualize JSCell::visitChildrenVirtual and remove all other visitChildrenVirtual methods


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (96346 => 96347)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-09-29 19:37:09 UTC (rev 96346)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-09-29 19:37:53 UTC (rev 96347)
@@ -1062,6 +1062,7 @@
 		86880F1914328BB900B08D42 /* DFGJITCompiler32_64.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = DFGJITCompiler32_64.cpp; path = dfg/DFGJITCompiler32_64.cpp; sourceTree = group; };
 		86880F1A14328BB900B08D42 /* DFGJITCompilerInlineMethods.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = DFGJITCompilerInlineMethods.h; path = dfg/DFGJITCompilerInlineMethods.h; sourceTree = group; };
 		86880F1B14328BB900B08D42 /* DFGSpeculativeJIT32_64.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = DFGSpeculativeJIT32_64.cpp; path = dfg/DFGSpeculativeJIT32_64.cpp; sourceTree = group; };
+		86880F311434FFAF00B08D42 /* ChangeLog */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ChangeLog; sourceTree = group; };
 		868BFA00117CEFD100B908B1 /* AtomicString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = AtomicString.cpp; path = text/AtomicString.cpp; sourceTree = group; };
 		868BFA01117CEFD100B908B1 /* AtomicString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AtomicString.h; path = text/AtomicString.h; sourceTree = group; };
 		868BFA02117CEFD100B908B1 /* AtomicStringImpl.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = AtomicStringImpl.h; path = text/AtomicStringImpl.h; sourceTree = group; };
@@ -1531,6 +1532,7 @@
 		0867D691FE84028FC02AAC07 /* _javascript_Core */ = {
 			isa = PBXGroup;
 			children = (
+86880F311434FFAF00B08D42 /* ChangeLog */,
 651122E5140469BA002B101D /* testRegExp.cpp */,
 A718F8211178EB4B002465A7 /* create_regex_tables */,
 937B63CC09E766D200A671DD /* DerivedSources.make */,


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h (96346 => 96347)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2011-09-29 19:37:09 UTC (rev 96346)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2011-09-29 19:37:53 UTC (rev 96347)
@@ -52,7 +52,7 @@
 #define ASSERT_VALID_CODE_OFFSET(offset) // Anything goes!
 #endif
 
-#if CPU(X86)  PLATFORM(MAC)
+#if CPU(X86)  !PLATFORM(WINDOWS)
 #define CALLING_CONVENTION_IS_CDECL 1
 #else
 #define CALLING_CONVENTION_IS_CDECL 0
@@ -109,35 +109,35 @@
 #if CALLING_CONVENTION_IS_CDECL
 #define STDCALL __attribute__ ((stdcall))
 templatetypename returnType
-FunctionPtr(returnType STDCALL(*value)())
+FunctionPtr(returnType (STDCALL *value)())
 : m_value((void*)value)
 {
 ASSERT_VALID_CODE_POINTER(m_value);
 }
 
 templatetypename returnType, typename argType1
-FunctionPtr(returnType STDCALL(*value)(argType1))
+FunctionPtr(returnType (STDCALL *value)(argType1))
 : m_value((void*)value)
 {
 ASSERT_VALID_CODE_POINTER(m_value);
 }
 
 templatetypename returnType, typename argType1, typename argType2
-FunctionPtr(returnType STDCALL(*value)(argType1, argType2))
+

[webkit-changes] [96349] trunk/Source/WebCore

2011-09-29 Thread japhet

Title: [96349] trunk/Source/WebCore








Revision 96349
Author jap...@chromium.org
Date 2011-09-29 12:46:01 -0700 (Thu, 29 Sep 2011)


Log Message
[V8, chromium] More logging to determine cause of a null
v8::Context in V8DOMWindowShell::namedItemAdded().

https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96348 => 96349)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 19:40:34 UTC (rev 96348)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 19:46:01 UTC (rev 96349)
@@ -1,3 +1,15 @@
+2011-09-29  Nate Chapin  jap...@chromium.org
+
+[V8, chromium] More logging to determine cause of a null
+v8::Context in V8DOMWindowShell::namedItemAdded().
+
+https://bugs.webkit.org/show_bug.cgi?id=68099
+
+Reviewed by Adam Barth.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::namedItemAdded):
+
 2011-09-29  Alexey Proskuryakov  a...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=69040


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (96348 => 96349)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-29 19:40:34 UTC (rev 96348)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-29 19:46:01 UTC (rev 96349)
@@ -78,6 +78,10 @@
 
 namespace WebCore {
 
+// FIXME: Temporary diagnostics as to why V8 sometimes crashes with a null context in namedItemAdded().
+// See https://bugs.webkit.org/show_bug.cgi?id=68099.
+static int s_contextFailureReason = -1;
+
 static void handleFatalErrorInV8()
 {
 // FIXME: We temporarily deal with V8 internal error situations
@@ -318,6 +322,7 @@
 // Bail out if allocation of the first global objects fails.
 if (m_global.IsEmpty()) {
 disposeContextHandles();
+s_contextFailureReason = 3;
 return false;
 }
 #ifndef NDEBUG
@@ -353,14 +358,18 @@
 v8::Persistentv8::Context result;
 
 // The activeDocumentLoader pointer could be 0 during frame shutdown.
-if (!m_frame-loader()-activeDocumentLoader())
+if (!m_frame-loader()-activeDocumentLoader()) {
+s_contextFailureReason = 0;
 return result;
+}
 
 // Create a new environment using an empty template for the shadow
 // object. Reuse the global object if one has been created earlier.
 v8::Persistentv8::ObjectTemplate globalTemplate = V8DOMWindow::GetShadowObjectTemplate();
-if (globalTemplate.IsEmpty())
+if (globalTemplate.IsEmpty()) {
+s_contextFailureReason = 1;
 return result;
+}
 
 // Used to avoid sleep calls in unload handlers.
 if (!V8Proxy::registeredExtensionWithV8(DateExtension::get()))
@@ -387,6 +396,8 @@
 v8::ExtensionConfiguration extensionConfiguration(index, extensionNames.get());
 result = v8::Context::New(extensionConfiguration, globalTemplate, global);
 
+if (result.IsEmpty())
+s_contextFailureReason = 2;
 return result;
 }
 
@@ -406,8 +417,10 @@
 v8::Handlev8::Function windowConstructor = V8DOMWrapper::getConstructor(V8DOMWindow::info, getHiddenObjectPrototype(context));
 v8::Localv8::Object jsWindow = SafeAllocation::newInstance(windowConstructor);
 // Bail out if allocation failed.
-if (jsWindow.IsEmpty())
+if (jsWindow.IsEmpty()) {
+s_contextFailureReason = 7;
 return false;
+}
 
 // Wrap the window.
 V8DOMWrapper::setDOMWrapper(jsWindow, V8DOMWindow::info, window);
@@ -573,15 +586,16 @@
 #if PLATFORM(CHROMIUM)
 // FIXME: Temporary diagnostics as to why V8 sometimes crashes with a null context below.
 // See https://bugs.webkit.org/show_bug.cgi?id=68099.
-PlatformSupport::incrementStatsCounter(V8Bindings.namedItemAdded.initContextFailed);
+PlatformSupport::histogramEnumeration(V8Bindings.nullContextState, 0, 3);
 if (m_frame-settings()  !m_frame-settings()-isJavaScriptEnabled())
-PlatformSupport::incrementStatsCounter(V8Bindings.namedItemAdded.scriptBlockedByWebCoreSettings);
+PlatformSupport::histogramEnumeration(V8Bindings.nullContextState, 1, 3);
 
 if (!m_frame-script()-canExecuteScripts(NotAboutToExecuteScript))
-PlatformSupport::incrementStatsCounter(V8Bindings.namedItemAdded.scriptBlockedByScriptController);
+PlatformSupport::histogramEnumeration(V8Bindings.nullContextState, 2, 3);
 
-if (V8Proxy::handleOutOfMemory())
-PlatformSupport::incrementStatsCounter(V8Bindings.namedItemAdded.outOfMemory);
+ if (s_contextFailureReason = 0  s_contextFailureReason = 7);
+PlatformSupport::histogramEnumeration(V8Bindings.nullContextReason, s_contextFailureReason, 8);
+ s_contextFailureReason = -1;
 #endif

[webkit-changes] [96350] trunk/Source/WebCore

2011-09-29 Thread mhahnenberg

Title: [96350] trunk/Source/WebCore








Revision 96350
Author mhahnenb...@apple.com
Date 2011-09-29 13:14:44 -0700 (Thu, 29 Sep 2011)


Log Message
Unreviewed: resetting baseline for code generator bindings

Unreviewed build fix

No new tests.

* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96349 => 96350)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 19:46:01 UTC (rev 96349)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 20:14:44 UTC (rev 96350)
@@ -1,3 +1,14 @@
+2011-09-29  Mark Hahnenberg  mhahnenb...@apple.com
+
+Unreviewed: resetting baseline for code generator bindings
+
+Unreviewed build fix
+
+No new tests.
+
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/JS/JSTestObj.h:
+
 2011-09-29  Nate Chapin  jap...@chromium.org
 
 [V8, chromium] More logging to determine cause of a null


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (96349 => 96350)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-09-29 19:46:01 UTC (rev 96349)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2011-09-29 20:14:44 UTC (rev 96350)
@@ -1870,11 +1870,6 @@
 return JSValue::encode(result);
 }
 
-void JSTestObj::visitChildrenVirtual(SlotVisitor visitor)
-{
-visitChildren(this, visitor);
-}
-
 void JSTestObj::visitChildren(JSCell* cell, SlotVisitor visitor)
 {
 JSTestObj* thisObject = static_castJSTestObj*(cell);


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h (96349 => 96350)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2011-09-29 19:46:01 UTC (rev 96349)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h	2011-09-29 20:14:44 UTC (rev 96350)
@@ -53,7 +53,6 @@
 static JSC::JSValue getConstructor(JSC::ExecState*, JSC::JSGlobalObject*);
 JSC::WriteBarrierJSC::Unknown m_cachedAttribute1;
 JSC::WriteBarrierJSC::Unknown m_cachedAttribute2;
-virtual void visitChildrenVirtual(JSC::SlotVisitor);
 static void visitChildren(JSCell*, JSC::SlotVisitor);
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96352] trunk/Source/WebCore

2011-09-29 Thread commit-queue

Title: [96352] trunk/Source/WebCore








Revision 96352
Author commit-qu...@webkit.org
Date 2011-09-29 13:30:17 -0700 (Thu, 29 Sep 2011)


Log Message
Shrink HTMLAnchorElement on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=69094

Patch by Andreas Kling kl...@webkit.org on 2011-09-29
Reviewed by Antti Koivisto.

* html/HTMLAnchorElement.h: Pack members into a bitfield.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAnchorElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96351 => 96352)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 20:21:02 UTC (rev 96351)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 20:30:17 UTC (rev 96352)
@@ -1,3 +1,12 @@
+2011-09-29  Andreas Kling  kl...@webkit.org
+
+Shrink HTMLAnchorElement on 32-bit.
+https://bugs.webkit.org/show_bug.cgi?id=69094
+
+Reviewed by Antti Koivisto.
+
+* html/HTMLAnchorElement.h: Pack members into a bitfield.
+
 2011-09-29  Dan Bernstein  m...@apple.com
 
 rdar://problem/10191243 Glyph variants (line final swashes) appear where they should not


Modified: trunk/Source/WebCore/html/HTMLAnchorElement.h (96351 => 96352)

--- trunk/Source/WebCore/html/HTMLAnchorElement.h	2011-09-29 20:21:02 UTC (rev 96351)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.h	2011-09-29 20:30:17 UTC (rev 96352)
@@ -126,8 +126,8 @@
 bool treatLinkAsLiveForEventType(EventType) const;
 
 RefPtrElement m_rootEditableElementForSelectionOnMouseDown;
-bool m_wasShiftKeyDownOnMouseDown;
-uint32_t m_linkRelations;
+bool m_wasShiftKeyDownOnMouseDown : 1;
+uint32_t m_linkRelations : 31;
 };
 
 // Functions shared with the other anchor elements (i.e., SVG).






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96353] trunk/Source/WebCore

2011-09-29 Thread rniwa

Title: [96353] trunk/Source/WebCore








Revision 96353
Author rn...@webkit.org
Date 2011-09-29 13:31:41 -0700 (Thu, 29 Sep 2011)


Log Message
Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=69023

Reviewed by Enrica Casucci.

Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).

Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.

Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
completeHTMLReplacement by nullity checks of start and end positions.

* dom/Node.cpp:
(WebCore::Node::traversePreviousSibling): Added.
* dom/Node.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
willRemoveNode.
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
removeUnrenderedTextNodesAtEnds.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
accessing m_firstNodeInserted.
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
* editing/ReplaceSelectionCommand.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (96352 => 96353)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 20:30:17 UTC (rev 96352)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 20:31:41 UTC (rev 96353)
@@ -1,3 +1,41 @@
+2011-09-29  Ryosuke Niwa  rn...@webkit.org
+
+Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand
+https://bugs.webkit.org/show_bug.cgi?id=69023
+
+Reviewed by Enrica Casucci.
+
+Converted to removeUnrenderedTextNodesAtEnds to use InsertedNodes instead of m_firstNodeInserted
+and m_lastLeafInserted. Extracted the logic to update nodes as InsertedNodes::willRemoveNode
+(old one was renamed to InsertedNodes::willRemoveNodePreservingChildren).
+
+Also extracted shouldPerformSmartReplace and addSpacesForSmartReplace out of doApply,
+and rewrote the logic to obtain endNode and startNode using startOfInsertedContent and
+endOfInsertedContent instead of m_firstNodeInserted and m_lastLeafInserted.
+
+Finally, replaced the nullity checks of m_firstNodeInserted and m_lastLeafInserted in
+completeHTMLReplacement by nullity checks of start and end positions.
+
+* dom/Node.cpp:
+(WebCore::Node::traversePreviousSibling): Added.
+* dom/Node.h:
+* editing/ReplaceSelectionCommand.cpp:
+(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren): Renamed from
+willRemoveNode.
+(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode): Extracted from
+removeUnrenderedTextNodesAtEnds.
+(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
+(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
+(WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Made const.
+(WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Made const.
+(WebCore::ReplaceSelectionCommand::handleStyleSpans): Takes firstNodeInserted instead of directly
+accessing m_firstNodeInserted.
+(WebCore::ReplaceSelectionCommand::doApply):
+(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
+(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
+(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
+* editing/ReplaceSelectionCommand.h:
+
 2011-09-29  Andreas Kling  kl...@webkit.org
 
 Shrink HTMLAnchorElement on 32-bit.


Modified: trunk/Source/WebCore/dom/Node.cpp (96352 => 96353)

--- trunk/Source/WebCore/dom/Node.cpp	2011-09-29 20:30:17 UTC (rev 96352)
+++ trunk/Source/WebCore/dom/Node.cpp	2011-09-29

[webkit-changes] [96354] trunk/Source/JavaScriptCore

2011-09-29 Thread fpizlo

Title: [96354] trunk/Source/_javascript_Core








Revision 96354
Author fpi...@apple.com
Date 2011-09-29 13:45:52 -0700 (Thu, 29 Sep 2011)


Log Message
Structure transitions involving many ( 64) properties sometimes cause structure corruption
https://bugs.webkit.org/show_bug.cgi?id=69102

Reviewed by Darin Adler.

Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
don't lead to the dictionary kind being forgotten.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
* runtime/Structure.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Structure.cpp
trunk/Source/_javascript_Core/runtime/Structure.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96353 => 96354)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 20:31:41 UTC (rev 96353)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 20:45:52 UTC (rev 96354)
@@ -1,3 +1,17 @@
+2011-09-29  Filip Pizlo  fpi...@apple.com
+
+Structure transitions involving many ( 64) properties sometimes cause structure corruption
+https://bugs.webkit.org/show_bug.cgi?id=69102
+
+Reviewed by Darin Adler.
+
+Made m_offset an int instead of a signed char. Changed the code to ensure that transitions
+don't lead to the dictionary kind being forgotten.
+
+* runtime/Structure.cpp:
+(JSC::Structure::Structure):
+* runtime/Structure.h:
+
 2011-09-29  Yuqiang Xian  yuqiang.x...@intel.com
 
 DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT


Modified: trunk/Source/_javascript_Core/runtime/Structure.cpp (96353 => 96354)

--- trunk/Source/_javascript_Core/runtime/Structure.cpp	2011-09-29 20:31:41 UTC (rev 96353)
+++ trunk/Source/_javascript_Core/runtime/Structure.cpp	2011-09-29 20:45:52 UTC (rev 96354)
@@ -202,7 +202,7 @@
 , m_classInfo(previous-m_classInfo)
 , m_propertyStorageCapacity(previous-m_propertyStorageCapacity)
 , m_offset(noOffset)
-, m_dictionaryKind(NoneDictionaryKind)
+, m_dictionaryKind(previous-m_dictionaryKind)
 , m_isPinnedPropertyTable(false)
 , m_hasGetterSetterProperties(previous-m_hasGetterSetterProperties)
 , m_hasNonEnumerableProperties(previous-m_hasNonEnumerableProperties)


Modified: trunk/Source/_javascript_Core/runtime/Structure.h (96353 => 96354)

--- trunk/Source/_javascript_Core/runtime/Structure.h	2011-09-29 20:31:41 UTC (rev 96353)
+++ trunk/Source/_javascript_Core/runtime/Structure.h	2011-09-29 20:45:52 UTC (rev 96354)
@@ -237,9 +237,9 @@
 
 bool isValid(ExecState*, StructureChain* cachedPrototypeChain) const;
 
-static const signed char s_maxTransitionLength = 64;
+static const int s_maxTransitionLength = 64;
 
-static const signed char noOffset = -1;
+static const int noOffset = -1;
 
 static const unsigned maxSpecificFunctionThrashCount = 3;
 
@@ -264,7 +264,7 @@
 uint32_t m_propertyStorageCapacity;
 
 // m_offset does not account for anonymous slots
-signed char m_offset;
+int m_offset;
 
 unsigned m_dictionaryKind : 2;
 bool m_isPinnedPropertyTable : 1;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96356] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96356] trunk/LayoutTests








Revision 96356
Author aba...@webkit.org
Date 2011-09-29 13:51:19 -0700 (Thu, 29 Sep 2011)


Log Message
Mark test as expected to fail.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96355 => 96356)

--- trunk/LayoutTests/ChangeLog	2011-09-29 20:50:20 UTC (rev 96355)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 20:51:19 UTC (rev 96356)
@@ -1,3 +1,9 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+Mark test as expected to fail.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-29  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2] Skip all failing tests (10605!) after refactored Qt5.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96355 => 96356)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 20:50:20 UTC (rev 96355)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 20:51:19 UTC (rev 96356)
@@ -3845,3 +3845,5 @@
 BUGWK69078 MAC CPU-CG : editing/unsupported-content/table-type-before.html = IMAGE
 
 BUGABARTH LEOPARD : svg/custom/pattern-excessive-malloc.svg = IMAGE
+
+BUGWK69103 : fast/text/line-initial-and-final-swashes.html = IMAGE+TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96357] trunk/Source/WebCore

2011-09-29 Thread abarth

Title: [96357] trunk/Source/WebCore








Revision 96357
Author aba...@webkit.org
Date 2011-09-29 14:07:11 -0700 (Thu, 29 Sep 2011)


Log Message
Fixenate the build.

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::namedItemAdded):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96356 => 96357)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 20:51:19 UTC (rev 96356)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 21:07:11 UTC (rev 96357)
@@ -1,3 +1,10 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+Fixenate the build.
+
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::namedItemAdded):
+
 2011-09-29  Ryosuke Niwa  rn...@webkit.org
 
 Remove direct reads to m_firstNodeInserted and m_lastLeafInserted in ReplaceSelectionCommand


Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (96356 => 96357)

--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-29 20:51:19 UTC (rev 96356)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp	2011-09-29 21:07:11 UTC (rev 96357)
@@ -593,9 +593,9 @@
 if (!m_frame-script()-canExecuteScripts(NotAboutToExecuteScript))
 PlatformSupport::histogramEnumeration(V8Bindings.nullContextState, 2, 3);
 
- if (s_contextFailureReason = 0  s_contextFailureReason = 7);
+if (s_contextFailureReason = 0  s_contextFailureReason = 7)
 PlatformSupport::histogramEnumeration(V8Bindings.nullContextReason, s_contextFailureReason, 8);
- s_contextFailureReason = -1;
+s_contextFailureReason = -1;
 #endif
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96358] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96358] trunk/LayoutTests








Revision 96358
Author aba...@webkit.org
Date 2011-09-29 14:12:10 -0700 (Thu, 29 Sep 2011)


Log Message
Attempt to update these image results again.

* platform/chromium-cg-mac-leopard/http/tests/misc: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
* platform/chromium-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt
trunk/LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/
trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96357 => 96358)

--- trunk/LayoutTests/ChangeLog	2011-09-29 21:07:11 UTC (rev 96357)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 21:12:10 UTC (rev 96358)
@@ -1,5 +1,17 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Attempt to update these image results again.
+
+* platform/chromium-cg-mac-leopard/http/tests/misc: Added.
+* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png: Added.
+* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
+* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
+* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt:
+* platform/chromium-mac/http/tests/misc/acid3-expected.png:
+* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Mark test as expected to fail.
 
 * platform/chromium/test_expectations.txt:


Modified: trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt (96357 => 96358)

--- trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt	2011-09-29 21:07:11 UTC (rev 96357)
+++ trunk/LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt	2011-09-29 21:12:10 UTC (rev 96358)
@@ -18,7 +18,7 @@
   RenderBlock {P} at (41,214) size 568x120
 RenderInline {SPAN} at (0,0) size 112x112
   RenderText {#text} at (260,4) size 112x112
-text run at (260,4) width 112: 92
+text run at (260,4) width 112: 94
 RenderInline {SPAN} at (0,0) size 28x112
   RenderText {#text} at (372,4) size 28x112
 text run at (372,4) width 28: /


Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt (0 => 96358)

--- trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt	2011-09-29 21:12:10 UTC (rev 96358)
@@ -0,0 +1,244 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (20,20) size 644x433
+  RenderBlock {HTML} at (20,20) size 644x433 [bgcolor=#C0C0C0] [border: none (4px solid #808080) none]
+RenderBody {BODY} at (-4,-4) size 644x433 [bgcolor=#FF] [border: (1px solid #00)]
+  RenderBlock {H1} at (41,41) size 562x120
+RenderText {#text} at (0,4) size 273x112
+  text run at (0,4) width 273: Acid3
+  RenderBlock {DIV} at (41,121) size 562x312
+RenderBlock {P} at (7,80) size 54x42 [bgcolor=#FF] [border: (1px solid #00)]
+RenderBlock {P} at (70,64) size 64x50 [bgcolor=#FFA500] [border: (1px solid #00)]
+RenderBlock {P} at (145,48) size 74x58 [bgcolor=#00] [border: (1px solid #00)]
+RenderBlock {P} at (231,32) size 86x66 [bgcolor=#00FF00] [border: (1px solid #00)]
+RenderBlock {P} at (330,16) size 96x74 [bgcolor=#FF] [border: (1px solid #00)]
+RenderBlock {P} at (441,0) size 106x82 [bgcolor=#800080] [border: (1px solid #00)]
+RenderText {#text} at (0,0) size 0x0
+  RenderBlock {P} at (41,214) size 568x120
+

[webkit-changes] [96359] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96359] trunk/LayoutTests








Revision 96359
Author aba...@webkit.org
Date 2011-09-29 14:15:56 -0700 (Thu, 29 Sep 2011)


Log Message
Delete bogus expectation.

* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96358 => 96359)

--- trunk/LayoutTests/ChangeLog	2011-09-29 21:12:10 UTC (rev 96358)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 21:15:56 UTC (rev 96359)
@@ -1,5 +1,11 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+Delete bogus expectation.
+
+* platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Attempt to update these image results again.
 
 * platform/chromium-cg-mac-leopard/http/tests/misc: Added.


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt (96358 => 96359)

--- trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt	2011-09-29 21:12:10 UTC (rev 96358)
+++ trunk/LayoutTests/platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt	2011-09-29 21:15:56 UTC (rev 96359)
@@ -1,21 +0,0 @@
-layer at (0,0) size 608x240
-  RenderView at (0,0) size 360x240
-layer at (0,0) size 360x236
-  RenderBlock {html} at (0,0) size 360x236
-RenderBody {body} at (8,16) size 344x204
-  RenderBlock {p} at (0,0) size 344x204
-RenderSVGRoot {svg} at (8,26) size 247x57
-  RenderSVGHiddenContainer {defs} at (0,0) size 0x0
-RenderSVGResourceLinearGradient {linearGradient} [id=gradient] [gradientUnits=objectBoundingBox] [gradientTransform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [start=(0,0)] [end=(1,0)]
-  RenderSVGGradientStop {stop} [offset=0.00] [color=#00]
-  RenderSVGGradientStop {stop} [offset=1.00] [color=#FF]
-  RenderSVGContainer {g} at (8,26) size 247x57
-RenderSVGText {text} at (0,12) size 245x23 contains 1 chunk(s)
-  RenderSVGInlineText {#text} at (0,0) size 245x23
-chunk 1 text run 1 at (0.00,30.00) startOffset 0 endOffset 28 width 245.00: Should have blue background.
-RenderSVGText {text} at (0,42) size 245x23 contains 1 chunk(s)
-  RenderSVGInlineText {#text} at (0,0) size 245x23
-chunk 1 text run 1 at (0.00,60.00) startOffset 0 endOffset 28 width 245.00: Should have blue background.
-RenderText {#text} at (0,0) size 0x0
-selection start: position 0 of child 0 {#text} of child 1 {text} of child 3 {g} of child 1 {svg} of child 1 {p} of body
-selection end:   position 28 of child 0 {#text} of child 3 {text} of child 3 {g} of child 1 {svg} of child 1 {p} of body






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96360] trunk/Tools

2011-09-29 Thread vestbo

Title: [96360] trunk/Tools








Revision 96360
Author ves...@webkit.org
Date 2011-09-29 14:29:11 -0700 (Thu, 29 Sep 2011)


Log Message
[Qt] Try to fix the minial build

* QtTestBrowser/launcherwindow.cpp:
* QtTestBrowser/webpage.cpp:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QtTestBrowser/launcherwindow.cpp
trunk/Tools/QtTestBrowser/webpage.cpp




Diff

Modified: trunk/Tools/ChangeLog (96359 => 96360)

--- trunk/Tools/ChangeLog	2011-09-29 21:15:56 UTC (rev 96359)
+++ trunk/Tools/ChangeLog	2011-09-29 21:29:11 UTC (rev 96360)
@@ -1,3 +1,10 @@
+2011-09-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Try to fix the minial build
+
+* QtTestBrowser/launcherwindow.cpp:
+* QtTestBrowser/webpage.cpp:
+
 2011-09-23  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi


Modified: trunk/Tools/QtTestBrowser/launcherwindow.cpp (96359 => 96360)

--- trunk/Tools/QtTestBrowser/launcherwindow.cpp	2011-09-29 21:15:56 UTC (rev 96359)
+++ trunk/Tools/QtTestBrowser/launcherwindow.cpp	2011-09-29 21:29:11 UTC (rev 96360)
@@ -800,7 +800,9 @@
 void LauncherWindow::setEditable(bool on)
 {
 page()-setContentEditable(on);
+#ifndef QT_NO_SHORTCUT
 m_formatMenuAction-setVisible(on);
+#endif
 }
 
 /*
@@ -861,7 +863,9 @@
 {
 m_windowOptions.useGraphicsView = graphicsBased;
 initializeView();
+#ifndef QT_NO_SHORTCUT
 menuBar()-clear();
+#endif
 createChrome();
 }
 


Modified: trunk/Tools/QtTestBrowser/webpage.cpp (96359 => 96360)

--- trunk/Tools/QtTestBrowser/webpage.cpp	2011-09-29 21:15:56 UTC (rev 96359)
+++ trunk/Tools/QtTestBrowser/webpage.cpp	2011-09-29 21:29:11 UTC (rev 96360)
@@ -40,6 +40,7 @@
 #ifndef QT_NO_DESKTOPSERVICES
 #include QDesktopServices
 #endif
+#include QDialog
 #include QDialogButtonBox
 #include QLabel
 #include QLayout






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96361] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96361] trunk/LayoutTests








Revision 96361
Author aba...@webkit.org
Date 2011-09-29 14:58:53 -0700 (Thu, 29 Sep 2011)


Log Message
This test can also time out.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96360 => 96361)

--- trunk/LayoutTests/ChangeLog	2011-09-29 21:29:11 UTC (rev 96360)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 21:58:53 UTC (rev 96361)
@@ -1,5 +1,11 @@
 2011-09-29  Adam Barth  aba...@webkit.org
 
+This test can also time out.
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Adam Barth  aba...@webkit.org
+
 Delete bogus expectation.
 
 * platform/chromium-cg-mac/svg/text/selection-background-color-expected.txt: Removed.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96360 => 96361)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 21:29:11 UTC (rev 96360)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-29 21:58:53 UTC (rev 96361)
@@ -3511,7 +3511,7 @@
 
 BUGWK66419 : http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html = TEXT
 BUGWK66419 : http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html = TEXT
-BUGWK66419 : http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html = TEXT
+BUGWK66419 : http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html = TEXT TIMEOUT
 
 BUGWK67121 DEBUG SLOW : editing/selection/move-by-word-visually-multi-space.html = PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96362] trunk/Source/WebKit/efl

2011-09-29 Thread commit-queue

Title: [96362] trunk/Source/WebKit/efl








Revision 96362
Author commit-qu...@webkit.org
Date 2011-09-29 15:02:37 -0700 (Thu, 29 Sep 2011)


Log Message
[EFL] API to get plain text of the frame
https://bugs.webkit.org/show_bug.cgi?id=67114

Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-09-29
Reviewed by Ryosuke Niwa.

Add a function to return a frame's contents converted to plain text,
as already exposed by other ports and needed by DRT when dumping a
frame's contents.

* ewk/ewk_frame.cpp:
(ewk_frame_plain_text_get):
* ewk/ewk_frame.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_frame.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (96361 => 96362)

--- trunk/Source/WebKit/efl/ChangeLog	2011-09-29 21:58:53 UTC (rev 96361)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-09-29 22:02:37 UTC (rev 96362)
@@ -1,3 +1,18 @@
+2011-09-29  Raphael Kubo da Costa  k...@profusion.mobi
+
+[EFL] API to get plain text of the frame
+https://bugs.webkit.org/show_bug.cgi?id=67114
+
+Reviewed by Ryosuke Niwa.
+
+Add a function to return a frame's contents converted to plain text,
+as already exposed by other ports and needed by DRT when dumping a
+frame's contents.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_plain_text_get):
+* ewk/ewk_frame.h:
+
 2011-09-28  KwangHyuk Kim  hyuki@samsung.com
 
 [EFL] Remove useless assignment code in _ewk_tiled_backing_store_zoom_set_internal.


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (96361 => 96362)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-29 21:58:53 UTC (rev 96361)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-09-29 22:02:37 UTC (rev 96362)
@@ -1587,6 +1587,22 @@
 return 0;
 }
 
+char* ewk_frame_plain_text_get(const Evas_Object* ewkFrame)
+{
+EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, sd, 0);
+EINA_SAFETY_ON_NULL_RETURN_VAL(sd-frame, 0);
+
+if (!sd-frame-document())
+return 0;
+
+WebCore::Element* documentElement = sd-frame-document()-documentElement();
+
+if (!documentElement)
+return 0;
+
+return strdup(documentElement-innerText().utf8().data());
+}
+
 /**
  * @internal
  * Reports uri changed and swap internal string reference.


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.h (96361 => 96362)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.h	2011-09-29 21:58:53 UTC (rev 96361)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.h	2011-09-29 22:02:37 UTC (rev 96362)
@@ -804,6 +804,19 @@
  */
 EAPI Eina_List *ewk_frame_resources_location_get(const Evas_Object *o);
 
+/**
+ * Retrieve the frame's contents in plain text.
+ *
+ * This function returns the contents of the given frame converted to plain text,
+ * removing all the HTML formatting.
+ *
+ * @param ewkFrame Frame object whose contents to retrieve.
+ *
+ * @return A newly allocated string (which must be freed by the caller with @c free())
+ * or @c 0 in case of failure.
+ */
+EAPI char* ewk_frame_plain_text_get(const Evas_Object* o);
+
 #ifdef __cplusplus
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96363] trunk/Source/JavaScriptCore

2011-09-29 Thread barraclough

Title: [96363] trunk/Source/_javascript_Core








Revision 96363
Author barraclo...@apple.com
Date 2011-09-29 15:13:37 -0700 (Thu, 29 Sep 2011)


Log Message
Unreviewed windows build fix.

* assembler/MacroAssemblerCodeRef.h:
* dfg/DFGOperations.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h
trunk/Source/_javascript_Core/dfg/DFGOperations.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96362 => 96363)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 22:02:37 UTC (rev 96362)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 22:13:37 UTC (rev 96363)
@@ -1,3 +1,10 @@
+2011-09-29  Gavin Barraclough  barraclo...@apple.com
+
+Unreviewed windows build fix.
+
+* assembler/MacroAssemblerCodeRef.h:
+* dfg/DFGOperations.h:
+
 2011-09-29  Filip Pizlo  fpi...@apple.com
 
 Structure transitions involving many ( 64) properties sometimes cause structure corruption


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h (96362 => 96363)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2011-09-29 22:02:37 UTC (rev 96362)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h	2011-09-29 22:13:37 UTC (rev 96363)
@@ -52,7 +52,7 @@
 #define ASSERT_VALID_CODE_OFFSET(offset) // Anything goes!
 #endif
 
-#if CPU(X86)  !PLATFORM(WINDOWS)
+#if CPU(X86)  !PLATFORM(WIN)
 #define CALLING_CONVENTION_IS_CDECL 1
 #else
 #define CALLING_CONVENTION_IS_CDECL 0


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.h (96362 => 96363)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.h	2011-09-29 22:02:37 UTC (rev 96362)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.h	2011-09-29 22:13:37 UTC (rev 96363)
@@ -42,11 +42,9 @@
 
 extern C {
 
-#if CPU(X86)  COMPILER(GCC)
+#if CALLING_CONVENTION_IS_CDECL
 #define DFG_OPERATION __attribute__ ((stdcall))
-#endif
-
-#ifndef DFG_OPERATION
+#else
 #define DFG_OPERATION
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96365] trunk/Source

2011-09-29 Thread commit-queue

Title: [96365] trunk/Source








Revision 96365
Author commit-qu...@webkit.org
Date 2011-09-29 15:16:56 -0700 (Thu, 29 Sep 2011)


Log Message
 Implement flick gesture in Chromium Gesture Recognizer
 https://bugs.webkit.org/show_bug.cgi?id=67930

 Reviewed by Dimitri Glazkov.

 Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp

 * platform/chromium/GestureRecognizerChromium.cpp:
 (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed):
 (WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
 (WebCore::GestureRecognizerChromium::updateValues):
 (WebCore::GestureRecognizerChromium::scrollEnd):
 * platform/chromium/GestureRecognizerChromium.h:

Patch by Varun Jain varunj...@google.com on 2011-09-29

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp
trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.h
trunk/Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96364 => 96365)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 22:14:42 UTC (rev 96364)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 22:16:56 UTC (rev 96365)
@@ -1,3 +1,19 @@
+2011-09-29  Varun Jain  varunj...@google.com
+ 
+ Implement flick gesture in Chromium Gesture Recognizer
+ https://bugs.webkit.org/show_bug.cgi?id=67930
+ 
+ Reviewed by Dimitri Glazkov.
+ 
+ Test: Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp 
+ 
+ * platform/chromium/GestureRecognizerChromium.cpp:
+ (WebCore::GestureRecognizerChromium::isOverMinFlickSpeed):
+ (WebCore::GestureRecognizerChromium::appendScrollGestureEnd):
+ (WebCore::GestureRecognizerChromium::updateValues):
+ (WebCore::GestureRecognizerChromium::scrollEnd):
+ * platform/chromium/GestureRecognizerChromium.h:
+
 2011-09-29  Noel Gordon  noel.gor...@gmail.com
 
 [chromium] canvas.toDataURL(image/jpeg): use libjpeg-turbo data swizzle


Modified: trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp (96364 => 96365)

--- trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp	2011-09-29 22:14:42 UTC (rev 96364)
+++ trunk/Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp	2011-09-29 22:16:56 UTC (rev 96365)
@@ -38,11 +38,17 @@
 static const double minimumTouchDownDurationInSecondsForClick = 0.01;
 static const double maximumSecondsBetweenDoubleClick = 0.7;
 static const int maximumTouchMoveInPixelsForClick = 20;
+static const float minFlickSpeedSquared = 550.f * 550.f;
 
 GestureRecognizerChromium::GestureRecognizerChromium()
 : m_firstTouchTime(0.0)
 , m_state(GestureRecognizerChromium::NoGesture)
 , m_lastTouchTime(0.0)
+, m_lastClickTime(0.0)
+, m_lastTouchPosition()
+, m_lastTouchScreenPosition()
+, m_xVelocity(0.0)
+, m_yVelocity(0.0)
 , m_ctrlKey(false)
 , m_altKey(false)
 , m_shiftKey(false)
@@ -70,6 +76,12 @@
 m_firstTouchTime = 0.0;
 m_state = GestureRecognizerChromium::NoGesture;
 m_lastTouchTime = 0.0;
+m_lastTouchPosition.setX(0);
+m_lastTouchPosition.setY(0);
+m_lastTouchScreenPosition.setX(0);
+m_lastTouchScreenPosition.setY(0);
+m_xVelocity = 0.0;
+m_yVelocity = 0.0;
 }
 
 GestureRecognizerChromium::~GestureRecognizerChromium()
@@ -99,6 +111,11 @@
 return manhattanDistance  maximumTouchMoveInPixelsForClick;
 }
 
+bool GestureRecognizerChromium::isOverMinFlickSpeed()
+{
+return (m_xVelocity * m_xVelocity + m_yVelocity * m_yVelocity)  minFlickSpeedSquared;
+}
+
 void GestureRecognizerChromium::appendTapDownGestureEvent(const PlatformTouchPoint touchPoint, Gestures gestures)
 {
 gestures-append(PlatformGestureEvent(PlatformGestureEvent::TapDownType, m_firstTouchPosition, m_firstTouchScreenPosition, m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
@@ -138,9 +155,9 @@
 gestures-append(PlatformGestureEvent(PlatformGestureEvent::ScrollBeginType, touchPoint.pos(), touchPoint.screenPos(), m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
 }
 
-void GestureRecognizerChromium::appendScrollGestureEnd(const PlatformTouchPoint touchPoint, Gestures gestures)
+void GestureRecognizerChromium::appendScrollGestureEnd(const PlatformTouchPoint touchPoint, Gestures gestures, float xVelocity, float yVelocity)
 {
-gestures-append(PlatformGestureEvent(PlatformGestureEvent::ScrollEndType, touchPoint.pos(), touchPoint.screenPos(), m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
+gestures-append(PlatformGestureEvent(PlatformGestureEvent::ScrollEndType, touchPoint.pos(), touchPoint.screenPos(), m_lastTouchTime, xVelocity, yVelocity, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));
 }
 
 void GestureRecognizerChromium::appendScrollGestureUpdate(const PlatformTouchPoint touchPoint, Gestures gestures)
@@ -154,11 +171,20 @@
 
 void

[webkit-changes] [96366] trunk/Source/WebCore

2011-09-29 Thread caryclark

Title: [96366] trunk/Source/WebCore








Revision 96366
Author carycl...@google.com
Date 2011-09-29 15:21:00 -0700 (Thu, 29 Sep 2011)


Log Message
Enable LCD text in Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=68734

Reviewed by Stephen White.

No new tests. Existing layout tests are generated
with LCD text disabled for pixel comparisons.

Duplicate the logic in FontMac.mm to pass settings
for antialiasing and smoothing. Also disable smoothing
for DumpRenderTree.

* platform/graphics/skia/FontSkia.cpp:
(WebCore::setupPaint):
(WebCore::Font::drawGlyphs):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (96365 => 96366)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 22:16:56 UTC (rev 96365)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 22:21:00 UTC (rev 96366)
@@ -1,3 +1,21 @@
+2011-09-29  Cary Clark  carycl...@google.com
+
+Enable LCD text in Skia on Mac
+https://bugs.webkit.org/show_bug.cgi?id=68734
+
+Reviewed by Stephen White.
+
+No new tests. Existing layout tests are generated
+with LCD text disabled for pixel comparisons.
+
+Duplicate the logic in FontMac.mm to pass settings
+for antialiasing and smoothing. Also disable smoothing
+for DumpRenderTree.
+ 
+* platform/graphics/skia/FontSkia.cpp:
+(WebCore::setupPaint):
+(WebCore::Font::drawGlyphs):
+
 2011-09-29  Varun Jain  varunj...@google.com
  
  Implement flick gesture in Chromium Gesture Recognizer


Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (96365 => 96366)

--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp	2011-09-29 22:16:56 UTC (rev 96365)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp	2011-09-29 22:21:00 UTC (rev 96366)
@@ -34,6 +34,7 @@
 #include GlyphBuffer.h
 #include GraphicsContext.h
 #include PlatformContextSkia.h
+#include PlatformSupport.h
 #include SimpleFontData.h
 
 #include SkCanvas.h
@@ -73,12 +74,12 @@
 paint-setLCDRenderText(false);
 }
 
-static void setupPaint(SkPaint* paint, const SimpleFontData* fontData, const Font* font)
+static void setupPaint(SkPaint* paint, const SimpleFontData* fontData, const Font* font, bool shouldAntialias, bool shouldSmoothFonts)
 {
 const FontPlatformData platformData = fontData-platformData();
 const float textSize = platformData.m_size = 0 ? platformData.m_size : 12;
 
-paint-setAntiAlias(true);
+paint-setAntiAlias(shouldAntialias);
 paint-setEmbeddedBitmapText(false);
 paint-setTextSize(SkFloatToScalar(textSize));
 SkTypeface* typeface = SkCreateTypefaceFromCTFont(platformData.ctFont());
@@ -87,7 +88,7 @@
 paint-setFakeBoldText(platformData.m_syntheticBold);
 paint-setTextSkewX(platformData.m_syntheticOblique ? -SK_Scalar1 / 4 : 0);
 paint-setAutohinted(false); // freetype specific
-paint-setLCDRenderText(font-fontDescription().fontSmoothing() == SubpixelAntialiased);
+paint-setLCDRenderText(shouldSmoothFonts);
 }
 
 // TODO: This needs to be split into helper functions to better scope the
@@ -98,6 +99,27 @@
   const FloatPoint point) const {
 COMPILE_ASSERT(sizeof(GlyphBufferGlyph) == sizeof(uint16_t), GlyphBufferGlyphSize_equals_uint16_t);
 
+bool shouldSmoothFonts = true;
+bool shouldAntialias = true;
+
+switch (fontDescription().fontSmoothing()) {
+case Antialiased:
+shouldSmoothFonts = false;
+break;
+case SubpixelAntialiased:
+break;
+case NoSmoothing:
+shouldAntialias = false;
+shouldSmoothFonts = false;
+break;
+case AutoSmoothing:
+// For the AutoSmooth case, don't do anything! Keep the default settings.
+break; 
+}
+
+if (!shouldUseSmoothing() || PlatformSupport::layoutTestMode())
+shouldSmoothFonts = false;
+
 const GlyphBufferGlyph* glyphs = glyphBuffer.glyphs(from);
 SkScalar x = SkFloatToScalar(point.x());
 SkScalar y = SkFloatToScalar(point.y());
@@ -133,7 +155,7 @@
 if (textMode  TextModeFill) {
 SkPaint paint;
 gc-platformContext()-setupPaintForFilling(paint);
-setupPaint(paint, font, this);
+setupPaint(paint, font, this, shouldAntialias, shouldSmoothFonts);
 adjustTextRenderMode(paint, gc-platformContext());
 paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
 paint.setColor(gc-fillColor().rgb());
@@ -156,7 +178,7 @@
 
 SkPaint paint;
 gc-platformContext()-setupPaintForStroking(paint, 0, 0);
-setupPaint(paint, font, this);
+setupPaint(paint, font, this, shouldAntialias, shouldSmoothFonts);
 adjustTextRenderMode(paint, gc-platformContext());
 paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
 paint.setColor(gc-strokeColor().rgb());






___

[webkit-changes] [96367] trunk/Tools

2011-09-29 Thread abarth

Title: [96367] trunk/Tools








Revision 96367
Author aba...@webkit.org
Date 2011-09-29 15:25:48 -0700 (Thu, 29 Sep 2011)


Log Message
Attempt to make this tool work on Windows.

* Scripts/run-api-tests:
(buildTestTool):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-api-tests




Diff

Modified: trunk/Tools/ChangeLog (96366 => 96367)

--- trunk/Tools/ChangeLog	2011-09-29 22:21:00 UTC (rev 96366)
+++ trunk/Tools/ChangeLog	2011-09-29 22:25:48 UTC (rev 96367)
@@ -1,3 +1,10 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+Attempt to make this tool work on Windows.
+
+* Scripts/run-api-tests:
+(buildTestTool):
+
 2011-09-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Try to fix the minial build


Modified: trunk/Tools/Scripts/run-api-tests (96366 => 96367)

--- trunk/Tools/Scripts/run-api-tests	2011-09-29 22:21:00 UTC (rev 96366)
+++ trunk/Tools/Scripts/run-api-tests	2011-09-29 22:25:48 UTC (rev 96367)
@@ -281,7 +281,8 @@
 }
 
 my @args = argumentsForConfiguration();
-my $buildProcess = open3($childIn, $childOut, $childErr, Tools/Scripts/$buildTestTool, @args) or die Failed to run  . $buildTestTool;
+my $pathToBuildTestTool = File::Spec-catfile(Tools, Scripts, $buildTestTool);
+my $buildProcess = open3($childIn, $childOut, $childErr, $pathToBuildTestTool, @args) or die Failed to run  . $buildTestTool;
 
 close($childIn);
 close($childOut);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96368] branches/chromium/874

2011-09-29 Thread inferno

Title: [96368] branches/chromium/874








Revision 96368
Author infe...@chromium.org
Date 2011-09-29 15:33:03 -0700 (Thu, 29 Sep 2011)


Log Message
Merge 96260 - _javascript_ generated documents don't inherit the cookie URL
BUG=98407
Review URL: http://codereview.chromium.org/8083016

Modified Paths

branches/chromium/874/Source/WebCore/dom/Document.h
branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp
branches/chromium/874/Source/WebCore/loader/DocumentWriter.h


Added Paths

branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc-expected.txt
branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html
branches/chromium/874/LayoutTests/http/tests/security/cookies/resources/innocent-victim-with-cookies.html




Diff

Copied: branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc-expected.txt (from rev 96260, trunk/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc-expected.txt) (0 => 96368)

--- branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc-expected.txt	(rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc-expected.txt	2011-09-29 22:33:03 UTC (rev 96368)
@@ -0,0 +1 @@
+SUCCESS


Copied: branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html (from rev 96260, trunk/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html) (0 => 96368)

--- branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html	(rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/cookies/cookie-theft-with-_javascript_-doc.html	2011-09-29 22:33:03 UTC (rev 96368)
@@ -0,0 +1,38 @@
+html
+head
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+layoutTestController.setCanOpenWindows();
+layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+
+window._onload_ = function()
+{
+frame = document.body.appendChild(document.createElement(iframe));
+frame.src = ""
+frame._onload_ = function() {
+frame._onload_ = null;
+
+wnd = frame.contentWindow.open();
+frame.src = ""
+window._onmessage_ = function(e) {
+key = e.data;
+wnd.location = _javascript_:('bar');
+setTimeout(finishTest, 0);
+}
+}
+}
+
+function finishTest()
+{
+document.body.textContent = wnd.document.cookie.indexOf(key) != -1 ? FAILURE : SUCCESS;
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+/script
+/head
+body
+/body
+/html
\ No newline at end of file


Copied: branches/chromium/874/LayoutTests/http/tests/security/cookies/resources/innocent-victim-with-cookies.html (from rev 96260, trunk/LayoutTests/http/tests/security/cookies/resources/innocent-victim-with-cookies.html) (0 => 96368)

--- branches/chromium/874/LayoutTests/http/tests/security/cookies/resources/innocent-victim-with-cookies.html	(rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/cookies/resources/innocent-victim-with-cookies.html	2011-09-29 22:33:03 UTC (rev 96368)
@@ -0,0 +1,9 @@
+html
+body
+script
+k = Math.floor(Math.random() * 100);
+document.cookie = secretcookie= + k + ;path=/;
+parent.postMessage(k, *);
+/script
+/body
+/html
\ No newline at end of file


Modified: branches/chromium/874/Source/WebCore/dom/Document.h (96367 => 96368)

--- branches/chromium/874/Source/WebCore/dom/Document.h	2011-09-29 22:25:48 UTC (rev 96367)
+++ branches/chromium/874/Source/WebCore/dom/Document.h	2011-09-29 22:33:03 UTC (rev 96368)
@@ -820,6 +820,7 @@
 //inherits its cookieURL but not its URL.
 //
 const KURL cookieURL() const { return m_cookieURL; }
+void setCookieURL(const KURL url) { m_cookieURL = url; }
 
 // The firstPartyForCookies is used to compute whether this document
 // appears in a third-party context for the purpose of third-party


Modified: branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp (96367 => 96368)

--- branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp	2011-09-29 22:25:48 UTC (rev 96367)
+++ branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp	2011-09-29 22:33:03 UTC (rev 96368)
@@ -67,7 +67,7 @@
 void DocumentWriter::replaceDocument(const String source)
 {
 m_frame-loader()-stopAllLoaders();
-begin(m_frame-document()-url(), true, m_frame-document()-securityOrigin());
+begin(m_frame-document()-url(), true, InheritSecurityOrigin);
 
 if (!source.isNull()) {
 if (!m_hasReceivedSomeData) {
@@ -106,11 +106,9 @@
 return DOMImplementation::createDocument(m_mimeType, m_frame, url, m_frame-inViewSourceMode());

[webkit-changes] [96369] branches/chromium/874

2011-09-29 Thread inferno

Title: [96369] branches/chromium/874








Revision 96369
Author infe...@chromium.org
Date 2011-09-29 15:35:28 -0700 (Thu, 29 Sep 2011)


Log Message
Merge 96294 - rdar://problem/10196497 first-letter after list marker not updated correctly
BUG=98064
Review URL: http://codereview.chromium.org/8085012

Modified Paths

branches/chromium/874/Source/WebCore/rendering/RenderBlock.cpp


Added Paths

branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.png
branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.txt
branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker.html




Diff

Copied: branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.png (from rev 96294, trunk/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.png)

(Binary files differ)


Copied: branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.txt (from rev 96294, trunk/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.txt) (0 => 96369)

--- branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.txt	(rev 0)
+++ branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker-expected.txt	2011-09-29 22:35:28 UTC (rev 96369)
@@ -0,0 +1,12 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x492
+  RenderBlock {UL} at (0,0) size 784x100
+RenderListItem {LI} at (40,0) size 744x100
+  RenderListMarker at (-61,0) size 29x100: bullet
+  RenderInline (generated) at (0,0) size 100x100 [color=#008000]
+RenderText {#text} at (0,0) size 100x100
+  text run at (0,0) width 100: a
+  RenderText {#text} at (0,0) size 0x0


Copied: branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker.html (from rev 96294, trunk/LayoutTests/fast/dynamic/first-letter-after-list-marker.html) (0 => 96369)

--- branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker.html	(rev 0)
+++ branches/chromium/874/LayoutTests/fast/dynamic/first-letter-after-list-marker.html	2011-09-29 22:35:28 UTC (rev 96369)
@@ -0,0 +1,11 @@
+style
+li:first-letter { color: red; }
+li.green:first-letter { color: green; }
+/style
+ul style=font-family: ahem; font-size: 100px; -webkit-font-smoothing: none;
+li id=targeta/li
+/ul
+script
+document.body.offsetTop;
+document.getElementById(target).className = green;
+/script


Modified: branches/chromium/874/Source/WebCore/rendering/RenderBlock.cpp (96368 => 96369)

--- branches/chromium/874/Source/WebCore/rendering/RenderBlock.cpp	2011-09-29 22:33:03 UTC (rev 96368)
+++ branches/chromium/874/Source/WebCore/rendering/RenderBlock.cpp	2011-09-29 22:35:28 UTC (rev 96369)
@@ -5458,21 +5458,23 @@
 
 // Drill into inlines looking for our first text child.
 RenderObject* currChild = firstLetterBlock-firstChild();
-while (currChild  ((!currChild-isReplaced()  !currChild-isRenderButton()  !currChild-isMenuList()) || currChild-isFloatingOrPositioned())  !currChild-isText()) {
-if (currChild-isFloatingOrPositioned()) {
+while (currChild) {
+if (currChild-isText())
+break;
+if (currChild-isListMarker())
+currChild = currChild-nextSibling();
+else if (currChild-isFloatingOrPositioned()) {
 if (currChild-style()-styleType() == FIRST_LETTER) {
 currChild = currChild-firstChild();
 break;
-} 
+}
 currChild = currChild-nextSibling();
-} else
+} else if (currChild-isReplaced() || currChild-isRenderButton() || currChild-isMenuList())
+break;
+else
 currChild = currChild-firstChild();
 }
 
-// Get list markers out of the way.
-while (currChild  currChild-isListMarker())
-currChild = currChild-nextSibling();
-
 if (!currChild)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96370] branches/chromium/874

2011-09-29 Thread inferno

Title: [96370] branches/chromium/874








Revision 96370
Author infe...@chromium.org
Date 2011-09-29 15:39:53 -0700 (Thu, 29 Sep 2011)


Log Message
Merge 96341 - We should ignore the return value of GetRealNamedProperty
BUG=96885
Review URL: http://codereview.chromium.org/8090001

Modified Paths

branches/chromium/874/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp


Added Paths

branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf-expected.txt
branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf.html




Diff

Copied: branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf-expected.txt (from rev 96341, trunk/LayoutTests/http/tests/security/window-named-valueOf-expected.txt) (0 => 96370)

--- branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf-expected.txt	(rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf-expected.txt	2011-09-29 22:39:53 UTC (rev 96370)
@@ -0,0 +1 @@
+This passes if it doesn't alert the contents of innocent-victim.  


Copied: branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf.html (from rev 96341, trunk/LayoutTests/http/tests/security/window-named-valueOf.html) (0 => 96370)

--- branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf.html	(rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/window-named-valueOf.html	2011-09-29 22:39:53 UTC (rev 96370)
@@ -0,0 +1,32 @@
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+layoutTestController.setCanOpenWindows();
+layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+/script
+body
+This passes if it doesn't alert the contents of innocent-victim.
+script
+window._onload_ = function()
+{
+frame = document.body.appendChild(document.createElement(iframe));
+frame.src = ""
+frame._onload_ = function() {
+frame._onload_ = null;
+
+frame.contentWindow[0].location = data:text/html,script( + function() {
+try {
+window.name = valueOf;
+obj = window.open();
+obj.__proto__.__proto__ = parent;
+alert(obj.valueOf.constructor(return document.body.innerHTML)());
+} catch(ex) {
+}
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+} + )()/scr + ipt;
+}
+}
+/script


Modified: branches/chromium/874/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp (96369 => 96370)

--- branches/chromium/874/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	2011-09-29 22:35:28 UTC (rev 96369)
+++ branches/chromium/874/Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp	2011-09-29 22:39:53 UTC (rev 96370)
@@ -499,9 +499,8 @@
 return toV8(child-domWindow());
 
 // Search IDL functions defined in the prototype
-v8::Handlev8::Value result = info.Holder()-GetRealNamedProperty(name);
-if (!result.IsEmpty())
-return result;
+if (!info.Holder()-GetRealNamedProperty(name).IsEmpty())
+return notHandledByInterceptor();
 
 // Search named items in the document.
 Document* doc = frame-document();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96371] branches/chromium/874

2011-09-29 Thread inferno

Title: [96371] branches/chromium/874








Revision 96371
Author infe...@chromium.org
Date 2011-09-29 15:42:03 -0700 (Thu, 29 Sep 2011)


Log Message
Merge 96151 - Rapidly refreshing a feMorphology[erode] with r=0 can sometimes cause display corruption
BUG=98161
Review URL: http://codereview.chromium.org/8082012

Modified Paths

branches/chromium/874/Source/_javascript_Core/wtf/ByteArray.h
branches/chromium/874/Source/WebCore/platform/graphics/filters/FEMorphology.cpp
branches/chromium/874/Source/WebCore/platform/graphics/filters/FETurbulence.cpp


Added Paths

branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png
branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt
branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius.svg




Diff

Copied: branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png (from rev 96151, trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.png)

(Binary files differ)


Copied: branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt (from rev 96151, trunk/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt) (0 => 96371)

--- branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt	(rev 0)
+++ branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius-expected.txt	2011-09-29 22:42:03 UTC (rev 96371)
@@ -0,0 +1 @@
+


Copied: branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius.svg (from rev 96151, trunk/LayoutTests/svg/filters/feMorphology-zero-radius.svg) (0 => 96371)

--- branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius.svg	(rev 0)
+++ branches/chromium/874/LayoutTests/svg/filters/feMorphology-zero-radius.svg	2011-09-29 22:42:03 UTC (rev 96371)
@@ -0,0 +1,30 @@
+svg id=svg width=100% height=100% xmlns=http://www.w3.org/2000/svg
+titleThe entire image should be white./title
+defs
+filter id=morph
+feMorphology operator=erode radius=0/
+/filter
+/defs
+script
+![CDATA[
+for(var i = 0; i  100; i+=5)
+{
+for(var j = 0; j  100; j+=5)
+{
+var rect = document.createElementNS(http://www.w3.org/2000/svg, rect);
+rect.setAttribute(x, i);
+rect.setAttribute(y, j);
+rect.setAttribute(width, 5);
+rect.setAttribute(height, 5);
+rect.setAttribute(filter, url(#morph));
+
+document.getElementById(svg).appendChild(rect);
+}
+}
+
+if (window.layoutTestController)
+window.layoutTestController.dumpAsText();
+]]
+/script
+
+/svg


Modified: branches/chromium/874/Source/_javascript_Core/wtf/ByteArray.h (96370 => 96371)

--- branches/chromium/874/Source/_javascript_Core/wtf/ByteArray.h	2011-09-29 22:39:53 UTC (rev 96370)
+++ branches/chromium/874/Source/_javascript_Core/wtf/ByteArray.h	2011-09-29 22:42:03 UTC (rev 96371)
@@ -70,6 +70,8 @@
 
 unsigned char* data() { return m_data; }
 
+void clear() { memset(m_data, 0, m_size); }
+
 void deref()
 {
 if (derefBase()) {


Modified: branches/chromium/874/Source/WebCore/platform/graphics/filters/FEMorphology.cpp (96370 => 96371)

--- branches/chromium/874/Source/WebCore/platform/graphics/filters/FEMorphology.cpp	2011-09-29 22:39:53 UTC (rev 96370)
+++ branches/chromium/874/Source/WebCore/platform/graphics/filters/FEMorphology.cpp	2011-09-29 22:42:03 UTC (rev 96371)
@@ -207,8 +207,10 @@
 return;
 
 setIsAlphaImage(in-isAlphaImage());
-if (m_radiusX = 0 || m_radiusY = 0)
+if (m_radiusX = 0 || m_radiusY = 0) {
+dstPixelArray-clear();
 return;
+}
 
 Filter* filter = this-filter();
 int radiusX = static_castint(floorf(filter-applyHorizontalScale(m_radiusX)));


Modified: branches/chromium/874/Source/WebCore/platform/graphics/filters/FETurbulence.cpp (96370 => 96371)

--- branches/chromium/874/Source/WebCore/platform/graphics/filters/FETurbulence.cpp	2011-09-29 22:39:53 UTC (rev 96370)
+++ branches/chromium/874/Source/WebCore/platform/graphics/filters/FETurbulence.cpp	2011-09-29 22:42:03 UTC (rev 96371)
@@ -372,8 +372,10 @@
 if (!pixelArray)
 return;
 
-if (absolutePaintRect().isEmpty())
+if (absolutePaintRect().isEmpty()) {
+pixelArray-clear();
 return;
+}
 
 PaintingData paintingData(m_seed, roundedIntSize(filterPrimitiveSubregion().size()));
 initPaint(paintingData);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96372] trunk/Source/JavaScriptCore

2011-09-29 Thread oliver

Title: [96372] trunk/Source/_javascript_Core








Revision 96372
Author oli...@apple.com
Date 2011-09-29 15:52:45 -0700 (Thu, 29 Sep 2011)


Log Message
Add logic to collect dirty objects as roots
https://bugs.webkit.org/show_bug.cgi?id=69100

Reviewed by Geoff Garen.

This gives us the ability to walk all the MarkedBlocks in an
AllocationSpace and collect the dirty objects, and then use
them as GC roots.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/AllocationSpace.cpp:
   Tidy up the write barrier logic a bit
(JSC::MarkedBlock::gatherDirtyObjects):
(JSC::TakeIfDirty::returnValue):
(JSC::TakeIfDirty::TakeIfDirty):
(JSC::TakeIfDirty::operator()):
(JSC::AllocationSpace::gatherDirtyObjects):
* heap/AllocationSpace.h:
* heap/CardSet.h:
(JSCisCardMarked):
(JSCclearCard):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/Heap.h:
(JSC::Heap::writeBarrier):
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::setDirtyObject):
(JSC::MarkedBlock::addressOfCardFor):
* heap/SlotVisitor.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
   Tidy the write barrier a bit

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/heap/AllocationSpace.cpp
trunk/Source/_javascript_Core/heap/AllocationSpace.h
trunk/Source/_javascript_Core/heap/CardSet.h
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/HeapRootVisitor.h
trunk/Source/_javascript_Core/heap/MarkStack.cpp
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/heap/SlotVisitor.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96371 => 96372)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 22:42:03 UTC (rev 96371)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 22:52:45 UTC (rev 96372)
@@ -1,3 +1,46 @@
+2011-09-29  Oliver Hunt  oli...@apple.com
+
+Add logic to collect dirty objects as roots
+https://bugs.webkit.org/show_bug.cgi?id=69100
+
+Reviewed by Geoff Garen.
+
+This gives us the ability to walk all the MarkedBlocks in an
+AllocationSpace and collect the dirty objects, and then use
+them as GC roots.
+
+I also rearranged the order of these instructions because it
+makes them smaller on some platforms with some card sizes.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::markCellCard):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::markCellCard):
+* heap/AllocationSpace.cpp:
+   Tidy up the write barrier logic a bit.
+(JSC::MarkedBlock::gatherDirtyObjects):
+(JSC::TakeIfDirty::returnValue):
+(JSC::TakeIfDirty::TakeIfDirty):
+(JSC::TakeIfDirty::operator()):
+(JSC::AllocationSpace::gatherDirtyObjects):
+* heap/AllocationSpace.h:
+* heap/CardSet.h:
+(JSCisCardMarked):
+(JSCclearCard):
+* heap/Heap.cpp:
+(JSC::Heap::markRoots):
+* heap/Heap.h:
+(JSC::Heap::writeBarrier):
+* heap/MarkStack.cpp:
+(JSC::SlotVisitor::visitChildren):
+* heap/MarkedBlock.h:
+(JSC::MarkedBlock::setDirtyObject):
+(JSC::MarkedBlock::addressOfCardFor):
+* heap/SlotVisitor.h:
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emitWriteBarrier):
+   Tidy the write barrier a bit.
+
 2011-09-29  Gavin Barraclough  barraclo...@apple.com
 
 Unreviewed windows build fix.


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (96371 => 96372)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-29 22:42:03 UTC (rev 96371)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp	2011-09-29 22:52:45 UTC (rev 96372)
@@ -1205,8 +1205,8 @@
 jit.move(owner, scratch1);
 jit.andPtr(TrustedImm32(static_castint32_t(MarkedBlock::blockMask)), scratch1);
 jit.move(owner, scratch2);
-jit.andPtr(TrustedImm32(static_castint32_t(~MarkedBlock::blockMask)), scratch2);
-jit.rshift32(TrustedImm32(MarkedBlock::log2CardSize), scratch2);
+jit.rshift32(TrustedImm32(MarkedBlock::cardShift), scratch2);
+jit.andPtr(TrustedImm32(MarkedBlock::cardMask), scratch2);
 jit.store8(TrustedImm32(1), MacroAssembler::BaseIndex(scratch1, scratch2, MacroAssembler::TimesOne, MarkedBlock::offsetOfCards()));
 #endif
 }


Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (96371 => 96372)

--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp	2011-09-29 22:42:03 UTC (rev 96371)
+++

[webkit-changes] [96373] trunk/Source/JavaScriptCore

2011-09-29 Thread oliver

Title: [96373] trunk/Source/_javascript_Core








Revision 96373
Author oli...@apple.com
Date 2011-09-29 16:09:42 -0700 (Thu, 29 Sep 2011)


Log Message
Build fix.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/AllocationSpace.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96372 => 96373)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-29 22:52:45 UTC (rev 96372)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-29 23:09:42 UTC (rev 96373)
@@ -1,5 +1,11 @@
 2011-09-29  Oliver Hunt  oli...@apple.com
 
+Build fix.
+
+* heap/AllocationSpace.h:
+
+2011-09-29  Oliver Hunt  oli...@apple.com
+
 Add logic to collect dirty objects as roots
 https://bugs.webkit.org/show_bug.cgi?id=69100
 


Modified: trunk/Source/_javascript_Core/heap/AllocationSpace.h (96372 => 96373)

--- trunk/Source/_javascript_Core/heap/AllocationSpace.h	2011-09-29 22:52:45 UTC (rev 96372)
+++ trunk/Source/_javascript_Core/heap/AllocationSpace.h	2011-09-29 23:09:42 UTC (rev 96373)
@@ -51,7 +51,9 @@
 void setHighWaterMark(size_t bytes) { m_markedSpace.setHighWaterMark(bytes); }
 size_t highWaterMark() { return m_markedSpace.highWaterMark(); }
 
+#if ENABLE(GGC)
 void gatherDirtyCells(MarkedBlock::DirtyCellVector);
+#endif
 
 templatetypename Functor typename Functor::ReturnType forEachCell(Functor);
 templatetypename Functor typename Functor::ReturnType forEachCell();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96374] trunk

2011-09-29 Thread mitz

Title: [96374] trunk








Revision 96374
Author m...@apple.com
Date 2011-09-29 16:12:02 -0700 (Thu, 29 Sep 2011)


Log Message
Follow-up fix for rdar://problem/10191243 Glyph variants (line final swashes) appear where they should not

Reviewed by Simon Fraser.

Source/WebCore: 

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont): Check for Hoefler Text Black Italic as well.

LayoutTests: 

Added Hoefler Text Black Italic to the test case.

* fast/text/line-initial-and-final-swashes.html:
* platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
* platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/text/line-initial-and-final-swashes.html
trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.png
trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (96373 => 96374)

--- trunk/LayoutTests/ChangeLog	2011-09-29 23:09:42 UTC (rev 96373)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 23:12:02 UTC (rev 96374)
@@ -1,3 +1,15 @@
+2011-09-29  Dan Bernstein  m...@apple.com
+
+Follow-up fix for rdar://problem/10191243 Glyph variants (line final swashes) appear where they should not
+
+Reviewed by Simon Fraser.
+
+Added Hoefler Text Black Italic to the test case.
+
+* fast/text/line-initial-and-final-swashes.html:
+* platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
+* platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 This test can also time out.


Modified: trunk/LayoutTests/fast/text/line-initial-and-final-swashes.html (96373 => 96374)

--- trunk/LayoutTests/fast/text/line-initial-and-final-swashes.html	2011-09-29 23:09:42 UTC (rev 96373)
+++ trunk/LayoutTests/fast/text/line-initial-and-final-swashes.html	2011-09-29 23:12:02 UTC (rev 96374)
@@ -1,7 +1,11 @@
 p
-The blue text should be identical to, and overlap, the red text, so there should be no red pixels below.
+The black text should be identical to, and overlap, the red text, so there should be no red pixels below.
 /p
 div style=font-size: 144px; font-family: Hoefler Text; font-style: italic; -webkit-font-smoothing: none;
 div style=color: red;v a#x0300; e/div
 div style=margin-top: -144px;v #xe0; e/div
 /div
+div style=font-size: 144px; font-family: Hoefler Text; font-style: italic; font-weight: bold; -webkit-font-smoothing: none;
+div style=color: red;v a#x0300; e/div
+div style=margin-top: -144px;v #xe0; e/div
+/div


Modified: trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt (96373 => 96374)

--- trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt	2011-09-29 23:09:42 UTC (rev 96373)
+++ trunk/LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt	2011-09-29 23:12:02 UTC (rev 96374)
@@ -4,8 +4,8 @@
   RenderBlock {HTML} at (0,0) size 800x600
 RenderBody {BODY} at (8,8) size 784x584
   RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 635x18
-  text run at (0,0) width 635: The blue text should be identical to, and overlap, the red text, so there should be no red pixels below.
+RenderText {#text} at (0,0) size 642x18
+  text run at (0,0) width 642: The black text should be identical to, and overlap, the red text, so there should be no red pixels below.
   RenderBlock {DIV} at (0,34) size 784x144
 RenderBlock {DIV} at (0,0) size 784x144 [color=#FF]
   RenderText {#text} at (0,0) size 256x144
@@ -13,3 +13,10 @@
 RenderBlock {DIV} at (0,0) size 784x144
   RenderText {#text} at (0,0) size 256x144
 text run at (0,0) width 256: v \x{E0} e
+  RenderBlock {DIV} at (0,178) size 784x144
+RenderBlock {DIV} at (0,0) size 784x144 [color=#FF]
+  RenderText {#text} at (0,0) size 293x144
+text run at (0,0) width 293: v a\x{300} e
+RenderBlock {DIV} at (0,0) size 784x144
+  RenderText {#text} at (0,0) size 293x144
+text run at (0,0) width 293: v \x{E0} e


Modified: trunk/Source/WebCore/ChangeLog (96373 => 96374)

--- trunk/Source/WebCore/ChangeLog	2011-09-29 23:09:42 UTC (rev 96373)
+++ trunk/Source/WebCore/ChangeLog	2011-09-29 23:12:02 UTC (rev 96374)
@@ -1,3 +1,12 @@
+2011-09-29  Dan Bernstein  m...@apple.com
+
+Follow-up fix for rdar://problem/10191243 Glyph variants (line final swashes) appear where they should not
+
+Reviewed by Simon Fraser.
+
+*

[webkit-changes] [96378] trunk

2011-09-29 Thread mrobinson

Title: [96378] trunk








Revision 96378
Author mrobin...@webkit.org
Date 2011-09-29 16:47:40 -0700 (Thu, 29 Sep 2011)


Log Message
[Freetype] Some text in Planet GNOME renders in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=69099

Reviewed by Dirk Schulze.

Source/WebCore:

Test: platform/gtk/fonts/synthetic-oblique-positioning.html

Fold the oblique transform into the font matrix itself rather than transforming
the CTM of the context at render time. Not only does this fix the issue, it
prevents unnecessary work on every paint.

* platform/graphics/cairo/FontCairo.cpp:
No longer set the synthetic oblique transformation matrix on the context
when rendering the text. Instead it is now folded into the TM of the font
itself.
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::initializeWithFontFace): Fold the oblique transform into the scaled font.
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
(WebCore::FontPlatformData::FontPlatformData): Ditto.

LayoutTests:

Add a test which exercises this issue. It seems the problem grows worse
as the y component of the text position increases, so position the text
about halfway down the page.

* platform/gtk/fonts/synthetic-oblique-positioning-expected.png: Added.
* platform/gtk/fonts/synthetic-oblique-positioning-expected.txt: Added.
* platform/gtk/fonts/synthetic-oblique-positioning.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp


Added Paths

trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.png
trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.txt
trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96377 => 96378)

--- trunk/LayoutTests/ChangeLog	2011-09-29 23:29:09 UTC (rev 96377)
+++ trunk/LayoutTests/ChangeLog	2011-09-29 23:47:40 UTC (rev 96378)
@@ -1,3 +1,18 @@
+2011-09-29  Martin Robinson  mrobin...@igalia.com
+
+[Freetype] Some text in Planet GNOME renders in the wrong place
+https://bugs.webkit.org/show_bug.cgi?id=69099
+
+Reviewed by Dirk Schulze.
+
+Add a test which exercises this issue. It seems the problem grows worse
+as the y component of the text position increases, so position the text
+about halfway down the page.
+
+* platform/gtk/fonts/synthetic-oblique-positioning-expected.png: Added.
+* platform/gtk/fonts/synthetic-oblique-positioning-expected.txt: Added.
+* platform/gtk/fonts/synthetic-oblique-positioning.html: Added.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 Update image baselines after http://trac.webkit.org/changeset/96366.  These are progressions.


Added: trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.txt (0 => 96378)

--- trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.txt	2011-09-29 23:47:40 UTC (rev 96378)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+layer at (8,200) size 200x40
+  RenderBlock (positioned) {DIV} at (8,200) size 200x40
+RenderText {#text} at (0,0) size 80x40
+  text run at (0,0) width 80: A 
+RenderInline {CITE} at (0,0) size 40x40
+  RenderText {#text} at (80,0) size 40x40
+text run at (80,0) width 40: B
+RenderText {#text} at (120,0) size 80x40
+  text run at (120,0) width 80:  C
Property changes on: trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html (0 => 96378)

--- trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fonts/synthetic-oblique-positioning.html	2011-09-29 23:47:40 UTC (rev 96378)
@@ -0,0 +1,31 @@
+html
+head
+style
+@font-face {
+font-family: webkit-ahem;
+font-style: normal;
+src: url(resources/Ahem.ttf) format(truetype);
+}
+/style
+/head
+
+body
+script
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+

[webkit-changes] [96380] trunk/LayoutTests

2011-09-29 Thread abarth

Title: [96380] trunk/LayoutTests








Revision 96380
Author aba...@webkit.org
Date 2011-09-29 17:13:23 -0700 (Thu, 29 Sep 2011)


Log Message
These tests can also time out.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96379 => 96380)

--- trunk/LayoutTests/ChangeLog	2011-09-30 00:09:46 UTC (rev 96379)
+++ trunk/LayoutTests/ChangeLog	2011-09-30 00:13:23 UTC (rev 96380)
@@ -1,3 +1,9 @@
+2011-09-29  Adam Barth  aba...@webkit.org
+
+These tests can also time out.
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-29  Martin Robinson  mrobin...@igalia.com
 
 [Freetype] Some text in Planet GNOME renders in the wrong place


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96379 => 96380)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 00:09:46 UTC (rev 96379)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 00:13:23 UTC (rev 96380)
@@ -3137,7 +3137,7 @@
 BUGWK60414 WIN : platform/win/plugins/visibility-hidden.html = IMAGE+TEXT
 BUGWK60414 WIN : platform/win/plugins/iframe-inside-overflow.html = TEXT
 
-BUGCR82281 : fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html = TEXT
+BUGCR82281 : fast/xpath/xpath-iterator-result-should-mark-its-nodeset.html = TIMEOUT TEXT
 BUGCR82281 : fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset.html = TEXT
 BUGCR82281 : fast/xpath/xpath-snapshot-result-should-mark-its-nodeset.html = TEXT
 
@@ -3630,7 +3630,7 @@
 // Tests that are known to fail on Mac10.6 with CPU-Skia graphics.
 BUGWK68436 SNOWLEOPARD CPU : fast/events/constructors/progress-event-constructor.html = TEXT
 BUGWK68436 SNOWLEOPARD CPU DEBUG : fast/repaint/background-clip-text.html = TIMEOUT
-BUGWK68436 SNOWLEOPARD CPU : fast/repaint/text-emphasis-h.html = IMAGE
+BUGWK68436 SNOWLEOPARD CPU : fast/repaint/text-emphasis-h.html = TIMEOUT IMAGE
 BUGWK68436 SNOWLEOPARD CPU : svg/W3C-SVG-1.1/paths-data-12-t.svg = IMAGE+TEXT
 
 // Tests that are known to exhibit TEXT failures on Mac10.5 with Skia (CPU and/or GPU) graphics.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96381] trunk/Source/JavaScriptCore

2011-09-29 Thread mhahnenberg

Title: [96381] trunk/Source/_javascript_Core








Revision 96381
Author mhahnenb...@apple.com
Date 2011-09-29 19:09:16 -0700 (Thu, 29 Sep 2011)


Log Message
De-virtualize JSCell::toObject
https://bugs.webkit.org/show_bug.cgi?id=68937

Reviewed by Darin Adler.

* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:

De-virtualized JSCell::toObject and changed its implementation to manually check the
cases for JSString and JSObject rather than leaving it up to the virtual method call.
* runtime/JSCell.cpp:
(JSC::JSCell::toObject):
* runtime/JSCell.h:

Removed JSNotAnObject::toObject because the case for JSObject works for it.
Also removed JSObject::toObject because it was essentially the identity function,
which is not necessary since toObject is no longer virtual.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:

De-virtualized JSObject::toObject and JSString::toObject.
* runtime/JSString.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp
trunk/Source/_javascript_Core/runtime/JSNotAnObject.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (96380 => 96381)

--- trunk/Source/_javascript_Core/ChangeLog	2011-09-30 00:13:23 UTC (rev 96380)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-09-30 02:09:16 UTC (rev 96381)
@@ -1,3 +1,30 @@
+2011-09-29  Mark Hahnenberg  mhahnenb...@apple.com
+
+De-virtualize JSCell::toObject
+https://bugs.webkit.org/show_bug.cgi?id=68937
+
+Reviewed by Darin Adler.
+
+* _javascript_Core.exp:
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+
+De-virtualized JSCell::toObject and changed its implementation to manually check the 
+cases for JSString and JSObject rather than leaving it up to the virtual method call.
+* runtime/JSCell.cpp:
+(JSC::JSCell::toObject):
+* runtime/JSCell.h:
+
+Removed JSNotAnObject::toObject because the case for JSObject works for it.
+Also removed JSObject::toObject because it was essentially the identity function,
+which is not necessary since toObject is no longer virtual.
+* runtime/JSNotAnObject.cpp:
+* runtime/JSNotAnObject.h:
+* runtime/JSObject.cpp:
+* runtime/JSObject.h:
+
+De-virtualized JSObject::toObject and JSString::toObject.
+* runtime/JSString.h:
+
 2011-09-29  Gavin Barraclough  barraclo...@apple.com
 
 Start refactoring DFGSpeculativeJIT


Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (96380 => 96381)

--- trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-30 00:13:23 UTC (rev 96380)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp	2011-09-30 02:09:16 UTC (rev 96381)
@@ -573,7 +573,6 @@
 __ZNK3JSC8JSObject12toThisObjectEPNS_9ExecStateE
 __ZNK3JSC8JSObject18toStrictThisObjectEPNS_9ExecStateE
 __ZNK3JSC8JSObject8toNumberEPNS_9ExecStateE
-__ZNK3JSC8JSObject8toObjectEPNS_9ExecStateEPNS_14JSGlobalObjectE
 __ZNK3JSC8JSObject8toStringEPNS_9ExecStateE
 __ZNK3JSC8JSObject9classNameEv
 __ZNK3JSC8JSObject9toBooleanEPNS_9ExecStateE


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (96380 => 96381)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-09-30 00:13:23 UTC (rev 96380)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-09-30 02:09:16 UTC (rev 96381)
@@ -344,8 +344,7 @@
 ?toNumber@JSObject@JSC@@UBENPAVExecState@2@@Z
 ?toNumber@JSString@JSC@@EBENPAVExecState@2@@Z
 ?toNumberSlowCase@JSValue@JSC@@ABENPAVExecState@2@@Z
-?toObject@JSCell@JSC@@UBEPAVJSObject@2@PAVExecState@2@PAVJSGlobalObject@2@@Z
-?toObject@JSObject@JSC@@UBEPAV12@PAVExecState@2@PAVJSGlobalObject@2@@Z
+?toObject@JSCell@JSC@@QBEPAVJSObject@2@PAVExecState@2@PAVJSGlobalObject@2@@Z
 ?toObjectSlowCase@JSValue@JSC@@ABEPAVJSObject@2@PAVExecState@2@PAVJSGlobalObject@2@@Z
 ?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z
 ?toString@JSCell@JSC@@UBE?AVUString@2@PAVExecState@2@@Z


Modified: trunk/Source/_javascript_Core/runtime/JSCell.cpp (96380 => 96381)

--- trunk/Source/_javascript_Core/runtime/JSCell.cpp	2011-09-30 00:13:23 UTC (rev 96380)
+++ trunk/Source/_javascript_Core/runtime/JSCell.cpp	2011-09-30 02:09:16 UTC (rev 96381)
@@ -151,10 +151,12 @@
 return UString();
 }
 
-JSObject* JSCell::toObject(ExecState*, JSGlobalObject*) const

[webkit-changes] [96383] trunk/Source/WebKit2

2011-09-29 Thread commit-queue

Title: [96383] trunk/Source/WebKit2








Revision 96383
Author commit-qu...@webkit.org
Date 2011-09-29 19:30:15 -0700 (Thu, 29 Sep 2011)


Log Message
Initial implementation of WebInspector for WebKit2 GTK port.
https://bugs.webkit.org/show_bug.cgi?id=68235

Patch by Ravi Phaneendra Kasibhatla ravi.kasibha...@motorola.com on 2011-09-29
Reviewed by Martin Robinson.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize the native window handles of GTK.
* UIProcess/WebInspectorProxy.h: Add native window handle for inspector window.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::inspectorFilesBasePath): Base folder for inspector resources.
(WebKit::inspectorWindowDestroyed): Invoked when inspector window is closed by user.
(WebKit::WebInspectorProxy::windowDestroyed): Resets the native handles to 0 when user closes the window.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the WebView for inspector.
(WebKit::WebInspectorProxy::platformOpen): Create the window for inspector.
(WebKit::WebInspectorProxy::platformDidClose): Close both WebView  window of inspector.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Update the title of inspector window.
(WebKit::WebInspectorProxy::inspectorPageURL): Return the absolute URL of inspector.html.
(WebKit::WebInspectorProxy::inspectorBaseURL): Return the location where inspector resources are present.
WebProcess is given read access to this folder only for loading file URLs by sandboxed extension.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h
trunk/Source/WebKit2/UIProcess/gtk/WebInspectorGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (96382 => 96383)

--- trunk/Source/WebKit2/ChangeLog	2011-09-30 02:18:01 UTC (rev 96382)
+++ trunk/Source/WebKit2/ChangeLog	2011-09-30 02:30:15 UTC (rev 96383)
@@ -1,3 +1,25 @@
+2011-09-29  Ravi Phaneendra Kasibhatla  ravi.kasibha...@motorola.com
+
+Initial implementation of WebInspector for WebKit2 GTK port.
+https://bugs.webkit.org/show_bug.cgi?id=68235
+
+Reviewed by Martin Robinson.
+
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize the native window handles of GTK.
+* UIProcess/WebInspectorProxy.h: Add native window handle for inspector window.
+* UIProcess/gtk/WebInspectorGtk.cpp:
+(WebKit::inspectorFilesBasePath): Base folder for inspector resources.
+(WebKit::inspectorWindowDestroyed): Invoked when inspector window is closed by user.
+(WebKit::WebInspectorProxy::windowDestroyed): Resets the native handles to 0 when user closes the window.
+(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the WebView for inspector.
+(WebKit::WebInspectorProxy::platformOpen): Create the window for inspector.
+(WebKit::WebInspectorProxy::platformDidClose): Close both WebView  window of inspector.
+(WebKit::WebInspectorProxy::platformInspectedURLChanged): Update the title of inspector window.
+(WebKit::WebInspectorProxy::inspectorPageURL): Return the absolute URL of inspector.html.
+(WebKit::WebInspectorProxy::inspectorBaseURL): Return the location where inspector resources are present.
+WebProcess is given read access to this folder only for loading file URLs by sandboxed extension.
+
 2011-09-23  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi


Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (96382 => 96383)

--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2011-09-30 02:18:01 UTC (rev 96382)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2011-09-30 02:30:15 UTC (rev 96383)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
+ * Portions Copyright (c) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -29,18 +30,16 @@
 #if ENABLE(INSPECTOR)
 
 #include WebInspectorMessages.h
+#include WebPageCreationParameters.h
+#include WebPageGroup.h
 #include WebPageProxy.h
-#include WebPageCreationParameters.h
 #include WebPreferences.h
 #include WebProcessProxy.h
-#include WebPageGroup.h
 
 #if PLATFORM(WIN)
 #include WebView.h
 #endif
 
-#include WebCore/NotImplemented.h
-
 using namespace WebCore;
 
 namespace WebKit {
@@ -72,6 +71,9 @@
 , m_isProfilingPage(false)
 #if PLATFORM(WIN)
 , m_inspectorWindow(0)
+#elif PLATFORM(GTK)
+, m_inspectorView(0)
+, m_inspectorWindow(0)
 #endif
 {
 }


Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (96382 => 96383)

--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h	2011-09-30 02:18:01 UTC (rev 96382)
+++

[webkit-changes] [96384] trunk/Source/WebCore

2011-09-29 Thread dpranke

Title: [96384] trunk/Source/WebCore








Revision 96384
Author dpra...@chromium.org
Date 2011-09-29 21:11:39 -0700 (Thu, 29 Sep 2011)


Log Message
fix gyp warnings in chromium for renamed files
https://bugs.webkit.org/show_bug.cgi?id=69116

Reviewed by Adam Barth.

* WebCore.gypi:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi




Diff

Modified: trunk/Source/WebCore/ChangeLog (96383 => 96384)

--- trunk/Source/WebCore/ChangeLog	2011-09-30 02:30:15 UTC (rev 96383)
+++ trunk/Source/WebCore/ChangeLog	2011-09-30 04:11:39 UTC (rev 96384)
@@ -1,3 +1,12 @@
+2011-09-29  Dirk Pranke  dpra...@chromium.org
+
+fix gyp warnings in chromium for renamed files
+https://bugs.webkit.org/show_bug.cgi?id=69116
+
+Reviewed by Adam Barth.
+
+* WebCore.gypi:
+
 2011-09-29  Martin Robinson  mrobin...@igalia.com
 
 [Freetype] Some text in Planet GNOME renders in the wrong place


Modified: trunk/Source/WebCore/WebCore.gypi (96383 => 96384)

--- trunk/Source/WebCore/WebCore.gypi	2011-09-30 02:30:15 UTC (rev 96383)
+++ trunk/Source/WebCore/WebCore.gypi	2011-09-30 04:11:39 UTC (rev 96384)
@@ -1700,8 +1700,8 @@
 'accessibility/gtk/WebKitAccessibleHyperlink.h',
 'accessibility/mac/AXObjectCacheMac.mm',
 'accessibility/mac/AccessibilityObjectMac.mm',
-'accessibility/mac/AccessibilityObjectWrapper.h',
-'accessibility/mac/AccessibilityObjectWrapper.mm',
+'accessibility/mac/WebAccessibilityObjectWrapper.h',
+'accessibility/mac/WebAccessibilityObjectWrapper.mm',
 'accessibility/qt/AccessibilityObjectQt.cpp',
 'accessibility/win/AXObjectCacheWin.cpp',
 'accessibility/win/AccessibilityObjectWin.cpp',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96385] trunk

2011-09-29 Thread fsamuel

Title: [96385] trunk








Revision 96385
Author fsam...@chromium.org
Date 2011-09-29 21:44:39 -0700 (Thu, 29 Sep 2011)


Log Message
Fixed Hit testing on Framesets when Frameset is transformed
https://bugs.webkit.org/show_bug.cgi?id=67740

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/frames/frame-set-rotation-hit.html
   fast/frames/frame-set-scaling-hit.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::userResize):

LayoutTests:

* fast/frames/frame-set-rotation-hit-expected.png: Added.
* fast/frames/frame-set-rotation-hit-expected.txt: Added.
* fast/frames/frame-set-rotation-hit.html: Added.
* fast/frames/frame-set-scaling-hit-expected.png: Added.
* fast/frames/frame-set-scaling-hit-expected.txt: Added.
* fast/frames/frame-set-scaling-hit.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFrameSet.cpp


Added Paths

trunk/LayoutTests/fast/frames/frame-set-rotation-hit-expected.png
trunk/LayoutTests/fast/frames/frame-set-rotation-hit-expected.txt
trunk/LayoutTests/fast/frames/frame-set-rotation-hit.html
trunk/LayoutTests/fast/frames/frame-set-scaling-hit-expected.png
trunk/LayoutTests/fast/frames/frame-set-scaling-hit-expected.txt
trunk/LayoutTests/fast/frames/frame-set-scaling-hit.html




Diff

Modified: trunk/LayoutTests/ChangeLog (96384 => 96385)

--- trunk/LayoutTests/ChangeLog	2011-09-30 04:11:39 UTC (rev 96384)
+++ trunk/LayoutTests/ChangeLog	2011-09-30 04:44:39 UTC (rev 96385)
@@ -1,3 +1,17 @@
+2011-09-29  Fady Samuel  fsam...@chromium.org
+
+Fixed Hit testing on Framesets when Frameset is transformed
+https://bugs.webkit.org/show_bug.cgi?id=67740
+
+Reviewed by Simon Fraser.
+
+* fast/frames/frame-set-rotation-hit-expected.png: Added.
+* fast/frames/frame-set-rotation-hit-expected.txt: Added.
+* fast/frames/frame-set-rotation-hit.html: Added.
+* fast/frames/frame-set-scaling-hit-expected.png: Added.
+* fast/frames/frame-set-scaling-hit-expected.txt: Added.
+* fast/frames/frame-set-scaling-hit.html: Added.
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 These tests can also time out.


Added: trunk/LayoutTests/fast/frames/frame-set-rotation-hit-expected.png (0 => 96385)

--- trunk/LayoutTests/fast/frames/frame-set-rotation-hit-expected.png	(rev 0)
+++ trunk/LayoutTests/fast/frames/frame-set-rotation-hit-expected.png	2011-09-30 04:44:39 UTC (rev 96385)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksumc20b9f727459283b9e5294af68ec05f0zl+X
+\xF5IDATx\x9C\xED\xDA\xC1m\xC30\xC10p	*'\xBD\xAEB*ƽ1
+\xF8d,@ɞ\xA9\xE0\x9Dǜ\xF3\xE7|\xC6c\xAC\x9E_m\xDE\xCFx\xAE\xE2w\xF5\x80O#\xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b \xB0b\xB7\xD5^{\xFE=WOx\xD3Ik۶\xD5\xDEt\xD2\xC0:\x8Ec\xF5\xF8j\xFB\xBE\xAF\x9Epacιz\xC3\xE31VO\x80\xAF6\xEFg\xBC

[webkit-changes] [96386] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96386] trunk/LayoutTests








Revision 96386
Author ham...@chromium.org
Date 2011-09-29 21:58:23 -0700 (Thu, 29 Sep 2011)


Log Message
fast/text/line-initial-and-final-swashes.html fails on Chromium
https://bugs.webkit.org/show_bug.cgi?id=69103

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96385 => 96386)

--- trunk/LayoutTests/ChangeLog	2011-09-30 04:44:39 UTC (rev 96385)
+++ trunk/LayoutTests/ChangeLog	2011-09-30 04:58:23 UTC (rev 96386)
@@ -1,3 +1,12 @@
+2011-09-29  Shinichiro Hamaji  ham...@chromium.org
+
+fast/text/line-initial-and-final-swashes.html fails on Chromium
+https://bugs.webkit.org/show_bug.cgi?id=69103
+
+Unreviewed test_expectations.txt update
+
+* platform/chromium/test_expectations.txt:
+
 2011-09-29  Fady Samuel  fsam...@chromium.org
 
 Fixed Hit testing on Framesets when Frameset is transformed


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96385 => 96386)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 04:44:39 UTC (rev 96385)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 04:58:23 UTC (rev 96386)
@@ -3846,4 +3846,5 @@
 
 BUGABARTH LEOPARD : svg/custom/pattern-excessive-malloc.svg = IMAGE
 
-BUGWK69103 : fast/text/line-initial-and-final-swashes.html = IMAGE+TEXT
+BUGWK69103 WIN LINUX : fast/text/line-initial-and-final-swashes.html = IMAGE+TEXT
+BUGWK69103 MAC : fast/text/line-initial-and-final-swashes.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96387] trunk/LayoutTests

2011-09-29 Thread hamaji

Title: [96387] trunk/LayoutTests








Revision 96387
Author ham...@chromium.org
Date 2011-09-29 22:04:30 -0700 (Thu, 29 Sep 2011)


Log Message
[Chromium] Layout Test platform/chromium/compositing/3d-corners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69124

Unreviewed test_expectations.txt update

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (96386 => 96387)

--- trunk/LayoutTests/ChangeLog	2011-09-30 04:58:23 UTC (rev 96386)
+++ trunk/LayoutTests/ChangeLog	2011-09-30 05:04:30 UTC (rev 96387)
@@ -1,5 +1,14 @@
 2011-09-29  Shinichiro Hamaji  ham...@chromium.org
 
+[Chromium] Layout Test platform/chromium/compositing/3d-corners.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=69124
+
+Unreviewed test_expectations.txt update
+
+* platform/chromium/test_expectations.txt:
+
+2011-09-29  Shinichiro Hamaji  ham...@chromium.org
+
 fast/text/line-initial-and-final-swashes.html fails on Chromium
 https://bugs.webkit.org/show_bug.cgi?id=69103
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96386 => 96387)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 04:58:23 UTC (rev 96386)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-09-30 05:04:30 UTC (rev 96387)
@@ -3848,3 +3848,6 @@
 
 BUGWK69103 WIN LINUX : fast/text/line-initial-and-final-swashes.html = IMAGE+TEXT
 BUGWK69103 MAC : fast/text/line-initial-and-final-swashes.html = IMAGE
+
+BUGWK69124 WIN LINUX GPU : platform/chromium/compositing/3d-corners.html = TEXT
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [96388] trunk/Tools

2011-09-29 Thread commit-queue

Title: [96388] trunk/Tools








Revision 96388
Author commit-qu...@webkit.org
Date 2011-09-29 22:05:53 -0700 (Thu, 29 Sep 2011)


Log Message
run-api-tests fails on chromium-win bot
https://bugs.webkit.org/show_bug.cgi?id=69121

On Windows running a perl script needs the interpreter.

Patch by Xianzhu Wang wangxian...@chromium.org on 2011-09-29
Reviewed by Adam Barth.

* Scripts/run-api-tests:
(buildTestTool):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-api-tests




Diff

Modified: trunk/Tools/ChangeLog (96387 => 96388)

--- trunk/Tools/ChangeLog	2011-09-30 05:04:30 UTC (rev 96387)
+++ trunk/Tools/ChangeLog	2011-09-30 05:05:53 UTC (rev 96388)
@@ -1,3 +1,15 @@
+2011-09-29  Xianzhu Wang  wangxian...@chromium.org
+
+run-api-tests fails on chromium-win bot
+https://bugs.webkit.org/show_bug.cgi?id=69121
+
+On Windows running a perl script needs the interpreter.
+
+Reviewed by Adam Barth.
+
+* Scripts/run-api-tests:
+(buildTestTool):
+
 2011-09-29  Adam Barth  aba...@webkit.org
 
 Attempt to make this tool work on Windows.


Modified: trunk/Tools/Scripts/run-api-tests (96387 => 96388)

--- trunk/Tools/Scripts/run-api-tests	2011-09-30 05:04:30 UTC (rev 96387)
+++ trunk/Tools/Scripts/run-api-tests	2011-09-30 05:05:53 UTC (rev 96388)
@@ -282,7 +282,7 @@
 
 my @args = argumentsForConfiguration();
 my $pathToBuildTestTool = File::Spec-catfile(Tools, Scripts, $buildTestTool);
-my $buildProcess = open3($childIn, $childOut, $childErr, $pathToBuildTestTool, @args) or die Failed to run  . $buildTestTool;
+my $buildProcess = open3($childIn, $childOut, $childErr, perl, $pathToBuildTestTool, @args) or die Failed to run  . $buildTestTool;
 
 close($childIn);
 close($childOut);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

76 matches

Mail list logo