[webkit-changes] [96790] trunk/Tools
Title: [96790] trunk/Tools
Revision 96790
Author commit-qu...@webkit.org
Date 2011-10-05 23:34:02 -0700 (Wed, 05 Oct 2011)
Log Message
[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=69498
Patch by James Robinson on 2011-10-05
Reviewed by Adam Barth.
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setThreadedCompositingEnabled):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (96789 => 96790)
--- trunk/Tools/ChangeLog 2011-10-06 06:04:20 UTC (rev 96789)
+++ trunk/Tools/ChangeLog 2011-10-06 06:34:02 UTC (rev 96790)
@@ -1,3 +1,24 @@
+2011-10-05 James Robinson
+
+[chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
+https://bugs.webkit.org/show_bug.cgi?id=69498
+
+Reviewed by Adam Barth.
+
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+(main):
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+(TestShell::resetWebSettings):
+* DumpRenderTree/chromium/TestShell.h:
+(TestShell::setThreadedCompositingEnabled):
+* DumpRenderTree/chromium/WebPreferences.cpp:
+(WebPreferences::reset):
+(WebPreferences::applyTo):
+* DumpRenderTree/chromium/WebPreferences.h:
+* Scripts/webkitpy/layout_tests/port/chromium.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
2011-10-05 Erik Arvidsson
[QT] Fix DRT after r96779
Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (96789 => 96790)
--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp 2011-10-06 06:04:20 UTC (rev 96789)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp 2011-10-06 06:34:02 UTC (rev 96790)
@@ -54,6 +54,7 @@
static const char optionHardwareAcceleratedGL[] = "--enable-hardware-gpu";
static const char optionEnableAcceleratedCompositing[] = "--enable-accelerated-compositing";
+static const char optionEnableThreadedCompositing[] = "--enable-threaded-compositing";
static const char optionForceCompositingMode[] = "--force-compositing-mode";
static const char optionEnableAccelerated2DCanvas[] = "--enable-accelerated-2d-canvas";
static const char optionEnableLegacyAccelerated2DCanvas[] = "--enable-legacy-accelerated-2d-canvas";
@@ -137,6 +138,7 @@
bool allowExternalPages = false;
bool startupDialog = false;
bool acceleratedCompositingEnabled = false;
+bool threadedCompositingEnabled = false;
bool compositeToTexture = false;
bool forceCompositingMode = false;
bool accelerated2DCanvasEnabled = false;
@@ -175,6 +177,8 @@
hardwareAcceleratedGL = true;
else if (argument == optionEnableAcceleratedCompositing)
acceleratedCompositingEnabled = true;
+else if (argument == optionEnableThreadedCompositing)
+threadedCompositingEnabled = true;
else if (argument == optionEnableCompositeToTexture)
compositeToTexture = true;
else if (argument == optionForceCompositingMode)
@@ -224,6 +228,7 @@
TestShell shell(testShellMode);
shell.setAllowExternalPages(allowExternalPages);
shell.setAcceleratedCompositingEnabled(acceleratedCompositingEnabled);
+shell.setThreadedCompositingEnabled(threadedCompositingEnabled);
shell.setCompositeToTexture(compositeToTexture);
shell.setForceCompositingMode(forceCompositingMode);
shell.setAccelerated2dCanvasEnabled(accelerated2DCanvasEnabled);
Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (96789 => 96790)
--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2011-10-06 06:04:20 UTC (rev 96789)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2011-10-06 06:34:02 UTC (rev 96790)
@@ -104,6 +104,7 @@
, m_devTools(0)
, m_allowExternalPages(false)
, m_acceleratedCompositingEnabled(false)
+, m_threadedCompositingEnabled(false)
, m_compositeToTexture(false)
, m_forceCompositingMode(false)
, m_accelerated2dCanvasEnabled(false)
@@ -192,6 +193,7 @@
{
[webkit-changes] [96789] trunk/Tools
Title: [96789] trunk/Tools
Revision 96789
Author a...@chromium.org
Date 2011-10-05 23:04:20 -0700 (Wed, 05 Oct 2011)
Log Message
[QT] Fix DRT after r96779
unreviewed.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::dumpHistoryItem):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (96788 => 96789)
--- trunk/Tools/ChangeLog 2011-10-06 06:00:41 UTC (rev 96788)
+++ trunk/Tools/ChangeLog 2011-10-06 06:04:20 UTC (rev 96789)
@@ -1,5 +1,14 @@
2011-10-05 Erik Arvidsson
+[QT] Fix DRT after r96779
+
+unreviewed.
+
+* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+(WebCore::dumpHistoryItem):
+
+2011-10-05 Erik Arvidsson
+
window.location.href and others needlessly decodes URI-encoded characters
https://bugs.webkit.org/show_bug.cgi?id=30225
Modified: trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (96788 => 96789)
--- trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2011-10-06 06:00:41 UTC (rev 96788)
+++ trunk/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp 2011-10-06 06:04:20 UTC (rev 96789)
@@ -831,7 +831,7 @@
for (int i = start; i < indent; i++)
result.append(' ');
-QString url = ""
+QString url = ""
if (url.contains("file://")) {
static QString layoutTestsString("/LayoutTests/");
static QString fileTestString("(file test):");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96788] trunk/Source/WebCore
Title: [96788] trunk/Source/WebCore Revision 96788 Author hara...@chromium.org Date 2011-10-05 23:00:41 -0700 (Wed, 05 Oct 2011) Log Message Refactor IDL attributes about constructor https://bugs.webkit.org/show_bug.cgi?id=69074 Reviewed by Adam Barth. Currently, IDL attributes about constructor are confusing: - [CustomConstructFunction] means that there is a custom constructor for JSC. - [V8CustomConstructor] means that there is a custom constructor for V8. - [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files. - For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at the same time. - ObjC, CPP and GObject bindings do not support custom constructors. This patch makes the following changes: - Rename [CustomConstructFunction] to [JSCustomConstructor]. - [JSCustomConstructor] means that there is a custom constructor for JSC. - [V8CustomConstructor] means that there is a custom constructor for V8. - [CustomConstructor] means that there is a custom constructor for both JSC and V8. No new tests. No change in behavior. Confirm that build succeeds. * bindings/scripts/CodeGeneratorJS.pm: Removed [CustomConstructFunction] and added [JSCustomConstructor] (GenerateHeader): (GenerateAttributesHashTable): (GenerateImplementation): (GenerateConstructorDefinition): * css/WebKitCSSMatrix.idl: Renamed [CustomConstructFunction] to [JSCustomConstructor]. If both [JSCustomConstructor] and [V8CustomConstructor] are specified, then we replaced them with [CustomConstructor]. * dom/CustomEvent.idl: Ditto. * dom/ErrorEvent.idl: Ditto. * dom/Event.idl: Ditto. * dom/HashChangeEvent.idl: Ditto. * dom/MessageChannel.idl: Ditto. * dom/MessageEvent.idl: Ditto. * dom/PageTransitionEvent.idl: Ditto. * dom/PopStateEvent.idl: Ditto. * dom/ProgressEvent.idl: Ditto. * dom/WebKitAnimationEvent.idl: Ditto. * html/DOMFormData.idl: Ditto. * html/canvas/ArrayBuffer.idl: Ditto. * html/canvas/DataView.idl: Ditto. * html/canvas/Float32Array.idl: Ditto. * html/canvas/Float64Array.idl: Ditto. * html/canvas/Int16Array.idl: Ditto. * html/canvas/Int32Array.idl: Ditto. * html/canvas/Int8Array.idl: Ditto. * html/canvas/Uint16Array.idl: Ditto. * html/canvas/Uint32Array.idl: Ditto. * html/canvas/Uint8Array.idl: Ditto. * p2p/PeerConnection.idl: Ditto. * page/EventSource.idl: Ditto. * page/WebKitPoint.idl: Ditto. * webaudio/AudioContext.idl: Ditto. * websockets/CloseEvent.idl: Ditto. * websockets/WebSocket.idl: Ditto. * workers/SharedWorker.idl: Ditto. * workers/Worker.idl: Ditto. * xml/XMLHttpRequest.idl: Ditto. * xml/XSLTProcessor.idl: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/css/WebKitCSSMatrix.idl trunk/Source/WebCore/dom/CustomEvent.idl trunk/Source/WebCore/dom/ErrorEvent.idl trunk/Source/WebCore/dom/Event.idl trunk/Source/WebCore/dom/HashChangeEvent.idl trunk/Source/WebCore/dom/MessageChannel.idl trunk/Source/WebCore/dom/MessageEvent.idl trunk/Source/WebCore/dom/PageTransitionEvent.idl trunk/Source/WebCore/dom/PopStateEvent.idl trunk/Source/WebCore/dom/ProgressEvent.idl trunk/Source/WebCore/dom/WebKitAnimationEvent.idl trunk/Source/WebCore/html/DOMFormData.idl trunk/Source/WebCore/html/canvas/ArrayBuffer.idl trunk/Source/WebCore/html/canvas/DataView.idl trunk/Source/WebCore/html/canvas/Float32Array.idl trunk/Source/WebCore/html/canvas/Float64Array.idl trunk/Source/WebCore/html/canvas/Int16Array.idl trunk/Source/WebCore/html/canvas/Int32Array.idl trunk/Source/WebCore/html/canvas/Int8Array.idl trunk/Source/WebCore/html/canvas/Uint16Array.idl trunk/Source/WebCore/html/canvas/Uint32Array.idl trunk/Source/WebCore/html/canvas/Uint8Array.idl trunk/Source/WebCore/p2p/PeerConnection.idl trunk/Source/WebCore/page/EventSource.idl trunk/Source/WebCore/page/WebKitPoint.idl trunk/Source/WebCore/webaudio/AudioContext.idl trunk/Source/WebCore/websockets/CloseEvent.idl trunk/Source/WebCore/websockets/WebSocket.idl trunk/Source/WebCore/workers/SharedWorker.idl trunk/Source/WebCore/workers/Worker.idl trunk/Source/WebCore/xml/XMLHttpRequest.idl trunk/Source/WebCore/xml/XSLTProcessor.idl Diff Modified: trunk/Source/WebCore/ChangeLog (96787 => 96788) --- trunk/Source/WebCore/ChangeLog 2011-10-06 05:37:43 UTC (rev 96787) +++ trunk/Source/WebCore/ChangeLog 2011-10-06 06:00:41 UTC (rev 96788) @@ -1,3 +1,65 @@ +2011-10-05 Kentaro Hara + +Refactor IDL attributes about constructor +https://bugs.webkit.org/show_bug.cgi?id=69074 + +Reviewed by Adam Barth. + +Currently, IDL attributes about constructor are confusing: + +- [CustomConstructFunction] means that there is a custom constructor for JSC. +- [V8CustomConstructor] means that there is a custom constructor for V8. +- [CustomConstructor] exists in CodeGenerator*.pm but is not used in any IDL files. +- For almost all IDL files, [CustomConstructFunction] and [V8CustomConstructor] are used at t
[webkit-changes] [96787] trunk/LayoutTests
Title: [96787] trunk/LayoutTests Revision 96787 Author bfulg...@webkit.org Date 2011-10-05 22:37:43 -0700 (Wed, 05 Oct 2011) Log Message [WinCairo] Unreviewed build fix. * platform/wincairo/Skipped: Skip css3 folder (for now). Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96786 => 96787) --- trunk/LayoutTests/ChangeLog 2011-10-06 04:18:03 UTC (rev 96786) +++ trunk/LayoutTests/ChangeLog 2011-10-06 05:37:43 UTC (rev 96787) @@ -1,3 +1,9 @@ +2011-10-05 Brent Fulgham + +[WinCairo] Unreviewed build fix. + +* platform/wincairo/Skipped: Skip css3 folder (for now). + 2011-10-05 Yuta Kitamura WebSocket: Add extensions attribute Modified: trunk/LayoutTests/platform/wincairo/Skipped (96786 => 96787) --- trunk/LayoutTests/platform/wincairo/Skipped 2011-10-06 04:18:03 UTC (rev 96786) +++ trunk/LayoutTests/platform/wincairo/Skipped 2011-10-06 05:37:43 UTC (rev 96787) @@ -90,15 +90,7 @@ css2.1 -css3/bdi-element.html -css3/css3-modsel-33.html -css3/css3-modsel-35.html -css3/css3-modsel-36.html -css3/css3-modsel-37.html -css3/unicode-bidi-isolate-aharon.html -css3/unicode-bidi-isolate-basic.html -css3/zoom-coords.xhtml -css3/filters/filter-property.html +css3 dom/xhtml/level3/core/documentgetinputencoding03.xhtml dom/xhtml/level3/core/entitygetinputencoding02.xhtml ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96786] trunk/Source
Title: [96786] trunk/Source Revision 96786 Author aes...@apple.com Date 2011-10-05 21:18:03 -0700 (Wed, 05 Oct 2011) Log Message Source/WebCore: Add the option to suppress rendering until the document's load event fires. https://bugs.webkit.org/show_bug.cgi?id=69298 Reviewed by Simon Fraser. Add a WebCore setting that suppresses painting and compositing layer updates until the document's load event fires. This masks the effects of incremental rendering (for clients that opt in) by ensuring that all sub-resources have loaded and a full layout has taken place before painting the document for the first time. No tests currently possible. Testing this would require the ability for DRT to dump state while resources are loading, which it doesn't currently do. * dom/Document.cpp: (WebCore::Document::implicitClose): If rendering was previously suppressed, force a repaint and compositing layer update. (WebCore::Document::visualUpdatesAllowed): Add a helper method to determine if the document is in a state where rendering is allowed. * dom/Document.h: * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: (WebCore::Settings::setSuppressIncrementalRendering): (WebCore::Settings::suppressIncrementalRendering): * rendering/RenderLayer.cpp: (WebCore::shouldSuppressPaintingLayer): Encapsulate the FOUC and painting suppression checks into a single helper function for readability's sake. (WebCore::RenderLayer::paintLayer): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers): If we should suppress compositing layer updates and the load event has yet to fire, return early. Source/WebKit/mac: Add an option to suppress rendering until the document's load event fires. https://bugs.webkit.org/show_bug.cgi?id=69298 Reviewed by Simon Fraser. Add a new private WebPreference. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences setSuppressRenderingWhileInitiallyLoading:]): (-[WebPreferences suppressRenderingWhileInitiallyLoading]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChanged:]): Source/WebKit2: Add an option to suppress rendering until the document's load event fires. https://bugs.webkit.org/show_bug.cgi?id=69298 Reviewed by Simon Fraser. Add a new WKPreference. * Shared/WebPreferencesStore.h: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetSuppressRenderingWhileInitiallyLoading): (WKPreferencesGetSuppressRenderingWhileInitiallyLoading): * UIProcess/API/C/WKPreferences.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/page/Settings.cpp trunk/Source/WebCore/page/Settings.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h trunk/Source/WebKit/mac/WebView/WebPreferences.mm trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPreferencesStore.h trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (96785 => 96786) --- trunk/Source/WebCore/ChangeLog 2011-10-06 03:37:38 UTC (rev 96785) +++ trunk/Source/WebCore/ChangeLog 2011-10-06 04:18:03 UTC (rev 96786) @@ -1,3 +1,41 @@ +2011-10-03 Andy Estes + +Add the option to suppress rendering until the document's load event fires. +https://bugs.webkit.org/show_bug.cgi?id=69298 + +Reviewed by Simon Fraser. + +Add a WebCore setting that suppresses painting and compositing layer +updates until the document's load event fires. This masks the effects +of incremental rendering (for clients that opt in) by ensuring that all +sub-resources have loaded and a full layout has taken place before +painting the document for the first time. + +No tests currently possible. Testing this would require the ability for +DRT to dump state while resources are loading, which it doesn't +currently do. + +* dom/Document.cpp: +(WebCore::Document::implicitClose): If rendering was previously +suppressed, force a repaint and compositing layer update. +(WebCore::Document::visualUpdatesAllowed): Add a helper method to +determine if the document is in a state where rendering is allowed. +* dom/Document.h: +* page/Settings.cpp: +(WebCore::Settings::Settings): +* page/Settings.h: +(WebCore::Settings::setSuppressIncrementalRendering): +(WebCore::Settings::suppressIncrementalRendering): +
[webkit-changes] [96785] trunk
Title: [96785] trunk
Revision 96785
Author yu...@chromium.org
Date 2011-10-05 20:37:38 -0700 (Wed, 05 Oct 2011)
Log Message
WebSocket: Add extensions attribute
https://bugs.webkit.org/show_bug.cgi?id=69408
Reviewed by Kent Tamura.
Source/WebCore:
Add WebSocket's "extensions" attribute as specified in the WebSocket API
.
WebSocket protocol extension is not implemented at all, thus this attribute
always returns an empty string.
Test: http/tests/websocket/tests/hybi/extensions.html
http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)
* websockets/WebSocket.cpp:
(WebCore::WebSocket::extensions):
If the hixie-76 protocol is chosen, we need to return "undefined" in order to
keep behavior of the ports which have not used the newer hybi protocol yet.
* websockets/WebSocket.h:
* websockets/WebSocket.idl:
LayoutTests:
* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
* http/tests/websocket/tests/hixie76/undefined-attributes.html:
Added "extensions" attribute to the list because it shouldn't be defined
when hixie-76 protocol is used.
* http/tests/websocket/tests/hybi/extensions-expected.txt: Added.
* http/tests/websocket/tests/hybi/extensions.html:
Added. Test whether .extensions attribute always returns an empty string.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/websockets/WebSocket.cpp
trunk/Source/WebCore/websockets/WebSocket.h
trunk/Source/WebCore/websockets/WebSocket.idl
Added Paths
trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt
trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (96784 => 96785)
--- trunk/LayoutTests/ChangeLog 2011-10-06 03:04:49 UTC (rev 96784)
+++ trunk/LayoutTests/ChangeLog 2011-10-06 03:37:38 UTC (rev 96785)
@@ -1,3 +1,18 @@
+2011-10-05 Yuta Kitamura
+
+WebSocket: Add extensions attribute
+https://bugs.webkit.org/show_bug.cgi?id=69408
+
+Reviewed by Kent Tamura.
+
+* http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt:
+* http/tests/websocket/tests/hixie76/undefined-attributes.html:
+Added "extensions" attribute to the list because it shouldn't be defined
+when hixie-76 protocol is used.
+* http/tests/websocket/tests/hybi/extensions-expected.txt: Added.
+* http/tests/websocket/tests/hybi/extensions.html:
+Added. Test whether .extensions attribute always returns an empty string.
+
2011-10-05 James Simonsen
[Chromium] Update test expectations for Web Audio on Windows.
Modified: trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt (96784 => 96785)
--- trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt 2011-10-06 03:04:49 UTC (rev 96784)
+++ trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt 2011-10-06 03:37:38 UTC (rev 96785)
@@ -3,6 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS ws.binaryType is undefined.
+PASS ws.extensions is undefined.
PASS ws.protocol is undefined.
PASS successfullyParsed is true
Modified: trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes.html (96784 => 96785)
--- trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes.html 2011-10-06 03:04:49 UTC (rev 96784)
+++ trunk/LayoutTests/http/tests/websocket/tests/hixie76/undefined-attributes.html 2011-10-06 03:37:38 UTC (rev 96785)
@@ -13,6 +13,7 @@
var ws = new WebSocket("ws://127.0.0.1:8880/websocket/tests/hixie76/simple");
shouldBeUndefined("ws.binaryType");
+shouldBeUndefined("ws.extensions");
shouldBeUndefined("ws.protocol");
var successfullyParsed = true;
Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt (0 => 96785)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions-expected.txt 2011-10-06 03:37:38 UTC (rev 96785)
@@ -0,0 +1,10 @@
+Test WebSocket.extensions attribute.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS ws.extensions is ""
+PASS ws.extensions is ""
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions.html (0 => 96785)
--- trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions.html (rev 0)
+++ trunk/LayoutTests/http/tests/websocket/tests/hybi/extensions.html 2011-10-06 03:37:38 UTC (rev 96785)
@@ -0,0 +1,27 @@
+
+
+
+
+
+
+
+
+description("Test WebSocket.extensions attribute.");
+
+if (window.layoutTestController)
[webkit-changes] [96784] trunk/Source/WebKit2
Title: [96784] trunk/Source/WebKit2
Revision 96784
Author simon.fra...@apple.com
Date 2011-10-05 20:04:49 -0700 (Wed, 05 Oct 2011)
Log Message
r96770 broke binary compatibility with Safari
https://bugs.webkit.org/show_bug.cgi?id=69496
Reviewed by Dan Bernstein.
Fix binary compatibility issue by declaring the deprecated methods inside a extern "C" block.
* UIProcess/API/C/WKContext.cpp:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (96783 => 96784)
--- trunk/Source/WebKit2/ChangeLog 2011-10-06 02:38:35 UTC (rev 96783)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-06 03:04:49 UTC (rev 96784)
@@ -1,3 +1,14 @@
+2011-10-05 Simon Fraser
+
+r96770 broke binary compatibility with Safari
+https://bugs.webkit.org/show_bug.cgi?id=69496
+
+Reviewed by Dan Bernstein.
+
+Fix binary compatibility issue by declaring the deprecated methods inside a extern "C" block.
+
+* UIProcess/API/C/WKContext.cpp:
+
2011-10-05 Jer Noble
Enable WEB_AUDIO by default in the WebKit/mac port.
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (96783 => 96784)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-10-06 02:38:35 UTC (rev 96783)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2011-10-06 03:04:49 UTC (rev 96784)
@@ -36,11 +36,13 @@
using namespace WebKit;
+extern "C" {
// For binary compatibility with Safari 5.1. Should be removed eventually.
WK_EXPORT void _WKContextSetAdditionalPluginsDirectory(WKContextRef context, WKStringRef pluginsDirectory);
WK_EXPORT void _WKContextRegisterURLSchemeAsEmptyDocument(WKContextRef context, WKStringRef urlScheme);
WK_EXPORT void _WKContextSetAlwaysUsesComplexTextCodePath(WKContextRef context, bool alwaysUseComplexTextCodePath);
WK_EXPORT void _WKContextSetHTTPPipeliningEnabled(WKContextRef context, bool enabled);
+}
WKTypeID WKContextGetTypeID()
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96783] trunk/Source/JavaScriptCore
Title: [96783] trunk/Source/_javascript_Core Revision 96783 Author rn...@webkit.org Date 2011-10-05 19:38:35 -0700 (Wed, 05 Oct 2011) Log Message Windows build fix attempt after r96760. * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (96782 => 96783) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-06 02:27:33 UTC (rev 96782) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-06 02:38:35 UTC (rev 96783) @@ -1,3 +1,9 @@ +2011-10-05 Ryosuke Niwa + +Windows build fix attempt after r96760. + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + 2011-10-05 Chris Rogers Define a log2f() function for Windows in wtf/MathExtras.h Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (96782 => 96783) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-06 02:27:33 UTC (rev 96782) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-06 02:38:35 UTC (rev 96783) @@ -54,6 +54,7 @@ ?addBytes@MD5@WTF@@QAEXPBEI@Z ?addBytes@SHA1@WTF@@QAEXPBEI@Z ?addCurrentThread@MachineThreads@JSC@@QAEXXZ +?addFinalizer@Heap@JSC@@QAEXPAVJSCell@2@P6AX0@Z@Z ?addPropertyTransition@Structure@JSC@@SAPAV12@AAVJSGlobalData@2@PAV12@ABVIdentifier@2@IPAVJSCell@2@AAI@Z ?addPropertyTransitionToExistingStructure@Structure@JSC@@SAPAV12@PAV12@ABVIdentifier@2@IPAVJSCell@2@AAI@Z ?addPropertyWithoutTransition@Structure@JSC@@QAEIAAVJSGlobalData@2@ABVIdentifier@2@IPAVJSCell@2@@Z @@ -87,6 +88,7 @@ ?className@JSObject@JSC@@UBE?AVUString@2@XZ ?clear@SourceProviderCache@JSC@@QAEXXZ ?clearBuiltinStructures@JSGlobalData@JSC@@QAEXXZ +?clearRareData@JSGlobalObject@JSC@@CAXPAVJSCell@2@@Z ?collate@Collator@WTF@@QBE?AW4Result@12@PB_WI0I@Z ?collectAllGarbage@Heap@JSC@@QAEXXZ ?computeHash@SHA1@WTF@@QAEXAAV?$Vector@E$0BE@@2@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96782] trunk/Source/WebCore
Title: [96782] trunk/Source/WebCore
Revision 96782
Author domin...@chromium.org
Date 2011-10-05 19:27:33 -0700 (Wed, 05 Oct 2011)
Log Message
IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
https://bugs.webkit.org/show_bug.cgi?id=69406
Reviewed by Hajime Morita.
No change in behavior => No new tests.
* dom/Node.cpp:
(WebCore::Node::setShadowHost): Don't twiddle the flag.
* dom/Node.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
* dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
* dom/TreeScope.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/dom/ShadowRoot.cpp
trunk/Source/WebCore/dom/TreeScope.cpp
trunk/Source/WebCore/dom/TreeScope.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96781 => 96782)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 02:27:33 UTC (rev 96782)
@@ -1,3 +1,21 @@
+2011-10-05 Dominic Cooney
+
+IsShadowRootFlag should not depend on whether a ShadowRoot is attached to a host.
+https://bugs.webkit.org/show_bug.cgi?id=69406
+
+Reviewed by Hajime Morita.
+
+No change in behavior => No new tests.
+
+* dom/Node.cpp:
+(WebCore::Node::setShadowHost): Don't twiddle the flag.
+* dom/Node.h:
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::ShadowRoot): Set the IsShadowRootFlag on creation.
+* dom/TreeScope.cpp:
+(WebCore::TreeScope::TreeScope): Let ShadowRoot set creation flags.
+* dom/TreeScope.h:
+
2011-10-05 Chris Rogers
Define a log2f() function for Windows in wtf/MathExtras.h
Modified: trunk/Source/WebCore/dom/Node.cpp (96781 => 96782)
--- trunk/Source/WebCore/dom/Node.cpp 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/dom/Node.cpp 2011-10-06 02:27:33 UTC (rev 96782)
@@ -568,12 +568,7 @@
void Node::setShadowHost(Element* host)
{
-ASSERT(!parentNode() && !isSVGShadowRoot());
-if (host)
-setFlag(IsShadowRootFlag);
-else
-clearFlag(IsShadowRootFlag);
-
+ASSERT(!parentNode() && isShadowRoot());
setParent(host);
}
Modified: trunk/Source/WebCore/dom/Node.h (96781 => 96782)
--- trunk/Source/WebCore/dom/Node.h 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/dom/Node.h 2011-10-06 02:27:33 UTC (rev 96782)
@@ -640,9 +640,10 @@
CreateComment = DefaultNodeFlags | IsCommentFlag,
CreateContainer = DefaultNodeFlags | IsContainerFlag,
CreateElement = CreateContainer | IsElementFlag,
+CreateShadowRoot = CreateContainer | IsShadowRootFlag,
CreateStyledElement = CreateElement | IsStyledElementFlag,
CreateHTMLElement = CreateStyledElement | IsHTMLFlag,
-CreateSVGElement = CreateStyledElement | IsSVGFlag,
+CreateSVGElement = CreateStyledElement | IsSVGFlag,
};
Node(Document*, ConstructionType);
Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (96781 => 96782)
--- trunk/Source/WebCore/dom/ShadowRoot.cpp 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp 2011-10-06 02:27:33 UTC (rev 96782)
@@ -37,7 +37,7 @@
namespace WebCore {
ShadowRoot::ShadowRoot(Document* document)
-: TreeScope(document)
+: TreeScope(document, CreateShadowRoot)
, m_applyAuthorSheets(false)
{
ASSERT(document);
Modified: trunk/Source/WebCore/dom/TreeScope.cpp (96781 => 96782)
--- trunk/Source/WebCore/dom/TreeScope.cpp 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/dom/TreeScope.cpp 2011-10-06 02:27:33 UTC (rev 96782)
@@ -36,8 +36,8 @@
using namespace HTMLNames;
-TreeScope::TreeScope(Document* document)
-: ContainerNode(document)
+TreeScope::TreeScope(Document* document, ConstructionType constructionType)
+: ContainerNode(document, constructionType)
, m_parentTreeScope(0)
, m_numNodeListCaches(0)
{
Modified: trunk/Source/WebCore/dom/TreeScope.h (96781 => 96782)
--- trunk/Source/WebCore/dom/TreeScope.h 2011-10-06 02:15:38 UTC (rev 96781)
+++ trunk/Source/WebCore/dom/TreeScope.h 2011-10-06 02:27:33 UTC (rev 96782)
@@ -65,7 +65,7 @@
virtual bool applyAuthorSheets() const;
protected:
-TreeScope(Document*);
+TreeScope(Document*, ConstructionType = CreateContainer);
virtual ~TreeScope();
void destroyTreeScopeData();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96781] trunk/LayoutTests
Title: [96781] trunk/LayoutTests Revision 96781 Author simon...@chromium.org Date 2011-10-05 19:15:38 -0700 (Wed, 05 Oct 2011) Log Message [Chromium] Update test expectations for Web Audio on Windows. Unreviewed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (96780 => 96781) --- trunk/LayoutTests/ChangeLog 2011-10-06 02:04:19 UTC (rev 96780) +++ trunk/LayoutTests/ChangeLog 2011-10-06 02:15:38 UTC (rev 96781) @@ -1,3 +1,11 @@ +2011-10-05 James Simonsen + +[Chromium] Update test expectations for Web Audio on Windows. + +Unreviewed. + +* platform/chromium/test_expectations.txt: + 2011-10-05 Erik Arvidsson window.location.href and others needlessly decodes URI-encoded characters Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96780 => 96781) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-06 02:04:19 UTC (rev 96780) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-06 02:15:38 UTC (rev 96781) @@ -3844,3 +3844,6 @@ // Broken with Skia roll: 2394 to 2412 BUGWK69465 LINUX : fast/forms/select-background-none.html = IMAGE + +// Broken in r96745. +BUGWK69494 WIN : webaudio/audiobuffersource-playbackrate.html = AUDIO ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96780] trunk/Source
Title: [96780] trunk/Source
Revision 96780
Author crog...@google.com
Date 2011-10-05 19:04:19 -0700 (Wed, 05 Oct 2011)
Log Message
Define a log2f() function for Windows in wtf/MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=69491
Reviewed by Darin Adler.
Source/_javascript_Core:
* wtf/MathExtras.h:
(log2f):
Source/WebCore:
No new tests. This change is tested in existing layout tests.
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/MathExtras.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96779 => 96780)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-06 01:40:05 UTC (rev 96779)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-06 02:04:19 UTC (rev 96780)
@@ -1,3 +1,13 @@
+2011-10-05 Chris Rogers
+
+Define a log2f() function for Windows in wtf/MathExtras.h
+https://bugs.webkit.org/show_bug.cgi?id=69491
+
+Reviewed by Darin Adler.
+
+* wtf/MathExtras.h:
+(log2f):
+
2011-10-05 Jer Noble
Enable WEB_AUDIO by default in the WebKit/mac port.
Modified: trunk/Source/_javascript_Core/wtf/MathExtras.h (96779 => 96780)
--- trunk/Source/_javascript_Core/wtf/MathExtras.h 2011-10-06 01:40:05 UTC (rev 96779)
+++ trunk/Source/_javascript_Core/wtf/MathExtras.h 2011-10-06 02:04:19 UTC (rev 96780)
@@ -149,13 +149,19 @@
inline double copysign(double x, double y) { return _copysign(x, y); }
inline int isfinite(double x) { return _finite(x); }
-// MSVC's math.h does not currently supply log2.
+// MSVC's math.h does not currently supply log2 or log2f.
inline double log2(double num)
{
// This constant is roughly M_LN2, which is not provided by default on Windows.
return log(num) / 0.693147180559945309417232121458176568;
}
+inline float log2f(float num)
+{
+// This constant is roughly M_LN2, which is not provided by default on Windows.
+return logf(num) / 0.693147180559945309417232121458176568f;
+}
+
// Work around a bug in Win, where atan2(+-infinity, +-infinity) yields NaN instead of specific values.
inline double wtf_atan2(double x, double y)
{
Modified: trunk/Source/WebCore/ChangeLog (96779 => 96780)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 01:40:05 UTC (rev 96779)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 02:04:19 UTC (rev 96780)
@@ -1,3 +1,15 @@
+2011-10-05 Chris Rogers
+
+Define a log2f() function for Windows in wtf/MathExtras.h
+https://bugs.webkit.org/show_bug.cgi?id=69491
+
+Reviewed by Darin Adler.
+
+No new tests. This change is tested in existing layout tests.
+
+* webaudio/AudioParamTimeline.cpp:
+(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
+
2011-10-05 Erik Arvidsson
window.location.href and others needlessly decodes URI-encoded characters
Modified: trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp (96779 => 96780)
--- trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp 2011-10-06 01:40:05 UTC (rev 96779)
+++ trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp 2011-10-06 02:04:19 UTC (rev 96780)
@@ -246,9 +246,8 @@
values[writeIndex] = value;
} else {
// Interpolate in log space.
-// FIXME: we should just use log2f(), but Windows doesn't have this function.
-value1 = narrowPrecisionToFloat(log2(value1));
-value2 = narrowPrecisionToFloat(log2(value2));
+value1 = log2f(value1);
+value2 = log2f(value2);
// FIXME: optimize to not use pow() in inner loop, this is just a simple exponential ramp.
for (; writeIndex < fillToFrame; ++writeIndex) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96778] trunk/Tools
Title: [96778] trunk/Tools
Revision 96778
Author da...@apple.com
Date 2011-10-05 18:14:15 -0700 (Wed, 05 Oct 2011)
Log Message
Fix build.
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
(TestWebKitAPI::TEST): Remove underscore prefix from call to
WKContextRegisterURLSchemeAsEmptyDocument.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp
Diff
Modified: trunk/Tools/ChangeLog (96777 => 96778)
--- trunk/Tools/ChangeLog 2011-10-06 00:56:43 UTC (rev 96777)
+++ trunk/Tools/ChangeLog 2011-10-06 01:14:15 UTC (rev 96778)
@@ -1,3 +1,11 @@
+2011-10-05 Darin Adler
+
+Fix build.
+
+* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
+(TestWebKitAPI::TEST): Remove underscore prefix from call to
+WKContextRegisterURLSchemeAsEmptyDocument.
+
2011-10-05 Brent Fulgham
[WinCairo] Switch to building Release target, and activate tests.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp (96777 => 96778)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp 2011-10-06 00:56:43 UTC (rev 96777)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp 2011-10-06 01:14:15 UTC (rev 96778)
@@ -57,7 +57,7 @@
WKRetainPtr context = adoptWK(Util::createContextForInjectedBundleTest("CanHandleRequestTest"));
setInjectedBundleClient(context.get());
-_WKContextRegisterURLSchemeAsEmptyDocument(context.get(), Util::toWK("emptyscheme").get());
+WKContextRegisterURLSchemeAsEmptyDocument(context.get(), Util::toWK("emptyscheme").get());
PlatformWebView webView(context.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96777] trunk/Source/WebCore
Title: [96777] trunk/Source/WebCore
Revision 96777
Author da...@apple.com
Date 2011-10-05 17:56:43 -0700 (Wed, 05 Oct 2011)
Log Message
[Mac] Use four more named cursors if present
https://bugs.webkit.org/show_bug.cgi?id=69488
Reviewed by Dan Bernstein.
* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
"ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
falls back if the cursors are not present.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/CursorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (96776 => 96777)
--- trunk/Source/WebCore/ChangeLog 2011-10-06 00:51:56 UTC (rev 96776)
+++ trunk/Source/WebCore/ChangeLog 2011-10-06 00:56:43 UTC (rev 96777)
@@ -1,3 +1,15 @@
+2011-10-05 Darin Adler
+
+[Mac] Use four more named cursors if present
+https://bugs.webkit.org/show_bug.cgi?id=69488
+
+Reviewed by Dan Bernstein.
+
+* platform/mac/CursorMac.mm:
+(WebCore::Cursor::ensurePlatformCursor): Use the names "Help", "Cell",
+"ZoomIn", and "ZoomOut" to get those cursors. Structure the code so it
+falls back if the cursors are not present.
+
2011-10-05 Tony Chang
force margin:auto to 0 in flex items
Modified: trunk/Source/WebCore/platform/mac/CursorMac.mm (96776 => 96777)
--- trunk/Source/WebCore/platform/mac/CursorMac.mm 2011-10-06 00:51:56 UTC (rev 96776)
+++ trunk/Source/WebCore/platform/mac/CursorMac.mm 2011-10-06 00:56:43 UTC (rev 96777)
@@ -79,21 +79,25 @@
case Cursor::Pointer:
m_platformCursor = [NSCursor arrowCursor];
break;
+
case Cursor::Cross:
m_platformCursor = [NSCursor crosshairCursor];
break;
+
case Cursor::Hand:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
m_platformCursor = [NSCursor pointingHandCursor];
#else
// The pointingHandCursor from NSCursor does not have a shadow on
-// older versions of Mac OS X, so use our own custom cursor.
+// older versions of OS X, so use our own custom cursor.
m_platformCursor = createNamedCursor("linkCursor", 6, 1);
#endif
break;
+
case Cursor::IBeam:
m_platformCursor = [NSCursor IBeamCursor];
break;
+
case Cursor::Wait:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
m_platformCursor = wkCursor("BusyButClickable");
@@ -101,9 +105,16 @@
m_platformCursor = createNamedCursor("waitCursor", 7, 7);
#endif
break;
+
case Cursor::Help:
+#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+m_platformCursor = wkCursor("Help");
+if (m_platformCursor)
+break;
+#endif
m_platformCursor = createNamedCursor("helpCursor", 8, 8);
break;
+
case Cursor::Move:
case Cursor::MiddlePanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -112,6 +123,7 @@
m_platformCursor = createNamedCursor("moveCursor", 7, 7);
#endif
break;
+
case Cursor::EastResize:
case Cursor::EastPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -120,6 +132,7 @@
m_platformCursor = createNamedCursor("eastResizeCursor", 14, 7);
#endif
break;
+
case Cursor::NorthResize:
case Cursor::NorthPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -128,6 +141,7 @@
m_platformCursor = createNamedCursor("northResizeCursor", 7, 1);
#endif
break;
+
case Cursor::NorthEastResize:
case Cursor::NorthEastPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -136,6 +150,7 @@
m_platformCursor = createNamedCursor("northEastResizeCursor", 14, 1);
#endif
break;
+
case Cursor::NorthWestResize:
case Cursor::NorthWestPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -144,6 +159,7 @@
m_platformCursor = createNamedCursor("northWestResizeCursor", 0, 0);
#endif
break;
+
case Cursor::SouthResize:
case Cursor::SouthPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -152,6 +168,7 @@
m_platformCursor = createNamedCursor("southResizeCursor", 7, 14);
#endif
break;
+
case Cursor::SouthEastResize:
case Cursor::SouthEastPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -160,6 +177,7 @@
m_platformCursor = createNamedCursor("southEastResizeCursor", 14, 14);
#endif
break;
+
case Cursor::SouthWestResize:
case Cursor::SouthWestPanning:
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -168,6 +186,7 @@
m_platformCursor = createNamedCursor("southWestResizeCursor", 1, 14);
#endif
break;
+
case Cursor::Wes
[webkit-changes] [96776] trunk
Title: [96776] trunk Revision 96776 Author t...@chromium.org Date 2011-10-05 17:51:56 -0700 (Wed, 05 Oct 2011) Log Message force margin:auto to 0 in flex items https://bugs.webkit.org/show_bug.cgi?id=69475 Reviewed by Ojan Vafai. Source/WebCore: The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::computePreferredLogicalWidth): (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): LayoutTests: * css3/flexbox/002.html: * css3/flexbox/003.html: * css3/flexbox/004.html: * css3/flexbox/writing-modes.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/002.html trunk/LayoutTests/css3/flexbox/003.html trunk/LayoutTests/css3/flexbox/004.html trunk/LayoutTests/css3/flexbox/writing-modes.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp Diff Modified: trunk/LayoutTests/ChangeLog (96775 => 96776) --- trunk/LayoutTests/ChangeLog 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/LayoutTests/ChangeLog 2011-10-06 00:51:56 UTC (rev 96776) @@ -1,3 +1,15 @@ +2011-10-05 Tony Chang + +force margin:auto to 0 in flex items +https://bugs.webkit.org/show_bug.cgi?id=69475 + +Reviewed by Ojan Vafai. + +* css3/flexbox/002.html: +* css3/flexbox/003.html: +* css3/flexbox/004.html: +* css3/flexbox/writing-modes.html: + 2011-10-05 Dean Jackson Computed style for filter property Modified: trunk/LayoutTests/css3/flexbox/002.html (96775 => 96776) --- trunk/LayoutTests/css3/flexbox/002.html 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/LayoutTests/css3/flexbox/002.html 2011-10-06 00:51:56 UTC (rev 96776) @@ -43,55 +43,55 @@ - + - + - + - - - + + + - + - + - + - + - + - - + + - - + + - - - + + + Modified: trunk/LayoutTests/css3/flexbox/003.html (96775 => 96776) --- trunk/LayoutTests/css3/flexbox/003.html 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/LayoutTests/css3/flexbox/003.html 2011-10-06 00:51:56 UTC (rev 96776) @@ -64,9 +64,9 @@ - - - + + + Modified: trunk/LayoutTests/css3/flexbox/004.html (96775 => 96776) --- trunk/LayoutTests/css3/flexbox/004.html 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/LayoutTests/css3/flexbox/004.html 2011-10-06 00:51:56 UTC (rev 96776) @@ -60,10 +60,10 @@ - + - - + + Modified: trunk/LayoutTests/css3/flexbox/writing-modes.html (96775 => 96776) --- trunk/LayoutTests/css3/flexbox/writing-modes.html 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/LayoutTests/css3/flexbox/writing-modes.html 2011-10-06 00:51:56 UTC (rev 96776) @@ -56,21 +56,21 @@ - - - + + + - - - + + + - - - + + + @@ -116,33 +116,33 @@ - - - + + + - - - + + + - - - + + + - - - + + + @@ -156,9 +156,9 @@ - - - + + + @@ -201,17 +201,17 @@ - - - + + + - - - + + + Modified: trunk/Source/WebCore/ChangeLog (96775 => 96776) --- trunk/Source/WebCore/ChangeLog 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/Source/WebCore/ChangeLog 2011-10-06 00:51:56 UTC (rev 96776) @@ -1,3 +1,16 @@ +2011-10-05 Tony Chang + +force margin:auto to 0 in flex items +https://bugs.webkit.org/show_bug.cgi?id=69475 + +Reviewed by Ojan Vafai. + +The spec used to say the margin had a value of flex(1 0 0), but changed to just be 0. + +* rendering/RenderFlexibleBox.cpp: +(WebCore::RenderFlexibleBox::computePreferredLogicalWidth): +(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): + 2011-10-05 Dean Jackson Computed style for filter property Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (96775 => 96776) --- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2011-10-06 00:44:27 UTC (rev 96775) +++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2011-10-06 00:51:56 UTC (rev 96776) @@ -392,11 +392,6 @@ preferredLogicalWidth += child->style()->marginBottom().calcMinValue(flexboxAvailableLogicalWidth); } -if (marginStartStyleForChild(child).isAuto()) -totalPositiveFlexibility += 1; -if (marginEndStyleForChild(child).isAuto()) -totalPositiveFlexibility += 1; - preferredLogicalWidth += logicalBorderAndPaddingWidthForChild(child); preferredLogicalWidth += preferredLogicalContentWidthForFlexItem(child); @@ -487,9 +482,9 @@ setFlowAwareLogicalHeight(std::max(flowAwareLogicalHeight(), flowAwareBorderBefore() + flowAwarePaddingBefor
[webkit-changes] [96775] trunk
Title: [96775] trunk
Revision 96775
Author d...@apple.com
Date 2011-10-05 17:44:27 -0700 (Wed, 05 Oct 2011)
Log Message
Computed style for filter property
https://bugs.webkit.org/show_bug.cgi?id=68477
Reviewed by Simon Fraser.
Reports the computed style for the new -webkit-filter
property value.
Test: css3/filters/filter-property-computed-style.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedFilter):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
New test to exercise computed style for -webkit-filter. Note
that drop-shadow is not yet supported.
* css3/filters/filter-property-computed-style-expected.txt: Added.
* css3/filters/filter-property-computed-style.html: Added.
* css3/filters/script-tests/filter-property-computed-style.js: Added.
(testComputedFilterRule):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
Added Paths
trunk/LayoutTests/css3/filters/filter-property-computed-style-expected.txt
trunk/LayoutTests/css3/filters/filter-property-computed-style.html
trunk/LayoutTests/css3/filters/script-tests/filter-property-computed-style.js
Diff
Modified: trunk/LayoutTests/ChangeLog (96774 => 96775)
--- trunk/LayoutTests/ChangeLog 2011-10-06 00:40:39 UTC (rev 96774)
+++ trunk/LayoutTests/ChangeLog 2011-10-06 00:44:27 UTC (rev 96775)
@@ -1,3 +1,18 @@
+2011-10-05 Dean Jackson
+
+Computed style for filter property
+https://bugs.webkit.org/show_bug.cgi?id=68477
+
+Reviewed by Simon Fraser.
+
+New test to exercise computed style for -webkit-filter. Note
+that drop-shadow is not yet supported.
+
+* css3/filters/filter-property-computed-style-expected.txt: Added.
+* css3/filters/filter-property-computed-style.html: Added.
+* css3/filters/script-tests/filter-property-computed-style.js: Added.
+(testComputedFilterRule):
+
2011-10-05 Jer Noble
Enable WEB_AUDIO by default in the WebKit/mac port.
Added: trunk/LayoutTests/css3/filters/filter-property-computed-style-expected.txt (0 => 96775)
--- trunk/LayoutTests/css3/filters/filter-property-computed-style-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/filters/filter-property-computed-style-expected.txt 2011-10-06 00:44:27 UTC (rev 96775)
@@ -0,0 +1,294 @@
+Test the computed style of the -webkit-filter property.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+
+Basic reference : url('#a')
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_REFERENCE
+PASS subRule.cssText is 'url(\'#a\')'
+
+Bare unquoted reference converting to quoted form : url(#a)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_REFERENCE
+PASS subRule.cssText is 'url(\'#a\')'
+
+Multiple references : url('#a') url('#b')
+PASS filterStyle.length is 2
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_REFERENCE
+PASS subRule.cssText is 'url(\'#a\')'
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_REFERENCE
+PASS subRule.cssText is 'url(\'#b\')'
+
+Reference as 2nd value : grayscale(1) url('#a')
+PASS filterStyle.length is 2
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(1)'
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_REFERENCE
+PASS subRule.cssText is 'url(\'#a\')'
+
+Integer value : grayscale(1)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(1)'
+
+Float value converts to integer : grayscale(1.0)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(1)'
+
+Zero value : grayscale(0)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(0)'
+
+Multiple values : grayscale(0.5) grayscale(0.25)
+PASS filterStyle.length is 2
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(0.5)'
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_GRAYSCALE
+PASS subRule.cssText is 'grayscale(0.25)'
+
+Integer value : sepia(1)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_SEPIA
+PASS subRule.cssText is 'sepia(1)'
+
+Float value converts to integer : sepia(1.0)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_SEPIA
+PASS subRule.cssText is 'sepia(1)'
+
+Zero value : sepia(0)
+PASS filterStyle.length is 1
+PASS subRule.operationType is WebKitCSSFilterValue.CSS_FILTER_SEPIA
+PASS subRule.cssText is 'sepia(0)'
+
+Multiple values : sepia(0.5) sepia(0.25)
+PASS filterStyle.length is 2
+PASS subRule.operationType is WebKitCSSFilterValue.
[webkit-changes] [96773] trunk/Tools
Title: [96773] trunk/Tools
Revision 96773
Author bfulg...@webkit.org
Date 2011-10-05 17:35:43 -0700 (Wed, 05 Oct 2011)
Log Message
[WinCairo] Switch to building Release target, and activate tests.
https://bugs.webkit.org/show_bug.cgi?id=69272
Reviewed by Adam Barth.
* BuildSlaveSupport/build.webkit.org-config/config.json:
Change from debug to release target. Switch from "Build" to
"BuildAndTest"
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (96772 => 96773)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-10-06 00:34:14 UTC (rev 96772)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2011-10-06 00:35:43 UTC (rev 96773)
@@ -254,8 +254,8 @@
"slavenames": ["google-linux-android"]
},
{
- "name": "WinCairo Debug (Build)", "type": "Build", "builddir": "win-cairo-debug",
- "platform": "wincairo", "configuration": "debug", "architectures": ["i386"],
+ "name": "WinCairo Release", "type": "BuildAndTest", "builddir": "win-cairo-release",
+ "platform": "wincairo", "configuration": "release", "architectures": ["i386"],
"slavenames": ["wincairo-1"]
},
{
Modified: trunk/Tools/ChangeLog (96772 => 96773)
--- trunk/Tools/ChangeLog 2011-10-06 00:34:14 UTC (rev 96772)
+++ trunk/Tools/ChangeLog 2011-10-06 00:35:43 UTC (rev 96773)
@@ -1,3 +1,14 @@
+2011-10-05 Brent Fulgham
+
+[WinCairo] Switch to building Release target, and activate tests.
+https://bugs.webkit.org/show_bug.cgi?id=69272
+
+Reviewed by Adam Barth.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+Change from debug to release target. Switch from "Build" to
+"BuildAndTest"
+
2011-10-05 Simon Fraser
In WebKitTestRunner, text has font smoothing in pixel snapshots
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96772] trunk/Source/WebKit/chromium
Title: [96772] trunk/Source/WebKit/chromium
Revision 96772
Author commit-qu...@webkit.org
Date 2011-10-05 17:34:14 -0700 (Wed, 05 Oct 2011)
Log Message
Make destructor of WebURLLoaderClient virtual.
https://bugs.webkit.org/show_bug.cgi?id=69457
Patch by Alexei Svitkine on 2011-10-05
Reviewed by Darin Fisher.
* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::~WebURLLoaderClient):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebURLLoaderClient.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (96771 => 96772)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-06 00:29:31 UTC (rev 96771)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-06 00:34:14 UTC (rev 96772)
@@ -1,3 +1,13 @@
+2011-10-05 Alexei Svitkine
+
+Make destructor of WebURLLoaderClient virtual.
+https://bugs.webkit.org/show_bug.cgi?id=69457
+
+Reviewed by Darin Fisher.
+
+* public/WebURLLoaderClient.h:
+(WebKit::WebURLLoaderClient::~WebURLLoaderClient):
+
2011-10-05 Vangelis Kokkevis
Switching threaded compositor from a compile time option to a
Modified: trunk/Source/WebKit/chromium/public/WebURLLoaderClient.h (96771 => 96772)
--- trunk/Source/WebKit/chromium/public/WebURLLoaderClient.h 2011-10-06 00:29:31 UTC (rev 96771)
+++ trunk/Source/WebKit/chromium/public/WebURLLoaderClient.h 2011-10-06 00:34:14 UTC (rev 96772)
@@ -70,7 +70,7 @@
virtual void didFail(WebURLLoader*, const WebURLError&) { }
protected:
-~WebURLLoaderClient() { }
+virtual ~WebURLLoaderClient() { }
};
} // namespace WebKit
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96771] trunk/LayoutTests
Title: [96771] trunk/LayoutTests Revision 96771 Author bfulg...@webkit.org Date 2011-10-05 17:29:31 -0700 (Wed, 05 Oct 2011) Log Message [WinCairo] unreviewed build correction. * platform/wincairo/Skipped: Update to get build green. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96770 => 96771) --- trunk/LayoutTests/ChangeLog 2011-10-06 00:08:04 UTC (rev 96770) +++ trunk/LayoutTests/ChangeLog 2011-10-06 00:29:31 UTC (rev 96771) @@ -1,3 +1,9 @@ +2011-10-05 Brent Fulgham + +[WinCairo] unreviewed build correction. + +* platform/wincairo/Skipped: Update to get build green. + 2011-10-03 Ojan Vafai [flexbox] take marginBeforeForChild into account when positioning children Modified: trunk/LayoutTests/platform/wincairo/Skipped (96770 => 96771) --- trunk/LayoutTests/platform/wincairo/Skipped 2011-10-06 00:08:04 UTC (rev 96770) +++ trunk/LayoutTests/platform/wincairo/Skipped 2011-10-06 00:29:31 UTC (rev 96771) @@ -503,6 +503,7 @@ svg/hixie/rendering-model svg/hixie/shapes/path svg/hixie/text +svg/hixie/viewbox svg/in-html svg/overflow svg/repaint @@ -553,6 +554,7 @@ http/tests/inspector/console-xhr-logging.html http/tests/inspector/inspect-iframe-from-different-domain.html http/tests/inspector/network-preflight-options.html +http/tests/inspector/network http/tests/inspector/resource-har-conversion.html http/tests/inspector/resource-main-cookies.php http/tests/inspector/resource-parameters.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96770] trunk
Title: [96770] trunk Revision 96770 Author simon.fra...@apple.com Date 2011-10-05 17:08:04 -0700 (Wed, 05 Oct 2011) Log Message In WebKitTestRunner, text has font smoothing in pixel snapshots https://bugs.webkit.org/show_bug.cgi?id=69396 Source/WebKit2: Reviewed by Darin Adler. Plumb through a method on WKContext that controls whether font smoothing is enabled. Since this is a global setting, such a method is more appropriate than a preference. Remove leading underscores on some WKContext functions, but keep exported versions of same for binary compatibility. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): (WebKit::WebProcessCreationParameters::encode): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/API/C/WKContext.cpp: (WKContextSetAlwaysUsesComplexTextCodePath): (WKContextSetShouldUseFontSmoothing): (WKContextSetAdditionalPluginsDirectory): (WKContextRegisterURLSchemeAsEmptyDocument): (WKContextSetHTTPPipeliningEnabled): (_WKContextSetAdditionalPluginsDirectory): (_WKContextRegisterURLSchemeAsEmptyDocument): (_WKContextSetAlwaysUsesComplexTextCodePath): (_WKContextSetHTTPPipeliningEnabled): * UIProcess/API/C/WKContextPrivate.h: * UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): (WebKit::WebContext::ensureWebProcess): (WebKit::WebContext::setShouldUseFontSmoothing): (WebKit::WebContext::httpPipeliningEnabled): * UIProcess/WebContext.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setShouldUseFontSmoothing): * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Tools: Reviewed by Darin Adler. Call the new WKContext method that disables font smoothing in WebKitTestRunner, so that pixel snapshots don't have font smoothing enabled. Remove leading underscore from a WKContext function call. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h trunk/Source/WebKit2/UIProcess/WebContext.cpp trunk/Source/WebKit2/UIProcess/WebContext.h trunk/Source/WebKit2/WebProcess/WebProcess.cpp trunk/Source/WebKit2/WebProcess/WebProcess.h trunk/Source/WebKit2/WebProcess/WebProcess.messages.in trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/TestController.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (96769 => 96770) --- trunk/Source/WebKit2/ChangeLog 2011-10-06 00:01:28 UTC (rev 96769) +++ trunk/Source/WebKit2/ChangeLog 2011-10-06 00:08:04 UTC (rev 96770) @@ -1,3 +1,45 @@ +2011-10-05 Simon Fraser + +In WebKitTestRunner, text has font smoothing in pixel snapshots +https://bugs.webkit.org/show_bug.cgi?id=69396 + +Reviewed by Darin Adler. + +Plumb through a method on WKContext that controls whether font smoothing +is enabled. Since this is a global setting, such a method is more appropriate +than a preference. + +Remove leading underscores on some WKContext functions, but keep +exported versions of same for binary compatibility. + +* Shared/WebProcessCreationParameters.cpp: +(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): +(WebKit::WebProcessCreationParameters::encode): +(WebKit::WebProcessCreationParameters::decode): +* Shared/WebProcessCreationParameters.h: +* UIProcess/API/C/WKContext.cpp: +(WKContextSetAlwaysUsesComplexTextCodePath): +(WKContextSetShouldUseFontSmoothing): +(WKContextSetAdditionalPluginsDirectory): +(WKContextRegisterURLSchemeAsEmptyDocument): +(WKContextSetHTTPPipeliningEnabled): +(_WKContextSetAdditionalPluginsDirectory): +(_WKContextRegisterURLSchemeAsEmptyDocument): +(_WKContextSetAlwaysUsesComplexTextCodePath): +(_WKContextSetHTTPPipeliningEnabled): +* UIProcess/API/C/WKContextPrivate.h: +* UIProcess/WebContext.cpp: +(WebKit::WebContext::WebContext): +(WebKit::WebContext::ensureWebProcess): +(WebKit::WebContext::setShouldUseFontSmoothing): +(WebKit::WebContext::httpPipeliningEnabled): +* UIProcess/WebContext.h: +* WebProcess/WebProcess.cpp: +(WebKit::WebProcess::initializeWebProcess): +(WebKit::WebProcess::setShouldUseFontSmoothing): +* WebProcess/WebProcess.h: +* WebProcess/WebProcess.messages.in: + 2011-10-05 Anders Carlsson Flash of white when unminimizing windows Modified: trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp (96769 => 96770) --- trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp 2011-10-06 00:01:28 UTC (rev 9676
[webkit-changes] [96769] trunk
Title: [96769] trunk Revision 96769 Author o...@chromium.org Date 2011-10-05 17:01:28 -0700 (Wed, 05 Oct 2011) Log Message [flexbox] take marginBeforeForChild into account when positioning children https://bugs.webkit.org/show_bug.cgi?id=69313 Reviewed by Tony Chang. Source/WebCore: * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): LayoutTests: * css3/flexbox/002.html: * css3/flexbox/writing-modes.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/flexbox/002-expected.txt trunk/LayoutTests/css3/flexbox/002.html trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt trunk/LayoutTests/css3/flexbox/writing-modes.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp Diff Modified: trunk/LayoutTests/ChangeLog (96768 => 96769) --- trunk/LayoutTests/ChangeLog 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/LayoutTests/ChangeLog 2011-10-06 00:01:28 UTC (rev 96769) @@ -1,3 +1,13 @@ +2011-10-03 Ojan Vafai + +[flexbox] take marginBeforeForChild into account when positioning children +https://bugs.webkit.org/show_bug.cgi?id=69313 + +Reviewed by Tony Chang. + +* css3/flexbox/002.html: +* css3/flexbox/writing-modes.html: + 2011-10-05 James Simonsen [Chromium] Update test expectations after Skia roll. Modified: trunk/LayoutTests/css3/flexbox/002-expected.txt (96768 => 96769) --- trunk/LayoutTests/css3/flexbox/002-expected.txt 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/LayoutTests/css3/flexbox/002-expected.txt 2011-10-06 00:01:28 UTC (rev 96769) @@ -8,4 +8,5 @@ PASS PASS PASS +PASS Modified: trunk/LayoutTests/css3/flexbox/002.html (96768 => 96769) --- trunk/LayoutTests/css3/flexbox/002.html 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/LayoutTests/css3/flexbox/002.html 2011-10-06 00:01:28 UTC (rev 96769) @@ -37,6 +37,12 @@ + + + + + + Modified: trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt (96768 => 96769) --- trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/LayoutTests/css3/flexbox/writing-modes-expected.txt 2011-10-06 00:01:28 UTC (rev 96769) @@ -16,4 +16,7 @@ PASS PASS PASS +PASS +PASS +PASS Modified: trunk/LayoutTests/css3/flexbox/writing-modes.html (96768 => 96769) --- trunk/LayoutTests/css3/flexbox/writing-modes.html 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/LayoutTests/css3/flexbox/writing-modes.html 2011-10-06 00:01:28 UTC (rev 96769) @@ -83,6 +83,14 @@ + + + + + + + + @@ -168,6 +176,14 @@ + + + + + + + + @@ -175,6 +191,14 @@ + + + + + + + + Modified: trunk/Source/WebCore/ChangeLog (96768 => 96769) --- trunk/Source/WebCore/ChangeLog 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/Source/WebCore/ChangeLog 2011-10-06 00:01:28 UTC (rev 96769) @@ -1,3 +1,13 @@ +2011-10-03 Ojan Vafai + +[flexbox] take marginBeforeForChild into account when positioning children +https://bugs.webkit.org/show_bug.cgi?id=69313 + +Reviewed by Tony Chang. + +* rendering/RenderFlexibleBox.cpp: +(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): + 2011-10-05 Vangelis Kokkevis Switching threaded compositor from a compile time option to a Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (96768 => 96769) --- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2011-10-06 00:00:30 UTC (rev 96768) +++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp 2011-10-06 00:01:28 UTC (rev 96769) @@ -497,7 +497,7 @@ LayoutUnit logicalLeft = isLeftToRightFlow() ? startEdge : totalLogicalWidth - startEdge - childLogicalWidth; // FIXME: Do repaintDuringLayoutIfMoved. // FIXME: Supporting layout deltas. -setFlowAwareLogicalLocationForChild(child, IntPoint(logicalLeft, logicalTop)); +setFlowAwareLogicalLocationForChild(child, IntPoint(logicalLeft, logicalTop + flowAwareMarginBeforeForChild(child))); startEdge += childLogicalWidth + marginEndForChild(child); if (hasPackingSpace(availableFreeSpace, totalPositiveFlexibility) && style()->flexPack() == PackJustify && childSizes.size() > 1) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96768] trunk/Tools
Title: [96768] trunk/Tools
Revision 96768
Author le...@chromium.org
Date 2011-10-05 17:00:30 -0700 (Wed, 05 Oct 2011)
Log Message
Improve the watchlist for threading entries.
https://bugs.webkit.org/show_bug.cgi?id=69463
Reviewed by Adam Barth.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (96767 => 96768)
--- trunk/Tools/ChangeLog 2011-10-05 23:59:36 UTC (rev 96767)
+++ trunk/Tools/ChangeLog 2011-10-06 00:00:30 UTC (rev 96768)
@@ -1,3 +1,12 @@
+2011-10-05 David Levin
+
+Improve the watchlist for threading entries.
+https://bugs.webkit.org/show_bug.cgi?id=69463
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/config/watchlist:
+
2011-10-05 Adam Roben
Add tests for using RetainPtrs inside HashMap and HashSet
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (96767 => 96768)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 23:59:36 UTC (rev 96767)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-06 00:00:30 UTC (rev 96768)
@@ -8,11 +8,19 @@
"filename": r"Source/WebKit/chromium/public/.*"
},
"ThreadingFiles": {
-"filename": r"Source/_javascript_Core/wtf/ThreadSafeRefCounted\.h"
-r"|Source/_javascript_Core/wtf/Threading\.h",
+"filename": r"Source/_javascript_Core/wtf/ThreadSpecific\..*"
+r"|Source/_javascript_Core/wtf/ThreadSafeRefCounted\..*"
+r"|Source/_javascript_Core/wtf/ThreadingPrimitives\..*"
+r"|Source/_javascript_Core/wtf/Threading\..*"
+r"|Source/WebCore/dom/CrossThreadTask\..*"
+r"|Source/WebCore/platform/CrossThreadCopier\..*",
},
"ThreadingUsage": {
-"more": r"deprecatedTurnOffVerifier|crossThreadString|threadsafeCopy|ThreadSafeRefCounted|CrossThreadRefCounted",
+# The intention of this regex is to detect places where people are using common threading mechanisms,
+# so that one can look them over for common mistakes. This list is long and likely to get longer over time.
+# Note the negative look-ahead to avoid new mentions of the files (for builds or includes).
+"more": r"(AllowCrossThreadAccess|AtomicallyInitialize|CrossThreadCopier|CrossThreadRefCounted|Mutex|ReadWriteLock|ThreadCondition|ThreadSafeRefCounted|ThreadSpecific"
+r"|createCallbackTask|crossThreadString|deprecatedTurnOffVerifier|threadsafeCopy)(?!\.(h|cpp))",
},
"WatchListScript": {
"filename": r"Tools/Scripts/webkitpy/common/watchlist/.*",
@@ -24,8 +32,8 @@
"filename": r"Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/.*",
},
"SecurityCritical": {
-"more": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
-"less": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
+"more": r"[Ss]ecurityOrigin(?!\.(h|cpp))",
+"less": r"[Ss]ecurityOrigin(?!\.(h|cpp))",
"filename": r"XSS|[Ss]ecurity",
},
"V8Bindings": {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96767] trunk/LayoutTests
Title: [96767] trunk/LayoutTests Revision 96767 Author simon...@chromium.org Date 2011-10-05 16:59:36 -0700 (Wed, 05 Oct 2011) Log Message [Chromium] Update test expectations after Skia roll. Unreviewed. * platform/chromium/test_expectations.txt: Added select-background-none.html on Linux. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (96766 => 96767) --- trunk/LayoutTests/ChangeLog 2011-10-05 23:46:21 UTC (rev 96766) +++ trunk/LayoutTests/ChangeLog 2011-10-05 23:59:36 UTC (rev 96767) @@ -1,3 +1,11 @@ +2011-10-05 James Simonsen + +[Chromium] Update test expectations after Skia roll. + +Unreviewed. + +* platform/chromium/test_expectations.txt: Added select-background-none.html on Linux. + 2011-10-05 Dean Jackson Parse '-webkit-filter' property syntax Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96766 => 96767) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 23:46:21 UTC (rev 96766) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 23:59:36 UTC (rev 96767) @@ -3841,3 +3841,6 @@ // New test in http://trac.webkit.org/changeset/96470 BUGABARTH : svg/custom/grayscale-gradient-mask-2.svg = IMAGE + +// Broken with Skia roll: 2394 to 2412 +BUGWK69465 LINUX : fast/forms/select-background-none.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96766] trunk/Source
Title: [96766] trunk/Source
Revision 96766
Author vange...@chromium.org
Date 2011-10-05 16:46:21 -0700 (Wed, 05 Oct 2011)
Log Message
Switching threaded compositor from a compile time option to a
run time one.
https://bugs.webkit.org/show_bug.cgi?id=69391
Reviewed by Darin Fisher.
Source/WebCore:
Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
called from anywhere,
No new tests as it doesn't add new functionality.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
(WebCore::CCLayerTreeHost::setNeedsRedraw):
(WebCore::CCLayerTreeHost::composite):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
(WebCore::CCSingleThreadProxy::compositeImmediately):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
Source/WebKit/chromium:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setMinimumAccelerated2dCanvasSize):
(WebKit::WebSettingsImpl::setUseThreadedCompositor):
* src/WebSettingsImpl.h:
(WebKit::WebSettingsImpl::useThreadedCompositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::createLayerTreeHostContext3D):
(WebKit::WebViewImpl::scheduleComposite):
(WebKit::WebViewImpl::graphicsContext3D):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96765 => 96766)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 23:40:09 UTC (rev 96765)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 23:46:21 UTC (rev 96766)
@@ -1,3 +1,27 @@
+2011-10-05 Vangelis Kokkevis
+
+Switching threaded compositor from a compile time option to a
+run time one.
+https://bugs.webkit.org/show_bug.cgi?id=69391
+
+Reviewed by Darin Fisher.
+
+Mostly converted #if USE(THREADED_COMPOSITING) to a regular if statements.
+In addition, CCLayerTreeHost::scheduleComposite() is removed as it wasn't being
+called from anywhere,
+
+No new tests as it doesn't add new functionality.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::setNeedsCommitThenRedraw):
+(WebCore::CCLayerTreeHost::setNeedsRedraw):
+(WebCore::CCLayerTreeHost::composite):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::setNeedsCommitThenRedraw):
+(WebCore::CCSingleThreadProxy::compositeImmediately):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+
2011-10-05 Dean Jackson
Parse '-webkit-filter' property syntax
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (96765 => 96766)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-10-05 23:40:09 UTC (rev 96765)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2011-10-05 23:46:21 UTC (rev 96766)
@@ -163,13 +163,6 @@
m_client->didRecreateGraphicsContext(success);
}
-#if !USE(THREADED_COMPOSITING)
-void CCLayerTreeHost::scheduleComposite()
-{
-m_client->scheduleComposite();
-}
-#endif
-
// Temporary hack until WebViewImpl context creation gets simplified
GraphicsContext3D* CCLayerTreeHost::context()
{
@@ -204,21 +197,19 @@
void CCLayerTreeHost::setNeedsCommitThenRedraw()
{
-#if USE(THREADED_COMPOSITING)
-TRACE_EVENT("CCLayerTreeHost::setNeedsCommitThenRedraw", this, 0);
-m_proxy->setNeedsCommitThenRedraw();
-#else
-m_client->scheduleComposite();
-#endif
+if (m_settings.enableCompositorThread) {
+TRACE_EVENT("CCLayerTreeHost::setNeedsRedraw", this, 0);
+m_proxy->setNeedsCommitThenRedraw();
+} else
+m_client->scheduleComposite();
}
void CCLayerTreeHost::setNeedsRedraw()
{
-#if USE(THREADED_COMPOSITING)
-m_proxy->setNeedsRedraw();
-#else
-m_client->scheduleComposite();
-#endif
+if (m_settings.enableCompositorThread)
+m_proxy->setNeedsRedraw();
+else
+m_client->scheduleComposite();
}
[webkit-changes] [96765] trunk/Source/WebKit2
Title: [96765] trunk/Source/WebKit2
Revision 96765
Author ander...@apple.com
Date 2011-10-05 16:40:09 -0700 (Wed, 05 Oct 2011)
Log Message
Flash of white when unminimizing windows
https://bugs.webkit.org/show_bug.cgi?id=69476
Reviewed by Simon Fraser.
Whenever the UI process requests an immediate backing store update, make sure to resume
painting if it's suspended.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updateBackingStoreState):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (96764 => 96765)
--- trunk/Source/WebKit2/ChangeLog 2011-10-05 23:27:54 UTC (rev 96764)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-05 23:40:09 UTC (rev 96765)
@@ -1,3 +1,17 @@
+2011-10-05 Anders Carlsson
+
+Flash of white when unminimizing windows
+https://bugs.webkit.org/show_bug.cgi?id=69476
+
+
+Reviewed by Simon Fraser.
+
+Whenever the UI process requests an immediate backing store update, make sure to resume
+painting if it's suspended.
+
+* WebProcess/WebPage/DrawingAreaImpl.cpp:
+(WebKit::DrawingAreaImpl::updateBackingStoreState):
+
2011-10-05 Caio Marcelo de Oliveira Filho
[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
Modified: trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp (96764 => 96765)
--- trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2011-10-05 23:27:54 UTC (rev 96764)
+++ trunk/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp 2011-10-05 23:40:09 UTC (rev 96765)
@@ -338,8 +338,14 @@
// sendDidUpdateBackingStoreState; otherwise we shouldn't do one right now.
m_isWaitingForDidUpdate = false;
-if (respondImmediately)
+if (respondImmediately) {
+// Make sure to resume painting if we're supposed to respond immediately, otherwise we'll just
+// send back an empty UpdateInfo struct.
+if (m_isPaintingSuspended)
+resumePainting();
+
sendDidUpdateBackingStoreState();
+}
m_inUpdateBackingStoreState = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96763] trunk/LayoutTests
Title: [96763] trunk/LayoutTests Revision 96763 Author crog...@google.com Date 2011-10-05 16:05:28 -0700 (Wed, 05 Oct 2011) Log Message Rebaseline webaudio/audiobuffersource-playbackrate.html due to http://trac.webkit.org/changeset/96745 https://bugs.webkit.org/show_bug.cgi?id=69470 Unreviewed. * webaudio/audiobuffersource-playbackrate-expected.wav: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav Diff Modified: trunk/LayoutTests/ChangeLog (96762 => 96763) --- trunk/LayoutTests/ChangeLog 2011-10-05 22:51:31 UTC (rev 96762) +++ trunk/LayoutTests/ChangeLog 2011-10-05 23:05:28 UTC (rev 96763) @@ -1,3 +1,12 @@ +2011-10-05 Chris Rogers + +Rebaseline webaudio/audiobuffersource-playbackrate.html due to http://trac.webkit.org/changeset/96745 +https://bugs.webkit.org/show_bug.cgi?id=69470 + +Unreviewed. + +* webaudio/audiobuffersource-playbackrate-expected.wav: + 2011-10-05 Brent Fulgham [WinCairo] Create a Skipped file to support the new WinCairo test bot. Modified: trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96762] trunk/Source/JavaScriptCore
Title: [96762] trunk/Source/_javascript_Core
Revision 96762
Author fpi...@apple.com
Date 2011-10-05 15:51:31 -0700 (Wed, 05 Oct 2011)
Log Message
Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
https://bugs.webkit.org/show_bug.cgi?id=69346
Reviewed by Oliver Hunt.
Removed the assertion, since it was completely wrong for op_post_inc.
Short of having specialized PostInc nodes in the DFG, there is no
robust way of asserting what this assertion was trying to assert while
also supporting op_post_inc.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96761 => 96762)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:49:05 UTC (rev 96761)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:51:31 UTC (rev 96762)
@@ -1,3 +1,22 @@
+2011-10-05 Filip Pizlo
+
+Assertion hit in JSC::DFG::SpeculativeJIT::compile on SL bots
+https://bugs.webkit.org/show_bug.cgi?id=69346
+
+Reviewed by Oliver Hunt.
+
+Removed the assertion, since it was completely wrong for op_post_inc.
+Short of having specialized PostInc nodes in the DFG, there is no
+robust way of asserting what this assertion was trying to assert while
+also supporting op_post_inc.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+
2011-10-05 Geoffrey Garen
Added a simpler mechanism for registering one-off finalizers
Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (96761 => 96762)
--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-10-05 22:49:05 UTC (rev 96761)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp 2011-10-05 22:51:31 UTC (rev 96762)
@@ -922,6 +922,7 @@
case op_post_inc: {
unsigned result = currentInstruction[1].u.operand;
unsigned srcDst = currentInstruction[2].u.operand;
+ASSERT(result != srcDst); // Required for assumptions we make during OSR.
NodeIndex op = getToNumber(srcDst);
set(result, op);
set(srcDst, makeSafe(addToGraph(ArithAdd, OpInfo(NodeUseBottom), op, one(;
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (96761 => 96762)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-05 22:49:05 UTC (rev 96761)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-05 22:51:31 UTC (rev 96762)
@@ -698,27 +698,6 @@
ASSERT(m_bytecodeIndexForOSR == node.codeOrigin.bytecodeIndex());
Node& nextNode = m_jit.graph()[m_compileIndex+1];
-// This assertion will fail if we ever emit multiple SetLocal's for
-// a single bytecode instruction. That's unlikely to happen. But if
-// it does, the solution is to to have this perform a search until
-// it finds a Node with a different bytecode index from the one we've
-// got, and to abstractly execute the SetLocal's along the way. Or,
-// better yet, handle all of the SetLocal's at once: abstract interpret
-// all of them, then emit code for all of them, with OSR exiting to
-// the next non-SetLocal instruction. Note the special case for when
-// both this SetLocal and the next op have a bytecode index of 0; this
-// occurs for SetLocal's generated at the top of the code block to
-// initialize locals to undefined. Ideally, we'd have a way of marking
-// in the CodeOrigin that a SetLocal is synthetic. This will make the
-// assertion more sensible-looking. We should then also assert that
-// synthetic SetLocal's don't have speculation checks, since they
-// should only be dropping values that we statically know we are
-// allowed to drop into the variables. DFGPropagator will guarantee
-// this, since it should have at least an approximation (if not
-// exact knowledge) of the type of the SetLocal's child node, and
-// should merge that information into the local that is being set.
-ASSERT(m_bytecodeIndexForOSR != nextNode.codeOrigin.bytecodeIndex()
- || (!m_bytecodeIndexForOSR && !nextNode.codeOrigin.bytecodeIndex()));
m_bytecodeIndexForOSR = nextNode.codeOrigin.bytecodeIndex();
PredictedType predictedType = node.varia
[webkit-changes] [96761] trunk/Source/WebCore
Title: [96761] trunk/Source/WebCore
Revision 96761
Author crog...@google.com
Date 2011-10-05 15:49:05 -0700 (Wed, 05 Oct 2011)
Log Message
Fix Windows build - it doesn't have a log2f() function...
https://bugs.webkit.org/show_bug.cgi?id=69473
Unreviewed build fix.
* webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96760 => 96761)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 22:44:36 UTC (rev 96760)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 22:49:05 UTC (rev 96761)
@@ -1,3 +1,13 @@
+2011-10-05 Chris Rogers
+
+Fix Windows build - it doesn't have a log2f() function...
+https://bugs.webkit.org/show_bug.cgi?id=69473
+
+Unreviewed build fix.
+
+* webaudio/AudioParamTimeline.cpp:
+(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
+
2011-10-05 James Robinson
[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
Modified: trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp (96760 => 96761)
--- trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp 2011-10-05 22:44:36 UTC (rev 96760)
+++ trunk/Source/WebCore/webaudio/AudioParamTimeline.cpp 2011-10-05 22:49:05 UTC (rev 96761)
@@ -246,8 +246,9 @@
values[writeIndex] = value;
} else {
// Interpolate in log space.
-value1 = log2f(value1);
-value2 = log2f(value2);
+// FIXME: we should just use log2f(), but Windows doesn't have this function.
+value1 = narrowPrecisionToFloat(log2(value1));
+value2 = narrowPrecisionToFloat(log2(value2));
// FIXME: optimize to not use pow() in inner loop, this is just a simple exponential ramp.
for (; writeIndex < fillToFrame; ++writeIndex) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96760] trunk/Source/JavaScriptCore
Title: [96760] trunk/Source/_javascript_Core Revision 96760 Author gga...@apple.com Date 2011-10-05 15:44:36 -0700 (Wed, 05 Oct 2011) Log Message Added a simpler mechanism for registering one-off finalizers https://bugs.webkit.org/show_bug.cgi?id=69466 Reviewed by Oliver Hunt. * heap/Heap.cpp: (JSC::Heap::addFinalizer): (JSC::Heap::FinalizerOwner::finalize): * heap/Heap.h: New function for adding an arbitrary finalizer for an arbitrary cell without declaring any special classes or Handles yourself. * _javascript_Core.exp: Fix build. * runtime/Executable.cpp: (JSC::ExecutableBase::clearCode): (JSC::ExecutableBase::clearCodeVirtual): (JSC::EvalExecutable::clearCodeVirtual): (JSC::ProgramExecutable::clearCodeVirtual): (JSC::FunctionExecutable::discardCode): (JSC::FunctionExecutable::clearCodeVirtual): * runtime/Executable.h: (JSC::ExecutableBase::finishCreation): Use the new mechanism for eager finalization of executables. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::clearRareData): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::createRareDataIfNeeded): (JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager finalization of weak maps. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/heap/Heap.cpp trunk/Source/_javascript_Core/heap/Heap.h trunk/Source/_javascript_Core/runtime/Executable.cpp trunk/Source/_javascript_Core/runtime/Executable.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/JSGlobalObject.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (96759 => 96760) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:42:28 UTC (rev 96759) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:44:36 UTC (rev 96760) @@ -1,3 +1,36 @@ +2011-10-05 Geoffrey Garen + +Added a simpler mechanism for registering one-off finalizers +https://bugs.webkit.org/show_bug.cgi?id=69466 + +Reviewed by Oliver Hunt. + +* heap/Heap.cpp: +(JSC::Heap::addFinalizer): +(JSC::Heap::FinalizerOwner::finalize): +* heap/Heap.h: New function for adding an arbitrary finalizer for an +arbitrary cell without declaring any special classes or Handles yourself. + +* _javascript_Core.exp: Fix build. + +* runtime/Executable.cpp: +(JSC::ExecutableBase::clearCode): +(JSC::ExecutableBase::clearCodeVirtual): +(JSC::EvalExecutable::clearCodeVirtual): +(JSC::ProgramExecutable::clearCodeVirtual): +(JSC::FunctionExecutable::discardCode): +(JSC::FunctionExecutable::clearCodeVirtual): +* runtime/Executable.h: +(JSC::ExecutableBase::finishCreation): Use the new mechanism for eager +finalization of executables. + +* runtime/JSGlobalObject.cpp: +(JSC::JSGlobalObject::clearRareData): +* runtime/JSGlobalObject.h: +(JSC::JSGlobalObject::createRareDataIfNeeded): +(JSC::JSGlobalObject::registerWeakMap): Use the new mechanism for eager +finalization of weak maps. + 2011-10-05 Adam Roben Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (96759 => 96760) --- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-10-05 22:42:28 UTC (rev 96759) +++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-10-05 22:44:36 UTC (rev 96760) @@ -117,7 +117,6 @@ __ZN3JSC11JSByteArray13s_defaultInfoE __ZN3JSC11JSByteArray15createStructureERNS_12JSGlobalDataEPNS_14JSGlobalObjectENS_7JSValueEPKNS_9ClassInfoE __ZN3JSC11JSByteArrayC1EPNS_9ExecStateEPNS_9StructureEPN3WTF9ByteArrayE -__ZN3JSC15AllocationSpace16allocateSlowCaseERNS_11MarkedSpace9SizeClassE __ZN3JSC11ParserArena5resetEv __ZN3JSC11checkSyntaxEPNS_9ExecStateERKNS_10SourceCodeEPNS_7JSValueE __ZN3JSC11createErrorEPNS_9ExecStateERKNS_7UStringE @@ -162,6 +161,7 @@ __ZN3JSC14JSGlobalObject10globalExecEv __ZN3JSC14JSGlobalObject12defineGetterEPNS_9ExecStateERKNS_10IdentifierEPNS_8JSObjectEj __ZN3JSC14JSGlobalObject12defineSetterEPNS_9ExecStateERKNS_10IdentifierEPNS_8JSObjectEj +__ZN3JSC14JSGlobalObject13clearRareDataEPNS_6JSCellE __ZN3JSC14JSGlobalObject13visitChildrenEPNS_6JSCellERNS_11SlotVisitorE __ZN3JSC14JSGlobalObject16addStaticGlobalsEPNS0_18GlobalPropertyInfoEi __ZN3JSC14JSGlobalObject17putWithAttributesEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueEj @@ -179,6 +179,7 @@ __ZN3JSC14TimeoutChecker5resetEv __ZN3JSC14VTableSpectrum5countEPNS_6JSCellE __ZN3JSC14throwTypeErrorEPNS_9ExecStateE +__ZN3JSC15AllocationSpace16allocateSlowCaseERNS_11MarkedSpace9SizeClassE __ZN3JSC15WeakHandleOwner26isReachableFromOpaqueRootsENS_6HandleINS_7UnknownEEEPvRNS_11SlotVisitorE __ZN3JSC15WeakHandleOwner8finalizeENS_6HandleINS_7UnknownEEEPv __ZN3JSC15WeakHandleOwnerD2Ev @@ -232,6 +233,7 @@ __ZN3JSC35createInterruptedEx
[webkit-changes] [96759] trunk/Source/WebCore
Title: [96759] trunk/Source/WebCore
Revision 96759
Author jam...@google.com
Date 2011-10-05 15:42:28 -0700 (Wed, 05 Oct 2011)
Log Message
[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
https://bugs.webkit.org/show_bug.cgi?id=69467
Reviewed by Kenneth Russell.
Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
false-positive ASSERT().
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doComposite):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96758 => 96759)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 22:39:30 UTC (rev 96758)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 22:42:28 UTC (rev 96759)
@@ -1,3 +1,16 @@
+2011-10-05 James Robinson
+
+[chromium] ASSERT triggered when gpu process lost in single-threaded compositing path
+https://bugs.webkit.org/show_bug.cgi?id=69467
+
+Reviewed by Kenneth Russell.
+
+Shuffles debug-only bookkeeping around to more closely match what we do in the threaded path and not trip a
+false-positive ASSERT().
+
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::doComposite):
+
2011-10-05 Sheriff Bot
Unreviewed, rolling out r96756.
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (96758 => 96759)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp 2011-10-05 22:39:30 UTC (rev 96758)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp 2011-10-05 22:42:28 UTC (rev 96759)
@@ -269,20 +269,21 @@
{
DebugScopedSetImplThread impl;
m_layerTreeHostImpl->drawLayers();
- if (m_layerTreeHostImpl->isContextLost()) {
- // Trying to recover the context right here will not work if GPU process
- // died. This is because GpuChannelHost::OnErrorMessage will only be
- // called at the next iteration of the message loop, reverting our
- // recovery attempts here. Instead, we detach the root layer from the
- // renderer, recreate the renderer at the next message loop iteration
- // and request a repaint yet again.
- m_graphicsContextLost = true;
- m_numFailedRecreateAttempts = 0;
- setNeedsCommitThenRedraw();
- return false;
- }
}
+if (m_layerTreeHostImpl->isContextLost()) {
+// Trying to recover the context right here will not work if GPU process
+// died. This is because GpuChannelHost::OnErrorMessage will only be
+// called at the next iteration of the message loop, reverting our
+// recovery attempts here. Instead, we detach the root layer from the
+// renderer, recreate the renderer at the next message loop iteration
+// and request a repaint yet again.
+m_graphicsContextLost = true;
+m_numFailedRecreateAttempts = 0;
+setNeedsCommitThenRedraw();
+return false;
+}
+
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96758] trunk/Source/WebCore
Title: [96758] trunk/Source/WebCore
Revision 96758
Author commit-qu...@webkit.org
Date 2011-10-05 15:39:30 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed, rolling out r96756.
http://trac.webkit.org/changeset/96756
https://bugs.webkit.org/show_bug.cgi?id=69472
Many builds broken due to WTFGetBacktrace not being exported
from _javascript_Core (Requested by aroben on #webkit).
Patch by Sheriff Bot on 2011-10-05
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptElement.cpp
trunk/Source/WebCore/dom/ScriptElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96757 => 96758)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 22:23:03 UTC (rev 96757)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 22:39:30 UTC (rev 96758)
@@ -1,3 +1,18 @@
+2011-10-05 Sheriff Bot
+
+Unreviewed, rolling out r96756.
+http://trac.webkit.org/changeset/96756
+https://bugs.webkit.org/show_bug.cgi?id=69472
+
+Many builds broken due to WTFGetBacktrace not being exported
+from _javascript_Core (Requested by aroben on #webkit).
+
+* dom/ScriptElement.cpp:
+(WebCore::ScriptElement::ScriptElement):
+(WebCore::ScriptElement::stopLoadRequest):
+(WebCore::ScriptElement::notifyFinished):
+* dom/ScriptElement.h:
+
2011-10-05 Gavin Peters
save resource zeroing stacks in ScriptElement for debugging
Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (96757 => 96758)
--- trunk/Source/WebCore/dom/ScriptElement.cpp 2011-10-05 22:23:03 UTC (rev 96757)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp 2011-10-05 22:39:30 UTC (rev 96758)
@@ -66,7 +66,6 @@
, m_forceAsync(!parserInserted)
, m_willExecuteInOrder(false)
, m_cachedScriptState(NeverSet)
-, m_backtraceSize(0)
{
ASSERT(m_element);
}
@@ -303,10 +302,7 @@
if (!m_willBeParserExecuted)
m_cachedScript->removeClient(this);
ASSERT(m_cachedScriptState == Set);
-
m_cachedScriptState = ZeroedInStopLoadRequest;
-m_backtraceSize = MaxBacktraceSize;
-WTFGetBacktrace(m_backtrace, &m_backtraceSize);
m_cachedScript = 0;
}
}
@@ -335,8 +331,6 @@
ASSERT(m_cachedScriptState == Set);
m_cachedScriptState = ZeroedInNotifyFinished;
-m_backtraceSize = MaxBacktraceSize;
-WTFGetBacktrace(m_backtrace, &m_backtraceSize);
m_cachedScript = 0;
}
Modified: trunk/Source/WebCore/dom/ScriptElement.h (96757 => 96758)
--- trunk/Source/WebCore/dom/ScriptElement.h 2011-10-05 22:23:03 UTC (rev 96757)
+++ trunk/Source/WebCore/dom/ScriptElement.h 2011-10-05 22:39:30 UTC (rev 96758)
@@ -113,14 +113,6 @@
ZeroedInStopLoadRequest,
ZeroedInNotifyFinished,
} m_cachedScriptState;
-
-// We grab a backtrace when we zero m_cachedScript, so that at later crashes
-// we'll have a debuggable stack.
-enum {
-MaxBacktraceSize = 32
-};
-int m_backtraceSize;
-void* m_backtrace[MaxBacktraceSize];
};
ScriptElement* toScriptElement(Element*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96757] trunk
Title: [96757] trunk
Revision 96757
Author aro...@apple.com
Date 2011-10-05 15:23:03 -0700 (Wed, 05 Oct 2011)
Log Message
Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer
RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
pointed-to type confused us when we implemented hashTableDeletedValue.
Fixes Using RetainPtr as the key type
in HashMap/HashSet fails to compile
Reviewed by John Sullivan.
Source/_javascript_Core:
* wtf/RetainPtr.h:
(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
since T might itself be a pointer.
(WTF::PtrHash >): Updated this to use PtrType everywhere, even though T* didn't
seem to be causing a problem.
Tools:
Add tests for using RetainPtrs inside HashMap and HashSet
* TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
(TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
and value type of HashMap.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added new file.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/RetainPtr.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WTF/cf/
trunk/Tools/TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96756 => 96757)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:03:35 UTC (rev 96756)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 22:23:03 UTC (rev 96757)
@@ -1,3 +1,22 @@
+2011-10-05 Adam Roben
+
+Ensure RetainPtr::hashTableDeletedValue returns a pointer, not a pointer to a pointer
+
+RetainPtr's behavior of allowing the template parameter to be either a pointer type or a
+pointed-to type confused us when we implemented hashTableDeletedValue.
+
+Fixes Using RetainPtr as the key type
+in HashMap/HashSet fails to compile
+
+Reviewed by John Sullivan.
+
+* wtf/RetainPtr.h:
+(WTF::RetainPtr::hashTableDeletedValue): Changed to use the PtrType typedef rather than T*,
+since T might itself be a pointer.
+
+(WTF::PtrHash >): Updated this to use PtrType everywhere, even though T* didn't
+seem to be causing a problem.
+
2011-10-05 Oliver Hunt
Remove last vestiges of anonymous storage.
Modified: trunk/Source/_javascript_Core/wtf/RetainPtr.h (96756 => 96757)
--- trunk/Source/_javascript_Core/wtf/RetainPtr.h 2011-10-05 22:03:35 UTC (rev 96756)
+++ trunk/Source/_javascript_Core/wtf/RetainPtr.h 2011-10-05 22:23:03 UTC (rev 96757)
@@ -103,7 +103,7 @@
PtrType releaseRef() { return leakRef(); }
private:
-static T* hashTableDeletedValue() { return reinterpret_cast(-1); }
+static PtrType hashTableDeletedValue() { return reinterpret_cast(-1); }
PtrType m_ptr;
};
@@ -236,13 +236,13 @@
template struct HashTraits > : SimpleClassHashTraits > { };
-template struct PtrHash > : PtrHash {
-using PtrHash::hash;
+template struct PtrHash > : PtrHash::PtrType> {
+using PtrHash::PtrType>::hash;
static unsigned hash(const RetainPtr& key) { return hash(key.get()); }
-using PtrHash::equal;
+using PtrHash::PtrType>::equal;
static bool equal(const RetainPtr& a, const RetainPtr& b) { return a == b; }
-static bool equal(P* a, const RetainPtr& b) { return a == b; }
-static bool equal(const RetainPtr& a, P* b) { return a == b; }
+static bool equal(typename RetainPtr::PtrType a, const RetainPtr& b) { return a == b; }
+static bool equal(const RetainPtr& a, typename RetainPtr::PtrType b) { return a == b; }
};
template struct DefaultHash > { typedef PtrHash > Hash; };
Modified: trunk/Tools/ChangeLog (96756 => 96757)
--- trunk/Tools/ChangeLog 2011-10-05 22:03:35 UTC (rev 96756)
+++ trunk/Tools/ChangeLog 2011-10-05 22:23:03 UTC (rev 96757)
@@ -1,3 +1,20 @@
+2011-10-05 Adam Roben
+
+Add tests for using RetainPtrs inside HashMap and HashSet
+
+Fixes Using RetainPtr as the key type
+in HashMap/HashSet fails to compile
+
+Reviewed by John Sullivan.
+
+* TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
+(TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
+and value type of HashMap.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/win/TestWebKitAPI.vcproj:
+Added new file.
+
2011-10-05 Adam Barth
Mark as Expected in garden-o-matic is confusing
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (96756 => 96757)
--- trunk/Tools/TestWebKitAPI/TestWe
[webkit-changes] [96756] trunk/Source/WebCore
Title: [96756] trunk/Source/WebCore
Revision 96756
Author gav...@chromium.org
Date 2011-10-05 15:03:35 -0700 (Wed, 05 Oct 2011)
Log Message
save resource zeroing stacks in ScriptElement for debugging
https://bugs.webkit.org/show_bug.cgi?id=69453
The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
75604). This patch will save a stack in the ScriptElement when this happens, so that if
we do later crash, we can see how we did the first zeroing.
See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
this change will help track down.
Reviewed by Nate Chapin.
No new tests, this shouldn't affect output at all, and isn't particularly testable.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::ScriptElement):
(WebCore::ScriptElement::stopLoadRequest):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptElement.cpp
trunk/Source/WebCore/dom/ScriptElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96755 => 96756)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 21:57:16 UTC (rev 96755)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 22:03:35 UTC (rev 96756)
@@ -1,3 +1,26 @@
+2011-10-05 Gavin Peters
+
+save resource zeroing stacks in ScriptElement for debugging
+https://bugs.webkit.org/show_bug.cgi?id=69453
+
+The state machine tracking how m_cachedScript gets zeroed shows that sometimes we get
+two notifyFinished() events in a ScriptElement, which can crash chrome (see chrome bug
+75604). This patch will save a stack in the ScriptElement when this happens, so that if
+we do later crash, we can see how we did the first zeroing.
+
+See http://code.google.com/p/chromium/issues/detail?id=75604 for the chromium bug that
+this change will help track down.
+
+Reviewed by Nate Chapin.
+
+No new tests, this shouldn't affect output at all, and isn't particularly testable.
+
+* dom/ScriptElement.cpp:
+(WebCore::ScriptElement::ScriptElement):
+(WebCore::ScriptElement::stopLoadRequest):
+(WebCore::ScriptElement::notifyFinished):
+* dom/ScriptElement.h:
+
2011-10-05 Alexey Proskuryakov
More build fix.
Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (96755 => 96756)
--- trunk/Source/WebCore/dom/ScriptElement.cpp 2011-10-05 21:57:16 UTC (rev 96755)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp 2011-10-05 22:03:35 UTC (rev 96756)
@@ -66,6 +66,7 @@
, m_forceAsync(!parserInserted)
, m_willExecuteInOrder(false)
, m_cachedScriptState(NeverSet)
+, m_backtraceSize(0)
{
ASSERT(m_element);
}
@@ -302,7 +303,10 @@
if (!m_willBeParserExecuted)
m_cachedScript->removeClient(this);
ASSERT(m_cachedScriptState == Set);
+
m_cachedScriptState = ZeroedInStopLoadRequest;
+m_backtraceSize = MaxBacktraceSize;
+WTFGetBacktrace(m_backtrace, &m_backtraceSize);
m_cachedScript = 0;
}
}
@@ -331,6 +335,8 @@
ASSERT(m_cachedScriptState == Set);
m_cachedScriptState = ZeroedInNotifyFinished;
+m_backtraceSize = MaxBacktraceSize;
+WTFGetBacktrace(m_backtrace, &m_backtraceSize);
m_cachedScript = 0;
}
Modified: trunk/Source/WebCore/dom/ScriptElement.h (96755 => 96756)
--- trunk/Source/WebCore/dom/ScriptElement.h 2011-10-05 21:57:16 UTC (rev 96755)
+++ trunk/Source/WebCore/dom/ScriptElement.h 2011-10-05 22:03:35 UTC (rev 96756)
@@ -113,6 +113,14 @@
ZeroedInStopLoadRequest,
ZeroedInNotifyFinished,
} m_cachedScriptState;
+
+// We grab a backtrace when we zero m_cachedScript, so that at later crashes
+// we'll have a debuggable stack.
+enum {
+MaxBacktraceSize = 32
+};
+int m_backtraceSize;
+void* m_backtrace[MaxBacktraceSize];
};
ScriptElement* toScriptElement(Element*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96755] trunk/Source/JavaScriptCore
Title: [96755] trunk/Source/_javascript_Core
Revision 96755
Author oli...@apple.com
Date 2011-10-05 14:57:16 -0700 (Wed, 05 Oct 2011)
Log Message
2011-10-05 Oliver Hunt
Remove last vestiges of anonymous storage.
Reviewed by Gavin Barraclough.
One anonymous storage function escaped my prior purge of
this feature, this patch removes it.
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
* runtime/JSObject.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
trunk/Source/_javascript_Core/runtime/JSObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96754 => 96755)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 21:48:36 UTC (rev 96754)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 21:57:16 UTC (rev 96755)
@@ -1,3 +1,16 @@
+2011-10-05 Oliver Hunt
+
+Remove last vestiges of anonymous storage.
+
+Reviewed by Gavin Barraclough.
+
+One anonymous storage function escaped my prior purge of
+this feature, this patch removes it.
+
+* runtime/JSGlobalObject.h:
+(JSC::JSGlobalObject::finishCreation):
+* runtime/JSObject.h:
+
2011-10-04 Filip Pizlo
DFG should be capable of a broader range of speculations on branch and not
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObject.h (96754 => 96755)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2011-10-05 21:48:36 UTC (rev 96754)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObject.h 2011-10-05 21:57:16 UTC (rev 96755)
@@ -168,7 +168,6 @@
{
Base::finishCreation(globalData);
structure()->setGlobalObject(globalData, this);
-putThisToAnonymousValue(0);
init(thisValue);
}
Modified: trunk/Source/_javascript_Core/runtime/JSObject.h (96754 => 96755)
--- trunk/Source/_javascript_Core/runtime/JSObject.h 2011-10-05 21:48:36 UTC (rev 96754)
+++ trunk/Source/_javascript_Core/runtime/JSObject.h 2011-10-05 21:57:16 UTC (rev 96755)
@@ -251,11 +251,6 @@
static const unsigned StructureFlags = 0;
-void putThisToAnonymousValue(unsigned index)
-{
-locationForOffset(index)->setWithoutWriteBarrier(this);
-}
-
// To instantiate objects you likely want JSFinalObject, below.
// To create derived types you likely want JSNonFinalObject, below.
JSObject(JSGlobalData&, Structure*, PropertyStorage inlineStorage);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96754] trunk/Source/WebCore
Title: [96754] trunk/Source/WebCore Revision 96754 Author a...@apple.com Date 2011-10-05 14:48:36 -0700 (Wed, 05 Oct 2011) Log Message More build fix. * WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (96753 => 96754) --- trunk/Source/WebCore/ChangeLog 2011-10-05 21:46:15 UTC (rev 96753) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 21:48:36 UTC (rev 96754) @@ -1,3 +1,9 @@ +2011-10-05 Alexey Proskuryakov + +More build fix. + +* WebCore.exp.in: Made a typo in a last minute change for my 32-bit build fix. + 2011-10-05 Anna Cavender Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient Modified: trunk/Source/WebCore/WebCore.exp.in (96753 => 96754) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-05 21:46:15 UTC (rev 96753) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-05 21:48:36 UTC (rev 96754) @@ -1346,7 +1346,7 @@ __ZNK7WebCore7IntRect8containsERKS0_ __ZNK7WebCore7IntRectcv6CGRectEv __ZNK7WebCore7IntRectcv7_NSRectEv -__ZNK7WebCore7IntSizecv6NSRectEv +__ZNK7WebCore7IntSizecv6CGSizeEv __ZNK7WebCore8Document10renderViewEv __ZNK7WebCore8Document11completeURLERKN3WTF6StringE __ZNK7WebCore8Document13axObjectCacheEv ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96753] trunk/Tools
Title: [96753] trunk/Tools
Revision 96753
Author aba...@webkit.org
Date 2011-10-05 14:46:15 -0700 (Wed, 05 Oct 2011)
Log Message
Mark as Expected in garden-o-matic is confusing
https://bugs.webkit.org/show_bug.cgi?id=69452
Reviewed by David Levin.
krit didn't understand the difference between this button and the
Rebaseline button because both of them seem to indicate that the new
behavior is expected. This patch renames "Mark as Expected" to "Expect
Failure" to make it clear that we're just expecting the test to fail
rather than accepting the new results as passing. We might need to
iterate on these names a bit more if folks continue to find them
confusing.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js (96752 => 96753)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-10-05 21:40:40 UTC (rev 96752)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js 2011-10-05 21:46:15 UTC (rev 96753)
@@ -86,7 +86,7 @@
// FIXME: Rename all the code to match the user-visible name.
ui.actions.UpdateExpectations = base.extends(Action, {
init: function() {
-this.textContent = 'Mark as Expected';
+this.textContent = 'Expect Failure';
this._eventName = 'updateexpectations';
}
});
Modified: trunk/Tools/ChangeLog (96752 => 96753)
--- trunk/Tools/ChangeLog 2011-10-05 21:40:40 UTC (rev 96752)
+++ trunk/Tools/ChangeLog 2011-10-05 21:46:15 UTC (rev 96753)
@@ -1,5 +1,22 @@
2011-10-05 Adam Barth
+Mark as Expected in garden-o-matic is confusing
+https://bugs.webkit.org/show_bug.cgi?id=69452
+
+Reviewed by David Levin.
+
+krit didn't understand the difference between this button and the
+Rebaseline button because both of them seem to indicate that the new
+behavior is expected. This patch renames "Mark as Expected" to "Expect
+Failure" to make it clear that we're just expecting the test to fail
+rather than accepting the new results as passing. We might need to
+iterate on these names a bit more if folks continue to find them
+confusing.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
+
+2011-10-05 Adam Barth
+
Add watchlist entries for abarth
https://bugs.webkit.org/show_bug.cgi?id=69461
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96751] trunk/Source/WebCore
Title: [96751] trunk/Source/WebCore
Revision 96751
Author ann...@chromium.org
Date 2011-10-05 14:40:11 -0700 (Wed, 05 Oct 2011)
Log Message
Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=69456
Reviewed by David Levin.
No new tests. No new functionality.
* html/track/CueParser.cpp:
(WebCore::CueParser::didFinishLoading):
* html/track/CueParser.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/track/CueParser.cpp
trunk/Source/WebCore/html/track/CueParser.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96750 => 96751)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 21:36:23 UTC (rev 96750)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 21:40:11 UTC (rev 96751)
@@ -1,3 +1,16 @@
+2011-10-05 Anna Cavender
+
+Fix CueParser::didFinishLoading to match changes in ThreadableLoaderClient
+https://bugs.webkit.org/show_bug.cgi?id=69456
+
+Reviewed by David Levin.
+
+No new tests. No new functionality.
+
+* html/track/CueParser.cpp:
+(WebCore::CueParser::didFinishLoading):
+* html/track/CueParser.h:
+
2011-10-05 Alexey Proskuryakov
32-bit build fix.
Modified: trunk/Source/WebCore/html/track/CueParser.cpp (96750 => 96751)
--- trunk/Source/WebCore/html/track/CueParser.cpp 2011-10-05 21:36:23 UTC (rev 96750)
+++ trunk/Source/WebCore/html/track/CueParser.cpp 2011-10-05 21:40:11 UTC (rev 96751)
@@ -88,7 +88,7 @@
m_private->parseBytes(data, length);
}
-void CueParser::didFinishLoading(unsigned long)
+void CueParser::didFinishLoading(unsigned long, double)
{
m_client->trackLoadCompleted();
}
Modified: trunk/Source/WebCore/html/track/CueParser.h (96750 => 96751)
--- trunk/Source/WebCore/html/track/CueParser.h 2011-10-05 21:36:23 UTC (rev 96750)
+++ trunk/Source/WebCore/html/track/CueParser.h 2011-10-05 21:40:11 UTC (rev 96751)
@@ -58,10 +58,10 @@
CueParser();
virtual ~CueParser();
-void didReceiveResponse(unsigned long, const ResourceResponse&);
-void didReceiveData(const char*, int);
-void didFinishLoading(unsigned long);
-void didFail(const ResourceError&);
+virtual void didReceiveResponse(unsigned long, const ResourceResponse&);
+virtual void didReceiveData(const char*, int);
+virtual void didFinishLoading(unsigned long /*identifier*/, double /*finishTime*/);
+virtual void didFail(const ResourceError&);
void load(const String&, ScriptExecutionContext*, CueParserClient*);
bool supportsType(const String&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96750] trunk/Source/JavaScriptCore
Title: [96750] trunk/Source/_javascript_Core
Revision 96750
Author fpi...@apple.com
Date 2011-10-05 14:36:23 -0700 (Wed, 05 Oct 2011)
Log Message
DFG should be capable of a broader range of speculations on branch and not
https://bugs.webkit.org/show_bug.cgi?id=69322
Reviewed by Oliver Hunt.
* bytecode/PredictedType.h:
(JSC::isFinalObjectOrOtherPrediction):
(JSC::isArrayOrOtherPrediction):
* dfg/DFGJITCodeGenerator.cpp:
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitBranch):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/PredictedType.h
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96749 => 96750)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 21:35:56 UTC (rev 96749)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 21:36:23 UTC (rev 96750)
@@ -1,3 +1,35 @@
+2011-10-04 Filip Pizlo
+
+DFG should be capable of a broader range of speculations on branch and not
+https://bugs.webkit.org/show_bug.cgi?id=69322
+
+Reviewed by Oliver Hunt.
+
+* bytecode/PredictedType.h:
+(JSC::isFinalObjectOrOtherPrediction):
+(JSC::isArrayOrOtherPrediction):
+* dfg/DFGJITCodeGenerator.cpp:
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::fillDouble):
+(JSC::DFG::JITCodeGenerator::fillJSValue):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::fillDouble):
+(JSC::DFG::JITCodeGenerator::fillJSValue):
+* dfg/DFGOperations.cpp:
+* dfg/DFGSpeculativeJIT.h:
+(JSC::DFG::SpeculativeJIT::shouldSpeculateFinalObjectOrOther):
+(JSC::DFG::SpeculativeJIT::shouldSpeculateArrayOrOther):
+(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::emitBranch):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
+(JSC::DFG::SpeculativeJIT::compileLogicalNot):
+(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
+(JSC::DFG::SpeculativeJIT::emitBranch):
+
2011-10-05 Sheriff Bot
Unreviewed, rolling out r96733.
Modified: trunk/Source/_javascript_Core/bytecode/PredictedType.h (96749 => 96750)
--- trunk/Source/_javascript_Core/bytecode/PredictedType.h 2011-10-05 21:35:56 UTC (rev 96749)
+++ trunk/Source/_javascript_Core/bytecode/PredictedType.h 2011-10-05 21:36:23 UTC (rev 96750)
@@ -67,6 +67,11 @@
return value == PredictFinalObject;
}
+inline bool isFinalObjectOrOtherPrediction(PredictedType value)
+{
+return !!(value & (PredictFinalObject | PredictOther)) && !(value & ~(PredictFinalObject | PredictOther));
+}
+
inline bool isStringPrediction(PredictedType value)
{
return value == PredictString;
@@ -77,6 +82,11 @@
return value == PredictArray;
}
+inline bool isArrayOrOtherPrediction(PredictedType value)
+{
+return !!(value & (PredictArray | PredictOther)) && !(value & ~(PredictArray | PredictOther));
+}
+
inline bool isInt32Prediction(PredictedType value)
{
return value == PredictInt32;
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (96749 => 96750)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-10-05 21:35:56 UTC (rev 96749)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-10-05 21:36:23 UTC (rev 96750)
@@ -874,7 +874,8 @@
{
SpeculationFailureDebugInfo* debugInfo = static_cast(debugInfoRaw);
CodeBlock* codeBlock = debugInfo->codeBlock;
-printf("Speculation failure in %p at 0x%x with executeCounter = %d, reoptimizationRetryCounter = %u, optimizationDelayCounter = %u, success/fail %u/%u\n", codeBlock, debugInfo->debugOffset, codeBlock->alternative()->executeCounter(), codeBlock->alternative()->reoptimizationRetryCounter(), codeBlock->altern
[webkit-changes] [96749] trunk/LayoutTests/ChangeLog
Title: [96749] trunk/LayoutTests/ChangeLog Revision 96749 Author bfulg...@webkit.org Date 2011-10-05 14:35:56 -0700 (Wed, 05 Oct 2011) Log Message [WinCairo] Create a Skipped file to support the new WinCairo test bot. https://bugs.webkit.org/show_bug.cgi?id=69280 Reviewed by Adam Roben. * platform/wincairo: Added. * platform/wincairo/Skipped: Added. Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (96748 => 96749) --- trunk/LayoutTests/ChangeLog 2011-10-05 21:35:14 UTC (rev 96748) +++ trunk/LayoutTests/ChangeLog 2011-10-05 21:35:56 UTC (rev 96749) @@ -1,3 +1,13 @@ +2011-10-05 Brent Fulgham + +[WinCairo] Create a Skipped file to support the new WinCairo test bot. +https://bugs.webkit.org/show_bug.cgi?id=69280 + +Reviewed by Adam Roben. + +* platform/wincairo: Added. +* platform/wincairo/Skipped: Added. + 2011-10-05 Chang Shu [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96748] trunk/Source/WebKit/mac
Title: [96748] trunk/Source/WebKit/mac
Revision 96748
Author ddkil...@apple.com
Date 2011-10-05 14:35:14 -0700 (Wed, 05 Oct 2011)
Log Message
REGRESSION: Curious Location of StorageTracker.db
Reviewed by Alexey Proskuryakov.
* Storage/WebStorageManager.mm:
(+[WebStorageManager _storageDirectoryPath]): Restore call to
-[NSString stringByStandardizingPath]. Also fix over-release of
sLocalStoragePath if the initial -objectForKey: call returned an
NSString object. Use pthread_once to be thread-safe.
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Storage/WebStorageManager.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (96747 => 96748)
--- trunk/Source/WebKit/mac/ChangeLog 2011-10-05 21:15:10 UTC (rev 96747)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-10-05 21:35:14 UTC (rev 96748)
@@ -1,3 +1,15 @@
+2011-10-05 David Kilzer
+
+ REGRESSION: Curious Location of StorageTracker.db
+
+Reviewed by Alexey Proskuryakov.
+
+* Storage/WebStorageManager.mm:
+(+[WebStorageManager _storageDirectoryPath]): Restore call to
+-[NSString stringByStandardizingPath]. Also fix over-release of
+sLocalStoragePath if the initial -objectForKey: call returned an
+NSString object. Use pthread_once to be thread-safe.
+
2011-10-04 Kent Tamura
Introduce feature flags for incomplete input types
Modified: trunk/Source/WebKit/mac/Storage/WebStorageManager.mm (96747 => 96748)
--- trunk/Source/WebKit/mac/Storage/WebStorageManager.mm 2011-10-05 21:15:10 UTC (rev 96747)
+++ trunk/Source/WebKit/mac/Storage/WebStorageManager.mm 2011-10-05 21:35:14 UTC (rev 96748)
@@ -32,12 +32,17 @@
#import
#import
+#import
using namespace WebCore;
NSString * const WebStorageDirectoryDefaultsKey = @"WebKitLocalStorageDatabasePathPreferenceKey";
NSString * const WebStorageDidModifyOriginNotification = @"WebStorageDidModifyOriginNotification";
+static NSString *sLocalStoragePath;
+static void initializeLocalStoragePath();
+static pthread_once_t registerLocalStoragePath = PTHREAD_ONCE_INIT;
+
@implementation WebStorageManager
+ (WebStorageManager *)sharedWebStorageManager
@@ -90,21 +95,20 @@
+ (NSString *)_storageDirectoryPath
{
-static NSString *sLocalStoragePath;
-
-if (sLocalStoragePath)
-return sLocalStoragePath;
-
+pthread_once(®isterLocalStoragePath, initializeLocalStoragePath);
+return sLocalStoragePath;
+}
+
+static void initializeLocalStoragePath()
+{
NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
sLocalStoragePath = [defaults objectForKey:WebStorageDirectoryDefaultsKey];
if (!sLocalStoragePath || ![sLocalStoragePath isKindOfClass:[NSString class]]) {
NSArray *paths = NSSearchPathForDirectoriesInDomains(NSLibraryDirectory, NSUserDomainMask, YES);
NSString *libraryDirectory = [paths objectAtIndex:0];
sLocalStoragePath = [libraryDirectory stringByAppendingPathComponent:@"WebKit/LocalStorage"];
-[sLocalStoragePath retain];
}
-
-return sLocalStoragePath;
+sLocalStoragePath = [[sLocalStoragePath stringByStandardizingPath] retain];
}
void WebKitInitializeStorageIfNecessary()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96747] trunk/Source/WebCore
Title: [96747] trunk/Source/WebCore Revision 96747 Author a...@apple.com Date 2011-10-05 14:15:10 -0700 (Wed, 05 Oct 2011) Log Message 32-bit build fix. * WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors. In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (96746 => 96747) --- trunk/Source/WebCore/ChangeLog 2011-10-05 21:01:17 UTC (rev 96746) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 21:15:10 UTC (rev 96747) @@ -1,3 +1,10 @@ +2011-10-05 Alexey Proskuryakov + +32-bit build fix. + +* WebCore.exp.in: In 32-bit, WebCore needs to export both NSSize and CGSize constructors. +In 64-bit, NSSize is just a typedef for CGSize. Also fixed conversion operators, for good measure. + 2011-10-05 Jer Noble WEB_AUDIO does not compile on Leopard 32-bit. Modified: trunk/Source/WebCore/WebCore.exp.in (96746 => 96747) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-05 21:01:17 UTC (rev 96746) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-05 21:15:10 UTC (rev 96747) @@ -859,7 +859,7 @@ __ZN7WebCore7IntRect5uniteERKS0_ __ZN7WebCore7IntRect9intersectERKS0_ __ZN7WebCore7IntRectC1ERKNS_9FloatRectE -__ZN7WebCore7IntSizeC1ERK7_NSSize +__ZN7WebCore7IntSizeC1ERK6CGSize __ZN7WebCore7TextRun19allowsRoundingHacksEv __ZN7WebCore7TextRun21s_allowsRoundingHacksE __ZN7WebCore7TextRun22setAllowsRoundingHacksEb @@ -1346,7 +1346,7 @@ __ZNK7WebCore7IntRect8containsERKS0_ __ZNK7WebCore7IntRectcv6CGRectEv __ZNK7WebCore7IntRectcv7_NSRectEv -__ZNK7WebCore7IntSizecv7_NSSizeEv +__ZNK7WebCore7IntSizecv6NSRectEv __ZNK7WebCore8Document10renderViewEv __ZNK7WebCore8Document11completeURLERKN3WTF6StringE __ZNK7WebCore8Document13axObjectCacheEv @@ -1963,3 +1963,8 @@ __ZN7WebCore5ColorC1ERKN3WTF6StringE __ZN7WebCore16HTMLInputElement21connectToColorChooserEv #endif + +#if !defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES) +__ZN7WebCore7IntSizeC1ERK7_NSSize +__ZNK7WebCore7IntSizecv7_NSSizeEv +#endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96746] trunk/Tools
Title: [96746] trunk/Tools
Revision 96746
Author aba...@webkit.org
Date 2011-10-05 14:01:17 -0700 (Wed, 05 Oct 2011)
Log Message
Add watchlist entries for abarth
https://bugs.webkit.org/show_bug.cgi?id=69461
Reviewed by David Levin.
I might have gone a bit overboard. We'll see if this is too much spam
for me.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (96745 => 96746)
--- trunk/Tools/ChangeLog 2011-10-05 20:53:43 UTC (rev 96745)
+++ trunk/Tools/ChangeLog 2011-10-05 21:01:17 UTC (rev 96746)
@@ -1,3 +1,15 @@
+2011-10-05 Adam Barth
+
+Add watchlist entries for abarth
+https://bugs.webkit.org/show_bug.cgi?id=69461
+
+Reviewed by David Levin.
+
+I might have gone a bit overboard. We'll see if this is too much spam
+for me.
+
+* Scripts/webkitpy/common/config/watchlist:
+
2011-10-05 Brent Fulgham
[WinCairo] Teach old-run-webkit-tests about wincairo.
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (96745 => 96746)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 20:53:43 UTC (rev 96745)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 21:01:17 UTC (rev 96746)
@@ -17,6 +17,26 @@
"WatchListScript": {
"filename": r"Tools/Scripts/webkitpy/common/watchlist/.*",
},
+"webkitpy": {
+"filename": r"Tools/Scripts/webkitpy/.*",
+},
+"TestFailures": {
+"filename": r"Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/.*",
+},
+"SecurityCritical": {
+"more": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
+"less": r"[Ss]ecurityOrigin(?!\.(h|cpp)",
+"filename": r"XSS|[Ss]ecurity",
+},
+"V8Bindings": {
+"filename": r"Source/WebCore/bindings/v8/.*",
+},
+"BindingsScripts": {
+"filename": r"Source/WebCore/bindings/scripts/.*",
+},
+"FrameLoader": {
+"more": r"FrameLoader\.(cpp|h)",
+},
},
"CC_RULES": {
# Note: All email addresses listed must be registered with bugzilla.
@@ -26,6 +46,7 @@
"ChromiumPublicApi": [ "fi...@chromium.org", ],
"ThreadingFiles|ThreadingUsage": [ "levin+thread...@chromium.org", ],
"WatchListScript": [ "levin+watchl...@chromium.org", ],
+"webkitpy|TestFailures|SecurityCritical|V8Bindings|BindingsScripts|FrameLoader": [ "aba...@webkit.org" ],
},
"MESSAGE_RULES": {
"ChromiumPublicApi": [ "Please wait for approval from fi...@chromium.org before submitting "
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96744] trunk/Tools
Title: [96744] trunk/Tools
Revision 96744
Author bfulg...@webkit.org
Date 2011-10-05 13:36:33 -0700 (Wed, 05 Oct 2011)
Log Message
[WinCairo] Teach old-run-webkit-tests about wincairo.
https://bugs.webkit.org/show_bug.cgi?id=69280
Reviewed by Adam Roben.
* Scripts/old-run-webkit-tests: Handle wincairo case.
(buildPlatformResultHierarchy):
(readSkippedFiles): Ditto
* Scripts/webkitdirs.pm: Deal with wincairo build case.
(determineConfiguration):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (96743 => 96744)
--- trunk/Tools/ChangeLog 2011-10-05 20:28:14 UTC (rev 96743)
+++ trunk/Tools/ChangeLog 2011-10-05 20:36:33 UTC (rev 96744)
@@ -1,3 +1,16 @@
+2011-10-05 Brent Fulgham
+
+[WinCairo] Teach old-run-webkit-tests about wincairo.
+https://bugs.webkit.org/show_bug.cgi?id=69280
+
+Reviewed by Adam Roben.
+
+* Scripts/old-run-webkit-tests: Handle wincairo case.
+(buildPlatformResultHierarchy):
+(readSkippedFiles): Ditto
+* Scripts/webkitdirs.pm: Deal with wincairo build case.
+(determineConfiguration):
+
2011-10-05 Chang Shu
[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
Modified: trunk/Tools/Scripts/old-run-webkit-tests (96743 => 96744)
--- trunk/Tools/Scripts/old-run-webkit-tests 2011-10-05 20:28:14 UTC (rev 96743)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2011-10-05 20:36:33 UTC (rev 96744)
@@ -249,6 +249,8 @@
$platform = "gtk";
} elsif (isWx()) {
$platform = "wx";
+} elsif (isWinCairo()) {
+$platform = "wincairo";
} elsif (isCygwin() || isWindows()) {
if (isWindowsXP()) {
$platform = "win-xp";
@@ -2180,6 +2182,10 @@
for (; $i < @platformList; $i++) {
push @platforms, $platformList[$i];
}
+
+if ($platform eq "wincairo") {
+@platforms = $platform;
+}
} elsif ($platform =~ /^qt-/) {
push @platforms, $platform;
push @platforms, "qt";
@@ -2470,7 +2476,6 @@
# cross-platform issues, the Windows and Qt ports use the Mac skipped list
# additionally to their own to avoid maintaining separate lists.
push(@skippedFileDirectories, catdir($platformBaseDirectory, "wk2")) if ($platform eq "win-wk2" || $platform eq "qt-wk2" || $platform eq "mac-wk2");
-
foreach my $level (@skippedFileDirectories) {
if (open SKIPPED, "<", "$level/Skipped") {
if ($verbose) {
Modified: trunk/Tools/Scripts/webkitdirs.pm (96743 => 96744)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-10-05 20:28:14 UTC (rev 96743)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-10-05 20:36:33 UTC (rev 96744)
@@ -232,7 +232,9 @@
}
if ($configuration && isWinCairo()) {
-$configuration .= "_Cairo_CFLite";
+unless ($configuration =~ /_Cairo_CFLite$/) {
+$configuration .= "_Cairo_CFLite";
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96743] trunk/Source/WebKit2
Title: [96743] trunk/Source/WebKit2
Revision 96743
Author caio.olive...@openbossa.org
Date 2011-10-05 13:28:14 -0700 (Wed, 05 Oct 2011)
Log Message
[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
https://bugs.webkit.org/show_bug.cgi?id=69274
Reviewed by Andreas Kling.
Use currently existing QtWidgets to provide an implementation of
window.alert(), window.confirm() and window.prompt().
* Shared/WebString.h:
(WebKit::WebString::createNull):
(WebKit::WebString::WebString):
Add a way to create a Null WebString. RunJavaScriptPrompt will differentiate
between empty and null strings.
* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::enableMouseEvents):
(QDesktopWebViewPrivate::disableMouseEvents):
Create helper functions to enable and disable mouse events. This is useful for
disabling mouse events in the WebView when we show QtWidget dialogs to avoid
unwanted interaction with the page.
(QDesktopWebViewPrivate::runJavaScriptAlert):
(QDesktopWebViewPrivate::runJavaScriptConfirm):
(QDesktopWebViewPrivate::runJavaScriptPrompt):
(QDesktopWebView::init):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(createNullWKString):
(qt_wk_runJavaScriptPrompt):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::runJavaScriptAlert):
(WebKit::TouchViewInterface::runJavaScriptConfirm):
(WebKit::TouchViewInterface::runJavaScriptPrompt):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebString.h
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qdesktopwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.cpp
trunk/Source/WebKit2/UIProcess/qt/TouchViewInterface.h
trunk/Source/WebKit2/UIProcess/qt/ViewInterface.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (96742 => 96743)
--- trunk/Source/WebKit2/ChangeLog 2011-10-05 20:25:11 UTC (rev 96742)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-05 20:28:14 UTC (rev 96743)
@@ -1,3 +1,46 @@
+2011-10-05 Caio Marcelo de Oliveira Filho
+
+[Qt] [WK2] Support JS alert/confirm/prompt in QDesktopWebView
+https://bugs.webkit.org/show_bug.cgi?id=69274
+
+Reviewed by Andreas Kling.
+
+Use currently existing QtWidgets to provide an implementation of
+window.alert(), window.confirm() and window.prompt().
+
+* Shared/WebString.h:
+(WebKit::WebString::createNull):
+(WebKit::WebString::WebString):
+Add a way to create a Null WebString. RunJavaScriptPrompt will differentiate
+between empty and null strings.
+
+* UIProcess/API/qt/qdesktopwebview.cpp:
+(QDesktopWebViewPrivate::enableMouseEvents):
+(QDesktopWebViewPrivate::disableMouseEvents):
+Create helper functions to enable and disable mouse events. This is useful for
+disabling mouse events in the WebView when we show QtWidget dialogs to avoid
+unwanted interaction with the page.
+
+(QDesktopWebViewPrivate::runJavaScriptAlert):
+(QDesktopWebViewPrivate::runJavaScriptConfirm):
+(QDesktopWebViewPrivate::runJavaScriptPrompt):
+(QDesktopWebView::init):
+* UIProcess/API/qt/qdesktopwebview_p.h:
+* UIProcess/qt/ClientImpl.cpp:
+(qt_wk_runJavaScriptAlert):
+(qt_wk_runJavaScriptConfirm):
+(createNullWKString):
+(qt_wk_runJavaScriptPrompt):
+* UIProcess/qt/ClientImpl.h:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::init):
+* UIProcess/qt/TouchViewInterface.cpp:
+(WebKit::TouchViewInterface::runJavaScriptAlert):
+(WebKit::TouchViewInterface::runJavaScriptConfirm):
+(WebKit::TouchViewInterface::runJavaScriptPrompt):
+* UIProcess/qt/TouchViewInterface.h:
+* UIProcess/qt/ViewInterface.h:
+
2011-10-05 Chang Shu
[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
Modified: trunk/Source/WebKit2/Shared/WebString.h (96742 => 96743)
--- trunk/Source/WebKit2/Shared/WebString.h 2011-10-05 20:25:11 UTC (rev 96742)
+++ trunk/Source/WebKit2/Shared/WebString.h 2011-10-05 20:28:14 UTC (rev 96743)
@@ -40,6 +40,11 @@
public:
static const Type APIType = TypeString;
+static PassRefPtr createNull()
+{
+return adoptRef(new WebString());
+}
+
static PassRefPtr create(const String& string)
{
return adoptRef(new WebString(string));
@@ -91,6 +96,11 @@
JSStringRef createJSString() const { return JSStringCreateWithCharacters(m_string.characters(), m_string.length()); }
p
[webkit-changes] [96741] trunk/Source/JavaScriptCore
Title: [96741] trunk/Source/_javascript_Core
Revision 96741
Author commit-qu...@webkit.org
Date 2011-10-05 13:01:32 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed, rolling out r96733.
http://trac.webkit.org/changeset/96733
https://bugs.webkit.org/show_bug.cgi?id=69454
Broke GCC for some reason (Requested by andersca on #webkit).
Patch by Sheriff Bot on 2011-10-05
* wtf/ListHashSet.h:
(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
(WTF::ListHashSetReverseIterator::get):
(WTF::ListHashSetReverseIterator::operator*):
(WTF::ListHashSetReverseIterator::operator->):
(WTF::ListHashSetReverseIterator::operator++):
(WTF::ListHashSetReverseIterator::operator--):
(WTF::ListHashSetReverseIterator::operator==):
(WTF::ListHashSetReverseIterator::operator!=):
(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
(WTF::ListHashSetReverseIterator::node):
(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
(WTF::ListHashSetConstReverseIterator::get):
(WTF::ListHashSetConstReverseIterator::operator*):
(WTF::ListHashSetConstReverseIterator::operator->):
(WTF::ListHashSetConstReverseIterator::operator++):
(WTF::ListHashSetConstReverseIterator::operator--):
(WTF::ListHashSetConstReverseIterator::operator==):
(WTF::ListHashSetConstReverseIterator::operator!=):
(WTF::ListHashSetConstReverseIterator::node):
(WTFrbegin):
(WTFrend):
(WTFmakeReverseIterator):
(WTFmakeConstReverseIterator):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/ListHashSet.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96740 => 96741)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 19:46:39 UTC (rev 96740)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 20:01:32 UTC (rev 96741)
@@ -1,3 +1,36 @@
+2011-10-05 Sheriff Bot
+
+Unreviewed, rolling out r96733.
+http://trac.webkit.org/changeset/96733
+https://bugs.webkit.org/show_bug.cgi?id=69454
+
+Broke GCC for some reason (Requested by andersca on #webkit).
+
+* wtf/ListHashSet.h:
+(WTF::ListHashSetReverseIterator::ListHashSetReverseIterator):
+(WTF::ListHashSetReverseIterator::get):
+(WTF::ListHashSetReverseIterator::operator*):
+(WTF::ListHashSetReverseIterator::operator->):
+(WTF::ListHashSetReverseIterator::operator++):
+(WTF::ListHashSetReverseIterator::operator--):
+(WTF::ListHashSetReverseIterator::operator==):
+(WTF::ListHashSetReverseIterator::operator!=):
+(WTF::ListHashSetReverseIterator::operator const_reverse_iterator):
+(WTF::ListHashSetReverseIterator::node):
+(WTF::ListHashSetConstReverseIterator::ListHashSetConstReverseIterator):
+(WTF::ListHashSetConstReverseIterator::get):
+(WTF::ListHashSetConstReverseIterator::operator*):
+(WTF::ListHashSetConstReverseIterator::operator->):
+(WTF::ListHashSetConstReverseIterator::operator++):
+(WTF::ListHashSetConstReverseIterator::operator--):
+(WTF::ListHashSetConstReverseIterator::operator==):
+(WTF::ListHashSetConstReverseIterator::operator!=):
+(WTF::ListHashSetConstReverseIterator::node):
+(WTFrbegin):
+(WTFrend):
+(WTFmakeReverseIterator):
+(WTFmakeConstReverseIterator):
+
2011-10-04 Oliver Hunt
Add rudimentary filtering to write barriers
Modified: trunk/Source/_javascript_Core/wtf/ListHashSet.h (96740 => 96741)
--- trunk/Source/_javascript_Core/wtf/ListHashSet.h 2011-10-05 19:46:39 UTC (rev 96740)
+++ trunk/Source/_javascript_Core/wtf/ListHashSet.h 2011-10-05 20:01:32 UTC (rev 96741)
@@ -27,7 +27,6 @@
#include "OwnPtr.h"
#include "PassOwnPtr.h"
#include "StdLibExtras.h"
-#include
namespace WTF {
@@ -50,6 +49,8 @@
template class ListHashSetIterator;
template class ListHashSetConstIterator;
+template class ListHashSetReverseIterator;
+template class ListHashSetConstReverseIterator;
template struct ListHashSetNode;
template struct ListHashSetNodeAllocator;
@@ -77,8 +78,9 @@
typedef ListHashSetConstIterator const_iterator;
friend class ListHashSetConstIterator;
-typedef std::reverse_iterator reverse_iterator;
-typedef std::reverse_iterator const_reverse_iterator;
+typedef ListHashSetReverseIterator reverse_iterator;
+typedef ListHashSetConstReverseIterator const_reverse_iterator;
+friend class ListHashSetConstReverseIterator;
ListHashSet();
ListHashSet(const ListHashSet&);
@@ -138,6 +140,8 @@
iterator makeIterator(Node*);
const_iterator makeConstIterator(Node*) const;
+reverse_iterator makeReverseIterator(Node*);
+const_reverse_iterator makeConstReverseIterator(Node*) const;
friend void deleteAllValues<>(const ListHashSet&);
@@ -267,16 +271,10 @@
typedef ValueType
[webkit-changes] [96740] trunk
Title: [96740] trunk Revision 96740 Author commit-qu...@webkit.org Date 2011-10-05 12:46:39 -0700 (Wed, 05 Oct 2011) Log Message [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController https://bugs.webkit.org/show_bug.cgi?id=68924 Source/WebKit2: Implemented WKBundlePage private APIs to support the above functions. Patch by Chang Shu on 2011-10-05 Reviewed by Darin Adler. * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetComposition): (WKBundlePageHasComposition): (WKBundlePageConfirmComposition): (WKBundlePageConfirmCompositionWithText): * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::setCompositionForTesting): (WebKit::WebPage::hasCompositionForTesting): (WebKit::WebPage::confirmCompositionForTesting): * WebProcess/WebPage/WebPage.h: Tools: Added TextInputController files and JS interfaces for the above functions. Patch by Chang Shu on 2011-10-05 Reviewed by Darin Adler. * WebKitTestRunner/DerivedSources.make: * WebKitTestRunner/DerivedSources.pro: * WebKitTestRunner/GNUmakefile.am: * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: (WTR::InjectedBundle::textInputController): * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::didClearWindowForFrame): * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added. (WTR::TextInputController::create): (WTR::TextInputController::TextInputController): (WTR::TextInputController::~TextInputController): (WTR::TextInputController::wrapperClass): (WTR::TextInputController::makeWindowObject): (WTR::TextInputController::setMarkedText): (WTR::TextInputController::hasMarkedText): (WTR::TextInputController::unmarkText): (WTR::TextInputController::insertText): * WebKitTestRunner/InjectedBundle/TextInputController.h: Added. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: * WebKitTestRunner/win/InjectedBundle.vcproj: LayoutTests: Unskip passed tests. Patch by Chang Shu on 2011-10-05 Reviewed by Darin Adler. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/DerivedSources.make trunk/Tools/WebKitTestRunner/DerivedSources.pro trunk/Tools/WebKitTestRunner/GNUmakefile.am trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj trunk/Tools/WebKitTestRunner/win/InjectedBundle.vcproj Added Paths trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/TextInputController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/TextInputController.h Diff Modified: trunk/LayoutTests/ChangeLog (96739 => 96740) --- trunk/LayoutTests/ChangeLog 2011-10-05 19:22:21 UTC (rev 96739) +++ trunk/LayoutTests/ChangeLog 2011-10-05 19:46:39 UTC (rev 96740) @@ -1,5 +1,16 @@ 2011-10-05 Chang Shu +[WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController +https://bugs.webkit.org/show_bug.cgi?id=68924 + +Unskip passed tests. + +Reviewed by Darin Adler. + +* platform/wk2/Skipped: + +2011-10-05 Chang Shu + [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport https://bugs.webkit.org/show_bug.cgi?id=69365 Modified: trunk/LayoutTests/platform/wk2/Skipped (96739 => 96740) --- trunk/LayoutTests/platform/wk2/Skipped 2011-10-05 19:22:21 UTC (rev 96739) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-10-05 19:46:39 UTC (rev 96740) @@ -436,16 +436,12 @@ # WebKitTestRunner needs textInputController # editing/input/setting-input-value-cancel-ime-composition.html -editing/inserting/insert-composition-whitespace.html svg/text/caret-in-svg-text.xhtml -editing/input/ime-composition-clearpreedit.html editing/spelling/spelling-backspace-between-lines.html editing/selection/5825350-1.html editing/selection/5825350-2.html editing/selection/move-left-right.html fast/events/ime-composition-events-001.html -fast/forms/input-maxlength-ime-completed.html -fast/forms/input-maxlength-ime-preedit.html fast/text/international/thai-cursor-position.html platform/mac/editing/
[webkit-changes] [96739] trunk/Source
Title: [96739] trunk/Source Revision 96739 Author a...@apple.com Date 2011-10-05 12:22:21 -0700 (Wed, 05 Oct 2011) Log Message [Mac] Make built-in PDF description localizable https://bugs.webkit.org/show_bug.cgi?id=69442 Reviewed by Dan Bernstein. Source/WebCore: Added strings for plug-in's name and for its supported MIME type. * English.lproj/Localizable.strings: * WebCore.exp.in: * platform/DefaultLocalizationStrategy.cpp: (WebCore::DefaultLocalizationStrategy::builtInPDFPluginName): (WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription): * platform/DefaultLocalizationStrategy.h: * platform/LocalizationStrategy.h: * platform/LocalizedStrings.cpp: (WebCore::builtInPDFPluginName): (WebCore::pdfDocumentTypeDescription): * platform/LocalizedStrings.h: Source/WebKit2: * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: Use a localized string instead of a literal one. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/Localizable.strings trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h trunk/Source/WebCore/platform/LocalizationStrategy.h trunk/Source/WebCore/platform/LocalizedStrings.cpp trunk/Source/WebCore/platform/LocalizedStrings.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (96738 => 96739) --- trunk/Source/WebCore/ChangeLog 2011-10-05 19:07:18 UTC (rev 96738) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 19:22:21 UTC (rev 96739) @@ -1,3 +1,24 @@ +2011-10-05 Alexey Proskuryakov + +[Mac] Make built-in PDF description localizable +https://bugs.webkit.org/show_bug.cgi?id=69442 + +Reviewed by Dan Bernstein. + +Added strings for plug-in's name and for its supported MIME type. + +* English.lproj/Localizable.strings: +* WebCore.exp.in: +* platform/DefaultLocalizationStrategy.cpp: +(WebCore::DefaultLocalizationStrategy::builtInPDFPluginName): +(WebCore::DefaultLocalizationStrategy::pdfDocumentTypeDescription): +* platform/DefaultLocalizationStrategy.h: +* platform/LocalizationStrategy.h: +* platform/LocalizedStrings.cpp: +(WebCore::builtInPDFPluginName): +(WebCore::pdfDocumentTypeDescription): +* platform/LocalizedStrings.h: + 2011-10-05 David Levin Attempt to fix the bindings test (broken by r96727). Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (96738 => 96739) --- trunk/Source/WebCore/English.lproj/Localizable.strings 2011-10-05 19:07:18 UTC (rev 96738) +++ trunk/Source/WebCore/English.lproj/Localizable.strings 2011-10-05 19:22:21 UTC (rev 96739) @@ -25,6 +25,12 @@ / * L a b e l t o d e s c r i b e t h e n u m b e r o f f i l e s s e l e c t e d i n a f i l e u p l o a d c o n t r o l t h a t a l l o w s m u l t i p l e f i l e s * / " % d f i l e s " = " % d f i l e s " ; + / * P s e u d o p l u g - i n n a m e , v i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / + " W e b K i t b u i l t - i n P D F " = " W e b K i t b u i l t - i n P D F " ; + + / * D e s c r i p t i o n o f t h e ( o n l y ) t y p e s u p p o r t e d b y P D F p s e u d o p l u g - i n . V i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / + " P o r t a b l e D o c u m e n t F o r m a t " = " P o r t a b l e D o c u m e n t F o r m a t " ; + / * M e n u i t e m t i t l e f o r K E Y G E N p o p - u p m e n u * / " 1 0 2 4 ( M e d i u m G r a d e ) " = " 1 0 2 4 ( M e d i u m G r a d e ) " ; Modified: trunk/Source/WebCore/WebCore.exp.in (96738 => 96739) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-05 19:07:18 UTC (rev 96738) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-05 19:22:21 UTC (rev 96739) @@ -572,6 +572,7 @@ __ZN7WebCore20UserGestureIndicator7s_stateE __ZN7WebCore20UserGestureIndicatorC1ENS_26ProcessingUserGestureStateE __ZN7WebCore20UserGestureIndicatorD1Ev +__ZN7WebCore20builtInPDFPluginNameEv __ZN7WebCore20makeRGBA32FromFloatsE __ZN7WebCore20protocolIsJavaScriptERKN3WTF6StringE __ZN7WebCore21BackForwardController11itemAtIndexEi @@ -639,6 +640,7 @@ __ZN7WebCore26UserTypingGestureIndicator28focusedElementAtGestureStartEv __ZN7WebCore26contextMenuItemTagFontMenuEv __ZN7WebCore26contextMenuItemTagOpenLinkEv +__ZN7WebCore26pdfDocumentTypeDescriptionEv __ZN7WebCore26stopObservingCookieChangesEv __ZN7WebCore26usesTestModeFocusRingColorEv __ZN7WebCore27AuthenticationChallengeBaseC2Ev Modified: trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp (96738 => 96739) --- trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp 2011-10-05 19:07:18 UTC (
[webkit-changes] [96738] trunk
Title: [96738] trunk
Revision 96738
Author oli...@apple.com
Date 2011-10-05 12:07:18 -0700 (Wed, 05 Oct 2011)
Log Message
Add rudimentary filtering to write barriers
https://bugs.webkit.org/show_bug.cgi?id=69392
Reviewed by Filip Pizlo.
../../../../Volumes/Data/git/WebKit/OpenSource/Source/_javascript_Core:
Add approximate filtering for write barriers based on the
target's mark bit. Also add some macros to support dumping
GC phase timings.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::markCellCard):
* heap/Heap.cpp:
(JSC::GCTimer::GCTimerScope::GCTimerScope):
(JSC::GCTimer::GCTimerScope::~GCTimerScope):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
Add phase timing information.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::offsetOfMarks):
(JSC::MarkedBlock::gatherDirtyCells):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitWriteBarrier):
../../../../Volumes/Data/git/WebKit/OpenSource/Tools:
When we're recording gc phase times Heap.o picks up
some exit time destructors, so we'll just ignore Heap.o
in this check.
* Scripts/check-for-exit-time-destructors:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/MarkedBlock.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/check-for-exit-time-destructors
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96737 => 96738)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 19:04:42 UTC (rev 96737)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 19:07:18 UTC (rev 96738)
@@ -1,3 +1,28 @@
+2011-10-04 Oliver Hunt
+
+Add rudimentary filtering to write barriers
+https://bugs.webkit.org/show_bug.cgi?id=69392
+
+Reviewed by Filip Pizlo.
+
+Add approximate filtering for write barriers based on the
+target's mark bit. Also add some macros to support dumping
+GC phase timings.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::markCellCard):
+* heap/Heap.cpp:
+(JSC::GCTimer::GCTimerScope::GCTimerScope):
+(JSC::GCTimer::GCTimerScope::~GCTimerScope):
+(JSC::Heap::markRoots):
+(JSC::Heap::collect):
+ Add phase timing information.
+* heap/MarkedBlock.h:
+(JSC::MarkedBlock::offsetOfMarks):
+(JSC::MarkedBlock::gatherDirtyCells):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emitWriteBarrier):
+
2011-10-05 Anders Carlsson
Use std::reverse_iterator for ListHashSet reverse iterators
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (96737 => 96738)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp 2011-10-05 19:04:42 UTC (rev 96737)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp 2011-10-05 19:07:18 UTC (rev 96738)
@@ -219,9 +219,15 @@
jit.move(owner, scratch1);
jit.andPtr(TrustedImm32(static_cast(MarkedBlock::blockMask)), scratch1);
jit.move(owner, scratch2);
+// consume additional 8 bits as we're using an approximate filter
+jit.rshift32(TrustedImm32(MarkedBlock::atomShift + 8), scratch2);
+jit.andPtr(TrustedImm32(MarkedBlock::atomMask >> 8), scratch2);
+MacroAssembler::Jump filter = jit.branchTest8(MacroAssembler::Zero, MacroAssembler::BaseIndex(scratch1, scratch2, MacroAssembler::TimesOne, MarkedBlock::offsetOfMarks()));
+jit.move(owner, scratch2);
jit.rshift32(TrustedImm32(MarkedBlock::cardShift), scratch2);
jit.andPtr(TrustedImm32(MarkedBlock::cardMask), scratch2);
jit.store8(TrustedImm32(1), MacroAssembler::BaseIndex(scratch1, scratch2, MacroAssembler::TimesOne, MarkedBlock::offsetOfCards()));
+filter.link(&jit);
#endif
}
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (96737 => 96738)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2011-10-05 19:04:42 UTC (rev 96737)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2011-10-05 19:07:18 UTC (rev 96738)
@@ -44,6 +44,58 @@
static const size_t largeHeapSize = 16 * 1024 * 1024;
static const size_t smallHeapSize = 512 * 1024;
+#if ENABLE(GC_LOGGING)
+
+struct GCTimer {
+GCTimer(const char* name)
+: m_time(0)
+, m_min(1)
+, m_max(0)
+, m_count(0)
+, m_name(name)
+{
+}
+~GCTimer()
+{
+printf("%s: %.2lfms (avg. %.2lf, min. %.2lf, max. %.2lf)\n", m_name, m_time * 1000, m_time * 1000 / m_count, m_min*1000, m_max*1000);
+}
+double m_time;
+double m_min;
+double m_max;
+size_t m_count;
+const char* m_name;
+};
+
+struct GCTimerScope {
+GCTimerScope(GCTimer* timer)
+: m_timer(timer)
+, m_start(WTF::currentTime())
+{
+}
+~GCTimerScope()
+{
+double delta = WTF::currentTime() - m_start;
+if (delta < m_timer->m_min)
+m_timer->m_min = delta;
+if (
[webkit-changes] [96737] trunk/Source/WebCore
Title: [96737] trunk/Source/WebCore
Revision 96737
Author le...@chromium.org
Date 2011-10-05 12:04:42 -0700 (Wed, 05 Oct 2011)
Log Message
Attempt to fix the bindings test (broken by r96727).
Reviewed by Adam Barth.
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96736 => 96737)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 18:46:10 UTC (rev 96736)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 19:04:42 UTC (rev 96737)
@@ -1,3 +1,17 @@
+2011-10-05 David Levin
+
+Attempt to fix the bindings test (broken by r96727).
+Reviewed by Adam Barth.
+
+* bindings/scripts/test/V8/V8TestInterface.cpp:
+(WebCore::ConfigureV8TestInterfaceTemplate):
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
+(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::ConfigureV8TestObjTemplate):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
+
2011-10-05 James Robinson
[chromium] Hook WebCompositor interface for input events up to the compositor proper
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp (96736 => 96737)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-10-05 18:46:10 UTC (rev 96736)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp 2011-10-05 19:04:42 UTC (rev 96737)
@@ -77,7 +77,8 @@
{
desc->ReadOnlyPrototype();
-v8::Local defaultSignature = configureTemplate(desc, "TestInterface", v8::Persistent(), V8TestInterface::internalFieldCount,
+v8::Local defaultSignature;
+defaultSignature = configureTemplate(desc, "TestInterface", v8::Persistent(), V8TestInterface::internalFieldCount,
0, 0,
0, 0);
UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp (96736 => 96737)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-10-05 18:46:10 UTC (rev 96736)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp 2011-10-05 19:04:42 UTC (rev 96737)
@@ -59,7 +59,8 @@
{
desc->ReadOnlyPrototype();
-v8::Local defaultSignature = configureTemplate(desc, "TestMediaQueryListListener", v8::Persistent(), V8TestMediaQueryListListener::internalFieldCount,
+v8::Local defaultSignature;
+defaultSignature = configureTemplate(desc, "TestMediaQueryListListener", v8::Persistent(), V8TestMediaQueryListListener::internalFieldCount,
0, 0,
TestMediaQueryListListenerCallbacks, WTF_ARRAY_LENGTH(TestMediaQueryListListenerCallbacks));
UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (96736 => 96737)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-05 18:46:10 UTC (rev 96736)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-05 19:04:42 UTC (rev 96737)
@@ -1406,7 +1406,8 @@
{
desc->ReadOnlyPrototype();
-v8::Local defaultSignature = configureTemplate(desc, "TestObj", v8::Persistent(), V8TestObj::internalFieldCount,
+v8::Local defaultSignature;
+defaultSignature = configureTemplate(desc, "TestObj", v8::Persistent(), V8TestObj::internalFieldCount,
TestObjAttrs, WTF_ARRAY_LENGTH(TestObjAttrs),
TestObjCallbacks, WTF_ARRAY_LENGTH(TestObjCallbacks));
UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp (96736 => 96737)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-10-05 18:46:10 UTC (rev 96736)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2011-10-05 19:04:42 UTC (rev 96737)
@@ -46,7 +46,8 @@
{
desc->ReadOnlyPrototype();
-v8::Local defaultSignature = configureTemplate(desc, "TestSerializedScriptValueInterface", v8::Persistent
[webkit-changes] [96736] trunk/Source
Title: [96736] trunk/Source Revision 96736 Author jam...@google.com Date 2011-10-05 11:46:10 -0700 (Wed, 05 Oct 2011) Log Message [chromium] Hook WebCompositor interface for input events up to the compositor proper https://bugs.webkit.org/show_bug.cgi?id=69394 Reviewed by Darin Fisher. Source/WebCore: This wires up WebCompositorImpl to the compositor itself so we can handle input events as scrolls on the compositor thread, although it doesn't actually wire up any input events to actual scrolling. The way this works: - CCThreadProxy owns an adapter that implements the CCScrollController interface - CCThreadProxy owns a CCInputHandler, which is implemented by WebKit::WebCompositorImpl, that has a pointer to the adapter - CCLayerTreeHost has an identifier (an int) for its WebKit::WebCompositorImpl that's initialized in initializeLayerRenderer. This identifier is exposed to its owner (WebKit::WebViewImpl) so the embedder can wire up the threading logic behind the scenes. This is just plumbing, no change in behavior. * WebCore.gypi: * platform/graphics/chromium/cc/CCInputHandler.h: Added. (WebCore::CCInputHandler::~CCInputHandler): (WebCore::CCInputHandler::CCInputHandler): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::CCLayerTreeHost): (WebCore::CCLayerTreeHost::initialize): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (WebCore::CCLayerTreeHost::compositorIdentifier): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::scrollRootLayer): * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: * platform/graphics/chromium/cc/CCProxy.h: * platform/graphics/chromium/cc/CCScrollController.h: Added. (WebCore::CCScrollController::CCScrollController): (WebCore::CCScrollController::~CCScrollController): * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: (WebCore::CCSingleThreadProxy::CCSingleThreadProxy): * platform/graphics/chromium/cc/CCSingleThreadProxy.h: (WebCore::CCSingleThreadProxy::compositorIdentifier): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxyScrollControllerAdapter::create): (WebCore::CCThreadProxyScrollControllerAdapter::~CCThreadProxyScrollControllerAdapter): (WebCore::CCThreadProxyScrollControllerAdapter::scrollRootLayer): (WebCore::CCThreadProxyScrollControllerAdapter::CCThreadProxyScrollControllerAdapter): (WebCore::CCThreadProxy::CCThreadProxy): (WebCore::CCThreadProxy::initializeLayerRenderer): (WebCore::CCThreadProxy::compositorIdentifier): (WebCore::CCThreadProxy::beginFrameAndCommit): (WebCore::CCThreadProxy::initializeLayerRendererOnCCThread): (WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread): * platform/graphics/chromium/cc/CCThreadProxy.h: Source/WebKit/chromium: This teaches WebCompositorImpl about WebCore::CCInputHandler, which WebCompositorImpl implements, and CCScrollController, which WebCompositorImpl will use in the future to do actual scrolling. One thing that is a bit unusual here is WebCore::CCInputHandler::create() which is defined in WebCompositorImpl.cpp. This is because we need a WebKit object (WebKit::WebCompositorImpl) to be owned by a WebCore object (WebCore::CCThreadProxy). The WebCore side only needs to know about the interface, CCInputHandler, but the actual implementation has to live in WebKit in order to know about the concrete type. * src/WebCompositorImpl.cpp: (WebCore::CCInputHandler::create): (WebKit::WebCompositor::fromIdentifier): (WebKit::WebCompositorImpl::fromIdentifier): (WebKit::WebCompositorImpl::WebCompositorImpl): (WebKit::WebCompositorImpl::~WebCompositorImpl): (WebKit::WebCompositorImpl::setClient): (WebKit::WebCompositorImpl::handleInputEvent): (WebKit::WebCompositorImpl::identifier): * src/WebCompositorImpl.h: (WebKit::WebCompositorImpl::create): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): * src/WebViewImpl.h: * tests/WebCompositorImplTest.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp trunk/Source/WebKit/chromium/src/WebCompositorImpl.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/src/WebViewImpl.h trunk/Source/WebKit/chromium/tests/WebCompositorImplTest.cpp Added Paths trunk/Source/WebCore/platform/graphics/chromium/cc/CCInputHandler.h trunk/Source/WebCore/platform/
[webkit-changes] [96735] branches/chromium/874
Title: [96735] branches/chromium/874
Revision 96735
Author rn...@webkit.org
Date 2011-10-05 11:36:12 -0700 (Wed, 05 Oct 2011)
Log Message
Merge 96552 - REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.
Test: fast/forms/clone-input-with-dirty-value.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributeProperties):
LayoutTests:
Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.
* fast/forms/clone-input-with-dirty-value-expected.txt: Added.
* fast/forms/clone-input-with-dirty-value.html: Added.
Review URL: http://codereview.chromium.org/8142040
Modified Paths
branches/chromium/874/Source/WebCore/html/HTMLInputElement.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt
branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt (from rev 96552, trunk/LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt) (0 => 96735)
--- branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value-expected.txt 2011-10-05 18:36:12 UTC (rev 96735)
@@ -0,0 +1,4 @@
+This tests cloning an input element with an edited value. The cloned input element should retain the edited value and you should see PASSED blow.
+
+PASSED
+
Copied: branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value.html (from rev 96552, trunk/LayoutTests/fast/forms/clone-input-with-dirty-value.html) (0 => 96735)
--- branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value.html (rev 0)
+++ branches/chromium/874/LayoutTests/fast/forms/clone-input-with-dirty-value.html 2011-10-05 18:36:12 UTC (rev 96735)
@@ -0,0 +1,30 @@
+
+
+
+This tests cloning an input element with an edited value.
+The cloned input element should retain the edited value and you should see PASSED blow.
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var test = document.getElementById('test');
+test.value = 'PASS';
+
+var x = test.offsetLeft; // Force layout
+
+var clone = test.cloneNode(true);
+test.parentNode.appendChild(clone);
+test.value = '';
+
+clone.focus();
+clone.selectionStart = clone.selectionEnd = clone.value.length;
+document.execCommand('InsertText', false, 'ED');
+
+document.getElementById('log').textContent = clone.value;
+
+
+
+
Modified: branches/chromium/874/Source/WebCore/html/HTMLInputElement.cpp (96734 => 96735)
--- branches/chromium/874/Source/WebCore/html/HTMLInputElement.cpp 2011-10-05 18:31:13 UTC (rev 96734)
+++ branches/chromium/874/Source/WebCore/html/HTMLInputElement.cpp 2011-10-05 18:36:12 UTC (rev 96735)
@@ -1027,6 +1027,9 @@
m_isIndeterminate = sourceElement->m_isIndeterminate;
HTMLTextFormControlElement::copyNonAttributeProperties(source);
+
+setFormControlValueMatchesRenderer(false);
+updateInnerTextValue();
}
String HTMLInputElement::value() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96734] branches/chromium/874/Source/WebCore
Title: [96734] branches/chromium/874/Source/WebCore
Revision 96734
Author rn...@webkit.org
Date 2011-10-05 11:31:13 -0700 (Wed, 05 Oct 2011)
Log Message
Merge 96628 - REGRESSION(r94274): setting input.value erroneously triggers focus event
https://bugs.webkit.org/show_bug.cgi?id=69315
Reviewed by Kent Tamura.
Fixed the bug by adding a new flag to setSelection to avoid calling setFocusedNodeIfNeeded
when called by nodeWillBeRemoved and textWillBeReplaced.
Added a manual test. Unfortunately, the test always passes in DRT.
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::textWillBeReplaced):
* editing/FrameSelection.h:
* manual-tests/mutate-unfocused-text-with-selection.html: Added.
Review URL: http://codereview.chromium.org/8133029
Modified Paths
branches/chromium/874/Source/WebCore/editing/FrameSelection.cpp
branches/chromium/874/Source/WebCore/editing/FrameSelection.h
Added Paths
branches/chromium/874/Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html
Diff
Modified: branches/chromium/874/Source/WebCore/editing/FrameSelection.cpp (96733 => 96734)
--- branches/chromium/874/Source/WebCore/editing/FrameSelection.cpp 2011-10-05 18:29:58 UTC (rev 96733)
+++ branches/chromium/874/Source/WebCore/editing/FrameSelection.cpp 2011-10-05 18:31:13 UTC (rev 96734)
@@ -220,7 +220,7 @@
m_selection = s;
setCaretRectNeedsUpdate();
-if (!s.isNone())
+if (!s.isNone() && !(options & DoNotSetFocus))
setFocusedNodeIfNeeded();
updateAppearance();
@@ -326,7 +326,7 @@
clearRenderViewSelection(m_selection.start());
if (clearDOMTreeSelection)
-setSelection(VisibleSelection(), 0);
+setSelection(VisibleSelection(), DoNotSetFocus);
}
enum EndPointType { EndPointIsStart, EndPointIsEnd };
@@ -377,7 +377,7 @@
newSelection.setWithoutValidation(end, start);
}
m_frame->document()->updateLayout();
-setSelection(newSelection, 0);
+setSelection(newSelection, DoNotSetFocus);
return;
}
Modified: branches/chromium/874/Source/WebCore/editing/FrameSelection.h (96733 => 96734)
--- branches/chromium/874/Source/WebCore/editing/FrameSelection.h 2011-10-05 18:29:58 UTC (rev 96733)
+++ branches/chromium/874/Source/WebCore/editing/FrameSelection.h 2011-10-05 18:31:13 UTC (rev 96734)
@@ -115,6 +115,7 @@
CloseTyping = 1 << 1,
ClearTypingStyle = 1 << 2,
SpellCorrectionTriggered = 1 << 3,
+DoNotSetFocus = 1 << 4,
};
typedef unsigned SetSelectionOptions; // Union of values in SetSelectionOption and EUserTriggered
static inline EUserTriggered selectionOptionsToUserTriggered(SetSelectionOptions options)
Copied: branches/chromium/874/Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html (from rev 96628, trunk/Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html) (0 => 96734)
--- branches/chromium/874/Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html (rev 0)
+++ branches/chromium/874/Source/WebCore/manual-tests/mutate-unfocused-text-with-selection.html 2011-10-05 18:31:13 UTC (rev 96734)
@@ -0,0 +1,24 @@
+
+
+
+This tests modifying a text node with selection but without a focus.
+WebKit used to automatically set the focus to the root editable element of this node but it should not.
+You should see 'PASS' below:
+hello
+world
+
+
+var target = document.getElementById('target');
+var focused = document.getElementById('focused');
+focused.focus();
+getSelection().setBaseAndExtent(target.firstChild, 1, target.firstChild, 3);
+
+// The bug doesn't reproduce if this function was ran here or inside load event handler
+setTimeout(function() {
+target.firstChild.data = '';
+alert('activeElement:' + document.activeElement.id); // necessary to reproduce the bug
+}, 50);
+
+
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96733] trunk/Source/JavaScriptCore
Title: [96733] trunk/Source/_javascript_Core
Revision 96733
Author ander...@apple.com
Date 2011-10-05 11:29:58 -0700 (Wed, 05 Oct 2011)
Log Message
Use std::reverse_iterator for ListHashSet reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=69446
Reviewed by Darin Adler.
* wtf/ListHashSet.h:
Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/ListHashSet.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96732 => 96733)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 18:22:53 UTC (rev 96732)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 18:29:58 UTC (rev 96733)
@@ -1,3 +1,14 @@
+2011-10-05 Anders Carlsson
+
+Use std::reverse_iterator for ListHashSet reverse iterators
+https://bugs.webkit.org/show_bug.cgi?id=69446
+
+Reviewed by Darin Adler.
+
+* wtf/ListHashSet.h:
+Use the std::reverse_iterator iterator adaptor for the ListHashSet reverse iterators
+and get rid of the ListHashSetReverseIterator and ListHashSetConstReverseIterator classes.
+
2011-10-04 Gavin Barraclough
Make Object.prototype getter/setter methods match ES5 behaviour
Modified: trunk/Source/_javascript_Core/wtf/ListHashSet.h (96732 => 96733)
--- trunk/Source/_javascript_Core/wtf/ListHashSet.h 2011-10-05 18:22:53 UTC (rev 96732)
+++ trunk/Source/_javascript_Core/wtf/ListHashSet.h 2011-10-05 18:29:58 UTC (rev 96733)
@@ -27,6 +27,7 @@
#include "OwnPtr.h"
#include "PassOwnPtr.h"
#include "StdLibExtras.h"
+#include
namespace WTF {
@@ -49,8 +50,6 @@
template class ListHashSetIterator;
template class ListHashSetConstIterator;
-template class ListHashSetReverseIterator;
-template class ListHashSetConstReverseIterator;
template struct ListHashSetNode;
template struct ListHashSetNodeAllocator;
@@ -78,9 +77,8 @@
typedef ListHashSetConstIterator const_iterator;
friend class ListHashSetConstIterator;
-typedef ListHashSetReverseIterator reverse_iterator;
-typedef ListHashSetConstReverseIterator const_reverse_iterator;
-friend class ListHashSetConstReverseIterator;
+typedef std::reverse_iterator reverse_iterator;
+typedef std::reverse_iterator const_reverse_iterator;
ListHashSet();
ListHashSet(const ListHashSet&);
@@ -140,8 +138,6 @@
iterator makeIterator(Node*);
const_iterator makeConstIterator(Node*) const;
-reverse_iterator makeReverseIterator(Node*);
-const_reverse_iterator makeConstReverseIterator(Node*) const;
friend void deleteAllValues<>(const ListHashSet&);
@@ -271,10 +267,16 @@
typedef ValueType* PointerType;
friend class ListHashSet;
-
+
ListHashSetIterator(const ListHashSetType* set, Node* position) : m_iterator(set, position) { }
public:
+typedef std::bidirectional_iterator_tag iterator_category;
+typedef ValueType value_type;
+typedef ReferenceType reference;
+typedef PointerType pointer;
+typedef int difference_type;
+
ListHashSetIterator() { }
// default copy, assignment and destructor are OK
@@ -323,6 +325,12 @@
}
public:
+typedef std::bidirectional_iterator_tag iterator_category;
+typedef ValueType value_type;
+typedef ReferenceType reference;
+typedef PointerType pointer;
+typedef int difference_type;
+
ListHashSetConstIterator()
{
}
@@ -372,118 +380,6 @@
Node* m_position;
};
-template class ListHashSetReverseIterator {
-private:
-typedef ListHashSet ListHashSetType;
-typedef ListHashSetReverseIterator reverse_iterator;
-typedef ListHashSetConstIterator const_reverse_iterator;
-typedef ListHashSetNode Node;
-typedef ValueArg ValueType;
-typedef ValueType& ReferenceType;
-typedef ValueType* PointerType;
-
-friend class ListHashSet;
-
-ListHashSetReverseIterator(const ListHashSetType* set, Node* position) : m_iterator(set, position) { }
-
-public:
-ListHashSetReverseIterator() { }
-
-// default copy, assignment and destructor are OK
-
-PointerType get() const { return const_cast(m_iterator.get()); }
-ReferenceType operator*() const { return *get(); }
-PointerType operator->() const { return get(); }
-
-reverse_iterator& operator++() { ++m_iterator; return *this; }
-
-// postfix ++ intentionally omitted
-
-reverse_iterator& operator--() { --m_iterator; return *this; }
-
-// postfix -- intentionally omitted
-
-// Comparison.
-bool operator==(const reverse_iterator& other) co
[webkit-changes] [96732] trunk/Source/WebCore
Title: [96732] trunk/Source/WebCore
Revision 96732
Author commit-qu...@webkit.org
Date 2011-10-05 11:22:53 -0700 (Wed, 05 Oct 2011)
Log Message
Shrink OutlineValue.
https://bugs.webkit.org/show_bug.cgi?id=69436
Patch by Andreas Kling on 2011-10-05
Reviewed by Darin Adler.
Move OutlineValue::m_isAuto up into the base class (BorderValue.)
This shrinks OutlineValue by 32 bit, which in turn shrinks
StyleBackgroundData by one CPU word.
This reduces memory consumption by 250 kB (on 64-bit) when loading
the full HTML5 spec.
* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::OutlineValue):
(WebCore::OutlineValue::isAuto):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/BorderValue.h
trunk/Source/WebCore/rendering/style/OutlineValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96731 => 96732)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 18:21:07 UTC (rev 96731)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 18:22:53 UTC (rev 96732)
@@ -1,3 +1,23 @@
+2011-10-05 Andreas Kling
+
+Shrink OutlineValue.
+https://bugs.webkit.org/show_bug.cgi?id=69436
+
+Reviewed by Darin Adler.
+
+Move OutlineValue::m_isAuto up into the base class (BorderValue.)
+This shrinks OutlineValue by 32 bit, which in turn shrinks
+StyleBackgroundData by one CPU word.
+
+This reduces memory consumption by 250 kB (on 64-bit) when loading
+the full HTML5 spec.
+
+* rendering/style/BorderValue.h:
+(WebCore::BorderValue::BorderValue):
+* rendering/style/OutlineValue.h:
+(WebCore::OutlineValue::OutlineValue):
+(WebCore::OutlineValue::isAuto):
+
2011-10-05 Chang Shu
[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
Modified: trunk/Source/WebCore/rendering/style/BorderValue.h (96731 => 96732)
--- trunk/Source/WebCore/rendering/style/BorderValue.h 2011-10-05 18:21:07 UTC (rev 96731)
+++ trunk/Source/WebCore/rendering/style/BorderValue.h 2011-10-05 18:22:53 UTC (rev 96732)
@@ -36,6 +36,7 @@
BorderValue()
: m_width(3)
, m_style(BNONE)
+, m_isAuto(AUTO_OFF)
{
}
@@ -71,7 +72,10 @@
protected:
Color m_color;
unsigned m_width : 12;
-unsigned m_style : 4; // EBorderStyle
+unsigned m_style : 4; // EBorderStyle
+
+// This is only used by OutlineValue but moved here to keep the bits packed.
+unsigned m_isAuto : 1; // OutlineIsAuto
};
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/style/OutlineValue.h (96731 => 96732)
--- trunk/Source/WebCore/rendering/style/OutlineValue.h 2011-10-05 18:21:07 UTC (rev 96731)
+++ trunk/Source/WebCore/rendering/style/OutlineValue.h 2011-10-05 18:22:53 UTC (rev 96732)
@@ -34,7 +34,6 @@
public:
OutlineValue()
: m_offset(0)
-, m_isAuto(AUTO_OFF)
{
}
@@ -49,11 +48,10 @@
}
int offset() const { return m_offset; }
-OutlineIsAuto isAuto() const { return m_isAuto; }
+OutlineIsAuto isAuto() const { return static_cast(m_isAuto); }
private:
int m_offset;
-OutlineIsAuto m_isAuto;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96731] trunk
Title: [96731] trunk Revision 96731 Author commit-qu...@webkit.org Date 2011-10-05 11:21:07 -0700 (Wed, 05 Oct 2011) Log Message [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport https://bugs.webkit.org/show_bug.cgi?id=69365 Patch by Chang Shu on 2011-10-05 Reviewed by Darin Adler. Source/WebCore: Expose computeViewportAttributes for mac build. * WebCore.exp.in: Source/WebKit2: Implement retrieving viewport configuration as text in WebProcess. * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageViewportConfigurationAsText): * WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::viewportConfigurationAsText): * WebProcess/WebPage/WebPage.h: Tools: Added js API in WTR LayoutTestController. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::dumpConfigurationForViewport): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: LayoutTests: Unskip passed tests on Qt. The tests work on Mac, too. But they are skipped by platform/mac/Skipped. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h Diff Modified: trunk/LayoutTests/ChangeLog (96730 => 96731) --- trunk/LayoutTests/ChangeLog 2011-10-05 18:18:42 UTC (rev 96730) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:21:07 UTC (rev 96731) @@ -1,3 +1,15 @@ +2011-10-05 Chang Shu + +[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport +https://bugs.webkit.org/show_bug.cgi?id=69365 + +Reviewed by Darin Adler. + +Unskip passed tests on Qt. The tests work on Mac, too. But they are skipped by +platform/mac/Skipped. + +* platform/qt-wk2/Skipped: + 2011-10-05 James Simonsen [Chromium] Add baselines for new SVG tests from r96712. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (96730 => 96731) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 18:18:42 UTC (rev 96730) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 18:21:07 UTC (rev 96731) @@ -301,9 +301,6 @@ # EventSender.mouseMoveTo is not yet supported svg/dynamic-updates -# layoutTestController.dumpConfigurationForViewport is unimplemented -fast/viewport - # eventSender.clearTouchPoints is unimplemented fast/events/touch Modified: trunk/Source/WebCore/ChangeLog (96730 => 96731) --- trunk/Source/WebCore/ChangeLog 2011-10-05 18:18:42 UTC (rev 96730) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 18:21:07 UTC (rev 96731) @@ -1,3 +1,14 @@ +2011-10-05 Chang Shu + +[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport +https://bugs.webkit.org/show_bug.cgi?id=69365 + +Reviewed by Darin Adler. + +Expose computeViewportAttributes for mac build. + +* WebCore.exp.in: + 2011-10-05 Anna Cavender Functions to make enabled at runtime, including changes to Modified: trunk/Source/WebCore/WebCore.exp.in (96730 => 96731) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-05 18:18:42 UTC (rev 96730) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-05 18:21:07 UTC (rev 96731) @@ -632,6 +632,7 @@ __ZN7WebCore25PluginMainThreadScheduler16unregisterPluginEP4_NPP __ZN7WebCore25PluginMainThreadScheduler9schedulerEv __ZN7WebCore25addLanguageChangeObserverEPvPFvS0_E +__ZN7WebCore25computeViewportAttributesENS_17ViewportArgumentsENS_7IntSizeE __ZN7WebCore25contextMenuItemTagOutlineEv __ZN7WebCore26CSSMutableStyleDeclarationC1Ev __ZN7WebCore26UserTypingGestureIndicator27processingUserTypingGestureEv Modified: trunk/Source/WebKit2/ChangeLog (96730 => 96731) --- trunk/Source/WebKit2/ChangeLog 2011-10-05 18:18:42 UTC (rev 96730) +++ trunk/Source/WebKit2/ChangeLog 2011-10-05 18:21:07 UTC (rev 96731) @@ -1,3 +1,19 @@ +2011-10-05 Chang Shu + +[WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport +https://bugs.webkit.org/show_bug.cgi?id=69365 + +Reviewed by Darin Adler. + +Implement retrieving viewport configuration as text in WebProcess. + +* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: +(WKBundlePageViewportConfigurationAsText): +* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: +
[webkit-changes] [96730] trunk/LayoutTests
Title: [96730] trunk/LayoutTests Revision 96730 Author simon...@chromium.org Date 2011-10-05 11:18:42 -0700 (Wed, 05 Oct 2011) Log Message [Chromium] Add baselines for new SVG tests from r96712. * platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png: Added. * platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Added. * platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. * platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png: Added. * platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png: Added. * platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. * platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png: Added. * platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png: Added. * platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png trunk/LayoutTests/platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png trunk/LayoutTests/platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png trunk/LayoutTests/platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png trunk/LayoutTests/platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png trunk/LayoutTests/platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (96729 => 96730) --- trunk/LayoutTests/ChangeLog 2011-10-05 18:15:55 UTC (rev 96729) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:18:42 UTC (rev 96730) @@ -1,3 +1,17 @@ +2011-10-05 James Simonsen + +[Chromium] Add baselines for new SVG tests from r96712. + +* platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png: Added. +* platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png: Added. +* platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. +* platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png: Added. +* platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png: Added. +* platform/chromium-linux/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. +* platform/chromium-win/svg/clip-path/clip-path-transform-1-expected.png: Added. +* platform/chromium-win/svg/clip-path/clip-path-transform-2-expected.png: Added. +* platform/chromium-win/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. + 2011-10-04 Gavin Barraclough Make Object.prototype getter/setter methods match ES5 behaviour Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-1-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/clip-path/clip-path-transform-2-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-1-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-2-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/clip-path/clip-path-transform-2-expect
[webkit-changes] [96729] trunk
Title: [96729] trunk Revision 96729 Author barraclo...@apple.com Date 2011-10-05 11:15:55 -0700 (Wed, 05 Oct 2011) Log Message Make Object.prototype getter/setter methods match ES5 behaviour https://bugs.webkit.org/show_bug.cgi?id=69393 Reviewed by Sam Weinig. Source/_javascript_Core: The rest of Object.prototype no longer substitute Null/Undefined with the global object, this is old ES3 behaviour. Remove it here too. * runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): LayoutTests: Update tests to conform with ES5 style handling of 'this' in host functions. * fast/dom/Window/Location/window-override-location-using-defineGetter.html: * fast/dom/Window/Location/window-override-window-using-defineGetter.html: * fast/js/exception-sequencing-binops.js: * fast/js/exception-sequencing.html: * fast/js/pic/delete-global-object.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/Location/window-override-location-using-defineGetter.html trunk/LayoutTests/fast/dom/Window/Location/window-override-window-using-defineGetter.html trunk/LayoutTests/fast/js/exception-sequencing-binops.js trunk/LayoutTests/fast/js/exception-sequencing.html trunk/LayoutTests/fast/js/pic/delete-global-object.html trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp Diff Modified: trunk/LayoutTests/ChangeLog (96728 => 96729) --- trunk/LayoutTests/ChangeLog 2011-10-05 18:09:05 UTC (rev 96728) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:15:55 UTC (rev 96729) @@ -1,3 +1,18 @@ +2011-10-04 Gavin Barraclough + +Make Object.prototype getter/setter methods match ES5 behaviour +https://bugs.webkit.org/show_bug.cgi?id=69393 + +Reviewed by Sam Weinig. + +Update tests to conform with ES5 style handling of 'this' in host functions. + +* fast/dom/Window/Location/window-override-location-using-defineGetter.html: +* fast/dom/Window/Location/window-override-window-using-defineGetter.html: +* fast/js/exception-sequencing-binops.js: +* fast/js/exception-sequencing.html: +* fast/js/pic/delete-global-object.html: + 2011-10-05 Andrew Scherkus Unreviewed. Skipping media layout tests for Mac Leopard GPU. Modified: trunk/LayoutTests/fast/dom/Window/Location/window-override-location-using-defineGetter.html (96728 => 96729) --- trunk/LayoutTests/fast/dom/Window/Location/window-override-location-using-defineGetter.html 2011-10-05 18:09:05 UTC (rev 96728) +++ trunk/LayoutTests/fast/dom/Window/Location/window-override-location-using-defineGetter.html 2011-10-05 18:15:55 UTC (rev 96729) @@ -8,7 +8,7 @@
[webkit-changes] [96728] trunk/LayoutTests
Title: [96728] trunk/LayoutTests Revision 96728 Author scher...@chromium.org Date 2011-10-05 11:09:05 -0700 (Wed, 05 Oct 2011) Log Message 2011-10-05 Andrew Scherkus Unreviewed. Skipping media layout tests for Mac Leopard GPU. They're a maintenance burden and we don't run the GPU compositor on Leopard. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (96727 => 96728) --- trunk/LayoutTests/ChangeLog 2011-10-05 18:08:32 UTC (rev 96727) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:09:05 UTC (rev 96728) @@ -1,3 +1,11 @@ +2011-10-05 Andrew Scherkus + +Unreviewed. Skipping media layout tests for Mac Leopard GPU. + +They're a maintenance burden and we don't run the GPU compositor on Leopard. + +* platform/chromium/test_expectations.txt: + 2011-10-05 Kenneth Russell Mask underlying RENDERER and VENDOR strings Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96727 => 96728) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 18:08:32 UTC (rev 96727) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 18:09:05 UTC (rev 96728) @@ -256,6 +256,7 @@ WONTFIX SKIP GPU GPU-CG LEOPARD : compositing = PASS TIMEOUT FAIL WONTFIX SKIP GPU GPU-CG LEOPARD : platform/chromium/compositing = PASS TIMEOUT FAIL WONTFIX SKIP GPU GPU-CG LEOPARD : animations/3d = PASS TIMEOUT FAIL +WONTFIX SKIP GPU GPU-CG LEOPARD : media = PASS TIMEOUT FAIL WONTFIX MAC WIN : platform/chromium-linux = FAIL WONTFIX SKIP LINUX MAC : platform/win = FAIL CRASH PASS @@ -2617,9 +2618,6 @@ // GPU // -// We only maintain pixel GPU baselines for Snow Leopard -WONTFIX GPU GPU-CG LEOPARD : media = IMAGE PASS - // Will need windows and linux baselines BUGWK47923 GPU GPU-CG : compositing/geometry/limit-layer-bounds-opacity-transition.html = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96727] trunk/Source
Title: [96727] trunk/Source
Revision 96727
Author ann...@chromium.org
Date 2011-10-05 11:08:32 -0700 (Wed, 05 Oct 2011)
Log Message
Source/WebCore: Functions to make enabled at runtime, including changes to
CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
be runtime-enabled.
https://bugs.webkit.org/show_bug.cgi?id=69352
Reviewed by Adam Barth.
No new tests. No new functionality.
* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
* bindings/scripts/CodeGeneratorV8.pm:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadTextTracks):
* html/HTMLTrackElement.idl:
Source/WebKit/chromium: Functions to make enabled at runtime.
https://bugs.webkit.org/show_bug.cgi?id=69352
Reviewed by Adam Barth.
* public/WebRuntimeFeatures.h:
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableVideoTrack):
(WebKit::WebRuntimeFeatures::isVideoTrackEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h
trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96726 => 96727)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 18:07:21 UTC (rev 96726)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 18:08:32 UTC (rev 96727)
@@ -1,3 +1,23 @@
+2011-10-05 Anna Cavender
+
+Functions to make enabled at runtime, including changes to
+CodeGeneratorvV8 to allow entire interfaces (not just attributes) to
+be runtime-enabled.
+https://bugs.webkit.org/show_bug.cgi?id=69352
+
+Reviewed by Adam Barth.
+
+No new tests. No new functionality.
+
+* bindings/generic/RuntimeEnabledFeatures.cpp:
+* bindings/generic/RuntimeEnabledFeatures.h:
+(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
+(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
+* bindings/scripts/CodeGeneratorV8.pm:
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::loadTextTracks):
+* html/HTMLTrackElement.idl:
+
2011-10-05 Kenneth Russell
Mask underlying RENDERER and VENDOR strings
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (96726 => 96727)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-10-05 18:07:21 UTC (rev 96726)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp 2011-10-05 18:08:32 UTC (rev 96727)
@@ -159,4 +159,8 @@
bool RuntimeEnabledFeatures::isMediaSourceEnabled = false;
#endif
+#if ENABLE(VIDEO_TRACK)
+bool RuntimeEnabledFeatures::isVideoTrackEnabled = false;
+#endif
+
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (96726 => 96727)
--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-10-05 18:07:21 UTC (rev 96726)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h 2011-10-05 18:08:32 UTC (rev 96727)
@@ -172,6 +172,11 @@
static void setWebkitMediaSourceEnabled(bool isEnabled) { isMediaSourceEnabled = isEnabled; }
#endif
+#if ENABLE(VIDEO_TRACK)
+static bool webkitVideoTrackEnabled() { return isVideoTrackEnabled; }
+static void setWebkitVideoTrackEnabled(bool isEnabled) { isVideoTrackEnabled = isEnabled; }
+#endif
+
private:
// Never instantiate.
RuntimeEnabledFeatures() { }
@@ -216,6 +221,10 @@
#if ENABLE(MEDIA_SOURCE)
static bool isMediaSourceEnabled;
#endif
+
+#if ENABLE(VIDEO_TRACK)
+static bool isVideoTrackEnabled;
+#endif
};
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (96726 => 96727)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-05 18:07:21 UTC (rev 96726)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-05 18:08:32 UTC (rev 96727)
@@ -2180,8 +2180,19 @@
{
desc->ReadOnlyPrototype();
-v8::Local defaultSignature = configureTemplate(desc, \"${visibleInterfaceName}\", $parentClassTemplate, V8${interfaceName}::internalFieldCount,
+v8::Local defaultSignature;
END
+if ($dataNode->extendedAttributes->{"EnabledAtRuntime"}) {
+my $enable_function = GetRuntimeEnableFunctionName($dataNode);
+push(@implContent, < # Set up our attributes if we have them
if ($has_attributes) {
push(@implContent, <
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (96726 => 96727)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-10-05 18:07:21
[webkit-changes] [96726] trunk
Title: [96726] trunk
Revision 96726
Author k...@google.com
Date 2011-10-05 11:07:21 -0700 (Wed, 05 Oct 2011)
Log Message
Mask underlying RENDERER and VENDOR strings
https://bugs.webkit.org/show_bug.cgi?id=69389
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/canvas/webgl/renderer-and-vendor-strings.html
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getParameter):
LayoutTests:
* fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
* fast/canvas/webgl/renderer-and-vendor-strings.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLGetInfo.h
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
Added Paths
trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt
trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html
Diff
Modified: trunk/LayoutTests/ChangeLog (96725 => 96726)
--- trunk/LayoutTests/ChangeLog 2011-10-05 18:02:32 UTC (rev 96725)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 18:07:21 UTC (rev 96726)
@@ -1,3 +1,13 @@
+2011-10-05 Kenneth Russell
+
+Mask underlying RENDERER and VENDOR strings
+https://bugs.webkit.org/show_bug.cgi?id=69389
+
+Reviewed by Sam Weinig.
+
+* fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added.
+* fast/canvas/webgl/renderer-and-vendor-strings.html: Added.
+
2011-10-05 Cary Clark
Unreviewed; new baselines (Skia on Mac)
Added: trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt (0 => 96726)
--- trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt 2011-10-05 18:07:21 UTC (rev 96726)
@@ -0,0 +1,10 @@
+Verifies the contents of the RENDERER and VENDOR strings to avoid regressions.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+PASS gl.getParameter(gl.RENDERER) is "WebKit WebGL"
+PASS gl.getParameter(gl.VENDOR) is "WebKit"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html (0 => 96726)
--- trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html 2011-10-05 18:07:21 UTC (rev 96726)
@@ -0,0 +1,31 @@
+
+
+
+
+
+
+
+description("Verifies the contents of the RENDERER and VENDOR strings to avoid regressions.")
+
+if (window.initNonKhronosFramework)
+window.initNonKhronosFramework(false);
+
+var gl = create3DContext();
+
+// Consensus in the WebGL working group has been to mask the
+// underlying hardware's RENDERER and VENDOR strings, which leak a
+// certain amount of personally identifiable information. This test is
+// intended only to catch accidental regressions, not to enforce the
+// specific strings.
+
+shouldBe("gl.getParameter(gl.RENDERER)", '"WebKit WebGL"');
+shouldBe("gl.getParameter(gl.VENDOR)", '"WebKit"');
+
+successfullyParsed = true;
+
+
+
[webkit-changes] [96725] trunk/LayoutTests
Title: [96725] trunk/LayoutTests Revision 96725 Author carycl...@google.com Date 2011-10-05 11:02:32 -0700 (Wed, 05 Oct 2011) Log Message Unreviewed; new baselines (Skia on Mac) Temporarily disable Skia on Mac on Leopard and Snow Leopard. * LayoutTests/platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (96724 => 96725) --- trunk/LayoutTests/ChangeLog 2011-10-05 17:56:25 UTC (rev 96724) +++ trunk/LayoutTests/ChangeLog 2011-10-05 18:02:32 UTC (rev 96725) @@ -1,3 +1,11 @@ +2011-10-05 Cary Clark + +Unreviewed; new baselines (Skia on Mac) + +Temporarily disable Skia on Mac on Leopard and Snow Leopard. + +* LayoutTests/platform/chromium/test_expectations.txt: + 2011-10-05 Sachin Puranik Spec change - option.label should be reflected like option.value Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (96724 => 96725) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 17:56:25 UTC (rev 96724) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-05 18:02:32 UTC (rev 96725) @@ -3651,26 +3651,27 @@ // Temporarily allowing many failures for Mac10.5 with Skia graphics. // epoger promises to remove these expectations by 10 October 2011. -BUGWK68270 LEOPARD CPU GPU : animations = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css1 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : css3 = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : editing = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : fast = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : fonts = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : http = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU : media = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : platform = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : plugins = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : svg = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : tables = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : transforms = PASS TEXT IMAGE IMAGE+TEXT -BUGWK68270 LEOPARD CPU GPU : transitions = PASS TEXT IMAGE IMAGE+TEXT +BUGWK68270 LEOPARD CPU GPU : animations = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css1 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css2.1 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : css3 = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : editing = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : fast = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : fonts = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : http = PASS FAIL +BUGWK68270 LEOPARD CPU : media = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : platform = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : plugins = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : scrollbars = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : svg = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : tables = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : transforms = PASS FAIL +BUGWK68270 LEOPARD CPU GPU : transitions = PASS FAIL // Temporarily allowing many failures for Mac10.6 with Skia graphics, while we work out kinks. // epoger promises to remove these expectations by 10 October 2011. BUGWK69279 SNOWLEOPARD CPU GPU : animations = PASS FAIL +BUGWK69279 SNOWLEOPARD GPU : compositing = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css1 = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css2.1 = PASS FAIL BUGWK69279 SNOWLEOPARD CPU GPU : css3 = PASS FAIL @@ -3743,7 +3744,7 @@ BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.primarycolours.html = TEXT BUGWK68879 MAC CPU-CG : canvas/philip/tests/toDataURL.jpeg.quality.basic.html = TEXT -BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH +BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH IMAGE BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH IMAGE BUGWK68885 MAC CPU-CG : fast/canvas/webgl/premultiplyalpha-test.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96724] trunk/Tools
Title: [96724] trunk/Tools Revision 96724 Author commit-qu...@webkit.org Date 2011-10-05 10:56:25 -0700 (Wed, 05 Oct 2011) Log Message [EFL] ImageDiff: Do not clear the image before it is processed and compared https://bugs.webkit.org/show_bug.cgi?id=69378 Patch by Raphael Kubo da Costa on 2011-10-05 Reviewed by Antonio Gomes. Commit 61836 to Evas added a few cleanup calls to some evas_object_image functions which effectively made ImageDiff consider all images to be equal. It turns out that now evas_object_image_colorspace_set clears any data set, so the call to evas_object_image_data_set was not having any effect. * DumpRenderTree/efl/ImageDiff.cpp: (readImageFromStdin): Call evas_object_image_data_set after evas_object_image_colorspace_set. Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp Diff Modified: trunk/Tools/ChangeLog (96723 => 96724) --- trunk/Tools/ChangeLog 2011-10-05 17:51:24 UTC (rev 96723) +++ trunk/Tools/ChangeLog 2011-10-05 17:56:25 UTC (rev 96724) @@ -1,5 +1,24 @@ 2011-10-05 Raphael Kubo da Costa +[EFL] ImageDiff: Do not clear the image before it is processed and compared +https://bugs.webkit.org/show_bug.cgi?id=69378 + +Reviewed by Antonio Gomes. + +Commit 61836 to Evas added a few cleanup calls to some +evas_object_image functions which effectively made ImageDiff consider +all images to be equal. + +It turns out that now evas_object_image_colorspace_set clears any +data set, so the call to evas_object_image_data_set was not having any +effect. + +* DumpRenderTree/efl/ImageDiff.cpp: +(readImageFromStdin): Call evas_object_image_data_set after +evas_object_image_colorspace_set. + +2011-10-05 Raphael Kubo da Costa + [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff. https://bugs.webkit.org/show_bug.cgi?id=68449 Modified: trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp (96723 => 96724) --- trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-10-05 17:51:24 UTC (rev 96723) +++ trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-10-05 17:56:25 UTC (rev 96724) @@ -258,8 +258,8 @@ return PassOwnPtr(); Evas_Object* image = evas_object_image_filled_add(evas); +evas_object_image_colorspace_set(image, EVAS_COLORSPACE_ARGB); evas_object_image_memfile_set(image, imageBuffer.get(), bytesRead, 0, 0); -evas_object_image_colorspace_set(image, EVAS_COLORSPACE_ARGB); resizeEcoreEvasIfNeeded(image); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96723] trunk/Tools
Title: [96723] trunk/Tools
Revision 96723
Author commit-qu...@webkit.org
Date 2011-10-05 10:51:24 -0700 (Wed, 05 Oct 2011)
Log Message
[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
https://bugs.webkit.org/show_bug.cgi?id=68449
Patch by Raphael Kubo da Costa on 2011-10-05
Reviewed by Antonio Gomes.
evas_render() must be called to close up temporary files and unmap unused
resources. evas_object_image_data_set() must be called after an
evas_object_image_data_get() to balance an internal reference count.
* DumpRenderTree/efl/ImageDiff.cpp:
(differenceImageFromDifferenceBuffer):
(calculateDifference):
(printImage):
(printImageDifferences):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp
Diff
Modified: trunk/Tools/ChangeLog (96722 => 96723)
--- trunk/Tools/ChangeLog 2011-10-05 17:44:26 UTC (rev 96722)
+++ trunk/Tools/ChangeLog 2011-10-05 17:51:24 UTC (rev 96723)
@@ -1,3 +1,20 @@
+2011-10-05 Raphael Kubo da Costa
+
+[EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
+https://bugs.webkit.org/show_bug.cgi?id=68449
+
+Reviewed by Antonio Gomes.
+
+evas_render() must be called to close up temporary files and unmap unused
+resources. evas_object_image_data_set() must be called after an
+evas_object_image_data_get() to balance an internal reference count.
+
+* DumpRenderTree/efl/ImageDiff.cpp:
+(differenceImageFromDifferenceBuffer):
+(calculateDifference):
+(printImage):
+(printImageDifferences):
+
2011-10-05 Balazs Kelemen
[Qt][WK2] Unreviewed build fix.
Modified: trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp (96722 => 96723)
--- trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-10-05 17:44:26 UTC (rev 96722)
+++ trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2011-10-05 17:51:24 UTC (rev 96723)
@@ -82,6 +82,8 @@
}
}
+evas_object_image_data_set(image, diffPixels);
+
return image;
}
@@ -104,7 +106,7 @@
return sqrtf(red * red + green * green + blue * blue + alpha * alpha) / 2.0f;
}
-static float calculateDifference(const Evas_Object* baselineImage, const Evas_Object* actualImage, OwnPtr& differenceImage)
+static float calculateDifference(Evas_Object* baselineImage, Evas_Object* actualImage, OwnPtr& differenceImage)
{
int width, height, baselineWidth, baselineHeight;
evas_object_image_size_get(actualImage, &width, &height);
@@ -144,6 +146,11 @@
}
}
+// When using evas_object_image_data_get(), a complementary evas_object_data_set() must be
+// issued to balance the reference count, even if the image hasn't been changed.
+evas_object_image_data_set(baselineImage, basePixels);
+evas_object_image_data_set(actualImage, actualPixels);
+
// Compute the difference as a percentage combining both the number of
// different pixels and their difference amount i.e. the average distance
// over the entire image
@@ -192,6 +199,8 @@
if (tempImageFd == -1)
abortWithErrorMessage("could not create temporary file");
+evas_render(evas_object_evas_get(image));
+
if (evas_object_image_save(image, fileName, 0, 0)) {
struct stat fileInfo;
if (!stat(fileName, &fileInfo)) {
@@ -208,7 +217,7 @@
unlink(fileName);
}
-static void printImageDifferences(const Evas_Object* baselineImage, Evas_Object* actualImage)
+static void printImageDifferences(Evas_Object* baselineImage, Evas_Object* actualImage)
{
OwnPtr differenceImage;
const float difference = calculateDifference(baselineImage, actualImage, differenceImage);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96722] trunk/Source/JavaScriptCore
Title: [96722] trunk/Source/_javascript_Core
Revision 96722
Author par...@webkit.org
Date 2011-10-05 10:44:26 -0700 (Wed, 05 Oct 2011)
Log Message
Get rid of posixThread in MachineStackMarker::Thread
https://bugs.webkit.org/show_bug.cgi?id=54836
Reviewed by Oliver Hunt.
* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::getCurrentPlatformThread):
(JSC::equalThread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
(JSC::MachineThreads::gatherConservativeRoots):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96721 => 96722)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 17:41:52 UTC (rev 96721)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 17:44:26 UTC (rev 96722)
@@ -1,3 +1,18 @@
+2011-10-05 Patrick Gansterer
+
+Get rid of posixThread in MachineStackMarker::Thread
+https://bugs.webkit.org/show_bug.cgi?id=54836
+
+Reviewed by Oliver Hunt.
+
+* heap/MachineStackMarker.cpp:
+(JSC::MachineThreads::Thread::Thread):
+(JSC::getCurrentPlatformThread):
+(JSC::equalThread):
+(JSC::MachineThreads::addCurrentThread):
+(JSC::MachineThreads::removeCurrentThread):
+(JSC::MachineThreads::gatherConservativeRoots):
+
2011-10-04 Geoffrey Garen
Removed JSValue::toJSNumber
Modified: trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp (96721 => 96722)
--- trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2011-10-05 17:41:52 UTC (rev 96721)
+++ trunk/Source/_javascript_Core/heap/MachineStackMarker.cpp 2011-10-05 17:44:26 UTC (rev 96722)
@@ -111,9 +111,8 @@
class MachineThreads::Thread {
public:
-Thread(pthread_t pthread, const PlatformThread& platThread, void* base)
-: posixThread(pthread)
-, platformThread(platThread)
+Thread(const PlatformThread& platThread, void* base)
+: platformThread(platThread)
, stackBase(base)
{
#if USE(PTHREADS) && !OS(WINDOWS) && !OS(DARWIN) && defined(SA_RESTART)
@@ -132,7 +131,6 @@
}
Thread* next;
-pthread_t posixThread;
PlatformThread platformThread;
void* stackBase;
};
@@ -164,12 +162,23 @@
#if OS(DARWIN)
return pthread_mach_thread_np(pthread_self());
#elif OS(WINDOWS)
-return pthread_getw32threadhandle_np(pthread_self());
+return GetCurrentThread();
#elif USE(PTHREADS)
return pthread_self();
#endif
}
+static inline bool equalThread(const PlatformThread& first, const PlatformThread& second)
+{
+#if OS(DARWIN) || OS(WINDOWS)
+return first == second;
+#elif USE(PTHREADS)
+return !!pthread_equal(first, second);
+#else
+#error Need a way to compare threads on this platform
+#endif
+}
+
void MachineThreads::makeUsableFromMultipleThreads()
{
if (m_threadSpecific)
@@ -188,7 +197,7 @@
return;
pthread_setspecific(m_threadSpecific, this);
-Thread* thread = new Thread(pthread_self(), getCurrentPlatformThread(), m_heap->globalData()->stack().origin());
+Thread* thread = new Thread(getCurrentPlatformThread(), m_heap->globalData()->stack().origin());
MutexLocker lock(m_registeredThreadsMutex);
@@ -204,11 +213,11 @@
void MachineThreads::removeCurrentThread()
{
-pthread_t currentPosixThread = pthread_self();
+PlatformThread currentPlatformThread = getCurrentPlatformThread();
MutexLocker lock(m_registeredThreadsMutex);
-if (pthread_equal(currentPosixThread, m_registeredThreads->posixThread)) {
+if (equalThread(currentPlatformThread, m_registeredThreads->platformThread)) {
Thread* t = m_registeredThreads;
m_registeredThreads = m_registeredThreads->next;
delete t;
@@ -216,7 +225,7 @@
Thread* last = m_registeredThreads;
Thread* t;
for (t = m_registeredThreads->next; t; t = t->next) {
-if (pthread_equal(t->posixThread, currentPosixThread)) {
+if (equalThread(t->platformThread, currentPlatformThread)) {
last->next = t->next;
break;
}
@@ -467,6 +476,7 @@
gatherFromCurrentThread(conservativeRoots, stackCurrent);
if (m_threadSpecific) {
+PlatformThread currentPlatformThread = getCurrentPlatformThread();
MutexLocker lock(m_registeredThreadsMutex);
@@ -479,7 +489,7 @@
// It is safe to access the registeredThreads list, because we earlier asserted that locks are being held,
// and since this is a shared heap, they are real locks.
for (Thread* thread = m_registeredThreads; thread; thread = thread->next) {
-if (!pthread_equal(thread->posixThread, pthread_self()))
+if (!equalThread(thread->platformThread, currentPlatformThread))
gatherFromOtherThread(conservativeRoots, thread);
}
#ifndef ND
[webkit-changes] [96721] trunk
Title: [96721] trunk
Revision 96721
Author commit-qu...@webkit.org
Date 2011-10-05 10:41:52 -0700 (Wed, 05 Oct 2011)
Log Message
Spec change - option.label should be reflected like option.value
https://bugs.webkit.org/show_bug.cgi?id=68684
Patch by Sachin Puranik on 2011-10-05
Reviewed by Darin Adler.
Source/WebCore:
Incorporating the recent change in spec for label attribute of
option element. While retrieving the "Label" IDL attribute return
the "Label" content attribute if present , else return the
value of textContent attribute.
Tests: fast/forms/option-label-trim-html-spaces.html
fast/forms/option-value-and-label-changed-by-js.html
* dom/OptionElement.cpp:
(WebCore::OptionElement::normalizeText):style fixes
* dom/OptionElement.h: make collectOptionInnerText() protected.
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::label): return innerText if label attribute un-available.
(WebCore::HTMLOptionElement::setLabel):setLabel() implementation.
* html/HTMLOptionElement.h: add setLabel declaration.
* html/HTMLOptionElement.idl: Change reflect to ConvertNullToNullString in idl
LayoutTests:
IDL "Label" attribute of option element should return textContent IDL attribute
if conetent attribute "Label" is unavailable. Changed the tests to match
above said behaviour. Added new tests.
* fast/forms/option-label-trim-html-spaces-expected.txt: Html space triming test.
* fast/forms/option-label-trim-html-spaces.html: Html space triming test.
* fast/forms/option-value-and-label-changed-by-js-expected.txt: Attribute change from JS.
* fast/forms/option-value-and-label-changed-by-js.html: Attribute change from JS.
* fast/forms/option-value-and-label-expected.txt: Changed test case as per new spec.
* fast/forms/option-value-and-label.html: Changed test case as per new spec.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/option-value-and-label-expected.txt
trunk/LayoutTests/fast/forms/option-value-and-label.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/OptionElement.cpp
trunk/Source/WebCore/dom/OptionElement.h
trunk/Source/WebCore/html/HTMLOptionElement.cpp
trunk/Source/WebCore/html/HTMLOptionElement.h
trunk/Source/WebCore/html/HTMLOptionElement.idl
Added Paths
trunk/LayoutTests/fast/forms/option-label-trim-html-spaces-expected.txt
trunk/LayoutTests/fast/forms/option-label-trim-html-spaces.html
trunk/LayoutTests/fast/forms/option-value-and-label-changed-by-js-expected.txt
trunk/LayoutTests/fast/forms/option-value-and-label-changed-by-js.html
Diff
Modified: trunk/LayoutTests/ChangeLog (96720 => 96721)
--- trunk/LayoutTests/ChangeLog 2011-10-05 17:39:01 UTC (rev 96720)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 17:41:52 UTC (rev 96721)
@@ -1,3 +1,21 @@
+2011-10-05 Sachin Puranik
+
+Spec change - option.label should be reflected like option.value
+https://bugs.webkit.org/show_bug.cgi?id=68684
+
+Reviewed by Darin Adler.
+
+IDL "Label" attribute of option element should return textContent IDL attribute
+if conetent attribute "Label" is unavailable. Changed the tests to match
+above said behaviour. Added new tests.
+
+* fast/forms/option-label-trim-html-spaces-expected.txt: Html space triming test.
+* fast/forms/option-label-trim-html-spaces.html: Html space triming test.
+* fast/forms/option-value-and-label-changed-by-js-expected.txt: Attribute change from JS.
+* fast/forms/option-value-and-label-changed-by-js.html: Attribute change from JS.
+* fast/forms/option-value-and-label-expected.txt: Changed test case as per new spec.
+* fast/forms/option-value-and-label.html: Changed test case as per new spec.
+
2011-10-05 Ilya Tikhonovsky
Unreviewed. Reduce test flakyness.
Added: trunk/LayoutTests/fast/forms/option-label-trim-html-spaces-expected.txt (0 => 96721)
--- trunk/LayoutTests/fast/forms/option-label-trim-html-spaces-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/option-label-trim-html-spaces-expected.txt 2011-10-05 17:41:52 UTC (rev 96721)
@@ -0,0 +1,13 @@
+Test for space striping .label attribute of OPTION element
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS o1.label is "text with extra while spaces"
+PASS o2.label is "text"
+PASS o3.label is " test text "
+PASS o4.label is "test  text"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/option-label-trim-html-spaces.html (0 => 96721)
--- trunk/LayoutTests/fast/forms/option-label-trim-html-spaces.html (rev 0)
+++ trunk/LayoutTests/fast/forms/option-label-trim-html-spaces.html 2011-10-05 17:41:52 UTC (rev 96721)
@@ -0,0 +1,41 @@
+
+
+
+
+
+
+
+
+
+
+ text with extra while spaces
+ text
+ test textÂ
+ test  text
+
+
+
+description('Test for space striping .label attribute of OPTION element');
+
+var o1 = document.g
[webkit-changes] [96720] trunk/Source/WebCore
Title: [96720] trunk/Source/WebCore Revision 96720 Author commit-qu...@webkit.org Date 2011-10-05 10:39:01 -0700 (Wed, 05 Oct 2011) Log Message [GTK] Fix compilation with gtk v2.20.1 https://bugs.webkit.org/show_bug.cgi?id=69418 Unreviewed build fix Patch by Rémi Duraffort on 2011-10-05 * platform/gtk/GtkDragAndDropHelper.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (96719 => 96720) --- trunk/Source/WebCore/ChangeLog 2011-10-05 17:19:55 UTC (rev 96719) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 17:39:01 UTC (rev 96720) @@ -1,3 +1,12 @@ +2011-10-05 Rémi Duraffort + +[GTK] Fix compilation with gtk v2.20.1 +https://bugs.webkit.org/show_bug.cgi?id=69418 + +Unreviewed build fix + +* platform/gtk/GtkDragAndDropHelper.cpp: + 2011-10-05 David Hyatt https://bugs.webkit.org/show_bug.cgi?id=68731 Modified: trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp (96719 => 96720) --- trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp 2011-10-05 17:19:55 UTC (rev 96719) +++ trunk/Source/WebCore/platform/gtk/GtkDragAndDropHelper.cpp 2011-10-05 17:39:01 UTC (rev 96720) @@ -22,6 +22,7 @@ #include "ClipboardUtilitiesGtk.h" #include "DragData.h" #include "GtkUtilities.h" +#include "GtkVersioning.h" #include "PasteboardHelper.h" #include #include ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96719] trunk/LayoutTests
Title: [96719] trunk/LayoutTests
Revision 96719
Author loi...@chromium.org
Date 2011-10-05 10:19:55 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed. Reduce test flakyness.
There was a race between Inspector's internal page reloaded message and load event.
* inspector/timeline/timeline-load-event-expected.txt:
* inspector/timeline/timeline-load-event.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-load-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (96718 => 96719)
--- trunk/LayoutTests/ChangeLog 2011-10-05 17:05:29 UTC (rev 96718)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 17:19:55 UTC (rev 96719)
@@ -1,3 +1,11 @@
+2011-10-05 Ilya Tikhonovsky
+
+Unreviewed. Reduce test flakyness.
+There was a race between Inspector's internal page reloaded message and load event.
+
+* inspector/timeline/timeline-load-event-expected.txt:
+* inspector/timeline/timeline-load-event.html:
+
2011-10-05 David Hyatt
https://bugs.webkit.org/show_bug.cgi?id=68731
Modified: trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt (96718 => 96719)
--- trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt 2011-10-05 17:05:29 UTC (rev 96718)
+++ trunk/LayoutTests/inspector/timeline/timeline-load-event-expected.txt 2011-10-05 17:19:55 UTC (rev 96719)
@@ -1,5 +1,6 @@
Tests the load event.
+Page reloaded.
MarkLoad Properties:
{
startTime :
@@ -9,5 +10,4 @@
usedHeapSize :
totalHeapSize :
}
-Page reloaded.
Modified: trunk/LayoutTests/inspector/timeline/timeline-load-event.html (96718 => 96719)
--- trunk/LayoutTests/inspector/timeline/timeline-load-event.html 2011-10-05 17:05:29 UTC (rev 96718)
+++ trunk/LayoutTests/inspector/timeline/timeline-load-event.html 2011-10-05 17:19:55 UTC (rev 96719)
@@ -14,14 +14,15 @@
function contentEvent()
{
-InspectorTest.printTimelineRecords("MarkLoad");
InspectorTest.stopTimeline(finish);
}
function finish()
{
-if (++finishCalled === 2)
+if (++finishCalled === 2) {
+InspectorTest.printTimelineRecords("MarkLoad");
InspectorTest.completeTest();
+}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96718] trunk
Title: [96718] trunk
Revision 96718
Author hy...@apple.com
Date 2011-10-05 10:05:29 -0700 (Wed, 05 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=68731
Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
translation offset and clip rects when overflow or outlines spill out.
Reviewed by Darin Adler.
Source/WebCore:
Added new test in fast/regions.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):
LayoutTests:
* fast/regions/outline-sides-in-region.html: Added.
* platform/mac/fast/regions/outline-sides-in-region-expected.png: Added.
* platform/mac/fast/regions/outline-sides-in-region-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
Added Paths
trunk/LayoutTests/fast/regions/outline-sides-in-region.html
trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.png
trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96717 => 96718)
--- trunk/LayoutTests/ChangeLog 2011-10-05 16:52:16 UTC (rev 96717)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 17:05:29 UTC (rev 96718)
@@ -1,3 +1,17 @@
+2011-10-05 David Hyatt
+
+https://bugs.webkit.org/show_bug.cgi?id=68731
+
+Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
+the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
+translation offset and clip rects when overflow or outlines spill out.
+
+Reviewed by Darin Adler.
+
+* fast/regions/outline-sides-in-region.html: Added.
+* platform/mac/fast/regions/outline-sides-in-region-expected.png: Added.
+* platform/mac/fast/regions/outline-sides-in-region-expected.txt: Added.
+
2011-10-05 Csaba Osztrogonác
[Qt][WK2] Unreviewed gardening.
Added: trunk/LayoutTests/fast/regions/outline-sides-in-region.html (0 => 96718)
--- trunk/LayoutTests/fast/regions/outline-sides-in-region.html (rev 0)
+++ trunk/LayoutTests/fast/regions/outline-sides-in-region.html 2011-10-05 17:05:29 UTC (rev 96718)
@@ -0,0 +1,29 @@
+
+
+
+ h1{
+ outline: 5px solid yellow;
+ }
+
+ #source{
+ -webkit-flow: "body";
+ }
+
+ #region{
+ content:-webkit-from-flow("body");
+ }
+ div{
+ width:200px;
+ height:200px;
+ }
+
+
+
+ Â
+
+
+
+
+ Â
+
+
\ No newline at end of file
Added: trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.txt (0 => 96718)
--- trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/regions/outline-sides-in-region-expected.txt 2011-10-05 17:05:29 UTC (rev 96718)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderRegion {DIV} at (0,0) size 200x200
+ RenderBlock {DIV} at (0,221) size 200x200
+RenderBlock {H1} at (0,0) size 200x37
+ RenderText {#text} at (0,0) size 8x37
+text run at (0,0) width 8: " "
+Flow Threads
+ Thread with flow-name 'body'
+layer at (0,0) size 200x200
+ RenderFlowThread at (0,0) size 200x200
+RenderBlock {DIV} at (0,21) size 200x200
+ RenderBlock {H1} at (0,0) size 200x37
+RenderText {#text} at (0,0) size 8x37
+ text run at (0,0) width 8: " "
+ Regions for flow 'body'
+RenderRegion {DIV} #region with index 0
Modified: trunk/Source/WebCore/ChangeLog (96717 => 96718)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 16:52:16 UTC (rev 96717)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 17:05:29 UTC (rev 96718)
@@ -1,3 +1,21 @@
+2011-10-05 David Hyatt
+
+https://bugs.webkit.org/show_bug.cgi?id=68731
+
+Outline sides not painted for region. Fix the painting and hit testing code for regions to add in
+the maximalOutlineSize on unclipped sides. Also fix some math errors with the computation of the
+translation offset and clip rects when overflow or outlines spill out.
+
+Reviewed by Darin Adler.
+
+Added new test
[webkit-changes] [96717] trunk/Source/JavaScriptCore
Title: [96717] trunk/Source/_javascript_Core
Revision 96717
Author gga...@apple.com
Date 2011-10-05 09:52:16 -0700 (Wed, 05 Oct 2011)
Log Message
Removed JSValue::toJSNumber
https://bugs.webkit.org/show_bug.cgi?id=69399
No perf. change.
toJSNumber() used to provide an implicit fast path for immediate numbers,
but those fast paths are all explicit now, so it's just cruft.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/JSValue.h
trunk/Source/_javascript_Core/runtime/JSValueInlineMethods.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96716 => 96717)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 16:45:04 UTC (rev 96716)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 16:52:16 UTC (rev 96717)
@@ -1,3 +1,20 @@
+2011-10-04 Geoffrey Garen
+
+Removed JSValue::toJSNumber
+https://bugs.webkit.org/show_bug.cgi?id=69399
+
+No perf. change.
+
+toJSNumber() used to provide an implicit fast path for immediate numbers,
+but those fast paths are all explicit now, so it's just cruft.
+
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute):
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+* runtime/JSValue.h:
+* runtime/JSValueInlineMethods.h:
+
2011-10-05 Gavin Peters
REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (96716 => 96717)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-10-05 16:45:04 UTC (rev 96716)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-10-05 16:52:16 UTC (rev 96717)
@@ -1974,10 +1974,10 @@
callFrame->uncheckedR(srcDst) = jsNumber(v.asInt32() + 1);
callFrame->uncheckedR(dst) = v;
} else {
-JSValue number = callFrame->r(srcDst).jsValue().toJSNumber(callFrame);
+double number = callFrame->r(srcDst).jsValue().toNumber(callFrame);
CHECK_FOR_EXCEPTION();
-callFrame->uncheckedR(srcDst) = jsNumber(number.asNumber() + 1);
-callFrame->uncheckedR(dst) = number;
+callFrame->uncheckedR(srcDst) = jsNumber(number + 1);
+callFrame->uncheckedR(dst) = jsNumber(number);
}
vPC += OPCODE_LENGTH(op_post_inc);
@@ -1997,10 +1997,10 @@
callFrame->uncheckedR(srcDst) = jsNumber(v.asInt32() - 1);
callFrame->uncheckedR(dst) = v;
} else {
-JSValue number = callFrame->r(srcDst).jsValue().toJSNumber(callFrame);
+double number = callFrame->r(srcDst).jsValue().toNumber(callFrame);
CHECK_FOR_EXCEPTION();
-callFrame->uncheckedR(srcDst) = jsNumber(number.asNumber() - 1);
-callFrame->uncheckedR(dst) = number;
+callFrame->uncheckedR(srcDst) = jsNumber(number - 1);
+callFrame->uncheckedR(dst) = jsNumber(number);
}
vPC += OPCODE_LENGTH(op_post_dec);
@@ -2020,9 +2020,9 @@
if (LIKELY(srcVal.isNumber()))
callFrame->uncheckedR(dst) = callFrame->r(src);
else {
-JSValue result = srcVal.toJSNumber(callFrame);
+double number = srcVal.toNumber(callFrame);
CHECK_FOR_EXCEPTION();
-callFrame->uncheckedR(dst) = result;
+callFrame->uncheckedR(dst) = jsNumber(number);
}
vPC += OPCODE_LENGTH(op_to_jsnumber);
Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (96716 => 96717)
--- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-05 16:45:04 UTC (rev 96716)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-10-05 16:52:16 UTC (rev 96717)
@@ -3049,11 +3049,11 @@
CallFrame* callFrame = stackFrame.callFrame;
-JSValue number = v.toJSNumber(callFrame);
+double number = v.toNumber(callFrame);
CHECK_FOR_EXCEPTION_AT_END();
-callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number.asNumber() + 1);
-return JSValue::encode(number);
+callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number + 1);
+return JSValue::encode(jsNumber(number));
}
DEFINE_STUB_FUNCTION(int, op_eq)
@@ -3348,11 +3348,11 @@
CallFrame* callFrame = stackFrame.callFrame;
-JSValue number = v.toJSNumber(callFrame);
+double number = v.toNumber(callFrame);
CHECK_FOR_EXCEPTION_AT_END();
-callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(number.asNumber() - 1);
-return JSValue::encode(number);
+callFrame->registers()[stackFrame.args[1].int32()] = jsNumber(numb
[webkit-changes] [96716] trunk/Source/WebCore
Title: [96716] trunk/Source/WebCore
Revision 96716
Author yu...@chromium.org
Date 2011-10-05 09:45:04 -0700 (Wed, 05 Oct 2011)
Log Message
2011-10-05 Yury Semikhatsky
Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (96715 => 96716)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 16:39:10 UTC (rev 96715)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 16:45:04 UTC (rev 96716)
@@ -1,3 +1,9 @@
+2011-10-05 Yury Semikhatsky
+
+Unreviewed. Build fix: make InspectorStateClient.h Private in XCode project.
+
+* WebCore.xcodeproj/project.pbxproj:
+
2011-10-05 Martin Robinson
libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (96715 => 96716)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-05 16:39:10 UTC (rev 96715)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-05 16:45:04 UTC (rev 96716)
@@ -5747,7 +5747,7 @@
F3D4C47912E07663003DA150 /* InspectorDOMDebuggerAgent.h in Headers */ = {isa = PBXBuildFile; fileRef = F3D4C47712E07663003DA150 /* InspectorDOMDebuggerAgent.h */; };
F3F5CF1112ED81A80084C569 /* InspectorConsoleInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = F3F5CF1012ED81A80084C569 /* InspectorConsoleInstrumentation.h */; };
F3F5CF1312ED81B30084C569 /* InspectorDatabaseInstrumentation.h in Headers */ = {isa = PBXBuildFile; fileRef = F3F5CF1212ED81B30084C569 /* InspectorDatabaseInstrumentation.h */; };
- F3F68DA6143CAC5A00C2F887 /* InspectorStateClient.h in Headers */ = {isa = PBXBuildFile; fileRef = F3F68DA5143CAC5A00C2F887 /* InspectorStateClient.h */; };
+ F3F68DA6143CAC5A00C2F887 /* InspectorStateClient.h in Headers */ = {isa = PBXBuildFile; fileRef = F3F68DA5143CAC5A00C2F887 /* InspectorStateClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
F4EAF4AE10C742B1009100D3 /* OpenTypeSanitizer.cpp in Sources */ = {isa = PBXBuildFile; fileRef = F4EAF4AC10C742B1009100D3 /* OpenTypeSanitizer.cpp */; };
F4EAF4AF10C742B1009100D3 /* OpenTypeSanitizer.h in Headers */ = {isa = PBXBuildFile; fileRef = F4EAF4AD10C742B1009100D3 /* OpenTypeSanitizer.h */; };
F5142C69123F12B000F5BD4C /* LocalizedNumber.h in Headers */ = {isa = PBXBuildFile; fileRef = F5142C68123F12B000F5BD4C /* LocalizedNumber.h */; };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96715] trunk/Source/WebCore
Title: [96715] trunk/Source/WebCore Revision 96715 Author mrobin...@webkit.org Date 2011-10-05 09:39:10 -0700 (Wed, 05 Oct 2011) Log Message libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed https://bugs.webkit.org/show_bug.cgi?id=64263 Reviewed by Xan Lopez. No new tests. This is difficult to test because it relies on network timing and to catch and parse stdout. Instead of allowing messages to pause and unpause after receiving headers, we wait until the completion of the sendRequestCallback. This will ensure that the SoupSession is in the correct state to allow for pausing and unpausing. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause until the sendRequestCallback is called. We detect this situation by checking whether or not we have an input stream yet. Previously the code was only pausing until after soupMessage->status_code was not equal to SOUP_STATUS_NONE. This means that the message was pausable right after headers are received. sendRequestCallback happens some time after that. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (96714 => 96715) --- trunk/Source/WebCore/ChangeLog 2011-10-05 16:27:30 UTC (rev 96714) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 16:39:10 UTC (rev 96715) @@ -1,3 +1,25 @@ +2011-10-05 Martin Robinson + +libsoup-CRITICAL **: soup_message_io_pause: assertion `io != NULL' failed +https://bugs.webkit.org/show_bug.cgi?id=64263 + +Reviewed by Xan Lopez. + +No new tests. This is difficult to test because it relies on network +timing and to catch and parse stdout. + +Instead of allowing messages to pause and unpause after receiving headers, +we wait until the completion of the sendRequestCallback. This will ensure +that the SoupSession is in the correct state to allow for pausing and unpausing. + +* platform/network/soup/ResourceHandleSoup.cpp: +(WebCore::ResourceHandle::platformSetDefersLoading): Don't pause and unpause +until the sendRequestCallback is called. We detect this situation by +checking whether or not we have an input stream yet. Previously the code +was only pausing until after soupMessage->status_code was not equal to +SOUP_STATUS_NONE. This means that the message was pausable right after +headers are received. sendRequestCallback happens some time after that. + 2011-10-05 Ilya Tikhonovsky Unreviewed build fix for Debug builders. Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (96714 => 96715) --- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-10-05 16:27:30 UTC (rev 96714) +++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-10-05 16:39:10 UTC (rev 96715) @@ -703,9 +703,10 @@ if (!d->m_soupMessage) return; -// Avoid any operation on not yet started messages and completed messages. +// Do not pause or unpause operations that are completed or have not reached +// sendRequestCallback yet. If m_defersLoading is true at that point, we'll pause. SoupMessage* soupMessage = d->m_soupMessage.get(); -if (d->m_finished || soupMessage->status_code == SOUP_STATUS_NONE) +if (d->m_finished || !d->m_inputStream) return; if (defersLoading) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96713] trunk/Source/WebCore
Title: [96713] trunk/Source/WebCore
Revision 96713
Author loi...@chromium.org
Date 2011-10-05 09:27:17 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed build fix for Debug builders.
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/WorkerInspectorController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96712 => 96713)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 16:20:32 UTC (rev 96712)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 16:27:17 UTC (rev 96713)
@@ -1,3 +1,10 @@
+2011-10-05 Ilya Tikhonovsky
+
+Unreviewed build fix for Debug builders.
+
+* inspector/WorkerInspectorController.cpp:
+(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
+
2011-10-05 Dirk Schulze
SVG 1.1: ineffectual transform attribute for ClipPath
Modified: trunk/Source/WebCore/inspector/WorkerInspectorController.cpp (96712 => 96713)
--- trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2011-10-05 16:20:32 UTC (rev 96712)
+++ trunk/Source/WebCore/inspector/WorkerInspectorController.cpp 2011-10-05 16:27:17 UTC (rev 96713)
@@ -194,7 +194,7 @@
void WorkerInspectorController::restoreInspectorStateFromCookie(const String& inspectorCookie)
{
-ASSERT(!m_inspectorFrontend);
+ASSERT(!m_frontend);
connectFrontend();
m_state->loadFromCookie(inspectorCookie);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96712] trunk
Title: [96712] trunk Revision 96712 Author k...@webkit.org Date 2011-10-05 09:20:32 -0700 (Wed, 05 Oct 2011) Log Message SVG 1.1: ineffectual transform attribute for ClipPath https://bugs.webkit.org/show_bug.cgi?id=55361 Source/WebCore: Reviewed by Nikolas Zimmermann. Respect 'transform' attribute/property for . If the masking code path is used the mask context gets transformed, otherwise the path itself. Tests: svg/clip-path/clip-path-transform-1.svg svg/clip-path/clip-path-transform-2.svg svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::pathOnlyClipping): Transform the clip path. (WebCore::RenderSVGResourceClipper::applyClippingToContext): (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): Transform the context of the mask image. (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): Repaint rect must get concatenated with the current animated transformation. (WebCore::RenderSVGResourceClipper::hitTestClipContent): Point for hit testing must be transformed by the current animated transformation. * rendering/svg/RenderSVGResourceClipper.h: LayoutTests: Reviewed by Nikolas Zimmermann. Test that the clip path gets concatenated with the current animated transformation and that hit testing is affected correctly. * platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Added. * platform/mac/svg/clip-path/clip-path-transform-1-expected.txt: Added. * platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Added. * platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Added. * svg/clip-path/clip-path-transform-1.svg: Added. Test clipping to path with transform. * svg/clip-path/clip-path-transform-2.svg: Added. Test masking with transform. * svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. * svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Added. * svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html: Added. * svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js: Added. (executeBackgroundTest): (executeTest): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.h Added Paths trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-transform-1-expected.png trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-transform-1-expected.txt trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-transform-2-expected.png trunk/LayoutTests/platform/mac/svg/clip-path/clip-path-transform-2-expected.txt trunk/LayoutTests/svg/clip-path/clip-path-transform-1.svg trunk/LayoutTests/svg/clip-path/clip-path-transform-2.svg trunk/LayoutTests/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png trunk/LayoutTests/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt trunk/LayoutTests/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html trunk/LayoutTests/svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js Diff Modified: trunk/LayoutTests/ChangeLog (96711 => 96712) --- trunk/LayoutTests/ChangeLog 2011-10-05 16:14:25 UTC (rev 96711) +++ trunk/LayoutTests/ChangeLog 2011-10-05 16:20:32 UTC (rev 96712) @@ -1,3 +1,26 @@ +2011-10-05 Dirk Schulze + +SVG 1.1: ineffectual transform attribute for ClipPath +https://bugs.webkit.org/show_bug.cgi?id=55361 + +Reviewed by Nikolas Zimmermann. + +Test that the clip path gets concatenated with the current animated transformation and +that hit testing is affected correctly. + +* platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Added. +* platform/mac/svg/clip-path/clip-path-transform-1-expected.txt: Added. +* platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Added. +* platform/mac/svg/clip-path/clip-path-transform-2-expected.txt: Added. +* svg/clip-path/clip-path-transform-1.svg: Added. Test clipping to path with transform. +* svg/clip-path/clip-path-transform-2.svg: Added. Test masking with transform. +* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added. +* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.txt: Added. +* svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting.html: Added. +* svg/dynamic-updates/script-tests/SVGClipPathElement-transform-influences-hitTesting.js: Added. +(executeBackgroundTest): +(executeTest): + 2011-10-05 Pavel Feldman Web Inspector: move elements panel update semantics from ElementsPanel to Elem
[webkit-changes] [96711] trunk
Title: [96711] trunk Revision 96711 Author pfeld...@chromium.org Date 2011-10-05 09:14:25 -0700 (Wed, 05 Oct 2011) Log Message Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline. https://bugs.webkit.org/show_bug.cgi?id=69431 Reviewed by Yury Semikhatsky. Source/WebCore: * inspector/front-end/ConsoleMessage.js: (WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.get this): (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.show): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype._selectedNodeChanged): (WebInspector.ElementsPanel.prototype._reset): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype.wireToDomAgent): (WebInspector.ElementsTreeOutline.prototype.setVisible): (WebInspector.ElementsTreeOutline.prototype.addEventListener): (WebInspector.ElementsTreeOutline.prototype.removeEventListener): (WebInspector.ElementsTreeOutline.prototype.selectDOMNode): (WebInspector.ElementsTreeOutline.prototype.update): (WebInspector.ElementsTreeOutline.prototype._selectedNodeChanged): (WebInspector.ElementsTreeOutline.prototype.findTreeElement.parentNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeOutline.prototype.createTreeElementFor): (WebInspector.ElementsTreeOutline.prototype._ondrop.callback): (WebInspector.ElementsTreeOutline.prototype._ondrop): (WebInspector.ElementsTreeOutline.prototype.adjustCollapsedRange): (WebInspector.ElementsTreeOutline.prototype._updateModifiedNodes): (WebInspector.ElementsTreeElement.prototype.insertChildElement): (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose): (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.changeTagNameCallback): (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted): (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): (WebInspector.ElementsTreeElement.prototype._editingCancelled): (): * inspector/front-end/externs.js: (WebInspector.ElementsTreeOutline): * inspector/front-end/utilities.js: LayoutTests: * http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.dumpElementsTree): (initialize_ElementTest.InspectorTest.expandElementsTree.onAllNodesAvailable): (initialize_ElementTest.InspectorTest.expandElementsTree): * inspector/elements/edit-dom-actions.html: * inspector/styles/styles-update-from-js.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/elements-test.js trunk/LayoutTests/inspector/elements/edit-dom-actions.html trunk/LayoutTests/inspector/styles/styles-update-from-js.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js trunk/Source/WebCore/inspector/front-end/ElementsPanel.js trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js trunk/Source/WebCore/inspector/front-end/externs.js trunk/Source/WebCore/inspector/front-end/utilities.js Diff Modified: trunk/LayoutTests/ChangeLog (96710 => 96711) --- trunk/LayoutTests/ChangeLog 2011-10-05 16:10:31 UTC (rev 96710) +++ trunk/LayoutTests/ChangeLog 2011-10-05 16:14:25 UTC (rev 96711) @@ -1,3 +1,17 @@ +2011-10-05 Pavel Feldman + +Web Inspector: move elements panel update semantics from ElementsPanel to ElementsTreeOutline. +https://bugs.webkit.org/show_bug.cgi?id=69431 + +Reviewed by Yury Semikhatsky. + +* http/tests/inspector/elements-test.js: +(initialize_ElementTest.InspectorTest.dumpElementsTree): +(initialize_ElementTest.InspectorTest.expandElementsTree.onAllNodesAvailable): +(initialize_ElementTest.InspectorTest.expandElementsTree): +* inspector/elements/edit-dom-actions.html: +* inspector/styles/styles-update-from-js.html: + 2011-10-05 Ilya Tikhonovsky Web Inspector: debugger-activation-crash2.html are flaky. Modified: trunk/LayoutTests/http/tests/inspector/elements-test.js (96710 => 96711) --- trunk/LayoutTests/http/tests/inspector/elements-test.js 2011-10-05 16:10:31 UTC (rev 96710) +++ trunk/LayoutTests/http/tests/inspector/elements-test.js 2011-10-05 16:14:25 UTC (rev 96711) @@ -320,7 +320,7 @@ print(children[children.length - 1], prefix); } -WebInspector.panels.elements.updateModifiedNodes(); +WebInspe
[webkit-changes] [96710] trunk/Source
Title: [96710] trunk/Source Revision 96710 Author yu...@chromium.org Date 2011-10-05 09:10:31 -0700 (Wed, 05 Oct 2011) Log Message Web Inspector: provide a way for persisting worker inspector state https://bugs.webkit.org/show_bug.cgi?id=69422 Source/WebCore: Worker inspector can persist and restore its state. InspectorStateClient is exctracted into a separate interface and has a custom implementation in case of worker inspector. Reviewed by Pavel Feldman. * GNUmakefile.list.am: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * inspector/InspectorClient.h: * inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState): * inspector/InspectorState.h: * inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h. (WebCore::InspectorStateClient::~InspectorStateClient): (WebCore::InspectorStateClient::updateInspectorStateCookie): * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::WorkerInspectorController): (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie): * inspector/WorkerInspectorController.h: * workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postMessageToPageInspector): (WebCore::SharedWorkerProxy::updateInspectorStateCookie): * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::updateInspectorStateCookie): * workers/WorkerMessagingProxy.h: * workers/WorkerReportingProxy.h: Source/WebKit/chromium: Provided an API for saving/restoring worker inspector state. Reviewed by Pavel Feldman. * public/WebCommonWorkerClient.h: (WebKit::WebCommonWorkerClient::saveDevToolsAgentState): * public/WebSharedWorker.h: (WebKit::WebSharedWorker::reattachDevTools): * src/WebSharedWorkerImpl.cpp: (WebKit::reconnectToWorkerContextInspectorTask): (WebKit::WebSharedWorkerImpl::reattachDevTools): * src/WebSharedWorkerImpl.h: * src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::updateInspectorStateCookie): (WebKit::WebWorkerBase::updateInspectorStateCookieTask): * src/WebWorkerBase.h: * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::updateInspectorStateCookie): * src/WebWorkerClientImpl.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/inspector/InspectorClient.h trunk/Source/WebCore/inspector/InspectorState.cpp trunk/Source/WebCore/inspector/InspectorState.h trunk/Source/WebCore/inspector/WorkerInspectorController.cpp trunk/Source/WebCore/inspector/WorkerInspectorController.h trunk/Source/WebCore/workers/DefaultSharedWorkerRepository.cpp trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp trunk/Source/WebCore/workers/WorkerMessagingProxy.h trunk/Source/WebCore/workers/WorkerReportingProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebCommonWorkerClient.h trunk/Source/WebKit/chromium/public/WebSharedWorker.h trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp trunk/Source/WebKit/chromium/src/WebSharedWorkerImpl.h trunk/Source/WebKit/chromium/src/WebWorkerBase.cpp trunk/Source/WebKit/chromium/src/WebWorkerBase.h trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h Added Paths trunk/Source/WebCore/inspector/InspectorStateClient.h Diff Modified: trunk/Source/WebCore/ChangeLog (96709 => 96710) --- trunk/Source/WebCore/ChangeLog 2011-10-05 16:09:52 UTC (rev 96709) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 16:10:31 UTC (rev 96710) @@ -1,3 +1,37 @@ +2011-10-05 Yury Semikhatsky + +Web Inspector: provide a way for persisting worker inspector state +https://bugs.webkit.org/show_bug.cgi?id=69422 + +Worker inspector can persist and restore its state. InspectorStateClient is +exctracted into a separate interface and has a custom implementation in case +of worker inspector. + +Reviewed by Pavel Feldman. + +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* inspector/InspectorClient.h: +* inspector/InspectorState.cpp: +(WebCore::InspectorState::InspectorState): +* inspector/InspectorState.h: +* inspector/InspectorStateClient.h: Copied from Source/WebCore/inspector/InspectorClient.h. +(WebCore::InspectorStateClient::~InspectorStateClient): +(WebCore::InspectorStateClient::updateInspectorStateCookie): +* inspector/WorkerInspectorController.cpp: +(WebCore::WorkerInspectorController::WorkerInspectorController): +(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie): +* inspector/WorkerInspectorController.h: +* workers/DefaultSharedWorkerRepository.cpp: +(WebCore::SharedWorkerProxy::postMessa
[webkit-changes] [96709] trunk/LayoutTests
Title: [96709] trunk/LayoutTests
Revision 96709
Author loi...@chromium.org
Date 2011-10-05 09:09:52 -0700 (Wed, 05 Oct 2011)
Log Message
Web Inspector: debugger-activation-crash2.html are flaky.
https://bugs.webkit.org/show_bug.cgi?id=69428
Reviewed by Yury Semikhatsky.
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/debugger-activation-crash2-expected.txt:
* inspector/debugger/debugger-activation-crash2.html:
* platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/debugger-test.js
trunk/LayoutTests/inspector/debugger/debugger-activation-crash2-expected.txt
trunk/LayoutTests/inspector/debugger/debugger-activation-crash2.html
Removed Paths
trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96708 => 96709)
--- trunk/LayoutTests/ChangeLog 2011-10-05 15:51:38 UTC (rev 96708)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 16:09:52 UTC (rev 96709)
@@ -1,3 +1,16 @@
+2011-10-05 Ilya Tikhonovsky
+
+Web Inspector: debugger-activation-crash2.html are flaky.
+https://bugs.webkit.org/show_bug.cgi?id=69428
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/debugger-test.js:
+(initialize_DebuggerTest):
+* inspector/debugger/debugger-activation-crash2-expected.txt:
+* inspector/debugger/debugger-activation-crash2.html:
+* platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
+
2011-10-05 Abhishek Arya
Crash in SVGTRefElement::updateReferencedText.
Modified: trunk/LayoutTests/http/tests/inspector/debugger-test.js (96708 => 96709)
--- trunk/LayoutTests/http/tests/inspector/debugger-test.js 2011-10-05 15:51:38 UTC (rev 96708)
+++ trunk/LayoutTests/http/tests/inspector/debugger-test.js 2011-10-05 16:09:52 UTC (rev 96709)
@@ -102,7 +102,7 @@
InspectorTest.waitUntilResumed(callback);
};
-InspectorTest.captureStackTrace = function(callFrames)
+InspectorTest.captureStackTrace = function(callFrames, dropLineNumbers)
{
InspectorTest.addResult("Call stack:");
for (var i = 0; i < callFrames.length; i++) {
@@ -117,7 +117,7 @@
url = "" script)";
lineNumber = "(line number)";
}
-var s = "" + i + ") " + frame.functionName + " (" + url + ":" + lineNumber + ")";
+var s = "" + i + ") " + frame.functionName + " (" + url + (dropLineNumbers ? "" : ":" + lineNumber) + ")";
InspectorTest.addResult(s);
}
};
Modified: trunk/LayoutTests/inspector/debugger/debugger-activation-crash2-expected.txt (96708 => 96709)
--- trunk/LayoutTests/inspector/debugger/debugger-activation-crash2-expected.txt 2011-10-05 15:51:38 UTC (rev 96708)
+++ trunk/LayoutTests/inspector/debugger/debugger-activation-crash2-expected.txt 2011-10-05 16:09:52 UTC (rev 96709)
@@ -5,8 +5,8 @@
Set timer for test function.
Script execution paused.
Call stack:
-0) (debugger-activation-crash2.html:9)
-1) testFunction (debugger-activation-crash2.html:20)
+0) (debugger-activation-crash2.html)
+1) testFunction (debugger-activation-crash2.html)
Script execution resumed.
Debugger was disabled.
Modified: trunk/LayoutTests/inspector/debugger/debugger-activation-crash2.html (96708 => 96709)
--- trunk/LayoutTests/inspector/debugger/debugger-activation-crash2.html 2011-10-05 15:51:38 UTC (rev 96708)
+++ trunk/LayoutTests/inspector/debugger/debugger-activation-crash2.html 2011-10-05 16:09:52 UTC (rev 96709)
@@ -40,7 +40,7 @@
function step3(callFrames)
{
-InspectorTest.captureStackTrace(callFrames);
+InspectorTest.captureStackTrace(callFrames, true);
InspectorTest.completeDebuggerTest();
}
}
Deleted: trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt (96708 => 96709)
--- trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt 2011-10-05 15:51:38 UTC (rev 96708)
+++ trunk/LayoutTests/platform/chromium/inspector/debugger/debugger-activation-crash2-expected.txt 2011-10-05 16:09:52 UTC (rev 96709)
@@ -1,12 +0,0 @@
-Tests for a crash when paused at a breakpoint caused by inaccurate Activation records. Bug 57120
-
-Debugger was enabled.
-Script source was shown.
-Set timer for test function.
-Script execution paused.
-Call stack:
-0) (debugger-activation-crash2.html:9)
-1) testFunction (debugger-activation-crash2.html:20)
-Script execution resumed.
-Debugger was disabled.
-
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96708] trunk/Source/JavaScriptCore
Title: [96708] trunk/Source/_javascript_Core
Revision 96708
Author gav...@chromium.org
Date 2011-10-05 08:51:38 -0700 (Wed, 05 Oct 2011)
Log Message
REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
https://bugs.webkit.org/show_bug.cgi?id=69424
Skip an extra frame in WTFReportBacktrace. As well, I now don't count skipped frames in maxFrames,
so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
31 reported frames.
Reviewed by Adam Roben.
* wtf/Assertions.cpp:
* wtf/Assertions.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Assertions.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96707 => 96708)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 15:40:05 UTC (rev 96707)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 15:51:38 UTC (rev 96708)
@@ -1,3 +1,17 @@
+2011-10-05 Gavin Peters
+
+REGRESSION (r96595): WTFReportBacktrace listed as the top frame in all assertion backtraces
+https://bugs.webkit.org/show_bug.cgi?id=69424
+
+Skip an extra frame in WTFReportBacktrace. As well, I now don't count skipped frames in maxFrames,
+so I've updated maxFrames to 31, as with one skipped frame the previous value was effectively
+31 reported frames.
+
+Reviewed by Adam Roben.
+
+* wtf/Assertions.cpp:
+* wtf/Assertions.h:
+
2011-10-05 Patrick Gansterer
Unreviewed WinCE build fix for r96595.
Modified: trunk/Source/_javascript_Core/wtf/Assertions.cpp (96707 => 96708)
--- trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-10-05 15:40:05 UTC (rev 96707)
+++ trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-10-05 15:51:38 UTC (rev 96708)
@@ -183,7 +183,7 @@
RtlCaptureStackBackTraceFunc captureStackBackTraceFunc = reinterpret_cast(
::GetProcAddress(kernel32, "RtlCaptureStackBackTrace"));
if (captureStackBackTraceFunc)
-*size = captureStackBackTraceFunc(1, *size, stack, 0);
+*size = captureStackBackTraceFunc(0, *size, stack, 0);
else
*size = 0;
#else
@@ -193,13 +193,14 @@
void WTFReportBacktrace()
{
-static const int maxFrames = 32;
-void* samples[maxFrames];
-int frames = maxFrames;
+static const int framesToShow = 31;
+static const int framesToSkip = 2;
+void* samples[framesToShow + framesToSkip];
+int frames = framesToShow + framesToSkip;
WTFGetBacktrace(samples, &frames);
-for (int i = 1; i < frames; ++i) {
+for (int i = framesToSkip; i < frames; ++i) {
const char* mangledName = 0;
char* cxaDemangled = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96707] trunk
Title: [96707] trunk
Revision 96707
Author infe...@chromium.org
Date 2011-10-05 08:40:05 -0700 (Wed, 05 Oct 2011)
Log Message
Crash in SVGTRefElement::updateReferencedText.
https://bugs.webkit.org/show_bug.cgi?id=67555
Reviewed by Rob Buis.
Source/WebCore:
Test: svg/text/tref-event-listener-crash.svg
* svg/SVGTRefElement.cpp:
(WebCore::SubtreeModificationEventListener::clear): This fixes the
crash. there can be cases when our target is removed, but our event
listener is alive. when our tref is going away, we need to disable
those event listeners by nulling out our tref element.
(WebCore::SubtreeModificationEventListener::handleEvent): Adding
null check for tref element, which can happen in cases where
event listener's clear is called, but we could not remove it from
the target.
(WebCore::SVGTRefElement::~SVGTRefElement): There are always
cases when removedFromDocument is not called. So, important to
clear event listener in those cases.
(WebCore::SVGTRefElement::svgAttributeChanged): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::buildPendingResource): Common function
to prevent triple duplication of same code. made it more readable.
(WebCore::SVGTRefElement::insertedIntoDocument): Use common
function buildPendingResource.
(WebCore::SVGTRefElement::removedFromDocument): Use new helper
removeEventListener.
(WebCore::SVGTRefElement::clearEventListener): Helper to clear
event listener. Name chosen to not collide with Node::removeEventListener.
* svg/SVGTRefElement.h: definition of new helpers.
* svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedIntoDocument): Copy same
logic as tref and use element. more asserts and easy bailouts.
LayoutTests:
* svg/text/tref-event-listener-crash-expected.txt: Added.
* svg/text/tref-event-listener-crash.svg: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGTRefElement.cpp
trunk/Source/WebCore/svg/SVGTRefElement.h
trunk/Source/WebCore/svg/SVGTextPathElement.cpp
Added Paths
trunk/LayoutTests/svg/text/tref-event-listener-crash-expected.txt
trunk/LayoutTests/svg/text/tref-event-listener-crash.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (96706 => 96707)
--- trunk/LayoutTests/ChangeLog 2011-10-05 15:18:57 UTC (rev 96706)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 15:40:05 UTC (rev 96707)
@@ -1,3 +1,13 @@
+2011-10-05 Abhishek Arya
+
+Crash in SVGTRefElement::updateReferencedText.
+https://bugs.webkit.org/show_bug.cgi?id=67555
+
+Reviewed by Rob Buis.
+
+* svg/text/tref-event-listener-crash-expected.txt: Added.
+* svg/text/tref-event-listener-crash.svg: Added.
+
2011-10-05 Balazs Kelemen
[Qt][WK2] First test always fails because of useless xcb dump
Added: trunk/LayoutTests/svg/text/tref-event-listener-crash-expected.txt (0 => 96707)
--- trunk/LayoutTests/svg/text/tref-event-listener-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/text/tref-event-listener-crash-expected.txt 2011-10-05 15:40:05 UTC (rev 96707)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Added: trunk/LayoutTests/svg/text/tref-event-listener-crash.svg (0 => 96707)
--- trunk/LayoutTests/svg/text/tref-event-listener-crash.svg (rev 0)
+++ trunk/LayoutTests/svg/text/tref-event-listener-crash.svg 2011-10-05 15:40:05 UTC (rev 96707)
@@ -0,0 +1,15 @@
+
+Test passes if it does not crash.
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+window._onload_ = function() {
+document.getElementById("container").textContent = "1";
+}
+
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (96706 => 96707)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 15:18:57 UTC (rev 96706)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 15:40:05 UTC (rev 96707)
@@ -1,3 +1,39 @@
+2011-10-05 Abhishek Arya
+
+Crash in SVGTRefElement::updateReferencedText.
+https://bugs.webkit.org/show_bug.cgi?id=67555
+
+Reviewed by Rob Buis.
+
+Test: svg/text/tref-event-listener-crash.svg
+
+* svg/SVGTRefElement.cpp:
+(WebCore::SubtreeModificationEventListener::clear): This fixes the
+crash. there can be cases when our target is removed, but our event
+listener is alive. when our tref is going away, we need to disable
+those event listeners by nulling out our tref element.
+(WebCore::SubtreeModificationEventListener::handleEvent): Adding
+null check for tref element, which can happen in cases where
+event listener's clear is called, but we could not remove it from
+the target.
+(WebCore::SVGTRefElement::~SVGTRefElement): There are always
+cases when removedFromDocument is not called. So, important to
+clear event listener in those cases.
+(WebCore::SVGTRefElement::svgAttributeChanged): Use common
+function buildPendingResou
[webkit-changes] [96706] trunk/Source/WebCore
Title: [96706] trunk/Source/WebCore
Revision 96706
Author pfeld...@chromium.org
Date 2011-10-05 08:18:57 -0700 (Wed, 05 Oct 2011)
Log Message
2011-10-05 Pavel Feldman
Not reviewed: restoring : shortcut in inspector.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSidebarButtons):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (96705 => 96706)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 15:13:00 UTC (rev 96705)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 15:18:57 UTC (rev 96706)
@@ -1,3 +1,10 @@
+2011-10-05 Pavel Feldman
+
+Not reviewed: restoring : shortcut in inspector.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._createSidebarButtons):
+
2011-10-05 Andreas Kling
Shrink FontDescription.
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (96705 => 96706)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-10-05 15:13:00 UTC (rev 96705)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-10-05 15:18:57 UTC (rev 96706)
@@ -1051,7 +1051,7 @@
handler = this._stepOutClicked.bind(this);
shortcuts = [];
shortcuts.push(WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.F11, WebInspector.KeyboardShortcut.Modifiers.Shift));
-shortcuts.push(WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.Semicolon, WebInspector.KeyboardShortcut.Modifiers.Shift, platformSpecificModifier));
+shortcuts.push(WebInspector.KeyboardShortcut.makeDescriptor(WebInspector.KeyboardShortcut.Keys.Semicolon, WebInspector.KeyboardShortcut.Modifiers.Shift | platformSpecificModifier));
this.stepOutButton = this._createSidebarButtonAndRegisterShortcuts("scripts-step-out", title, handler, shortcuts, WebInspector.UIString("Step out"));
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96705] trunk/Source/WebCore
Title: [96705] trunk/Source/WebCore
Revision 96705
Author andreas.kl...@nokia.com
Date 2011-10-05 08:13:00 -0700 (Wed, 05 Oct 2011)
Log Message
Shrink FontDescription.
https://bugs.webkit.org/show_bug.cgi?id=69426
Reviewed by Nikolas Zimmermann.
Pack FontDescription's members in a bitfield, effectively shrinking
the class by two CPU-words. This reduces memory consumption by ~1 MB
on 64-bit when loading the full HTML5 spec.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::orientation):
(WebCore::FontDescription::textOrientation):
(WebCore::FontDescription::widthVariant):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontDescription.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96704 => 96705)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 14:51:58 UTC (rev 96704)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 15:13:00 UTC (rev 96705)
@@ -1,3 +1,19 @@
+2011-10-05 Andreas Kling
+
+Shrink FontDescription.
+https://bugs.webkit.org/show_bug.cgi?id=69426
+
+Reviewed by Nikolas Zimmermann.
+
+Pack FontDescription's members in a bitfield, effectively shrinking
+the class by two CPU-words. This reduces memory consumption by ~1 MB
+on 64-bit when loading the full HTML5 spec.
+
+* platform/graphics/FontDescription.h:
+(WebCore::FontDescription::orientation):
+(WebCore::FontDescription::textOrientation):
+(WebCore::FontDescription::widthVariant):
+
2011-10-05 Vsevolod Vlasov
Web Inspector: Add support for search in script content.
Modified: trunk/Source/WebCore/platform/graphics/FontDescription.h (96704 => 96705)
--- trunk/Source/WebCore/platform/graphics/FontDescription.h 2011-10-05 14:51:58 UTC (rev 96704)
+++ trunk/Source/WebCore/platform/graphics/FontDescription.h 2011-10-05 15:13:00 UTC (rev 96705)
@@ -119,9 +119,9 @@
FontTraitsMask traitsMask() const;
bool isSpecifiedFont() const { return m_isSpecifiedFont; }
-FontOrientation orientation() const { return m_orientation; }
-TextOrientation textOrientation() const { return m_textOrientation; }
-FontWidthVariant widthVariant() const { return m_widthVariant; }
+FontOrientation orientation() const { return static_cast(m_orientation); }
+TextOrientation textOrientation() const { return static_cast(m_textOrientation); }
+FontWidthVariant widthVariant() const { return static_cast(m_widthVariant); }
FontFeatureSettings* featureSettings() const { return m_featureSettings.get(); }
FontDescription makeNormalFeatureSettings() const;
@@ -153,18 +153,17 @@
private:
FontFamily m_familyList; // The list of font families to be used.
+RefPtr m_featureSettings;
float m_specifiedSize; // Specified CSS value. Independent of rendering issues such as integer
// rounding, minimum font sizes, and zooming.
float m_computedSize;// Computed size adjusted for the minimum font size and the zoom factor.
-FontOrientation m_orientation; // Whether the font is rendering on a horizontal line or a vertical line.
-TextOrientation m_textOrientation; // Only used by vertical text. Determines the default orientation for non-ideograph glyphs.
+unsigned m_orientation : 1; // FontOrientation - Whether the font is rendering on a horizontal line or a vertical line.
+unsigned m_textOrientation : 1; // TextOrientation - Only used by vertical text. Determines the default orientation for non-ideograph glyphs.
-FontWidthVariant m_widthVariant;
+unsigned m_widthVariant : 2; // FontWidthVariant
-RefPtr m_featureSettings;
-
unsigned m_italic : 1; // FontItalic
unsigned m_smallCaps : 1; // FontSmallCaps
bool m_isAbsoluteSize : 1; // Whether or not CSS specified an explicit size
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96704] trunk/LayoutTests
Title: [96704] trunk/LayoutTests Revision 96704 Author kbal...@webkit.org Date 2011-10-05 07:51:58 -0700 (Wed, 05 Oct 2011) Log Message [Qt][WK2] First test always fails because of useless xcb dump https://bugs.webkit.org/show_bug.cgi?id=69132 Unskip the first test because the failure always affects the first test we run so skipping makes no sense. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96703 => 96704) --- trunk/LayoutTests/ChangeLog 2011-10-05 14:30:29 UTC (rev 96703) +++ trunk/LayoutTests/ChangeLog 2011-10-05 14:51:58 UTC (rev 96704) @@ -1,3 +1,13 @@ +2011-10-05 Balazs Kelemen + +[Qt][WK2] First test always fails because of useless xcb dump +https://bugs.webkit.org/show_bug.cgi?id=69132 + +Unskip the first test because the failure always affects the first test we run +so skipping makes no sense. + +* platform/qt-wk2/Skipped: + 2011-10-05 Vsevolod Vlasov Web Inspector: Add support for search in script content. Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (96703 => 96704) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 14:30:29 UTC (rev 96703) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 14:51:58 UTC (rev 96704) @@ -216,10 +216,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=69419 fast/text/regional-indicator-symobls.html -# [Qt][WK2] Layout test failure because of screen info printed to stdout -# https://bugs.webkit.org/show_bug.cgi?id=69420 -http/tests/cache/post-redirect-get.php - # NOT YET TRACKED BY BUG REPORTS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96703] trunk
Title: [96703] trunk Revision 96703 Author vse...@chromium.org Date 2011-10-05 07:30:29 -0700 (Wed, 05 Oct 2011) Log Message Web Inspector: Add support for search in script content. https://bugs.webkit.org/show_bug.cgi?id=69015 Reviewed by Pavel Feldman. Source/WebCore: Tests: http/tests/inspector/search/search-in-concatenated-script.html http/tests/inspector/search/search-in-script.html * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::searchInContent): (WebCore::InspectorDebuggerAgent::getScriptSource): * inspector/InspectorDebuggerAgent.h: * inspector/front-end/ContentProviders.js: (WebInspector.ScriptContentProvider.prototype.searchInContent): (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts.var): (WebInspector.ConcatenatedScriptsContentProvider.prototype._sortedScripts): (WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent): (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback): (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback): (WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent): (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent): * inspector/front-end/Script.js: (WebInspector.Script.prototype.requestSource.didGetScriptSource): (WebInspector.Script.prototype.requestSource): (WebInspector.Script.prototype.searchInContent): LayoutTests: * http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest): * http/tests/inspector/resources-test.js: (initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished): (initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished): (initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback): (initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer): (initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame): (initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit): (initialize_ResourceTest): * http/tests/inspector/search/resources/search-concatenated.html: Added. * http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added. * http/tests/inspector/search/search-in-concatenated-script.html: Added. * http/tests/inspector/search/search-in-resource.html: * http/tests/inspector/search/search-in-script-expected.txt: Added. * http/tests/inspector/search/search-in-script.html: Added. * http/tests/inspector/search/search-test.js: (initialize_SearchTest): * inspector/debugger/content-providers.html: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js trunk/LayoutTests/http/tests/inspector/resources-test.js trunk/LayoutTests/http/tests/inspector/search/search-in-resource.html trunk/LayoutTests/http/tests/inspector/search/search-test.js trunk/LayoutTests/inspector/debugger/content-providers.html trunk/LayoutTests/platform/qt/Skipped trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h trunk/Source/WebCore/inspector/front-end/ContentProviders.js trunk/Source/WebCore/inspector/front-end/Script.js Added Paths trunk/LayoutTests/http/tests/inspector/search/resources/search-concatenated.html trunk/LayoutTests/http/tests/inspector/search/search-in-concatenated-script-expected.txt trunk/LayoutTests/http/tests/inspector/search/search-in-concatenated-script.html trunk/LayoutTests/http/tests/inspector/search/search-in-script-expected.txt trunk/LayoutTests/http/tests/inspector/search/search-in-script.html Diff Modified: trunk/LayoutTests/ChangeLog (96702 => 96703) --- trunk/LayoutTests/ChangeLog 2011-10-05 14:20:22 UTC (rev 96702) +++ trunk/LayoutTests/ChangeLog 2011-10-05 14:30:29 UTC (rev 96703) @@ -1,3 +1,31 @@ +2011-10-05 Vsevolod Vlasov + +Web Inspector: Add support for search in script content. +https://bugs.webkit.org/show_bug.cgi?id=69015 + +Reviewed by Pavel Feldman. + +* http/tests/inspector/resource-tree/resource-tree-test.js: +(initialize_ResourceTreeTest): +* http/tests/inspector/resources-test.js: +(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished): +(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished): +(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback): +(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer): +(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame): +(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit): +(initialize_ResourceTest): +* http/tests/inspector/sea
[webkit-changes] [96702] trunk/Source
Title: [96702] trunk/Source
Revision 96702
Author alexis.men...@openbossa.org
Date 2011-10-05 07:20:22 -0700 (Wed, 05 Oct 2011)
Log Message
[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
https://bugs.webkit.org/show_bug.cgi?id=69111
Reviewed by Kenneth Rohde Christiansen.
Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.
Source/WebCore:
No new tests : existing ones should cover.
* platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::SharedCookieJarQt):
Source/WebKit2:
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDataLocation):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/CookieJarQt.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96701 => 96702)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 14:19:51 UTC (rev 96701)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 14:20:22 UTC (rev 96702)
@@ -1,3 +1,17 @@
+2011-10-05 Alexis Menard
+
+[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
+https://bugs.webkit.org/show_bug.cgi?id=69111
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.
+
+No new tests : existing ones should cover.
+
+* platform/qt/CookieJarQt.cpp:
+(WebCore::SharedCookieJarQt::SharedCookieJarQt):
+
2011-10-05 Patrick Gansterer
Unreviewed build fix for !ENABLE(FILTERS) after r96203.
Modified: trunk/Source/WebCore/platform/qt/CookieJarQt.cpp (96701 => 96702)
--- trunk/Source/WebCore/platform/qt/CookieJarQt.cpp 2011-10-05 14:19:51 UTC (rev 96701)
+++ trunk/Source/WebCore/platform/qt/CookieJarQt.cpp 2011-10-05 14:20:22 UTC (rev 96702)
@@ -42,7 +42,6 @@
#include "qwebpage.h"
#include "qwebsettings.h"
#include
-#include
#include
#include
#include
@@ -227,8 +226,7 @@
{
m_database = QSqlDatabase::addDatabase(QLatin1String("QSQLITE"));
const QString cookieStoragePath = cookieStorageDirectory;
-QDir().mkpath(cookieStoragePath + QLatin1String(".QtWebKit/"));
-const QString dataBaseName = cookieStoragePath + QLatin1String(".QtWebKit/cookies.db");
+const QString dataBaseName = cookieStoragePath + QLatin1String("cookies.db");
m_database.setDatabaseName(dataBaseName);
ensureDatabaseTable();
loadCookies();
Modified: trunk/Source/WebKit2/ChangeLog (96701 => 96702)
--- trunk/Source/WebKit2/ChangeLog 2011-10-05 14:19:51 UTC (rev 96701)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-05 14:20:22 UTC (rev 96702)
@@ -1,3 +1,19 @@
+2011-10-05 Alexis Menard
+
+[Qt][WK2] Default directories and paths are missing for LocalStorage, Database and IconDatabase.
+https://bugs.webkit.org/show_bug.cgi?id=69111
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Provide default path for LocalStorage, Database and IconDatabase using QDesktopServices.
+
+* UIProcess/qt/WebContextQt.cpp:
+(WebKit::defaultDataLocation):
+(WebKit::WebContext::platformInitializeWebProcess):
+(WebKit::WebContext::platformDefaultDatabaseDirectory):
+(WebKit::WebContext::platformDefaultIconDatabasePath):
+(WebKit::WebContext::platformDefaultLocalStorageDirectory):
+
2011-10-05 Carlos Garcia Campos
[GTK] Use WKRetainPtr for WK types in WebKit2 GTK+
Modified: trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp (96701 => 96702)
--- trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp 2011-10-05 14:19:51 UTC (rev 96701)
+++ trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp 2011-10-05 14:20:22 UTC (rev 96702)
@@ -28,12 +28,33 @@
#include "WebContext.h"
#include "ApplicationCacheStorage.h"
+#include "FileSystem.h"
#include "WebProcessCreationParameters.h"
+#include
#include
+#include
#include
namespace WebKit {
+static QString defaultDataLocation()
+{
+static QString s_dataLocation;
+
+if (!s_dataLocation.isEmpty())
+return s_dataLocation;
+
+QString dataLocation = QDesktopServices::storageLocation(QDesktopServices::DataLocation);
+if (dataLocation.isEmpty())
+dataLocation = WebCore::pathByAppendingComponent(QDir::homePath(), QCoreApplication::applicationName());
+s_dataLocation = WebCore::pathByAppendingComponent(dataLocation, ".QtWebKit/");
+WebCore::makeAllDirectories(s_dataLocation);
+return s_dataLocation;
+}
+
+static QString s_defaultDatabaseDirectory;
+static QString s_defaultLocalStorageDirectory;
+
String WebContext::applicationCacheDirectory()
{
return WebCore::cacheStorage().cacheDirectory(
[webkit-changes] [96701] trunk/LayoutTests
Title: [96701] trunk/LayoutTests Revision 96701 Author kbal...@webkit.org Date 2011-10-05 07:19:51 -0700 (Wed, 05 Oct 2011) Log Message [Qt][WK2] Try to paint the bot green. Unreviewed gardening. * platform/qt-wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96700 => 96701) --- trunk/LayoutTests/ChangeLog 2011-10-05 14:14:01 UTC (rev 96700) +++ trunk/LayoutTests/ChangeLog 2011-10-05 14:19:51 UTC (rev 96701) @@ -1,5 +1,13 @@ 2011-10-05 Balazs Kelemen +[Qt][WK2] Try to paint the bot green. + +Unreviewed gardening. + +* platform/qt-wk2/Skipped: + +2011-10-05 Balazs Kelemen + WTR needs an implementation for eventSender.continuousMouseScrollBy https://bugs.webkit.org/show_bug.cgi?id=69417 Modified: trunk/LayoutTests/platform/qt-wk2/Skipped (96700 => 96701) --- trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 14:14:01 UTC (rev 96700) +++ trunk/LayoutTests/platform/qt-wk2/Skipped 2011-10-05 14:19:51 UTC (rev 96701) @@ -212,6 +212,14 @@ # fast/loader/onload-willSendRequest-null-for-script.html +# [Qt][WK2] Crash in fast/text/regional-indicator-symobls.html +# https://bugs.webkit.org/show_bug.cgi?id=69419 +fast/text/regional-indicator-symobls.html + +# [Qt][WK2] Layout test failure because of screen info printed to stdout +# https://bugs.webkit.org/show_bug.cgi?id=69420 +http/tests/cache/post-redirect-get.php + # NOT YET TRACKED BY BUG REPORTS @@ -248,6 +256,7 @@ plugins/embed-prefers-plugins-for-images.html plugins/npp-set-window-called-during-destruction.html plugins/reloadplugins-and-pages.html +plugins/mouse-click-iframe-to-plugin.html # Unexplained failures fast/dom/frame-loading-via-document-write.html @@ -268,6 +277,10 @@ storage/transaction-callback-isolated-world.html storage/transaction-error-callback-isolated-world.html storage/transaction-success-callback-isolated-world.html +editing/pasteboard/paste-plaintext-user-select-none.html +fast/css-generated-content/first-letter-in-nested-before.html +fast/frames/set-parent-src-synchronously.html +fast/text/complex-synthetic-bold-space-width.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96700] trunk/Source/WebCore
Title: [96700] trunk/Source/WebCore
Revision 96700
Author par...@webkit.org
Date 2011-10-05 07:14:01 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed build fix for !ENABLE(FILTERS) after r96203.
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientUpdatedFromElement):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (96699 => 96700)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 13:53:49 UTC (rev 96699)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 14:14:01 UTC (rev 96700)
@@ -1,3 +1,10 @@
+2011-10-05 Patrick Gansterer
+
+Unreviewed build fix for !ENABLE(FILTERS) after r96203.
+
+* rendering/svg/SVGResourcesCache.cpp:
+(WebCore::SVGResourcesCache::clientUpdatedFromElement):
+
2011-10-05 Ilya Tikhonovsky
Unreviewed build fix for windows bots after r96679.
Modified: trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp (96699 => 96700)
--- trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp 2011-10-05 13:53:49 UTC (rev 96699)
+++ trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp 2011-10-05 14:14:01 UTC (rev 96700)
@@ -135,7 +135,7 @@
clientUpdatedFromElement(renderer, newStyle);
RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer, false);
}
-
+
void SVGResourcesCache::clientUpdatedFromElement(RenderObject* renderer, const RenderStyle* newStyle)
{
ASSERT(renderer);
@@ -145,9 +145,11 @@
cache->removeResourcesFromRenderObject(renderer);
cache->addResourcesFromRenderObject(renderer, newStyle);
+#if ENABLE(FILTERS)
SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(renderer);
if (resources && resources->filter())
resources->removeClientFromCache(renderer);
+#endif
}
void SVGResourcesCache::clientDestroyed(RenderObject* renderer)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96699] trunk/LayoutTests
Title: [96699] trunk/LayoutTests Revision 96699 Author kbal...@webkit.org Date 2011-10-05 06:53:49 -0700 (Wed, 05 Oct 2011) Log Message WTR needs an implementation for eventSender.continuousMouseScrollBy https://bugs.webkit.org/show_bug.cgi?id=69417 Unreviewed gardening: skip dependent test. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (96698 => 96699) --- trunk/LayoutTests/ChangeLog 2011-10-05 13:08:51 UTC (rev 96698) +++ trunk/LayoutTests/ChangeLog 2011-10-05 13:53:49 UTC (rev 96699) @@ -1,3 +1,12 @@ +2011-10-05 Balazs Kelemen + +WTR needs an implementation for eventSender.continuousMouseScrollBy +https://bugs.webkit.org/show_bug.cgi?id=69417 + +Unreviewed gardening: skip dependent test. + +* platform/wk2/Skipped: + 2011-10-05 Ilya Tikhonovsky Unreviewed rebaseline for test. Modified: trunk/LayoutTests/platform/wk2/Skipped (96698 => 96699) --- trunk/LayoutTests/platform/wk2/Skipped 2011-10-05 13:08:51 UTC (rev 96698) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-10-05 13:53:49 UTC (rev 96699) @@ -1117,6 +1117,10 @@ editing/input/password-echo-passnode3.html editing/input/password-echo-textnode.html +# WTR needs an implementation for eventSender.continuousMouseScrollBy +# https://bugs.webkit.org/show_bug.cgi?id=69417 +fast/events/wheelevent-direction-inverted-from-device.html + ### END OF (2) Classified failures without bug reports (yet) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96698] trunk/Tools
Title: [96698] trunk/Tools
Revision 96698
Author kbal...@webkit.org
Date 2011-10-05 06:08:51 -0700 (Wed, 05 Oct 2011)
Log Message
[Qt][WK2] Unreviewed build fix.
Don't use WebCore directly in WTR.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (96697 => 96698)
--- trunk/Tools/ChangeLog 2011-10-05 12:21:19 UTC (rev 96697)
+++ trunk/Tools/ChangeLog 2011-10-05 13:08:51 UTC (rev 96698)
@@ -1,3 +1,14 @@
+2011-10-05 Balazs Kelemen
+
+[Qt][WK2] Unreviewed build fix.
+
+Don't use WebCore directly in WTR.
+
+* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+(WTR::PlatformWebView::addChromeInputField):
+(WTR::PlatformWebView::removeChromeInputField):
+(WTR::PlatformWebView::makeWebViewFirstResponder):
+
2011-10-05 David Levin
watchlist: Add more rules for chromium public api and sort the file.
Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (96697 => 96698)
--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-10-05 12:21:19 UTC (rev 96697)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-10-05 13:08:51 UTC (rev 96698)
@@ -32,7 +32,6 @@
#include
#include
#include
-#include
namespace WTR {
@@ -121,17 +120,14 @@
void PlatformWebView::addChromeInputField()
{
-notImplemented();
}
void PlatformWebView::removeChromeInputField()
{
-notImplemented();
}
void PlatformWebView::makeWebViewFirstResponder()
{
-notImplemented();
}
} // namespace WTR
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96697] trunk/Source/WebCore
Title: [96697] trunk/Source/WebCore Revision 96697 Author loi...@chromium.org Date 2011-10-05 05:21:19 -0700 (Wed, 05 Oct 2011) Log Message Unreviewed build fix for windows bots after r96679. * html/NumberInputType.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/NumberInputType.h Diff Modified: trunk/Source/WebCore/ChangeLog (96696 => 96697) --- trunk/Source/WebCore/ChangeLog 2011-10-05 12:03:03 UTC (rev 96696) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 12:21:19 UTC (rev 96697) @@ -1,3 +1,9 @@ +2011-10-05 Ilya Tikhonovsky + +Unreviewed build fix for windows bots after r96679. + +* html/NumberInputType.h: + 2011-10-04 Pavel Feldman Web Inspector: make ResourceView(s) compile Modified: trunk/Source/WebCore/html/NumberInputType.h (96696 => 96697) --- trunk/Source/WebCore/html/NumberInputType.h 2011-10-05 12:03:03 UTC (rev 96696) +++ trunk/Source/WebCore/html/NumberInputType.h 2011-10-05 12:21:19 UTC (rev 96697) @@ -64,7 +64,7 @@ virtual double parseToDoubleWithDecimalPlaces(const String&, double, unsigned*) const; virtual String serialize(double) const; virtual double acceptableError(double) const; -virtual void handleBlurEvent() OVERRIDE; +virtual void handleBlurEvent(); virtual String visibleValue() const; virtual String convertFromVisibleValue(const String&) const; virtual bool isAcceptableValue(const String&); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96696] trunk/LayoutTests
Title: [96696] trunk/LayoutTests Revision 96696 Author loi...@chromium.org Date 2011-10-05 05:03:03 -0700 (Wed, 05 Oct 2011) Log Message Unreviewed rebaseline for test. * inspector/debugger/linkifier-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/debugger/linkifier-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (96695 => 96696) --- trunk/LayoutTests/ChangeLog 2011-10-05 11:55:41 UTC (rev 96695) +++ trunk/LayoutTests/ChangeLog 2011-10-05 12:03:03 UTC (rev 96696) @@ -1,3 +1,9 @@ +2011-10-05 Ilya Tikhonovsky + +Unreviewed rebaseline for test. + +* inspector/debugger/linkifier-expected.txt: + 2011-10-04 Ilya Tikhonovsky Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances. Modified: trunk/LayoutTests/inspector/debugger/linkifier-expected.txt (96695 => 96696) --- trunk/LayoutTests/inspector/debugger/linkifier-expected.txt 2011-10-05 11:55:41 UTC (rev 96695) +++ trunk/LayoutTests/inspector/debugger/linkifier-expected.txt 2011-10-05 12:03:03 UTC (rev 96696) @@ -23,6 +23,6 @@ --- location update --- original location: linkifier.html:93 -pretty printed location: linkifier.html:99 +pretty printed location: linkifier.html:98 reverted location: linkifier.html:93 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96695] trunk/Source/WebCore
Title: [96695] trunk/Source/WebCore Revision 96695 Author pfeld...@chromium.org Date 2011-10-05 04:55:41 -0700 (Wed, 05 Oct 2011) Log Message Web Inspector: make ResourceView(s) compile https://bugs.webkit.org/show_bug.cgi?id=69351 Reviewed by Yury Semikhatsky. * inspector/compile-front-end.sh: * inspector/front-end/CookiesTable.js: (WebInspector.CookiesTable.prototype._sortCookies): * inspector/front-end/DataGrid.js: * inspector/front-end/EmptyView.js: * inspector/front-end/FontView.js: (WebInspector.FontView.prototype._createContentIfNeeded): * inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): (WebInspector.ImageView.prototype._createContentIfNeeded): (WebInspector.ImageView.prototype._openInNewTab): * inspector/front-end/NetworkItemView.js: * inspector/front-end/ResourceCookiesView.js: * inspector/front-end/ResourceHTMLView.js: (WebInspector.ResourceHTMLView.prototype.hide): * inspector/front-end/ResourceHeadersView.js: (WebInspector.ResourceHeadersView.prototype._refreshParms): (WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): (WebInspector.ResourceHeadersView.prototype._refreshHeaders): (WebInspector.ResourceHeadersView.prototype._refreshHeadersText): * inspector/front-end/ResourceJSONView.js: (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP): * inspector/front-end/ResourcePreviewView.js: * inspector/front-end/ResourceResponseView.js: * inspector/front-end/ResourceTimingView.js: (WebInspector.ResourceTimingView.createTimingTable): * inspector/front-end/ResourceView.js: (WebInspector.ResourceSourceFrame): * inspector/front-end/SourceFrame.js: * inspector/front-end/TabbedPane.js: * inspector/front-end/UIUtils.js: (Number.secondsToString): (Number.bytesToString): * inspector/front-end/inspector.js: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/compile-front-end.sh trunk/Source/WebCore/inspector/front-end/CookiesTable.js trunk/Source/WebCore/inspector/front-end/DataGrid.js trunk/Source/WebCore/inspector/front-end/EmptyView.js trunk/Source/WebCore/inspector/front-end/FontView.js trunk/Source/WebCore/inspector/front-end/ImageView.js trunk/Source/WebCore/inspector/front-end/NetworkItemView.js trunk/Source/WebCore/inspector/front-end/ResourceCookiesView.js trunk/Source/WebCore/inspector/front-end/ResourceHTMLView.js trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js trunk/Source/WebCore/inspector/front-end/ResourceJSONView.js trunk/Source/WebCore/inspector/front-end/ResourcePreviewView.js trunk/Source/WebCore/inspector/front-end/ResourceResponseView.js trunk/Source/WebCore/inspector/front-end/ResourceTimingView.js trunk/Source/WebCore/inspector/front-end/ResourceView.js trunk/Source/WebCore/inspector/front-end/SourceFrame.js trunk/Source/WebCore/inspector/front-end/TabbedPane.js trunk/Source/WebCore/inspector/front-end/UIUtils.js trunk/Source/WebCore/inspector/front-end/inspector.js Diff Modified: trunk/Source/WebCore/ChangeLog (96694 => 96695) --- trunk/Source/WebCore/ChangeLog 2011-10-05 11:41:07 UTC (rev 96694) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 11:55:41 UTC (rev 96695) @@ -1,3 +1,45 @@ +2011-10-04 Pavel Feldman + +Web Inspector: make ResourceView(s) compile +https://bugs.webkit.org/show_bug.cgi?id=69351 + +Reviewed by Yury Semikhatsky. + +* inspector/compile-front-end.sh: +* inspector/front-end/CookiesTable.js: +(WebInspector.CookiesTable.prototype._sortCookies): +* inspector/front-end/DataGrid.js: +* inspector/front-end/EmptyView.js: +* inspector/front-end/FontView.js: +(WebInspector.FontView.prototype._createContentIfNeeded): +* inspector/front-end/ImageView.js: +(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad): +(WebInspector.ImageView.prototype._createContentIfNeeded): +(WebInspector.ImageView.prototype._openInNewTab): +* inspector/front-end/NetworkItemView.js: +* inspector/front-end/ResourceCookiesView.js: +* inspector/front-end/ResourceHTMLView.js: +(WebInspector.ResourceHTMLView.prototype.hide): +* inspector/front-end/ResourceHeadersView.js: +(WebInspector.ResourceHeadersView.prototype._refreshParms): +(WebInspector.ResourceHeadersView.prototype._refreshHeadersTitle): +(WebInspector.ResourceHeadersView.prototype._refreshHeaders): +(WebInspector.ResourceHeadersView.prototype._refreshHeadersText): +* inspector/front-end/ResourceJSONView.js: +(WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.parseJSONP): +* inspector/front-end/ResourcePreviewView.js: +* inspector/front-end/ResourceResponseView.js: +* inspector/front-end/ResourceTimingView.js: +(WebInspector.ResourceTimingView.createTimingTable): +* inspector/front-end/ResourceView.js: +(
[webkit-changes] [96693] trunk/Source/WebCore
Title: [96693] trunk/Source/WebCore
Revision 96693
Author andreas.kl...@nokia.com
Date 2011-10-05 04:38:51 -0700 (Wed, 05 Oct 2011)
Log Message
REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
https://bugs.webkit.org/show_bug.cgi?id=64914
Reviewed by Antti Koivisto.
Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
since nobody is using them anymore. nextOnLineExists() is still used by
GTK+ accessibility code.
Also added a compile-time assertion to guard against future bloating of
the InlineBox class.
* rendering/InlineBox.cpp:
(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/InlineBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96692 => 96693)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 11:24:20 UTC (rev 96692)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 11:38:51 UTC (rev 96693)
@@ -1,3 +1,22 @@
+2011-10-03 Andreas Kling
+
+REGRESSION(r82611) InlineBox has 33 bits of bitset, causing alignment issues and extra memory use.
+https://bugs.webkit.org/show_bug.cgi?id=64914
+
+Reviewed by Antti Koivisto.
+
+Remove InlineBox::prevOnLineExists() and its two accompanying bitfields
+since nobody is using them anymore. nextOnLineExists() is still used by
+GTK+ accessibility code.
+
+Also added a compile-time assertion to guard against future bloating of
+the InlineBox class.
+
+* rendering/InlineBox.cpp:
+(WebCore::SameSizeAsInlineBox::~SameSizeAsInlineBox):
+* rendering/InlineBox.h:
+(WebCore::InlineBox::InlineBox):
+
2011-10-05 Andreas Kling
Shrink FontFallbackList.
Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (96692 => 96693)
--- trunk/Source/WebCore/rendering/InlineBox.cpp 2011-10-05 11:24:20 UTC (rev 96692)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2011-10-05 11:38:51 UTC (rev 96693)
@@ -34,8 +34,25 @@
using namespace std;
namespace WebCore {
-
+
+#if !COMPILER(MSVC)
+// FIXME: Figure out why this doesn't work on MSVC.
+class SameSizeAsInlineBox {
+virtual ~SameSizeAsInlineBox() { }
+void* a[4];
+FloatPoint b;
+float c;
+uint32_t d : 31;
+bool e : 1;
#ifndef NDEBUG
+bool f;
+#endif
+};
+
+COMPILE_ASSERT(sizeof(InlineBox) == sizeof(SameSizeAsInlineBox), InlineBox_size_guard);
+#endif
+
+#ifndef NDEBUG
static bool inInlineBoxDetach;
#endif
@@ -258,21 +275,6 @@
return m_nextOnLineExists;
}
-bool InlineBox::prevOnLineExists() const
-{
-if (!m_determinedIfPrevOnLineExists) {
-m_determinedIfPrevOnLineExists = true;
-
-if (!parent())
-m_prevOnLineExists = false;
-else if (prevOnLine())
-m_prevOnLineExists = true;
-else
-m_prevOnLineExists = parent()->prevOnLineExists();
-}
-return m_prevOnLineExists;
-}
-
InlineBox* InlineBox::nextLeafChild() const
{
InlineBox* leaf = 0;
Modified: trunk/Source/WebCore/rendering/InlineBox.h (96692 => 96693)
--- trunk/Source/WebCore/rendering/InlineBox.h 2011-10-05 11:24:20 UTC (rev 96692)
+++ trunk/Source/WebCore/rendering/InlineBox.h 2011-10-05 11:38:51 UTC (rev 96693)
@@ -56,9 +56,7 @@
, m_dirOverride(false)
, m_isText(false)
, m_determinedIfNextOnLineExists(false)
-, m_determinedIfPrevOnLineExists(false)
, m_nextOnLineExists(false)
-, m_prevOnLineExists(false)
, m_expansion(0)
#ifndef NDEBUG
, m_hasBadParent(false)
@@ -90,9 +88,7 @@
, m_dirOverride(false)
, m_isText(false)
, m_determinedIfNextOnLineExists(false)
-, m_determinedIfPrevOnLineExists(false)
, m_nextOnLineExists(false)
-, m_prevOnLineExists(false)
, m_expansion(0)
#ifndef NDEBUG
, m_hasBadParent(false)
@@ -203,7 +199,6 @@
m_prev = prev;
}
bool nextOnLineExists() const;
-bool prevOnLineExists() const;
virtual bool isLeaf() const { return true; }
@@ -364,9 +359,7 @@
bool m_isText : 1; // Whether or not this object represents text with a non-zero height. Includes non-image list markers, text boxes.
protected:
mutable bool m_determinedIfNextOnLineExists : 1;
-mutable bool m_determinedIfPrevOnLineExists : 1;
mutable bool m_nextOnLineExists : 1;
-mutable bool m_prevOnLineExists : 1;
signed m_expansion : 11; // for justified text
#ifndef NDEBUG
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96692] trunk/Source/WebCore
Title: [96692] trunk/Source/WebCore Revision 96692 Author andreas.kl...@nokia.com Date 2011-10-05 04:24:20 -0700 (Wed, 05 Oct 2011) Log Message Shrink FontFallbackList. https://bugs.webkit.org/show_bug.cgi?id=69093 Rubber-stamped by Antti Koivisto. Workaround MSVC quirk by making enum bitfield "unsigned". * platform/graphics/FontFallbackList.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/FontFallbackList.h Diff Modified: trunk/Source/WebCore/ChangeLog (96691 => 96692) --- trunk/Source/WebCore/ChangeLog 2011-10-05 11:19:39 UTC (rev 96691) +++ trunk/Source/WebCore/ChangeLog 2011-10-05 11:24:20 UTC (rev 96692) @@ -1,5 +1,16 @@ 2011-10-05 Andreas Kling +Shrink FontFallbackList. +https://bugs.webkit.org/show_bug.cgi?id=69093 + +Rubber-stamped by Antti Koivisto. + +Workaround MSVC quirk by making enum bitfield "unsigned". + +* platform/graphics/FontFallbackList.h: + +2011-10-05 Andreas Kling + Shrink StyleRareNonInheritedData. https://bugs.webkit.org/show_bug.cgi?id=69331 Modified: trunk/Source/WebCore/platform/graphics/FontFallbackList.h (96691 => 96692) --- trunk/Source/WebCore/platform/graphics/FontFallbackList.h 2011-10-05 11:19:39 UTC (rev 96691) +++ trunk/Source/WebCore/platform/graphics/FontFallbackList.h 2011-10-05 11:24:20 UTC (rev 96692) @@ -89,7 +89,7 @@ RefPtr m_fontSelector; mutable int m_familyIndex; unsigned short m_generation; -mutable Pitch m_pitch : 3; +mutable unsigned m_pitch : 3; // Pitch mutable bool m_loadingCustomFonts : 1; friend class Font; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96691] trunk/Source/WebCore
Title: [96691] trunk/Source/WebCore
Revision 96691
Author andreas.kl...@nokia.com
Date 2011-10-05 04:19:39 -0700 (Wed, 05 Oct 2011)
Log Message
Shrink StyleRareNonInheritedData.
https://bugs.webkit.org/show_bug.cgi?id=69331
Reviewed by Darin Adler.
Workaround MSVC quirk by making enum bitfields "unsigned".
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::regionOverflow):
(WebCore::InheritedFlags::transformStyle3D):
(WebCore::InheritedFlags::backfaceVisibility):
(WebCore::InheritedFlags::pageSizeType):
* rendering/style/StyleRareNonInheritedData.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (96690 => 96691)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 10:32:28 UTC (rev 96690)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 11:19:39 UTC (rev 96691)
@@ -1,3 +1,19 @@
+2011-10-05 Andreas Kling
+
+Shrink StyleRareNonInheritedData.
+https://bugs.webkit.org/show_bug.cgi?id=69331
+
+Reviewed by Darin Adler.
+
+Workaround MSVC quirk by making enum bitfields "unsigned".
+
+* rendering/style/RenderStyle.h:
+(WebCore::InheritedFlags::regionOverflow):
+(WebCore::InheritedFlags::transformStyle3D):
+(WebCore::InheritedFlags::backfaceVisibility):
+(WebCore::InheritedFlags::pageSizeType):
+* rendering/style/StyleRareNonInheritedData.h:
+
2011-10-05 Pavel Feldman
Web Inspector: add CSS model classes to the compilation.
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (96690 => 96691)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-10-05 10:32:28 UTC (rev 96690)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2011-10-05 11:19:39 UTC (rev 96691)
@@ -802,7 +802,7 @@
const AtomicString& flowThread() const { return rareNonInheritedData->m_flowThread; }
const AtomicString& regionThread() const { return rareNonInheritedData->m_regionThread; }
int regionIndex() const { return rareNonInheritedData->m_regionIndex; }
-RegionOverflow regionOverflow() const { return rareNonInheritedData->m_regionOverflow; }
+RegionOverflow regionOverflow() const { return static_cast(rareNonInheritedData->m_regionOverflow); }
// Apple-specific property getter methods
EPointerEvents pointerEvents() const { return static_cast(inherited_flags._pointerEvents); }
@@ -818,16 +818,16 @@
// return the first found Animation (including 'all' transitions)
const Animation* transitionForProperty(int property) const;
-ETransformStyle3D transformStyle3D() const { return rareNonInheritedData->m_transformStyle3D; }
+ETransformStyle3D transformStyle3D() const { return static_cast(rareNonInheritedData->m_transformStyle3D); }
bool preserves3D() const { return rareNonInheritedData->m_transformStyle3D == TransformStyle3DPreserve3D; }
-EBackfaceVisibility backfaceVisibility() const { return rareNonInheritedData->m_backfaceVisibility; }
+EBackfaceVisibility backfaceVisibility() const { return static_cast(rareNonInheritedData->m_backfaceVisibility); }
float perspective() const { return rareNonInheritedData->m_perspective; }
bool hasPerspective() const { return rareNonInheritedData->m_perspective > 0; }
Length perspectiveOriginX() const { return rareNonInheritedData->m_perspectiveOriginX; }
Length perspectiveOriginY() const { return rareNonInheritedData->m_perspectiveOriginY; }
LengthSize pageSize() const { return rareNonInheritedData->m_pageSize; }
-PageSizeType pageSizeType() const { return rareNonInheritedData->m_pageSizeType; }
+PageSizeType pageSizeType() const { return static_cast(rareNonInheritedData->m_pageSizeType); }
#if USE(ACCELERATED_COMPOSITING)
// When set, this ensures that styles compare as different. Used during accelerated animations.
Modified: trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h (96690 => 96691)
--- trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2011-10-05 10:32:28 UTC (rev 96690)
+++ trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h 2011-10-05 11:19:39 UTC (rev 96691)
@@ -129,15 +129,15 @@
AtomicString m_flowThread;
AtomicString m_regionThread;
int m_regionIndex;
-RegionOverflow m_regionOverflow : 1;
+unsigned m_regionOverflow : 1; // RegionOverflow
unsigned m_regionBreakAfter : 2; // EPageBreak
unsigned m_regionBreakBefore : 2; // EPageBreak
unsigned m_regionBreakInside : 2; // EPageBreak
-PageSizeType m_pageSizeType : 2;
-ETransformStyle3D m_transformStyle3D : 1;
-EBackfaceVisibility m_backfaceVisibility : 1;
+unsigned m_pageSizeType : 2; // PageSizeType
+unsigned m_transformStyle3D : 1; // ETransformStyle3D
+unsigned m_backfaceVisibility : 1; // EBackfaceVisibility
unsigned userDrag : 2;
[webkit-changes] [96690] trunk/Source/JavaScriptCore
Title: [96690] trunk/Source/_javascript_Core
Revision 96690
Author par...@webkit.org
Date 2011-10-05 03:32:28 -0700 (Wed, 05 Oct 2011)
Log Message
Unreviewed WinCE build fix for r96595.
* wtf/Assertions.cpp:
RtlCaptureStackBackTrace() isn't available on WinCE.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Assertions.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (96689 => 96690)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-05 10:12:56 UTC (rev 96689)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-05 10:32:28 UTC (rev 96690)
@@ -1,3 +1,10 @@
+2011-10-05 Patrick Gansterer
+
+Unreviewed WinCE build fix for r96595.
+
+* wtf/Assertions.cpp:
+RtlCaptureStackBackTrace() isn't available on WinCE.
+
2011-10-04 Kent Tamura
Introduce feature flags for incomplete input types
Modified: trunk/Source/_javascript_Core/wtf/Assertions.cpp (96689 => 96690)
--- trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-10-05 10:12:56 UTC (rev 96689)
+++ trunk/Source/_javascript_Core/wtf/Assertions.cpp 2011-10-05 10:32:28 UTC (rev 96690)
@@ -170,7 +170,7 @@
{
#if OS(DARWIN) || OS(LINUX)
*size = backtrace(stack, *size);
-#elif OS(WINDOWS)
+#elif OS(WINDOWS) && !OS(WINCE)
// The CaptureStackBackTrace function is available in XP, but it is not defined
// in the Windows Server 2003 R2 Platform SDK. So, we'll grab the function
// through GetProcAddress.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96689] trunk/Source/WebCore
Title: [96689] trunk/Source/WebCore
Revision 96689
Author pfeld...@chromium.org
Date 2011-10-05 03:12:56 -0700 (Wed, 05 Oct 2011)
Log Message
Web Inspector: add CSS model classes to the compilation.
https://bugs.webkit.org/show_bug.cgi?id=69376
Patch by Pavel Feldman on 2011-10-05
Reviewed by Yury Semikhatsky.
* inspector/compile-front-end.sh:
* inspector/front-end/CSSCompletions.js:
* inspector/front-end/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleDeclaration):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):
* inspector/front-end/ResourceTreeModel.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._containsInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
* inspector/front-end/externs.js:
(Array.prototype.keySet):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/compile-front-end.sh
trunk/Source/WebCore/inspector/front-end/CSSCompletions.js
trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js
trunk/Source/WebCore/inspector/front-end/CSSStyleModel.js
trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/externs.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (96688 => 96689)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 09:28:55 UTC (rev 96688)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 10:12:56 UTC (rev 96689)
@@ -1,3 +1,27 @@
+2011-10-05 Pavel Feldman
+
+Web Inspector: add CSS model classes to the compilation.
+https://bugs.webkit.org/show_bug.cgi?id=69376
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/compile-front-end.sh:
+* inspector/front-end/CSSCompletions.js:
+* inspector/front-end/CSSKeywordCompletions.js:
+(WebInspector.CSSKeywordCompletions.forProperty):
+* inspector/front-end/CSSStyleModel.js:
+(WebInspector.CSSStyleDeclaration):
+(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
+(WebInspector.CSSStyleModelResourceBinding.prototype.canSetContent):
+* inspector/front-end/ResourceTreeModel.js:
+* inspector/front-end/StylesSidebarPane.js:
+(WebInspector.StylesSidebarPane.prototype._containsInherited):
+(WebInspector.StylePropertiesSection.prototype.isPropertyInherited):
+(WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded):
+(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
+* inspector/front-end/externs.js:
+(Array.prototype.keySet):
+
2011-10-05 Kent Tamura
Input styles are unexpectedly shared regardless of required status difference.
Modified: trunk/Source/WebCore/inspector/compile-front-end.sh (96688 => 96689)
--- trunk/Source/WebCore/inspector/compile-front-end.sh 2011-10-05 09:28:55 UTC (rev 96688)
+++ trunk/Source/WebCore/inspector/compile-front-end.sh 2011-10-05 10:12:56 UTC (rev 96689)
@@ -44,12 +44,15 @@
--js Source/WebCore/inspector/front-end/Object.js \
--js Source/WebCore/inspector/front-end/Settings.js \
--js Source/WebCore/inspector/front-end/UserMetrics.js \
---module jsmodule_sdk:20:jsmodule_common \
+--module jsmodule_sdk:23:jsmodule_common \
--js Source/WebCore/inspector/front-end/CompilerSourceMapping.js \
--js Source/WebCore/inspector/front-end/CompilerSourceMappingProvider.js \
--js Source/WebCore/inspector/front-end/ConsoleModel.js \
--js Source/WebCore/inspector/front-end/ContentProviders.js \
--js Source/WebCore/inspector/front-end/CookieParser.js \
+--js Source/WebCore/inspector/front-end/CSSCompletions.js \
+--js Source/WebCore/inspector/front-end/CSSKeywordCompletions.js \
+--js Source/WebCore/inspector/front-end/CSSStyleModel.js \
--js Source/WebCore/inspector/front-end/BreakpointManager.js \
--js Source/WebCore/inspector/front-end/Database.js \
--js Source/WebCore/inspector/front-end/DOMAgent.js \
Modified: trunk/Source/WebCore/inspector/front-end/CSSCompletions.js (96688 => 96689)
--- trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2011-10-05 09:28:55 UTC (rev 96688)
+++ trunk/Source/WebCore/inspector/front-end/CSSCompletions.js 2011-10-05 10:12:56 UTC (rev 96689)
@@ -30,6 +30,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+/**
+ * @constructor
+ */
WebInspector.CSSCompletions = function(values, acceptEmptyPrefix)
{
this._values = values.slice();
Modified: trunk/Source/WebCore/inspec
[webkit-changes] [96688] trunk/Tools
Title: [96688] trunk/Tools
Revision 96688
Author le...@chromium.org
Date 2011-10-05 02:28:55 -0700 (Wed, 05 Oct 2011)
Log Message
watchlist: Add more rules for chromium public api and sort the file.
https://bugs.webkit.org/show_bug.cgi?id=69323
Reviewed by Adam Barth.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (96687 => 96688)
--- trunk/Tools/ChangeLog 2011-10-05 09:26:58 UTC (rev 96687)
+++ trunk/Tools/ChangeLog 2011-10-05 09:28:55 UTC (rev 96688)
@@ -1,5 +1,14 @@
2011-10-05 David Levin
+watchlist: Add more rules for chromium public api and sort the file.
+https://bugs.webkit.org/show_bug.cgi?id=69323
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/config/watchlist:
+
+2011-10-05 David Levin
+
watchlist: Don't add the same message to a bug more than once.
https://bugs.webkit.org/show_bug.cgi?id=69303
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (96687 => 96688)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 09:26:58 UTC (rev 96687)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2011-10-05 09:28:55 UTC (rev 96688)
@@ -1,9 +1,12 @@
# -*- mode: Python;-*-
{
"DEFINITIONS": {
-"WatchListScript": {
-"filename": r"Tools/Scripts/webkitpy/common/watchlist/.*",
+"ChromiumGraphics": {
+"filename": r"Source/WebCore/platform/graphics/chromium/.*",
},
+"ChromiumPublicApi": {
+"filename": r"Source/WebKit/chromium/public/.*"
+},
"ThreadingFiles": {
"filename": r"Source/_javascript_Core/wtf/ThreadSafeRefCounted\.h"
r"|Source/_javascript_Core/wtf/Threading\.h",
@@ -11,16 +14,21 @@
"ThreadingUsage": {
"more": r"deprecatedTurnOffVerifier|crossThreadString|threadsafeCopy|ThreadSafeRefCounted|CrossThreadRefCounted",
},
-"ChromiumGraphics": {
-"filename": r"Source/WebCore/platform/graphics/chromium/.*",
+"WatchListScript": {
+"filename": r"Tools/Scripts/webkitpy/common/watchlist/.*",
},
},
"CC_RULES": {
# Note: All email addresses listed must be registered with bugzilla.
# Specifically, le...@chromium.org and levin+thread...@chromium.org are
# two different accounts as far as bugzilla is concerned.
+"ChromiumGraphics": [ "jam...@chromium.org", ],
+"ChromiumPublicApi": [ "fi...@chromium.org", ],
+"ThreadingFiles|ThreadingUsage": [ "levin+thread...@chromium.org", ],
"WatchListScript": [ "levin+watchl...@chromium.org", ],
-"ThreadingFiles|ThreadingUsage": [ "levin+thread...@chromium.org", ],
-"ChromiumGraphics": [ "jam...@chromium.org", ],
},
+"MESSAGE_RULES": {
+"ChromiumPublicApi": [ "Please wait for approval from fi...@chromium.org before submitting "
+ "because this patch contains changes to the Chromium public API.", ],
+},
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96687] trunk/LayoutTests
Title: [96687] trunk/LayoutTests
Revision 96687
Author h...@chromium.org
Date 2011-10-05 02:26:58 -0700 (Wed, 05 Oct 2011)
Log Message
Rebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
for chromium-cg-mac after r96675. (By Garden-o-Matic.)
* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96686 => 96687)
--- trunk/LayoutTests/ChangeLog 2011-10-05 09:25:32 UTC (rev 96686)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 09:26:58 UTC (rev 96687)
@@ -1,3 +1,12 @@
+2011-10-05 Hans Wennborg
+
+Rebaseline fast/repaint/japanese-rl-selection-repaint-in-regions.html
+for chromium-cg-mac after r96675. (By Garden-o-Matic.)
+
+* platform/chromium-cg-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
+* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
+* platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
+
2011-10-05 Kent Tamura
Input styles are unexpectedly shared regardless of required status difference.
Modified: trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png
(Binary files differ)
Added: trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt (0 => 96687)
--- trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt 2011-10-05 09:26:58 UTC (rev 96687)
@@ -0,0 +1,32 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (754,0) size 46x600
+ RenderBlock {HTML} at (0,0) size 46x600 [border: (10px solid #80)]
+RenderBody {BODY} at (18,18) size 10x564 [border: (5px solid #00)]
+layer at (296,100) size 404x404
+ RenderRegion {DIV} at (100,100) size 404x404 [border: (2px solid #00)]
+Flow Threads
+ Thread with flow-name 'thread'
+layer at (400,0) size 400x400
+ RenderFlowThread at (0,0) size 400x400
+RenderBlock {DIV} at (0,0) size 480x400
+ RenderText {#text} at (5,0) size 469x388
+text run at (5,0) width 381: "\x{305B}\x{3063}\x{304B}\x{304F}\x{898B}\x{3064}\x{3051}\x{305F}\x{3059}\x{3070}\x{3089}\x{3057}\x{3044}\x{8A18}\x{4E8B}\x{304C}\x{3069}\x{3053}"
+text run at (37,0) width 381: "\x{306B}\x{3042}\x{3063}\x{305F}\x{304B}\x{5FD8}\x{308C}\x{3066}\x{3057}\x{307E}\x{3063}\x{305F}\x{7D4C}\x{9A13}\x{306F}\x{3042}\x{308A}\x{307E}"
+text run at (69,0) width 360: "\x{3059}\x{304B}\x{306A}\x{3089}\x{30BF}\x{30A4}\x{30C8}\x{30EB}\x{3068}\x{30A2}\x{30C9}\x{30EC}\x{30B9}\x{3060}\x{3051}\x{3067}\x{306A}"
+text run at (101,0) width 381: "\x{304F}\x{3001}\x{8A2A}\x{554F}\x{3057}\x{305F}\x{30A6}\x{30A7}\x{30D6}\x{30DA}\x{30FC}\x{30B8}\x{306E}\x{30B3}\x{30F3}\x{30C6}\x{30F3}\x{30C4}"
+text run at (133,0) width 381: "\x{304B}\x{3089}\x{3082}\x{691C}\x{7D22}\x{3059}\x{308B}\x{3053}\x{3068}\x{304C}\x{3067}\x{304D}\x{307E}\x{3059}\x{3002}\x{305B}\x{3063}\x{304B}"
+text run at (165,0) width 381: "\x{304F}\x{898B}\x{3064}\x{3051}\x{305F}\x{3059}\x{3070}\x{3089}\x{3057}\x{3044}\x{8A18}\x{4E8B}\x{304C}\x{3069}\x{3053}\x{306B}\x{3042}\x{3063}"
+text run at (197,0) width 388: "\x{305F}\x{304B}\x{5FD8}\x{308C}\x{3066}\x{3057}\x{307E}\x{3063}\x{305F}\x{7D4C}\x{9A13}\x{306F}\x{3042}\x{308A}\x{307E}\x{3059}\x{304B} \x{306A}"
+text run at (229,0) width 381: "\x{3089}\x{30BF}\x{30A4}\x{30C8}\x{30EB}\x{3068}\x{30A2}\x{30C9}\x{30EC}\x{30B9}\x{3060}\x{3051}\x{3067}\x{306A}\x{304F}\x{3001}\x{8A2A}\x{554F}"
+text run at (261,0) width 381: "\x{3057}\x{305F}\x{30A6}\x{30A7}\x{30D6}\x{30DA}\x{30FC}\x{30B8}\x{306E}\x{30B3}\x{30F3}\x{30C6}\x{30F3}\x{30C4}\x{304B}\x{3089}\x{3082}\x{691C}"
+text run at (293,0) width 381: "\x{7D22}\x{3059}\x{308B}\x{3053}\x{3068}\x{304C}\x{3067}\x{304D}\x{307E}\x{3059}\x{3002}\x{8A2A}\x{554F}\x{3057}\x{305F}\x{30A6}\x{30A7}\x{30D6}"
+text run at (325,0) width 381: "\x{30DA}\x{30FC}\x{30B8}\x{306E}\x{30B3}\x{30F3}\x{30C6}\x{30F3}\x{3
[webkit-changes] [96686] trunk
Title: [96686] trunk
Revision 96686
Author tk...@chromium.org
Date 2011-10-05 02:25:32 -0700 (Wed, 05 Oct 2011)
Log Message
Input styles are unexpectedly shared regardless of required status difference.
https://bugs.webkit.org/show_bug.cgi?id=69402
Reviewed by Daniel Bates.
Source/WebCore:
Tests: fast/css/pseudo-required-shared.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
LayoutTests:
* fast/css/pseudo-required-shared-expected.html: Added.
* fast/css/pseudo-required-shared.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html
trunk/LayoutTests/fast/css/pseudo-required-shared.html
Diff
Modified: trunk/LayoutTests/ChangeLog (96685 => 96686)
--- trunk/LayoutTests/ChangeLog 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 09:25:32 UTC (rev 96686)
@@ -1,3 +1,13 @@
+2011-10-05 Kent Tamura
+
+Input styles are unexpectedly shared regardless of required status difference.
+https://bugs.webkit.org/show_bug.cgi?id=69402
+
+Reviewed by Daniel Bates.
+
+* fast/css/pseudo-required-shared-expected.html: Added.
+* fast/css/pseudo-required-shared.html: Added.
+
2011-10-05 Gabor Rapcsanyi
[Qt] Unreviewed gardening, update expected file after r96509.
Added: trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html (0 => 96686)
--- trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css/pseudo-required-shared-expected.html 2011-10-05 09:25:32 UTC (rev 96686)
@@ -0,0 +1,7 @@
+
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/css/pseudo-required-shared.html (0 => 96686)
--- trunk/LayoutTests/fast/css/pseudo-required-shared.html (rev 0)
+++ trunk/LayoutTests/fast/css/pseudo-required-shared.html 2011-10-05 09:25:32 UTC (rev 96686)
@@ -0,0 +1,15 @@
+
+
+
+
+
+:required:valid {
+color: red;
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (96685 => 96686)
--- trunk/Source/WebCore/ChangeLog 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/Source/WebCore/ChangeLog 2011-10-05 09:25:32 UTC (rev 96686)
@@ -1,3 +1,15 @@
+2011-10-05 Kent Tamura
+
+Input styles are unexpectedly shared regardless of required status difference.
+https://bugs.webkit.org/show_bug.cgi?id=69402
+
+Reviewed by Daniel Bates.
+
+Tests: fast/css/pseudo-required-shared.html
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::canShareStyleWithControl): Check the difference of required().
+
2011-10-04 Kent Tamura
Remove Node::willBlur()
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (96685 => 96686)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-05 09:21:54 UTC (rev 96685)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-05 09:25:32 UTC (rev 96686)
@@ -790,13 +790,15 @@
return false;
if (thisInputElement->isIndeterminate() != otherInputElement->isIndeterminate())
return false;
+if (thisInputElement->required() != otherInputElement->required())
+return false;
if (element->isEnabledFormControl() != m_element->isEnabledFormControl())
return false;
if (element->isDefaultButtonForForm() != m_element->isDefaultButtonForForm())
return false;
-
+
if (!m_element->document()->containsValidityStyleRules())
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96685] trunk/Tools
Title: [96685] trunk/Tools
Revision 96685
Author le...@chromium.org
Date 2011-10-05 02:21:54 -0700 (Wed, 05 Oct 2011)
Log Message
watchlist: Don't add the same message to a bug more than once.
https://bugs.webkit.org/show_bug.cgi?id=69303
Reviewed by Adam Barth.
* Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
if a message is in the comments already.
* Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
Pick a bug supplied by the mock. Change the test due to different output
from the mock watch list tool.
* Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
another email so it will be filtered out, fix bugs to have the cc and comment fields,
and fix fetch_bug to handle bug_id's which are text (because that took me way too long
to debug).
* Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
and/or cc's that are already in the bug.
* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
and remove a comment that is filtered out.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug.py
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py
trunk/Tools/Scripts/webkitpy/tool/mocktool.py
trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py
trunk/Tools/Scripts/webkitpy/tool/steps/applywatchlist_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (96684 => 96685)
--- trunk/Tools/ChangeLog 2011-10-05 09:09:33 UTC (rev 96684)
+++ trunk/Tools/ChangeLog 2011-10-05 09:21:54 UTC (rev 96685)
@@ -1,3 +1,25 @@
+2011-10-05 David Levin
+
+watchlist: Don't add the same message to a bug more than once.
+https://bugs.webkit.org/show_bug.cgi?id=69303
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
+if a message is in the comments already.
+* Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
+* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
+Pick a bug supplied by the mock. Change the test due to different output
+from the mock watch list tool.
+* Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
+another email so it will be filtered out, fix bugs to have the cc and comment fields,
+and fix fetch_bug to handle bug_id's which are text (because that took me way too long
+to debug).
+* Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
+and/or cc's that are already in the bug.
+* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
+and remove a comment that is filtered out.
+
2011-10-05 Balazs Kelemen
[Qt][WK2] Unreviewed build fix after r96643.
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug.py (96684 => 96685)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug.py 2011-10-05 09:09:33 UTC (rev 96684)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug.py 2011-10-05 09:21:54 UTC (rev 96685)
@@ -116,3 +116,10 @@
def comments(self):
return self.bug_dictionary["comments"]
+
+def is_in_comments(self, message):
+for comment in self.comments():
+if message in comment["text"]:
+return True
+return False
+
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py (96684 => 96685)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py 2011-10-05 09:09:33 UTC (rev 96684)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py 2011-10-05 09:21:54 UTC (rev 96685)
@@ -38,3 +38,10 @@
self.assertTrue(bug.is_unassigned())
bug = Bug({"assigned_to_email": "t...@test.com"}, bugzilla=None)
self.assertFalse(bug.is_unassigned())
+
+def test_is_in_comments(self):
+bug = Bug({"comments": [{"text": "Message1."},
+{"text": "Message2. Message3. Message4."}, ], },
+ bugzilla=None)
+self.assertTrue(bug.is_in_comments("Message3."))
+self.assertFalse(bug.is_in_comments("Message."))
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py (96684 => 96685)
--- trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py 2011-10-05 09:09:33 UTC (rev 96684)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py 2011-10-05 09:21:54 UTC (rev 96685)
@@ -26,6 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
from webkitpy.tool.commands.commandtest import CommandsTest
from webkitpy.tool.comman
[webkit-changes] [96684] trunk/Tools
Title: [96684] trunk/Tools
Revision 96684
Author kbal...@webkit.org
Date 2011-10-05 02:09:33 -0700 (Wed, 05 Oct 2011)
Log Message
[Qt][WK2] Unreviewed build fix after r96643.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::addChromeInputField):
(WTR::PlatformWebView::removeChromeInputField):
(WTR::PlatformWebView::makeWebViewFirstResponder):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp
Diff
Modified: trunk/Tools/ChangeLog (96683 => 96684)
--- trunk/Tools/ChangeLog 2011-10-05 09:03:01 UTC (rev 96683)
+++ trunk/Tools/ChangeLog 2011-10-05 09:09:33 UTC (rev 96684)
@@ -1,3 +1,12 @@
+2011-10-05 Balazs Kelemen
+
+[Qt][WK2] Unreviewed build fix after r96643.
+
+* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+(WTR::PlatformWebView::addChromeInputField):
+(WTR::PlatformWebView::removeChromeInputField):
+(WTR::PlatformWebView::makeWebViewFirstResponder):
+
2011-10-04 Kent Tamura
Introduce feature flags for incomplete input types
Modified: trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp (96683 => 96684)
--- trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-10-05 09:03:01 UTC (rev 96683)
+++ trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp 2011-10-05 09:09:33 UTC (rev 96684)
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
namespace WTR {
@@ -118,6 +119,21 @@
QCoreApplication::postEvent(m_view, event);
}
+void PlatformWebView::addChromeInputField()
+{
+notImplemented();
+}
+
+void PlatformWebView::removeChromeInputField()
+{
+notImplemented();
+}
+
+void PlatformWebView::makeWebViewFirstResponder()
+{
+notImplemented();
+}
+
} // namespace WTR
#include "PlatformWebViewQt.moc"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [96683] trunk/LayoutTests
Title: [96683] trunk/LayoutTests
Revision 96683
Author rga...@webkit.org
Date 2011-10-05 02:03:01 -0700 (Wed, 05 Oct 2011)
Log Message
[Qt] Unreviewed gardening, update expected file after r96509.
* platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (96682 => 96683)
--- trunk/LayoutTests/ChangeLog 2011-10-05 08:21:59 UTC (rev 96682)
+++ trunk/LayoutTests/ChangeLog 2011-10-05 09:03:01 UTC (rev 96683)
@@ -1,5 +1,11 @@
2011-10-05 Gabor Rapcsanyi
+[Qt] Unreviewed gardening, update expected file after r96509.
+
+* platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt:
+
+2011-10-05 Gabor Rapcsanyi
+
[Qt] Unreviewed gardening.
* platform/qt-mac/Skipped: Skip new failing tests.
Modified: trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt (96682 => 96683)
--- trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt 2011-10-05 08:21:59 UTC (rev 96682)
+++ trunk/LayoutTests/platform/qt-4.8/tables/mozilla/bugs/bug113235-2-expected.txt 2011-10-05 09:03:01 UTC (rev 96683)
@@ -16,8 +16,8 @@
RenderInline {A} at (0,0) size 186x27
RenderText {#text} at (0,0) size 186x27
text run at (0,0) width 186: "Table of Contents"
-RenderTable {TABLE} at (0,43) size 4x4
- RenderTableSection {TBODY} at (0,0) size 4x4
-RenderTableRow {TR} at (0,2) size 4x0
+RenderTable {TABLE} at (0,43) size 2x4
+ RenderTableSection {TBODY} at (0,0) size 2x4
+RenderTableRow {TR} at (0,2) size 2x0
RenderBlock (anonymous) at (0,97) size 784x0
RenderInline {FONT} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
