[webkit-changes] [97044] trunk/Source/WebCore
Title: [97044] trunk/Source/WebCore
Revision 97044
Author yu...@chromium.org
Date 2011-10-10 00:15:15 -0700 (Mon, 10 Oct 2011)
Log Message
Missing m_notificationPresenter initialization in WorkerThread constructor
https://bugs.webkit.org/show_bug.cgi?id=69741
Added missing m_notificationPresenter(0)
Reviewed by Pavel Feldman.
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerThread.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97043 => 97044)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 05:57:49 UTC (rev 97043)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 07:15:15 UTC (rev 97044)
@@ -1,3 +1,15 @@
+2011-10-09 Yury Semikhatsky yu...@chromium.org
+
+Missing m_notificationPresenter initialization in WorkerThread constructor
+https://bugs.webkit.org/show_bug.cgi?id=69741
+
+Added missing m_notificationPresenter(0)
+
+Reviewed by Pavel Feldman.
+
+* workers/WorkerThread.cpp:
+(WebCore::WorkerThread::WorkerThread):
+
2011-10-09 Daniel Bates dba...@webkit.org
Another attempt to fix the Leopard Intel Debug build after changeset 97034 http://trac.webkit.org/changeset/97034
Modified: trunk/Source/WebCore/workers/WorkerThread.cpp (97043 => 97044)
--- trunk/Source/WebCore/workers/WorkerThread.cpp 2011-10-10 05:57:49 UTC (rev 97043)
+++ trunk/Source/WebCore/workers/WorkerThread.cpp 2011-10-10 07:15:15 UTC (rev 97044)
@@ -88,6 +88,9 @@
, m_workerLoaderProxy(workerLoaderProxy)
, m_workerReportingProxy(workerReportingProxy)
, m_startupData(WorkerThreadStartupData::create(scriptURL, userAgent, sourceCode))
+#if ENABLE(NOTIFICATIONS)
+, m_notificationPresenter(0)
+#endif
{
MutexLocker lock(threadCountMutex());
m_threadCount++;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97045] trunk/Source
Title: [97045] trunk/Source Revision 97045 Author andreas.kl...@nokia.com Date 2011-10-10 00:50:48 -0700 (Mon, 10 Oct 2011) Log Message Shrink BorderValue. https://bugs.webkit.org/show_bug.cgi?id=69521 Reviewed by Antti Koivisto. Source/_javascript_Core: * config.h: Touch to force full rebuild. Source/WebCore: Unroll BorderValue's Color member so we can pack the color's validity flag in BorderValue's bitfield. This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by 16 bytes. This reduces memory consumption by 760 kB when loading the full HTML5 spec. * platform/graphics/Color.h: (WebCore::Color::Color): Allow construction of Color objects with specific validity. * rendering/style/BorderValue.h: (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::isTransparent): (WebCore::BorderValue::operator==): (WebCore::BorderValue::setColor): (WebCore::BorderValue::color): * rendering/style/OutlineValue.h: (WebCore::OutlineValue::operator==): Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool. Made those variables private and added color(), setColor() accessors. * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderLeftColor): (WebCore::InheritedFlags::setBorderRightColor): (WebCore::InheritedFlags::setBorderTopColor): (WebCore::InheritedFlags::setBorderBottomColor): (WebCore::InheritedFlags::setOutlineColor): (WebCore::InheritedFlags::setColumnRuleColor): Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR when setting BorderValue colors. (WebCore::InheritedFlags::fillPaintColor): (WebCore::InheritedFlags::strokePaintColor): (WebCore::InheritedFlags::borderLeftColor): (WebCore::InheritedFlags::borderRightColor): (WebCore::InheritedFlags::borderTopColor): (WebCore::InheritedFlags::borderBottomColor): (WebCore::InheritedFlags::backgroundColor): (WebCore::InheritedFlags::color): (WebCore::InheritedFlags::columnRuleColor): (WebCore::InheritedFlags::outlineColor): (WebCore::InheritedFlags::textEmphasisColor): (WebCore::InheritedFlags::textFillColor): (WebCore::InheritedFlags::textStrokeColor): (WebCore::InheritedFlags::stopColor): (WebCore::InheritedFlags::floodColor): (WebCore::InheritedFlags::lightingColor): Made color getters return Color instead of const Color since BorderValue no longer has an actual object to return the reference to. * css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyColor::applyInheritValue): * page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperColor::PropertyWrapperColor): (WebCore::PropertyWrapperColor::blend): (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor): (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint): (WebCore::AnimationBase::ensurePropertyMap): Adapt to RenderStyle color getters now returning Color instead of const Color. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/config.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/page/animation/AnimationBase.cpp trunk/Source/WebCore/platform/graphics/Color.h trunk/Source/WebCore/rendering/style/BorderValue.h trunk/Source/WebCore/rendering/style/OutlineValue.h trunk/Source/WebCore/rendering/style/RenderStyle.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97044 => 97045) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 07:15:15 UTC (rev 97044) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 07:50:48 UTC (rev 97045) @@ -1,3 +1,12 @@ +2011-10-10 Andreas Kling kl...@webkit.org + +Shrink BorderValue. +https://bugs.webkit.org/show_bug.cgi?id=69521 + +Reviewed by Antti Koivisto. + +* config.h: Touch to force full rebuild. + 2011-10-09 Yuqiang Xian yuqiang.x...@intel.com Improve Null or Undefined test in 32_64 DFG Modified: trunk/Source/_javascript_Core/config.h (97044 => 97045) --- trunk/Source/_javascript_Core/config.h 2011-10-10 07:15:15 UTC (rev 97044) +++ trunk/Source/_javascript_Core/config.h 2011-10-10 07:50:48 UTC (rev 97045) @@ -109,7 +109,7 @@ // this breaks compilation of QFontDatabase, at least, so turn it off for now // Also generates errors on wx on Windows and QNX, because these functions -// are used from wx and QNX headers. +// are used from wx and QNX headers. #if !PLATFORM(QT) !PLATFORM(WX) !OS(QNX) #include wtf/DisallowCType.h #endif Modified: trunk/Source/WebCore/ChangeLog (97044 => 97045) --- trunk/Source/WebCore/ChangeLog 2011-10-10 07:15:15 UTC (rev 97044) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 07:50:48 UTC (rev 97045) @@ -1,3 +1,77 @@ +2011-10-06 Andreas Kling kl...@webkit.org + +Shrink BorderValue. +https://bugs.webkit.org/show_bug.cgi?id=69521 + +Reviewed by Antti Koivisto. + +Unroll BorderValue's Color member so we can pack the color's validity flag +in BorderValue's bitfield. + +This shrinks
[webkit-changes] [97046] trunk/Source
Title: [97046] trunk/Source Revision 97046 Author commit-qu...@webkit.org Date 2011-10-10 02:03:28 -0700 (Mon, 10 Oct 2011) Log Message Unreviewed, rolling out r97045. http://trac.webkit.org/changeset/97045 https://bugs.webkit.org/show_bug.cgi?id=69746 makes apple bots very crashy :( (Requested by kling on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-10 Source/_javascript_Core: * config.h: Source/WebCore: * css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyColor::applyInheritValue): * page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor): (WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint): (WebCore::AnimationBase::ensurePropertyMap): * platform/graphics/Color.h: (WebCore::Color::Color): * rendering/style/BorderValue.h: (WebCore::BorderValue::BorderValue): (WebCore::BorderValue::isTransparent): (WebCore::BorderValue::operator==): (WebCore::BorderValue::color): * rendering/style/OutlineValue.h: (WebCore::OutlineValue::operator==): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBorderLeftColor): (WebCore::InheritedFlags::setBorderRightColor): (WebCore::InheritedFlags::setBorderTopColor): (WebCore::InheritedFlags::setBorderBottomColor): (WebCore::InheritedFlags::setOutlineColor): (WebCore::InheritedFlags::setColumnRuleColor): (WebCore::InheritedFlags::fillPaintColor): (WebCore::InheritedFlags::strokePaintColor): (WebCore::InheritedFlags::borderLeftColor): (WebCore::InheritedFlags::borderRightColor): (WebCore::InheritedFlags::borderTopColor): (WebCore::InheritedFlags::borderBottomColor): (WebCore::InheritedFlags::backgroundColor): (WebCore::InheritedFlags::color): (WebCore::InheritedFlags::columnRuleColor): (WebCore::InheritedFlags::outlineColor): (WebCore::InheritedFlags::textEmphasisColor): (WebCore::InheritedFlags::textFillColor): (WebCore::InheritedFlags::textStrokeColor): (WebCore::InheritedFlags::stopColor): (WebCore::InheritedFlags::floodColor): (WebCore::InheritedFlags::lightingColor): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/config.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/page/animation/AnimationBase.cpp trunk/Source/WebCore/platform/graphics/Color.h trunk/Source/WebCore/rendering/style/BorderValue.h trunk/Source/WebCore/rendering/style/OutlineValue.h trunk/Source/WebCore/rendering/style/RenderStyle.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97045 => 97046) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 07:50:48 UTC (rev 97045) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 09:03:28 UTC (rev 97046) @@ -1,3 +1,14 @@ +2011-10-10 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r97045. +http://trac.webkit.org/changeset/97045 +https://bugs.webkit.org/show_bug.cgi?id=69746 + +makes apple bots very crashy :( (Requested by kling on +#webkit). + +* config.h: + 2011-10-10 Andreas Kling kl...@webkit.org Shrink BorderValue. Modified: trunk/Source/_javascript_Core/config.h (97045 => 97046) --- trunk/Source/_javascript_Core/config.h 2011-10-10 07:50:48 UTC (rev 97045) +++ trunk/Source/_javascript_Core/config.h 2011-10-10 09:03:28 UTC (rev 97046) @@ -109,7 +109,7 @@ // this breaks compilation of QFontDatabase, at least, so turn it off for now // Also generates errors on wx on Windows and QNX, because these functions -// are used from wx and QNX headers. +// are used from wx and QNX headers. #if !PLATFORM(QT) !PLATFORM(WX) !OS(QNX) #include wtf/DisallowCType.h #endif Modified: trunk/Source/WebCore/ChangeLog (97045 => 97046) --- trunk/Source/WebCore/ChangeLog 2011-10-10 07:50:48 UTC (rev 97045) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 09:03:28 UTC (rev 97046) @@ -1,3 +1,51 @@ +2011-10-10 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r97045. +http://trac.webkit.org/changeset/97045 +https://bugs.webkit.org/show_bug.cgi?id=69746 + +makes apple bots very crashy :( (Requested by kling on +#webkit). + +* css/CSSStyleApplyProperty.cpp: +(WebCore::ApplyPropertyColor::applyInheritValue): +* page/animation/AnimationBase.cpp: +(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor): +(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint): +(WebCore::AnimationBase::ensurePropertyMap): +* platform/graphics/Color.h: +(WebCore::Color::Color): +* rendering/style/BorderValue.h: +(WebCore::BorderValue::BorderValue): +(WebCore::BorderValue::isTransparent): +(WebCore::BorderValue::operator==): +(WebCore::BorderValue::color): +* rendering/style/OutlineValue.h: +(WebCore::OutlineValue::operator==): +* rendering/style/RenderStyle.h: +
[webkit-changes] [97047] trunk/Source/WebKit2
Title: [97047] trunk/Source/WebKit2
Revision 97047
Author carlo...@webkit.org
Date 2011-10-10 02:20:19 -0700 (Mon, 10 Oct 2011)
Log Message
[GTK] Add methods to reload the view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69613
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadReloadProvisionalLoadStarted):
(loadReloadLoadFinished):
(testLoadTimeoutFinishLoop):
(testLoadReload):
(main):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/testloading.c
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97046 => 97047)
--- trunk/Source/WebKit2/ChangeLog 2011-10-10 09:03:28 UTC (rev 97046)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-10 09:20:19 UTC (rev 97047)
@@ -1,3 +1,21 @@
+2011-10-10 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Add methods to reload the view to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=69613
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkit_web_view_reload):
+(webkit_web_view_reload_bypass_cache):
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/tests/testloading.c:
+(loadReloadProvisionalLoadStarted):
+(loadReloadLoadFinished):
+(testLoadTimeoutFinishLoop):
+(testLoadReload):
+(main):
+
2011-10-09 Luke Macpherson macpher...@chromium.org
Fix Lion, Leopard and Snow Leopard builds after changeset 97034 http://trac.webkit.org/changeset/97034
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (97046 => 97047)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-10 09:03:28 UTC (rev 97046)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-10 09:20:19 UTC (rev 97047)
@@ -252,6 +252,34 @@
}
/**
+ * webkit_web_view_reload:
+ * @web_view: a #WebKitWebView
+ *
+ * Reloads the current contents of @web_view.
+ * See also webkit_web_view_reload_bypass_cache().
+ */
+void webkit_web_view_reload(WebKitWebView* webView)
+{
+g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
+
+WKPageReload(toAPI(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView;
+}
+
+/**
+ * webkit_web_view_reload_bypass_cache:
+ * @webView: a #WebKitWebView
+ *
+ * Reloads the current contents of @web_view without
+ * using any cached data.
+ */
+void webkit_web_view_reload_bypass_cache(WebKitWebView* webView)
+{
+g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
+
+WKPageReloadFromOrigin(toAPI(webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView;
+}
+
+/**
* webkit_web_view_go_back:
* @web_view: a #WebKitWebView
*
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h (97046 => 97047)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h 2011-10-10 09:03:28 UTC (rev 97046)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h 2011-10-10 09:20:19 UTC (rev 97047)
@@ -96,6 +96,12 @@
const gchar *unreachable_uri);
WEBKIT_API void
+webkit_web_view_reload (WebKitWebView *web_view);
+
+WEBKIT_API void
+webkit_web_view_reload_bypass_cache (WebKitWebView *web_view);
+
+WEBKIT_API void
webkit_web_view_go_back (WebKitWebView *web_view);
WEBKIT_API void
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/testloading.c (97046 => 97047)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/testloading.c 2011-10-10 09:03:28 UTC (rev 97046)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/testloading.c 2011-10-10 09:20:19 UTC (rev 97047)
@@ -285,6 +285,65 @@
g_main_loop_run(fixture-loop);
}
+static gboolean loadReloadProvisionalLoadStarted(WebKitWebLoaderClient *client, WebLoadingFixture *fixture)
+{
+g_assert(!fixture-hasBeenProvisional);
+fixture-hasBeenProvisional = TRUE;
+
+return TRUE;
+}
+
+static gboolean loadReloadLoadFinished(WebKitWebLoaderClient *client, WebLoadingFixture *fixture)
+{
+g_assert(!fixture-hasBeenFinished);
+fixture-hasBeenFinished = TRUE;
+g_main_loop_quit(fixture-loop);
+
+return TRUE;
+}
+
+static gboolean testLoadTimeoutFinishLoop(WebLoadingFixture *fixture)
+{
+g_main_loop_quit(fixture-loop);
+
+return FALSE;
+}
+
+static void testLoadReload(WebLoadingFixture *fixture, gconstpointer data)
+{
+char *uriString;
+WebKitWebLoaderClient *client = webkit_web_view_get_loader_client(fixture-webView);
+
+g_signal_connect(client, provisional-load-started, G_CALLBACK(loadReloadProvisionalLoadStarted), fixture);
+g_signal_connect(client, load-finished, G_CALLBACK(loadReloadLoadFinished), fixture);
+
+/* Check nothing happens when there's
[webkit-changes] [97048] trunk/Source/WebKit2
Title: [97048] trunk/Source/WebKit2
Revision 97048
Author hausm...@webkit.org
Date 2011-10-10 02:21:41 -0700 (Mon, 10 Oct 2011)
Log Message
[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan
Reviewed by Andreas Kling.
Explicitly choose the qreal variant of qMin, since QPointF is using qreal.
* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97047 => 97048)
--- trunk/Source/WebKit2/ChangeLog 2011-10-10 09:20:19 UTC (rev 97047)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-10 09:21:41 UTC (rev 97048)
@@ -1,3 +1,14 @@
+2011-10-10 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan
+
+Reviewed by Andreas Kling.
+
+Explicitly choose the qreal variant of qMin, since QPointF is using qreal.
+
+* UIProcess/qt/ViewportInteractionEngine.cpp:
+(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):
+
2011-10-10 Carlos Garcia Campos cgar...@igalia.com
[GTK] Add methods to reload the view to WebKit2 GTK+ API
Modified: trunk/Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp (97047 => 97048)
--- trunk/Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp 2011-10-10 09:20:19 UTC (rev 97047)
+++ trunk/Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp 2011-10-10 09:21:41 UTC (rev 97048)
@@ -260,7 +260,7 @@
if (contentGeometry.width() m_viewport-width())
newPos.setX((m_viewport-width() - contentGeometry.width()) / 2);
else {
-newPos.setX(qMin(0., newPos.x()));
+newPos.setX(qMinqreal(0., newPos.x()));
const qreal rightSideGap = m_viewport-boundingRect().right() - contentGeometry.right();
if (rightSideGap 0.)
newPos.setX(newPos.x() + rightSideGap);
@@ -270,7 +270,7 @@
if (contentGeometry.height() m_viewport-height())
newPos.setY(0);
else {
-newPos.setY(qMin(0., newPos.y()));
+newPos.setY(qMinqreal(0., newPos.y()));
const qreal bottomSideGap = m_viewport-boundingRect().bottom() - contentGeometry.bottom();
if (bottomSideGap 0.)
newPos.setY(newPos.y() + bottomSideGap);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97050] trunk/Source/WebCore
Title: [97050] trunk/Source/WebCore
Revision 97050
Author loi...@chromium.org
Date 2011-10-10 02:54:02 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: small memory leak in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=69744
Scripts panel doesn't clean the list of child views.
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97049 => 97050)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 09:33:18 UTC (rev 97049)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 09:54:02 UTC (rev 97050)
@@ -1,3 +1,17 @@
+2011-10-10 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: small memory leak in scripts panel.
+https://bugs.webkit.org/show_bug.cgi?id=69744
+
+Scripts panel doesn't clean the list of child views.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
+
2011-10-07 Yury Semikhatsky yu...@chromium.org
Web Inspector: allow to start WorkerContext paused
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (97049 => 97050)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-10 09:33:18 UTC (rev 97049)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-10 09:54:02 UTC (rev 97050)
@@ -56,6 +56,7 @@
WebInspector.DebuggerPresentationModel.Events = {
UISourceCodeAdded: source-file-added,
UISourceCodeReplaced: source-file-replaced,
+UISourceCodeRemoved: source-file-removed,
ConsoleMessageAdded: console-message-added,
ConsoleMessagesCleared: console-messages-cleared,
BreakpointAdded: breakpoint-added,
@@ -430,8 +431,10 @@
_debuggerReset: function()
{
-for (var id in this._rawSourceCode)
+for (var id in this._rawSourceCode) {
+this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, this._rawSourceCode[id].sourceMapping.uiSourceCode);
this._rawSourceCode[id].removeAllListeners();
+}
this._rawSourceCode = {};
this._presentationCallFrames = [];
this._selectedCallFrame = null;
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (97049 => 97050)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-10-10 09:33:18 UTC (rev 97049)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-10-10 09:54:02 UTC (rev 97050)
@@ -171,6 +171,7 @@
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.UISourceCodeAdded, this._uiSourceCodeAdded, this)
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.UISourceCodeReplaced, this._uiSourceCodeReplaced, this);
+this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.ConsoleMessageAdded, this._consoleMessageAdded, this);
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.ConsoleMessagesCleared, this._consoleMessagesCleared, this);
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.BreakpointAdded, this._breakpointAdded, this);
@@ -253,6 +254,13 @@
this._showSourceFrameAndAddToHistory(uiSourceCode);
},
+_uiSourceCodeRemoved: function(event)
+{
+var uiSourceCode = event.data;
+if (uiSourceCode._sourceFrame)
+this.removeChildView(uiSourceCode._sourceFrame);
+},
+
_showScriptFoldersSettingChanged: function()
{
var selectedOption = this._filesSelectElement[this._filesSelectElement.selectedIndex];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97051] trunk/Source/WebCore
Title: [97051] trunk/Source/WebCore Revision 97051 Author podivi...@chromium.org Date 2011-10-10 03:08:08 -0700 (Mon, 10 Oct 2011) Log Message 2011-10-10 Pavel Podivilov podivi...@chromium.org Unreviewed, attempt to fix chromium mac build after r97034. * platform/ScrollAnimatorNone.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ScrollAnimatorNone.h Diff Modified: trunk/Source/WebCore/ChangeLog (97050 => 97051) --- trunk/Source/WebCore/ChangeLog 2011-10-10 09:54:02 UTC (rev 97050) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 10:08:08 UTC (rev 97051) @@ -1,3 +1,9 @@ +2011-10-10 Pavel Podivilov podivi...@chromium.org + +Unreviewed, attempt to fix chromium mac build after r97034. + +* platform/ScrollAnimatorNone.h: + 2011-10-10 Ilya Tikhonovsky loi...@chromium.org Web Inspector: small memory leak in scripts panel. Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.h (97050 => 97051) --- trunk/Source/WebCore/platform/ScrollAnimatorNone.h 2011-10-10 09:54:02 UTC (rev 97050) +++ trunk/Source/WebCore/platform/ScrollAnimatorNone.h 2011-10-10 10:08:08 UTC (rev 97051) @@ -150,7 +150,7 @@ double m_desiredTransY; }; -friend class ZoomData; +friend struct ZoomData; void animationTimerFired(TimerScrollAnimatorNone*); void stopAnimationTimerIfNeeded(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97052] trunk/Source/WebCore
Title: [97052] trunk/Source/WebCore
Revision 97052
Author andreas.kl...@nokia.com
Date 2011-10-10 03:14:25 -0700 (Mon, 10 Oct 2011)
Log Message
Shrink RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=69707
Reviewed by Antti Koivisto.
Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
Enum bitfields were changed to unsigned for the MSVC signedness quirk.
Also move one 32-bit member to the head of RootInlineBox so it falls into the
padding at the end of InlineFlowBox on 64-bit.
This reduces memory consumption by 780 kB (on 64-bit) when loading the full
HTML5 spec.
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineBreakBidiStatus):
* rendering/RootInlineBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineFlowBox.h
trunk/Source/WebCore/rendering/RootInlineBox.cpp
trunk/Source/WebCore/rendering/RootInlineBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97051 => 97052)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 10:08:08 UTC (rev 97051)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 10:14:25 UTC (rev 97052)
@@ -1,3 +1,27 @@
+2011-10-10 Andreas Kling kl...@webkit.org
+
+Shrink RootInlineBox.
+https://bugs.webkit.org/show_bug.cgi?id=69707
+
+Reviewed by Antti Koivisto.
+
+Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
+This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
+Enum bitfields were changed to unsigned for the MSVC signedness quirk.
+
+Also move one 32-bit member to the head of RootInlineBox so it falls into the
+padding at the end of InlineFlowBox on 64-bit.
+
+This reduces memory consumption by 780 kB (on 64-bit) when loading the full
+HTML5 spec.
+
+* rendering/InlineFlowBox.h:
+(WebCore::InlineFlowBox::InlineFlowBox):
+* rendering/RootInlineBox.cpp:
+(WebCore::RootInlineBox::RootInlineBox):
+(WebCore::RootInlineBox::lineBreakBidiStatus):
+* rendering/RootInlineBox.h:
+
2011-10-10 Pavel Podivilov podivi...@chromium.org
Unreviewed, attempt to fix chromium mac build after r97034.
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.h (97051 => 97052)
--- trunk/Source/WebCore/rendering/InlineFlowBox.h 2011-10-10 10:08:08 UTC (rev 97051)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.h 2011-10-10 10:14:25 UTC (rev 97052)
@@ -46,6 +46,9 @@
, m_includeLogicalLeftEdge(false)
, m_includeLogicalRightEdge(false)
, m_descendantsHaveSameLineHeightAndBaseline(true)
+, m_baselineType(AlphabeticBaseline)
+, m_hasAnnotationsBefore(false)
+, m_hasAnnotationsAfter(false)
#ifndef NDEBUG
, m_hasBadChildList(false)
#endif
@@ -296,7 +299,23 @@
bool m_hasTextDescendants : 1;
bool m_descendantsHaveSameLineHeightAndBaseline : 1;
+// The following members are only used by RootInlineBox but moved here to keep the bits packed.
+
+// Whether or not this line uses alphabetic or ideographic baselines by default.
+unsigned m_baselineType : 1; // FontBaseline
+
+// If the line contains any ruby runs, then this will be true.
+bool m_hasAnnotationsBefore : 1;
+bool m_hasAnnotationsAfter : 1;
+
+unsigned m_lineBreakBidiStatusEor : 5; // WTF::Unicode::Direction
+unsigned m_lineBreakBidiStatusLastStrong : 5; // WTF::Unicode::Direction
+unsigned m_lineBreakBidiStatusLast : 5; // WTF::Unicode::Direction
+
+// End of RootInlineBox-specific members.
+
#ifndef NDEBUG
+private:
bool m_hasBadChildList;
#endif
};
Modified: trunk/Source/WebCore/rendering/RootInlineBox.cpp (97051 => 97052)
--- trunk/Source/WebCore/rendering/RootInlineBox.cpp 2011-10-10 10:08:08 UTC (rev 97051)
+++ trunk/Source/WebCore/rendering/RootInlineBox.cpp 2011-10-10 10:14:25 UTC (rev 97052)
@@ -34,6 +34,7 @@
#include RenderArena.h
#include RenderBlock.h
#include VerticalPositionCache.h
+#include wtf/unicode/Unicode.h
using namespace std;
@@ -44,17 +45,14 @@
RootInlineBox::RootInlineBox(RenderBlock* block)
: InlineFlowBox(block)
-, m_lineBreakObj(0)
, m_lineBreakPos(0)
+, m_lineBreakObj(0)
, m_lineTop(0)
, m_lineBottom(0)
, m_lineTopWithLeading(0)
, m_lineBottomWithLeading(0)
, m_paginationStrut(0)
, m_paginatedLineWidth(0)
-, m_baselineType(AlphabeticBaseline)
-, m_hasAnnotationsBefore(false)
-, m_hasAnnotationsAfter(false)
{
setIsHorizontal(block-isHorizontalWritingMode());
}
@@ -514,7 +512,7 @@
BidiStatus RootInlineBox::lineBreakBidiStatus() const
{
-return BidiStatus(m_lineBreakBidiStatusEor, m_lineBreakBidiStatusLastStrong, m_lineBreakBidiStatusLast, m_lineBreakContext);
+
[webkit-changes] [97053] trunk/Source/WebKit/chromium
Title: [97053] trunk/Source/WebKit/chromium
Revision 97053
Author podivi...@chromium.org
Date 2011-10-10 04:27:59 -0700 (Mon, 10 Oct 2011)
Log Message
2011-10-10 Pavel Podivilov podivi...@chromium.org
Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.
* tests/CCThreadTest.cpp:
(WebKit::TEST):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97052 => 97053)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-10 10:14:25 UTC (rev 97052)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-10 11:27:59 UTC (rev 97053)
@@ -1,3 +1,10 @@
+2011-10-10 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.
+
+* tests/CCThreadTest.cpp:
+(WebKit::TEST):
+
2011-10-07 Yury Semikhatsky yu...@chromium.org
Web Inspector: allow to start WorkerContext paused
Modified: trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp (97052 => 97053)
--- trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-10 10:14:25 UTC (rev 97052)
+++ trunk/Source/WebKit/chromium/tests/CCThreadTest.cpp 2011-10-10 11:27:59 UTC (rev 97053)
@@ -86,7 +86,13 @@
bool hit;
};
-TEST(CCThreadTest, startPostAndWaitOnCondition)
+#if OS(WINDOWS) || OS(MAC_OS_X)
+#define MAYBE_startPostAndWaitOnCondition DISABLED_startPostAndWaitOnCondition
+#else
+#define MAYBE_startPostAndWaitOnCondition startPostAndWaitOnCondition
+#endif
+
+TEST(CCThreadTest, MAYBE_startPostAndWaitOnCondition)
{
OwnPtrWebThread webThread = adoptPtr(webKitPlatformSupport()-createThread(test));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97054] trunk/Source/WebCore
Title: [97054] trunk/Source/WebCore Revision 97054 Author andreas.kl...@nokia.com Date 2011-10-10 04:29:53 -0700 (Mon, 10 Oct 2011) Log Message Shrink RenderListItem on 64-bit. https://bugs.webkit.org/show_bug.cgi?id=69751 Reviewed by Kenneth Rohde Christiansen. Rearrange members to utilize the padding at the end of RenderBlock. This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption by 60 kB when loading the full HTML5 spec. * rendering/RenderListItem.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderListItem.h Diff Modified: trunk/Source/WebCore/ChangeLog (97053 => 97054) --- trunk/Source/WebCore/ChangeLog 2011-10-10 11:27:59 UTC (rev 97053) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 11:29:53 UTC (rev 97054) @@ -1,5 +1,18 @@ 2011-10-10 Andreas Kling kl...@webkit.org +Shrink RenderListItem on 64-bit. +https://bugs.webkit.org/show_bug.cgi?id=69751 + +Reviewed by Kenneth Rohde Christiansen. + +Rearrange members to utilize the padding at the end of RenderBlock. +This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption +by 60 kB when loading the full HTML5 spec. + +* rendering/RenderListItem.h: + +2011-10-10 Andreas Kling kl...@webkit.org + Shrink RootInlineBox. https://bugs.webkit.org/show_bug.cgi?id=69707 Modified: trunk/Source/WebCore/rendering/RenderListItem.h (97053 => 97054) --- trunk/Source/WebCore/rendering/RenderListItem.h 2011-10-10 11:27:59 UTC (rev 97053) +++ trunk/Source/WebCore/rendering/RenderListItem.h 2011-10-10 11:29:53 UTC (rev 97054) @@ -75,8 +75,8 @@ void updateValueNow() const; void explicitValueChanged(); +int m_explicitValue; RenderListMarker* m_marker; -int m_explicitValue; mutable int m_value; bool m_hasExplicitValue : 1; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97055] trunk/Source/WebCore
Title: [97055] trunk/Source/WebCore
Revision 97055
Author loi...@chromium.org
Date 2011-10-10 04:43:40 -0700 (Mon, 10 Oct 2011)
Log Message
Unreviewed test fix for r97050.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97054 => 97055)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 11:29:53 UTC (rev 97054)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 11:43:40 UTC (rev 97055)
@@ -1,3 +1,10 @@
+2011-10-10 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed test fix for r97050.
+
+* inspector/front-end/DebuggerPresentationModel.js:
+(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
+
2011-10-10 Andreas Kling kl...@webkit.org
Shrink RenderListItem on 64-bit.
Modified: trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js (97054 => 97055)
--- trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-10 11:29:53 UTC (rev 97054)
+++ trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js 2011-10-10 11:43:40 UTC (rev 97055)
@@ -432,7 +432,8 @@
_debuggerReset: function()
{
for (var id in this._rawSourceCode) {
-this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, this._rawSourceCode[id].sourceMapping.uiSourceCode);
+if (this._rawSourceCode[id].sourceMapping this._rawSourceCode[id].sourceMapping.uiSourceCode)
+this.dispatchEventToListeners(WebInspector.DebuggerPresentationModel.Events.UISourceCodeRemoved, this._rawSourceCode[id].sourceMapping.uiSourceCode);
this._rawSourceCode[id].removeAllListeners();
}
this._rawSourceCode = {};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97056] trunk
Title: [97056] trunk
Revision 97056
Author podivi...@chromium.org
Date 2011-10-10 05:40:19 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: saving _javascript_ after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340
Source/WebCore:
Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentChanged):
LayoutTests:
Reviewed by Yury Semikhatsky.
* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/ui-source-code-expected.txt:
* inspector/debugger/ui-source-code.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97055 => 97056)
--- trunk/LayoutTests/ChangeLog 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 12:40:19 UTC (rev 97056)
@@ -1,3 +1,16 @@
+2011-10-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: saving _javascript_ after live edit resets scroller position.
+https://bugs.webkit.org/show_bug.cgi?id=69340
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/raw-source-code-expected.txt:
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/scripts-panel.html:
+* inspector/debugger/ui-source-code-expected.txt:
+* inspector/debugger/ui-source-code.html:
+
2011-10-09 Adam Barth aba...@webkit.org
CSP should log unrecognized directives to the console
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt (97055 => 97056)
--- trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code-expected.txt 2011-10-10 12:40:19 UTC (rev 97056)
@@ -7,8 +7,6 @@
Running: testHTMLWithFinishedResource
-Running: testContentEdited
-
Running: testForceUpdateSourceMapping
Running: testFormattingWithFinishedResource
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97055 => 97056)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 11:43:40 UTC (rev 97055)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 12:40:19 UTC (rev 97056)
@@ -181,39 +181,6 @@
}
},
-function testContentEdited(next)
-{
-var script = createScriptMock(foo.js, 0, 0, true, script source);
-var resource = createFinishedResourceMock(script, resource content);
-var rawSourceCode = createRawSourceCode(script, resource);
-
-var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
-uiSourceCode.requestContent(didRequestContent);
-
-function didRequestContent(mimeType, content)
-{
-InspectorTest.assertEquals(text/_javascript_, mimeType);
-InspectorTest.assertEquals(resource content, content);
-
-waitForSourceMappingEvent(rawSourceCode, mappingReadyAfterEdit);
-resource.content = edited resource content;
-rawSourceCode.contentEdited();
-}
-
-function mappingReadyAfterEdit()
-{
-rawSourceCode.sourceMapping.uiSourceCode.requestContent(didRequestContentAfterEdit);
-}
-
-function didRequestContentAfterEdit(mimeType, content)
-{
-InspectorTest.assertEquals(mimeType, text/_javascript_);
-InspectorTest.assertEquals(edited resource content, content);
-next();
-}
-},
-
function testForceUpdateSourceMapping(next)
{
[webkit-changes] [97057] trunk/Source/WebCore
Title: [97057] trunk/Source/WebCore
Revision 97057
Author loi...@chromium.org
Date 2011-10-10 06:04:00 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: memory leak in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=69754
Reviewed by Yury Semikhatsky.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.reset):
* inspector/front-end/View.js:
(WebInspector.View.prototype.childViews):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
trunk/Source/WebCore/inspector/front-end/View.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (97056 => 97057)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 12:40:19 UTC (rev 97056)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 13:04:00 UTC (rev 97057)
@@ -1,3 +1,15 @@
+2011-10-10 Ilya Tikhonovsky loi...@chromium.org
+
+Web Inspector: memory leak in Resource panel.
+https://bugs.webkit.org/show_bug.cgi?id=69754
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.ResourcesPanel.prototype.reset):
+* inspector/front-end/View.js:
+(WebInspector.View.prototype.childViews):
+
2011-10-06 Pavel Podivilov podivi...@chromium.org
Web Inspector: saving _javascript_ after live edit resets scroller position.
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (97056 => 97057)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-10-10 12:40:19 UTC (rev 97056)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2011-10-10 13:04:00 UTC (rev 97057)
@@ -171,6 +171,10 @@
if (this.sidebarTree.selectedTreeElement)
this.sidebarTree.selectedTreeElement.deselect();
+
+var childViews = this.childViews();
+for (var i = 0; i childViews.length; ++i)
+this.removeChildView(childViews[i]);
},
_populateResourceTree: function()
Modified: trunk/Source/WebCore/inspector/front-end/View.js (97056 => 97057)
--- trunk/Source/WebCore/inspector/front-end/View.js 2011-10-10 12:40:19 UTC (rev 97056)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2011-10-10 13:04:00 UTC (rev 97057)
@@ -155,6 +155,11 @@
view._detach();
},
+childViews: function()
+{
+return this._children.slice();
+},
+
onResize: function()
{
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97058] trunk/Source/WebCore
Title: [97058] trunk/Source/WebCore
Revision 97058
Author carycl...@google.com
Date 2011-10-10 06:07:53 -0700 (Mon, 10 Oct 2011)
Log Message
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889
Reviewed by Stephen White.
Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.
Tests: fast/text/justify-ideograph-complex.html
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97057 => 97058)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 13:07:53 UTC (rev 97058)
@@ -1,3 +1,22 @@
+2011-10-10 Cary Clark carycl...@google.com
+
+[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
+https://bugs.webkit.org/show_bug.cgi?id=69656
+https://bugs.webkit.org/show_bug.cgi?id=62987
+https://bugs.webkit.org/show_bug.cgi?id=62889
+
+Reviewed by Stephen White.
+
+Skia on Linux and Windows uses different font engines from
+Skia on Mac. After determining that the underlying CoreText
+can handle it, enabling this allows justification to work
+correctly.
+
+Tests: fast/text/justify-ideograph-complex.html
+
+* platform/graphics/skia/FontSkia.cpp:
+(WebCore::Font::canExpandAroundIdeographsInComplexText):
+
2011-10-10 Ilya Tikhonovsky loi...@chromium.org
Web Inspector: memory leak in Resource panel.
Modified: trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp (97057 => 97058)
--- trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:04:00 UTC (rev 97057)
+++ trunk/Source/WebCore/platform/graphics/skia/FontSkia.cpp 2011-10-10 13:07:53 UTC (rev 97058)
@@ -49,12 +49,9 @@
return true;
}
-// FIXME: Determine if the Mac port of Chromium using Skia can expand around
-// ideographs in complex text. (The Windows and Linux ports for Chromium can't.)
-// This issue is tracked in https://bugs.webkit.org/show_bug.cgi?id=62987
bool Font::canExpandAroundIdeographsInComplexText()
{
-return false;
+return true;
}
static bool isCanvasMultiLayered(SkCanvas* canvas)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97059] branches/chromium/874
Title: [97059] branches/chromium/874
Revision 97059
Author pfeld...@chromium.org
Date 2011-10-10 06:24:59 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 96319 - Web Inspector: Scripts panel without folders causes errors when creating content scripts section.
https://bugs.webkit.org/show_bug.cgi?id=68827
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
LayoutTests:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* platform/chromium-win/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt: Removed.
* platform/mac/inspector/debugger/scripts-panel-expected.txt: Removed.
* platform/win/inspector/debugger/scripts-panel-expected.txt: Removed.
TBR=pfeld...@chromium.org
Review URL: http://codereview.chromium.org/8222004
Modified Paths
branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel-expected.txt
branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel.html
branches/chromium/874/LayoutTests/inspector/debugger/scripts-sorting-expected.txt
branches/chromium/874/LayoutTests/inspector/debugger/scripts-sorting.html
branches/chromium/874/Source/WebCore/inspector/front-end/ScriptsPanel.js
Removed Paths
branches/chromium/874/LayoutTests/platform/chromium/inspector/debugger/scripts-sorting-expected.txt
branches/chromium/874/LayoutTests/platform/chromium-win/inspector/debugger/scripts-panel-expected.txt
branches/chromium/874/LayoutTests/platform/mac/inspector/debugger/scripts-panel-expected.txt
branches/chromium/874/LayoutTests/platform/win/inspector/debugger/scripts-panel-expected.txt
Diff
Modified: branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel-expected.txt (97058 => 97059)
--- branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel-expected.txt 2011-10-10 13:07:53 UTC (rev 97058)
+++ branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel-expected.txt 2011-10-10 13:24:59 UTC (rev 97059)
@@ -28,6 +28,7 @@
LayoutTests/inspector/debugger/foo/baz
script.js(root/foo/baz/script.js)
— Content scripts —
+LayoutTests/inspector/debugger/foo/bar
contentScript.js?a=1(root/foo/bar/contentScript.js?a=1)
contentScript.js?a=2(root/foo/bar/contentScript.js?a=2)
contentScript2.js?a=1(root/foo/bar/contentScript2.js?a=1)
Modified: branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel.html (97058 => 97059)
--- branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel.html 2011-10-10 13:07:53 UTC (rev 97058)
+++ branches/chromium/874/LayoutTests/inspector/debugger/scripts-panel.html 2011-10-10 13:24:59 UTC (rev 97059)
@@ -6,6 +6,9 @@
function test()
{
+// Always use indentation in scripts drop box
+WebInspector._isMac = false;
+
function createDebuggerPresentationModelMock()
{
var model = new WebInspector.Object();
Modified: branches/chromium/874/LayoutTests/inspector/debugger/scripts-sorting-expected.txt (97058 => 97059)
--- branches/chromium/874/LayoutTests/inspector/debugger/scripts-sorting-expected.txt 2011-10-10 13:07:53 UTC (rev 97058)
+++ branches/chromium/874/LayoutTests/inspector/debugger/scripts-sorting-expected.txt 2011-10-10 13:24:59 UTC (rev 97059)
@@ -3,9 +3,81 @@
Debugger was enabled.
WebInspector.settings.showScriptFolders = true
+*Non*URL*path
+— bar.com —
+/foo/path
+bar.js?file=bar/zzz.js
+foo.js?file=bar/aaa.js
+— foo.com —
+block.js?block=foo
+ga.js
+lenta.ban?pg=4883ifr=1
+lenta.ban?pg=5309ifr=1
+top100.jcn?80674
+/_js/production
+motor.js?1308927432
+/foo/path
+bar.js?file=bar/zzz.js
+foo.js?file=bar/aaa.js
+/i
+xgemius.js
+/i/js
+jquery-1.5.1.min.js
+jquery.cookie.js
+— Content scripts —
+*Non*URL*path
+extension-name
+bar.js
+extension-name/folder
+baz.js
WebInspector.settings.showScriptFolders = false
+*Non*URL*path
+bar.js?file=bar/zzz.js
+bar.js?file=bar/zzz.js
+block.js?block=foo
+foo.js?file=bar/aaa.js
+foo.js?file=bar/aaa.js
+ga.js
+jquery-1.5.1.min.js
+jquery.cookie.js
+lenta.ban?pg=4883ifr=1
+lenta.ban?pg=5309ifr=1
+motor.js?1308927432
+top100.jcn?80674
+xgemius.js
+— Content scripts —
+*Non*URL*path
+extension-name/bar.js
+extension-name/folder/baz.js
WebInspector.settings.showScriptFolders = true
+*Non*URL*path
+— bar.com —
+/foo/path
+bar.js?file=bar/zzz.js
+foo.js?file=bar/aaa.js
+— foo.com —
+block.js?block=foo
+ga.js
+lenta.ban?pg=4883ifr=1
+lenta.ban?pg=5309ifr=1
+top100.jcn?80674
+/_js/production
+motor.js?1308927432
+/foo/path
+bar.js?file=bar/zzz.js
[webkit-changes] [97060] trunk/LayoutTests
Title: [97060] trunk/LayoutTests
Revision 97060
Author podivi...@chromium.org
Date 2011-10-10 07:06:25 -0700 (Mon, 10 Oct 2011)
Log Message
2011-10-10 Pavel Podivilov podivi...@chromium.org
Unreviewed, fix test after r97056.
* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt
trunk/LayoutTests/inspector/debugger/script-formatter.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97059 => 97060)
--- trunk/LayoutTests/ChangeLog 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 14:06:25 UTC (rev 97060)
@@ -1,3 +1,11 @@
+2011-10-10 Pavel Podivilov podivi...@chromium.org
+
+Unreviewed, fix test after r97056.
+
+* inspector/debugger/script-formatter-expected.txt:
+* inspector/debugger/script-formatter.html:
+* platform/chromium/test_expectations.txt:
+
2011-10-06 Pavel Podivilov podivi...@chromium.org
Web Inspector: saving _javascript_ after live edit resets scroller position.
Modified: trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt (97059 => 97060)
--- trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/inspector/debugger/script-formatter-expected.txt 2011-10-10 14:06:25 UTC (rev 97060)
@@ -18,18 +18,12 @@
Running: testBreakpointsInOriginalAndFormattedSource
Script execution paused.
-Call stack:
-0) f1 (script-formatter.html:12)
-1) (script-formatter.html:1)
Script execution resumed.
Page reloaded.
Navigated to test-navigation.html
Page reloaded.
Navigated back to test page.
Script execution paused.
-Call stack:
-0) f2 (script-formatter.html:17)
-1) (script-formatter.html:1)
Script execution resumed.
Running: testConsoleMessagesForFormattedScripts
Modified: trunk/LayoutTests/inspector/debugger/script-formatter.html (97059 => 97060)
--- trunk/LayoutTests/inspector/debugger/script-formatter.html 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/inspector/debugger/script-formatter.html 2011-10-10 14:06:25 UTC (rev 97060)
@@ -54,12 +54,12 @@
InspectorTest.showScriptSource(obfuscated.js, didShowScriptSource);
function didShowScriptSource(sourceFrame)
{
-formatter.formatContent(text/_javascript_, sourceFrame._content, didFormatContent);
+formatter.formatContent(text/_javascript_, sourceFrame._textModel.text, didFormatContent);
}
function didFormatContent(content, mapping)
{
-var source = WebInspector.panels.scripts.visibleView._content;
+var source = WebInspector.panels.scripts.visibleView._textModel.text;
var formattedSource = content;
function testMapping(string)
@@ -125,7 +125,7 @@
function pausedInF1(callFrames)
{
-InspectorTest.captureStackTrace(callFrames);
+InspectorTest.assertEquals(f1, callFrames[0].functionName);
InspectorTest.resumeExecution(resumed);
}
@@ -163,7 +163,7 @@
function pausedInF2(callFrames)
{
-InspectorTest.captureStackTrace(callFrames);
+InspectorTest.assertEquals(f2, callFrames[0].functionName);
panel._toggleFormatSource();
InspectorTest.resumeExecution(next);
}
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97059 => 97060)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 13:24:59 UTC (rev 97059)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 14:06:25 UTC (rev 97060)
@@ -156,7 +156,6 @@
WONTFIX SKIP : http/tests/eventsource/workers = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/websocket/tests/hixie76/workers/ = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/websocket/tests/hybi/workers/ = PASS TIMEOUT FAIL
-WONTFIX SKIP : inspector/debugger/script-formatter.html = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/inspector/network/network-shared-worker.html = PASS TIMEOUT FAIL
WONTFIX SKIP : http/tests/inspector/network/network-worker.html = PASS TIMEOUT FAIL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97061] trunk/LayoutTests
Title: [97061] trunk/LayoutTests Revision 97061 Author kbal...@webkit.org Date 2011-10-10 07:47:07 -0700 (Mon, 10 Oct 2011) Log Message Unreviewed gardening after r96958. https://bugs.webkit.org/show_bug.cgi?id=69757 Unreviewed gardening. Patch by Zsolt Fehér fehe...@inf.u-szeged.hu on 2011-10-10 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97060 => 97061) --- trunk/LayoutTests/ChangeLog 2011-10-10 14:06:25 UTC (rev 97060) +++ trunk/LayoutTests/ChangeLog 2011-10-10 14:47:07 UTC (rev 97061) @@ -1,3 +1,12 @@ +2011-10-10 Zsolt Fehér fehe...@inf.u-szeged.hu + +Unreviewed gardening after r96958. +https://bugs.webkit.org/show_bug.cgi?id=69757 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-10-10 Pavel Podivilov podivi...@chromium.org Unreviewed, fix test after r97056. Modified: trunk/LayoutTests/platform/qt/Skipped (97060 => 97061) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-10 14:06:25 UTC (rev 97060) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-10 14:47:07 UTC (rev 97061) @@ -2413,3 +2413,7 @@ # [Qt] fast/text/line-initial-and-final-swashes.html fails # https://bugs.webkit.org/show_bug.cgi?id=69719 fast/text/line-initial-and-final-swashes.html + +# [Qt] inspector/debugger/script-formatter.html failed after r97056 +# https://bugs.webkit.org/show_bug.cgi?id=69757 +inspector/debugger/script-formatter.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97062] trunk/Source/WebCore
Title: [97062] trunk/Source/WebCore
Revision 97062
Author andreas.kl...@nokia.com
Date 2011-10-10 07:51:44 -0700 (Mon, 10 Oct 2011)
Log Message
Shrink RenderLayer and ScrollableArea.
https://bugs.webkit.org/show_bug.cgi?id=69759
Reviewed by Antti Koivisto.
Rearrange the members of RenderLayer and its base class ScrollableArea
to maximize struct packing, shrinking RenderLayer by one CPU word on
32-bit (and two on 64-bit.)
This reduces memory consumption by 134 kB (on 64-bit) when loading the
full HTML5 spec.
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
(WebCore::ScrollableArea::scrollbarOverlayStyle):
Cast the now-bitfield members to the appropriate enum types.
* rendering/RenderLayer.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Move shouldBeNormalFlowOnly() call out of initializer list since it
depends on m_renderer being initialized.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97061 => 97062)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 14:47:07 UTC (rev 97061)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 14:51:44 UTC (rev 97062)
@@ -1,3 +1,31 @@
+2011-10-10 Andreas Kling kl...@webkit.org
+
+Shrink RenderLayer and ScrollableArea.
+https://bugs.webkit.org/show_bug.cgi?id=69759
+
+Reviewed by Antti Koivisto.
+
+Rearrange the members of RenderLayer and its base class ScrollableArea
+to maximize struct packing, shrinking RenderLayer by one CPU word on
+32-bit (and two on 64-bit.)
+
+This reduces memory consumption by 134 kB (on 64-bit) when loading the
+full HTML5 spec.
+
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::verticalScrollElasticity):
+(WebCore::ScrollableArea::horizontalScrollElasticity):
+(WebCore::ScrollableArea::scrollbarOverlayStyle):
+
+Cast the now-bitfield members to the appropriate enum types.
+
+* rendering/RenderLayer.h:
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::RenderLayer):
+
+Move shouldBeNormalFlowOnly() call out of initializer list since it
+depends on m_renderer being initialized.
+
2011-10-10 Cary Clark carycl...@google.com
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
Modified: trunk/Source/WebCore/platform/ScrollableArea.h (97061 => 97062)
--- trunk/Source/WebCore/platform/ScrollableArea.h 2011-10-10 14:47:07 UTC (rev 97061)
+++ trunk/Source/WebCore/platform/ScrollableArea.h 2011-10-10 14:51:44 UTC (rev 97062)
@@ -66,10 +66,10 @@
void setConstrainsScrollingToContentEdge(bool constrainsScrollingToContentEdge) { m_constrainsScrollingToContentEdge = constrainsScrollingToContentEdge; }
void setVerticalScrollElasticity(ScrollElasticity scrollElasticity) { m_verticalScrollElasticity = scrollElasticity; }
-ScrollElasticity verticalScrollElasticity() const { return m_verticalScrollElasticity; }
+ScrollElasticity verticalScrollElasticity() const { return static_castScrollElasticity(m_verticalScrollElasticity); }
void setHorizontalScrollElasticity(ScrollElasticity scrollElasticity) { m_horizontalScrollElasticity = scrollElasticity; }
-ScrollElasticity horizontalScrollElasticity() const { return m_horizontalScrollElasticity; }
+ScrollElasticity horizontalScrollElasticity() const { return static_castScrollElasticity(m_horizontalScrollElasticity); }
bool inLiveResize() const { return m_inLiveResize; }
void willStartLiveResize();
@@ -82,7 +82,7 @@
bool hasOverlayScrollbars() const;
virtual void setScrollbarOverlayStyle(ScrollbarOverlayStyle);
-ScrollbarOverlayStyle scrollbarOverlayStyle() const { return m_scrollbarOverlayStyle; }
+ScrollbarOverlayStyle scrollbarOverlayStyle() const { return static_castScrollbarOverlayStyle(m_scrollbarOverlayStyle); }
ScrollAnimator* scrollAnimator() const;
const IntPoint scrollOrigin() const { return m_scrollOrigin; }
@@ -165,21 +165,6 @@
// NOTE: Only called from Internals for testing.
void setScrollOffsetFromInternals(const IntPoint);
-private:
-// NOTE: Only called from the ScrollAnimator.
-friend class ScrollAnimator;
-void setScrollOffsetFromAnimation(const IntPoint);
-
-mutable OwnPtrScrollAnimator m_scrollAnimator;
-bool m_constrainsScrollingToContentEdge;
-
-bool m_inLiveResize;
-
-ScrollElasticity m_verticalScrollElasticity;
-ScrollElasticity m_horizontalScrollElasticity;
-
-ScrollbarOverlayStyle m_scrollbarOverlayStyle;
-
protected:
virtual void invalidateScrollbarRect(Scrollbar*, const IntRect) = 0;
virtual void invalidateScrollCornerRect(const IntRect) =
[webkit-changes] [97063] trunk
Title: [97063] trunk
Revision 97063
Author podivi...@chromium.org
Date 2011-10-10 09:09:22 -0700 (Mon, 10 Oct 2011)
Log Message
Web Inspector: RawSourceCode could be mapped to multiple sources.
https://bugs.webkit.org/show_bug.cgi?id=68526
Source/WebCore:
Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
then one UISourceCode associated with a RawSourceCode.
Reviewed by Pavel Feldman.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/raw-source-code.html
trunk/LayoutTests/inspector/debugger/scripts-panel.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/RawSourceCode.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97062 => 97063)
--- trunk/LayoutTests/ChangeLog 2011-10-10 14:51:44 UTC (rev 97062)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 16:09:22 UTC (rev 97063)
@@ -1,3 +1,13 @@
+2011-09-28 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: RawSourceCode could be mapped to multiple sources.
+https://bugs.webkit.org/show_bug.cgi?id=68526
+
+Reviewed by Pavel Feldman.
+
+* inspector/debugger/raw-source-code.html:
+* inspector/debugger/scripts-panel.html:
+
2011-10-10 Zsolt Fehér fehe...@inf.u-szeged.hu
Unreviewed gardening after r96958.
Modified: trunk/LayoutTests/inspector/debugger/raw-source-code.html (97062 => 97063)
--- trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 14:51:44 UTC (rev 97062)
+++ trunk/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-10 16:09:22 UTC (rev 97063)
@@ -106,7 +106,8 @@
var rawSourceCode = createRawSourceCode(script, null);
var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(foo.js, uiSourceCode.url);
InspectorTest.assertEquals(true, uiSourceCode.isContentScript);
InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode);
@@ -136,7 +137,9 @@
function mappingReady(event)
{
InspectorTest.assertTrue(!event.data.oldSourceCode);
-var uiSourceCode = rawSourceCode.sourceMapping.uiSourceCode;
+var sourceMapping = rawSourceCode.sourceMapping;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(index.html, uiSourceCode.url);
InspectorTest.assertEquals(false, uiSourceCode.isContentScript);
uiSourceCode.requestContent(didRequestContent);
@@ -161,7 +164,8 @@
var rawSourceCode = createRawSourceCode(script1, resource);
var sourceMapping = rawSourceCode.sourceMapping;
-var uiSourceCode = sourceMapping.uiSourceCode;
+InspectorTest.assertEquals(1, sourceMapping.uiSourceCodeList().length);
+var uiSourceCode = sourceMapping.uiSourceCodeList()[0];
InspectorTest.assertEquals(index.html, uiSourceCode.url);
InspectorTest.assertEquals(false, uiSourceCode.isContentScript);
uiSourceCode.requestContent(didRequestContent);
@@ -195,7 +199,10 @@
function requestContent()
{
-
[webkit-changes] [97066] trunk/LayoutTests
Title: [97066] trunk/LayoutTests
Revision 97066
Author loi...@chromium.org
Date 2011-10-10 09:58:23 -0700 (Mon, 10 Oct 2011)
Log Message
Unreviewed fix for the test. The amount of used memory was calculated incorrectly.
* inspector/performance/resources/network-append-30-requests.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97065 => 97066)
--- trunk/LayoutTests/ChangeLog 2011-10-10 16:40:44 UTC (rev 97065)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 16:58:23 UTC (rev 97066)
@@ -1,3 +1,9 @@
+2011-10-10 Ilya Tikhonovsky loi...@chromium.org
+
+Unreviewed fix for the test. The amount of used memory was calculated incorrectly.
+
+* inspector/performance/resources/network-append-30-requests.html:
+
2011-09-28 Pavel Podivilov podivi...@chromium.org
Web Inspector: RawSourceCode could be mapped to multiple sources.
Modified: trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html (97065 => 97066)
--- trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html 2011-10-10 16:40:44 UTC (rev 97065)
+++ trunk/LayoutTests/inspector/performance/resources/network-append-30-requests.html 2011-10-10 16:58:23 UTC (rev 97066)
@@ -24,12 +24,14 @@
var cookie = InspectorTest.timer.start(network-append-30-requests);
originalRefresh.call(this);
InspectorTest.timer.finish(cookie);
+WebInspector.panels.network._networkLogView._reset();
+// In real life this array is cleaning up at navigation event.
+WebInspector.networkLog._resources = [];
InspectorTest.timer.done();
}
function test(timer)
{
-WebInspector.panels.network._networkLogView._reset();
InspectorTest.evaluateInPage(makeXHRRequests(30));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97069] trunk/Source/WebCore
Title: [97069] trunk/Source/WebCore
Revision 97069
Author tk...@chromium.org
Date 2011-10-10 11:01:09 -0700 (Mon, 10 Oct 2011)
Log Message
Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
https://bugs.webkit.org/show_bug.cgi?id=69755
Reviewed by Ryosuke Niwa.
No new tests, just a refactoring.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextValidIndex):
Make this a static member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::nextSelectableListIndex):
Make this a member function of HTMLSelectElement.
(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
(WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
* html/HTMLSelectElement.h:
- Add the above function declarations.
- Move SkipDirection definition from HTMLSelectElement.cpp.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLSelectElement.cpp
trunk/Source/WebCore/html/HTMLSelectElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97068 => 97069)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 17:24:24 UTC (rev 97068)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 18:01:09 UTC (rev 97069)
@@ -1,3 +1,29 @@
+2011-10-10 Kent Tamura tk...@chromium.org
+
+Make static functions in HTMLSelectElement.cpp member functions of HTMLSelectElement class
+https://bugs.webkit.org/show_bug.cgi?id=69755
+
+Reviewed by Ryosuke Niwa.
+
+
+No new tests, just a refactoring.
+
+* html/HTMLSelectElement.cpp:
+(WebCore::HTMLSelectElement::nextValidIndex):
+Make this a static member function of HTMLSelectElement.
+(WebCore::HTMLSelectElement::nextSelectableListIndex):
+Make this a member function of HTMLSelectElement.
+(WebCore::HTMLSelectElement::previousSelectableListIndex): ditto.
+(WebCore::HTMLSelectElement::firstSelectableListIndex): ditto.
+(WebCore::HTMLSelectElement::lastSelectableListIndex): ditto.
+(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto.
+(WebCore::HTMLSelectElement::selectAll): Update callsite of the above functions.
+(WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto.
+(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
+* html/HTMLSelectElement.h:
+ - Add the above function declarations.
+ - Move SkipDirection definition from HTMLSelectElement.cpp.
+
2011-10-10 Pavel Feldman pfeld...@google.com
Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
Modified: trunk/Source/WebCore/html/HTMLSelectElement.cpp (97068 => 97069)
--- trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-10-10 17:24:24 UTC (rev 97068)
+++ trunk/Source/WebCore/html/HTMLSelectElement.cpp 2011-10-10 18:01:09 UTC (rev 97069)
@@ -74,11 +74,6 @@
static const DOMTimeStamp typeAheadTimeout = 1000;
-enum SkipDirection {
-SkipBackwards = -1,
-SkipForwards = 1
-};
-
HTMLSelectElement::HTMLSelectElement(const QualifiedName tagName, Document* document, HTMLFormElement* form)
: HTMLFormControlElementWithState(tagName, document, form)
{
@@ -443,7 +438,7 @@
// Otherwise, it returns the valid item closest to that boundary which is past |listIndex| if there is one.
// Otherwise, it returns |listIndex|.
// Valid means that it is enabled and an option element.
-static int nextValidIndex(const VectorElement* listItems, int listIndex, SkipDirection direction, int skip)
+int HTMLSelectElement::nextValidIndex(const VectorElement* listItems, int listIndex, SkipDirection direction, int skip)
{
ASSERT(direction == -1 || direction == 1);
int lastGoodIndex = listIndex;
@@ -459,40 +454,40 @@
return lastGoodIndex;
}
-static int nextSelectableListIndex(SelectElementData data, Element* element, int startIndex)
+int HTMLSelectElement::nextSelectableListIndex(int startIndex) const
{
-return nextValidIndex(data.listItems(element), startIndex, SkipForwards, 1);
+return nextValidIndex(m_data.listItems(this), startIndex, SkipForwards, 1);
}
-static int previousSelectableListIndex(SelectElementData data, Element* element, int startIndex)
+int HTMLSelectElement::previousSelectableListIndex(int startIndex) const
{
if (startIndex == -1)
-startIndex = data.listItems(element).size();
-return nextValidIndex(data.listItems(element), startIndex, SkipBackwards, 1);
+startIndex = m_data.listItems(this).size();
+return nextValidIndex(m_data.listItems(this), startIndex, SkipBackwards, 1);
}
-static int
[webkit-changes] [97070] trunk/Websites/webkit.org
Title: [97070] trunk/Websites/webkit.org
Revision 97070
Author rn...@webkit.org
Date 2011-10-10 11:12:28 -0700 (Mon, 10 Oct 2011)
Log Message
Style guide should mandate use of pass-by-reference for out arguments
https://bugs.webkit.org/show_bug.cgi?id=69766
Reviewed by Darin Adler.
This matches the convention used throughout WebCore.
* coding/coding-style.html:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/coding/coding-style.html
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (97069 => 97070)
--- trunk/Websites/webkit.org/ChangeLog 2011-10-10 18:01:09 UTC (rev 97069)
+++ trunk/Websites/webkit.org/ChangeLog 2011-10-10 18:12:28 UTC (rev 97070)
@@ -1,3 +1,14 @@
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
+Style guide should mandate use of pass-by-reference for out arguments
+https://bugs.webkit.org/show_bug.cgi?id=69766
+
+Reviewed by Darin Adler.
+
+This matches the convention used throughout WebCore.
+
+* coding/coding-style.html:
+
2011-10-06 Amruth Raj amruth...@motorola.com
Add Motorola Mobility to team.html
Modified: trunk/Websites/webkit.org/coding/coding-style.html (97069 => 97070)
--- trunk/Websites/webkit.org/coding/coding-style.html 2011-10-10 18:01:09 UTC (rev 97069)
+++ trunk/Websites/webkit.org/coding/coding-style.html 2011-10-10 18:12:28 UTC (rev 97070)
@@ -575,6 +575,17 @@
/pre
/li
+liPrecede getters that return values through out arguments with the word get./li
+h4 class=rightRight:/h4
+pre class=code
+void getInlineBoxAndOffset(InlineBox*amp;, intamp; caretOffset) const;
+/pre
+
+h4 class=wrongWrong:/h4
+pre class=code
+void inlineBoxAndOffset(InlineBox*amp;, intamp; caretOffset) const;
+/pre
+
liUse descriptive verbs in function names.
h4 class=rightRight:/h4
pre class=code
@@ -697,7 +708,12 @@
MyOtherClass::MyOtherClass() : MySuperClass() {}
/pre
+/ol
+h3Pointers and References/h3
+
+ol
+
liPointer types in non-C++ code mdash; Pointer types should be written with a space between the
type and the * (so the * is adjacent to the following identifier if any).
@@ -720,6 +736,32 @@
const KCDashArray amp;dashes = dashArray();
/pre
+liAn out argument of a function should be passed by reference except rare cases where
+it is optional in which case it should be passed by pointer.
+
+h4 class=rightRight:/h4
+pre class=code
+void MyClass::getSomeValue(OutArgumentTypeamp; outArgument) const
+{
+outArgument = m_value;
+}
+
+void MyClass::doSomething(OutArgumentType* outArgument) const
+{
+doSomething();
+if (outArgument)
+outArgument = m_value;
+}
+/pre
+
+h4 class=wrongWrong:/h4
+pre class=code
+void MyClass::getSomeValue(OutArgumentType* outArgument) const
+{
+*outArgument = m_value;
+}
+/pre
+
/ol
h3#include Statements/h3
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97071] trunk/Source/JavaScriptCore
Title: [97071] trunk/Source/_javascript_Core
Revision 97071
Author barraclo...@apple.com
Date 2011-10-10 11:43:44 -0700 (Mon, 10 Oct 2011)
Log Message
DFG JIT: callOperation should return the Call.
https://bugs.webkit.org/show_bug.cgi?id=69682
Reviewed by Oliver Hunt.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
(JSC::DFG::appendCallWithExceptionCheckSetResult):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::appendCall):
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97070 => 97071)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 18:12:28 UTC (rev 97070)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 18:43:44 UTC (rev 97071)
@@ -1,3 +1,17 @@
+2011-10-07 Gavin Barraclough barraclo...@apple.com
+
+DFG JIT: callOperation should return the Call.
+https://bugs.webkit.org/show_bug.cgi?id=69682
+
+Reviewed by Oliver Hunt.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+(JSC::DFG::appendCallWithExceptionCheckSetResult):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::appendCall):
+* wtf/Platform.h:
+
2011-10-10 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r97045.
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97070 => 97071)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 18:12:28 UTC (rev 97070)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 18:43:44 UTC (rev 97071)
@@ -1054,146 +1054,136 @@
}
// These methods add calls to C++ helper functions.
-void callOperation(J_DFGOperation_EP operation, GPRReg result, void* pointer)
+JITCompiler::Call callOperation(J_DFGOperation_EP operation, GPRReg result, void* pointer)
{
m_jit.move(JITCompiler::TrustedImmPtr(pointer), GPRInfo::argumentGPR1);
m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operation);
-m_jit.move(GPRInfo::returnValueGPR, result);
+return appendCallWithExceptionCheckSetResult(operation, result);
}
-void callOperation(J_DFGOperation_EI operation, GPRReg result, Identifier* identifier)
+JITCompiler::Call callOperation(J_DFGOperation_EI operation, GPRReg result, Identifier* identifier)
{
-callOperation((J_DFGOperation_EP)operation, result, identifier);
+return callOperation((J_DFGOperation_EP)operation, result, identifier);
}
-void callOperation(J_DFGOperation_EA operation, GPRReg result, GPRReg arg1)
+JITCompiler::Call callOperation(J_DFGOperation_EA operation, GPRReg result, GPRReg arg1)
{
-callOperation((J_DFGOperation_EP)operation, result, arg1);
+return callOperation((J_DFGOperation_EP)operation, result, arg1);
}
-void callOperation(J_DFGOperation_EPS operation, GPRReg result, void* pointer, size_t size)
+JITCompiler::Call callOperation(J_DFGOperation_EPS operation, GPRReg result, void* pointer, size_t size)
{
m_jit.move(JITCompiler::TrustedImmPtr(size), GPRInfo::argumentGPR2);
m_jit.move(JITCompiler::TrustedImmPtr(pointer), GPRInfo::argumentGPR1);
m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operation);
-m_jit.move(GPRInfo::returnValueGPR, result);
+return appendCallWithExceptionCheckSetResult(operation, result);
}
-void callOperation(J_DFGOperation_ESS operation, GPRReg result, int startConstant, int numConstants)
+JITCompiler::Call callOperation(J_DFGOperation_ESS operation, GPRReg result, int startConstant, int numConstants)
{
m_jit.move(JITCompiler::TrustedImm32(numConstants), GPRInfo::argumentGPR2);
m_jit.move(JITCompiler::TrustedImm32(startConstant), GPRInfo::argumentGPR1);
m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operation);
-m_jit.move(GPRInfo::returnValueGPR, result);
+return appendCallWithExceptionCheckSetResult(operation, result);
}
-void callOperation(J_DFGOperation_EJP operation, GPRReg result, GPRReg arg1, void* pointer)
+JITCompiler::Call callOperation(J_DFGOperation_EJP operation, GPRReg result, GPRReg arg1, void* pointer)
{
m_jit.move(arg1, GPRInfo::argumentGPR1);
m_jit.move(JITCompiler::TrustedImmPtr(pointer), GPRInfo::argumentGPR2);
m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
-appendCallWithExceptionCheck(operation);
-m_jit.move(GPRInfo::returnValueGPR, result);
+return appendCallWithExceptionCheckSetResult(operation, result);
}
-void callOperation(J_DFGOperation_EJI operation, GPRReg result, GPRReg
[webkit-changes] [97073] trunk/Source/JavaScriptCore
Title: [97073] trunk/Source/_javascript_Core
Revision 97073
Author aro...@apple.com
Date 2011-10-10 11:56:48 -0700 (Mon, 10 Oct 2011)
Log Message
Build fix
* wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/MainThread.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97072 => 97073)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 18:45:31 UTC (rev 97072)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 18:56:48 UTC (rev 97073)
@@ -1,3 +1,9 @@
+2011-10-10 Adam Roben aro...@apple.com
+
+Build fix
+
+* wtf/MainThread.h: Pull in Platform.h since this file uses PLATFORM() macros.
+
2011-10-10 Yuqiang Xian yuqiang.x...@intel.com
JSVALUE32_64 DFG JIT - Bug fix for BranchNull
Modified: trunk/Source/_javascript_Core/wtf/MainThread.h (97072 => 97073)
--- trunk/Source/_javascript_Core/wtf/MainThread.h 2011-10-10 18:45:31 UTC (rev 97072)
+++ trunk/Source/_javascript_Core/wtf/MainThread.h 2011-10-10 18:56:48 UTC (rev 97073)
@@ -30,6 +30,8 @@
#ifndef MainThread_h
#define MainThread_h
+#include Platform.h
+
#include stdint.h
namespace WTF {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97074] trunk
Title: [97074] trunk
Revision 97074
Author infe...@chromium.org
Date 2011-10-10 11:58:12 -0700 (Mon, 10 Oct 2011)
Log Message
Handle insertion into an anonymous table part that
is followed by a non-anonymous block correctly.
https://bugs.webkit.org/show_bug.cgi?id=69536
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: fast/table/table-insert-before-non-anonymous-block.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::splitColumn):
LayoutTests:
* fast/table/table-insert-before-non-anonymous-block-expected.png: Added.
* fast/table/table-insert-before-non-anonymous-block-expected.txt: Added.
* fast/table/table-insert-before-non-anonymous-block.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTableRow.cpp
trunk/Source/WebCore/rendering/RenderTableSection.cpp
Added Paths
trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png
trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt
trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97073 => 97074)
--- trunk/LayoutTests/ChangeLog 2011-10-10 18:56:48 UTC (rev 97073)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 18:58:12 UTC (rev 97074)
@@ -1,3 +1,15 @@
+2011-10-10 Abhishek Arya infe...@chromium.org
+
+Handle insertion into an anonymous table part that
+is followed by a non-anonymous block correctly.
+https://bugs.webkit.org/show_bug.cgi?id=69536
+
+Reviewed by Dan Bernstein.
+
+* fast/table/table-insert-before-non-anonymous-block-expected.png: Added.
+* fast/table/table-insert-before-non-anonymous-block-expected.txt: Added.
+* fast/table/table-insert-before-non-anonymous-block.html: Added.
+
2011-10-10 Pavel Feldman pfeld...@google.com
Web Inspector: annotate DOMAgent, Debugger(Presentation)Model with types.
Added: trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (0 => 97074)
--- trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt 2011-10-10 18:58:12 UTC (rev 97074)
@@ -0,0 +1,55 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x466
+ RenderBlock {HTML} at (0,0) size 800x466
+RenderBody {BODY} at (8,8) size 784x450
+ RenderTable {DIV} at (0,0) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableSection {DIV} at (0,50) size 100x0
+ RenderTable {DIV} at (0,50) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+ RenderTableRow {DIV} at (0,50) size 100x0
+ RenderTable {DIV} at (0,100) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderBlock {DIV} at (0,0) size 100x0
+ RenderTable {DIV} at (0,150) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCol {DIV} at (0,0) size 0x0
+ RenderTable {DIV} at (0,200) size 50x50
+RenderTableSection (anonymous) at (0,0) size 50x50
+ RenderTableRow (anonymous) at (0,0) size 50x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+ RenderTableRow {DIV} at (0,50) size 50x0
+
[webkit-changes] [97075] trunk
Title: [97075] trunk Revision 97075 Author infe...@chromium.org Date 2011-10-10 12:47:17 -0700 (Mon, 10 Oct 2011) Log Message Style for updated due to inability to locate :before content in presence of listmarkers and runins. https://bugs.webkit.org/show_bug.cgi?id=68624 Reviewed by Dan Bernstein. Source/WebCore: Tests: fast/lists/inline-before-content-after-list-marker.html fast/runin/runin-between-list-marker-and-before-content.html fast/runin/runin-into-div-with-float-child.html fast/runin/runin-not-go-into-float.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild): Fix as per spec that we should not be skipping over floating/positioned renderers to push runins into neighbouring block. This matches Opera renderings. * rendering/RenderObject.cpp: Add const to parameter variable to make call from beforePseudoElementRenderer easier. Also matches CounterNode.h definition. (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): * rendering/RenderObject.h: Same const addition. * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::beforePseudoElementRenderer): Remove skipping of floating/positioned renderers, similar to handleRunIn. Revert code change in r94857 and add better next sibling iterator. This addresses the layouttest in r94857 where :before content is in its own anonymous rendertable. LayoutTests: * fast/lists/inline-before-content-after-list-marker-expected.png: Added. * fast/lists/inline-before-content-after-list-marker-expected.txt: Added. * fast/lists/inline-before-content-after-list-marker.html: Added. * fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. * fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added. * fast/runin/runin-between-list-marker-and-before-content.html: Added. * fast/runin/runin-into-div-with-float-child-expected.png: Added. * fast/runin/runin-into-div-with-float-child-expected.txt: Added. * fast/runin/runin-into-div-with-float-child.html: Added. * fast/runin/runin-not-go-into-float-expected.png: Added. * fast/runin/runin-not-go-into-float-expected.txt: Added. * fast/runin/runin-not-go-into-float.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlock.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderObjectChildList.cpp Added Paths trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker.html trunk/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.png trunk/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt trunk/LayoutTests/fast/runin/runin-between-list-marker-and-before-content.html trunk/LayoutTests/fast/runin/runin-into-div-with-float-child-expected.png trunk/LayoutTests/fast/runin/runin-into-div-with-float-child-expected.txt trunk/LayoutTests/fast/runin/runin-into-div-with-float-child.html trunk/LayoutTests/fast/runin/runin-not-go-into-float-expected.png trunk/LayoutTests/fast/runin/runin-not-go-into-float-expected.txt trunk/LayoutTests/fast/runin/runin-not-go-into-float.html Diff Modified: trunk/LayoutTests/ChangeLog (97074 => 97075) --- trunk/LayoutTests/ChangeLog 2011-10-10 18:58:12 UTC (rev 97074) +++ trunk/LayoutTests/ChangeLog 2011-10-10 19:47:17 UTC (rev 97075) @@ -1,5 +1,26 @@ 2011-10-10 Abhishek Arya infe...@chromium.org +Style for updated due to inability to locate +:before content in presence of listmarkers and runins. +https://bugs.webkit.org/show_bug.cgi?id=68624 + +Reviewed by Dan Bernstein. + +* fast/lists/inline-before-content-after-list-marker-expected.png: Added. +* fast/lists/inline-before-content-after-list-marker-expected.txt: Added. +* fast/lists/inline-before-content-after-list-marker.html: Added. +* fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. +* fast/runin/runin-between-list-marker-and-before-content-expected.txt: Added. +* fast/runin/runin-between-list-marker-and-before-content.html: Added. +* fast/runin/runin-into-div-with-float-child-expected.png: Added. +* fast/runin/runin-into-div-with-float-child-expected.txt: Added. +* fast/runin/runin-into-div-with-float-child.html: Added. +* fast/runin/runin-not-go-into-float-expected.png: Added. +* fast/runin/runin-not-go-into-float-expected.txt: Added. +* fast/runin/runin-not-go-into-float.html: Added. + +2011-10-10 Abhishek Arya infe...@chromium.org + Handle insertion into an anonymous table part that is followed by a non-anonymous block correctly.
[webkit-changes] [97076] branches/chromium/874
Title: [97076] branches/chromium/874 Revision 97076 Author k...@google.com Date 2011-10-10 12:47:26 -0700 (Mon, 10 Oct 2011) Log Message Merge 96726 - Mask underlying RENDERER and VENDOR strings https://bugs.webkit.org/show_bug.cgi?id=69389 Reviewed by Sam Weinig. Source/WebCore: Test: fast/canvas/webgl/renderer-and-vendor-strings.html * html/canvas/WebGLGetInfo.h: * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getParameter): LayoutTests: * fast/canvas/webgl/renderer-and-vendor-strings-expected.txt: Added. * fast/canvas/webgl/renderer-and-vendor-strings.html: Added. TBR=k...@google.com Review URL: http://codereview.chromium.org/8218017 Modified Paths branches/chromium/874/Source/WebCore/html/canvas/WebGLGetInfo.h branches/chromium/874/Source/WebCore/html/canvas/WebGLRenderingContext.cpp Added Paths branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html Diff Copied: branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt (from rev 96726, trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt) (0 => 97076) --- branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt (rev 0) +++ branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings-expected.txt 2011-10-10 19:47:26 UTC (rev 97076) @@ -0,0 +1,10 @@ +Verifies the contents of the RENDERER and VENDOR strings to avoid regressions. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + +PASS gl.getParameter(gl.RENDERER) is WebKit WebGL +PASS gl.getParameter(gl.VENDOR) is WebKit +PASS successfullyParsed is true + +TEST COMPLETE + Copied: branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html (from rev 96726, trunk/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html) (0 => 97076) --- branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html (rev 0) +++ branches/chromium/874/LayoutTests/fast/canvas/webgl/renderer-and-vendor-strings.html 2011-10-10 19:47:26 UTC (rev 97076) @@ -0,0 +1,31 @@ +head +link rel=stylesheet href="" +script src="" +script src="" +/head +body +div id=description/div +div id=console/div + +script +description(Verifies the contents of the RENDERER and VENDOR strings to avoid regressions.) + +if (window.initNonKhronosFramework) +window.initNonKhronosFramework(false); + +var gl = create3DContext(); + +// Consensus in the WebGL working group has been to mask the +// underlying hardware's RENDERER and VENDOR strings, which leak a +// certain amount of personally identifiable information. This test is +// intended only to catch accidental regressions, not to enforce the +// specific strings. + +shouldBe(gl.getParameter(gl.RENDERER), 'WebKit WebGL'); +shouldBe(gl.getParameter(gl.VENDOR), 'WebKit'); + +successfullyParsed = true; +/script + +script src="" +/body Modified: branches/chromium/874/Source/WebCore/html/canvas/WebGLGetInfo.h (97075 => 97076) --- branches/chromium/874/Source/WebCore/html/canvas/WebGLGetInfo.h 2011-10-10 19:47:17 UTC (rev 97075) +++ branches/chromium/874/Source/WebCore/html/canvas/WebGLGetInfo.h 2011-10-10 19:47:26 UTC (rev 97076) @@ -70,25 +70,25 @@ kTypeWebGLVertexArrayObjectOES, }; -WebGLGetInfo(bool value); +explicit WebGLGetInfo(bool value); WebGLGetInfo(const bool* value, int size); -WebGLGetInfo(float value); -WebGLGetInfo(int value); +explicit WebGLGetInfo(float value); +explicit WebGLGetInfo(int value); // Represents the null value and type. WebGLGetInfo(); -WebGLGetInfo(const String value); -WebGLGetInfo(unsigned int value); -WebGLGetInfo(PassRefPtrWebGLBuffer value); -WebGLGetInfo(PassRefPtrFloat32Array value); -WebGLGetInfo(PassRefPtrWebGLFramebuffer value); -WebGLGetInfo(PassRefPtrInt32Array value); +explicit WebGLGetInfo(const String value); +explicit WebGLGetInfo(unsigned int value); +explicit WebGLGetInfo(PassRefPtrWebGLBuffer value); +explicit WebGLGetInfo(PassRefPtrFloat32Array value); +explicit WebGLGetInfo(PassRefPtrWebGLFramebuffer value); +explicit WebGLGetInfo(PassRefPtrInt32Array value); // FIXME: implement WebGLObjectArray // WebGLGetInfo(PassRefPtrWebGLObjectArray value); -WebGLGetInfo(PassRefPtrWebGLProgram value); -WebGLGetInfo(PassRefPtrWebGLRenderbuffer value); -WebGLGetInfo(PassRefPtrWebGLTexture value); -WebGLGetInfo(PassRefPtrUint8Array value); -WebGLGetInfo(PassRefPtrWebGLVertexArrayObjectOES value); +explicit WebGLGetInfo(PassRefPtrWebGLProgram value); +explicit WebGLGetInfo(PassRefPtrWebGLRenderbuffer value); +explicit WebGLGetInfo(PassRefPtrWebGLTexture value); +explicit
[webkit-changes] [97077] trunk/Tools
Title: [97077] trunk/Tools
Revision 97077
Author commit-qu...@webkit.org
Date 2011-10-10 12:52:06 -0700 (Mon, 10 Oct 2011)
Log Message
check-webkit-style: Add readability exception for Ewk_* data types.
https://bugs.webkit.org/show_bug.cgi?id=69763
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-10-10
Reviewed by David Levin.
Many EFL-related files (such as EditorClientEfl.h or
DumpRenderTreeSupportEfl.h) need to have declarations such as typedef
struct _Ewk_Foo Ewk_Foo, which currently produce false positives in
check-webkit-style.
Add an exception for them, just like there are exceptions for
Evas_*, Ecore_* and others.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (97076 => 97077)
--- trunk/Tools/ChangeLog 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/ChangeLog 2011-10-10 19:52:06 UTC (rev 97077)
@@ -1,3 +1,21 @@
+2011-10-10 Raphael Kubo da Costa k...@profusion.mobi
+
+check-webkit-style: Add readability exception for Ewk_* data types.
+https://bugs.webkit.org/show_bug.cgi?id=69763
+
+Reviewed by David Levin.
+
+Many EFL-related files (such as EditorClientEfl.h or
+DumpRenderTreeSupportEfl.h) need to have declarations such as typedef
+struct _Ewk_Foo Ewk_Foo, which currently produce false positives in
+check-webkit-style.
+
+Add an exception for them, just like there are exceptions for
+Evas_*, Ecore_* and others.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+
2011-10-10 Dominic Mazzoni dmazz...@google.com
[Chromium] Get rid of WebAccessibilityCache.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (97076 => 97077)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-10 19:52:06 UTC (rev 97077)
@@ -3067,6 +3067,7 @@
and not modified_identifier.startswith('Ecore_')
and not modified_identifier.startswith('Eina_')
and not modified_identifier.startswith('Evas_')
+and not modified_identifier.startswith('Ewk_')
and not modified_identifier.find('::qt_') = 0
and not modified_identifier == const_iterator
and not modified_identifier == vm_throw):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (97076 => 97077)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-10 19:47:26 UTC (rev 97076)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-10 19:52:06 UTC (rev 97077)
@@ -4429,6 +4429,7 @@
self.assert_lint('typedef struct _Ecore_Pipe Ecore_Pipe;', '')
self.assert_lint('typedef struct _Eina_Rectangle Eina_Rectangle;', '')
self.assert_lint('typedef struct _Evas_Object Evas_Object;', '')
+self.assert_lint('typedef struct _Ewk_History_Item Ewk_History_Item;', '')
# NPAPI functions that start with NPN_, NPP_ or NP_ are allowed.
self.assert_lint('void NPN_Status(NPP, const char*)', '')
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97078] trunk/Source/JavaScriptCore
Title: [97078] trunk/Source/_javascript_Core Revision 97078 Author commit-qu...@webkit.org Date 2011-10-10 12:54:08 -0700 (Mon, 10 Oct 2011) Log Message JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases crypto and raytrace https://bugs.webkit.org/show_bug.cgi?id=69748 Patch by Yuqiang Xian yuqiang.x...@intel.com on 2011-10-10 Reviewed by Filip Pizlo. * dfg/DFGJITCodeGenerator32_64.cpp: (JSC::DFG::JITCodeGenerator::cachedGetMethod): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compileObjectEquality): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97077 => 97078) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 19:52:06 UTC (rev 97077) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 19:54:08 UTC (rev 97078) @@ -1,3 +1,15 @@ +2011-10-10 Yuqiang Xian yuqiang.x...@intel.com + +JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases crypto and raytrace +https://bugs.webkit.org/show_bug.cgi?id=69748 + +Reviewed by Filip Pizlo. + +* dfg/DFGJITCodeGenerator32_64.cpp: +(JSC::DFG::JITCodeGenerator::cachedGetMethod): +* dfg/DFGSpeculativeJIT32_64.cpp: +(JSC::DFG::SpeculativeJIT::compileObjectEquality): + 2011-10-10 Adam Roben aro...@apple.com Build fix Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (97077 => 97078) --- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-10 19:52:06 UTC (rev 97077) +++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-10 19:54:08 UTC (rev 97078) @@ -1139,6 +1139,7 @@ JITCompiler::Jump wrongProtoStructure = m_jit.branchPtrWithPatch(JITCompiler::NotEqual, JITCompiler::Address(resultPayloadGPR, JSCell::structureOffset()), protoStructToCompare, JITCompiler::TrustedImmPtr(reinterpret_castvoid*(-1))); putFunction = m_jit.moveWithPatch(JITCompiler::TrustedImmPtr(0), resultPayloadGPR); +m_jit.move(TrustedImm32(JSValue::CellTag), resultTagGPR); JITCompiler::Jump done = m_jit.jump(); Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (97077 => 97078) --- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-10 19:52:06 UTC (rev 97077) +++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-10 19:54:08 UTC (rev 97078) @@ -352,7 +352,7 @@ SpeculateCellOperand op1(this, node.child1()); SpeculateCellOperand op2(this, node.child2()); GPRTemporary resultTag(this, op1); -GPRTemporary resultPayload(this, op1); +GPRTemporary resultPayload(this, op2); GPRReg op1GPR = op1.gpr(); GPRReg op2GPR = op2.gpr(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97079] trunk/Source/WebCore
Title: [97079] trunk/Source/WebCore
Revision 97079
Author simon.fra...@apple.com
Date 2011-10-10 13:05:16 -0700 (Mon, 10 Oct 2011)
Log Message
REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
https://bugs.webkit.org/show_bug.cgi?id=69238
Reviewed by Darin Adler.
Fix PLT regression from additional scrollbars invalidations.
Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
and setHasVerticalScrollbar(), because this is called during FrameView
teardown, at which point the invalidation is redundant.
Instead, invalidate from ScrollView::updateScrollbars(), which is
called only when scrollbars change because of size or layout
changes.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
(WebCore::ScrollView::updateScrollbars):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97078 => 97079)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 19:54:08 UTC (rev 97078)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 20:05:16 UTC (rev 97079)
@@ -1,3 +1,25 @@
+2011-10-10 Simon Fraser simon.fra...@apple.com
+
+REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation
+https://bugs.webkit.org/show_bug.cgi?id=69238
+
+Reviewed by Darin Adler.
+
+Fix PLT regression from additional scrollbars invalidations.
+
+Don't invalidate the scrollbar rect from setHasHorizontalScrollbar()
+and setHasVerticalScrollbar(), because this is called during FrameView
+teardown, at which point the invalidation is redundant.
+
+Instead, invalidate from ScrollView::updateScrollbars(), which is
+called only when scrollbars change because of size or layout
+changes.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::setHasHorizontalScrollbar):
+(WebCore::ScrollView::setHasVerticalScrollbar):
+(WebCore::ScrollView::updateScrollbars):
+
2011-10-10 Abhishek Arya infe...@chromium.org
Style for updated due to inability to locate
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (97078 => 97079)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2011-10-10 19:54:08 UTC (rev 97078)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2011-10-10 20:05:16 UTC (rev 97079)
@@ -95,7 +95,6 @@
didAddHorizontalScrollbar(m_horizontalScrollbar.get());
m_horizontalScrollbar-styleChanged();
} else if (!hasBar m_horizontalScrollbar) {
-m_horizontalScrollbar-invalidate();
willRemoveHorizontalScrollbar(m_horizontalScrollbar.get());
removeChild(m_horizontalScrollbar.get());
m_horizontalScrollbar = 0;
@@ -114,7 +113,6 @@
didAddVerticalScrollbar(m_verticalScrollbar.get());
m_verticalScrollbar-styleChanged();
} else if (!hasBar m_verticalScrollbar) {
-m_verticalScrollbar-invalidate();
willRemoveVerticalScrollbar(m_verticalScrollbar.get());
removeChild(m_verticalScrollbar.get());
m_verticalScrollbar = 0;
@@ -497,6 +495,8 @@
if (hasHorizontalScrollbar != newHasHorizontalScrollbar (hasHorizontalScrollbar || !avoidScrollbarCreation())) {
if (m_scrollOrigin.y() !newHasHorizontalScrollbar)
m_scrollOrigin.setY(m_scrollOrigin.y() - m_horizontalScrollbar-height());
+if (m_horizontalScrollbar)
+m_horizontalScrollbar-invalidate();
setHasHorizontalScrollbar(newHasHorizontalScrollbar);
sendContentResizedNotification = true;
}
@@ -504,6 +504,8 @@
if (hasVerticalScrollbar != newHasVerticalScrollbar (hasVerticalScrollbar || !avoidScrollbarCreation())) {
if (m_scrollOrigin.x() !newHasVerticalScrollbar)
m_scrollOrigin.setX(m_scrollOrigin.x() - m_verticalScrollbar-width());
+if (m_verticalScrollbar)
+m_verticalScrollbar-invalidate();
setHasVerticalScrollbar(newHasVerticalScrollbar);
sendContentResizedNotification = true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97080] trunk/Source/WebKit/efl
Title: [97080] trunk/Source/WebKit/efl
Revision 97080
Author commit-qu...@webkit.org
Date 2011-10-10 13:48:17 -0700 (Mon, 10 Oct 2011)
Log Message
[EFL] Do not cache a frame's contents size.
https://bugs.webkit.org/show_bug.cgi?id=69772
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-10-10
Reviewed by Antonio Gomes.
As part of the process of experimenting with having scrollbars with
an actual size, it became clear that setting the contents size via
ChromeClient::contentsSizeChanged() and keeping the value around does
not work.
Case in point: FrameView::adjustViewSize() can result in nested
ScrollView::updateScrollbars() calls in which the innermost ones run
ChromeClient::contentsSizeChanged() before the outermost ones. This
means the ewk_frame's smart data will store an old value.
* ewk/ewk_frame.cpp:
(ewk_frame_contents_size_get):
(ewk_frame_contents_size_changed):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (97079 => 97080)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-10 20:05:16 UTC (rev 97079)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-10 20:48:17 UTC (rev 97080)
@@ -1,3 +1,24 @@
+2011-10-10 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Do not cache a frame's contents size.
+https://bugs.webkit.org/show_bug.cgi?id=69772
+
+Reviewed by Antonio Gomes.
+
+As part of the process of experimenting with having scrollbars with
+an actual size, it became clear that setting the contents size via
+ChromeClient::contentsSizeChanged() and keeping the value around does
+not work.
+
+Case in point: FrameView::adjustViewSize() can result in nested
+ScrollView::updateScrollbars() calls in which the innermost ones run
+ChromeClient::contentsSizeChanged() before the outermost ones. This
+means the ewk_frame's smart data will store an old value.
+
+* ewk/ewk_frame.cpp:
+(ewk_frame_contents_size_get):
+(ewk_frame_contents_size_changed):
+
2011-10-09 Ryuan Choi ryuan.c...@samsung.com
[EFL] Refactor zoom related APIs.
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (97079 => 97080)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-10-10 20:05:16 UTC (rev 97079)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-10-10 20:48:17 UTC (rev 97080)
@@ -72,9 +72,6 @@
const char* title;
const char* uri;
const char* name;
-struct {
-Evas_Coord w, h;
-} contents_size;
Eina_Bool editable : 1;
};
@@ -371,10 +368,12 @@
if (h)
*h = 0;
EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
+if (!sd-frame || !sd-frame-view())
+return EINA_FALSE;
if (w)
-*w = sd-contents_size.w;
+*w = sd-frame-view()-contentsWidth();
if (h)
-*h = sd-contents_size.h;
+*h = sd-frame-view()-contentsHeight();
return EINA_TRUE;
}
@@ -1418,14 +1417,6 @@
*/
void ewk_frame_contents_size_changed(Evas_Object* o, Evas_Coord w, Evas_Coord h)
{
-DBG(o=%p: %dx%d, o, w, h);
-EWK_FRAME_SD_GET_OR_RETURN(o, sd);
-if (sd-contents_size.w == w sd-contents_size.h == h)
-return;
-sd-contents_size.w = w;
-sd-contents_size.h = h;
-// TODO: update something else internally?
-
Evas_Coord size[2] = {w, h};
evas_object_smart_callback_call(o, contents,size,changed, size);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97082] trunk/Tools
Title: [97082] trunk/Tools
Revision 97082
Author simon.fra...@apple.com
Date 2011-10-10 14:02:05 -0700 (Mon, 10 Oct 2011)
Log Message
3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276
Reviewed by Anders Carlsson.
The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
the window when doing pixel tests.
Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
* WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
(WTR::createBitmapCGContext): Utility function to create a bitmap context.
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
We need the window to autodisplay for Core Animation to render layers and start animations.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
Added Paths
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.mm
Removed Paths
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
Diff
Modified: trunk/Tools/ChangeLog (97081 => 97082)
--- trunk/Tools/ChangeLog 2011-10-10 21:01:59 UTC (rev 97081)
+++ trunk/Tools/ChangeLog 2011-10-10 21:02:05 UTC (rev 97082)
@@ -1,5 +1,30 @@
2011-10-10 Simon Fraser simon.fra...@apple.com
+3D transforms are flattened in WebKit2 snapshots
+https://bugs.webkit.org/show_bug.cgi?id=68276
+
+Reviewed by Anders Carlsson.
+
+The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
+flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
+the window when doing pixel tests.
+
+Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
+
+* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
+* WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
+(WTR::createBitmapCGContext): Utility function to create a bitmap context.
+(WTR::computeMD5HashStringForContext):
+(WTR::dumpBitmap):
+(WTR::paintRepaintRectOverlay):
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
+grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
+We need the window to autodisplay for Core Animation to render layers and start animations.
+
+2011-10-10 Simon Fraser simon.fra...@apple.com
+
WebKitTestRunner needs layoutTestController.setWindowIsKey
https://bugs.webkit.org/show_bug.cgi?id=42688
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (97081 => 97082)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2011-10-10 21:01:59 UTC (rev 97081)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2011-10-10 21:02:05 UTC (rev 97082)
@@ -54,7 +54,7 @@
BC8DAD7B1316D91000EC96FC /* InjectedBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC8DAD771316D7B900EC96FC /* InjectedBundleMac.mm */; };
BC8FD8CA120E527F00F3E71A /* EventSendingController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC8FD8C9120E527F00F3E71A /* EventSendingController.cpp */; };
BC8FD8D2120E545B00F3E71A /* JSEventSendingController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC8FD8D0120E545B00F3E71A /* JSEventSendingController.cpp */; };
- BC9192051333E4F8003011DC /* TestInvocationCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC9192041333E4F8003011DC /* TestInvocationCG.cpp */; };
+ BC9192051333E4F8003011DC /* TestInvocationCG.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC9192041333E4F8003011DC /* TestInvocationCG.mm */; };
BC952C0D11F3B965003398B4 /* JSWrapper.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC952C0C11F3B965003398B4 /* JSWrapper.cpp */; };
BC952F1F11F3C652003398B4 /* JSLayoutTestController.cpp in Sources */ = {isa = PBXBuildFile; fileRef =
[webkit-changes] [97081] trunk
Title: [97081] trunk Revision 97081 Author simon.fra...@apple.com Date 2011-10-10 14:01:59 -0700 (Mon, 10 Oct 2011) Log Message WebKitTestRunner needs layoutTestController.setWindowIsKey https://bugs.webkit.org/show_bug.cgi?id=42688 Reviewed by Anders Carlsson. Tools: Implement layoutTestController.setWindowIsKey() in WebKitTestRunner. This sets a flag that the platform layer uses to indicate that the window is the key window, which fixes focus ring drawing in pixel results. Also focus the web view when we get a 'didCommitLoad' for the main frame, as DumpRenderTree does. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::postSetWindowIsKey): * WebKitTestRunner/InjectedBundle/InjectedBundle.h: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum. (WTR::LayoutTestController::addChromeInputField): (WTR::LayoutTestController::removeChromeInputField): (WTR::LayoutTestController::focusWebView): (WTR::LayoutTestController::setWindowIsKey): (WTR::LayoutTestController::callAddChromeInputFieldCallback): (WTR::LayoutTestController::callRemoveChromeInputFieldCallback): (WTR::LayoutTestController::callFocusWebViewCallback): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass so that we can override -isKeyWindow. Use a boolean member variable to track window key status. (WTR::PlatformWebView::setWindowIsKey): (WTR::PlatformWebView::windowIsKey): * WebKitTestRunner/TestController.cpp: (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does. (WTR::closeOtherPage): Use the same cast as other functions. (WTR::focus): Implement to call setWindowIsKey(true) (WTR::unfocus): Implement to call setWindowIsKey(false) (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus. (WTR::TestController::initialize): (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does. * WebKitTestRunner/TestController.h: * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[WebKitTestRunnerWindow isKeyWindow]): (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow. (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us. (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does. * WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView): * WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::PlatformWebView): LayoutTests: Adjust the Skipped list for WebKit2, unskipping some tests, but keeping others skipped for new reasons. * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wk2/Skipped trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h trunk/Tools/WebKitTestRunner/PlatformWebView.h trunk/Tools/WebKitTestRunner/TestController.cpp trunk/Tools/WebKitTestRunner/TestController.h trunk/Tools/WebKitTestRunner/TestInvocation.cpp trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp Diff Modified: trunk/LayoutTests/ChangeLog (97080 => 97081) --- trunk/LayoutTests/ChangeLog 2011-10-10 20:48:17 UTC (rev 97080) +++ trunk/LayoutTests/ChangeLog 2011-10-10 21:01:59 UTC (rev 97081) @@ -1,3 +1,15 @@ +2011-10-10 Simon Fraser simon.fra...@apple.com + +WebKitTestRunner needs layoutTestController.setWindowIsKey +https://bugs.webkit.org/show_bug.cgi?id=42688 + +Reviewed by Anders Carlsson. + +Adjust the Skipped list for WebKit2, unskipping some tests, but +keeping others skipped for new reasons. + +* platform/wk2/Skipped: + 2011-10-10 Abhishek Arya infe...@chromium.org Style for updated due to inability to locate Modified: trunk/LayoutTests/platform/wk2/Skipped (97080 => 97081) --- trunk/LayoutTests/platform/wk2/Skipped 2011-10-10 20:48:17 UTC (rev 97080) +++ trunk/LayoutTests/platform/wk2/Skipped 2011-10-10 21:01:59 UTC (rev 97081) @@ -642,7 +642,9 @@ # WebKitTestRunner needs layoutTestController.setMainFrameIsFirstResponder #
[webkit-changes] [97083] trunk/Source/JavaScriptCore
Title: [97083] trunk/Source/_javascript_Core
Revision 97083
Author barraclo...@apple.com
Date 2011-10-10 14:02:38 -0700 (Mon, 10 Oct 2011)
Log Message
Switch last calls from DFGSpeculativeJIT to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69780
Reviewed by Oliver Hunt.
Also, rename type in operations for booleans from Z to B, since Z is the mathematical symbol for integers.
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compile):
* wtf/Platform.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97082 => 97083)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 21:02:05 UTC (rev 97082)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 21:02:38 UTC (rev 97083)
@@ -1,3 +1,34 @@
+2011-10-10 Gavin Barraclough barraclo...@apple.com
+
+Switch last calls from DFGSpeculativeJIT to use callOperation.
+https://bugs.webkit.org/show_bug.cgi?id=69780
+
+Reviewed by Oliver Hunt.
+
+Also, rename type in operations for booleans from Z to B, since Z is the mathematical symbol for integers.
+
+* dfg/DFGJITCodeGenerator.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeCompare):
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
+* dfg/DFGOperations.h:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compare):
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compare):
+(JSC::DFG::SpeculativeJIT::compile):
+* wtf/Platform.h:
+
2011-10-10 Yuqiang Xian yuqiang.x...@intel.com
JSVALUE32_64 DFG JIT - bug fix for V8 benchmark cases crypto and raytrace
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp (97082 => 97083)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp 2011-10-10 21:02:05 UTC (rev 97082)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp 2011-10-10 21:02:38 UTC (rev 97083)
@@ -345,7 +345,7 @@
#endif
}
-bool JITCodeGenerator::nonSpeculativeCompare(Node node, MacroAssembler::RelationalCondition cond, Z_DFGOperation_EJJ helperFunction)
+bool JITCodeGenerator::nonSpeculativeCompare(Node node, MacroAssembler::RelationalCondition cond, B_DFGOperation_EJJ helperFunction)
{
NodeIndex branchNodeIndex = detectPeepHoleBranch();
if (branchNodeIndex != NoNode) {
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97082 => 97083)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 21:02:05 UTC (rev 97082)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 21:02:38 UTC (rev 97083)
@@ -774,9 +774,9 @@
void nonSpeculativePeepholeBranchNull(NodeIndex operand, NodeIndex branchNodeIndex, bool invert = false);
bool nonSpeculativeCompareNull(Node, NodeIndex operand, bool invert = false);
-void nonSpeculativePeepholeBranch(Node, NodeIndex branchNodeIndex, MacroAssembler::RelationalCondition, Z_DFGOperation_EJJ helperFunction);
-void nonSpeculativeNonPeepholeCompare(Node, MacroAssembler::RelationalCondition, Z_DFGOperation_EJJ helperFunction);
-bool
[webkit-changes] [97084] trunk/Source/WebCore
Title: [97084] trunk/Source/WebCore Revision 97084 Author commit-qu...@webkit.org Date 2011-10-10 14:14:37 -0700 (Mon, 10 Oct 2011) Log Message Add missing ifdef for _javascript__DEBUGGER feature. https://bugs.webkit.org/show_bug.cgi?id=69758 Patch by Nayan Kumar K naya...@motorola.com on 2011-10-10 Reviewed by Adam Barth. No new tests added since this is a build failure fix. * bindings/v8/custom/V8ScriptProfileCustom.cpp: * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97083 => 97084) --- trunk/Source/WebCore/ChangeLog 2011-10-10 21:02:38 UTC (rev 97083) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 21:14:37 UTC (rev 97084) @@ -1,3 +1,15 @@ +2011-10-10 Nayan Kumar K naya...@motorola.com + +Add missing ifdef for _javascript__DEBUGGER feature. +https://bugs.webkit.org/show_bug.cgi?id=69758 + +Reviewed by Adam Barth. + +No new tests added since this is a build failure fix. + +* bindings/v8/custom/V8ScriptProfileCustom.cpp: +* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: + 2011-10-10 Simon Fraser simon.fra...@apple.com REGRESSION(96070) 25% intl1 PLT regression from scrollbar invalidation Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp (97083 => 97084) --- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp 2011-10-10 21:02:38 UTC (rev 97083) +++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileCustom.cpp 2011-10-10 21:14:37 UTC (rev 97084) @@ -29,6 +29,7 @@ */ #include config.h +#if ENABLE(_javascript__DEBUGGER) #include V8ScriptProfile.h #include ScriptProfile.h @@ -59,3 +60,5 @@ } } // namespace WebCore + +#endif // ENABLE(_javascript__DEBUGGER) Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp (97083 => 97084) --- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2011-10-10 21:02:38 UTC (rev 97083) +++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2011-10-10 21:14:37 UTC (rev 97084) @@ -29,6 +29,7 @@ */ #include config.h +#if ENABLE(_javascript__DEBUGGER) #include V8ScriptProfileNode.h #include ScriptProfileNode.h @@ -79,3 +80,5 @@ } } // namespace WebCore + +#endif // ENABLE(_javascript__DEBUGGER) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97085] branches/chromium/874
Title: [97085] branches/chromium/874
Revision 97085
Author infe...@chromium.org
Date 2011-10-10 14:17:17 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97074 - Handle insertion into an anonymous table part that
is followed by a non-anonymous block correctly.
BUG=99338
Review URL: http://codereview.chromium.org/8226006
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderTable.cpp
branches/chromium/874/Source/WebCore/rendering/RenderTableRow.cpp
branches/chromium/874/Source/WebCore/rendering/RenderTableSection.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png
branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt
branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png (from rev 97074, trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (from rev 97074, trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt) (0 => 97085)
--- branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt 2011-10-10 21:17:17 UTC (rev 97085)
@@ -0,0 +1,55 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x466
+ RenderBlock {HTML} at (0,0) size 800x466
+RenderBody {BODY} at (8,8) size 784x450
+ RenderTable {DIV} at (0,0) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableSection {DIV} at (0,50) size 100x0
+ RenderTable {DIV} at (0,50) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+ RenderTableRow {DIV} at (0,50) size 100x0
+ RenderTable {DIV} at (0,100) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderBlock {DIV} at (0,0) size 100x0
+ RenderTable {DIV} at (0,150) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCol {DIV} at (0,0) size 0x0
+ RenderTable {DIV} at (0,200) size 50x50
+RenderTableSection (anonymous) at (0,0) size 50x50
+ RenderTableRow (anonymous) at (0,0) size 50x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+ RenderTableRow {DIV} at (0,50) size 50x0
+RenderTableSection {DIV} at (0,50) size 50x0
+ RenderTable {DIV} at (0,250) size 100x50
+RenderTableSection (anonymous) at (0,0) size 100x50
+ RenderTableRow (anonymous) at (0,0) size 100x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCol {DIV} at (0,0) size 0x0
+ RenderTable {DIV} at (0,300) size 101x50
+RenderTableSection (anonymous) at (0,0) size 101x50
+ RenderTableRow (anonymous) at (0,0) size 101x50
+RenderTableCell {DIV} at (0,0) size 50x0 [bgcolor=#FF] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCell (anonymous) at (100,0) size 1x0 [r=0 c=2 rs=1 cs=1]
+ RenderBlock {DIV} at (0,0) size 1x0
+ RenderTable {DIV} at (0,350) size 100x100
+RenderTableSection (anonymous) at (0,0) size 100x100
+ RenderTableRow (anonymous) at (0,0) size 100x100
+RenderTableCell (anonymous) at (0,0) size 50x100 [r=0 c=0 rs=1 cs=1]
+ RenderBlock {DIV} at (0,0) size 50x50 [bgcolor=#FF]
+ RenderBlock {DIV} at
[webkit-changes] [97086] branches/chromium/874
Title: [97086] branches/chromium/874
Revision 97086
Author infe...@chromium.org
Date 2011-10-10 14:21:41 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97075 - Style for updated due to inability to locate
:before content in presence of listmarkers and runins.
BUG=97599
Review URL: http://codereview.chromium.org/8216022
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderBlock.cpp
branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/874/Source/WebCore/rendering/RenderObject.h
branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png
branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt
branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker.html
branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.png
branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt
branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content.html
branches/chromium/874/LayoutTests/fast/runin/runin-into-div-with-float-child-expected.png
branches/chromium/874/LayoutTests/fast/runin/runin-into-div-with-float-child-expected.txt
branches/chromium/874/LayoutTests/fast/runin/runin-into-div-with-float-child.html
branches/chromium/874/LayoutTests/fast/runin/runin-not-go-into-float-expected.png
branches/chromium/874/LayoutTests/fast/runin/runin-not-go-into-float-expected.txt
branches/chromium/874/LayoutTests/fast/runin/runin-not-go-into-float.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png (from rev 97075, trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt (from rev 97075, trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt) (0 => 97086)
--- branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker-expected.txt 2011-10-10 21:21:41 UTC (rev 97086)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x56
+ RenderBlock {HTML} at (0,0) size 800x56
+RenderBody {BODY} at (8,8) size 784x40 [color=#008000]
+ RenderListItem {LI} at (0,0) size 784x40
+RenderBlock (anonymous) at (0,0) size 784x40
+ RenderListMarker at (-1,0) size 13x40: bullet
+ RenderInline (generated) at (0,0) size 80x40
+RenderText at (32,0) size 80x40
+ text run at (32,0) width 80: PA
+ RenderText {#text} at (112,0) size 80x40
+text run at (112,0) width 80: SS
+RenderBlock {DIV} at (0,40) size 784x0
Copied: branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker.html (from rev 97075, trunk/LayoutTests/fast/lists/inline-before-content-after-list-marker.html) (0 => 97086)
--- branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker.html (rev 0)
+++ branches/chromium/874/LayoutTests/fast/lists/inline-before-content-after-list-marker.html 2011-10-10 21:21:41 UTC (rev 97086)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+!-- Test passes if you see green text only and no PA repetition --
+html
+body style=font-family: ahem; font-size: 40px; -webkit-font-smoothing: none;
+style
+li:before { content: PA; }
+/style
+liSS
+div/div
+/li
+script
+document.body.offsetTop;
+document.body.style.color = green;
+/script
+/body
+/html
Copied: branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.png (from rev 97075, trunk/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt (from rev 97075, trunk/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt) (0 => 97086)
--- branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/runin/runin-between-list-marker-and-before-content-expected.txt 2011-10-10 21:21:41 UTC (rev 97086)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x56
+ RenderBlock {HTML} at (0,0) size 800x56
+RenderBody {BODY} at (8,8) size 784x40
+ RenderListItem {LI} at (0,0) size 784x40 [color=#FF]
+RenderListMarker at (-1,0) size 13x40: bullet
+
[webkit-changes] [97087] trunk
Title: [97087] trunk
Revision 97087
Author commit-qu...@webkit.org
Date 2011-10-10 14:28:53 -0700 (Mon, 10 Oct 2011)
Log Message
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777
Patch by Sergey Glazunov serg.glazu...@gmail.com on 2011-10-10
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:
Source/WebKit/chromium:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):
LayoutTests:
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Added.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Added Paths
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97086 => 97087)
--- trunk/LayoutTests/ChangeLog 2011-10-10 21:21:41 UTC (rev 97086)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 21:28:53 UTC (rev 97087)
@@ -1,3 +1,13 @@
+2011-10-10 Sergey Glazunov serg.glazu...@gmail.com
+
+ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
+https://bugs.webkit.org/show_bug.cgi?id=69777
+
+Reviewed by Adam Barth.
+
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Added.
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Added.
+
2011-10-10 Simon Fraser simon.fra...@apple.com
WebKitTestRunner needs layoutTestController.setWindowIsKey
Added: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (0 => 97087)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-10 21:28:53 UTC (rev 97087)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
+
+This test passes if there's no alert dialog.
Added: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (0 => 97087)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-10 21:28:53 UTC (rev 97087)
@@ -0,0 +1,42 @@
+html
+head
+script
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+ layoutTestController.setCanOpenWindows();
+ layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+
+window._onload_ = function()
+{
+ victim = document.body.appendChild(document.createElement(iframe));
+ wnd = victim.contentWindow.open();
+ victim.src = ""
+ victim._onload_ = function() {
+ victim._onload_ = null;
+
+ wnd.eval(( + function() {
+ location = _javascript_:( + function() {
+a = document.createElement(a);
+a.href = ""
+e = document.createEvent(MouseEvent);
+e.initMouseEvent(click);
+a.dispatchEvent(e);
+
+return script( + function() {
+ opener.location = _javascript_:alert(document.body.innerHTML);
+
+ if (window.layoutTestController)
+ setTimeout(layoutTestController.notifyDone(), 0);
+} + )()\/script;
+ } + )();
+ } + )());
+ }
+}
+/script
+/head
+body
+This test passes if there's no alert dialog.
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (97086 => 97087)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 21:21:41 UTC (rev 97086)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 21:28:53 UTC (rev 97087)
@@ -1,3 +1,19 @@
+2011-10-10 Sergey Glazunov serg.glazu...@gmail.com
+
+ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
+https://bugs.webkit.org/show_bug.cgi?id=69777
+
+Reviewed by Adam Barth.
+
+Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
+
+*
[webkit-changes] [97088] trunk
Title: [97088] trunk
Revision 97088
Author commit-qu...@webkit.org
Date 2011-10-10 14:31:14 -0700 (Mon, 10 Oct 2011)
Log Message
Exiting fullscreen shouldn't crash if the element that was fullscreened
had associated anonymous blocks.
https://bugs.webkit.org/show_bug.cgi?id=68503
Source/WebCore:
Patch by Jeremy Apthorp jere...@chromium.org on 2011-10-10
Reviewed by Simon Fraser.
Test: fullscreen/full-screen-render-inline.html
Test: fullscreen/parent-flow-inline-with-block-child.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveChildrenTo):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::moveChildTo):
(WebCore::RenderBlock::moveAllChildrenTo):
(WebCore::RenderBlock::moveChildrenTo):
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
Move all children back to the parent, not just the firstChild.
LayoutTests:
When exiting fullscreen, if the child of the RenderFullScreen is a
block and the parent has inline flow elements, the parent's children
should be made non-inline before adding the fullscreened element back
to the parent.
Patch by Jeremy Apthorp jere...@chromium.org on 2011-10-10
Reviewed by Simon Fraser.
* fullscreen/full-screen-render-inline.html: Added.
* fullscreen/full-screen-render-inline-expected.png: Added.
* fullscreen/full-screen-render-inline-expected.txt: Added.
* fullscreen/parent-flow-inline-with-block-child.html: Added.
* fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
* fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFullScreen.cpp
Added Paths
trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.png
trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.txt
trunk/LayoutTests/fullscreen/full-screen-render-inline.html
trunk/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.png
trunk/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.txt
trunk/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97087 => 97088)
--- trunk/LayoutTests/ChangeLog 2011-10-10 21:28:53 UTC (rev 97087)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 21:31:14 UTC (rev 97088)
@@ -1,3 +1,23 @@
+2011-10-10 Jeremy Apthorp jere...@chromium.org
+
+Exiting fullscreen shouldn't crash if the element that was fullscreened
+had associated anonymous blocks.
+https://bugs.webkit.org/show_bug.cgi?id=68503
+
+When exiting fullscreen, if the child of the RenderFullScreen is a
+block and the parent has inline flow elements, the parent's children
+should be made non-inline before adding the fullscreened element back
+to the parent.
+
+Reviewed by Simon Fraser.
+
+* fullscreen/full-screen-render-inline.html: Added.
+* fullscreen/full-screen-render-inline-expected.png: Added.
+* fullscreen/full-screen-render-inline-expected.txt: Added.
+* fullscreen/parent-flow-inline-with-block-child.html: Added.
+* fullscreen/parent-flow-inline-with-block-child-expected.png: Added.
+* fullscreen/parent-flow-inline-with-block-child-expected.txt: Added.
+
2011-10-10 Sergey Glazunov serg.glazu...@gmail.com
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
Added: trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.png (0 => 97088)
--- trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.png (rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.png 2011-10-10 21:31:14 UTC (rev 97088)
@@ -0,0 +1,4 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum b18b65cdba862a3c73de2fb5e5a1ec37\xA0A1 \x95IDATx\x9C\xED\xDD1\xC2@ A\xDD\xFF\xBFl^\x80R@6\x82\xCC\xD4\xD9\xED\xCAE\xD6\xCC\xCC \xF0\xBCz \xE0 \x90 @F\x80 d \x90 @f =Xk{\xBC\xE57% \xF0?\@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8\xEC\xB3\xCC\xCC\xD9# \x80 \xE1 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @f\x9F=`\xAD\xF5\xD1\xF73\xF3\xA5M \x80\xAB\xB9\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90\xD9Gf\xA6\xD8 \xB8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8
[webkit-changes] [97089] trunk/Tools
Title: [97089] trunk/Tools
Revision 97089
Author commit-qu...@webkit.org
Date 2011-10-10 14:31:45 -0700 (Mon, 10 Oct 2011)
Log Message
Unreviewed, rolling out r97082.
http://trac.webkit.org/changeset/97082
https://bugs.webkit.org/show_bug.cgi?id=69784
broke Windows build (Requested by smfr on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-10
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
(WTR::createCGContextFromImage):
(WTR::computeMD5HashStringForContext):
(WTR::dumpBitmap):
(WTR::paintRepaintRectOverlay):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
Added Paths
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
Removed Paths
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.mm
Diff
Modified: trunk/Tools/ChangeLog (97088 => 97089)
--- trunk/Tools/ChangeLog 2011-10-10 21:31:14 UTC (rev 97088)
+++ trunk/Tools/ChangeLog 2011-10-10 21:31:45 UTC (rev 97089)
@@ -1,3 +1,21 @@
+2011-10-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r97082.
+http://trac.webkit.org/changeset/97082
+https://bugs.webkit.org/show_bug.cgi?id=69784
+
+broke Windows build (Requested by smfr on #webkit).
+
+* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+* WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
+(WTR::createCGContextFromImage):
+(WTR::computeMD5HashStringForContext):
+(WTR::dumpBitmap):
+(WTR::paintRepaintRectOverlay):
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::PlatformWebView):
+
2011-10-10 Simon Fraser simon.fra...@apple.com
3D transforms are flattened in WebKit2 snapshots
Modified: trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj (97088 => 97089)
--- trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2011-10-10 21:31:14 UTC (rev 97088)
+++ trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj 2011-10-10 21:31:45 UTC (rev 97089)
@@ -54,7 +54,7 @@
BC8DAD7B1316D91000EC96FC /* InjectedBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC8DAD771316D7B900EC96FC /* InjectedBundleMac.mm */; };
BC8FD8CA120E527F00F3E71A /* EventSendingController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC8FD8C9120E527F00F3E71A /* EventSendingController.cpp */; };
BC8FD8D2120E545B00F3E71A /* JSEventSendingController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC8FD8D0120E545B00F3E71A /* JSEventSendingController.cpp */; };
- BC9192051333E4F8003011DC /* TestInvocationCG.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC9192041333E4F8003011DC /* TestInvocationCG.mm */; };
+ BC9192051333E4F8003011DC /* TestInvocationCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC9192041333E4F8003011DC /* TestInvocationCG.cpp */; };
BC952C0D11F3B965003398B4 /* JSWrapper.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC952C0C11F3B965003398B4 /* JSWrapper.cpp */; };
BC952F1F11F3C652003398B4 /* JSLayoutTestController.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC952F1D11F3C652003398B4 /* JSLayoutTestController.cpp */; };
BCC997A411D3C8F60017BCA2 /* InjectedBundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BCC997A011D3C8F60017BCA2 /* InjectedBundle.cpp */; };
@@ -138,7 +138,7 @@
BC8FD8CB120E52B000F3E71A /* EventSendingController.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = EventSendingController.idl; sourceTree = group; };
BC8FD8D0120E545B00F3E71A /* JSEventSendingController.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSEventSendingController.cpp; path = DerivedSources/WebKitTestRunner/JSEventSendingController.cpp; sourceTree = BUILT_PRODUCTS_DIR; };
BC8FD8D1120E545B00F3E71A /* JSEventSendingController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSEventSendingController.h; path = DerivedSources/WebKitTestRunner/JSEventSendingController.h; sourceTree = BUILT_PRODUCTS_DIR; };
- BC9192041333E4F8003011DC /* TestInvocationCG.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = TestInvocationCG.mm; path = cg/TestInvocationCG.mm; sourceTree = group; };
+ BC9192041333E4F8003011DC /* TestInvocationCG.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = TestInvocationCG.cpp; path =
[webkit-changes] [97090] branches/chromium/874
Title: [97090] branches/chromium/874
Revision 97090
Author infe...@chromium.org
Date 2011-10-10 14:32:57 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97087 - ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
BUG=99750
Review URL: http://codereview.chromium.org/8223012
Modified Paths
branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp
branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp
branches/chromium/874/Source/WebCore/loader/DocumentWriter.h
branches/chromium/874/Source/WebKit/chromium/src/WebFrameImpl.cpp
Added Paths
branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt
branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
Diff
Copied: branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (from rev 97087, trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt) (0 => 97090)
--- branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-10 21:32:57 UTC (rev 97090)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
+
+This test passes if there's no alert dialog.
Copied: branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (from rev 97087, trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html) (0 => 97090)
--- branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-10 21:32:57 UTC (rev 97090)
@@ -0,0 +1,42 @@
+html
+head
+script
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+ layoutTestController.setCanOpenWindows();
+ layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+
+window._onload_ = function()
+{
+ victim = document.body.appendChild(document.createElement(iframe));
+ wnd = victim.contentWindow.open();
+ victim.src = ""
+ victim._onload_ = function() {
+ victim._onload_ = null;
+
+ wnd.eval(( + function() {
+ location = _javascript_:( + function() {
+a = document.createElement(a);
+a.href = ""
+e = document.createEvent(MouseEvent);
+e.initMouseEvent(click);
+a.dispatchEvent(e);
+
+return script( + function() {
+ opener.location = _javascript_:alert(document.body.innerHTML);
+
+ if (window.layoutTestController)
+ setTimeout(layoutTestController.notifyDone(), 0);
+} + )()\/script;
+ } + )();
+ } + )());
+ }
+}
+/script
+/head
+body
+This test passes if there's no alert dialog.
+/body
+/html
Modified: branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp (97089 => 97090)
--- branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-10-10 21:31:45 UTC (rev 97089)
+++ branches/chromium/874/Source/WebCore/bindings/ScriptControllerBase.cpp 2011-10-10 21:32:57 UTC (rev 97090)
@@ -93,6 +93,7 @@
// We need to hold onto the Frame here because executing script can
// destroy the frame.
RefPtrFrame protector(m_frame);
+RefPtrDocument ownerDocument(m_frame-document());
const int _javascript_SchemeLength = sizeof(_javascript_:) - 1;
@@ -125,7 +126,7 @@
// DocumentWriter::replaceDocument can cause the DocumentLoader to get deref'ed and possible destroyed,
// so protect it with a RefPtr.
if (RefPtrDocumentLoader loader = m_frame-document()-loader())
-loader-writer()-replaceDocument(scriptResult);
+loader-writer()-replaceDocument(scriptResult, ownerDocument.get());
}
return true;
}
Modified: branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp (97089 => 97090)
--- branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp 2011-10-10 21:31:45 UTC (rev 97089)
+++ branches/chromium/874/Source/WebCore/loader/DocumentWriter.cpp 2011-10-10 21:32:57 UTC (rev 97090)
@@ -64,10 +64,10 @@
// This is only called by ScriptController::executeIfJavaScriptURL
// and always contains the result of evaluating a _javascript_: url.
// This is the iframe src="" case.
-void DocumentWriter::replaceDocument(const String source)
+void DocumentWriter::replaceDocument(const String source, Document* ownerDocument)
{
[webkit-changes] [97091] branches/chromium/874
Title: [97091] branches/chromium/874
Revision 97091
Author infe...@chromium.org
Date 2011-10-10 14:43:56 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 95371 - Don't detach elements from the render tree when entering fullscreen mode
BUG=97006
Review URL: http://codereview.chromium.org/8218020
Modified Paths
branches/chromium/874/Source/WebCore/dom/Document.cpp
branches/chromium/874/Source/WebCore/dom/NodeRenderingContext.cpp
branches/chromium/874/Source/WebCore/rendering/RenderFullScreen.cpp
branches/chromium/874/Source/WebCore/rendering/RenderFullScreen.h
Added Paths
branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload-expected.txt
branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload.html
Diff
Copied: branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload-expected.txt (from rev 95371, trunk/LayoutTests/plugins/fullscreen-plugins-dont-reload-expected.txt) (0 => 97091)
--- branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload-expected.txt 2011-10-10 21:43:56 UTC (rev 97091)
@@ -0,0 +1,5 @@
+ALERT: Plugin Loaded!
+go fullscreen
+There should only be one ALERT. If there were two, the plugin was reloaded during the transition to fullscreen.
+
+
Copied: branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload.html (from rev 95371, trunk/LayoutTests/plugins/fullscreen-plugins-dont-reload.html) (0 => 97091)
--- branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload.html (rev 0)
+++ branches/chromium/874/LayoutTests/plugins/fullscreen-plugins-dont-reload.html 2011-10-10 21:43:56 UTC (rev 97091)
@@ -0,0 +1,25 @@
+html
+a id='link' href=""
+fullscreen/a
+p
+There should only be one ALERT. If there were two, the plugin was reloaded
+during the transition to fullscreen.
+/p
+embed id=plg type=application/x-webkit-test-netscape src=""
+
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+
+var plugin = document.getElementById('plg');
+plugin.addEventListener('webkitfullscreenchange', function () {
+layoutTestController.notifyDone();
+})
+document.addEventListener('keydown', function () {
+plugin.webkitRequestFullScreen();
+})
+eventSender.keyDown('a')
+}
+/script
+/html
Modified: branches/chromium/874/Source/WebCore/dom/Document.cpp (97090 => 97091)
--- branches/chromium/874/Source/WebCore/dom/Document.cpp 2011-10-10 21:32:57 UTC (rev 97090)
+++ branches/chromium/874/Source/WebCore/dom/Document.cpp 2011-10-10 21:43:56 UTC (rev 97091)
@@ -4882,6 +4882,9 @@
ASSERT(element);
ASSERT(page() page()-settings()-fullScreenEnabled());
+if (m_fullScreenRenderer)
+m_fullScreenRenderer-unwrapRenderer();
+
m_fullScreenElement = element;
// Create a placeholder block for a the full-screen element, to keep the page from reflowing
@@ -4896,7 +4899,7 @@
}
if (m_fullScreenElement != documentElement())
-m_fullScreenElement-detach();
+RenderFullScreen::wrapRenderer(renderer, this);
m_fullScreenElement-setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);
@@ -4947,15 +4950,11 @@
{
m_areKeysEnabledInFullScreen = false;
setAnimatingFullScreen(false);
-
-if (m_fullScreenRenderer)
-m_fullScreenRenderer-remove();
-if (m_fullScreenElement != documentElement())
-m_fullScreenElement-detach();
+if (m_fullScreenRenderer)
+m_fullScreenRenderer-unwrapRenderer();
m_fullScreenChangeEventTargetQueue.append(m_fullScreenElement.release());
-setFullScreenRenderer(0);
#if USE(ACCELERATED_COMPOSITING)
page()-chrome()-client()-setRootFullScreenLayer(0);
#endif
Modified: branches/chromium/874/Source/WebCore/dom/NodeRenderingContext.cpp (97090 => 97091)
--- branches/chromium/874/Source/WebCore/dom/NodeRenderingContext.cpp 2011-10-10 21:32:57 UTC (rev 97090)
+++ branches/chromium/874/Source/WebCore/dom/NodeRenderingContext.cpp 2011-10-10 21:43:56 UTC (rev 97091)
@@ -321,22 +321,6 @@
return newRenderer;
}
-#if ENABLE(FULLSCREEN_API)
-static RenderObject* wrapWithRenderFullScreen(RenderObject* object, Document* document)
-{
-RenderFullScreen* fullscreenRenderer = new (document-renderArena()) RenderFullScreen(document);
-fullscreenRenderer-setStyle(RenderFullScreen::createFullScreenStyle());
-// It's possible that we failed to create the new render and end up wrapping nothing.
-// We'll end up displaying a black screen, but Jer says this is expected.
-if (object)
-fullscreenRenderer-addChild(object);
-document-setFullScreenRenderer(fullscreenRenderer);
-if (fullscreenRenderer-placeholder())
-return fullscreenRenderer-placeholder();
-return
[webkit-changes] [97092] branches/chromium/874
Title: [97092] branches/chromium/874
Revision 97092
Author infe...@chromium.org
Date 2011-10-10 14:46:22 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97088 - Exiting fullscreen shouldn't crash if the element that was fullscreened had associated anonymous blocks.
BUG=97006
Review URL: http://codereview.chromium.org/8218021
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderFullScreen.cpp
Added Paths
branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline-expected.png
branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline-expected.txt
branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline.html
branches/chromium/874/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.png
branches/chromium/874/LayoutTests/fullscreen/parent-flow-inline-with-block-child-expected.txt
branches/chromium/874/LayoutTests/fullscreen/parent-flow-inline-with-block-child.html
Diff
Copied: branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline-expected.png (from rev 97088, trunk/LayoutTests/fullscreen/full-screen-render-inline-expected.png) (0 => 97092)
--- branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline-expected.png (rev 0)
+++ branches/chromium/874/LayoutTests/fullscreen/full-screen-render-inline-expected.png 2011-10-10 21:46:22 UTC (rev 97092)
@@ -0,0 +1,4 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum b18b65cdba862a3c73de2fb5e5a1ec37\xA0A1 \x95IDATx\x9C\xED\xDD1\xC2@ A\xDD\xFF\xBFl^\x80R@6\x82\xCC\xD4\xD9\xED\xCAE\xD6\xCC\xCC \xF0\xBCz \xE0 \x90 @F\x80 d \x90 @f =Xk{\xBC\xE57% \xF0?\@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8\xEC\xB3\xCC\xCC\xD9# \x80 \xE1 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @f\x9F=`\xAD\xF5\xD1\xF73\xF3\xA5M \x80\xAB\xB9\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90\xD9Gf\xA6\xD8 \xB8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8 #@ \x80\x8C 2 \xC8
[webkit-changes] [97093] trunk/Source/WebCore
Title: [97093] trunk/Source/WebCore
Revision 97093
Author jer.no...@apple.com
Date 2011-10-10 15:01:38 -0700 (Mon, 10 Oct 2011)
Log Message
media/video-loop.html is failing on Lion because of negative currentTime()
https://bugs.webkit.org/show_bug.cgi?id=69468
Reviewed by Darin Adler.
No new tests. Covered by media/video-loop.html test.
AVFoundation will occasionally return small, negative current times during loop operations.
Clean up these negative times before returning the currentTime.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (97092 => 97093)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 21:46:22 UTC (rev 97092)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 22:01:38 UTC (rev 97093)
@@ -1,3 +1,18 @@
+2011-10-06 Jer Noble jer.no...@apple.com
+
+media/video-loop.html is failing on Lion because of negative currentTime()
+https://bugs.webkit.org/show_bug.cgi?id=69468
+
+Reviewed by Darin Adler.
+
+No new tests. Covered by media/video-loop.html test.
+
+AVFoundation will occasionally return small, negative current times during loop operations.
+Clean up these negative times before returning the currentTime.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):
+
2011-10-10 Jeremy Apthorp jere...@chromium.org
Exiting fullscreen shouldn't crash if the element that was fullscreened
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (97092 => 97093)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2011-10-10 21:46:22 UTC (rev 97092)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2011-10-10 22:01:38 UTC (rev 97093)
@@ -430,8 +430,9 @@
return 0;
CMTime itemTime = [m_avPlayerItem.get() currentTime];
-if (CMTIME_IS_NUMERIC(itemTime))
-return narrowPrecisionToFloat(CMTimeGetSeconds(itemTime));
+if (CMTIME_IS_NUMERIC(itemTime)) {
+return max(narrowPrecisionToFloat(CMTimeGetSeconds(itemTime)), 0.0f);
+}
return 0;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97094] trunk/Tools
Title: [97094] trunk/Tools Revision 97094 Author le...@chromium.org Date 2011-10-10 15:02:35 -0700 (Mon, 10 Oct 2011) Log Message Quick fix for watchlist unit test failures when using Python 2.7+ Reviewed by Adam Barth. Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a better fix. * Scripts/webkitpy/common/webkitunittest.py: Always use our version of assertRaisesRegexp. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/webkitunittest.py Diff Modified: trunk/Tools/ChangeLog (97093 => 97094) --- trunk/Tools/ChangeLog 2011-10-10 22:01:38 UTC (rev 97093) +++ trunk/Tools/ChangeLog 2011-10-10 22:02:35 UTC (rev 97094) @@ -1,3 +1,14 @@ +2011-10-10 David Levin le...@chromium.org + +Quick fix for watchlist unit test failures when using Python 2.7+ +Reviewed by Adam Barth. + +Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a +better fix. + +* Scripts/webkitpy/common/webkitunittest.py: Always use our +version of assertRaisesRegexp. + 2011-10-10 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r97082. Modified: trunk/Tools/Scripts/webkitpy/common/webkitunittest.py (97093 => 97094) --- trunk/Tools/Scripts/webkitpy/common/webkitunittest.py 2011-10-10 22:01:38 UTC (rev 97093) +++ trunk/Tools/Scripts/webkitpy/common/webkitunittest.py 2011-10-10 22:02:35 UTC (rev 97094) @@ -34,9 +34,8 @@ class TestCase(unittest.TestCase): def setUp(self): -# For versions of Python before 2.7. -if not 'assertRaisesRegexp' in dir(self): -self.assertRaisesRegexp = self._assertRaisesRegexp +# FIXME: Only do this for versions of Python before 2.7. +self.assertRaisesRegexp = self._assertRaisesRegexp def _assertRaisesRegexp(self, regex_message, callable, *args): try: ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97095] trunk/Source/WebKit
Title: [97095] trunk/Source/WebKit
Revision 97095
Author joep...@webkit.org
Date 2011-10-10 15:05:16 -0700 (Mon, 10 Oct 2011)
Log Message
http://webkit.org/b/69575 Extract WebOpenPanelResultListener out into its own file
Reviewed by David Kilzer.
Source/WebKit:
* WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Extract the WebOpenPanelResultListener class out into
its own file. No functional change.
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebOpenPanelResultListener.h: Added.
* WebCoreSupport/WebOpenPanelResultListener.mm: Added.
(-[WebOpenPanelResultListener dealloc]):
(-[WebOpenPanelResultListener finalize]):
(-[WebOpenPanelResultListener cancel]):
(-[WebOpenPanelResultListener chooseFilename:]):
(-[WebOpenPanelResultListener chooseFilenames:]):
* WebView/WebUIDelegate.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm
trunk/Source/WebKit/mac/WebView/WebUIDelegate.h
Added Paths
trunk/Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.h
trunk/Source/WebKit/mac/WebCoreSupport/WebOpenPanelResultListener.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (97094 => 97095)
--- trunk/Source/WebKit/ChangeLog 2011-10-10 22:02:35 UTC (rev 97094)
+++ trunk/Source/WebKit/ChangeLog 2011-10-10 22:05:16 UTC (rev 97095)
@@ -1,3 +1,12 @@
+2011-10-10 Joseph Pecoraro joep...@webkit.org
+
+Extract WebOpenPanelResultListener out into its own file
+https://bugs.webkit.org/show_bug.cgi?id=69575
+
+Reviewed by David Kilzer.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2011-10-06 Anders Carlsson ander...@apple.com
When building with clang, enable -Wglobal-constructors and -Wexit-time-destructors
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (97094 => 97095)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2011-10-10 22:02:35 UTC (rev 97094)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2011-10-10 22:05:16 UTC (rev 97095)
@@ -320,6 +320,8 @@
A5687BDA135B791A0074CBCB /* WebNodeHighlighter.h in Headers */ = {isa = PBXBuildFile; fileRef = A5687BD8135B791A0074CBCB /* WebNodeHighlighter.h */; };
A5687BDB135B791A0074CBCB /* WebNodeHighlighter.mm in Sources */ = {isa = PBXBuildFile; fileRef = A5687BD9135B791A0074CBCB /* WebNodeHighlighter.mm */; };
A57E2F24120749E600048DF3 /* WebQuotaManager.h in Headers */ = {isa = PBXBuildFile; fileRef = A57E2F22120749E600048DF3 /* WebQuotaManager.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ A58A5799143E727000125F50 /* WebOpenPanelResultListener.h in Headers */ = {isa = PBXBuildFile; fileRef = A58A5797143E727000125F50 /* WebOpenPanelResultListener.h */; };
+ A58A579A143E727000125F50 /* WebOpenPanelResultListener.mm in Sources */ = {isa = PBXBuildFile; fileRef = A58A5798143E727000125F50 /* WebOpenPanelResultListener.mm */; };
A5DEFC0A11D5331C00885273 /* WebSecurityOrigin.mm in Sources */ = {isa = PBXBuildFile; fileRef = A5DEFC0711D5331C00885273 /* WebSecurityOrigin.mm */; };
A5DEFC0B11D5331C00885273 /* WebSecurityOriginInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = A5DEFC0811D5331C00885273 /* WebSecurityOriginInternal.h */; };
A5DEFC0C11D5331C00885273 /* WebSecurityOriginPrivate.h in Headers */ = {isa = PBXBuildFile; fileRef = A5DEFC0911D5331C00885273 /* WebSecurityOriginPrivate.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -629,6 +631,8 @@
A5687BD8135B791A0074CBCB /* WebNodeHighlighter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebNodeHighlighter.h; sourceTree = group; };
A5687BD9135B791A0074CBCB /* WebNodeHighlighter.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebNodeHighlighter.mm; sourceTree = group; };
A57E2F22120749E600048DF3 /* WebQuotaManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebQuotaManager.h; sourceTree = group; };
+ A58A5797143E727000125F50 /* WebOpenPanelResultListener.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebOpenPanelResultListener.h; sourceTree = group; };
+ A58A5798143E727000125F50 /* WebOpenPanelResultListener.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebOpenPanelResultListener.mm; sourceTree = group; };
A5DEFC0711D5331C00885273 /* WebSecurityOrigin.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebSecurityOrigin.mm; sourceTree = group; };
A5DEFC0811D5331C00885273 /* WebSecurityOriginInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebSecurityOriginInternal.h; sourceTree = group; };
A5DEFC0911D5331C00885273 /* WebSecurityOriginPrivate.h */ = {isa = PBXFileReference;
[webkit-changes] [97096] trunk/LayoutTests
Title: [97096] trunk/LayoutTests Revision 97096 Author simon...@chromium.org Date 2011-10-10 15:17:57 -0700 (Mon, 10 Oct 2011) Log Message [Chromium] Add baselines for new tests. Update baselines for 10.6 debug and rolled out v8 change. Unreviewed. * platform/chromium-mac-snowleopard/fast/lists/inline-before-content-after-list-marker-expected.png: Added. * platform/chromium-mac-snowleopard/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. * platform/chromium-win/fast/lists/inline-before-content-after-list-marker-expected.png: Added. * platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/lists/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/lists/inline-before-content-after-list-marker-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/runin/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/runin/runin-between-list-marker-and-before-content-expected.png trunk/LayoutTests/platform/chromium-win/fast/lists/inline-before-content-after-list-marker-expected.png trunk/LayoutTests/platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97095 => 97096) --- trunk/LayoutTests/ChangeLog 2011-10-10 22:05:16 UTC (rev 97095) +++ trunk/LayoutTests/ChangeLog 2011-10-10 22:17:57 UTC (rev 97096) @@ -1,3 +1,15 @@ +2011-10-10 James Simonsen simon...@chromium.org + +[Chromium] Add baselines for new tests. Update baselines for 10.6 debug and rolled out v8 change. + +Unreviewed. + +* platform/chromium-mac-snowleopard/fast/lists/inline-before-content-after-list-marker-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. +* platform/chromium-win/fast/lists/inline-before-content-after-list-marker-expected.png: Added. +* platform/chromium-win/fast/runin/runin-between-list-marker-and-before-content-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-10-10 Jeremy Apthorp jere...@chromium.org Exiting fullscreen shouldn't crash if the element that was fullscreened Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97095 => 97096) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 22:05:16 UTC (rev 97095) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 22:17:57 UTC (rev 97096) @@ -2785,7 +2785,7 @@ // Flaky BUGCR76609 DEBUG : animations/play-state.html = PASS TEXT BUGCR76610 MAC WIN DEBUG : canvas/philip/tests/2d.text.draw.align.center.html = PASS TEXT -BUGCR76716 LINUX WIN SNOWLEOPARD DEBUG : fast/css/first-child-pseudo-class.html = PASS TEXT +BUGCR76716 LINUX WIN DEBUG : fast/css/first-child-pseudo-class.html = PASS TEXT BUGCR76979 WIN RELEASE : inspector/console/console-dirxml.html = PASS TEXT BUGCR76979 SLOW LINUX WIN DEBUG : inspector/console/console-dirxml.html = PASS @@ -2937,7 +2937,7 @@ BUGCR79854 : editing/execCommand/delete-empty-container.html = PASS TEXT // Flaky on debug -BUGCR79855 LINUX WIN SNOWLEOPARD DEBUG : fast/css/only-child-pseudo-class.html = PASS TEXT +BUGCR79855 LINUX WIN DEBUG : fast/css/only-child-pseudo-class.html = PASS TEXT // Flaky on debug BUGCR79857 DEBUG : fast/events/popup-blocking-timers.html = PASS TEXT @@ -2955,7 +2955,7 @@ BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = PASS TIMEOUT BUGWK60099 DEBUG : fast/dom/Attr/access-after-element-destruction.html = PASS CRASH -BUGWK60096 LINUX WIN SNOWLEOPARD DEBUG : fast/css/last-child-pseudo-class.html = PASS TEXT +BUGWK60096 LINUX WIN DEBUG : fast/css/last-child-pseudo-class.html = PASS TEXT BUGWK60097 DEBUG : fast/dom/HTMLLinkElement/link-and-subresource-test.html = PASS TEXT // Looks like some uninitialized memory at the bottom. @@ -2992,7 +2992,7 @@ BUGDPRANKE WIN DEBUG : http/tests/misc/empty-file-formdata.html = PASS TIMEOUT BUGDPRANKE WIN DEBUG : http/tests/xmlhttprequest/access-control-preflight-headers-async.html = PASS TIMEOUT -BUGDPRANKE LINUX WIN SNOWLEOPARD DEBUG : fast/css/only-of-type-pseudo-class.html = PASS TEXT +BUGDPRANKE LINUX WIN DEBUG : fast/css/only-of-type-pseudo-class.html = PASS TEXT // Introduced in r84443 BUGWK59063 : fast/images/animated-gif-restored-from-bfcache.html = TEXT @@ -3076,7 +3076,7 @@ BUGDPRANKE WIN DEBUG : fast/css/getComputedStyle/counterIncrement-without-counter.html = PASS CRASH // flakiness on the deps bots (noted r~83476) -BUGWK60105 LINUX WIN SNOWLEOPARD DEBUG : fast/css/empty-pseudo-class.html = PASS TEXT +BUGWK60105 LINUX WIN DEBUG : fast/css/empty-pseudo-class.html = PASS TEXT BUGWK59782 LINUX WIN :
[webkit-changes] [97098] trunk/Tools/Scripts/webkitpy/common/config/committers.py
Title: [97098] trunk/Tools/Scripts/webkitpy/common/config/committers.py Revision 97098 Author dmazz...@google.com Date 2011-10-10 15:39:20 -0700 (Mon, 10 Oct 2011) Log Message Adding myself to the committers file. Modified Paths trunk/Tools/Scripts/webkitpy/common/config/committers.py Diff Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (97097 => 97098) --- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-10-10 22:32:00 UTC (rev 97097) +++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-10-10 22:39:20 UTC (rev 97098) @@ -178,6 +178,7 @@ Committer(Diego Gonzalez, [diego...@webkit.org, diego.gonza...@openbossa.org], diegohcg), Committer(Dmitry Lomov, [dslo...@google.com, dslo...@chromium.org], dslomov), Committer(Dominic Cooney, [domin...@chromium.org, domin...@google.com], dominicc), +Committer(Dominic Mazzoni, [dmazz...@chromium.org, dmazz...@google.com], dmazzoni), Committer(Drew Wilson, atwil...@chromium.org, atwilson), Committer(Eli Fidler, [e...@staikos.net, efid...@rim.com], efidler), Committer(Emil A Eklund, e...@chromium.org, eae), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97099] trunk
Title: [97099] trunk
Revision 97099
Author fpi...@apple.com
Date 2011-10-10 15:41:01 -0700 (Mon, 10 Oct 2011)
Log Message
REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
https://bugs.webkit.org/show_bug.cgi?id=69412
Reviewed by Oliver Hunt.
Source/_javascript_Core:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
LayoutTests:
* fast/js/dfg-min-max-expected.txt: Added.
* fast/js/dfg-min-max.html: Added.
* fast/js/script-tests/dfg-min-max.js: Added.
(doMin):
(doMax):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/jit/JIT.h
Added Paths
trunk/LayoutTests/fast/js/dfg-min-max-expected.txt
trunk/LayoutTests/fast/js/dfg-min-max.html
trunk/LayoutTests/fast/js/script-tests/dfg-min-max.js
Diff
Modified: trunk/LayoutTests/ChangeLog (97098 => 97099)
--- trunk/LayoutTests/ChangeLog 2011-10-10 22:39:20 UTC (rev 97098)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 22:41:01 UTC (rev 97099)
@@ -1,3 +1,16 @@
+2011-10-10 Filip Pizlo fpi...@apple.com
+
+REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
+https://bugs.webkit.org/show_bug.cgi?id=69412
+
+Reviewed by Oliver Hunt.
+
+* fast/js/dfg-min-max-expected.txt: Added.
+* fast/js/dfg-min-max.html: Added.
+* fast/js/script-tests/dfg-min-max.js: Added.
+(doMin):
+(doMax):
+
2011-10-10 James Simonsen simon...@chromium.org
[Chromium] Add baselines for new tests. Update baselines for 10.6 debug and rolled out v8 change.
Added: trunk/LayoutTests/fast/js/dfg-min-max-expected.txt (0 => 97099)
--- trunk/LayoutTests/fast/js/dfg-min-max-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/dfg-min-max-expected.txt 2011-10-10 22:41:01 UTC (rev 97099)
@@ -0,0 +1,27 @@
+This tests that Math.min and Math.max for doubles works correctly in the DFG JIT.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS doMin(1.5, 2.5) is 1.5
+PASS doMin(2.5, 1.5) is 1.5
+PASS doMin(1.5, 1.5) is 1.5
+PASS doMin(2.5, 2.5) is 2.5
+PASS doMin(1.5, NaN) is NaN
+PASS doMin(2.5, NaN) is NaN
+PASS doMin(NaN, 1.5) is NaN
+PASS doMin(NaN, 2.5) is NaN
+PASS doMin(NaN, NaN) is NaN
+PASS doMax(1.5, 2.5) is 2.5
+PASS doMax(2.5, 1.5) is 2.5
+PASS doMax(1.5, 1.5) is 1.5
+PASS doMax(2.5, 2.5) is 2.5
+PASS doMax(1.5, NaN) is NaN
+PASS doMax(2.5, NaN) is NaN
+PASS doMax(NaN, 1.5) is NaN
+PASS doMax(NaN, 2.5) is NaN
+PASS doMax(NaN, NaN) is NaN
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/js/dfg-min-max.html (0 => 97099)
--- trunk/LayoutTests/fast/js/dfg-min-max.html (rev 0)
+++ trunk/LayoutTests/fast/js/dfg-min-max.html 2011-10-10 22:41:01 UTC (rev 97099)
@@ -0,0 +1,13 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script src=""
+script src=""
+/body
+/html
Added: trunk/LayoutTests/fast/js/script-tests/dfg-min-max.js (0 => 97099)
--- trunk/LayoutTests/fast/js/script-tests/dfg-min-max.js (rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/dfg-min-max.js 2011-10-10 22:41:01 UTC (rev 97099)
@@ -0,0 +1,42 @@
+description(
+This tests that Math.min and Math.max for doubles works correctly in the DFG JIT.
+);
+
+function doMin(a, b) {
+return Math.min(a, b);
+}
+
+function doMax(a, b) {
+return Math.max(a, b);
+}
+
+for (var i = 0; i 1000; ++i) {
+doMin(1.5, 2.5);
+doMax(1.5, 2.5);
+}
+
+shouldBe(doMin(1.5, 2.5), 1.5);
+shouldBe(doMin(2.5, 1.5), 1.5);
+shouldBe(doMin(1.5, 1.5), 1.5);
+shouldBe(doMin(2.5, 2.5), 2.5);
+
+shouldBe(doMin(1.5, NaN), NaN);
+shouldBe(doMin(2.5, NaN), NaN);
+shouldBe(doMin(NaN, 1.5), NaN);
+shouldBe(doMin(NaN, 2.5), NaN);
+
+shouldBe(doMin(NaN, NaN), NaN);
+
+shouldBe(doMax(1.5, 2.5), 2.5);
+shouldBe(doMax(2.5, 1.5), 2.5);
+shouldBe(doMax(1.5, 1.5), 1.5);
+shouldBe(doMax(2.5, 2.5), 2.5);
+
+shouldBe(doMax(1.5, NaN), NaN);
+shouldBe(doMax(2.5, NaN), NaN);
+shouldBe(doMax(NaN, 1.5), NaN);
+shouldBe(doMax(NaN, 2.5), NaN);
+
+shouldBe(doMax(NaN, NaN), NaN);
+
+var successfullyParsed = true;
Modified: trunk/Source/_javascript_Core/ChangeLog (97098 => 97099)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 22:39:20 UTC (rev 97098)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 22:41:01 UTC (rev 97099)
@@ -1,3 +1,18 @@
+2011-10-10 Filip Pizlo fpi...@apple.com
+
+REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
+
[webkit-changes] [97100] trunk
Title: [97100] trunk Revision 97100 Author jer.no...@apple.com Date 2011-10-10 15:42:28 -0700 (Mon, 10 Oct 2011) Log Message MediaControlSeekButtonElement should support seeking by changing the playback rate. https://bugs.webkit.org/show_bug.cgi?id=63595 Reviewed by Eric Carlson. Source/WebCore: Test: media/video-controls-scanning.html Add a new property to HTMLMediaElement, supportsScanning(), which returns whether the element is capable of playing its media at a rate greater than 1x. HTMLMediaElement passes this call through to MediaPlayer and MediaPlayerPrivate. If this property returns true, the built-in scanning controls can prefer to scan by changing the playbackRate, rather than by repeatedly seeking small amounts of time. Unless overridden by specific media engines, this property defaults to false. * html/HTMLMediaElement.h: * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::supportsScanning): Added. Calls through to MediaPlayer. * platform/graphics/MediaPlayer.h: * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::supportsScanning): Added. Calls through to MediaPlayerPrivate. * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::supportsScanning): Added. Defaults to false. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::supportsScanning): Added. * platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivateQTKit::supportsScanning): Added. MediaControlSeekButtonElement now queries HTMLMediaElement::supportsScanning() to see if the media element can implement its seeking behavior by scanning the media at greater than 1x rate. Note whether the media was playing or paused when the seek begins, so that the playing state can be restored when seeking ends. Instead of capturing the mouse after mouseDown, the seek button now responds to setActive() and begins seeking when the button is active and stops when it becomes inactive. Some behaviors have changed: clicking on the seek button no longer causes the media element to pause; the media will end in the same state it began after the click. cStepTime has been eliminated; Clicking the seek button will always skip by at least cSeekTime, or 0.2s. * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Initialize new ivars. (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Mark mouseDown and mouseUp as defaultHandled, so as not to trigger drag start and drag end actions. (WebCore::MediaControlSeekButtonElement::setActive): Call startTimer or stopTimer based on whether the button is active or not. (WebCore::MediaControlSeekButtonElement::startTimer): Determine whether to scan or skip and start the seekTimer. (WebCore::MediaControlSeekButtonElement::stopTimer): Restore the playing state and stop the timer. (WebCore::MediaControlSeekButtonElement::seekTimerFired): Depending on whether we're scanning or skipping, jump ahead or change the playback rate. * html/shadow/MediaControlElements.h: LayoutTests: * media/video-controls-scanning-expected.txt: Added. * media/video-controls-scanning.html: Added. * platform/mac/media/video-controls-scanning-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/html/shadow/MediaControlElements.cpp trunk/Source/WebCore/html/shadow/MediaControlElements.h trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.h Diff Modified: trunk/LayoutTests/ChangeLog (97099 => 97100) --- trunk/LayoutTests/ChangeLog 2011-10-10 22:41:01 UTC (rev 97099) +++ trunk/LayoutTests/ChangeLog 2011-10-10 22:42:28 UTC (rev 97100) @@ -1,3 +1,14 @@ +2011-09-20 Jer Noble jer.no...@apple.com + +MediaControlSeekButtonElement should support seeking by changing the playback rate. +https://bugs.webkit.org/show_bug.cgi?id=63595 + +Reviewed by Eric Carlson. + +* media/video-controls-scanning-expected.txt: Added. +* media/video-controls-scanning.html: Added. +* platform/mac/media/video-controls-scanning-expected.txt: Added. + 2011-10-10 Filip Pizlo fpi...@apple.com REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs Modified: trunk/Source/WebCore/ChangeLog (97099 => 97100) --- trunk/Source/WebCore/ChangeLog 2011-10-10 22:41:01 UTC (rev 97099) +++ trunk/Source/WebCore/ChangeLog 2011-10-10 22:42:28 UTC (rev 97100) @@ -1,3 +1,58 @@ +2011-09-20 Jer Noble jer.no...@apple.com + +MediaControlSeekButtonElement should support
[webkit-changes] [97101] trunk/Source/JavaScriptCore
Title: [97101] trunk/Source/_javascript_Core
Revision 97101
Author barraclo...@apple.com
Date 2011-10-10 15:54:05 -0700 (Mon, 10 Oct 2011)
Log Message
DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795
Reviewed by Oliver Hunt.
Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGRepatch.cpp:
(JSC::DFG::appropriatePutByIdFunction):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGRepatch.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97100 => 97101)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 22:42:28 UTC (rev 97100)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 22:54:05 UTC (rev 97101)
@@ -1,3 +1,25 @@
+2011-10-10 Gavin Barraclough baraclo...@apple.com
+
+DFG: Switch GetById / PutById to use callOperation
+https://bugs.webkit.org/show_bug.cgi?id=69795
+
+Reviewed by Oliver Hunt.
+
+Also make the take base as a cell, so 32_64 doesn't have to set up the cell tag.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::cachedGetById):
+(JSC::DFG::JITCodeGenerator::cachedPutById):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::cachedGetById):
+(JSC::DFG::JITCodeGenerator::cachedPutById):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+* dfg/DFGRepatch.cpp:
+(JSC::DFG::appropriatePutByIdFunction):
+
2011-10-10 Filip Pizlo fpi...@apple.com
REGRESSIoN (r95399): Web process hangs when opening documents on Google Docs
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97100 => 97101)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 22:42:28 UTC (rev 97100)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 22:54:05 UTC (rev 97101)
@@ -1098,9 +1098,9 @@
return appendCallWithExceptionCheckSetResult(operation, result);
}
-JITCompiler::Call callOperation(J_DFGOperation_EJI operation, GPRReg result, GPRReg arg1, Identifier* identifier)
+JITCompiler::Call callOperation(J_DFGOperation_ECI operation, GPRReg result, GPRReg arg1, Identifier* identifier)
{
-return callOperation((J_DFGOperation_EJP)operation, result, arg1, identifier);
+return callOperation((J_DFGOperation_EPP)operation, result, arg1, identifier);
}
JITCompiler::Call callOperation(J_DFGOperation_EJA operation, GPRReg result, GPRReg arg1, GPRReg arg2)
{
@@ -1156,7 +1156,7 @@
return appendCallWithExceptionCheckSetResult(operation, result);
}
-JITCompiler::Call callOperation(V_DFGOperation_EJJP operation, GPRReg arg1, GPRReg arg2, void* pointer)
+JITCompiler::Call callOperation(V_DFGOperation_EJPP operation, GPRReg arg1, GPRReg arg2, void* pointer)
{
setupStubArguments(arg1, arg2);
m_jit.move(JITCompiler::TrustedImmPtr(pointer), GPRInfo::argumentGPR3);
@@ -1164,9 +1164,9 @@
return appendCallWithExceptionCheck(operation);
}
-JITCompiler::Call callOperation(V_DFGOperation_EJJI operation, GPRReg arg1, GPRReg arg2, Identifier* identifier)
+JITCompiler::Call callOperation(V_DFGOperation_EJCI operation, GPRReg arg1, GPRReg arg2, Identifier* identifier)
{
-return callOperation((V_DFGOperation_EJJP)operation, arg1, arg2, identifier);
+return callOperation((V_DFGOperation_EJPP)operation, arg1, arg2, identifier);
}
JITCompiler::Call callOperation(V_DFGOperation_EJJJ operation, GPRReg arg1, GPRReg arg2, GPRReg arg3)
{
@@ -1292,9 +1292,9 @@
return appendCallWithExceptionCheckSetResult(operation, resultTag, resultPayload);
}
-JITCompiler::Call callOperation(J_DFGOperation_EJI operation, GPRReg resultTag, GPRReg resultPayload, GPRReg arg1Tag, GPRReg arg1Payload, Identifier* identifier)
+JITCompiler::Call callOperation(J_DFGOperation_ECI operation, GPRReg resultTag, GPRReg resultPayload, GPRReg arg1, Identifier* identifier)
{
-return callOperation((J_DFGOperation_EJP)operation, resultTag, resultPayload, arg1Tag, arg1Payload, identifier);
+return
[webkit-changes] [97102] trunk
Title: [97102] trunk
Revision 97102
Author rn...@webkit.org
Date 2011-10-10 16:09:12 -0700 (Mon, 10 Oct 2011)
Log Message
REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
https://bugs.webkit.org/show_bug.cgi?id=69587
Reviewed by Enrica Casucci.
Source/WebCore:
Insert a space at the correct offset when startNode is a text node.
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):
LayoutTests:
Unskip the test. Also rebaseline a test for a nbsp/sp change.
* platform/win/Skipped:
* platform/win/fast/events/ondragenter-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp
Added Paths
trunk/LayoutTests/platform/win/editing/pasteboard/smart-paste-008-expected.txt
trunk/LayoutTests/platform/win/fast/events/ondragenter-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97101 => 97102)
--- trunk/LayoutTests/ChangeLog 2011-10-10 22:54:05 UTC (rev 97101)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 23:09:12 UTC (rev 97102)
@@ -1,3 +1,15 @@
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
+https://bugs.webkit.org/show_bug.cgi?id=69587
+
+Reviewed by Enrica Casucci.
+
+Unskip the test. Also rebaseline a test for a nbsp/sp change.
+
+* platform/win/Skipped:
+* platform/win/fast/events/ondragenter-expected.txt:
+
2011-09-20 Jer Noble jer.no...@apple.com
MediaControlSeekButtonElement should support seeking by changing the playback rate.
Modified: trunk/LayoutTests/platform/win/Skipped (97101 => 97102)
--- trunk/LayoutTests/platform/win/Skipped 2011-10-10 22:54:05 UTC (rev 97101)
+++ trunk/LayoutTests/platform/win/Skipped 2011-10-10 23:09:12 UTC (rev 97102)
@@ -1419,7 +1419,3 @@
# https://bugs.webkit.org/show_bug.cgi?id=66773
http/tests/loading/progress-finished-callback.html
-
-# REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
-# https://bugs.webkit.org/show_bug.cgi?id=69587
-editing/pasteboard/smart-paste-008.html
Copied: trunk/LayoutTests/platform/win/editing/pasteboard/smart-paste-008-expected.txt (from rev 97101, trunk/LayoutTests/platform/mac/editing/pasteboard/smart-paste-008-expected.txt) (0 => 97102)
--- trunk/LayoutTests/platform/win/editing/pasteboard/smart-paste-008-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/editing/pasteboard/smart-paste-008-expected.txt 2011-10-10 23:09:12 UTC (rev 97102)
@@ -0,0 +1,21 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 773x36
+ text run at (0,0) width 394: There was a bug in paste's smart replace whitespace handling.
+ text run at (394,0) width 379: In some cases, it used information gathered at the start of the
+ text run at (0,18) width 722: selection being pasted into to decide whether or not a space needed to be added to the end of the incoming content.
+ RenderBlock {P} at (0,52) size 784x36
+RenderText {#text} at (0,0) size 765x36
+ text run at (0,0) width 548: A smart paste is performed into a selection starting in one block and ending in another.
+ text run at (548,0) width 217: Spaces should surround the pasted
+ text run at (0,18) width 37: word.
+ RenderBlock {DIV} at (0,104) size 784x18
+RenderBlock {DIV} at (0,0) size 784x18
+ RenderText {#text} at (0,0) size 54x18
+text run at (0,0) width 54: f foo bar
+RenderBlock (anonymous) at (0,18) size 784x0
+caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
Copied: trunk/LayoutTests/platform/win/fast/events/ondragenter-expected.txt (from rev 97101, trunk/LayoutTests/fast/events/ondragenter-expected.txt) (0 => 97102)
--- trunk/LayoutTests/platform/win/fast/events/ondragenter-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/fast/events/ondragenter-expected.txt 2011-10-10 23:09:12 UTC (rev 97102)
@@ -0,0 +1,3 @@
+
+Success: Text
+This automated layout test checks to see that ondragenter events are being sent.
Modified: trunk/Source/WebCore/ChangeLog (97101 => 97102)
--- trunk/Source/WebCore/ChangeLog 2011-10-10 22:54:05 UTC (rev 97101)
+++ trunk/Source/WebCore/ChangeLog 2011-10-10 23:09:12 UTC (rev 97102)
@@ -1,3 +1,15 @@
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
+REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
+https://bugs.webkit.org/show_bug.cgi?id=69587
+
+Reviewed by Enrica Casucci.
+
+Insert a space at the correct offset
[webkit-changes] [97103] trunk
Title: [97103] trunk
Revision 97103
Author tha...@chromium.org
Date 2011-10-10 16:32:15 -0700 (Mon, 10 Oct 2011)
Log Message
PluginDocumentParser uses incorrect syntax for background color
https://bugs.webkit.org/show_bug.cgi?id=69694
Reviewed by Adam Barth.
Source/WebCore:
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
LayoutTests:
* platform/mac/plugins/iframe-plugin-bgcolor-expected.txt: Added
* plugins/iframe-plugin-bgcolor.html: Added.
* plugins/iframe-plugin-bgcolor-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/PluginDocument.cpp
Added Paths
trunk/LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt
trunk/LayoutTests/plugins/iframe-plugin-bgcolor-expected.png
trunk/LayoutTests/plugins/iframe-plugin-bgcolor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97102 => 97103)
--- trunk/LayoutTests/ChangeLog 2011-10-10 23:09:12 UTC (rev 97102)
+++ trunk/LayoutTests/ChangeLog 2011-10-10 23:32:15 UTC (rev 97103)
@@ -1,3 +1,14 @@
+2011-10-10 Nico Weber tha...@chromium.org
+
+PluginDocumentParser uses incorrect syntax for background color
+https://bugs.webkit.org/show_bug.cgi?id=69694
+
+Reviewed by Adam Barth.
+
+* platform/mac/plugins/iframe-plugin-bgcolor-expected.txt: Added
+* plugins/iframe-plugin-bgcolor.html: Added.
+* plugins/iframe-plugin-bgcolor-expected.png: Added.
+
2011-10-10 Ryosuke Niwa rn...@webkit.org
REGRESSION(r96870): editing/pasteboard/smart-paste-008.html fails on non-Mac
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97102 => 97103)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 23:09:12 UTC (rev 97102)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-10 23:32:15 UTC (rev 97103)
@@ -638,6 +638,8 @@
// Other
// -
+BUGWK69791 WIN LINUX : plugins/iframe-plugin-bgcolor.html = TEXT
+
// Mac Safari under certain circumstances automatically places
// a caret in editable document even when none was requested programatically.
// We don't intend to copy this feature (at least not for Beta).
Added: trunk/LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt (0 => 97103)
--- trunk/LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/plugins/iframe-plugin-bgcolor-expected.txt 2011-10-10 23:32:15 UTC (rev 97103)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x170
+ RenderBlock {HTML} at (0,0) size 800x170
+RenderBody {BODY} at (8,8) size 784x154
+ RenderPartObject {IFRAME} at (0,0) size 300x150
+layer at (0,0) size 300x150
+ RenderView at (0,0) size 300x150
+layer at (0,0) size 300x150
+ RenderBlock {HTML} at (0,0) size 300x150
+RenderBody {BODY} at (0,0) size 300x150 [bgcolor=#262626]
+ RenderEmbeddedObject {EMBED} at (0,0) size 300x150
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/plugins/iframe-plugin-bgcolor-expected.png (0 => 97103)
--- trunk/LayoutTests/plugins/iframe-plugin-bgcolor-expected.png (rev 0)
+++ trunk/LayoutTests/plugins/iframe-plugin-bgcolor-expected.png 2011-10-10 23:32:15 UTC (rev 97103)
@@ -0,0 +1,37 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum af3413156a24c5c5c21b45fe2a009b87\xC5] \xEEiCCPICC Profile x\x85T\xCFkA\xFE6n\xA9\xD0Zk\xB2x\x90IY\xABhE\xD46\xFDbk \xDB \xB6E\x90d3I\xD6n6\xEB\xEE\xB5\xA5\x88\xE4\xE2\xD1*\xDEE\xED\xA1\xFF\x80 z\xF0d/J\x85ZE(ޫ(b\xA1-\xF1\xCDnL\xB6\xA5\xEA\xC0\xCE~\xF3\xDE7\xEF}ov\xDF
+r\xD24\xF5\x80\xE4
+\xC7R\xA2il|Bj\xFC\x88 \x8E\xA2 A4%U\xDB\xECN$A\x83s\xF9{\xE7\xD8z\x81[V\xC3{\xFBw\xB2w\xAD\x9AҶ\x9A\x84\xFD@\xE0G\x9A\xD9*\xB0\xEFq
+Y\x88ߡ)\xC7t\xDF\xE3\xD8\xF2\xEC\x8F9Nyx\xC1\xB5+=\xC4Y|@5-\xCEM\xB8S\xCD%\xD3@\x83H8\x94\xF5qR\x9C\x94\xD7 inf\xC6\xC8\xBDO\x90\xA6\xBB\xCC\xEE\xABb\xA1\x9CN\xF6\x90\xBD\x9D\xF4~N\xB3\xDE\xC2!\xC2 \xAD?F\xB8\x8D\x9E\xF5\x8C\xD5?\xE2a\xE1\xA4\xE6Ć= 5\xF4\xF8`\xB7\xA9\xF85\xC2_M'\xA2Tq\xD9.
+\xF1\x98\xAE\xFDV\xF2J\x82p\x908\xCAda\x80sZHO\xD7Ln\xF8\xBA\x87}\xD7\xAF\xE2wVQ\xE1y\x8Fg\xDE\xD4\xDD\xEFE\xDA\xAF0 \x9A
+HPEa\x98\xB0P@\x8614\xB2r?#\xAB\x93{2u$j\xBBtbD\xB1A{6\xDC=\xB7Q\xA4\xDD\xFE(q\x94C\xB5\x92\xFCA\xFE*\xAF\xC9O\xE5y\xF9\xCB\\xB0\xD8V\x{1D4B5B}\x9A\xBA\xF2\xE0;\xC5噹 \xD7\xD3\xC8\xE3sM^|\x95\xD4v\x93WG\x96\xACyz\xBC\x9A\xEC?\xECW\x971\xE6\x825\x8F\xC4s\xB0\xFB\xF1-_\x95̗)\x8C\xC5\xE3U\xF3\xEAK\x84uZ17ߟl;=\xE2.\xCF.\xB5\xD6s\xAD\x89\x8B7V\x9B\x97g\xFDjH\xFB\x93\xE6U\xF9O^\xF5\xF1\xFCg\xCD\xC4c\xE2)1v\x8A\xE7!\x89\x97\xC5.\xF1\x92\xD8K\xAB
[webkit-changes] [97104] trunk/Tools
Title: [97104] trunk/Tools
Revision 97104
Author simon.fra...@apple.com
Date 2011-10-10 16:34:14 -0700 (Mon, 10 Oct 2011)
Log Message
3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276
Reviewed by Anders Carlsson.
Use a snapshot of the window, rather than an image from the web process
for pixel testing in WebKitTestRunner. This correctly captures compositing
layers, so works for 3D transform tests.
* WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
* WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
use that instead of the image we get from the web process.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::windowSnapshotImage): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/PlatformWebView.h
trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
trunk/Tools/WebKitTestRunner/qt/PlatformWebViewQt.cpp
trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
Diff
Modified: trunk/Tools/ChangeLog (97103 => 97104)
--- trunk/Tools/ChangeLog 2011-10-10 23:32:15 UTC (rev 97103)
+++ trunk/Tools/ChangeLog 2011-10-10 23:34:14 UTC (rev 97104)
@@ -1,3 +1,28 @@
+2011-10-10 Simon Fraser simon.fra...@apple.com
+
+3D transforms are flattened in WebKit2 snapshots
+https://bugs.webkit.org/show_bug.cgi?id=68276
+
+Reviewed by Anders Carlsson.
+
+Use a snapshot of the window, rather than an image from the web process
+for pixel testing in WebKitTestRunner. This correctly captures compositing
+layers, so works for 3D transform tests.
+
+* WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
+* WebKitTestRunner/cg/TestInvocationCG.cpp:
+(WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
+(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
+use that instead of the image we get from the web process.
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::windowSnapshotImage): Ditto.
+* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
+(WTR::PlatformWebView::windowSnapshotImage): Ditto.
+* WebKitTestRunner/win/PlatformWebViewWin.cpp:
+(WTR::PlatformWebView::windowSnapshotImage): Ditto.
+
2011-10-10 David Levin le...@chromium.org
Quick fix for watchlist unit test failures when using Python 2.7+
Modified: trunk/Tools/WebKitTestRunner/PlatformWebView.h (97103 => 97104)
--- trunk/Tools/WebKitTestRunner/PlatformWebView.h 2011-10-10 23:32:15 UTC (rev 97103)
+++ trunk/Tools/WebKitTestRunner/PlatformWebView.h 2011-10-10 23:34:14 UTC (rev 97104)
@@ -26,6 +26,8 @@
#ifndef PlatformWebView_h
#define PlatformWebView_h
+#include WebKit2/WKRetainPtr.h
+
#if defined(BUILDING_QT__)
class QDesktopWebView;
typedef QDesktopWebView* PlatformWKView;
@@ -76,6 +78,8 @@
void makeWebViewFirstResponder();
void setWindowIsKey(bool isKey) { m_windowIsKey = isKey; }
bool windowIsKey() const { return m_windowIsKey; }
+
+WKRetainPtrWKImageRef windowSnapshotImage();
private:
PlatformWKView m_view;
Modified: trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp (97103 => 97104)
--- trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2011-10-10 23:32:15 UTC (rev 97103)
+++ trunk/Tools/WebKitTestRunner/cg/TestInvocationCG.cpp 2011-10-10 23:34:14 UTC (rev 97104)
@@ -45,7 +45,12 @@
namespace WTR {
-static CGContextRef createCGContextFromImage(WKImageRef wkImage)
+enum FlipGraphicsContextOrNot {
+DontFlipGraphicsContext,
+FlipGraphicsContext
+};
+
+static CGContextRef createCGContextFromImage(WKImageRef wkImage, FlipGraphicsContextOrNot flip = DontFlipGraphicsContext)
{
RetainPtrCGImageRef image(AdoptCF, WKImageCreateCGImage(wkImage));
@@ -58,7 +63,15 @@
CGContextRef context = CGBitmapContextCreate(buffer, pixelsWide, pixelsHigh, 8, rowBytes, colorSpace, kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
CGColorSpaceRelease(colorSpace);
+if (flip == FlipGraphicsContext) {
+CGContextSaveGState(context);
+
[webkit-changes] [97105] trunk/Source/JavaScriptCore
Title: [97105] trunk/Source/_javascript_Core
Revision 97105
Author barraclo...@apple.com
Date 2011-10-10 16:56:58 -0700 (Mon, 10 Oct 2011)
Log Message
Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802
Reviewed by Oliver Hunt.
Compares, add, mod are the easy cases.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97104 => 97105)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 23:34:14 UTC (rev 97104)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-10 23:56:58 UTC (rev 97105)
@@ -1,5 +1,34 @@
2011-10-10 Gavin Barraclough baraclo...@apple.com
+Switch most calls in DFGJITCodeGenerator to use callOperation.
+https://bugs.webkit.org/show_bug.cgi?id=69802
+
+Reviewed by Oliver Hunt.
+
+Compares, add, mod are the easy cases.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeArithMod):
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeKnownConstantArithOp):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeBasicArithOp):
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
+(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeStrictEq):
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+
+2011-10-10 Gavin Barraclough baraclo...@apple.com
+
DFG: Switch GetById / PutById to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69795
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97104 => 97105)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 23:34:14 UTC (rev 97104)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 23:56:58 UTC (rev 97105)
@@ -1149,6 +1149,22 @@
return appendCallWithExceptionCheckSetResult(operation, result);
}
+JITCompiler::Call callOperation(J_DFGOperation_EJJ operation, GPRReg result, GPRReg arg1, MacroAssembler::Imm32 imm)
+{
+m_jit.move(arg1, GPRInfo::argumentGPR1);
+m_jit.move(MacroAssembler::ImmPtr(static_castconst void*(JSValue::encode(jsNumber(imm.m_value, GPRInfo::argumentGPR2);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
+JITCompiler::Call callOperation(J_DFGOperation_EJJ operation, GPRReg result, MacroAssembler::Imm32 imm, GPRReg arg2)
+{
+m_jit.move(MacroAssembler::ImmPtr(static_castconst void*(JSValue::encode(jsNumber(imm.m_value, GPRInfo::argumentGPR1);
+m_jit.move(arg2, GPRInfo::argumentGPR2);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
JITCompiler::Call callOperation(J_DFGOperation_ECJ operation, GPRReg result, GPRReg arg1, GPRReg arg2)
{
setupStubArguments(arg1, arg2);
@@ -1349,6 +1365,26 @@
[webkit-changes] [97106] trunk/Tools
Title: [97106] trunk/Tools
Revision 97106
Author ad...@chromium.org
Date 2011-10-10 16:59:37 -0700 (Mon, 10 Oct 2011)
Log Message
Support Distributed-CompileC as an action name in filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=69783
Reviewed by Ojan Vafai.
* Scripts/filter-build-webkit:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/filter-build-webkit
Diff
Modified: trunk/Tools/ChangeLog (97105 => 97106)
--- trunk/Tools/ChangeLog 2011-10-10 23:56:58 UTC (rev 97105)
+++ trunk/Tools/ChangeLog 2011-10-10 23:59:37 UTC (rev 97106)
@@ -1,3 +1,12 @@
+2011-10-10 Adam Klein ad...@chromium.org
+
+Support Distributed-CompileC as an action name in filter-build-webkit
+https://bugs.webkit.org/show_bug.cgi?id=69783
+
+Reviewed by Ojan Vafai.
+
+* Scripts/filter-build-webkit:
+
2011-10-10 Simon Fraser simon.fra...@apple.com
3D transforms are flattened in WebKit2 snapshots
Modified: trunk/Tools/Scripts/filter-build-webkit (97105 => 97106)
--- trunk/Tools/Scripts/filter-build-webkit 2011-10-10 23:56:58 UTC (rev 97105)
+++ trunk/Tools/Scripts/filter-build-webkit 2011-10-10 23:59:37 UTC (rev 97106)
@@ -147,7 +147,7 @@
printLine($line, STYLE_PLAIN);
} elsif ($line =~ /\*\* BUILD SUCCEEDED \*\*/) {
printLine(Build Succeeded, STYLE_SUCCESS);
-} elsif ($line =~ /^(PhaseScriptExecution|CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze) ([^]+|\S+)/) {
+} elsif ($line =~ /^(PhaseScriptExecution|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze) ([^]+|\S+)/) {
my ($command, $path) = ($1, basename($2));
printLine($command $path, STYLE_PLAIN);
} else {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97107] trunk/Source/JavaScriptCore
Title: [97107] trunk/Source/_javascript_Core
Revision 97107
Author barraclo...@apple.com
Date 2011-10-10 17:08:54 -0700 (Mon, 10 Oct 2011)
Log Message
Remove some unused methods from the DFG JIT.
Rubber stamped by Oliver Hunt
Thee methods were only used by the non-speculative JIT, and can be removed.
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCodeGenerator32_64.cpp:
* dfg/DFGJITCodeGenerator64.cpp:
- removed:
nonSpeculativeAdd
nonSpeculativeArithSub
nonSpeculativeArithMod
nonSpeculativeCheckHasInstance
nonSpeculativeInstanceOf
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
- removed:
operationArithMod
operationInstanceOf
operationThrowHasInstanceError
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97106 => 97107)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-10 23:59:37 UTC (rev 97106)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-11 00:08:54 UTC (rev 97107)
@@ -1,5 +1,29 @@
2011-10-10 Gavin Barraclough baraclo...@apple.com
+Remove some unused methods from the DFG JIT.
+
+Rubber stamped by Oliver Hunt
+
+Thee methods were only used by the non-speculative JIT, and can be removed.
+
+* dfg/DFGJITCodeGenerator.h:
+* dfg/DFGJITCodeGenerator32_64.cpp:
+* dfg/DFGJITCodeGenerator64.cpp:
+- removed:
+nonSpeculativeAdd
+nonSpeculativeArithSub
+nonSpeculativeArithMod
+nonSpeculativeCheckHasInstance
+nonSpeculativeInstanceOf
+* dfg/DFGOperations.cpp:
+* dfg/DFGOperations.h:
+- removed:
+operationArithMod
+operationInstanceOf
+operationThrowHasInstanceError
+
+2011-10-10 Gavin Barraclough baraclo...@apple.com
+
Switch most calls in DFGJITCodeGenerator to use callOperation.
https://bugs.webkit.org/show_bug.cgi?id=69802
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97106 => 97107)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-10 23:59:37 UTC (rev 97106)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-11 00:08:54 UTC (rev 97107)
@@ -730,36 +730,6 @@
void nonSpeculativeKnownConstantArithOp(NodeType op, NodeIndex regChild, NodeIndex immChild, bool commute);
void nonSpeculativeBasicArithOp(NodeType op, Node);
-// Handles both ValueAdd and ArithAdd.
-void nonSpeculativeAdd(NodeType op, Node node)
-{
-if (isInt32Constant(node.child1())) {
-nonSpeculativeKnownConstantArithOp(op, node.child2(), node.child1(), true);
-return;
-}
-
-if (isInt32Constant(node.child2())) {
-nonSpeculativeKnownConstantArithOp(op, node.child1(), node.child2(), false);
-return;
-}
-
-nonSpeculativeBasicArithOp(op, node);
-}
-
-void nonSpeculativeArithSub(Node node)
-{
-if (isInt32Constant(node.child2())) {
-nonSpeculativeKnownConstantArithOp(ArithSub, node.child1(), node.child2(), false);
-return;
-}
-
-nonSpeculativeBasicArithOp(ArithSub, node);
-}
-
-void nonSpeculativeArithMod(Node);
-void nonSpeculativeCheckHasInstance(Node);
-void nonSpeculativeInstanceOf(Node);
-
#if USE(JSVALUE64)
JITCompiler::Call cachedGetById(GPRReg baseGPR, GPRReg resultGPR, GPRReg scratchGPR, unsigned identifierNumber, JITCompiler::Jump slowPathTarget = JITCompiler::Jump(), NodeType = GetById);
void cachedPutById(GPRReg base, GPRReg value, NodeIndex valueIndex, GPRReg scratchGPR, unsigned identifierNumber, PutKind, JITCompiler::Jump slowPathTarget = JITCompiler::Jump());
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (97106 => 97107)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-10 23:59:37 UTC (rev 97106)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-11 00:08:54 UTC (rev 97107)
@@ -818,185 +818,6 @@
jsValueResult(resultTagGPR, resultPayloadGPR, m_compileIndex, UseChildrenCalledExplicitly);
}
-void JITCodeGenerator::nonSpeculativeArithMod(Node node)
-{
-JSValueOperand op1(this, node.child1());
-JSValueOperand op2(this, node.child2());
-GPRTemporary eax(this, X86Registers::eax);
-GPRTemporary edx(this, X86Registers::edx);
-
-FPRTemporary op1Double(this);
-FPRTemporary op2Double(this);
-
-GPRReg op1TagGPR = op1.tagGPR();
-GPRReg op1PayloadGPR = op1.payloadGPR();
-
[webkit-changes] [97108] trunk/Source/WebKit/chromium
Title: [97108] trunk/Source/WebKit/chromium
Revision 97108
Author tha...@chromium.org
Date 2011-10-10 17:10:55 -0700 (Mon, 10 Oct 2011)
Log Message
[chromium] Pull tools/clang from upstream.
https://bugs.webkit.org/show_bug.cgi?id=69797
Reviewed by Adam Barth.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97107 => 97108)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-11 00:08:54 UTC (rev 97107)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-11 00:10:55 UTC (rev 97108)
@@ -1,3 +1,12 @@
+2011-10-10 Nico Weber tha...@chromium.org
+
+[chromium] Pull tools/clang from upstream.
+https://bugs.webkit.org/show_bug.cgi?id=69797
+
+Reviewed by Adam Barth.
+
+* DEPS:
+
2011-10-10 Sergey Glazunov serg.glazu...@gmail.com
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
Modified: trunk/Source/WebKit/chromium/DEPS (97107 => 97108)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-11 00:08:54 UTC (rev 97107)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-11 00:10:55 UTC (rev 97108)
@@ -44,6 +44,8 @@
Var('chromium_svn')+'/build@'+Var('chromium_rev'),
'tools/gyp':
From('chromium_deps', 'src/tools/gyp'),
+ 'tools/clang':
+Var('chromium_svn')+'/tools/clang@'+Var('chromium_rev'),
# Basic tools
'base':
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97109] trunk/Source/WebCore
Title: [97109] trunk/Source/WebCore
Revision 97109
Author aba...@webkit.org
Date 2011-10-10 17:11:14 -0700 (Mon, 10 Oct 2011)
Log Message
[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=69792
Reviewed by Nate Chapin.
We used to hard code the list of active DOM objects in the code
generator, but now we have an IDL attribute. This patch switches the
code generator over to using the IDL attribute.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateImplementation):
(GetDomMapFunction):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (97108 => 97109)
--- trunk/Source/WebCore/ChangeLog 2011-10-11 00:10:55 UTC (rev 97108)
+++ trunk/Source/WebCore/ChangeLog 2011-10-11 00:11:14 UTC (rev 97109)
@@ -1,3 +1,20 @@
+2011-10-10 Adam Barth aba...@webkit.org
+
+[V8] CodeGeneratorV8 shouldn't hardcode the list of ActiveDOMObjects
+https://bugs.webkit.org/show_bug.cgi?id=69792
+
+Reviewed by Nate Chapin.
+
+We used to hard code the list of active DOM objects in the code
+generator, but now we have an IDL attribute. This patch switches the
+code generator over to using the IDL attribute.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateHeader):
+(GenerateNormalAttrGetter):
+(GenerateImplementation):
+(GetDomMapFunction):
+
2011-10-10 Nico Weber tha...@chromium.org
PluginDocumentParser uses incorrect syntax for background color
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (97108 => 97109)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-11 00:10:55 UTC (rev 97108)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-11 00:11:14 UTC (rev 97109)
@@ -265,7 +265,7 @@
# EventTarget.
$codeGenerator-AddMethodsConstantsAndAttributesFromParentClasses($dataNode, \@allParents, 1);
-my $hasDependentLifetime = $dataNode-extendedAttributes-{V8DependentLifetime} || IsActiveDomType($interfaceName) || $className =~ /SVG/;
+my $hasDependentLifetime = $dataNode-extendedAttributes-{V8DependentLifetime} || $dataNode-extendedAttributes-{ActiveDOMObject} || $className =~ /SVG/;
if (!$hasDependentLifetime) {
foreach (@{$dataNode-parents}) {
my $parent = $codeGenerator-StripModule($_);
@@ -349,7 +349,7 @@
static void derefObject(void*);
static WrapperTypeInfo info;
END
-if (IsActiveDomType($implClassName)) {
+if ($dataNode-extendedAttributes-{ActiveDOMObject}) {
push(@headerContent, static ActiveDOMObject* toActiveDOMObject(v8::Handlev8::Object);\n);
}
@@ -420,6 +420,8 @@
}
push(@headerContent, END);
+static v8::Handlev8::Object existingWrapper(${nativeType}*);
+
private:
static v8::Handlev8::Object wrapSlow(${nativeType}*);
};
@@ -427,14 +429,20 @@
END
push(@headerContent, END);
+ALWAYS_INLINE v8::Handlev8::Object ${className}::existingWrapper(${nativeType}* impl)
+{
+END
+my $getWrapper = IsNodeSubType($dataNode) ? V8DOMWrapper::getWrapper(impl) : ${domMapFunction}.get(impl);
+push(@headerContent, END);
+return ${getWrapper};
+}
v8::Handlev8::Object ${className}::wrap(${nativeType}* impl${forceNewObjectInput})
{
END
push(@headerContent, if (!forceNewObject) {\n) if IsDOMNodeType($interfaceName);
-my $getWrapper = IsNodeSubType($dataNode) ? V8DOMWrapper::getWrapper(impl) : ${domMapFunction}.get(impl);
push(@headerContent, END);
-v8::Handlev8::Object wrapper = ${getWrapper};
+v8::Handlev8::Object wrapper = existingWrapper(impl);
if (!wrapper.IsEmpty())
return wrapper;
END
@@ -880,11 +888,10 @@
$returnType ne EventTarget $returnType ne SerializedScriptValue $returnType ne DOMWindow
$returnType !~ /SVG/ $returnType !~ /HTML/ !IsDOMNodeType($returnType))) {
AddIncludesForType($returnType);
-my $domMapFunction = GetDomMapFunction(0, $returnType);
# Check for a wrapper in the wrapper cache. If there is one, we know that a hidden reference has already
# been created. If we don't find a wrapper, we create both a wrapper and a hidden reference.
push(@implContentDecls, RefPtr$returnType result = ${getterString};\n);
-push(@implContentDecls, v8::Handlev8::Value wrapper = result.get() ? ${domMapFunction}.get(result.get()) : v8::Handlev8::Value();\n);
+push(@implContentDecls, v8::Handlev8::Value wrapper = result.get() ? V8${returnType}::existingWrapper(result.get()) : v8::Handlev8::Object();\n);
push(@implContentDecls, if (wrapper.IsEmpty()) {\n);
push(@implContentDecls, wrapper = toV8(result.get());\n);
push(@implContentDecls, if
[webkit-changes] [97110] trunk
Title: [97110] trunk
Revision 97110
Author commit-qu...@webkit.org
Date 2011-10-10 17:18:47 -0700 (Mon, 10 Oct 2011)
Log Message
Unreviewed, rolling out r97087.
http://trac.webkit.org/changeset/97087
https://bugs.webkit.org/show_bug.cgi?id=69805
failing assert on debug builds (Requested by simonjam on
#webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-10
Source/WebCore:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:
Source/WebKit/chromium:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):
LayoutTests:
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Removed.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Removed Paths
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97109 => 97110)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,3 +1,15 @@
+2011-10-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r97087.
+http://trac.webkit.org/changeset/97087
+https://bugs.webkit.org/show_bug.cgi?id=69805
+
+failing assert on debug builds (Requested by simonjam on
+#webkit).
+
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Removed.
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Removed.
+
2011-10-10 Nico Weber tha...@chromium.org
PluginDocumentParser uses incorrect syntax for background color
Deleted: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (97109 => 97110)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,3 +0,0 @@
-CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
-
-This test passes if there's no alert dialog.
Deleted: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (97109 => 97110)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,42 +0,0 @@
-html
-head
-script
-if (window.layoutTestController) {
- layoutTestController.dumpAsText();
- layoutTestController.waitUntilDone();
- layoutTestController.setCanOpenWindows();
- layoutTestController.setCloseRemainingWindowsWhenComplete(true);
-}
-
-window._onload_ = function()
-{
- victim = document.body.appendChild(document.createElement(iframe));
- wnd = victim.contentWindow.open();
- victim.src = ""
- victim._onload_ = function() {
- victim._onload_ = null;
-
- wnd.eval(( + function() {
- location = _javascript_:( + function() {
-a = document.createElement(a);
-a.href = ""
-e = document.createEvent(MouseEvent);
-e.initMouseEvent(click);
-a.dispatchEvent(e);
-
-return script( + function() {
- opener.location = _javascript_:alert(document.body.innerHTML);
-
- if (window.layoutTestController)
- setTimeout(layoutTestController.notifyDone(), 0);
-} + )()\/script;
- } + )();
- } + )());
- }
-}
-/script
-/head
-body
-This test passes if there's no alert dialog.
-/body
-/html
Modified: trunk/Source/WebCore/ChangeLog (97109 => 97110)
--- trunk/Source/WebCore/ChangeLog 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/Source/WebCore/ChangeLog 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,3 +1,19 @@
+2011-10-10 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r97087.
+http://trac.webkit.org/changeset/97087
+https://bugs.webkit.org/show_bug.cgi?id=69805
+
+failing assert on debug builds (Requested by simonjam on
+#webkit).
+
+*
[webkit-changes] [97111] trunk/Websites/webkit.org
Title: [97111] trunk/Websites/webkit.org
Revision 97111
Author rn...@webkit.org
Date 2011-10-10 17:29:34 -0700 (Mon, 10 Oct 2011)
Log Message
Fix a typo pointed by Sam (Weinig).
* coding/coding-style.html:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/coding/coding-style.html
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (97110 => 97111)
--- trunk/Websites/webkit.org/ChangeLog 2011-10-11 00:18:47 UTC (rev 97110)
+++ trunk/Websites/webkit.org/ChangeLog 2011-10-11 00:29:34 UTC (rev 97111)
@@ -1,5 +1,11 @@
2011-10-10 Ryosuke Niwa rn...@webkit.org
+Fix a typo pointed by Sam (Weinig).
+
+* coding/coding-style.html:
+
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
Style guide should mandate use of pass-by-reference for out arguments
https://bugs.webkit.org/show_bug.cgi?id=69766
Modified: trunk/Websites/webkit.org/coding/coding-style.html (97110 => 97111)
--- trunk/Websites/webkit.org/coding/coding-style.html 2011-10-11 00:18:47 UTC (rev 97110)
+++ trunk/Websites/webkit.org/coding/coding-style.html 2011-10-11 00:29:34 UTC (rev 97111)
@@ -750,7 +750,7 @@
{
doSomething();
if (outArgument)
-outArgument = m_value;
+*outArgument = m_value;
}
/pre
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97112] trunk/LayoutTests
Title: [97112] trunk/LayoutTests
Revision 97112
Author rn...@webkit.org
Date 2011-10-10 17:35:52 -0700 (Mon, 10 Oct 2011)
Log Message
Chromium rebaseline after r97102.
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
* platform/chromium-win/fast/events/ondragenter-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97111 => 97112)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:35:52 UTC (rev 97112)
@@ -1,3 +1,10 @@
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
+Chromium rebaseline after r97102.
+
+* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
+* platform/chromium-win/fast/events/ondragenter-expected.txt:
+
2011-10-10 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r97087.
Modified: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt (97111 => 97112)
--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 00:35:52 UTC (rev 97112)
@@ -8,7 +8,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text DIV DIV BODY HTML #document to 1 of #text DIV DIV BODY HTML #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text DIV DIV BODY HTML #document to 1 of DIV BODY HTML #document toDOMRange:range from 4 of #text DIV DIV BODY HTML #document to 4 of #text DIV DIV BODY HTML #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text DIV DIV BODY HTML #document to 1 of DIV BODY HTML #document toDOMRange:range from 5 of #text DIV DIV BODY HTML #document to 5 of #text DIV DIV BODY HTML #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -27,11 +27,7 @@
text run at (522,0) width 250: Spaces should surround the pasted word.
RenderBlock {DIV} at (0,92) size 784x20
RenderBlock {DIV} at (0,0) size 784x20
- RenderText {#text} at (0,0) size 4x19
-text run at (0,0) width 4: f
- RenderText {#text} at (4,0) size 24x19
-text run at (4,0) width 24: foo
- RenderText {#text} at (28,0) size 24x19
-text run at (28,0) width 24: bar
+ RenderText {#text} at (0,0) size 52x19
+text run at (0,0) width 52: f foo bar
RenderBlock (anonymous) at (0,20) size 784x0
-caret: position 4 of child 1 {#text} of child 0 {DIV} of child 4 {DIV} of body
+caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
Modified: trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt (97111 => 97112)
--- trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt 2011-10-11 00:35:52 UTC (rev 97112)
@@ -1,3 +1,3 @@
- Success:Text
+Success: Text
This automated layout test checks to see that ondragenter events are being sent.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97114] trunk
Title: [97114] trunk
Revision 97114
Author m...@apple.com
Date 2011-10-10 17:46:53 -0700 (Mon, 10 Oct 2011)
Log Message
rdar://problem/10246137 Duplicate ::after content when both ::before and ::after are styled as table parts
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/css-generated-content/table-parts-before-and-after.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
into it.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
into it.
LayoutTests:
* fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
* fast/css-generated-content/table-parts-before-and-after.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderTable.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97113 => 97114)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:41:18 UTC (rev 97113)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:46:53 UTC (rev 97114)
@@ -1,3 +1,13 @@
+2011-10-10 Dan Bernstein m...@apple.com
+
+rdar://problem/10246137 Duplicate ::after content when both ::before and ::after are styled as table parts
+
+Reviewed by Sam Weinig.
+
+* fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
+* fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
+* fast/css-generated-content/table-parts-before-and-after.html: Added.
+
2011-10-10 Ryosuke Niwa rn...@webkit.org
Chromium rebaseline after r97102.
Added: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (0 => 97114)
--- trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt 2011-10-11 00:46:53 UTC (rev 97114)
@@ -0,0 +1,101 @@
+layer at (0,0) size 785x736
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x736
+ RenderBlock {HTML} at (0,0) size 785x736
+RenderBody {BODY} at (8,8) size 769x720
+ RenderBlock {DIV} at (0,0) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,120) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,240) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+
[webkit-changes] [97115] trunk/LayoutTests
Title: [97115] trunk/LayoutTests Revision 97115 Author rn...@webkit.org Date 2011-10-10 17:49:43 -0700 (Mon, 10 Oct 2011) Log Message Another Chromium rebaseline after r97102. * platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. * platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed. * platform/chromium-win/fast/events/ondragenter-expected.txt: Removed. * platform/chromium/fast/events/ondragenter-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt. * platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97114 => 97115) --- trunk/LayoutTests/ChangeLog 2011-10-11 00:46:53 UTC (rev 97114) +++ trunk/LayoutTests/ChangeLog 2011-10-11 00:49:43 UTC (rev 97115) @@ -1,3 +1,17 @@ +2011-10-10 Ryosuke Niwa rn...@webkit.org + +Another Chromium rebaseline after r97102. + +* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed. +* platform/chromium-win/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium/fast/events/ondragenter-expected.txt: Copied from +LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt. +* platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from +LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt. +* platform/chromium/test_expectations.txt: + 2011-10-10 Dan Bernstein m...@apple.com rdar://problem/10246137 Duplicate ::after content when both ::before and ::after are styled as table parts Copied: trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt (from rev 97112, trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt) (0 => 97115) --- trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt 2011-10-11 00:49:43 UTC (rev 97115) @@ -0,0 +1,3 @@ + +Success: Text +This automated layout test checks to see that ondragenter events are being sent. Copied: trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt (from rev 97112, trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt) (0 => 97115) --- trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt 2011-10-11 00:49:43 UTC (rev 97115) @@ -0,0 +1,33 @@ +EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV BODY HTML #document to 2 of DIV BODY HTML #document +EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV DIV BODY HTML #document to 0 of DIV DIV BODY HTML #document toDOMRange:range from 0 of #text DIV DIV BODY HTML #document to 3 of #text DIV DIV BODY HTML #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text DIV DIV BODY HTML #document to 1 of #text DIV DIV BODY HTML #document givenAction:WebViewInsertActionPasted +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text DIV DIV
[webkit-changes] [97116] branches/chromium/874
Title: [97116] branches/chromium/874
Revision 97116
Author infe...@chromium.org
Date 2011-10-10 17:57:11 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97114 - rdar://problem/10246137 Duplicate ::after content when both ::before and ::after are styled as table parts
BUG=99348
Review URL: http://codereview.chromium.org/8222024
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/874/Source/WebCore/rendering/RenderTable.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png (from rev 97114, trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (from rev 97114, trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt) (0 => 97116)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt 2011-10-11 00:57:11 UTC (rev 97116)
@@ -0,0 +1,101 @@
+layer at (0,0) size 785x736
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x736
+ RenderBlock {HTML} at (0,0) size 785x736
+RenderBody {BODY} at (8,8) size 769x720
+ RenderBlock {DIV} at (0,0) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,120) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,240) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: 22
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: 333
+ RenderBlock {DIV} at (0,360) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: 1
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0)
[webkit-changes] [97117] trunk/Source/JavaScriptCore
Title: [97117] trunk/Source/_javascript_Core
Revision 97117
Author barraclo...@apple.com
Date 2011-10-10 18:01:30 -0700 (Mon, 10 Oct 2011)
Log Message
DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGOperations.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97116 => 97117)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:01:30 UTC (rev 97117)
@@ -1,5 +1,22 @@
2011-10-10 Gavin Barraclough baraclo...@apple.com
+DFG JIT switch dfgConvert methods to use callOperation
+https://bugs.webkit.org/show_bug.cgi?id=69806
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+* dfg/DFGOperations.h:
+
+2011-10-10 Gavin Barraclough baraclo...@apple.com
+
Remove some unused methods from the DFG JIT.
Rubber stamped by Oliver Hunt
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97116 => 97117)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-11 01:01:30 UTC (rev 97117)
@@ -1179,6 +1179,22 @@
return appendCallWithExceptionCheck(operation);
}
+JITCompiler::Call callOperation(Z_DFGOperation_EJ operation, GPRReg result, GPRReg arg1)
+{
+m_jit.move(arg1, GPRInfo::argumentGPR1);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
+JITCompiler::Call callOperation(D_DFGOperation_EJ operation, FPRReg result, GPRReg arg1)
+{
+m_jit.move(arg1, GPRInfo::argumentGPR1);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+JITCompiler::Call call = appendCallWithExceptionCheck(operation);
+m_jit.moveDouble(FPRInfo::returnValueFPR, result);
+return call;
+}
JITCompiler::Call callOperation(D_DFGOperation_DD operation, FPRReg result, FPRReg arg1, FPRReg arg2)
{
setupTwoStubArgsFPRInfo::argumentFPR0, FPRInfo::argumentFPR1(arg1, arg2);
@@ -1404,6 +1420,25 @@
return callOperation((V_DFGOperation_EPZJ)operation, arg1, arg2, arg3Tag, arg3Payload);
}
+JITCompiler::Call callOperation(Z_DFGOperation_EJ operation, GPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
+{
+m_jit.push(arg1Tag);
+m_jit.push(arg1Payload);
+m_jit.push(GPRInfo::callFrameRegister);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
+JITCompiler::Call callOperation(D_DFGOperation_EJ operation, FPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
+{
+m_jit.push(arg1Tag);
+m_jit.push(arg1Payload);
+m_jit.push(GPRInfo::callFrameRegister);
+
+JITCompiler::Call call = appendCallWithExceptionCheck(operation);
+m_jit.assembler().fstpl(0, JITCompiler::stackPointerRegister);
+m_jit.loadDouble(JITCompiler::stackPointerRegister, result);
+return call;
+}
JITCompiler::Call callOperation(D_DFGOperation_DD operation, FPRReg result, FPRReg arg1, FPRReg arg2)
{
m_jit.subPtr(TrustedImm32(2 * sizeof(double)), JITCompiler::stackPointerRegister);
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (97116 => 97117)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-11 01:01:30 UTC (rev 97117)
@@ -346,10 +346,7 @@
// Next handle cells ( other JS immediates)
nonNumeric.link(m_jit);
silentSpillAllRegisters(resultTagGPR, resultPayloadGPR);
-m_jit.push(tagGPR);
-m_jit.push(payloadGPR);
-m_jit.push(GPRInfo::callFrameRegister);
-
[webkit-changes] [97118] trunk/Source/JavaScriptCore
Title: [97118] trunk/Source/_javascript_Core Revision 97118 Author fpi...@apple.com Date 2011-10-10 18:14:13 -0700 (Mon, 10 Oct 2011) Log Message DFG JSVALUE64 spill/fill code should not box integers and doubles https://bugs.webkit.org/show_bug.cgi?id=69782 Reviewed by Oliver Hunt. Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat. This required changing all of the places that spill registers (both silently and not) and filling registers (both silently and on demand). It also required changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile) may have the wrong format for the old JIT (unboxed int or double). This is a slight win on Kraken (0.25%) and neutral elsewhere. * dfg/DFGGenerationInfo.h: (JSC::DFG::GenerationInfo::spill): * dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::silentFillFPR): (JSC::DFG::JITCodeGenerator::spill): * dfg/DFGJITCodeGenerator64.cpp: (JSC::DFG::JITCodeGenerator::fillInteger): (JSC::DFG::JITCodeGenerator::fillDouble): (JSC::DFG::JITCodeGenerator::fillJSValue): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::exitSpeculativeWithOSR): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::ValueRecovery::displacedInRegisterFile): (JSC::DFG::ValueRecovery::virtualRegister): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): (JSC::DFG::SpeculativeJIT::fillSpeculateDouble): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97117 => 97118) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:01:30 UTC (rev 97117) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:14:13 UTC (rev 97118) @@ -1,3 +1,40 @@ +2011-10-10 Filip Pizlo fpi...@apple.com + +DFG JSVALUE64 spill/fill code should not box integers and doubles +https://bugs.webkit.org/show_bug.cgi?id=69782 + +Reviewed by Oliver Hunt. + +Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat. +This required changing all of the places that spill registers (both silently +and not) and filling registers (both silently and on demand). It also required +changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile) +may have the wrong format for the old JIT (unboxed int or double). + +This is a slight win on Kraken (0.25%) and neutral elsewhere. + +* dfg/DFGGenerationInfo.h: +(JSC::DFG::GenerationInfo::spill): +* dfg/DFGJITCodeGenerator.h: +(JSC::DFG::JITCodeGenerator::silentFillFPR): +(JSC::DFG::JITCodeGenerator::spill): +* dfg/DFGJITCodeGenerator64.cpp: +(JSC::DFG::JITCodeGenerator::fillInteger): +(JSC::DFG::JITCodeGenerator::fillDouble): +(JSC::DFG::JITCodeGenerator::fillJSValue): +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::exitSpeculativeWithOSR): +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor): +* dfg/DFGSpeculativeJIT.h: +(JSC::DFG::ValueRecovery::displacedInRegisterFile): +(JSC::DFG::ValueRecovery::virtualRegister): +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): +(JSC::DFG::SpeculativeJIT::fillSpeculateDouble): +(JSC::DFG::SpeculativeJIT::fillSpeculateCell): +(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): + 2011-10-10 Gavin Barraclough baraclo...@apple.com DFG JIT switch dfgConvert methods to use callOperation Modified: trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h (97117 => 97118) --- trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h 2011-10-11 01:01:30 UTC (rev 97117) +++ trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h 2011-10-11 01:14:13 UTC (rev 97118) @@ -367,7 +367,7 @@ // pointers. This is not true anymore, but we still assume, in the fill code, // that any spill slot for a JS value is boxed. For storage pointers, there is // nothing we can do to box them, so we allow that to be an exception. -ASSERT((spillFormat DataFormatJS) || spillFormat == DataFormatStorage); +ASSERT((spillFormat DataFormatJS) || spillFormat == DataFormatStorage || spillFormat == DataFormatInteger || spillFormat == DataFormatDouble); m_registerFormat =
[webkit-changes] [97119] trunk/LayoutTests
Title: [97119] trunk/LayoutTests
Revision 97119
Author rn...@webkit.org
Date 2011-10-10 18:15:09 -0700 (Mon, 10 Oct 2011)
Log Message
Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
* platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97118 => 97119)
--- trunk/LayoutTests/ChangeLog 2011-10-11 01:14:13 UTC (rev 97118)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 01:15:09 UTC (rev 97119)
@@ -1,5 +1,13 @@
2011-10-10 Ryosuke Niwa rn...@webkit.org
+Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
+
+* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
+LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
+* platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
+
+2011-10-10 Ryosuke Niwa rn...@webkit.org
+
Another Chromium rebaseline after r97102.
* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
Copied: trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt (from rev 97115, trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt) (0 => 97119)
--- trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 01:15:09 UTC (rev 97119)
@@ -0,0 +1,33 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV BODY HTML #document to 2 of DIV BODY HTML #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV DIV BODY HTML #document to 0 of DIV DIV BODY HTML #document toDOMRange:range from 0 of #text DIV DIV BODY HTML #document to 3 of #text DIV DIV BODY HTML #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text DIV DIV BODY HTML #document to 1 of #text DIV DIV BODY HTML #document givenAction:WebViewInsertActionPasted
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text DIV DIV BODY HTML #document to 1 of DIV BODY HTML #document toDOMRange:range from 5 of #text DIV DIV BODY HTML #document to 5 of #text DIV DIV BODY HTML #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x40
+RenderText {#text} at (0,0) size 740x39
+ text run at (0,0) width 376: There was a bug in paste's smart replace whitespace handling.
+ text run at (376,0) width 364: In some cases, it used information gathered at the start of the
+ text run at (0,20) width 696: selection being pasted into to decide whether or not a space needed to be added to the end of the incoming content.
+ RenderBlock {P} at (0,56) size 784x20
+RenderText {#text} at (0,0) size 772x19
+ text run at (0,0) width 522: A smart paste is performed into a selection starting in one block and ending in another.
+ text run at (522,0) width 250: Spaces should surround the pasted word.
+ RenderBlock {DIV} at (0,92) size 784x20
+RenderBlock {DIV} at (0,0) size 784x20
+ RenderText {#text} at (0,0) size 52x19
+text run at (0,0) width 52: f foo bar
+RenderBlock (anonymous) at (0,20) size 784x0
+caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
Deleted: trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt (97118
[webkit-changes] [97120] trunk/LayoutTests
Title: [97120] trunk/LayoutTests Revision 97120 Author simon...@chromium.org Date 2011-10-10 20:01:51 -0700 (Mon, 10 Oct 2011) Log Message [Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests. Unreviewed. * platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added. * platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png: * platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css-generated-content/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97119 => 97120) --- trunk/LayoutTests/ChangeLog 2011-10-11 01:15:09 UTC (rev 97119) +++ trunk/LayoutTests/ChangeLog 2011-10-11 03:01:51 UTC (rev 97120) @@ -1,3 +1,19 @@ +2011-10-10 James Simonsen simon...@chromium.org + +[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests. + +Unreviewed. + +* platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added. +* platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png. +* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png: +* platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-10-10 Ryosuke Niwa rn...@webkit.org Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97119 => 97120) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 01:15:09 UTC (rev 97119) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 03:01:51 UTC (rev 97120) @@ -2221,7 +2221,6 @@ BUGCR98248 WIN : fast/text/stroking.html = IMAGE BUGCR98248 WIN : fast/transforms/shadows.html = IMAGE BUGCR98248 WIN : fast/writing-mode/english-lr-text.html = IMAGE -BUGCR98248 WIN : svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg = IMAGE BUGCR98248 WIN : svg/css/group-with-shadow.svg = IMAGE BUGCR98248 WIN : svg/css/text-gradient-shadow.svg = IMAGE @@ -2688,7 +2687,7 @@ BUGWK54322 SNOWLEOPARD : fast/text/international/pop-up-button-text-alignment-and-direction.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/text/international/text-combine-image-test.html = IMAGE BUGWK54322 SNOWLEOPARD : fonts/monospace.html = IMAGE -BUGWK54322 SNOWLEOPARD : http/tests/misc/acid3.html = IMAGE+TEXT // See SVG tests section too +BUGWK54322 SNOWLEOPARD DEBUG SLOW : http/tests/misc/acid3.html = IMAGE+TEXT // See SVG tests section too BUGWK54322 SNOWLEOPARD : svg/custom/animate-path-discrete.svg = IMAGE BUGWK54322 SNOWLEOPARD :
[webkit-changes] [97121] trunk/Source/WebCore
Title: [97121] trunk/Source/WebCore Revision 97121 Author tk...@chromium.org Date 2011-10-10 21:16:59 -0700 (Mon, 10 Oct 2011) Log Message Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement https://bugs.webkit.org/show_bug.cgi?id=69812 Reviewed by Ryosuke Niwa. Move SelectElementData::m_recalcListItems, SelectElementData::m_listItems, and related functions of SelectElementData class to HTMLSelectElement. Non-const listItems() was removed because it is used only in recalcListItemsInternal() and it can access m_listItems diretly. Static recalcListItems() is changed to non-static, and renamed to recalcListItemsInternal() in order to avoid confusion with the existing recalcListItems(). No new tests, just a refactoring. * dom/SelectElement.cpp: Move checkListItems() and listItems() to HTMLSelectElement. (WebCore::SelectElementData::SelectElementData): Remove Initialization of m_recalcListItems. * dom/SelectElement.h: Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initializes m_recalcListItems. (WebCore::HTMLSelectElement::recalcListItems): Rename the static recalcListItems() to recalcListItemsInternal(). (WebCore::HTMLSelectElement::recalcListItemsIfNeeded): Use m_recalcListItems directly. (WebCore::HTMLSelectElement::nextSelectableListIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto. (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto. (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto. (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto. (WebCore::HTMLSelectElement::saveLastSelection): ditto. (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto. (WebCore::HTMLSelectElement::updateListBoxSelection): ditto. (WebCore::HTMLSelectElement::listBoxOnChange): ditto. (WebCore::HTMLSelectElement::checkListItems): Moved from SelectElementData. (WebCore::HTMLSelectElement::listItems): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): Use m_recalcListItems directly. (WebCore::HTMLSelectElement::recalcListItemsInternal): - Make this non-static. - Renamed from recalcListItems() to avoid confilct with another recalcListItems(). - Use m_recalcListItems and m_listItems directly. (WebCore::HTMLSelectElement::selectedIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto. (WebCore::HTMLSelectElement::optionToListIndex): ditto. (WebCore::HTMLSelectElement::listToOptionIndex): ditto. (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto. (WebCore::HTMLSelectElement::saveFormControlState): Update callsites of listItems() and recalcListItems(). (WebCore::HTMLSelectElement::restoreFormControlState): Update a listItems() callsite. (WebCore::HTMLSelectElement::appendFormData): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::updateSelectedState): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto. (WebCore::HTMLSelectElement::typeAheadFind): ditto. (WebCore::HTMLSelectElement::insertedIntoTree): Update a recalcListItems() callsite. (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::length): ditto. * html/HTMLSelectElement.h: Move m_recalcListItems, m_listItems, and related functions from SelectElementData. * html/HTMLSelectElementWin.cpp: (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Update a listItems() callsite. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/SelectElement.cpp trunk/Source/WebCore/dom/SelectElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLSelectElementWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97120 => 97121) --- trunk/Source/WebCore/ChangeLog 2011-10-11 03:01:51 UTC (rev 97120) +++ trunk/Source/WebCore/ChangeLog 2011-10-11 04:16:59 UTC (rev 97121) @@ -1,3 +1,83 @@ +2011-10-10 Kent Tamura tk...@chromium.org + +Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement +https://bugs.webkit.org/show_bug.cgi?id=69812 + +Reviewed by Ryosuke Niwa. + +Move SelectElementData::m_recalcListItems, +SelectElementData::m_listItems, and related functions of +SelectElementData class to HTMLSelectElement. + +Non-const listItems() was removed because it is used only in +recalcListItemsInternal() and it can access m_listItems diretly. + +Static recalcListItems() is changed to non-static, and renamed to +recalcListItemsInternal() in order to avoid confusion with the +existing recalcListItems(). + +No new tests,
[webkit-changes] [97123] trunk/Source/WebCore
Title: [97123] trunk/Source/WebCore Revision 97123 Author tk...@chromium.org Date 2011-10-10 21:57:27 -0700 (Mon, 10 Oct 2011) Log Message Unreviewed, rolling out r97121. http://trac.webkit.org/changeset/97121 https://bugs.webkit.org/show_bug.cgi?id=69815 Many layout tests failed (Requested by tkent on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-10-10 * dom/SelectElement.cpp: (WebCore::SelectElementData::SelectElementData): (WebCore::SelectElementData::checkListItems): (WebCore::SelectElementData::listItems): * dom/SelectElement.h: (WebCore::SelectElementData::shouldRecalcListItems): (WebCore::SelectElementData::setShouldRecalcListItems): (WebCore::SelectElementData::rawListItems): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded): (WebCore::HTMLSelectElement::nextSelectableListIndex): (WebCore::HTMLSelectElement::previousSelectableListIndex): (WebCore::HTMLSelectElement::firstSelectableListIndex): (WebCore::HTMLSelectElement::lastSelectableListIndex): (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): (WebCore::HTMLSelectElement::saveLastSelection): (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::listBoxOnChange): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::selectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexInternal): (WebCore::HTMLSelectElement::optionToListIndex): (WebCore::HTMLSelectElement::listToOptionIndex): (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): (WebCore::HTMLSelectElement::saveFormControlState): (WebCore::HTMLSelectElement::restoreFormControlState): (WebCore::HTMLSelectElement::appendFormData): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::updateSelectedState): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::lastSelectedListIndex): (WebCore::HTMLSelectElement::typeAheadFind): (WebCore::HTMLSelectElement::insertedIntoTree): (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): (WebCore::HTMLSelectElement::length): * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::listItems): * html/HTMLSelectElementWin.cpp: (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/SelectElement.cpp trunk/Source/WebCore/dom/SelectElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLSelectElementWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97122 => 97123) --- trunk/Source/WebCore/ChangeLog 2011-10-11 04:55:43 UTC (rev 97122) +++ trunk/Source/WebCore/ChangeLog 2011-10-11 04:57:27 UTC (rev 97123) @@ -1,3 +1,55 @@ +2011-10-10 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r97121. +http://trac.webkit.org/changeset/97121 +https://bugs.webkit.org/show_bug.cgi?id=69815 + +Many layout tests failed (Requested by tkent on #webkit). + +* dom/SelectElement.cpp: +(WebCore::SelectElementData::SelectElementData): +(WebCore::SelectElementData::checkListItems): +(WebCore::SelectElementData::listItems): +* dom/SelectElement.h: +(WebCore::SelectElementData::shouldRecalcListItems): +(WebCore::SelectElementData::setShouldRecalcListItems): +(WebCore::SelectElementData::rawListItems): +* html/HTMLSelectElement.cpp: +(WebCore::HTMLSelectElement::HTMLSelectElement): +(WebCore::HTMLSelectElement::recalcListItems): +(WebCore::HTMLSelectElement::recalcListItemsIfNeeded): +(WebCore::HTMLSelectElement::nextSelectableListIndex): +(WebCore::HTMLSelectElement::previousSelectableListIndex): +(WebCore::HTMLSelectElement::firstSelectableListIndex): +(WebCore::HTMLSelectElement::lastSelectableListIndex): +(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): +(WebCore::HTMLSelectElement::saveLastSelection): +(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): +(WebCore::HTMLSelectElement::updateListBoxSelection): +(WebCore::HTMLSelectElement::listBoxOnChange): +(WebCore::HTMLSelectElement::setRecalcListItems): +(WebCore::HTMLSelectElement::selectedIndex): +(WebCore::HTMLSelectElement::setSelectedIndexInternal): +(WebCore::HTMLSelectElement::optionToListIndex): +(WebCore::HTMLSelectElement::listToOptionIndex): +(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): +(WebCore::HTMLSelectElement::saveFormControlState): +(WebCore::HTMLSelectElement::restoreFormControlState): +
[webkit-changes] [97124] trunk
Title: [97124] trunk
Revision 97124
Author infe...@chromium.org
Date 2011-10-10 22:08:13 -0700 (Mon, 10 Oct 2011)
Log Message
Style not updated on text fragment in :first-letter
nested in :before table.
https://bugs.webkit.org/show_bug.cgi?id=69540
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/css-generated-content/first-letter-in-nested-before-table.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
* fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97123 => 97124)
--- trunk/LayoutTests/ChangeLog 2011-10-11 04:57:27 UTC (rev 97123)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 05:08:13 UTC (rev 97124)
@@ -1,3 +1,15 @@
+2011-10-10 Abhishek Arya infe...@chromium.org
+
+Style not updated on text fragment in :first-letter
+nested in :before table.
+https://bugs.webkit.org/show_bug.cgi?id=69540
+
+Reviewed by Dan Bernstein.
+
+* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
+* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
+* fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
+
2011-10-10 James Simonsen simon...@chromium.org
[Chromium] Fix expectations from r97120.
Added: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (0 => 97124)
--- trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt 2011-10-11 05:08:13 UTC (rev 97124)
@@ -0,0 +1,40 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x266
+ RenderBlock {HTML} at (0,0) size 800x266
+RenderBody {BODY} at (8,8) size 784x250 [color=#FF]
+ RenderBlock {DIV} at (0,0) size 784x100
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: A
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: B
+RenderBlock (anonymous) at (0,50) size 784x50
+ RenderText {#text} at (0,0) size 50x50
+text run at (0,0) width 50: C
+ RenderBlock {DIV} at (0,100) size 784x100
+RenderBlock (anonymous) at (0,0) size 784x50
+ RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+RenderText {#text} at (0,0) size 50x50
+ text run at (0,0) width 50: D
+ RenderText {#text} at (0,0) size 0x0
+RenderTable at (0,50) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 100x50
+ text run at (0,0) width 100: EF
+ RenderBlock {DIV} at (0,200) size 784x50
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: E
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: F
Added:
[webkit-changes] [97125] branches/chromium/874
Title: [97125] branches/chromium/874
Revision 97125
Author infe...@chromium.org
Date 2011-10-10 22:12:53 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97124 - Style not updated on text fragment in :first-letter nested in :before table.
BUG=99294
Review URL: http://codereview.chromium.org/8229001
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt) (0 => 97125)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt 2011-10-11 05:12:53 UTC (rev 97125)
@@ -0,0 +1,40 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x266
+ RenderBlock {HTML} at (0,0) size 800x266
+RenderBody {BODY} at (8,8) size 784x250 [color=#FF]
+ RenderBlock {DIV} at (0,0) size 784x100
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: A
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: B
+RenderBlock (anonymous) at (0,50) size 784x50
+ RenderText {#text} at (0,0) size 50x50
+text run at (0,0) width 50: C
+ RenderBlock {DIV} at (0,100) size 784x100
+RenderBlock (anonymous) at (0,0) size 784x50
+ RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+RenderText {#text} at (0,0) size 50x50
+ text run at (0,0) width 50: D
+ RenderText {#text} at (0,0) size 0x0
+RenderTable at (0,50) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 100x50
+ text run at (0,0) width 100: EF
+ RenderBlock {DIV} at (0,200) size 784x50
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: E
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: F
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html) (0 => 97125)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html 2011-10-11 05:12:53 UTC (rev 97125)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+!-- No text in black, B and F should be blue. --
+html
+body style=font-family: ahem; font-size: 50px; -webkit-font-smoothing: none;
+style
+.test1:before {
+display: table;
+content: AB;
+}
+.test2:after {
+display: table;
+content: EF;
+}
+.test1:first-letter { color: green; }
+.test2:first-letter { color: green; }
+/style
+div class=test1C/div
+div class=test2D/div
+div class=test2/div
+script
+document.body.offsetTop;
+document.body.style.color = blue;
+/script
+/html
\ No newline at end of file
Modified: branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp (97124 => 97125)
--- branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-10-11 05:08:13 UTC (rev
[webkit-changes] [97126] trunk/LayoutTests
Title: [97126] trunk/LayoutTests Revision 97126 Author simon...@chromium.org Date 2011-10-10 22:33:44 -0700 (Mon, 10 Oct 2011) Log Message [Chromium] Fix expectations from r97120. (again) Unreviewed. * platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png: * platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97125 => 97126) --- trunk/LayoutTests/ChangeLog 2011-10-11 05:12:53 UTC (rev 97125) +++ trunk/LayoutTests/ChangeLog 2011-10-11 05:33:44 UTC (rev 97126) @@ -1,3 +1,12 @@ +2011-10-10 James Simonsen simon...@chromium.org + +[Chromium] Fix expectations from r97120. (again) + +Unreviewed. + +* platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png: +* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: + 2011-10-10 Abhishek Arya infe...@chromium.org Style not updated on text fragment in :first-letter Modified: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
