[webkit-changes] [97127] trunk/Source/WebCore
Title: [97127] trunk/Source/WebCore
Revision 97127
Author aba...@webkit.org
Date 2011-10-11 00:00:13 -0700 (Tue, 11 Oct 2011)
Log Message
Update test results.
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::V8TestInterface::existingWrapper):
(WebCore::V8TestInterface::wrap):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::V8TestMediaQueryListListener::existingWrapper):
(WebCore::V8TestMediaQueryListListener::wrap):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
(WebCore::TestObjInternal::cachedAttribute2AttrGetter):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::V8TestObj::existingWrapper):
(WebCore::V8TestObj::wrap):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.h
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97126 => 97127)
--- trunk/Source/WebCore/ChangeLog 2011-10-11 05:33:44 UTC (rev 97126)
+++ trunk/Source/WebCore/ChangeLog 2011-10-11 07:00:13 UTC (rev 97127)
@@ -1,3 +1,24 @@
+2011-10-10 Adam Barth
+
+Update test results.
+
+* bindings/scripts/test/V8/V8TestInterface.h:
+(WebCore::V8TestInterface::existingWrapper):
+(WebCore::V8TestInterface::wrap):
+* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
+(WebCore::V8TestMediaQueryListListener::existingWrapper):
+(WebCore::V8TestMediaQueryListListener::wrap):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjInternal::readOnlyTestObjAttrAttrGetter):
+(WebCore::TestObjInternal::cachedAttribute1AttrGetter):
+(WebCore::TestObjInternal::cachedAttribute2AttrGetter):
+* bindings/scripts/test/V8/V8TestObj.h:
+(WebCore::V8TestObj::existingWrapper):
+(WebCore::V8TestObj::wrap):
+* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
+(WebCore::V8TestSerializedScriptValueInterface::existingWrapper):
+(WebCore::V8TestSerializedScriptValueInterface::wrap):
+
2011-10-10 Abhishek Arya
Style not updated on text fragment in :first-letter
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h (97126 => 97127)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2011-10-11 05:33:44 UTC (rev 97126)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h 2011-10-11 07:00:13 UTC (rev 97127)
@@ -47,14 +47,20 @@
static WrapperTypeInfo info;
static v8::Handle constructorCallback(const v8::Arguments& args);
static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
+static v8::Handle existingWrapper(TestInterface*);
+
private:
static v8::Handle wrapSlow(TestInterface*);
};
+ALWAYS_INLINE v8::Handle V8TestInterface::existingWrapper(TestInterface* impl)
+{
+return getDOMObjectMap().get(impl);
+}
v8::Handle V8TestInterface::wrap(TestInterface* impl)
{
-v8::Handle wrapper = getDOMObjectMap().get(impl);
+v8::Handle wrapper = existingWrapper(impl);
if (!wrapper.IsEmpty())
return wrapper;
return V8TestInterface::wrapSlow(impl);
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h (97126 => 97127)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2011-10-11 05:33:44 UTC (rev 97126)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestMediaQueryListListener.h 2011-10-11 07:00:13 UTC (rev 97127)
@@ -44,14 +44,20 @@
static void derefObject(void*);
static WrapperTypeInfo info;
static const int internalFieldCount = v8DefaultWrapperInternalFieldCount + 0;
+static v8::Handle existingWrapper(TestMediaQueryListListener*);
+
private:
static v8::Handle wrapSlow(TestMediaQueryListListener*);
};
+ALWAYS_INLINE v8::Handle V8TestMediaQueryListListener::existingWrapper(TestMediaQueryListListener* impl)
+{
+return getDOMObjectMap().get(impl);
+}
v8::Handle V8TestMediaQueryListListener::wrap(TestMediaQueryListListener* impl)
{
-v8::Handle wrapper = getDOMObjectMap().get(impl);
+v8::Handle wrapper = existingWrapper(impl);
if (!wrapper.IsEmpty())
return wrapper;
return V8TestMediaQueryListListener::wrapSlow(impl);
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (97126 => 97127)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8T
[webkit-changes] [97126] trunk/LayoutTests
Title: [97126] trunk/LayoutTests Revision 97126 Author simon...@chromium.org Date 2011-10-10 22:33:44 -0700 (Mon, 10 Oct 2011) Log Message [Chromium] Fix expectations from r97120. (again) Unreviewed. * platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png: * platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97125 => 97126) --- trunk/LayoutTests/ChangeLog 2011-10-11 05:12:53 UTC (rev 97125) +++ trunk/LayoutTests/ChangeLog 2011-10-11 05:33:44 UTC (rev 97126) @@ -1,3 +1,12 @@ +2011-10-10 James Simonsen + +[Chromium] Fix expectations from r97120. (again) + +Unreviewed. + +* platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png: +* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: + 2011-10-10 Abhishek Arya Style not updated on text fragment in :first-letter Modified: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/smart-paste-008-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97125] branches/chromium/874
Title: [97125] branches/chromium/874
Revision 97125
Author infe...@chromium.org
Date 2011-10-10 22:12:53 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97124 - Style not updated on text fragment in :first-letter nested in :before table.
BUG=99294
Review URL: http://codereview.chromium.org/8229001
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt) (0 => 97125)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt 2011-10-11 05:12:53 UTC (rev 97125)
@@ -0,0 +1,40 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x266
+ RenderBlock {HTML} at (0,0) size 800x266
+RenderBody {BODY} at (8,8) size 784x250 [color=#FF]
+ RenderBlock {DIV} at (0,0) size 784x100
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: "A"
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: "B"
+RenderBlock (anonymous) at (0,50) size 784x50
+ RenderText {#text} at (0,0) size 50x50
+text run at (0,0) width 50: "C"
+ RenderBlock {DIV} at (0,100) size 784x100
+RenderBlock (anonymous) at (0,0) size 784x50
+ RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+RenderText {#text} at (0,0) size 50x50
+ text run at (0,0) width 50: "D"
+ RenderText {#text} at (0,0) size 0x0
+RenderTable at (0,50) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 100x50
+ text run at (0,0) width 100: "EF"
+ RenderBlock {DIV} at (0,200) size 784x50
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: "E"
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: "F"
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html (from rev 97124, trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html) (0 => 97125)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html 2011-10-11 05:12:53 UTC (rev 97125)
@@ -0,0 +1,24 @@
+
+
+
+
+
+.test1:before {
+display: table;
+content: "AB";
+}
+.test2:after {
+display: table;
+content: "EF";
+}
+.test1:first-letter { color: green; }
+.test2:first-letter { color: green; }
+
+C
+D
+
+
+document.body.offsetTop;
+document.body.style.color = "blue";
+
+
\ No newline at end of file
Modified: branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp (97124 => 97125)
--- branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-10-11 05:08:13 UTC (rev 97124)
+++ branches/chromium/874/Source/WebCore/rendering/RenderObjectChildList.cpp 2011-10-11 05:12:53 UTC (rev 97125)
@@ -446,6 +446,14 @@
ASSERT(genChild->isListMarker() || genChild->sty
[webkit-changes] [97124] trunk
Title: [97124] trunk
Revision 97124
Author infe...@chromium.org
Date 2011-10-10 22:08:13 -0700 (Mon, 10 Oct 2011)
Log Message
Style not updated on text fragment in :first-letter
nested in :before table.
https://bugs.webkit.org/show_bug.cgi?id=69540
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/css-generated-content/first-letter-in-nested-before-table.html
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):
LayoutTests:
* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
* fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt
trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97123 => 97124)
--- trunk/LayoutTests/ChangeLog 2011-10-11 04:57:27 UTC (rev 97123)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 05:08:13 UTC (rev 97124)
@@ -1,3 +1,15 @@
+2011-10-10 Abhishek Arya
+
+Style not updated on text fragment in :first-letter
+nested in :before table.
+https://bugs.webkit.org/show_bug.cgi?id=69540
+
+Reviewed by Dan Bernstein.
+
+* fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Added.
+* fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Added.
+* fast/css-generated-content/first-letter-in-nested-before-table.html: Added.
+
2011-10-10 James Simonsen
[Chromium] Fix expectations from r97120.
Added: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (0 => 97124)
--- trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt 2011-10-11 05:08:13 UTC (rev 97124)
@@ -0,0 +1,40 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x266
+ RenderBlock {HTML} at (0,0) size 800x266
+RenderBody {BODY} at (8,8) size 784x250 [color=#FF]
+ RenderBlock {DIV} at (0,0) size 784x100
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: "A"
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: "B"
+RenderBlock (anonymous) at (0,50) size 784x50
+ RenderText {#text} at (0,0) size 50x50
+text run at (0,0) width 50: "C"
+ RenderBlock {DIV} at (0,100) size 784x100
+RenderBlock (anonymous) at (0,0) size 784x50
+ RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+RenderText {#text} at (0,0) size 50x50
+ text run at (0,0) width 50: "D"
+ RenderText {#text} at (0,0) size 0x0
+RenderTable at (0,50) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 100x50
+ text run at (0,0) width 100: "EF"
+ RenderBlock {DIV} at (0,200) size 784x50
+RenderTable at (0,0) size 100x50
+ RenderTableSection (anonymous) at (0,0) size 100x50
+RenderTableRow (anonymous) at (0,0) size 100x50
+ RenderTableCell (anonymous) at (0,0) size 100x50 [r=0 c=0 rs=1 cs=1]
+RenderInline (generated) at (0,0) size 50x50 [color=#008000]
+ RenderText at (0,0) size 50x50
+text run at (0,0) width 50: "E"
+RenderText at (50,0) size 50x50
+ text run at (50,0) width 50: "F"
Added: trunk/LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html (0 => 97124)
--- trunk
[webkit-changes] [97123] trunk/Source/WebCore
Title: [97123] trunk/Source/WebCore Revision 97123 Author tk...@chromium.org Date 2011-10-10 21:57:27 -0700 (Mon, 10 Oct 2011) Log Message Unreviewed, rolling out r97121. http://trac.webkit.org/changeset/97121 https://bugs.webkit.org/show_bug.cgi?id=69815 Many layout tests failed (Requested by tkent on #webkit). Patch by Sheriff Bot on 2011-10-10 * dom/SelectElement.cpp: (WebCore::SelectElementData::SelectElementData): (WebCore::SelectElementData::checkListItems): (WebCore::SelectElementData::listItems): * dom/SelectElement.h: (WebCore::SelectElementData::shouldRecalcListItems): (WebCore::SelectElementData::setShouldRecalcListItems): (WebCore::SelectElementData::rawListItems): * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::recalcListItemsIfNeeded): (WebCore::HTMLSelectElement::nextSelectableListIndex): (WebCore::HTMLSelectElement::previousSelectableListIndex): (WebCore::HTMLSelectElement::firstSelectableListIndex): (WebCore::HTMLSelectElement::lastSelectableListIndex): (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): (WebCore::HTMLSelectElement::saveLastSelection): (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::listBoxOnChange): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::selectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexInternal): (WebCore::HTMLSelectElement::optionToListIndex): (WebCore::HTMLSelectElement::listToOptionIndex): (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): (WebCore::HTMLSelectElement::saveFormControlState): (WebCore::HTMLSelectElement::restoreFormControlState): (WebCore::HTMLSelectElement::appendFormData): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::updateSelectedState): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::lastSelectedListIndex): (WebCore::HTMLSelectElement::typeAheadFind): (WebCore::HTMLSelectElement::insertedIntoTree): (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): (WebCore::HTMLSelectElement::length): * html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::listItems): * html/HTMLSelectElementWin.cpp: (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/SelectElement.cpp trunk/Source/WebCore/dom/SelectElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLSelectElementWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97122 => 97123) --- trunk/Source/WebCore/ChangeLog 2011-10-11 04:55:43 UTC (rev 97122) +++ trunk/Source/WebCore/ChangeLog 2011-10-11 04:57:27 UTC (rev 97123) @@ -1,3 +1,55 @@ +2011-10-10 Sheriff Bot + +Unreviewed, rolling out r97121. +http://trac.webkit.org/changeset/97121 +https://bugs.webkit.org/show_bug.cgi?id=69815 + +Many layout tests failed (Requested by tkent on #webkit). + +* dom/SelectElement.cpp: +(WebCore::SelectElementData::SelectElementData): +(WebCore::SelectElementData::checkListItems): +(WebCore::SelectElementData::listItems): +* dom/SelectElement.h: +(WebCore::SelectElementData::shouldRecalcListItems): +(WebCore::SelectElementData::setShouldRecalcListItems): +(WebCore::SelectElementData::rawListItems): +* html/HTMLSelectElement.cpp: +(WebCore::HTMLSelectElement::HTMLSelectElement): +(WebCore::HTMLSelectElement::recalcListItems): +(WebCore::HTMLSelectElement::recalcListItemsIfNeeded): +(WebCore::HTMLSelectElement::nextSelectableListIndex): +(WebCore::HTMLSelectElement::previousSelectableListIndex): +(WebCore::HTMLSelectElement::firstSelectableListIndex): +(WebCore::HTMLSelectElement::lastSelectableListIndex): +(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): +(WebCore::HTMLSelectElement::saveLastSelection): +(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): +(WebCore::HTMLSelectElement::updateListBoxSelection): +(WebCore::HTMLSelectElement::listBoxOnChange): +(WebCore::HTMLSelectElement::setRecalcListItems): +(WebCore::HTMLSelectElement::selectedIndex): +(WebCore::HTMLSelectElement::setSelectedIndexInternal): +(WebCore::HTMLSelectElement::optionToListIndex): +(WebCore::HTMLSelectElement::listToOptionIndex): +(WebCore::HTMLSelectElement::deselectItemsWithoutValidation): +(WebCore::HTMLSelectElement::saveFormControlState): +(WebCore::HTMLSelectElement::restoreFormControlState): +(WebCore::HTMLSelectElement::appendFormData): +(WebCore::HTMLSelectElement::reset): +
[webkit-changes] [97121] trunk/Source/WebCore
Title: [97121] trunk/Source/WebCore Revision 97121 Author tk...@chromium.org Date 2011-10-10 21:16:59 -0700 (Mon, 10 Oct 2011) Log Message Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement https://bugs.webkit.org/show_bug.cgi?id=69812 Reviewed by Ryosuke Niwa. Move SelectElementData::m_recalcListItems, SelectElementData::m_listItems, and related functions of SelectElementData class to HTMLSelectElement. Non-const listItems() was removed because it is used only in recalcListItemsInternal() and it can access m_listItems diretly. Static recalcListItems() is changed to non-static, and renamed to recalcListItemsInternal() in order to avoid confusion with the existing recalcListItems(). No new tests, just a refactoring. * dom/SelectElement.cpp: Move checkListItems() and listItems() to HTMLSelectElement. (WebCore::SelectElementData::SelectElementData): Remove Initialization of m_recalcListItems. * dom/SelectElement.h: Move m_recalcListItems, m_listItems, and related functions to HTMLSelectElement. * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initializes m_recalcListItems. (WebCore::HTMLSelectElement::recalcListItems): Rename the static recalcListItems() to recalcListItemsInternal(). (WebCore::HTMLSelectElement::recalcListItemsIfNeeded): Use m_recalcListItems directly. (WebCore::HTMLSelectElement::nextSelectableListIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::previousSelectableListIndex): ditto. (WebCore::HTMLSelectElement::firstSelectableListIndex): ditto. (WebCore::HTMLSelectElement::lastSelectableListIndex): ditto. (WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): ditto. (WebCore::HTMLSelectElement::saveLastSelection): ditto. (WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto. (WebCore::HTMLSelectElement::updateListBoxSelection): ditto. (WebCore::HTMLSelectElement::listBoxOnChange): ditto. (WebCore::HTMLSelectElement::checkListItems): Moved from SelectElementData. (WebCore::HTMLSelectElement::listItems): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): Use m_recalcListItems directly. (WebCore::HTMLSelectElement::recalcListItemsInternal): - Make this non-static. - Renamed from recalcListItems() to avoid confilct with another recalcListItems(). - Use m_recalcListItems and m_listItems directly. (WebCore::HTMLSelectElement::selectedIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::setSelectedIndexInternal): ditto. (WebCore::HTMLSelectElement::optionToListIndex): ditto. (WebCore::HTMLSelectElement::listToOptionIndex): ditto. (WebCore::HTMLSelectElement::deselectItemsWithoutValidation): ditto. (WebCore::HTMLSelectElement::saveFormControlState): Update callsites of listItems() and recalcListItems(). (WebCore::HTMLSelectElement::restoreFormControlState): Update a listItems() callsite. (WebCore::HTMLSelectElement::appendFormData): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::updateSelectedState): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::lastSelectedListIndex): ditto. (WebCore::HTMLSelectElement::typeAheadFind): ditto. (WebCore::HTMLSelectElement::insertedIntoTree): Update a recalcListItems() callsite. (WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Update a listItems() callsite. (WebCore::HTMLSelectElement::length): ditto. * html/HTMLSelectElement.h: Move m_recalcListItems, m_listItems, and related functions from SelectElementData. * html/HTMLSelectElementWin.cpp: (WebCore::HTMLSelectElement::platformHandleKeydownEvent): Update a listItems() callsite. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/SelectElement.cpp trunk/Source/WebCore/dom/SelectElement.h trunk/Source/WebCore/html/HTMLSelectElement.cpp trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLSelectElementWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97120 => 97121) --- trunk/Source/WebCore/ChangeLog 2011-10-11 03:01:51 UTC (rev 97120) +++ trunk/Source/WebCore/ChangeLog 2011-10-11 04:16:59 UTC (rev 97121) @@ -1,3 +1,83 @@ +2011-10-10 Kent Tamura + +Move m_listItems and m_recalcListItems from SelectElementData to HTMLSelectElement +https://bugs.webkit.org/show_bug.cgi?id=69812 + +Reviewed by Ryosuke Niwa. + +Move SelectElementData::m_recalcListItems, +SelectElementData::m_listItems, and related functions of +SelectElementData class to HTMLSelectElement. + +Non-const listItems() was removed because it is used only in +recalcListItemsInternal() and it can access m_listItems diretly. + +Static recalcListItems() is changed to non-static, and renamed to +recalcListItemsInternal() in order to avoid confusion with the +existing recalcListItems(). + +No new tests, just a refactoring
[webkit-changes] [97120] trunk/LayoutTests
Title: [97120] trunk/LayoutTests Revision 97120 Author simon...@chromium.org Date 2011-10-10 20:01:51 -0700 (Mon, 10 Oct 2011) Log Message [Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests. Unreviewed. * platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added. * platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png: * platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css-generated-content/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png trunk/LayoutTests/platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png Removed Paths trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97119 => 97120) --- trunk/LayoutTests/ChangeLog 2011-10-11 01:15:09 UTC (rev 97119) +++ trunk/LayoutTests/ChangeLog 2011-10-11 03:01:51 UTC (rev 97120) @@ -1,3 +1,19 @@ +2011-10-10 James Simonsen + +[Chromium] Rebaselines for r97102 and r97114. Pass 2 more tests. + +Unreviewed. + +* platform/chromium-cg-mac-leopard/editing/pasteboard/smart-paste-008-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.txt: Added. +* platform/chromium-cg-mac-snowleopard/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium-linux/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png. +* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.png: +* platform/chromium-win/fast/css-generated-content/table-parts-before-and-after-expected.png: Added. +* platform/chromium/test_expectations.txt: + 2011-10-10 Ryosuke Niwa Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97119 => 97120) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 01:15:09 UTC (rev 97119) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-11 03:01:51 UTC (rev 97120) @@ -2221,7 +2221,6 @@ BUGCR98248 WIN : fast/text/stroking.html = IMAGE BUGCR98248 WIN : fast/transforms/shadows.html = IMAGE BUGCR98248 WIN : fast/writing-mode/english-lr-text.html = IMAGE -BUGCR98248 WIN : svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context.svg = IMAGE BUGCR98248 WIN : svg/css/group-with-shadow.svg = IMAGE BUGCR98248 WIN : svg/css/text-gradient-shadow.svg = IMAGE @@ -2688,7 +2687,7 @@ BUGWK54322 SNOWLEOPARD : fast/text/international/pop-up-button-text-alignment-and-direction.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/text/international/text-combine-image-test.html = IMAGE BUGWK54322 SNOWLEOPARD : fonts/monospace.html = IMAGE -BUGWK54322 SNOWLEOPARD : http/tests/misc/acid3.html = IMAGE+TEXT // See "SVG tests" section too +BUGWK54322 SNOWLEOPARD DEBUG SLOW : http/tests/misc/acid3.html = IMAGE+TEXT // See "SVG tests" section too BUGWK54322 SNOWLEOPARD : svg/custom/animate-path-discrete.svg = IMAGE BUGWK54322 SNOWLEOPARD : svg/W3C-SVG-1.1/coords-viewattr-01-b.sv
[webkit-changes] [97119] trunk/LayoutTests
Title: [97119] trunk/LayoutTests
Revision 97119
Author rn...@webkit.org
Date 2011-10-10 18:15:09 -0700 (Mon, 10 Oct 2011)
Log Message
Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
* platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97118 => 97119)
--- trunk/LayoutTests/ChangeLog 2011-10-11 01:14:13 UTC (rev 97118)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 01:15:09 UTC (rev 97119)
@@ -1,5 +1,13 @@
2011-10-10 Ryosuke Niwa
+Fix r97115. smart-paste-008.html is in editing/paste, not in fast/events.
+
+* platform/chromium/editing/pasteboard/smart-paste-008-expected.txt: Copied from
+LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt.
+* platform/chromium/fast/events/smart-paste-008-expected.txt: Removed.
+
+2011-10-10 Ryosuke Niwa
+
Another Chromium rebaseline after r97102.
* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed.
Copied: trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt (from rev 97115, trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt) (0 => 97119)
--- trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 01:15:09 UTC (rev 97119)
@@ -0,0 +1,33 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > DIV > BODY > HTML > #document to 3 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
+EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {P} at (0,0) size 784x40
+RenderText {#text} at (0,0) size 740x39
+ text run at (0,0) width 376: "There was a bug in paste's smart replace whitespace handling. "
+ text run at (376,0) width 364: "In some cases, it used information gathered at the start of the"
+ text run at (0,20) width 696: "selection being pasted into to decide whether or not a space needed to be added to the end of the incoming content."
+ RenderBlock {P} at (0,56) size 784x20
+RenderText {#text} at (0,0) size 772x19
+ text run at (0,0) width 522: "A smart paste is performed into a selection starting in one block and ending in another. "
+ text run at (522,0) width 250: "Spaces should surround the pasted word."
+ RenderBlock {DIV} at (0,92) size 784x20
+RenderBlock {DIV} at (0,0) size 784x20
+ RenderText {#text} at (0,0) size 52x19
+text run at (0,0) width 52: "f foo bar"
+RenderBlock (anonymous) at (0,20) size 784x0
+caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
Deleted: trunk/LayoutTests/platform/chromium/fast/events/smart-
[webkit-changes] [97118] trunk/Source/JavaScriptCore
Title: [97118] trunk/Source/_javascript_Core Revision 97118 Author fpi...@apple.com Date 2011-10-10 18:14:13 -0700 (Mon, 10 Oct 2011) Log Message DFG JSVALUE64 spill/fill code should not box integers and doubles https://bugs.webkit.org/show_bug.cgi?id=69782 Reviewed by Oliver Hunt. Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat. This required changing all of the places that spill registers (both silently and not) and filling registers (both silently and on demand). It also required changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile) may have the wrong format for the old JIT (unboxed int or double). This is a slight win on Kraken (0.25%) and neutral elsewhere. * dfg/DFGGenerationInfo.h: (JSC::DFG::GenerationInfo::spill): * dfg/DFGJITCodeGenerator.h: (JSC::DFG::JITCodeGenerator::silentFillFPR): (JSC::DFG::JITCodeGenerator::spill): * dfg/DFGJITCodeGenerator64.cpp: (JSC::DFG::JITCodeGenerator::fillInteger): (JSC::DFG::JITCodeGenerator::fillDouble): (JSC::DFG::JITCodeGenerator::fillJSValue): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::exitSpeculativeWithOSR): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::computeValueRecoveryFor): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::ValueRecovery::displacedInRegisterFile): (JSC::DFG::ValueRecovery::virtualRegister): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): (JSC::DFG::SpeculativeJIT::fillSpeculateDouble): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97117 => 97118) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:01:30 UTC (rev 97117) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:14:13 UTC (rev 97118) @@ -1,3 +1,40 @@ +2011-10-10 Filip Pizlo + +DFG JSVALUE64 spill/fill code should not box integers and doubles +https://bugs.webkit.org/show_bug.cgi?id=69782 + +Reviewed by Oliver Hunt. + +Added the notion of DataFormatInteger and DataFormatDouble to the spillFormat. +This required changing all of the places that spill registers (both silently +and not) and filling registers (both silently and on demand). It also required +changing OSR exit to recognize that a spilled value (DisplacedInRegisterFile) +may have the wrong format for the old JIT (unboxed int or double). + +This is a slight win on Kraken (0.25%) and neutral elsewhere. + +* dfg/DFGGenerationInfo.h: +(JSC::DFG::GenerationInfo::spill): +* dfg/DFGJITCodeGenerator.h: +(JSC::DFG::JITCodeGenerator::silentFillFPR): +(JSC::DFG::JITCodeGenerator::spill): +* dfg/DFGJITCodeGenerator64.cpp: +(JSC::DFG::JITCodeGenerator::fillInteger): +(JSC::DFG::JITCodeGenerator::fillDouble): +(JSC::DFG::JITCodeGenerator::fillJSValue): +* dfg/DFGJITCompiler.cpp: +(JSC::DFG::JITCompiler::exitSpeculativeWithOSR): +* dfg/DFGSpeculativeJIT.cpp: +(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor): +* dfg/DFGSpeculativeJIT.h: +(JSC::DFG::ValueRecovery::displacedInRegisterFile): +(JSC::DFG::ValueRecovery::virtualRegister): +* dfg/DFGSpeculativeJIT64.cpp: +(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): +(JSC::DFG::SpeculativeJIT::fillSpeculateDouble): +(JSC::DFG::SpeculativeJIT::fillSpeculateCell): +(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): + 2011-10-10 Gavin Barraclough DFG JIT switch dfgConvert methods to use callOperation Modified: trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h (97117 => 97118) --- trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h 2011-10-11 01:01:30 UTC (rev 97117) +++ trunk/Source/_javascript_Core/dfg/DFGGenerationInfo.h 2011-10-11 01:14:13 UTC (rev 97118) @@ -367,7 +367,7 @@ // pointers. This is not true anymore, but we still assume, in the fill code, // that any spill slot for a JS value is boxed. For storage pointers, there is // nothing we can do to box them, so we allow that to be an exception. -ASSERT((spillFormat & DataFormatJS) || spillFormat == DataFormatStorage); +ASSERT((spillFormat & DataFormatJS) || spillFormat == DataFormatStorage || spillFormat == DataFormatInteger || spillFormat == DataFormatDouble); m_registerFormat = DataFormatNone; m_spillFo
[webkit-changes] [97117] trunk/Source/JavaScriptCore
Title: [97117] trunk/Source/_javascript_Core
Revision 97117
Author barraclo...@apple.com
Date 2011-10-10 18:01:30 -0700 (Mon, 10 Oct 2011)
Log Message
DFG JIT switch dfgConvert methods to use callOperation
https://bugs.webkit.org/show_bug.cgi?id=69806
Reviewed by Filip Pizlo.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGOperations.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97116 => 97117)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-11 01:01:30 UTC (rev 97117)
@@ -1,5 +1,22 @@
2011-10-10 Gavin Barraclough
+DFG JIT switch dfgConvert methods to use callOperation
+https://bugs.webkit.org/show_bug.cgi?id=69806
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGJITCodeGenerator.h:
+(JSC::DFG::callOperation):
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToNumber):
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+* dfg/DFGOperations.h:
+
+2011-10-10 Gavin Barraclough
+
Remove some unused methods from the DFG JIT.
Rubber stamped by Oliver Hunt
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h (97116 => 97117)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator.h 2011-10-11 01:01:30 UTC (rev 97117)
@@ -1179,6 +1179,22 @@
return appendCallWithExceptionCheck(operation);
}
+JITCompiler::Call callOperation(Z_DFGOperation_EJ operation, GPRReg result, GPRReg arg1)
+{
+m_jit.move(arg1, GPRInfo::argumentGPR1);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
+JITCompiler::Call callOperation(D_DFGOperation_EJ operation, FPRReg result, GPRReg arg1)
+{
+m_jit.move(arg1, GPRInfo::argumentGPR1);
+m_jit.move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0);
+
+JITCompiler::Call call = appendCallWithExceptionCheck(operation);
+m_jit.moveDouble(FPRInfo::returnValueFPR, result);
+return call;
+}
JITCompiler::Call callOperation(D_DFGOperation_DD operation, FPRReg result, FPRReg arg1, FPRReg arg2)
{
setupTwoStubArgs(arg1, arg2);
@@ -1404,6 +1420,25 @@
return callOperation((V_DFGOperation_EPZJ)operation, arg1, arg2, arg3Tag, arg3Payload);
}
+JITCompiler::Call callOperation(Z_DFGOperation_EJ operation, GPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
+{
+m_jit.push(arg1Tag);
+m_jit.push(arg1Payload);
+m_jit.push(GPRInfo::callFrameRegister);
+
+return appendCallWithExceptionCheckSetResult(operation, result);
+}
+JITCompiler::Call callOperation(D_DFGOperation_EJ operation, FPRReg result, GPRReg arg1Tag, GPRReg arg1Payload)
+{
+m_jit.push(arg1Tag);
+m_jit.push(arg1Payload);
+m_jit.push(GPRInfo::callFrameRegister);
+
+JITCompiler::Call call = appendCallWithExceptionCheck(operation);
+m_jit.assembler().fstpl(0, JITCompiler::stackPointerRegister);
+m_jit.loadDouble(JITCompiler::stackPointerRegister, result);
+return call;
+}
JITCompiler::Call callOperation(D_DFGOperation_DD operation, FPRReg result, FPRReg arg1, FPRReg arg2)
{
m_jit.subPtr(TrustedImm32(2 * sizeof(double)), JITCompiler::stackPointerRegister);
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (97116 => 97117)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-11 00:57:11 UTC (rev 97116)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-11 01:01:30 UTC (rev 97117)
@@ -346,10 +346,7 @@
// Next handle cells (& other JS immediates)
nonNumeric.link(&m_jit);
silentSpillAllRegisters(resultTagGPR, resultPayloadGPR);
-m_jit.push(tagGPR);
-m_jit.push(payloadGPR);
-m_jit.push(GPRInfo::callFrameRegister);
-appendCallWithExceptionCheck(dfgConvertJSValueToNumber);
+callOperation(dfg
[webkit-changes] [97116] branches/chromium/874
Title: [97116] branches/chromium/874
Revision 97116
Author infe...@chromium.org
Date 2011-10-10 17:57:11 -0700 (Mon, 10 Oct 2011)
Log Message
Merge 97114 - Duplicate ::after content when both ::before and ::after are styled as table parts
BUG=99348
Review URL: http://codereview.chromium.org/8222024
Modified Paths
branches/chromium/874/Source/WebCore/rendering/RenderObject.cpp
branches/chromium/874/Source/WebCore/rendering/RenderTable.cpp
Added Paths
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt
branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png (from rev 97114, trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png)
(Binary files differ)
Copied: branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (from rev 97114, trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt) (0 => 97116)
--- branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt 2011-10-11 00:57:11 UTC (rev 97116)
@@ -0,0 +1,101 @@
+layer at (0,0) size 785x736
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x736
+ RenderBlock {HTML} at (0,0) size 785x736
+RenderBody {BODY} at (8,8) size 769x720
+ RenderBlock {DIV} at (0,0) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: "22"
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: "333"
+ RenderBlock {DIV} at (0,120) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: "22"
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: "333"
+ RenderBlock {DIV} at (0,240) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: "22"
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: "333"
+ RenderBlock {DIV} at (0,360) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 8
[webkit-changes] [97115] trunk/LayoutTests
Title: [97115] trunk/LayoutTests Revision 97115 Author rn...@webkit.org Date 2011-10-10 17:49:43 -0700 (Mon, 10 Oct 2011) Log Message Another Chromium rebaseline after r97102. * platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. * platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. * platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed. * platform/chromium-win/fast/events/ondragenter-expected.txt: Removed. * platform/chromium/fast/events/ondragenter-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt. * platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97114 => 97115) --- trunk/LayoutTests/ChangeLog 2011-10-11 00:46:53 UTC (rev 97114) +++ trunk/LayoutTests/ChangeLog 2011-10-11 00:49:43 UTC (rev 97115) @@ -1,3 +1,17 @@ +2011-10-10 Ryosuke Niwa + +Another Chromium rebaseline after r97102. + +* platform/chromium-cg-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium-mac-snowleopard/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt: Removed. +* platform/chromium-win/fast/events/ondragenter-expected.txt: Removed. +* platform/chromium/fast/events/ondragenter-expected.txt: Copied from +LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt. +* platform/chromium/fast/events/smart-paste-008-expected.txt: Copied from +LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt. +* platform/chromium/test_expectations.txt: + 2011-10-10 Dan Bernstein Duplicate ::after content when both ::before and ::after are styled as table parts Copied: trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt (from rev 97112, trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt) (0 => 97115) --- trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt 2011-10-11 00:49:43 UTC (rev 97115) @@ -0,0 +1,3 @@ + +Success: Text +This automated layout test checks to see that ondragenter events are being sent. Copied: trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt (from rev 97112, trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt) (0 => 97115) --- trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/fast/events/smart-paste-008-expected.txt 2011-10-11 00:49:43 UTC (rev 97115) @@ -0,0 +1,33 @@ +EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 2 of DIV > BODY > HTML > #document +EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > DIV > BODY > HTML > #document to 3 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #docum
[webkit-changes] [97114] trunk
Title: [97114] trunk
Revision 97114
Author m...@apple.com
Date 2011-10-10 17:46:53 -0700 (Mon, 10 Oct 2011)
Log Message
Duplicate ::after content when both ::before and ::after are styled as table parts
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/css-generated-content/table-parts-before-and-after.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Prevented table part childern after a ::before table from being merged
into it.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Prevented children after a ::before table section from being merged
into it.
LayoutTests:
* fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
* fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
* fast/css-generated-content/table-parts-before-and-after.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderTable.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt
trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97113 => 97114)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:41:18 UTC (rev 97113)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:46:53 UTC (rev 97114)
@@ -1,3 +1,13 @@
+2011-10-10 Dan Bernstein
+
+ Duplicate ::after content when both ::before and ::after are styled as table parts
+
+Reviewed by Sam Weinig.
+
+* fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
+* fast/css-generated-content/table-parts-before-and-after-expected.txt: Added.
+* fast/css-generated-content/table-parts-before-and-after.html: Added.
+
2011-10-10 Ryosuke Niwa
Chromium rebaseline after r97102.
Added: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (0 => 97114)
--- trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/table-parts-before-and-after-expected.txt 2011-10-11 00:46:53 UTC (rev 97114)
@@ -0,0 +1,101 @@
+layer at (0,0) size 785x736
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x736
+ RenderBlock {HTML} at (0,0) size 785x736
+RenderBody {BODY} at (8,8) size 769x720
+ RenderBlock {DIV} at (0,0) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: "22"
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: "333"
+ RenderBlock {DIV} at (0,120) size 769x120 [color=#FF]
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 40x40
+ text run at (0,0) width 40: "1"
+RenderBlock (anonymous) at (0,40) size 769x40
+ RenderText {#text} at (0,0) size 80x40
+text run at (0,0) width 80: "22"
+RenderTable at (0,80) size 120x40
+ RenderTableSection (anonymous) at (0,0) size 120x40
+RenderTableRow (anonymous) at (0,0) size 120x40
+ RenderTableCell (anonymous) at (0,0) size 120x40 [r=0 c=0 rs=1 cs=1]
+RenderText at (0,0) size 120x40
+ text run at (0,0) width 120: "333"
+ RenderBlock {DIV} at (0,240) size 769x120
+RenderTable at (0,0) size 40x40
+ RenderTableSection (anonymous) at (0,0) size 40x40
+RenderTableRow (anonymous) at (0,0) size 40x40
+ RenderTableCell (anonymous) at (0,0) size 40x40 [r=0 c=0 rs=1 cs=1]
+
[webkit-changes] [97112] trunk/LayoutTests
Title: [97112] trunk/LayoutTests
Revision 97112
Author rn...@webkit.org
Date 2011-10-10 17:35:52 -0700 (Mon, 10 Oct 2011)
Log Message
Chromium rebaseline after r97102.
* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
* platform/chromium-win/fast/events/ondragenter-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97111 => 97112)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:35:52 UTC (rev 97112)
@@ -1,3 +1,10 @@
+2011-10-10 Ryosuke Niwa
+
+Chromium rebaseline after r97102.
+
+* platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt:
+* platform/chromium-win/fast/events/ondragenter-expected.txt:
+
2011-10-10 Sheriff Bot
Unreviewed, rolling out r97087.
Modified: trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt (97111 => 97112)
--- trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/platform/chromium-win/editing/pasteboard/smart-paste-008-expected.txt 2011-10-11 00:35:52 UTC (rev 97112)
@@ -8,7 +8,7 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldInsertNode:#document-fragment replacingDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of #text > DIV > DIV > BODY > HTML > #document givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > DIV > DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document toDOMRange:range from 4 of #text > DIV > DIV > BODY > HTML > #document to 4 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 1 of #text > DIV > DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document toDOMRange:range from 5 of #text > DIV > DIV > BODY > HTML > #document to 5 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
layer at (0,0) size 800x600
@@ -27,11 +27,7 @@
text run at (522,0) width 250: "Spaces should surround the pasted word."
RenderBlock {DIV} at (0,92) size 784x20
RenderBlock {DIV} at (0,0) size 784x20
- RenderText {#text} at (0,0) size 4x19
-text run at (0,0) width 4: "f"
- RenderText {#text} at (4,0) size 24x19
-text run at (4,0) width 24: " foo"
- RenderText {#text} at (28,0) size 24x19
-text run at (28,0) width 24: " bar"
+ RenderText {#text} at (0,0) size 52x19
+text run at (0,0) width 52: "f foo bar"
RenderBlock (anonymous) at (0,20) size 784x0
-caret: position 4 of child 1 {#text} of child 0 {DIV} of child 4 {DIV} of body
+caret: position 5 of child 0 {#text} of child 0 {DIV} of child 4 {DIV} of body
Modified: trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt (97111 => 97112)
--- trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt 2011-10-11 00:29:34 UTC (rev 97111)
+++ trunk/LayoutTests/platform/chromium-win/fast/events/ondragenter-expected.txt 2011-10-11 00:35:52 UTC (rev 97112)
@@ -1,3 +1,3 @@
- Success:Text
+Success: Text
This automated layout test checks to see that ondragenter events are being sent.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97111] trunk/Websites/webkit.org
Title: [97111] trunk/Websites/webkit.org
Revision 97111
Author rn...@webkit.org
Date 2011-10-10 17:29:34 -0700 (Mon, 10 Oct 2011)
Log Message
Fix a typo pointed by Sam (Weinig).
* coding/coding-style.html:
Modified Paths
trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/coding/coding-style.html
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (97110 => 97111)
--- trunk/Websites/webkit.org/ChangeLog 2011-10-11 00:18:47 UTC (rev 97110)
+++ trunk/Websites/webkit.org/ChangeLog 2011-10-11 00:29:34 UTC (rev 97111)
@@ -1,5 +1,11 @@
2011-10-10 Ryosuke Niwa
+Fix a typo pointed by Sam (Weinig).
+
+* coding/coding-style.html:
+
+2011-10-10 Ryosuke Niwa
+
Style guide should mandate use of pass-by-reference for out arguments
https://bugs.webkit.org/show_bug.cgi?id=69766
Modified: trunk/Websites/webkit.org/coding/coding-style.html (97110 => 97111)
--- trunk/Websites/webkit.org/coding/coding-style.html 2011-10-11 00:18:47 UTC (rev 97110)
+++ trunk/Websites/webkit.org/coding/coding-style.html 2011-10-11 00:29:34 UTC (rev 97111)
@@ -750,7 +750,7 @@
{
doSomething();
if (outArgument)
-outArgument = m_value;
+*outArgument = m_value;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97110] trunk
Title: [97110] trunk
Revision 97110
Author commit-qu...@webkit.org
Date 2011-10-10 17:18:47 -0700 (Mon, 10 Oct 2011)
Log Message
Unreviewed, rolling out r97087.
http://trac.webkit.org/changeset/97087
https://bugs.webkit.org/show_bug.cgi?id=69805
failing assert on debug builds (Requested by simonjam on
#webkit).
Patch by Sheriff Bot on 2011-10-10
Source/WebCore:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):
* loader/DocumentWriter.h:
Source/WebKit/chromium:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::loadJavaScriptURL):
LayoutTests:
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Removed.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/WebCore/loader/DocumentWriter.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
Removed Paths
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97109 => 97110)
--- trunk/LayoutTests/ChangeLog 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/ChangeLog 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,3 +1,15 @@
+2011-10-10 Sheriff Bot
+
+Unreviewed, rolling out r97087.
+http://trac.webkit.org/changeset/97087
+https://bugs.webkit.org/show_bug.cgi?id=69805
+
+failing assert on debug builds (Requested by simonjam on
+#webkit).
+
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Removed.
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Removed.
+
2011-10-10 Nico Weber
PluginDocumentParser uses incorrect syntax for background color
Deleted: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (97109 => 97110)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,3 +0,0 @@
-CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
-
-This test passes if there's no alert dialog.
Deleted: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (97109 => 97110)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-11 00:11:14 UTC (rev 97109)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-10-11 00:18:47 UTC (rev 97110)
@@ -1,42 +0,0 @@
-
-
-
-if (window.layoutTestController) {
- layoutTestController.dumpAsText();
- layoutTestController.waitUntilDone();
- layoutTestController.setCanOpenWindows();
- layoutTestController.setCloseRemainingWindowsWhenComplete(true);
-}
-
-window._onload_ = function()
-{
- victim = document.body.appendChild(document.createElement("iframe"));
- wnd = victim.contentWindow.open();
- victim.src = ""
- victim._onload_ = function() {
- victim._onload_ = null;
-
- wnd.eval("(" + function() {
- location = "_javascript_:(" + function() {
-a = document.createElement("a");
-a.href = ""
-e = document.createEvent("MouseEvent");
-e.initMouseEvent("click");
-a.dispatchEvent(e);
-
-return "