[webkit-changes] [97445] trunk/Source/WebCore
Title: [97445] trunk/Source/WebCore
Revision 97445
Author ba...@chromium.org
Date 2011-10-13 23:57:10 -0700 (Thu, 13 Oct 2011)
Log Message
[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
https://bugs.webkit.org/show_bug.cgi?id=70087
Reviewed by Kent Tamura.
Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.
No new tests because there is no behavior change. Manually tested with valgrind.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::setupFontFeatures):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97444 => 97445)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 06:24:10 UTC (rev 97444)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 06:57:10 UTC (rev 97445)
@@ -1,3 +1,17 @@
+2011-10-13 Kenichi Ishibashi
+
+[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
+https://bugs.webkit.org/show_bug.cgi?id=70087
+
+Reviewed by Kent Tamura.
+
+Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.
+
+No new tests because there is no behavior change. Manually tested with valgrind.
+
+* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
+(WebCore::setupFontFeatures):
+
2011-10-13 Csaba Osztrogonác
[Qt][Win] Unreviewed buildfix after r97433.
Modified: trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp (97444 => 97445)
--- trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-14 06:24:10 UTC (rev 97444)
+++ trunk/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp 2011-10-14 06:57:10 UTC (rev 97445)
@@ -220,13 +220,13 @@
if (hbFace->gpos)
HB_GPOS_Clear_Features(hbFace->gpos);
-HB_UShort scriptIndex;
+HB_UShort scriptIndex = 0;
HB_GSUB_Select_Script(hbFace->gsub, HB_MAKE_TAG('D', 'F', 'L', 'T'), &scriptIndex);
size_t numFeatures = settings->size();
for (size_t i = 0; i < numFeatures; ++i) {
if (!settings->at(i).value())
continue;
-HB_UShort featureIndex;
+HB_UShort featureIndex = 0;
const UChar* tag = settings->at(i).tag().characters();
HB_UInt feature = HB_MAKE_TAG(tag[0], tag[1], tag[2], tag[3]);
if (hbFace->gsub && HB_GSUB_Select_Feature(hbFace->gsub, feature, scriptIndex, 0x, &featureIndex) == HB_Err_Ok)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97444] trunk/Source/WebKit/chromium
Title: [97444] trunk/Source/WebKit/chromium
Revision 97444
Author commit-qu...@webkit.org
Date 2011-10-13 23:24:10 -0700 (Thu, 13 Oct 2011)
Log Message
Expose layer debug borders to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=70079
Patch by Antoine Labour on 2011-10-13
Reviewed by Darin Fisher.
* public/WebLayer.h:
* src/WebLayer.cpp:
(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebLayer.h
trunk/Source/WebKit/chromium/src/WebLayer.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97443 => 97444)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-14 06:14:54 UTC (rev 97443)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-14 06:24:10 UTC (rev 97444)
@@ -1,3 +1,15 @@
+2011-10-13 Antoine Labour
+
+Expose layer debug borders to WebLayer
+https://bugs.webkit.org/show_bug.cgi?id=70079
+
+Reviewed by Darin Fisher.
+
+* public/WebLayer.h:
+* src/WebLayer.cpp:
+(WebKit::WebLayer::setDebugBorderColor):
+(WebKit::WebLayer::setDebugBorderWidth):
+
2011-10-13 Julien Chaffraix
Remove layerX / layerY from the Chromium API
Modified: trunk/Source/WebKit/chromium/public/WebLayer.h (97443 => 97444)
--- trunk/Source/WebKit/chromium/public/WebLayer.h 2011-10-14 06:14:54 UTC (rev 97443)
+++ trunk/Source/WebKit/chromium/public/WebLayer.h 2011-10-14 06:24:10 UTC (rev 97444)
@@ -26,6 +26,7 @@
#ifndef WebLayer_h
#define WebLayer_h
+#include "WebColor.h"
#include "WebCommon.h"
#include "WebPrivatePtr.h"
@@ -92,6 +93,9 @@
WEBKIT_EXPORT void setTransform(const SkMatrix44&);
WEBKIT_EXPORT SkMatrix44 transform() const;
+WEBKIT_EXPORT void setDebugBorderColor(const WebColor&);
+WEBKIT_EXPORT void setDebugBorderWidth(float);
+
template T to()
{
T res;
Modified: trunk/Source/WebKit/chromium/src/WebLayer.cpp (97443 => 97444)
--- trunk/Source/WebKit/chromium/src/WebLayer.cpp 2011-10-14 06:14:54 UTC (rev 97443)
+++ trunk/Source/WebKit/chromium/src/WebLayer.cpp 2011-10-14 06:24:10 UTC (rev 97444)
@@ -26,6 +26,7 @@
#include "config.h"
#include "WebLayer.h"
+#include "Color.h"
#include "LayerChromium.h"
#include "SkMatrix44.h"
#include "TransformationMatrix.h"
@@ -235,6 +236,16 @@
return skMatrix44FromTransformationMatrix(m_private->transform());
}
+void WebLayer::setDebugBorderColor(const WebColor& color)
+{
+m_private->setDebugBorderColor(color);
+}
+
+void WebLayer::setDebugBorderWidth(float width)
+{
+m_private->setDebugBorderWidth(width);
+}
+
WebLayer::WebLayer(const PassRefPtr& node)
: m_private(node)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97443] trunk/Source/WebCore
Title: [97443] trunk/Source/WebCore
Revision 97443
Author o...@webkit.org
Date 2011-10-13 23:14:54 -0700 (Thu, 13 Oct 2011)
Log Message
[Qt][Win] Unreviewed buildfix after r97433.
* platform/MemoryPressureHandler.h: Add a missing include.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MemoryPressureHandler.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97442 => 97443)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 05:21:51 UTC (rev 97442)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 06:14:54 UTC (rev 97443)
@@ -1,3 +1,9 @@
+2011-10-13 Csaba Osztrogonác
+
+[Qt][Win] Unreviewed buildfix after r97433.
+
+* platform/MemoryPressureHandler.h: Add a missing include.
+
2011-10-13 Adam Barth
Spelling error in v8WebSocket::constructorCallback error
Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.h (97442 => 97443)
--- trunk/Source/WebCore/platform/MemoryPressureHandler.h 2011-10-14 05:21:51 UTC (rev 97442)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.h 2011-10-14 06:14:54 UTC (rev 97443)
@@ -26,6 +26,7 @@
#ifndef MemoryPressureHandler_h
#define MemoryPressureHandler_h
+#include
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97442] trunk/LayoutTests
Title: [97442] trunk/LayoutTests Revision 97442 Author scher...@chromium.org Date 2011-10-13 22:21:51 -0700 (Thu, 13 Oct 2011) Log Message 2011-10-13 Andrew Scherkus Unreviewed, updating Chromium expectations for http/tests/media/video-play-stall.html. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97441 => 97442) --- trunk/LayoutTests/ChangeLog 2011-10-14 05:12:32 UTC (rev 97441) +++ trunk/LayoutTests/ChangeLog 2011-10-14 05:21:51 UTC (rev 97442) @@ -1,3 +1,9 @@ +2011-10-13 Andrew Scherkus + +Unreviewed, updating Chromium expectations for http/tests/media/video-play-stall.html. + +* platform/chromium/test_expectations.txt: + 2011-10-13 Adam Barth Spelling error in v8WebSocket::constructorCallback error Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97441 => 97442) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 05:12:32 UTC (rev 97441) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 05:21:51 UTC (rev 97442) @@ -748,7 +748,8 @@ BUGCR78376 : http/tests/media/video-play-stall-seek.html = TIMEOUT // canplaythrough event is sent too early. -BUGCR100103 BUGCR73609 : http/tests/media/video-play-stall.html = TEXT TIMEOUT PASS +// Test is intentionally SLOW as we're waiting for a connection timeout. +BUGCR73609 SLOW : http/tests/media/video-play-stall.html = TEXT PASS // video.buffered multiple TimeRanges support. BUGCR49165 SKIP : http/tests/media/video-buffered.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97441] trunk
Title: [97441] trunk
Revision 97441
Author aba...@webkit.org
Date 2011-10-13 22:12:32 -0700 (Thu, 13 Oct 2011)
Log Message
Spelling error in v8WebSocket::constructorCallback error
https://bugs.webkit.org/show_bug.cgi?id=63943
Reviewed by Kent Tamura.
Source/WebCore:
Fix typo.
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
LayoutTests:
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (97440 => 97441)
--- trunk/LayoutTests/ChangeLog 2011-10-14 05:08:29 UTC (rev 97440)
+++ trunk/LayoutTests/ChangeLog 2011-10-14 05:12:32 UTC (rev 97441)
@@ -1,5 +1,14 @@
2011-10-13 Adam Barth
+Spelling error in v8WebSocket::constructorCallback error
+https://bugs.webkit.org/show_bug.cgi?id=63943
+
+Reviewed by Kent Tamura.
+
+* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
+
+2011-10-13 Adam Barth
+
Add missing result. Yes, it's supposed to be blank.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png: Added.
Modified: trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt (97440 => 97441)
--- trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt 2011-10-14 05:08:29 UTC (rev 97440)
+++ trunk/LayoutTests/platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt 2011-10-14 05:12:32 UTC (rev 97441)
@@ -22,7 +22,7 @@
PASS Uint8Array() threw exception TypeError: DOM object constructor cannot be called as a function..
PASS WebKitCSSMatrix() threw exception TypeError: DOM object constructor cannot be called as a function..
PASS WebKitPoint() threw exception TypeError: DOM object constructor cannot be called as a function..
-PASS WebSocket() threw exception TypeError: DOM object custructor cannot be called as a function..
+PASS WebSocket() threw exception TypeError: DOM object constructor cannot be called as a function..
PASS Worker() threw exception TypeError: DOM object constructor cannot be called as a function..
PASS XMLHttpRequest() threw exception TypeError: DOM object constructor cannot be called as a function..
PASS XSLTProcessor() threw exception TypeError: DOM object constructor cannot be called as a function..
Modified: trunk/Source/WebCore/ChangeLog (97440 => 97441)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 05:08:29 UTC (rev 97440)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 05:12:32 UTC (rev 97441)
@@ -1,3 +1,15 @@
+2011-10-13 Adam Barth
+
+Spelling error in v8WebSocket::constructorCallback error
+https://bugs.webkit.org/show_bug.cgi?id=63943
+
+Reviewed by Kent Tamura.
+
+Fix typo.
+
+* bindings/v8/custom/V8WebSocketCustom.cpp:
+(WebCore::V8WebSocket::constructorCallback):
+
2011-10-13 Mark Hahnenberg
Rename virtual getConstructData to getConstructDataVirtual
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp (97440 => 97441)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp 2011-10-14 05:08:29 UTC (rev 97440)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp 2011-10-14 05:12:32 UTC (rev 97441)
@@ -56,7 +56,7 @@
INC_STATS("DOM.WebSocket.Constructor");
if (!args.IsConstructCall())
-return throwError("DOM object custructor cannot be called as a function.", V8Proxy::TypeError);
+return throwError("DOM object constructor cannot be called as a function.", V8Proxy::TypeError);
if (args.Length() == 0)
return throwError("Not enough arguments", V8Proxy::SyntaxError);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97440] trunk/LayoutTests
Title: [97440] trunk/LayoutTests Revision 97440 Author aba...@webkit.org Date 2011-10-13 22:08:29 -0700 (Thu, 13 Oct 2011) Log Message Add missing result. Yes, it's supposed to be blank. * http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97439 => 97440) --- trunk/LayoutTests/ChangeLog 2011-10-14 03:32:09 UTC (rev 97439) +++ trunk/LayoutTests/ChangeLog 2011-10-14 05:08:29 UTC (rev 97440) @@ -1,3 +1,9 @@ +2011-10-13 Adam Barth + +Add missing result. Yes, it's supposed to be blank. + +* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png: Added. + 2011-10-13 Kent Tamura [Chromium] Update test expectation. Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97439] trunk/LayoutTests
Title: [97439] trunk/LayoutTests Revision 97439 Author tk...@chromium.org Date 2011-10-13 20:32:09 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Update test expectation. - Mark some tests flaky on Windows GPU - Update Leopard-specific images. * platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added. * platform/chromium-cg-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added. * platform/chromium-cg-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added. * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added. * platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added. * platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added. * platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png trunk/LayoutTests/platform/chromium-mac-l
[webkit-changes] [97437] trunk/Tools
Title: [97437] trunk/Tools
Revision 97437
Author o...@chromium.org
Date 2011-10-13 20:11:24 -0700 (Thu, 13 Oct 2011)
Log Message
Make filter-build-webkit exit 1 if the build fails.
https://bugs.webkit.org/show_bug.cgi?id=70080
Reviewed by Eric Seidel.
This only works if you redirect stderr to stdout, but it at least makes it possible.
This is useful if you want to run a followup command (e.g. run-webkit-tests) but
only if the build succeeds.
* Scripts/filter-build-webkit:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/filter-build-webkit
Diff
Modified: trunk/Tools/ChangeLog (97436 => 97437)
--- trunk/Tools/ChangeLog 2011-10-14 02:22:41 UTC (rev 97436)
+++ trunk/Tools/ChangeLog 2011-10-14 03:11:24 UTC (rev 97437)
@@ -1,3 +1,16 @@
+2011-10-13 Ojan Vafai
+
+Make filter-build-webkit exit 1 if the build fails.
+https://bugs.webkit.org/show_bug.cgi?id=70080
+
+Reviewed by Eric Seidel.
+
+This only works if you redirect stderr to stdout, but it at least makes it possible.
+This is useful if you want to run a followup command (e.g. run-webkit-tests) but
+only if the build succeeds.
+
+* Scripts/filter-build-webkit:
+
2011-10-13 Dimitri Glazkov
land-cowboy should at least check style.
Modified: trunk/Tools/Scripts/filter-build-webkit (97436 => 97437)
--- trunk/Tools/Scripts/filter-build-webkit 2011-10-14 02:22:41 UTC (rev 97436)
+++ trunk/Tools/Scripts/filter-build-webkit 2011-10-14 03:11:24 UTC (rev 97437)
@@ -118,6 +118,7 @@
print OUTPUT_HANDLE HTML_HEADER if ($outputFormat eq "html");
my $buildFinished;
+my $buildFailed = 0;
while (my $line = <>) {
print UNFILTERED_OUTPUT_HANDLE $line if $logUnfilteredOutput;
@@ -151,6 +152,10 @@
my ($command, $path) = ($1, basename($2));
printLine("$command $path", STYLE_PLAIN);
} else {
+# This only gets hit if stderr is redirected to stdout.
+if ($line =~ /\*\* BUILD FAILED \*\*/) {
+$buildFailed = 1;
+}
printLine($line, $buildFinished ? STYLE_SUCCESS : STYLE_ALERT);
}
}
@@ -160,7 +165,7 @@
close(OUTPUT_HANDLE);
close(UNFILTERED_OUTPUT_HANDLE) if ($logUnfilteredOutput);
-exit 0;
+exit $buildFailed;
sub printLine($$)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97435] trunk/Websites/bugs.webkit.org
Title: [97435] trunk/Websites/bugs.webkit.org Revision 97435 Author aba...@webkit.org Date 2011-10-13 18:40:23 -0700 (Thu, 13 Oct 2011) Log Message Would be nice if the review-tool offered to show the corresponding header https://bugs.webkit.org/show_bug.cgi?id=63963 Reviewed by Ojan Vafai. This is a first cut at adding links to the header file in the review tool. If folks like this feature, we can cover more cases in the future. * code-review.js: Modified Paths trunk/Websites/bugs.webkit.org/ChangeLog trunk/Websites/bugs.webkit.org/code-review-test.html trunk/Websites/bugs.webkit.org/code-review.js Diff Modified: trunk/Websites/bugs.webkit.org/ChangeLog (97434 => 97435) --- trunk/Websites/bugs.webkit.org/ChangeLog 2011-10-14 01:22:42 UTC (rev 97434) +++ trunk/Websites/bugs.webkit.org/ChangeLog 2011-10-14 01:40:23 UTC (rev 97435) @@ -1,3 +1,16 @@ +2011-10-13 Adam Barth + +Would be nice if the review-tool offered to show the corresponding header +https://bugs.webkit.org/show_bug.cgi?id=63963 + +Reviewed by Ojan Vafai. + +This is a first cut at adding links to the header file in the review +tool. If folks like this feature, we can cover more cases in the +future. + +* code-review.js: + 2011-09-14 Ben Wells PrettyPatch should handle "delta" patch mechanism in git binary patches Modified: trunk/Websites/bugs.webkit.org/code-review-test.html (97434 => 97435) --- trunk/Websites/bugs.webkit.org/code-review-test.html 2011-10-14 01:22:42 UTC (rev 97434) +++ trunk/Websites/bugs.webkit.org/code-review-test.html 2011-10-14 01:40:23 UTC (rev 97435) @@ -2,6 +2,7 @@ FIXME: Run these as part of the layout test suite? CODE_REVIEW_UNITTEST = true +
[webkit-changes] [97434] trunk/Source/WebCore
Title: [97434] trunk/Source/WebCore
Revision 97434
Author simon.fra...@apple.com
Date 2011-10-13 18:22:42 -0700 (Thu, 13 Oct 2011)
Log Message
Remove #include of in a widely-used header.
Reviewed by Sam Weinig.
* platform/PlatformScreen.h: Typedef PlatformDisplayID to a uint32_t.
* platform/graphics/DisplayRefreshMonitor.h: Typedef CVDisplayLinkRef as
an opaque type to avoid bringing in QuartzCore.h, and move displayLinkCallback
to the .cpp file since it uses Core Video types.
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::displayLinkCallback): Make this a local static function, that
calls a member fuction on the object.
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformScreen.h
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h
trunk/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97433 => 97434)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 01:16:52 UTC (rev 97433)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 01:22:42 UTC (rev 97434)
@@ -1,3 +1,19 @@
+2011-10-13 Simon Fraser
+
+Remove #include of in a widely-used header.
+
+Reviewed by Sam Weinig.
+
+* platform/PlatformScreen.h: Typedef PlatformDisplayID to a uint32_t.
+* platform/graphics/DisplayRefreshMonitor.h: Typedef CVDisplayLinkRef as
+an opaque type to avoid bringing in QuartzCore.h, and move displayLinkCallback
+to the .cpp file since it uses Core Video types.
+* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
+(WebCore::displayLinkCallback): Make this a local static function, that
+calls a member fuction on the object.
+(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
+(WebCore::DisplayRefreshMonitor::displayLinkFired):
+
2011-10-13 Michael Saboff
REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection
Modified: trunk/Source/WebCore/platform/PlatformScreen.h (97433 => 97434)
--- trunk/Source/WebCore/platform/PlatformScreen.h 2011-10-14 01:16:52 UTC (rev 97433)
+++ trunk/Source/WebCore/platform/PlatformScreen.h 2011-10-14 01:22:42 UTC (rev 97434)
@@ -31,8 +31,6 @@
#include
#if PLATFORM(MAC)
-#include
-
#ifdef __OBJC__
@class NSScreen;
@class NSWindow;
@@ -40,11 +38,10 @@
class NSScreen;
class NSWindow;
#endif
-typedef CGDirectDisplayID PlatformDisplayID;
-#else
-typedef uint64_t PlatformDisplayID;
#endif
+typedef uint32_t PlatformDisplayID;
+
namespace WebCore {
class FloatRect;
Modified: trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h (97433 => 97434)
--- trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h 2011-10-14 01:16:52 UTC (rev 97433)
+++ trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h 2011-10-14 01:22:42 UTC (rev 97434)
@@ -32,6 +32,10 @@
#include
#include
+#if PLATFORM(MAC)
+typedef struct __CVDisplayLink *CVDisplayLinkRef;
+#endif
+
namespace WebCore {
class DisplayRefreshMonitor;
@@ -101,8 +105,10 @@
Vector m_clients;
#if PLATFORM(MAC)
+public:
+void displayLinkFired(double nowSeconds, double outputTimeSeconds);
+private:
static void refreshDisplayOnMainThread(void* data);
-static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp* now, const CVTimeStamp* outputTime, CVOptionFlags, CVOptionFlags*, void* data);
CVDisplayLinkRef m_displayLink;
#endif
Modified: trunk/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp (97433 => 97434)
--- trunk/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp 2011-10-14 01:16:52 UTC (rev 97433)
+++ trunk/Source/WebCore/platform/graphics/mac/DisplayRefreshMonitorMac.cpp 2011-10-14 01:22:42 UTC (rev 97434)
@@ -35,20 +35,14 @@
namespace WebCore {
-CVReturn DisplayRefreshMonitor::displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp* now, const CVTimeStamp* outputTime, CVOptionFlags, CVOptionFlags*, void* data)
+static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp* now, const CVTimeStamp* outputTime, CVOptionFlags, CVOptionFlags*, void* data)
{
DisplayRefreshMonitor* monitor = static_cast(data);
-
-MutexLocker lock(monitor->m_mutex);
-if (!monitor->m_scheduled)
-return kCVReturnSuccess;
double nowSeconds = static_cast(now->videoTime) / static_cast(now->videoTimeScale);
double outputTimeSeconds = static_cast(outputTime->videoTime) / static_cast(outputTime->videoTimeScale);
-double webKitNow = currentTime();
-monitor->m_timestamp = webKitNow - nowSeconds + outputTimeSeconds;
-
-callOnMainThread(DisplayRefreshMonitor::refreshDisplayOnMainThread, monitor);
+monitor->displayLinkFired(nowSeconds, outputTimeSeconds);
+
return kCVRetu
[webkit-changes] [97433] trunk/Source/WebCore
Title: [97433] trunk/Source/WebCore
Revision 97433
Author msab...@apple.com
Date 2011-10-13 18:16:52 -0700 (Thu, 13 Oct 2011)
Log Message
REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection
https://bugs.webkit.org/show_bug.cgi?id=69774
Throttle the processing of memory pressure events to no more often than once every 5 seconds.
Reviewed by Geoffrey Garen.
No new tests.
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
* platform/MemoryPressureHandler.h:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/MemoryPressureHandler.cpp
trunk/Source/WebCore/platform/MemoryPressureHandler.h
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (97432 => 97433)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 01:01:45 UTC (rev 97432)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 01:16:52 UTC (rev 97433)
@@ -1,3 +1,20 @@
+2011-10-13 Michael Saboff
+
+REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection
+https://bugs.webkit.org/show_bug.cgi?id=69774
+
+Throttle the processing of memory pressure events to no more often than once every 5 seconds.
+
+Reviewed by Geoffrey Garen.
+
+No new tests.
+
+* platform/MemoryPressureHandler.cpp:
+(WebCore::MemoryPressureHandler::MemoryPressureHandler):
+* platform/MemoryPressureHandler.h:
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::respondToMemoryPressure):
+
2011-10-13 Kentaro Hara
Implement an OverflowEvent constructor for V8
Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.cpp (97432 => 97433)
--- trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2011-10-14 01:01:45 UTC (rev 97432)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.cpp 2011-10-14 01:16:52 UTC (rev 97433)
@@ -38,12 +38,17 @@
MemoryPressureHandler::MemoryPressureHandler()
: m_installed(false)
+, m_lastRespondTime(0)
{
}
#if !PLATFORM(MAC) || defined(BUILDING_ON_LEOPARD) || defined(BUILDING_ON_SNOW_LEOPARD)
void MemoryPressureHandler::install() { }
+void MemoryPressureHandler::uninstall() { }
+
+void MemoryPressureHandler::holdOff(unsigned) { }
+
void MemoryPressureHandler::respondToMemoryPressure() { }
#endif
Modified: trunk/Source/WebCore/platform/MemoryPressureHandler.h (97432 => 97433)
--- trunk/Source/WebCore/platform/MemoryPressureHandler.h 2011-10-14 01:01:45 UTC (rev 97432)
+++ trunk/Source/WebCore/platform/MemoryPressureHandler.h 2011-10-14 01:16:52 UTC (rev 97433)
@@ -35,7 +35,10 @@
friend MemoryPressureHandler& memoryPressureHandler();
void install();
+void uninstall();
+void holdOff(unsigned);
+
private:
MemoryPressureHandler();
~MemoryPressureHandler();
@@ -43,6 +46,7 @@
void respondToMemoryPressure();
bool m_installed;
+time_t m_lastRespondTime;
};
// Function to obtain the global memory pressure object.
Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (97432 => 97433)
--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-10-14 01:01:45 UTC (rev 97432)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-10-14 01:16:52 UTC (rev 97433)
@@ -52,12 +52,17 @@
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
static dispatch_source_t _cache_event_source = 0;
+static dispatch_source_t _timer_event_source = 0;
+static int _notifyToken;
+// Disable memory event reception for 5 seconds after receiving an event.
+// This value seems reasonable and testing verifies that it throttles frequent
+// low memory events, greatly reducing CPU usage.
+static const time_t s_secondsBetweenMemoryCleanup = 5;
+
void MemoryPressureHandler::install()
{
-static int notifyToken;
-
-if (m_installed)
+if (m_installed || _timer_event_source)
return;
dispatch_async(dispatch_get_main_queue(), ^{
@@ -69,14 +74,47 @@
}
});
-notify_register_dispatch("org.WebKit.lowMemory", ¬ifyToken,
+notify_register_dispatch("org.WebKit.lowMemory", &_notifyToken,
dispatch_get_main_queue(), ^(int) { memoryPressureHandler().respondToMemoryPressure();});
m_installed = true;
}
+void MemoryPressureHandler::uninstall()
+{
+if (!m_installed)
+return;
+
+dispatch_source_cancel(_cache_event_source);
+_cache_event_source = 0;
+m_installed = false;
+
+notify_cancel(_notifyToken);
+}
+
+void MemoryPressureHandler::holdOff(unsigned seconds)
+{
+uninstall();
+
+dispatch_async(dispatch_get_main_queue(), ^{
+_timer_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER,
[webkit-changes] [97432] trunk/Source/JavaScriptCore
Title: [97432] trunk/Source/_javascript_Core Revision 97432 Author fpi...@apple.com Date 2011-10-13 18:01:45 -0700 (Thu, 13 Oct 2011) Log Message Rubber stamped Stephanie Lewis. DFG_ENABLE() macro was always returning false. * dfg/DFGNode.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGNode.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (97431 => 97432) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-14 00:57:31 UTC (rev 97431) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-14 01:01:45 UTC (rev 97432) @@ -1,3 +1,11 @@ +2011-10-13 Filip Pizlo + +Rubber stamped Stephanie Lewis. + +DFG_ENABLE() macro was always returning false. + +* dfg/DFGNode.h: + 2011-10-13 Gavin Barraclough Speculative build fix for !DFG builds. Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (97431 => 97432) --- trunk/Source/_javascript_Core/dfg/DFGNode.h 2011-10-14 00:57:31 UTC (rev 97431) +++ trunk/Source/_javascript_Core/dfg/DFGNode.h 2011-10-14 01:01:45 UTC (rev 97432) @@ -29,7 +29,7 @@ #if ENABLE(DFG_JIT) /* DFG_ENABLE() - turn on a specific features in the DFG JIT */ -#define DFG_ENABLE(FEATURE) (defined DFG_ENABLE_##DFG_FEATURE && DFG_ENABLE_##DFG_FEATURE) +#define DFG_ENABLE(DFG_FEATURE) (defined DFG_ENABLE_##DFG_FEATURE && DFG_ENABLE_##DFG_FEATURE) // Emit various logging information for debugging, including dumping the dataflow graphs. #define DFG_ENABLE_DEBUG_VERBOSE 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97431] trunk
Title: [97431] trunk
Revision 97431
Author hara...@chromium.org
Date 2011-10-13 17:57:31 -0700 (Thu, 13 Oct 2011)
Log Message
Implement an OverflowEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70017
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/overflow-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
* dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
LayoutTests:
Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
trunk/Source/WebCore/dom/OverflowEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (97430 => 97431)
--- trunk/LayoutTests/ChangeLog 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/LayoutTests/ChangeLog 2011-10-14 00:57:31 UTC (rev 97431)
@@ -1,5 +1,16 @@
2011-10-13 Kentaro Hara
+Implement an OverflowEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=70017
+
+Reviewed by Adam Barth.
+
+Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.
+
+* platform/chromium/test_expectations.txt:
+
+2011-10-13 Kentaro Hara
+
Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97430 => 97431)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-14 00:57:31 UTC (rev 97431)
@@ -92,9 +92,6 @@
BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
-// This will soon be fixed after implementing an OverflowEvent constructor for V8.
-BUGWK69907 : fast/events/constructors/overflow-event-constructor.html = FAIL
-
// According to the Chromium bug, we need to write some sort of workaround for
// how clipboards on Windows work, or something? That doesn't explain why this
// fails for other platforms...
Modified: trunk/Source/WebCore/ChangeLog (97430 => 97431)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 00:57:31 UTC (rev 97431)
@@ -1,3 +1,15 @@
+2011-10-13 Kentaro Hara
+
+Implement an OverflowEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=70017
+
+Reviewed by Adam Barth.
+
+Test: fast/events/constructors/overflow-event-constructor.html
+
+* bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
+* dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
2011-10-13 Anantanarayanan G Iyengar
https://bugs.webkit.org/show_bug.cgi?id=70064
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (97430 => 97431)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-14 00:57:31 UTC (rev 97431)
@@ -39,6 +39,7 @@
#include "ErrorEvent.h"
#include "HashChangeEvent.h"
#include "Node.h"
+#include "OverflowEvent.h"
#include "PageTransitionEvent.h"
#include "PopStateEvent.h"
#include "ProgressEvent.h"
@@ -56,6 +57,7 @@
#include "V8Event.h"
#include "V8HashChangeEvent.h"
#include "V8Node.h"
+#include "V8OverflowEvent.h"
#include "V8PageTransitionEvent.h"
#include "V8PopStateEvent.h"
#include "V8ProgressEvent.h"
@@ -126,6 +128,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_OVERFLOW_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/OverflowEvent.idl (97430 => 97431)
--- trunk/Source/WebCore/dom/OverflowEvent.idl 2011-10-14 00:42:06 UTC (rev 97430)
+++ trunk/Source/WebCore/dom/OverflowEvent.idl 2011-10-14 00:57:31 UTC (rev 97431)
@@ -27,7 +27,7 @@
interface [
CanBeConstructed,
-JSCustomConstructor
+CustomConstructor
] OverflowEvent : Event {
const unsigned short HORIZONTAL = 0;
const unsigned short VERTICAL = 1;
___
webkit-changes mailing l
[webkit-changes] [97430] trunk/Source/WebKit2
Title: [97430] trunk/Source/WebKit2
Revision 97430
Author wei...@apple.com
Date 2011-10-13 17:42:06 -0700 (Thu, 13 Oct 2011)
Log Message
Another SnowLeopard build fix.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
(-[WKPasteboardOwner initWithImage:WebCore::]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97429 => 97430)
--- trunk/Source/WebKit2/ChangeLog 2011-10-14 00:37:56 UTC (rev 97429)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-14 00:42:06 UTC (rev 97430)
@@ -1,5 +1,14 @@
2011-10-13 Sam Weinig
+Another SnowLeopard build fix.
+
+* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
+(WebKit::cachedImage):
+(WebKit::WebDragClient::declareAndWriteDragImage):
+(-[WKPasteboardOwner initWithImage:WebCore::]):
+
+2011-10-13 Sam Weinig
+
Fix SnowLeopard build.
* UIProcess/WebPageProxy.cpp:
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm (97429 => 97430)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm 2011-10-14 00:37:56 UTC (rev 97429)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm 2011-10-14 00:42:06 UTC (rev 97430)
@@ -102,14 +102,14 @@
m_page->send(Messages::WebPageProxy::SetDragImage(frame->view()->contentsToWindow(point), handle, linkDrag));
}
-static CachedImage* cachedImage(Element* element)
+static WebCore::CachedImage* cachedImage(Element* element)
{
RenderObject* renderer = element->renderer();
if (!renderer)
return 0;
if (!renderer->isRenderImage())
return 0;
-CachedImage* image = toRenderImage(renderer)->cachedImage();
+WebCore::CachedImage* image = toRenderImage(renderer)->cachedImage();
if (!image || image->errorOccurred())
return 0;
return image;
@@ -128,7 +128,7 @@
Element* coreElement = core(element);
-CachedImage* image = cachedImage(coreElement);
+WebCore::CachedImage* image = cachedImage(coreElement);
NSString *extension = @"";
if (image) {
@@ -225,7 +225,7 @@
_image = 0;
}
-- (id)initWithImage:(CachedImage*)image
+- (id)initWithImage:(WebCore::CachedImage*)image
{
self = [super init];
if (!self)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97429] trunk/Source/WebCore
Title: [97429] trunk/Source/WebCore
Revision 97429
Author infe...@chromium.org
Date 2011-10-13 17:37:56 -0700 (Thu, 13 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70064
The NPObjectWrapper class used by V8 bindings in Chromium to wrap the window
script object was allocating an instance of itself in the NPAllocate
implementation and returning this pointer. It should be returning a pointer
to the wrapped NPObject structure (NPProxyObject). The member function
getUnderlyingNPObject should return 0 if we fail to find the underlying NPObject
for the call. It was incorrectly returning a pointer to the same NPObject in
this case which could cause recursion.
Patch by Anantanarayanan G Iyengar on 2011-10-13
Reviewed by Nate Chapin.
No new tests as there is no change in functionality.
* bindings/v8/NPObjectWrapper.cpp:
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
* bindings/v8/NPObjectWrapper.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/NPObjectWrapper.cpp
trunk/Source/WebCore/bindings/v8/NPObjectWrapper.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97428 => 97429)
--- trunk/Source/WebCore/ChangeLog 2011-10-14 00:35:11 UTC (rev 97428)
+++ trunk/Source/WebCore/ChangeLog 2011-10-14 00:37:56 UTC (rev 97429)
@@ -1,3 +1,24 @@
+2011-10-13 Anantanarayanan G Iyengar
+
+https://bugs.webkit.org/show_bug.cgi?id=70064
+
+The NPObjectWrapper class used by V8 bindings in Chromium to wrap the window
+script object was allocating an instance of itself in the NPAllocate
+implementation and returning this pointer. It should be returning a pointer
+to the wrapped NPObject structure (NPProxyObject). The member function
+getUnderlyingNPObject should return 0 if we fail to find the underlying NPObject
+for the call. It was incorrectly returning a pointer to the same NPObject in
+this case which could cause recursion.
+
+Reviewed by Nate Chapin.
+
+No new tests as there is no change in functionality.
+
+* bindings/v8/NPObjectWrapper.cpp:
+(WebCore::NPObjectWrapper::getObjectForCall):
+(WebCore::NPObjectWrapper::NPAllocate):
+* bindings/v8/NPObjectWrapper.h:
+
2011-10-13 Arthur Hsu
Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
Modified: trunk/Source/WebCore/bindings/v8/NPObjectWrapper.cpp (97428 => 97429)
--- trunk/Source/WebCore/bindings/v8/NPObjectWrapper.cpp 2011-10-14 00:35:11 UTC (rev 97428)
+++ trunk/Source/WebCore/bindings/v8/NPObjectWrapper.cpp 2011-10-14 00:37:56 UTC (rev 97429)
@@ -1,43 +1,43 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "NPObjectWrapper.h"
-
-namespace WebCore {
-
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name o
[webkit-changes] [97428] trunk/Source/WebKit2
Title: [97428] trunk/Source/WebKit2
Revision 97428
Author wei...@apple.com
Date 2011-10-13 17:35:11 -0700 (Thu, 13 Oct 2011)
Log Message
Fix SnowLeopard build.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCursor):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97427 => 97428)
--- trunk/Source/WebKit2/ChangeLog 2011-10-14 00:29:15 UTC (rev 97427)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-14 00:35:11 UTC (rev 97428)
@@ -1,3 +1,11 @@
+2011-10-13 Sam Weinig
+
+Fix SnowLeopard build.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::setCursor):
+* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
+
2011-10-13 Alexey Proskuryakov
[Mac] PDF Documents at epo.org look very blurry
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (97427 => 97428)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-10-14 00:29:15 UTC (rev 97427)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2011-10-14 00:35:11 UTC (rev 97428)
@@ -2642,7 +2642,7 @@
m_pageClient->toolTipChanged(oldToolTip, m_toolTip);
}
-void WebPageProxy::setCursor(const Cursor& cursor)
+void WebPageProxy::setCursor(const WebCore::Cursor& cursor)
{
m_pageClient->setCursor(cursor);
}
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm (97427 => 97428)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm 2011-10-14 00:29:15 UTC (rev 97427)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm 2011-10-14 00:35:11 UTC (rev 97428)
@@ -69,9 +69,9 @@
@interface WKPasteboardOwner : NSObject
{
-CachedResourceHandle _image;
+CachedResourceHandle _image;
}
-- (id)initWithImage:(CachedImage*)image;
+- (id)initWithImage:(WebCore::CachedImage*)image;
@end
namespace WebKit {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97427] trunk/Tools
Title: [97427] trunk/Tools Revision 97427 Author dglaz...@chromium.org Date 2011-10-13 17:29:15 -0700 (Thu, 13 Oct 2011) Log Message land-cowboy should at least check style. https://bugs.webkit.org/show_bug.cgi?id=70073 Reviewed by Adam Barth. * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/tool/commands/download.py Diff Modified: trunk/Tools/ChangeLog (97426 => 97427) --- trunk/Tools/ChangeLog 2011-10-14 00:17:22 UTC (rev 97426) +++ trunk/Tools/ChangeLog 2011-10-14 00:29:15 UTC (rev 97427) @@ -1,3 +1,12 @@ +2011-10-13 Dimitri Glazkov + +land-cowboy should at least check style. +https://bugs.webkit.org/show_bug.cgi?id=70073 + +Reviewed by Adam Barth. + +* Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command. + 2011-10-13 Tony Chang fix regex in layout test times dashboard Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (97426 => 97427) --- trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2011-10-14 00:17:22 UTC (rev 97426) +++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py 2011-10-14 00:29:15 UTC (rev 97427) @@ -118,6 +118,7 @@ steps = [ steps.PrepareChangeLog, steps.EditChangeLog, +steps.CheckStyle, steps.ConfirmDiff, steps.Build, steps.RunTests, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97426] trunk/Source/WebCore
Title: [97426] trunk/Source/WebCore Revision 97426 Author simon...@chromium.org Date 2011-10-13 17:17:22 -0700 (Thu, 13 Oct 2011) Log Message Ensure font loaded before calling Skia to drawPosText in Chrome sandbox https://bugs.webkit.org/show_bug.cgi?id=69370 Patch by Arthur Hsu on 2011-10-13 Reviewed by James Robinson. * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97425 => 97426) --- trunk/Source/WebCore/ChangeLog 2011-10-13 23:51:59 UTC (rev 97425) +++ trunk/Source/WebCore/ChangeLog 2011-10-14 00:17:22 UTC (rev 97426) @@ -1,3 +1,13 @@ +2011-10-13 Arthur Hsu + +Ensure font loaded before calling Skia to drawPosText in Chrome sandbox +https://bugs.webkit.org/show_bug.cgi?id=69370 + +Reviewed by James Robinson. + +* platform/graphics/chromium/FontChromiumWin.cpp: +(WebCore::Font::drawGlyphs): + 2011-10-13 Kentaro Hara Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL Modified: trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp (97425 => 97426) --- trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-13 23:51:59 UTC (rev 97425) +++ trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-14 00:17:22 UTC (rev 97426) @@ -395,6 +395,7 @@ return; HFONT hfont = font->platformData().hfont(); +PlatformSupport::ensureFontLoaded(hfont); // We draw the glyphs in chunks to avoid having to do a heap allocation for // the arrays of characters and advances. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97425] trunk/Source/WebKit/chromium
Title: [97425] trunk/Source/WebKit/chromium
Revision 97425
Author jchaffr...@webkit.org
Date 2011-10-13 16:51:59 -0700 (Thu, 13 Oct 2011)
Log Message
Remove layerX / layerY from the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=70052
Reviewed by Darin Fisher.
* public/WebDOMMouseEvent.h:
* src/WebDOMMouseEvent.cpp:
Just remove the 2 properties without considering the ABI stability.
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDOMMouseEvent.h
trunk/Source/WebKit/chromium/src/WebDOMMouseEvent.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97424 => 97425)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 23:45:43 UTC (rev 97424)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 23:51:59 UTC (rev 97425)
@@ -1,3 +1,14 @@
+2011-10-13 Julien Chaffraix
+
+Remove layerX / layerY from the Chromium API
+https://bugs.webkit.org/show_bug.cgi?id=70052
+
+Reviewed by Darin Fisher.
+
+* public/WebDOMMouseEvent.h:
+* src/WebDOMMouseEvent.cpp:
+Just remove the 2 properties without considering the ABI stability.
+
2011-10-13 Nico Weber
[chromium] Automatically pull clang on `update-webkit --chromium` on mac
Modified: trunk/Source/WebKit/chromium/public/WebDOMMouseEvent.h (97424 => 97425)
--- trunk/Source/WebKit/chromium/public/WebDOMMouseEvent.h 2011-10-13 23:45:43 UTC (rev 97424)
+++ trunk/Source/WebKit/chromium/public/WebDOMMouseEvent.h 2011-10-13 23:51:59 UTC (rev 97425)
@@ -44,8 +44,6 @@
WEBKIT_EXPORT int screenY() const;
WEBKIT_EXPORT int clientX() const;
WEBKIT_EXPORT int clientY() const;
-WEBKIT_EXPORT int layerX();
-WEBKIT_EXPORT int layerY();
WEBKIT_EXPORT int offsetX();
WEBKIT_EXPORT int offsetY();
WEBKIT_EXPORT int pageX() const;
Modified: trunk/Source/WebKit/chromium/src/WebDOMMouseEvent.cpp (97424 => 97425)
--- trunk/Source/WebKit/chromium/src/WebDOMMouseEvent.cpp 2011-10-13 23:45:43 UTC (rev 97424)
+++ trunk/Source/WebKit/chromium/src/WebDOMMouseEvent.cpp 2011-10-13 23:51:59 UTC (rev 97425)
@@ -57,16 +57,6 @@
return constUnwrap()->clientY();
}
-int WebDOMMouseEvent::layerX()
-{
-return unwrap()->layerX();
-}
-
-int WebDOMMouseEvent::layerY()
-{
-return unwrap()->layerY();
-}
-
int WebDOMMouseEvent::offsetX()
{
return unwrap()->offsetX();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97424] trunk/Source/WebCore
Title: [97424] trunk/Source/WebCore
Revision 97424
Author hara...@chromium.org
Date 2011-10-13 16:45:43 -0700 (Thu, 13 Oct 2011)
Log Message
Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
https://bugs.webkit.org/show_bug.cgi?id=69801
As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
Reviewed by Adam Barth.
No new tests, since no change in behavior.
* bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
(GenerateConstructorCallback):
* bindings/scripts/test/TestInterface.idl: Ditto.
* fileapi/FileReader.idl: Ditto.
* p2p/PeerConnection.idl: Ditto.
* page/EventSource.idl: Ditto.
* workers/Worker.idl: Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl
trunk/Source/WebCore/fileapi/FileReader.idl
trunk/Source/WebCore/p2p/PeerConnection.idl
trunk/Source/WebCore/page/EventSource.idl
trunk/Source/WebCore/workers/Worker.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (97423 => 97424)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 23:45:43 UTC (rev 97424)
@@ -1,5 +1,25 @@
2011-10-13 Kentaro Hara
+Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
+https://bugs.webkit.org/show_bug.cgi?id=69801
+
+As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
+We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
+
+Reviewed by Adam Barth.
+
+No new tests, since no change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
+(GenerateConstructorCallback):
+* bindings/scripts/test/TestInterface.idl: Ditto.
+* fileapi/FileReader.idl: Ditto.
+* p2p/PeerConnection.idl: Ditto.
+* page/EventSource.idl: Ditto.
+* workers/Worker.idl: Ditto.
+
+2011-10-13 Kentaro Hara
+
Constructor should not be called if the object is being constructed inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (97423 => 97424)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-13 23:45:43 UTC (rev 97424)
@@ -1548,7 +1548,7 @@
push(@implContent, $parameterCheckString);
my @contextArgument;
-if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") {
+if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") {
push(@contextArgument, "context");
push(@implContent, <
Modified: trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl (97423 => 97424)
--- trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -34,7 +34,6 @@
CanBeConstructed,
CallWith=ScriptExecutionContext,
Constructor(in DOMString str1, in [Optional=CallWithDefaultValue] DOMString str2),
-ConstructorWith=ScriptExecutionContext,
V8ConstructorSetsActiveDOMWrapper,
ConstructorRaisesException
] TestInterface {
Modified: trunk/Source/WebCore/fileapi/FileReader.idl (97423 => 97424)
--- trunk/Source/WebCore/fileapi/FileReader.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/fileapi/FileReader.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -38,7 +38,6 @@
EventTarget,
NoStaticTables,
Constructor,
-ConstructorWith=ScriptExecutionContext,
V8ConstructorSetsActiveDOMWrapper
] FileReader {
// ready states
Modified: trunk/Source/WebCore/p2p/PeerConnection.idl (97423 => 97424)
--- trunk/Source/WebCore/p2p/PeerConnection.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ trunk/Source/WebCore/p2p/PeerConnection.idl 2011-10-13 23:45:43 UTC (rev 97424)
@@ -30,7 +30,7 @@
CanBeConstructed,
ConstructorParameters=2,
Constructor(in DOMString serverConfiguration, in [Callback=FunctionOnly] SignalingCallback signalingCallback),
-ConstructorWith=ScriptExecutionContext,
+CallWith=ScriptExecutionContext,
JSCustomConstructor,
V8ConstructorSetsActiveDOMWrapper,
EventTarget
Modified: trunk/Source/WebCore/page/EventSource.idl (97423 => 97424)
--- trunk/Source/WebCore/page/EventSource.idl 2011-10-13 23:39:11 UTC (rev 97423)
+++ tru
[webkit-changes] [97423] trunk/Source/WebCore
Title: [97423] trunk/Source/WebCore
Revision 97423
Author hara...@chromium.org
Date 2011-10-13 16:39:11 -0700 (Thu, 13 Oct 2011)
Log Message
Constructor should not be called if the object is being constructed inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015
Reviewed by Adam Barth.
Summary: A DOM object can be created from the JS context and from the WebCore context.
Constructor should be called if the object is created from the JS context,
but should not be called if the object is created from the WebCore context.
Details:
- Expected behavior when the object is created from the JS context (e.g. "new Event()"):
(1) V8::constructorCallback() is called.
(2) V8::constructorCallback() calls ::create().
(3) ::create() creates a C++ object.
(4) V8::constructorCallback() calls toV8() for the C++ object.
(5) toV8() wraps the C++ object and returns the wrapped JS object.
- Actual behavior when the object is created from the JS context (e.g. "new Event()"):
As described above (1) - (5). That's fine!!
- Expected behavior when the object is created from the WebCore context.
(e.g. "window.addEventListener("load", function (event) { ... });". In this case,
the Event object is created inside the WebCore context):
(1) WebCore calls ::create().
(2) ::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() wraps the C++ object and returns the wrapped JS object.
- Actual behavior when the object is created from the WebCore context.
(e.g. "window.addEventListener("load", function (event) { ... });"):
(1) WebCore calls ::create().
(2) ::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() can call ::constructorCallback(). (Whether or not toV8() calls
::constructorCallback() depends on the implementation of toV8().)
(5) V8::constructorCallback() calls ::create().
(6) ::create() creates __another__ C++ object.
(7) V8::constructorCallback() calls toV8() for the C++ object.
(8) toV8() wraps the C++ object and returns the wrapped JS object.
This actual behavior definitely causes the following problems:
- Problem1: The object returned to JS is not the object created in (2)
but the object created in (6). However, I do not yet know a test case that causes
some visible bug because of this problem.
- Problem2: In (4), ::constructorCallback() can be called with no argument.
If ::constructorCallback() expects at least one argument, ::constructorCallback()
throws TypeError, resulting in crash. For example, Event caused this problem
when I implemented constructor for Event. Based on the discussion with Dominicc,
we solved this problem by adding the following two lines of code to Event::constructorCallback()
(See here: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp&exact_package=chromium&q=allowallocation&type=cs):
::constructorCallback(...) {
...;
if (AllowAllocation::current())
return args.Holder();
...;
}
This if check means "::constructorCallback() returns immediately if it is called
from the WebCore context".
With these observations, we think that all constructorCallback() should have the above
if check. This patch adds the if check to CodeGeneratorV8.pm. After this patch is landed,
I would like to add the if check to all existing custom V8 constructors.
No new tests, since we could not find a test case that causes some visible bug without the if check.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback): Generates a constructor so that it returns immediately without doing anything if the constructor is called from the WebCore context.
* bindings/scripts/test/V8/V8TestInterface.cpp: Updated the result.
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::V8TestObj::constructorCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97422 => 97423)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 23:38:32 UTC (rev 97422)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 23:39:11 UTC (rev 97423)
@@ -1,5 +1,83 @@
2011-10-13 Kentaro Hara
+Constructor should not be called if the object is being constructed inside WebCore
+https://bugs.webkit.org/show_bug.cgi?id=70015
+
+Reviewed by Adam Barth.
+
+Summary: A DOM object can be created from the JS context and from the WebCore context.
+Constructor should be called if the object is created from the JS context,
+but should not be called if the object is created from the WebCore context.
+
+Details:
+- Expected behavior when the object is created from
[webkit-changes] [97422] trunk/Source/WebKit2
Title: [97422] trunk/Source/WebKit2
Revision 97422
Author a...@apple.com
Date 2011-10-13 16:38:32 -0700 (Thu, 13 Oct 2011)
Log Message
[Mac] PDF Documents at epo.org look very blurry
https://bugs.webkit.org/show_bug.cgi?id=70072
Reviewed by Dan Bernstein.
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent):
Ensure integral coordinates. tracks lifting this limitation.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97421 => 97422)
--- trunk/Source/WebKit2/ChangeLog 2011-10-13 23:37:35 UTC (rev 97421)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-13 23:38:32 UTC (rev 97422)
@@ -1,5 +1,15 @@
2011-10-13 Alexey Proskuryakov
+[Mac] PDF Documents at epo.org look very blurry
+https://bugs.webkit.org/show_bug.cgi?id=70072
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent):
+Ensure integral coordinates. tracks lifting this limitation.
+
+2011-10-13 Alexey Proskuryakov
+
[Mac] Wheel event handler counter is incorrect with PDF views
https://bugs.webkit.org/show_bug.cgi?id=70062
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp (97421 => 97422)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-13 23:37:35 UTC (rev 97421)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-13 23:38:32 UTC (rev 97422)
@@ -280,8 +280,8 @@
int pageTop = 0;
for (size_t i = 0; i < m_pageBoxes.size(); ++i) {
IntRect pageBox = m_pageBoxes[i];
-float extraOffsetForCenteringX = max((m_frameRect.width() - pageBox.width()) / 2.0f, 0.0f);
-float extraOffsetForCenteringY = (m_pageBoxes.size() == 1) ? max((m_frameRect.height() - pageBox.height() + shadowOffsetY) / 2.0f, 0.0f) : 0;
+float extraOffsetForCenteringX = max(roundf((m_frameRect.width() - pageBox.width()) / 2.0f), 0.0f);
+float extraOffsetForCenteringY = (m_pageBoxes.size() == 1) ? max(roundf((m_frameRect.height() - pageBox.height() + shadowOffsetY) / 2.0f), 0.0f) : 0;
if (pageTop > contentRect.maxY())
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97421] trunk/Source/WebKit/efl
Title: [97421] trunk/Source/WebKit/efl
Revision 97421
Author commit-qu...@webkit.org
Date 2011-10-13 16:37:35 -0700 (Thu, 13 Oct 2011)
Log Message
[EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=70002
Patch by Raphael Kubo da Costa on 2011-10-13
Reviewed by Joseph Pecoraro.
Adapt to the changes introduced in r97336 and r97338 by using a vector
of strings instead of a single string in runOpenPanel().
* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runOpenPanel):
* ewk/ewk_private.h:
* ewk/ewk_view.cpp:
(ewk_view_run_open_panel): Change signature; accept a Vector
instead of a char*. Build an Eina_List to pass for child classes.
* ewk/ewk_view.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp
trunk/Source/WebKit/efl/ewk/ewk_private.h
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (97420 => 97421)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-13 23:22:53 UTC (rev 97420)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-13 23:37:35 UTC (rev 97421)
@@ -1,3 +1,21 @@
+2011-10-13 Raphael Kubo da Costa
+
+[EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
+https://bugs.webkit.org/show_bug.cgi?id=70002
+
+Reviewed by Joseph Pecoraro.
+
+Adapt to the changes introduced in r97336 and r97338 by using a vector
+of strings instead of a single string in runOpenPanel().
+
+* WebCoreSupport/ChromeClientEfl.cpp:
+(WebCore::ChromeClientEfl::runOpenPanel):
+* ewk/ewk_private.h:
+* ewk/ewk_view.cpp:
+(ewk_view_run_open_panel): Change signature; accept a Vector
+instead of a char*. Build an Eina_List to pass for child classes.
+* ewk/ewk_view.h:
+
2011-10-13 Leandro Pereira
Unreviewed; revert some changes introduced in r97329 which are
Modified: trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp (97420 => 97421)
--- trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2011-10-13 23:22:53 UTC (rev 97420)
+++ trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp 2011-10-13 23:37:35 UTC (rev 97421)
@@ -428,13 +428,12 @@
void ChromeClientEfl::runOpenPanel(Frame* frame, PassRefPtr prpFileChooser)
{
RefPtr chooser = prpFileChooser;
-bool confirm;
Eina_List* selectedFilenames = 0;
void* filename;
Vector filenames;
-CString accept = chooser->settings().deprecatedAcceptTypes.utf8();
-confirm = ewk_view_run_open_panel(m_view, kit(frame), chooser->settings().allowsMultipleFiles, accept.data(), &selectedFilenames);
+const FileChooserSettings& settings = chooser->settings();
+bool confirm = ewk_view_run_open_panel(m_view, kit(frame), settings.allowsMultipleFiles, settings.acceptMIMETypes, &selectedFilenames);
if (!confirm)
return;
Modified: trunk/Source/WebKit/efl/ewk/ewk_private.h (97420 => 97421)
--- trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-10-13 23:22:53 UTC (rev 97420)
+++ trunk/Source/WebKit/efl/ewk/ewk_private.h 2011-10-13 23:37:35 UTC (rev 97421)
@@ -121,7 +121,7 @@
Eina_Bool ewk_view_should_interrupt_javascript(Evas_Object* o);
uint64_t ewk_view_exceeded_database_quota(Evas_Object* o, Evas_Object* frame, const char* databaseName, uint64_t current_size, uint64_t expected_size);
-Eina_Bool ewk_view_run_open_panel(Evas_Object* o, Evas_Object* frame, Eina_Bool allows_multiple_files, const char* accept_types, Eina_List** selected_filenames);
+Eina_Bool ewk_view_run_open_panel(Evas_Object* ewkView, Evas_Object* frame, bool allowsMultipleFiles, const Vector& acceptMIMETypes, Eina_List** selectedFilenames);
void ewk_view_repaint(Evas_Object* o, Evas_Coord x, Evas_Coord y, Evas_Coord w, Evas_Coord h);
void ewk_view_scroll(Evas_Object* o, Evas_Coord dx, Evas_Coord dy, Evas_Coord sx, Evas_Coord sy, Evas_Coord sw, Evas_Coord sh, Evas_Coord cx, Evas_Coord cy, Evas_Coord cw, Evas_Coord ch, Eina_Bool main_frame);
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (97420 => 97421)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-13 23:22:53 UTC (rev 97420)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-13 23:37:35 UTC (rev 97421)
@@ -3253,30 +3253,37 @@
* @internal
* Open panel to choose a file.
*
- * @param o View.
+ * @param ewkView View.
* @param frame Frame in which operation is required.
- * @param allows_multiple_files @c EINA_TRUE when more than one file may be
- * selected, @c EINA_FALSE otherwise
- * @param accept_types accept mime types
- * @selected_filenames List of files selected.
+ * @param allowsMultipleFiles @c true when more than one file may be selected, @c false otherwise.
+ * @param acceptMIMETypes List of accepted mime types. It is passed to child objects as an Eina_List of char pointers that is freed automatically.
+ * @param selec
[webkit-changes] [97420] trunk/Tools
Title: [97420] trunk/Tools
Revision 97420
Author t...@chromium.org
Date 2011-10-13 16:22:53 -0700 (Thu, 13 Oct 2011)
Log Message
fix regex in layout test times dashboard
https://bugs.webkit.org/show_bug.cgi?id=70059
This fixes the treemapfocus query param.
Reviewed by Ojan Vafai.
* TestResultServer/static-dashboards/treemap.html:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestResultServer/static-dashboards/treemap.html
Diff
Modified: trunk/Tools/ChangeLog (97419 => 97420)
--- trunk/Tools/ChangeLog 2011-10-13 23:16:09 UTC (rev 97419)
+++ trunk/Tools/ChangeLog 2011-10-13 23:22:53 UTC (rev 97420)
@@ -1,3 +1,14 @@
+2011-10-13 Tony Chang
+
+fix regex in layout test times dashboard
+https://bugs.webkit.org/show_bug.cgi?id=70059
+
+This fixes the treemapfocus query param.
+
+Reviewed by Ojan Vafai.
+
+* TestResultServer/static-dashboards/treemap.html:
+
2011-10-13 Beth Dakin
https://bugs.webkit.org/show_bug.cgi?id=70050
Modified: trunk/Tools/TestResultServer/static-dashboards/treemap.html (97419 => 97420)
--- trunk/Tools/TestResultServer/static-dashboards/treemap.html 2011-10-13 23:16:09 UTC (rev 97419)
+++ trunk/Tools/TestResultServer/static-dashboards/treemap.html 2011-10-13 23:22:53 UTC (rev 97420)
@@ -298,7 +298,7 @@
function() {
// FIXME: There's probably a simpler regexp here. Just trying to match ascii + forward-slash.
// e.g. LayoutTests/foo/bar.html
-return (value.match(/^(\w+\/\w*)*/$));
+return (value.match(/^(\w+\/\w*)*$/));
});
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97419] trunk
Title: [97419] trunk
Revision 97419
Author hara...@chromium.org
Date 2011-10-13 16:16:09 -0700 (Thu, 13 Oct 2011)
Log Message
Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/events/constructors/before-load-event-constructor.html
* bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
* dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
LayoutTests:
Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
trunk/Source/WebCore/dom/BeforeLoadEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (97418 => 97419)
--- trunk/LayoutTests/ChangeLog 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 23:16:09 UTC (rev 97419)
@@ -1,3 +1,14 @@
+2011-10-13 Kentaro Hara
+
+Implement a BeforeLoadEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=69980
+
+Reviewed by Adam Barth.
+
+Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.
+
+* platform/chromium/test_expectations.txt:
+
2011-10-13 Dimitri Glazkov
[Chromium] Add a colon to make expectation valid.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97418 => 97419)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:16:09 UTC (rev 97419)
@@ -92,9 +92,6 @@
BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
-// This will soon be fixed after implementing a BeforeLoadEvent constructor for V8.
-BUGWK69893 : fast/events/constructors/before-load-event-constructor.html = FAIL
-
// This will soon be fixed after implementing an OverflowEvent constructor for V8.
BUGWK69907 : fast/events/constructors/overflow-event-constructor.html = FAIL
Modified: trunk/Source/WebCore/ChangeLog (97418 => 97419)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 23:16:09 UTC (rev 97419)
@@ -1,3 +1,15 @@
+2011-10-13 Kentaro Hara
+
+Implement a BeforeLoadEvent constructor for V8
+https://bugs.webkit.org/show_bug.cgi?id=69980
+
+Reviewed by Adam Barth.
+
+Test: fast/events/constructors/before-load-event-constructor.html
+
+* bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
+* dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
+
2011-10-13 Joshua Bell
make IDBFactory.open wait for pending setVersion transactions to complete
Modified: trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp (97418 => 97419)
--- trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp 2011-10-13 23:16:09 UTC (rev 97419)
@@ -31,6 +31,7 @@
#include "config.h"
#include "EventConstructors.h"
+#include "BeforeLoadEvent.h"
#include "CloseEvent.h"
#include "CustomEvent.h"
#include "Document.h"
@@ -45,6 +46,7 @@
#include "WebKitTransitionEvent.h"
#include "OptionsObject.h"
+#include "V8BeforeLoadEvent.h"
#include "V8Binding.h"
#include "V8BindingMacros.h"
#include "V8CloseEvent.h"
@@ -123,6 +125,7 @@
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/BeforeLoadEvent.idl (97418 => 97419)
--- trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-10-13 23:14:19 UTC (rev 97418)
+++ trunk/Source/WebCore/dom/BeforeLoadEvent.idl 2011-10-13 23:16:09 UTC (rev 97419)
@@ -28,7 +28,7 @@
interface [
CanBeConstructed,
-JSCustomConstructor
+CustomConstructor
] BeforeLoadEvent : Event {
void initBeforeLoadEvent(in [Optional=CallWithDefaultValue] DOMString type,
in [Optional=CallWithDefaultValue] boolean canBubble,
___
webkit-changes mailing list
[webkit-changes] [97418] trunk/LayoutTests
Title: [97418] trunk/LayoutTests Revision 97418 Author dglaz...@chromium.org Date 2011-10-13 16:14:19 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Add a colon to make expectation valid. * platform/chromium/test_expectations.txt: Jeez. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97417 => 97418) --- trunk/LayoutTests/ChangeLog 2011-10-13 23:08:13 UTC (rev 97417) +++ trunk/LayoutTests/ChangeLog 2011-10-13 23:14:19 UTC (rev 97418) @@ -1,3 +1,9 @@ +2011-10-13 Dimitri Glazkov + +[Chromium] Add a colon to make expectation valid. + +* platform/chromium/test_expectations.txt: Jeez. + 2011-10-13 Joshua Bell make IDBFactory.open wait for pending setVersion transactions to complete Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97417 => 97418) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:08:13 UTC (rev 97417) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 23:14:19 UTC (rev 97418) @@ -3813,4 +3813,4 @@ // These all will timeout, because we are lacking a hook that signals test completion. BUGWK70066 SKIP : fast/hidpi = TIMEOUT -BUGWK70069 http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php = MISSING +BUGWK70069 : http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php = MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97417] trunk
Title: [97417] trunk Revision 97417 Author commit-qu...@webkit.org Date 2011-10-13 16:08:13 -0700 (Thu, 13 Oct 2011) Log Message make IDBFactory.open wait for pending setVersion transactions to complete https://bugs.webkit.org/show_bug.cgi?id=69307 Patch by Joshua Bell on 2011-10-13 Reviewed by Tony Chang. Source/WebCore: Added a queue of pending open calls, similar to the queue of pending setVersion calls. Ensure pending calls are processed in the correct order when transactions complete. Tests: storage/indexeddb/open-close-version.html storage/indexeddb/two-version-changes.html storage/indexeddb/version-change-exclusive.html * storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create): (WebCore::IDBDatabaseBackendImpl::PendingOpenCall::callbacks): (WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall): (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transactionStarted): (WebCore::IDBDatabaseBackendImpl::transactionFinished): (WebCore::IDBDatabaseBackendImpl::processPendingCalls): (WebCore::IDBDatabaseBackendImpl::openConnection): (WebCore::IDBDatabaseBackendImpl::close): * storage/IDBDatabaseBackendImpl.h: * storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): * storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::start): (WebCore::IDBTransactionBackendImpl::commit): LayoutTests: Some tests marked FAIL due to crbug.com/100123 * storage/indexeddb/open-close-version-expected.txt: Added. * storage/indexeddb/open-close-version.html: Added. * storage/indexeddb/two-version-changes-expected.txt: Added. * storage/indexeddb/two-version-changes.html: Added. * storage/indexeddb/version-change-exclusive-expected.txt: Added. * storage/indexeddb/version-change-exclusive.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/storage/IDBDatabaseBackendImpl.cpp trunk/Source/WebCore/storage/IDBDatabaseBackendImpl.h trunk/Source/WebCore/storage/IDBFactoryBackendImpl.cpp trunk/Source/WebCore/storage/IDBTransactionBackendImpl.cpp Added Paths trunk/LayoutTests/storage/indexeddb/open-close-version-expected.txt trunk/LayoutTests/storage/indexeddb/open-close-version.html trunk/LayoutTests/storage/indexeddb/two-version-changes-expected.txt trunk/LayoutTests/storage/indexeddb/two-version-changes.html trunk/LayoutTests/storage/indexeddb/version-change-exclusive-expected.txt trunk/LayoutTests/storage/indexeddb/version-change-exclusive.html Diff Modified: trunk/LayoutTests/ChangeLog (97416 => 97417) --- trunk/LayoutTests/ChangeLog 2011-10-13 22:54:02 UTC (rev 97416) +++ trunk/LayoutTests/ChangeLog 2011-10-13 23:08:13 UTC (rev 97417) @@ -1,3 +1,19 @@ +2011-10-13 Joshua Bell + +make IDBFactory.open wait for pending setVersion transactions to complete +https://bugs.webkit.org/show_bug.cgi?id=69307 + +Reviewed by Tony Chang. + +Some tests marked FAIL due to crbug.com/100123 + +* storage/indexeddb/open-close-version-expected.txt: Added. +* storage/indexeddb/open-close-version.html: Added. +* storage/indexeddb/two-version-changes-expected.txt: Added. +* storage/indexeddb/two-version-changes.html: Added. +* storage/indexeddb/version-change-exclusive-expected.txt: Added. +* storage/indexeddb/version-change-exclusive.html: Added. + 2011-10-13 Dimitri Glazkov https://bugs.webkit.org/show_bug.cgi?id=70069 Added: trunk/LayoutTests/storage/indexeddb/open-close-version-expected.txt (0 => 97417) --- trunk/LayoutTests/storage/indexeddb/open-close-version-expected.txt (rev 0) +++ trunk/LayoutTests/storage/indexeddb/open-close-version-expected.txt 2011-10-13 23:08:13 UTC (rev 97417) @@ -0,0 +1,103 @@ +Test interleaved open/close/setVersion calls in various permutations + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB; +PASS indexedDB == null is false + +TEST: setVersion blocked on open handles +window.dbname = 'test1'; window.ver = 1; window.steps = [] +'h1.open' +'h1.open.onsuccess' +'h2.open' +'h2.open.onsuccess' +'h1.setVersion' +'h2.onversionchange' +h2 closing, but not immediately +'h1.setVersion.onblocked' +'h2.close' +'h1.setVersion.onsuccess' +'h1.setVersion.transaction-complete' +PASS window.steps.toString() is "h1.open,h1.open.onsuccess,h2.open,h2.open.onsuccess,h1.setVersion,h2.onversionchange,h1.setVersion.onblocked,h2.close,h1.setVersion.onsuccess,h1.setVersion.transaction-complete" + +TEST: setVersion not blocked if handle closed immediately +window.dbname = 'test2'; window.ver = 1; window.steps = [] +'h1.open' +'h1.open.onsuccess' +'h2.open' +'h2.open.onsuccess' +'h1.setVersion' +'h2.onversionchange' +h2 closing immediately
[webkit-changes] [97416] trunk/LayoutTests
Title: [97416] trunk/LayoutTests Revision 97416 Author dglaz...@chromium.org Date 2011-10-13 15:54:02 -0700 (Thu, 13 Oct 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=70069 REGRESSION (r63637): [Chromium] http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php reports as MISSING results. * platform/chromium/test_expectations.txt: Added expectations. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97415 => 97416) --- trunk/LayoutTests/ChangeLog 2011-10-13 22:51:44 UTC (rev 97415) +++ trunk/LayoutTests/ChangeLog 2011-10-13 22:54:02 UTC (rev 97416) @@ -1,5 +1,12 @@ 2011-10-13 Dimitri Glazkov +https://bugs.webkit.org/show_bug.cgi?id=70069 +REGRESSION (r63637): [Chromium] http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php reports as MISSING results. + +* platform/chromium/test_expectations.txt: Added expectations. + +2011-10-13 Dimitri Glazkov + Tweaking moar expectations. * platform/chromium/test_expectations.txt: Tweakage. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97415 => 97416) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 22:51:44 UTC (rev 97415) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 22:54:02 UTC (rev 97416) @@ -3813,3 +3813,4 @@ // These all will timeout, because we are lacking a hook that signals test completion. BUGWK70066 SKIP : fast/hidpi = TIMEOUT +BUGWK70069 http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php = MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97415] trunk/Source/WebKit/chromium
Title: [97415] trunk/Source/WebKit/chromium
Revision 97415
Author tha...@chromium.org
Date 2011-10-13 15:51:44 -0700 (Thu, 13 Oct 2011)
Log Message
[chromium] Automatically pull clang on `update-webkit --chromium` on mac
https://bugs.webkit.org/show_bug.cgi?id=70058
Reviewed by Adam Barth.
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97414 => 97415)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 22:39:24 UTC (rev 97414)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 22:51:44 UTC (rev 97415)
@@ -1,3 +1,12 @@
+2011-10-13 Nico Weber
+
+[chromium] Automatically pull clang on `update-webkit --chromium` on mac
+https://bugs.webkit.org/show_bug.cgi?id=70058
+
+Reviewed by Adam Barth.
+
+* DEPS:
+
2011-10-13 John Knottenbelt
[Chromium] Allow building without speech input enabled.
Modified: trunk/Source/WebKit/chromium/DEPS (97414 => 97415)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-13 22:39:24 UTC (rev 97414)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-13 22:51:44 UTC (rev 97415)
@@ -204,6 +204,11 @@
hooks = [
{
+# Pull clang on mac.
+"pattern": ".",
+"action": ["python", "tools/clang/scripts/update.py", "--mac-only"],
+ },
+ {
# A change to any file in this directory should run the gyp generator.
'pattern': '.',
'action': ['python', 'gyp_webkit'],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97414] trunk/LayoutTests
Title: [97414] trunk/LayoutTests Revision 97414 Author dglaz...@chromium.org Date 2011-10-13 15:39:24 -0700 (Thu, 13 Oct 2011) Log Message Tweaking moar expectations. * platform/chromium/test_expectations.txt: Tweakage. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97413 => 97414) --- trunk/LayoutTests/ChangeLog 2011-10-13 22:34:34 UTC (rev 97413) +++ trunk/LayoutTests/ChangeLog 2011-10-13 22:39:24 UTC (rev 97414) @@ -1,3 +1,9 @@ +2011-10-13 Dimitri Glazkov + +Tweaking moar expectations. + +* platform/chromium/test_expectations.txt: Tweakage. + 2011-10-13 Beth Dakin https://bugs.webkit.org/show_bug.cgi?id=70050 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97413 => 97414) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 22:34:34 UTC (rev 97413) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 22:39:24 UTC (rev 97414) @@ -3800,14 +3800,6 @@ // New failures from WebKit r51577 BUGCR29164 WIN LINUX : fast/frames/sandboxed-iframe-plugins.html = TEXT -// We need to upstream new test expectations for these after fixing some -// V8 bugs. Keeping here until we are sure that the push with the new GC -// stays in. -BUG_RICOW : fast/js/array-functions-non-arrays.html = TEXT -BUG_RICOW : fast/js/array-prototype-properties.html = TEXT -BUG_RICOW : fast/js/kde/RegExp.html = TEXT -BUG_RICOW : fast/js/toString-overrides.html = TEXT - BUGWK69998 LINUX WIN : plugins/refcount-leaks.html = PASS TEXT BUGWK70001 LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL MISSING // Randon crash in fast/canvas. @@ -3818,3 +3810,6 @@ BUGWK70013 WIN GPU : fast/canvas/canvas-arc-connecting-line.html = CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-fillPath-pattern-shadow.html = CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = CRASH + +// These all will timeout, because we are lacking a hook that signals test completion. +BUGWK70066 SKIP : fast/hidpi = TIMEOUT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97413] trunk/Source/WebCore
Title: [97413] trunk/Source/WebCore
Revision 97413
Author cmar...@apple.com
Date 2011-10-13 15:34:34 -0700 (Thu, 13 Oct 2011)
Log Message
Leopard build fix
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97412 => 97413)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 22:30:05 UTC (rev 97412)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 22:34:34 UTC (rev 97413)
@@ -1,3 +1,11 @@
+2011-10-13 Chris Marrin
+
+Fix Leopard build
+
+Unreviewed.
+
+* platform/graphics/DisplayRefreshMonitor.h: Added.
+
2011-10-12 Chris Marrin
Sync requestAnimationFrame callback to CVDisplayLink on Mac
Modified: trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h (97412 => 97413)
--- trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h 2011-10-13 22:30:05 UTC (rev 97412)
+++ trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h 2011-10-13 22:34:34 UTC (rev 97413)
@@ -41,8 +41,8 @@
// Abstract virtual client which receives refresh fired messages on the main thread
//
class DisplayRefreshMonitorClient {
-friend DisplayRefreshMonitor;
-friend DisplayRefreshMonitorManager;
+friend class DisplayRefreshMonitor;
+friend class DisplayRefreshMonitorManager;
public:
DisplayRefreshMonitorClient();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97412] trunk/Source/JavaScriptCore
Title: [97412] trunk/Source/_javascript_Core
Revision 97412
Author barraclo...@apple.com
Date 2011-10-13 15:30:05 -0700 (Thu, 13 Oct 2011)
Log Message
Speculative build fix for !DFG builds.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JIT.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97411 => 97412)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-13 22:25:05 UTC (rev 97411)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-13 22:30:05 UTC (rev 97412)
@@ -1,3 +1,10 @@
+2011-10-13 Gavin Barraclough
+
+Speculative build fix for !DFG builds.
+
+* jit/JIT.cpp:
+(JSC::JIT::privateCompile):
+
2011-10-13 Oliver Hunt
Fix performance of ValueToInt32 node when predicting double
Modified: trunk/Source/_javascript_Core/jit/JIT.cpp (97411 => 97412)
--- trunk/Source/_javascript_Core/jit/JIT.cpp 2011-10-13 22:25:05 UTC (rev 97411)
+++ trunk/Source/_javascript_Core/jit/JIT.cpp 2011-10-13 22:30:05 UTC (rev 97412)
@@ -557,10 +557,12 @@
Jump registerFileCheck;
if (m_codeBlock->codeType() == FunctionCode) {
+#if ENABLE(DFG_JIT)
#if DFG_ENABLE(SUCCESS_STATS)
static SamplingCounter counter("orignalJIT");
emitCount(counter);
#endif
+#endif
#if ENABLE(VALUE_PROFILER)
ASSERT(m_bytecodeOffset == (unsigned)-1);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97411] trunk/Source/WebKit2
Title: [97411] trunk/Source/WebKit2
Revision 97411
Author a...@apple.com
Date 2011-10-13 15:25:05 -0700 (Thu, 13 Oct 2011)
Log Message
[Mac] Wheel event handler counter is incorrect with PDF views
https://bugs.webkit.org/show_bug.cgi?id=70062
Reviewed by Dan Bernstein.
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::didAddVerticalScrollbar): Added forgotten override for vertical case.
(WebKit::BuiltInPDFView::willRemoveVerticalScrollbar): Ditto.
(WebKit::BuiltInPDFView::createScrollbar): Notify self, do not make a shortcut to ScrollAnimator.
(WebKit::BuiltInPDFView::destroyScrollbar): Ditto.
(WebKit::BuiltInPDFView::destroy): Actually destroy the scrollbars.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97410 => 97411)
--- trunk/Source/WebKit2/ChangeLog 2011-10-13 22:23:47 UTC (rev 97410)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-13 22:25:05 UTC (rev 97411)
@@ -1,3 +1,18 @@
+2011-10-13 Alexey Proskuryakov
+
+[Mac] Wheel event handler counter is incorrect with PDF views
+https://bugs.webkit.org/show_bug.cgi?id=70062
+
+Reviewed by Dan Bernstein.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.h:
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+(WebKit::BuiltInPDFView::didAddVerticalScrollbar): Added forgotten override for vertical case.
+(WebKit::BuiltInPDFView::willRemoveVerticalScrollbar): Ditto.
+(WebKit::BuiltInPDFView::createScrollbar): Notify self, do not make a shortcut to ScrollAnimator.
+(WebKit::BuiltInPDFView::destroyScrollbar): Ditto.
+(WebKit::BuiltInPDFView::destroy): Actually destroy the scrollbars.
+
2011-10-12 Chris Marrin
Sync requestAnimationFrame callback to CVDisplayLink on Mac
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp (97410 => 97411)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-13 22:23:47 UTC (rev 97410)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp 2011-10-13 22:25:05 UTC (rev 97411)
@@ -142,14 +142,28 @@
pluginView->frame()->document()->didRemoveWheelEventHandler();
}
+void BuiltInPDFView::didAddVerticalScrollbar(Scrollbar* scrollbar)
+{
+pluginView()->frame()->document()->didAddWheelEventHandler();
+ScrollableArea::didAddVerticalScrollbar(scrollbar);
+}
+
+void BuiltInPDFView::willRemoveVerticalScrollbar(Scrollbar* scrollbar)
+{
+ScrollableArea::willRemoveVerticalScrollbar(scrollbar);
+// FIXME: Maybe need a separate ScrollableArea::didRemoveHorizontalScrollbar callback?
+if (PluginView* pluginView = this->pluginView())
+pluginView->frame()->document()->didRemoveWheelEventHandler();
+}
+
PassRefPtr BuiltInPDFView::createScrollbar(ScrollbarOrientation orientation)
{
// FIXME: Support custom scrollbar styles.
RefPtr widget = Scrollbar::createNativeScrollbar(this, orientation, RegularScrollbar);
if (orientation == HorizontalScrollbar)
-scrollAnimator()->didAddHorizontalScrollbar(widget.get());
+didAddHorizontalScrollbar(widget.get());
else
-scrollAnimator()->didAddVerticalScrollbar(widget.get());
+didAddVerticalScrollbar(widget.get());
pluginView()->frame()->view()->addChild(widget.get());
return widget.release();
}
@@ -161,9 +175,9 @@
return;
if (orientation == HorizontalScrollbar)
-scrollAnimator()->willRemoveHorizontalScrollbar(scrollbar.get());
+willRemoveHorizontalScrollbar(scrollbar.get());
else
-scrollAnimator()->willRemoveVerticalScrollbar(scrollbar.get());
+willRemoveVerticalScrollbar(scrollbar.get());
scrollbar->removeFromParent();
scrollbar->disconnectFromScrollableArea();
@@ -214,10 +228,8 @@
if (m_page)
m_page->removeScrollableArea(this);
-if (m_horizontalScrollbar)
-willRemoveHorizontalScrollbar(m_horizontalScrollbar.get());
-if (m_verticalScrollbar)
-willRemoveVerticalScrollbar(m_verticalScrollbar.get());
+destroyScrollbar(HorizontalScrollbar);
+destroyScrollbar(VerticalScrollbar);
}
void BuiltInPDFView::paint(GraphicsContext* graphicsContext, const IntRect& dirtyRectInWindowCoordinates)
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h (97410 => 97411)
--- trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h 2011-10-13 22:23:47 UTC (rev 97410)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h 2011-10-13 22:25:05 UTC (rev 97411)
@@ -56,6 +56,8 @@
void updateScrollbars();
void didAddHorizontalScrollbar(WebCore::Scrollbar*);
void willRemoveHorizontalScrollbar(WebCore::Scrollbar*);
+vo
[webkit-changes] [97410] trunk/Source/JavaScriptCore
Title: [97410] trunk/Source/_javascript_Core
Revision 97410
Author oli...@apple.com
Date 2011-10-13 15:23:47 -0700 (Thu, 13 Oct 2011)
Log Message
Fix performance of ValueToInt32 node when predicting double
https://bugs.webkit.org/show_bug.cgi?id=70063
Reviewed by Filip Pizlo.
Currently we fail to inline double to int conversion when
performing a ValueToInt32 operation on a value we predict
to be a double.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
Apply correct filter for the double prediction path
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
Support double parameters even when value has been spilled.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
Moved old valueToInt32 code to this function, and added
path for double prediction
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Made the two implementations of ValueToInt32 call a single
shared compileValueToInt32 function.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97409 => 97410)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-13 22:11:36 UTC (rev 97409)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-13 22:23:47 UTC (rev 97410)
@@ -1,3 +1,34 @@
+2011-10-13 Oliver Hunt
+
+Fix performance of ValueToInt32 node when predicting double
+https://bugs.webkit.org/show_bug.cgi?id=70063
+
+Reviewed by Filip Pizlo.
+
+Currently we fail to inline double to int conversion when
+performing a ValueToInt32 operation on a value we predict
+to be a double.
+
+* dfg/DFGAbstractState.cpp:
+(JSC::DFG::AbstractState::execute):
+ Apply correct filter for the double prediction path
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+* dfg/DFGJITCodeGenerator64.cpp:
+(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
+ Support double parameters even when value has been spilled.
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileValueToInt32):
+ Moved old valueToInt32 code to this function, and added
+ path for double prediction
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+ Made the two implementations of ValueToInt32 call a single
+ shared compileValueToInt32 function.
+
2011-10-13 Chris Marrin
Sync requestAnimationFrame callback to CVDisplayLink on Mac
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp (97409 => 97410)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-10-13 22:11:36 UTC (rev 97409)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp 2011-10-13 22:23:47 UTC (rev 97410)
@@ -212,8 +212,12 @@
break;
case ValueToInt32:
-if (!m_graph[node.child1()].shouldNotSpeculateInteger())
-forNode(node.child1()).filter(PredictInt32);
+if (!m_graph[node.child1()].shouldNotSpeculateInteger()) {
+if (m_graph[node.child1()].shouldSpeculateDouble())
+forNode(node.child1()).filter(PredictNumber);
+else
+forNode(node.child1()).filter(PredictInt32);
+}
forNode(nodeIndex).set(PredictInt32);
break;
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (97409 => 97410)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-13 22:11:36 UTC (rev 97409)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-13 22:23:47 UTC (rev 97410)
@@ -374,7 +374,7 @@
}
GenerationInfo& childInfo = m_generationInfo[at(node.child1()).virtualRegister()];
-if (isJSDouble(childInfo.registerFormat())) {
+if (childInfo.isJSDouble()) {
DoubleOperand op1(this, node.child1());
GPRTemporary result(this);
FPRReg fpr = op1.fpr();
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp (97409 => 97410)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator64.cpp 2011-10-13 22:11:3
[webkit-changes] [97409] trunk/Source/WebKit/qt
Title: [97409] trunk/Source/WebKit/qt
Revision 97409
Author commit-qu...@webkit.org
Date 2011-10-13 15:11:36 -0700 (Thu, 13 Oct 2011)
Log Message
[Qt] GeolocationClient cleanups
https://bugs.webkit.org/show_bug.cgi?id=69737
Patch by Adenilson Cavalcanti on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.
Qt5 has a location module, so no need to use an external
library like Qt Mobility. This patch will allow the GeolocationClientQt
to compile with both Qt5 and Qt4.
* QtWebKit.pro:
* WebCoreSupport/GeolocationClientQt.cpp:
(WebCore::GeolocationClientQt::positionUpdated):
* WebCoreSupport/GeolocationClientQt.h:
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/QtWebKit.pro
trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.h
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (97408 => 97409)
--- trunk/Source/WebKit/qt/ChangeLog 2011-10-13 22:11:13 UTC (rev 97408)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-10-13 22:11:36 UTC (rev 97409)
@@ -1,3 +1,19 @@
+2011-10-13 Adenilson Cavalcanti
+
+[Qt] GeolocationClient cleanups
+https://bugs.webkit.org/show_bug.cgi?id=69737
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Qt5 has a location module, so no need to use an external
+library like Qt Mobility. This patch will allow the GeolocationClientQt
+to compile with both Qt5 and Qt4.
+
+* QtWebKit.pro:
+* WebCoreSupport/GeolocationClientQt.cpp:
+(WebCore::GeolocationClientQt::positionUpdated):
+* WebCoreSupport/GeolocationClientQt.h:
+
2011-10-11 Simon Fraser
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
Modified: trunk/Source/WebKit/qt/QtWebKit.pro (97408 => 97409)
--- trunk/Source/WebKit/qt/QtWebKit.pro 2011-10-13 22:11:13 UTC (rev 97408)
+++ trunk/Source/WebKit/qt/QtWebKit.pro 2011-10-13 22:11:36 UTC (rev 97409)
@@ -287,6 +287,8 @@
}
contains(DEFINES, ENABLE_GEOLOCATION=1) {
+ qt5: QT += location
+
HEADERS += \
$$PWD/WebCoreSupport/GeolocationClientQt.h
SOURCES += \
Modified: trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp (97408 => 97409)
--- trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp 2011-10-13 22:11:13 UTC (rev 97408)
+++ trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.cpp 2011-10-13 22:11:36 UTC (rev 97409)
@@ -37,7 +37,11 @@
#include "qwebpage.h"
#include "qwebpage_p.h"
-using namespace QtMobility;
+#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)
+#include
+#elif QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
+#include
+#endif
namespace WebCore {
@@ -60,7 +64,7 @@
delete this;
}
-void GeolocationClientQt::positionUpdated(const QGeoPositionInfo &geoPosition)
+void GeolocationClientQt::positionUpdated(const QGeoPositionInfo& geoPosition)
{
if (!geoPosition.isValid())
return;
Modified: trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.h (97408 => 97409)
--- trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.h 2011-10-13 22:11:13 UTC (rev 97408)
+++ trunk/Source/WebKit/qt/WebCoreSupport/GeolocationClientQt.h 2011-10-13 22:11:36 UTC (rev 97409)
@@ -27,20 +27,27 @@
#define GeolocationClientQt_h
#include "GeolocationClient.h"
-#include
+
+#include
#include
-// FIXME: Remove usage of "using namespace" in a header file.
-// There is bug in qtMobility signal names are not full qualified when used with namespace
-// QtMobility namespace in slots throws up error and its required to be fixed in qtmobility.
+#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)
+#include
+namespace QtMobility {
+class QGeoPositionInfoSource;
+};
using namespace QtMobility;
+#elif QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
+#include
+class QGeoPositionInfoSource;
+#endif
+
class QWebPage;
namespace WebCore {
-// This class provides a implementation of a GeolocationService for qtWebkit.
-// It uses QtMobility (v1.0.0) location service to get positions
+// This class provides an implementation of a GeolocationService for QtWebkit.
class GeolocationClientQt : public QObject, public GeolocationClient {
Q_OBJECT
@@ -59,13 +66,12 @@
virtual void cancelPermissionRequest(Geolocation*);
private Q_SLOTS:
-// QGeoPositionInfoSource
void positionUpdated(const QGeoPositionInfo&);
private:
const QWebPage* m_page;
RefPtr m_lastPosition;
-QtMobility::QGeoPositionInfoSource* m_location;
+QGeoPositionInfoSource* m_location;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97406] trunk/LayoutTests
Title: [97406] trunk/LayoutTests Revision 97406 Author dglaz...@chromium.org Date 2011-10-13 15:01:15 -0700 (Thu, 13 Oct 2011) Log Message Update expectations after gdi->skia switch. * platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png. * platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added. * platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png: Added. * platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Added. * platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png. * platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Removed. * platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added. * platform/chromium-win/svg/batik/text/textFeatures-expected.png: * platform/chromium-win/svg/css/text-shadow-multiple-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-win/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-win/svg/css/text-shadow-multiple-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/batik/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/batik/text/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/ trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/text/ trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/svg/css/ trunk/LayoutTests/platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/batik/ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/batik/text/ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/css/ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png trunk/LayoutTests/platform/chromium-win-xp/svg/css/ trunk/LayoutTests/platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png trunk/LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (97405 => 97406) --- trunk/LayoutTests/ChangeLog 2011-10-13 21:59:25 UTC (rev 97405) +++ trunk/LayoutTests/ChangeLog 2011-10-13 22:01:15 UTC (rev 97406) @@ -1,3 +1,17 @@ +2011-10-13 Dimitri Glazkov + +Update expectations after gdi->skia switch. + +* platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png. +* platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added. +* platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png: Added. +* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Added. +* platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png. +* platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Removed. +* platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added. +* platform/chromium-win/svg/batik/text/textFeatures-expected.png: +* platform/chromium-win/svg/css/text-shadow-multiple-expected.png: + 2011-10-12 Chris Marrin Sync requestAnimationFrame callback to CVDisplayLink on Mac Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png (Binary files differ) Copied: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png (from rev 97405, trunk/LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png) (Binary files differ) Property changes: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-mac/svg/batik/text/textFeatures-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png (Binary files differ) Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png
[webkit-changes] [97404] trunk/Source/WebCore
Title: [97404] trunk/Source/WebCore Revision 97404 Author infe...@chromium.org Date 2011-10-13 14:52:12 -0700 (Thu, 13 Oct 2011) Log Message Unreviewed. Qt compile fix. * css/CSSFontFaceSource.cpp: include Document.h. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSFontFaceSource.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97403 => 97404) --- trunk/Source/WebCore/ChangeLog 2011-10-13 21:40:02 UTC (rev 97403) +++ trunk/Source/WebCore/ChangeLog 2011-10-13 21:52:12 UTC (rev 97404) @@ -1,3 +1,9 @@ +2011-10-13 Abhishek Arya + +Unreviewed. Qt compile fix. + +* css/CSSFontFaceSource.cpp: include Document.h. + 2011-10-12 Abhishek Arya Register custom fonts at their creation time, Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (97403 => 97404) --- trunk/Source/WebCore/css/CSSFontFaceSource.cpp 2011-10-13 21:40:02 UTC (rev 97403) +++ trunk/Source/WebCore/css/CSSFontFaceSource.cpp 2011-10-13 21:52:12 UTC (rev 97404) @@ -30,6 +30,7 @@ #include "CSSFontFace.h" #include "CSSFontSelector.h" #include "CachedResourceLoader.h" +#include "Document.h" #include "FontCache.h" #include "FontDescription.h" #include "GlyphPageTreeNode.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97403] branches/chromium/874
Title: [97403] branches/chromium/874
Revision 97403
Author infe...@chromium.org
Date 2011-10-13 14:40:02 -0700 (Thu, 13 Oct 2011)
Log Message
Merge 97402 - Source/WebCore: Register custom fonts at their creation time, rather than at retirement time.
BUG=100059
Review URL: http://codereview.chromium.org/8273018
Modified Paths
branches/chromium/874/Source/WebCore/css/CSSFontFace.cpp
branches/chromium/874/Source/WebCore/css/CSSFontFace.h
branches/chromium/874/Source/WebCore/css/CSSFontFaceSource.cpp
branches/chromium/874/Source/WebCore/css/CSSFontSelector.cpp
branches/chromium/874/Source/WebCore/css/CSSFontSelector.h
branches/chromium/874/Source/WebCore/css/CSSSegmentedFontFace.cpp
branches/chromium/874/Source/WebCore/dom/Document.cpp
branches/chromium/874/Source/WebCore/dom/Document.h
Added Paths
branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2-expected.txt
branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2.html
Diff
Copied: branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2-expected.txt (from rev 97402, trunk/LayoutTests/fast/text/custom-font-data-crash2-expected.txt) (0 => 97403)
--- branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2-expected.txt 2011-10-13 21:40:02 UTC (rev 97403)
@@ -0,0 +1 @@
+PASS
Copied: branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2.html (from rev 97402, trunk/LayoutTests/fast/text/custom-font-data-crash2.html) (0 => 97403)
--- branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2.html (rev 0)
+++ branches/chromium/874/LayoutTests/fast/text/custom-font-data-crash2.html 2011-10-13 21:40:02 UTC (rev 97403)
@@ -0,0 +1,33 @@
+
+
+
+@font-face { font-family: A; src: url(); }
+#y { font-family: A; }
+#y:first-letter { content: "A"; }
+
+
+EFGH
+
+
+function finish() {
+document.body.innerHTML = "PASS";
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+}
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+document.designMode = 'on';
+document.execCommand('selectall');
+
+// Let the font load to finish.
+setTimeout("finish()", 50);
+
+
+#y:before { content: "ABCD"; }
+
+
+
\ No newline at end of file
Modified: branches/chromium/874/Source/WebCore/css/CSSFontFace.cpp (97402 => 97403)
--- branches/chromium/874/Source/WebCore/css/CSSFontFace.cpp 2011-10-13 21:37:04 UTC (rev 97402)
+++ branches/chromium/874/Source/WebCore/css/CSSFontFace.cpp 2011-10-13 21:40:02 UTC (rev 97403)
@@ -118,19 +118,6 @@
return 0;
}
-void CSSFontFace::retireCustomFont(SimpleFontData* fontData)
-{
-if (m_segmentedFontFaces.isEmpty()) {
-GlyphPageTreeNode::pruneTreeCustomFontData(fontData);
-delete fontData;
-return;
-}
-
-// Use one of the CSSSegmentedFontFaces' font selector. They all have
-// the same font selector.
-(*m_segmentedFontFaces.begin())->fontSelector()->retireCustomFont(fontData);
-}
-
#if ENABLE(SVG_FONTS)
bool CSSFontFace::hasSVGFontFaceSource() const
{
Modified: branches/chromium/874/Source/WebCore/css/CSSFontFace.h (97402 => 97403)
--- branches/chromium/874/Source/WebCore/css/CSSFontFace.h 2011-10-13 21:37:04 UTC (rev 97402)
+++ branches/chromium/874/Source/WebCore/css/CSSFontFace.h 2011-10-13 21:40:02 UTC (rev 97403)
@@ -63,7 +63,6 @@
void addSource(CSSFontFaceSource*);
void fontLoaded(CSSFontFaceSource*);
-void retireCustomFont(SimpleFontData*);
SimpleFontData* getFontData(const FontDescription&, bool syntheticBold, bool syntheticItalic);
Modified: branches/chromium/874/Source/WebCore/css/CSSFontFaceSource.cpp (97402 => 97403)
--- branches/chromium/874/Source/WebCore/css/CSSFontFaceSource.cpp 2011-10-13 21:37:04 UTC (rev 97402)
+++ branches/chromium/874/Source/WebCore/css/CSSFontFaceSource.cpp 2011-10-13 21:40:02 UTC (rev 97403)
@@ -72,10 +72,6 @@
if (m_fontDataTable.isEmpty())
return;
-HashMap::iterator end = m_fontDataTable.end();
-for (HashMap::iterator it = m_fontDataTable.begin(); it != end; ++it)
-m_face->retireCustomFont(it->second);
-
m_fontDataTable.clear();
}
@@ -194,6 +190,9 @@
SimpleFontData* fontDataRawPtr = fontData.leakPtr();
m_fontDataTable.set(hashKey, fontDataRawPtr);
+ASSERT(fontSelector->document());
+if (Document* doc = fontSelector->document())
+doc->registerCustomFont(fontDataRawPtr);
return fontDataRawPtr;
}
Modified: branches/chromium/874/Source/WebCore/css/CSSFontSelector.cpp (97402 => 97403)
--- branches/chromium/874/Source/WebCore/css/CSSFontSelector.cpp 2011-10-13 21:37:04 UTC (rev 97402)
+++ branches/chromium/874/Source/WebCore/css/CSSFontSelector.cpp 2011-10-13 21:40:02 UTC (rev 97403)
@@ -383,16 +383,6 @@
dispatchInvalidationCall
[webkit-changes] [97402] trunk
Title: [97402] trunk
Revision 97402
Author infe...@chromium.org
Date 2011-10-13 14:37:04 -0700 (Thu, 13 Oct 2011)
Log Message
Source/WebCore: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929
Reviewed by Dan Bernstein.
Test: fast/text/custom-font-data-crash2.html
* css/CSSFontFace.cpp:
* css/CSSFontFace.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSFontFaceSource::getFontData): register custom
font to document's m_customFonts.
* css/CSSFontSelector.cpp:
* css/CSSFontSelector.h: remove function added in r94508,
which is no longer needed. We now register custom fonts
at creation time.
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSSegmentedFontFace::getFontData): register custom
font to document's m_customFonts.
* dom/Document.cpp: Change function names to registerCustomFont
, deleteCustomFonts and local to m_customFont.
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle): yanking out the comment. We
no longer keep retired custom fonts. We clear all custom fonts
on Document destruction.
(WebCore::Document::registerCustomFont):
(WebCore::Document::deleteCustomFonts):
* dom/Document.h:
LayoutTests: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929
Reviewed by Dan Bernstein.
* fast/text/custom-font-data-crash2-expected.txt: Added.
* fast/text/custom-font-data-crash2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFace.cpp
trunk/Source/WebCore/css/CSSFontFace.h
trunk/Source/WebCore/css/CSSFontFaceSource.cpp
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSFontSelector.h
trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
Added Paths
trunk/LayoutTests/fast/text/custom-font-data-crash2-expected.txt
trunk/LayoutTests/fast/text/custom-font-data-crash2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97401 => 97402)
--- trunk/LayoutTests/ChangeLog 2011-10-13 21:28:13 UTC (rev 97401)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 21:37:04 UTC (rev 97402)
@@ -1,3 +1,14 @@
+2011-10-12 Abhishek Arya
+
+Register custom fonts at their creation time,
+rather than at retirement time.
+https://bugs.webkit.org/show_bug.cgi?id=68929
+
+Reviewed by Dan Bernstein.
+
+* fast/text/custom-font-data-crash2-expected.txt: Added.
+* fast/text/custom-font-data-crash2.html: Added.
+
2011-10-13 Simon Fraser
Add results to keep the bots quiet.
Added: trunk/LayoutTests/fast/text/custom-font-data-crash2-expected.txt (0 => 97402)
--- trunk/LayoutTests/fast/text/custom-font-data-crash2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/text/custom-font-data-crash2-expected.txt 2011-10-13 21:37:04 UTC (rev 97402)
@@ -0,0 +1 @@
+PASS
Added: trunk/LayoutTests/fast/text/custom-font-data-crash2.html (0 => 97402)
--- trunk/LayoutTests/fast/text/custom-font-data-crash2.html (rev 0)
+++ trunk/LayoutTests/fast/text/custom-font-data-crash2.html 2011-10-13 21:37:04 UTC (rev 97402)
@@ -0,0 +1,33 @@
+
+
+
+@font-face { font-family: A; src: url(); }
+#y { font-family: A; }
+#y:first-letter { content: "A"; }
+
+
+EFGH
+
+
+function finish() {
+document.body.innerHTML = "PASS";
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+}
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+document.designMode = 'on';
+document.execCommand('selectall');
+
+// Let the font load to finish.
+setTimeout("finish()", 50);
+
+
+#y:before { content: "ABCD"; }
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (97401 => 97402)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 21:28:13 UTC (rev 97401)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 21:37:04 UTC (rev 97402)
@@ -1,3 +1,41 @@
+2011-10-12 Abhishek Arya
+
+Register custom fonts at their creation time,
+rather than at retirement time.
+https://bugs.webkit.org/show_bug.cgi?id=68929
+
+Reviewed by Dan Bernstein.
+
+Test: fast/text/custom-font-data-crash2.html
+
+* css/CSSFontFace.cpp:
+* css/CSSFontFace.h: remove function added in r94508,
+which is no longer needed. We now register custom fonts
+at creation time.
+* css/CSSFontFaceSource.cpp:
+(WebCore::CSSFontFaceSource::pruneTable): no long
[webkit-changes] [97401] trunk/LayoutTests
Title: [97401] trunk/LayoutTests
Revision 97401
Author simon.fra...@apple.com
Date 2011-10-13 14:28:13 -0700 (Thu, 13 Oct 2011)
Log Message
Add results to keep the bots quiet.
* fast/images/color-jpeg-with-color-profile-expected.png: Added.
* fast/images/color-jpeg-with-color-profile-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png
trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97400 => 97401)
--- trunk/LayoutTests/ChangeLog 2011-10-13 21:25:29 UTC (rev 97400)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 21:28:13 UTC (rev 97401)
@@ -1,3 +1,10 @@
+2011-10-13 Simon Fraser
+
+Add results to keep the bots quiet.
+
+* fast/images/color-jpeg-with-color-profile-expected.png: Added.
+* fast/images/color-jpeg-with-color-profile-expected.txt: Added.
+
2011-10-13 Dimitri Glazkov
Tweak flakiness expectation.
Added: trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.txt (0 => 97401)
--- trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.txt 2011-10-13 21:28:13 UTC (rev 97401)
@@ -0,0 +1,7 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderImage {IMG} at (0,0) size 275x207
+ RenderText {#text} at (0,0) size 0x0
Property changes on: trunk/LayoutTests/fast/images/color-jpeg-with-color-profile-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97400] trunk/LayoutTests
Title: [97400] trunk/LayoutTests Revision 97400 Author dglaz...@chromium.org Date 2011-10-13 14:25:29 -0700 (Thu, 13 Oct 2011) Log Message Tweak flakiness expectation. * platform/chromium/test_expectations.txt: Tweaked. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97399 => 97400) --- trunk/LayoutTests/ChangeLog 2011-10-13 21:20:59 UTC (rev 97399) +++ trunk/LayoutTests/ChangeLog 2011-10-13 21:25:29 UTC (rev 97400) @@ -1,5 +1,11 @@ 2011-10-13 Dimitri Glazkov +Tweak flakiness expectation. + +* platform/chromium/test_expectations.txt: Tweaked. + +2011-10-13 Dimitri Glazkov + Add GPU crashes that cropped up. * platform/chromium/test_expectations.txt: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97399 => 97400) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 21:20:59 UTC (rev 97399) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 21:25:29 UTC (rev 97400) @@ -1176,7 +1176,7 @@ // green so new mac regressions are caught much quicker. // (there are a few others marked w/ multiple status like this in other parts of // the file, but they were left there as the comments in those areas are valid.) -BUGCR10384 MAC RELEASE : fast/dom/Window/new-window-opener.html = TEXT +BUGCR10384 SLOW MAC : fast/dom/Window/new-window-opener.html = TEXT PASS // We can support legacy Mac encodings by building platform/text/mac, but we may // not want to. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97399] trunk/Source/WebKit2
Title: [97399] trunk/Source/WebKit2
Revision 97399
Author je...@webkit.org
Date 2011-10-13 14:20:59 -0700 (Thu, 13 Oct 2011)
Log Message
[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
https://bugs.webkit.org/show_bug.cgi?id=70053
Reviewed by Kenneth Rohde Christiansen.
Now we will be aligned with WKError.h and WebError.h by using the shared
and pre-defined enum for error codes and WebError::webkitErrorDomain().
* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97398 => 97399)
--- trunk/Source/WebKit2/ChangeLog 2011-10-13 21:16:27 UTC (rev 97398)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-13 21:20:59 UTC (rev 97399)
@@ -1,5 +1,22 @@
2011-10-13 Jesus Sanchez-Palencia
+[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
+https://bugs.webkit.org/show_bug.cgi?id=70053
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Now we will be aligned with WKError.h and WebError.h by using the shared
+and pre-defined enum for error codes and WebError::webkitErrorDomain().
+
+* WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
+(WebKit::blockedError):
+(WebKit::cannotShowURLError):
+(WebKit::interruptedForPolicyChangeError):
+(WebKit::cannotShowMIMETypeError):
+(WebKit::pluginWillHandleLoadError):
+
+2011-10-13 Jesus Sanchez-Palencia
+
[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
https://bugs.webkit.org/show_bug.cgi?id=70047
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp (97398 => 97399)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp 2011-10-13 21:16:27 UTC (rev 97398)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp 2011-10-13 21:20:59 UTC (rev 97399)
@@ -27,6 +27,8 @@
#include "config.h"
#include "WebErrors.h"
+#include "WKError.h"
+#include "WebError.h"
#include
#include
#include
@@ -38,18 +40,6 @@
namespace WebKit {
-// copied from WebKit/Misc/WebKitErrors[Private].h
-enum {
-WebKitErrorCannotShowMIMEType = 100,
-WebKitErrorCannotShowURL = 101,
-WebKitErrorFrameLoadInterruptedByPolicyChange = 102,
-WebKitErrorCannotUseRestrictedPort =103,
-WebKitErrorCannotFindPlugIn = 200,
-WebKitErrorCannotLoadPlugIn = 201,
-WebKitErrorJavaUnavailable =202,
-WebKitErrorPluginWillHandleLoad = 203
-};
-
ResourceError cancelledError(const ResourceRequest& request)
{
ResourceError error = ResourceError("QtNetwork", QNetworkReply::OperationCanceledError, request.url().string(),
@@ -60,25 +50,25 @@
ResourceError blockedError(const ResourceRequest& request)
{
-return ResourceError("WebKit", WebKitErrorCannotUseRestrictedPort, request.url().string(),
+return ResourceError(WebError::webKitErrorDomain(), kWKErrorCodeCannotUseRestrictedPort, request.url().string(),
QCoreApplication::translate("QWebFrame", "Request blocked", 0, QCoreApplication::UnicodeUTF8));
}
ResourceError cannotShowURLError(const ResourceRequest& request)
{
-return ResourceError("WebKit", WebKitErrorCannotShowURL, request.url().string(),
+return ResourceError(WebError::webKitErrorDomain(), kWKErrorCodeCannotShowURL, request.url().string(),
QCoreApplication::translate("QWebFrame", "Cannot show URL", 0, QCoreApplication::UnicodeUTF8));
}
ResourceError interruptedForPolicyChangeError(const ResourceRequest& request)
{
-return ResourceError("WebKit", WebKitErrorFrameLoadInterruptedByPolicyChange, request.url().string(),
+return ResourceError(WebError::webKitErrorDomain(), kWKErrorCodeFrameLoadInterruptedByPolicyChange, request.url().string(),
QCoreApplication::translate("QWebFrame", "Frame load interrupted by policy change", 0, QCoreApplication::UnicodeUTF8));
}
ResourceError cannotShowMIMETypeError(const ResourceResponse& response)
{
-return ResourceError("WebKit", WebKitErrorCannotShowMIMEType, response.url().string(),
+return ResourceError(WebError::webKitErrorDomain(), kWKErrorCodeCannotShowMIMEType, response.url().string(),
QCoreApplication::translate("QWebFrame", "Cannot show mimetype", 0, QCoreApplication::UnicodeUTF8));
}
@@ -90,7 +80,7 @@
ResourceError pluginWillHandleLoadError(const ResourceResponse& response)
{
-return ResourceError("WebKit", WebKitError
[webkit-changes] [97398] trunk/Source/WebKit2
Title: [97398] trunk/Source/WebKit2 Revision 97398 Author je...@webkit.org Date 2011-10-13 14:16:27 -0700 (Thu, 13 Oct 2011) Log Message [Qt][WK2] WebViews are emitting loadFailed for "private" error codes https://bugs.webkit.org/show_bug.cgi?id=70047 Reviewed by Kenneth Rohde Christiansen. Both QDesktopWebView and QTouchWebView are emitting loadFailed for private errors like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp. We now filter these by not emitting this signal for FrameLoadInterruptedByPolicyChange, PlugInWillHandleLoad and Cancellation, following previous decisions from WebKit 1. * UIProcess/qt/ClientImpl.cpp: (dispatchLoadFailed): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (97397 => 97398) --- trunk/Source/WebKit2/ChangeLog 2011-10-13 21:11:17 UTC (rev 97397) +++ trunk/Source/WebKit2/ChangeLog 2011-10-13 21:16:27 UTC (rev 97398) @@ -1,3 +1,19 @@ +2011-10-13 Jesus Sanchez-Palencia + +[Qt][WK2] WebViews are emitting loadFailed for "private" error codes +https://bugs.webkit.org/show_bug.cgi?id=70047 + +Reviewed by Kenneth Rohde Christiansen. + +Both QDesktopWebView and QTouchWebView are emitting loadFailed for private errors +like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp. + +We now filter these by not emitting this signal for FrameLoadInterruptedByPolicyChange, +PlugInWillHandleLoad and Cancellation, following previous decisions from WebKit 1. + +* UIProcess/qt/ClientImpl.cpp: +(dispatchLoadFailed): + 2011-10-13 Ravi Phaneendra Kasibhatla Implement TextChecker for WebKit2 GTK+ Modified: trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp (97397 => 97398) --- trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp 2011-10-13 21:11:17 UTC (rev 97397) +++ trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp 2011-10-13 21:16:27 UTC (rev 97398) @@ -74,6 +74,11 @@ return; toQtWebPageProxy(clientInfo)->updateNavigationActions(); + +int errorCode = WKErrorGetErrorCode(error); +if (toImpl(error)->platformError().isCancellation() || errorCode == kWKErrorCodeFrameLoadInterruptedByPolicyChange || errorCode == kWKErrorCodePlugInWillHandleLoad) +return; + toQtWebPageProxy(clientInfo)->loadDidFail(QWebErrorPrivate::createQWebError(error)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97397] trunk/LayoutTests
Title: [97397] trunk/LayoutTests Revision 97397 Author dglaz...@chromium.org Date 2011-10-13 14:11:17 -0700 (Thu, 13 Oct 2011) Log Message Add GPU crashes that cropped up. * platform/chromium/test_expectations.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97396 => 97397) --- trunk/LayoutTests/ChangeLog 2011-10-13 21:05:33 UTC (rev 97396) +++ trunk/LayoutTests/ChangeLog 2011-10-13 21:11:17 UTC (rev 97397) @@ -1,5 +1,11 @@ 2011-10-13 Dimitri Glazkov +Add GPU crashes that cropped up. + +* platform/chromium/test_expectations.txt: Added. + +2011-10-13 Dimitri Glazkov + Remove expectations of failure after r97149. * platform/chromium/test_expectations.txt: Yipee. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97396 => 97397) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 21:05:33 UTC (rev 97396) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 21:11:17 UTC (rev 97397) @@ -3815,3 +3815,6 @@ BUGWK70013 WIN GPU : fast/canvas/canvas-strokePath-alpha-shadow.html = PASS CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-arc-360-winding.html = PASS CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-largedraws.html = PASS CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-arc-connecting-line.html = CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-fillPath-pattern-shadow.html = CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-transforms-fillRect-shadow.html = CRASH ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97396] trunk/LayoutTests
Title: [97396] trunk/LayoutTests Revision 97396 Author dglaz...@chromium.org Date 2011-10-13 14:05:33 -0700 (Thu, 13 Oct 2011) Log Message Remove expectations of failure after r97149. * platform/chromium/test_expectations.txt: Yipee. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97395 => 97396) --- trunk/LayoutTests/ChangeLog 2011-10-13 20:58:42 UTC (rev 97395) +++ trunk/LayoutTests/ChangeLog 2011-10-13 21:05:33 UTC (rev 97396) @@ -1,5 +1,11 @@ 2011-10-13 Dimitri Glazkov +Remove expectations of failure after r97149. + +* platform/chromium/test_expectations.txt: Yipee. + +2011-10-13 Dimitri Glazkov + [Chromium] Update expectations after r97378. 2011-10-13 Dimitri Glazkov Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97395 => 97396) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 20:58:42 UTC (rev 97395) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 21:05:33 UTC (rev 97396) @@ -2038,72 +2038,6 @@ BUGCR48859 WIN : fast/inline/continuation-outlines-with-layers-2.html = IMAGE+TEXT -// These should be rebaselined after the patch lands, as we are now drawing -// all text with skia (instead of gdi) and in these cases, we have differences -// in antialiasing (drt specific) or in fractional-baselines (gdi rounds in src -// space, skia rounds in devices space -BUGWK65203 WIN : fast/borders/border-antialiasing.html = IMAGE -BUGWK65203 WIN : fast/reflections/reflection-overflow-hidden.html = IMAGE -BUGWK65203 WIN : fast/repaint/reflection-redraw.html = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-37-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-39-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-40-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-41-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-46-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-60-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-61-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-62-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-63-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-64-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-65-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-66-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-67-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-68-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-69-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-70-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-81-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-82-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/animate-elem-83-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/pservers-grad-07-b.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/struct-frag-02-t.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/text-align-04-b.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/text-align-05-b.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/text-align-06-b.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/text-path-01-b.svg = IMAGE -BUGWK65203 WIN : svg/W3C-SVG-1.1/text-text-05-t.svg = IMAGE -BUGWK65203 WIN : svg/as-image/animated-svg-as-image.html = IMAGE -BUGWK65203 WIN : svg/batik/filters/filterRegions.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/longTextOnPath.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textAnchor.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textFeatures.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textLayout.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textPCDATA.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textProperties.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/textProperties2.svg = IMAGE -BUGWK65203 WIN : svg/batik/text/verticalText.svg = IMAGE -BUGWK65203 WIN : svg/carto.net/textbox.svg = IMAGE -BUGWK65203 WIN : svg/carto.net/window.svg = IMAGE -BUGWK65203 WIN : svg/css/text-shadow-multiple.xhtml = IMAGE -BUGWK65203 WIN : svg/custom/js-late-clipPath-and-object-creation.svg = IMAGE -BUGWK65203 WIN : svg/custom/js-late-clipPath-creation.svg = IMAGE -BUGWK65203 WIN : svg/custom/linking-a-03-b-viewBox.svg = IMAGE -BUGWK65203 WIN : svg/custom/linking-uri-01-b.svg = IMAGE -BUGWK65203 WIN : svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr.html = IMAGE -BUGWK65203 WIN : svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop.html = IMAGE -BUGWK65203 WIN : svg/hixie/mixed/009.xml = IMAGE -BUGWK65203 WIN : svg/text/foreignObject-text-clipping-bug.xml = IMAGE -BUGWK65203 WIN : svg/text/scaling-font-with-geometric-precision.html = IMAGE -BUGWK65203 WIN : svg/text/text-align-01-b.svg = IMAGE -BUGWK65203 WIN : svg/text/text-align-05-b.svg = IMAGE -BUGWK65203 WIN : svg/text/text-align-06-b.svg = IMAGE -BUGWK65203 WIN : svg/text/text-path-01-b.svg = IMAGE -BUGWK65203 WIN
[webkit-changes] [97395] trunk/Source/WebCore
Title: [97395] trunk/Source/WebCore
Revision 97395
Author rn...@webkit.org
Date 2011-10-13 13:58:42 -0700 (Thu, 13 Oct 2011)
Log Message
Crash in DeleteSelectionCommand::handleGeneralDelete
https://bugs.webkit.org/show_bug.cgi?id=70045
Reviewed by Darin Adler.
Exit early when m_upstreamStart is null.
No new tests because we don't have a reduction.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (97394 => 97395)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 20:54:53 UTC (rev 97394)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 20:58:42 UTC (rev 97395)
@@ -1,3 +1,17 @@
+2011-10-13 Ryosuke Niwa
+
+Crash in DeleteSelectionCommand::handleGeneralDelete
+https://bugs.webkit.org/show_bug.cgi?id=70045
+
+Reviewed by Darin Adler.
+
+Exit early when m_upstreamStart is null.
+
+No new tests because we don't have a reduction.
+
+* editing/DeleteSelectionCommand.cpp:
+(WebCore::DeleteSelectionCommand::handleGeneralDelete):
+
2011-10-13 David Hyatt
https://bugs.webkit.org/show_bug.cgi?id=70049
Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp (97394 => 97395)
--- trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2011-10-13 20:54:53 UTC (rev 97394)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp 2011-10-13 20:58:42 UTC (rev 97395)
@@ -408,9 +408,12 @@
void DeleteSelectionCommand::handleGeneralDelete()
{
+if (m_upstreamStart.isNull())
+return;
+
int startOffset = m_upstreamStart.deprecatedEditingOffset();
Node* startNode = m_upstreamStart.deprecatedNode();
-
+
// Never remove the start block unless it's a table, in which case we won't merge content in.
if (startNode == m_startBlock && startOffset == 0 && canHaveChildrenForEditing(startNode) && !startNode->hasTagName(tableTag)) {
startOffset = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97394] trunk/LayoutTests
Title: [97394] trunk/LayoutTests Revision 97394 Author dglaz...@chromium.org Date 2011-10-13 13:54:53 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Update expectations after r97378. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/css2.1/20110323/floating-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/css2.1/20110323/inline-block-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/css2.1/20110323/inline-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-win/css2.1/20110323/floating-replaced-height-008-expected.txt trunk/LayoutTests/platform/chromium-win/css2.1/20110323/inline-block-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-win/css2.1/20110323/inline-block-replaced-height-008-expected.txt trunk/LayoutTests/platform/chromium-win/css2.1/20110323/inline-replaced-height-008-expected.png trunk/LayoutTests/platform/chromium-win/css2.1/20110323/inline-replaced-height-008-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97393 => 97394) --- trunk/LayoutTests/ChangeLog 2011-10-13 20:51:20 UTC (rev 97393) +++ trunk/LayoutTests/ChangeLog 2011-10-13 20:54:53 UTC (rev 97394) @@ -1,5 +1,9 @@ 2011-10-13 Dimitri Glazkov +[Chromium] Update expectations after r97378. + +2011-10-13 Dimitri Glazkov + [Chromium] Update expectations after r97369. * platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97393 => 97394) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 20:51:20 UTC (rev 97393) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 20:54:53 UTC (rev 97394) @@ -3881,112 +3881,3 @@ BUGWK70013 WIN GPU : fast/canvas/canvas-strokePath-alpha-shadow.html = PASS CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-arc-360-winding.html = PASS CRASH BUGWK70013 WIN GPU : fast/canvas/canvas-largedraws.html = PASS CRASH - -BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.composite.transparent.destination-atop.html = TIMEOUT -BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-5.html = TIMEOUT -BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.imageData.create2.tiny.html = TIMEOUT -BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.path.bezierCurveTo.shape.html = TIMEOUT -BUGCR100056 MAC DEBUG : dom/html/level1/core/hc_elementretrieveattrvalue.html = TIMEOUT -BUGCR100056 MAC DEBUG : dom/html/level2/html/HTMLFrameElement03.html = TIMEOUT -BUGCR100056 MAC DEBUG : dom/html/level2/html/HTMLOptionElement08.html = TIMEOUT -BUGCR100056 MAC DEBUG : editing/selection/doubleclick-beside-cr-span.html = TIMEOUT -BUGCR100056 MAC DEBUG : editing/selection/move-by-word-visually-single-space-inline-element.html = TIMEOUT -BUGCR100056 MAC DEBUG : editing/text-iterator/first-letter-word-boundary.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/canvas/canvas-large-fills.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/canvas/webgl/type-conversion-test.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/css/css-selector-deeply-nested.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/dom/Window/new-window-opener.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/dom/body-clone-link-decl-parent-crash.html = TIMEOUT -BUGCR100056 MAC DEBUG : fast/events/before-unload-adopt-subframe-to-outside.html = TIMEOUT -BUGCR100056 MAC DEBUG : http/tests/misc/dns-prefetch-control.html = TIMEOUT -BUGCR100056 WIN DEBUG : editing/execCommand/4580583-1.html = TIMEOUT PASS -BUGCR100056 WIN DEBUG : editing/selection/invalid-in-RenderView.html = TIMEOUT PASS -BUGCR100056 WIN DEBUG : fast/css/css-selector-deeply-nested.html = TIMEOUT PASS -BUGCR100056 WIN DEBUG : fast/dom/HTMLScriptElement
[webkit-changes] [97393] trunk/Source/JavaScriptCore
Title: [97393] trunk/Source/_javascript_Core
Revision 97393
Author barraclo...@apple.com
Date 2011-10-13 13:51:20 -0700 (Thu, 13 Oct 2011)
Log Message
terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell
Rubber stamped by Filip Pizlo
This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97392 => 97393)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-13 20:48:00 UTC (rev 97392)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-13 20:51:20 UTC (rev 97393)
@@ -1,3 +1,16 @@
+2011-10-13 Gavin Barraclough
+
+terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell
+
+Rubber stamped by Filip Pizlo
+
+This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.
+
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
+
2011-10-13 Mark Hahnenberg
De-virtualized JSCell::toNumber
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (97392 => 97393)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-13 20:48:00 UTC (rev 97392)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp 2011-10-13 20:51:20 UTC (rev 97393)
@@ -194,12 +194,15 @@
switch (info.registerFormat()) {
case DataFormatNone:
-case DataFormatCell:
case DataFormatBoolean:
case DataFormatStorage:
// Should have filled, above.
ASSERT_NOT_REACHED();
-
+
+case DataFormatCell:
+terminateSpeculativeExecution();
+return fprAllocate();
+
case DataFormatJSCell:
case DataFormatJS:
case DataFormatJSInteger:
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (97392 => 97393)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-10-13 20:48:00 UTC (rev 97392)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2011-10-13 20:51:20 UTC (rev 97393)
@@ -244,8 +244,11 @@
case DataFormatBoolean: // This type never occurs.
case DataFormatStorage:
ASSERT_NOT_REACHED();
-
+
case DataFormatCell:
+terminateSpeculativeExecution();
+return fprAllocate();
+
case DataFormatJSCell:
case DataFormatJS:
case DataFormatJSBoolean: {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97391] trunk
Title: [97391] trunk
Revision 97391
Author hy...@apple.com
Date 2011-10-13 13:37:28 -0700 (Thu, 13 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70049
[CSS Regions] Add a test of a float being pushed down because it can't fit
next to another float and make sure it re-evaluates its position when it changes
regions as a result of the push.
Reviewed by Sam Weinig.
Source/WebCore:
Added new test in fast/regions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
LayoutTests:
* fast/regions/float-pushed-width-change.html: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.png: Added.
* platform/mac/fast/regions/float-pushed-width-change-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/regions/float-pushed-width-change.html
trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.png
trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97390 => 97391)
--- trunk/LayoutTests/ChangeLog 2011-10-13 20:22:35 UTC (rev 97390)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 20:37:28 UTC (rev 97391)
@@ -1,3 +1,17 @@
+2011-10-13 David Hyatt
+
+https://bugs.webkit.org/show_bug.cgi?id=70049
+
+[CSS Regions] Add a test of a float being pushed down because it can't fit
+next to another float and make sure it re-evaluates its position when it changes
+regions as a result of the push.
+
+Reviewed by Sam Weinig.
+
+* fast/regions/float-pushed-width-change.html: Added.
+* platform/mac/fast/regions/float-pushed-width-change-expected.png: Added.
+* platform/mac/fast/regions/float-pushed-width-change-expected.txt: Added.
+
2011-10-13 Robert Hogan
Platform-specific results for r97378
Added: trunk/LayoutTests/fast/regions/float-pushed-width-change.html (0 => 97391)
--- trunk/LayoutTests/fast/regions/float-pushed-width-change.html (rev 0)
+++ trunk/LayoutTests/fast/regions/float-pushed-width-change.html 2011-10-13 20:37:28 UTC (rev 97391)
@@ -0,0 +1,62 @@
+
+
+
+#content {
+-webkit-flow: "flow1";
+text-align: justify;
+padding: 5px;
+}
+
+#float1 {
+float: left;
+width: 150px;
+height: 100px;
+background-color:green
+}
+
+#float2 {
+float:right;
+width:200px;
+height:30px;
+background-color:orange
+}
+
+#region1, #region2, #region3 {
+border: 1px solid black;
+content: -webkit-from-flow("flow1");
+}
+
+#region1 {
+width: 180px;
+height: 90px;
+}
+
+#region2 {
+width: 400px;
+height: 90px;
+}
+
+#region3 {
+width: 400px;
+height: 90px;
+}
+
+
+In the example below, the green float should be at the top of the first region and on the left. It should spill into region two.
+The orange float should be on the right at the top of region two.
+
+
+
+
+This line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region. This line of text should not get out of the region.
+This line of text should not get out of the region..
+
+
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.txt (0 => 97391)
--- trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/regions/float-pushed-width-change-expected.txt 2011-10-13 20:37:28 UTC (rev 97391)
@@ -0,0 +1,37 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x352
+ RenderBlock {HTML} at (0,0) size 800x352
+RenderBody {BODY} at (8,16) size 784x328
+ RenderBlock {P} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 764x36
+ text run at (0,0) width 764: "In the example below, the green float should be at the top of the first region and on the left. It should spill into region two."
+ text run at (0,18) width 400: "The orange float should be on the right at the top of region two."
+ RenderBlock {DIV} at (0,52) size 784x276
+RenderRegion {DIV} at (0,0) size 182x92 [border: (1px solid #00)]
+RenderRegion {DIV} at (0,92) size 402x92 [border: (
[webkit-changes] [97390] trunk/LayoutTests
Title: [97390] trunk/LayoutTests
Revision 97390
Author rob...@webkit.org
Date 2011-10-13 13:22:35 -0700 (Thu, 13 Oct 2011)
Log Message
Platform-specific results for r97378
Unreviewed, new platform-specific results.
* platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt
trunk/LayoutTests/platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt
trunk/LayoutTests/platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt
trunk/LayoutTests/platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97389 => 97390)
--- trunk/LayoutTests/ChangeLog 2011-10-13 20:18:19 UTC (rev 97389)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 20:22:35 UTC (rev 97390)
@@ -1,3 +1,19 @@
+2011-10-13 Robert Hogan
+
+Platform-specific results for r97378
+
+Unreviewed, new platform-specific results.
+
+* platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
+* platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
+* platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
+* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
+* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
+* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
+* platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
+* platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
+* platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
+
2011-10-13 Ben Wells
Rebaseline for webkit bug 69503
Added: trunk/LayoutTests/platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt (0 => 97390)
--- trunk/LayoutTests/platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt 2011-10-13 20:22:35 UTC (rev 97390)
@@ -0,0 +1,33 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x187
+ RenderBlock {HTML} at (0,0) size 800x187
+RenderBody {BODY} at (8,16) size 784x38
+ RenderBlock {P} at (0,0) size 784x38
+RenderText {#text} at (0,0) size 106x19
+ text run at (0,0) width 106: "There should be "
+RenderInline {STRONG} at (0,0) size 143x19
+ RenderText {#text} at (106,0) size 143x19
+text run at (106,0) width 143: "5 filled green squares"
+RenderText {#text} at (249,0) size 185x19
+ text run at (249,0) width 185: " with the same width and the "
+RenderInline {STRONG} at (0,0) size 80x19
+ RenderText {#text} at (434,0) size 80x19
+text run at (434,0) width 80: "same height"
+RenderText {#text} at (514,0) size 236x19
+ text run at (514,0) width 236: ". The 5 filled green squares should be"
+RenderInline {STRONG} at (0,0) size 57x19
+ RenderText {#text} at (0,19) size 57x19
+text run at (0,19) width 57: "identical"
+RenderText {#text} at (57,19) size 445x19
+ text run at (57,19) width 445: " to each other. This should still remain true even after a window resize."
+ RenderBlock {DIV} at (0,54) size 784x0
+RenderImage {IMG} at (0,0) size 117x117
+RenderImage {IMG} at (117,0) size 5x5
+RenderImage {IMG} at (122,0) size 117x117
+RenderImage {IMG} at (239,0) size 5x5
+RenderImage {IMG} at (244,0) size 117x117
+Render
[webkit-changes] [97388] trunk
Title: [97388] trunk
Revision 97388
Author aba...@webkit.org
Date 2011-10-13 13:03:36 -0700 (Thu, 13 Oct 2011)
Log Message
Move XSTL to script-src in Content-Security-Policy
https://bugs.webkit.org/show_bug.cgi?id=63637
Reviewed by Eric Seidel.
Source/WebCore:
The spec was unclear about how to treat XSLT. My reading was that they
should fall under style-src, but further discussion on the mailing list
settled on using script-src because an XSLT can inject arbitrary DOM
and script into a page, which is more risky than including style.
Tests: http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
LayoutTests:
* http/tests/security/contentSecurityPolicy/xsl-allowed.php:
* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-blocked.php:
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed.php
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked.php
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
Added Paths
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php
Diff
Modified: trunk/LayoutTests/ChangeLog (97387 => 97388)
--- trunk/LayoutTests/ChangeLog 2011-10-13 19:47:27 UTC (rev 97387)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 20:03:36 UTC (rev 97388)
@@ -1,3 +1,18 @@
+2011-10-13 Adam Barth
+
+Move XSTL to script-src in Content-Security-Policy
+https://bugs.webkit.org/show_bug.cgi?id=63637
+
+Reviewed by Eric Seidel.
+
+* http/tests/security/contentSecurityPolicy/xsl-allowed.php:
+* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
+* http/tests/security/contentSecurityPolicy/xsl-blocked.php:
+* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php: Added.
+* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php: Added.
+
2011-10-13 Simon Fraser
Rebase some editing/spelling results for Lion.
Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed.php (97387 => 97388)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed.php 2011-10-13 19:47:27 UTC (rev 97387)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed.php 2011-10-13 20:03:36 UTC (rev 97388)
@@ -1,6 +1,6 @@
header("Content-Type: application/xhtml+xml");
-header("X-WebKit-CSP: style-src *; script-src 'unsafe-inline'");
+header("X-WebKit-CSP: script-src * 'unsafe-inline'");
echo '';
echo '
Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt (97387 => 97388)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt 2011-10-13 19:47:27 UTC (rev 97387)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt 2011-10-13 20:03:36 UTC (rev 97388)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 1: Refused to load style from 'http://127.0.0.1:8000/security/contentSecurityPolicy/resources/style.xsl' because of Content-Security-Policy.
+CONSOLE MESSAGE: line 1: Refused to load script from 'http://127.0.0.1:8000/security/contentSecurityPolicy/resources/style.xsl' because of Content-Security-Policy.
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked.php (97387 => 97388)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked.php 2011-10-13 19:47:27 UTC (rev 97387)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/xsl-blocked.php 2011-10-13 20:03:36 UTC (rev 97388)
@@ -1,6 +1,6 @@
header("Content-Type: application/xhtml+xml");
-header("X-Web
[webkit-changes] [97387] trunk/Source
Title: [97387] trunk/Source
Revision 97387
Author commit-qu...@webkit.org
Date 2011-10-13 12:47:27 -0700 (Thu, 13 Oct 2011)
Log Message
[Qt] QtWebKit build error for Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=69914
In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
But this is meant to be defined in NSGeometry.h under certain preconditions.
Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
met and therefore NSGeometry.h will create several conflicting type definitions.
With this patch we create consistent definitions again.
Due to the order of include files we cannot remove
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.
Patch by Zeno Albisser on 2011-10-13
Reviewed by Andreas Kling.
* WebCore.pro:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebKit/qt/QtWebKit.pro
Diff
Modified: trunk/Source/WebCore/ChangeLog (97386 => 97387)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 19:37:57 UTC (rev 97386)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 19:47:27 UTC (rev 97387)
@@ -1,3 +1,22 @@
+2011-10-13 Zeno Albisser
+
+[Qt] QtWebKit build error for Mac 32bit
+https://bugs.webkit.org/show_bug.cgi?id=69914
+
+In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
+when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
+But this is meant to be defined in NSGeometry.h under certain preconditions.
+Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
+met and therefore NSGeometry.h will create several conflicting type definitions.
+
+With this patch we create consistent definitions again.
+Due to the order of include files we cannot remove
+NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.
+
+Reviewed by Andreas Kling.
+
+* WebCore.pro:
+
2011-10-13 Tom Hudson
Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
Modified: trunk/Source/WebCore/WebCore.pro (97386 => 97387)
--- trunk/Source/WebCore/WebCore.pro 2011-10-13 19:37:57 UTC (rev 97386)
+++ trunk/Source/WebCore/WebCore.pro 2011-10-13 19:47:27 UTC (rev 97387)
@@ -3109,6 +3109,9 @@
platform/mac/WebWindowAnimation.mm
DEFINES+=NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
+contains(CONFIG, "x86") {
+DEFINES+=NS_BUILD_32_LIKE_64
+}
} else: contains(DEFINES, WTF_USE_GSTREAMER=1) {
HEADERS += \
Modified: trunk/Source/WebKit/qt/QtWebKit.pro (97386 => 97387)
--- trunk/Source/WebKit/qt/QtWebKit.pro 2011-10-13 19:37:57 UTC (rev 97386)
+++ trunk/Source/WebKit/qt/QtWebKit.pro 2011-10-13 19:47:27 UTC (rev 97387)
@@ -237,6 +237,9 @@
$$SOURCE_DIR/../WebKitLibraries/
DEFINES+=NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
+contains(CONFIG, "x86") {
+DEFINES+=NS_BUILD_32_LIKE_64
+}
HEADERS += $$PWD/WebCoreSupport/WebSystemInterface.h \
$$PWD/WebCoreSupport/QTKitFullScreenVideoHandler.h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97386] trunk
Title: [97386] trunk
Revision 97386
Author commit-qu...@webkit.org
Date 2011-10-13 12:37:57 -0700 (Thu, 13 Oct 2011)
Log Message
Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
https://bugs.webkit.org/show_bug.cgi?id=69844
Patch by Tom Hudson on 2011-10-13
Reviewed by Simon Fraser.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect): Only process border radius clips #if !PLATFORM(CHROMIUM)
Modified Paths
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Diff
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97385 => 97386)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 19:36:34 UTC (rev 97385)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 19:37:57 UTC (rev 97386)
@@ -3498,6 +3498,12 @@
BUGWK63186 LEOPARD LINUX WIN : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
BUGWK65862 MAC DEBUG SLOW : storage/indexeddb/index-cursor.html = PASS
+// Performance issues with border radius clipping on Chromium not yet resolved
+BUGCR97716 : fast/clip/overflow-border-radius-composited.html = IMAGE
+BUGCR97716 : fast/clip/overflow-border-radius-fixed-position.html = IMAGE
+BUGCR97716 : fast/clip/overflow-border-radius-transformed.html = IMAGE
+BUGCR97716 : fast/clip/overflow-border-radius-combinations.html = IMAGE
+
// Caused by r92618
BUGWK65874 : fast/js/preventExtensions.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (97385 => 97386)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 19:36:34 UTC (rev 97385)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 19:37:57 UTC (rev 97386)
@@ -1,3 +1,13 @@
+2011-10-13 Tom Hudson
+
+Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
+https://bugs.webkit.org/show_bug.cgi?id=69844
+
+Reviewed by Simon Fraser.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::clipToRect): Only process border radius clips #if !PLATFORM(CHROMIUM)
+
2011-10-13 Julien Chaffraix
Deprecate event.layerX and event.layerY in WebKit
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (97385 => 97386)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-10-13 19:36:34 UTC (rev 97385)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-10-13 19:37:57 UTC (rev 97386)
@@ -98,6 +98,12 @@
#include "SVGNames.h"
#endif
+#if PLATFORM(CHROMIUM)
+// FIXME: border radius clipping triggers too-slow path on Chromium
+// https://bugs.webkit.org/show_bug.cgi?id=69866
+#define DISABLE_ROUNDED_CORNER_CLIPPING
+#endif
+
#define MIN_INTERSECT_FOR_REVEAL 32
using namespace std;
@@ -2555,6 +2561,7 @@
m_containsDirtyOverlayScrollbars = false;
}
+#ifndef DISABLE_ROUNDED_CORNER_CLIPPING
static bool inContainingBlockChain(RenderLayer* startLayer, RenderLayer* endLayer)
{
if (startLayer == endLayer)
@@ -2568,6 +2575,7 @@
return false;
}
+#endif
void RenderLayer::clipToRect(RenderLayer* rootLayer, GraphicsContext* context, const LayoutRect& paintDirtyRect, const ClipRect& clipRect,
BorderRadiusClippingRule rule)
@@ -2580,6 +2588,7 @@
if (!clipRect.hasRadius())
return;
+#ifndef DISABLE_ROUNDED_CORNER_CLIPPING
// If the clip rect has been tainted by a border radius, then we have to walk up our layer chain applying the clips from
// any layers with overflow. The condition for being able to apply these clips is that the overflow object be in our
// containing block chain so we check that also.
@@ -2593,6 +2602,7 @@
if (layer == rootLayer)
break;
}
+#endif
}
void RenderLayer::restoreClip(GraphicsContext* p, const LayoutRect& paintDirtyRect, const ClipRect& clipRect)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97385] trunk/Source/WebKit2
Title: [97385] trunk/Source/WebKit2 Revision 97385 Author commit-qu...@webkit.org Date 2011-10-13 12:36:34 -0700 (Thu, 13 Oct 2011) Log Message Implement TextChecker for WebKit2 GTK+ https://bugs.webkit.org/show_bug.cgi?id=68548 Patch by Ravi Phaneendra Kasibhatla on 2011-10-13 Reviewed by Anders Carlsson. Added implementation for all functions in TextCheckerGtk.cpp removing earlier stubbed implementations. Moved couple of API earlier specific to win port to common section and added stubbed implementation of the same for remaining ports of Qt, Efl and Mac. * GNUmakefile.am: Added TextChecker implementation files. * UIProcess/TextChecker.h: Moved spellCheckingEnabled and grammarCheckingEnabled API outside of win port. * UIProcess/efl/TextCheckerEfl.cpp: Stubbed implementation of API which was moved outside win port. * UIProcess/gtk/TextCheckerGtk.cpp: Implementation of all TextChecker API. (WebKit::TextChecker::state): (WebKit::TextChecker::isContinuousSpellCheckingAllowed): (WebKit::TextChecker::setContinuousSpellCheckingEnabled): (WebKit::TextChecker::setGrammarCheckingEnabled): (WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged): (WebKit::TextChecker::grammarCheckingEnabledStateChanged): (WebKit::TextChecker::uniqueSpellDocumentTag): (WebKit::TextChecker::closeSpellDocumentWithTag): (WebKit::TextChecker::checkSpellingOfString): (WebKit::TextChecker::checkGrammarOfString): (WebKit::TextChecker::spellingUIIsShowing): (WebKit::TextChecker::toggleSpellingUIIsShowing): (WebKit::TextChecker::updateSpellingUIWithMisspelledWord): (WebKit::TextChecker::updateSpellingUIWithGrammarString): (WebKit::TextChecker::getGuessesForWord): (WebKit::TextChecker::learnWord): (WebKit::TextChecker::ignoreWord): * UIProcess/mac/TextCheckerMac.mm: Implementation of API which was moved outside win port. * UIProcess/qt/TextCheckerQt.cpp: Stubbed implementation of API which was moved outside win port. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am trunk/Source/WebKit2/UIProcess/TextChecker.h trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp trunk/Source/WebKit2/UIProcess/mac/TextCheckerMac.mm trunk/Source/WebKit2/UIProcess/qt/TextCheckerQt.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (97384 => 97385) --- trunk/Source/WebKit2/ChangeLog 2011-10-13 19:30:41 UTC (rev 97384) +++ trunk/Source/WebKit2/ChangeLog 2011-10-13 19:36:34 UTC (rev 97385) @@ -1,3 +1,38 @@ +2011-10-13 Ravi Phaneendra Kasibhatla + +Implement TextChecker for WebKit2 GTK+ +https://bugs.webkit.org/show_bug.cgi?id=68548 + +Reviewed by Anders Carlsson. + +Added implementation for all functions in TextCheckerGtk.cpp removing earlier stubbed implementations. +Moved couple of API earlier specific to win port to common section and added stubbed implementation +of the same for remaining ports of Qt, Efl and Mac. + +* GNUmakefile.am: Added TextChecker implementation files. +* UIProcess/TextChecker.h: Moved spellCheckingEnabled and grammarCheckingEnabled API outside of win port. +* UIProcess/efl/TextCheckerEfl.cpp: Stubbed implementation of API which was moved outside win port. +* UIProcess/gtk/TextCheckerGtk.cpp: Implementation of all TextChecker API. +(WebKit::TextChecker::state): +(WebKit::TextChecker::isContinuousSpellCheckingAllowed): +(WebKit::TextChecker::setContinuousSpellCheckingEnabled): +(WebKit::TextChecker::setGrammarCheckingEnabled): +(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged): +(WebKit::TextChecker::grammarCheckingEnabledStateChanged): +(WebKit::TextChecker::uniqueSpellDocumentTag): +(WebKit::TextChecker::closeSpellDocumentWithTag): +(WebKit::TextChecker::checkSpellingOfString): +(WebKit::TextChecker::checkGrammarOfString): +(WebKit::TextChecker::spellingUIIsShowing): +(WebKit::TextChecker::toggleSpellingUIIsShowing): +(WebKit::TextChecker::updateSpellingUIWithMisspelledWord): +(WebKit::TextChecker::updateSpellingUIWithGrammarString): +(WebKit::TextChecker::getGuessesForWord): +(WebKit::TextChecker::learnWord): +(WebKit::TextChecker::ignoreWord): +* UIProcess/mac/TextCheckerMac.mm: Implementation of API which was moved outside win port. +* UIProcess/qt/TextCheckerQt.cpp: Stubbed implementation of API which was moved outside win port. + 2011-10-13 Jesus Sanchez-Palencia [Qt][WK2] Implement decidePolicyForResponse in our PolicyClient Modified: trunk/Source/WebKit2/GNUmakefile.am (97384 => 97385) --- trunk/Source/WebKit2/GNUmakefile.am 2011-10-13 19:30:41 UTC (rev 97384) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-10-13 19:36:34 UTC (rev 97385) @@ -48,6 +48,7 @@ $(WebKit2)/UIProcess/API/C/WKFormSubmissionListener.h \ $(WebKit2)/UIProcess/API/C/WKFrame.h \ $(
[webkit-changes] [97383] trunk/LayoutTests/platform/mac/fast/repaint/ region-painting-via-layout-expected.txt
Title: [97383] trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt
Revision 97383
Author hy...@apple.com
Date 2011-10-13 12:29:28 -0700 (Thu, 13 Oct 2011)
Log Message
Fix layout test result on Lion to account for content-order removal patch.
Modified Paths
trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt
Diff
Modified: trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt (97382 => 97383)
--- trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt 2011-10-13 19:24:53 UTC (rev 97382)
+++ trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt 2011-10-13 19:29:28 UTC (rev 97383)
@@ -13,5 +13,5 @@
RenderBlock {DIV} at (0,1000) size 784x200
RenderBlock {DIV} at (0,0) size 784x200 [bgcolor=#008000]
Regions for flow 'flow1'
-RenderRegion {DIV} #region1 with index 0
-RenderRegion {DIV} #region2 with index 0
+RenderRegion {DIV} #region1
+RenderRegion {DIV} #region2
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97381] trunk/Source
Title: [97381] trunk/Source
Revision 97381
Author mhahnenb...@apple.com
Date 2011-10-13 12:24:53 -0700 (Thu, 13 Oct 2011)
Log Message
De-virtualized JSCell::toNumber
https://bugs.webkit.org/show_bug.cgi?id=69858
Reviewed by Sam Weinig.
Source/_javascript_Core:
Removed JSCallbackObject::toNumber because its no longer necessary since
JSObject::toNumber now suffices since we implicitly add valueOf to an object's
prototype whenever a convertToType callback is provided.
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
De-virtualized JSCell::toNumber, JSObject::toNumber, and JSString::toNumber.
* runtime/JSCell.cpp:
(JSC::JSCell::toNumber):
* runtime/JSCell.h:
* runtime/JSObject.h:
* runtime/JSString.h:
Removed JSNotAnObject::toNumber because its result doesn't matter and it implements
defaultValue, therefore JSObject::toNumber can cover its case.
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
Source/_javascript_Glue:
Removed UserObjectImp::toNumber because it's no longer necessary since
JSObject::toNumber can cover this case.
* UserObjectImp.cpp:
* UserObjectImp.h:
Modified Paths
trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp
trunk/Source/_javascript_Core/runtime/JSNotAnObject.h
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Glue/ChangeLog
trunk/Source/_javascript_Glue/UserObjectImp.cpp
trunk/Source/_javascript_Glue/UserObjectImp.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (97380 => 97381)
--- trunk/Source/_javascript_Core/API/JSCallbackObject.h 2011-10-13 19:07:00 UTC (rev 97380)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h 2011-10-13 19:24:53 UTC (rev 97381)
@@ -193,8 +193,6 @@
virtual void getOwnPropertyNames(ExecState*, PropertyNameArray&, EnumerationMode mode = ExcludeDontEnumProperties);
-virtual double toNumber(ExecState*) const;
-
virtual ConstructType getConstructData(ConstructData&);
static ConstructType getConstructData(JSCell*, ConstructData&);
static CallType getCallData(JSCell*, CallData&);
Modified: trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h (97380 => 97381)
--- trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h 2011-10-13 19:07:00 UTC (rev 97380)
+++ trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h 2011-10-13 19:24:53 UTC (rev 97381)
@@ -479,41 +479,6 @@
}
template
-double JSCallbackObject::toNumber(ExecState* exec) const
-{
-// We need this check to guard against the case where this object is rhs of
-// a binary _expression_ where lhs threw an exception in its conversion to
-// primitive
-if (exec->hadException())
-return std::numeric_limits::quiet_NaN();
-JSContextRef ctx = toRef(exec);
-JSObjectRef thisRef = toRef(this);
-
-for (JSClassRef jsClass = classRef(); jsClass; jsClass = jsClass->parentClass)
-if (JSObjectConvertToTypeCallback convertToType = jsClass->convertToType) {
-JSValueRef exception = 0;
-JSValueRef value;
-{
-APICallbackShim callbackShim(exec);
-value = convertToType(ctx, thisRef, kJSTypeNumber, &exception);
-}
-if (exception) {
-throwError(exec, toJS(exec, exception));
-return 0;
-}
-if (!value)
-continue;
-
-JSValue jsValue = toJS(exec, value);
-if (!jsValue.isNumber())
-return std::numeric_limits::quiet_NaN();
-return jsValue.asNumber();
-}
-
-return Parent::toNumber(exec);
-}
-
-template
void JSCallbackObject::setPrivate(void* data)
{
m_callbackObjectData->privateData = data;
Modified: trunk/Source/_javascript_Core/ChangeLog (97380 => 97381)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-13 19:07:00 UTC (rev 97380)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-13 19:24:53 UTC (rev 97381)
@@ -1,3 +1,30 @@
+2011-10-13 Mark Hahnenberg
+
+De-virtualized JSCell::toNumber
+https://bugs.webkit.org/show_bug.cgi?id=69858
+
+Reviewed by Sam Weinig.
+
+
+Removed JSCallbackObject::toNumber because its no longer necessary since
+JSObject::toNumber now suffices since we implicitly add valueOf to an object's
+prototype whenever a convertToType callback is provided.
+* API/JSCallbackObject.h:
+* API/JSCallbackObjectFunctions.h:
+* _javascript_Core.vc
[webkit-changes] [97380] trunk
Title: [97380] trunk Revision 97380 Author jchaffr...@webkit.org Date 2011-10-13 12:07:00 -0700 (Thu, 13 Oct 2011) Log Message Deprecate event.layerX and event.layerY in WebKit https://bugs.webkit.org/show_bug.cgi?id=69951 Reviewed by Darin Adler. Source/WebCore: layerX and layerY were concepts of the old Netscape code that stayed in WebKit for a long time without changes. Now the code is completely wrong and Mozilla has expressed some interest in removing it from their API too. This is a first step in the removal as layerX and layerY are exposed in some APIs. Chromium and Win are fine with removing the property directly, but ObjC needs to deprecate them first. * bindings/objc/PublicDOMInterfaces.h: Mark the API as deprecated. * dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::layerX): (WebCore::MouseRelatedEvent::layerY): * dom/UIEvent.cpp: (WebCore::UIEvent::layerX): (WebCore::UIEvent::layerY): Added a call to warnDeprecatedLayerXYUsage in the previous functions. (WebCore::UIEvent::warnDeprecatedLayerXYUsage): Print a warning in the console about the removal of event.layerX and event.layerY in the near future. * dom/UIEvent.h: Added warnDeprecatedLayerXYUsage. LayoutTests: * fast/dom/Window/window-xy-properties-expected.txt: * fast/events/init-events-expected.txt: * fast/events/mouse-relative-position-expected.txt: * fast/events/mouseclick-target-and-positioning-expected.txt: * fast/events/simulated-click-coords-expected.txt: * jquery/events-expected.txt: Updated those tests with the console messages to keep our existing coverage until we remove the 2 properties. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/Window/window-xy-properties-expected.txt trunk/LayoutTests/fast/events/init-events-expected.txt trunk/LayoutTests/fast/events/mouse-relative-position-expected.txt trunk/LayoutTests/fast/events/mouseclick-target-and-positioning-expected.txt trunk/LayoutTests/fast/events/simulated-click-coords-expected.txt trunk/LayoutTests/jquery/event-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/objc/PublicDOMInterfaces.h trunk/Source/WebCore/dom/MouseRelatedEvent.cpp trunk/Source/WebCore/dom/UIEvent.cpp trunk/Source/WebCore/dom/UIEvent.h Diff Modified: trunk/LayoutTests/ChangeLog (97379 => 97380) --- trunk/LayoutTests/ChangeLog 2011-10-13 19:06:43 UTC (rev 97379) +++ trunk/LayoutTests/ChangeLog 2011-10-13 19:07:00 UTC (rev 97380) @@ -1,3 +1,19 @@ +2011-10-13 Julien Chaffraix + +Deprecate event.layerX and event.layerY in WebKit +https://bugs.webkit.org/show_bug.cgi?id=69951 + +Reviewed by Darin Adler. + +* fast/dom/Window/window-xy-properties-expected.txt: +* fast/events/init-events-expected.txt: +* fast/events/mouse-relative-position-expected.txt: +* fast/events/mouseclick-target-and-positioning-expected.txt: +* fast/events/simulated-click-coords-expected.txt: +* jquery/events-expected.txt: +Updated those tests with the console messages to keep our existing +coverage until we remove the 2 properties. + 2011-10-03 Robert Hogan CSS 2.1 failure: inline-replaced-height-008.htm Modified: trunk/LayoutTests/fast/dom/Window/window-xy-properties-expected.txt (97379 => 97380) --- trunk/LayoutTests/fast/dom/Window/window-xy-properties-expected.txt 2011-10-13 19:06:43 UTC (rev 97379) +++ trunk/LayoutTests/fast/dom/Window/window-xy-properties-expected.txt 2011-10-13 19:07:00 UTC (rev 97380) @@ -1,3 +1,11 @@ +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. +CONSOLE MESSAGE: line 1: event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future. PASS event.clientX is 50 PASS event.clientY is 50 PASS event.pageX is 50 Modified: trunk/LayoutTests/fast/events/init-events-expected.txt (97379 => 97380) --- trunk/LayoutTests/fast/events/init-events-expected.txt 2011-10-13 19:06:43 UTC (rev 97379)
[webkit-changes] [97379] trunk
Title: [97379] trunk
Revision 97379
Author jknot...@chromium.org
Date 2011-10-13 12:06:43 -0700 (Thu, 13 Oct 2011)
Log Message
[Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867
Reviewed by Darin Fisher.
Source/WebKit/chromium:
* src/AssertMatchingEnums.cpp:
* src/WebSpeechInputControllerMockImpl.cpp:
(WebKit::WebSpeechInputControllerMock::create):
* src/WebSpeechInputControllerMockImpl.h:
* src/WebSpeechInputResult.cpp:
Tools:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::addMockSpeechInputResult):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp
trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp
trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h
trunk/Source/WebKit/chromium/src/WebSpeechInputResult.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97378 => 97379)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 19:06:43 UTC (rev 97379)
@@ -1,3 +1,16 @@
+2011-10-13 John Knottenbelt
+
+[Chromium] Allow building without speech input enabled.
+https://bugs.webkit.org/show_bug.cgi?id=69867
+
+Reviewed by Darin Fisher.
+
+* src/AssertMatchingEnums.cpp:
+* src/WebSpeechInputControllerMockImpl.cpp:
+(WebKit::WebSpeechInputControllerMock::create):
+* src/WebSpeechInputControllerMockImpl.h:
+* src/WebSpeechInputResult.cpp:
+
2011-10-13 Peng Huang
[chromium] Add a selectionBounds() method to WebWidget.
Modified: trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp (97378 => 97379)
--- trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Source/WebKit/chromium/src/AssertMatchingEnums.cpp 2011-10-13 19:06:43 UTC (rev 97379)
@@ -310,9 +310,11 @@
COMPILE_ASSERT_MATCHING_ENUM(WebIconURL::TypeTouch, TouchIcon);
COMPILE_ASSERT_MATCHING_ENUM(WebIconURL::TypeTouchPrecomposed, TouchPrecomposedIcon);
+#if ENABLE(INPUT_SPEECH)
COMPILE_ASSERT_MATCHING_ENUM(WebInputElement::Idle, InputFieldSpeechButtonElement::Idle);
COMPILE_ASSERT_MATCHING_ENUM(WebInputElement::Recording, InputFieldSpeechButtonElement::Recording);
COMPILE_ASSERT_MATCHING_ENUM(WebInputElement::Recognizing, InputFieldSpeechButtonElement::Recognizing);
+#endif
COMPILE_ASSERT_MATCHING_ENUM(WebNode::ElementNode, Node::ELEMENT_NODE);
COMPILE_ASSERT_MATCHING_ENUM(WebNode::AttributeNode, Node::ATTRIBUTE_NODE);
Modified: trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp (97378 => 97379)
--- trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.cpp 2011-10-13 19:06:43 UTC (rev 97379)
@@ -31,6 +31,8 @@
#include "config.h"
#include "WebSpeechInputControllerMockImpl.h"
+#if ENABLE(INPUT_SPEECH)
+
#include "PlatformString.h"
#include "SecurityOrigin.h"
#include "SpeechInputClientMock.h"
@@ -99,3 +101,17 @@
}
} // namespace WebKit
+
+#else
+
+namespace WebKit {
+
+WebSpeechInputControllerMock* WebSpeechInputControllerMock::create(WebSpeechInputListener* listener)
+{
+return 0;
+}
+
+} // namespace WebKit
+
+#endif // ENABLE(INPUT_SPEECH)
+
Modified: trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h (97378 => 97379)
--- trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Source/WebKit/chromium/src/WebSpeechInputControllerMockImpl.h 2011-10-13 19:06:43 UTC (rev 97379)
@@ -37,6 +37,8 @@
#include "WebString.h"
#include
+#if ENABLE(INPUT_SPEECH)
+
namespace WebCore {
class SpeechInputClientMock;
}
@@ -72,4 +74,6 @@
} // namespace WebKit
+#endif // ENABLE(INPUT_SPEECH)
+
#endif // WebSpeechInputControllerMockImpl_h
Modified: trunk/Source/WebKit/chromium/src/WebSpeechInputResult.cpp (97378 => 97379)
--- trunk/Source/WebKit/chromium/src/WebSpeechInputResult.cpp 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Source/WebKit/chromium/src/WebSpeechInputResult.cpp 2011-10-13 19:06:43 UTC (rev 97379)
@@ -26,6 +26,8 @@
#include "config.h"
#include "WebSpeechInputResult.h"
+#if ENABLE(INPUT_SPEECH)
+
#include "SpeechInputResult.h"
#include
@@ -52,3 +54,5 @@
}
} // namespace WebKit
+
+#endif // ENABLE(INPUT_SPEECH)
Modified: trunk/Tools/ChangeLog (97378 => 97379)
--- trunk/Tools/ChangeLog 2011-10-13 19:04:43 UTC (rev 97378)
+++ trunk/Tools/ChangeLog 2011-10-13 19:06:43 UTC (rev 97379)
@@ -1,3 +1,13 @@
+2011-10-13 John Knottenbelt
+
+[Chromium] Allow building without speech input enabled.
+https://bugs.webkit.org/show_bug.cgi?id=69867
+
+Reviewed by Darin Fisher.
+
+* DumpR
[webkit-changes] [97378] trunk
Title: [97378] trunk
Revision 97378
Author rob...@webkit.org
Date 2011-10-13 12:04:43 -0700 (Thu, 13 Oct 2011)
Log Message
CSS 2.1 failure: inline-replaced-height-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69273
Reviewed by Simon Fraser.
Source/WebCore:
Test: css2.1/20110323/inline-block-replaced-height-008.html
Per http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height, if 'height' has computed value of
'auto', the replaced element has an intrinsic ratio and its used width is known or resolved, then
the used value of 'height' is determined by the equation (used width) / (intrinsic ratio).
* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalHeight):
* rendering/RenderReplaced.h:
LayoutTests:
* css2.1/20110323/floating-replaced-height-008.htm: Added.
* css2.1/20110323/inline-block-replaced-height-008.htm: Added.
* css2.1/20110323/inline-replaced-height-008.htm: Added.
* css2.1/20110323/support/60x60-green.png: Added
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp
trunk/Source/WebCore/rendering/RenderReplaced.h
Added Paths
trunk/LayoutTests/css2.1/20110323/floating-replaced-height-008.htm
trunk/LayoutTests/css2.1/20110323/inline-block-replaced-height-008.htm
trunk/LayoutTests/css2.1/20110323/inline-replaced-height-008.htm
trunk/LayoutTests/css2.1/20110323/support/
trunk/LayoutTests/css2.1/20110323/support/60x60-green.png
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png
trunk/LayoutTests/platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97377 => 97378)
--- trunk/LayoutTests/ChangeLog 2011-10-13 19:02:03 UTC (rev 97377)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 19:04:43 UTC (rev 97378)
@@ -1,3 +1,21 @@
+2011-10-03 Robert Hogan
+
+CSS 2.1 failure: inline-replaced-height-008.htm
+https://bugs.webkit.org/show_bug.cgi?id=69273
+
+Reviewed by Simon Fraser.
+
+* css2.1/20110323/floating-replaced-height-008.htm: Added.
+* css2.1/20110323/inline-block-replaced-height-008.htm: Added.
+* css2.1/20110323/inline-replaced-height-008.htm: Added.
+* css2.1/20110323/support/60x60-green.png: Added
+* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
+* platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
+* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
+* platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
+* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
+* platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
+
2011-10-13 Adam Klein
Unreviewed, skip MutationObserver tests on wincairo.
Added: trunk/LayoutTests/css2.1/20110323/floating-replaced-height-008.htm (0 => 97378)
--- trunk/LayoutTests/css2.1/20110323/floating-replaced-height-008.htm (rev 0)
+++ trunk/LayoutTests/css2.1/20110323/floating-replaced-height-008.htm 2011-10-13 19:04:43 UTC (rev 97378)
@@ -0,0 +1,38 @@
+
+
+
+
+
+ CSS Test: Floating replaced elements - specified width, height in percentages and intrinsic ratio
+
+
+
+
+
+
+
+
+ img {float: left;}
+
+
+
+
+
+
+ There should be 5 filled green squares with the same width and the same height. The 5 filled green squares should be identical to each other. This should still remain true even after a window resize.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
Property changes on: trunk/LayoutTests/css2.1/20110323/floating-replaced-height-008.htm
___
Added: svn:eol-style
Added: trunk/LayoutTests/css2.1/20110
[webkit-changes] [97377] trunk/LayoutTests
Title: [97377] trunk/LayoutTests Revision 97377 Author ad...@chromium.org Date 2011-10-13 12:02:03 -0700 (Thu, 13 Oct 2011) Log Message Unreviewed, skip MutationObserver tests on wincairo. These tests are not yet enabled on any platform. * platform/wincairo/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97376 => 97377) --- trunk/LayoutTests/ChangeLog 2011-10-13 18:51:16 UTC (rev 97376) +++ trunk/LayoutTests/ChangeLog 2011-10-13 19:02:03 UTC (rev 97377) @@ -1,3 +1,10 @@ +2011-10-13 Adam Klein + +Unreviewed, skip MutationObserver tests on wincairo. +These tests are not yet enabled on any platform. + +* platform/wincairo/Skipped: + 2011-10-13 Andrew Scherkus Add stallFor URL parameter for http/tests/media/video-play-stall.html test. Modified: trunk/LayoutTests/platform/wincairo/Skipped (97376 => 97377) --- trunk/LayoutTests/platform/wincairo/Skipped 2011-10-13 18:51:16 UTC (rev 97376) +++ trunk/LayoutTests/platform/wincairo/Skipped 2011-10-13 19:02:03 UTC (rev 97377) @@ -1917,6 +1917,9 @@ # For now, Web Audio API is disabled webaudio/ +# MutationObservers are net yet enabled. http://webkit.org/b/68729 +fast/mutation + # Tests for WebVTT parser for . Feature is not yet functional. # https://bugs.webkit.org/show_bug.cgi?id=43668 media/track/ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97376] trunk/LayoutTests
Title: [97376] trunk/LayoutTests
Revision 97376
Author scher...@chromium.org
Date 2011-10-13 11:51:16 -0700 (Thu, 13 Oct 2011)
Log Message
Add stallFor URL parameter for http/tests/media/video-play-stall.html test.
https://bugs.webkit.org/show_bug.cgi?id=69974
Without the call to sleep(), the test server will issue a TCP
connection close earlier than the 3 second wait time required to issue
a stalled event.
Reviewed by Eric Carlson.
* http/tests/media/video-play-stall.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/video-play-stall.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97375 => 97376)
--- trunk/LayoutTests/ChangeLog 2011-10-13 18:44:02 UTC (rev 97375)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 18:51:16 UTC (rev 97376)
@@ -1,3 +1,16 @@
+2011-10-13 Andrew Scherkus
+
+Add stallFor URL parameter for http/tests/media/video-play-stall.html test.
+https://bugs.webkit.org/show_bug.cgi?id=69974
+
+Without the call to sleep(), the test server will issue a TCP
+connection close earlier than the 3 second wait time required to issue
+a stalled event.
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/video-play-stall.html:
+
2011-10-13 Ryosuke Niwa
Mac test expectation update for the bug 6.
Modified: trunk/LayoutTests/http/tests/media/video-play-stall.html (97375 => 97376)
--- trunk/LayoutTests/http/tests/media/video-play-stall.html 2011-10-13 18:44:02 UTC (rev 97375)
+++ trunk/LayoutTests/http/tests/media/video-play-stall.html 2011-10-13 18:51:16 UTC (rev 97376)
@@ -36,6 +36,6 @@
var mediaFile = findMediaFile("video", "content/test");
var mimeType = mimeTypeForFile(mediaFile);
-video.src = "" + mediaFile + "&mimeType=" + mimeType + "&stallAt=10";
+video.src = "" + mediaFile + "&mimeType=" + mimeType + "&stallAt=10&stallFor=6";
run("video.play()");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97375] trunk/Source/WebKit2
Title: [97375] trunk/Source/WebKit2
Revision 97375
Author commit-qu...@webkit.org
Date 2011-10-13 11:44:02 -0700 (Thu, 13 Oct 2011)
Log Message
[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832
Patch by Jesus Sanchez-Palencia on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.
We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.
* UIProcess/qt/ClientImpl.cpp:
(qt_wk_decidePolicyForResponse):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp
trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97374 => 97375)
--- trunk/Source/WebKit2/ChangeLog 2011-10-13 18:31:26 UTC (rev 97374)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-13 18:44:02 UTC (rev 97375)
@@ -1,3 +1,19 @@
+2011-10-13 Jesus Sanchez-Palencia
+
+[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
+https://bugs.webkit.org/show_bug.cgi?id=69832
+
+Reviewed by Kenneth Rohde Christiansen.
+
+We implement decidePolicyForResponse in our PolicyClient in order to
+decide whether a given ResourceResponse should be downloaded or loaded.
+
+* UIProcess/qt/ClientImpl.cpp:
+(qt_wk_decidePolicyForResponse):
+* UIProcess/qt/ClientImpl.h:
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::init):
+
2011-10-13 Carlos Garcia Campos
[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
Modified: trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp (97374 => 97375)
--- trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp 2011-10-13 18:31:26 UTC (rev 97374)
+++ trunk/Source/WebKit2/UIProcess/qt/ClientImpl.cpp 2011-10-13 18:44:02 UTC (rev 97375)
@@ -247,3 +247,30 @@
break;
}
}
+
+void qt_wk_decidePolicyForResponse(WKPageRef page, WKFrameRef frame, WKURLResponseRef response, WKURLRequestRef request, WKFramePolicyListenerRef listener, WKTypeRef userData, const void* clientInfo)
+{
+String type = toImpl(response)->resourceResponse().mimeType();
+type.makeLower();
+bool canShowMIMEType = toImpl(frame)->canShowMIMEType(type);
+
+if (WKPageGetMainFrame(page) == frame) {
+if (canShowMIMEType) {
+WKFramePolicyListenerUse(listener);
+return;
+}
+
+// If we can't use (show) it then we should download it.
+WKFramePolicyListenerDownload(listener);
+return;
+}
+
+// We should ignore downloadable top-level content for subframes, with an exception for text/xml and application/xml so we can still support Acid3 test.
+// It makes the browser intentionally behave differently when it comes to text(application)/xml content in subframes vs. mainframe.
+if (!canShowMIMEType && !(type == "text/xml" || type == "application/xml")) {
+WKFramePolicyListenerIgnore(listener);
+return;
+}
+
+WKFramePolicyListenerUse(listener);
+}
Modified: trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h (97374 => 97375)
--- trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h 2011-10-13 18:31:26 UTC (rev 97374)
+++ trunk/Source/WebKit2/UIProcess/qt/ClientImpl.h 2011-10-13 18:44:02 UTC (rev 97375)
@@ -48,6 +48,7 @@
// Policy client.
void qt_wk_decidePolicyForNavigationAction(WKPageRef, WKFrameRef, WKFrameNavigationType, WKEventModifiers, WKEventMouseButton, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef userData, const void* clientInfo);
+void qt_wk_decidePolicyForResponse(WKPageRef, WKFrameRef, WKURLResponseRef, WKURLRequestRef, WKFramePolicyListenerRef, WKTypeRef userData, const void* clientInfo);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (97374 => 97375)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-10-13 18:31:26 UTC (rev 97374)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-10-13 18:44:02 UTC (rev 97375)
@@ -156,6 +156,7 @@
policyClient.version = kWKPagePolicyClientCurrentVersion;
policyClient.clientInfo = m_policyInterface;
policyClient.decidePolicyForNavigationAction = qt_wk_decidePolicyForNavigationAction;
+policyClient.decidePolicyForResponse = qt_wk_decidePolicyForResponse;
WKPageSetPagePolicyClient(toAPI(m_webPageProxy.get()), &policyClient);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97374] trunk/LayoutTests
Title: [97374] trunk/LayoutTests Revision 97374 Author rn...@webkit.org Date 2011-10-13 11:31:26 -0700 (Thu, 13 Oct 2011) Log Message Mac test expectation update for the bug 6. * platform/mac/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97373 => 97374) --- trunk/LayoutTests/ChangeLog 2011-10-13 18:28:32 UTC (rev 97373) +++ trunk/LayoutTests/ChangeLog 2011-10-13 18:31:26 UTC (rev 97374) @@ -1,3 +1,9 @@ +2011-10-13 Ryosuke Niwa + +Mac test expectation update for the bug 6. + +* platform/mac/test_expectations.txt: + 2011-10-13 Dimitri Glazkov [Chromium] Update expectations while waiting on results from bots. Modified: trunk/LayoutTests/platform/mac/test_expectations.txt (97373 => 97374) --- trunk/LayoutTests/platform/mac/test_expectations.txt 2011-10-13 18:28:32 UTC (rev 97373) +++ trunk/LayoutTests/platform/mac/test_expectations.txt 2011-10-13 18:31:26 UTC (rev 97374) @@ -30,4 +30,4 @@ BUGWK67007 DEBUG : fast/ruby/generated-after-counter-doesnt-crash.html = CRASH BUGWK67007 DEBUG : fast/ruby/generated-before-and-after-counter-doesnt-crash.html = CRASH -BUGWK6 RELEASE : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TIMEOUT PASS +BUGWK6 RELEASE : http/tests/security/contentSecurityPolicy/media-src-allowed.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97373] trunk/LayoutTests
Title: [97373] trunk/LayoutTests Revision 97373 Author dglaz...@chromium.org Date 2011-10-13 11:28:32 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Update expectations while waiting on results from bots. * platform/chromium/test_expectations.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97372 => 97373) --- trunk/LayoutTests/ChangeLog 2011-10-13 18:02:10 UTC (rev 97372) +++ trunk/LayoutTests/ChangeLog 2011-10-13 18:28:32 UTC (rev 97373) @@ -1,3 +1,9 @@ +2011-10-13 Dimitri Glazkov + +[Chromium] Update expectations while waiting on results from bots. + +* platform/chromium/test_expectations.txt: Updated. + 2011-10-13 Sheriff Bot Unreviewed, rolling out r97362. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97372 => 97373) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 18:02:10 UTC (rev 97372) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 18:28:32 UTC (rev 97373) @@ -3990,3 +3990,20 @@ BUGCR100056 MAC DEBUG SLOW : http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html = PASS BUGCR100056 MAC DEBUG SLOW : http/tests/misc/submit-post-in-utf32le.html = PASS BUGCR100056 MAC DEBUG SLOW : http/tests/misc/window-open-then-write.html = PASS + +// new tests -- rebaseline once all bots have results +BUG_DGLAZKOV : fast/repaint/region-painting-via-layout.html = TEXT +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html = IMAGE +BUG_DGLAZKOV : svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97372] trunk
Title: [97372] trunk
Revision 97372
Author commit-qu...@webkit.org
Date 2011-10-13 11:02:10 -0700 (Thu, 13 Oct 2011)
Log Message
Unreviewed, rolling out r97362.
http://trac.webkit.org/changeset/97362
https://bugs.webkit.org/show_bug.cgi?id=70039
Relies on V8 APIs that have been reverted upstream. (Requested
by dglazkov on #webkit).
Patch by Sheriff Bot on 2011-10-13
Source/WebCore:
* English.lproj/localizedStrings.js:
* bindings/js/ScriptProfiler.cpp:
* bindings/js/ScriptProfiler.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/ScriptProfiler.h:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
* inspector/InspectorProfilerAgent.h:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):
* inspector/front-end/HeapSnapshotProxy.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/heapProfiler.css:
LayoutTests:
* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
* inspector/profiler/heap-snapshot.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt
trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js
trunk/LayoutTests/inspector/profiler/heap-snapshot.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp
trunk/Source/WebCore/bindings/js/ScriptProfiler.h
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp
trunk/Source/WebCore/bindings/v8/ScriptProfiler.h
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorController.cpp
trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp
trunk/Source/WebCore/inspector/InspectorProfilerAgent.h
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js
trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js
trunk/Source/WebCore/inspector/front-end/RemoteObject.js
trunk/Source/WebCore/inspector/front-end/heapProfiler.css
Diff
Modified: trunk/LayoutTests/ChangeLog (97371 => 97372)
--- trunk/LayoutTests/ChangeLog 2011-10-13 17:00:59 UTC (rev 97371)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 18:02:10 UTC (rev 97372)
@@ -1,3 +1,17 @@
+2011-10-13 Sheriff Bot
+
+Unreviewed, rolling out r97362.
+http://trac.webkit.org/changeset/97362
+https://bugs.webkit.org/show_bug.cgi?id=70039
+
+Relies on V8 APIs that have been reverted upstream. (Requested
+by dglazkov on #webkit).
+
+* inspector/profiler/heap-snapshot-expected.txt:
+* inspector/profiler/heap-snapshot-test.js:
+(initialize_HeapSnapshotTest):
+* inspector/profiler/heap-snapshot.html:
+
2011-10-13 David Hyatt
https://bugs.webkit.org/show_bug.cgi?id=69932
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt (97371 => 97372)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt 2011-10-13 17:00:59 UTC (rev 97371)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt 2011-10-13 18:02:10 UTC (rev 97372)
@@ -17,8 +17,6 @@
Running: heapSnapshotAggregatesTest
-Running: heapSnapshotFlagsTest
-
Running: heapSnapshotNodesProviderTest
Running: heapSnapshotEdgesProviderTest
Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js (97371 => 97372)
--- trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2011-10-13 17:00:59 UTC (rev 97371)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js 2011-10-13 18:02:10 UTC (rev 97372)
@@ -66,41 +66,4 @@
};
};
-InspectorTest.createHeapSnapshotMockWithDOM = function()
-{
-return {
-snapshot: {},
-nodes: [
-{ fields: ["type", "name", "id", "children_count", "children"],
- types: [["hidden", "object"], "", "", "", { fields: ["type", "name_or_index", "to_node"], types: [["element", "hidden", "internal"], "", ""] }] },
-// A tree with DOMWi
[webkit-changes] [97371] trunk/Source/JavaScriptCore
Title: [97371] trunk/Source/_javascript_Core
Revision 97371
Author commit-qu...@webkit.org
Date 2011-10-13 10:00:59 -0700 (Thu, 13 Oct 2011)
Log Message
Use realloc() to expand/shrink StringBuilder buffer
https://bugs.webkit.org/show_bug.cgi?id=69913
Patch by Xianzhu Wang on 2011-10-13
Reviewed by Darin Adler.
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::reallocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.
* wtf/text/StringImpl.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/StringBuilder.cpp
trunk/Source/_javascript_Core/wtf/text/StringBuilder.h
trunk/Source/_javascript_Core/wtf/text/StringImpl.cpp
trunk/Source/_javascript_Core/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (97370 => 97371)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-13 16:55:13 UTC (rev 97370)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-13 17:00:59 UTC (rev 97371)
@@ -1,3 +1,20 @@
+2011-10-13 Xianzhu Wang
+
+Use realloc() to expand/shrink StringBuilder buffer
+https://bugs.webkit.org/show_bug.cgi?id=69913
+
+Reviewed by Darin Adler.
+
+* wtf/text/StringBuilder.cpp:
+(WTF::StringBuilder::reserveCapacity):
+(WTF::StringBuilder::reallocateBuffer):
+(WTF::StringBuilder::appendUninitialized):
+(WTF::StringBuilder::shrinkToFit):
+* wtf/text/StringBuilder.h:
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.
+* wtf/text/StringImpl.h:
+
2011-10-12 Filip Pizlo
If an Arguments object is being used to copy the arguments, then
Modified: trunk/Source/_javascript_Core/wtf/text/StringBuilder.cpp (97370 => 97371)
--- trunk/Source/_javascript_Core/wtf/text/StringBuilder.cpp 2011-10-13 16:55:13 UTC (rev 97370)
+++ trunk/Source/_javascript_Core/wtf/text/StringBuilder.cpp 2011-10-13 17:00:59 UTC (rev 97371)
@@ -83,7 +83,7 @@
if (m_buffer) {
// If there is already a buffer, then grow if necessary.
if (newCapacity > m_buffer->length())
-allocateBuffer(m_buffer->characters(), newCapacity);
+reallocateBuffer(newCapacity);
} else {
// Grow the string, if necessary.
if (newCapacity > m_length)
@@ -104,13 +104,24 @@
m_string = String();
}
+void StringBuilder::reallocateBuffer(unsigned requiredLength)
+{
+// If the buffer has only one ref (by this StringBuilder), reallocate it,
+// otherwise fall back to "allocate and copy" method.
+m_string = String();
+if (m_buffer->hasOneRef())
+m_buffer = StringImpl::reallocate(m_buffer.release(), requiredLength, m_bufferCharacters);
+else
+allocateBuffer(m_buffer->characters(), requiredLength);
+}
+
// Make 'length' additional capacity be available in m_buffer, update m_string & m_length,
// return a pointer to the newly allocated storage.
UChar* StringBuilder::appendUninitialized(unsigned length)
{
ASSERT(length);
-// Calcuate the new size of the builder after appending.
+// Calculate the new size of the builder after appending.
unsigned requiredLength = length + m_length;
if (requiredLength < length)
CRASH();
@@ -127,8 +138,7 @@
return m_bufferCharacters + currentLength;
}
-// We need to realloc the buffer.
-allocateBuffer(m_buffer->characters(), std::max(requiredLength, std::max(minimumCapacity, m_buffer->length() * 2)));
+reallocateBuffer(std::max(requiredLength, std::max(minimumCapacity, m_buffer->length() * 2)));
} else {
ASSERT(m_string.length() == m_length);
allocateBuffer(m_string.characters(), std::max(requiredLength, std::max(minimumCapacity, m_length * 2)));
@@ -164,9 +174,8 @@
{
// If the buffer is at least 80% full, don't bother copying. Need to tune this heuristic!
if (m_buffer && m_buffer->length() > (m_length + (m_length >> 2))) {
-UChar* result;
-m_string = StringImpl::createUninitialized(m_length, result);
-memcpy(result, m_buffer->characters(), static_cast(m_length) * 2); // This can't overflow.
+reallocateBuffer(m_length);
+m_string = m_buffer;
m_buffer = 0;
}
}
Modified: trunk/Source/_javascript_Core/wtf/text/StringBuilder.h (97370 => 97371)
--- trunk/Source/_javascript_Core/wtf/text/StringBuilder.h 2011-10-13 16:55:13 UTC (rev 97370)
+++ trunk/Source/_javascript_Core/wtf/text/StringBuilder.h 2011-10-13 17:00:59 UTC (rev 97371)
@@ -130,6 +130,7 @@
private:
void allocateBuffer(const UChar* currentCharacters, unsigned requiredLength);
+void reallocateBuffer(unsigned requiredLength);
UCha
[webkit-changes] [97370] trunk
Title: [97370] trunk
Revision 97370
Author hy...@apple.com
Date 2011-10-13 09:55:13 -0700 (Thu, 13 Oct 2011)
Log Message
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932
Layout repainting messed up for objects in regions. There were two bugs here.
The first is that the regionOverflowRect needs to at least be the size of the
region's rect. When you're in the middle of layout, you haven't computed the
overflow rect for the flow thread yet (the flow thread's height could even be 0),
and so you just need to enforce a minimum size. Also removed the region-overflow:break
clipping behavior, since it was established that was wrong.
The second bug is that when you tell a region to repaint, you need to disable layout state,
since applying layout deltas from the flow thread makes no sense. The region is in a totally
different place in the render tree, so the current flow thread layout state can't be used
to determine your coordinate offset.
Reviewed by Dan Bernstein.
Added fast/repaint test.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOverflowRect):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69932
Layout repainting messed up for objects in regions. Add a repaint test to
illustrate the issue.
Reviewed by Dan Bernstein.
* fast/repaint/region-painting-via-layout.html: Added.
* platform/mac/fast/regions/region-overflow-break-expected.png:
* platform/mac/fast/repaint/region-painting-via-layout-expected.png: Added.
* platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/regions/region-overflow-break-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderRegion.cpp
Added Paths
trunk/LayoutTests/fast/repaint/region-painting-via-layout.html
trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png
trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97369 => 97370)
--- trunk/LayoutTests/ChangeLog 2011-10-13 16:33:19 UTC (rev 97369)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 16:55:13 UTC (rev 97370)
@@ -1,3 +1,17 @@
+2011-10-13 David Hyatt
+
+https://bugs.webkit.org/show_bug.cgi?id=69932
+
+Layout repainting messed up for objects in regions. Add a repaint test to
+illustrate the issue.
+
+Reviewed by Dan Bernstein.
+
+* fast/repaint/region-painting-via-layout.html: Added.
+* platform/mac/fast/regions/region-overflow-break-expected.png:
+* platform/mac/fast/repaint/region-painting-via-layout-expected.png: Added.
+* platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Added.
+
2011-10-13 Renata Hodovan
FEComponentTransfer element doesn't support dynamic invalidation
Added: trunk/LayoutTests/fast/repaint/region-painting-via-layout.html (0 => 97370)
--- trunk/LayoutTests/fast/repaint/region-painting-via-layout.html (rev 0)
+++ trunk/LayoutTests/fast/repaint/region-painting-via-layout.html 2011-10-13 16:55:13 UTC (rev 97370)
@@ -0,0 +1,49 @@
+
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=69932
+
+#content {
+-webkit-flow: "flow1";
+position:relative;
+padding-top:1000px;
+}
+
+#target { height: 200px; background-color: red }
+
+#region1, #region2, #region3 {
+content: -webkit-from-flow("flow1");
+}
+
+#region1 {
+width: 300px;
+height: 1000px;
+background-color:red
+}
+
+#region2 {
+width: 100%;
+height: 180px;
+border:1px solid black;
+background-color:red
+}
+
+
+
+
+function repaintTest()
+{
+document.getElementById('target').style.fontSize = '36px';
+document.getElementById('target').style.backgroundColor = 'green';
+}
+
+
+
+
+
+
+
+
+
+
+
+
Modified: trunk/LayoutTests/platform/mac/fast/regions/region-overflow-break-expected.png
(Binary files differ)
Added: trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt (0 => 97370)
--- trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt 2011-10-13 16:55:13 UTC (rev 97370)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+
[webkit-changes] [97366] trunk/Source/WebKit2
Title: [97366] trunk/Source/WebKit2
Revision 97366
Author carlo...@webkit.org
Date 2011-10-13 08:28:38 -0700 (Thu, 13 Oct 2011)
Log Message
[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
https://bugs.webkit.org/show_bug.cgi?id=70010
Reviewed by Martin Robinson.
With this class tests using a soup server only need to implement
the soup server callback.
* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Use WebKitTestServer.
(testLoadingStatus):
(testLoadingError):
(testLoadAlternateContent):
(testWebViewReload):
(testLoadProgress):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebKitTestServer.cpp: Added.
(WebKitTestServer::WebKitTestServer):
(WebKitTestServer::~WebKitTestServer):
(WebKitTestServer::run): Run the soup server and adds the given
soup server callback to handle requests.
(WebKitTestServer::getURIForPath): Returns the server absolute URI
for the given relative path.
* UIProcess/API/gtk/tests/WebKitTestServer.h: Added.
(WebKitTestServer::baseURI):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp
Added Paths
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (97365 => 97366)
--- trunk/Source/WebKit2/ChangeLog 2011-10-13 14:31:38 UTC (rev 97365)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-13 15:28:38 UTC (rev 97366)
@@ -1,3 +1,32 @@
+2011-10-13 Carlos Garcia Campos
+
+[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
+https://bugs.webkit.org/show_bug.cgi?id=70010
+
+Reviewed by Martin Robinson.
+
+With this class tests using a soup server only need to implement
+the soup server callback.
+
+* UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
+* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Use WebKitTestServer.
+(testLoadingStatus):
+(testLoadingError):
+(testLoadAlternateContent):
+(testWebViewReload):
+(testLoadProgress):
+(beforeAll):
+(afterAll):
+* UIProcess/API/gtk/tests/WebKitTestServer.cpp: Added.
+(WebKitTestServer::WebKitTestServer):
+(WebKitTestServer::~WebKitTestServer):
+(WebKitTestServer::run): Run the soup server and adds the given
+soup server callback to handle requests.
+(WebKitTestServer::getURIForPath): Returns the server absolute URI
+for the given relative path.
+* UIProcess/API/gtk/tests/WebKitTestServer.h: Added.
+(WebKitTestServer::baseURI):
+
2011-10-13 Nayan Kumar K
[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am (97365 => 97366)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am 2011-10-13 14:31:38 UTC (rev 97365)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am 2011-10-13 15:28:38 UTC (rev 97366)
@@ -36,6 +36,8 @@
Libraries_libWebKit2APITestCore_la_SOURCES = \
Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp \
Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h \
+ Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp \
+ Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h \
Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp \
Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h \
Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp \
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp (97365 => 97366)
--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp 2011-10-13 14:31:38 UTC (rev 97365)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp 2011-10-13 15:28:38 UTC (rev 97366)
@@ -21,24 +21,16 @@
#include "config.h"
#include "LoadTrackingTest.h"
+#include "WebKitTestServer.h"
#include
#include
#include
-static SoupURI* kBaseURI = 0;
-static SoupServer* kSoupServer = 0;
+static WebKitTestServer* kServer;
-static CString getURIForPath(const char* path)
-{
-SoupURI* uri = soup_uri_new_with_base(kBaseURI, path);
-GOwnPtr uriString(soup_uri_to_string(uri, FALSE));
-soup_uri_free(uri);
-return uriString.get();
-}
-
static void testLoadingStatus(LoadTrackingTest* test, gconstpointer data)
{
-webkit_web_view_load_uri(test->m_webView, getURIForPath("/redirect").data());
+webkit_web_view_load_uri(test->m_webView, kServer->getURIForPath("/redirect").data());
test->waitUntilLoadFinished();
Vector& events = test->m_loadEvents;
@@ -51,7 +43,7 @@
static void testLoadingError(LoadTrackingTest* test, gconstpointer)
{
-webkit_web_view_load_uri(test->m_webView,
[webkit-changes] [97368] trunk/Source/WebKit/chromium
Title: [97368] trunk/Source/WebKit/chromium
Revision 97368
Author commit-qu...@webkit.org
Date 2011-10-13 09:12:48 -0700 (Thu, 13 Oct 2011)
Log Message
[chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028
Patch by Peng Huang on 2011-10-13
Reviewed by Darin Fisher.
* public/WebWidget.h:
(WebKit::WebWidget::selectionBounds):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::selectionRange):
(WebKit::WebViewImpl::selectionBounds):
* src/WebViewImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (97367 => 97368)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 15:57:09 UTC (rev 97367)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-13 16:12:48 UTC (rev 97368)
@@ -1,3 +1,17 @@
+2011-10-13 Peng Huang
+
+[chromium] Add a selectionBounds() method to WebWidget.
+https://bugs.webkit.org/show_bug.cgi?id=69028
+
+Reviewed by Darin Fisher.
+
+* public/WebWidget.h:
+(WebKit::WebWidget::selectionBounds):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::selectionRange):
+(WebKit::WebViewImpl::selectionBounds):
+* src/WebViewImpl.h:
+
2011-10-13 Kent Tamura
Cleanup of HTMLSelectElement
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (97367 => 97368)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2011-10-13 15:57:09 UTC (rev 97367)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2011-10-13 16:12:48 UTC (rev 97368)
@@ -42,7 +42,6 @@
namespace WebKit {
class WebInputEvent;
-class WebRange;
class WebString;
struct WebPoint;
template class WebVector;
@@ -149,15 +148,23 @@
// otherwise the anchor index will be the same value of the focus index.
virtual bool getSelectionOffsetsAndTextInEditableContent(WebString&, size_t& focus, size_t& anchor) const { return false; }
+// FIXME: It has been replaced by selectionBounds. Remove it when chromium
+// switches to selectionBounds.
// Returns the current caret bounds of this WebWidget. The selection bounds
// will be returned if a selection range is available.
virtual WebRect caretOrSelectionBounds() { return WebRect(); }
+// FIXME: It has been replaced by selectionBounds. Remove it when chromium
+// switches to selectionBounds.
// Returns the start and end point for the current selection, aligned to the
// bottom of the selected line. start and end are the logical beginning and
// ending positions of the selection. Visually, start may lie after end.
virtual bool selectionRange(WebPoint& start, WebPoint& end) const { return false; }
+// Returns the start and end bounds of the current selection.
+// If the selection range is empty, it returns the caret bounds.
+virtual bool selectionBounds(WebRect& start, WebRect& end) const { return false; }
+
// Fetch the current selection range of this WebWidget. If there is no
// selection, it will output a 0-length range with the location at the
// caret. Returns true and fills the out-paramters on success; returns false
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (97367 => 97368)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-13 15:57:09 UTC (rev 97367)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-13 16:12:48 UTC (rev 97368)
@@ -295,7 +295,7 @@
m_autofillClient = autofillClient;
}
-void WebViewImpl::setDevToolsAgentClient(WebDevToolsAgentClient* devToolsClient)
+void WebViewImpl::setDevToolsAgentClient(WebDevToolsAgentClient* devToolsClient)
{
if (devToolsClient)
m_devToolsAgent = adoptPtr(new WebDevToolsAgentImpl(this, devToolsClient));
@@ -1568,34 +1568,51 @@
bool WebViewImpl::selectionRange(WebPoint& start, WebPoint& end) const
{
+WebRect startRect, endRect;
+if (!selectionBounds(startRect, endRect))
+return false;
+start.x = startRect.x;
+start.y = startRect.y + startRect.height - 1;
+end.x = endRect.x + endRect.width - 1;
+end.y = endRect.y + endRect.height - 1;
+return true;
+}
+
+bool WebViewImpl::selectionBounds(WebRect& start, WebRect& end) const
+{
const Frame* frame = focusedWebCoreFrame();
-if (!frame || !frame->selection()->isRange())
+if (!frame)
return false;
+FrameSelection* selection = frame->selection();
+if (!selection)
+return false;
+
+if (selection->isCaret()) {
+start = end = frame->view()->contentsToWindow(selection->absoluteCaretBounds());
+return true;
+}
+
RefPtr selectedRange = frame->selection()->toNormalizedRange();
if (!selectedRange)
return false;
+
RefPtr range(Range::create(selectedRange->startContainer()->document(),
[webkit-changes] [97367] trunk
Title: [97367] trunk
Revision 97367
Author commit-qu...@webkit.org
Date 2011-10-13 08:57:09 -0700 (Thu, 13 Oct 2011)
Log Message
REGRESSION (r95381): Standalone video can be focused and draws a focus ring.
https://bugs.webkit.org/show_bug.cgi?id=69097
Patch by Deepak Sherveghar on 2011-10-13
Reviewed by Eric Carlson.
Source/WebCore:
We don't want to focus a media element in a standalone document.
Test: fast/events/media-focus-in-standalone-media-document.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus): return false if media element is in a standalone media document.
LayoutTests:
New test to check that media element in a standalone document are not focussed.
* fast/events/media-focus-in-standalone-media-document-expected.txt: Added.
* fast/events/media-focus-in-standalone-media-document.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Added Paths
trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt
trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97366 => 97367)
--- trunk/LayoutTests/ChangeLog 2011-10-13 15:28:38 UTC (rev 97366)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 15:57:09 UTC (rev 97367)
@@ -1,3 +1,15 @@
+2011-10-13 Deepak Sherveghar
+
+REGRESSION (r95381): Standalone video can be focused and draws a focus ring.
+https://bugs.webkit.org/show_bug.cgi?id=69097
+
+Reviewed by Eric Carlson.
+
+New test to check that media element in a standalone document are not focussed.
+
+* fast/events/media-focus-in-standalone-media-document-expected.txt: Added.
+* fast/events/media-focus-in-standalone-media-document.html: Added.
+
2011-10-13 Sergio Villar Senin
Unreviewed, rebaselined GTK SVG test result.
Added: trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt (0 => 97367)
--- trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document-expected.txt 2011-10-13 15:57:09 UTC (rev 97367)
@@ -0,0 +1,13 @@
+This tests that media element in a standalone media document cannot be focused directly using focus() method or by mouse click.
+
+
+
+*** Should not focus video element by calling focus() method.
+EXPECTED (standaloneMediaDocument.activeElement != '[object HTMLVideoElement]') OK
+
+*** Should not focus video element by mouse click.
+*** Video element clicked.
+EXPECTED (standaloneMediaDocument.activeElement != '[object HTMLVideoElement]') OK
+
+END OF TEST
+
Added: trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document.html (0 => 97367)
--- trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document.html (rev 0)
+++ trunk/LayoutTests/fast/events/media-focus-in-standalone-media-document.html 2011-10-13 15:57:09 UTC (rev 97367)
@@ -0,0 +1,56 @@
+
+
+
+
+var videoElement;
+var standaloneMediaDocument;
+var skipOnFirstEmptyLoad = 0;
+
+function frameLoaded()
+{
+if (++skipOnFirstEmptyLoad == 1)
+return;
+
+standaloneMediaDocument = document.getElementById("videoframe").contentDocument;
+videoElement = standaloneMediaDocument.querySelector("video");
+
+videoElement.addEventListener('click',function(){
+consoleWrite("*** Video element clicked.");
+},false);
+
+testFocus();
+testFocusbyMouseClick();
+consoleWrite("");
+endTest();
+}
+
+function testFocus()
+{
+consoleWrite("
*** Should not focus video element by calling focus() method.");
+videoElement.focus();
+testExpected("standaloneMediaDocument.activeElement", videoElement, "!=");
+}
+
+function testFocusbyMouseClick()
+{
+// Simulate click event to try focus video element.
+consoleWrite("
*** Should not focus video element by mouse click.");
+var click = document.createEvent("MouseEvents");
+click.initMouseEvent("click", true, true, window, 1, 0, 0, 0, 0, false, false, false, false, 0, document);
+videoElement.dispatchEvent(click);
+testExpected("standaloneMediaDocument.activeElement", videoElement, "!=");
+}
+
+
+
+
+This tests that media element in a standalone media document cannot be focused directly using focus() method or by mouse click.
+
+
+
+document.getElementById("videoframe").src
[webkit-changes] [97365] trunk/Source/WebKit/efl
Title: [97365] trunk/Source/WebKit/efl
Revision 97365
Author lean...@webkit.org
Date 2011-10-13 07:31:38 -0700 (Thu, 13 Oct 2011)
Log Message
Unreviewed; revert some changes introduced in r97329 which are
unrelated to the patch and reverted other patches themselves.
* ewk/ewk_frame.cpp:
(_ewk_frame_smart_del): Remove warning again.
(ewk_frame_contents_size_get): Check for Frame and FrameView again.
* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Revert back default font size change.
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (97364 => 97365)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-13 13:58:48 UTC (rev 97364)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-13 14:31:38 UTC (rev 97365)
@@ -1,3 +1,14 @@
+2011-10-13 Leandro Pereira
+
+Unreviewed; revert some changes introduced in r97329 which are
+unrelated to the patch and reverted other patches themselves.
+
+* ewk/ewk_frame.cpp:
+(_ewk_frame_smart_del): Remove warning again.
+(ewk_frame_contents_size_get): Check for Frame and FrameView again.
+* ewk/ewk_view.cpp:
+(_ewk_view_priv_new): Revert back default font size change.
+
2011-10-12 Joseph Pecoraro
Pass Parsed Accept Attribute MIME Types to WebKit Clients
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (97364 => 97365)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-10-13 13:58:48 UTC (rev 97364)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2011-10-13 14:31:38 UTC (rev 97365)
@@ -231,7 +231,6 @@
static void _ewk_frame_smart_del(Evas_Object* ewkFrame)
{
-WRN("ewkFrame=%p", ewkFrame); // XXX REMOVE ME LATER
EWK_FRAME_SD_GET(ewkFrame, sd);
if (sd) {
@@ -368,6 +367,8 @@
if (height)
*height = 0;
EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, sd, EINA_FALSE);
+if (!sd->frame || !sd->frame->view())
+return EINA_FALSE;
if (width)
*width = sd->frame->view()->contentsWidth();
if (height)
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (97364 => 97365)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-13 13:58:48 UTC (rev 97364)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-13 14:31:38 UTC (rev 97365)
@@ -595,8 +595,8 @@
priv->viewport_arguments.userScalable = EINA_TRUE;
priv->page_settings->setLoadsImagesAutomatically(true);
-priv->page_settings->setDefaultFixedFontSize(10);
-priv->page_settings->setDefaultFontSize(13);
+priv->page_settings->setDefaultFixedFontSize(12);
+priv->page_settings->setDefaultFontSize(16);
priv->page_settings->setSerifFontFamily("serif");
priv->page_settings->setFixedFontFamily("monotype");
priv->page_settings->setSansSerifFontFamily("sans");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97364] trunk/Source/WebKit2
Title: [97364] trunk/Source/WebKit2 Revision 97364 Author commit-qu...@webkit.org Date 2011-10-13 06:58:48 -0700 (Thu, 13 Oct 2011) Log Message [WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation. https://bugs.webkit.org/show_bug.cgi?id=69928 Patch by Nayan Kumar K on 2011-10-13 Reviewed by Philippe Normand. Patch fixes the warnings reported by gtk-doc while generating WebKit2-GTK+ documentation. * UIProcess/API/gtk/WebKitWebContext.h: Correct the documentation comment. * UIProcess/API/gtk/WebKitWebView.cpp: Parameter name correction. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (97363 => 97364) --- trunk/Source/WebKit2/ChangeLog 2011-10-13 11:13:32 UTC (rev 97363) +++ trunk/Source/WebKit2/ChangeLog 2011-10-13 13:58:48 UTC (rev 97364) @@ -1,3 +1,16 @@ +2011-10-13 Nayan Kumar K + +[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation. +https://bugs.webkit.org/show_bug.cgi?id=69928 + +Reviewed by Philippe Normand. + +Patch fixes the warnings reported by gtk-doc while generating +WebKit2-GTK+ documentation. + +* UIProcess/API/gtk/WebKitWebContext.h: Correct the documentation comment. +* UIProcess/API/gtk/WebKitWebView.cpp: Parameter name correction. + 2011-10-12 Joseph Pecoraro Pass Parsed Accept Attribute MIME Types to WebKit Clients Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h (97363 => 97364) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h 2011-10-13 11:13:32 UTC (rev 97363) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h 2011-10-13 13:58:48 UTC (rev 97364) @@ -36,7 +36,7 @@ #define WEBKIT_IS_WEB_CONTEXT_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE((klass), WEBKIT_TYPE_WEB_CONTEXT)) #define WEBKIT_WEB_CONTEXT_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS((obj), WEBKIT_TYPE_WEB_CONTEXT, WebKitWebContextClass)) -/* +/** * WebKitCacheModel: * @WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER: Disable the cache completely, which * substantially reduces memory usage. Useful for applications that only Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (97363 => 97364) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-13 11:13:32 UTC (rev 97363) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-13 13:58:48 UTC (rev 97364) @@ -267,7 +267,7 @@ /** * webkit_web_view_reload_bypass_cache: - * @webView: a #WebKitWebView + * @web_view: a #WebKitWebView * * Reloads the current contents of @web_view without * using any cached data. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97363] trunk/LayoutTests
Title: [97363] trunk/LayoutTests
Revision 97363
Author ser...@webkit.org
Date 2011-10-13 04:13:32 -0700 (Thu, 13 Oct 2011)
Log Message
Unreviewed, rebaselined GTK SVG test result.
* platform/gtk/svg/hixie/cascade/002-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/hixie/cascade/002-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (97362 => 97363)
--- trunk/LayoutTests/ChangeLog 2011-10-13 11:08:49 UTC (rev 97362)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 11:13:32 UTC (rev 97363)
@@ -1,3 +1,9 @@
+2011-10-13 Sergio Villar Senin
+
+Unreviewed, rebaselined GTK SVG test result.
+
+* platform/gtk/svg/hixie/cascade/002-expected.txt:
+
2011-10-13 Mikhail Naganov
Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
Modified: trunk/LayoutTests/platform/gtk/svg/hixie/cascade/002-expected.txt (97362 => 97363)
--- trunk/LayoutTests/platform/gtk/svg/hixie/cascade/002-expected.txt 2011-10-13 11:08:49 UTC (rev 97362)
+++ trunk/LayoutTests/platform/gtk/svg/hixie/cascade/002-expected.txt 2011-10-13 11:13:32 UTC (rev 97363)
@@ -3,4 +3,4 @@
layer at (0,0) size 400x400
RenderSVGRoot {svg} at (100,100) size 200x200
RenderSVGContainer {a} at (100,100) size 200x200
- RenderSVGPath {circle} at (100,100) size 200x200 [fill={[type=SOLID] [color=#008000]}] [cx=200.00] [cy=200.00] [r=100.00]
+ RenderSVGPath {circle} at (100,100) size 200x200 [fill={[type=SOLID] [color=#80]}] [cx=200.00] [cy=200.00] [r=100.00]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97362] trunk
Title: [97362] trunk Revision 97362 Author mnaga...@chromium.org Date 2011-10-13 04:08:49 -0700 (Thu, 13 Oct 2011) Log Message Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile. https://bugs.webkit.org/show_bug.cgi?id=61179 This is exteremely helpful when dealing with DOM wrappers, as their properties are mostly implemented with getters and thus not stored in heap snapshots. Reviewed by Pavel Feldman. * English.lproj/localizedStrings.js: * bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::objectByHeapObjectId): * bindings/js/ScriptProfiler.h: * bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::objectByHeapObjectId): * bindings/v8/ScriptProfiler.h: * inspector/Inspector.json: * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::create): (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::getObjectByHeapObjectId): * inspector/InspectorProfilerAgent.h: * inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent): (WebInspector.HeapSnapshotGenericObjectNode): (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data): (WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult): (WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent): (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL): * inspector/front-end/DetailedHeapshotView.js: (WebInspector.DetailedHeapshotView.prototype._showObjectPopover): * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshotNode.prototype.get canBeQueried): (WebInspector.HeapSnapshotNode.prototype.get flags): (WebInspector.HeapSnapshotNode.prototype.get isDOMWindow): (WebInspector.HeapSnapshot.prototype._init): (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype._flagsOfNode): (WebInspector.HeapSnapshot.prototype._calculateFlags): (WebInspector.HeapSnapshot.prototype.updateStaticData): (WebInspector.HeapSnapshotNodesProvider.prototype._serialize): * inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.get nodeFlags): * inspector/front-end/RemoteObject.js: (WebInspector.RemoteObject.fromError): * inspector/front-end/heapProfiler.css: (.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight): * inspector/profiler/heap-snapshot-expected.txt: * inspector/profiler/heap-snapshot-test.js: (initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM): (initialize_HeapSnapshotTest): * inspector/profiler/heap-snapshot.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt trunk/LayoutTests/inspector/profiler/heap-snapshot-test.js trunk/LayoutTests/inspector/profiler/heap-snapshot.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/English.lproj/localizedStrings.js trunk/Source/WebCore/bindings/js/ScriptProfiler.cpp trunk/Source/WebCore/bindings/js/ScriptProfiler.h trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp trunk/Source/WebCore/bindings/v8/ScriptProfiler.h trunk/Source/WebCore/inspector/Inspector.json trunk/Source/WebCore/inspector/InspectorController.cpp trunk/Source/WebCore/inspector/InspectorProfilerAgent.cpp trunk/Source/WebCore/inspector/InspectorProfilerAgent.h trunk/Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js trunk/Source/WebCore/inspector/front-end/HeapSnapshotProxy.js trunk/Source/WebCore/inspector/front-end/RemoteObject.js trunk/Source/WebCore/inspector/front-end/heapProfiler.css Diff Modified: trunk/LayoutTests/ChangeLog (97361 => 97362) --- trunk/LayoutTests/ChangeLog 2011-10-13 10:59:31 UTC (rev 97361) +++ trunk/LayoutTests/ChangeLog 2011-10-13 11:08:49 UTC (rev 97362) @@ -1,3 +1,20 @@ +2011-10-13 Mikhail Naganov + +Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile. +https://bugs.webkit.org/show_bug.cgi?id=61179 + +This is exteremely helpful when dealing with DOM wrappers, as +their properties are mostly implemented with getters and thus not +stored in heap snapshots. + +Reviewed by Pavel Feldman. + +* inspector/profiler/heap-snapshot-expected.txt: +* inspector/profiler/heap-snapshot-test.js: +(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM): +(initialize_HeapSnapshotTest): +* inspector/profiler/heap-snapshot.html: + 2011-10-13 Kent Tamura [Chromium] Fix test expectations. Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot-expected.txt (97361 => 97362) --- trunk/LayoutTests/inspector/profiler/heap-snapshot-
[webkit-changes] [97361] trunk/LayoutTests
Title: [97361] trunk/LayoutTests Revision 97361 Author tk...@chromium.org Date 2011-10-13 03:59:31 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Fix test expectations. * platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png Removed Paths trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png Diff Modified: trunk/LayoutTests/ChangeLog (97360 => 97361) --- trunk/LayoutTests/ChangeLog 2011-10-13 10:16:40 UTC (rev 97360) +++ trunk/LayoutTests/ChangeLog 2011-10-13 10:59:31 UTC (rev 97361) @@ -1,3 +1,10 @@ +2011-10-13 Kent Tamura + +[Chromium] Fix test expectations. + +* platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png. +* platform/chromium/test_expectations.txt: + 2011-10-13 Adam Barth script-src * should allow all URLs Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97360 => 97361) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 10:16:40 UTC (rev 97360) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 10:59:31 UTC (rev 97361) @@ -2714,7 +2714,7 @@ BUGCR97686 LINUX GPU RELEASE : media/video-controls-rendering.html = IMAGE // Take new baselines from the bots when 68035 lands. -BUGWK69624 MAC WIN GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE +BUGWK69624 MAC WIN GPU GPU-CG : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE MISSING BUGCR72223 : media/video-frame-accurate-seek.html = PASS IMAGE @@ -3876,6 +3876,11 @@ BUGWK69998 LINUX WIN : plugins/refcount-leaks.html = PASS TEXT BUGWK70001 LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL MISSING +// Randon crash in fast/canvas. +BUGWK70013 WIN GPU : fast/canvas/canvas-fillPath-gradient-shadow.html = PASS CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-strokePath-alpha-shadow.html = PASS CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-arc-360-winding.html = PASS CRASH +BUGWK70013 WIN GPU : fast/canvas/canvas-largedraws.html = PASS CRASH BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.composite.transparent.destination-atop.html = TIMEOUT BUGCR100056 MAC DEBUG : canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-5.html = TIMEOUT Copied: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png (from rev 97360, trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png) (Binary files differ) Property changes: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png Added: svn:mime-type Deleted: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97360] trunk
Title: [97360] trunk
Revision 97360
Author aba...@webkit.org
Date 2011-10-13 03:16:40 -0700 (Thu, 13 Oct 2011)
Log Message
script-src * should allow all URLs
https://bugs.webkit.org/show_bug.cgi?id=70011
Reviewed by Eric Seidel.
Source/WebCore:
This patch gets us slightly ahead of the spec. Technically, script-src
means "any host" and inherits the current scheme. However, that's not
what developers expect and it's even contradicted by examples in the
spec itself. After this patch, * matches all URLs.
Test: http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSourceList::CSPSourceList):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::addSourceStar):
LayoutTests:
Test that using * in script-src matches URLs with other schemes.
* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ContentSecurityPolicy.cpp
Added Paths
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97359 => 97360)
--- trunk/LayoutTests/ChangeLog 2011-10-13 10:12:34 UTC (rev 97359)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 10:16:40 UTC (rev 97360)
@@ -1,3 +1,15 @@
+2011-10-13 Adam Barth
+
+script-src * should allow all URLs
+https://bugs.webkit.org/show_bug.cgi?id=70011
+
+Reviewed by Eric Seidel.
+
+Test that using * in script-src matches URLs with other schemes.
+
+* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html: Added.
+
2011-10-13 Kent Tamura
[Chromium] Update test expectation.
Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt (0 => 97360)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt 2011-10-13 10:16:40 UTC (rev 97360)
@@ -0,0 +1,6 @@
+
+
+
+Frame: '-->'
+
+PASS
Added: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html (0 => 97360)
--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html 2011-10-13 10:16:40 UTC (rev 97360)
@@ -0,0 +1,14 @@
+
+
+
+
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.dumpChildFramesAsText();
+}
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (97359 => 97360)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 10:12:34 UTC (rev 97359)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 10:16:40 UTC (rev 97360)
@@ -1,3 +1,23 @@
+2011-10-13 Adam Barth
+
+script-src * should allow all URLs
+https://bugs.webkit.org/show_bug.cgi?id=70011
+
+Reviewed by Eric Seidel.
+
+This patch gets us slightly ahead of the spec. Technically, script-src
+means "any host" and inherits the current scheme. However, that's not
+what developers expect and it's even contradicted by examples in the
+spec itself. After this patch, * matches all URLs.
+
+Test: http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html
+
+* page/ContentSecurityPolicy.cpp:
+(WebCore::CSPSourceList::CSPSourceList):
+(WebCore::CSPSourceList::matches):
+(WebCore::CSPSourceList::parseSource):
+(WebCore::CSPSourceList::addSourceStar):
+
2011-10-13 Kentaro Hara
Implement an OverflowEvent constructor for JSC
Modified: trunk/Source/WebCore/page/ContentSecurityPolicy.cpp (97359 => 97360)
--- trunk/Source/WebCore/page/ContentSecurityPolicy.cpp 2011-10-13 10:12:34 UTC (rev 97359)
+++ trunk/Source/WebCore/page/ContentSecurityPolicy.cpp 2011-10-13 10:16:40 UTC (rev 97360)
@@ -190,17 +190,20 @@
bool parsePort(const UChar* begin, const UChar* end, int& port, bool& portHasWildcard);
void addSourceSelf();
+void addSourceStar();
void addSourceUnsafeInline();
void addSourceUnsafeEval();
SecurityOrigin* m_origin;
Vector m_list;
+bool m_allowStar;
bool m_allowInline;
bool m_allowEval;
};
CSPSourceList::CSPSourceList(SecurityOrigin* origin)
: m_origin(origin)
+, m_allowStar(false)
, m_allowInli
[webkit-changes] [97358] trunk/LayoutTests
Title: [97358] trunk/LayoutTests Revision 97358 Author tk...@chromium.org Date 2011-10-13 02:50:45 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Update test expectation. * platform/chromium-gpu-linux/media/video-playing-and-pause.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png Diff Modified: trunk/LayoutTests/ChangeLog (97357 => 97358) --- trunk/LayoutTests/ChangeLog 2011-10-13 09:30:37 UTC (rev 97357) +++ trunk/LayoutTests/ChangeLog 2011-10-13 09:50:45 UTC (rev 97358) @@ -1,5 +1,11 @@ 2011-10-13 Kent Tamura +[Chromium] Update test expectation. + +* platform/chromium-gpu-linux/media/video-playing-and-pause.png: Added. + +2011-10-13 Kent Tamura + Update expectation of xss-DENIED-contentWindow-eval.html for r97353 * http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Added: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97357] trunk/LayoutTests
Title: [97357] trunk/LayoutTests Revision 97357 Author tk...@chromium.org Date 2011-10-13 02:30:37 -0700 (Thu, 13 Oct 2011) Log Message Update expectation of xss-DENIED-contentWindow-eval.html for r97353 * http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/xss-DENIED-contentWindow-eval-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97356 => 97357) --- trunk/LayoutTests/ChangeLog 2011-10-13 09:13:47 UTC (rev 97356) +++ trunk/LayoutTests/ChangeLog 2011-10-13 09:30:37 UTC (rev 97357) @@ -1,3 +1,9 @@ +2011-10-13 Kent Tamura + +Update expectation of xss-DENIED-contentWindow-eval.html for r97353 + +* http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: + 2011-10-13 Kentaro Hara Implement an OverflowEvent constructor for JSC Modified: trunk/LayoutTests/http/tests/security/xss-DENIED-contentWindow-eval-expected.txt (97356 => 97357) --- trunk/LayoutTests/http/tests/security/xss-DENIED-contentWindow-eval-expected.txt 2011-10-13 09:13:47 UTC (rev 97356) +++ trunk/LayoutTests/http/tests/security/xss-DENIED-contentWindow-eval-expected.txt 2011-10-13 09:30:37 UTC (rev 97357) @@ -1,3 +1 @@ -CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL about:blank from frame with URL about:blank. Domains, protocols and ports must match. - This test passes if alert() is not called. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97356] trunk
Title: [97356] trunk
Revision 97356
Author hara...@chromium.org
Date 2011-10-13 02:13:47 -0700 (Thu, 13 Oct 2011)
Log Message
Implement an OverflowEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69907
Reviewed by Adam Barth.
Source/WebCore:
There is no spec for the OverflowEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initOverflowEvent(), the constructor IDL should be as follows.
[Constructor(DOMString type, optional OverflowEventInit eventInitDict)]
interface OverflowEvent : Event {
...;
}
dictionary OverflowEventInit : EventInit {
unsigned short orient;
boolean horizontalOverflow;
boolean verticalOverflow;
}
Note: In initOverflowEvent(), we cannot specify |bubbles| and |cancelable|.
I do not know why, but we can find a comment in fast/events/script-tests/init-events.js
that says "initOverflowEvent has an interface that has a design that's
inconsistent with the init functions from other events".
On the other hand, the above constructor enables to specify |bubbles| and |cancelable|,
which is consistent with other constructors.
Test: fast/events/constructors/overflow-event-constructor.html
* bindings/generic/EventConstructors.h: Added a definition for the OverflowEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for OverflowEvent.
* dom/OverflowEvent.cpp:
(WebCore::OverflowEventInit::OverflowEventInit):
(WebCore::OverflowEvent::OverflowEvent):
(WebCore::OverflowEvent::initOverflowEvent):
* dom/OverflowEvent.h: Added a definition for OverflowEventInit.
(WebCore::OverflowEvent::create):
(WebCore::OverflowEvent::orient):
(WebCore::OverflowEvent::horizontalOverflow):
(WebCore::OverflowEvent::verticalOverflow):
* dom/OverflowEvent.idl: Makes OverflowEvent constructible.
LayoutTests:
overflow-event-constructor.html checks the behavior of the OverflowEvent constructor.
* fast/dom/constructed-objects-prototypes-expected.txt: Added inner.OverflowEvent().
* fast/dom/dom-constructors-expected.txt: Updated the test result.
* fast/dom/dom-constructors.html: Removed OverflowEvent from test cases, since now OverflowEvent has a constructor.
* fast/events/constructors/overflow-event-constructor-expected.txt: Added.
* fast/events/constructors/overflow-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped overflow-event-constructor.html, since V8 does not yet have the OverflowEvent constructor.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors-expected.txt
trunk/LayoutTests/fast/dom/dom-constructors.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/EventConstructors.h
trunk/Source/WebCore/bindings/js/JSEventConstructors.cpp
trunk/Source/WebCore/dom/OverflowEvent.cpp
trunk/Source/WebCore/dom/OverflowEvent.h
trunk/Source/WebCore/dom/OverflowEvent.idl
Added Paths
trunk/LayoutTests/fast/events/constructors/overflow-event-constructor-expected.txt
trunk/LayoutTests/fast/events/constructors/overflow-event-constructor.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97355 => 97356)
--- trunk/LayoutTests/ChangeLog 2011-10-13 09:13:35 UTC (rev 97355)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 09:13:47 UTC (rev 97356)
@@ -1,3 +1,19 @@
+2011-10-13 Kentaro Hara
+
+Implement an OverflowEvent constructor for JSC
+https://bugs.webkit.org/show_bug.cgi?id=69907
+
+Reviewed by Adam Barth.
+
+overflow-event-constructor.html checks the behavior of the OverflowEvent constructor.
+
+* fast/dom/constructed-objects-prototypes-expected.txt: Added inner.OverflowEvent().
+* fast/dom/dom-constructors-expected.txt: Updated the test result.
+* fast/dom/dom-constructors.html: Removed OverflowEvent from test cases, since now OverflowEvent has a constructor.
+* fast/events/constructors/overflow-event-constructor-expected.txt: Added.
+* fast/events/constructors/overflow-event-constructor.html: Added.
+* platform/chromium/test_expectations.txt: Skipped overflow-event-constructor.html, since V8 does not yet have the OverflowEvent constructor.
+
2011-10-13 Adam Barth
DOMWindow subobjects can be re-created after navigation
Modified: trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt (97355 => 97356)
--- trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-10-13 09:13:35 UTC (rev 97355)
+++ trunk/LayoutTests/fast/dom/constructed-objects-prototypes-expected.txt 2011-10-13 09:13:47 UTC (rev 97356)
@@ -29,6 +29,8 @@
PASS (new inner.MessageEvent()).constructor.isInner is true
PASS (new inner.Option()).isInner is true
PASS (new inner.Option()).constructor.isInner is true
+PASS (new inner.OverflowEvent()).isInner is true
+PASS (new inner.OverflowEvent()).constructor.isInner is true
[webkit-changes] [97355] branches/chromium/874
Title: [97355] branches/chromium/874
Revision 97355
Author infe...@chromium.org
Date 2011-10-13 02:13:35 -0700 (Thu, 13 Oct 2011)
Log Message
Merge 97353 - DOMWindow subobjects can be re-created after navigation
BUG=96047
Review URL: http://codereview.chromium.org/8256010
Modified Paths
branches/chromium/874/Source/WebCore/page/DOMWindow.cpp
branches/chromium/874/Source/WebCore/page/DOMWindow.h
Added Paths
branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt
branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html
Diff
Copied: branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt (from rev 97353, trunk/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt) (0 => 97355)
--- branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt (rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt 2011-10-13 09:13:35 UTC (rev 97355)
@@ -0,0 +1 @@
+This tests passes if it doesn't alert the contents of innocent-victim.html.
Copied: branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html (from rev 97353, trunk/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html) (0 => 97355)
--- branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html (rev 0)
+++ branches/chromium/874/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html 2011-10-13 09:13:35 UTC (rev 97355)
@@ -0,0 +1,32 @@
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+window._onload_ = function()
+{
+frame = document.body.appendChild(document.createElement("iframe"));
+wnd = frame.contentWindow;
+func = wnd.Function;
+
+wnd.location = "about:blank";
+frame._onload_ = function() {
+selection = func("return getSelection()")();
+
+wnd.location = "http://localhost:8000/security/resources/innocent-victim.html";
+frame._onload_ = function() {
+frame._onload_ = null;
+
+try {
+selection.baseNode.constructor.constructor.constructor("alert(document.body.innerHTML)")()
+} catch(ex) {
+}
+
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+}
+}
+
+This tests passes if it doesn't alert the contents of innocent-victim.html.
Modified: branches/chromium/874/Source/WebCore/page/DOMWindow.cpp (97354 => 97355)
--- branches/chromium/874/Source/WebCore/page/DOMWindow.cpp 2011-10-13 09:08:18 UTC (rev 97354)
+++ branches/chromium/874/Source/WebCore/page/DOMWindow.cpp 2011-10-13 09:13:35 UTC (rev 97355)
@@ -405,6 +405,45 @@
if (m_frame)
m_frame->clearFormerDOMWindow(this);
+ASSERT(!m_screen);
+ASSERT(!m_selection);
+ASSERT(!m_history);
+ASSERT(!m_crypto);
+ASSERT(!m_locationbar);
+ASSERT(!m_menubar);
+ASSERT(!m_personalbar);
+ASSERT(!m_scrollbars);
+ASSERT(!m_statusbar);
+ASSERT(!m_toolbar);
+ASSERT(!m_console);
+ASSERT(!m_navigator);
+#if ENABLE(WEB_TIMING)
+ASSERT(!m_performance);
+#endif
+ASSERT(!m_location);
+ASSERT(!m_media);
+#if ENABLE(DOM_STORAGE)
+ASSERT(!m_sessionStorage);
+ASSERT(!m_localStorage);
+#endif
+ASSERT(!m_applicationCache);
+#if ENABLE(NOTIFICATIONS)
+ASSERT(!m_notifications);
+#endif
+#if ENABLE(INDEXED_DATABASE)
+ASSERT(!m_idbFactory);
+#endif
+#if ENABLE(BLOB)
+ASSERT(!m_domURL);
+#endif
+#if ENABLE(QUOTA)
+ASSERT(!m_storageInfo);
+#endif
+
+// This clear should be unnessary given the ASSERTs above, but we don't
+// want any of these objects to hang around after we've been destroyed.
+clear();
+
removeAllUnloadEventListeners(this);
removeAllBeforeUnloadEventListeners(this);
}
@@ -517,84 +556,97 @@
#if ENABLE(INDEXED_DATABASE)
m_idbFactory = 0;
#endif
+
+#if ENABLE(BLOB)
+m_domURL = 0;
+#endif
+
+#if ENABLE(QUOTA)
+m_storageInfo = 0;
+#endif
}
+bool DOMWindow::isCurrentlyDisplayedInFrame() const
+{
+return m_frame && m_frame->domWindow() == this;
+}
+
#if ENABLE(ORIENTATION_EVENTS)
int DOMWindow::orientation() const
{
if (!m_frame)
return 0;
-
+
return m_frame->orientation();
}
#endif
Screen* DOMWindow::screen() const
{
-if (!m_screen)
+if (!m_screen && isCurrentlyDisplayedInFrame())
m_screen = Screen::create(m_frame);
return m_screen.get();
}
History* DOMWindow::history() const
{
-if (!m_history)
+if (!m_history && isCurrentlyDisplayedInFra
[webkit-changes] [97353] trunk
Title: [97353] trunk Revision 97353 Author aba...@webkit.org Date 2011-10-13 01:53:50 -0700 (Thu, 13 Oct 2011) Log Message DOMWindow subobjects can be re-created after navigation https://bugs.webkit.org/show_bug.cgi?id=68849 Reviewed by Sam Weinig. Source/WebCore: Test: http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html * page/DOMWindow.cpp: (WebCore::DOMWindow::~DOMWindow): - Add ASSERTs to show that we're not recreating these objects. - Add a call to clear() as defense in depth in case we have any of these objects hanging around. (WebCore::DOMWindow::clear): - Clear out a couple of objects that weren't getting cleared. These are actually not likely to cause problems, but clearing them out is the safe thing to do. (WebCore::DOMWindow::isActive): - Add a concept of whether the DOMWindow is "active" in its frame. We had this concept in a couple places already, but centralizing it into a helper function make it easier to use and talk about. (WebCore::DOMWindow::orientation): - Whitespace nit. (WebCore::DOMWindow::screen): (WebCore::DOMWindow::history): (WebCore::DOMWindow::crypto): (WebCore::DOMWindow::locationbar): (WebCore::DOMWindow::menubar): (WebCore::DOMWindow::personalbar): (WebCore::DOMWindow::scrollbars): (WebCore::DOMWindow::statusbar): (WebCore::DOMWindow::toolbar): (WebCore::DOMWindow::console): (WebCore::DOMWindow::applicationCache): (WebCore::DOMWindow::navigator): (WebCore::DOMWindow::performance): (WebCore::DOMWindow::location): (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): (WebCore::DOMWindow::webkitNotifications): (WebCore::DOMWindow::webkitIndexedDB): (WebCore::DOMWindow::getSelection): (WebCore::DOMWindow::styleMedia): (WebCore::DOMWindow::webkitURL): (WebCore::DOMWindow::webkitStorageInfo): - Avoid creating these objects when we're not active. That can only lead to sadness. (WebCore::DOMWindow::webkitRequestFileSystem): (WebCore::DOMWindow::webkitResolveLocalFileSystemURL): (WebCore::DOMWindow::openDatabase): (WebCore::DOMWindow::postMessage): - While not techincally creating subobjects, these functions also seem unwise when the DOMWindow is inactive. (WebCore::DOMWindow::find): (WebCore::DOMWindow::length): (WebCore::DOMWindow::getMatchedCSSRules): - These functions operate on the active Document. When we're not active, that's not us! (WebCore::DOMWindow::document): - Update to use the new concept of being active rather than having this function roll its own implementation. (WebCore::DOMWindow::webkitConvertPointFromNodeToPage): (WebCore::DOMWindow::webkitConvertPointFromPageToNode): (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo): - These functions also look unwise to run when inactive because they're reading information from the active document. - I added a RefPtr for node because the call to updateLayoutIgnorePendingStylesheets() seems likely to be able to run script somehow. (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::dispatchLoadEvent): (WebCore::DOMWindow::dispatchEvent): - I don't think these functions worked when inactive anyway, but explicitly blocking them seems wise. (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::isInsecureScriptAccess): (WebCore::DOMWindow::open): (WebCore::DOMWindow::showModalDialog): - These already have checks for being active, but it can't hurt to be explicit at the top of the function. * page/DOMWindow.h: LayoutTests: * http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt: Added. * http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebCore/page/DOMWindow.h Added Paths trunk/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt trunk/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html Diff Modified: trunk/LayoutTests/ChangeLog (97352 => 97353) --- trunk/LayoutTests/ChangeLog 2011-10-13 07:50:55 UTC (rev 97352) +++ trunk/LayoutTests/ChangeLog 2011-10-13 08:53:50 UTC (rev 97353) @@ -1,3 +1,13 @@ +2011-10-13 Adam Barth + +DOMWindow subobjects can be re-created after navigation +https://bugs.webkit.org/show_bug.cgi?id=68849 + +Reviewed by Sam Weinig. + +* http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt: Added. +* http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html: Added. + 2011-10-13 Kent Tamura [Chromium] Fix errors in test_expectations.txt. Added: trunk/LayoutTests/http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt (0 => 97353) --- trunk/LayoutTests/http/tests/secur
[webkit-changes] [97352] trunk/LayoutTests
Title: [97352] trunk/LayoutTests Revision 97352 Author tk...@chromium.org Date 2011-10-13 00:50:55 -0700 (Thu, 13 Oct 2011) Log Message [Chromium] Fix errors in test_expectations.txt. * platform/chromium/test_expectations.txt: Remove duplicated entries for MAC DEBUG. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (97351 => 97352) --- trunk/LayoutTests/ChangeLog 2011-10-13 07:34:55 UTC (rev 97351) +++ trunk/LayoutTests/ChangeLog 2011-10-13 07:50:55 UTC (rev 97352) @@ -1,5 +1,12 @@ 2011-10-13 Kent Tamura +[Chromium] Fix errors in test_expectations.txt. + +* platform/chromium/test_expectations.txt: +Remove duplicated entries for MAC DEBUG. + +2011-10-13 Kent Tamura + REGRESSION(r89915): don't show the default value https://bugs.webkit.org/show_bug.cgi?id=69895 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (97351 => 97352) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 07:34:55 UTC (rev 97351) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-13 07:50:55 UTC (rev 97352) @@ -3912,7 +3912,6 @@ BUGCR100056 WIN DEBUG : fast/frames/viewsource-unfinished-tags.html = TIMEOUT PASS BUGCR100056 MAC DEBUG SLOW : canvas/philip/tests/2d.gradient.radial.equal.html = PASS -BUGCR100056 MAC DEBUG SLOW : canvas/philip/tests/2d.gradient.radial.inside3.html = PASS BUGCR100056 MAC DEBUG SLOW : canvas/philip/tests/2d.imageData.create2.basic.html = PASS BUGCR100056 MAC DEBUG SLOW : canvas/philip/tests/2d.path.isPointInPath.arc.html = PASS BUGCR100056 MAC DEBUG SLOW : dom/html/level1/core/hc_nodeappendchildnodeancestor.html = PASS @@ -3945,7 +3944,6 @@ BUGCR100056 MAC DEBUG SLOW : fast/block/child-not-removed-from-parent-lineboxes-crash.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/context-lost-restored.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/gl-teximage.html = PASS -BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/premultiplyalpha-test.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/program-test.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/texture-npot.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/canvas/webgl/texture-transparent-pixels-initialized.html = PASS @@ -3978,7 +3976,6 @@ BUGCR100056 MAC DEBUG SLOW : fast/frames/calculate-order.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/harness/show-modal-dialog.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/history/history-back-initial-vs-final-url.html = PASS -BUGCR100056 MAC DEBUG SLOW : fast/history/sibling-visited-test.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/images/destroyed-image-load-event.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/js/pic/delete-global-object.html = PASS BUGCR100056 MAC DEBUG SLOW : fast/loader/data-url-encoding-html.html = PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97351] trunk
Title: [97351] trunk
Revision 97351
Author tk...@chromium.org
Date 2011-10-13 00:34:55 -0700 (Thu, 13 Oct 2011)
Log Message
REGRESSION(r89915): don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895
Reviewed by Hajime Morita.
Source/WebCore:
m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.
To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::sanitizeValue):
- Make this const.
- Remove null check.
* html/ColorInputType.h: Make sanitizeValue() const.
* html/EmailInputType.cpp:
(WebCore::EmailInputType::sanitizeValue): Make this const.
* html/EmailInputType.h: Make sanitizeValue() const.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):
* html/InputType.cpp:
(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.
* html/InputType.h: Make sanitizeValue() const.
* html/NumberInputType.cpp:
(WebCore::NumberInputType::sanitizeValue): Make this const.
* html/NumberInputType.h: Make sanitizeValue() const.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::sanitizeValue):
- Make this const.
- Remove null check.
* html/RangeInputType.h: Make sanitizeValue() const.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::sanitizeValue): Make this const.
* html/TextFieldInputType.h: Make sanitizeValue() const.
LayoutTests:
* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/input-value-sanitization.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/input-value-sanitization-expected.txt
trunk/LayoutTests/fast/forms/input-value-sanitization.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/ColorInputType.cpp
trunk/Source/WebCore/html/ColorInputType.h
trunk/Source/WebCore/html/EmailInputType.cpp
trunk/Source/WebCore/html/EmailInputType.h
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/html/NumberInputType.cpp
trunk/Source/WebCore/html/NumberInputType.h
trunk/Source/WebCore/html/RangeInputType.cpp
trunk/Source/WebCore/html/RangeInputType.h
trunk/Source/WebCore/html/TextFieldInputType.cpp
trunk/Source/WebCore/html/TextFieldInputType.h
Diff
Modified: trunk/LayoutTests/ChangeLog (97350 => 97351)
--- trunk/LayoutTests/ChangeLog 2011-10-13 07:32:31 UTC (rev 97350)
+++ trunk/LayoutTests/ChangeLog 2011-10-13 07:34:55 UTC (rev 97351)
@@ -1,3 +1,13 @@
+2011-10-13 Kent Tamura
+
+REGRESSION(r89915): don't show the default value
+https://bugs.webkit.org/show_bug.cgi?id=69895
+
+Reviewed by Hajime Morita.
+
+* fast/forms/input-value-sanitization-expected.txt:
+* fast/forms/input-value-sanitization.html:
+
2011-10-13 Csaba Osztrogonác
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/forms/input-value-sanitization-expected.txt (97350 => 97351)
--- trunk/LayoutTests/fast/forms/input-value-sanitization-expected.txt 2011-10-13 07:32:31 UTC (rev 97350)
+++ trunk/LayoutTests/fast/forms/input-value-sanitization-expected.txt 2011-10-13 07:34:55 UTC (rev 97351)
@@ -1,6 +1,11 @@
Tests for value sanitization algorithm.
+Email with multiple:
+PASS input.value is "tk...@chromium.org,tkent@example.!!!"
+Email without multiple:
+PASS input.value is " tk...@chromium.org, tkent@example.*** "
+
Number:
PASS input.value is "65536"
PASS input.value = "256"; input.value is "256"
Modified: trunk/LayoutTests/fast/forms/input-value-sanitization.html (97350 => 97351)
--- trunk/LayoutTests/fast/forms/input-value-sanitization.html 2011-10-13 07:32:31 UTC (rev 97350)
+++ trunk/LayoutTests/fast/forms/input-value-sanitization.html 2011-10-13 07:34:55 UTC (rev 97351)
@@ -11,6 +11,20 @@
var input;
debug('');
+debug('Email with multiple:');
+input = document.createElement('input');
+input.multiple = true;
+input.type = 'email';
+input.setAttribute('value', ' tk...@chromium.org, tkent@example.!!! ');
+shouldBe('input.value', '"tk...@chromium.org,tkent@example.!!!"');
+debug('Email without multiple:');
+input = document.createElement('input');
+input.multiple = false;
+input.type = 'email';
+input.setAttribute('value', ' tk...@chromium.org, tkent@example.*** \r\n');
+shouldBe('input.value', '" tk...@chromium.org, tkent@example.*** "');
+
+debug('');
debug('Number:');
input = document.createElement('input');
input.setAttribute('value', '65536');
Modified: trunk/Source/WebCore/ChangeLog (97350 => 97351)
--- trunk/Source/WebCore/ChangeLog 2011-10-13 07:32:31 UTC (rev 97350)
+++ trunk/Source/WebCore/ChangeLog 2011-10-13 07:34:55 UTC (rev 97351)
@@ -1,3 +1,
[webkit-changes] [97350] trunk/Tools
Title: [97350] trunk/Tools
Revision 97350
Author tk...@chromium.org
Date 2011-10-13 00:32:31 -0700 (Thu, 13 Oct 2011)
Log Message
[Chromium] A DRT fix for r97348.
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::overridePreference):
Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
print an error message.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
Diff
Modified: trunk/Tools/ChangeLog (97349 => 97350)
--- trunk/Tools/ChangeLog 2011-10-13 07:07:15 UTC (rev 97349)
+++ trunk/Tools/ChangeLog 2011-10-13 07:32:31 UTC (rev 97350)
@@ -1,3 +1,12 @@
+2011-10-13 Kent Tamura
+
+[Chromium] A DRT fix for r97348.
+
+* DumpRenderTree/chromium/LayoutTestController.cpp:
+(LayoutTestController::overridePreference):
+Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
+print an error message.
+
2011-10-12 Lucas Forschler
Update kill-old-processes logic.
Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp (97349 => 97350)
--- trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp 2011-10-13 07:07:15 UTC (rev 97349)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp 2011-10-13 07:32:31 UTC (rev 97350)
@@ -1439,7 +1439,9 @@
prefs->allowRunningOfInsecureContent = cppVariantToBool(value);
else if (key == "WebKitHixie76WebSocketProtocolEnabled")
prefs->hixie76WebSocketProtocolEnabled = cppVariantToBool(value);
-else {
+else if (key == "WebKitWebAudioEnabled") {
+ASSERT(cppVariantToBool(value));
+} else {
string message("Invalid name for preference: ");
message.append(key);
logErrorToConsole(message);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97349] trunk/LayoutTests
Title: [97349] trunk/LayoutTests Revision 97349 Author o...@webkit.org Date 2011-10-13 00:07:15 -0700 (Thu, 13 Oct 2011) Log Message [Qt] Unreviewed gardening. Web Inspector: REGRESSION(r97267): It made 3 tests fail on the Qt bot https://bugs.webkit.org/show_bug.cgi?id=70005 * platform/qt/Skipped: Skip failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (97348 => 97349) --- trunk/LayoutTests/ChangeLog 2011-10-13 06:52:56 UTC (rev 97348) +++ trunk/LayoutTests/ChangeLog 2011-10-13 07:07:15 UTC (rev 97349) @@ -1,3 +1,12 @@ +2011-10-13 Csaba Osztrogonác + +[Qt] Unreviewed gardening. + +Web Inspector: REGRESSION(r97267): It made 3 tests fail on the Qt bot +https://bugs.webkit.org/show_bug.cgi?id=70005 + +* platform/qt/Skipped: Skip failing tests. + 2011-10-11 Philippe Normand Tests don't override the WebKitWebAudioEnabled runtime preference Modified: trunk/LayoutTests/platform/qt/Skipped (97348 => 97349) --- trunk/LayoutTests/platform/qt/Skipped 2011-10-13 06:52:56 UTC (rev 97348) +++ trunk/LayoutTests/platform/qt/Skipped 2011-10-13 07:07:15 UTC (rev 97349) @@ -2413,3 +2413,9 @@ # [Qt] Assertion fail in CSSPrimitiveValue ctor # https://bugs.webkit.org/show_bug.cgi?id=69933 fast/borders/inline-mask-overlay-image-outset-vertical-rl.html + +# Web Inspector: REGRESSION(r97267): It made 3 tests fail on the Qt bot +# https://bugs.webkit.org/show_bug.cgi?id=70005 +http/tests/inspector/resource-tree/resource-tree-document-url.html +http/tests/inspector/resource-tree/resource-tree-frame-navigate.html +http/tests/inspector/resource-tree/resource-tree-non-unique-url.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
