[webkit-changes] [97575] trunk
Title: [97575] trunk
Revision 97575
Author m...@apple.com
Date 2011-10-16 08:55:33 -0700 (Sun, 16 Oct 2011)
Log Message
REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
https://bugs.webkit.org/show_bug.cgi?id=70197
Reviewed by Dave Kilzer.
Source/WebCore:
Test: fast/block/float/avoidance-rtl.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Changed
logicalLeftOffsetForContent() to startOffsetForContent() to get the right value in the
right-to-left case.
LayoutTests:
* fast/block/float/avoidance-rtl-expected.png: Added.
* fast/block/float/avoidance-rtl-expected.txt: Added.
* fast/block/float/avoidance-rtl.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.png
trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.txt
trunk/LayoutTests/fast/block/float/avoidance-rtl.html
Diff
Modified: trunk/LayoutTests/ChangeLog (97574 => 97575)
--- trunk/LayoutTests/ChangeLog 2011-10-16 10:28:50 UTC (rev 97574)
+++ trunk/LayoutTests/ChangeLog 2011-10-16 15:55:33 UTC (rev 97575)
@@ -1,3 +1,14 @@
+2011-10-16 Dan Bernstein m...@apple.com
+
+REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
+https://bugs.webkit.org/show_bug.cgi?id=70197
+
+Reviewed by Dave Kilzer.
+
+* fast/block/float/avoidance-rtl-expected.png: Added.
+* fast/block/float/avoidance-rtl-expected.txt: Added.
+* fast/block/float/avoidance-rtl.html: Added.
+
2011-10-16 Adam Barth aba...@webkit.org
Always enable ENABLE(DOM_STORAGE)
Added: trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.txt (0 => 97575)
--- trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/block/float/avoidance-rtl-expected.txt 2011-10-16 15:55:33 UTC (rev 97575)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 250x100 [bgcolor=#FF] [border: (50px solid #008000)]
+RenderBlock (floating) {DIV} at (150,0) size 100x100 [bgcolor=#008000]
+layer at (58,8) size 100x100
+ RenderBlock {DIV} at (50,0) size 100x100 [bgcolor=#008000]
Added: trunk/LayoutTests/fast/block/float/avoidance-rtl.html (0 => 97575)
--- trunk/LayoutTests/fast/block/float/avoidance-rtl.html (rev 0)
+++ trunk/LayoutTests/fast/block/float/avoidance-rtl.html 2011-10-16 15:55:33 UTC (rev 97575)
@@ -0,0 +1,4 @@
+div style=border-left: 50px solid green; direction: rtl; width: 200; background-color: red;
+div style=background-color: green; width: 100px; height: 100px; float: right;/div
+div style=overflow: hidden; background-color: green; height: 100px; width: 100px;/div
+/div
Modified: trunk/Source/WebCore/ChangeLog (97574 => 97575)
--- trunk/Source/WebCore/ChangeLog 2011-10-16 10:28:50 UTC (rev 97574)
+++ trunk/Source/WebCore/ChangeLog 2011-10-16 15:55:33 UTC (rev 97575)
@@ -1,3 +1,17 @@
+2011-10-16 Dan Bernstein m...@apple.com
+
+REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
+https://bugs.webkit.org/show_bug.cgi?id=70197
+
+Reviewed by Dave Kilzer.
+
+Test: fast/block/float/avoidance-rtl.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Changed
+logicalLeftOffsetForContent() to startOffsetForContent() to get the right value in the
+right-to-left case.
+
2011-10-16 Adam Barth aba...@webkit.org
Always enable ENABLE(DOM_STORAGE)
Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (97574 => 97575)
--- trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-10-16 10:28:50 UTC (rev 97574)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp 2011-10-16 15:55:33 UTC (rev 97575)
@@ -1812,7 +1812,7 @@
LayoutUnit RenderBlock::computeStartPositionDeltaForChildAvoidingFloats(const RenderBox* child, LayoutUnit childMarginStart,
LayoutUnit childLogicalWidth, RenderRegion* region, LayoutUnit offsetFromLogicalTopOfFirstPage)
{
-LayoutUnit startPosition = logicalLeftOffsetForContent(region, offsetFromLogicalTopOfFirstPage);
+LayoutUnit startPosition = startOffsetForContent(region, offsetFromLogicalTopOfFirstPage);
// Add in our start margin.
LayoutUnit oldPosition = startPosition +
[webkit-changes] [97576] trunk/Source/WebCore
Title: [97576] trunk/Source/WebCore
Revision 97576
Author dslo...@google.com
Date 2011-10-16 12:19:42 -0700 (Sun, 16 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70186
Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.
Reviewed by Oliver Hunt.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
(WebCore::JSDOMWindow::postMessage):
(WebCore::JSDOMWindow::webkitPostMessage):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
(WebCore::JSMessageEvent::initMessageEvent):
(WebCore::JSMessageEvent::webkitInitMessageEvent):
* bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
* bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):
* bindings/js/SerializedScriptValue.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSDictionary.cpp
trunk/Source/WebCore/bindings/js/JSHistoryCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSMessagePortCustom.h
trunk/Source/WebCore/bindings/js/JSPopStateEventCustom.cpp
trunk/Source/WebCore/bindings/js/ScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp
trunk/Source/WebCore/bindings/js/SerializedScriptValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (97575 => 97576)
--- trunk/Source/WebCore/ChangeLog 2011-10-16 15:55:33 UTC (rev 97575)
+++ trunk/Source/WebCore/ChangeLog 2011-10-16 19:19:42 UTC (rev 97576)
@@ -1,3 +1,36 @@
+2011-10-16 Dmitry Lomov dslo...@google.com
+
+https://bugs.webkit.org/show_bug.cgi?id=70186
+Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.
+
+Reviewed by Oliver Hunt.
+
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::handlePostMessage):
+(WebCore::JSDOMWindow::postMessage):
+(WebCore::JSDOMWindow::webkitPostMessage):
+* bindings/js/JSDictionary.cpp:
+(WebCore::JSDictionary::convertValue):
+* bindings/js/JSHistoryCustom.cpp:
+(WebCore::JSHistory::pushState):
+(WebCore::JSHistory::replaceState):
+* bindings/js/JSMessageEventCustom.cpp:
+(WebCore::JSMessageEvent::data):
+(WebCore::handleInitMessageEvent):
+(WebCore::JSMessageEvent::initMessageEvent):
+(WebCore::JSMessageEvent::webkitInitMessageEvent):
+* bindings/js/JSMessagePortCustom.h:
+(WebCore::handlePostMessage):
+* bindings/js/JSPopStateEventCustom.cpp:
+(WebCore::JSPopStateEvent::state):
+* bindings/js/ScriptValue.cpp:
+(WebCore::ScriptValue::serialize):
+(WebCore::ScriptValue::deserialize):
+* bindings/js/SerializedScriptValue.cpp:
+(WebCore::SerializedScriptValue::create):
+(WebCore::SerializedScriptValue::deserialize):
+* bindings/js/SerializedScriptValue.h:
+
2011-10-16 Dan Bernstein m...@apple.com
REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (97575 => 97576)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-10-16 15:55:33 UTC (rev 97575)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2011-10-16 19:19:42 UTC (rev 97576)
@@ -715,33 +715,39 @@
return handler.returnValue();
}
-JSValue JSDOMWindow::postMessage(ExecState* exec)
+static JSValue handlePostMessage(DOMWindow* impl, ExecState* exec, bool doTransfer)
{
-RefPtrSerializedScriptValue message = SerializedScriptValue::create(exec, exec-argument(0));
-
-if (exec-hadException())
-return jsUndefined();
-
MessagePortArray messagePorts;
if (exec-argumentCount() 2)
fillMessagePortArray(exec, exec-argument(1), messagePorts);
if (exec-hadException())
return jsUndefined();
+RefPtrSerializedScriptValue message = SerializedScriptValue::create(exec, exec-argument(0),
+ doTransfer ? messagePorts : 0);
+
+if (exec-hadException())
+return jsUndefined();
+
String targetOrigin = valueToStringWithUndefinedOrNullCheck(exec, exec-argument((exec-argumentCount() == 2) ? 1 : 2));
if (exec-hadException())
return jsUndefined();
ExceptionCode ec = 0;
-impl()-postMessage(message.release(), messagePorts, targetOrigin, activeDOMWindow(exec), ec);
+
[webkit-changes] [97577] trunk/LayoutTests
Title: [97577] trunk/LayoutTests Revision 97577 Author o...@webkit.org Date 2011-10-16 14:37:25 -0700 (Sun, 16 Oct 2011) Log Message [Qt] Unreviewed weekend gardening. * platform/qt/fast/dom/Window/window-properties-expected.txt: * platform/qt/fast/files/url-required-arguments-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt Added Paths trunk/LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (97576 => 97577) --- trunk/LayoutTests/ChangeLog 2011-10-16 19:19:42 UTC (rev 97576) +++ trunk/LayoutTests/ChangeLog 2011-10-16 21:37:25 UTC (rev 97577) @@ -1,3 +1,10 @@ +2011-10-16 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed weekend gardening. + +* platform/qt/fast/dom/Window/window-properties-expected.txt: +* platform/qt/fast/files/url-required-arguments-expected.txt: Added. + 2011-10-16 Dan Bernstein m...@apple.com REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (97576 => 97577) --- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-10-16 19:19:42 UTC (rev 97576) +++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2011-10-16 21:37:25 UTC (rev 97577) @@ -44,6 +44,7 @@ window.Audio [object AudioConstructor] window.Audio.length [number] window.Audio.prototype [object HTMLAudioElementPrototype] +window.Audio.prototype.ALLOW_KEYBOARD_INPUT [number] window.Audio.prototype.ATTRIBUTE_NODE [number] window.Audio.prototype.CDATA_SECTION_NODE [number] window.Audio.prototype.COMMENT_NODE [number] @@ -124,6 +125,7 @@ window.Audio.prototype.setAttributeNode [function] window.Audio.prototype.setAttributeNodeNS [function] window.Audio.prototype.webkitMatchesSelector [function] +window.Audio.prototype.webkitRequestFullScreen [function] window.BeforeLoadEvent [object BeforeLoadEventConstructor] window.BeforeLoadEvent.prototype [object BeforeLoadEventPrototype] window.BeforeLoadEvent.prototype.AT_TARGET [number] @@ -727,6 +729,7 @@ window.Document.prototype.removeChild [function] window.Document.prototype.removeEventListener [function] window.Document.prototype.replaceChild [function] +window.Document.prototype.webkitCancelFullScreen [function] window.DocumentFragment [object DocumentFragmentConstructor] window.DocumentFragment.prototype [object DocumentFragmentPrototype] window.DocumentFragment.prototype.ATTRIBUTE_NODE [number] @@ -808,7 +811,9 @@ window.DocumentType.prototype.removeEventListener [function] window.DocumentType.prototype.replaceChild [function] window.Element [object ElementConstructor] +window.Element.ALLOW_KEYBOARD_INPUT [number] window.Element.prototype [object ElementPrototype] +window.Element.prototype.ALLOW_KEYBOARD_INPUT [number] window.Element.prototype.ATTRIBUTE_NODE [number] window.Element.prototype.CDATA_SECTION_NODE [number] window.Element.prototype.COMMENT_NODE [number] @@ -873,6 +878,7 @@ window.Element.prototype.setAttributeNode [function] window.Element.prototype.setAttributeNodeNS [function] window.Element.prototype.webkitMatchesSelector [function] +window.Element.prototype.webkitRequestFullScreen [function] window.Entity [object EntityConstructor] window.Entity.prototype [object EntityPrototype] window.Entity.prototype.ATTRIBUTE_NODE [number] Added: trunk/LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt (0 => 97577) --- trunk/LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/fast/files/url-required-arguments-expected.txt 2011-10-16 21:37:25 UTC (rev 97577) @@ -0,0 +1,10 @@ +Test required arguments of URL object. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + +PASS webkitURL.createObjectURL() threw exception TypeError: Not enough arguments. +PASS webkitURL.revokeObjectURL() threw exception TypeError: Not enough arguments. +PASS successfullyParsed is true + +TEST COMPLETE + ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97580] trunk/Source/WebCore
Title: [97580] trunk/Source/WebCore
Revision 97580
Author hara...@chromium.org
Date 2011-10-16 19:02:18 -0700 (Sun, 16 Oct 2011)
Log Message
Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
https://bugs.webkit.org/show_bug.cgi?id=70206
Reviewed by Adam Barth.
Tests: fast/xsl/xslt-processor.html
fast/xsl/default-html.html
fast/dom/global-constructors.html
* bindings/js/JSXSLTProcessorCustom.cpp: Removed a custom constructor.
* xml/XSLTProcessor.idl: Removed 'JSCustomConstructor'.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp
trunk/Source/WebCore/xml/XSLTProcessor.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (97579 => 97580)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 01:11:52 UTC (rev 97579)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 02:02:18 UTC (rev 97580)
@@ -1,5 +1,19 @@
2011-10-16 Kentaro Hara hara...@chromium.org
+Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
+https://bugs.webkit.org/show_bug.cgi?id=70206
+
+Reviewed by Adam Barth.
+
+Tests: fast/xsl/xslt-processor.html
+ fast/xsl/default-html.html
+ fast/dom/global-constructors.html
+
+* bindings/js/JSXSLTProcessorCustom.cpp: Removed a custom constructor.
+* xml/XSLTProcessor.idl: Removed 'JSCustomConstructor'.
+
+2011-10-16 Kentaro Hara hara...@chromium.org
+
Support [Constructor] IDL for JSC.
https://bugs.webkit.org/show_bug.cgi?id=70101
Modified: trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp (97579 => 97580)
--- trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp 2011-10-17 01:11:52 UTC (rev 97579)
+++ trunk/Source/WebCore/bindings/js/JSXSLTProcessorCustom.cpp 2011-10-17 02:02:18 UTC (rev 97580)
@@ -116,12 +116,6 @@
return jsUndefined();
}
-EncodedJSValue JSC_HOST_CALL JSXSLTProcessorConstructor::constructJSXSLTProcessor(ExecState* exec)
-{
-JSXSLTProcessorConstructor* jsConstructor = static_castJSXSLTProcessorConstructor*(exec-callee());
-return JSValue::encode(CREATE_DOM_WRAPPER(exec, jsConstructor-globalObject(), XSLTProcessor, XSLTProcessor::create().get()));
-}
-
} // namespace WebCore
#endif // ENABLE(XSLT)
Modified: trunk/Source/WebCore/xml/XSLTProcessor.idl (97579 => 97580)
--- trunk/Source/WebCore/xml/XSLTProcessor.idl 2011-10-17 01:11:52 UTC (rev 97579)
+++ trunk/Source/WebCore/xml/XSLTProcessor.idl 2011-10-17 02:02:18 UTC (rev 97580)
@@ -35,7 +35,6 @@
interface [
Conditional=XSLT,
CanBeConstructed,
-JSCustomConstructor,
Constructor
] XSLTProcessor {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [97581] trunk/Source/WebCore
Title: [97581] trunk/Source/WebCore
Revision 97581
Author hara...@chromium.org
Date 2011-10-16 20:13:53 -0700 (Sun, 16 Oct 2011)
Log Message
Generate XMLHttpRequest constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70208
Reviewed by Adam Barth.
This patch generates an XMLHttpRequest constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires a special logic.
Tests: fast/dom/global-constructors.html
fast/dom/XMLHttpRequest-constants.html
fast/dom/xmlhttprequest-constructor-in-detached-document.html
http/tests/security/cookies/xmlhttprequest.html
* bindings/js/JSXMLHttpRequestCustom.cpp: Removed an XMLHttpRequest custom constructor.
* bindings/scripts/CodeGeneratorV8.pm: Currently, CodeGeneratorV8.pm generates constructor code whenever [Constructor] is specified, even if [V8CustomConstructor] is specified. This is wrong. This patch fixes the condition where the constructor code is generated.
* bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-binding-tests result.
* xml/XMLHttpRequest.h: Added a necessary header.
* xml/XMLHttpRequest.idl: V8 is still using a custom constructor.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/xml/XMLHttpRequest.h
trunk/Source/WebCore/xml/XMLHttpRequest.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (97580 => 97581)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 02:02:18 UTC (rev 97580)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 03:13:53 UTC (rev 97581)
@@ -1,5 +1,26 @@
2011-10-16 Kentaro Hara hara...@chromium.org
+Generate XMLHttpRequest constructor for JSC by [Constructor] IDL
+https://bugs.webkit.org/show_bug.cgi?id=70208
+
+Reviewed by Adam Barth.
+
+This patch generates an XMLHttpRequest constructor for JSC by [Constructor] IDL,
+but V8 is still using a custom constructor since the V8 constructor requires a special logic.
+
+Tests: fast/dom/global-constructors.html
+ fast/dom/XMLHttpRequest-constants.html
+ fast/dom/xmlhttprequest-constructor-in-detached-document.html
+ http/tests/security/cookies/xmlhttprequest.html
+
+* bindings/js/JSXMLHttpRequestCustom.cpp: Removed an XMLHttpRequest custom constructor.
+* bindings/scripts/CodeGeneratorV8.pm: Currently, CodeGeneratorV8.pm generates constructor code whenever [Constructor] is specified, even if [V8CustomConstructor] is specified. This is wrong. This patch fixes the condition where the constructor code is generated.
+* bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-binding-tests result.
+* xml/XMLHttpRequest.h: Added a necessary header.
+* xml/XMLHttpRequest.idl: V8 is still using a custom constructor.
+
+2011-10-16 Kentaro Hara hara...@chromium.org
+
Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
https://bugs.webkit.org/show_bug.cgi?id=70206
Modified: trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp (97580 => 97581)
--- trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2011-10-17 02:02:18 UTC (rev 97580)
+++ trunk/Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp 2011-10-17 03:13:53 UTC (rev 97581)
@@ -203,15 +203,4 @@
return jsUndefined();
}
-EncodedJSValue JSC_HOST_CALL JSXMLHttpRequestConstructor::constructJSXMLHttpRequest(ExecState* exec)
-{
-JSXMLHttpRequestConstructor* jsConstructor = static_castJSXMLHttpRequestConstructor*(exec-callee());
-ScriptExecutionContext* context = jsConstructor-scriptExecutionContext();
-if (!context)
-return throwVMError(exec, createReferenceError(exec, XMLHttpRequest constructor associated document is unavailable));
-
-RefPtrXMLHttpRequest xmlHttpRequest = XMLHttpRequest::create(context);
-return JSValue::encode(CREATE_DOM_WRAPPER(exec, jsConstructor-globalObject(), XMLHttpRequest, xmlHttpRequest.get()));
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (97580 => 97581)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-17 02:02:18 UTC (rev 97580)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2011-10-17 03:13:53 UTC (rev 97581)
@@ -2153,9 +2153,7 @@
}
END
-}
-
-if ($dataNode-extendedAttributes-{Constructor}) {
+} elsif ($dataNode-extendedAttributes-{CanBeConstructed} !($dataNode-extendedAttributes-{V8CustomConstructor} || $dataNode-extendedAttributes-{CustomConstructor})) {
GenerateConstructorCallback($dataNode-constructor, $dataNode, $interfaceName);
}
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (97580 => 97581)
---
[webkit-changes] [97583] trunk/Source/WebCore
Title: [97583] trunk/Source/WebCore Revision 97583 Author commit-qu...@webkit.org Date 2011-10-16 21:27:09 -0700 (Sun, 16 Oct 2011) Log Message Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function https://bugs.webkit.org/show_bug.cgi?id=64865 Patch by David Barr davidb...@chromium.org on 2011-10-16 Reviewed by Darin Adler. Based on profiling and patch from: Tamas Czene czene.ta...@stud.u-szeged.hu This is expected to produce a small performance progression. Additional memory overhead is avoided by using spare bits. CSSQuirkPrimitiveValue is removed as it becomes just a factory. * GNUmakefile.list.am: * WebCore.gypi: * WebCore.order: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * css/CSSParser.cpp: (WebCore::CSSParser::parseValidPrimitive): * css/CSSParserValues.cpp: (WebCore::CSSParserValue::createCSSValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::createAllowingMarginQuirk): Moved from CSSQuirkPrimitiveValue::create. (WebCore::CSSPrimitiveValue::isQuirkValue): * css/CSSQuirkPrimitiveValue.h: Removed. * css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.order trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSParserValues.cpp trunk/Source/WebCore/css/CSSPrimitiveValue.cpp trunk/Source/WebCore/css/CSSPrimitiveValue.h trunk/Source/WebCore/css/SVGCSSParser.cpp Removed Paths trunk/Source/WebCore/css/CSSQuirkPrimitiveValue.h Diff Modified: trunk/Source/WebCore/ChangeLog (97582 => 97583) --- trunk/Source/WebCore/ChangeLog 2011-10-17 04:03:37 UTC (rev 97582) +++ trunk/Source/WebCore/ChangeLog 2011-10-17 04:27:09 UTC (rev 97583) @@ -1,3 +1,36 @@ +2011-10-16 David Barr davidb...@chromium.org + +Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function +https://bugs.webkit.org/show_bug.cgi?id=64865 + +Reviewed by Darin Adler. + +Based on profiling and patch from: +Tamas Czene czene.ta...@stud.u-szeged.hu + +This is expected to produce a small performance progression. +Additional memory overhead is avoided by using spare bits. +CSSQuirkPrimitiveValue is removed as it becomes just a factory. + +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.order: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* css/CSSParser.cpp: +(WebCore::CSSParser::parseValidPrimitive): +* css/CSSParserValues.cpp: +(WebCore::CSSParserValue::createCSSValue): +* css/CSSPrimitiveValue.cpp: +(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): +* css/CSSPrimitiveValue.h: +(WebCore::CSSPrimitiveValue::createAllowingMarginQuirk): +Moved from CSSQuirkPrimitiveValue::create. +(WebCore::CSSPrimitiveValue::isQuirkValue): +* css/CSSQuirkPrimitiveValue.h: Removed. +* css/SVGCSSParser.cpp: +(WebCore::CSSParser::parseSVGValue): + 2011-10-16 Kentaro Hara hara...@chromium.org Generate XMLHttpRequest constructor for JSC by [Constructor] IDL Modified: trunk/Source/WebCore/GNUmakefile.list.am (97582 => 97583) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-10-17 04:03:37 UTC (rev 97582) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-10-17 04:27:09 UTC (rev 97583) @@ -993,7 +993,6 @@ Source/WebCore/css/CSSPropertyLonghand.h \ Source/WebCore/css/CSSPropertySourceData.cpp \ Source/WebCore/css/CSSPropertySourceData.h \ - Source/WebCore/css/CSSQuirkPrimitiveValue.h \ Source/WebCore/css/CSSReflectionDirection.h \ Source/WebCore/css/CSSReflectValue.cpp \ Source/WebCore/css/CSSReflectValue.h \ Modified: trunk/Source/WebCore/WebCore.gypi (97582 => 97583) --- trunk/Source/WebCore/WebCore.gypi 2011-10-17 04:03:37 UTC (rev 97582) +++ trunk/Source/WebCore/WebCore.gypi 2011-10-17 04:27:09 UTC (rev 97583) @@ -2380,7 +2380,6 @@ 'css/CSSPropertyLonghand.cpp', 'css/CSSPropertyLonghand.h', 'css/CSSPropertySourceData.cpp', -'css/CSSQuirkPrimitiveValue.h', 'css/CSSReflectValue.cpp', 'css/CSSRule.cpp', 'css/CSSRule.h', Modified: trunk/Source/WebCore/WebCore.order (97582 => 97583) --- trunk/Source/WebCore/WebCore.order 2011-10-17 04:03:37 UTC (rev 97582) +++ trunk/Source/WebCore/WebCore.order 2011-10-17 04:27:09 UTC (rev 97583) @@ -3243,7 +3243,6 @@ __ZN7WebCore16CSSStyleSelector22checkForTextSizeAdjustEv __ZN7WebCore16CSSStyleSelector27checkForGenericFamilyChangeEPNS_11RenderStyleES2_ __ZN7WebCore16CSSStyleSelector18checkForZoomChangeEPNS_11RenderStyleES2_
[webkit-changes] [97584] trunk/Source/WebCore
Title: [97584] trunk/Source/WebCore Revision 97584 Author hara...@chromium.org Date 2011-10-16 22:06:15 -0700 (Sun, 16 Oct 2011) Log Message Generate EventSource constructor for JSC by [Constructor] IDL https://bugs.webkit.org/show_bug.cgi?id=70212 Reviewed by Adam Barth. Removed JSEventSourceCustom.cpp. Tests: fast/dom/global-constructors.html fast/eventsource/eventsource-constructor.html fast/eventsource/eventsource-attribute-listeners.html * GNUmakefile.list.am: Removed JSEventSourceCustom.cpp. * UseJSC.cmake: Ditto. * WebCore.gypi: Ditto. * WebCore.pro: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. * bindings/js/JSBindingsAllInOne.cpp: Ditto. * bindings/js/JSEventSourceCustom.cpp: Removed this file. * page/EventSource.idl: Removed 'JSCustomConstructor' IDL. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/UseJSC.cmake trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp trunk/Source/WebCore/page/EventSource.idl Removed Paths trunk/Source/WebCore/bindings/js/JSEventSourceCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (97583 => 97584) --- trunk/Source/WebCore/ChangeLog 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/ChangeLog 2011-10-17 05:06:15 UTC (rev 97584) @@ -1,3 +1,25 @@ +2011-10-16 Kentaro Hara hara...@chromium.org + +Generate EventSource constructor for JSC by [Constructor] IDL +https://bugs.webkit.org/show_bug.cgi?id=70212 + +Reviewed by Adam Barth. + +Removed JSEventSourceCustom.cpp. + +Tests: fast/dom/global-constructors.html + fast/eventsource/eventsource-constructor.html + fast/eventsource/eventsource-attribute-listeners.html + +* GNUmakefile.list.am: Removed JSEventSourceCustom.cpp. +* UseJSC.cmake: Ditto. +* WebCore.gypi: Ditto. +* WebCore.pro: Ditto. +* WebCore.xcodeproj/project.pbxproj: Ditto. +* bindings/js/JSBindingsAllInOne.cpp: Ditto. +* bindings/js/JSEventSourceCustom.cpp: Removed this file. +* page/EventSource.idl: Removed 'JSCustomConstructor' IDL. + 2011-10-16 David Barr davidb...@chromium.org Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function Modified: trunk/Source/WebCore/GNUmakefile.list.am (97583 => 97584) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-10-17 05:06:15 UTC (rev 97584) @@ -730,7 +730,6 @@ Source/WebCore/bindings/js/JSEventConstructors.cpp \ Source/WebCore/bindings/js/JSEventListener.cpp \ Source/WebCore/bindings/js/JSEventListener.h \ - Source/WebCore/bindings/js/JSEventSourceCustom.cpp \ Source/WebCore/bindings/js/JSEventTarget.cpp \ Source/WebCore/bindings/js/JSEventTarget.h \ Source/WebCore/bindings/js/JSErrorHandler.cpp \ Modified: trunk/Source/WebCore/UseJSC.cmake (97583 => 97584) --- trunk/Source/WebCore/UseJSC.cmake 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/UseJSC.cmake 2011-10-17 05:06:15 UTC (rev 97584) @@ -54,7 +54,6 @@ bindings/js/JSEventConstructors.cpp bindings/js/JSEventCustom.cpp bindings/js/JSEventListener.cpp -bindings/js/JSEventSourceCustom.cpp bindings/js/JSEventTarget.cpp bindings/js/JSExceptionBase.cpp bindings/js/JSFloat32ArrayCustom.cpp Modified: trunk/Source/WebCore/WebCore.gypi (97583 => 97584) --- trunk/Source/WebCore/WebCore.gypi 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/WebCore.gypi 2011-10-17 05:06:15 UTC (rev 97584) @@ -1842,7 +1842,6 @@ 'bindings/js/JSEventCustom.cpp', 'bindings/js/JSEventListener.cpp', 'bindings/js/JSEventListener.h', -'bindings/js/JSEventSourceCustom.cpp', 'bindings/js/JSEventTarget.cpp', 'bindings/js/JSEventTarget.h', 'bindings/js/JSExceptionBase.cpp', Modified: trunk/Source/WebCore/WebCore.pro (97583 => 97584) --- trunk/Source/WebCore/WebCore.pro 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/WebCore.pro 2011-10-17 05:06:15 UTC (rev 97584) @@ -277,7 +277,6 @@ bindings/js/JSEventConstructors.cpp \ bindings/js/JSEventCustom.cpp \ bindings/js/JSEventListener.cpp \ -bindings/js/JSEventSourceCustom.cpp \ bindings/js/JSEventTarget.cpp \ bindings/js/JSExceptionBase.cpp \ bindings/js/JSFileReaderCustom.cpp \ Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (97583 => 97584) --- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-17 04:27:09 UTC (rev 97583) +++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-17 05:06:15 UTC (rev 97584) @@ -4950,7 +4950,6 @@ BC274B31140EBED800EADFA6 /* CSSBorderImageSliceValue.cpp in Sources */
[webkit-changes] [97585] trunk/Source/WebCore
Title: [97585] trunk/Source/WebCore
Revision 97585
Author rn...@webkit.org
Date 2011-10-16 22:44:50 -0700 (Sun, 16 Oct 2011)
Log Message
[Mac] fontForSelection and styleForSelectionStart should be moved to EditorMac
https://bugs.webkit.org/show_bug.cgi?id=70114
Reviewed by Hajime Morita.
Moved fontForSelection and styleForSelectionStart from Editor to EditorMac
and made styleForSelectionStart static local.
* editing/Editor.cpp:
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::styleForSelectionStart):
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/mac/EditorMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (97584 => 97585)
--- trunk/Source/WebCore/ChangeLog 2011-10-17 05:06:15 UTC (rev 97584)
+++ trunk/Source/WebCore/ChangeLog 2011-10-17 05:44:50 UTC (rev 97585)
@@ -1,3 +1,20 @@
+2011-10-16 Ryosuke Niwa rn...@webkit.org
+
+[Mac] fontForSelection and styleForSelectionStart should be moved to EditorMac
+https://bugs.webkit.org/show_bug.cgi?id=70114
+
+Reviewed by Hajime Morita.
+
+Moved fontForSelection and styleForSelectionStart from Editor to EditorMac
+and made styleForSelectionStart static local.
+
+* editing/Editor.cpp:
+* editing/Editor.h:
+* editing/mac/EditorMac.mm:
+(WebCore::styleForSelectionStart):
+(WebCore::Editor::fontForSelection):
+(WebCore::Editor::fontAttributesForSelectionStart):
+
2011-10-16 Kentaro Hara hara...@chromium.org
Generate EventSource constructor for JSC by [Constructor] IDL
Modified: trunk/Source/WebCore/editing/Editor.cpp (97584 => 97585)
--- trunk/Source/WebCore/editing/Editor.cpp 2011-10-17 05:06:15 UTC (rev 97584)
+++ trunk/Source/WebCore/editing/Editor.cpp 2011-10-17 05:44:50 UTC (rev 97585)
@@ -509,53 +509,6 @@
client()-respondToChangedContents();
}
-#if PLATFORM(MAC)
-const SimpleFontData* Editor::fontForSelection(bool hasMultipleFonts) const
-{
-hasMultipleFonts = false;
-
-if (!m_frame-selection()-isRange()) {
-Node* nodeToRemove;
-RenderStyle* style = styleForSelectionStart(nodeToRemove); // sets nodeToRemove
-
-const SimpleFontData* result = 0;
-if (style)
-result = style-font().primaryFont();
-
-if (nodeToRemove) {
-ExceptionCode ec;
-nodeToRemove-remove(ec);
-ASSERT(!ec);
-}
-
-return result;
-}
-
-const SimpleFontData* font = 0;
-RefPtrRange range = m_frame-selection()-toNormalizedRange();
-if (Node* startNode = adjustedSelectionStartForStyleComputation(m_frame-selection()-selection()).deprecatedNode()) {
-Node* pastEnd = range-pastLastNode();
-// In the loop below, n should eventually match pastEnd and not become nil, but we've seen at least one
-// unreproducible case where this didn't happen, so check for null also.
-for (Node* n = startNode; n n != pastEnd; n = n-traverseNextNode()) {
-RenderObject* renderer = n-renderer();
-if (!renderer)
-continue;
-// FIXME: Are there any node types that have renderers, but that we should be skipping?
-const SimpleFontData* f = renderer-style()-font().primaryFont();
-if (!font)
-font = f;
-else if (font != f) {
-hasMultipleFonts = true;
-break;
-}
-}
-}
-
-return font;
-}
-#endif
-
WritingDirection Editor::textDirectionForSelection(bool hasNestedOrMultipleEmbeddings) const
{
hasNestedOrMultipleEmbeddings = true;
@@ -2796,42 +2749,6 @@
ASSERT(!ec);
}
-#if PLATFORM(MAC)
-RenderStyle* Editor::styleForSelectionStart(Node *nodeToRemove) const
-{
-nodeToRemove = 0;
-
-if (m_frame-selection()-isNone())
-return 0;
-
-Position position = m_frame-selection()-selection().visibleStart().deepEquivalent();
-if (!position.isCandidate())
-return 0;
-if (!position.deprecatedNode())
-return 0;
-
-RefPtrEditingStyle typingStyle = m_frame-selection()-typingStyle();
-if (!typingStyle || !typingStyle-style())
-return position.deprecatedNode()-renderer()-style();
-
-RefPtrElement styleElement = m_frame-document()-createElement(spanTag, false);
-
-ExceptionCode ec = 0;
-String styleText = typingStyle-style()-cssText() + display: inline;
-styleElement-setAttribute(styleAttr, styleText.impl(), ec);
-ASSERT(!ec);
-
-styleElement-appendChild(m_frame-document()-createEditingTextNode(), ec);
-ASSERT(!ec);
-
-position.deprecatedNode()-parentNode()-appendChild(styleElement, ec);
-ASSERT(!ec);
-
-nodeToRemove = styleElement.get();
-return styleElement-renderer() ?
