[webkit-changes] [98323] trunk/LayoutTests
Title: [98323] trunk/LayoutTests
Revision 98323
Author o...@webkit.org
Date 2011-10-24 23:59:32 -0700 (Mon, 24 Oct 2011)
Log Message
[Qt] Unreviewed gardening, add missing result after r98309.
Patch by Oliver Varga on 2011-10-24
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png
trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98322 => 98323)
--- trunk/LayoutTests/ChangeLog 2011-10-25 06:51:35 UTC (rev 98322)
+++ trunk/LayoutTests/ChangeLog 2011-10-25 06:59:32 UTC (rev 98323)
@@ -1,3 +1,12 @@
+2011-10-24 Oliver Varga
+
+[Qt] Unreviewed gardening, add missing result after r98309.
+
+* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
+* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
+* platform/qt/svg/filters/feColorMatrix-default-type-expected.png: Added.
+* platform/qt/svg/filters/feColorMatrix-default-type-expected.txt: Added.
+
2011-10-24 Martin Robinson
REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK
Added: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (0 => 98323)
--- trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt 2011-10-25 06:59:32 UTC (rev 98323)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x171
+ RenderBlock {HTML} at (0,0) size 800x171
+RenderBody {BODY} at (8,8) size 784x155
+ RenderPartObject {IFRAME} at (0,0) size 784x150
+layer at (0,0) size 784x150
+ RenderView at (0,0) size 784x150
+layer at (0,0) size 784x121
+ RenderBlock {HTML} at (0,0) size 784x121
+RenderBody {BODY} at (8,8) size 768x105
+ RenderSVGRoot {svg} at (8,8) size 100x100
+RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt (0 => 98323)
--- trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/filters/feColorMatrix-default-type-expected.txt 2011-10-25 06:59:32 UTC (rev 98323)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 230x111
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGResourceFilter {filter} [id="filt"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type="MATRIX" values="0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00"]
+ [SourceGraphic]
+ RenderSVGResourceFilter {filter} [id="filt2"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type="MATRIX" values="0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00"]
+ [SourceGraphic]
+RenderSVGPath {rect} at (0,0) size 111x111 [fill={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+ [filter="filt"] RenderSVGResourceFilter {filter} at (-10,-10) size 120x120
+RenderSVGPath {rect} at (110,0) size 120x111 [fill={[type=SOLID] [color=#FF]}] [x=120.00] [y=0.00] [width=100.00] [height=100.00]
+ [filter="filt2"] RenderSVGResourceFilter {filter} at (110,-10) size 120x1
[webkit-changes] [98322] trunk/LayoutTests
Title: [98322] trunk/LayoutTests Revision 98322 Author mrobin...@webkit.org Date 2011-10-24 23:51:35 -0700 (Mon, 24 Oct 2011) Log Message REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK https://bugs.webkit.org/show_bug.cgi?id=70481 Update test results to reflect that the plugin clipping rectangle is now correct. * platform/gtk/Skipped: Unskip the test. * platform/gtk/plugins/resize-from-plugin-expected.txt: Update results. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98321 => 98322) --- trunk/LayoutTests/ChangeLog 2011-10-25 05:43:15 UTC (rev 98321) +++ trunk/LayoutTests/ChangeLog 2011-10-25 06:51:35 UTC (rev 98322) @@ -1,3 +1,14 @@ +2011-10-24 Martin Robinson + +REGRESSION (r97865): broke plugins/resize-from-plugin.html on GTK +https://bugs.webkit.org/show_bug.cgi?id=70481 + +Update test results to reflect that the plugin clipping rectangle +is now correct. + +* platform/gtk/Skipped: Unskip the test. +* platform/gtk/plugins/resize-from-plugin-expected.txt: Update results. + 2011-10-24 Julien Chaffraix Unreviewed gardening. Modified: trunk/LayoutTests/platform/gtk/Skipped (98321 => 98322) --- trunk/LayoutTests/platform/gtk/Skipped 2011-10-25 05:43:15 UTC (rev 98321) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-10-25 06:51:35 UTC (rev 98322) @@ -1644,9 +1644,6 @@ # Microdata DOM API is not yet enabled. fast/dom/MicroData -# https://bugs.webkit.org/show_bug.cgi?id=70481 -plugins/resize-from-plugin.html - # https://bugs.webkit.org/show_bug.cgi?id=70485 fast/events/drag-selects-image.html Modified: trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt (98321 => 98322) --- trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt 2011-10-25 05:43:15 UTC (rev 98321) +++ trunk/LayoutTests/platform/gtk/plugins/resize-from-plugin-expected.txt 2011-10-25 06:51:35 UTC (rev 98322) @@ -7,6 +7,6 @@ Test for NPP_SetWindow calls sent while a plug-in resizes itself. -x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 0, 0) +x: 0, y: 0, width: 200, height: 200, clipRect: (0, 0, 200, 142) Height and width should equal 200, and the plug-in size should not change on scroll. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98321] trunk/Source/JavaScriptCore
Title: [98321] trunk/Source/_javascript_Core
Revision 98321
Author commit-qu...@webkit.org
Date 2011-10-24 22:43:15 -0700 (Mon, 24 Oct 2011)
Log Message
DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
https://bugs.webkit.org/show_bug.cgi?id=70798
Patch by Yuqiang Xian on 2011-10-24
Reviewed by Filip Pizlo.
When filling an integer for a known integer node (not speculated), it
should accept DataFormatJSInteger as well.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98320 => 98321)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-25 04:57:36 UTC (rev 98320)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-25 05:43:15 UTC (rev 98321)
@@ -1,3 +1,16 @@
+2011-10-24 Yuqiang Xian
+
+DFG JIT 32_64 - fillInteger should accept DataFormatJSInteger
+https://bugs.webkit.org/show_bug.cgi?id=70798
+
+Reviewed by Filip Pizlo.
+
+When filling an integer for a known integer node (not speculated), it
+should accept DataFormatJSInteger as well.
+
+* dfg/DFGJITCodeGenerator32_64.cpp:
+(JSC::DFG::JITCodeGenerator::fillInteger):
+
2011-10-24 Geoffrey Garen
Build fix: removed some cases of threadsafeCopy() that I missed in
Modified: trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp (98320 => 98321)
--- trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-25 04:57:36 UTC (rev 98320)
+++ trunk/Source/_javascript_Core/dfg/DFGJITCodeGenerator32_64.cpp 2011-10-25 05:43:15 UTC (rev 98321)
@@ -76,13 +76,27 @@
case DataFormatJS:
case DataFormatCell:
case DataFormatJSCell:
-case DataFormatJSInteger:
case DataFormatBoolean:
case DataFormatJSBoolean:
case DataFormatStorage:
// Should only be calling this function if we know this operand to be integer.
ASSERT_NOT_REACHED();
+case DataFormatJSInteger: {
+GPRReg tagGPR = info.tagGPR();
+GPRReg payloadGPR = info.payloadGPR();
+m_gprs.lock(tagGPR);
+m_jit.jitAssertIsJSInt32(tagGPR);
+m_gprs.unlock(tagGPR);
+m_gprs.lock(payloadGPR);
+m_gprs.release(tagGPR);
+m_gprs.release(payloadGPR);
+m_gprs.retain(payloadGPR, virtualRegister, SpillOrderInteger);
+info.fillInteger(payloadGPR);
+returnFormat = DataFormatInteger;
+return payloadGPR;
+}
+
case DataFormatInteger: {
GPRReg gpr = info.gpr();
m_gprs.lock(gpr);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98320] trunk/Source/WebCore
Title: [98320] trunk/Source/WebCore
Revision 98320
Author gga...@apple.com
Date 2011-10-24 21:57:36 -0700 (Mon, 24 Oct 2011)
Log Message
Chromium build fix: #include window.h for HANDLE.
* platform/graphics/opentype/OpenTypeUtilities.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98319 => 98320)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 04:49:18 UTC (rev 98319)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 04:57:36 UTC (rev 98320)
@@ -1,3 +1,9 @@
+2011-10-24 Geoffrey Garen
+
+Chromium build fix: #include window.h for HANDLE.
+
+* platform/graphics/opentype/OpenTypeUtilities.h:
+
2011-10-24 Ryosuke Niwa
Include ThreadSafeRefCounted.h since the class declared in this header file
Modified: trunk/Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.h (98319 => 98320)
--- trunk/Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.h 2011-10-25 04:49:18 UTC (rev 98319)
+++ trunk/Source/WebCore/platform/graphics/opentype/OpenTypeUtilities.h 2011-10-25 04:57:36 UTC (rev 98320)
@@ -28,6 +28,7 @@
#define OpenTypeUtilities_h
#include "PlatformString.h"
+#include
#include
namespace WebCore {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98319] trunk/Source/WebCore
Title: [98319] trunk/Source/WebCore Revision 98319 Author rn...@webkit.org Date 2011-10-24 21:49:18 -0700 (Mon, 24 Oct 2011) Log Message Include ThreadSafeRefCounted.h since the class declared in this header file inherits from ThreadSafeRefCounted. * storage/IDBIndexBackendInterface.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/storage/IDBIndexBackendInterface.h Diff Modified: trunk/Source/WebCore/ChangeLog (98318 => 98319) --- trunk/Source/WebCore/ChangeLog 2011-10-25 04:33:38 UTC (rev 98318) +++ trunk/Source/WebCore/ChangeLog 2011-10-25 04:49:18 UTC (rev 98319) @@ -1,5 +1,12 @@ 2011-10-24 Ryosuke Niwa +Include ThreadSafeRefCounted.h since the class declared in this header file +inherits from ThreadSafeRefCounted. + +* storage/IDBIndexBackendInterface.h: + +2011-10-24 Ryosuke Niwa + Fix a typo. * bindings/v8/_javascript_CallFrame.h: Modified: trunk/Source/WebCore/storage/IDBIndexBackendInterface.h (98318 => 98319) --- trunk/Source/WebCore/storage/IDBIndexBackendInterface.h 2011-10-25 04:33:38 UTC (rev 98318) +++ trunk/Source/WebCore/storage/IDBIndexBackendInterface.h 2011-10-25 04:49:18 UTC (rev 98319) @@ -29,6 +29,7 @@ #include "ExceptionCode.h" #include "PlatformString.h" #include +#include #if ENABLE(INDEXED_DATABASE) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98318] trunk/Source
Title: [98318] trunk/Source
Revision 98318
Author gga...@apple.com
Date 2011-10-24 21:33:38 -0700 (Mon, 24 Oct 2011)
Log Message
Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.
Source/_javascript_Core:
* _javascript_Core.order:
Source/WebKit/win:
* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::didImportIconURLForPageURL):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.order
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebDownloadCFNet.cpp
trunk/Source/WebKit/win/WebIconDatabase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98317 => 98318)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-25 04:26:38 UTC (rev 98317)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-25 04:33:38 UTC (rev 98318)
@@ -1,5 +1,12 @@
2011-10-24 Geoffrey Garen
+Build fix: removed some cases of threadsafeCopy() that I missed in
+my previous patch.
+
+* _javascript_Core.order:
+
+2011-10-24 Geoffrey Garen
+
Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698
Modified: trunk/Source/_javascript_Core/_javascript_Core.order (98317 => 98318)
--- trunk/Source/_javascript_Core/_javascript_Core.order 2011-10-25 04:26:38 UTC (rev 98317)
+++ trunk/Source/_javascript_Core/_javascript_Core.order 2011-10-25 04:33:38 UTC (rev 98318)
@@ -82,8 +82,6 @@
__ZN3WTF6String8fromUTF8EPKcm
__ZN3WTF7Unicode18convertUTF8ToUTF16EPPKcS2_PPtS4_b
__ZN3WTF15ThreadCondition6signalEv
-__ZNK3WTF6String14threadsafeCopyEv
-__ZNK3WTF10StringImpl14threadsafeCopyEv
__ZN3WTF7CStringC1EPKc
__ZN3WTF7CString4initEPKcm
__ZNK3WTF6String4utf8Eb
Modified: trunk/Source/WebKit/win/ChangeLog (98317 => 98318)
--- trunk/Source/WebKit/win/ChangeLog 2011-10-25 04:26:38 UTC (rev 98317)
+++ trunk/Source/WebKit/win/ChangeLog 2011-10-25 04:33:38 UTC (rev 98318)
@@ -1,3 +1,15 @@
+2011-10-24 Geoffrey Garen
+
+Build fix: removed some cases of threadsafeCopy() that I missed in
+my previous patch.
+
+* WebDatabaseManager.cpp:
+(DidModifyOriginData::dispatchToMainThread):
+* WebDownloadCFNet.cpp:
+(WebDownload::initToResumeWithBundle):
+* WebIconDatabase.cpp:
+(WebIconDatabase::didImportIconURLForPageURL):
+
2011-10-24 Ryosuke Niwa
threadsafeCopy has been renamed to isolatedCopy.
Modified: trunk/Source/WebKit/win/WebDownloadCFNet.cpp (98317 => 98318)
--- trunk/Source/WebKit/win/WebDownloadCFNet.cpp 2011-10-25 04:26:38 UTC (rev 98317)
+++ trunk/Source/WebKit/win/WebDownloadCFNet.cpp 2011-10-25 04:33:38 UTC (rev 98318)
@@ -194,7 +194,7 @@
// Attempt to remove the ".download" extension from the bundle for the final file destination
// Failing that, we clear m_destination and will ask the delegate later once the download starts
if (m_bundlePath.endsWith(DownloadBundle::fileExtension(), false)) {
-m_destination = m_bundlePath.threadsafeCopy();
+m_destination = m_bundlePath.isolatedCopy();
m_destination.truncate(m_destination.length() - DownloadBundle::fileExtension().length());
} else
m_destination = String();
Modified: trunk/Source/WebKit/win/WebIconDatabase.cpp (98317 => 98318)
--- trunk/Source/WebKit/win/WebIconDatabase.cpp 2011-10-25 04:26:38 UTC (rev 98317)
+++ trunk/Source/WebKit/win/WebIconDatabase.cpp 2011-10-25 04:33:38 UTC (rev 98318)
@@ -336,7 +336,7 @@
void WebIconDatabase::didImportIconURLForPageURL(const WTF::String& pageURL)
{
MutexLocker locker(m_notificationMutex);
-m_notificationQueue.append(pageURL.threadsafeCopy());
+m_notificationQueue.append(pageURL.isolatedCopy());
scheduleNotificationDelivery();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98317] trunk/Source
Title: [98317] trunk/Source
Revision 98317
Author rn...@webkit.org
Date 2011-10-24 21:26:38 -0700 (Mon, 24 Oct 2011)
Log Message
Source/WebCore: Fix a typo.
* bindings/v8/_javascript_CallFrame.h:
Source/WebKit/win: threadsafeCopy has been renamed to isolatedCopy.
* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/_javascript_CallFrame.h
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebDatabaseManager.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98316 => 98317)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 03:54:15 UTC (rev 98316)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 04:26:38 UTC (rev 98317)
@@ -1,3 +1,9 @@
+2011-10-24 Ryosuke Niwa
+
+Fix a typo.
+
+* bindings/v8/_javascript_CallFrame.h:
+
2011-10-24 Geoffrey Garen
Removed SharedUChar and tightened language around its previous uses
Modified: trunk/Source/WebCore/bindings/v8/_javascript_CallFrame.h (98316 => 98317)
--- trunk/Source/WebCore/bindings/v8/_javascript_CallFrame.h 2011-10-25 03:54:15 UTC (rev 98316)
+++ trunk/Source/WebCore/bindings/v8/_javascript_CallFrame.h 2011-10-25 04:26:38 UTC (rev 98317)
@@ -36,7 +36,7 @@
#include "OwnHandle.h"
#include "PlatformString.h"
#include
-#inculde
+#include
namespace WebCore {
Modified: trunk/Source/WebKit/win/ChangeLog (98316 => 98317)
--- trunk/Source/WebKit/win/ChangeLog 2011-10-25 03:54:15 UTC (rev 98316)
+++ trunk/Source/WebKit/win/ChangeLog 2011-10-25 04:26:38 UTC (rev 98317)
@@ -1,3 +1,10 @@
+2011-10-24 Ryosuke Niwa
+
+threadsafeCopy has been renamed to isolatedCopy.
+
+* WebDatabaseManager.cpp:
+(DidModifyOriginData::dispatchToMainThread):
+
2011-10-24 Adam Barth
Attempt to fix Windows build by updating to the new interface.
Modified: trunk/Source/WebKit/win/WebDatabaseManager.cpp (98316 => 98317)
--- trunk/Source/WebKit/win/WebDatabaseManager.cpp 2011-10-25 03:54:15 UTC (rev 98316)
+++ trunk/Source/WebKit/win/WebDatabaseManager.cpp 2011-10-25 04:26:38 UTC (rev 98317)
@@ -334,7 +334,7 @@
public:
static void dispatchToMainThread(WebDatabaseManager* databaseManager, SecurityOrigin* origin)
{
-DidModifyOriginData* context = new DidModifyOriginData(databaseManager, origin->threadsafeCopy());
+DidModifyOriginData* context = new DidModifyOriginData(databaseManager, origin->isolatedCopy());
callOnMainThread(&DidModifyOriginData::dispatchDidModifyOriginOnMainThread, context);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98315] trunk/Tools
Title: [98315] trunk/Tools
Revision 98315
Author mnaga...@chromium.org
Date 2011-10-24 20:36:24 -0700 (Mon, 24 Oct 2011)
Log Message
Fix bug summary when rolling Chromium DEPS to LKGR.
https://bugs.webkit.org/show_bug.cgi?id=69917
Reviewed by Adam Barth.
* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/sheriff.py:
* Scripts/webkitpy/tool/commands/roll.py:
* Scripts/webkitpy/tool/commands/roll_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py
trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py
trunk/Tools/Scripts/webkitpy/tool/commands/roll.py
trunk/Tools/Scripts/webkitpy/tool/commands/roll_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98314 => 98315)
--- trunk/Tools/ChangeLog 2011-10-25 03:17:25 UTC (rev 98314)
+++ trunk/Tools/ChangeLog 2011-10-25 03:36:24 UTC (rev 98315)
@@ -1,3 +1,15 @@
+2011-10-24 Mikhail Naganov
+
+Fix bug summary when rolling Chromium DEPS to LKGR.
+https://bugs.webkit.org/show_bug.cgi?id=69917
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/tool/bot/irc_command.py:
+* Scripts/webkitpy/tool/bot/sheriff.py:
+* Scripts/webkitpy/tool/commands/roll.py:
+* Scripts/webkitpy/tool/commands/roll_unittest.py:
+
2011-10-24 Ivan Briano
[EFL] Build fix. Add include path to find npapi.h
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (98314 => 98315)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-10-25 03:17:25 UTC (rev 98314)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2011-10-25 03:36:24 UTC (rev 98315)
@@ -163,7 +163,7 @@
tool.irc().post("%s: Rolling Chromium DEPS to %s" % (nick, roll_target))
try:
-bug_id = sheriff.post_chromium_deps_roll(revision)
+bug_id = sheriff.post_chromium_deps_roll(revision, roll_target)
bug_url = tool.bugs.bug_url_for_bug_id(bug_id)
tool.irc().post("%s: Created DEPS roll: %s" % (nick, bug_url))
except ScriptError, e:
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py (98314 => 98315)
--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py 2011-10-25 03:17:25 UTC (rev 98314)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriff.py 2011-10-25 03:36:24 UTC (rev 98315)
@@ -90,15 +90,15 @@
])
return parse_bug_id(output)
-def post_chromium_deps_roll(self, revision):
+def post_chromium_deps_roll(self, revision, revision_name):
args = [
"post-chromium-deps-roll",
"--force-clean",
"--non-interactive",
"--parent-command=sheriff-bot",
]
-if revision:
-args += [revision]
+# revision can be None, but revision_name is always something meaningful.
+args += [revision, revision_name]
output = self._sheriffbot.run_webkit_patch(args)
return parse_bug_id(output)
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/roll.py (98314 => 98315)
--- trunk/Tools/Scripts/webkitpy/tool/commands/roll.py 2011-10-25 03:17:25 UTC (rev 98314)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/roll.py 2011-10-25 03:36:24 UTC (rev 98315)
@@ -50,8 +50,8 @@
class PostChromiumDEPSRoll(AbstractSequencedCommand):
name = "post-chromium-deps-roll"
-help_text = "Posts a patch to update Chromium DEPS (defaults to the last-known good revision of Chromium)"
-argument_names = "[CHROMIUM_REVISION]"
+help_text = "Posts a patch to update Chromium DEPS (revision defaults to the last-known good revision of Chromium)"
+argument_names = "CHROMIUM_REVISION CHROMIUM_REVISION_NAME"
steps = [
steps.CleanWorkingDirectory,
steps.Update,
@@ -65,9 +65,10 @@
options.review = False
options.request_commit = True
-chromium_revision = (args and args[0])
+chromium_revision = args[0]
+chromium_revision_name = args[1]
return {
"chromium_revision": chromium_revision,
-"bug_title": "Roll Chromium DEPS to r%s" % chromium_revision,
+"bug_title": "Roll Chromium DEPS to %s" % chromium_revision_name,
"bug_description": "A DEPS roll a day keeps the build break away.",
}
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/roll_unittest.py (98314 => 98315)
--- trunk/Tools/Scripts/webkitpy/tool/commands/roll_unittest.py 2011-10-25 03:17:25 UTC (rev 98314)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/roll_unittest.py 2011-10-25 03:36:24 UTC (rev 98315)
@@ -48,3 +48,16 @@
ERROR: Unable to update Chromium DEPS
"""
self.assert_execute_outputs(RollChromiumDEPS(), [5764], options=options, expected_stderr=expected_stderr, expected_exception=SystemExit)
+
+
+class PostRollCommandsTest(CommandsTest):
+def test_prepare_state(self):
+postroll = PostChromiumDEPSRoll()
+options = MockOptions()
+tool = MockTool()
+
[webkit-changes] [98314] trunk/Source/WebCore
Title: [98314] trunk/Source/WebCore Revision 98314 Author aba...@webkit.org Date 2011-10-24 20:17:25 -0700 (Mon, 24 Oct 2011) Log Message Remove empty directory. * p2p: Removed. Modified Paths trunk/Source/WebCore/ChangeLog Removed Paths trunk/Source/WebCore/p2p/ Diff Modified: trunk/Source/WebCore/ChangeLog (98313 => 98314) --- trunk/Source/WebCore/ChangeLog 2011-10-25 02:54:22 UTC (rev 98313) +++ trunk/Source/WebCore/ChangeLog 2011-10-25 03:17:25 UTC (rev 98314) @@ -1,3 +1,9 @@ +2011-10-24 Adam Barth + +Remove empty directory. + +* p2p: Removed. + 2011-10-24 Shawn Singh [chromium] Refactor painting/updating/drawing code. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98313] trunk/Source/WebCore
Title: [98313] trunk/Source/WebCore
Revision 98313
Author commit-qu...@webkit.org
Date 2011-10-24 19:54:22 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Refactor painting/updating/drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057
Patch by Shawn Singh on 2011-10-24
Reviewed by James Robinson.
This refactoring separates the "early exits" from the actual loop
that draws layers. As part of this, it was also appropriate to
clean up the way that masks and replicas are dealt with when
painting and updating. The purpose of all this is to make things
easier to test, and for a scissoring optimization that needs to
know exatly what gets drawn. Existing layout tests were able to
verify the refactoring did not change behavior.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
(WebCore::CCLayerTreeHost::updateCompositorResources):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerShouldBeAppended):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.h
Property Changed
trunk/Source/WebCore/ChangeLog
Diff
Modified: trunk/Source/WebCore/ChangeLog (98312 => 98313)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 02:53:31 UTC (rev 98312)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 02:54:22 UTC (rev 98313)
@@ -1,3 +1,34 @@
+2011-10-24 Shawn Singh
+
+[chromium] Refactor painting/updating/drawing code.
+https://bugs.webkit.org/show_bug.cgi?id=70057
+
+Reviewed by James Robinson.
+
+This refactoring separates the "early exits" from the actual loop
+that draws layers. As part of this, it was also appropriate to
+clean up the way that masks and replicas are dealt with when
+painting and updating. The purpose of all this is to make things
+easier to test, and for a scissoring optimization that needs to
+know exatly what gets drawn. Existing layout tests were able to
+verify the refactoring did not change behavior.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
+(WebCore::LayerRendererChromium::drawLayersInternal):
+(WebCore::LayerRendererChromium::drawLayer):
+* platform/graphics/chromium/LayerRendererChromium.h:
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::paintMaskAndReplicaForRenderSurface):
+(WebCore::CCLayerTreeHost::paintLayerContents):
+(WebCore::CCLayerTreeHost::updateCompositorResources):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::layerShouldBeAppended):
+(WebCore::calculateDrawTransformsAndVisibilityInternal):
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
+(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
+
2011-10-24 Luke Macpherson
REGRESSION(80893): HTML5 spec takes 2s longer to load due to time spent in CSSStyleSelector
Property changes on: trunk/Source/WebCore/ChangeLog
___
Deleted: svn:executable
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (98312 => 98313)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-10-25 02:53:31 UTC (rev 98312)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-10-25 02:54:22 UTC (rev 98313)
@@ -301,6 +301,45 @@
copyOffscreenTextureToDisplay();
}
+void LayerRendererChromium::drawLayersOntoRenderSurfaces(CCLayerImpl* rootDrawLayer, const CCLayerList& renderSurfaceLayerList)
+{
+TRACE_EVENT("LayerRendererChromium::drawLayersOntoRenderSurfaces", this, 0);
+
+// Update the contents of the render surfaces. We traverse the render surfaces
+// from back to front to guarantee that nested ren
[webkit-changes] [98312] trunk/LayoutTests
Title: [98312] trunk/LayoutTests Revision 98312 Author jchaffr...@webkit.org Date 2011-10-24 19:53:31 -0700 (Mon, 24 Oct 2011) Log Message Unreviewed gardening. Add a new baseline for snow-leopard. * platform/chromium-mac-snowleopard/svg/filters: Added. * platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98311 => 98312) --- trunk/LayoutTests/ChangeLog 2011-10-25 02:47:22 UTC (rev 98311) +++ trunk/LayoutTests/ChangeLog 2011-10-25 02:53:31 UTC (rev 98312) @@ -1,3 +1,12 @@ +2011-10-24 Julien Chaffraix + +Unreviewed gardening. + +Add a new baseline for snow-leopard. + +* platform/chromium-mac-snowleopard/svg/filters: Added. +* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png: Added. + 2011-10-24 Ben Wells Canvas drawImage with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-default-type-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98311] trunk/Source/WebKit2
Title: [98311] trunk/Source/WebKit2
Revision 98311
Author wei...@apple.com
Date 2011-10-24 19:47:22 -0700 (Mon, 24 Oct 2011)
Log Message
Simplify url accessors on WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70797
Reviewed by Anders Carlsson.
* UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
* UIProcess/API/C/WKPage.h:
Add accessors to C SPI.
* UIProcess/API/mac/WKBrowsingContextController.h:
Remove unreachableURL accessor for now. It may make a glorious return when we have
error page support.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
Implement these in terms of the new C SPI.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
Add computation of the "active" URL, which is the URL one would show
in an address field. It is the pending URL when there is one, the provisional
URL when there is one, and otherwise the committed/final URL.
(WebKit::WebPageProxy::provisionalURL):
(WebKit::WebPageProxy::committedURL):
Add access to the main frame URL.
* UIProcess/WebPageProxy.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPage.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98310 => 98311)
--- trunk/Source/WebKit2/ChangeLog 2011-10-25 02:38:26 UTC (rev 98310)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-25 02:47:22 UTC (rev 98311)
@@ -1,5 +1,40 @@
2011-10-24 Sam Weinig
+Simplify url accessors on WKBrowsingContextController
+https://bugs.webkit.org/show_bug.cgi?id=70797
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/C/WKPage.cpp:
+(WKPageCopyActiveURL):
+(WKPageCopyProvisionalURL):
+(WKPageCopyCommittedURL):
+* UIProcess/API/C/WKPage.h:
+Add accessors to C SPI.
+
+* UIProcess/API/mac/WKBrowsingContextController.h:
+Remove unreachableURL accessor for now. It may make a glorious return when we have
+error page support.
+
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(-[WKBrowsingContextController activeURL]):
+(-[WKBrowsingContextController provisionalURL]):
+(-[WKBrowsingContextController committedURL]):
+Implement these in terms of the new C SPI.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::activeURL):
+Add computation of the "active" URL, which is the URL one would show
+in an address field. It is the pending URL when there is one, the provisional
+URL when there is one, and otherwise the committed/final URL.
+
+(WebKit::WebPageProxy::provisionalURL):
+(WebKit::WebPageProxy::committedURL):
+Add access to the main frame URL.
+* UIProcess/WebPageProxy.h:
+
+2011-10-24 Sam Weinig
+
Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp (98310 => 98311)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2011-10-25 02:38:26 UTC (rev 98310)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp 2011-10-25 02:47:22 UTC (rev 98311)
@@ -506,6 +506,21 @@
return toCopiedURLAPI(toImpl(pageRef)->pendingAPIRequestURL());
}
+WKURLRef WKPageCopyActiveURL(WKPageRef pageRef)
+{
+return toCopiedURLAPI(toImpl(pageRef)->activeURL());
+}
+
+WKURLRef WKPageCopyProvisionalURL(WKPageRef pageRef)
+{
+return toCopiedURLAPI(toImpl(pageRef)->provisionalURL());
+}
+
+WKURLRef WKPageCopyCommittedURL(WKPageRef pageRef)
+{
+return toCopiedURLAPI(toImpl(pageRef)->committedURL());
+}
+
void WKPageSetDebugPaintFlags(WKPageDebugPaintFlags flags)
{
WebPageProxy::setDebugPaintFlags(flags);
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPage.h (98310 => 98311)
--- trunk/Source/WebKit2/UIProcess/API/C/WKPage.h 2011-10-25 02:38:26 UTC (rev 98310)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPage.h 2011-10-25 02:47:22 UTC (rev 98311)
@@ -323,6 +323,10 @@
WK_EXPORT WKURLRef WKPageCopyPendingAPIRequestURL(WKPageRef page);
+WK_EXPORT WKURLRef WKPageCopyActiveURL(WKPageRef page);
+WK_EXPORT WKURLRef WKPageCopyProvisionalURL(WKPageRef page);
+WK_EXPORT WKURLRef WKPageCopyCommittedURL(WKPageRef page);
+
WK_EXPORT WKFrameRef WKPageGetMainFrame(WKPageRef page);
WK_EXPORT WKFrameRef WKPageGetFocusedFrame(WKPageRef page); // The focused frame may be inactive.
WK_EXPORT WKFrameRef WKPageGetFrameSetLargestFrame(WKPageRef page);
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsin
[webkit-changes] [98308] trunk/LayoutTests
Title: [98308] trunk/LayoutTests Revision 98308 Author rn...@webkit.org Date 2011-10-24 19:15:18 -0700 (Mon, 24 Oct 2011) Log Message GTK and Windows rebaselines after r98199. * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: * platform/win/fast/dom/prototype-inheritance-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98307 => 98308) --- trunk/LayoutTests/ChangeLog 2011-10-25 01:24:05 UTC (rev 98307) +++ trunk/LayoutTests/ChangeLog 2011-10-25 02:15:18 UTC (rev 98308) @@ -1,3 +1,10 @@ +2011-10-24 Ryosuke Niwa + +GTK and Windows rebaselines after r98199. + +* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: +* platform/win/fast/dom/prototype-inheritance-2-expected.txt: + 2011-10-24 Julien Chaffraix Unreviewed rebaseline after r98293. Modified: trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt (98307 => 98308) --- trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt 2011-10-25 01:24:05 UTC (rev 98307) +++ trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt 2011-10-25 02:15:18 UTC (rev 98308) @@ -182,12 +182,12 @@ PASS NodeListPrototype from inner.document.forms.testForm.__proto__ PASS NodePrototype from inner.document.forms.testForm.0.ownerDocument.__proto__.__proto__.__proto__ PASS Object from inner.document.location.__proto__.__proto__ -PASS Plugin from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.3 +PASS Plugin from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.0 PASS PluginArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins PASS PluginArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.constructor PASS PluginArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.__proto__ PASS PluginConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.0.constructor -PASS PluginPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.3.__proto__ +PASS PluginPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.0.__proto__ PASS RGBColor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(fill).rgbColor PASS RGBColorConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(fill).rgbColor.constructor PASS RGBColorPrototype from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(fill).rgbColor.__proto__ Modified: trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt (98307 => 98308) --- trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt 2011-10-25 01:24:05 UTC (rev 98307) +++ trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt 2011-10-25 02:15:18 UTC (rev 98308) @@ -168,26 +168,26 @@ PASS MediaListPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.media.__proto__ PASS MemoryInfo from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory PASS MemoryInfoPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory.__proto__ -PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0 -PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes -PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.constructor -PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.__proto__ -PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.constructor -PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.__proto__ +PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0 +PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes +PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.constructor +PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.__proto__ +PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.constructor +PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.__proto__ PASS NamedNodeMap from inner.document
[webkit-changes] [98307] trunk/Source
Title: [98307] trunk/Source
Revision 98307
Author jchaffr...@webkit.org
Date 2011-10-24 18:24:05 -0700 (Mon, 24 Oct 2011)
Log Message
Unreviewed, rolling out r98294 and r98306.
http://trac.webkit.org/changeset/98294
http://trac.webkit.org/changeset/98306
https://bugs.webkit.org/show_bug.cgi?id=70790
the first patch broke chromium-mac and the second gclient
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot on 2011-10-24
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gypi:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (98306 => 98307)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 00:44:27 UTC (rev 98306)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 01:24:05 UTC (rev 98307)
@@ -1,3 +1,15 @@
+2011-10-24 Sheriff Bot
+
+Unreviewed, rolling out r98294 and r98306.
+http://trac.webkit.org/changeset/98294
+http://trac.webkit.org/changeset/98306
+https://bugs.webkit.org/show_bug.cgi?id=70790
+
+the first patch broke chromium-mac and the second gclient
+(Requested by jchaffraix on #webkit).
+
+* WebCore.gyp/WebCore.gyp:
+
2011-10-24 Ryosuke Niwa
Build fix after r98300.
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (98306 => 98307)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-25 00:44:27 UTC (rev 98306)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-25 01:24:05 UTC (rev 98307)
@@ -1465,7 +1465,7 @@
# Cherry-pick some files that can't be included by broader regexps.
# Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the "exclude" list below.
+# the specific exclusions in the "sources!" list below.
['include', 'rendering/RenderThemeMac\\.mm$'],
['include', 'platform/graphics/mac/ColorMac\\.mm$'],
['include', 'platform/graphics/mac/ComplexTextControllerCoreText\\.mm$'],
@@ -1505,10 +1505,6 @@
['exclude', 'platform/graphics/cg/ImageSourceCG\\.cpp$'],
['exclude', 'platform/graphics/cg/PDFDocumentImage\\.cpp$'],
-# Mac uses only ScrollAnimatorMac.
-['exclude', 'platform/ScrollAnimatorNone\\.cpp$'],
-['exclude', 'platform/ScrollAnimatorNone\\.h$'],
-
['include', '/chrome/junk\\.txt$'],
],
},{ # OS!="mac"
@@ -1522,7 +1518,7 @@
'sources/': [
# Cherry-pick some files that can't be included by broader regexps.
# Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the "exclude" list below.
+# the specific exclusions in the "sources!" list below.
['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
# Chromium Mac does not use skia.
Modified: trunk/Source/WebKit/chromium/ChangeLog (98306 => 98307)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-25 00:44:27 UTC (rev 98306)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-25 01:24:05 UTC (rev 98307)
@@ -1,3 +1,15 @@
+2011-10-24 Sheriff Bot
+
+Unreviewed, rolling out r98294 and r98306.
+http://trac.webkit.org/changeset/98294
+http://trac.webkit.org/changeset/98306
+https://bugs.webkit.org/show_bug.cgi?id=70790
+
+the first patch broke chromium-mac and the second gclient
+(Requested by jchaffraix on #webkit).
+
+* WebKit.gypi:
+
2011-10-24 Nico Weber
[chromium] Try to fix mac build after r98294
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (98306 => 98307)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-25 00:44:27 UTC (rev 98306)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-25 01:24:05 UTC (rev 98307)
@@ -75,6 +75,7 @@
'tests/PODArenaTest.cpp',
'tests/PODIntervalTreeTest.cpp',
'tests/PODRedBlackTreeTest.cpp',
+'tests/ScrollAnimatorNoneTest.cpp',
'tests/TilingDataTest.cpp',
'tests/TreeSynchronizerTest.cpp',
'tests/TreeTestHelpers.cpp',
@@ -98,10 +99,6 @@
'tests/WebPageSerializerTest.cpp',
],
}],
-['OS!="mac"', {
- # Mac uses ScrollAnimatorMac instead of ScrollAnimatorNone.
- 'tests/ScrollAnimatorNoneTest.cpp',
-}],
['toolkit_uses_gtk == 1', {
'webkit_unittest_files': [
# FIXME: Port DragImageTest to Mac.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98306] trunk/Source/WebKit/chromium
Title: [98306] trunk/Source/WebKit/chromium
Revision 98306
Author jchaffr...@webkit.org
Date 2011-10-24 17:44:27 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Try to fix mac build after r98294
https://bugs.webkit.org/show_bug.cgi?id=70785
Remove test for ScrollAnimatorNone on mac.
Unreviewed, build fix.
Patch by Nico Weber on 2011-10-24
* WebKit.gypi:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98305 => 98306)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-25 00:44:17 UTC (rev 98305)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-25 00:44:27 UTC (rev 98306)
@@ -1,3 +1,14 @@
+2011-10-24 Nico Weber
+
+[chromium] Try to fix mac build after r98294
+https://bugs.webkit.org/show_bug.cgi?id=70785
+
+Remove test for ScrollAnimatorNone on mac.
+
+Unreviewed, build fix.
+
+* WebKit.gypi:
+
2011-10-24 Sheriff Bot
Unreviewed, rolling out r98266.
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (98305 => 98306)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-25 00:44:17 UTC (rev 98305)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-25 00:44:27 UTC (rev 98306)
@@ -75,7 +75,6 @@
'tests/PODArenaTest.cpp',
'tests/PODIntervalTreeTest.cpp',
'tests/PODRedBlackTreeTest.cpp',
-'tests/ScrollAnimatorNoneTest.cpp',
'tests/TilingDataTest.cpp',
'tests/TreeSynchronizerTest.cpp',
'tests/TreeTestHelpers.cpp',
@@ -99,6 +98,10 @@
'tests/WebPageSerializerTest.cpp',
],
}],
+['OS!="mac"', {
+ # Mac uses ScrollAnimatorMac instead of ScrollAnimatorNone.
+ 'tests/ScrollAnimatorNoneTest.cpp',
+}],
['toolkit_uses_gtk == 1', {
'webkit_unittest_files': [
# FIXME: Port DragImageTest to Mac.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98305] trunk/Source/WebCore
Title: [98305] trunk/Source/WebCore Revision 98305 Author rn...@webkit.org Date 2011-10-24 17:44:17 -0700 (Mon, 24 Oct 2011) Log Message Build fix after r98300. * WebCore.gypi: * WebCore.pro: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.pro Diff Modified: trunk/Source/WebCore/ChangeLog (98304 => 98305) --- trunk/Source/WebCore/ChangeLog 2011-10-25 00:33:10 UTC (rev 98304) +++ trunk/Source/WebCore/ChangeLog 2011-10-25 00:44:17 UTC (rev 98305) @@ -1,3 +1,10 @@ +2011-10-24 Ryosuke Niwa + +Build fix after r98300. + +* WebCore.gypi: +* WebCore.pro: + 2011-10-24 Anders Carlsson It should be possible for Widget subclasses to control whether transforms affect the frame rect Modified: trunk/Source/WebCore/WebCore.gypi (98304 => 98305) --- trunk/Source/WebCore/WebCore.gypi 2011-10-25 00:33:10 UTC (rev 98304) +++ trunk/Source/WebCore/WebCore.gypi 2011-10-25 00:44:17 UTC (rev 98305) @@ -5559,8 +5559,6 @@ 'html/MediaError.h', 'html/MicroDataItemValue.cpp', 'html/MicroDataItemValue.h', -'html/MutableTextTrack.cpp', -'html/MutableTextTrack.h', 'html/MonthInputType.cpp', 'html/MonthInputType.h', 'html/NumberInputType.cpp', Modified: trunk/Source/WebCore/WebCore.pro (98304 => 98305) --- trunk/Source/WebCore/WebCore.pro 2011-10-25 00:33:10 UTC (rev 98304) +++ trunk/Source/WebCore/WebCore.pro 2011-10-25 00:44:17 UTC (rev 98305) @@ -1812,7 +1812,6 @@ html/LoadableTextTrack.h \ html/MediaDocument.h \ html/MicroDataItemValue.h \ -html/MutableTextTrack.h \ html/PluginDocument.h \ html/StepRange.h \ html/TextDocument.h \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98304] trunk/Source/WebCore
Title: [98304] trunk/Source/WebCore
Revision 98304
Author ander...@apple.com
Date 2011-10-24 17:33:10 -0700 (Mon, 24 Oct 2011)
Log Message
It should be possible for Widget subclasses to control whether transforms affect the frame rect
https://bugs.webkit.org/show_bug.cgi?id=70787
Reviewed by Sam Weinig.
Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
this behavior and have the frame rect set to the absolute content box without any transforms applied.
* platform/Widget.h:
(WebCore::Widget::transformsAffectFrameRect):
Add new member function.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
false, just set the frame rect to the absolute content box.
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Call updateWidgetGeometry.
* rendering/RenderWidget.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Widget.h
trunk/Source/WebCore/rendering/RenderWidget.cpp
trunk/Source/WebCore/rendering/RenderWidget.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98303 => 98304)
--- trunk/Source/WebCore/ChangeLog 2011-10-25 00:26:40 UTC (rev 98303)
+++ trunk/Source/WebCore/ChangeLog 2011-10-25 00:33:10 UTC (rev 98304)
@@ -1,3 +1,29 @@
+2011-10-24 Anders Carlsson
+
+It should be possible for Widget subclasses to control whether transforms affect the frame rect
+https://bugs.webkit.org/show_bug.cgi?id=70787
+
+Reviewed by Sam Weinig.
+
+Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
+content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
+this behavior and have the frame rect set to the absolute content box without any transforms applied.
+
+* platform/Widget.h:
+(WebCore::Widget::transformsAffectFrameRect):
+Add new member function.
+
+* rendering/RenderWidget.cpp:
+(WebCore::RenderWidget::updateWidgetGeometry):
+Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
+false, just set the frame rect to the absolute content box.
+
+(WebCore::RenderWidget::setWidget):
+(WebCore::RenderWidget::updateWidgetPosition):
+Call updateWidgetGeometry.
+
+* rendering/RenderWidget.h:
+
2011-10-24 Arko Saha
Microdata: Add itemprop, itemref, itemvalue attributes.
Modified: trunk/Source/WebCore/platform/Widget.h (98303 => 98304)
--- trunk/Source/WebCore/platform/Widget.h 2011-10-25 00:26:40 UTC (rev 98303)
+++ trunk/Source/WebCore/platform/Widget.h 2011-10-25 00:33:10 UTC (rev 98304)
@@ -198,6 +198,10 @@
// Notifies this widget that other widgets on the page have been repositioned.
virtual void widgetPositionsUpdated() {}
+// Whether transforms affect the frame rect. FIXME: We get rid of this and have
+// the frame rects be the same no matter what transforms are applied.
+virtual bool transformsAffectFrameRect() { return true; }
+
#if PLATFORM(MAC)
NSView* getOuterView() const;
Modified: trunk/Source/WebCore/rendering/RenderWidget.cpp (98303 => 98304)
--- trunk/Source/WebCore/rendering/RenderWidget.cpp 2011-10-25 00:26:40 UTC (rev 98303)
+++ trunk/Source/WebCore/rendering/RenderWidget.cpp 2011-10-25 00:33:10 UTC (rev 98304)
@@ -166,6 +166,21 @@
return boundsChanged;
}
+bool RenderWidget::updateWidgetGeometry()
+{
+IntRect contentBox = contentBoxRect();
+if (!m_widget->transformsAffectFrameRect())
+return setWidgetGeometry(absoluteContentBox());
+
+IntRect absoluteContentBox = IntRect(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
+if (m_widget->isFrameView()) {
+contentBox.setLocation(absoluteContentBox.location());
+return setWidgetGeometry(contentBox);
+}
+
+return setWidgetGeometry(absoluteContentBox);
+}
+
void RenderWidget::setWidget(PassRefPtr widget)
{
if (widget == m_widget)
@@ -183,15 +198,9 @@
// widget immediately, but we have to have really been fully constructed (with a non-null
// style pointer).
if (style()) {
-if (!needsLayout()) {
-IntRect contentBox = contentBoxRect();
-IntRect absoluteContentBox = IntRect(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
-if (m_widget->isFrameView()) {
-contentBox.setLocation(absoluteContentBox.location());
-setWidgetGeometry(contentBox);
-} else
-setWidgetGeometry(absoluteContentBox);
-
[webkit-changes] [98302] trunk/Source/JavaScriptCore
Title: [98302] trunk/Source/_javascript_Core
Revision 98302
Author oli...@apple.com
Date 2011-10-24 17:21:29 -0700 (Mon, 24 Oct 2011)
Log Message
Crash in void JSC::validateCell(JSC::RegExp*)
https://bugs.webkit.org/show_bug.cgi?id=70689
Reviewed by Filip Pizlo.
While performing codegen we need to make the GlobalData explicitly
aware of the codeblock being compiled, as compilation may trigger GC
and CodeBlock holds GC values, but has not yet been assigned to its
owner executable.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::~BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::startedCompiling):
(JSC::JSGlobalData::finishedCompiling):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/heap/AllocationSpace.cpp
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98301 => 98302)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-25 00:19:30 UTC (rev 98301)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-25 00:21:29 UTC (rev 98302)
@@ -1,3 +1,29 @@
+2011-10-24 Oliver Hunt
+
+Crash in void JSC::validateCell(JSC::RegExp*)
+https://bugs.webkit.org/show_bug.cgi?id=70689
+
+Reviewed by Filip Pizlo.
+
+While performing codegen we need to make the GlobalData explicitly
+aware of the codeblock being compiled, as compilation may trigger GC
+and CodeBlock holds GC values, but has not yet been assigned to its
+owner executable.
+
+* bytecompiler/BytecodeGenerator.cpp:
+(JSC::BytecodeGenerator::BytecodeGenerator):
+(JSC::BytecodeGenerator::~BytecodeGenerator):
+* bytecompiler/BytecodeGenerator.h:
+* heap/AllocationSpace.cpp:
+(JSC::AllocationSpace::allocateSlowCase):
+* heap/Heap.cpp:
+(JSC::Heap::markRoots):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::JSGlobalData):
+* runtime/JSGlobalData.h:
+(JSC::JSGlobalData::startedCompiling):
+(JSC::JSGlobalData::finishedCompiling):
+
2011-10-24 Filip Pizlo
Object-or-other branch speculation may corrupt the state for OSR if the child of the
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp (98301 => 98302)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2011-10-25 00:19:30 UTC (rev 98301)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp 2011-10-25 00:21:29 UTC (rev 98302)
@@ -219,6 +219,7 @@
, m_usesExceptions(false)
, m_expressionTooDeep(false)
{
+m_globalData->startedCompiling(m_codeBlock);
if (m_shouldEmitDebugHooks)
m_codeBlock->setNeedsFullScopeChain(true);
@@ -289,6 +290,7 @@
, m_usesExceptions(false)
, m_expressionTooDeep(false)
{
+m_globalData->startedCompiling(m_codeBlock);
if (m_shouldEmitDebugHooks)
m_codeBlock->setNeedsFullScopeChain(true);
@@ -450,6 +452,7 @@
, m_usesExceptions(false)
, m_expressionTooDeep(false)
{
+m_globalData->startedCompiling(m_codeBlock);
if (m_shouldEmitDebugHooks || m_baseScopeDepth)
m_codeBlock->setNeedsFullScopeChain(true);
@@ -472,6 +475,11 @@
preserveLastVar();
}
+BytecodeGenerator::~BytecodeGenerator()
+{
+m_globalData->finishedCompiling(m_codeBlock);
+}
+
RegisterID* BytecodeGenerator::emitInitLazyRegister(RegisterID* reg)
{
emitOpcode(op_init_lazy_reg);
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (98301 => 98302)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2011-10-25 00:19:30 UTC (rev 98301)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2011-10-25 00:21:29 UTC (rev 98302)
@@ -96,6 +96,8 @@
BytecodeGenerator(FunctionBodyNode*, ScopeChainNode*, SymbolTable*, CodeBlock*, CompilationKind);
BytecodeGenerator(EvalNode*, ScopeChainNode*, SymbolTable*, EvalCodeBlock*, CompilationKind);
+~BytecodeGenerator();
+
JSGlobalData* globalData() const { return m_globalData; }
const CommonIdentifiers& propertyNames() const { return *m_globalData->propertyNames; }
Modified: trunk/Source/_javascript_Core/heap/AllocationSpace.cpp (98301 => 98302)
--- trunk/Source/_javascript_Core/heap/AllocationSpace.cpp 2011-10-25 00:19:30 UTC (rev 98301)
+++ trunk/Source/_javascript_Core/heap/AllocationSpace.cpp 2011-10-25 00:21:29 UTC (rev 98302)
@@ -44,7 +44,7 @@
[webkit-changes] [98301] trunk/LayoutTests
Title: [98301] trunk/LayoutTests Revision 98301 Author jchaffr...@webkit.org Date 2011-10-24 17:19:30 -0700 (Mon, 24 Oct 2011) Log Message Unreviewed rebaseline after r98293. * platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98300 => 98301) --- trunk/LayoutTests/ChangeLog 2011-10-25 00:13:34 UTC (rev 98300) +++ trunk/LayoutTests/ChangeLog 2011-10-25 00:19:30 UTC (rev 98301) @@ -1,3 +1,9 @@ +2011-10-24 Julien Chaffraix + +Unreviewed rebaseline after r98293. + +* platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png: Added. + 2011-10-24 Arko Saha Microdata: Add itemprop, itemref, itemvalue attributes. Added: trunk/LayoutTests/platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/svg/filters/feColorMatrix-default-type-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98299] trunk
Title: [98299] trunk
Revision 98299
Author fpi...@apple.com
Date 2011-10-24 17:00:14 -0700 (Mon, 24 Oct 2011)
Log Message
Object-or-other branch speculation may corrupt the state for OSR if the child of the
branch is an integer
https://bugs.webkit.org/show_bug.cgi?id=70777
Reviewed by Oliver Hunt.
Source/_javascript_Core:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
LayoutTests:
* fast/js/dfg-other-branch-expected.txt: Added.
* fast/js/dfg-other-branch.html: Added.
* fast/js/script-tests/dfg-other-branch.js: Added.
(foo):
(bar):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Added Paths
trunk/LayoutTests/fast/js/dfg-other-branch-expected.txt
trunk/LayoutTests/fast/js/dfg-other-branch.html
trunk/LayoutTests/fast/js/script-tests/dfg-other-branch.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98298 => 98299)
--- trunk/LayoutTests/ChangeLog 2011-10-24 23:45:13 UTC (rev 98298)
+++ trunk/LayoutTests/ChangeLog 2011-10-25 00:00:14 UTC (rev 98299)
@@ -1,3 +1,17 @@
+2011-10-24 Filip Pizlo
+
+Object-or-other branch speculation may corrupt the state for OSR if the child of the
+branch is an integer
+https://bugs.webkit.org/show_bug.cgi?id=70777
+
+Reviewed by Oliver Hunt.
+
+* fast/js/dfg-other-branch-expected.txt: Added.
+* fast/js/dfg-other-branch.html: Added.
+* fast/js/script-tests/dfg-other-branch.js: Added.
+(foo):
+(bar):
+
2011-10-24 Julien Chaffraix
Unreviewed gardening.
Added: trunk/LayoutTests/fast/js/dfg-other-branch-expected.txt (0 => 98299)
--- trunk/LayoutTests/fast/js/dfg-other-branch-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/dfg-other-branch-expected.txt 2011-10-25 00:00:14 UTC (rev 98299)
@@ -0,0 +1,29 @@
+This tests that speculating other on a branch does not corrupt state.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS foo({f:i}) is "no"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS foo({f:i}) is "yes"
+PASS bar({f:i}) is true
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS bar({f:i}) is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/js/dfg-other-branch.html (0 => 98299)
--- trunk/LayoutTests/fast/js/dfg-other-branch.html (rev 0)
+++ trunk/LayoutTests/fast/js/dfg-other-branch.html 2011-10-25 00:00:14 UTC (rev 98299)
@@ -0,0 +1,10 @@
+
+
+
+
[webkit-changes] [98298] trunk/LayoutTests
Title: [98298] trunk/LayoutTests
Revision 98298
Author jchaffr...@webkit.org
Date 2011-10-24 16:45:13 -0700 (Mon, 24 Oct 2011)
Log Message
Unreviewed gardening.
Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
The new result is consistent with the other platforms.
* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
* platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98297 => 98298)
--- trunk/LayoutTests/ChangeLog 2011-10-24 23:43:24 UTC (rev 98297)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 23:45:13 UTC (rev 98298)
@@ -1,3 +1,15 @@
+2011-10-24 Julien Chaffraix
+
+Unreviewed gardening.
+
+Bug 58013 has landed 3 months ago and it looks like the rebaseline was forgotten.
+The new result is consistent with the other platforms.
+
+* platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt: Removed.
+* platform/chromium-win/fast/repaint/scale-page-shrink-expected.png: Added.
+* platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
2011-10-24 Filip Pizlo
op_new_array_buffer is not inlined correctly
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98297 => 98298)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 23:43:24 UTC (rev 98297)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 23:45:13 UTC (rev 98298)
@@ -576,10 +576,6 @@
// error in the header of the following test.
BUGCR24197 SKIP : fast/css/disabled-author-styles.html = FAIL
-// Needs eventSender.scalePageBy().
-// These failures are going to be removed as a rebase line after the patch for bug 58013 is landed.
-BUGWK58013 WIN : fast/repaint/scale-page-shrink.html = IMAGE+TEXT
-
// -
// Inspector tests
// -
Deleted: trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt (98297 => 98298)
--- trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt 2011-10-24 23:43:24 UTC (rev 98297)
+++ trunk/LayoutTests/platform/chromium-linux/fast/repaint/scale-page-shrink-expected.txt 2011-10-24 23:45:13 UTC (rev 98298)
@@ -1,9 +0,0 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584
- RenderBlock (anonymous) at (0,0) size 784x20
-RenderText {#text} at (0,0) size 686x19
- text run at (0,0) width 686: "This test must be run in DumpRenderTree as a pixel test. There should not be visual aritfacts after scaling the page."
- RenderBlock {DIV} at (0,20) size 500x500 [bgcolor=#008000]
Added: trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt (0 => 98298)
--- trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt 2011-10-24 23:45:13 UTC (rev 98298)
@@ -0,0 +1,9 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock (anonymous) at (0,0) size 784x20
+RenderText {#text} at (0,0) size 686x19
+ text run at (0,0) width 686: "This test must be run in DumpRenderTree as a pixel test. There should not be visual aritfacts after scaling the page."
+ RenderBlock {DIV} at (0,20) size 500x500 [bgcolor=#008000]
Property changes on: trunk/LayoutTests/platform/chromium-win/fast/repaint/scale-page-shrink-expected.txt
___
Added: svn:eol-style
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.
[webkit-changes] [98297] branches/subpixellayout/Source/WebCore
Title: [98297] branches/subpixellayout/Source/WebCore
Revision 98297
Author le...@chromium.org
Date 2011-10-24 16:43:24 -0700 (Mon, 24 Oct 2011)
Log Message
Switching FloatingObjectTree/Interval to use rounded ints instead of LayoutUnits to correct comparisons with the line box tree.
Modified Paths
branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h
branches/subpixellayout/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj (98296 => 98297)
--- branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-24 23:22:39 UTC (rev 98296)
+++ branches/subpixellayout/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-10-24 23:43:24 UTC (rev 98297)
@@ -298,7 +298,7 @@
14C0A2BD1446321E00520798 /* FixedSizeCG.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BAB771A81444F24500EC4C4C /* FixedSizeCG.cpp */; };
14C0A2BE1446321E00520798 /* FixedSizeHash.h in Headers */ = {isa = PBXBuildFile; fileRef = BAB771511444CBD400EC4C4C /* FixedSizeHash.h */; settings = {ATTRIBUTES = (Private, ); }; };
14C0A2BF1446321E00520798 /* FixedSizeMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BAB771A51444F22E00EC4C4C /* FixedSizeMac.mm */; };
- 14C9A5EA0B3D105F005A0232 /* Settings.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14C9A5E90B3D105F005A0232 /* Settings.cpp */; };
+ 14C9A5EA0B3D105F005A0232 /* Settings.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14C9A5E90B3D105F005A0232 /* Settings.cpp */; };
14CD8D82106B529000A46D23 /* JSSharedWorkerCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14CD8D81106B529000A46D23 /* JSSharedWorkerCustom.cpp */; };
14CF78A409F58CBF00EB3665 /* JSCSSValue.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 14CF78A309F58CBF00EB3665 /* JSCSSValue.cpp */; };
14CF78A609F58CD800EB3665 /* JSCSSValue.h in Headers */ = {isa = PBXBuildFile; fileRef = 14CF78A509F58CD800EB3665 /* JSCSSValue.h */; };
@@ -27624,7 +27624,6 @@
14C0A2BB1446321E00520798 /* FixedSize.cpp in Sources */,
14C0A2BD1446321E00520798 /* FixedSizeCG.cpp in Sources */,
14C0A2BF1446321E00520798 /* FixedSizeMac.mm in Sources */,
-14C0A2C01446321E00520798 /* FloatPoint.cpp in Sources */,
29D7BCF61444AF580070619C /* AccessibilitySpinButton.cpp in Sources */,
0F09087F1444FDB200028917 /* ScrollbarTheme.cpp in Sources */,
9B375EDA14478A0100F3CAE5 /* MicroDataItemList.cpp in Sources */,
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp (98296 => 98297)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2011-10-24 23:22:39 UTC (rev 98296)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2011-10-24 23:43:24 UTC (rev 98297)
@@ -3645,7 +3645,7 @@
*heightRemaining = 1;
LayoutUnit rightFloatOffset = fixedOffset;
-FloatIntervalSearchAdapter adapter(this, logicalTop, rightFloatOffset, heightRemaining);
+FloatIntervalSearchAdapter adapter(this, logicalTop.round(), rightFloatOffset, heightRemaining);
m_floatingObjects->placedFloatsTree().allOverlapsWithAdapter(adapter);
right = min(right, rightFloatOffset);
}
@@ -6807,8 +6807,8 @@
inline RenderBlock::FloatingObjectInterval RenderBlock::FloatingObjects::intervalForFloatingObject(FloatingObject* floatingObject)
{
if (m_horizontalWritingMode)
-return RenderBlock::FloatingObjectInterval(floatingObject->y(), floatingObject->maxY(), floatingObject);
-return RenderBlock::FloatingObjectInterval(floatingObject->x(), floatingObject->maxX(), floatingObject);
+return RenderBlock::FloatingObjectInterval(floatingObject->y().round(), floatingObject->maxY().round(), floatingObject);
+return RenderBlock::FloatingObjectInterval(floatingObject->x().round(), floatingObject->maxX().round(), floatingObject);
}
void RenderBlock::FloatingObjects::addPlacedObject(FloatingObject* floatingObject)
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h (98296 => 98297)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2011-10-24 23:22:39 UTC (rev 98296)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2011-10-24 23:43:24 UTC (rev 98297)
@@ -915,15 +915,15 @@
};
typedef ListHashSet FloatingObjectSet;
typedef FloatingObjectSet::const_iterator FloatingObjectSetIterator;
-typedef PODInterval FloatingObjectInterval;
-typedef PODIntervalTree FloatingObjectTree;
+typedef PODInterval FloatingObjectInterval;
+typedef PODIntervalTree FloatingObjectTree;
template
class FloatIntervalSearchAdapter {
public:
typedef FloatingObjectInterval IntervalType;
-FloatIntervalSearchAdapter(const RenderBlock* renderer, La
[webkit-changes] [98296] trunk
Title: [98296] trunk Revision 98296 Author fpi...@apple.com Date 2011-10-24 16:22:39 -0700 (Mon, 24 Oct 2011) Log Message op_new_array_buffer is not inlined correctly https://bugs.webkit.org/show_bug.cgi?id=70770 Source/_javascript_Core: Reviewed by Oliver Hunt. Disabled inlining of op_new_array_buffer, for now. * dfg/DFGCapabilities.h: (JSC::DFG::canInlineOpcode): LayoutTests: Reviewed by Oliver Hunt. * fast/js/dfg-inline-new-array-buffer-expected.txt: Added. * fast/js/dfg-inline-new-array-buffer.html: Added. * fast/js/script-tests/dfg-inline-new-array-buffer.js: Added. (foo): (bar): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGCapabilities.h Added Paths trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer-expected.txt trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer.html trunk/LayoutTests/fast/js/script-tests/dfg-inline-new-array-buffer.js Diff Modified: trunk/LayoutTests/ChangeLog (98295 => 98296) --- trunk/LayoutTests/ChangeLog 2011-10-24 23:03:14 UTC (rev 98295) +++ trunk/LayoutTests/ChangeLog 2011-10-24 23:22:39 UTC (rev 98296) @@ -1,3 +1,16 @@ +2011-10-24 Filip Pizlo + +op_new_array_buffer is not inlined correctly +https://bugs.webkit.org/show_bug.cgi?id=70770 + +Reviewed by Oliver Hunt. + +* fast/js/dfg-inline-new-array-buffer-expected.txt: Added. +* fast/js/dfg-inline-new-array-buffer.html: Added. +* fast/js/script-tests/dfg-inline-new-array-buffer.js: Added. +(foo): +(bar): + 2011-10-24 Tim Horton feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified Added: trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer-expected.txt (0 => 98296) --- trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer-expected.txt 2011-10-24 23:22:39 UTC (rev 98296) @@ -0,0 +1,49 @@ +This tests that inlining correctly handles constant buffers. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS bar()[0] is 1 +PASS bar()[1] is 2 +PASS bar()[2] is 3 +PASS bar()[3] is 4 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer.html (0 => 98296) --- trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer.html (rev 0) +++ trunk/LayoutTests/fast/js/dfg-inline-new-array-buffer.html 2011-10-24 23:22:39 UTC (rev 98296) @@ -0,0 +1,10 @@ + + + +
[webkit-changes] [98295] trunk/Source/WebCore
Title: [98295] trunk/Source/WebCore
Revision 98295
Author joep...@webkit.org
Date 2011-10-24 16:03:14 -0700 (Mon, 24 Oct 2011)
Log Message
Remove unused instance variable
https://bugs.webkit.org/show_bug.cgi?id=70750
Reviewed by Dimitri Glazkov.
* rendering/RenderTextControl.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98294 => 98295)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 23:02:05 UTC (rev 98294)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 23:03:14 UTC (rev 98295)
@@ -1,3 +1,12 @@
+2011-10-24 Joseph Pecoraro
+
+Remove unused instance variable
+https://bugs.webkit.org/show_bug.cgi?id=70750
+
+Reviewed by Dimitri Glazkov.
+
+* rendering/RenderTextControl.h:
+
2011-10-24 Nico Weber
[chromium/mac] Fix an ODR violation.
Modified: trunk/Source/WebCore/rendering/RenderTextControl.h (98294 => 98295)
--- trunk/Source/WebCore/rendering/RenderTextControl.h 2011-10-24 23:02:05 UTC (rev 98294)
+++ trunk/Source/WebCore/rendering/RenderTextControl.h 2011-10-24 23:03:14 UTC (rev 98295)
@@ -65,8 +65,6 @@
virtual void computeLogicalHeight();
virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren);
-bool m_placeholderVisible;
-
private:
virtual const char* renderName() const { return "RenderTextControl"; }
virtual bool isTextControl() const { return true; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98294] trunk/Source/WebCore
Title: [98294] trunk/Source/WebCore
Revision 98294
Author tha...@chromium.org
Date 2011-10-24 16:02:05 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753
Reviewed by Anders Carlsson.
Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.
* WebCore.gyp/WebCore.gyp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98293 => 98294)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 22:56:01 UTC (rev 98293)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 23:02:05 UTC (rev 98294)
@@ -1,3 +1,15 @@
+2011-10-24 Nico Weber
+
+[chromium/mac] Fix an ODR violation.
+https://bugs.webkit.org/show_bug.cgi?id=70753
+
+Reviewed by Anders Carlsson.
+
+Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
+Remove the unused one.
+
+* WebCore.gyp/WebCore.gyp:
+
2011-10-24 Tim Horton
feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (98293 => 98294)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-24 22:56:01 UTC (rev 98293)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2011-10-24 23:02:05 UTC (rev 98294)
@@ -1465,7 +1465,7 @@
# Cherry-pick some files that can't be included by broader regexps.
# Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the "sources!" list below.
+# the specific exclusions in the "exclude" list below.
['include', 'rendering/RenderThemeMac\\.mm$'],
['include', 'platform/graphics/mac/ColorMac\\.mm$'],
['include', 'platform/graphics/mac/ComplexTextControllerCoreText\\.mm$'],
@@ -1505,6 +1505,10 @@
['exclude', 'platform/graphics/cg/ImageSourceCG\\.cpp$'],
['exclude', 'platform/graphics/cg/PDFDocumentImage\\.cpp$'],
+# Mac uses only ScrollAnimatorMac.
+['exclude', 'platform/ScrollAnimatorNone\\.cpp$'],
+['exclude', 'platform/ScrollAnimatorNone\\.h$'],
+
['include', '/chrome/junk\\.txt$'],
],
},{ # OS!="mac"
@@ -1518,7 +1522,7 @@
'sources/': [
# Cherry-pick some files that can't be included by broader regexps.
# Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the "sources!" list below.
+# the specific exclusions in the "exclude" list below.
['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
# Chromium Mac does not use skia.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98293] trunk
Title: [98293] trunk
Revision 98293
Author timothy_hor...@apple.com
Date 2011-10-24 15:56:01 -0700 (Mon, 24 Oct 2011)
Log Message
feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
https://bugs.webkit.org/show_bug.cgi?id=70035
Reviewed by Nikolas Zimmermann.
Make feColorMatrix's type attribute be "matrix" by default.
Test: svg/filters/feColorMatrix-default-type.svg
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGFEColorMatrixElement.cpp
Added Paths
trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.png
trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.txt
trunk/LayoutTests/svg/filters/feColorMatrix-default-type.svg
Diff
Modified: trunk/LayoutTests/ChangeLog (98292 => 98293)
--- trunk/LayoutTests/ChangeLog 2011-10-24 22:51:51 UTC (rev 98292)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 22:56:01 UTC (rev 98293)
@@ -1,3 +1,17 @@
+2011-10-24 Tim Horton
+
+feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
+https://bugs.webkit.org/show_bug.cgi?id=70035
+
+
+Reviewed by Nikolas Zimmermann.
+
+Add a test that ensures that feColorMatrix's type attribute defaults to "matrix".
+
+* platform/mac/svg/filters/feColorMatrix-default-type-expected.png: Added.
+* platform/mac/svg/filters/feColorMatrix-default-type-expected.txt: Added.
+* svg/filters/feColorMatrix-default-type.svg: Added.
+
2011-10-24 Levi Weintraub
Adding Chromium expectations from http://trac.webkit.org/changeset/98263
Added: trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.txt (0 => 98293)
--- trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/filters/feColorMatrix-default-type-expected.txt 2011-10-24 22:56:01 UTC (rev 98293)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderSVGRoot {svg} at (0,0) size 230x111
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+ RenderSVGResourceFilter {filter} [id="filt"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type="MATRIX" values="0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00"]
+ [SourceGraphic]
+ RenderSVGResourceFilter {filter} [id="filt2"] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feColorMatrix type="MATRIX" values="0.00 0.00 0.00 0.00 0.00 1.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 1.00 0.00"]
+ [SourceGraphic]
+RenderSVGPath {rect} at (0,0) size 111x111 [fill={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=100.00] [height=100.00]
+ [filter="filt"] RenderSVGResourceFilter {filter} at (-10,-10) size 120x120
+RenderSVGPath {rect} at (110,0) size 120x111 [fill={[type=SOLID] [color=#FF]}] [x=120.00] [y=0.00] [width=100.00] [height=100.00]
+ [filter="filt2"] RenderSVGResourceFilter {filter} at (110,-10) size 120x120
Added: trunk/LayoutTests/svg/filters/feColorMatrix-default-type.svg (0 => 98293)
--- trunk/LayoutTests/svg/filters/feColorMatrix-default-type.svg (rev 0)
+++ trunk/LayoutTests/svg/filters/feColorMatrix-default-type.svg 2011-10-24 22:56:01 UTC (rev 98293)
@@ -0,0 +1,19 @@
+
+There should be two green squares.
+
+
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (98292 => 98293)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 22:51:51 UTC (rev 98292)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 22:56:01 UTC (rev 98293)
@@ -1,3 +1,18 @@
+2011-10-24 Tim Horton
+
+feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
+https://bugs.webkit.org/show_bug.cgi?id=70035
+
+
+Reviewed by Nikolas Zimmermann.
+
+Make feColorMatrix's type attribute be "matrix" by default.
+
+Test: svg/filters/feColorMatrix-default-type.svg
+
+* svg/SVGFEColorMatrixElement.cpp:
+(WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
+
2011-10-24 Joshua Bell
Unbreak binding generation tests
Modified: trunk/Source/WebCore/svg/SVGFEColorMatrixElement.cpp (98292 => 98293)
--- trunk/Sour
[webkit-changes] [98292] trunk/Source/WebKit/efl
Title: [98292] trunk/Source/WebKit/efl
Revision 98292
Author commit-qu...@webkit.org
Date 2011-10-24 15:51:51 -0700 (Mon, 24 Oct 2011)
Log Message
[EFL] Build fix. Rename all instances of a variable when it gets changed
https://bugs.webkit.org/show_bug.cgi?id=70732
Unreviewed build fix.
Patch by Ivan Briano on 2011-10-24
* ewk/ewk_js.cpp:
(ewk_js_property_set): s/obj/object/
* ewk/ewk_view.cpp:
(ewk_view_js_object_add): s/exec/executeState/
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_js.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (98291 => 98292)
--- trunk/Source/WebKit/efl/ChangeLog 2011-10-24 22:51:25 UTC (rev 98291)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-10-24 22:51:51 UTC (rev 98292)
@@ -1,3 +1,15 @@
+2011-10-24 Ivan Briano
+
+[EFL] Build fix. Rename all instances of a variable when it gets changed
+https://bugs.webkit.org/show_bug.cgi?id=70732
+
+Unreviewed build fix.
+
+* ewk/ewk_js.cpp:
+(ewk_js_property_set): s/obj/object/
+* ewk/ewk_view.cpp:
+(ewk_view_js_object_add): s/exec/executeState/
+
2011-10-21 Gyuyoung Kim
[EFL] Change efl style local variables with WebKit coding Style.
Modified: trunk/Source/WebKit/efl/ewk/ewk_js.cpp (98291 => 98292)
--- trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2011-10-24 22:51:25 UTC (rev 98291)
+++ trunk/Source/WebKit/efl/ewk/ewk_js.cpp 2011-10-24 22:51:51 UTC (rev 98292)
@@ -153,7 +153,7 @@
bool fail = false;
EINA_SAFETY_ON_NULL_RETURN_VAL(npObject, false);
-EINA_MAGIC_CHECK_OR_RETURN(obj, false);
+EINA_MAGIC_CHECK_OR_RETURN(object, false);
if (!_NPN_IdentifierIsString(name)) {
ERR("int NPIdentifier is not supported.");
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (98291 => 98292)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-24 22:51:25 UTC (rev 98291)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-24 22:51:51 UTC (rev 98292)
@@ -3654,10 +3654,10 @@
object->view = ewkView;
JSC::JSObject* runtimeObject = (JSC::JSObject*)JSC::Bindings::CInstance::create((NPObject*)object, root)->createRuntimeObject(executeState);
-JSC::Identifier id = JSC::Identifier(exec, objectName);
+JSC::Identifier id = JSC::Identifier(executeState, objectName);
JSC::PutPropertySlot slot;
-window->putVirtual(exec, id, runtimeObject, slot);
+window->putVirtual(executeState, id, runtimeObject, slot);
return EINA_TRUE;
#else
return EINA_FALSE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98290] trunk/Tools
Title: [98290] trunk/Tools
Revision 98290
Author commit-qu...@webkit.org
Date 2011-10-24 15:49:26 -0700 (Mon, 24 Oct 2011)
Log Message
[EFL] Build fix. Add include path to find npapi.h
https://bugs.webkit.org/show_bug.cgi?id=70730
Unreviewed build fix.
Patch by Ivan Briano on 2011-10-24
* DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/CMakeLists.txt
Diff
Modified: trunk/Tools/ChangeLog (98289 => 98290)
--- trunk/Tools/ChangeLog 2011-10-24 22:39:16 UTC (rev 98289)
+++ trunk/Tools/ChangeLog 2011-10-24 22:49:26 UTC (rev 98290)
@@ -1,3 +1,12 @@
+2011-10-24 Ivan Briano
+
+[EFL] Build fix. Add include path to find npapi.h
+https://bugs.webkit.org/show_bug.cgi?id=70730
+
+Unreviewed build fix.
+
+* DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
+
2011-10-24 Eric Seidel
Plugin tests are failing after switching WK2 to NRWT
Modified: trunk/Tools/DumpRenderTree/efl/CMakeLists.txt (98289 => 98290)
--- trunk/Tools/DumpRenderTree/efl/CMakeLists.txt 2011-10-24 22:39:16 UTC (rev 98289)
+++ trunk/Tools/DumpRenderTree/efl/CMakeLists.txt 2011-10-24 22:49:26 UTC (rev 98290)
@@ -59,6 +59,7 @@
${WEBCORE_DIR}/platform/graphics
${WEBCORE_DIR}/platform/graphics/cairo
${WEBCORE_DIR}/platform/network
+${WEBCORE_DIR}/plugins
${WEBCORE_DIR}/rendering
${WEBCORE_DIR}/rendering/style
${WEBCORE_DIR}/history
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98289] trunk/Source/WebCore
Title: [98289] trunk/Source/WebCore
Revision 98289
Author t...@chromium.org
Date 2011-10-24 15:39:16 -0700 (Mon, 24 Oct 2011)
Log Message
Unbreak binding generation tests
https://bugs.webkit.org/show_bug.cgi?id=70768
Patch by Joshua Bell on 2011-10-24
Reviewed by Darin Adler.
Update the expected output of V8 binding tests to match
results c/o https://bugs.webkit.org/show_bug.cgi?id=70065
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::idbKeyCallback):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98288 => 98289)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 22:26:06 UTC (rev 98288)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 22:39:16 UTC (rev 98289)
@@ -1,3 +1,16 @@
+2011-10-24 Joshua Bell
+
+Unbreak binding generation tests
+https://bugs.webkit.org/show_bug.cgi?id=70768
+
+Reviewed by Darin Adler.
+
+Update the expected output of V8 binding tests to match
+results c/o https://bugs.webkit.org/show_bug.cgi?id=70065
+
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjInternal::idbKeyCallback):
+
2011-10-21 Nat Duca
[chromium] Add isTraceEventEnabled to PlatformSupport.
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (98288 => 98289)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-24 22:26:06 UTC (rev 98288)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2011-10-24 22:39:16 UTC (rev 98289)
@@ -780,19 +780,9 @@
{
INC_STATS("DOM.TestObj.idbKey");
TestObj* imp = V8TestObj::toNative(args.Holder());
-ExceptionCode ec = 0;
-{
-RefPtr key = createIDBKeyFromValue(args[0]);
-if (UNLIKELY(!key)) {
-ec = TYPE_MISMATCH_ERR;
-goto fail;
-}
+EXCEPTION_BLOCK(RefPtr, key, createIDBKeyFromValue(MAYBE_MISSING_PARAMETER(args, 0, MissingIsUndefined)));
imp->idbKey(key);
return v8::Handle();
-}
-fail:
-V8Proxy::setDOMException(ec);
-return v8::Handle();
}
static v8::Handle optionsObjectCallback(const v8::Arguments& args)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98288] trunk/Tools
Title: [98288] trunk/Tools
Revision 98288
Author e...@webkit.org
Date 2011-10-24 15:26:06 -0700 (Mon, 24 Oct 2011)
Log Message
Plugin tests are failing after switching WK2 to NRWT
https://bugs.webkit.org/show_bug.cgi?id=70760
Reviewed by Simon Fraser.
Perpetuate this horrible hack.
* Scripts/webkitpy/layout_tests/port/webkit.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98287 => 98288)
--- trunk/Tools/ChangeLog 2011-10-24 22:19:32 UTC (rev 98287)
+++ trunk/Tools/ChangeLog 2011-10-24 22:26:06 UTC (rev 98288)
@@ -1,5 +1,16 @@
2011-10-24 Eric Seidel
+Plugin tests are failing after switching WK2 to NRWT
+https://bugs.webkit.org/show_bug.cgi?id=70760
+
+Reviewed by Simon Fraser.
+
+Perpetuate this horrible hack.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+
+2011-10-24 Eric Seidel
+
NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (98287 => 98288)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-24 22:19:32 UTC (rev 98287)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-24 22:26:06 UTC (rev 98288)
@@ -110,8 +110,15 @@
return self._executive.run_command(run_script_command, cwd=self._config.webkit_base_dir(), decode_output=decode_output)
def _build_driver(self):
+# FIXME: We build both DumpRenderTree and WebKitTestRunner for
+# WebKitTestRunner runs because DumpRenderTree still includes
+# the DumpRenderTreeSupport module and the TestNetscapePlugin.
+# These two projects should be factored out into their own
+# projects.
try:
-self._run_script(self._driver_build_script_name())
+self._run_script("build-dumprendertree")
+if self.get_option('webkit_test_runner'):
+self._run_script("build-webkittestrunner")
except ScriptError:
_log.error("Failed to build %s" % self.driver_name())
return False
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (98287 => 98288)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-10-24 22:19:32 UTC (rev 98287)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-10-24 22:26:06 UTC (rev 98288)
@@ -155,12 +155,13 @@
# Make sure when passed --webkit-test-runner web build the right tool.
port._options = MockOptions(webkit_test_runner=True, configuration="Release")
-expected_stderr = "MOCK run_command: ['Tools/Scripts/build-webkittestrunner', '--release'], cwd=/mock-checkout\n"
+expected_stderr = "MOCK run_command: ['Tools/Scripts/build-dumprendertree', '--release'], cwd=/mock-checkout\nMOCK run_command: ['Tools/Scripts/build-webkittestrunner', '--release'], cwd=/mock-checkout\n"
self.assertTrue(output.assert_outputs(self, port._build_driver, expected_stderr=expected_stderr))
# Make sure that failure to build returns False.
port._executive = MockExecutive(should_log=True, should_throw=True)
-expected_stderr = "MOCK run_command: ['Tools/Scripts/build-webkittestrunner', '--release'], cwd=/mock-checkout\n"
+# Because WK2 currently has to build both webkittestrunner and DRT, if DRT fails, that's the only one it tries.
+expected_stderr = "MOCK run_command: ['Tools/Scripts/build-dumprendertree', '--release'], cwd=/mock-checkout\n"
self.assertFalse(output.assert_outputs(self, port._build_driver, expected_stderr=expected_stderr))
def _assert_config_file_for_platform(self, port, platform, config_file):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98287] trunk/LayoutTests
Title: [98287] trunk/LayoutTests Revision 98287 Author le...@chromium.org Date 2011-10-24 15:19:32 -0700 (Mon, 24 Oct 2011) Log Message Adding Chromium expectations from http://trac.webkit.org/changeset/98263 Unreviewed. * platform/chromium-cg-mac-snowleopard/svg/as-object: Added. * platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. * platform/chromium-linux-x86/svg/as-object: Removed. * platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. * platform/chromium-mac-snowleopard/svg/as-object: Added. * platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. * platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. * platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/as-object/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png trunk/LayoutTests/platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/as-object/ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png trunk/LayoutTests/platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png trunk/LayoutTests/platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-linux-x86/svg/as-object/ Diff Modified: trunk/LayoutTests/ChangeLog (98286 => 98287) --- trunk/LayoutTests/ChangeLog 2011-10-24 22:15:51 UTC (rev 98286) +++ trunk/LayoutTests/ChangeLog 2011-10-24 22:19:32 UTC (rev 98287) @@ -1,5 +1,21 @@ 2011-10-24 Levi Weintraub +Adding Chromium expectations from http://trac.webkit.org/changeset/98263 + +Unreviewed. + +* platform/chromium-cg-mac-snowleopard/svg/as-object: Added. +* platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. +* platform/chromium-linux-x86/svg/as-object: Removed. +* platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. +* platform/chromium-mac-snowleopard/svg/as-object: Added. +* platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. +* platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added. +* platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added. +* platform/chromium/test_expectations.txt: + +2011-10-24 Levi Weintraub + Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263 Unreviewed test expectations update. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98286 => 98287) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 22:15:51 UTC (rev 98286) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 22:19:32 UTC (rev 98287) @@ -3812,6 +3812,3 @@ BUGWK67031 SNOWLEOPARD DEBUG : storage/domstorage/events/basic-body-attribute.html = PASS CRASH BUGWK70749 SNOWLEOPARD CPU GPU : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS - -// Will rebaseline -BUGLEVIW : svg/as-object/svg-embedded-in-html-in-iframe.html = FAIL Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/as-object/svg-embedded-in-html-in-iframe-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/as-object/svg-embedded-in-html-in-iframe-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-win/svg/as-object/svg-embedded-in-html-in-iframe-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-win/svg/as-object/svg-embedded-in-html-in-ifr
[webkit-changes] [98286] trunk/LayoutTests
Title: [98286] trunk/LayoutTests
Revision 98286
Author le...@chromium.org
Date 2011-10-24 15:15:51 -0700 (Mon, 24 Oct 2011)
Log Message
Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263
Unreviewed test expectations update.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes
an empty text node.
* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt
Added Paths
trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98285 => 98286)
--- trunk/LayoutTests/ChangeLog 2011-10-24 22:07:24 UTC (rev 98285)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 22:15:51 UTC (rev 98286)
@@ -1,3 +1,13 @@
+2011-10-24 Levi Weintraub
+
+Fixing a collision in Mac results and adding qt results from http://trac.webkit.org/changeset/98263
+
+Unreviewed test expectations update.
+
+* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Fixing collision that removes
+an empty text node.
+* platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt: Added.
+
2011-10-24 Joshua Bell
IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
Modified: trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (98285 => 98286)
--- trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt 2011-10-24 22:07:24 UTC (rev 98285)
+++ trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt 2011-10-24 22:15:51 UTC (rev 98286)
@@ -11,5 +11,4 @@
RenderBody {BODY} at (8,8) size 768x104
RenderSVGRoot {svg} at (8,8) size 100x100
RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
- RenderText {#text} at (0,0) size 0x0
RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt (0 => 98286)
--- trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/svg/as-object/svg-embedded-in-html-in-iframe-actual.txt 2011-10-24 22:15:51 UTC (rev 98286)
@@ -0,0 +1,14 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x171
+ RenderBlock {HTML} at (0,0) size 800x171
+RenderBody {BODY} at (8,8) size 784x155
+ RenderPartObject {IFRAME} at (0,0) size 784x150
+layer at (0,0) size 784x150
+ RenderView at (0,0) size 784x150
+layer at (0,0) size 784x121
+ RenderBlock {HTML} at (0,0) size 784x121
+RenderBody {BODY} at (8,8) size 768x105
+ RenderSVGRoot {svg} at (8,8) size 100x100
+RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
+ RenderText {#text} at (0,0) size 0x0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98285] trunk/Source/WebKit2
Title: [98285] trunk/Source/WebKit2
Revision 98285
Author wei...@apple.com
Date 2011-10-24 15:07:24 -0700 (Mon, 24 Oct 2011)
Log Message
Hook up minimalist load delegate to WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70764
Reviewed by Simon Fraser.
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
Add loadDelegate getter/setter. As per convention, the delegate is not
retained.
(didStartProvisionalLoadForFrame):
(didCommitLoadForFrame):
(didFinishLoadForFrame):
(setUpPageLoaderClient):
(-[WKBrowsingContextController initWithPageRef:]):
Hookup the delegate to a WKPageLoaderClient.
* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.
Add load delegate as a proper protocol.
* WebKit2.xcodeproj/project.pbxproj:
Add new file.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98284 => 98285)
--- trunk/Source/WebKit2/ChangeLog 2011-10-24 21:58:41 UTC (rev 98284)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-24 22:07:24 UTC (rev 98285)
@@ -1,3 +1,30 @@
+2011-10-24 Sam Weinig
+
+Hook up minimalist load delegate to WKBrowsingContextController
+https://bugs.webkit.org/show_bug.cgi?id=70764
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/mac/WKBrowsingContextController.h:
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(-[WKBrowsingContextController loadDelegate]):
+(-[WKBrowsingContextController setLoadDelegate:]):
+Add loadDelegate getter/setter. As per convention, the delegate is not
+retained.
+
+(didStartProvisionalLoadForFrame):
+(didCommitLoadForFrame):
+(didFinishLoadForFrame):
+(setUpPageLoaderClient):
+(-[WKBrowsingContextController initWithPageRef:]):
+Hookup the delegate to a WKPageLoaderClient.
+
+* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Added.
+Add load delegate as a proper protocol.
+
+* WebKit2.xcodeproj/project.pbxproj:
+Add new file.
+
2011-10-24 Michael Saboff
WebKit doesn't build with recent changes to libdispatch
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h (98284 => 98285)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 21:58:41 UTC (rev 98284)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 22:07:24 UTC (rev 98285)
@@ -27,6 +27,7 @@
#import
@class WKBrowsingContextControllerData;
+@protocol WKBrowsingContextLoadDelegate;
WK_EXPORT
@interface WKBrowsingContextController : NSObject {
@@ -34,6 +35,11 @@
WKBrowsingContextControllerData *_data;
}
+#pragma mark Delegates
+
+@property(assign) id loadDelegate;
+
+
#pragma mark Loading
/* Load a request. This is only valid for requests of non-file: URLs. Passing a
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (98284 => 98285)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 21:58:41 UTC (rev 98284)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 22:07:24 UTC (rev 98285)
@@ -35,6 +35,7 @@
#import "WKURLRequest.h"
#import "WKURLRequestNS.h"
+#import "WKBrowsingContextLoadDelegate.h"
static inline NSString *autoreleased(WKStringRef string)
{
@@ -51,7 +52,11 @@
@interface WKBrowsingContextControllerData : NSObject {
@public
+// Underlying WKPageRef.
WKRetainPtr _pageRef;
+
+// Delegate for load callbacks.
+id _loadDelegate;
}
@end
@@ -71,6 +76,19 @@
return _data->_pageRef.get();
}
+#pragma mark Delegates
+
+- (id)loadDelegate
+{
+return _data->_loadDelegate;
+}
+
+- (void)setLoadDelegate:(id)loadDelegate
+{
+_data->_loadDelegate = loadDelegate;
+}
+
+
#pragma mark Loading
- (void)loadRequest:(NSURLRequest *)request
@@ -185,6 +203,48 @@
@implementation WKBrowsingContextController (Internal)
+static void didStartProvisionalLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
+{
+if (!WKFrameIsMainFrame(frame))
+return;
+
+WKBrowsingContextController *browsingContext = (WKBrowsingContextController *)clientInfo;
+[browsingContext.loadDelegate browsingContextControllerDidStartProvisionalLoad:browsingContext];
+}
+
+static void didCommitLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
+{
+if (!WKFrameIsMainFrame(frame))
+return;
+
+WKBrowsingContextControl
[webkit-changes] [98284] trunk/Source/WebKit/chromium
Title: [98284] trunk/Source/WebKit/chromium Revision 98284 Author commit-qu...@webkit.org Date 2011-10-24 14:58:41 -0700 (Mon, 24 Oct 2011) Log Message Unreviewed, rolling out r98266. http://trac.webkit.org/changeset/98266 https://bugs.webkit.org/show_bug.cgi?id=70767 Broke the chromium build. (Requested by dave_levin on #webkit). Patch by Sheriff Bot on 2011-10-24 * features.gypi: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (98283 => 98284) --- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 21:29:02 UTC (rev 98283) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 21:58:41 UTC (rev 98284) @@ -1,3 +1,14 @@ +2011-10-24 Sheriff Bot + +Unreviewed, rolling out r98266. +http://trac.webkit.org/changeset/98266 +https://bugs.webkit.org/show_bug.cgi?id=70767 + +Broke the chromium build. (Requested by dave_levin on +#webkit). + +* features.gypi: + 2011-10-21 Nat Duca [chromium] Add isTraceEventEnabled to PlatformSupport. Modified: trunk/Source/WebKit/chromium/features.gypi (98283 => 98284) --- trunk/Source/WebKit/chromium/features.gypi 2011-10-24 21:29:02 UTC (rev 98283) +++ trunk/Source/WebKit/chromium/features.gypi 2011-10-24 21:58:41 UTC (rev 98284) @@ -63,7 +63,6 @@ 'ENABLE_JAVASCRIPT_DEBUGGER=1', 'ENABLE_JAVASCRIPT_I18N_API=1', 'ENABLE_LINK_PREFETCH=1', - 'ENABLE_MEDIA_SOURCE=1', 'ENABLE_MEDIA_STATISTICS=1', 'ENABLE_MEDIA_STREAM=1', 'ENABLE_METER_TAG=1', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98283] branches/safari-534.52-branch/Source
Title: [98283] branches/safari-534.52-branch/Source Revision 98283 Author lforsch...@apple.com Date 2011-10-24 14:29:02 -0700 (Mon, 24 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98282 => 98283) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 21:19:24 UTC (rev 98282) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 21:29:02 UTC (rev 98283) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98282 => 98283) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 21:19:24 UTC (rev 98282) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 21:29:02 UTC (rev 98283) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98282 => 98283) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 21:19:24 UTC (rev 98282) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 21:29:02 UTC (rev 98283) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98282 => 98283) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 21:19:24 UTC (rev 98282) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 21:29:02 UTC (rev 98283) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98282 => 98283) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 21:19:24 UTC (rev 98282) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 21:29:02 UTC (rev 98283) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 3; +TINY_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98282] trunk/Source
Title: [98282] trunk/Source
Revision 98282
Author nd...@chromium.org
Date 2011-10-24 14:19:24 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Add isTraceEventEnabled to PlatformSupport.
https://bugs.webkit.org/show_bug.cgi?id=70618
Reviewed by Darin Fisher.
Source/WebCore:
* platform/chromium/PlatformSupport.h:
Source/WebKit/chromium:
* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::isTraceEventEnabled):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::isTraceEventEnabled):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebKitPlatformSupport.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98281 => 98282)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 21:01:24 UTC (rev 98281)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 21:19:24 UTC (rev 98282)
@@ -1,3 +1,12 @@
+2011-10-21 Nat Duca
+
+[chromium] Add isTraceEventEnabled to PlatformSupport.
+https://bugs.webkit.org/show_bug.cgi?id=70618
+
+Reviewed by Darin Fisher.
+
+* platform/chromium/PlatformSupport.h:
+
2011-10-24 Mihnea Ovidenie
Use StringBuilder in CSSRuleList::rulesText()/CSSSelectorList::selectorsText()
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (98281 => 98282)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-10-24 21:01:24 UTC (rev 98281)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-10-24 21:19:24 UTC (rev 98282)
@@ -405,6 +405,7 @@
#endif
// Trace Event
+static bool isTraceEventEnabled();
static void traceEventBegin(const char* name, void*, const char* extra);
static void traceEventEnd(const char* name, void*, const char* extra);
Modified: trunk/Source/WebKit/chromium/ChangeLog (98281 => 98282)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 21:01:24 UTC (rev 98281)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 21:19:24 UTC (rev 98282)
@@ -1,3 +1,15 @@
+2011-10-21 Nat Duca
+
+[chromium] Add isTraceEventEnabled to PlatformSupport.
+https://bugs.webkit.org/show_bug.cgi?id=70618
+
+Reviewed by Darin Fisher.
+
+* public/WebKitPlatformSupport.h:
+(WebKit::WebKitPlatformSupport::isTraceEventEnabled):
+* src/PlatformSupport.cpp:
+(WebCore::PlatformSupport::isTraceEventEnabled):
+
2011-10-24 Joshua Bell
IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
Modified: trunk/Source/WebKit/chromium/public/WebKitPlatformSupport.h (98281 => 98282)
--- trunk/Source/WebKit/chromium/public/WebKitPlatformSupport.h 2011-10-24 21:01:24 UTC (rev 98281)
+++ trunk/Source/WebKit/chromium/public/WebKitPlatformSupport.h 2011-10-24 21:19:24 UTC (rev 98282)
@@ -230,6 +230,7 @@
// An event is identified by the pair (name, id). The extra parameter
// specifies additional data to log with the event.
+virtual bool isTraceEventEnabled() const { return true; }
virtual void traceEventBegin(const char* name, void* id, const char* extra) { }
virtual void traceEventEnd(const char* name, void* id, const char* extra) { }
Modified: trunk/Source/WebKit/chromium/src/PlatformSupport.cpp (98281 => 98282)
--- trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2011-10-24 21:01:24 UTC (rev 98281)
+++ trunk/Source/WebKit/chromium/src/PlatformSupport.cpp 2011-10-24 21:19:24 UTC (rev 98282)
@@ -935,6 +935,11 @@
// Trace Event
+bool PlatformSupport::isTraceEventEnabled()
+{
+return webKitPlatformSupport()->isTraceEventEnabled();
+}
+
void PlatformSupport::traceEventBegin(const char* name, void* id, const char* extra)
{
webKitPlatformSupport()->traceEventBegin(name, id, extra);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98280] trunk/Source
Title: [98280] trunk/Source
Revision 98280
Author msab...@apple.com
Date 2011-10-24 13:57:59 -0700 (Mon, 24 Oct 2011)
Log Message
WebKit doesn't build with recent changes to libdispatch
https://bugs.webkit.org/show_bug.cgi?id=70737
Source/WebCore:
Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::install
to use new function.
Reviewed by Geoffrey Garen.
No new tests. Moved functionality to WebKitSystemInterface.
* WebCore.exp.in:
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.
Reviewed by Geoffrey Garen.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Added initialization for new WebKitSystemInterface function
CreateVMPressureDispatchOnMainQueue.
Reviewed by Geoffrey Garen.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h
trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.mm
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (98279 => 98280)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 20:54:14 UTC (rev 98279)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 20:57:59 UTC (rev 98280)
@@ -1,3 +1,22 @@
+2011-10-24 Michael Saboff
+
+WebKit doesn't build with recent changes to libdispatch
+https://bugs.webkit.org/show_bug.cgi?id=70737
+
+Added initialization for new WebKitSystemInterface function
+CreateVMPressureDispatchOnMainQueue. Changed MemoryPressureHandler::install
+to use new function.
+
+Reviewed by Geoffrey Garen.
+
+No new tests. Moved functionality to WebKitSystemInterface.
+
+* WebCore.exp.in:
+* platform/mac/MemoryPressureHandlerMac.mm:
+(WebCore::MemoryPressureHandler::install):
+* platform/mac/WebCoreSystemInterface.h:
+* platform/mac/WebCoreSystemInterface.mm:
+
2011-10-24 Joshua Bell
IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
Modified: trunk/Source/WebCore/WebCore.exp.in (98279 => 98280)
--- trunk/Source/WebCore/WebCore.exp.in 2011-10-24 20:54:14 UTC (rev 98279)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-10-24 20:57:59 UTC (rev 98280)
@@ -1981,3 +1981,7 @@
__ZN7WebCore7IntSizeC1ERK7_NSSize
__ZNK7WebCore7IntSizecv7_NSSizeEv
#endif
+
+#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+_wkCreateVMPressureDispatchOnMainQueue
+#endif
Modified: trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm (98279 => 98280)
--- trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-10-24 20:54:14 UTC (rev 98279)
+++ trunk/Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm 2011-10-24 20:57:59 UTC (rev 98280)
@@ -33,20 +33,10 @@
#import
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
-#import
+#import "WebCoreSystemInterface.h"
#import
-
-#ifndef DISPATCH_SOURCE_TYPE_VM
-#define DISPATCH_SOURCE_TYPE_VM (&_dispatch_source_type_vm)
-DISPATCH_EXPORT const struct dispatch_source_type_s _dispatch_source_type_vm;
-
-enum {
- DISPATCH_VM_PRESSURE = 0x8000,
-};
#endif
-#endif
-
namespace WebCore {
#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
@@ -66,7 +56,7 @@
return;
dispatch_async(dispatch_get_main_queue(), ^{
-_cache_event_source = dispatch_source_create(DISPATCH_SOURCE_TYPE_VM, 0, DISPATCH_VM_PRESSURE, dispatch_get_main_queue());
+_cache_event_source = wkCreateVMPressureDispatchOnMainQueue();
if (_cache_event_source) {
dispatch_set_context(_cache_event_source, this);
dispatch_source_set_event_handler(_cache_event_source, ^{ memoryPressureHandler().respondToMemoryPressure();});
Modified: trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h (98279 => 98280)
--- trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2011-10-24 20:54:14 UTC (rev 98279)
+++ trunk/Source/WebCore/platform/mac/WebCoreSystemInterface.h 2011-10-24 20:57:59 UTC (rev 98280)
@@ -310,6 +310,13 @@
extern void (*wkCFURLRequestSetHTTPRequestBodyParts)(CFMutableURLRequestRef, CFArrayRef bodyParts);
extern void (*wkSetRequestStorageSession)(CFURLStorageSessionRef, CFMutableURLRequestRef);
#endif
+
+#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD)
+#import
+
+ext
[webkit-changes] [98279] trunk/Tools
Title: [98279] trunk/Tools
Revision 98279
Author e...@webkit.org
Date 2011-10-24 13:54:14 -0700 (Mon, 24 Oct 2011)
Log Message
NRWT doesn't support ORWT's --root option, but should
https://bugs.webkit.org/show_bug.cgi?id=70416
Reviewed by Dirk Pranke.
Add support for ORWT's --root option which is used for
running tests with a nightly build of WebKit.
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/base.py:
- webkit_build_path was never called by any code, removed.
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (98278 => 98279)
--- trunk/Tools/ChangeLog 2011-10-24 20:51:02 UTC (rev 98278)
+++ trunk/Tools/ChangeLog 2011-10-24 20:54:14 UTC (rev 98279)
@@ -1,3 +1,19 @@
+2011-10-24 Eric Seidel
+
+NRWT doesn't support ORWT's --root option, but should
+https://bugs.webkit.org/show_bug.cgi?id=70416
+
+Reviewed by Dirk Pranke.
+
+Add support for ORWT's --root option which is used for
+running tests with a nightly build of WebKit.
+
+* Scripts/old-run-webkit-tests:
+* Scripts/webkitpy/layout_tests/port/base.py:
+ - webkit_build_path was never called by any code, removed.
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
2011-10-24 David Levin
check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
Modified: trunk/Tools/Scripts/old-run-webkit-tests (98278 => 98279)
--- trunk/Tools/Scripts/old-run-webkit-tests 2011-10-24 20:51:02 UTC (rev 98278)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2011-10-24 20:54:14 UTC (rev 98279)
@@ -440,7 +440,7 @@
if (!defined($root) && !$noBuildDumpTool) {
# FIXME: We build both DumpRenderTree and WebKitTestRunner for
-# WebKitTestRunner runs becuase DumpRenderTree still includes
+# WebKitTestRunner runs because DumpRenderTree still includes
# the DumpRenderTreeSupport module and the TestNetscapePlugin.
# These two projects should be factored out into their own
# projects.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (98278 => 98279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-10-24 20:51:02 UTC (rev 98278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py 2011-10-24 20:54:14 UTC (rev 98279)
@@ -885,8 +885,6 @@
# The routines below should only be called by routines in this class
# or any of its subclasses.
#
-def _webkit_build_directory(self, args):
-return self._config.build_directory(args[0])
def _uses_apache(self):
return True
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (98278 => 98279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-24 20:51:02 UTC (rev 98278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-10-24 20:54:14 UTC (rev 98279)
@@ -125,7 +125,8 @@
return True
def check_build(self, needs_http):
-if self.get_option('build') and not self._build_driver():
+# If we're using a pre-built copy of WebKit (--root), we assume it also includes a build of DRT.
+if not self.get_option('root') and self.get_option('build') and not self._build_driver():
return False
if not self._check_driver():
return False
@@ -364,8 +365,11 @@
return tests_to_skip
def _build_path(self, *comps):
-return self._filesystem.join(self._config.build_directory(
-self.get_option('configuration')), *comps)
+# --root is used for running with a pre-built root (like from a nightly zip).
+build_directory = self.get_option('root')
+if not build_directory:
+build_directory = self._config.build_directory(self.get_option('configuration'))
+return self._filesystem.join(build_directory, *comps)
def _path_to_driver(self):
return self._build_path(self.driver_name())
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (98278 => 98279)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-10-24 20:51:02 UTC (rev 98278)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-10-24 20:54:14 UTC (rev 98279)
@@ -125,6 +125,11 @@
port._options = MockOptions(webkit_test_runner=True)
self.assertEqual(port._skipped_file_search_paths(), set(['testwebkitport', 'testwebkitport-version', 'testwebkitport-wk2', 'wk2']))
+def test_root_option(self):
+port = TestWebKitPort()
+
[webkit-changes] [98277] trunk/Source/WebCore
Title: [98277] trunk/Source/WebCore
Revision 98277
Author al...@chromium.org
Date 2011-10-24 13:48:33 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656
Reviewed by James Robinson.
Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
(WebCore::FrameBuffer::FrameBuffer::initialize):
(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98276 => 98277)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 20:47:45 UTC (rev 98276)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 20:48:33 UTC (rev 98277)
@@ -1,3 +1,27 @@
+2011-10-24 Alok Priyadarshi
+
+[chromium] Make accelerated drawing work with threaded compositing
+https://bugs.webkit.org/show_bug.cgi?id=70656
+
+Reviewed by James Robinson.
+
+Make sure that the compositor context is not used outside LayerTextureUpdater::updateTextureRect().
+Created a FrameBuffer class that wraps skia gpu canvas and manages GL resources.
+
+* platform/graphics/chromium/ContentLayerChromium.cpp:
+(WebCore::ContentLayerChromium::createTextureUpdater):
+* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
+(WebCore::FrameBuffer::FrameBuffer::FrameBuffer):
+(WebCore::FrameBuffer::FrameBuffer::~FrameBuffer):
+(WebCore::FrameBuffer::FrameBuffer::initialize):
+(WebCore::LayerTextureUpdaterSkPicture::LayerTextureUpdaterSkPicture):
+(WebCore::LayerTextureUpdaterSkPicture::~LayerTextureUpdaterSkPicture):
+(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
+(WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
+* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::initialize):
+
2011-10-24 Adam Klein
Optimize Node::isInShadowTree to execute in constant-time
Modified: trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp (98276 => 98277)
--- trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp 2011-10-24 20:47:45 UTC (rev 98276)
+++ trunk/Source/WebCore/platform/graphics/chromium/ContentLayerChromium.cpp 2011-10-24 20:48:33 UTC (rev 98277)
@@ -120,15 +120,12 @@
void ContentLayerChromium::createTextureUpdater(const CCLayerTreeHost* host)
{
-#if USE(SKIA) && USE(ACCELERATED_DRAWING)
-// Note that host->skiaContext() will crash if called while in threaded
-// mode. This thus depends on CCLayerTreeHost::initialize turning off
-// acceleratePainting to prevent this from crashing.
+#if USE(SKIA)
if (host->settings().acceleratePainting) {
m_textureUpdater = LayerTextureUpdaterSkPicture::create(ContentLayerPainter::create(m_delegate));
return;
}
-#endif // USE(SKIA) && USE(ACCELERATED_DRAWING)
+#endif // USE(SKIA)
m_textureUpdater = LayerTextureUpdaterBitmap::create(ContentLayerPainter::create(m_delegate), host->layerRendererCapabilities().usingMapSub);
}
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp (98276 => 98277)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp 2011-10-24 20:47:45 UTC (rev 98276)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp 2011-10-24 20:48:33 UTC (rev 98277)
@@ -46,6 +46,66 @@
namespace WebCore {
+#if USE(SKIA)
+namespace {
+
+class FrameBuffer {
+public:
+FrameBuffer();
+~FrameBuffer();
+
+SkCanvas* initialize(GraphicsContext3D*, TextureAllocator*, ManagedTexture*);
+
+private:
+GraphicsContext3D* m_context;
+Platform3DObject m_fbo;
+OwnPtr m_canvas;
+};
+
+FrameBuffer::FrameBuffer()
+: m_context(0)
+, m_fbo(0)
+{
+}
+
+FrameBuffer:
[webkit-changes] [98276] trunk/Source/JavaScriptCore
Title: [98276] trunk/Source/_javascript_Core Revision 98276 Author mhahnenb...@apple.com Date 2011-10-24 13:47:45 -0700 (Mon, 24 Oct 2011) Log Message Fixing Windows build Unreviewed build fix * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98275 => 98276) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-24 20:41:33 UTC (rev 98275) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-24 20:47:45 UTC (rev 98276) @@ -1,3 +1,11 @@ +2011-10-24 Mark Hahnenberg + +Fixing Windows build + +Unreviewed build fix + +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: + 2011-10-24 Yuqiang Xian BitVector isInline check could fail Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (98275 => 98276) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-24 20:41:33 UTC (rev 98275) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-24 20:47:45 UTC (rev 98276) @@ -145,6 +145,7 @@ ?deleteOwnedPtr@WTF@@YAXPAUHRGN__@@@Z ?deleteProperty@JSObject@JSC@@SA_NPAVJSCell@2@PAVExecState@2@ABVIdentifier@2@@Z ?deleteProperty@JSVariableObject@JSC@@SA_NPAVJSCell@2@PAVExecState@2@ABVIdentifier@2@@Z +?deletePropertyByIndex@JSObject@JSC@@SA_NPAVJSCell@2@PAVExecState@2@I@Z ?deletePropertyVirtual@JSCell@JSC@@UAE_NPAVExecState@2@ABVIdentifier@2@@Z ?deletePropertyVirtual@JSCell@JSC@@UAE_NPAVExecState@2@I@Z ?deletePropertyVirtual@JSObject@JSC@@UAE_NPAVExecState@2@ABVIdentifier@2@@Z ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98275] trunk/Source/WebCore
Title: [98275] trunk/Source/WebCore
Revision 98275
Author ad...@chromium.org
Date 2011-10-24 13:41:33 -0700 (Mon, 24 Oct 2011)
Log Message
Optimize Node::isInShadowTree to execute in constant-time
https://bugs.webkit.org/show_bug.cgi?id=67686
Reviewed by Dimitri Glazkov.
No expected change in behavior, so no new tests.
* dom/Node.cpp:
(WebCore::Node::isInShadowTree):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98274 => 98275)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 20:40:28 UTC (rev 98274)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 20:41:33 UTC (rev 98275)
@@ -1,3 +1,15 @@
+2011-10-24 Adam Klein
+
+Optimize Node::isInShadowTree to execute in constant-time
+https://bugs.webkit.org/show_bug.cgi?id=67686
+
+Reviewed by Dimitri Glazkov.
+
+No expected change in behavior, so no new tests.
+
+* dom/Node.cpp:
+(WebCore::Node::isInShadowTree):
+
2011-10-24 Nat Duca
[chromium] Expose WebThread::postDelayedTask to CCThread
Modified: trunk/Source/WebCore/dom/Node.cpp (98274 => 98275)
--- trunk/Source/WebCore/dom/Node.cpp 2011-10-24 20:40:28 UTC (rev 98274)
+++ trunk/Source/WebCore/dom/Node.cpp 2011-10-24 20:41:33 UTC (rev 98275)
@@ -1592,10 +1592,7 @@
bool Node::isInShadowTree()
{
-for (Node* n = this; n; n = n->parentNode())
-if (n->isShadowRoot())
-return true;
-return false;
+return treeScope() != document();
}
Element* Node::parentOrHostElement() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98274] trunk/LayoutTests
Title: [98274] trunk/LayoutTests
Revision 98274
Author o...@chromium.org
Date 2011-10-24 13:40:28 -0700 (Mon, 24 Oct 2011)
Log Message
Some more fixups from http://trac.webkit.org/changeset/98265.
The leopard bot results are incorrect, but that's because the
chromium leopard bots have not compiled in a few days. Once
the bots are fixed, we'll need to rebaseline this test again for
leopard.
* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98273 => 98274)
--- trunk/LayoutTests/ChangeLog 2011-10-24 20:35:54 UTC (rev 98273)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 20:40:28 UTC (rev 98274)
@@ -1,3 +1,17 @@
+2011-10-24 Ojan Vafai
+
+Some more fixups from http://trac.webkit.org/changeset/98265.
+
+The leopard bot results are incorrect, but that's because the
+chromium leopard bots have not compiled in a few days. Once
+the bots are fixed, we'll need to rebaseline this test again for
+leopard.
+
+* platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
+* platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
+* platform/chromium-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
+* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
+
2011-10-24 Julien Chaffraix
Unreviewed rebaseline of svg/W3C-SVG-1.1-SE/coords-units-03-b.html
Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (0 => 98274)
--- trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt 2011-10-24 20:40:28 UTC (rev 98274)
@@ -0,0 +1,18 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x0
+ RenderBlock {DIV} at (0,0) size 160x160
+RenderText {#text} at (0,0) size 108x160
+ text run at (0,0) width 121: "Assuming the port-"
+ text run at (18,0) width 132: "specific theme draws"
+ text run at (18,132) width 4: " "
+ text run at (36,0) width 124: "focus rings, this test"
+ text run at (36,124) width 4: " "
+ text run at (54,0) width 159: "draws focus rings around"
+ text run at (54,159) width 1: " "
+ text run at (72,0) width 151: "editable multiline text in"
+ text run at (72,151) width 4: " "
+ text run at (90,0) width 138: "vertical writing mode."
+caret: position 1 of child 0 {#text} of child 1 {DIV} of body
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (0 => 98274)
--- trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt 2011-10-24 20:40:28 UTC (rev 98274)
@@ -0,0 +1,18 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock {DIV} at (0,0) size 160x160
+RenderText {#text} at (0,0) size 108x160
+ text run at (0,0) width 121: "Assuming the port-"
+ text run at (18,0) width 132: "specific theme draws"
+ text run at (18,13
[webkit-changes] [98273] tags/Safari-534.52.3/
Title: [98273] tags/Safari-534.52.3/ Revision 98273 Author lforsch...@apple.com Date 2011-10-24 13:35:54 -0700 (Mon, 24 Oct 2011) Log Message New tag. Added Paths tags/Safari-534.52.3/ Diff Property changes: tags/Safari-534.52.3 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98272] branches/safari-534.52-branch/Source/WebCore
Title: [98272] branches/safari-534.52-branch/Source/WebCore Revision 98272 Author lforsch...@apple.com Date 2011-10-24 13:32:51 -0700 (Mon, 24 Oct 2011) Log Message Fix Localization. Modified Paths branches/safari-534.52-branch/Source/WebCore/ChangeLog branches/safari-534.52-branch/Source/WebCore/English.lproj/Localizable.strings Diff Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98271 => 98272) --- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-24 20:11:56 UTC (rev 98271) +++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-24 20:32:51 UTC (rev 98272) @@ -1,3 +1,9 @@ +2011-10-24 Lucas Forschler + +Update Localizable strings. + +* English.lproj/Localizable.strings: + 2011-10-21 Lucas Forschler Merge 98112 Modified: branches/safari-534.52-branch/Source/WebCore/English.lproj/Localizable.strings (98271 => 98272) --- branches/safari-534.52-branch/Source/WebCore/English.lproj/Localizable.strings 2011-10-24 20:11:56 UTC (rev 98271) +++ branches/safari-534.52-branch/Source/WebCore/English.lproj/Localizable.strings 2011-10-24 20:32:51 UTC (rev 98272) @@ -25,12 +25,6 @@ / * L a b e l t o d e s c r i b e t h e n u m b e r o f f i l e s s e l e c t e d i n a f i l e u p l o a d c o n t r o l t h a t a l l o w s m u l t i p l e f i l e s * / " % d f i l e s " = " % d f i l e s " ; - / * P s e u d o p l u g - i n n a m e , v i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / - " W e b K i t b u i l t - i n P D F " = " W e b K i t b u i l t - i n P D F " ; - - / * D e s c r i p t i o n o f t h e ( o n l y ) t y p e s u p p o r t e d b y P D F p s e u d o p l u g - i n . V i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / - " P o r t a b l e D o c u m e n t F o r m a t " = " P o r t a b l e D o c u m e n t F o r m a t " ; - / * M e n u i t e m t i t l e f o r K E Y G E N p o p - u p m e n u * / " 1 0 2 4 ( M e d i u m G r a d e ) " = " 1 0 2 4 ( M e d i u m G r a d e ) " ; @@ -301,6 +295,9 @@ / * W e b K i t E r r o r P l u g I n W i l l H a n d l e L o a d d e s c r i p t i o n * / " P l u g - i n h a n d l e d l o a d " = " P l u g - i n h a n d l e d l o a d " ; + / * D e s c r i p t i o n o f t h e ( o n l y ) t y p e s u p p o r t e d b y P D F p s e u d o p l u g - i n . V i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / + " P o r t a b l e D o c u m e n t F o r m a t " = " P o r t a b l e D o c u m e n t F o r m a t " ; + / * U n d o a c t i o n n a m e * / " R a i s e B a s e l i n e ( U n d o a c t i o n n a m e ) " = " R a i s e B a s e l i n e " ; @@ -490,6 +487,9 @@ / * W e b I n s p e c t o r w i n d o w t i t l e * / " W e b I n s p e c t o r % @ " = " W e b I n s p e c t o r % @ " ; + / * P s e u d o p l u g - i n n a m e , v i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * / + " W e b K i t b u i l t - i n P D F " = " W e b K i t b u i l t - i n P D F " ; + / * m e s s a g e i n a u t h e n t i c a t i o n p a n e l * / " Y o u r l o g i n i n f o r m a t i o n w i l l b e s e n t s e c u r e l y . " = " Y o u r l o g i n i n f o r m a t i o n w i l l b e s e n t s e c u r e l y . " ; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98271] trunk/Source
Title: [98271] trunk/Source
Revision 98271
Author nd...@chromium.org
Date 2011-10-24 13:11:56 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Expose WebThread::postDelayedTask to CCThread
https://bugs.webkit.org/show_bug.cgi?id=70712
Reviewed by James Robinson.
Source/WebCore:
* platform/graphics/chromium/cc/CCThread.h:
Source/WebKit/chromium:
* src/CCThreadImpl.cpp:
(WebKit::CCThreadImpl::postDelayedTask):
* src/CCThreadImpl.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThread.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/CCThreadImpl.cpp
trunk/Source/WebKit/chromium/src/CCThreadImpl.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98270 => 98271)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 19:55:26 UTC (rev 98270)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 20:11:56 UTC (rev 98271)
@@ -1,3 +1,12 @@
+2011-10-24 Nat Duca
+
+[chromium] Expose WebThread::postDelayedTask to CCThread
+https://bugs.webkit.org/show_bug.cgi?id=70712
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCThread.h:
+
2011-10-24 Levi Weintraub
fails to use explicit width and height inside inside IFRAME
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThread.h (98270 => 98271)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThread.h 2011-10-24 19:55:26 UTC (rev 98270)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThread.h 2011-10-24 20:11:56 UTC (rev 98271)
@@ -47,8 +47,12 @@
void* m_instance;
};
-virtual void postTask(PassOwnPtr) = 0; // Executes the task on context's thread asynchronously.
+// Executes the task on context's thread asynchronously.
+virtual void postTask(PassOwnPtr) = 0;
+// Executes the task after the specified delay.
+virtual void postDelayedTask(PassOwnPtr, long long delayMs) = 0;
+
virtual WTF::ThreadIdentifier threadID() const = 0;
};
Modified: trunk/Source/WebKit/chromium/ChangeLog (98270 => 98271)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 19:55:26 UTC (rev 98270)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 20:11:56 UTC (rev 98271)
@@ -1,5 +1,16 @@
2011-10-24 Nat Duca
+[chromium] Expose WebThread::postDelayedTask to CCThread
+https://bugs.webkit.org/show_bug.cgi?id=70712
+
+Reviewed by James Robinson.
+
+* src/CCThreadImpl.cpp:
+(WebKit::CCThreadImpl::postDelayedTask):
+* src/CCThreadImpl.h:
+
+2011-10-24 Nat Duca
+
[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688
Modified: trunk/Source/WebKit/chromium/src/CCThreadImpl.cpp (98270 => 98271)
--- trunk/Source/WebKit/chromium/src/CCThreadImpl.cpp 2011-10-24 19:55:26 UTC (rev 98270)
+++ trunk/Source/WebKit/chromium/src/CCThreadImpl.cpp 2011-10-24 20:11:56 UTC (rev 98271)
@@ -90,6 +90,11 @@
m_thread->postTask(new CCThreadTaskAdapter(task));
}
+void CCThreadImpl::postDelayedTask(PassOwnPtr task, long long delayMs)
+{
+m_thread->postDelayedTask(new CCThreadTaskAdapter(task), delayMs);
+}
+
ThreadIdentifier CCThreadImpl::threadID() const
{
return m_threadID;
Modified: trunk/Source/WebKit/chromium/src/CCThreadImpl.h (98270 => 98271)
--- trunk/Source/WebKit/chromium/src/CCThreadImpl.h 2011-10-24 19:55:26 UTC (rev 98270)
+++ trunk/Source/WebKit/chromium/src/CCThreadImpl.h 2011-10-24 20:11:56 UTC (rev 98271)
@@ -39,7 +39,8 @@
public:
static PassOwnPtr create(WebThread*);
virtual ~CCThreadImpl();
-void postTask(PassOwnPtr);
+virtual void postTask(PassOwnPtr);
+virtual void postDelayedTask(PassOwnPtr, long long delayMs);
WTF::ThreadIdentifier threadID() const;
private:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98270] trunk/Source/WebKit2
Title: [98270] trunk/Source/WebKit2
Revision 98270
Author wei...@apple.com
Date 2011-10-24 12:55:26 -0700 (Mon, 24 Oct 2011)
Log Message
Add URL getters for the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=70752
Reviewed by Anders Carlsson.
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(autoreleased):
Added helpers for autoreleasing.
(-[WKBrowsingContextController activeURL]):
Added buy not implemented yet.
(-[WKBrowsingContextController pendingURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController commitedURL]):
(-[WKBrowsingContextController unreachableURL]):
Added getters.
(-[WKBrowsingContextController title]):
Convert to new autoreleased helper.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98269 => 98270)
--- trunk/Source/WebKit2/ChangeLog 2011-10-24 19:53:07 UTC (rev 98269)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-24 19:55:26 UTC (rev 98270)
@@ -1,5 +1,29 @@
2011-10-24 Sam Weinig
+Add URL getters for the WKBrowsingContextController
+https://bugs.webkit.org/show_bug.cgi?id=70752
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/mac/WKBrowsingContextController.h:
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(autoreleased):
+Added helpers for autoreleasing.
+
+(-[WKBrowsingContextController activeURL]):
+Added buy not implemented yet.
+
+(-[WKBrowsingContextController pendingURL]):
+(-[WKBrowsingContextController provisionalURL]):
+(-[WKBrowsingContextController commitedURL]):
+(-[WKBrowsingContextController unreachableURL]):
+Added getters.
+
+(-[WKBrowsingContextController title]):
+Convert to new autoreleased helper.
+
+2011-10-24 Sam Weinig
+
Add zoom and title support to Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70744
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h (98269 => 98270)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 19:53:07 UTC (rev 98269)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 19:55:26 UTC (rev 98270)
@@ -72,6 +72,24 @@
@property(readonly) BOOL canGoBack;
+#pragma mark Active Load Introspection
+
+/* URL for the active load. This is the URL that should be shown in user interface. */
+@property(readonly) NSURL *activeURL;
+
+/* URL that has been requested to load by the user, but not yet sent. */
+@property(readonly) NSURL *pendingURL;
+
+/* URL for a request that has been sent, but no response has been recieved yet. */
+@property(readonly) NSURL *provisionalURL;
+
+/* URL for a request that has been recieved, and is now being used. */
+@property(readonly) NSURL *commitedURL;
+
+/* URL for a request that had an error, whose error page is now showing. */
+@property(readonly) NSURL *unreachableURL;
+
+
#pragma mark Active Document Introspection
/* Title of the document associated with the active load. */
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (98269 => 98270)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 19:53:07 UTC (rev 98269)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 19:55:26 UTC (rev 98270)
@@ -27,12 +27,28 @@
#import "WKBrowsingContextController.h"
#import "WKBrowsingContextControllerInternal.h"
+#import "WKFrame.h"
#import "WKPage.h"
#import "WKRetainPtr.h"
+#import "WKStringCF.h"
+#import "WKURLCF.h"
#import "WKURLRequest.h"
#import "WKURLRequestNS.h"
-#import "WKStringCF.h"
+
+static inline NSString *autoreleased(WKStringRef string)
+{
+WKRetainPtr wkString = adoptWK(string);
+return [(NSString *)WKStringCopyCFString(kCFAllocatorDefault, wkString.get()) autorelease];
+}
+
+static inline NSURL *autoreleased(WKURLRef url)
+{
+WKRetainPtr wkURL = adoptWK(url);
+return [(NSURL *)WKURLCopyCFURL(kCFAllocatorDefault, wkURL.get()) autorelease];
+}
+
+
@interface WKBrowsingContextControllerData : NSObject {
@public
WKRetainPtr _pageRef;
@@ -105,12 +121,41 @@
return WKPageCanGoBack(self.pageRef);
}
+
+#pragma mark Active Load Introspection
+
+- (NSURL *)activeURL
+{
+/* FIXME: Implement. */
+return nil;
+}
+
+- (NSURL *)pendingURL
+{
+return autoreleased(WKPageCopyPendingAPIRequestURL(self.pageRef));
+}
+
+- (NSURL *)provisionalURL
+{
+return autoreleased(WKFrameCopyProvisionalURL(WKPageGetMainFrame(self.pageRef)));
+}
+
+- (NSURL *)commitedURL
+{
+return autoreleased(WKFrameCopyURL(WKPageGetMainFrame(self.pageRef)));
+}
+
+- (NSURL *)unreachableURL
+{
+return autoreleased(WKF
[webkit-changes] [98269] trunk/Source/WebKit/chromium
Title: [98269] trunk/Source/WebKit/chromium
Revision 98269
Author nd...@chromium.org
Date 2011-10-24 12:53:07 -0700 (Mon, 24 Oct 2011)
Log Message
[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
https://bugs.webkit.org/show_bug.cgi?id=70688
Reviewed by Tony Chang.
* tests/RunAllTests.cpp:
(main):
* tests/WebUnitTests.cpp:
(WebKit::InitTestSuite):
(WebKit::RunAllUnitTests):
(WebKit::DeleteTestSuite):
* tests/WebUnitTests.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/RunAllTests.cpp
trunk/Source/WebKit/chromium/tests/WebUnitTests.cpp
trunk/Source/WebKit/chromium/tests/WebUnitTests.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98268 => 98269)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 19:41:29 UTC (rev 98268)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 19:53:07 UTC (rev 98269)
@@ -1,3 +1,18 @@
+2011-10-24 Nat Duca
+
+[chromium] Manage webkit_unit_tests TestSuite lifetime explicitly in DLL build
+https://bugs.webkit.org/show_bug.cgi?id=70688
+
+Reviewed by Tony Chang.
+
+* tests/RunAllTests.cpp:
+(main):
+* tests/WebUnitTests.cpp:
+(WebKit::InitTestSuite):
+(WebKit::RunAllUnitTests):
+(WebKit::DeleteTestSuite):
+* tests/WebUnitTests.h:
+
2011-10-24 Aaron Colwell
Enable MEDIA_SOURCE feature for Chromium
Modified: trunk/Source/WebKit/chromium/tests/RunAllTests.cpp (98268 => 98269)
--- trunk/Source/WebKit/chromium/tests/RunAllTests.cpp 2011-10-24 19:41:29 UTC (rev 98268)
+++ trunk/Source/WebKit/chromium/tests/RunAllTests.cpp 2011-10-24 19:53:07 UTC (rev 98269)
@@ -41,22 +41,25 @@
#include
+// TestSuite must be created before SetUpTestEnvironment so it performs
+// initializations needed by WebKit support. This is slightly complicated by the
+// fact that chromium multi-dll build requires that the TestSuite object be created
+// and run inside webkit.dll.
int main(int argc, char** argv)
{
+#if defined(WEBKIT_DLL_UNITTEST)
+WebKit::InitTestSuite(argc, argv);
+webkit_support::SetUpTestEnvironmentForUnitTests();
+int result = WebKit::RunAllUnitTests();
+webkit_support::TearDownTestEnvironment();
+WebKit::DeleteTestSuite();
+#else
::testing::InitGoogleMock(&argc, argv);
TestSuite testSuite(argc, argv);
-// TestSuite must be created before SetUpTestEnvironment so it performs
-// initializations needed by WebKit support.
webkit_support::SetUpTestEnvironmentForUnitTests();
-
-#if defined(WEBKIT_DLL_UNITTEST)
-// For chromium multi-dll build, need to call webkit api to create a
-// TestSuite instance in webkit.dll and run all tests from there.
-int result = WebKit::RunAllUnitTests(argc, argv);
-#else
int result = testSuite.Run();
+webkit_support::TearDownTestEnvironment();
#endif
-webkit_support::TearDownTestEnvironment();
return result;
}
Modified: trunk/Source/WebKit/chromium/tests/WebUnitTests.cpp (98268 => 98269)
--- trunk/Source/WebKit/chromium/tests/WebUnitTests.cpp 2011-10-24 19:41:29 UTC (rev 98268)
+++ trunk/Source/WebKit/chromium/tests/WebUnitTests.cpp 2011-10-24 19:53:07 UTC (rev 98269)
@@ -32,13 +32,31 @@
#include "WebUnitTests.h"
#include
+#include
+static TestSuite* testSuite = 0;
+
namespace WebKit {
-int RunAllUnitTests(int argc, char** argv)
+void InitTestSuite(int argc, char** argv)
{
-TestSuite testSuite(argc, argv);
-return testSuite.Run();
+::testing::InitGoogleMock(&argc, argv);
+testSuite = new TestSuite(argc, argv);
}
+int RunAllUnitTests()
+{
+ASSERT(testSuite);
+
+int result = testSuite->Run();
+
+return result;
+}
+
+void DeleteTestSuite()
+{
+delete testSuite;
+testSuite = 0;
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/tests/WebUnitTests.h (98268 => 98269)
--- trunk/Source/WebKit/chromium/tests/WebUnitTests.h 2011-10-24 19:41:29 UTC (rev 98268)
+++ trunk/Source/WebKit/chromium/tests/WebUnitTests.h 2011-10-24 19:53:07 UTC (rev 98269)
@@ -36,9 +36,21 @@
namespace WebKit {
// In chromium multi-dll build, webkit unittest code are compiled in webkit.dll.
-// This is the API to run all unittests inside webkit.dll.
-WEBKIT_EXPORT int RunAllUnitTests(int argc, char** argv);
+// This means the test suite object needs to be initialized inside WebKit.
+//
+// However, the webkit unittest code needs to also initialize/teardown.
+// This leads to the API here, which has explicit managment of the TestSuite
+// lifetime.
+// Initialize the global testSuite object inside webkit.dll
+WEBKIT_EXPORT void InitTestSuite(int argc, char** argv);
+
+// Runs all tests found inside webkit.dll
+WEBKIT_EXPORT int RunAllUnitTests();
+
+// Deletes the global testSuite object inside webkit.dll
+WEBKIT_EXPORT void DeleteTestSuite();
+
} // namespace WebKit
#endif
___
webkit-chang
[webkit-changes] [98268] trunk/Source/JavaScriptCore
Title: [98268] trunk/Source/_javascript_Core
Revision 98268
Author commit-qu...@webkit.org
Date 2011-10-24 12:41:29 -0700 (Mon, 24 Oct 2011)
Log Message
BitVector isInline check could fail
https://bugs.webkit.org/show_bug.cgi?id=70691
Patch by Yuqiang Xian on 2011-10-24
Reviewed by Geoffrey Garen.
Current BitVector uses the highest bit of m_bitsOrPointer to indicate
whether it's an inlined bit set or a pointer to an outOfLine bit set.
This check may fail in case the pointer also has the highest bit set,
which is surely possible on IA32 (Linux).
In this case the check failure can result in unexpected behaviors,
for example if the BitVector is incorrectly determined as having an
inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
modify the memory adjacent to the BitVector object.
This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
or outofline, based on the assumption that the pointer to OutOfLineBits
should be 4 or 8 byte aligned.
We could mark the lowest bit (bit 0) with 1 for inlined bit set,
and bits 1~bitsInPointer are used for bit set/test.
In this case we need do one bit more shift for bit set/test.
* wtf/BitVector.cpp:
(WTF::BitVector::resizeOutOfLine):
* wtf/BitVector.h:
(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):
(WTF::BitVector::makeInlineBits):
(WTF::BitVector::isInline):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/BitVector.cpp
trunk/Source/_javascript_Core/wtf/BitVector.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98267 => 98268)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-24 19:40:54 UTC (rev 98267)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-24 19:41:29 UTC (rev 98268)
@@ -1,3 +1,34 @@
+2011-10-24 Yuqiang Xian
+
+BitVector isInline check could fail
+https://bugs.webkit.org/show_bug.cgi?id=70691
+
+Reviewed by Geoffrey Garen.
+
+Current BitVector uses the highest bit of m_bitsOrPointer to indicate
+whether it's an inlined bit set or a pointer to an outOfLine bit set.
+This check may fail in case the pointer also has the highest bit set,
+which is surely possible on IA32 (Linux).
+In this case the check failure can result in unexpected behaviors,
+for example if the BitVector is incorrectly determined as having an
+inlined bit set, then setting a bit exceeding maxInlineBits will wrongly
+modify the memory adjacent to the BitVector object.
+This fix is to use the lowest bit of m_bitsOrPointer to indicate inline
+or outofline, based on the assumption that the pointer to OutOfLineBits
+should be 4 or 8 byte aligned.
+We could mark the lowest bit (bit 0) with 1 for inlined bit set,
+and bits 1~bitsInPointer are used for bit set/test.
+In this case we need do one bit more shift for bit set/test.
+
+* wtf/BitVector.cpp:
+(WTF::BitVector::resizeOutOfLine):
+* wtf/BitVector.h:
+(WTF::BitVector::quickGet):
+(WTF::BitVector::quickSet):
+(WTF::BitVector::quickClear):
+(WTF::BitVector::makeInlineBits):
+(WTF::BitVector::isInline):
+
2011-10-24 Mark Hahnenberg
Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
Modified: trunk/Source/_javascript_Core/wtf/BitVector.cpp (98267 => 98268)
--- trunk/Source/_javascript_Core/wtf/BitVector.cpp 2011-10-24 19:40:54 UTC (rev 98267)
+++ trunk/Source/_javascript_Core/wtf/BitVector.cpp 2011-10-24 19:41:29 UTC (rev 98268)
@@ -91,7 +91,7 @@
OutOfLineBits* newOutOfLineBits = OutOfLineBits::create(numBits);
if (isInline()) {
// Make sure that all of the bits are zero in case we do a no-op resize.
-*newOutOfLineBits->bits() = m_bitsOrPointer & ~(static_cast(1) << maxInlineBits());
+*newOutOfLineBits->bits() = m_bitsOrPointer & ~(static_cast(1));
} else {
if (numBits > size()) {
size_t oldNumWords = outOfLineBits()->numWords();
@@ -103,6 +103,7 @@
OutOfLineBits::destroy(outOfLineBits());
}
m_bitsOrPointer = bitwise_cast(newOutOfLineBits);
+ASSERT(!isInline());
}
#ifndef NDEBUG
Modified: trunk/Source/_javascript_Core/wtf/BitVector.h (98267 => 98268)
--- trunk/Source/_javascript_Core/wtf/BitVector.h 2011-10-24 19:40:54 UTC (rev 98267)
+++ trunk/Source/_javascript_Core/wtf/BitVector.h 2011-10-24 19:41:29 UTC (rev 98268)
@@ -114,19 +114,19 @@
bool quickGet(size_t bit) const
{
ASSERT(bit < size());
-return !!(bits()[bit / bitsInPointer()] & (static_cast(1) << (bit & (bitsInPointer() - 1;
+return !!(bits()[bit / bitsInPointer()] & (static_cast(1) << ((bit & (bitsInPointer() - 1)) + 1)));
}
void quickSet(size_t bit)
{
ASSERT(bit < size());
-bits()[bit / bitsInPointer()] |= (static_cast(1) << (bit & (bitsInPointer()
[webkit-changes] [98266] trunk/Source/WebKit/chromium
Title: [98266] trunk/Source/WebKit/chromium Revision 98266 Author commit-qu...@webkit.org Date 2011-10-24 12:29:05 -0700 (Mon, 24 Oct 2011) Log Message Enable MEDIA_SOURCE feature for Chromium https://bugs.webkit.org/show_bug.cgi?id=70745 Patch by Aaron Colwell on 2011-10-24 Reviewed by David Levin. * features.gypi: Modified Paths trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/features.gypi Diff Modified: trunk/Source/WebKit/chromium/ChangeLog (98265 => 98266) --- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 19:22:56 UTC (rev 98265) +++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 19:29:05 UTC (rev 98266) @@ -1,3 +1,12 @@ +2011-10-24 Aaron Colwell + +Enable MEDIA_SOURCE feature for Chromium +https://bugs.webkit.org/show_bug.cgi?id=70745 + +Reviewed by David Levin. + +* features.gypi: + 2011-10-24 Yury Semikhatsky Web Inspector: allow debugging dedicated worker initialization Modified: trunk/Source/WebKit/chromium/features.gypi (98265 => 98266) --- trunk/Source/WebKit/chromium/features.gypi 2011-10-24 19:22:56 UTC (rev 98265) +++ trunk/Source/WebKit/chromium/features.gypi 2011-10-24 19:29:05 UTC (rev 98266) @@ -63,6 +63,7 @@ 'ENABLE_JAVASCRIPT_DEBUGGER=1', 'ENABLE_JAVASCRIPT_I18N_API=1', 'ENABLE_LINK_PREFETCH=1', + 'ENABLE_MEDIA_SOURCE=1', 'ENABLE_MEDIA_STATISTICS=1', 'ENABLE_MEDIA_STREAM=1', 'ENABLE_METER_TAG=1', ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98265] trunk/LayoutTests
Title: [98265] trunk/LayoutTests
Revision 98265
Author o...@chromium.org
Date 2011-10-24 12:22:56 -0700 (Mon, 24 Oct 2011)
Log Message
Cleanup some test expectations missed in r98183.
* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
* platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
* platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png
Removed Paths
trunk/LayoutTests/platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt
trunk/LayoutTests/platform/chromium/fast/writing-mode/fallback-orientation-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98264 => 98265)
--- trunk/LayoutTests/ChangeLog 2011-10-24 19:02:21 UTC (rev 98264)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 19:22:56 UTC (rev 98265)
@@ -1,3 +1,15 @@
+2011-10-24 Ojan Vafai
+
+Cleanup some test expectations missed in r98183.
+
+* platform/chromium-mac-snowleopard/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
+* platform/chromium-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Removed.
+* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
+* platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Removed.
+* platform/chromium/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.
+* platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Removed.
+* platform/chromium/test_expectations.txt:
+
2011-10-24 Levi Weintraub
fails to use explicit width and height inside inside IFRAME
Deleted: trunk/LayoutTests/platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt (98264 => 98265)
--- trunk/LayoutTests/platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt 2011-10-24 19:02:21 UTC (rev 98264)
+++ trunk/LayoutTests/platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt 2011-10-24 19:22:56 UTC (rev 98265)
@@ -1,55 +0,0 @@
-layer at (0,0) size 785x852
- RenderView at (0,0) size 785x600
-layer at (0,0) size 785x852
- RenderBlock {HTML} at (0,0) size 785x852
-RenderBody {BODY} at (8,8) size 769x0
- RenderBlock {DIV} at (0,0) size 769x148
-RenderBlock {DIV} at (10,10) size 268x128
- RenderBlock {DIV} at (12,12) size 110x100 [bgcolor=#00] [border: (20px solid #FF)]
- RenderText {#text} at (132,108) size 4x18
-text run at (132,108) width 4: " "
- RenderBlock {DIV} at (146,12) size 110x100 [bgcolor=#00] [border: (20px double #FF)]
- RenderText {#text} at (0,0) size 0x0
-RenderText {#text} at (288,118) size 4x18
- text run at (288,118) width 4: " "
-RenderBlock {DIV} at (302,10) size 268x128 [bgcolor=#808080]
- RenderBlock {DIV} at (12,12) size 110x100 [bgcolor=#FF] [border: (20px solid #FF7F)]
- RenderText {#text} at (132,108) size 4x18
-text run at (132,108) width 4: " "
- RenderBlock {DIV} at (146,12) size 110x100 [bgcolor=#FF] [border: (20px double #FF7F)]
- RenderText {#text} at (0,0) size 0x0
-RenderText {#text} at (0,0) size 0x0
-layer at (8,156) size 769x148
- RenderBlock {DIV} at (0,148) size 769x148
-RenderBlock {DIV} at (10,10) size 268x128
- RenderBlock {DIV} at (12,12) size 110x100 [bgcolor=#00] [border: (20px solid #FF)]
- RenderText {#text} at (132,108) size 4x18
-text run at (132,108) width 4: " "
- RenderBlock {DIV} at (146,12) size 110x100 [bgcolor=#00] [border: (20px double #FF)]
- RenderText {
[webkit-changes] [98264] trunk/Tools
Title: [98264] trunk/Tools
Revision 98264
Author le...@chromium.org
Date 2011-10-24 12:02:21 -0700 (Mon, 24 Oct 2011)
Log Message
check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747
Reviewed by Tony Chang.
* Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98263 => 98264)
--- trunk/Tools/ChangeLog 2011-10-24 18:56:16 UTC (rev 98263)
+++ trunk/Tools/ChangeLog 2011-10-24 19:02:21 UTC (rev 98264)
@@ -1,3 +1,13 @@
+2011-10-24 David Levin
+
+check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
+https://bugs.webkit.org/show_bug.cgi?id=70747
+
+Reviewed by Tony Chang.
+
+* Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
+* Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
+
2011-10-24 Balazs Kelemen
[Qt][WK2] Crash when running pixel tests
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (98263 => 98264)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-24 18:56:16 UTC (rev 98263)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-24 19:02:21 UTC (rev 98264)
@@ -1602,9 +1602,9 @@
modifiers_and_return_type = function_state.modifiers_and_return_type()
if filename.find('/chromium/') != -1 and search(r'\bWEBKIT_EXPORT\b', modifiers_and_return_type):
-if filename.find('/chromium/public/') == -1:
+if filename.find('/chromium/public/') == -1 and filename.find('/chromium/tests/') == -1:
error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
- 'WEBKIT_EXPORT should only appear in the chromium public directory.')
+ 'WEBKIT_EXPORT should only appear in the chromium public (or tests) directory.')
elif not file_extension == "h":
error(function_state.function_name_start_position.row, 'readability/webkit_export', 5,
'WEBKIT_EXPORT should only be used in header files.')
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (98263 => 98264)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-24 18:56:16 UTC (rev 98263)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-24 19:02:21 UTC (rev 98264)
@@ -4524,11 +4524,15 @@
self.perform_lint('WEBKIT_EXPORT int foo();\n',
'WebKit/chromium/public/test.h',
webkit_export_error_rules))
+self.assertEquals('',
+ self.perform_lint('WEBKIT_EXPORT int foo();\n',
+'WebKit/chromium/tests/test.h',
+webkit_export_error_rules))
self.assertEquals('WEBKIT_EXPORT should only be used in header files. [readability/webkit_export] [5]',
self.perform_lint('WEBKIT_EXPORT int foo();\n',
'WebKit/chromium/public/test.cpp',
webkit_export_error_rules))
-self.assertEquals('WEBKIT_EXPORT should only appear in the chromium public directory. [readability/webkit_export] [5]',
+self.assertEquals('WEBKIT_EXPORT should only appear in the chromium public (or tests) directory. [readability/webkit_export] [5]',
self.perform_lint('WEBKIT_EXPORT int foo();\n',
'WebKit/chromium/src/test.h',
webkit_export_error_rules))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98263] trunk
Title: [98263] trunk
Revision 98263
Author le...@chromium.org
Date 2011-10-24 11:56:16 -0700 (Mon, 24 Oct 2011)
Log Message
fails to use explicit width and height inside inside IFRAME
https://bugs.webkit.org/show_bug.cgi?id=64823
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Checking that embedded SVG is in an SVG document before negotiating size
with the host document.
Test: svg/as-object/svg-embedded-in-html-in-iframe.html
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::isEmbeddedThroughFrameContainingSVGDocument):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
LayoutTests:
Fixing a bug where SVG negotiated size when embedded in html inside an iframe.
* platform/chromium/test_expectations.txt: Will update with results on other platforms.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
* svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Added Paths
trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt
trunk/LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98262 => 98263)
--- trunk/LayoutTests/ChangeLog 2011-10-24 18:41:35 UTC (rev 98262)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 18:56:16 UTC (rev 98263)
@@ -1,3 +1,17 @@
+2011-10-24 Levi Weintraub
+
+ fails to use explicit width and height inside inside IFRAME
+https://bugs.webkit.org/show_bug.cgi?id=64823
+
+Reviewed by Nikolas Zimmermann.
+
+Fixing a bug where SVG negotiated size when embedded in html inside an iframe.
+
+* platform/chromium/test_expectations.txt: Will update with results on other platforms.
+* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png: Added.
+* platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Added.
+* svg/as-object/svg-embedded-in-html-in-iframe.html: Added.
+
2011-10-24 Julien Chaffraix
Unreviewed gardening rebaselining.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98262 => 98263)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 18:41:35 UTC (rev 98262)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 18:56:16 UTC (rev 98263)
@@ -3819,3 +3819,7 @@
BUGWK70704 SNOWLEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE+TEXT PASS
BUGWK70704 SNOWLEOPARD : fast/writing-mode/fallback-orientation.html = TEXT
BUGWK70704 SNOWLEOPARD : fast/backgrounds/background-leakage-transforms.html = TEXT
+
+// Will rebaseline
+BUGLEVIW : svg/as-object/svg-embedded-in-html-in-iframe.html = FAIL
+
Added: trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (0 => 98263)
--- trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt 2011-10-24 18:56:16 UTC (rev 98263)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x170
+ RenderBlock {HTML} at (0,0) size 800x170
+RenderBody {BODY} at (8,8) size 784x154
+ RenderPartObject {IFRAME} at (0,0) size 784x150
+layer at (0,0) size 784x150
+ RenderView at (0,0) size 784x150
+layer at (0,0) size 784x120
+ RenderBlock {HTML} at (0,0) size 784x120
+RenderBody {BODY} at (8,8) size 768x104
+ RenderSVGRoot {svg} at (8,8) size 100x100
+RenderSVGPath {circle} at (8,8) size 100x100 [fill={[type=SOLID] [color=#FF]}] [cx=50.00] [cy=50.00] [r=50.00]
+ RenderText {#text} at (0,0) size 0x0
+ RenderText {#text} at (0,0) size 0x0
Added: trunk/LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html (0 => 98263)
--- trunk/LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html (rev 0)
+++ trunk/LayoutTests/svg/as-object/svg-embedded-in-html-in-iframe.html 2011-10-24 18:56:16 UTC (rev 98263)
@@ -0,0 +1,22 @@
+
+
+
+
+function CreateCircle(){
+var B="";
+B+="";
+B+="";
+B+="";
+B+="
[webkit-changes] [98262] trunk/Source/WebCore
Title: [98262] trunk/Source/WebCore
Revision 98262
Author commit-qu...@webkit.org
Date 2011-10-24 11:41:35 -0700 (Mon, 24 Oct 2011)
Log Message
Node::registeredMutationObserversOfType should be prefixed by "get"
https://bugs.webkit.org/show_bug.cgi?id=70359
Patch by Rafael Weinstein on 2011-10-24
Reviewed by Ojan Vafai.
This change renames Node::registeredMutationObserversOfType to
Node::getRegisteredMutationObserversOfType per the WebKit style guide.
No tests needed as the change is only method renaming.
* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/ChildListMutationScope.cpp:
(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/Node.cpp:
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.cpp
trunk/Source/WebCore/dom/ChildListMutationScope.cpp
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98261 => 98262)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 18:41:35 UTC (rev 98262)
@@ -1,3 +1,25 @@
+2011-10-24 Rafael Weinstein
+
+Node::registeredMutationObserversOfType should be prefixed by "get"
+https://bugs.webkit.org/show_bug.cgi?id=70359
+
+Reviewed by Ojan Vafai.
+
+This change renames Node::registeredMutationObserversOfType to
+Node::getRegisteredMutationObserversOfType per the WebKit style guide.
+
+No tests needed as the change is only method renaming.
+
+* dom/CharacterData.cpp:
+(WebCore::CharacterData::dispatchModifiedEvent):
+* dom/ChildListMutationScope.cpp:
+(WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel):
+* dom/Element.cpp:
+(WebCore::enqueueAttributesMutationRecord):
+* dom/Node.cpp:
+(WebCore::Node::getRegisteredMutationObserversOfType):
+* dom/Node.h:
+
2011-10-24 Mark Hahnenberg
Rename static getOwnPropertySlot to getOwnPropertySlotByIndex
Modified: trunk/Source/WebCore/dom/CharacterData.cpp (98261 => 98262)
--- trunk/Source/WebCore/dom/CharacterData.cpp 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/CharacterData.cpp 2011-10-24 18:41:35 UTC (rev 98262)
@@ -194,7 +194,7 @@
{
#if ENABLE(MUTATION_OBSERVERS)
Vector observers;
-registeredMutationObserversOfType(observers, WebKitMutationObserver::CharacterData);
+getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::CharacterData);
if (!observers.isEmpty()) {
RefPtr mutation = MutationRecord::createCharacterData(this);
for (size_t i = 0; i < observers.size(); ++i)
Modified: trunk/Source/WebCore/dom/ChildListMutationScope.cpp (98261 => 98262)
--- trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/ChildListMutationScope.cpp 2011-10-24 18:41:35 UTC (rev 98262)
@@ -245,7 +245,7 @@
}
Vector observers;
-target->registeredMutationObserversOfType(observers, WebKitMutationObserver::ChildList);
+target->getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::ChildList);
if (observers.isEmpty())
m_accumulations.set(target, 0);
else
Modified: trunk/Source/WebCore/dom/Element.cpp (98261 => 98262)
--- trunk/Source/WebCore/dom/Element.cpp 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Element.cpp 2011-10-24 18:41:35 UTC (rev 98262)
@@ -620,7 +620,7 @@
static void enqueueAttributesMutationRecord(Element* element, const QualifiedName& name)
{
Vector observers;
-element->registeredMutationObserversOfType(observers, WebKitMutationObserver::Attributes);
+element->getRegisteredMutationObserversOfType(observers, WebKitMutationObserver::Attributes);
if (observers.isEmpty())
return;
Modified: trunk/Source/WebCore/dom/Node.cpp (98261 => 98262)
--- trunk/Source/WebCore/dom/Node.cpp 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Node.cpp 2011-10-24 18:41:35 UTC (rev 98262)
@@ -2711,7 +2711,7 @@
}
}
-void Node::registeredMutationObserversOfType(Vector& observers, WebKitMutationObserver::MutationType type)
+void Node::getRegisteredMutationObserversOfType(Vector& observers, WebKitMutationObserver::MutationType type)
{
HashSet observerSet;
addMatchingObservers(observerSet, mutationObserverEntries(), type);
Modified: trunk/Source/WebCore/dom/Node.h (98261 => 98262)
--- trunk/Source/WebCore/dom/Node.h 2011-10-24 18:37:37 UTC (rev 98261)
+++ trunk/Source/WebCore/dom/Node.h 2011-10-24 18:41:35 UTC (rev 98262)
@@ -589,7 +589,7 @@
#endif
#if ENABLE(MUTATION_OBSERVERS)
-void reg
[webkit-changes] [98261] trunk/Source
Title: [98261] trunk/Source Revision 98261 Author mhahnenb...@apple.com Date 2011-10-24 11:37:37 -0700 (Mon, 24 Oct 2011) Log Message Rename static getOwnPropertySlot to getOwnPropertySlotByIndex https://bugs.webkit.org/show_bug.cgi?id=70271 Reviewed by Darin Adler. Source/_javascript_Core: Renaming versions of getOwnPropertySlot that use an unsigned as the property name to "getOwnPropertySlotByIndex" in preparation for adding them to the MethodTable, which requires unique names for each method. * _javascript_Core.exp: * _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: * runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertySlotVirtual): (JSC::Arguments::getOwnPropertySlotByIndex): * runtime/Arguments.h: * runtime/JSArray.cpp: (JSC::JSArray::getOwnPropertySlotVirtual): (JSC::JSArray::getOwnPropertySlotByIndex): (JSC::JSArray::getOwnPropertySlot): * runtime/JSArray.h: * runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertySlotVirtual): (JSC::JSByteArray::getOwnPropertySlotByIndex): * runtime/JSByteArray.h: * runtime/JSCell.cpp: (JSC::JSCell::getOwnPropertySlotVirtual): (JSC::JSCell::getOwnPropertySlotByIndex): * runtime/JSCell.h: * runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::getOwnPropertySlotVirtual): (JSC::JSNotAnObject::getOwnPropertySlotByIndex): * runtime/JSNotAnObject.h: * runtime/JSObject.cpp: (JSC::JSObject::getOwnPropertySlotVirtual): (JSC::JSObject::getOwnPropertySlotByIndex): * runtime/JSObject.h: * runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlotVirtual): (JSC::JSString::getOwnPropertySlotByIndex): * runtime/JSString.h: * runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::getOwnPropertySlotVirtual): (JSC::ObjectPrototype::getOwnPropertySlotByIndex): * runtime/ObjectPrototype.h: * runtime/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlotVirtual): (JSC::RegExpMatchesArray::getOwnPropertySlotByIndex): * runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertySlotVirtual): (JSC::StringObject::getOwnPropertySlotByIndex): * runtime/StringObject.h: Source/WebCore: No new tests. Renaming versions of getOwnPropertySlot that use an unsigned as the property name to "getOwnPropertySlotByIndex" in preparation for adding them to the MethodTable, which requires unique names for each method. * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::getSparseIndex): * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): (GenerateImplementation): * bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertySlotVirtual): (JSC::RuntimeArray::getOwnPropertySlotByIndex): * bridge/runtime_array.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.exp trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def trunk/Source/_javascript_Core/runtime/Arguments.cpp trunk/Source/_javascript_Core/runtime/Arguments.h trunk/Source/_javascript_Core/runtime/JSArray.cpp trunk/Source/_javascript_Core/runtime/JSArray.h trunk/Source/_javascript_Core/runtime/JSByteArray.cpp trunk/Source/_javascript_Core/runtime/JSByteArray.h trunk/Source/_javascript_Core/runtime/JSCell.cpp trunk/Source/_javascript_Core/runtime/JSCell.h trunk/Source/_javascript_Core/runtime/JSNotAnObject.cpp trunk/Source/_javascript_Core/runtime/JSNotAnObject.h trunk/Source/_javascript_Core/runtime/JSObject.cpp trunk/Source/_javascript_Core/runtime/JSObject.h trunk/Source/_javascript_Core/runtime/JSString.cpp trunk/Source/_javascript_Core/runtime/JSString.h trunk/Source/_javascript_Core/runtime/ObjectPrototype.cpp trunk/Source/_javascript_Core/runtime/ObjectPrototype.h trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h trunk/Source/_javascript_Core/runtime/StringObject.cpp trunk/Source/_javascript_Core/runtime/StringObject.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm trunk/Source/WebCore/bridge/runtime_array.cpp trunk/Source/WebCore/bridge/runtime_array.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98260 => 98261) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-24 18:37:04 UTC (rev 98260) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-24 18:37:37 UTC (rev 98261) @@ -1,3 +1,57 @@ +2011-10-24 Mark Hahnenberg + +Rename static getOwnPropertySlot to getOwnPropertySlotByIndex +https://bugs.webkit.org/show_bug.cgi?id=70271 + +Reviewed by Darin Adler. + +Renaming versions of getOwnPropertySlot that use an unsigned as the property +name to "getOwnPropertySlotByIndex" in preparation for adding them to the +MethodTable, which requires unique names for each method. + +* _javascript_Core.exp: +* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def: +* runtime/Arguments.cpp: +(JSC::Arguments::getOwnPropertySlotVirtual): +(JSC::Arguments::getOwnPropertySlotByIndex): +* run
[webkit-changes] [98260] trunk/LayoutTests
Title: [98260] trunk/LayoutTests Revision 98260 Author jchaffr...@webkit.org Date 2011-10-24 11:37:04 -0700 (Mon, 24 Oct 2011) Log Message Unreviewed gardening rebaselining. Updating those baselines as they match Mac and looks like progressions. Linux was needing a wrong rebaseline, so it was not rebaselined. * platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint: Added. * platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. * platform/chromium-mac-leopard/fast/repaint: Added. * platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. * platform/chromium-mac-snowleopard/fast/repaint: Added. * platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. * platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/ trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98259 => 98260) --- trunk/LayoutTests/ChangeLog 2011-10-24 18:36:18 UTC (rev 98259) +++ trunk/LayoutTests/ChangeLog 2011-10-24 18:37:04 UTC (rev 98260) @@ -1,3 +1,20 @@ +2011-10-24 Julien Chaffraix + +Unreviewed gardening rebaselining. + +Updating those baselines as they match Mac and looks like progressions. Linux was needing a wrong +rebaseline, so it was not rebaselined. + +* platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint: Added. +* platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. +* platform/chromium-mac-leopard/fast/repaint: Added. +* platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/repaint: Added. +* platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png: Added. +* platform/chromium-win/fast/repaint/table-cell-collapsed-border-expected.png: +* platform/chromium/test_expectations.txt: + 2011-10-24 Joshua Bell IndexedDB add should fail adding an inline and passed key simultaneously Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98259 => 98260) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 18:36:18 UTC (rev 98259) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 18:37:04 UTC (rev 98260) @@ -1364,7 +1364,7 @@ BUGCR23473 MAC : fast/repaint/transform-translate.html = IMAGE // Fails due to r67862. -BUGWK39966 : fast/repaint/table-cell-collapsed-border.html = IMAGE +BUGWK39966 LINUX : fast/repaint/table-cell-collapsed-border.html = IMAGE // Thicker shadow than expected BUGCR23471 LEOPARD : fast/text/stroking.html = IMAGE Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/table-cell-collapsed-border-expected.png ___ Added: svn:mime-type Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/table-cell-collapsed-border-expected.png (Binary files differ) Pro
[webkit-changes] [98259] trunk/Source/WebKit2
Title: [98259] trunk/Source/WebKit2
Revision 98259
Author wei...@apple.com
Date 2011-10-24 11:36:18 -0700 (Mon, 24 Oct 2011)
Log Message
Add zoom and title support to Objective-C WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=70744
Reviewed by Darin Adler.
* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98258 => 98259)
--- trunk/Source/WebKit2/ChangeLog 2011-10-24 18:31:55 UTC (rev 98258)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-24 18:36:18 UTC (rev 98259)
@@ -1,3 +1,18 @@
+2011-10-24 Sam Weinig
+
+Add zoom and title support to Objective-C WebKit2 API
+https://bugs.webkit.org/show_bug.cgi?id=70744
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/mac/WKBrowsingContextController.h:
+* UIProcess/API/mac/WKBrowsingContextController.mm:
+(-[WKBrowsingContextController title]):
+(-[WKBrowsingContextController textZoom]):
+(-[WKBrowsingContextController setTextZoom:]):
+(-[WKBrowsingContextController pageZoom]):
+(-[WKBrowsingContextController setPageZoom:]):
+
2011-10-24 Carlos Garcia Campos
[GTK] Fix make distcheck build
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h (98258 => 98259)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 18:31:55 UTC (rev 98258)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h 2011-10-24 18:36:18 UTC (rev 98259)
@@ -62,13 +62,28 @@
/* Go to the next page in the back/forward list. */
- (void)goForward;
-/* Returns whether there is a next page in the back/forward list. */
-- (BOOL)canGoForward;
+/* Whether there is a next page in the back/forward list. */
+@property(readonly) BOOL canGoForward;
/* Go to the previous page in the back/forward list. */
- (void)goBack;
-/* Returns whether there is a previous page in the back/forward list. */
-- (BOOL)canGoBack;
+/* Whether there is a previous page in the back/forward list. */
+@property(readonly) BOOL canGoBack;
+
+#pragma mark Active Document Introspection
+
+/* Title of the document associated with the active load. */
+@property(readonly) NSString *title;
+
+
+#pragma mark Zoom
+
+/* Sets the text zoom for the active URL. */
+@property CGFloat textZoom;
+
+/* Sets the text zoom for the active URL. */
+@property CGFloat pageZoom;
+
@end
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm (98258 => 98259)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 18:31:55 UTC (rev 98258)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm 2011-10-24 18:36:18 UTC (rev 98259)
@@ -31,6 +31,7 @@
#import "WKRetainPtr.h"
#import "WKURLRequest.h"
#import "WKURLRequestNS.h"
+#import "WKStringCF.h"
@interface WKBrowsingContextControllerData : NSObject {
@public
@@ -104,6 +105,36 @@
return WKPageCanGoBack(self.pageRef);
}
+#pragma mark Active Document Introspection
+
+- (NSString *)title
+{
+WKRetainPtr wkTitle = adoptWK(WKPageCopyTitle(self.pageRef));
+return [(NSString *)WKStringCopyCFString(kCFAllocatorDefault, wkTitle.get()) autorelease];
+}
+
+#pragma mark Zoom
+
+- (CGFloat)textZoom
+{
+return WKPageGetTextZoomFactor(self.pageRef);
+}
+
+- (void)setTextZoom:(CGFloat)textZoom
+{
+return WKPageSetTextZoomFactor(self.pageRef, textZoom);
+}
+
+- (CGFloat)pageZoom
+{
+return WKPageGetPageZoomFactor(self.pageRef);
+}
+
+- (void)setPageZoom:(CGFloat)pageZoom
+{
+return WKPageSetPageZoomFactor(self.pageRef, pageZoom);
+}
+
@end
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98258] trunk
Title: [98258] trunk
Revision 98258
Author commit-qu...@webkit.org
Date 2011-10-24 11:31:55 -0700 (Mon, 24 Oct 2011)
Log Message
IndexedDB add should fail adding an inline and passed key simultaneously
https://bugs.webkit.org/show_bug.cgi?id=58598
Patch by Joshua Bell on 2011-10-24
Reviewed by Tony Chang.
Source/WebCore:
Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
Implement the spec clause: passing a key into add() or put() when
the object store has a key path ("inline key") is an error.
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
LayoutTests:
* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html: Added.
* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt
trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98257 => 98258)
--- trunk/LayoutTests/ChangeLog 2011-10-24 18:29:40 UTC (rev 98257)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 18:31:55 UTC (rev 98258)
@@ -1,3 +1,13 @@
+2011-10-24 Joshua Bell
+
+IndexedDB add should fail adding an inline and passed key simultaneously
+https://bugs.webkit.org/show_bug.cgi?id=58598
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/mozilla/key-requirements-inline-and-passed.html: Added.
+* storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Added.
+
2011-10-24 Cary Clark
Unreviewed gardening: third chunk of baselines for Chromium-Skia
Added: trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt (0 => 98258)
--- trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt 2011-10-24 18:31:55 UTC (rev 98258)
@@ -0,0 +1,21 @@
+Test IndexedDB's behavior adding inline and passed key simultaneously
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS 'webkitIndexedDB' in window is true
+PASS webkitIndexedDB == null is false
+webkitIndexedDB.open(name, description)
+openSuccess():
+db = event.target.result
+request = db.setVersion('version 1')
+cleanDatabase():
+Deleted all object stores.
+objectStore = db.createObjectStore('baz', { keyPath: 'id' });
+Expecting exception from objectStore.add({id: 5}, 5);
+PASS Exception was thrown.
+PASS code is webkitIDBDatabaseException.DATA_ERR
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed.html (0 => 98258)
--- trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed.html (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed.html 2011-10-24 18:31:55 UTC (rev 98258)
@@ -0,0 +1,61 @@
+
+
+
+
+
+
+
+
+
+
+description("Test IndexedDB's behavior adding inline and passed key simultaneously");
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function test()
+{
+shouldBeTrue("'webkitIndexedDB' in window");
+shouldBeFalse("webkitIndexedDB == null");
+
+name = window.location.pathname;
+description = "My Test Database";
+request = evalAndLog("webkitIndexedDB.open(name, description)");
+request._onsuccess_ = openSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function openSuccess()
+{
+debug("openSuccess():");
+db = evalAndLog("db = event.target.result");
+
+request = evalAndLog("request = db.setVersion('version 1')");
+request._onsuccess_ = cleanDatabase;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function cleanDatabase()
+{
+debug("cleanDatabase():");
+deleteAllObjectStores(db);
+objectStore = evalAndLog("objectStore = db.createObjectStore('baz', { keyPath: 'id' });");
+evalAndExpectException("objectStore.add({id: 5}, 5);", "webkitIDBDatabaseException.DATA_ERR");
+done();
+}
+
+var successfullyParsed = true;
+
+test();
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (98257 => 98258)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 18:29:40 UTC (rev 98257)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 18:31:55 UTC (rev 98258)
@@ -1,3 +1,18 @@
+2011-10-24 Joshua Bell
+
+IndexedDB add should fail adding an inline and passed key simultaneously
+https://bugs.webkit.org/show_bug.cgi?id=58598
+
+Reviewed by Tony Chang.
+
+Test: storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
+
+Implement the spec clause: passing a key into add() or put() wh
[webkit-changes] [98257] branches/safari-534.52-branch/Source
Title: [98257] branches/safari-534.52-branch/Source Revision 98257 Author lforsch...@apple.com Date 2011-10-24 11:29:40 -0700 (Mon, 24 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98256 => 98257) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 18:07:39 UTC (rev 98256) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 18:29:40 UTC (rev 98257) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98256 => 98257) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 18:07:39 UTC (rev 98256) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 18:29:40 UTC (rev 98257) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98256 => 98257) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 18:07:39 UTC (rev 98256) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 18:29:40 UTC (rev 98257) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98256 => 98257) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 18:07:39 UTC (rev 98256) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 18:29:40 UTC (rev 98257) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98256 => 98257) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 18:07:39 UTC (rev 98256) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 18:29:40 UTC (rev 98257) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 2; +TINY_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98256] trunk/WebKitLibraries
Title: [98256] trunk/WebKitLibraries Revision 98256 Author msab...@apple.com Date 2011-10-24 11:07:39 -0700 (Mon, 24 Oct 2011) Log Message WebKit doesn't build with recent changes to libdispatch https://bugs.webkit.org/show_bug.cgi?id=70737 Added new WebKitSystemInterface method CreateVMPressureDispatchOnMainQueue. * WebKitSystemInterface.h: * libWebKitSystemInterfaceLeopard.a: * libWebKitSystemInterfaceLion.a: * libWebKitSystemInterfaceSnowLeopard.a: Modified Paths trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitSystemInterface.h trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a Diff Modified: trunk/WebKitLibraries/ChangeLog (98255 => 98256) --- trunk/WebKitLibraries/ChangeLog 2011-10-24 18:05:57 UTC (rev 98255) +++ trunk/WebKitLibraries/ChangeLog 2011-10-24 18:07:39 UTC (rev 98256) @@ -1,3 +1,15 @@ +2011-10-24 Michael Saboff + +WebKit doesn't build with recent changes to libdispatch +https://bugs.webkit.org/show_bug.cgi?id=70737 + +Added new WebKitSystemInterface method CreateVMPressureDispatchOnMainQueue. + +* WebKitSystemInterface.h: +* libWebKitSystemInterfaceLeopard.a: +* libWebKitSystemInterfaceLion.a: +* libWebKitSystemInterfaceSnowLeopard.a: + 2011-10-21 Jeff Miller Focus rings are too thin in HiDPI in WebKit2 Modified: trunk/WebKitLibraries/WebKitSystemInterface.h (98255 => 98256) --- trunk/WebKitLibraries/WebKitSystemInterface.h 2011-10-24 18:05:57 UTC (rev 98255) +++ trunk/WebKitLibraries/WebKitSystemInterface.h 2011-10-24 18:07:39 UTC (rev 98256) @@ -445,6 +445,14 @@ #endif +#if !defined(BUILDING_ON_LEOPARD) && !defined(BUILDING_ON_SNOW_LEOPARD) + +#import + +dispatch_source_t WKCreateVMPressureDispatchOnMainQueue(void); + +#endif + #ifdef __cplusplus } #endif Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceLeopard.a (Binary files differ) Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceLion.a (Binary files differ) Modified: trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98255] trunk/Source/WebCore
Title: [98255] trunk/Source/WebCore
Revision 98255
Author simon.fra...@apple.com
Date 2011-10-24 11:05:57 -0700 (Mon, 24 Oct 2011)
Log Message
Improve debug compositing border colors
https://bugs.webkit.org/show_bug.cgi?id=70742
Reviewed by Dean Jackson.
Improve the appearance of the debug borders used to indicate compositing:
1. Use green for normal layers, orange for tiled layers
2. Make the repaint counter translucent
3. Change the color of the repaint counter to show when accelerated drawing is enabled.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::updateDebugIndicators):
* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (98254 => 98255)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 17:54:40 UTC (rev 98254)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 18:05:57 UTC (rev 98255)
@@ -1,3 +1,20 @@
+2011-10-24 Simon Fraser
+
+Improve debug compositing border colors
+https://bugs.webkit.org/show_bug.cgi?id=70742
+
+Reviewed by Dean Jackson.
+
+Improve the appearance of the debug borders used to indicate compositing:
+1. Use green for normal layers, orange for tiled layers
+2. Make the repaint counter translucent
+3. Change the color of the repaint counter to show when accelerated drawing is enabled.
+
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::updateDebugIndicators):
+* platform/graphics/mac/WebLayer.mm:
+(drawLayerContents):
+
2011-10-24 Carlos Garcia Campos
[GTK] Fix make distcheck build
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (98254 => 98255)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2011-10-24 17:54:40 UTC (rev 98254)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2011-10-24 18:05:57 UTC (rev 98255)
@@ -306,15 +306,13 @@
if (GraphicsLayer::showDebugBorders()) {
if (drawsContent()) {
if (m_usingTiledLayer)
-setDebugBorder(Color(0, 255, 0, 204), 2.0f);// tiled layer: green
+setDebugBorder(Color(255, 128, 0, 128), 2); // tiled layer: orange
else
-setDebugBorder(Color(255, 0, 0, 204), 2.0f);// normal layer: red
+setDebugBorder(Color(0, 128, 32, 128), 2); // normal layer: green
} else if (masksToBounds()) {
-setDebugBorder(Color(128, 255, 255, 178), 2.0f);// masking layer: pale blue
-if (GraphicsLayer::showDebugBorders())
-setDebugBackgroundColor(Color(128, 255, 255, 52));
+setDebugBorder(Color(128, 255, 255, 48), 20); // masking layer: pale blue
} else
-setDebugBorder(Color(255, 255, 0, 204), 2.0f); // container: yellow
+setDebugBorder(Color(255, 255, 0, 192), 2); // container: yellow
}
}
Modified: trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm (98254 => 98255)
--- trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2011-10-24 17:54:40 UTC (rev 98254)
+++ trunk/Source/WebCore/platform/graphics/mac/WebLayer.mm 2011-10-24 18:05:57 UTC (rev 98255)
@@ -87,24 +87,31 @@
char text[16]; // that's a lot of repaints
snprintf(text, sizeof(text), "%d", layerContents->platformCALayerIncrementRepaintCount());
+CGRect indicatorBox = layerBounds;
+indicatorBox.size.width = 12 + 10 * strlen(text);
+indicatorBox.size.height = 27;
CGContextSaveGState(context);
+
+CGContextSetAlpha(context, 0.5);
+CGContextBeginTransparencyLayerWithRect(context, indicatorBox, 0);
+
if (isTiledLayer)
-CGContextSetRGBFillColor(context, 0.0f, 1.0f, 0.0f, 0.8f);
+CGContextSetRGBFillColor(context, 1, 0.5f, 0, 1);
else
-CGContextSetRGBFillColor(context, 1.0f, 0.0f, 0.0f, 0.8f);
+CGContextSetRGBFillColor(context, 0, 0.5f, 0.25f, 1);
-CGRect aBounds = layerBounds;
-
-aBounds.size.width = 10 + 12 * strlen(text);
-aBounds.size.height = 25;
-CGContextFillRect(context, aBounds);
+CGContextFillRect(context, indicatorBox);
-CGContextSetRGBFillColor(context, 0.0f, 0.0f, 0.0f, 1.0f);
+if (platformLayer->acceleratesDrawing())
+CGContextSetRGBFillColor(context, 1, 0, 0, 1);
+else
+CGContextSetRGBFillColor(context, 1, 1, 1, 1);
-CGContextSetTextMatrix(context, CGAffineTransformMakeScale(1.0f, -1.0f));
-CGContextSelectFont(context, "Helvetica", 25, kCGEncodingMacRoman);
-CGContextShowTextAtPoint(context, aBounds.origin.x + 3.0f, aBounds.origin.y + 20.0f, text, strlen(text));
+CGContextSetTextMatrix(context, CGAffineTr
[webkit-changes] [98254] branches/subpixellayout/Source/WebCore
Title: [98254] branches/subpixellayout/Source/WebCore
Revision 98254
Author le...@chromium.org
Date 2011-10-24 10:54:40 -0700 (Mon, 24 Oct 2011)
Log Message
Fixing repaint issues from truncated damage rects. Fixing a remaining loop in RenderDeprecatedFlexibleBox. Properly constructing FloatWithRect with a LayoutRect, which fixes lots of line layout issues.
Modified Paths
branches/subpixellayout/Source/WebCore/page/FrameView.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h
branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderRegion.cpp
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/page/FrameView.cpp (98253 => 98254)
--- branches/subpixellayout/Source/WebCore/page/FrameView.cpp 2011-10-24 17:34:07 UTC (rev 98253)
+++ branches/subpixellayout/Source/WebCore/page/FrameView.cpp 2011-10-24 17:54:40 UTC (rev 98254)
@@ -1870,7 +1870,7 @@
continue;
}
#endif
-ScrollView::repaintContentRectangle(m_repaintRects[i], false);
+ScrollView::repaintContentRectangle(enclosingIntRect(m_repaintRects[i]), false);
}
m_repaintRects.clear();
m_repaintCount = 0;
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h (98253 => 98254)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2011-10-24 17:34:07 UTC (rev 98253)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2011-10-24 17:54:40 UTC (rev 98254)
@@ -476,7 +476,7 @@
struct FloatWithRect {
FloatWithRect(RenderBox* f)
: object(f)
-, rect(IntRect(f->x() - f->marginLeft(), f->y() - f->marginTop(), f->width() + f->marginLeft() + f->marginRight(), f->height() + f->marginTop() + f->marginBottom()))
+, rect(LayoutRect(f->x() - f->marginLeft(), f->y() - f->marginTop(), f->width() + f->marginLeft() + f->marginRight(), f->height() + f->marginTop() + f->marginBottom()))
, everHadLayout(f->m_everHadLayout)
{
}
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp (98253 => 98254)
--- branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp 2011-10-24 17:34:07 UTC (rev 98253)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp 2011-10-24 17:54:40 UTC (rev 98254)
@@ -798,7 +798,11 @@
}
if (groupRemainingSpace == groupRemainingSpaceAtBeginning) {
// This is not advancing, avoid getting stuck by distributing the remaining pixels.
-LayoutUnit spaceAdd = groupRemainingSpace > 0 ? 1 : -1;
+int spaceAdd;
+if (groupRemainingSpace.abs() < 1)
+spaceAdd = groupRemainingSpace;
+else
+spaceAdd = groupRemainingSpace > 0 ? 1 : -1;
for (RenderBox* child = iterator.first(); child && groupRemainingSpace; child = iterator.next()) {
if (allowedChildFlex(child, expanding, i)) {
child->setOverrideHeight(child->overrideHeight() + spaceAdd);
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderRegion.cpp (98253 => 98254)
--- branches/subpixellayout/Source/WebCore/rendering/RenderRegion.cpp 2011-10-24 17:34:07 UTC (rev 98253)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderRegion.cpp 2011-10-24 17:54:40 UTC (rev 98254)
@@ -41,7 +41,7 @@
namespace WebCore {
RenderRegion::RenderRegion(Node* node, RenderFlowThread* flowThread)
-: RenderReplaced(node, IntSize())
+: RenderReplaced(node, LayoutSize())
, m_flowThread(flowThread)
, m_parentFlowThread(0)
, m_isValid(false)
Modified: branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp (98253 => 98254)
--- branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-10-24 17:34:07 UTC (rev 98253)
+++ branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGRoot.cpp 2011-10-24 17:54:40 UTC (rev 98254)
@@ -119,7 +119,7 @@
if (!style()->width().isPercent())
return replacedWidth;
// FIXME: Remove unnecessary rounding when layout is off ints: webkit.org/b/63656
-return static_cast(ceilf(replacedWidth * style()->effectiveZoom()));
+return static_cast(ceilf(replacedWidth * style()->effectiveZoom()));
}
LayoutUnit RenderSVGRoot::computeIntrinsicHeight(LayoutUnit replacedHeight) const
@@ -127,7 +127,7 @@
if (!style()->height().isPercent())
return replacedHeight;
// FIXME: Remove unnecessary rounding when layout is off ints: webkit.org/b/63656
-return static_cast(ceilf(replacedHeight * style()->effectiveZoom()));
+return static_cast(ceilf(replacedHeight * styl
[webkit-changes] [98252] trunk/Tools
Title: [98252] trunk/Tools Revision 98252 Author kbal...@webkit.org Date 2011-10-24 10:33:01 -0700 (Mon, 24 Oct 2011) Log Message [Qt][WK2] Crash when running pixel tests https://bugs.webkit.org/show_bug.cgi?id=70725 Reviewed by Chang Shu. * WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp Diff Modified: trunk/Tools/ChangeLog (98251 => 98252) --- trunk/Tools/ChangeLog 2011-10-24 17:24:55 UTC (rev 98251) +++ trunk/Tools/ChangeLog 2011-10-24 17:33:01 UTC (rev 98252) @@ -1,3 +1,13 @@ +2011-10-24 Balazs Kelemen + +[Qt][WK2] Crash when running pixel tests +https://bugs.webkit.org/show_bug.cgi?id=70725 + +Reviewed by Chang Shu. + +* WebKitTestRunner/qt/TestInvocationQt.cpp: +(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): + 2011-10-24 Carlos Garcia Campos [GTK] Remove g_thread_init() calls Modified: trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp (98251 => 98252) --- trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp 2011-10-24 17:24:55 UTC (rev 98251) +++ trunk/Tools/WebKitTestRunner/qt/TestInvocationQt.cpp 2011-10-24 17:33:01 UTC (rev 98252) @@ -68,7 +68,7 @@ QImage image = WKImageCreateQImage(imageRef); QCryptographicHash hash(QCryptographicHash::Md5); for (unsigned row = 0; row < image.height(); ++row) -hash.addData(reinterpret_cast(image.constScanLine(row)), image.width() * image.bytesPerLine()); +hash.addData(reinterpret_cast(image.constScanLine(row)), image.bytesPerLine()); QByteArray actualHash = hash.result().toHex(); ASSERT(actualHash.size() == 32); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98251] trunk/Source/WebKit/win
Title: [98251] trunk/Source/WebKit/win
Revision 98251
Author aba...@webkit.org
Date 2011-10-24 10:24:55 -0700 (Mon, 24 Oct 2011)
Log Message
Attempt to fix Windows build by updating to the new interface.
* DOMEventsClasses.cpp:
(DOMEvent::createInstance):
Modified Paths
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/DOMEventsClasses.cpp
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (98250 => 98251)
--- trunk/Source/WebKit/win/ChangeLog 2011-10-24 16:44:54 UTC (rev 98250)
+++ trunk/Source/WebKit/win/ChangeLog 2011-10-24 17:24:55 UTC (rev 98251)
@@ -1,3 +1,10 @@
+2011-10-24 Adam Barth
+
+Attempt to fix Windows build by updating to the new interface.
+
+* DOMEventsClasses.cpp:
+(DOMEvent::createInstance):
+
2011-10-18 Adam Barth
Always enable ENABLE(XPATH)
Modified: trunk/Source/WebKit/win/DOMEventsClasses.cpp (98250 => 98251)
--- trunk/Source/WebKit/win/DOMEventsClasses.cpp 2011-10-24 16:44:54 UTC (rev 98250)
+++ trunk/Source/WebKit/win/DOMEventsClasses.cpp 2011-10-24 17:24:55 UTC (rev 98251)
@@ -31,6 +31,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -111,13 +112,13 @@
} else if (e->isMouseEvent()) {
DOMMouseEvent* newEvent = new DOMMouseEvent(e);
hr = newEvent->QueryInterface(IID_IDOMMouseEvent, (void**)&domEvent);
-} else if (e->isMutationEvent()) {
+} else if (e->hasInterface(WebCore::eventNames().interfaceForMutationEvent)) {
DOMMutationEvent* newEvent = new DOMMutationEvent(e);
hr = newEvent->QueryInterface(IID_IDOMMutationEvent, (void**)&domEvent);
-} else if (e->isOverflowEvent()) {
+} else if (e->hasInterface(WebCore::eventNames().interfaceForOverflowEvent)) {
DOMOverflowEvent* newEvent = new DOMOverflowEvent(e);
hr = newEvent->QueryInterface(IID_IDOMOverflowEvent, (void**)&domEvent);
-} else if (e->isWheelEvent()) {
+} else if (e->hasInterface(WebCore::eventNames().interfaceForWheelEvent)) {
DOMWheelEvent* newEvent = new DOMWheelEvent(e);
hr = newEvent->QueryInterface(IID_IDOMWheelEvent, (void**)&domEvent);
} else if (e->isUIEvent()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98250] trunk/Source
Title: [98250] trunk/Source Revision 98250 Author carlo...@webkit.org Date 2011-10-24 09:44:54 -0700 (Mon, 24 Oct 2011) Log Message [GTK] Fix make distcheck build https://bugs.webkit.org/show_bug.cgi?id=69745 Reviewed by Martin Robinson. Source/WebCore: * GNUmakefile.am: * GNUmakefile.list.am: Source/WebKit2: * GNUmakefile.am: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.am trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/GNUmakefile.am Diff Modified: trunk/Source/WebCore/ChangeLog (98249 => 98250) --- trunk/Source/WebCore/ChangeLog 2011-10-24 16:39:00 UTC (rev 98249) +++ trunk/Source/WebCore/ChangeLog 2011-10-24 16:44:54 UTC (rev 98250) @@ -1,3 +1,13 @@ +2011-10-24 Carlos Garcia Campos + +[GTK] Fix make distcheck build +https://bugs.webkit.org/show_bug.cgi?id=69745 + +Reviewed by Martin Robinson. + +* GNUmakefile.am: +* GNUmakefile.list.am: + 2011-10-24 Alexander Pavlov Web Inspector: [Styles] Adding a new style rule breaks things Modified: trunk/Source/WebCore/GNUmakefile.am (98249 => 98250) --- trunk/Source/WebCore/GNUmakefile.am 2011-10-24 16:39:00 UTC (rev 98249) +++ trunk/Source/WebCore/GNUmakefile.am 2011-10-24 16:44:54 UTC (rev 98250) @@ -684,7 +684,7 @@ DerivedSources/WebCore/EventFactory.cpp DerivedSources/WebCore/EventHeaders.h DerivedSources/WebCore/EventInterfaces.h: $(WebCore)/dom/make_event_factory.pl $(WebCore)/dom/EventFactory.in $(AM_V_GEN)$(PERL) -I$(WebCore)/bindings/scripts $< --events $(WebCore)/dom/EventFactory.in --outputDir "$(GENSOURCES_WEBCORE)" -# All Web Inspector generated files are created with this one call to CodeGeneratorInspector.pm +# All Web Inspector generated files are created with this one call to CodeGeneratorInspector.py DerivedSources/WebCore/InspectorProtocolVersion.h : $(WebCore)/inspector/Inspector.json $(WebCore)/inspector/generate-inspector-protocol-version $(PYTHON) $(WebCore)/inspector/generate-inspector-protocol-version -o $(GENSOURCES_WEBCORE)/InspectorProtocolVersion.h $(WebCore)/inspector/Inspector.json @@ -877,17 +877,18 @@ Source/WebCore/css/tokenizer.flex \ Source/WebCore/css/view-source.css \ Source/WebCore/css/WebKitFontFamilyNames.in \ + Source/WebCore/dom/EventFactory.in \ Source/WebCore/dom/make_names.pl \ + Source/WebCore/dom/make_event_factory.pl \ Source/WebCore/html/HTMLAttributeNames.in \ Source/WebCore/html/HTMLTagNames.in \ Source/WebCore/html/parser/create-html-entity-table \ Source/WebCore/html/parser/HTMLEntityNames.in \ Source/WebCore/icu/LICENSE \ - Source/WebCore/inspector/CodeGeneratorInspector.pm \ + Source/WebCore/inspector/CodeGeneratorInspector.py \ Source/WebCore/inspector/InjectedScriptSource.js \ Source/WebCore/inspector/Inspector.json \ Source/WebCore/inspector/Inspector-0.1.json \ - Source/WebCore/inspector/generate-inspector-idl \ Source/WebCore/inspector/generate-inspector-protocol-version \ Source/WebCore/inspector/xxd.pl \ Source/WebCore/LICENSE-APPLE \ Modified: trunk/Source/WebCore/GNUmakefile.list.am (98249 => 98250) --- trunk/Source/WebCore/GNUmakefile.list.am 2011-10-24 16:39:00 UTC (rev 98249) +++ trunk/Source/WebCore/GNUmakefile.list.am 2011-10-24 16:44:54 UTC (rev 98250) @@ -1210,6 +1210,7 @@ Source/WebCore/dom/EventDispatcher.cpp \ Source/WebCore/dom/EventDispatcher.h \ Source/WebCore/dom/EventException.h \ + Source/WebCore/dom/EventFactory.h \ Source/WebCore/dom/EventListener.h \ Source/WebCore/dom/EventListenerMap.cpp \ Source/WebCore/dom/EventListenerMap.h \ Modified: trunk/Source/WebKit2/ChangeLog (98249 => 98250) --- trunk/Source/WebKit2/ChangeLog 2011-10-24 16:39:00 UTC (rev 98249) +++ trunk/Source/WebKit2/ChangeLog 2011-10-24 16:44:54 UTC (rev 98250) @@ -1,5 +1,14 @@ 2011-10-24 Carlos Garcia Campos +[GTK] Fix make distcheck build +https://bugs.webkit.org/show_bug.cgi?id=69745 + +Reviewed by Martin Robinson. + +* GNUmakefile.am: + +2011-10-24 Carlos Garcia Campos + [GTK] Initial implementation of back forward list for WebKit2 GTK+ API https://bugs.webkit.org/show_bug.cgi?id=69343 Modified: trunk/Source/WebKit2/GNUmakefile.am (98249 => 98250) --- trunk/Source/WebKit2/GNUmakefile.am 2011-10-24 16:39:00 UTC (rev 98249) +++ trunk/Source/WebKit2/GNUmakefile.am 2011-10-24 16:44:54 UTC (rev 98250) @@ -1376,7 +1376,7 @@ EXTRA_DIST += \ $(WebKit2)/UIProcess/API/gtk/docs/GNUmakefile.am \ - $(WebKit2)/UIProcess/API/gtk/docs/webkitgtk-docs.sgml \ - $(WebKit2)/UIProcess/API/gtk/docs/webkitgtk-sections.txt \ + $(WebKit2)/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml \ + $(WebKit2)/UIProcess/API/gtk/docs/webkit2gtk-sections.txt \ $(WebKit2)/UIProcess/API/gtk/docs/version.xml.in \ $(WebKit2)/UIProcess/API/gtk/docs/webkit2gtk.types ___ webkit-changes mailing list webkit-changes@lists.we
[webkit-changes] [98249] trunk/LayoutTests
Title: [98249] trunk/LayoutTests Revision 98249 Author jchaffr...@webkit.org Date 2011-10-24 09:39:00 -0700 (Mon, 24 Oct 2011) Log Message [chromium] New failing test fast/events/dropzone-002.html https://bugs.webkit.org/show_bug.cgi?id=61625 Unreviewed gardening. * platform/chromium/test_expectations.txt: The test has been passing on all platforms except leopard for several days. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98248 => 98249) --- trunk/LayoutTests/ChangeLog 2011-10-24 16:31:07 UTC (rev 98248) +++ trunk/LayoutTests/ChangeLog 2011-10-24 16:39:00 UTC (rev 98249) @@ -1,3 +1,13 @@ +2011-10-24 Julien Chaffraix + +[chromium] New failing test fast/events/dropzone-002.html +https://bugs.webkit.org/show_bug.cgi?id=61625 + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: The test has been passing +on all platforms except leopard for several days. + 2011-10-24 Alexander Pavlov Web Inspector: [Styles] Adding a new style rule breaks things Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98248 => 98249) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 16:31:07 UTC (rev 98248) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-24 16:39:00 UTC (rev 98249) @@ -3204,7 +3204,7 @@ BUGWK61611 LINUX WIN : editing/pasteboard/interchange-newline-2.html = TEXT -BUGWK61625 : fast/events/dropzone-002.html = TEXT +BUGWK61625 LEOPARD : fast/events/dropzone-002.html = TEXT BUGWK61624 WIN : editing/pasteboard/smart-paste-003.html = TEXT BUGWK61624 WIN : editing/pasteboard/smart-paste-004.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98248] branches/chromium/912
Title: [98248] branches/chromium/912
Revision 98248
Author apav...@chromium.org
Date 2011-10-24 09:31:07 -0700 (Mon, 24 Oct 2011)
Log Message
Merge 98243 - Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721
Reviewed by Pavel Feldman.
Source/WebCore:
We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
LayoutTests:
* inspector/styles/styles-add-new-rule-expected.txt:
* inspector/styles/styles-add-new-rule.html:
TBR=apav...@chromium.org
Review URL: http://codereview.chromium.org/8380009
Modified Paths
branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt
branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule.html
branches/chromium/912/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt (98247 => 98248)
--- branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt 2011-10-24 15:54:10 UTC (rev 98247)
+++ branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt 2011-10-24 16:31:07 UTC (rev 98248)
@@ -1,4 +1,4 @@
-Tests that adding a new rule works after sitching nodes.
+Tests that adding a new rule works after switching nodes.
Text
After adding new rule (inspected):
@@ -7,6 +7,7 @@
Matched CSS Rules
[expanded] #inspected { (via inspector)
+color: maroon;
[expanded] div { (user agent stylesheet)
display: block;
Modified: branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule.html (98247 => 98248)
--- branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule.html 2011-10-24 15:54:10 UTC (rev 98247)
+++ branches/chromium/912/LayoutTests/inspector/styles/styles-add-new-rule.html 2011-10-24 16:31:07 UTC (rev 98248)
@@ -13,25 +13,40 @@
function step1()
{
-// Click add new rule
+// Click "Add new rule".
document.getElementById("add-style-button-test-id").click();
-InspectorTest.selectNodeAndWaitForStyles("other", step2);
+var section = WebInspector.panels.elements.sidebarPanes.styles.sections[0][2];
+section._selectorElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+InspectorTest.runAfterPendingDispatches(step2);
}
-function step2() {
-// Click add new rule
-document.getElementById("add-style-button-test-id").click();
-InspectorTest.selectNodeAndWaitForStyles("inspected", step3);
+function step2()
+{
+var section = WebInspector.panels.elements.sidebarPanes.styles.sections[0][2];
+var newProperty = section.addNewBlankProperty();
+newProperty.startEditing();
+newProperty.nameElement.textContent = "color";
+newProperty.nameElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+newProperty.valueElement.textContent = "maroon";
+newProperty.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+InspectorTest.selectNodeAndWaitForStyles("other", step3);
}
function step3()
{
+// Click "Add new rule".
+document.getElementById("add-style-button-test-id").click();
+InspectorTest.selectNodeAndWaitForStyles("inspected", step4);
+}
+
+function step4()
+{
InspectorTest.addResult("After adding new rule (inspected):");
InspectorTest.dumpSelectedElementStyles(true, false, true);
-InspectorTest.selectNodeAndWaitForStyles("other", step4);
+InspectorTest.selectNodeAndWaitForStyles("other", step5);
}
-function step4()
+function step5()
{
InspectorTest.addResult("After adding new rule (other):");
InspectorTest.dumpSelectedElementStyles(true, false, true);
@@ -44,7 +59,7 @@
-Tests that adding a new rule works after sitching nodes.
+Tests that adding a new rule works after switching nodes.
Text
Modified: branches/chromium/912/Source/WebCore/inspector/front-end/StylesSidebarPane.js (98247 => 98248)
--- branches/chromium/912/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2011-10-24 15:54:10 UTC (rev 98247)
+++ branches/chromium/912/Source/WebCore/insp
[webkit-changes] [98247] branches/chromium/912
Title: [98247] branches/chromium/912 Revision 98247 Author vse...@chromium.org Date 2011-10-24 08:54:10 -0700 (Mon, 24 Oct 2011) Log Message Merge 97975 - Web Inspector: Advanced search results should keep working after pretty print toggled. https://bugs.webkit.org/show_bug.cgi?id=70347 Reviewed by Pavel Feldman. Source/WebCore: * inspector/front-end/AdvancedSearchController.js: (WebInspector.SearchScope.prototype.createSearchResultsPane): (WebInspector.FileBasedSearchResultsPane.prototype.createAnchor): (WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult): (WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges): (WebInspector.FileBasedSearchResultsPane.prototype._createContentSpan): * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._materializeBreakpoint): * inspector/front-end/CompilerSourceMapping.js: (WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel.prototype.createLinkifier): (WebInspector.DebuggerPresentationModel.prototype.continueToLine): (WebInspector.DebuggerPresentationModel.LinkifierFormatter): (WebInspector.DebuggerPresentationModel.LinkifierFormatter.prototype.formatRawSourceCodeAnchor): (WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter): (WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor): (WebInspector.DebuggerPresentationModel.Linkifier): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyResource): (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawSourceCode): (WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor): * inspector/front-end/RawSourceCode.js: (WebInspector.RawSourceCode.SourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiLocationToRawLocation): (WebInspector.RawSourceCode.CompilerSourceMapping.prototype.uiLocationToRawLocation): * inspector/front-end/ScriptsSearchScope.js: (WebInspector.ScriptsSearchResultsPane): (WebInspector.ScriptsSearchResultsPane.prototype.createAnchor): (WebInspector.ScriptsSearchResultsPane.LinkifierFormatter): (WebInspector.ScriptsSearchResultsPane.LinkifierFormatter.prototype.formatRawSourceCodeAnchor): * inspector/front-end/inspector.html: LayoutTests: * inspector/debugger/raw-source-code.html: BUG=101016 TBR=vse...@chromium.org Review URL: http://codereview.chromium.org/8382007 Modified Paths branches/chromium/912/LayoutTests/inspector/debugger/raw-source-code.html branches/chromium/912/Source/WebCore/inspector/front-end/AdvancedSearchController.js branches/chromium/912/Source/WebCore/inspector/front-end/BreakpointManager.js branches/chromium/912/Source/WebCore/inspector/front-end/CompilerSourceMapping.js branches/chromium/912/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js branches/chromium/912/Source/WebCore/inspector/front-end/RawSourceCode.js branches/chromium/912/Source/WebCore/inspector/front-end/ScriptsSearchScope.js branches/chromium/912/Source/WebCore/inspector/front-end/inspector.html Diff Modified: branches/chromium/912/LayoutTests/inspector/debugger/raw-source-code.html (98246 => 98247) --- branches/chromium/912/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-24 15:26:48 UTC (rev 98246) +++ branches/chromium/912/LayoutTests/inspector/debugger/raw-source-code.html 2011-10-24 15:54:10 UTC (rev 98247) @@ -112,7 +112,7 @@ InspectorTest.assertEquals(true, uiSourceCode.isContentScript); InspectorTest.assertEquals(rawSourceCode, uiSourceCode.rawSourceCode); checkUILocation(uiSourceCode, 0, 5, sourceMapping.rawLocationToUILocation(createRawLocation(0, 5))); -checkRawLocation(script, 10, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 10)); +checkRawLocation(script, 10, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 10, 0)); uiSourceCode.requestContent(didRequestContent); function didRequestContent(mimeType, content) @@ -178,8 +178,8 @@ rawSourceCode.addScript(script2); rawSourceCode.forceUpdateSourceMapping(); checkUILocation(uiSourceCode, 1, 20, sourceMapping.rawLocationToUILocation(createRawLocation(1, 20))); -checkRawLocation(script1, 1, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 1)); -checkRawLocation(script2, 6, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 6)); +checkRawLocation(script1, 1, 0, sourceMapping.uiLocationToRawLocation(uiSourceCode, 1, 0)); +checkRawLocation(script2, 6, 0, sourceMapping.uiLocationToRawLocation(uiSour
[webkit-changes] [98246] branches/safari-534.52-branch/Source
Title: [98246] branches/safari-534.52-branch/Source Revision 98246 Author lforsch...@apple.com Date 2011-10-24 08:26:48 -0700 (Mon, 24 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98245 => 98246) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 15:24:08 UTC (rev 98245) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 15:26:48 UTC (rev 98246) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98245 => 98246) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 15:24:08 UTC (rev 98245) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 15:26:48 UTC (rev 98246) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98245 => 98246) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 15:24:08 UTC (rev 98245) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 15:26:48 UTC (rev 98246) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98245 => 98246) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 15:24:08 UTC (rev 98245) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 15:26:48 UTC (rev 98246) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98245 => 98246) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 15:24:08 UTC (rev 98245) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 15:26:48 UTC (rev 98246) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 52; -TINY_VERSION = 1; +TINY_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98244] tags/Safari-534.52.1/
Title: [98244] tags/Safari-534.52.1/ Revision 98244 Author lforsch...@apple.com Date 2011-10-24 08:23:35 -0700 (Mon, 24 Oct 2011) Log Message New tag. Added Paths tags/Safari-534.52.1/ Diff Property changes: tags/Safari-534.52.1 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98243] trunk
Title: [98243] trunk
Revision 98243
Author apav...@chromium.org
Date 2011-10-24 08:23:20 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721
Reviewed by Pavel Feldman.
Source/WebCore:
We had used to swap BlankStylePropertiesSection prototype and recently got rid of this hack,
but still had dependencies on the old behavior.
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._refreshStyleRules):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.get isBlank):
(WebInspector.BlankStylePropertiesSection.prototype.expand):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCancelled):
(WebInspector.BlankStylePropertiesSection.prototype.makeNormal):
LayoutTests:
* inspector/styles/styles-add-new-rule-expected.txt:
* inspector/styles/styles-add-new-rule.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt
trunk/LayoutTests/inspector/styles/styles-add-new-rule.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98242 => 98243)
--- trunk/LayoutTests/ChangeLog 2011-10-24 15:20:38 UTC (rev 98242)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 15:23:20 UTC (rev 98243)
@@ -1,3 +1,13 @@
+2011-10-24 Alexander Pavlov
+
+Web Inspector: [Styles] Adding a new style rule breaks things
+https://bugs.webkit.org/show_bug.cgi?id=70721
+
+Reviewed by Pavel Feldman.
+
+* inspector/styles/styles-add-new-rule-expected.txt:
+* inspector/styles/styles-add-new-rule.html:
+
2011-10-24 Pavel Feldman
Web Inspector: do not force document loading on reload (should happen on demand).
Modified: trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt (98242 => 98243)
--- trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt 2011-10-24 15:20:38 UTC (rev 98242)
+++ trunk/LayoutTests/inspector/styles/styles-add-new-rule-expected.txt 2011-10-24 15:23:20 UTC (rev 98243)
@@ -1,4 +1,4 @@
-Tests that adding a new rule works after sitching nodes.
+Tests that adding a new rule works after switching nodes.
Text
After adding new rule (inspected):
@@ -7,6 +7,7 @@
Matched CSS Rules
[expanded] #inspected { (via inspector)
+color: maroon;
[expanded] div { (user agent stylesheet)
display: block;
Modified: trunk/LayoutTests/inspector/styles/styles-add-new-rule.html (98242 => 98243)
--- trunk/LayoutTests/inspector/styles/styles-add-new-rule.html 2011-10-24 15:20:38 UTC (rev 98242)
+++ trunk/LayoutTests/inspector/styles/styles-add-new-rule.html 2011-10-24 15:23:20 UTC (rev 98243)
@@ -13,25 +13,40 @@
function step1()
{
-// Click add new rule
+// Click "Add new rule".
document.getElementById("add-style-button-test-id").click();
-InspectorTest.selectNodeAndWaitForStyles("other", step2);
+var section = WebInspector.panels.elements.sidebarPanes.styles.sections[0][2];
+section._selectorElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+InspectorTest.runAfterPendingDispatches(step2);
}
-function step2() {
-// Click add new rule
-document.getElementById("add-style-button-test-id").click();
-InspectorTest.selectNodeAndWaitForStyles("inspected", step3);
+function step2()
+{
+var section = WebInspector.panels.elements.sidebarPanes.styles.sections[0][2];
+var newProperty = section.addNewBlankProperty();
+newProperty.startEditing();
+newProperty.nameElement.textContent = "color";
+newProperty.nameElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+newProperty.valueElement.textContent = "maroon";
+newProperty.valueElement.dispatchEvent(InspectorTest.createKeyEvent("Enter"));
+InspectorTest.selectNodeAndWaitForStyles("other", step3);
}
function step3()
{
+// Click "Add new rule".
+document.getElementById("add-style-button-test-id").click();
+InspectorTest.selectNodeAndWaitForStyles("inspected", step4);
+}
+
+function step4()
+{
InspectorTest.addResult("After adding new rule (inspected):");
InspectorTest.dumpSelectedElementStyles(true, false, true);
-InspectorTest.selectNodeAndWaitForStyles("other", step4);
+InspectorTest.selectNodeAndWaitForStyles("other", step5);
}
-function step4()
+function step5()
{
InspectorTest.addResult("After adding new rule (other):");
InspectorTest.dumpSelec
[webkit-changes] [98242] branches/safari-534.52-branch/Source
Title: [98242] branches/safari-534.52-branch/Source Revision 98242 Author lforsch...@apple.com Date 2011-10-24 08:20:38 -0700 (Mon, 24 Oct 2011) Log Message Versioning. Modified Paths branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98241 => 98242) --- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 15:17:25 UTC (rev 98241) +++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-24 15:20:38 UTC (rev 98242) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 51; -TINY_VERSION = 24; +MINOR_VERSION = 52; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98241 => 98242) --- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 15:17:25 UTC (rev 98241) +++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-24 15:20:38 UTC (rev 98242) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 51; -TINY_VERSION = 24; +MINOR_VERSION = 52; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98241 => 98242) --- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 15:17:25 UTC (rev 98241) +++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-24 15:20:38 UTC (rev 98242) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 51; -TINY_VERSION = 24; +MINOR_VERSION = 52; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98241 => 98242) --- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 15:17:25 UTC (rev 98241) +++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-24 15:20:38 UTC (rev 98242) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 51; -TINY_VERSION = 24; +MINOR_VERSION = 52; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98241 => 98242) --- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 15:17:25 UTC (rev 98241) +++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-24 15:20:38 UTC (rev 98242) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 51; -TINY_VERSION = 24; +MINOR_VERSION = 52; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98241] trunk/Source/WebKit2
Title: [98241] trunk/Source/WebKit2
Revision 98241
Author carlo...@webkit.org
Date 2011-10-24 08:17:25 -0700 (Mon, 24 Oct 2011)
Log Message
[GTK] Add helper function to set the loader client in WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70594
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSetLoaderClient): Helper function to set the loader
client.
(webkitWebViewConstructed): Use webkitWebViewSetLoaderClient() to
avoid unnecessary checks.
(webkit_web_view_set_loader_client): Use
webkitWebViewSetLoaderClient().
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98240 => 98241)
--- trunk/Source/WebKit2/ChangeLog 2011-10-24 15:14:46 UTC (rev 98240)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-24 15:17:25 UTC (rev 98241)
@@ -1,5 +1,20 @@
2011-10-24 Carlos Garcia Campos
+[GTK] Add helper function to set the loader client in WebKitWebView
+https://bugs.webkit.org/show_bug.cgi?id=70594
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewSetLoaderClient): Helper function to set the loader
+client.
+(webkitWebViewConstructed): Use webkitWebViewSetLoaderClient() to
+avoid unnecessary checks.
+(webkit_web_view_set_loader_client): Use
+webkitWebViewSetLoaderClient().
+
+2011-10-24 Carlos Garcia Campos
+
[GTK] Remove g_thread_init() calls
https://bugs.webkit.org/show_bug.cgi?id=70717
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (98240 => 98241)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-24 15:14:46 UTC (rev 98240)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2011-10-24 15:17:25 UTC (rev 98241)
@@ -54,15 +54,27 @@
G_DEFINE_TYPE(WebKitWebView, webkit_web_view, WEBKIT_TYPE_WEB_VIEW_BASE)
+static void webkitWebViewSetLoaderClient(WebKitWebView* webView, WebKitWebLoaderClient* loaderClient, WKPageRef wkPage)
+{
+webView->priv->loaderClient = loaderClient;
+webkitWebLoaderClientAttachLoaderClientToPage(loaderClient, wkPage);
+}
+
static void webkitWebViewConstructed(GObject* object)
{
+if (G_OBJECT_CLASS(webkit_web_view_parent_class)->constructed)
+G_OBJECT_CLASS(webkit_web_view_parent_class)->constructed(object);
+
WebKitWebView* webView = WEBKIT_WEB_VIEW(object);
WebKitWebViewPrivate* priv = webView->priv;
+WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(webView);
-webkitWebViewBaseCreateWebPage(WEBKIT_WEB_VIEW_BASE(webView), webkitWebContextGetWKContext(priv->context), 0);
+webkitWebViewBaseCreateWebPage(webViewBase, webkitWebContextGetWKContext(priv->context), 0);
+WebPageProxy* page = webkitWebViewBaseGetPage(webViewBase);
+
static GRefPtr defaultLoaderClient = adoptGRef(WEBKIT_WEB_LOADER_CLIENT(g_object_new(WEBKIT_TYPE_WEB_LOADER_CLIENT, NULL)));
-webkit_web_view_set_loader_client(webView, defaultLoaderClient.get());
+webkitWebViewSetLoaderClient(webView, defaultLoaderClient.get(), toAPI(page));
}
static void webkitWebViewSetProperty(GObject* object, guint propId, const GValue* value, GParamSpec* paramSpec)
@@ -235,8 +247,7 @@
return;
WebPageProxy* page = webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(webView));
-webkitWebLoaderClientAttachLoaderClientToPage(loaderClient, toAPI(page));
-priv->loaderClient = loaderClient;
+webkitWebViewSetLoaderClient(webView, loaderClient, toAPI(page));
}
/**
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98240] trunk
Title: [98240] trunk
Revision 98240
Author pfeld...@chromium.org
Date 2011-10-24 08:14:46 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: do not force document loading on reload (should happen on demand).
https://bugs.webkit.org/show_bug.cgi?id=70724
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._documentUpdated):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.wasShown):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.setVisible):
LayoutTests:
* inspector/debugger/dom-breakpoints.html:
* inspector/debugger/error-in-watch-expressions.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/dom-breakpoints.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js
trunk/Source/WebCore/inspector/front-end/DOMAgent.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/LayoutTests/ChangeLog (98239 => 98240)
--- trunk/LayoutTests/ChangeLog 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 15:14:46 UTC (rev 98240)
@@ -1,3 +1,13 @@
+2011-10-24 Pavel Feldman
+
+Web Inspector: do not force document loading on reload (should happen on demand).
+https://bugs.webkit.org/show_bug.cgi?id=70724
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/debugger/dom-breakpoints.html:
+* inspector/debugger/error-in-watch-expressions.html:
+
2011-10-24 Yury Semikhatsky
Web Inspector: allow debugging dedicated worker initialization
Modified: trunk/LayoutTests/inspector/debugger/dom-breakpoints.html (98239 => 98240)
--- trunk/LayoutTests/inspector/debugger/dom-breakpoints.html 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/LayoutTests/inspector/debugger/dom-breakpoints.html 2011-10-24 15:14:46 UTC (rev 98240)
@@ -137,6 +137,11 @@
function step3()
{
+InspectorTest.expandElementsTree(step4);
+}
+
+function step4()
+{
InspectorTest.evaluateInPageWithTimeout("appendElement('rootElement', 'childElement')");
InspectorTest.addResult("Append childElement to rootElement.");
waitUntilPausedAndDumpStack(next);
Modified: trunk/Source/WebCore/ChangeLog (98239 => 98240)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 15:14:46 UTC (rev 98240)
@@ -1,3 +1,19 @@
+2011-10-24 Pavel Feldman
+
+Web Inspector: do not force document loading on reload (should happen on demand).
+https://bugs.webkit.org/show_bug.cgi?id=70724
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/ConsoleMessage.js:
+(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
+* inspector/front-end/DOMAgent.js:
+(WebInspector.DOMAgent.prototype._documentUpdated):
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel.prototype.wasShown):
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeOutline.prototype.setVisible):
+
2011-10-24 Eric Carlson
Drop MutableTextTrack and make TextTrack always mutable
Modified: trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js (98239 => 98240)
--- trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/Source/WebCore/inspector/front-end/ConsoleMessage.js 2011-10-24 15:14:46 UTC (rev 98240)
@@ -289,6 +289,7 @@
return;
}
var treeOutline = new WebInspector.ElementsTreeOutline(false, false, true);
+treeOutline.setVisible(true);
treeOutline.rootDOMNode = WebInspector.domAgent.nodeForId(nodeId);
treeOutline.element.addStyleClass("outline-disclosure");
if (!treeOutline.children[0].hasChildren)
Modified: trunk/Source/WebCore/inspector/front-end/DOMAgent.js (98239 => 98240)
--- trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/Source/WebCore/inspector/front-end/DOMAgent.js 2011-10-24 15:14:46 UTC (rev 98240)
@@ -726,7 +726,6 @@
_documentUpdated: function()
{
this._setDocument(null);
-this.requestDocument();
},
/**
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (98239 => 98240)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2011-10-24 14:56:39 UTC (rev 98239)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2011-10-24 15:14:46 UTC (rev 98240)
@@ -138,6 +138,9 @@
this.treeOutline.updateSelection()
[webkit-changes] [98239] trunk
Title: [98239] trunk Revision 98239 Author carlo...@webkit.org Date 2011-10-24 07:56:39 -0700 (Mon, 24 Oct 2011) Log Message [GTK] Remove g_thread_init() calls https://bugs.webkit.org/show_bug.cgi?id=70717 Reviewed by Xan Lopez. With newer glib it's not needed anymore and with previous versions it was already called by g_type_init(). Source/WebKit/gtk: * tests/testapplicationcache.c: (main): * tests/testatk.c: (main): * tests/testatkroles.c: (main): * tests/testcopyandpaste.c: (main): * tests/testdomdocument.c: (main): * tests/testdomdomwindow.c: (main): * tests/testdomnode.c: (main): * tests/testdownload.c: (main): * tests/testglobals.c: (main): * tests/testhittestresult.c: (main): * tests/testhttpbackend.c: (main): * tests/testkeyevents.c: (main): * tests/testloading.c: (main): * tests/testmimehandling.c: (main): * tests/testnetworkrequest.c: (main): * tests/testnetworkresponse.c: (main): * tests/testwebbackforwardlist.c: (main): * tests/testwebdatasource.c: (main): * tests/testwebframe.c: (main): * tests/testwebhistoryitem.c: (main): * tests/testwebplugindatabase.c: (main): * tests/testwebresource.c: (main): * tests/testwebsettings.c: (main): * tests/testwebview.c: * tests/testwindow.c: (main): Source/WebKit2: * UIProcess/API/gtk/tests/TestMain.cpp: (main): Tools: * DumpRenderTree/gtk/DumpRenderTree.cpp: (main): * GtkLauncher/main.c: (main): * MiniBrowser/gtk/main.c: (main): Modified Paths trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/tests/testapplicationcache.c trunk/Source/WebKit/gtk/tests/testatk.c trunk/Source/WebKit/gtk/tests/testatkroles.c trunk/Source/WebKit/gtk/tests/testcopyandpaste.c trunk/Source/WebKit/gtk/tests/testdomdocument.c trunk/Source/WebKit/gtk/tests/testdomdomwindow.c trunk/Source/WebKit/gtk/tests/testdomnode.c trunk/Source/WebKit/gtk/tests/testdownload.c trunk/Source/WebKit/gtk/tests/testglobals.c trunk/Source/WebKit/gtk/tests/testhittestresult.c trunk/Source/WebKit/gtk/tests/testhttpbackend.c trunk/Source/WebKit/gtk/tests/testkeyevents.c trunk/Source/WebKit/gtk/tests/testloading.c trunk/Source/WebKit/gtk/tests/testmimehandling.c trunk/Source/WebKit/gtk/tests/testnetworkrequest.c trunk/Source/WebKit/gtk/tests/testnetworkresponse.c trunk/Source/WebKit/gtk/tests/testwebbackforwardlist.c trunk/Source/WebKit/gtk/tests/testwebdatasource.c trunk/Source/WebKit/gtk/tests/testwebframe.c trunk/Source/WebKit/gtk/tests/testwebhistoryitem.c trunk/Source/WebKit/gtk/tests/testwebplugindatabase.c trunk/Source/WebKit/gtk/tests/testwebresource.c trunk/Source/WebKit/gtk/tests/testwebsettings.c trunk/Source/WebKit/gtk/tests/testwebview.c trunk/Source/WebKit/gtk/tests/testwindow.c trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp trunk/Tools/GtkLauncher/main.c trunk/Tools/MiniBrowser/gtk/main.c Diff Modified: trunk/Source/WebKit/gtk/ChangeLog (98238 => 98239) --- trunk/Source/WebKit/gtk/ChangeLog 2011-10-24 14:41:26 UTC (rev 98238) +++ trunk/Source/WebKit/gtk/ChangeLog 2011-10-24 14:56:39 UTC (rev 98239) @@ -1,3 +1,63 @@ +2011-10-24 Carlos Garcia Campos + +[GTK] Remove g_thread_init() calls +https://bugs.webkit.org/show_bug.cgi?id=70717 + +Reviewed by Xan Lopez. + +With newer glib it's not needed anymore and with previous versions +it was already called by g_type_init(). + +* tests/testapplicationcache.c: +(main): +* tests/testatk.c: +(main): +* tests/testatkroles.c: +(main): +* tests/testcopyandpaste.c: +(main): +* tests/testdomdocument.c: +(main): +* tests/testdomdomwindow.c: +(main): +* tests/testdomnode.c: +(main): +* tests/testdownload.c: +(main): +* tests/testglobals.c: +(main): +* tests/testhittestresult.c: +(main): +* tests/testhttpbackend.c: +(main): +* tests/testkeyevents.c: +(main): +* tests/testloading.c: +(main): +* tests/testmimehandling.c: +(main): +* tests/testnetworkrequest.c: +(main): +* tests/testnetworkresponse.c: +(main): +* tests/testwebbackforwardlist.c: +(main): +* tests/testwebdatasource.c: +(main): +* tests/testwebframe.c: +(main): +* tests/testwebhistoryitem.c: +(main): +* tests/testwebplugindatabase.c: +(main): +* tests/testwebresource.c: +(main): +* tests/testwebsettings.c: +(main): +* tests/testwebview.c: +* tests/testwindow.c: +(main): + 2011-10-20 Gustavo Noronha Silva [GTK] webkitgtk's pkgconfig file needs to require _javascript_coregtk Modified: trunk/Source/WebKit/gtk/tests/testapplicationcache.c (98238 => 98239) --- trunk/Source/WebKit/gtk/tests/testapplicationcache.c 2011-10
[webkit-changes] [98237] trunk
Title: [98237] trunk
Revision 98237
Author yu...@chromium.org
Date 2011-10-24 07:32:44 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: allow debugging dedicated worker initialization
https://bugs.webkit.org/show_bug.cgi?id=70723
Source/WebCore:
Now it is possible to pause each new dedicated worker on start. The user
needs to select a checkbox and then each newly created dedicated worker
will be paused on the first statement until the user resumes it explicitely.
Reviewed by Pavel Feldman.
* inspector/Inspector.json: resume command is added. It is similar to GDB's run
command, i.e. worker execution will be paused until explicit "resume" command is
received.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStartImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::shouldPauseDedicatedWorkerOnStart):
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::resume):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext):
* inspector/InspectorRuntimeAgent.h:
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::shouldPauseDedicatedWorkerOnStart): returns true
if the user chose to automatically pause all new workers.
* inspector/InspectorWorkerAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::resume):
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.loaded):
(WebInspector.WorkerManager.loadCompleted):
(WebInspector.WorkerManager.prototype._workerCreated):
(WebInspector.WorkerManager.prototype.openWorkerInspector):
(WebInspector.WorkerManager.prototype._openInspectorWindow):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
* workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
* workers/WorkerContextProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext): additional flag specifying
worker initial state(paused/not paused) is added to the factory method. The flag
will be carried to the corresponding WorkerThread.
(WebCore::WorkerMessagingProxy::connectToInspector):
* workers/WorkerMessagingProxy.h:
Source/WebKit/chromium:
Pass worker thread start mode to the worker thread.
Reviewed by Pavel Feldman.
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
* src/WebWorkerClientImpl.h:
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt
trunk/LayoutTests/inspector/protocol/runtime-agent.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/Inspector.json
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.cpp
trunk/Source/WebCore/inspector/InspectorRuntimeAgent.h
trunk/Source/WebCore/inspector/InspectorWorkerAgent.cpp
trunk/Source/WebCore/inspector/InspectorWorkerAgent.h
trunk/Source/WebCore/inspector/WorkerInspectorController.cpp
trunk/Source/WebCore/inspector/front-end/WorkerManager.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebCore/workers/Worker.cpp
trunk/Source/WebCore/workers/WorkerContextProxy.h
trunk/Source/WebCore/workers/WorkerMessagingProxy.cpp
trunk/Source/WebCore/workers/WorkerMessagingProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.cpp
trunk/Source/WebKit/chromium/src/WebWorkerClientImpl.h
Diff
Modified: trunk/LayoutTests/ChangeLog (98236 => 98237)
--- trunk/LayoutTests/ChangeLog 2011-10-24 13:52:51 UTC (rev 98236)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 14:32:44 UTC (rev 98237)
@@ -1,3 +1,13 @@
+2011-10-24 Yury Semikhatsky
+
+Web Inspector: allow debugging dedicated worker initialization
+https://bugs.webkit.org/show_bug.cgi?id=70723
+
+Reviewed by Pavel Feldman.
+
+* inspector/protocol/runtime-agent-expected.txt:
+* inspector/protocol/runtime-agent.html:
+
2011-10-24 Alejandro G. Castro
Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline
Modified: trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt (98236 => 98237)
--- trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt 2011-10-24 13:52:51 UTC (rev 98236)
+++ trunk/LayoutTests/inspector/protocol/runtime-agent-expected.txt 2011-10-24 14:32:44 UTC (rev 98237)
@@ -253,6 +253,22 @@
id :
}
+---
+RuntimeAgent.run()
+
+request:
+{
+method : "Runtime.run"
+id :
+}
+
+response:
+{
+result : {
+}
+id :
+}
+
===
Coverage for RuntimeAgent
{
@@ -261,5 +277,6 @@
getProperties : "checked"
releaseObject : "checked"
releaseObjectGroup : "check
[webkit-changes] [98236] trunk/Source/WebCore
Title: [98236] trunk/Source/WebCore
Revision 98236
Author pfeld...@chromium.org
Date 2011-10-24 06:52:51 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986
Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".
Patch by Nikita Vasilyev on 2011-10-21
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
(WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel):
* inspector/front-end/TextViewer.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
trunk/Source/WebCore/inspector/front-end/TextEditorModel.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (98235 => 98236)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 12:52:45 UTC (rev 98235)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 13:52:51 UTC (rev 98236)
@@ -1,3 +1,21 @@
+2011-10-21 Nikita Vasilyev
+
+Web Inspector: Make indent configurable
+https://bugs.webkit.org/show_bug.cgi?id=69986
+
+Add a setting to choose an indent from "8 spaces", "4 spaces" (default), "2 spaces", or "Tab character".
+
+Reviewed by Pavel Feldman.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/SettingsScreen.js:
+(WebInspector.SettingsScreen):
+(WebInspector.SettingsScreen.prototype._createSelectSetting.get p):
+(WebInspector.SettingsScreen.prototype._createSelectSetting.changeListener):
+* inspector/front-end/TextEditorModel.js:
+(WebInspector.TextEditorModel):
+* inspector/front-end/TextViewer.js:
+
2011-10-17 Andrey Kosyakov
Web Inspector: add "Add to Watch" option to context menu on selection in source frame
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (98235 => 98236)
--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2011-10-24 12:52:45 UTC (rev 98235)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js 2011-10-24 13:52:51 UTC (rev 98236)
@@ -50,6 +50,13 @@
[ WebInspector.StylesSidebarPane.ColorFormat.HSL, "HSL: hsl(300, 80%, 90%)" ] ], WebInspector.settings.colorFormat));
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Show user agent styles"), WebInspector.settings.showUserAgentStyles));
+p = this._appendSection(WebInspector.UIString("Text editor"));
+p.appendChild(this._createSelectSetting(WebInspector.UIString("Indent"), [
+[ WebInspector.TextEditorModel.Indent.TwoSpaces, WebInspector.UIString("2 spaces") ],
+[ WebInspector.TextEditorModel.Indent.FourSpaces, WebInspector.UIString("4 spaces") ],
+[ WebInspector.TextEditorModel.Indent.EightSpaces, WebInspector.UIString("8 spaces") ],
+[ WebInspector.TextEditorModel.Indent.TabCharacter, WebInspector.UIString("Tab character") ] ], WebInspector.settings.textEditorIndent));
+
if (Preferences.canDisableCache) {
p = this._appendSection(WebInspector.UIString("Network"), true);
p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Disable cache"), WebInspector.settings.cacheDisabled));
@@ -65,7 +72,7 @@
if (Preferences.haveExtensions) {
var handlerSelector = new WebInspector.HandlerSelector(WebInspector.openAnchorLocationRegistry);
p = this._appendSection(WebInspector.UIString("Extensions"), true);
-p.appendChild(this._createCustomSetting(WebInspector.UIString("Open links in..."), handlerSelector.element));
+p.appendChild(this._createCustomSetting(WebInspector.UIString("Open links in"), handlerSelector.element));
}
var table = document.createElement("table");
table.className = "help-table";
@@ -118,6 +125,35 @@
return p;
},
+_createSelectSetting: function(name, options, setting)
+{
+var fieldsetElement = document.createElement("fieldset");
+fieldsetElement.textContent = name;
+
+var select = document.createElement("select");
+var settingValue = setting.get();
+
+for (var i = 0; i < options.length; ++i) {
+var option = options[i];
+select.add(new Option(option[1], option[0]));
+if (settingValue === option[0])
+select.selectedIndex = i;
+
+}
+
+function changeListener(e)
+{
+setting.set(e.target.value);
+}
+
+select.addEventListener("change", changeListener, false);
+fieldsetElement.appendChild(se
[webkit-changes] [98235] trunk/LayoutTests
Title: [98235] trunk/LayoutTests Revision 98235 Author a...@webkit.org Date 2011-10-24 05:52:45 -0700 (Mon, 24 Oct 2011) Log Message 2011-10-24 Alejandro G. Castro Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline prototype-inheritance-2.html. * platform/gtk/Skipped: skipped fast/events/event-creation.html. * platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: Reset expected results after r98199. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98234 => 98235) --- trunk/LayoutTests/ChangeLog 2011-10-24 12:23:11 UTC (rev 98234) +++ trunk/LayoutTests/ChangeLog 2011-10-24 12:52:45 UTC (rev 98235) @@ -1,3 +1,12 @@ +2011-10-24 Alejandro G. Castro + +Unreviewed, skip failing test in GTK, added bug 70720. Rebaseline +prototype-inheritance-2.html. + +* platform/gtk/Skipped: skipped fast/events/event-creation.html. +* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt: +Reset expected results after r98199. + 2011-10-21 Alexander Pavlov Web Inspector: Audits hang on pages without img[src] elements Modified: trunk/LayoutTests/platform/gtk/Skipped (98234 => 98235) --- trunk/LayoutTests/platform/gtk/Skipped 2011-10-24 12:23:11 UTC (rev 98234) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-10-24 12:52:45 UTC (rev 98235) @@ -1653,3 +1653,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=70606 # Missing DRT AccessibilityController::addNotificationListener implementation accessibility/menu-list-sends-change-notification.html + +# https://bugs.webkit.org/show_bug.cgi?id=70720 +# [GTK] fast/events/event-creation.html fails creating MediaStreamEvent +fast/events/event-creation.html Modified: trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt (98234 => 98235) --- trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt 2011-10-24 12:23:11 UTC (rev 98234) +++ trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt 2011-10-24 12:52:45 UTC (rev 98235) @@ -168,26 +168,26 @@ PASS MediaListPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.media.__proto__ PASS MemoryInfo from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory PASS MemoryInfoPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory.__proto__ -PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0 -PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes -PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.constructor -PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.__proto__ -PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.constructor -PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.__proto__ +PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0 +PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes +PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.constructor +PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.__proto__ +PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.constructor +PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.__proto__ PASS NamedNodeMap from inner.document.forms.testForm.0.parentNode.attributes -PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation -PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.__proto__ +PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator +PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.__proto__ PASS NodeList from inner.document.forms.testForm PASS NodeListConstructor from inner.document.forms.testForm.constructor PASS NodeListPrototype from inner.document.forms.testForm.__proto__ -PASS NodePrototype from inner.document.forms.testForm.0.attributes.0.__proto__.__proto__ +PASS NodePrototype from inner.document.forms.testForm.0.ownerDocument.__proto__.__proto__.__proto__ PASS Object from inner.document.location.__proto__.__proto__ -PASS Plugin from inner.document.forms.testForm.0.owne
[webkit-changes] [98234] trunk/Source/WebKit/chromium
Title: [98234] trunk/Source/WebKit/chromium
Revision 98234
Author commit-qu...@webkit.org
Date 2011-10-24 05:23:11 -0700 (Mon, 24 Oct 2011)
Log Message
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot on 2011-10-24
* DEPS:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98233 => 98234)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 12:08:39 UTC (rev 98233)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-24 12:23:11 UTC (rev 98234)
@@ -1,3 +1,9 @@
+2011-10-24 Sheriff Bot
+
+Unreviewed. Rolled DEPS.
+
+* DEPS:
+
2011-10-21 Nat Duca
[chromium] Make setVisibility extension- and thread-correct
Modified: trunk/Source/WebKit/chromium/DEPS (98233 => 98234)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-24 12:08:39 UTC (rev 98233)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-24 12:23:11 UTC (rev 98234)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '106670'
+ 'chromium_rev': '106896'
}
deps = {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98233] trunk/Source/WebCore
Title: [98233] trunk/Source/WebCore
Revision 98233
Author ca...@chromium.org
Date 2011-10-24 05:08:39 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: add "Add to Watch" option to context menu on selection in source frame
https://bugs.webkit.org/show_bug.cgi?id=69924
Reviewed by Pavel Feldman.
- added 'Add to Watch' context menu item in scripts panel;
- include both default and custom items into a context menu if selection is present;
* inspector/front-end/ScriptsPanel.js:
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
(WebInspector.SourceFrameDelegate.prototype.addToWatch):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._contextMenu):
(WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
(WebInspector.WatchExpressionsSection.prototype.addExpression):
(WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenu):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js
trunk/Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js
trunk/Source/WebCore/page/ContextMenuController.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98232 => 98233)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 11:04:55 UTC (rev 98232)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 12:08:39 UTC (rev 98233)
@@ -1,3 +1,32 @@
+2011-10-17 Andrey Kosyakov
+
+Web Inspector: add "Add to Watch" option to context menu on selection in source frame
+https://bugs.webkit.org/show_bug.cgi?id=69924
+
+Reviewed by Pavel Feldman.
+
+- added 'Add to Watch' context menu item in scripts panel;
+- include both default and custom items into a context menu if selection is present;
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
+(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.addToWatch):
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame.prototype.populateSelectionContextMenu):
+(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateSelectionContextMenu):
+(WebInspector.SourceFrameDelegate.prototype.suggestedFileName):
+(WebInspector.SourceFrameDelegate.prototype.addToWatch):
+* inspector/front-end/TextViewer.js:
+(WebInspector.TextViewer.prototype._contextMenu):
+(WebInspector.TextViewerDelegate.prototype.populateSelectionContextMenu):
+* inspector/front-end/WatchExpressionsSidebarPane.js:
+(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
+(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):
+(WebInspector.WatchExpressionsSection.prototype.addExpression):
+(WebInspector.WatchExpressionsSection.prototype.addNewExpressionAndEdit):
+* page/ContextMenuController.cpp:
+(WebCore::ContextMenuController::showContextMenu):
+
2011-10-21 Alexander Pavlov
Web Inspector: Audits hang on pages without img[src] elements
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (98232 => 98233)
--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2011-10-24 11:04:55 UTC (rev 98232)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js 2011-10-24 12:08:39 UTC (rev 98233)
@@ -121,6 +121,14 @@
container.appendChild(tokens[i]);
parentElement.insertBefore(container, nextElement);
return container;
+},
+
+populateTextAreaContextMenu: function(contextMenu)
+{
+var selection = window.getSelection();
+if (selection.type !== "Range" || selection.isCollapsed)
+return;
+contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Add to watch" : "Add to Watch"), this._delegate.addToWatch.bind(this._delegate, selection.toString()));
}
}
Modified: trunk/Source/WebCore/inspector/front-end/S
[webkit-changes] [98232] trunk
Title: [98232] trunk
Revision 98232
Author apav...@chromium.org
Date 2011-10-24 04:04:55 -0700 (Mon, 24 Oct 2011)
Log Message
Web Inspector: Audits hang on pages without img[src] elements
https://bugs.webkit.org/show_bug.cgi?id=70604
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/audits/audits-panel-noimages-functional.html
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
LayoutTests:
* inspector/audits/audits-panel-noimages-functional-expected.txt: Added.
* inspector/audits/audits-panel-noimages-functional.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AuditRules.js
Added Paths
trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt
trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98231 => 98232)
--- trunk/LayoutTests/ChangeLog 2011-10-24 10:29:26 UTC (rev 98231)
+++ trunk/LayoutTests/ChangeLog 2011-10-24 11:04:55 UTC (rev 98232)
@@ -1,3 +1,13 @@
+2011-10-21 Alexander Pavlov
+
+Web Inspector: Audits hang on pages without img[src] elements
+https://bugs.webkit.org/show_bug.cgi?id=70604
+
+Reviewed by Pavel Feldman.
+
+* inspector/audits/audits-panel-noimages-functional-expected.txt: Added.
+* inspector/audits/audits-panel-noimages-functional.html: Added.
+
2011-10-24 Deepak Sherveghar
[Qt] fast/events/media-focus-in-standalone-media-document.html fails
Added: trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt (0 => 98232)
--- trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt (rev 0)
+++ trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt 2011-10-24 11:04:55 UTC (rev 98232)
@@ -0,0 +1,33 @@
+Tests audit rules on a page without images.
+Page reloaded.
+ Network Utilization
+Combine external _javascript_ (4)
+ There are multiple resources served from same domain. Consider combining them into as few files as possible.
+ 4 _javascript_ resources served from [domain].
+ Web Page Performance
+Optimize the order of styles and scripts (2)
+ The following external CSS files were included after an external _javascript_ file in the document head. To ensure CSS files are downloaded in parallel, always include external CSS before external _javascript_.
+ audits-style1.css
+ 1 inline script block was found in the head between an external CSS file and another resource. To allow parallel downloading, move the inline script before the external CSS file, or after the next resource.
+Put CSS in the document head (2)
+ CSS in the document body adversely impacts rendering performance.
+ 1 style block(s) in the
+ audits-panel-noimages-functional.html
+ body should be moved to the document head.
+ Link node
+ audits-style1.css
+ should be moved to the document head in
+ audits-panel-noimages-functional.html
+Remove unused CSS rules (4)
+ 141B (100%) of CSS is not used by the current page.
+ Inline block #1: 29B (100%) is not used by the current page.
+ .unused
+ audits-style1.css
+ : 43B (100%) is not used by the current page.
+ .some-style
+ Inline block #2: 26B (100%) is not used by the current page.
+ .violation
+ audits-style1.css
+ : 43B (100%) is not used by the current page.
+ .some-style
+
Property changes on: trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional.html (0 => 98232)
--- trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional.html (rev 0)
+++ trunk/LayoutTests/inspector/audits/audits-panel-noimages-functional.html 2011-10-24 11:04:55 UTC (rev 98232)
@@ -0,0 +1,54 @@
+
+
+
+
+.unused {
+color: green;
+}
+
+
+JSON = {};
+
+
+