[webkit-changes] [98700] trunk/Source
Title: [98700] trunk/Source Revision 98700 Author nd...@chromium.org Date 2011-10-27 23:50:19 -0700 (Thu, 27 Oct 2011) Log Message [chromium] Implement frame rate control portions of CCScheduler https://bugs.webkit.org/show_bug.cgi?id=70713 Reviewed by James Robinson. Source/WebCore: * WebCore.gypi: * platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added. (WebCore::CCDelayBasedTimeSource::setActive): (WebCore::CCDelayBasedTimeSource::postTickTask): (WebCore::CCDelayBasedTimeSource::onTick): * platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added. (WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource): (WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource): (WebCore::CCDelayBasedTimeSource::setClient): (WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime): * platform/graphics/chromium/cc/CCFrameRateController.cpp: Added. (WebCore::CCFrameRateControllerTimeSourceAdapter::create): (WebCore::CCFrameRateControllerTimeSourceAdapter::~CCFrameRateControllerTimeSourceAdapter): (WebCore::CCFrameRateControllerTimeSourceAdapter::onTimerTick): (WebCore::CCFrameRateControllerTimeSourceAdapter::CCFrameRateControllerTimeSourceAdapter): (WebCore::CCFrameRateController::CCFrameRateController): (WebCore::CCFrameRateController::~CCFrameRateController): (WebCore::CCFrameRateController::onTimerTick): (WebCore::CCFrameRateController::didBeginFrame): (WebCore::CCFrameRateController::didFinishFrame): (WebCore::CCFrameRateController::didAbortAllPendingFrames): * platform/graphics/chromium/cc/CCFrameRateController.h: Added. (WebCore::CCFrameRateControllerClient::~CCFrameRateControllerClient): (WebCore::CCFrameRateController::setClient): (WebCore::CCFrameRateController::setActive): * platform/graphics/chromium/cc/CCTimeSource.h: Added. (WebCore::CCTimeSourceClient::~CCTimeSourceClient): (WebCore::CCTimeSource::~CCTimeSource): Source/WebKit/chromium: * WebKit.gypi: * tests/CCDelayBasedTimeSourceTest.cpp: Added. (WebKitTests::TEST): * tests/CCFrameRateControllerTest.cpp: Added. (WebKitTests::FakeCCFrameRateControllerClient::FakeCCFrameRateControllerClient): (WebKitTests::FakeCCFrameRateControllerClient::reset): (WebKitTests::FakeCCFrameRateControllerClient::frameBegun): (WebKitTests::FakeCCFrameRateControllerClient::beginFrame): (WebKitTests::TEST): * tests/CCLayerTreeHostTest.cpp: * tests/CCSchedulerTestCommon.h: Added. (WebKitTests::FakeCCTimeSourceClient::FakeCCTimeSourceClient): (WebKitTests::FakeCCTimeSourceClient::reset): (WebKitTests::FakeCCTimeSourceClient::tickCalled): (WebKitTests::FakeCCTimeSourceClient::onTimerTick): (WebKitTests::FakeCCThread::FakeCCThread): (WebKitTests::FakeCCThread::reset): (WebKitTests::FakeCCThread::hasPendingTask): (WebKitTests::FakeCCThread::runPendingTask): (WebKitTests::FakeCCThread::pendingDelay): (WebKitTests::FakeCCThread::postTask): (WebKitTests::FakeCCThread::postDelayedTask): (WebKitTests::FakeCCThread::threadID): (WebKitTests::FakeCCDelayBasedTimeSource::FakeCCDelayBasedTimeSource): (WebKitTests::FakeCCDelayBasedTimeSource::setMonotonicallyIncreasingTime): (WebKitTests::FakeCCDelayBasedTimeSource::monotonicallyIncreasingTime): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gypi trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp Added Paths trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCTimeSource.h trunk/Source/WebKit/chromium/tests/CCDelayBasedTimeSourceTest.cpp trunk/Source/WebKit/chromium/tests/CCFrameRateControllerTest.cpp trunk/Source/WebKit/chromium/tests/CCSchedulerTestCommon.h Diff Modified: trunk/Source/WebCore/ChangeLog (98699 => 98700) --- trunk/Source/WebCore/ChangeLog 2011-10-28 06:44:54 UTC (rev 98699) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 06:50:19 UTC (rev 98700) @@ -1,3 +1,39 @@ +2011-10-26 Nat Duca + +[chromium] Implement frame rate control portions of CCScheduler +https://bugs.webkit.org/show_bug.cgi?id=70713 + +Reviewed by James Robinson. + +* WebCore.gypi: +* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Added. +(WebCore::CCDelayBasedTimeSource::setActive): +(WebCore::CCDelayBasedTimeSource::postTickTask): +(WebCore::CCDelayBasedTimeSource::onTick): +* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Added. +(WebCore::CCDelayBasedTimeSource::CCDelayBasedTimeSource): +(WebCore::CCDelayBasedTimeSource::~CCDelayBasedTimeSource): +(WebCore::CCDelayBasedTimeSource::setClient): +(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime): +* platform/graph
[webkit-changes] [98699] trunk
Title: [98699] trunk Revision 98699 Author commit-qu...@webkit.org Date 2011-10-27 23:44:54 -0700 (Thu, 27 Oct 2011) Log Message [GTK] Create .xz tarballs during distcheck https://bugs.webkit.org/show_bug.cgi?id=71001 Patch by Priit Laes on 2011-10-27 Reviewed by Martin Robinson. * configure.ac: Switched tarballs to use .xz compression. Modified Paths trunk/ChangeLog trunk/configure.ac Diff Modified: trunk/ChangeLog (98698 => 98699) --- trunk/ChangeLog 2011-10-28 06:26:07 UTC (rev 98698) +++ trunk/ChangeLog 2011-10-28 06:44:54 UTC (rev 98699) @@ -1,3 +1,12 @@ +2011-10-27 Priit Laes + +[GTK] Create .xz tarballs during distcheck +https://bugs.webkit.org/show_bug.cgi?id=71001 + +Reviewed by Martin Robinson. + +* configure.ac: Switched tarballs to use .xz compression. + 2011-10-27 Daniel Bates CMake: Add support to optionally install the built _javascript_ shell Modified: trunk/configure.ac (98698 => 98699) --- trunk/configure.ac 2011-10-28 06:26:07 UTC (rev 98698) +++ trunk/configure.ac 2011-10-28 06:44:54 UTC (rev 98699) @@ -38,7 +38,7 @@ LIBWEBKITGTK_VERSION=11:1:11 AC_SUBST([LIBWEBKITGTK_VERSION]) -AM_INIT_AUTOMAKE([foreign subdir-objects tar-ustar]) +AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar]) # Use AM_SILENT_RULES if present m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98698] trunk/LayoutTests
Title: [98698] trunk/LayoutTests Revision 98698 Author rn...@webkit.org Date 2011-10-27 23:26:07 -0700 (Thu, 27 Oct 2011) Log Message Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because it passes on my Mac. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98697 => 98698) --- trunk/LayoutTests/ChangeLog 2011-10-28 06:18:02 UTC (rev 98697) +++ trunk/LayoutTests/ChangeLog 2011-10-28 06:26:07 UTC (rev 98698) @@ -1,5 +1,11 @@ 2011-10-27 Ryosuke Niwa + Unskip platform/mac/editing/deleting/backward-delete.html on Chromium because it passes on my Mac. + +* platform/chromium/test_expectations.txt: + +2011-10-27 Ryosuke Niwa + Group editing test expectations for Chromium in one place. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98697 => 98698) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 06:18:02 UTC (rev 98697) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 06:26:07 UTC (rev 98698) @@ -300,7 +300,7 @@ // This is a Safari specific test to make WebKit behave like AppKit on the Mac. // We do not support it because PLATFORM(MAC) is not defined for the mac version. -WONTFIX SKIP : platform/mac/editing/deleting/backward-delete.html = TEXT +WONTFIX : platform/mac/editing/deleting/backward-delete.html = TEXT // Ignored because we do not have OBJC bindings WONTFIX SKIP : editing/pasteboard/paste-RTFD.html = FAIL ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98697] trunk/LayoutTests
Title: [98697] trunk/LayoutTests Revision 98697 Author rn...@webkit.org Date 2011-10-27 23:18:02 -0700 (Thu, 27 Oct 2011) Log Message Group editing test expectations for Chromium in one place. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98696 => 98697) --- trunk/LayoutTests/ChangeLog 2011-10-28 06:06:57 UTC (rev 98696) +++ trunk/LayoutTests/ChangeLog 2011-10-28 06:18:02 UTC (rev 98697) @@ -1,5 +1,11 @@ 2011-10-27 Ryosuke Niwa +Group editing test expectations for Chromium in one place. + +* platform/chromium/test_expectations.txt: + +2011-10-27 Ryosuke Niwa + Chromium Mac rebaselines. * platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98696 => 98697) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 06:06:57 UTC (rev 98696) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 06:18:02 UTC (rev 98697) @@ -701,7 +701,39 @@ // Low priority, unclear if test expectations are correct (see bug) BUGCR6139 LINUX WIN : fast/forms/select-writing-direction-natural.html = IMAGE+TEXT BUGCR6139 LEOPARD : fast/forms/select-writing-direction-natural.html = IMAGE+TEXT +BUGCR64733 : editing/text-iterator/findString.html = TEXT +// Selection is wrong. +BUGCR64938 : editing/selection/5354455-1.html = TEXT + +BUGWK55560 : editing/input/setting-input-value-cancel-ime-composition.html = TEXT + +// New test added in r82159 +BUGCR77706 : editing/spelling/grammar.html = FAIL + +// Flaky +BUGCR79854 : editing/execCommand/delete-empty-container.html = PASS TEXT + +// pulled in from downstream during webkit roll 84350:84431 +BUGCASEQ LINUX WIN : editing/selection/select-from-textfield-outwards.html = IMAGE+TEXT + +BUGWK60120 DEBUG : editing/execCommand/append-node-under-document.html = PASS TEXT + +BUGWK59642 WIN : editing/input/scroll-viewport-page-up-down.html = PASS TEXT + +BUGWK61611 LINUX WIN : editing/pasteboard/interchange-newline-2.html = TEXT + +BUGWK61624 WIN : editing/pasteboard/smart-paste-003.html = TEXT +BUGWK61624 WIN : editing/pasteboard/smart-paste-004.html = TEXT + +// New test in r93068 +BUGWK66268 MAC CPU-CG : editing/deleting/regional-indicators.html = TEXT +BUGWK66268 WIN LINUX : editing/deleting/regional-indicators.html = TEXT + +BUGWK67121 DEBUG SLOW : editing/selection/move-by-word-visually-multi-space.html = PASS + +BUGWK63509 : editing/style/smoosh-styles-003.html = PASS IMAGE + // - // Plugin tests // - @@ -2497,8 +2529,6 @@ BUGCR64672 : fast/regex/invalid-range-in-class.html = TEXT -BUGCR64733 : editing/text-iterator/findString.html = TEXT - // FIXME: Need to add tooling support for V8 bugs. BUGV8_953 : fast/regex/pcre-test-1.html = TIMEOUT @@ -2506,9 +2536,6 @@ BUGWK50282 LINUX WIN : fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html = IMAGE+TEXT BUGWK50282 LINUX WIN : fast/images/imagemap-focus-ring-outline-color.html = IMAGE+TEXT -// Selection is wrong. -BUGCR64938 : editing/selection/5354455-1.html = TEXT - // Regressed at r73423. All areas are painted green. BUGWK50734 LINUX WIN : fast/repaint/positioned-document-element.html = IMAGE BUGWK50734 LEOPARD : fast/repaint/positioned-document-element.html = IMAGE @@ -2863,8 +2890,6 @@ BUGWK55300 : fast/images/support-broken-image-delegate.html = TEXT -BUGWK55560 : editing/input/setting-input-value-cancel-ime-composition.html = TEXT - BUGCR74710 LINUX MAC : svg/text/font-size-below-point-five.svg = PASS TEXT IMAGE IMAGE+TEXT BUGCR74766 WIN DEBUG : http/tests/security/_javascript_URL/xss-ALLOWED-from-_javascript_-url-sub-frame-to-_javascript_-url-sub-frame.html = PASS CRASH @@ -2971,9 +2996,6 @@ BUGWK57302 LEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE IMAGE+TEXT BUGWK57302 LEOPARD : fast/text/international/text-combine-image-test.html = IMAGE IMAGE+TEXT -// New test added in r82159 -BUGCR77706 : editing/spelling/grammar.html = FAIL - // New test added in r82152 and test expectation updated in r82189. BUGCR77734 : http/tests/uri/username-with-no-hostname.html = TEXT @@ -3050,9 +3072,6 @@ // Flaky, possibly timing related. BUGCR79853 : animations/combo-transform-translate+scale.html = PASS TEXT -// Flaky -BUGCR79854 : editing/execCommand/delete-empty-container.html = PASS TEXT - // Flaky on debug BUGCR79855 LINUX WIN DEBUG : fast/css/only-child-pseudo-class.html = PASS TEXT @@ -3090,7 +3109,6 @@ BUGDPRANKE LINUX WIN : animations/change-one-anim.html = PASS TEXT // pulled in from downstream during webkit roll 84350:84431 -BUGCASEQ LINUX WIN : editing/selection/select-from-textfield-outwards.html = IMAGE+TEXT B
[webkit-changes] [98696] trunk/LayoutTests
Title: [98696] trunk/LayoutTests Revision 98696 Author rn...@webkit.org Date 2011-10-27 23:06:57 -0700 (Thu, 27 Oct 2011) Log Message Chromium Mac rebaselines. * platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png: * platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png: * platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png: * platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png: * platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png: * platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png: * platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/4944770-1-expected.png: * platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png: * platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png: * platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png: * platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png: * platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-before-expected.png: * platform/chromium-cg-mac-leopard/fast/dom/blur-contenteditable-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/deleting/table-cells-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/execCommand/create-list-with-hr-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/execCommand/find-after-replace-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-1-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/execCommand/paste-2-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/inserting/4278698-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-in-table-2-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/3976872-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-2-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-3-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/4076267-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/pasteboard/undoable-fragment-removes-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/selection/select-all-iframe-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/undo: Added. * platform/chromium-cg-mac-snowleopard/editing/undo/4063751-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/unsupported-content: Added. * platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-after-expected.png: Added. * platform/chromium-cg-mac-snowleopard/editing/unsupported-content/table-type-before-expected.png: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/deleting/table-cells-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/create-list-with-hr-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/find-after-replace-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/paste-1-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/execCommand/paste-2-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/inserting/4278698-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-in-table-2-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/3976872-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-2-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-3-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/4076267-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/4944770-1-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/pasteboard/undoable-fragment-removes-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/selection/select-all-iframe-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/undo/4063751-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/editing/unsupported-content/table-type-after-expected.png
[webkit-changes] [98695] trunk/Source/WebCore
Title: [98695] trunk/Source/WebCore Revision 98695 Author hara...@chromium.org Date 2011-10-27 22:52:58 -0700 (Thu, 27 Oct 2011) Log Message Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL https://bugs.webkit.org/show_bug.cgi?id=71088 Reviewed by Adam Barth. I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536, but I found that it has the same meaning as [ActiveDOMObject] IDL. This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL. No change in behavior. Tests: fast/dom/global-constructors.html fast/eventsource/eventsource-constructor.html fast/eventsource/eventsource-attribute-listeners.html fast/files/blob-slice-test.html fast/files/file-reader-abort.html ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor ui_tests:WorkerTest.FLAKY_SharedWorkerFastName ui_tests:WorkerTest.FLAKY_WorkerConstructor ui_tests:WorkerTest.FLAKY_WorkerEventListener * bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActiveDOMWrapper" with "ActiveDOMObject". (GenerateConstructorCallback): * bindings/scripts/test/TestInterface.idl: Ditto. * bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result. (WebCore::isObservable): (WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots): (WebCore::JSTestInterfaceOwner::finalize): * bindings/scripts/test/JS/JSTestInterface.h: Ditto. (WebCore::wrapperOwner): (WebCore::wrapperContext): * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto. * bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto. * bindings/scripts/test/JS/JSTestObj.cpp: Ditto. * bindings/scripts/test/JS/JSTestObj.h: Ditto. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto. * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto. * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto. (WebCore::V8TestInterface::toActiveDOMObject): (WebCore::V8TestInterface::wrapSlow): * bindings/scripts/test/V8/V8TestInterface.h: Ditto. (WebCore::V8TestInterface::existingWrapper): * fileapi/FileReader.idl: Removed [V8ConstructorSetsActiveDOMWrapper] IDL. * mediastream/PeerConnection.idl: Ditto. * page/EventSource.idl: Ditto. * workers/SharedWorker.idl: Ditto. * workers/Worker.idl: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.h trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/V8/V8TestInterface.h trunk/Source/WebCore/fileapi/FileReader.idl trunk/Source/WebCore/mediastream/PeerConnection.idl trunk/Source/WebCore/page/EventSource.idl trunk/Source/WebCore/workers/SharedWorker.idl trunk/Source/WebCore/workers/Worker.idl Diff Modified: trunk/Source/WebCore/ChangeLog (98694 => 98695) --- trunk/Source/WebCore/ChangeLog 2011-10-28 05:39:15 UTC (rev 98694) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 05:52:58 UTC (rev 98695) @@ -1,3 +1,53 @@ +2011-10-27 Kentaro Hara + +Deprecate [V8ConstructorSetsActiveDOMWrapper] IDL +https://bugs.webkit.org/show_bug.cgi?id=71088 + +Reviewed by Adam Barth. + +I introduced [V8ConstructorSetsActiveDOMWrapper] IDL in bug 66536, +but I found that it has the same meaning as [ActiveDOMObject] IDL. +This patch removes [V8ConstructorSetsActiveDOMWrapper] IDL. + +No change in behavior. + +Tests: fast/dom/global-constructors.html + fast/eventsource/eventsource-constructor.html + fast/eventsource/eventsource-attribute-listeners.html + fast/files/blob-slice-test.html + fast/files/file-reader-abort.html + ui_tests:WorkerTest.FLAKY_SharedWorkerFastConstructor + ui_tests:WorkerTest.FLAKY_SharedWorkerFastName + ui_tests:WorkerTest.FLAKY_WorkerConstructor + ui_tests:WorkerTest.FLAKY_WorkerEventListener + +* bindings/scripts/CodeGeneratorV8.pm: Replaced "V8ConstructorSetsActiveDOMWrapper" with "ActiveDOMObject". +(GenerateConstructorCallback): +* bindings/scripts/test/TestInterface.idl: Ditto. +* bindings/scripts/test/JS/JSTestInterface.cpp: Updated a test result. +(WebCore::isObservable): +(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots): +(WebCore::JSTestInterfaceOwner::finalize): +* bindings/scripts/test/JS/JSTestInterface.h: Ditto. +(WebCore::wrapperOwner): +(WebCore::wrapperContext): +* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto. +* bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto. +* bindings/scripts/test/JS/JSTestObj.cpp: Ditto. +* bindings/scripts/test/JS/JSTestObj.h: Ditto. +* bindings/script
[webkit-changes] [98694] trunk/Source/WebCore
Title: [98694] trunk/Source/WebCore
Revision 98694
Author yu...@chromium.org
Date 2011-10-27 22:39:15 -0700 (Thu, 27 Oct 2011)
Log Message
Race condition in SocketStreamHandleCFNet when PAC script is used
https://bugs.webkit.org/show_bug.cgi?id=70894
Reviewed by Alexey Proskuryakov.
Pass callback functions that call ref() or deref() as retain/release member
of CFStreamClientContext.
No new tests, as it is not possible to write a test with PAC script enabled.
* platform/network/cf/SocketStreamHandle.h:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::scheduleStreams):
(WebCore::SocketStreamHandle::retainSocketStreamHandle):
(WebCore::SocketStreamHandle::releaseSocketStreamHandle):
(WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
This callback may be called after platformClose() is already called. We should
not create new streams in this case.
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::readStreamCallback):
This manual ref/deref can be safely removed as m_readStream holds the reference.
(WebCore::SocketStreamHandle::writeStreamCallback):
Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/SocketStreamHandle.h
trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98693 => 98694)
--- trunk/Source/WebCore/ChangeLog 2011-10-28 05:39:13 UTC (rev 98693)
+++ trunk/Source/WebCore/ChangeLog 2011-10-28 05:39:15 UTC (rev 98694)
@@ -1,3 +1,29 @@
+2011-10-28 Yuta Kitamura
+
+Race condition in SocketStreamHandleCFNet when PAC script is used
+https://bugs.webkit.org/show_bug.cgi?id=70894
+
+Reviewed by Alexey Proskuryakov.
+
+Pass callback functions that call ref() or deref() as retain/release member
+of CFStreamClientContext.
+
+No new tests, as it is not possible to write a test with PAC script enabled.
+
+* platform/network/cf/SocketStreamHandle.h:
+* platform/network/cf/SocketStreamHandleCFNet.cpp:
+(WebCore::SocketStreamHandle::scheduleStreams):
+(WebCore::SocketStreamHandle::retainSocketStreamHandle):
+(WebCore::SocketStreamHandle::releaseSocketStreamHandle):
+(WebCore::SocketStreamHandle::pacExecutionCallbackMainThread):
+This callback may be called after platformClose() is already called. We should
+not create new streams in this case.
+(WebCore::SocketStreamHandle::executePACFileURL):
+(WebCore::SocketStreamHandle::readStreamCallback):
+This manual ref/deref can be safely removed as m_readStream holds the reference.
+(WebCore::SocketStreamHandle::writeStreamCallback):
+Ditto.
+
2011-10-27 Arthur Hsu
Reland patch ensure font load before calling Skia during printing
Modified: trunk/Source/WebCore/platform/network/cf/SocketStreamHandle.h (98693 => 98694)
--- trunk/Source/WebCore/platform/network/cf/SocketStreamHandle.h 2011-10-28 05:39:13 UTC (rev 98693)
+++ trunk/Source/WebCore/platform/network/cf/SocketStreamHandle.h 2011-10-28 05:39:15 UTC (rev 98694)
@@ -74,7 +74,9 @@
void addCONNECTCredentials(CFHTTPMessageRef response);
-static CFStringRef copyCFStreamDescription(void* );
+static void* retainSocketStreamHandle(void*);
+static void releaseSocketStreamHandle(void*);
+static CFStringRef copyCFStreamDescription(void*);
static void readStreamCallback(CFReadStreamRef, CFStreamEventType, void*);
static void writeStreamCallback(CFWriteStreamRef, CFStreamEventType, void*);
#if PLATFORM(WIN)
Modified: trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp (98693 => 98694)
--- trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp 2011-10-28 05:39:13 UTC (rev 98693)
+++ trunk/Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp 2011-10-28 05:39:15 UTC (rev 98694)
@@ -82,7 +82,7 @@
ASSERT(m_readStream);
ASSERT(m_writeStream);
-CFStreamClientContext clientContext = { 0, this, 0, 0, copyCFStreamDescription };
+CFStreamClientContext clientContext = { 0, this, retainSocketStreamHandle, releaseSocketStreamHandle, copyCFStreamDescription };
// FIXME: Pass specific events we're interested in instead of -1.
CFReadStreamSetClient(m_readStream.get(), static_cast(-1), readStreamCallback, &clientContext);
CFWriteStreamSetClient(m_writeStream.get(), static_cast(-1), writeStreamCallback, &clientContext);
@@ -104,6 +104,19 @@
m_connectingSubstate = WaitingForConnect;
}
+void* SocketStreamHandle::retainSocketStreamHandle(void* info)
+{
+SocketStreamHandle* handle = static_cast(info);
+handle->ref();
+return handle;
+}
+
+void SocketStreamHandle::releaseSocketStreamHandle(void* info)
+{
+SocketStreamHandle* handle = static_cast(info);
+handle->deref();
+}
+
CFStringRef SocketStreamHandle::copyPACExecutionDescription(void*)
{
[webkit-changes] [98693] trunk/Tools
Title: [98693] trunk/Tools Revision 98693 Author yu...@chromium.org Date 2011-10-27 22:39:13 -0700 (Thu, 27 Oct 2011) Log Message WebSocket: Connecting to localhost:8880 takes one second on Windows https://bugs.webkit.org/show_bug.cgi?id=64788 Reviewed by Dirk Pranke. * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html from timing out on Windows, because this test tries to open a lot of connections to localhost and each attempt takes one second to fall back from IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though). Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py Diff Modified: trunk/Tools/ChangeLog (98692 => 98693) --- trunk/Tools/ChangeLog 2011-10-28 05:37:32 UTC (rev 98692) +++ trunk/Tools/ChangeLog 2011-10-28 05:39:13 UTC (rev 98693) @@ -1,3 +1,17 @@ +2011-10-27 Yuta Kitamura + +WebSocket: Connecting to localhost:8880 takes one second on Windows +https://bugs.webkit.org/show_bug.cgi?id=64788 + +Reviewed by Dirk Pranke. + +* Scripts/webkitpy/layout_tests/servers/websocket_server.py: +Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both +IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html +from timing out on Windows, because this test tries to open a lot of +connections to localhost and each attempt takes one second to fall back from +IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though). + 2011-10-27 Adam Barth Dis-integrate run-bindings-tests with webkitpy Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py (98692 => 98693) --- trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-28 05:37:32 UTC (rev 98692) +++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py 2011-10-28 05:39:13 UTC (rev 98693) @@ -117,7 +117,7 @@ pywebsocket_script = self._filesystem.join(pywebsocket_base, 'mod_pywebsocket', 'standalone.py') start_cmd = [ python_interp, '-u', pywebsocket_script, -'--server-host', '127.0.0.1', +'--server-host', 'localhost', '--port', str(self._port), # FIXME: Don't we have a self._port_obj.layout_test_path? '--document-root', self._filesystem.join(self._layout_tests, 'http', 'tests'), ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98692] trunk/Source/WebCore
Title: [98692] trunk/Source/WebCore Revision 98692 Author commit-qu...@webkit.org Date 2011-10-27 22:37:32 -0700 (Thu, 27 Oct 2011) Log Message Reland patch ensure font load before calling Skia during printing https://bugs.webkit.org/show_bug.cgi?id=70390 Patch by Arthur Hsu on 2011-10-27 Reviewed by James Robinson. * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): * platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98691 => 98692) --- trunk/Source/WebCore/ChangeLog 2011-10-28 05:22:35 UTC (rev 98691) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 05:37:32 UTC (rev 98692) @@ -1,3 +1,15 @@ +2011-10-27 Arthur Hsu + +Reland patch ensure font load before calling Skia during printing +https://bugs.webkit.org/show_bug.cgi?id=70390 + +Reviewed by James Robinson. + +* platform/graphics/chromium/FontChromiumWin.cpp: +(WebCore::Font::drawGlyphs): +* platform/graphics/skia/SkiaFontWin.cpp: +(WebCore::paintSkiaText): + 2011-10-27 Adam Barth Attempt to fix the Qt build. Modified: trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp (98691 => 98692) --- trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-28 05:22:35 UTC (rev 98691) +++ trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-28 05:37:32 UTC (rev 98692) @@ -395,7 +395,6 @@ return; HFONT hfont = font->platformData().hfont(); -PlatformSupport::ensureFontLoaded(hfont); // We draw the glyphs in chunks to avoid having to do a heap allocation for // the arrays of characters and advances. Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (98691 => 98692) --- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-28 05:22:35 UTC (rev 98691) +++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-28 05:37:32 UTC (rev 98692) @@ -33,9 +33,11 @@ #include "AffineTransform.h" #include "PlatformContextSkia.h" +#include "PlatformSupport.h" #include "Gradient.h" #include "Pattern.h" #include "SkCanvas.h" +#include "SkDevice.h" #include "SkPaint.h" #include "SkShader.h" #include "SkTemplates.h" @@ -236,6 +238,9 @@ PlatformContextSkia* platformContext = context->platformContext(); SkCanvas* canvas = platformContext->canvas(); TextDrawingModeFlags textMode = platformContext->getTextDrawingMode(); +// Ensure font load for printing, because PDF device needs it. +if (canvas->getTopDevice()->getDeviceCapabilities() & SkDevice::kVector_Capability) +PlatformSupport::ensureFontLoaded(hfont); // Filling (if necessary). This is the common case. SkPaint paint; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98691] trunk/LayoutTests
Title: [98691] trunk/LayoutTests Revision 98691 Author msab...@apple.com Date 2011-10-27 22:22:35 -0700 (Thu, 27 Oct 2011) Log Message Test Failure in fast/dom/prototype-inheritance-2.html after r98495 https://bugs.webkit.org/show_bug.cgi?id=71058 Rebaselined these results due to hash order changes in r98495. Reviewed by Darin Adler. * fast/dom/prototype-inheritance-2-expected.txt: * platform/mac/fast/dom/prototype-inheritance-2-expected.txt: * platform/qt/fast/dom/prototype-inheritance-2-expected.txt: * platform/win/fast/dom/prototype-inheritance-2-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt trunk/LayoutTests/platform/win/fast/dom/prototype-inheritance-2-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98690 => 98691) --- trunk/LayoutTests/ChangeLog 2011-10-28 05:11:31 UTC (rev 98690) +++ trunk/LayoutTests/ChangeLog 2011-10-28 05:22:35 UTC (rev 98691) @@ -1,3 +1,17 @@ +2011-10-27 Michael Saboff + +Test Failure in fast/dom/prototype-inheritance-2.html after r98495 +https://bugs.webkit.org/show_bug.cgi?id=71058 + +Rebaselined these results due to hash order changes in r98495. + +Reviewed by Darin Adler. + +* fast/dom/prototype-inheritance-2-expected.txt: +* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: +* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: +* platform/win/fast/dom/prototype-inheritance-2-expected.txt: + 2011-10-27 Ryosuke Niwa Remove erroneous expected results after r98685. Modified: trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt (98690 => 98691) --- trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt 2011-10-28 05:11:31 UTC (rev 98690) +++ trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt 2011-10-28 05:22:35 UTC (rev 98691) @@ -168,26 +168,26 @@ PASS MediaListPrototype from inner.document.forms.testForm.0.ownerDocument.styleSheets.0.media.__proto__ PASS MemoryInfo from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory PASS MemoryInfoPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.console.memory.__proto__ -PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0 -PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes -PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.constructor -PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.__proto__ -PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.constructor -PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.mimeTypes.0.__proto__ +PASS MimeType from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0 +PASS MimeTypeArray from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes +PASS MimeTypeArrayConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.constructor +PASS MimeTypeArrayPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.__proto__ +PASS MimeTypeConstructor from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.constructor +PASS MimeTypePrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.mimeTypes.0.__proto__ PASS NamedNodeMap from inner.document.forms.testForm.0.parentNode.attributes -PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator -PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.__proto__ +PASS Navigator from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation +PASS NavigatorPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.clientInformation.__proto__ PASS NodeList from inner.document.forms.testForm PASS NodeListConstructor from inner.document.forms.testForm.constructor PASS NodeListPrototype from inner.document.forms.testForm.__proto__ -PASS NodePrototype from inner.document.forms.testForm.0.ownerDocument.__proto__.__proto__.__proto__ +PASS NodePrototype from inner.document.forms.testForm.0.attributes.0.__proto__.__proto__ PASS Object from inner.document.location.__proto__.__proto__ -PASS Plugin from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins.5 -PASS PluginArray from inner.document.forms.testForm.0.ownerDocument.defaultView.navigator.plugins -PASS PluginArrayConstr
[webkit-changes] [98690] trunk/Source/WebCore
Title: [98690] trunk/Source/WebCore Revision 98690 Author aba...@webkit.org Date 2011-10-27 22:11:31 -0700 (Thu, 27 Oct 2011) Log Message Attempt to fix the Qt build. * WebCore.pro: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.pro Diff Modified: trunk/Source/WebCore/ChangeLog (98689 => 98690) --- trunk/Source/WebCore/ChangeLog 2011-10-28 05:10:10 UTC (rev 98689) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 05:11:31 UTC (rev 98690) @@ -1,3 +1,9 @@ +2011-10-27 Adam Barth + +Attempt to fix the Qt build. + +* WebCore.pro: + 2011-10-27 Ryosuke Niwa binding test rebaseline after r98679. Modified: trunk/Source/WebCore/WebCore.pro (98689 => 98690) --- trunk/Source/WebCore/WebCore.pro 2011-10-28 05:10:10 UTC (rev 98689) +++ trunk/Source/WebCore/WebCore.pro 2011-10-28 05:11:31 UTC (rev 98690) @@ -633,16 +633,36 @@ editing/WrapContentsInDummySpanCommand.cpp \ fileapi/Blob.cpp \ fileapi/BlobURL.cpp \ +fileapi/DOMFilePath.cpp \ +fileapi/DOMFileSystem.cpp \ +fileapi/DOMFileSystemBase.cpp \ +fileapi/DOMFileSystemSync.cpp \ +fileapi/DirectoryEntry.cpp \ +fileapi/DirectoryEntrySync.cpp \ +fileapi/DirectoryReader.cpp \ +fileapi/DirectoryReaderSync.cpp \ +fileapi/Entry.cpp \ +fileapi/EntryArray.cpp \ +fileapi/EntryArraySync.cpp \ +fileapi/EntryBase.cpp \ +fileapi/EntrySync.cpp \ fileapi/File.cpp \ +fileapi/FileEntry.cpp \ +fileapi/FileEntrySync.cpp \ fileapi/FileException.cpp \ fileapi/FileList.cpp \ fileapi/FileReader.cpp \ fileapi/FileReaderLoader.cpp \ fileapi/FileReaderSync.cpp \ fileapi/FileStreamProxy.cpp \ +fileapi/FileSystemCallbacks.cpp \ fileapi/FileThread.cpp \ -fileapi/FileException.cpp \ +fileapi/FileWriter.cpp \ +fileapi/FileWriterBase.cpp \ +fileapi/FileWriterSync.cpp \ +fileapi/LocalFileSystem.cpp \ fileapi/OperationNotAllowedException.cpp \ +fileapi/ThreadableBlobRegistry.cpp \ fileapi/WebKitBlobBuilder.cpp \ history/BackForwardController.cpp \ history/BackForwardListImpl.cpp \ @@ -2978,25 +2998,6 @@ bindings/js/JSDirectoryEntrySyncCustom.cpp \ bindings/js/JSEntryCustom.cpp \ bindings/js/JSEntrySyncCustom.cpp \ -fileapi/DirectoryEntry.cpp \ -fileapi/DirectoryEntrySync.cpp \ -fileapi/DirectoryReader.cpp \ -fileapi/DirectoryReaderSync.cpp \ -fileapi/DOMFilePath.cpp \ -fileapi/DOMFileSystem.cpp \ -fileapi/DOMFileSystemBase.cpp \ -fileapi/DOMFileSystemSync.cpp \ -fileapi/Entry.cpp \ -fileapi/EntryArray.cpp \ -fileapi/EntryArraySync.cpp \ -fileapi/EntrySync.cpp \ -fileapi/FileEntry.cpp \ -fileapi/FileEntrySync.cpp \ -fileapi/FileSystemCallbacks.cpp \ -fileapi/FileWriter.cpp \ -fileapi/FileWriterBase.cpp \ -fileapi/FileWriterSync.cpp \ -fileapi/LocalFileSystem.cpp \ platform/AsyncFileSystem.cpp } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98689] trunk/LayoutTests
Title: [98689] trunk/LayoutTests Revision 98689 Author rn...@webkit.org Date 2011-10-27 22:10:10 -0700 (Thu, 27 Oct 2011) Log Message Remove erroneous expected results after r98685. * platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png: Removed. * platform/chromium-win/editing/selection/click-before-and-after-table-expected.png: Removed. * platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt: Removed. * platform/qt/editing/selection/click-before-and-after-table-expected.png: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.png trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt trunk/LayoutTests/platform/qt/editing/selection/click-before-and-after-table-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98688 => 98689) --- trunk/LayoutTests/ChangeLog 2011-10-28 04:58:21 UTC (rev 98688) +++ trunk/LayoutTests/ChangeLog 2011-10-28 05:10:10 UTC (rev 98689) @@ -1,5 +1,14 @@ 2011-10-27 Ryosuke Niwa +Remove erroneous expected results after r98685. + +* platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png: Removed. +* platform/chromium-win/editing/selection/click-before-and-after-table-expected.png: Removed. +* platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt: Removed. +* platform/qt/editing/selection/click-before-and-after-table-expected.png: Removed. + +2011-10-27 Ryosuke Niwa + Fix click-before-and-after-table.html for Chromium https://bugs.webkit.org/show_bug.cgi?id=70869 Deleted: trunk/LayoutTests/platform/chromium-linux/editing/selection/click-before-and-after-table-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.png (Binary files differ) Deleted: trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt (98688 => 98689) --- trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt 2011-10-28 04:58:21 UTC (rev 98688) +++ trunk/LayoutTests/platform/chromium-win/editing/selection/click-before-and-after-table-expected.txt 2011-10-28 05:10:10 UTC (rev 98689) @@ -1 +0,0 @@ -This test isn't expected to pass. See test expectations. Deleted: trunk/LayoutTests/platform/qt/editing/selection/click-before-and-after-table-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98688] trunk/Source/WebCore
Title: [98688] trunk/Source/WebCore Revision 98688 Author rn...@webkit.org Date 2011-10-27 21:58:21 -0700 (Thu, 27 Oct 2011) Log Message binding test rebaseline after r98679. * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceConstructor::constructJSTestInterface): * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::setJSTestObjStringAttr): (WebCore::setJSTestObjStringAttrWithGetterException): (WebCore::setJSTestObjStringAttrWithSetterException): (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): (WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): (WebCore::jsTestObjPrototypeFunctionSerializedValue): (WebCore::jsTestObjPrototypeFunctionIdbKey): (WebCore::jsTestObjPrototypeFunctionOptionsObject): (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): (WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): (WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98687 => 98688) --- trunk/Source/WebCore/ChangeLog 2011-10-28 04:55:21 UTC (rev 98687) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 04:58:21 UTC (rev 98688) @@ -1,3 +1,40 @@ +2011-10-27 Ryosuke Niwa + +binding test rebaseline after r98679. + +* bindings/scripts/test/JS/JSTestInterface.cpp: +(WebCore::JSTestInterfaceConstructor::constructJSTestInterface): +* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: +(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): +* bindings/scripts/test/JS/JSTestObj.cpp: +(WebCore::setJSTestObjStringAttr): +(WebCore::setJSTestObjStringAttrWithGetterException): +(WebCore::setJSTestObjStringAttrWithSetterException): +(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): +(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): +(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): +(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs): +(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows): +(WebCore::jsTestObjPrototypeFunctionSerializedValue): +(WebCore::jsTestObjPrototypeFunctionIdbKey): +(WebCore::jsTestObjPrototypeFunctionOptionsObject): +(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): +(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): +(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): +(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): +(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): +(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg): +(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): +(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): +(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): +(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): +(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional): + 2011-10-27 Adam Barth Move type-specific exception descriptions into the implementation files for each type Modified: trunk/Source/Web
[webkit-changes] [98687] trunk/Tools
Title: [98687] trunk/Tools
Revision 98687
Author aba...@webkit.org
Date 2011-10-27 21:55:21 -0700 (Thu, 27 Oct 2011)
Log Message
Dis-integrate run-bindings-tests with webkitpy
https://bugs.webkit.org/show_bug.cgi?id=71092
Reviewed by Ryosuke Niwa.
These tests aren't really adding any value.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ports.py
trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py
trunk/Tools/Scripts/webkitpy/tool/mocktool.py
trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py
trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py
trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98686 => 98687)
--- trunk/Tools/ChangeLog 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/ChangeLog 2011-10-28 04:55:21 UTC (rev 98687)
@@ -1,3 +1,19 @@
+2011-10-27 Adam Barth
+
+Dis-integrate run-bindings-tests with webkitpy
+https://bugs.webkit.org/show_bug.cgi?id=71092
+
+Reviewed by Ryosuke Niwa.
+
+These tests aren't really adding any value.
+
+* Scripts/webkitpy/common/config/ports.py:
+* Scripts/webkitpy/tool/commands/download_unittest.py:
+* Scripts/webkitpy/tool/mocktool.py:
+* Scripts/webkitpy/tool/steps/runtests.py:
+* Scripts/webkitpy/tool/steps/runtests_unittest.py:
+* Scripts/webkitpy/tool/steps/steps_unittest.py:
+
2011-10-27 Eric Seidel
REGRESSION (r98639): NRWT crashes when parsing leaks output
Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -117,10 +117,6 @@
return cls.script_shell_command("test-webkitperl")
@classmethod
-def run_bindings_tests_command(cls):
-return cls.script_shell_command("run-bindings-tests")
-
-@classmethod
def layout_tests_results_path(cls):
return "/tmp/layout-test-results/results.html"
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (98686 => 98687)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-10-28 04:44:36 UTC (rev 98686)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2011-10-28 04:55:21 UTC (rev 98687)
@@ -89,7 +89,7 @@
self.assert_execute_outputs(Build(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_build_and_test(self):
-expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
+expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\n"
self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
def test_apply_attachment(self):
@@ -115,7 +115,7 @@
self.assert_execute_outputs(ApplyWatchList(), [1], options=self._default_options(), expected_stderr=expected_stderr, tool=MockTool(log_executive=True))
def test_land(self):
-expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: \nUpdating bug 5\n"
+expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning _javascript_Core tests\nRunning run-webkit-tests\nCommitted r49824: \nUpdating bug 5\n"
mock_tool = MockTool()
mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
mock_tool.checkout().modified_changelogs = Mock(return_value=[])
@@ -136,8 +136,6 @@
MOCK run_and_throw_if_fail: ['mock-test-webkitpy'], cwd=/mock-checkout
Running Perl unit tests
MOCK run_and_throw_if_fail: ['mock-test-webkitperl'], cwd=/mock-checkout
-Running Bindings tests
-MOCK run_and_throw_if_fail: ['mock-run-bindings-tests'], cwd=/mock-checkout
Running _javascript_Core tests
MOCK run_and_throw_if_fail: ['mock-run-javacriptcore-tests'], cwd=/mock-checkout
Running run-webkit-tests
@@ -150,7 +148,7 @@
self.assert_execute_outputs(LandCowboy(), [5], options=self._default_options(), expected_stderr=expected_stderr, tool=mock_tool)
def test_land_red_builders(self):
-expected_stderr = 'Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunn
[webkit-changes] [98685] trunk/LayoutTests
Title: [98685] trunk/LayoutTests Revision 98685 Author rn...@webkit.org Date 2011-10-27 21:24:35 -0700 (Thu, 27 Oct 2011) Log Message Fix click-before-and-after-table.html for Chromium https://bugs.webkit.org/show_bug.cgi?id=70869 Reviewed by Tony Chang. Fixed the test by wrapping tests in a function to avoid shadowing "top" variable. * editing/selection/click-before-and-after-table.html: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/editing/selection/click-before-and-after-table.html trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98684 => 98685) --- trunk/LayoutTests/ChangeLog 2011-10-28 03:50:15 UTC (rev 98684) +++ trunk/LayoutTests/ChangeLog 2011-10-28 04:24:35 UTC (rev 98685) @@ -1,3 +1,15 @@ +2011-10-27 Ryosuke Niwa + +Fix click-before-and-after-table.html for Chromium +https://bugs.webkit.org/show_bug.cgi?id=70869 + +Reviewed by Tony Chang. + +Fixed the test by wrapping tests in a function to avoid shadowing "top" variable. + +* editing/selection/click-before-and-after-table.html: +* platform/chromium/test_expectations.txt: + 2011-10-27 John Gregg Update chromium test expectations. Modified: trunk/LayoutTests/editing/selection/click-before-and-after-table.html (98684 => 98685) --- trunk/LayoutTests/editing/selection/click-before-and-after-table.html 2011-10-28 03:50:15 UTC (rev 98684) +++ trunk/LayoutTests/editing/selection/click-before-and-after-table.html 2011-10-28 04:24:35 UTC (rev 98685) @@ -1,7 +1,3 @@ - -if (window.layoutTestController) - layoutTestController.dumpEditingCallbacks(); -
[webkit-changes] [98684] trunk/Source/WebKit2
Title: [98684] trunk/Source/WebKit2 Revision 98684 Author mrobin...@webkit.org Date 2011-10-27 20:50:15 -0700 (Thu, 27 Oct 2011) Log Message Fix the GTK+ build after r98664. * WebProcess/Plugins/Plugin.h: Add an IntSize forward declaration. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h Diff Modified: trunk/Source/WebKit2/ChangeLog (98683 => 98684) --- trunk/Source/WebKit2/ChangeLog 2011-10-28 03:50:06 UTC (rev 98683) +++ trunk/Source/WebKit2/ChangeLog 2011-10-28 03:50:15 UTC (rev 98684) @@ -1,3 +1,9 @@ +2011-10-27 Martin Robinson + +Fix the GTK+ build after r98664. + +* WebProcess/Plugins/Plugin.h: Add an IntSize forward declaration. + 2011-10-27 Anders Carlsson Add a Plugin::geometryDidChange that will work with transforms Modified: trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h (98683 => 98684) --- trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2011-10-28 03:50:06 UTC (rev 98683) +++ trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h 2011-10-28 03:50:15 UTC (rev 98684) @@ -43,6 +43,7 @@ class AffineTransform; class GraphicsContext; class IntRect; +class IntSize; class Scrollbar; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98683] trunk/LayoutTests
Title: [98683] trunk/LayoutTests Revision 98683 Author john...@google.com Date 2011-10-27 20:50:06 -0700 (Thu, 27 Oct 2011) Log Message Update chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98682 => 98683) --- trunk/LayoutTests/ChangeLog 2011-10-28 03:47:02 UTC (rev 98682) +++ trunk/LayoutTests/ChangeLog 2011-10-28 03:50:06 UTC (rev 98683) @@ -1,5 +1,11 @@ 2011-10-27 John Gregg +Update chromium test expectations. + +* platform/chromium/test_expectations.txt: + +2011-10-27 John Gregg + Add more test expectations and chromium results. * platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98682 => 98683) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 03:47:02 UTC (rev 98682) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 03:50:06 UTC (rev 98683) @@ -3666,7 +3666,7 @@ BUGCR95972 WIN DEBUG : webaudio/sample-accurate-scheduling.html = CRASH // Failing after r94912. -BUGWK67913 : media/video-zoom-controls.html = TEXT IMAGE+TEXT +BUGWK67913 : media/video-zoom-controls.html = TEXT IMAGE+TEXT IMAGE BUGCR96220 : fast/borders/border-image-outset-split-inline-vertical-lr.html = IMAGE BUGCR96220 : fast/reflections/reflection-masks-outset.html = IMAGE BUGCR96220 WIN LINUX : fast/borders/block-mask-overlay-image-outset.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98682] trunk/Tools
Title: [98682] trunk/Tools Revision 98682 Author e...@webkit.org Date 2011-10-27 20:47:02 -0700 (Thu, 27 Oct 2011) Log Message REGRESSION (r98639): NRWT crashes when parsing leaks output https://bugs.webkit.org/show_bug.cgi?id=71087 Unreviewed. Sadly we have no good way to test logging. * Scripts/webkitpy/layout_tests/port/leakdetector.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py Diff Modified: trunk/Tools/ChangeLog (98681 => 98682) --- trunk/Tools/ChangeLog 2011-10-28 02:54:17 UTC (rev 98681) +++ trunk/Tools/ChangeLog 2011-10-28 03:47:02 UTC (rev 98682) @@ -1,3 +1,12 @@ +2011-10-27 Eric Seidel + +REGRESSION (r98639): NRWT crashes when parsing leaks output +https://bugs.webkit.org/show_bug.cgi?id=71087 + +Unreviewed. Sadly we have no good way to test logging. + +* Scripts/webkitpy/layout_tests/port/leakdetector.py: + 2011-10-27 David Levin Test expectation errors should include the file name and platform in both the log and exception info. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py (98681 => 98682) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-28 02:54:17 UTC (rev 98681) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-28 03:47:02 UTC (rev 98682) @@ -26,11 +26,14 @@ # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +import logging import re from webkitpy.common.system.executive import ScriptError +_log = logging.getLogger(__name__) + # If other ports/platforms decide to support --leaks, we should see about sharing as much of this code as possible. # Right now this code is only used by Apple's MacPort. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98681] trunk
Title: [98681] trunk
Revision 98681
Author dba...@webkit.org
Date 2011-10-27 19:54:17 -0700 (Thu, 27 Oct 2011)
Log Message
CMake: Add support to optionally install the built _javascript_ shell
https://bugs.webkit.org/show_bug.cgi?id=71062
Reviewed by Antonio Gomes.
.:
Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
defined will generate an installation rule to install the built
_javascript_ shell into /bin (with respect to the prefix path).
By default, we don't define this option and hence don't generate
an installation rule for the _javascript_ shell.
* Source/CMakeLists.txt:
Source/_javascript_Core:
Generate an installation rule for installing the _javascript_ shell in
/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
is defined.
* shell/CMakeLists.txt:
Modified Paths
trunk/ChangeLog
trunk/Source/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/CMakeLists.txt
Diff
Modified: trunk/ChangeLog (98680 => 98681)
--- trunk/ChangeLog 2011-10-28 02:47:48 UTC (rev 98680)
+++ trunk/ChangeLog 2011-10-28 02:54:17 UTC (rev 98681)
@@ -1,3 +1,19 @@
+2011-10-27 Daniel Bates
+
+CMake: Add support to optionally install the built _javascript_ shell
+https://bugs.webkit.org/show_bug.cgi?id=71062
+
+Reviewed by Antonio Gomes.
+
+Adds a CMake option, called SHOULD_INSTALL_JS_SHELL, that when
+defined will generate an installation rule to install the built
+_javascript_ shell into /bin (with respect to the prefix path).
+
+By default, we don't define this option and hence don't generate
+an installation rule for the _javascript_ shell.
+
+* Source/CMakeLists.txt:
+
2011-10-27 Sheriff Bot
Unreviewed, rolling out r98556.
Modified: trunk/Source/CMakeLists.txt (98680 => 98681)
--- trunk/Source/CMakeLists.txt 2011-10-28 02:47:48 UTC (rev 98680)
+++ trunk/Source/CMakeLists.txt 2011-10-28 02:54:17 UTC (rev 98681)
@@ -139,6 +139,11 @@
ENDIF ()
# -
+# Install _javascript_ shell
+# -
+OPTION(SHOULD_INSTALL_JS_SHELL "generate an installation rule to install the built _javascript_ shell")
+
+# -
# Add test browser if exists
# -
INCLUDE_IF_EXISTS(${TOOLS_DIR}/CMakeLists${PORT}.txt)
Modified: trunk/Source/_javascript_Core/ChangeLog (98680 => 98681)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-28 02:47:48 UTC (rev 98680)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-28 02:54:17 UTC (rev 98681)
@@ -1,3 +1,16 @@
+2011-10-27 Daniel Bates
+
+CMake: Add support to optionally install the built _javascript_ shell
+https://bugs.webkit.org/show_bug.cgi?id=71062
+
+Reviewed by Antonio Gomes.
+
+Generate an installation rule for installing the _javascript_ shell in
+/bin (with respect to the prefix path) when SHOULD_INSTALL_JS_SHELL
+is defined.
+
+* shell/CMakeLists.txt:
+
2011-10-27 Kentaro Hara
Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
Modified: trunk/Source/_javascript_Core/shell/CMakeLists.txt (98680 => 98681)
--- trunk/Source/_javascript_Core/shell/CMakeLists.txt 2011-10-28 02:47:48 UTC (rev 98680)
+++ trunk/Source/_javascript_Core/shell/CMakeLists.txt 2011-10-28 02:54:17 UTC (rev 98681)
@@ -23,3 +23,7 @@
IF (SHARED_CORE)
SET_TARGET_PROPERTIES(${JSC_EXECUTABLE_NAME} PROPERTIES VERSION ${PROJECT_VERSION})
ENDIF ()
+
+IF (SHOULD_INSTALL_JS_SHELL)
+INSTALL(TARGETS ${JSC_EXECUTABLE_NAME} DESTINATION bin)
+ENDIF ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98680] trunk/Source/WebKit/efl
Title: [98680] trunk/Source/WebKit/efl Revision 98680 Author commit-qu...@webkit.org Date 2011-10-27 19:47:48 -0700 (Thu, 27 Oct 2011) Log Message [EFL] Fix variable renaming issue inside ewk_view.cpp https://bugs.webkit.org/show_bug.cgi?id=71020 Unreviewed build fix. Patch by Gustavo Lima Chaves on 2011-10-27 * ewk/ewk_view.cpp: (ewk_view_js_object_add): Modified Paths trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/ewk/ewk_view.cpp Diff Modified: trunk/Source/WebKit/efl/ChangeLog (98679 => 98680) --- trunk/Source/WebKit/efl/ChangeLog 2011-10-28 02:43:12 UTC (rev 98679) +++ trunk/Source/WebKit/efl/ChangeLog 2011-10-28 02:47:48 UTC (rev 98680) @@ -1,3 +1,13 @@ +2011-10-27 Gustavo Lima Chaves + +[EFL] Fix variable renaming issue inside ewk_view.cpp +https://bugs.webkit.org/show_bug.cgi?id=71020 + +Unreviewed build fix. + +* ewk/ewk_view.cpp: +(ewk_view_js_object_add): + 2011-10-26 Zalan Bujtas Name viewport change event consistently. Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (98679 => 98680) --- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-28 02:43:12 UTC (rev 98679) +++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2011-10-28 02:47:48 UTC (rev 98680) @@ -3694,7 +3694,7 @@ JSC::Identifier id = JSC::Identifier(executeState, objectName); JSC::PutPropertySlot slot; -window->methodTable()->put(window, execState, id, runtimeObject, slot); +window->methodTable()->put(window, executeState, id, runtimeObject, slot); return EINA_TRUE; #else return EINA_FALSE; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98679] trunk/Source
Title: [98679] trunk/Source
Revision 98679
Author hara...@chromium.org
Date 2011-10-27 19:43:12 -0700 (Thu, 27 Oct 2011)
Log Message
Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70215
Reviewed by Adam Barth.
Source/_javascript_Core:
Added a method that judges if a given JSValue is empty.
Tests: transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::JSValue::isEmpty):
Source/WebCore:
This patch implements [Optional=CallWithNullValue] IDL for JSC.
While a parameter specified as [Optional=CallWithDefaultValue] is
handled as a string "undefined", a parameter specified as
[Optional=CallWithNullValue] is handled as a null string.
(Note: not a string "null", but a null string).
c.f. [Optional=CallWithNullValue] is implemented in V8 in bug 67458.
Tests: fast/dom/global-constructors.html
transforms/svg-vs-css.xhtml
transforms/cssmatrix-2d-interface.xhtml
transforms/cssmatrix-3d-interface.xhtml
* GNUmakefile.list.am: Removed JSWebKitCSSMatrixCustom.cpp.
* UseJSC.cmake: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.
* bindings/js/JSDOMBinding.h: MAYBE_MISSING_PARAMETER(exec, index, policy) returns the index-th parameter, if the parameter exists. It returns an undefined value, if the index-th parameter is missing and the policy is MissingIsUndefined. It returns an empty value, otherwise (i.e. if the index-th parameter is missing and the policy is MissingIsEmpty).
* bindings/js/JSWebKitCSSMatrixCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Supported [Optional=CallWithNullValue].
(GenerateConstructorDefinition): Supported [Optional=CallWithNullValue].
* css/WebKitCSSMatrix.idl: Removed [JSCustomConstructor].
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSValue.h
trunk/Source/_javascript_Core/runtime/JSValueInlineMethods.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/UseJSC.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/WebCore.pro
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/css/WebKitCSSMatrix.idl
Removed Paths
trunk/Source/WebCore/bindings/js/JSWebKitCSSMatrixCustom.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98678 => 98679)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-28 02:30:16 UTC (rev 98678)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-28 02:43:12 UTC (rev 98679)
@@ -1,3 +1,20 @@
+2011-10-27 Kentaro Hara
+
+Generate WebKitCSSMatrix constructor for JSC by [Constructor] IDL
+https://bugs.webkit.org/show_bug.cgi?id=70215
+
+Reviewed by Adam Barth.
+
+Added a method that judges if a given JSValue is empty.
+
+Tests: transforms/svg-vs-css.xhtml
+ transforms/cssmatrix-2d-interface.xhtml
+ transforms/cssmatrix-3d-interface.xhtml
+
+* runtime/JSValue.h:
+* runtime/JSValueInlineMethods.h:
+(JSC::JSValue::isEmpty):
+
2011-10-27 Michael Saboff
ENH: Add 8 bit string support to JSC JIT
Modified: trunk/Source/_javascript_Core/runtime/JSValue.h (98678 => 98679)
--- trunk/Source/_javascript_Core/runtime/JSValue.h 2011-10-28 02:30:16 UTC (rev 98678)
+++ trunk/Source/_javascript_Core/runtime/JSValue.h 2011-10-28 02:43:12 UTC (rev 98679)
@@ -162,6 +162,7 @@
double asNumber() const;
// Querying the type.
+bool isEmpty() const;
bool isUndefined() const;
bool isNull() const;
bool isUndefinedOrNull() const;
Modified: trunk/Source/_javascript_Core/runtime/JSValueInlineMethods.h (98678 => 98679)
--- trunk/Source/_javascript_Core/runtime/JSValueInlineMethods.h 2011-10-28 02:30:16 UTC (rev 98678)
+++ trunk/Source/_javascript_Core/runtime/JSValueInlineMethods.h 2011-10-28 02:43:12 UTC (rev 98679)
@@ -223,6 +223,11 @@
return u.asInt64 != other.u.asInt64;
}
+inline bool JSValue::isEmpty() const
+{
+return tag() == EmptyValueTag;
+}
+
inline bool JSValue::isUndefined() const
{
return tag() == UndefinedTag;
@@ -368,6 +373,11 @@
return u.ptr != other.u.ptr;
}
+inline bool JSValue::isEmpty() const
+{
+return u.asInt64 == ValueEmpty;
+}
+
inline bool JSValue::isUndefined() const
{
return asValue() == JSValue(JSUndefined);
Modified: trunk/Source/WebCore/ChangeLog (98678 => 98679)
--- trunk/Source/WebCore/ChangeLog 2011-10-28 02:30:16 UTC (rev 98678)
+++ trunk/Source/WebCore/C
[webkit-changes] [98678] trunk/LayoutTests
Title: [98678] trunk/LayoutTests Revision 98678 Author john...@google.com Date 2011-10-27 19:30:16 -0700 (Thu, 27 Oct 2011) Log Message Add more test expectations and chromium results. * platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added. * platform/chromium-cg-mac-leopard/fast/css/getComputedStyle: Removed. * platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added. * platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added. * platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.png: Added. * platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.txt: Added. * platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png: Added. * platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added. * platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png: Added. * platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt: Added. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png trunk/LayoutTests/platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/css/getComputedStyle/ trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98677 => 98678) --- trunk/LayoutTests/ChangeLog 2011-10-28 01:40:49 UTC (rev 98677) +++ trunk/LayoutTests/ChangeLog 2011-10-28 02:30:16 UTC (rev 98678) @@ -1,3 +1,21 @@ +2011-10-27 John Gregg + +Add more test expectations and chromium results. + +* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added. +* platform/chromium-cg-mac-leopard/fast/css/getComputedStyle: Removed. +* platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added. +* platform/chromium-cg-mac-leopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added. +* platform/chromium-cg-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added. +* platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.png: Added. +* platform/chromium-linux-x86/fast/css/child-style-can-override-visited-style-expected.txt: Added. +* platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.png: Added. +* platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt: Added. +* platform/chromium-mac-snowleopard/fast/css/child-style-can-override-visited-style-expected.png: Added. +* platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.png: Added. +* platform/chromium-win/fast/css/child-style-can-override-visited-style-expected.txt: Added. +* platform/chromium/test_expectations.txt: + 2011-10-27 Dan Bernstein Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98677 => 98678) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 01:40:49 UTC (rev 98677) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 02:30:16 UTC (rev 98678) @@ -3970,8 +3970,8 @@ BUGWK71032 : tables/mozilla_expected_failures/bugs/bug14007-2.html = FAIL BUGWK71074 MAC : fast/table/border-collapsing/border-collapsing-head-foot.html = IMAGE+TEXT -BUGWK71080 : printing/single-line-must-not-be-split-into-two-pages.html = IMAGE+TEXT -BUGWK71080 : printing/setPrinting.html = IMAGE+TEXT +BUGWK71080 : printing/single-line-must-not-be-split-into-two-pages.html = IMAGE+TEXT IMAGE PASS +BUGWK7108
[webkit-changes] [98676] trunk/Source/WebCore
Title: [98676] trunk/Source/WebCore Revision 98676 Author jchaffr...@webkit.org Date 2011-10-27 18:28:58 -0700 (Thu, 27 Oct 2011) Log Message RenderTableCell m_row and m_column should not be signed values https://bugs.webkit.org/show_bug.cgi?id=70369 Reviewed by Darin Adler. No new tests, refactoring only. The gist of the change is to update row / column handling in the table's rendering code to use unsigned values. Not all the code is switched over to unsigned but this is a good start. Using unsigned makes a lot more sense that allowing some negative indexes to creep in the algorithms. Also it enables us to "free" the unused signed bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a follow-up patch. * accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::cellForColumnAndRow): Removed 2 casts to int as the left side now computes to an unsigned too. Added some ASSERT to make sure we don't get negative values (colSpan / rowSpan are always >= 1 by definition but better to be safe). * accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObjectForSection): * accessibility/AccessibilityTableColumn.h: Switched m_columnIndex to unsigned to remove any signed / unsigned comparisons. * rendering/RenderTable.cpp: (WebCore::RenderTable::splitColumn): (WebCore::RenderTable::calcBorderEnd): (WebCore::RenderTable::cellAbove): (WebCore::RenderTable::cellBelow): (WebCore::RenderTable::cellBefore): (WebCore::RenderTable::cellAfter): Mostly mechanical changes to avoid signed / unsigned comparisons or casts. * rendering/RenderTable.h: (WebCore::RenderTable::numEffCols): (WebCore::RenderTable::colToEffCol): Updated a couple of functions to use an unsigned. * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): * rendering/RenderTableCell.h: (WebCore::RenderTableCell::col): (WebCore::RenderTableCell::setCol): (WebCore::RenderTableCell::row): (WebCore::RenderTableCell::setRow): Updated after switching the fields to unsigned. Also added 2 constants to cover the not-initialized-yet value for row and column indexes. Note: we don't enforce that you can't reach those indexes but neither did the previous code! * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::setCellLogicalWidths): (WebCore::RenderTableSection::calcRowLogicalHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::calcOuterBorderStart): (WebCore::RenderTableSection::calcOuterBorderEnd): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::clearGrid): (WebCore::RenderTableSection::numColumns): (WebCore::RenderTableSection::appendColumn): (WebCore::RenderTableSection::splitColumn): Lots of mechanical: signed -> unsigned changes. However we had to change the logic a bit as it assumed that m_cRow started at -1 and increased from there. The new meaning of m_cRow is the number of rows seen and m_cRow - 1 is where to insert your new cells. (WebCore::RenderTableSection::addCell): Checked the callers and all increase m_cRow before calling the function. Added an ASSERT to catch up wrong usage in the future. * rendering/RenderTableSection.h: (WebCore::RenderTableSection::numRows): Switched to unsigned. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityTable.cpp trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp trunk/Source/WebCore/accessibility/AccessibilityTableColumn.h trunk/Source/WebCore/rendering/RenderTable.cpp trunk/Source/WebCore/rendering/RenderTable.h trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableCell.h trunk/Source/WebCore/rendering/RenderTableSection.cpp trunk/Source/WebCore/rendering/RenderTableSection.h Diff Modified: trunk/Source/WebCore/ChangeLog (98675 => 98676) --- trunk/Source/WebCore/ChangeLog 2011-10-28 01:11:49 UTC (rev 98675) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 01:28:58 UTC (rev 98676) @@ -1,3 +1,85 @@ +2011-10-27 Julien Chaffraix + +RenderTableCell m_row and m_column should not be signed values +https://bugs.webkit.org/show_bug.cgi?id=70369 + +Reviewed by Darin Adler. + +No new tests, refactoring only. + +The gist of the change is to update row / column handling in the table's +rendering code to use unsigned values. Not all the code is switched over +to unsigned but this is a good start. + +Using unsigned makes a lot more sense that allowing some negative indexes +to creep in the algorithms. Also it enables us to "free" the unused signed +bit on the 2 RenderTableCell fields that can be used to pack 2 bits in a +follow-up patch. + +* accessibility/AccessibilityTable.cpp: +(WebCore::AccessibilityTable::cellForColumnAndRow): +
[webkit-changes] [98675] trunk
Title: [98675] trunk
Revision 98675
Author m...@apple.com
Date 2011-10-27 18:11:49 -0700 (Thu, 27 Oct 2011)
Log Message
Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com
https://bugs.webkit.org/show_bug.cgi?id=71085
Reviewed by Jon Honeycutt.
Source/WebCore:
Test: fast/css-generated-content/attr-missing.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): If the element does not have the attribute specified
in the attr() function in the content property, set the content to the empty string, per
.
LayoutTests:
* fast/css-generated-content/attr-missing-expected.txt: Added.
* fast/css-generated-content/attr-missing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/attr-missing-expected.txt
trunk/LayoutTests/fast/css-generated-content/attr-missing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98674 => 98675)
--- trunk/LayoutTests/ChangeLog 2011-10-28 01:09:53 UTC (rev 98674)
+++ trunk/LayoutTests/ChangeLog 2011-10-28 01:11:49 UTC (rev 98675)
@@ -1,3 +1,13 @@
+2011-10-27 Dan Bernstein
+
+Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com
+https://bugs.webkit.org/show_bug.cgi?id=71085
+
+Reviewed by Jon Honeycutt.
+
+* fast/css-generated-content/attr-missing-expected.txt: Added.
+* fast/css-generated-content/attr-missing.html: Added.
+
2011-10-27 Mike Lawther
Test that :visited style can be overridden by child element style
Added: trunk/LayoutTests/fast/css-generated-content/attr-missing-expected.txt (0 => 98675)
--- trunk/LayoutTests/fast/css-generated-content/attr-missing-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/attr-missing-expected.txt 2011-10-28 01:11:49 UTC (rev 98675)
@@ -0,0 +1,3 @@
+Test for https://bugs.webkit.org/show_bug.cgi?id=71085 Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com.
+
+The test passes if it does not cause an assertion failure in a debug build.
Added: trunk/LayoutTests/fast/css-generated-content/attr-missing.html (0 => 98675)
--- trunk/LayoutTests/fast/css-generated-content/attr-missing.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/attr-missing.html 2011-10-28 01:11:49 UTC (rev 98675)
@@ -0,0 +1,15 @@
+
+span::before { content: attr(foo); }
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+Test for .
+
+
+The test passes if it does not cause an assertion failure in a debug build.
+
Modified: trunk/Source/WebCore/ChangeLog (98674 => 98675)
--- trunk/Source/WebCore/ChangeLog 2011-10-28 01:09:53 UTC (rev 98674)
+++ trunk/Source/WebCore/ChangeLog 2011-10-28 01:11:49 UTC (rev 98675)
@@ -1,3 +1,17 @@
+2011-10-27 Dan Bernstein
+
+Assertion failure (m_text) in RenderText::RenderText() at icanhascheezburger.com
+https://bugs.webkit.org/show_bug.cgi?id=71085
+
+Reviewed by Jon Honeycutt.
+
+Test: fast/css-generated-content/attr-missing.html
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::applyProperty): If the element does not have the attribute specified
+in the attr() function in the content property, set the content to the empty string, per
+.
+
2011-10-27 Helder Correia
[Qt] Failure to build when QT_NO_CURSOR defined
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (98674 => 98675)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-28 01:09:53 UTC (rev 98674)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-28 01:11:49 UTC (rev 98675)
@@ -2822,7 +2822,8 @@
else
m_parentStyle->setUnique();
QualifiedName attr(nullAtom, contentValue->getStringValue().impl(), nullAtom);
-m_style->setContent(m_element->getAttribute(attr).impl(), didSet);
+const AtomicString& value = m_element->getAttribute(attr);
+m_style->setContent(value.isNull() ? emptyAtom : value.impl(), didSet);
didSet = true;
// register the fact that the attribute value affects the style
m_features.attrsInRules.add(attr.localName().impl());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98674] trunk/Source/JavaScriptCore
Title: [98674] trunk/Source/_javascript_Core
Revision 98674
Author msab...@apple.com
Date 2011-10-27 18:09:53 -0700 (Thu, 27 Oct 2011)
Log Message
ENH: Add 8 bit string support to JSC JIT
https://bugs.webkit.org/show_bug.cgi?id=71073
Changed the JIT String character access generation to create code
to check the character size and load8() or load16() as approriate.
Reviewed by Gavin Barraclough.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::load8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::movzbl_mr):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadCharacterString):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
* jit/JSInterfaceJIT.h:
(JSC::ThunkHelpers::stringImplFlagsOffset):
(JSC::ThunkHelpers::stringImpl8BitFlag):
* jit/ThunkGenerators.cpp:
(JSC::stringCharLoad):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/jit/JITInlineMethods.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp
trunk/Source/_javascript_Core/jit/JSInterfaceJIT.h
trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98673 => 98674)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-28 01:01:45 UTC (rev 98673)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-28 01:09:53 UTC (rev 98674)
@@ -1,3 +1,32 @@
+2011-10-27 Michael Saboff
+
+ENH: Add 8 bit string support to JSC JIT
+https://bugs.webkit.org/show_bug.cgi?id=71073
+
+Changed the JIT String character access generation to create code
+to check the character size and load8() or load16() as approriate.
+
+Reviewed by Gavin Barraclough.
+
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::load8):
+* assembler/X86Assembler.h:
+(JSC::X86Assembler::movzbl_mr):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
+(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
+* jit/JITInlineMethods.h:
+(JSC::JIT::emitLoadCharacterString):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::stringGetByValStubGenerator):
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::stringGetByValStubGenerator):
+* jit/JSInterfaceJIT.h:
+(JSC::ThunkHelpers::stringImplFlagsOffset):
+(JSC::ThunkHelpers::stringImpl8BitFlag):
+* jit/ThunkGenerators.cpp:
+(JSC::stringCharLoad):
+
2011-10-27 Filip Pizlo
If the bytecode generator emits code after the return in the first basic block,
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (98673 => 98674)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2011-10-28 01:01:45 UTC (rev 98673)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2011-10-28 01:09:53 UTC (rev 98674)
@@ -481,6 +481,11 @@
m_assembler.movzbl_mr(address.offset, address.base, address.index, address.scale, dest);
}
+void load8(ImplicitAddress address, RegisterID dest)
+{
+m_assembler.movzbl_mr(address.offset, address.base, dest);
+}
+
void load16(BaseIndex address, RegisterID dest)
{
m_assembler.movzwl_mr(address.offset, address.base, address.index, address.scale, dest);
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (98673 => 98674)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-10-28 01:01:45 UTC (rev 98673)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2011-10-28 01:09:53 UTC (rev 98674)
@@ -1231,6 +1231,11 @@
m_formatter.twoByteOp(OP2_MOVZX_GvEw, dst, base, index, scale, offset);
}
+void movzbl_mr(int offset, RegisterID base, RegisterID dst)
+{
+m_formatter.twoByteOp(OP2_MOVZX_GvEb, dst, base, offset);
+}
+
void movzbl_mr(int offset, RegisterID base, RegisterID index, int scale, RegisterID dst)
{
m_formatter.twoByteOp(OP2_MOVZX_GvEb, dst, base, index, scale, offset);
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (98673 => 98674)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-10-28 01:01:45 UTC (rev 98673)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2011-10-28 01:09:53 UTC (rev 98674)
@@ -581,28 +581,38 @@
ASSERT(node.child3() == NoNode);
SpeculateCellOperand string(this, node.child1());
SpeculateStrictInt32Operand index(this, node.child2());
-
+
GPRRe
[webkit-changes] [98673] trunk/LayoutTests
Title: [98673] trunk/LayoutTests
Revision 98673
Author mikelawt...@chromium.org
Date 2011-10-27 18:01:45 -0700 (Thu, 27 Oct 2011)
Log Message
Test that :visited style can be overridden by child element style
Added as requested on https://bugs.webkit.org/show_bug.cgi?id=70470
https://bugs.webkit.org/show_bug.cgi?id=70568
Reviewed by Antti Koivisto.
* fast/css/child-style-can-override-visited-style-expected.txt: Added.
* fast/css/child-style-can-override-visited-style.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Added Paths
trunk/LayoutTests/fast/css/child-style-can-override-visited-style.html
trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt
trunk/LayoutTests/platform/mac/fast/css/child-style-can-override-visited-style-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98672 => 98673)
--- trunk/LayoutTests/ChangeLog 2011-10-28 00:57:21 UTC (rev 98672)
+++ trunk/LayoutTests/ChangeLog 2011-10-28 01:01:45 UTC (rev 98673)
@@ -1,3 +1,15 @@
+2011-10-27 Mike Lawther
+
+Test that :visited style can be overridden by child element style
+Added as requested on https://bugs.webkit.org/show_bug.cgi?id=70470
+
+https://bugs.webkit.org/show_bug.cgi?id=70568
+
+Reviewed by Antti Koivisto.
+
+* fast/css/child-style-can-override-visited-style-expected.txt: Added.
+* fast/css/child-style-can-override-visited-style.html: Added.
+
2011-10-27 Tony Chang
add snow leopard results for flexbox repaint tests
Added: trunk/LayoutTests/fast/css/child-style-can-override-visited-style.html (0 => 98673)
--- trunk/LayoutTests/fast/css/child-style-can-override-visited-style.html (rev 0)
+++ trunk/LayoutTests/fast/css/child-style-can-override-visited-style.html 2011-10-28 01:01:45 UTC (rev 98673)
@@ -0,0 +1,10 @@
+
+.flim {color: green;}
+a:visited {color: red;}
+
+This tests that a child style can override the :visited style.
+
+This text should be green (and underlined)
+
+
+This text should be green
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98672 => 98673)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 00:57:21 UTC (rev 98672)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 01:01:45 UTC (rev 98673)
@@ -3918,6 +3918,9 @@
BUGWK70298 : svg/custom/js-late-gradient-creation.svg = IMAGE PASS
BUGWK70298 : svg/custom/js-late-pattern-creation.svg = IMAGE PASS
+// Needs rebaseline for WIN
+BUGWK70568 WIN : fast/css/child-style-can-override-visited-style.html = TEXT
+
// Failing since ~r97700.
BUGWK70298 WIN LINUX SNOWLEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE+TEXT PASS
BUGWK70298 LEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE
Added: trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt (0 => 98673)
--- trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/css/child-style-can-override-visited-style-expected.txt 2011-10-28 01:01:45 UTC (rev 98673)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderBlock (anonymous) at (0,0) size 784x20
+RenderText {#text} at (0,0) size 337x19
+ text run at (0,0) width 337: "This tests that a child style can override the :visited style."
+RenderInline {A} at (0,0) size 0x0 [color=#FF]
+ RenderText {#text} at (0,0) size 0x0
+ RenderBlock (anonymous) at (0,20) size 784x20 [color=#FF]
+RenderBlock {DIV} at (0,0) size 784x20 [color=#008000]
+ RenderText {#text} at (0,0) size 252x19
+text run at (0,0) width 252: "This text should be green (and underlined)"
+ RenderBlock (anonymous) at (0,40) size 784x0
+RenderInline {A} at (0,0) size 0x0 [color=#FF]
+RenderText {#text} at (0,0) size 0x0
+ RenderBlock {DIV} at (0,40) size 784x20 [color=#008000]
+RenderText {#text} at (0,0) size 150x19
+ text run at (0,0) width 150: "This text should be green"
\ No newline at end of file
Added: trunk/LayoutTests/platform/mac/fast/css/child-style-can-override-visited-style-expected.txt (0 => 98673)
--- trunk/LayoutTests/platform/mac/fast/css/child-style-can-override-visited-style-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/fast/css/child-style-can-override-visited-style-expected.txt 2011-10-28 01:01:45 UTC (rev 98673)
@@ -0,0 +1,20 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 8
[webkit-changes] [98672] trunk/Source/WebKit/chromium
Title: [98672] trunk/Source/WebKit/chromium
Revision 98672
Author vange...@chromium.org
Date 2011-10-27 17:57:21 -0700 (Thu, 27 Oct 2011)
Log Message
Expose Settings::setAcceleratedCompositingForFixedPositionEnabled to WebSettingsImpl.
https://bugs.webkit.org/show_bug.cgi?id=71077
Reviewed by James Robinson.
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedCompositingForFixedPositionEnabled):
* src/WebSettingsImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98671 => 98672)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-28 00:50:31 UTC (rev 98671)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-28 00:57:21 UTC (rev 98672)
@@ -1,3 +1,14 @@
+2011-10-27 Vangelis Kokkevis
+
+Expose Settings::setAcceleratedCompositingForFixedPositionEnabled to WebSettingsImpl.
+https://bugs.webkit.org/show_bug.cgi?id=71077
+
+Reviewed by James Robinson.
+
+* src/WebSettingsImpl.cpp:
+(WebKit::WebSettingsImpl::setAcceleratedCompositingForFixedPositionEnabled):
+* src/WebSettingsImpl.h:
+
2011-10-27 Peng Huang
[chromium] Remove some APIs which are not used anymore.
Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp (98671 => 98672)
--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp 2011-10-28 00:50:31 UTC (rev 98671)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp 2011-10-28 00:57:21 UTC (rev 98672)
@@ -364,6 +364,11 @@
m_settings->setLegacyAccelerated2dCanvasEnabled(enabled);
}
+void WebSettingsImpl::setAcceleratedCompositingForFixedPositionEnabled(bool enabled)
+{
+m_settings->setAcceleratedCompositingForFixedPositionEnabled(enabled);
+}
+
void WebSettingsImpl::setMinimumAccelerated2dCanvasSize(int numPixels)
{
m_settings->setMinimumAccelerated2dCanvasSize(numPixels);
Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.h (98671 => 98672)
--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.h 2011-10-28 00:50:31 UTC (rev 98671)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.h 2011-10-28 00:57:21 UTC (rev 98672)
@@ -104,6 +104,7 @@
virtual void setAcceleratedCompositingForCanvasEnabled(bool);
virtual void setAcceleratedCompositingForAnimationEnabled(bool);
virtual void setAccelerated2dCanvasEnabled(bool);
+virtual void setAcceleratedCompositingForFixedPositionEnabled(bool);
virtual void setLegacyAccelerated2dCanvasEnabled(bool);
virtual void setMinimumAccelerated2dCanvasSize(int);
virtual void setAcceleratedDrawingEnabled(bool);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98671] trunk/Source/WebCore
Title: [98671] trunk/Source/WebCore
Revision 98671
Author commit-qu...@webkit.org
Date 2011-10-27 17:50:31 -0700 (Thu, 27 Oct 2011)
Log Message
[Qt] Failure to build when QT_NO_CURSOR defined
https://bugs.webkit.org/show_bug.cgi?id=71060
Patch by Helder Correia on 2011-10-27
Reviewed by Noam Rosenthal.
PlatformVideoWindowQt needs to wrap some code around #ifndef
QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined.
Build fix, no new tests.
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::closeEvent):
(FullScreenVideoWindow::hideCursor):
(FullScreenVideoWindow::showCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowQt.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98670 => 98671)
--- trunk/Source/WebCore/ChangeLog 2011-10-28 00:44:49 UTC (rev 98670)
+++ trunk/Source/WebCore/ChangeLog 2011-10-28 00:50:31 UTC (rev 98671)
@@ -1,3 +1,21 @@
+2011-10-27 Helder Correia
+
+[Qt] Failure to build when QT_NO_CURSOR defined
+https://bugs.webkit.org/show_bug.cgi?id=71060
+
+Reviewed by Noam Rosenthal.
+
+PlatformVideoWindowQt needs to wrap some code around #ifndef
+QT_NO_CURSOR in order to build QtWebKit when QT_NO_CURSOR is defined.
+
+Build fix, no new tests.
+
+* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
+(FullScreenVideoWindow::FullScreenVideoWindow):
+(FullScreenVideoWindow::closeEvent):
+(FullScreenVideoWindow::hideCursor):
+(FullScreenVideoWindow::showCursor):
+
2011-10-27 Shawn Singh
[chromium] Track when CCLayerImpl properties have changed.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowQt.cpp (98670 => 98671)
--- trunk/Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowQt.cpp 2011-10-28 00:44:49 UTC (rev 98670)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/PlatformVideoWindowQt.cpp 2011-10-28 00:50:31 UTC (rev 98671)
@@ -29,7 +29,9 @@
#include
using namespace WebCore;
+#ifndef QT_NO_CURSOR
static const int gHideMouseCursorDelay = 3000;
+#endif
FullScreenVideoWindow::FullScreenVideoWindow()
: QWidget(0, Qt::Window)
@@ -40,8 +42,10 @@
setAttribute(Qt::WA_NoSystemBackground, true);
setAttribute(Qt::WA_PaintOnScreen, true);
+#ifndef QT_NO_CURSOR
m_cursorTimer.setSingleShot(true);
connect(&m_cursorTimer, SIGNAL(timeout()), this, SLOT(hideCursor()));
+#endif
}
void FullScreenVideoWindow::setVideoElement(HTMLVideoElement* element)
@@ -51,10 +55,14 @@
void FullScreenVideoWindow::closeEvent(QCloseEvent*)
{
+#ifndef QT_NO_CURSOR
m_cursorTimer.stop();
+#endif
setMouseTracking(false);
releaseMouse();
+#ifndef QT_NO_CURSOR
QApplication::restoreOverrideCursor();
+#endif
}
void FullScreenVideoWindow::keyPressEvent(QKeyEvent* ev)
@@ -96,13 +104,17 @@
void FullScreenVideoWindow::hideCursor()
{
+#ifndef QT_NO_CURSOR
QApplication::setOverrideCursor(QCursor(Qt::BlankCursor));
+#endif
}
void FullScreenVideoWindow::showCursor()
{
+#ifndef QT_NO_CURSOR
QApplication::restoreOverrideCursor();
m_cursorTimer.start(gHideMouseCursorDelay);
+#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98669] trunk/Source/WebKit/chromium
Title: [98669] trunk/Source/WebKit/chromium
Revision 98669
Author commit-qu...@webkit.org
Date 2011-10-27 17:40:22 -0700 (Thu, 27 Oct 2011)
Log Message
[chromium] Remove some APIs which are not used anymore.
https://bugs.webkit.org/show_bug.cgi?id=71068
Patch by Peng Huang on 2011-10-27
Reviewed by Darin Fisher.
* public/WebWidget.h:
* src/WebPopupMenuImpl.cpp:
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp
trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98668 => 98669)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-28 00:39:16 UTC (rev 98668)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-28 00:40:22 UTC (rev 98669)
@@ -1,3 +1,16 @@
+2011-10-27 Peng Huang
+
+[chromium] Remove some APIs which are not used anymore.
+https://bugs.webkit.org/show_bug.cgi?id=71068
+
+Reviewed by Darin Fisher.
+
+* public/WebWidget.h:
+* src/WebPopupMenuImpl.cpp:
+* src/WebPopupMenuImpl.h:
+* src/WebViewImpl.cpp:
+* src/WebViewImpl.h:
+
2011-10-27 Shawn Singh
[chromium] Track when CCLayerImpl properties have changed.
Modified: trunk/Source/WebKit/chromium/public/WebWidget.h (98668 => 98669)
--- trunk/Source/WebKit/chromium/public/WebWidget.h 2011-10-28 00:39:16 UTC (rev 98668)
+++ trunk/Source/WebKit/chromium/public/WebWidget.h 2011-10-28 00:40:22 UTC (rev 98669)
@@ -143,24 +143,6 @@
// Returns the current text input type of this WebWidget.
virtual WebTextInputType textInputType() { return WebKit::WebTextInputTypeNone; }
-// Returns the plain text around the edit caret and the focus index in the
-// text. If selection exists, it will return the anchor index as well,
-// otherwise the anchor index will be the same value of the focus index.
-virtual bool getSelectionOffsetsAndTextInEditableContent(WebString&, size_t& focus, size_t& anchor) const { return false; }
-
-// FIXME: It has been replaced by selectionBounds. Remove it when chromium
-// switches to selectionBounds.
-// Returns the current caret bounds of this WebWidget. The selection bounds
-// will be returned if a selection range is available.
-virtual WebRect caretOrSelectionBounds() { return WebRect(); }
-
-// FIXME: It has been replaced by selectionBounds. Remove it when chromium
-// switches to selectionBounds.
-// Returns the start and end point for the current selection, aligned to the
-// bottom of the selected line. start and end are the logical beginning and
-// ending positions of the selection. Visually, start may lie after end.
-virtual bool selectionRange(WebPoint& start, WebPoint& end) const { return false; }
-
// Returns the start and end bounds of the current selection.
// If the selection range is empty, it returns the caret bounds.
virtual bool selectionBounds(WebRect& start, WebRect& end) const { return false; }
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp (98668 => 98669)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-10-28 00:39:16 UTC (rev 98668)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.cpp 2011-10-28 00:40:22 UTC (rev 98669)
@@ -327,11 +327,6 @@
return WebTextInputTypeNone;
}
-WebRect WebPopupMenuImpl::caretOrSelectionBounds()
-{
-return WebRect();
-}
-
bool WebPopupMenuImpl::caretOrSelectionRange(size_t* location, size_t* length)
{
*location = 0;
Modified: trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h (98668 => 98669)
--- trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-10-28 00:39:16 UTC (rev 98668)
+++ trunk/Source/WebKit/chromium/src/WebPopupMenuImpl.h 2011-10-28 00:40:22 UTC (rev 98669)
@@ -87,8 +87,6 @@
virtual bool confirmComposition(const WebString& text);
virtual bool compositionRange(size_t* location, size_t* length);
virtual WebTextInputType textInputType();
-virtual WebRect caretOrSelectionBounds();
-virtual bool selectionRange(WebPoint& start, WebPoint& end) const { return false; }
virtual bool caretOrSelectionRange(size_t* location, size_t* length);
virtual void setTextDirection(WebTextDirection direction);
virtual bool isAcceleratedCompositingActive() const { return false; }
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (98668 => 98669)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-28 00:39:16 UTC (rev 98668)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2011-10-28 00:40:22 UTC (rev 98669)
@@ -1505,79 +1505,6 @@
return WebTextInputTypeNone;
}
-bool WebViewImpl::getSelectionOffsetsAndTextInEditableContent(WebString& text, size_t& focus, size_
[webkit-changes] [98668] trunk/LayoutTests
Title: [98668] trunk/LayoutTests Revision 98668 Author john...@google.com Date 2011-10-27 17:39:16 -0700 (Thu, 27 Oct 2011) Log Message Unreviewed, more gardening. * platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (98667 => 98668) --- trunk/LayoutTests/ChangeLog 2011-10-28 00:37:02 UTC (rev 98667) +++ trunk/LayoutTests/ChangeLog 2011-10-28 00:39:16 UTC (rev 98668) @@ -1,5 +1,12 @@ 2011-10-27 John Gregg +Unreviewed, more gardening. + +* platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png: +* platform/chromium/test_expectations.txt: + +2011-10-27 John Gregg + Unreviewed, gardening chromium. * platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98667 => 98668) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 00:37:02 UTC (rev 98667) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 00:39:16 UTC (rev 98668) @@ -520,7 +520,7 @@ // This requires usp10.dll version 1.600 or greater on Windows and // it isn't installed on XP by default. -WONTFIX XP : css3/font-feature-settings-rendering.html = PASS FAIL +WONTFIX WIN : css3/font-feature-settings-rendering.html = PASS FAIL // - // LIGHTTPD @@ -3969,3 +3969,6 @@ BUGWK71074 MAC : fast/table/border-collapsing/border-collapsing-head-foot.html = IMAGE+TEXT BUGWK71080 : printing/single-line-must-not-be-split-into-two-pages.html = IMAGE+TEXT BUGWK71080 : printing/setPrinting.html = IMAGE+TEXT + +BUGWK71083 MAC : fast/frames/iframe-double-scale-contents.html = FAIL CRASH +BUGWK71084 WIN : http/tests/inspector/extensions-ignore-cache.html = FAIL CRASH Modified: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98667] trunk/Source
Title: [98667] trunk/Source Revision 98667 Author commit-qu...@webkit.org Date 2011-10-27 17:37:02 -0700 (Thu, 27 Oct 2011) Log Message [chromium] Track when CCLayerImpl properties have changed. https://bugs.webkit.org/show_bug.cgi?id=70442 Patch by Shawn Singh on 2011-10-27 Reviewed by James Robinson. Source/WebCore: To determine a good scissor rect, we must determine what will change on the screen on the next redraw. This patch tracks the necessary information on CCLayerImpl and marks a flag indicating whether this layer will "damage" the screen. The other portion of "change", the updateRect, was already landed in https://bugs.webkit.org/show_bug.cgi?id=69441. New unit test added to CCLayerImplTest to test this patch. * platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::CCLayerImpl): (WebCore::CCLayerImpl::scrollBy): (WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree): (WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants): (WebCore::CCLayerImpl::setBounds): (WebCore::CCLayerImpl::setMaskLayer): (WebCore::CCLayerImpl::setReplicaLayer): (WebCore::CCLayerImpl::setDrawsContent): (WebCore::CCLayerImpl::setAnchorPoint): (WebCore::CCLayerImpl::setAnchorPointZ): (WebCore::CCLayerImpl::setMasksToBounds): (WebCore::CCLayerImpl::setOpaque): (WebCore::CCLayerImpl::setOpacity): (WebCore::CCLayerImpl::setPosition): (WebCore::CCLayerImpl::setPreserves3D): (WebCore::CCLayerImpl::setSublayerTransform): (WebCore::CCLayerImpl::setTransform): (WebCore::CCLayerImpl::setDebugBorderColor): (WebCore::CCLayerImpl::setDebugBorderWidth): (WebCore::CCLayerImpl::setContentBounds): (WebCore::CCLayerImpl::setScrollPosition): (WebCore::CCLayerImpl::setScrollDelta): (WebCore::CCLayerImpl::setDoubleSided): * platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::layerPropertyChanged): (WebCore::CCLayerImpl::resetLayerPropertyChanged): Source/WebKit/chromium: * WebKit.gypi: * tests/CCLayerImplTest.cpp: Added. (WebCore::TEST): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/WebKit.gypi Added Paths trunk/Source/WebKit/chromium/tests/CCLayerImplTest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98666 => 98667) --- trunk/Source/WebCore/ChangeLog 2011-10-28 00:29:39 UTC (rev 98666) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 00:37:02 UTC (rev 98667) @@ -1,3 +1,47 @@ +2011-10-27 Shawn Singh + +[chromium] Track when CCLayerImpl properties have changed. +https://bugs.webkit.org/show_bug.cgi?id=70442 + +Reviewed by James Robinson. + +To determine a good scissor rect, we must determine what +will change on the screen on the next redraw. This patch +tracks the necessary information on CCLayerImpl and marks +a flag indicating whether this layer will "damage" the screen. +The other portion of "change", the updateRect, was already +landed in https://bugs.webkit.org/show_bug.cgi?id=69441. + +New unit test added to CCLayerImplTest to test this patch. + +* platform/graphics/chromium/cc/CCLayerImpl.cpp: +(WebCore::CCLayerImpl::CCLayerImpl): +(WebCore::CCLayerImpl::scrollBy): +(WebCore::CCLayerImpl::noteLayerPropertyChangedForSubtree): +(WebCore::CCLayerImpl::noteLayerPropertyChangedForDescendants): +(WebCore::CCLayerImpl::setBounds): +(WebCore::CCLayerImpl::setMaskLayer): +(WebCore::CCLayerImpl::setReplicaLayer): +(WebCore::CCLayerImpl::setDrawsContent): +(WebCore::CCLayerImpl::setAnchorPoint): +(WebCore::CCLayerImpl::setAnchorPointZ): +(WebCore::CCLayerImpl::setMasksToBounds): +(WebCore::CCLayerImpl::setOpaque): +(WebCore::CCLayerImpl::setOpacity): +(WebCore::CCLayerImpl::setPosition): +(WebCore::CCLayerImpl::setPreserves3D): +(WebCore::CCLayerImpl::setSublayerTransform): +(WebCore::CCLayerImpl::setTransform): +(WebCore::CCLayerImpl::setDebugBorderColor): +(WebCore::CCLayerImpl::setDebugBorderWidth): +(WebCore::CCLayerImpl::setContentBounds): +(WebCore::CCLayerImpl::setScrollPosition): +(WebCore::CCLayerImpl::setScrollDelta): +(WebCore::CCLayerImpl::setDoubleSided): +* platform/graphics/chromium/cc/CCLayerImpl.h: +(WebCore::CCLayerImpl::layerPropertyChanged): +(WebCore::CCLayerImpl::resetLayerPropertyChanged): + 2011-10-27 Anders Carlsson Add a Plugin::geometryDidChange that will work with transforms Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp (98666 => 98667) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp 2011-10-28 00:29:39 UTC (rev 98666) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cp
[webkit-changes] [98666] trunk/Tools
Title: [98666] trunk/Tools
Revision 98666
Author le...@chromium.org
Date 2011-10-27 17:29:39 -0700 (Thu, 27 Oct 2011)
Log Message
Test expectation errors should include the file name and platform in both the log and exception info.
https://bugs.webkit.org/show_bug.cgi?id=71067
Reviewed by Ojan Vafai.
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (98665 => 98666)
--- trunk/Tools/ChangeLog 2011-10-28 00:21:08 UTC (rev 98665)
+++ trunk/Tools/ChangeLog 2011-10-28 00:29:39 UTC (rev 98666)
@@ -1,3 +1,13 @@
+2011-10-27 David Levin
+
+Test expectation errors should include the file name and platform in both the log and exception info.
+https://bugs.webkit.org/show_bug.cgi?id=71067
+
+Reviewed by Ojan Vafai.
+
+* Scripts/webkitpy/layout_tests/models/test_expectations.py:
+* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+
2011-10-27 Eric Seidel
new-run-webkit-tests doesn't understand --qt or --gtk
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py (98665 => 98666)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-10-28 00:21:08 UTC (rev 98665)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py 2011-10-28 00:29:39 UTC (rev 98666)
@@ -695,6 +695,7 @@
self._is_lint_mode = is_lint_mode
self._model = TestExpectationsModel()
self._parser = TestExpectationParser(port, tests, is_lint_mode)
+self._port = port
self._test_configuration_converter = TestConfigurationConverter(port.all_test_configurations(), port.configuration_specifier_macros())
self._expectations = TestExpectationParser.tokenize_list(expectations)
@@ -783,7 +784,11 @@
warnings.append("Line:%s %s %s" % (expectation.line_number, warning, expectation.name if expectation.expectations else expectation.original_string))
if len(errors) or len(warnings):
-_log.error("FAILURES FOR %s" % str(self._test_config))
+webkit_base_path = self._port.webkit_base()
+test_expectation_path = self._port.path_to_test_expectations_file()
+test_expectation_relative_path = test_expectation_path[len(webkit_base_path):].lstrip('/')
+failure_title = "FAILURES FOR %s in %s" % (str(self._test_config), test_expectation_relative_path)
+_log.error(failure_title)
for error in errors:
_log.error(error)
@@ -791,11 +796,11 @@
_log.error(warning)
if len(errors):
-raise ParseError(fatal=True, errors=errors)
+raise ParseError(fatal=True, errors=[failure_title] + errors)
if len(warnings):
self._has_warnings = True
if self._is_lint_mode:
-raise ParseError(fatal=False, errors=warnings)
+raise ParseError(fatal=False, errors=[failure_title] + warnings)
def _process_tests_without_expectations(self):
if self._full_test_list:
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (98665 => 98666)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2011-10-28 00:21:08 UTC (rev 98665)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py 2011-10-28 00:29:39 UTC (rev 98666)
@@ -199,7 +199,8 @@
self.assertFalse(True, "ParseError wasn't raised")
except ParseError, e:
self.assertTrue(e.fatal)
-exp_errors = [u"Line:1 Unrecognized modifier 'foo' failures/expected/text.html",
+exp_errors = [u"FAILURES FOR %s in LayoutTests/platform/test/test_expectations.txt" % self._port.test_configuration(),
+ u"Line:1 Unrecognized modifier 'foo' failures/expected/text.html",
u"Line:2 Missing expectations SKIP : failures/expected/image.html"]
self.assertEqual(str(e), '\n'.join(map(str, exp_errors)))
self.assertEqual(e.errors, exp_errors)
@@ -211,7 +212,8 @@
self.assertFalse(True, "ParseError wasn't raised")
except ParseError, e:
self.assertFalse(e.fatal)
-exp_errors = [u'Line:1 Test lacks BUG modifier. failures/expected/text.html']
+exp_errors = [u'FAILURES FOR %s in LayoutTests/platform/test/test_expectations.txt' % self._port.test_configuration(),
+ u'Line:1 Test lacks BUG modifier. failures/expected/text.html']
self.assertEqual(str(e), '\n'.join(map(str, exp_errors)))
[webkit-changes] [98665] trunk/Tools
Title: [98665] trunk/Tools
Revision 98665
Author e...@webkit.org
Date 2011-10-27 17:21:08 -0700 (Thu, 27 Oct 2011)
Log Message
new-run-webkit-tests doesn't understand --qt or --gtk
https://bugs.webkit.org/show_bug.cgi?id=63970
Reviewed by Ojan Vafai.
Add support for --qt and --gtk to NRWT.
I also removed some incorrect comments in the option parsing
code (options which we already implement, but said we didn't)
as well as moved --platform parsing out of the "results_options"
section into the top configuration section.
Now run-webkit-tests no longer needs NRWT-specific code for passing
--platform=qt, etc.
* Scripts/run-webkit-tests:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
Diff
Modified: trunk/Tools/ChangeLog (98664 => 98665)
--- trunk/Tools/ChangeLog 2011-10-28 00:18:55 UTC (rev 98664)
+++ trunk/Tools/ChangeLog 2011-10-28 00:21:08 UTC (rev 98665)
@@ -1,5 +1,24 @@
2011-10-27 Eric Seidel
+new-run-webkit-tests doesn't understand --qt or --gtk
+https://bugs.webkit.org/show_bug.cgi?id=63970
+
+Reviewed by Ojan Vafai.
+
+Add support for --qt and --gtk to NRWT.
+I also removed some incorrect comments in the option parsing
+code (options which we already implement, but said we didn't)
+as well as moved --platform parsing out of the "results_options"
+section into the top configuration section.
+
+Now run-webkit-tests no longer needs NRWT-specific code for passing
+--platform=qt, etc.
+
+* Scripts/run-webkit-tests:
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+
+2011-10-27 Eric Seidel
+
REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=66227
Modified: trunk/Tools/Scripts/run-webkit-tests (98664 => 98665)
--- trunk/Tools/Scripts/run-webkit-tests 2011-10-28 00:18:55 UTC (rev 98664)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-10-28 00:21:08 UTC (rev 98665)
@@ -89,24 +89,15 @@
if (runningOnBuildBot()) {
push(@ARGV, "--verbose");
}
+}
-# FIXME: We need a cleaner way to do --platform handling.
-# webkitdirs.pm strips --qt and --gtk from @ARGV when we call isQt/isGtk.
-# Unfortunately new-run-webkit-tests wouldn't understand --qt/--gtk if we passed it to it anyway,
-# so we have to convert it to --platform=PORT equivalents.
-# https://bugs.webkit.org/show_bug.cgi?id=63970
-if (isQt()) {
-push(@ARGV, "--platform=qt");
-} elsif (isGtk()) {
-push(@ARGV, "--platform=gtk");
-}
-} else {
-# We have to add back any --PORT arguments which may have been removed by isPort() checks above.
-if (isQt()) {
-push(@ARGV, "--qt");
-} elsif (isGtk()) {
-push(@ARGV, "--gtk");
-}
+# FIXME: We need a cleaner way to do --platform handling.
+# webkitdirs.pm strips --qt and --gtk from @ARGV when we call isQt/isGtk.
+# We have to add back any --PORT arguments which may have been removed by isPort() checks above.
+if (isQt()) {
+push(@ARGV, "--qt");
+} elsif (isGtk()) {
+push(@ARGV, "--gtk");
}
my $harnessPath = File::Spec->catfile(relativeScriptsDir(), $harnessName);
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (98664 => 98665)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-10-28 00:18:55 UTC (rev 98664)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2011-10-28 00:21:08 UTC (rev 98665)
@@ -189,6 +189,9 @@
const='Release', dest="configuration",
help='Set the configuration to Release'),
# old-run-webkit-tests also accepts -c, --configuration CONFIGURATION.
+optparse.make_option("--platform", help="Override port/platform being tested (i.e. chromium-mac)"),
+optparse.make_option('--qt', action='', const='qt', dest="platform", help='Alias for --platform=qt'),
+optparse.make_option('--gtk', action='', const='gtk', dest="platform", help='Alias for --platform=gtk'),
]
print_options = printing.print_options()
@@ -263,8 +266,6 @@
]
results_options = [
-# NEED for bots: --use-remote-links-to-tests Link to test files
-# within the SVN repository in the results.
optparse.make_option("-p", "--pixel-tests", action=""
dest="pixel_tests", help="Enable pixel-to-pixel PNG comparisons"),
optparse.make_option("--no-pixel-tests", action=""
@@ -304,23 +305,13 @@
"are done"),
# FIXME: We should have a helper function to do this sort of
# deprectated mapping and automatically log, etc.
-optparse.make_option("--noshow-results", action=""
-dest="show_results",
-
[webkit-changes] [98664] trunk/Source
Title: [98664] trunk/Source Revision 98664 Author ander...@apple.com Date 2011-10-27 17:18:55 -0700 (Thu, 27 Oct 2011) Log Message Add a Plugin::geometryDidChange that will work with transforms https://bugs.webkit.org/show_bug.cgi?id=71072 Reviewed by Simon Fraser. Source/WebCore: Export symbols needed by WebKit2. * WebCore.exp.in: Source/WebKit2: Add a new Plugin::geometryDidChange pure virtual member function, that takes the size of the plug-in, the clip rect (in plug-in coordinates), and a matrix that makes it possible to convert between root view coordinates and plug-in coordinates. PluginView only calls this new geometryDidChange member function if Plugin::wantsWindowRelativeCoordinates returns false, which is only true for BuiltInPDFView right now. * WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::geometryDidChange): * WebProcess/Plugins/Netscape/NetscapePlugin.h: Add stub. * WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::updateScrollbars): (WebKit::BuiltInPDFView::pdfDocumentDidLoad): (WebKit::BuiltInPDFView::paintContent): (WebKit::BuiltInPDFView::deprecatedGeometryDidChange): (WebKit::BuiltInPDFView::geometryDidChange): (WebKit::BuiltInPDFView::setScrollOffset): (WebKit::BuiltInPDFView::maximumScrollPosition): (WebKit::BuiltInPDFView::visibleHeight): (WebKit::BuiltInPDFView::visibleWidth): * WebProcess/Plugins/PDF/BuiltInPDFView.h: There's no need to keep track of the plug-in rect anymore. * WebProcess/Plugins/Plugin.h: Add and document geometryDidChange. * WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange): * WebProcess/Plugins/PluginProxy.h: Add stub. * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::viewGeometryDidChange): Call geometryDidChange. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98663 => 98664) --- trunk/Source/WebCore/ChangeLog 2011-10-28 00:01:45 UTC (rev 98663) +++ trunk/Source/WebCore/ChangeLog 2011-10-28 00:18:55 UTC (rev 98664) @@ -1,3 +1,14 @@ +2011-10-27 Anders Carlsson + +Add a Plugin::geometryDidChange that will work with transforms +https://bugs.webkit.org/show_bug.cgi?id=71072 + +Reviewed by Simon Fraser. + +Export symbols needed by WebKit2. + +* WebCore.exp.in: + 2011-10-27 Adam Barth Exception subtypes have incorrect namespace indentation Modified: trunk/Source/WebCore/WebCore.exp.in (98663 => 98664) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-28 00:01:45 UTC (rev 98663) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-28 00:18:55 UTC (rev 98664) @@ -401,6 +401,7 @@ __ZN7WebCore14StorageTracker18diskUsageForOriginEPNS_14SecurityOriginE __ZN7WebCore14StorageTracker32syncFileSystemAndTrackerDatabaseEv __ZN7WebCore14endOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE +__ZN7WebCore15AffineTransformC1Edd __ZN7WebCore15ArchiveResource6createEN3WTF10PassRefPtrINS_12SharedBufferEEERKNS_4KURLERKNS1_6StringESA_SA_RKNS_16ResourceResponseE __ZN7WebCore15DOMWrapperWorld13clearWrappersEv __ZN7WebCore15DOMWrapperWorldD1Ev @@ -1121,6 +1122,7 @@ __ZNK7WebCore10ScrollView16windowToContentsERKNS_8IntPointE __ZNK7WebCore10ScrollView18visibleContentRectEb __ZNK7WebCore10ScrollView18contentsToRootViewERKNS_7IntRectE +__ZNK7WebCore10ScrollView18contentsToRootViewERKNS_8IntPointE __ZN7WebCore11CachedImage5imageEv __ZNK7WebCore11FrameLoader10isCompleteEv __ZNK7WebCore11FrameLoader14cancelledErrorERKNS_15ResourceRequestE Modified: trunk/Source/WebKit2/ChangeLog (98663 => 98664) --- trunk/Source/WebKit2/ChangeLog 2011-10-28 00:01:45 UTC (rev 98663) +++ trunk/Source/WebKit2/ChangeLog 2011-10-28 00:18:55 UTC (rev 98664) @@ -1,3 +1,47 @@ +2011-10-27 Anders Carlsson + +Add a Plugin::geometryDidChange that will work with transforms +https://bugs.webkit.org/show_bug.cgi?id=71072 + +Reviewed by Simon Fraser. + +Add a new Plugin::geometryDidChange pure virtual member function, that takes +the size of the plug-in, the clip rect (in plug-in coordinates), and a matrix that makes +it possible to convert between root view coordinates and plug-in coordinates. + +PluginView only calls this new geometryDidChange member function if +Plugin::wantsWindowRelativeCoordinates returns false, which is only true for BuiltInPDFView right now. + +* WebProcess/Plu
[webkit-changes] [98663] trunk/LayoutTests
Title: [98663] trunk/LayoutTests Revision 98663 Author john...@google.com Date 2011-10-27 17:01:45 -0700 (Thu, 27 Oct 2011) Log Message Unreviewed, gardening chromium. * platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added. * platform/chromium-mac-snowleopard/fast/table: Added. * platform/chromium-mac-snowleopard/fast/table/border-collapsing: Added. * platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added. * platform/chromium-win-vista/fast/css/getComputedStyle: Removed. * platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed. * platform/chromium-win-xp/fast/css/getComputedStyle: Removed. * platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed. * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: * platform/chromium/fast/css/getComputedStyle: Removed. * platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Removed. * platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed. * platform/chromium/svg/css: Removed. * platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Removed. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt Added Paths trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/border-collapsing/ trunk/LayoutTests/platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png Removed Paths trunk/LayoutTests/platform/chromium/fast/css/getComputedStyle/ trunk/LayoutTests/platform/chromium/svg/css/ trunk/LayoutTests/platform/chromium-win-vista/fast/css/getComputedStyle/ trunk/LayoutTests/platform/chromium-win-xp/fast/css/getComputedStyle/ Diff Modified: trunk/LayoutTests/ChangeLog (98662 => 98663) --- trunk/LayoutTests/ChangeLog 2011-10-28 00:00:41 UTC (rev 98662) +++ trunk/LayoutTests/ChangeLog 2011-10-28 00:01:45 UTC (rev 98663) @@ -1,3 +1,25 @@ +2011-10-27 John Gregg + +Unreviewed, gardening chromium. + +* platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added. +* platform/chromium-mac-snowleopard/fast/table: Added. +* platform/chromium-mac-snowleopard/fast/table/border-collapsing: Added. +* platform/chromium-mac-snowleopard/fullscreen/full-screen-render-inline-expected.png: Added. +* platform/chromium-win-vista/fast/css/getComputedStyle: Removed. +* platform/chromium-win-vista/fast/css/getComputedStyle/computed-style-expected.txt: Removed. +* platform/chromium-win-xp/fast/css/getComputedStyle: Removed. +* platform/chromium-win-xp/fast/css/getComputedStyle/computed-style-expected.txt: Removed. +* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt: +* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt: +* platform/chromium/fast/css/getComputedStyle: Removed. +* platform/chromium/fast/css/getComputedStyle/computed-style-expected.txt: Removed. +* platform/chromium/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed. +* platform/chromium/svg/css: Removed. +* platform/chromium/svg/css/getComputedStyle-basic-expected.txt: Removed. +* platform/chromium/test_expectations.txt: + 2011-10-27 Kenneth Russell Implement new restrictions on uniform and attribute location lengths Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98662 => 98663) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 00:00:41 UTC (rev 98662) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-28 00:01:45 UTC (rev 98663) @@ -42,8 +42,9 @@ BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/Window/window-postmessage-clone-deep-array.html = PASS BUGCR24182 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/calculate-percentage.html = PASS -BUGCR24182 SLOW DEBUG SNOWLEOPARD : svg/hixie/perf/007.xml = PASS -BUGCR24182 DEBUG LEOPARD : svg/hixie/perf/007.xml
[webkit-changes] [98661] trunk/Source/WebCore
Title: [98661] trunk/Source/WebCore
Revision 98661
Author aba...@webkit.org
Date 2011-10-27 16:58:36 -0700 (Thu, 27 Oct 2011)
Log Message
Exception subtypes have incorrect namespace indentation
https://bugs.webkit.org/show_bug.cgi?id=71075
Reviewed by Eric Seidel.
This patch is in preparation for editing these headers. We decided to
not indent namespaces in headers and update the headers as we edited
them.
* dom/DOMCoreException.h:
(WebCore::DOMCoreException::create):
(WebCore::DOMCoreException::DOMCoreException):
* dom/EventException.h:
(WebCore::EventException::create):
(WebCore::EventException::EventException):
* dom/RangeException.h:
(WebCore::RangeException::create):
(WebCore::RangeException::RangeException):
* xml/XMLHttpRequestException.h:
(WebCore::XMLHttpRequestException::create):
(WebCore::XMLHttpRequestException::XMLHttpRequestException):
* xml/XPathException.h:
(WebCore::XPathException::create):
(WebCore::XPathException::XPathException):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DOMCoreException.h
trunk/Source/WebCore/dom/EventException.h
trunk/Source/WebCore/dom/RangeException.h
trunk/Source/WebCore/xml/XMLHttpRequestException.h
trunk/Source/WebCore/xml/XPathException.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98660 => 98661)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 23:55:11 UTC (rev 98660)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 23:58:36 UTC (rev 98661)
@@ -1,3 +1,30 @@
+2011-10-27 Adam Barth
+
+Exception subtypes have incorrect namespace indentation
+https://bugs.webkit.org/show_bug.cgi?id=71075
+
+Reviewed by Eric Seidel.
+
+This patch is in preparation for editing these headers. We decided to
+not indent namespaces in headers and update the headers as we edited
+them.
+
+* dom/DOMCoreException.h:
+(WebCore::DOMCoreException::create):
+(WebCore::DOMCoreException::DOMCoreException):
+* dom/EventException.h:
+(WebCore::EventException::create):
+(WebCore::EventException::EventException):
+* dom/RangeException.h:
+(WebCore::RangeException::create):
+(WebCore::RangeException::RangeException):
+* xml/XMLHttpRequestException.h:
+(WebCore::XMLHttpRequestException::create):
+(WebCore::XMLHttpRequestException::XMLHttpRequestException):
+* xml/XPathException.h:
+(WebCore::XPathException::create):
+(WebCore::XPathException::XPathException):
+
2011-10-27 Kenneth Russell
Implement new restrictions on uniform and attribute location lengths
Modified: trunk/Source/WebCore/dom/DOMCoreException.h (98660 => 98661)
--- trunk/Source/WebCore/dom/DOMCoreException.h 2011-10-27 23:55:11 UTC (rev 98660)
+++ trunk/Source/WebCore/dom/DOMCoreException.h 2011-10-27 23:58:36 UTC (rev 98661)
@@ -33,19 +33,19 @@
namespace WebCore {
-class DOMCoreException : public ExceptionBase {
-public:
-static PassRefPtr create(const ExceptionCodeDescription& description)
-{
-return adoptRef(new DOMCoreException(description));
-}
+class DOMCoreException : public ExceptionBase {
+public:
+static PassRefPtr create(const ExceptionCodeDescription& description)
+{
+return adoptRef(new DOMCoreException(description));
+}
-private:
-DOMCoreException(const ExceptionCodeDescription& description)
-: ExceptionBase(description)
-{
-}
-};
+private:
+DOMCoreException(const ExceptionCodeDescription& description)
+: ExceptionBase(description)
+{
+}
+};
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/EventException.h (98660 => 98661)
--- trunk/Source/WebCore/dom/EventException.h 2011-10-27 23:55:11 UTC (rev 98660)
+++ trunk/Source/WebCore/dom/EventException.h 2011-10-27 23:58:36 UTC (rev 98661)
@@ -33,28 +33,28 @@
namespace WebCore {
-class EventException : public ExceptionBase {
-public:
-static PassRefPtr create(const ExceptionCodeDescription& description)
-{
-return adoptRef(new EventException(description));
-}
+class EventException : public ExceptionBase {
+public:
+static PassRefPtr create(const ExceptionCodeDescription& description)
+{
+return adoptRef(new EventException(description));
+}
-static const int EventExceptionOffset = 100;
-static const int EventExceptionMax = 199;
+static const int EventExceptionOffset = 100;
+static const int EventExceptionMax = 199;
-enum EventExceptionCode {
-UNSPECIFIED_EVENT_TYPE_ERR = EventExceptionOffset,
-DISPATCH_REQUEST_ERR
-};
-
-private:
-EventException(const ExceptionCodeDescription& description)
-: ExceptionBase(description)
-{
-}
+enum EventExceptionCode {
+UNSPECIFIED_EVENT_TYPE_ERR = EventExceptionOffset,
+D
[webkit-changes] [98660] trunk
Title: [98660] trunk
Revision 98660
Author k...@google.com
Date 2011-10-27 16:55:11 -0700 (Thu, 27 Oct 2011)
Log Message
Implement new restrictions on uniform and attribute location lengths
https://bugs.webkit.org/show_bug.cgi?id=70981
Reviewed by Chris Marrin.
Source/WebCore:
Tests: fast/canvas/webgl/attrib-location-length-limits.html
fast/canvas/webgl/uniform-location-length-limits.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::validateLocationLength):
* html/canvas/WebGLRenderingContext.h:
LayoutTests:
* fast/canvas/webgl/attrib-location-length-limits-expected.txt: Added.
* fast/canvas/webgl/attrib-location-length-limits.html: Added (imported from WebGL conformance suite).
* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
(WebGLTestUtils.): Updated to latest version in WebGL conformance suite.
* fast/canvas/webgl/uniform-location-length-limits-expected.txt: Added.
* fast/canvas/webgl/uniform-location-length-limits.html: Added (imported from WebGL conformance suite).
* platform/mac/Skipped: Temporarily skip new tests on Mac until WebKit's copy of ANGLE is upgraded.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/resources/webgl-test-utils.js
trunk/LayoutTests/platform/mac/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.h
Added Paths
trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits-expected.txt
trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits.html
trunk/LayoutTests/fast/canvas/webgl/uniform-location-length-limits-expected.txt
trunk/LayoutTests/fast/canvas/webgl/uniform-location-length-limits.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98659 => 98660)
--- trunk/LayoutTests/ChangeLog 2011-10-27 23:38:09 UTC (rev 98659)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 23:55:11 UTC (rev 98660)
@@ -1,3 +1,19 @@
+2011-10-27 Kenneth Russell
+
+Implement new restrictions on uniform and attribute location lengths
+https://bugs.webkit.org/show_bug.cgi?id=70981
+
+Reviewed by Chris Marrin.
+
+* fast/canvas/webgl/attrib-location-length-limits-expected.txt: Added.
+* fast/canvas/webgl/attrib-location-length-limits.html: Added (imported from WebGL conformance suite).
+* fast/canvas/webgl/resources/webgl-test-utils.js:
+(WebGLTestUtils):
+(WebGLTestUtils.): Updated to latest version in WebGL conformance suite.
+* fast/canvas/webgl/uniform-location-length-limits-expected.txt: Added.
+* fast/canvas/webgl/uniform-location-length-limits.html: Added (imported from WebGL conformance suite).
+* platform/mac/Skipped: Temporarily skip new tests on Mac until WebKit's copy of ANGLE is upgraded.
+
2011-10-27 Rafael Weinstein
[MutationObservers] Implement subtree observation of transiently disconnected nodes
@@ -410,7 +426,6 @@
* platform/efl/tables: [...]
->>> .r98598
2011-10-27 Philippe Normand
Unreviewed, GTK rebaseline.
Added: trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits-expected.txt (0 => 98660)
--- trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits-expected.txt 2011-10-27 23:55:11 UTC (rev 98660)
@@ -0,0 +1,18 @@
+Verify limits on the lengths of attrib locations.
+Test attrib location underneath the length limit
+PASS gl.getProgramParameter(program, gl.LINK_STATUS) is true
+PASS attrib location should not be -1
+PASS getError was expected value: NO_ERROR :
+Test attrib location over the length limit
+Shader compilation should fail
+PASS wtu.loadShaderFromScript(gl, "badVertexShader", gl.VERTEX_SHADER, function (err) {}) is null
+PASS getError was expected value: NO_ERROR :
+Attempt to bind too-long attrib location should produce error
+PASS getError was expected value: INVALID_VALUE :
+Attempt to fetch too-long attrib location should produce error
+PASS gl.getAttribLocation(program, "vPosition01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567") is -1
+PASS getError was expected value: INVALID_VALUE :
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits.html (0 => 98660)
--- trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/webgl/attrib-location-length-limits.html 2011-10-27 23
[webkit-changes] [98659] trunk
Title: [98659] trunk Revision 98659 Author commit-qu...@webkit.org Date 2011-10-27 16:38:09 -0700 (Thu, 27 Oct 2011) Log Message [MutationObservers] Implement subtree observation of transiently disconnected nodes https://bugs.webkit.org/show_bug.cgi?id=70788 Patch by Rafael Weinstein on 2011-10-27 Reviewed by Ryosuke Niwa. Source/WebCore: This patch adds support for observing all descendant nodes reachable from a subtree observation until delivery of mutations -- even if they become detached. We do this by introducing a "transient registration" which can exist for a short time along side normal registrations on Node. Transient registrations have a reference to the node which "owns" the subtree observation registration (the "registrationNode"). Transient registrations are cleared immediately before mutations are delivered to an observer, or when the observer re-observes at the registrationNode, in-effect resetting the observation. New tests added to fast/mutation/observe-subtree.html. * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): * dom/ChildListMutationScope.cpp: (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::ChildListMutationAccumulator): (WebCore::MutationAccumulationRouter::ChildListMutationAccumulator::enqueueMutationRecord): (WebCore::MutationAccumulationRouter::MutationAccumulationRouter::incrementScopingLevel): * dom/ContainerNode.cpp: (WebCore::dispatchChildRemovalEvents): * dom/Element.cpp: (WebCore::enqueueAttributesMutationRecord): * dom/Node.cpp: (WebCore::addMatchingObservers): (WebCore::Node::getRegisteredMutationObserversOfType): (WebCore::Node::registerMutationObserver): (WebCore::Node::unregisterMutationObserver): (WebCore::Node::notifySubtreeObserversOfDisconnection): * dom/Node.h: * dom/NodeRareData.h: (WebCore::MutationObserverEntry::MutationObserverEntry): (WebCore::MutationObserverEntry::operator==): * dom/WebKitMutationObserver.cpp: (WebCore::WebKitMutationObserver::observe): (WebCore::unregisterTransientEntries): (WebCore::WebKitMutationObserver::disconnect): (WebCore::WebKitMutationObserver::observedNodeDestructed): (WebCore::WebKitMutationObserver::observedSubtreeWillDisconnect): (WebCore::WebKitMutationObserver::clearTransientEntries): (WebCore::WebKitMutationObserver::deliver): * dom/WebKitMutationObserver.h: LayoutTests: Added tests which assert that nodes can be detached from a subtree where observation is registered and still be observed -- until the end of the current "microtask". * fast/mutation/observe-subtree-expected.txt: * fast/mutation/observe-subtree.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/mutation/observe-subtree-expected.txt trunk/LayoutTests/fast/mutation/observe-subtree.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/CharacterData.cpp trunk/Source/WebCore/dom/ChildListMutationScope.cpp trunk/Source/WebCore/dom/ContainerNode.cpp trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/NodeRareData.h trunk/Source/WebCore/dom/WebKitMutationObserver.cpp trunk/Source/WebCore/dom/WebKitMutationObserver.h Diff Modified: trunk/LayoutTests/ChangeLog (98658 => 98659) --- trunk/LayoutTests/ChangeLog 2011-10-27 23:35:43 UTC (rev 98658) +++ trunk/LayoutTests/ChangeLog 2011-10-27 23:38:09 UTC (rev 98659) @@ -1,3 +1,16 @@ +2011-10-27 Rafael Weinstein + +[MutationObservers] Implement subtree observation of transiently disconnected nodes +https://bugs.webkit.org/show_bug.cgi?id=70788 + +Reviewed by Ryosuke Niwa. + +Added tests which assert that nodes can be detached from a subtree where observation is registered +and still be observed -- until the end of the current "microtask". + +* fast/mutation/observe-subtree-expected.txt: +* fast/mutation/observe-subtree.html: + 2011-10-27 Filip Pizlo If the bytecode generator emits code after the return in the first basic block, Modified: trunk/LayoutTests/fast/mutation/observe-subtree-expected.txt (98658 => 98659) --- trunk/LayoutTests/fast/mutation/observe-subtree-expected.txt 2011-10-27 23:35:43 UTC (rev 98658) +++ trunk/LayoutTests/fast/mutation/observe-subtree-expected.txt 2011-10-27 23:38:09 UTC (rev 98659) @@ -33,6 +33,48 @@ PASS mutations[0].attributeName is "foo" PASS mutations[0].attributeNamespace is null +Testing that transiently detached nodes are still observed via subtree. +...both changes should be received. Change detached subDiv again. +PASS mutations.length is 2 +PASS mutations[0].type is "attributes" +PASS mutations[0].target is subDiv +PASS mutations[0].attributeName is "foo" +PASS mutations[1].type is "attributes" +PASS mutations[1].target is subDiv +PASS mutations[1].attributeName is "test" +...transient subtree observation was stopped after delivery, so subDiv change should not be received. Reattach and change again. +PASS mutations is null +...reatta
[webkit-changes] [98658] trunk
Title: [98658] trunk Revision 98658 Author fpi...@apple.com Date 2011-10-27 16:35:43 -0700 (Thu, 27 Oct 2011) Log Message If the bytecode generator emits code after the return in the first basic block, DFG's inliner crashes https://bugs.webkit.org/show_bug.cgi?id=71071 Source/_javascript_Core: Reviewed by Gavin Barraclough. Removed some cruft dealing with parsing failures due to unsupported functionality (that's never reached anymore due to it being caught in DFGCapabilities). This allowed me to repurpose the bool return from parseBlock() to mean: true if we should continue to parse, or false if we've already parsed all live code. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (JSC::DFG::ByteCodeParser::parseBlock): (JSC::DFG::ByteCodeParser::parseCodeBlock): LayoutTests: Reviewed by Gavin Barraclough. * fast/js/dfg-inline-early-return-expected.txt: Added. * fast/js/dfg-inline-early-return.html: Added. * fast/js/script-tests/dfg-inline-early-return.js: Added. (foo): (bar): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp Added Paths trunk/LayoutTests/fast/js/dfg-inline-early-return-expected.txt trunk/LayoutTests/fast/js/dfg-inline-early-return.html trunk/LayoutTests/fast/js/script-tests/dfg-inline-early-return.js Diff Modified: trunk/LayoutTests/ChangeLog (98657 => 98658) --- trunk/LayoutTests/ChangeLog 2011-10-27 23:24:59 UTC (rev 98657) +++ trunk/LayoutTests/ChangeLog 2011-10-27 23:35:43 UTC (rev 98658) @@ -1,3 +1,17 @@ +2011-10-27 Filip Pizlo + +If the bytecode generator emits code after the return in the first basic block, +DFG's inliner crashes +https://bugs.webkit.org/show_bug.cgi?id=71071 + +Reviewed by Gavin Barraclough. + +* fast/js/dfg-inline-early-return-expected.txt: Added. +* fast/js/dfg-inline-early-return.html: Added. +* fast/js/script-tests/dfg-inline-early-return.js: Added. +(foo): +(bar): + 2011-10-27 John Gregg Unreviewed, new chromium expectations for shading/anti-aliasing changes. Added: trunk/LayoutTests/fast/js/dfg-inline-early-return-expected.txt (0 => 98658) --- trunk/LayoutTests/fast/js/dfg-inline-early-return-expected.txt (rev 0) +++ trunk/LayoutTests/fast/js/dfg-inline-early-return-expected.txt 2011-10-27 23:35:43 UTC (rev 98658) @@ -0,0 +1,11 @@ +This tests that an early return in the first basic block does not crash the DFG's bytecode parser whilst inlining. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +PASS foo(42) is 42 +PASS bar(42) is 42 +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/js/dfg-inline-early-return.html (0 => 98658) --- trunk/LayoutTests/fast/js/dfg-inline-early-return.html (rev 0) +++ trunk/LayoutTests/fast/js/dfg-inline-early-return.html 2011-10-27 23:35:43 UTC (rev 98658) @@ -0,0 +1,10 @@ + + + +
[webkit-changes] [98657] trunk/Source/WebCore
Title: [98657] trunk/Source/WebCore
Revision 98657
Author psola...@apple.com
Date 2011-10-27 16:24:59 -0700 (Thu, 27 Oct 2011)
Log Message
Ask CG to not parse image metadata
https://bugs.webkit.org/show_bug.cgi?id=71029
Reviewed by Simon Fraser.
We don't need CG to parse the image metadata since WebCore never uses it. Passing this
option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. Under Instruments I
saw the time drop from ~75ms to ~25ms when loading http://boston.com/bigpicture and the
first link on that page.
No new tests because no change in functionality.
* platform/graphics/ImageSource.h:
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::imageSourceOptions):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ImageSource.h
trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98656 => 98657)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 23:15:04 UTC (rev 98656)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 23:24:59 UTC (rev 98657)
@@ -1,3 +1,27 @@
+2011-10-27 Pratik Solanki
+
+Ask CG to not parse image metadata
+https://bugs.webkit.org/show_bug.cgi?id=71029
+
+Reviewed by Simon Fraser.
+
+We don't need CG to parse the image metadata since WebCore never uses it. Passing this
+option shaves off time spent under CGImageSourceCopyPropertiesAtIndex. Under Instruments I
+saw the time drop from ~75ms to ~25ms when loading http://boston.com/bigpicture and the
+first link on that page.
+
+No new tests because no change in functionality.
+
+* platform/graphics/ImageSource.h:
+* platform/graphics/cg/ImageSourceCG.cpp:
+(WebCore::imageSourceOptions):
+(WebCore::ImageSource::isSizeAvailable):
+(WebCore::ImageSource::frameSizeAtIndex):
+(WebCore::ImageSource::getHotSpot):
+(WebCore::ImageSource::repetitionCount):
+(WebCore::ImageSource::createFrameAtIndex):
+(WebCore::ImageSource::frameDurationAtIndex):
+
2011-10-27 David Grogan
Move eventqueue from Document to ScriptExecutionContext so that it can be accessed from workers
Modified: trunk/Source/WebCore/platform/graphics/ImageSource.h (98656 => 98657)
--- trunk/Source/WebCore/platform/graphics/ImageSource.h 2011-10-27 23:15:04 UTC (rev 98656)
+++ trunk/Source/WebCore/platform/graphics/ImageSource.h 2011-10-27 23:24:59 UTC (rev 98657)
@@ -126,6 +126,13 @@
GammaAndColorProfileIgnored
};
+#if USE(CG)
+enum ShouldSkipMetaData {
+DoNotSkipMetaData,
+SkipMetaData
+};
+#endif
+
ImageSource(AlphaOption alphaOption = AlphaPremultiplied, GammaAndColorProfileOption gammaAndColorProfileOption = GammaAndColorProfileApplied);
~ImageSource();
Modified: trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp (98656 => 98657)
--- trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2011-10-27 23:15:04 UTC (rev 98656)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp 2011-10-27 23:24:59 UTC (rev 98657)
@@ -41,6 +41,7 @@
namespace WebCore {
const CFStringRef kCGImageSourceShouldPreferRGB32 = CFSTR("kCGImageSourceShouldPreferRGB32");
+const CFStringRef kCGImageSourceSkipMetaData = CFSTR("kCGImageSourceSkipMetaData");
// kCGImagePropertyGIFUnclampedDelayTime is available in the ImageIO framework headers on some versions
// of SnowLeopard. It's not possible to detect whether the constant is available so we define our own here
@@ -107,14 +108,15 @@
setData(data, allDataReceived);
}
-static CFDictionaryRef imageSourceOptions()
+static CFDictionaryRef imageSourceOptions(ImageSource::ShouldSkipMetaData skipMetaData)
{
static CFDictionaryRef options;
if (!options) {
-const unsigned numOptions = 2;
-const void* keys[numOptions] = { kCGImageSourceShouldCache, kCGImageSourceShouldPreferRGB32 };
-const void* values[numOptions] = { kCFBooleanTrue, kCFBooleanTrue };
+const unsigned numOptions = 3;
+const CFBooleanRef imageSourceSkipMetaData = (skipMetaData == ImageSource::SkipMetaData) ? kCFBooleanTrue : kCFBooleanFalse;
+const void* keys[numOptions] = { kCGImageSourceShouldCache, kCGImageSourceShouldPreferRGB32, kCGImageSourceSkipMetaData };
+const void* values[numOptions] = { kCFBooleanTrue, kCFBooleanTrue, imageSourceSkipMetaData };
options = CFDictionaryCreate(NULL, keys, values, numOptions,
&kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks);
}
@@ -172,7 +174,7 @@
// Ragnaros yells: TOO SOON! You have awakened me TOO SOON, Executus!
if (imageSourc
[webkit-changes] [98654] trunk/Source/WebCore
Title: [98654] trunk/Source/WebCore
Revision 98654
Author commit-qu...@webkit.org
Date 2011-10-27 16:06:26 -0700 (Thu, 27 Oct 2011)
Log Message
[GStreamer] Prevent memory leak when fullscreening a video
https://bugs.webkit.org/show_bug.cgi?id=71043
Patch by Jonathon Jongsma on 2011-10-27
Reviewed by Gustavo Noronha Silva.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98653 => 98654)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 23:03:08 UTC (rev 98653)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 23:06:26 UTC (rev 98654)
@@ -1,3 +1,16 @@
+2011-10-27 Jonathon Jongsma
+
+[GStreamer] Prevent memory leak when fullscreening a video
+https://bugs.webkit.org/show_bug.cgi?id=71043
+
+Reviewed by Gustavo Noronha Silva.
+
+* platform/graphics/gstreamer/GStreamerGWorld.cpp:
+(WebCore::GStreamerGWorld::GStreamerGWorld):
+(WebCore::GStreamerGWorld::enterFullscreen):
+(WebCore::GStreamerGWorld::exitFullscreen):
+* platform/graphics/gstreamer/GStreamerGWorld.h:
+
2011-10-27 Joseph Pecoraro
Reviewed by David Kilzer.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp (98653 => 98654)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp 2011-10-27 23:03:08 UTC (rev 98653)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp 2011-10-27 23:06:26 UTC (rev 98654)
@@ -57,7 +57,6 @@
GStreamerGWorld::GStreamerGWorld(GstElement* pipeline)
: m_pipeline(pipeline)
-, m_dynamicPadName(0)
{
// XOverlay messages need to be handled synchronously.
GstBus* bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
@@ -105,7 +104,7 @@
gst_pad_link(srcPad, sinkPad);
gst_object_unref(GST_OBJECT(sinkPad));
-m_dynamicPadName = gst_pad_get_name(srcPad);
+m_dynamicPadName.set(gst_pad_get_name(srcPad));
// Synchronize the new elements with pipeline state. If it's
// paused limit the state change to pre-rolling.
@@ -164,7 +163,7 @@
GstElement* videoScale = gst_bin_get_by_name(GST_BIN(videoSink.get()), "videoScale");
// Get pads to unlink and remove.
-GstPad* srcPad = gst_element_get_static_pad(tee, m_dynamicPadName);
+GstPad* srcPad = gst_element_get_static_pad(tee, m_dynamicPadName.get());
GstPad* sinkPad = gst_element_get_static_pad(queue, "sink");
// Block data flow towards the pipeline branch to remove. No need
@@ -195,7 +194,7 @@
gst_object_unref(platformVideoSink);
gst_object_unref(tee);
-m_dynamicPadName = 0;
+m_dynamicPadName.clear();
}
void GStreamerGWorld::setWindowOverlay(GstMessage* message)
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h (98653 => 98654)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h 2011-10-27 23:03:08 UTC (rev 98653)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h 2011-10-27 23:06:26 UTC (rev 98654)
@@ -22,6 +22,7 @@
#define GStreamerGWorld_h
#if ENABLE(VIDEO) && USE(GSTREAMER)
+#include "GOwnPtr.h"
#include "PlatformVideoWindow.h"
#include "RefCounted.h"
#include "RefPtr.h"
@@ -60,7 +61,7 @@
GStreamerGWorld(GstElement*);
GstElement* m_pipeline;
RefPtr m_videoWindow;
-gchar* m_dynamicPadName;
+GOwnPtr m_dynamicPadName;
};
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98653] branches/subpixellayout/Source/WebCore
Title: [98653] branches/subpixellayout/Source/WebCore
Revision 98653
Author le...@chromium.org
Date 2011-10-27 16:03:08 -0700 (Thu, 27 Oct 2011)
Log Message
Fixing the Mac build by rolling out Region changes. Only RenderRegion needed the previous fix.
Modified Paths
branches/subpixellayout/Source/WebCore/WebCore.exp.in
branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp
branches/subpixellayout/Source/WebCore/platform/graphics/Region.h
Diff
Modified: branches/subpixellayout/Source/WebCore/WebCore.exp.in (98652 => 98653)
--- branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-27 22:51:40 UTC (rev 98652)
+++ branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-27 23:03:08 UTC (rev 98653)
@@ -850,8 +850,8 @@
__ZN7WebCore6Region5uniteERKS0_
__ZN7WebCore6Region8subtractERKS0_
__ZN7WebCore6Region9intersectERKS0_
-__ZN7WebCore6Region9translateERKNS_9FixedSizeE
-__ZN7WebCore6RegionC1ERKNS_9FixedRectE
+__ZN7WebCore6Region9translateERKNS_7IntSizeE
+__ZN7WebCore6RegionC1ERKNS_7IntRectE
__ZN7WebCore6RegionC1Ev
__ZN7WebCore6Widget12setFrameRectERKNS_9FixedRectE
__ZN7WebCore6Widget16removeFromParentEv
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp (98652 => 98653)
--- branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp 2011-10-27 22:51:40 UTC (rev 98652)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp 2011-10-27 23:03:08 UTC (rev 98653)
@@ -40,25 +40,25 @@
{
}
-Region::Region(const LayoutRect& rect)
+Region::Region(const IntRect& rect)
: m_bounds(rect)
, m_shape(rect)
{
}
-Vector Region::rects() const
+Vector Region::rects() const
{
-Vector rects;
+Vector rects;
for (Shape::SpanIterator span = m_shape.spans_begin(), end = m_shape.spans_end(); span != end && span + 1 != end; ++span) {
-LayoutUnit y = span->y;
-LayoutUnit height = (span + 1)->y - y;
+int y = span->y;
+int height = (span + 1)->y - y;
for (Shape::SegmentIterator segment = m_shape.segments_begin(span), end = m_shape.segments_end(span); segment != end && segment + 1 != end; segment += 2) {
-LayoutUnit x = *segment;
-LayoutUnit width = *(segment + 1) - x;
+int x = *segment;
+int width = *(segment + 1) - x;
-rects.append(LayoutRect(x, y, width, height));
+rects.append(IntRect(x, y, width, height));
}
}
@@ -69,7 +69,7 @@
{
}
-Region::Shape::Shape(const LayoutRect& rect)
+Region::Shape::Shape(const IntRect& rect)
{
appendSpan(rect.y());
appendSegment(rect.x());
@@ -77,7 +77,7 @@
appendSpan(rect.maxY());
}
-void Region::Shape::appendSpan(LayoutUnit y)
+void Region::Shape::appendSpan(int y)
{
m_spans.append(Span(y, m_segments.size()));
}
@@ -102,7 +102,7 @@
return true;
}
-void Region::Shape::appendSpan(LayoutUnit y, SegmentIterator begin, SegmentIterator end)
+void Region::Shape::appendSpan(int y, SegmentIterator begin, SegmentIterator end)
{
if (canCoalesce(begin, end))
return;
@@ -117,7 +117,7 @@
appendSpan(it->y, shape.segments_begin(it), shape.segments_end(it));
}
-void Region::Shape::appendSegment(LayoutUnit x)
+void Region::Shape::appendSegment(int x)
{
m_segments.append(x);
}
@@ -164,10 +164,10 @@
void Region::Shape::dump() const
{
for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span != end; ++span) {
-printf("%6d: (", span->y.toInt());
+printf("%6d: (", span->y);
for (Shape::SegmentIterator segment = segments_begin(span), end = segments_end(span); segment != end; ++segment)
-printf("%d ", segment->toInt());
+printf("%d ", *segment);
printf(")\n");
}
@@ -175,19 +175,19 @@
}
#endif
-LayoutRect Region::Shape::bounds() const
+IntRect Region::Shape::bounds() const
{
if (isEmpty())
-return LayoutRect();
+return IntRect();
SpanIterator span = spans_begin();
-LayoutUnit minY = span->y;
+int minY = span->y;
SpanIterator lastSpan = spans_end() - 1;
-LayoutUnit maxY = lastSpan->y;
+int maxY = lastSpan->y;
-LayoutUnit minX = std::numeric_limits::max();
-LayoutUnit maxX = std::numeric_limits::min();
+int minX = std::numeric_limits::max();
+int maxX = std::numeric_limits::min();
while (span != lastSpan) {
SegmentIterator firstSegment = segments_begin(span);
@@ -209,10 +209,10 @@
ASSERT(minX <= maxX);
ASSERT(minY <= maxY);
-return LayoutRect(minX, minY, maxX - minX, maxY - minY);
+return IntRect(minX, minY, maxX - minX, maxY - minY);
}
-void Region::Shape::translate(const LayoutSize& offset)
+void Region::Shape::translate(const IntSize& offset)
{
for (size_t i = 0; i < m_segments.size(); ++i)
m_segments[i] += offset.width();
@@ -255,8 +255,8 @@
// Iterate over all spans.
while (s
[webkit-changes] [98652] trunk/Source
Title: [98652] trunk/Source Revision 98652 Author commit-qu...@webkit.org Date 2011-10-27 15:51:40 -0700 (Thu, 27 Oct 2011) Log Message Patch by Joseph Pecoraro on 2011-10-27 Reviewed by David Kilzer. Make FeatureDefines Identical Across OS X Projects https://bugs.webkit.org/show_bug.cgi?id=71051 Source/_javascript_Core: * Configurations/FeatureDefines.xcconfig: Source/WebCore: * Configurations/FeatureDefines.xcconfig: Source/WebKit/mac: * Configurations/FeatureDefines.xcconfig: Source/WebKit2: * Configurations/FeatureDefines.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98651 => 98652) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 22:38:31 UTC (rev 98651) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 22:51:40 UTC (rev 98652) @@ -1,3 +1,12 @@ +2011-10-27 Joseph Pecoraro + +Reviewed by David Kilzer. + +Make FeatureDefines Identical Across OS X Projects +https://bugs.webkit.org/show_bug.cgi?id=71051 + +* Configurations/FeatureDefines.xcconfig: + 2011-10-27 Filip Pizlo Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (98651 => 98652) --- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-10-27 22:38:31 UTC (rev 98651) +++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2011-10-27 22:51:40 UTC (rev 98652) @@ -73,10 +73,7 @@ ENABLE_ANIMATION_API = ; ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING; ENABLE_CSS3_FLEXBOX = ; -ENABLE_CSS_EXCLUSIONS = ; ENABLE_CSS_FILTERS = ENABLE_CSS_FILTERS; -ENABLE_CSS_REGIONS = ; -ENABLE_SQL_DATABASE = ENABLE_SQL_DATABASE; ENABLE_DATA_TRANSFER_ITEMS = ; ENABLE_DETAILS = ENABLE_DETAILS; ENABLE_DEVICE_ORIENTATION = ; @@ -101,7 +98,9 @@ ENABLE_PROGRESS_TAG = ENABLE_PROGRESS_TAG; ENABLE_QUOTA = ; ENABLE_REGISTER_PROTOCOL_HANDLER = ; +ENABLE_REQUEST_ANIMATION_FRAME = ENABLE_REQUEST_ANIMATION_FRAME; ENABLE_SHARED_WORKERS = ENABLE_SHARED_WORKERS; +ENABLE_SQL_DATABASE = ENABLE_SQL_DATABASE; ENABLE_SVG = ENABLE_SVG; ENABLE_SVG_FONTS = ENABLE_SVG_FONTS; ENABLE_TOUCH_ICON_LOADING = ; @@ -114,4 +113,4 @@ ENABLE_WORKERS = ENABLE_WORKERS; ENABLE_XSLT = ENABLE_XSLT; -FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_EXCLUSIONS) $(ENABLE_CSS_REGIONS) $(ENABLE_SQL_DATABASE) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_MUTATION_OBSERVERS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_SHARED_WORKERS) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XSLT); +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS3_FLEXBOX) $(ENABLE_CSS_FILTERS) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_MUTATION_OBSERVERS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API)
[webkit-changes] [98651] trunk/Source/WebKit/chromium
Title: [98651] trunk/Source/WebKit/chromium
Revision 98651
Author vse...@chromium.org
Date 2011-10-27 15:38:31 -0700 (Thu, 27 Oct 2011)
Log Message
Web Inspector: HTTP headers merged incorrect in Chrome
https://bugs.webkit.org/show_bug.cgi?id=69674
Reviewed by Pavel Feldman.
* src/WebHTTPLoadInfo.cpp:
(WebKit::addHeader):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (98650 => 98651)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-27 22:34:59 UTC (rev 98650)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-27 22:38:31 UTC (rev 98651)
@@ -1,3 +1,13 @@
+2011-10-27 Vsevolod Vlasov
+
+Web Inspector: HTTP headers merged incorrect in Chrome
+https://bugs.webkit.org/show_bug.cgi?id=69674
+
+Reviewed by Pavel Feldman.
+
+* src/WebHTTPLoadInfo.cpp:
+(WebKit::addHeader):
+
2011-10-27 Stephen Chenney
[Chromium] Need setPrinting
Modified: trunk/Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp (98650 => 98651)
--- trunk/Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp 2011-10-27 22:34:59 UTC (rev 98650)
+++ trunk/Source/WebKit/chromium/src/WebHTTPLoadInfo.cpp 2011-10-27 22:38:31 UTC (rev 98651)
@@ -105,7 +105,7 @@
{
pair result = map->add(name, value);
if (!result.second)
-result.first->second += "\n" + String(value);
+result.first->second += ", " + String(value);
}
void WebHTTPLoadInfo::addRequestHeader(const WebString& name, const WebString& value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98650] trunk/Source/WebCore
Title: [98650] trunk/Source/WebCore Revision 98650 Author commit-qu...@webkit.org Date 2011-10-27 15:34:59 -0700 (Thu, 27 Oct 2011) Log Message Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols https://bugs.webkit.org/show_bug.cgi?id=71047 Patch by Joseph Pecoraro on 2011-10-27 Reviewed by David Kilzer. * WebCore.exp.in: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in Diff Modified: trunk/Source/WebCore/ChangeLog (98649 => 98650) --- trunk/Source/WebCore/ChangeLog 2011-10-27 22:28:16 UTC (rev 98649) +++ trunk/Source/WebCore/ChangeLog 2011-10-27 22:34:59 UTC (rev 98650) @@ -1,3 +1,12 @@ +2011-10-27 Joseph Pecoraro + +Correctly Guard Exported REQUEST_ANIMATION_FRAME Symbols +https://bugs.webkit.org/show_bug.cgi?id=71047 + +Reviewed by David Kilzer. + +* WebCore.exp.in: + 2011-10-27 Sheriff Bot Unreviewed, rolling out r98626. Modified: trunk/Source/WebCore/WebCore.exp.in (98649 => 98650) --- trunk/Source/WebCore/WebCore.exp.in 2011-10-27 22:28:16 UTC (rev 98649) +++ trunk/Source/WebCore/WebCore.exp.in 2011-10-27 22:34:59 UTC (rev 98650) @@ -1015,7 +1015,6 @@ __ZN7WebCore9FrameView22setBaseBackgroundColorERKNS_5ColorE __ZN7WebCore9FrameView23updateCanHaveScrollbarsEv __ZN7WebCore9FrameView24forceLayoutForPaginationERKNS_9FloatSizeES3_fNS_19AdjustViewSizeOrNotE -__ZN7WebCore9FrameView25serviceScriptedAnimationsEy __ZN7WebCore9FrameView26adjustPageHeightDeprecatedEP __ZN7WebCore9FrameView29setShouldUpdateWhileOffscreenEb __ZN7WebCore9FrameView37updateLayoutAndStyleIfNeededRecursiveEv @@ -1860,6 +1859,10 @@ .objc_class_name_DOMSVGFilterElement #endif +#if ENABLE(REQUEST_ANIMATION_FRAME) +__ZN7WebCore9FrameView25serviceScriptedAnimationsEy +#endif + #if ENABLE(VIDEO) __ZN7WebCore16HTMLMediaElement12endScrubbingEv __ZN7WebCore16HTMLMediaElement14beginScrubbingEv ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98649] branches/subpixellayout/Source
Title: [98649] branches/subpixellayout/Source
Revision 98649
Author e...@chromium.org
Date 2011-10-27 15:28:16 -0700 (Thu, 27 Oct 2011)
Log Message
Qt/chromium linux fixes and cleanup
Modified Paths
branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp
branches/subpixellayout/Source/WebCore/plugins/PluginView.h
branches/subpixellayout/Source/WebCore/plugins/qt/PluginViewQt.cpp
branches/subpixellayout/Source/WebKit/chromium/src/ChromeClientImpl.h
branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.cpp
branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.h
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp (98648 => 98649)
--- branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp 2011-10-27 22:25:24 UTC (rev 98648)
+++ branches/subpixellayout/Source/WebCore/platform/chromium/ScrollbarThemeChromium.cpp 2011-10-27 22:28:16 UTC (rev 98649)
@@ -108,7 +108,7 @@
return; // nothing to draw on.
// Get the tickmarks for the frameview.
-Vector tickmarks;
+Vector tickmarks;
scrollbar->scrollableArea()->getTickmarks(tickmarks);
if (!tickmarks.size())
return;
@@ -122,7 +122,7 @@
context->save();
-for (Vector::const_iterator i = tickmarks.begin(); i != tickmarks.end(); ++i) {
+for (Vector::const_iterator i = tickmarks.begin(); i != tickmarks.end(); ++i) {
// Calculate how far down (in %) the tick-mark should appear.
const float percent = static_cast(i->y()) / scrollbar->totalSize();
Modified: branches/subpixellayout/Source/WebCore/plugins/PluginView.h (98648 => 98649)
--- branches/subpixellayout/Source/WebCore/plugins/PluginView.h 2011-10-27 22:25:24 UTC (rev 98648)
+++ branches/subpixellayout/Source/WebCore/plugins/PluginView.h 2011-10-27 22:28:16 UTC (rev 98649)
@@ -321,7 +321,7 @@
#endif // ENABLE(NETSCAPE_PLUGIN_API)
#endif
void updatePluginWidget();
-void paintMissingPluginIcon(GraphicsContext*, const IntRect&);
+void paintMissingPluginIcon(GraphicsContext*, const LayoutRect&);
void handleKeyboardEvent(KeyboardEvent*);
void handleMouseEvent(MouseEvent*);
Modified: branches/subpixellayout/Source/WebCore/plugins/qt/PluginViewQt.cpp (98648 => 98649)
--- branches/subpixellayout/Source/WebCore/plugins/qt/PluginViewQt.cpp 2011-10-27 22:25:24 UTC (rev 98648)
+++ branches/subpixellayout/Source/WebCore/plugins/qt/PluginViewQt.cpp 2011-10-27 22:28:16 UTC (rev 98649)
@@ -341,7 +341,7 @@
painter->drawPixmap(QPoint(exposedRect.x(), exposedRect.y()), qtDrawable, exposedRect);
}
-void PluginView::paint(GraphicsContext* context, const IntRect& rect)
+void PluginView::paint(GraphicsContext* context, const LayoutRect& rect)
{
if (!m_isStarted) {
paintMissingPluginIcon(context, rect);
Modified: branches/subpixellayout/Source/WebKit/chromium/src/ChromeClientImpl.h (98648 => 98649)
--- branches/subpixellayout/Source/WebKit/chromium/src/ChromeClientImpl.h 2011-10-27 22:25:24 UTC (rev 98648)
+++ branches/subpixellayout/Source/WebKit/chromium/src/ChromeClientImpl.h 2011-10-27 22:28:16 UTC (rev 98649)
@@ -120,7 +120,7 @@
virtual void contentsSizeChanged(WebCore::Frame*, const WebCore::LayoutSize&) const;
virtual void layoutUpdated(WebCore::Frame*) const;
virtual void scrollRectIntoView(
-const WebCore::FixedRect&) const { }
+const WebCore::LayoutRect&) const { }
virtual void scrollbarsModeDidChange() const;
virtual void mouseDidMoveOverElement(
const WebCore::HitTestResult& result, unsigned modifierFlags);
Modified: branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.cpp (98648 => 98649)
--- branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.cpp 2011-10-27 22:25:24 UTC (rev 98648)
+++ branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.cpp 2011-10-27 22:28:16 UTC (rev 98649)
@@ -99,7 +99,7 @@
m_client->invalidateScrollbarRect(this, webrect);
}
-void WebScrollbarImpl::getTickmarks(Vector& tickmarks) const
+void WebScrollbarImpl::getTickmarks(Vector& tickmarks) const
{
WebVector ticks;
m_client->getTickmarks(const_cast(this), &ticks);
@@ -108,9 +108,9 @@
tickmarks[i] = LayoutRect(ticks[i]);
}
-WebCore::FixedPoint WebScrollbarImpl::convertFromContainingViewToScrollbar(const WebCore::FixedPoint& parentPoint) const
+LayoutPoint WebScrollbarImpl::convertFromContainingViewToScrollbar(const LayoutPoint& parentPoint) const
{
-WebCore::FixedPoint offset(parentPoint.x() - m_scrollbar->x(), parentPoint.y() - m_scrollbar->y());
+LayoutPoint offset(parentPoint.x() - m_scrollbar->x(), parentPoint.y() - m_scrollbar->y());
return m_scrollbar->Widget::convertFromContainingView(offset);
}
Modified: branches/subpixellayout/Source/WebKit/chromium/src/WebScrollbarImpl.h (98648 => 98649)
--- branches/su
[webkit-changes] [98648] branches/subpixellayout/Source/WebCore
Title: [98648] branches/subpixellayout/Source/WebCore
Revision 98648
Author le...@chromium.org
Date 2011-10-27 15:25:24 -0700 (Thu, 27 Oct 2011)
Log Message
Fixing region's usage of integers and INT_MAX with LayoutUnit-friendly versions
Modified Paths
branches/subpixellayout/Source/WebCore/WebCore.exp.in
branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp
branches/subpixellayout/Source/WebCore/platform/graphics/Region.h
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/WebCore.exp.in (98647 => 98648)
--- branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-27 22:19:14 UTC (rev 98647)
+++ branches/subpixellayout/Source/WebCore/WebCore.exp.in 2011-10-27 22:25:24 UTC (rev 98648)
@@ -850,8 +850,8 @@
__ZN7WebCore6Region5uniteERKS0_
__ZN7WebCore6Region8subtractERKS0_
__ZN7WebCore6Region9intersectERKS0_
-__ZN7WebCore6Region9translateERKNS_7IntSizeE
-__ZN7WebCore6RegionC1ERKNS_7IntRectE
+__ZN7WebCore6Region9translateERKNS_9FixedSizeE
+__ZN7WebCore6RegionC1ERKNS_9FixedRectE
__ZN7WebCore6RegionC1Ev
__ZN7WebCore6Widget12setFrameRectERKNS_9FixedRectE
__ZN7WebCore6Widget16removeFromParentEv
Modified: branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp (98647 => 98648)
--- branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp 2011-10-27 22:19:14 UTC (rev 98647)
+++ branches/subpixellayout/Source/WebCore/platform/graphics/Region.cpp 2011-10-27 22:25:24 UTC (rev 98648)
@@ -40,25 +40,25 @@
{
}
-Region::Region(const IntRect& rect)
+Region::Region(const LayoutRect& rect)
: m_bounds(rect)
, m_shape(rect)
{
}
-Vector Region::rects() const
+Vector Region::rects() const
{
-Vector rects;
+Vector rects;
for (Shape::SpanIterator span = m_shape.spans_begin(), end = m_shape.spans_end(); span != end && span + 1 != end; ++span) {
-int y = span->y;
-int height = (span + 1)->y - y;
+LayoutUnit y = span->y;
+LayoutUnit height = (span + 1)->y - y;
for (Shape::SegmentIterator segment = m_shape.segments_begin(span), end = m_shape.segments_end(span); segment != end && segment + 1 != end; segment += 2) {
-int x = *segment;
-int width = *(segment + 1) - x;
+LayoutUnit x = *segment;
+LayoutUnit width = *(segment + 1) - x;
-rects.append(IntRect(x, y, width, height));
+rects.append(LayoutRect(x, y, width, height));
}
}
@@ -69,7 +69,7 @@
{
}
-Region::Shape::Shape(const IntRect& rect)
+Region::Shape::Shape(const LayoutRect& rect)
{
appendSpan(rect.y());
appendSegment(rect.x());
@@ -77,7 +77,7 @@
appendSpan(rect.maxY());
}
-void Region::Shape::appendSpan(int y)
+void Region::Shape::appendSpan(LayoutUnit y)
{
m_spans.append(Span(y, m_segments.size()));
}
@@ -102,7 +102,7 @@
return true;
}
-void Region::Shape::appendSpan(int y, SegmentIterator begin, SegmentIterator end)
+void Region::Shape::appendSpan(LayoutUnit y, SegmentIterator begin, SegmentIterator end)
{
if (canCoalesce(begin, end))
return;
@@ -117,7 +117,7 @@
appendSpan(it->y, shape.segments_begin(it), shape.segments_end(it));
}
-void Region::Shape::appendSegment(int x)
+void Region::Shape::appendSegment(LayoutUnit x)
{
m_segments.append(x);
}
@@ -164,10 +164,10 @@
void Region::Shape::dump() const
{
for (Shape::SpanIterator span = spans_begin(), end = spans_end(); span != end; ++span) {
-printf("%6d: (", span->y);
+printf("%6d: (", span->y.toInt());
for (Shape::SegmentIterator segment = segments_begin(span), end = segments_end(span); segment != end; ++segment)
-printf("%d ", *segment);
+printf("%d ", segment->toInt());
printf(")\n");
}
@@ -175,19 +175,19 @@
}
#endif
-IntRect Region::Shape::bounds() const
+LayoutRect Region::Shape::bounds() const
{
if (isEmpty())
-return IntRect();
+return LayoutRect();
SpanIterator span = spans_begin();
-int minY = span->y;
+LayoutUnit minY = span->y;
SpanIterator lastSpan = spans_end() - 1;
-int maxY = lastSpan->y;
+LayoutUnit maxY = lastSpan->y;
-int minX = std::numeric_limits::max();
-int maxX = std::numeric_limits::min();
+LayoutUnit minX = std::numeric_limits::max();
+LayoutUnit maxX = std::numeric_limits::min();
while (span != lastSpan) {
SegmentIterator firstSegment = segments_begin(span);
@@ -209,10 +209,10 @@
ASSERT(minX <= maxX);
ASSERT(minY <= maxY);
-return IntRect(minX, minY, maxX - minX, maxY - minY);
+return LayoutRect(minX, minY, maxX - minX, maxY - minY);
}
-void Region::Shape::translate(const IntSize& offset)
+void Region::Shape::translate(const LayoutSize& offset)
{
for (size_t i = 0; i < m_segments.size(); ++i)
m_segments[i] += offset.width();
@@ -255,8 +255,8
[webkit-changes] [98647] trunk/Source/JavaScriptCore
Title: [98647] trunk/Source/_javascript_Core Revision 98647 Author fpi...@apple.com Date 2011-10-27 15:19:14 -0700 (Thu, 27 Oct 2011) Log Message Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic https://bugs.webkit.org/show_bug.cgi?id=71045 Reviewed by Geoff Garen. Make sure that if a structure is pinned, it also has a property map. * runtime/Structure.cpp: (JSC::Structure::changePrototypeTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::getterSetterTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition): (JSC::Structure::pin): (JSC::Structure::copyPropertyTableForPinning): * runtime/Structure.h: (JSC::Structure::materializePropertyMapIfNecessaryForPinning): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/Structure.cpp trunk/Source/_javascript_Core/runtime/Structure.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98646 => 98647) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 22:07:32 UTC (rev 98646) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 22:19:14 UTC (rev 98647) @@ -1,3 +1,25 @@ +2011-10-27 Filip Pizlo + +Crash in JSC::Structure::materializePropertyMap when viewing Garden-O-Matic +https://bugs.webkit.org/show_bug.cgi?id=71045 + +Reviewed by Geoff Garen. + +Make sure that if a structure is pinned, it also has a property map. + +* runtime/Structure.cpp: +(JSC::Structure::changePrototypeTransition): +(JSC::Structure::despecifyFunctionTransition): +(JSC::Structure::getterSetterTransition): +(JSC::Structure::toDictionaryTransition): +(JSC::Structure::preventExtensionsTransition): +(JSC::Structure::addPropertyWithoutTransition): +(JSC::Structure::removePropertyWithoutTransition): +(JSC::Structure::pin): +(JSC::Structure::copyPropertyTableForPinning): +* runtime/Structure.h: +(JSC::Structure::materializePropertyMapIfNecessaryForPinning): + 2011-10-27 Michael Saboff 32bit build failure after r98624 Modified: trunk/Source/_javascript_Core/runtime/Structure.cpp (98646 => 98647) --- trunk/Source/_javascript_Core/runtime/Structure.cpp 2011-10-27 22:07:32 UTC (rev 98646) +++ trunk/Source/_javascript_Core/runtime/Structure.cpp 2011-10-27 22:19:14 UTC (rev 98647) @@ -371,7 +371,7 @@ // Don't set m_offset, as one can not transition to this. structure->materializePropertyMapIfNecessary(globalData); -transition->m_propertyTable = structure->copyPropertyTable(globalData, transition); +transition->m_propertyTable = structure->copyPropertyTableForPinning(globalData, transition); transition->pin(); return transition; @@ -387,7 +387,7 @@ // Don't set m_offset, as one can not transition to this. structure->materializePropertyMapIfNecessary(globalData); -transition->m_propertyTable = structure->copyPropertyTable(globalData, transition); +transition->m_propertyTable = structure->copyPropertyTableForPinning(globalData, transition); transition->pin(); if (transition->m_specificFunctionThrashCount == maxSpecificFunctionThrashCount) @@ -407,7 +407,7 @@ // Don't set m_offset, as one can not transition to this. structure->materializePropertyMapIfNecessary(globalData); -transition->m_propertyTable = structure->copyPropertyTable(globalData, transition); +transition->m_propertyTable = structure->copyPropertyTableForPinning(globalData, transition); transition->pin(); return transition; @@ -420,7 +420,7 @@ Structure* transition = create(globalData, structure); structure->materializePropertyMapIfNecessary(globalData); -transition->m_propertyTable = structure->copyPropertyTable(globalData, transition); +transition->m_propertyTable = structure->copyPropertyTableForPinning(globalData, transition); transition->m_dictionaryKind = kind; transition->pin(); @@ -473,7 +473,7 @@ // Don't set m_offset, as one can not transition to this. structure->materializePropertyMapIfNecessary(globalData); -transition->m_propertyTable = structure->copyPropertyTable(globalData, transition); +transition->m_propertyTable = structure->copyPropertyTableForPinning(globalData, transition); transition->m_preventExtensions = true; transition->pin(); @@ -551,7 +551,7 @@ if (m_specificFunctionThrashCount == maxSpecificFunctionThrashCount) specificValue = 0; -materializePropertyMapIfNecessary(globalData); +materializePropertyMapIfNecessaryForPinning(globalData); pin(); @@ -566,7 +566,7 @@ ASSERT(isUncacheableDictionary()); ASSERT(!m_enumerationCache); -materializePropertyMapIfNecessary(globalData); +materializeP
[webkit-changes] [98646] trunk/Source/WebKit2
Title: [98646] trunk/Source/WebKit2
Revision 98646
Author ander...@apple.com
Date 2011-10-27 15:07:32 -0700 (Thu, 27 Oct 2011)
Log Message
Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71065
Reviewed by Simon Fraser.
In preparation for adding a version of geometryDidChange that doesn't take window coordinates.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::deprecatedGeometryDidChange):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
trunk/Source/WebKit2/WebProcess/Plugins/Plugin.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98645 => 98646)
--- trunk/Source/WebKit2/ChangeLog 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-27 22:07:32 UTC (rev 98646)
@@ -1,3 +1,27 @@
+2011-10-27 Anders Carlsson
+
+Rename Plugin::geometryDidChange to Plugin::deprecatedGeometryDidChange
+https://bugs.webkit.org/show_bug.cgi?id=71065
+
+Reviewed by Simon Fraser.
+
+In preparation for adding a version of geometryDidChange that doesn't take window coordinates.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::geometryDidChange):
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::deprecatedGeometryDidChange):
+* WebProcess/Plugins/Netscape/NetscapePlugin.h:
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+(WebKit::BuiltInPDFView::deprecatedGeometryDidChange):
+* WebProcess/Plugins/PDF/BuiltInPDFView.h:
+* WebProcess/Plugins/Plugin.h:
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::deprecatedGeometryDidChange):
+* WebProcess/Plugins/PluginProxy.h:
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewGeometryDidChange):
+
2011-10-27 Michael Saboff
Investigate storing strings in 8-bit buffers when possible
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (98645 => 98646)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -452,7 +452,7 @@
m_backingStore = ShareableBitmap::create(backingStoreHandle);
}
-m_plugin->geometryDidChange(frameRect, clipRect);
+m_plugin->deprecatedGeometryDidChange(frameRect, clipRect);
}
void PluginControllerProxy::didEvaluateJavaScript(uint64_t requestID, const String& result)
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 22:07:32 UTC (rev 98646)
@@ -660,7 +660,7 @@
return m_isTransparent;
}
-void NetscapePlugin::geometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
+void NetscapePlugin::deprecatedGeometryDidChange(const IntRect& frameRect, const IntRect& clipRect)
{
ASSERT(m_isStarted);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (98645 => 98646)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 22:05:17 UTC (rev 98645)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 22:07:32 UTC (rev 98646)
@@ -168,7 +168,7 @@
virtual PlatformLayer* pluginLayer();
#endif
virtual bool isTransparent();
-virtual void geometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
+virtual void deprecatedGeometryDidChange(const WebCore::IntRect& frameRect, const WebCore::IntRect& clipRect);
virtual void visibilityDidChange();
virtual void frameDidFinishLoading(uint64_t requestID);
virtual void frameDidFail(uint64_t requestID, bool w
[webkit-changes] [98645] trunk/Source/WebCore
Title: [98645] trunk/Source/WebCore Revision 98645 Author commit-qu...@webkit.org Date 2011-10-27 15:05:17 -0700 (Thu, 27 Oct 2011) Log Message Unreviewed, rolling out r98626. http://trac.webkit.org/changeset/98626 https://bugs.webkit.org/show_bug.cgi?id=71066 Does not compile on cr-win (Requested by jamesr_ on #webkit). Patch by Sheriff Bot on 2011-10-27 * platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs): * platform/graphics/skia/SkiaFontWin.cpp: (WebCore::paintSkiaText): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98644 => 98645) --- trunk/Source/WebCore/ChangeLog 2011-10-27 21:56:57 UTC (rev 98644) +++ trunk/Source/WebCore/ChangeLog 2011-10-27 22:05:17 UTC (rev 98645) @@ -1,3 +1,16 @@ +2011-10-27 Sheriff Bot + +Unreviewed, rolling out r98626. +http://trac.webkit.org/changeset/98626 +https://bugs.webkit.org/show_bug.cgi?id=71066 + +Does not compile on cr-win (Requested by jamesr_ on #webkit). + +* platform/graphics/chromium/FontChromiumWin.cpp: +(WebCore::Font::drawGlyphs): +* platform/graphics/skia/SkiaFontWin.cpp: +(WebCore::paintSkiaText): + 2011-10-27 Tony Chang Fix a compiler warning caught by gcc 4.6.1. Need to return something. Modified: trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp (98644 => 98645) --- trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-27 21:56:57 UTC (rev 98644) +++ trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-27 22:05:17 UTC (rev 98645) @@ -395,6 +395,7 @@ return; HFONT hfont = font->platformData().hfont(); +PlatformSupport::ensureFontLoaded(hfont); // We draw the glyphs in chunks to avoid having to do a heap allocation for // the arrays of characters and advances. Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (98644 => 98645) --- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-27 21:56:57 UTC (rev 98644) +++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-27 22:05:17 UTC (rev 98645) @@ -35,7 +35,6 @@ #include "PlatformContextSkia.h" #include "Gradient.h" #include "Pattern.h" -#include "PlatformSupport.h" #include "SkCanvas.h" #include "SkPaint.h" #include "SkShader.h" @@ -237,9 +236,6 @@ PlatformContextSkia* platformContext = context->platformContext(); SkCanvas* canvas = platformContext->canvas(); TextDrawingModeFlags textMode = platformContext->getTextDrawingMode(); -// Ensure font load for printing, because PDF device needs it. -if (canvas->getTopDevice()->getDeviceCapabilities() & SkDevice::kVector_Capability) -PlatformSupport::ensureFontLoaded(hfont); // Filling (if necessary). This is the common case. SkPaint paint; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98644] trunk/Source/WebCore
Title: [98644] trunk/Source/WebCore Revision 98644 Author t...@chromium.org Date 2011-10-27 14:56:57 -0700 (Thu, 27 Oct 2011) Log Message Fix a compiler warning caught by gcc 4.6.1. Need to return something. * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: (WebCore::CCSchedulerStateMachine::nextAction): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (98643 => 98644) --- trunk/Source/WebCore/ChangeLog 2011-10-27 21:54:11 UTC (rev 98643) +++ trunk/Source/WebCore/ChangeLog 2011-10-27 21:56:57 UTC (rev 98644) @@ -1,3 +1,10 @@ +2011-10-27 Tony Chang + +Fix a compiler warning caught by gcc 4.6.1. Need to return something. + +* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: +(WebCore::CCSchedulerStateMachine::nextAction): + 2011-10-27 Vsevolod Vlasov Web Inspector: Advanced search style fixes. Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (98643 => 98644) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 21:54:11 UTC (rev 98643) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 21:56:57 UTC (rev 98644) @@ -59,6 +59,8 @@ case COMMIT_STATE_READY_TO_COMMIT: return ACTION_COMMIT; } +ASSERT_NOT_REACHED(); +return ACTION_NONE; } void CCSchedulerStateMachine::updateState(Action action) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98643] trunk/Source/JavaScriptCore
Title: [98643] trunk/Source/_javascript_Core Revision 98643 Author msab...@apple.com Date 2011-10-27 14:54:11 -0700 (Thu, 27 Oct 2011) Log Message 32bit build failure after r98624 https://bugs.webkit.org/show_bug.cgi?id=71064 Disambiguated operator overload with unsigned index (0u). Reviewed by Sam Weinig. * runtime/UString.h: (JSC::operator==): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/UString.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98642 => 98643) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 21:48:34 UTC (rev 98642) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 21:54:11 UTC (rev 98643) @@ -1,3 +1,15 @@ +2011-10-27 Michael Saboff + +32bit build failure after r98624 +https://bugs.webkit.org/show_bug.cgi?id=71064 + +Disambiguated operator overload with unsigned index (0u). + +Reviewed by Sam Weinig. + +* runtime/UString.h: +(JSC::operator==): + 2011-10-27 Gustavo Noronha Silva Fix building on GNU/kFreeBSD Modified: trunk/Source/_javascript_Core/runtime/UString.h (98642 => 98643) --- trunk/Source/_javascript_Core/runtime/UString.h 2011-10-27 21:48:34 UTC (rev 98642) +++ trunk/Source/_javascript_Core/runtime/UString.h 2011-10-27 21:54:11 UTC (rev 98643) @@ -161,7 +161,7 @@ return true; if (size1 == 1) -return (*rep1)[0] == (*rep2)[0]; +return (*rep1)[0u] == (*rep2)[0u]; return equalSlowCase(s1, s2); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98642] trunk/LayoutTests
Title: [98642] trunk/LayoutTests Revision 98642 Author ann...@chromium.org Date 2011-10-27 14:48:34 -0700 (Thu, 27 Oct 2011) Log Message Individually Skip track-related LayoutTests rather than block-Skipping them. https://bugs.webkit.org/show_bug.cgi?id=71037 Reviewed by Adam Barth. * platform/chromium/test_expectations.txt: * platform/efl/Skipped: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * platform/wincairo/Skipped: * platform/wk2/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/efl/Skipped trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/mac/Skipped trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/win/Skipped trunk/LayoutTests/platform/wincairo/Skipped trunk/LayoutTests/platform/wk2/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (98641 => 98642) --- trunk/LayoutTests/ChangeLog 2011-10-27 21:43:22 UTC (rev 98641) +++ trunk/LayoutTests/ChangeLog 2011-10-27 21:48:34 UTC (rev 98642) @@ -1,3 +1,19 @@ +2011-10-27 Anna Cavender + +Individually Skip track-related LayoutTests rather than block-Skipping them. +https://bugs.webkit.org/show_bug.cgi?id=71037 + +Reviewed by Adam Barth. + +* platform/chromium/test_expectations.txt: +* platform/efl/Skipped: +* platform/gtk/Skipped: +* platform/mac/Skipped: +* platform/qt/Skipped: +* platform/win/Skipped: +* platform/wincairo/Skipped: +* platform/wk2/Skipped: + 2011-10-27 David Hyatt https://bugs.webkit.org/show_bug.cgi?id=71061 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98641 => 98642) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 21:43:22 UTC (rev 98641) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 21:48:34 UTC (rev 98642) @@ -77,8 +77,39 @@ // CSS3 Selectors3 test suite BUGCR89468 : css3/selectors3 = PASS FAIL -// Tests for WebVTT parser for . Feature is not yet functional. -BUGWK43668 SKIP : media/track/ = TIMEOUT +// Tests for . Feature is not yet functional. +BUGWK43668 SKIP : media/track/track-mutable.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-text-track-cue-list.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-text-track.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc000-empty.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc001-utf8.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc002-bom.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc003-newlines.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc004-magic-header.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc005-header-comment.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc006-cue-identifiers.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc007-cue-no-id.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc008-timings-no-hours.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc009-timings-hour.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc010-no-timings.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc011-blank-lines.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc012-out-of-order.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc013-settings.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc014-alignment.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc015-positioning.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc016-align-positioning.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc017-line-position.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc018-align-text-line-position.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc019-cue-size.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc020-cue-size-align.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc021-valign.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc022-entities.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc023-markup.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc024-timestamp.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc025-class-markup.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc026-voice.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc027-empty-cue.html = TIMEOUT +BUGWK43668 SKIP : media/track/track-webvtt-tc028-unsupported-markup.html = TIMEOUT // Tests for MediaSource API. Feature is not yet functional. BUGWK64731 SKIP : http/tests/media/media-source/ = TIMEOUT Modified: trunk/LayoutTests/platform/efl/Skipped (98641 => 98642) --- trunk/LayoutTests/platform/efl/Skipped 2011-10-27 21:43:22 UTC (rev 98641) +++ trunk/LayoutTests/platform/efl/Skipped 2011-10-27 21:48:34 UTC (rev 98642) @@ -1
[webkit-changes] [98641] branches/subpixellayout/Source/WebCore/platform
Title: [98641] branches/subpixellayout/Source/WebCore/platform
Revision 98641
Author le...@chromium.org
Date 2011-10-27 14:43:22 -0700 (Thu, 27 Oct 2011)
Log Message
Painting Mac scrollbars on integer bounds.
Modified Paths
branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h
branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.mm
Diff
Modified: branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h (98640 => 98641)
--- branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h 2011-10-27 21:42:48 UTC (rev 98640)
+++ branches/subpixellayout/Source/WebCore/platform/ScrollbarTheme.h 2011-10-27 21:43:22 UTC (rev 98641)
@@ -80,7 +80,7 @@
virtual void invalidatePart(Scrollbar*, ScrollbarPart) {}
virtual void paintScrollCorner(ScrollView*, GraphicsContext* context, const FixedRect& cornerRect) { defaultPaintScrollCorner(context, cornerRect); }
-static void defaultPaintScrollCorner(GraphicsContext* context, const FixedRect& cornerRect) { context->fillRect(cornerRect, Color::white, ColorSpaceDeviceRGB); }
+static void defaultPaintScrollCorner(GraphicsContext* context, const FixedRect& cornerRect) { context->fillRect(enclosingIntRect(cornerRect), Color::white, ColorSpaceDeviceRGB); }
virtual void paintOverhangAreas(ScrollView*, GraphicsContext*, const FixedRect&, const FixedRect&, const FixedRect&) { }
Modified: branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.mm (98640 => 98641)
--- branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.mm 2011-10-27 21:42:48 UTC (rev 98640)
+++ branches/subpixellayout/Source/WebCore/platform/mac/ScrollbarThemeMac.mm 2011-10-27 21:43:22 UTC (rev 98641)
@@ -534,7 +534,7 @@
HIThemeTrackDrawInfo trackInfo;
trackInfo.version = 0;
trackInfo.kind = scrollbar->controlSize() == RegularScrollbar ? kThemeMediumScrollBar : kThemeSmallScrollBar;
-trackInfo.bounds = scrollbar->frameRect();
+trackInfo.bounds = enclosingIntRect(scrollbar->frameRect());
float maximum = 0.0f;
float position = 0.0f;
@@ -553,8 +553,8 @@
}
trackInfo.min = 0;
-trackInfo.max = static_cast(maximum);
-trackInfo.value = static_cast(position);
+trackInfo.max = static_cast(maximum);
+trackInfo.value = static_cast(position);
trackInfo.trackInfo.scrollbar.viewsize = scrollbar->visibleSize();
trackInfo.attributes = 0;
@@ -578,7 +578,7 @@
if (canDrawDirectly)
HIThemeDrawTrack(&trackInfo, 0, context->platformContext(), kHIThemeOrientationNormal);
else {
-trackInfo.bounds = LayoutRect(LayoutPoint(), scrollbar->frameRect().size());
+trackInfo.bounds = IntRect(IntPoint(), expandedIntSize(scrollbar->frameRect().size()));
LayoutRect bufferRect(scrollbar->frameRect());
bufferRect.intersect(damageRect);
@@ -587,7 +587,7 @@
if (!imageBuffer)
return true;
-imageBuffer->context()->translate(scrollbar->frameRect().x() - bufferRect.x(), scrollbar->frameRect().y() - bufferRect.y());
+imageBuffer->context()->translate((scrollbar->frameRect().x() - bufferRect.x()).round(), (scrollbar->frameRect().y() - bufferRect.y()).round());
HIThemeDrawTrack(&trackInfo, 0, imageBuffer->context()->platformContext(), kHIThemeOrientationNormal);
context->drawImageBuffer(imageBuffer.get(), ColorSpaceDeviceRGB, roundedIntPoint(bufferRect.location()));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98640] trunk/Source/WebCore
Title: [98640] trunk/Source/WebCore
Revision 98640
Author vse...@chromium.org
Date 2011-10-27 14:42:48 -0700 (Thu, 27 Oct 2011)
Log Message
Web Inspector: Advanced search style fixes.
https://bugs.webkit.org/show_bug.cgi?id=71036
Reviewed by Pavel Feldman.
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/inspector.css:
(.search-view .search-panel):
(.search-view .search-panel input[type="search"].search-config-search):
(.search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox):
(#drawer-status-bar .search-status-bar-progress):
(body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress):
(body.platform-mac #drawer-status-bar .search-status-bar-progress):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js
trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
trunk/Source/WebCore/inspector/front-end/inspector.css
Diff
Modified: trunk/Source/WebCore/ChangeLog (98639 => 98640)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 21:29:53 UTC (rev 98639)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 21:42:48 UTC (rev 98640)
@@ -1,3 +1,23 @@
+2011-10-27 Vsevolod Vlasov
+
+Web Inspector: Advanced search style fixes.
+https://bugs.webkit.org/show_bug.cgi?id=71036
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/AdvancedSearchController.js:
+(WebInspector.SearchView):
+* inspector/front-end/Images/statusbarButtonGlyphs.png:
+* inspector/front-end/inspector.css:
+(.search-view .search-panel):
+(.search-view .search-panel input[type="search"].search-config-search):
+(.search-view .search-panel input[type="checkbox"].search-config-checkbox):
+(body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox):
+(body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox):
+(#drawer-status-bar .search-status-bar-progress):
+(body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress):
+(body.platform-mac #drawer-status-bar .search-status-bar-progress):
+
2011-10-27 David Hyatt
https://bugs.webkit.org/show_bug.cgi?id=71061
Modified: trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js (98639 => 98640)
--- trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2011-10-27 21:29:53 UTC (rev 98639)
+++ trunk/Source/WebCore/inspector/front-end/AdvancedSearchController.js 2011-10-27 21:42:48 UTC (rev 98640)
@@ -156,6 +156,7 @@
WebInspector.SearchView = function(controller)
{
WebInspector.View.call(this);
+this.registerRequiredCSS("textViewer.css");
this._controller = controller;
Modified: trunk/Source/WebCore/inspector/front-end/Images/statusbarButtonGlyphs.png
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (98639 => 98640)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2011-10-27 21:29:53 UTC (rev 98639)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2011-10-27 21:42:48 UTC (rev 98640)
@@ -2325,10 +2325,10 @@
.search-view .search-panel {
position: absolute;
top: 0;
-height: 35px;
+height: 28px;
left: 0;
right: 0;
-padding-top: 4px;
+padding-top: 2px;
padding-left: 10px;
background-color: #EBEBEB;
border-bottom: 1px solid #BBB;
@@ -2338,6 +2338,7 @@
.search-view .search-panel input[type="search"].search-config-search {
margin-right: 8px;
+font-size: 11px;
color: #303030;
}
@@ -2348,9 +2349,16 @@
.search-view .search-panel input[type="checkbox"].search-config-checkbox {
vertical-align: bottom;
-margin-bottom: 6px;
}
+body:not(.platform-mac) .search-view .search-panel input[type="checkbox"].search-config-checkbox {
+margin-bottom: 5px;
+}
+
+body.platform-mac .search-view .search-panel input[type="checkbox"].search-config-checkbox {
+margin-bottom: 4px;
+}
+
#drawer-status-bar .search-status-bar-item {
cursor: pointer;
font-size: 11px;
@@ -2365,12 +2373,19 @@
}
#drawer-status-bar .search-status-bar-progress {
-height: 10px;
+height: 11px;
width: 100px;
-margin-top: 8px;
float: left;
}
+body:not(.platform-mac) #drawer-status-bar .search-status-bar-progress {
+margin-top: 8px;
+}
+
+body.platform-mac #drawer-status-bar .search-status-bar-progress {
+margin-top: 7px;
+}
+
#drawer-status-bar .search-status-bar-stop-button-item {
width: 19px;
height: 24px;
___
webkit-changes
[webkit-changes] [98639] trunk/Tools
Title: [98639] trunk/Tools
Revision 98639
Author e...@webkit.org
Date 2011-10-27 14:29:53 -0700 (Thu, 27 Oct 2011)
Log Message
REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=66227
Reviewed by Adam Roben.
I believe this should fix the bug.
* Scripts/run-webkit-tests: make NRWT default for --leaks
* Scripts/webkitpy/layout_tests/port/leakdetector.py:
(LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
(LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
(LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
* Scripts/webkitpy/layout_tests/port/mac.py:
Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py
Diff
Modified: trunk/Tools/ChangeLog (98638 => 98639)
--- trunk/Tools/ChangeLog 2011-10-27 21:21:32 UTC (rev 98638)
+++ trunk/Tools/ChangeLog 2011-10-27 21:29:53 UTC (rev 98639)
@@ -1,3 +1,22 @@
+2011-10-27 Eric Seidel
+
+REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
+https://bugs.webkit.org/show_bug.cgi?id=66227
+
+Reviewed by Adam Roben.
+
+I believe this should fix the bug.
+
+* Scripts/run-webkit-tests: make NRWT default for --leaks
+* Scripts/webkitpy/layout_tests/port/leakdetector.py:
+(LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
+(LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
+(LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
+* Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
+Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
+* Scripts/webkitpy/layout_tests/port/mac.py:
+Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
+
2011-10-27 Stephen Chenney
[Chromium] Need setPrinting
Modified: trunk/Tools/Scripts/run-webkit-tests (98638 => 98639)
--- trunk/Tools/Scripts/run-webkit-tests 2011-10-27 21:21:32 UTC (rev 98638)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-10-27 21:29:53 UTC (rev 98639)
@@ -55,14 +55,6 @@
return $isBuildBotUser{$ENV{"USER"}};
}
-sub usingLeaks()
-{
-# LeaksViewer gets confused by NRWT's --leaks output, see bugs:
-# https://bugs.webkit.org/show_bug.cgi?id=66227
-# https://bugs.webkit.org/show_bug.cgi?id=66228
-return grep(/--leaks/, @ARGV);
-}
-
sub useNewRunWebKitTests()
{
# Change this check to control which platforms use new-run-webkit-tests by default.
@@ -75,12 +67,12 @@
# NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756
-# NRWT doesn't support qt-mac, qt-arm and qt-4.8 platforms now: https://bugs.webkit.org/show_bug.cgi?id=64071 and https://bugs.webkit.org/show_bug.cgi?id=64086
+# NRWT doesn't support qt-arm and qt-4.8 platforms now: https://bugs.webkit.org/show_bug.cgi?id=64071 and https://bugs.webkit.org/show_bug.cgi?id=64086
if (isQt()) {
return (!isARM());
}
-return ((isLeopard() or isSnowLeopard() or isLion() or isGtk()) and !usingLeaks());
+return (isLeopard() or isSnowLeopard() or isLion() or isGtk());
}
my $harnessName = "old-run-webkit-tests";
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py (98638 => 98639)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-27 21:21:32 UTC (rev 98638)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/leakdetector.py 2011-10-27 21:29:53 UTC (rev 98639)
@@ -84,9 +84,9 @@
leaks_args.append(pid)
return leaks_args
-def _parse_leaks_output(self, leaks_output, process_pid):
-count, bytes = re.search(r'Process %s: (\d+) leaks? for (\d+) total' % process_pid, leaks_output).groups()
-excluded_match = re.search(r'(\d+) leaks? excluded', leaks_output)
+def _parse_leaks_output(self, leaks_output):
+_, count, bytes = re.search(r'Process (?P\
[webkit-changes] [98638] trunk
Title: [98638] trunk Revision 98638 Author hy...@apple.com Date 2011-10-27 14:21:32 -0700 (Thu, 27 Oct 2011) Log Message https://bugs.webkit.org/show_bug.cgi?id=71061 [CSS Line Grid] Add support for parsing the line-grid property. Source/WebCore: New tests in fast/line-grid. Reviewed by Dan Bernstein. * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): * css/CSSProperty.cpp: (WebCore::CSSProperty::isInheritedProperty): * css/CSSPropertyNames.in: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::lineGrid): (WebCore::InheritedFlags::setLineGrid): (WebCore::InheritedFlags::initialLineGrid): * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): * rendering/style/StyleRareInheritedData.h: LayoutTests: Reviewed by Dan Bernstein. * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/line-grid: Added. * fast/line-grid/line-grid-parsing-expected.txt: Added. * fast/line-grid/line-grid-parsing.html: Added. * fast/line-grid/script-tests: Added. * fast/line-grid/script-tests/line-grid-parsing.js: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSProperty.cpp trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h Added Paths trunk/LayoutTests/fast/line-grid/ trunk/LayoutTests/fast/line-grid/line-grid-parsing-expected.txt trunk/LayoutTests/fast/line-grid/line-grid-parsing.html trunk/LayoutTests/fast/line-grid/script-tests/ trunk/LayoutTests/fast/line-grid/script-tests/line-grid-parsing.js Diff Modified: trunk/LayoutTests/ChangeLog (98637 => 98638) --- trunk/LayoutTests/ChangeLog 2011-10-27 21:09:24 UTC (rev 98637) +++ trunk/LayoutTests/ChangeLog 2011-10-27 21:21:32 UTC (rev 98638) @@ -1,3 +1,19 @@ +2011-10-27 David Hyatt + +https://bugs.webkit.org/show_bug.cgi?id=71061 + +[CSS Line Grid] Add support for parsing the line-grid property. + +Reviewed by Dan Bernstein. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* fast/line-grid: Added. +* fast/line-grid/line-grid-parsing-expected.txt: Added. +* fast/line-grid/line-grid-parsing.html: Added. +* fast/line-grid/script-tests: Added. +* fast/line-grid/script-tests/line-grid-parsing.js: Added. + 2011-10-27 Fady Samuel iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0 Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (98637 => 98638) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2011-10-27 21:09:24 UTC (rev 98637) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2011-10-27 21:21:32 UTC (rev 98638) @@ -152,6 +152,7 @@ -webkit-line-box-contain: block inline replaced; -webkit-line-break: normal; -webkit-line-clamp: none; +-webkit-line-grid: none; -webkit-locale: auto; -webkit-margin-before-collapse: collapse; -webkit-margin-after-collapse: collapse; Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (98637 => 98638) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2011-10-27 21:09:24 UTC (rev 98637) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2011-10-27 21:21:32 UTC (rev 98638) @@ -151,6 +151,7 @@ -webkit-line-box-contain: block inline replaced -webkit-line-break: normal -webkit-line-clamp: none +-webkit-line-grid: none -webkit-locale: auto -webkit-margin-before-collapse: collapse -webkit-margin-after-collapse: collapse Added: trunk/LayoutTests/fast/line-grid/line-grid-parsing-expected.txt (0 => 98638) --- trunk/LayoutTests/fast/line-grid/line-grid-parsing-expected.txt (rev 0) +++ trunk/LayoutTests/fast/line-grid/line-grid-parsing-expected.txt 2011-10-27 21:21:32 UTC (rev 98638) @@ -0,0 +1,24 @@ +Test parsing of the CSS line-grid property. + +On success, you will see a series o
[webkit-changes] [98637] trunk
Title: [98637] trunk
Revision 98637
Author fsam...@chromium.org
Date 2011-10-27 14:09:24 -0700 (Thu, 27 Oct 2011)
Log Message
iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0
https://bugs.webkit.org/show_bug.cgi?id=70552
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/frames/iframe-double-scale-contents.html
The iframe's document style was using the page's scale factor, rather than the frame's (1.0).
If the page scale factor was set after layout was complete, then this would have no impact because the iframe's document style and layout is not recomputed,
but if the page scale factor is set prior to creating and laying out the iframe, the iframe's content would be doubly scaled.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForDocument):
LayoutTests:
* fast/frames/iframe-double-scale-contents-expected.png: Added.
* fast/frames/iframe-double-scale-contents-expected.txt: Added.
* fast/frames/iframe-double-scale-contents.html: Added.
* fast/frames/resources/iframe-content-scaling-bug-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
Added Paths
trunk/LayoutTests/fast/frames/iframe-double-scale-contents-expected.png
trunk/LayoutTests/fast/frames/iframe-double-scale-contents-expected.txt
trunk/LayoutTests/fast/frames/iframe-double-scale-contents.html
trunk/LayoutTests/fast/frames/resources/iframe-content-scaling-bug-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98636 => 98637)
--- trunk/LayoutTests/ChangeLog 2011-10-27 21:04:32 UTC (rev 98636)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 21:09:24 UTC (rev 98637)
@@ -1,3 +1,15 @@
+2011-10-27 Fady Samuel
+
+iframes seem to occasionally doubly scale or scale incorrectly when pageScaleFactor != 1.0
+https://bugs.webkit.org/show_bug.cgi?id=70552
+
+Reviewed by Simon Fraser.
+
+* fast/frames/iframe-double-scale-contents-expected.png: Added.
+* fast/frames/iframe-double-scale-contents-expected.txt: Added.
+* fast/frames/iframe-double-scale-contents.html: Added.
+* fast/frames/resources/iframe-content-scaling-bug-iframe.html: Added.
+
2011-10-27 Mike Reed
test_rebaseline_expectations failing
Added: trunk/LayoutTests/fast/frames/iframe-double-scale-contents-expected.png (0 => 98637)
--- trunk/LayoutTests/fast/frames/iframe-double-scale-contents-expected.png (rev 0)
+++ trunk/LayoutTests/fast/frames/iframe-double-scale-contents-expected.png 2011-10-27 21:09:24 UTC (rev 98637)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum 8b7e44169b5fe17cc38d4e93486078c1| T\xB5
+\xB6IDATx\x9C\xED\xD8\xD1 \x800Ac\xE3\xDA\xF9\xB3\x89\x85@\x9C\xA9\xE0>\x97[\xD7{\xC0o\xCD3\xBB'p\xA0{\xF7 \x80\xD3, \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 ,
[webkit-changes] [98636] trunk/LayoutTests
Title: [98636] trunk/LayoutTests Revision 98636 Author r...@google.com Date 2011-10-27 14:04:32 -0700 (Thu, 27 Oct 2011) Log Message test_rebaseline_expectations failing https://bugs.webkit.org/show_bug.cgi?id=71033 Reviewed by Adam Barth. Resolve overlaps * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (98635 => 98636) --- trunk/LayoutTests/ChangeLog 2011-10-27 20:55:01 UTC (rev 98635) +++ trunk/LayoutTests/ChangeLog 2011-10-27 21:04:32 UTC (rev 98636) @@ -1,3 +1,14 @@ +2011-10-27 Mike Reed + +test_rebaseline_expectations failing +https://bugs.webkit.org/show_bug.cgi?id=71033 + +Reviewed by Adam Barth. + +Resolve overlaps + +* platform/chromium/test_expectations.txt: + 2011-10-27 Dan Bernstein Updated expected results after r98608. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98635 => 98636) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 20:55:01 UTC (rev 98635) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 21:04:32 UTC (rev 98636) @@ -1078,20 +1078,17 @@ BUGWK70748 CPU : media/controls-without-preload.html = IMAGE BUGWK70748 CPU : media/media-controls-clone.html = IMAGE BUGWK70748 CPU : media/media-document-audio-repaint.html = IMAGE -BUGWK70748 CPU : media/video-controls-rendering.html = IMAGE BUGWK70748 CPU : media/video-display-toggle.html = IMAGE BUGWK70748 CPU : media/video-empty-source.html = IMAGE BUGWK70748 CPU : media/video-no-audio.html = IMAGE BUGWK70748 CPU : media/video-playing-and-pause.html = IMAGE BUGWK70748 CPU : media/video-volume-slider.html = IMAGE -BUGWK70748 GPU : media/video-zoom-controls.html = IMAGE BUGWK70748 GPU : media/audio-controls-rendering.html = IMAGE BUGWK70748 GPU : media/controls-after-reload.html = IMAGE BUGWK70748 GPU : media/controls-strict.html = IMAGE BUGWK70748 GPU : media/controls-styling.html = IMAGE BUGWK70748 GPU : media/controls-without-preload.html = IMAGE BUGWK70748 GPU : media/media-controls-clone.html = IMAGE -BUGWK70748 GPU : media/video-controls-rendering.html = IMAGE BUGWK70748 GPU : media/video-display-toggle.html = IMAGE BUGWK70748 GPU : media/video-empty-source.html = IMAGE BUGWK70748 GPU : media/video-no-audio.html = IMAGE @@ -2750,8 +2747,7 @@ BUGWK55968 MAC GPU GPU-CG : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE IMAGE+TEXT BUGWK55968 WIN DEBUG GPU : compositing/webgl/webgl-nonpremultiplied-blend.html = IMAGE -BUGWK58587 LINUX GPU DEBUG : media/video-controls-rendering.html = IMAGE -BUGCR97686 LINUX GPU RELEASE : media/video-controls-rendering.html = IMAGE +BUGWK58587 : media/video-controls-rendering.html = IMAGE // Take new baselines from the bots when 68035 lands. BUGWK69624 SLOW WIN GPU : platform/chromium/compositing/zoom-animator-scale-test2.html = IMAGE+TEXT @@ -3638,8 +3634,7 @@ BUGCR95972 WIN DEBUG : webaudio/sample-accurate-scheduling.html = CRASH // Failing after r94912. -BUGWK67913 WIN LINUX SNOWLEOPARD : media/video-zoom-controls.html = TEXT -BUGWK67913 LEOPARD : media/video-zoom-controls.html = TEXT IMAGE+TEXT +BUGWK67913 : media/video-zoom-controls.html = TEXT IMAGE+TEXT BUGCR96220 : fast/borders/border-image-outset-split-inline-vertical-lr.html = IMAGE BUGCR96220 : fast/reflections/reflection-masks-outset.html = IMAGE BUGCR96220 WIN LINUX : fast/borders/block-mask-overlay-image-outset.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98635] trunk/LayoutTests
Title: [98635] trunk/LayoutTests Revision 98635 Author m...@apple.com Date 2011-10-27 13:55:01 -0700 (Thu, 27 Oct 2011) Log Message Updated expected results after r98608. * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (98634 => 98635) --- trunk/LayoutTests/ChangeLog 2011-10-27 20:53:53 UTC (rev 98634) +++ trunk/LayoutTests/ChangeLog 2011-10-27 20:55:01 UTC (rev 98635) @@ -1,3 +1,11 @@ +2011-10-27 Dan Bernstein + +Updated expected results after r98608. + +* fast/css/getComputedStyle/computed-style-expected.txt: +* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: +* svg/css/getComputedStyle-basic-expected.txt: + 2011-10-27 Stephen Chenney [Chromium] Need setPrinting Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (98634 => 98635) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2011-10-27 20:53:53 UTC (rev 98634) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2011-10-27 20:55:01 UTC (rev 98635) @@ -134,6 +134,7 @@ -webkit-column-break-after: auto; -webkit-column-break-before: auto; -webkit-column-break-inside: auto; +-webkit-column-axis: auto; -webkit-column-count: auto; -webkit-column-gap: normal; -webkit-column-rule-color: rgb(0, 0, 0); Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (98634 => 98635) --- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2011-10-27 20:53:53 UTC (rev 98634) +++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2011-10-27 20:55:01 UTC (rev 98635) @@ -133,6 +133,7 @@ -webkit-column-break-after: auto -webkit-column-break-before: auto -webkit-column-break-inside: auto +-webkit-column-axis: auto -webkit-column-count: auto -webkit-column-gap: normal -webkit-column-rule-color: rgb(0, 0, 0) Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (98634 => 98635) --- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2011-10-27 20:53:53 UTC (rev 98634) +++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2011-10-27 20:55:01 UTC (rev 98635) @@ -266,6 +266,8 @@ rect: style.getPropertyCSSValue(-webkit-column-break-before) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-column-break-inside) : auto rect: style.getPropertyCSSValue(-webkit-column-break-inside) : [object CSSPrimitiveValue] +rect: style.getPropertyValue(-webkit-column-axis) : auto +rect: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-column-count) : auto rect: style.getPropertyCSSValue(-webkit-column-count) : [object CSSPrimitiveValue] rect: style.getPropertyValue(-webkit-column-gap) : normal @@ -746,6 +748,8 @@ g: style.getPropertyCSSValue(-webkit-column-break-before) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-column-break-inside) : auto g: style.getPropertyCSSValue(-webkit-column-break-inside) : [object CSSPrimitiveValue] +g: style.getPropertyValue(-webkit-column-axis) : auto +g: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-column-count) : auto g: style.getPropertyCSSValue(-webkit-column-count) : [object CSSPrimitiveValue] g: style.getPropertyValue(-webkit-column-gap) : normal ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98633] trunk/Source
Title: [98633] trunk/Source Revision 98633 Author lforsch...@apple.com Date 2011-10-27 13:52:56 -0700 (Thu, 27 Oct 2011) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/_javascript_Glue/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebKit/mac/Configurations/Version.xcconfig trunk/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (98632 => 98633) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-27 20:43:41 UTC (rev 98632) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-27 20:52:56 UTC (rev 98633) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 7; +MINOR_VERSION = 8; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/_javascript_Glue/Configurations/Version.xcconfig (98632 => 98633) --- trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-27 20:43:41 UTC (rev 98632) +++ trunk/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-27 20:52:56 UTC (rev 98633) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 7; +MINOR_VERSION = 8; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (98632 => 98633) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2011-10-27 20:43:41 UTC (rev 98632) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2011-10-27 20:52:56 UTC (rev 98633) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 7; +MINOR_VERSION = 8; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (98632 => 98633) --- trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-27 20:43:41 UTC (rev 98632) +++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-27 20:52:56 UTC (rev 98633) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 7; +MINOR_VERSION = 8; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (98632 => 98633) --- trunk/Source/WebKit2/Configurations/Version.xcconfig 2011-10-27 20:43:41 UTC (rev 98632) +++ trunk/Source/WebKit2/Configurations/Version.xcconfig 2011-10-27 20:52:56 UTC (rev 98633) @@ -22,7 +22,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 535; -MINOR_VERSION = 7; +MINOR_VERSION = 8; TINY_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98631] trunk/Source
Title: [98631] trunk/Source
Revision 98631
Author nd...@chromium.org
Date 2011-10-27 13:42:54 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, fix CCSchedulerStateMachine build errors.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h
trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98630 => 98631)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 20:41:05 UTC (rev 98630)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 20:42:54 UTC (rev 98631)
@@ -1,3 +1,10 @@
+2011-10-27 Nat Duca
+
+Unreviewed, fix CCSchedulerStateMachine build errors.
+
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
+
2011-10-27 Tony Chang
fix sizing of auto sized flexbox
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (98630 => 98631)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 20:41:05 UTC (rev 98630)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 20:42:54 UTC (rev 98631)
@@ -34,20 +34,6 @@
, m_needsCommit(false)
, m_updatedThisFrame(false) { }
-CCSchedulerStateMachine::CCSchedulerStateMachine(const CCSchedulerStateMachine& that)
-{
-*this = that;
-}
-
-CCSchedulerStateMachine::CCSchedulerStateMachine& CCSchedulerStateMachine::operator=(const CCSchedulerStateMachine& that)
-{
-m_commitState = that.m_commitState;
-m_needsRedraw = that.m_needsRedraw;
-m_needsCommit = that.m_needsCommit;
-m_updatedThisFrame = that.m_updatedThisFrame;
-return *this;
-}
-
CCSchedulerStateMachine::Action CCSchedulerStateMachine::nextAction(bool insideVSyncTick) const
{
switch (m_commitState) {
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h (98630 => 98631)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h 2011-10-27 20:41:05 UTC (rev 98630)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h 2011-10-27 20:42:54 UTC (rev 98631)
@@ -25,6 +25,8 @@
#ifndef CCSchedulerStateMachine_h
#define CCSchedulerStateMachine_h
+#include
+
namespace WebCore {
// The CCSchedulerStateMachine decides how to coordinates main thread activites
@@ -40,8 +42,6 @@
class CCSchedulerStateMachine {
public:
CCSchedulerStateMachine();
-CCSchedulerStateMachine(const CCSchedulerStateMachine& that);
-CCSchedulerStateMachine& operator=(const CCSchedulerStateMachine& that);
enum CommitState {
COMMIT_STATE_IDLE,
Modified: trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp (98630 => 98631)
--- trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp 2011-10-27 20:41:05 UTC (rev 98630)
+++ trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp 2011-10-27 20:42:54 UTC (rev 98631)
@@ -60,28 +60,34 @@
TEST(CCSchedulerStateMachineTest, TestNextActionBeginsFrameIfNeeded)
{
-StateMachine state;
// If no commit needed, do nothing
-state = StateMachine();
-state.setCommitState(CCSchedulerStateMachine::COMMIT_STATE_IDLE);
-state.setNeedsRedraw(false);
-state.setNeedsCommit(false);
-state.setUpdatedThisFrame(false);
-EXPECT_EQ(CCSchedulerStateMachine::ACTION_NONE, state.nextAction(false));
-EXPECT_EQ(CCSchedulerStateMachine::ACTION_NONE, state.nextAction(true));
+{
+StateMachine state;
+state.setCommitState(CCSchedulerStateMachine::COMMIT_STATE_IDLE);
+state.setNeedsRedraw(false);
+state.setNeedsCommit(false);
+state.setUpdatedThisFrame(false);
+EXPECT_EQ(CCSchedulerStateMachine::ACTION_NONE, state.nextAction(false));
+EXPECT_EQ(CCSchedulerStateMachine::ACTION_NONE, state.nextAction(true));
+}
// If commit requested, begin a frame
-state = StateMachine();
-state.setCommitState(CCSchedulerStateMachine::COMMIT_STATE_IDLE);
-state.setNeedsRedraw(false);
-state.setNeedsCommit(true);
-state.setUpdatedThisFrame(false);
-EXPECT_EQ(CCSchedulerStateMachine::ACTION_BEGIN_FRAME, state.nextAction(false));
+{
+StateMachine state;
+state.setCommitState(CCSchedulerStateMachine::COMMIT_STATE_IDLE);
+state.setNeedsRedraw(false);
+state.setNeedsCommit(true);
+state.setUpdatedThisFrame(false);
+EXPECT_EQ(CCSchedulerStateMachine::ACTION_BEGIN_FRAME, state.nextAction(false));
+}
// Begin the frame, make sure needsCommit and commitState update correctly.
-state.updateState(CCSchedulerStateMachine::ACTION_BEGIN
[webkit-changes] [98630] trunk/Source
Title: [98630] trunk/Source
Revision 98630
Author jam...@google.com
Date 2011-10-27 13:41:05 -0700 (Thu, 27 Oct 2011)
Log Message
Fix teardown in Web*LayerImpl, and add tests for Web*Layer
https://bugs.webkit.org/show_bug.cgi?id=70431
Patch by Antoine Labour on 2011-10-27
Reviewed by James Robinson.
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
* src/WebLayerImpl.cpp:
(WebKit::WebLayerImpl::~WebLayerImpl):
Modified Paths
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp
trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp
Added Paths
trunk/Source/WebKit/chromium/tests/WebLayerTest.cpp
Diff
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (98629 => 98630)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-10-27 20:41:05 UTC (rev 98630)
@@ -96,13 +96,13 @@
const IntSize& bounds() const { return m_bounds; }
virtual IntSize contentBounds() const { return bounds(); }
-void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; }
+void setMasksToBounds(bool masksToBounds) { m_masksToBounds = masksToBounds; setNeedsCommit(); }
bool masksToBounds() const { return m_masksToBounds; }
void setName(const String&);
const String& name() const { return m_name; }
-void setMaskLayer(LayerChromium* maskLayer) { m_maskLayer = maskLayer; }
+void setMaskLayer(LayerChromium* maskLayer) { m_maskLayer = maskLayer; setNeedsCommit(); }
LayerChromium* maskLayer() const { return m_maskLayer.get(); }
void setNeedsDisplay(const FloatRect& dirtyRect);
Modified: trunk/Source/WebKit/chromium/ChangeLog (98629 => 98630)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-10-27 20:41:05 UTC (rev 98630)
@@ -1,3 +1,17 @@
+2011-10-27 Antoine Labour
+
+Fix teardown in Web*LayerImpl, and add tests for Web*Layer
+https://bugs.webkit.org/show_bug.cgi?id=70431
+
+Reviewed by James Robinson.
+
+* src/WebContentLayerImpl.cpp:
+(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
+* src/WebExternalTextureLayerImpl.cpp:
+(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
+* src/WebLayerImpl.cpp:
+(WebKit::WebLayerImpl::~WebLayerImpl):
+
2011-10-24 Nat Duca
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
Modified: trunk/Source/WebKit/chromium/DEPS (98629 => 98630)
--- trunk/Source/WebKit/chromium/DEPS 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebKit/chromium/DEPS 2011-10-27 20:41:05 UTC (rev 98630)
@@ -32,7 +32,7 @@
vars = {
'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
- 'chromium_rev': '107113'
+ 'chromium_rev': '107458'
}
deps = {
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (98629 => 98630)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2011-10-27 20:41:05 UTC (rev 98630)
@@ -82,6 +82,7 @@
'tests/TreeTestHelpers.h',
'tests/WebCompositorImplTest.cpp',
'tests/WebFrameTest.cpp',
+'tests/WebLayerTest.cpp',
'tests/WebURLRequestTest.cpp',
'tests/WebViewTest.cpp',
],
Modified: trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp (98629 => 98630)
--- trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebKit/chromium/src/WebContentLayerImpl.cpp 2011-10-27 20:41:05 UTC (rev 98630)
@@ -54,11 +54,13 @@
WebContentLayerImpl::~WebContentLayerImpl()
{
+setDelegate(0);
}
void WebContentLayerImpl::setDrawsContent(bool drawsContent)
{
m_drawsContent = drawsContent;
+setNeedsCommit();
}
bool WebContentLayerImpl::drawsContent() const
Modified: trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp (98629 => 98630)
--- trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp 2011-10-27 20:40:29 UTC (rev 98629)
+++ trunk/Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp 2011-10-27 20:41:05 UTC (rev 98630)
@@ -48,6 +48,7 @@
WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl()
{
+setDelegate(0);
}
bool WebExternalTextureLayerImpl::drawsContent() const
Modified: trunk/Source/WebKit/chromium/src/WebLayerImpl.cpp (98629 => 98
[webkit-changes] [98629] trunk/Source/JavaScriptCore
Title: [98629] trunk/Source/_javascript_Core Revision 98629 Author commit-qu...@webkit.org Date 2011-10-27 13:40:29 -0700 (Thu, 27 Oct 2011) Log Message Fix building on GNU/kFreeBSD https://bugs.webkit.org/show_bug.cgi?id=71005 Patch by Gustavo Noronha Silva on 2011-10-27 Reviewed by Darin Adler. * config.h: * wtf/Platform.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/config.h trunk/Source/_javascript_Core/wtf/Platform.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (98628 => 98629) --- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 20:30:08 UTC (rev 98628) +++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 20:40:29 UTC (rev 98629) @@ -1,3 +1,13 @@ +2011-10-27 Gustavo Noronha Silva + +Fix building on GNU/kFreeBSD +https://bugs.webkit.org/show_bug.cgi?id=71005 + +Reviewed by Darin Adler. + +* config.h: +* wtf/Platform.h: + 2011-10-27 Michael Saboff Investigate storing strings in 8-bit buffers when possible Modified: trunk/Source/_javascript_Core/config.h (98628 => 98629) --- trunk/Source/_javascript_Core/config.h 2011-10-27 20:30:08 UTC (rev 98628) +++ trunk/Source/_javascript_Core/config.h 2011-10-27 20:40:29 UTC (rev 98629) @@ -92,7 +92,7 @@ #define WTF_USE_OS_RANDOMNESS 1 #endif -#if OS(FREEBSD) || OS(OPENBSD) +#if (OS(FREEBSD) || OS(OPENBSD)) && !defined(__GLIBC__) #define HAVE_PTHREAD_NP_H 1 #endif Modified: trunk/Source/_javascript_Core/wtf/Platform.h (98628 => 98629) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-27 20:30:08 UTC (rev 98628) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-10-27 20:40:29 UTC (rev 98629) @@ -347,7 +347,7 @@ #endif /* OS(FREEBSD) - FreeBSD */ -#if defined(__FreeBSD__) || defined(__DragonFly__) +#if defined(__FreeBSD__) || defined(__DragonFly__) || defined(__FreeBSD_kernel__) #define WTF_OS_FREEBSD 1 #endif @@ -633,7 +633,7 @@ #endif #if !defined(HAVE_STRNSTR) -#if OS(DARWIN) || OS(FREEBSD) +#if OS(DARWIN) || (OS(FREEBSD) && !defined(__GLIBC__)) #define HAVE_STRNSTR 1 #endif #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98628] trunk
Title: [98628] trunk
Revision 98628
Author t...@chromium.org
Date 2011-10-27 13:30:08 -0700 (Thu, 27 Oct 2011)
Log Message
fix sizing of auto sized flexbox
https://bugs.webkit.org/show_bug.cgi?id=70839
Reviewed by David Hyatt.
Source/WebCore:
Correctly set the height of the flexbox when we have a column flow
and the height is auto.
Tests: css3/flexbox/columns-auto-size.html
css3/flexbox/flex-flow-margins-auto-size.html
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Always computeLogicalHeight() after we're done placing children.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection): Set the height as we place children.
LayoutTests:
* css3/flexbox/columns-auto-size-expected.txt: Added.
* css3/flexbox/columns-auto-size.html: Added.
* css3/flexbox/flex-flow-margins-auto-size-expected.txt: Added.
* css3/flexbox/flex-flow-margins-auto-size.html: Added.
A bunch of these cases fail, but that's because of bug 70769.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/columns-auto-size-expected.txt
trunk/LayoutTests/css3/flexbox/columns-auto-size.html
trunk/LayoutTests/css3/flexbox/flex-flow-margins-auto-size-expected.txt
trunk/LayoutTests/css3/flexbox/flex-flow-margins-auto-size.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98627 => 98628)
--- trunk/LayoutTests/ChangeLog 2011-10-27 20:28:40 UTC (rev 98627)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 20:30:08 UTC (rev 98628)
@@ -1,3 +1,16 @@
+2011-10-27 Tony Chang
+
+fix sizing of auto sized flexbox
+https://bugs.webkit.org/show_bug.cgi?id=70839
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/columns-auto-size-expected.txt: Added.
+* css3/flexbox/columns-auto-size.html: Added.
+* css3/flexbox/flex-flow-margins-auto-size-expected.txt: Added.
+* css3/flexbox/flex-flow-margins-auto-size.html: Added.
+A bunch of these cases fail, but that's because of bug 70769.
+
2011-10-25 Vangelis Kokkevis
Adding tests for fixed positioned elements getting their own composited layer.
Added: trunk/LayoutTests/css3/flexbox/columns-auto-size-expected.txt (0 => 98628)
--- trunk/LayoutTests/css3/flexbox/columns-auto-size-expected.txt (rev 0)
+++ trunk/LayoutTests/css3/flexbox/columns-auto-size-expected.txt 2011-10-27 20:30:08 UTC (rev 98628)
@@ -0,0 +1,6 @@
+PASS
+PASS
+PASS
+PASS
+PASS
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/columns-auto-size-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/css3/flexbox/columns-auto-size.html (0 => 98628)
--- trunk/LayoutTests/css3/flexbox/columns-auto-size.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/columns-auto-size.html 2011-10-27 20:30:08 UTC (rev 98628)
@@ -0,0 +1,94 @@
+
+
+
+body {
+margin: 0;
+}
+
+.flexbox {
+display: -webkit-flexbox;
+-webkit-flex-flow: column;
+background-color: #aaa;
+position: relative;
+}
+.horizontal {
+width: 400px;
+}
+
+.horizontal div {
+width: 100%;
+}
+.vertical {
+-webkit-writing-mode: vertical-rl;
+height: 50px;
+}
+.vertical div {
+height: 100%;
+}
+
+.flexbox > :nth-child(1) {
+background-color: blue;
+}
+.flexbox > :nth-child(2) {
+background-color: green;
+}
+.flexbox > :nth-child(3) {
+background-color: red;
+}
+.flexbox > :nth-child(4) {
+background-color: orange;
+}
+.child-div {
+background-color: yellow;
+}
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
[webkit-changes] [98627] trunk
Title: [98627] trunk
Revision 98627
Author vange...@chromium.org
Date 2011-10-27 13:28:40 -0700 (Thu, 27 Oct 2011)
Log Message
Source/WebCore: Add support for creating compositing layers for fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=69796
position:fixed elements will get a compositing layer if:
1. Settings:acceleratedCompositingForFixedPositionEnabled() returns true,
2. The element has its own stacking context (e.g. has a z-index), and
3. The element's container is the RenderView (e.g. not a descendant of a transformed element)
Reviewed by Simon Fraser.
Test: compositing/geometry/fixed-position-composited-switch.html
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedCompositingForFixedPositionEnabled):
(WebCore::Settings::acceleratedCompositingForFixedPositionEnabled):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:
* testing/Internals.cpp:
(WebCore::Internals::setEnableCompositingForFixedPosition):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests: Adding tests for fixed positioned elements getting their own composited layer.
https://bugs.webkit.org/show_bug.cgi?id=69796
Reviewed by Simon Fraser.
* compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
* compositing/geometry/fixed-position-composited-switch.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt
trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html
Diff
Modified: trunk/LayoutTests/ChangeLog (98626 => 98627)
--- trunk/LayoutTests/ChangeLog 2011-10-27 20:20:27 UTC (rev 98626)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 20:28:40 UTC (rev 98627)
@@ -1,3 +1,14 @@
+2011-10-25 Vangelis Kokkevis
+
+Adding tests for fixed positioned elements getting their own composited layer.
+https://bugs.webkit.org/show_bug.cgi?id=69796
+
+Reviewed by Simon Fraser.
+
+
+* compositing/geometry/fixed-position-composited-switch-expected.txt: Added.
+* compositing/geometry/fixed-position-composited-switch.html: Added.
+
2011-10-27 John Gregg
Unreviewed, more chromium baselines for new multicol tests.
Added: trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt (0 => 98627)
--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt 2011-10-27 20:28:40 UTC (rev 98627)
@@ -0,0 +1,20 @@
+Before (should be empty):
+
+After (should not be empty):
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (position 495.00 30.00)
+ (bounds 300.00 100.00)
+ (drawsContent 1)
+)
+ )
+)
+ )
+)
+After (should be empty):
+
Property changes on: trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html (0 => 98627)
--- trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html (rev 0)
+++ trunk/LayoutTests/compositing/geometry/fixed-position-composited-switch.html 2011-10-27 20:28:40 UTC (rev 98627)
@@ -0,0 +1,65 @@
+
+
+
+ Creating composited layers for fixed position elements
+
+
+#tall {
+ height: 100px;
+}
+
+#fixed {
+ width: 300px;
+ height: 100px;
+ position: fixed;
+ top: 30px;
+ right: 5px;
+ background-color: green;
+}
+
+
+if (window.internals)
+ window.internals.setEnableCompositingForFixedPosition(document, true);
+
+function doTest()
+{
+ var layerTreeOutput = '';
+
+ // If the fixed position element doesn't have its own stacking context then
+ // it cannot get a composited layer.
+ if (window.layoutTestController)
+layerTreeOutput += 'Before (should be empty): \n' + layoutTestController.layerTreeAsText() + '\n';
+
+ // Adding a z-index to the fixed position element will give it a stac
[webkit-changes] [98626] trunk/Source/WebCore
Title: [98626] trunk/Source/WebCore
Revision 98626
Author commit-qu...@webkit.org
Date 2011-10-27 13:20:27 -0700 (Thu, 27 Oct 2011)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=70390
Ensure font load for Skia backend during printing.
Patch by Arthur Hsu on 2011-10-27
Reviewed by James Robinson.
* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::paintSkiaText):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp
trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98625 => 98626)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 20:19:55 UTC (rev 98625)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 20:20:27 UTC (rev 98626)
@@ -1,3 +1,15 @@
+2011-10-27 Arthur Hsu
+
+https://bugs.webkit.org/show_bug.cgi?id=70390
+Ensure font load for Skia backend during printing.
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/FontChromiumWin.cpp:
+(WebCore::Font::drawGlyphs):
+* platform/graphics/skia/SkiaFontWin.cpp:
+(WebCore::paintSkiaText):
+
2011-10-27 Michael Saboff
Investigate storing strings in 8-bit buffers when possible
Modified: trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp (98625 => 98626)
--- trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-27 20:19:55 UTC (rev 98625)
+++ trunk/Source/WebCore/platform/graphics/chromium/FontChromiumWin.cpp 2011-10-27 20:20:27 UTC (rev 98626)
@@ -395,7 +395,6 @@
return;
HFONT hfont = font->platformData().hfont();
-PlatformSupport::ensureFontLoaded(hfont);
// We draw the glyphs in chunks to avoid having to do a heap allocation for
// the arrays of characters and advances.
Modified: trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp (98625 => 98626)
--- trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-27 20:19:55 UTC (rev 98625)
+++ trunk/Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp 2011-10-27 20:20:27 UTC (rev 98626)
@@ -35,6 +35,7 @@
#include "PlatformContextSkia.h"
#include "Gradient.h"
#include "Pattern.h"
+#include "PlatformSupport.h"
#include "SkCanvas.h"
#include "SkPaint.h"
#include "SkShader.h"
@@ -236,6 +237,9 @@
PlatformContextSkia* platformContext = context->platformContext();
SkCanvas* canvas = platformContext->canvas();
TextDrawingModeFlags textMode = platformContext->getTextDrawingMode();
+// Ensure font load for printing, because PDF device needs it.
+if (canvas->getTopDevice()->getDeviceCapabilities() & SkDevice::kVector_Capability)
+PlatformSupport::ensureFontLoaded(hfont);
// Filling (if necessary). This is the common case.
SkPaint paint;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98625] branches/safari-534.52-branch/Source
Title: [98625] branches/safari-534.52-branch/Source
Revision 98625
Author lforsch...@apple.com
Date 2011-10-27 13:19:55 -0700 (Thu, 27 Oct 2011)
Log Message
Versioning.
Modified Paths
branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig
Diff
Modified: branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig (98624 => 98625)
--- branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-27 20:16:20 UTC (rev 98624)
+++ branches/safari-534.52-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-10-27 20:19:55 UTC (rev 98625)
@@ -23,7 +23,7 @@
MAJOR_VERSION = 534;
MINOR_VERSION = 52;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
// The bundle version and short version string are set based on the current build configuration, see below.
Modified: branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (98624 => 98625)
--- branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-27 20:16:20 UTC (rev 98624)
+++ branches/safari-534.52-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-10-27 20:19:55 UTC (rev 98625)
@@ -23,7 +23,7 @@
MAJOR_VERSION = 534;
MINOR_VERSION = 52;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
// The bundle version and short version string are set based on the current build configuration, see below.
Modified: branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig (98624 => 98625)
--- branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-27 20:16:20 UTC (rev 98624)
+++ branches/safari-534.52-branch/Source/WebCore/Configurations/Version.xcconfig 2011-10-27 20:19:55 UTC (rev 98625)
@@ -23,7 +23,7 @@
MAJOR_VERSION = 534;
MINOR_VERSION = 52;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
// The bundle version and short version string are set based on the current build configuration, see below.
Modified: branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig (98624 => 98625)
--- branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-27 20:16:20 UTC (rev 98624)
+++ branches/safari-534.52-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-10-27 20:19:55 UTC (rev 98625)
@@ -23,7 +23,7 @@
MAJOR_VERSION = 534;
MINOR_VERSION = 52;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
// The bundle version and short version string are set based on the current build configuration, see below.
Modified: branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig (98624 => 98625)
--- branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-27 20:16:20 UTC (rev 98624)
+++ branches/safari-534.52-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-10-27 20:19:55 UTC (rev 98625)
@@ -23,7 +23,7 @@
MAJOR_VERSION = 534;
MINOR_VERSION = 52;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
// The bundle version and short version string are set based on the current build configuration, see below.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98623] trunk/LayoutTests
Title: [98623] trunk/LayoutTests
Revision 98623
Author john...@google.com
Date 2011-10-27 13:08:14 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, more chromium baselines for new multicol tests.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol: Removed.
* platform/chromium-linux/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/multicol/block-axis-horizontal-bt-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/multicol/block-axis-horizontal-tb-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/multicol/block-axis-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/multicol/block-axis-vertical-rl-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.png
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-horizontal-bt-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.png
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-horizontal-tb-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.png
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-vertical-lr-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.png
trunk/LayoutTests/platform/chromium-win/fast/multicol/block-axis-vertical-rl-expected.txt
Removed Paths
trunk/LayoutTests/platform/chromium-linux-x86/fast/multicol/
Diff
Modified: trunk/LayoutTests/ChangeLog (98622 => 98623)
--- trunk/LayoutTests/ChangeLog 2011-10-27 20:01:59 UTC (rev 98622)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 20:08:14 UTC (rev 98623)
@@ -1,5 +1,32 @@
2011-10-27 John Gregg
+Unreviewed, more chromium baselines for new multicol tests.
+
+* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-lr-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/fast/multicol/block-axis-vertical-rl-expected.png: Added.
+* platfo
[webkit-changes] [98622] trunk
Title: [98622] trunk
Revision 98622
Author wei...@apple.com
Date 2011-10-27 13:01:59 -0700 (Thu, 27 Oct 2011)
Log Message
Add allowsPlugIns property to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70987
Reviewed by Anders Carlsson.
Source/WebKit2:
Test: WKBrowsingContextGroupTest.GetSetPluginsEnabled
* UIProcess/API/mac/WKBrowsingContextGroup.h:
* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
Rename to allowsJavaScript/setAllowsJavaScript.
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
Add allowsPlugIns/setAllowsPlugIns.
Tools:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
Add basic test for WKBrowsingContextGroup.allowsPlugIns.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h
trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98621 => 98622)
--- trunk/Source/WebKit2/ChangeLog 2011-10-27 20:01:28 UTC (rev 98621)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-27 20:01:59 UTC (rev 98622)
@@ -1,3 +1,22 @@
+2011-10-27 Sam Weinig
+
+Add allowsPlugIns property to WKBrowsingContextGroup
+https://bugs.webkit.org/show_bug.cgi?id=70987
+
+Reviewed by Anders Carlsson.
+
+Test: WKBrowsingContextGroupTest.GetSetPluginsEnabled
+
+* UIProcess/API/mac/WKBrowsingContextGroup.h:
+* UIProcess/API/mac/WKBrowsingContextGroup.mm:
+(-[WKBrowsingContextGroup allowsJavaScript]):
+(-[WKBrowsingContextGroup setAllowsJavaScript:]):
+Rename to allowsJavaScript/setAllowsJavaScript.
+
+(-[WKBrowsingContextGroup allowsPlugIns]):
+(-[WKBrowsingContextGroup setAllowsPlugIns:]):
+Add allowsPlugIns/setAllowsPlugIns.
+
2011-10-27 Carlos Garcia Campos
[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h (98621 => 98622)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h 2011-10-27 20:01:28 UTC (rev 98621)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h 2011-10-27 20:01:59 UTC (rev 98622)
@@ -39,6 +39,14 @@
/* Settings */
-@property(getter = isJavaScriptEnabled) BOOL _javascript_Enabled;
+/* Setting to control whether _javascript_ referenced by a page is enabled.
+ Default: YES
+*/
+@property BOOL allowsJavaScript;
+/* Setting to control whether plug-ins are enabled.
+ Default: YES
+*/
+@property BOOL allowsPlugIns;
+
@end
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm (98621 => 98622)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm 2011-10-27 20:01:28 UTC (rev 98621)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm 2011-10-27 20:01:59 UTC (rev 98622)
@@ -61,16 +61,26 @@
[super dealloc];
}
-- (BOOL)isJavaScriptEnabled
+- (BOOL)allowsJavaScript
{
return WKPreferencesGetJavaScriptEnabled(WKPageGroupGetPreferences(self.pageGroupRef));
}
-- (void)setJavaScriptEnabled:(BOOL)_javascript_Enabled
+- (void)setAllowsJavaScript:(BOOL)allowsJavaScript
{
-WKPreferencesSetJavaScriptEnabled(WKPageGroupGetPreferences(self.pageGroupRef), _javascript_Enabled);
+WKPreferencesSetJavaScriptEnabled(WKPageGroupGetPreferences(self.pageGroupRef), allowsJavaScript);
}
+- (BOOL)allowsPlugIns
+{
+return WKPreferencesGetPluginsEnabled(WKPageGroupGetPreferences(self.pageGroupRef));
+}
+
+- (void)setAllowsPlugIns:(BOOL)allowsPlugIns
+{
+WKPreferencesSetPluginsEnabled(WKPageGroupGetPreferences(self.pageGroupRef), allowsPlugIns);
+}
+
@end
@implementation WKBrowsingContextGroup (Internal)
Modified: trunk/Tools/ChangeLog (98621 => 98622)
--- trunk/Tools/ChangeLog 2011-10-27 20:01:28 UTC (rev 98621)
+++ trunk/Tools/ChangeLog 2011-10-27 20:01:59 UTC (rev 98622)
@@ -1,3 +1,13 @@
+2011-10-27 Sam Weinig
+
+Add allowsPlugIns property to WKBrowsingContextGroup
+https://bugs.webkit.org/show_bug.cgi?id=70987
+
+Reviewed by Anders Carlsson.
+
+* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
+Add basic test for WKBrowsingContextGroup.allowsPlugIns.
+
2011-10-27 Adam Roben
Test WKBundlePageGetBackingScaleFactor
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm (98621 => 98622)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm 2011-10-27 20:01:28 UTC (rev 98621)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm 2011-10-27 20:01:59 UTC (rev 98622)
@@ -32,13 +32,24 @@
{
WKBrowsingContextGroup *browsingContextGroup = [[WKBrowsingContextGroup alloc] initWi
[webkit-changes] [98621] tags/Safari-534.52.5/
Title: [98621] tags/Safari-534.52.5/
Revision 98621
Author lforsch...@apple.com
Date 2011-10-27 13:01:28 -0700 (Thu, 27 Oct 2011)
Log Message
New tag.
Added Paths
tags/Safari-534.52.5/
Diff
Property changes: tags/Safari-534.52.5
Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild
Added: svn:mergeinfo
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98619] trunk/Source/WebKit/qt
Title: [98619] trunk/Source/WebKit/qt
Revision 98619
Author commit-qu...@webkit.org
Date 2011-10-27 12:52:48 -0700 (Thu, 27 Oct 2011)
Log Message
[Qt] Failure to build when QT_NO_MENU defined
https://bugs.webkit.org/show_bug.cgi?id=70970
Patch by Helder Correia on 2011-10-27
Reviewed by Andreas Kling.
iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.
Build fix, no new tests.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (98618 => 98619)
--- trunk/Source/WebKit/qt/ChangeLog 2011-10-27 19:33:29 UTC (rev 98618)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-10-27 19:52:48 UTC (rev 98619)
@@ -1,3 +1,16 @@
+2011-10-27 Helder Correia
+
+[Qt] Failure to build when QT_NO_MENU defined
+https://bugs.webkit.org/show_bug.cgi?id=70970
+
+Reviewed by Andreas Kling.
+
+iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.
+
+Build fix, no new tests.
+
+* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+
2011-10-26 Zalan Bujtas
Name viewport change event consistently.
Modified: trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp (98618 => 98619)
--- trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-10-27 19:33:29 UTC (rev 98618)
+++ trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp 2011-10-27 19:52:48 UTC (rev 98619)
@@ -1033,6 +1033,7 @@
corePage->settings()->setInteractiveFormValidationEnabled(enable);
}
+#ifndef QT_NO_MENU
static QStringList iterateContextMenu(QMenu* menu)
{
if (!menu)
@@ -1050,6 +1051,7 @@
}
return items;
}
+#endif
QStringList DumpRenderTreeSupportQt::contextMenu(QWebPage* page)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98618] trunk/Source
Title: [98618] trunk/Source
Revision 98618
Author nd...@chromium.org
Date 2011-10-27 12:33:29 -0700 (Thu, 27 Oct 2011)
Log Message
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714
Source/WebCore:
Reland of ill-fated r98612.
Reviewed by James Robinson.
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
Source/WebKit/chromium:
Reviewed by James Robinson.
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Added.
(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Added Paths
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h
trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98617 => 98618)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 19:22:31 UTC (rev 98617)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 19:33:29 UTC (rev 98618)
@@ -1,3 +1,25 @@
+2011-10-27 Nat Duca
+
+[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
+https://bugs.webkit.org/show_bug.cgi?id=70714
+
+Reland of ill-fated r98612.
+
+Reviewed by James Robinson.
+
+* WebCore.gypi:
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
+(WebCore::CCSchedulerStateMachine::nextAction):
+(WebCore::CCSchedulerStateMachine::updateState):
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
+(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
+(WebCore::CCSchedulerStateMachine::operator=):
+(WebCore::CCSchedulerStateMachine::commitPending):
+(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
+(WebCore::CCSchedulerStateMachine::setNeedsCommit):
+(WebCore::CCSchedulerStateMachine::beginFrameComplete):
+(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
+
2011-10-27 Pavel Podivilov
Get rid of optional parameters in the middle in IDLs.
Modified: trunk/Source/WebCore/WebCore.gypi (98617 => 98618)
--- trunk/Source/WebCore/WebCore.gypi 2011-10-27 19:22:31 UTC (rev 98617)
+++ trunk/Source/WebCore/WebCore.gypi 2011-10-27 19:33:29 UTC (rev 98618)
@@ -3560,6 +3560,8 @@
'platform/graphics/chromium/cc/CCRenderSurface.h',
'platform/graphics/chromium/cc/CCScheduler.cpp',
'platform/graphics/chromium/cc/CCScheduler.h',
+'platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp',
+'platform/graphics/chromium/cc/CCSchedulerStateMachine.h',
'platform/graphics/chromium/cc/CCScopedMainThreadProxy.h',
'platform/graphics/chromium/cc/CCScrollController.h',
'platform/graphics/chromium/cc/CCSingleThreadProxy.cpp',
Added: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (0 => 98618)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (rev 0)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 19:33:29 UTC (rev 98618)
@@ -0,0 +1,134 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
[webkit-changes] [98617] trunk
Title: [98617] trunk
Revision 98617
Author podivi...@chromium.org
Date 2011-10-27 12:22:31 -0700 (Thu, 27 Oct 2011)
Log Message
Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816
Reviewed by Adam Barth.
Optional parameters in the middle are prohibited by WebIDL spec.
Source/WebCore:
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateArgumentsCountCheck):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
* html/canvas/CanvasRenderingContext2D.idl:
* page/DOMWindow.idl:
LayoutTests:
* fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
* fast/canvas/canvas-putImageData.js:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt
trunk/LayoutTests/fast/canvas/canvas-putImageData.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl
trunk/Source/WebCore/page/DOMWindow.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (98616 => 98617)
--- trunk/LayoutTests/ChangeLog 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 19:22:31 UTC (rev 98617)
@@ -1,3 +1,15 @@
+2011-10-27 Pavel Podivilov
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* fast/canvas/canvas-putImageData-expected.txt: expectation was wrong, context.putImageData({}, 0, 0) should throw Type Error.
+* fast/canvas/canvas-putImageData.js:
+
2011-10-27 John Gregg
unreviewed, test expectations
Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt (98616 => 98617)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData-expected.txt 2011-10-27 19:22:31 UTC (rev 98617)
@@ -144,7 +144,7 @@
PASS getPixel(9,9) is [0,128,0,255]
PASS getPixel(1,1) is [0,128,0,255]
PASS getPixel(9,9) is [0,128,0,255]
-PASS context.putImageData({}, 0, 0) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
+PASS context.putImageData({}, 0, 0) threw exception TypeError: Type error.
PASS context.putImageData(buffer, NaN, 0, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
PASS context.putImageData(buffer, 0, NaN, 0, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
PASS context.putImageData(buffer, 0, 0, NaN, 0, 0, 0) threw exception Error: NOT_SUPPORTED_ERR: DOM Exception 9.
Modified: trunk/LayoutTests/fast/canvas/canvas-putImageData.js (98616 => 98617)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData.js 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData.js 2011-10-27 19:22:31 UTC (rev 98617)
@@ -201,7 +201,7 @@
pixelShouldBe(9, 9, [0, 128,0,255]);
-shouldThrow("context.putImageData({}, 0, 0)", "'Error: TYPE_MISMATCH_ERR: DOM Exception 17'");
+shouldThrow("context.putImageData({}, 0, 0)", "'TypeError: Type error'");
shouldThrow("context.putImageData(buffer, NaN, 0, 0, 0, 0, 0)", "'Error: NOT_SUPPORTED_ERR: DOM Exception 9'");
shouldThrow("context.putImageData(buffer, 0, NaN, 0, 0, 0, 0)", "'Error: NOT_SUPPORTED_ERR: DOM Exception 9'");
shouldThrow("context.putImageData(buffer, 0, 0, NaN, 0, 0, 0)", "'Error: NOT_SUPPORTED_ERR: DOM Exception 9'");
Modified: trunk/Source/WebCore/ChangeLog (98616 => 98617)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 19:16:15 UTC (rev 98616)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 19:22:31 UTC (rev 98617)
@@ -1,3 +1,28 @@
+2011-10-27 Pavel Podivilov
+
+Get rid of optional parameters in the middle in IDLs.
+https://bugs.webkit.org/show_bug.cgi?id=70816
+
+Reviewed by Adam Barth.
+
+Optional parameters in the middle are prohibited by WebIDL spec.
+
+* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/CodeGeneratorV8.pm
[webkit-changes] [98616] trunk/LayoutTests
Title: [98616] trunk/LayoutTests
Revision 98616
Author john...@google.com
Date 2011-10-27 12:16:15 -0700 (Thu, 27 Oct 2011)
Log Message
unreviewed, test expectations
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98615 => 98616)
--- trunk/LayoutTests/ChangeLog 2011-10-27 19:15:05 UTC (rev 98615)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 19:16:15 UTC (rev 98616)
@@ -1,3 +1,9 @@
+2011-10-27 John Gregg
+
+unreviewed, test expectations
+
+* platform/chromium/test_expectations.txt:
+
2011-10-27 Dan Bernstein
Allow column progression to be independent of writing mode
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98615 => 98616)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 19:15:05 UTC (rev 98615)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 19:16:15 UTC (rev 98616)
@@ -1084,7 +1084,7 @@
BUGWK70748 CPU : media/video-no-audio.html = IMAGE
BUGWK70748 CPU : media/video-playing-and-pause.html = IMAGE
BUGWK70748 CPU : media/video-volume-slider.html = IMAGE
-BUGWK70748 GPU : media/video-zoom-controls.html = IMAGE+TEXT
+BUGWK70748 GPU : media/video-zoom-controls.html = IMAGE
BUGWK70748 GPU : media/audio-controls-rendering.html = IMAGE
BUGWK70748 GPU : media/controls-after-reload.html = IMAGE
BUGWK70748 GPU : media/controls-strict.html = IMAGE
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98615] trunk/Source/WebCore
Title: [98615] trunk/Source/WebCore
Revision 98615
Author an...@apple.com
Date 2011-10-27 12:15:05 -0700 (Thu, 27 Oct 2011)
Log Message
REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
https://bugs.webkit.org/show_bug.cgi?id=71032
Reviewed by Dave Hyatt.
If we apply an explicitly inherited property, we need to apply any further
non-inherited properties as the property might get overridden again.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::styleForKeyframe):
(WebCore::CSSStyleSelector::styleForPage):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
* css/CSSStyleSelector.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp
trunk/Source/WebCore/css/CSSStyleSelector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98614 => 98615)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 19:12:39 UTC (rev 98614)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 19:15:05 UTC (rev 98615)
@@ -1,3 +1,20 @@
+2011-10-27 Antti Koivisto
+
+REGRESSION(r98542): tables/mozilla_expected_failures/bugs/bug14007-2.html
+https://bugs.webkit.org/show_bug.cgi?id=71032
+
+Reviewed by Dave Hyatt.
+
+If we apply an explicitly inherited property, we need to apply any further
+non-inherited properties as the property might get overridden again.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::styleForKeyframe):
+(WebCore::CSSStyleSelector::styleForPage):
+(WebCore::CSSStyleSelector::applyDeclaration):
+(WebCore::CSSStyleSelector::applyDeclarations):
+* css/CSSStyleSelector.h:
+
2011-10-27 Julien Chaffraix
Remove RenderTableSection::m_gridRows
Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (98614 => 98615)
--- trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-27 19:12:39 UTC (rev 98614)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp 2011-10-27 19:15:05 UTC (rev 98615)
@@ -1264,8 +1264,9 @@
// We don't need to bother with !important. Since there is only ever one
// decl, there's nothing to override. So just add the first properties.
+bool inheritedOnly = false;
if (keyframeRule->style())
-applyDeclarations(false, 0, m_matchedDecls.size() - 1);
+applyDeclarations(false, 0, m_matchedDecls.size() - 1, inheritedOnly);
// If our font got dirtied, go ahead and update it now.
updateFont();
@@ -1276,7 +1277,7 @@
// Now do rest of the properties.
if (keyframeRule->style())
-applyDeclarations(false, 0, m_matchedDecls.size() - 1);
+applyDeclarations(false, 0, m_matchedDecls.size() - 1, inheritedOnly);
// If our font got dirtied by one of the non-essential font props,
// go ahead and update it a second time.
@@ -1411,7 +1412,8 @@
matchPageRules(m_userStyle.get(), isLeft, isFirst, page);
matchPageRules(m_authorStyle.get(), isLeft, isFirst, page);
m_lineHeightValue = 0;
-applyDeclarations(false, 0, m_matchedDecls.size() - 1);
+bool inheritedOnly = false;
+applyDeclarations(false, 0, m_matchedDecls.size() - 1, inheritedOnly);
// If our font got dirtied, go ahead and update it now.
updateFont();
@@ -1420,7 +1422,7 @@
if (m_lineHeightValue)
applyProperty(CSSPropertyLineHeight, m_lineHeightValue);
-applyDeclarations(false, 0, m_matchedDecls.size() - 1);
+applyDeclarations(false, 0, m_matchedDecls.size() - 1, inheritedOnly);
// Start loading images referenced by this style.
loadPendingImages();
@@ -2096,15 +2098,21 @@
}
template
-void CSSStyleSelector::applyDeclaration(CSSMutableStyleDeclaration* styleDeclaration, bool isImportant, bool inheritedOnly)
+void CSSStyleSelector::applyDeclaration(CSSMutableStyleDeclaration* styleDeclaration, bool isImportant, bool& inheritedOnly)
{
CSSMutableStyleDeclaration::const_iterator end = styleDeclaration->end();
for (CSSMutableStyleDeclaration::const_iterator it = styleDeclaration->begin(); it != end; ++it) {
const CSSProperty& current = *it;
if (isImportant != current.isImportant())
continue;
-if (inheritedOnly && !current.isInherited() && current.value()->cssValueType() != CSSValue::CSS_INHERIT)
-continue;
+if (inheritedOnly && !current.isInherited()) {
+if (current.value()->cssValueType() != CSSValue::CSS_INHERIT)
+continue;
+// If the property value is explicitly inherited, we need to apply further non-inherited properties
+// as they might override the value inherited here. This is really per-property but that is
+// probably not worth optimizing for.
+inheritedOnly = false;
+}
int property = current.id();
if (applyFirst) {
COMPILE_ASSERT(firstCSSProperty == CSSPropertyColor, CSS_color_is_first_property
[webkit-changes] [98614] trunk/Source/WebCore
Title: [98614] trunk/Source/WebCore
Revision 98614
Author jchaffr...@webkit.org
Date 2011-10-27 12:12:39 -0700 (Thu, 27 Oct 2011)
Log Message
Remove RenderTableSection::m_gridRows
https://bugs.webkit.org/show_bug.cgi?id=70570
Reviewed by Darin Adler.
No new test, refactoring only.
Just nuke the old field that was duplicating
m_grid.size().
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::numRows):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paint):
(WebCore::RenderTableSection::paintObject):
(WebCore::RenderTableSection::clearGrid):
(WebCore::RenderTableSection::numColumns):
(WebCore::RenderTableSection::appendColumn):
(WebCore::RenderTableSection::splitColumn):
s/m_gridRows/m_grid.size()/.
Also updated the code as m_grid.size() is unsigned.
(WebCore::RenderTableSection::recalcCells):
The old code would keep the grid's memory but we have to clear it to properly
count the elements. To avoid lots of small reallocations, we reallocate the
buffer at the old capacity upfront.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp
trunk/Source/WebCore/rendering/RenderTableSection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98613 => 98614)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 18:45:28 UTC (rev 98613)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 19:12:39 UTC (rev 98614)
@@ -1,3 +1,42 @@
+2011-10-27 Julien Chaffraix
+
+Remove RenderTableSection::m_gridRows
+https://bugs.webkit.org/show_bug.cgi?id=70570
+
+Reviewed by Darin Adler.
+
+No new test, refactoring only.
+
+Just nuke the old field that was duplicating
+m_grid.size().
+
+* rendering/RenderTableSection.h:
+(WebCore::RenderTableSection::numRows):
+* rendering/RenderTableSection.cpp:
+(WebCore::RenderTableSection::RenderTableSection):
+(WebCore::RenderTableSection::ensureRows):
+(WebCore::RenderTableSection::setCellLogicalWidths):
+(WebCore::RenderTableSection::calcRowLogicalHeight):
+(WebCore::RenderTableSection::layoutRows):
+(WebCore::RenderTableSection::calcOuterBorderBefore):
+(WebCore::RenderTableSection::calcOuterBorderAfter):
+(WebCore::RenderTableSection::calcOuterBorderStart):
+(WebCore::RenderTableSection::calcOuterBorderEnd):
+(WebCore::RenderTableSection::firstLineBoxBaseline):
+(WebCore::RenderTableSection::paint):
+(WebCore::RenderTableSection::paintObject):
+(WebCore::RenderTableSection::clearGrid):
+(WebCore::RenderTableSection::numColumns):
+(WebCore::RenderTableSection::appendColumn):
+(WebCore::RenderTableSection::splitColumn):
+s/m_gridRows/m_grid.size()/.
+Also updated the code as m_grid.size() is unsigned.
+
+(WebCore::RenderTableSection::recalcCells):
+The old code would keep the grid's memory but we have to clear it to properly
+count the elements. To avoid lots of small reallocations, we reallocate the
+buffer at the old capacity upfront.
+
2011-10-27 Nat Duca
Unreviewed, rolling out r98612.
Modified: trunk/Source/WebCore/rendering/RenderTableSection.cpp (98613 => 98614)
--- trunk/Source/WebCore/rendering/RenderTableSection.cpp 2011-10-27 18:45:28 UTC (rev 98613)
+++ trunk/Source/WebCore/rendering/RenderTableSection.cpp 2011-10-27 19:12:39 UTC (rev 98614)
@@ -58,7 +58,6 @@
RenderTableSection::RenderTableSection(Node* node)
: RenderBox(node)
-, m_gridRows(0)
, m_cCol(0)
, m_cRow(-1)
, m_outerBorderStart(0)
@@ -177,17 +176,16 @@
bool RenderTableSection::ensureRows(int numRows)
{
-int nRows = m_gridRows;
-if (numRows > nRows) {
-if (numRows > static_cast(m_grid.size())) {
-size_t maxSize = numeric_limits::max() / sizeof(RowStruct);
-if (static_cast(numRows) > maxSize)
-return false;
-m_grid.grow(numRows);
-}
-m_gridRows = numRows;
+if (numRows > static_cast(m_grid.size())) {
+size_t maxSize = numeric_limits::max() / sizeof(RowStruct);
+if (static_cast(numRows) > maxSize)
+return false;
+
+unsigned oldSize = m_grid.size();
+m_grid.grow(numRows);
+
int nCols = max(1, table()->numEffCols());
-for (int r = nRows; r < numRows; r++) {
+for (int r = oldSize; r < numRows; r++) {
[webkit-changes] [98613] trunk/Source
Title: [98613] trunk/Source
Revision 98613
Author nd...@chromium.org
Date 2011-10-27 11:45:28 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, rolling out r98612.
http://trac.webkit.org/changeset/98612
https://bugs.webkit.org/show_bug.cgi?id=70714
Broke build
Source/WebCore:
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Removed.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Removed Paths
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h
trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98612 => 98613)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 18:29:40 UTC (rev 98612)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 18:45:28 UTC (rev 98613)
@@ -1,3 +1,15 @@
+2011-10-27 Nat Duca
+
+Unreviewed, rolling out r98612.
+http://trac.webkit.org/changeset/98612
+https://bugs.webkit.org/show_bug.cgi?id=70714
+
+Broke build
+
+* WebCore.gypi:
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
+
2011-10-24 Nat Duca
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
Modified: trunk/Source/WebCore/WebCore.gypi (98612 => 98613)
--- trunk/Source/WebCore/WebCore.gypi 2011-10-27 18:29:40 UTC (rev 98612)
+++ trunk/Source/WebCore/WebCore.gypi 2011-10-27 18:45:28 UTC (rev 98613)
@@ -3560,8 +3560,6 @@
'platform/graphics/chromium/cc/CCRenderSurface.h',
'platform/graphics/chromium/cc/CCScheduler.cpp',
'platform/graphics/chromium/cc/CCScheduler.h',
-'platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp',
-'platform/graphics/chromium/cc/CCSchedulerStateMachine.h',
'platform/graphics/chromium/cc/CCScopedMainThreadProxy.h',
'platform/graphics/chromium/cc/CCScrollController.h',
'platform/graphics/chromium/cc/CCSingleThreadProxy.cpp',
Deleted: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (98612 => 98613)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 18:29:40 UTC (rev 98612)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 18:45:28 UTC (rev 98613)
@@ -1,134 +0,0 @@
-/*
- * Copyright (C) 2011 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#include "cc/CCSchedulerStateMachine.h"
-
-namespace WebCore {
-
-CCSchedulerStateMachine::CCSchedulerStateMachine()
-: m_commitState(COMMIT_STATE_IDLE)
-, m_needsRedraw(false)
-, m_needsCommit(false)
-, m_updatedThisFrame(false) { }
-
-CCSchedulerStateMachine::CCSchedulerStateMachine(const CCSchedulerStateMachine& that)
-{
-*this = that;
-}
-
-CCSchedulerStateMachine::CCSchedulerStateMachine& operator=(const CCSchedulerStateMachine& that)
-{
-m_commitState = that.m_commitState;
-m_needsRedraw = that.m_needsRedraw;
-m_needsCommit = that.m_needsCommit;
-m_updatedThisFrame = that.m_updatedThisFrame;
-return *this;
-}
-
-CCSchedulerStateMachine::Action CCSchedulerStateMachine::nextAction(bool insideVSyncTick) const
-{
-switch (m_commitState)
[webkit-changes] [98612] trunk/Source
Title: [98612] trunk/Source
Revision 98612
Author nd...@chromium.org
Date 2011-10-27 11:29:40 -0700 (Thu, 27 Oct 2011)
Log Message
[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714
Reviewed by James Robinson.
Source/WebCore:
* WebCore.gypi:
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::operator=):
(WebCore::CCSchedulerStateMachine::commitPending):
(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
(WebCore::CCSchedulerStateMachine::setNeedsCommit):
(WebCore::CCSchedulerStateMachine::beginFrameComplete):
(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCSchedulerStateMachineTest.cpp: Added.
(WebCore::StateMachine::setCommitState):
(WebCore::StateMachine::commitState):
(WebCore::StateMachine::setNeedsCommit):
(WebCore::StateMachine::needsCommit):
(WebCore::StateMachine::setNeedsRedraw):
(WebCore::StateMachine::needsRedraw):
(WebCore::StateMachine::setUpdatedThisFrame):
(WebCore::StateMachine::updatedThisFrame):
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
Added Paths
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h
trunk/Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98611 => 98612)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 18:27:23 UTC (rev 98611)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 18:29:40 UTC (rev 98612)
@@ -1,3 +1,23 @@
+2011-10-24 Nat Duca
+
+[chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine
+https://bugs.webkit.org/show_bug.cgi?id=70714
+
+Reviewed by James Robinson.
+
+* WebCore.gypi:
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Added.
+(WebCore::CCSchedulerStateMachine::nextAction):
+(WebCore::CCSchedulerStateMachine::updateState):
+* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Added.
+(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
+(WebCore::CCSchedulerStateMachine::operator=):
+(WebCore::CCSchedulerStateMachine::commitPending):
+(WebCore::CCSchedulerStateMachine::setNeedsRedraw):
+(WebCore::CCSchedulerStateMachine::setNeedsCommit):
+(WebCore::CCSchedulerStateMachine::beginFrameComplete):
+(WebCore::CCSchedulerStateMachine::updateResourcesComplete):
+
2011-10-27 Dan Bernstein
Allow column progression to be independent of writing mode
Modified: trunk/Source/WebCore/WebCore.gypi (98611 => 98612)
--- trunk/Source/WebCore/WebCore.gypi 2011-10-27 18:27:23 UTC (rev 98611)
+++ trunk/Source/WebCore/WebCore.gypi 2011-10-27 18:29:40 UTC (rev 98612)
@@ -3560,6 +3560,8 @@
'platform/graphics/chromium/cc/CCRenderSurface.h',
'platform/graphics/chromium/cc/CCScheduler.cpp',
'platform/graphics/chromium/cc/CCScheduler.h',
+'platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp',
+'platform/graphics/chromium/cc/CCSchedulerStateMachine.h',
'platform/graphics/chromium/cc/CCScopedMainThreadProxy.h',
'platform/graphics/chromium/cc/CCScrollController.h',
'platform/graphics/chromium/cc/CCSingleThreadProxy.cpp',
Added: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (0 => 98612)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp (rev 0)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp 2011-10-27 18:29:40 UTC (rev 98612)
@@ -0,0 +1,134 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+ * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULA
[webkit-changes] [98611] tags/Safari-535.7/
Title: [98611] tags/Safari-535.7/
Revision 98611
Author lforsch...@apple.com
Date 2011-10-27 11:27:23 -0700 (Thu, 27 Oct 2011)
Log Message
New tag.
Added Paths
tags/Safari-535.7/
Diff
Property changes: tags/Safari-535.7
Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild
Added: svn:mergeinfo
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98610] branches/safari-534.52-branch/Source/WebCore
Title: [98610] branches/safari-534.52-branch/Source/WebCore
Revision 98610
Author lforsch...@apple.com
Date 2011-10-27 11:13:04 -0700 (Thu, 27 Oct 2011)
Log Message
Merged r98530.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98609 => 98610)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 18:11:07 UTC (rev 98609)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 18:13:04 UTC (rev 98610)
@@ -1,5 +1,20 @@
2011-10-27 Lucas Forschler
+Merge 98530
+
+2011-10-26 Steve Falkenburg
+
+ResourceError doesn't support custom domains on Windows
+https://bugs.webkit.org/show_bug.cgi?id=70983
+
+
+Reviewed by Oliver Hunt.
+
+* platform/network/cf/ResourceErrorCF.cpp:
+(WebCore::ResourceError::platformLazyInit): Add fallback case for unknown error types.
+
+2011-10-27 Lucas Forschler
+
Merge 98503
2011-10-25 Alexey Proskuryakov
Modified: branches/safari-534.52-branch/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp (98609 => 98610)
--- branches/safari-534.52-branch/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp 2011-10-27 18:11:07 UTC (rev 98609)
+++ branches/safari-534.52-branch/Source/WebCore/platform/network/cf/ResourceErrorCF.cpp 2011-10-27 18:13:04 UTC (rev 98610)
@@ -84,6 +84,8 @@
m_domain = "NSOSStatusErrorDomain";
else if (domain == kCFErrorDomainWinSock)
m_domain = "kCFErrorDomainWinSock";
+else
+m_domain = domain;
m_errorCode = CFErrorGetCode(m_platformError.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98609] branches/safari-534.52-branch/Source/WebKit2
Title: [98609] branches/safari-534.52-branch/Source/WebKit2
Revision 98609
Author lforsch...@apple.com
Date 2011-10-27 11:11:07 -0700 (Thu, 27 Oct 2011)
Log Message
Merged r98526.
Modified Paths
branches/safari-534.52-branch/Source/WebKit2/ChangeLog
branches/safari-534.52-branch/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm
Diff
Modified: branches/safari-534.52-branch/Source/WebKit2/ChangeLog (98608 => 98609)
--- branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 17:59:32 UTC (rev 98608)
+++ branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 18:11:07 UTC (rev 98609)
@@ -1,5 +1,19 @@
2011-10-27 Lucas Forschler
+Merge 98526
+
+2011-10-26 Alexey Proskuryakov
+
+REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
+https://bugs.webkit.org/show_bug.cgi?id=70982
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
+Null check page, it may be invalid already.
+
+2011-10-27 Lucas Forschler
+
Merge 98503
2011-10-25 Alexey Proskuryakov
Modified: branches/safari-534.52-branch/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm (98608 => 98609)
--- branches/safari-534.52-branch/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2011-10-27 17:59:32 UTC (rev 98608)
+++ branches/safari-534.52-branch/Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm 2011-10-27 18:11:07 UTC (rev 98609)
@@ -92,7 +92,8 @@
[self _setAutodisplay:YES];
// Enabling autodisplay normally implicitly calls endPrinting() via -[WKView drawRect:], but not when content is in accelerated compositing mode.
-_webFrame->page()->endPrinting();
+if (_webFrame->page())
+_webFrame->page()->endPrinting();
}
- (void)_delayedResumeAutodisplay
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98607] trunk/LayoutTests
Title: [98607] trunk/LayoutTests
Revision 98607
Author john...@google.com
Date 2011-10-27 10:58:02 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, adding additional expected failures.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98606 => 98607)
--- trunk/LayoutTests/ChangeLog 2011-10-27 17:55:26 UTC (rev 98606)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 17:58:02 UTC (rev 98607)
@@ -1,5 +1,11 @@
2011-10-27 John Gregg
+Unreviewed, adding additional expected failures.
+
+* platform/chromium/test_expectations.txt:
+
+2011-10-27 John Gregg
+
Unreviewed, fixing duplicate entries in test expectations.
* platform/chromium/test_expectations.txt:
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98606 => 98607)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:55:26 UTC (rev 98606)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:58:02 UTC (rev 98607)
@@ -1084,6 +1084,19 @@
BUGWK70748 CPU : media/video-no-audio.html = IMAGE
BUGWK70748 CPU : media/video-playing-and-pause.html = IMAGE
BUGWK70748 CPU : media/video-volume-slider.html = IMAGE
+BUGWK70748 GPU : media/video-zoom-controls.html = IMAGE+TEXT
+BUGWK70748 GPU : media/audio-controls-rendering.html = IMAGE
+BUGWK70748 GPU : media/controls-after-reload.html = IMAGE
+BUGWK70748 GPU : media/controls-strict.html = IMAGE
+BUGWK70748 GPU : media/controls-styling.html = IMAGE
+BUGWK70748 GPU : media/controls-without-preload.html = IMAGE
+BUGWK70748 GPU : media/media-controls-clone.html = IMAGE
+BUGWK70748 GPU : media/video-controls-rendering.html = IMAGE
+BUGWK70748 GPU : media/video-display-toggle.html = IMAGE
+BUGWK70748 GPU : media/video-empty-source.html = IMAGE
+BUGWK70748 GPU : media/video-no-audio.html = IMAGE
+BUGWK70748 GPU : media/video-playing-and-pause.html = IMAGE
+BUGWK70748 GPU : media/video-volume-slider.html = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-in-mask-objectBoundingBox.svg = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-in-mask-userSpaceOnUse.svg = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-path-clipped-evenodd-twice.svg = IMAGE
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98606] trunk/Source/JavaScriptCore
Title: [98606] trunk/Source/_javascript_Core
Revision 98606
Author mhahnenb...@apple.com
Date 2011-10-27 10:55:26 -0700 (Thu, 27 Oct 2011)
Log Message
Fixing windows build
Unreviewed build fix
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98605 => 98606)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 17:54:54 UTC (rev 98605)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 17:55:26 UTC (rev 98606)
@@ -1,5 +1,13 @@
2011-10-27 Mark Hahnenberg
+Fixing windows build
+
+Unreviewed build fix
+
+* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
+
+2011-10-27 Mark Hahnenberg
+
Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986
Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (98605 => 98606)
--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-27 17:54:54 UTC (rev 98605)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def 2011-10-27 17:55:26 UTC (rev 98606)
@@ -342,6 +342,7 @@
?toString@JSObject@JSC@@QBE?AVUString@2@PAVExecState@2@@Z
?toStringDecimal@DecimalNumber@WTF@@QBEIPA_WI@Z
?toStringExponential@DecimalNumber@WTF@@QBEIPA_WI@Z
+?toThisObject@JSObject@JSC@@SAPAV12@PAVJSCell@2@PAVExecState@2@@Z
?toThisObjectSlowCase@JSValue@JSC@@ABEPAVJSObject@2@PAVExecState@2@@Z
?toUInt32@Identifier@JSC@@SAIABVUString@2@AA_N@Z
?tryFastCalloc@WTF@@YA?AUTryMallocReturnValue@1@II@Z
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98605] branches/safari-534.52-branch/Source
Title: [98605] branches/safari-534.52-branch/Source
Revision 98605
Author lforsch...@apple.com
Date 2011-10-27 10:54:54 -0700 (Thu, 27 Oct 2011)
Log Message
Merged r98503.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/WebCore.exp.in
branches/safari-534.52-branch/Source/WebKit2/ChangeLog
branches/safari-534.52-branch/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Plugin.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98604 => 98605)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 17:52:17 UTC (rev 98604)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 17:54:54 UTC (rev 98605)
@@ -1,5 +1,18 @@
2011-10-27 Lucas Forschler
+Merge 98503
+
+2011-10-25 Alexey Proskuryakov
+
+Embedded PDFs should be known to DocumentLoader
+https://bugs.webkit.org/show_bug.cgi?id=70864
+
+Reviewed by Darin Adler.
+
+* WebCore.exp.in: Added exports.
+
+2011-10-27 Lucas Forschler
+
Merge 98304
2011-10-24 Anders Carlsson
Modified: branches/safari-534.52-branch/Source/WebCore/WebCore.exp.in (98604 => 98605)
--- branches/safari-534.52-branch/Source/WebCore/WebCore.exp.in 2011-10-27 17:52:17 UTC (rev 98604)
+++ branches/safari-534.52-branch/Source/WebCore/WebCore.exp.in 2011-10-27 17:54:54 UTC (rev 98605)
@@ -284,6 +284,7 @@
__ZN7WebCore12RenderWidget19showSubstituteImageEN3WTF10PassRefPtrINS_5ImageEEE
__ZN7WebCore12RenderWidget28resumeWidgetHierarchyUpdatesEv
__ZN7WebCore12RenderWidget29suspendWidgetHierarchyUpdatesEv
+__ZN7WebCore12SharedBuffer10wrapCFDataEPK8__CFData
__ZN7WebCore12SharedBuffer10wrapNSDataEP6NSData
__ZN7WebCore12SharedBuffer12createNSDataEv
__ZN7WebCore12SharedBuffer24createWithContentsOfFileERKN3WTF6StringE
@@ -554,7 +555,11 @@
__ZN7WebCore19TextResourceDecoderD1Ev
__ZN7WebCore19applicationIsSafariEv
__ZN7WebCore20RenderEmbeddedObject30setShowsCrashedPluginIndicatorEv
+__ZN7WebCore20ResourceResponseBase11setMimeTypeERKN3WTF6StringE
+__ZN7WebCore20ResourceResponseBase17setHTTPStatusCodeEi
+__ZN7WebCore20ResourceResponseBase20setSuggestedFilenameERKN3WTF6StringE
__ZN7WebCore20ResourceResponseBase24setExpectedContentLengthEx
+__ZN7WebCore20ResourceResponseBase6setURLERKNS_4KURLE
__ZN7WebCore20ResourceResponseBaseC2Ev
__ZN7WebCore20SpaceSplitStringData12createVectorEv
__ZN7WebCore20UserGestureIndicator23s_processingUserGestureE
Modified: branches/safari-534.52-branch/Source/WebKit2/ChangeLog (98604 => 98605)
--- branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 17:52:17 UTC (rev 98604)
+++ branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 17:54:54 UTC (rev 98605)
@@ -1,5 +1,52 @@
2011-10-27 Lucas Forschler
+Merge 98503
+
+2011-10-25 Alexey Proskuryakov
+
+Embedded PDFs should be known to DocumentLoader
+https://bugs.webkit.org/show_bug.cgi?id=70864
+
+Reviewed by Darin Adler.
+
+* WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested
+file name, in case the plug-in wants to save the file properly.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.h:
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+(WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader.
+(WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource.
+(WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource
+for that. The URL needs to match one in HitTestResult, so we can't use response URL.
+(WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so
+that we could put it in archive resource later.
+(WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.
+
+* PluginProcess/PluginControllerProxy.cpp:
+(WebKit::PluginControllerProxy::streamDidReceiveResponse):
+(WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
+Pass an empty string for suggested file name. No plug-in that runs in a separate process
+cares about it, so it's not sent to the p
[webkit-changes] [98604] branches/safari-534.52-branch/Source/WebCore
Title: [98604] branches/safari-534.52-branch/Source/WebCore
Revision 98604
Author lforsch...@apple.com
Date 2011-10-27 10:52:17 -0700 (Thu, 27 Oct 2011)
Log Message
Merge 98304.
Modified Paths
branches/safari-534.52-branch/Source/WebCore/ChangeLog
branches/safari-534.52-branch/Source/WebCore/platform/Widget.h
branches/safari-534.52-branch/Source/WebCore/rendering/RenderWidget.cpp
branches/safari-534.52-branch/Source/WebCore/rendering/RenderWidget.h
Diff
Modified: branches/safari-534.52-branch/Source/WebCore/ChangeLog (98603 => 98604)
--- branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 17:46:20 UTC (rev 98603)
+++ branches/safari-534.52-branch/Source/WebCore/ChangeLog 2011-10-27 17:52:17 UTC (rev 98604)
@@ -1,3 +1,33 @@
+2011-10-27 Lucas Forschler
+
+Merge 98304
+
+2011-10-24 Anders Carlsson
+
+It should be possible for Widget subclasses to control whether transforms affect the frame rect
+https://bugs.webkit.org/show_bug.cgi?id=70787
+
+Reviewed by Sam Weinig.
+
+Currently RenderWidget sets the frame rect of it's hosted widget to the bounding box of the transformed
+content box rect (unless the Widget is a frame view). It should be possible for Widget subclasses to override
+this behavior and have the frame rect set to the absolute content box without any transforms applied.
+
+* platform/Widget.h:
+(WebCore::Widget::transformsAffectFrameRect):
+Add new member function.
+
+* rendering/RenderWidget.cpp:
+(WebCore::RenderWidget::updateWidgetGeometry):
+Move shared code from setWidget and updateWidgetPosition out into a new function. If transformsAffectFrameRect returns
+false, just set the frame rect to the absolute content box.
+
+(WebCore::RenderWidget::setWidget):
+(WebCore::RenderWidget::updateWidgetPosition):
+Call updateWidgetGeometry.
+
+* rendering/RenderWidget.h:
+
2011-10-26 Lucas Forschler
Merge 98178
Modified: branches/safari-534.52-branch/Source/WebCore/platform/Widget.h (98603 => 98604)
--- branches/safari-534.52-branch/Source/WebCore/platform/Widget.h 2011-10-27 17:46:20 UTC (rev 98603)
+++ branches/safari-534.52-branch/Source/WebCore/platform/Widget.h 2011-10-27 17:52:17 UTC (rev 98604)
@@ -215,6 +215,10 @@
// Notifies this widget that other widgets on the page have been repositioned.
virtual void widgetPositionsUpdated() {}
+// Whether transforms affect the frame rect. FIXME: We get rid of this and have
+// the frame rects be the same no matter what transforms are applied.
+virtual bool transformsAffectFrameRect() { return true; }
+
#if PLATFORM(MAC)
NSView* getOuterView() const;
Modified: branches/safari-534.52-branch/Source/WebCore/rendering/RenderWidget.cpp (98603 => 98604)
--- branches/safari-534.52-branch/Source/WebCore/rendering/RenderWidget.cpp 2011-10-27 17:46:20 UTC (rev 98603)
+++ branches/safari-534.52-branch/Source/WebCore/rendering/RenderWidget.cpp 2011-10-27 17:52:17 UTC (rev 98604)
@@ -191,6 +191,21 @@
return boundsChanged;
}
+bool RenderWidget::updateWidgetGeometry()
+{
+IntRect contentBox = contentBoxRect();
+ if (!m_widget->transformsAffectFrameRect())
+ return setWidgetGeometry(absoluteContentBox(), contentBox.size());
+
+ IntRect absoluteContentBox = IntRect(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
+ if (m_widget->isFrameView()) {
+ contentBox.setLocation(absoluteContentBox.location());
+ return setWidgetGeometry(contentBox, contentBox.size());
+ }
+
+ return setWidgetGeometry(absoluteContentBox, contentBox.size());
+}
+
void RenderWidget::setWidget(PassRefPtr widget)
{
if (widget == m_widget)
@@ -208,15 +223,9 @@
// widget immediately, but we have to have really been fully constructed (with a non-null
// style pointer).
if (style()) {
-if (!needsLayout()) {
-IntRect contentBox = contentBoxRect();
-IntRect absoluteContentBox = IntRect(localToAbsoluteQuad(FloatQuad(contentBox)).boundingBox());
-if (m_widget->isFrameView()) {
-contentBox.setLocation(absoluteContentBox.location());
-setWidgetGeometry(contentBox, contentBox.size());
-} else
-setWidgetGeometry(absoluteContentBox, contentBox.size());
-}
+if (!needsLayout())
+updateWidgetGeometry();
+
if (style()->visibility() != VISIBLE)
m_widget->hide();
else {
@@ -354,15 +363,7 @@
if (!m_widget || !node()) // Check the node in case destroy() has been called.
return;
-IntRect contentBox = contentBoxRect();
-IntRect absoluteContentBox = IntRect(l
[webkit-changes] [98602] trunk/LayoutTests
Title: [98602] trunk/LayoutTests
Revision 98602
Author john...@google.com
Date 2011-10-27 10:42:39 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, fixing duplicate entries in test expectations.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98601 => 98602)
--- trunk/LayoutTests/ChangeLog 2011-10-27 17:38:19 UTC (rev 98601)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 17:42:39 UTC (rev 98602)
@@ -1,3 +1,9 @@
+2011-10-27 John Gregg
+
+Unreviewed, fixing duplicate entries in test expectations.
+
+* platform/chromium/test_expectations.txt:
+
2011-10-27 Mihnea Ovidenie
[CSSRegions]Flag regions with custom styling
@@ -55,6 +61,7 @@
* platform/efl/tables: [...]
+>>> .r98598
2011-10-27 Philippe Normand
Unreviewed, GTK rebaseline.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98601 => 98602)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:38:19 UTC (rev 98601)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:42:39 UTC (rev 98602)
@@ -850,7 +850,8 @@
BUGWK62974 MAC : svg/text/text-text-06-t.svg = IMAGE
BUGWK62974 LINUX WIN : svg/wicd/test-rightsizing-b.xhtml = IMAGE+TEXT
BUGWK62974 MAC : svg/wicd/test-rightsizing-b.xhtml = IMAGE
-BUGWK62974 WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
+// Extended by BUGCR101797.
+// BUGWK62974 WIN : svg/W3C-SVG-1.1/animate-elem-36-t.svg = IMAGE
BUGWK62974 : svg/custom/svg-fonts-in-html.html = IMAGE
BUGWK62974 : svg/custom/svg-fonts-with-no-element-reference.html = IMAGE+TEXT IMAGE
BUGWK62974 MAC : svg/W3C-SVG-1.1/pservers-grad-08-b.svg = IMAGE
@@ -1631,8 +1632,9 @@
BUGCR101797 CPU : svg/custom/use-forward-refs.svg = IMAGE
BUGCR101797 CPU : svg/filters/subRegion-one-effect.svg = IMAGE
BUGCR101797 CPU : svg/filters/subRegion-two-effects.svg = IMAGE
-BUGCR101797 CPU : svg/hixie/perf/001.xml = IMAGE
-BUGCR101797 CPU : svg/hixie/perf/002.xml = IMAGE
+// Already marked as flaky under BUGCR10479
+// BUGCR101797 CPU : svg/hixie/perf/001.xml = IMAGE
+// BUGCR101797 CPU : svg/hixie/perf/002.xml = IMAGE
BUGCR101797 CPU : svg/hixie/perf/007.xml = IMAGE
// Flaky for a while; also related to BUGCR17974
@@ -1944,9 +1946,6 @@
// Started failing at r58152
BUGWK38038 : fast/url/file-http-base.html = TEXT
-// Started failing at 58212
-BUGWK38108 MAC : fast/backgrounds/size/contain-and-cover.html = IMAGE
-
// WebKit roll 58304:58400
// Skip since not relevant
BUGUKAI SKIP MAC WIN : fast/text/international/bold-bengali.html = FAIL
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98601] trunk/Source/JavaScriptCore
Title: [98601] trunk/Source/_javascript_Core
Revision 98601
Author mhahnenb...@apple.com
Date 2011-10-27 10:38:19 -0700 (Thu, 27 Oct 2011)
Log Message
Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986
Reviewed by Geoffrey Garen.
Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name. This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.
* runtime/ClassInfo.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ClassInfo.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98600 => 98601)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 17:33:07 UTC (rev 98600)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 17:38:19 UTC (rev 98601)
@@ -1,5 +1,20 @@
2011-10-27 Mark Hahnenberg
+Add ability to check for presence of static members at compile time
+https://bugs.webkit.org/show_bug.cgi?id=70986
+
+Reviewed by Geoffrey Garen.
+
+Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
+HAS_MEMBER_NAMED macro to use that template to check if the specified class
+does indeed have a method with that name. This mechanism is not currently
+used anywhere, but will be in the future when adding virtual methods from
+JSObject to the MethodTable.
+
+* runtime/ClassInfo.h:
+
+2011-10-27 Mark Hahnenberg
+
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958
Modified: trunk/Source/_javascript_Core/runtime/ClassInfo.h (98600 => 98601)
--- trunk/Source/_javascript_Core/runtime/ClassInfo.h 2011-10-27 17:33:07 UTC (rev 98600)
+++ trunk/Source/_javascript_Core/runtime/ClassInfo.h 2011-10-27 17:38:19 UTC (rev 98601)
@@ -63,6 +63,25 @@
ToThisObjectFunctionPtr toThisObject;
};
+#define CREATE_MEMBER_CHECKER(member) \
+template \
+struct MemberCheck##member { \
+struct Fallback { \
+void member(...); \
+}; \
+struct Derived : T, Fallback { }; \
+template struct Check; \
+typedef char Yes[2]; \
+typedef char No[1]; \
+template \
+static No &func(Check*); \
+template \
+static Yes &func(...); \
+enum { has = sizeof(func(0)) == sizeof(Yes) }; \
+}
+
+#define HAS_MEMBER_NAMED(klass, name) (MemberCheck##name::has)
+
#define CREATE_METHOD_TABLE(ClassName) { \
&ClassName::visitChildren, \
&ClassName::getCallData, \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98599] trunk/Source/WebKit2
Title: [98599] trunk/Source/WebKit2
Revision 98599
Author carlo...@webkit.org
Date 2011-10-27 10:27:15 -0700 (Thu, 27 Oct 2011)
Log Message
[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
https://bugs.webkit.org/show_bug.cgi?id=71027
Reviewed by Martin Robinson.
Fixes windowless plugins in GTK+ port.
* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
call the paint method that doesn't receive a scaleFactor.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98598 => 98599)
--- trunk/Source/WebKit2/ChangeLog 2011-10-27 17:24:49 UTC (rev 98598)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-27 17:27:15 UTC (rev 98599)
@@ -1,3 +1,16 @@
+2011-10-27 Carlos Garcia Campos
+
+[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
+https://bugs.webkit.org/show_bug.cgi?id=71027
+
+Reviewed by Martin Robinson.
+
+Fixes windowless plugins in GTK+ port.
+
+* Shared/cairo/ShareableBitmapCairo.cpp:
+(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
+call the paint method that doesn't receive a scaleFactor.
+
2011-10-27 Sheriff Bot
Unreviewed, rolling out r98556.
Modified: trunk/Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp (98598 => 98599)
--- trunk/Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp 2011-10-27 17:24:49 UTC (rev 98598)
+++ trunk/Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp 2011-10-27 17:27:15 UTC (rev 98599)
@@ -55,10 +55,14 @@
context.platformContext()->drawSurfaceToContext(surface.get(), destRect, srcRect, &context);
}
-void ShareableBitmap::paint(GraphicsContext&, float /*scaleFactor*/, const IntPoint& /*dstPoint*/, const IntRect& /*srcRect*/)
+void ShareableBitmap::paint(GraphicsContext& context, float scaleFactor, const IntPoint& dstPoint, const IntRect& srcRect)
{
-// See .
-notImplemented();
+if (scaleFactor != 1) {
+// See .
+notImplemented();
+return;
+}
+paint(context, dstPoint, srcRect);
}
PassRefPtr ShareableBitmap::createCairoSurface()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98598] trunk
Title: [98598] trunk
Revision 98598
Author commit-qu...@webkit.org
Date 2011-10-27 10:24:49 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, rolling out r98556.
http://trac.webkit.org/changeset/98556
https://bugs.webkit.org/show_bug.cgi?id=71031
The test added by the patch doesn't pass on Snow Leopard
(Requested by rniwa on #webkit).
Patch by Sheriff Bot on 2011-10-27
.:
* Source/autotools/symbols.filter:
Source/WebCore:
* editing/TextCheckingHelper.cpp:
(WebCore::checkTextOfParagraph):
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* editing/spelling/spelling-unified-emulation-expected.txt: Removed.
* editing/spelling/spelling-unified-emulation.html: Removed.
Modified Paths
trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextCheckingHelper.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/win/WebKit2.def
trunk/Source/WebKit2/win/WebKit2CFLite.def
trunk/Source/autotools/symbols.filter
Removed Paths
trunk/LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt
trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html
Diff
Modified: trunk/ChangeLog (98597 => 98598)
--- trunk/ChangeLog 2011-10-27 17:22:18 UTC (rev 98597)
+++ trunk/ChangeLog 2011-10-27 17:24:49 UTC (rev 98598)
@@ -1,3 +1,14 @@
+2011-10-27 Sheriff Bot
+
+Unreviewed, rolling out r98556.
+http://trac.webkit.org/changeset/98556
+https://bugs.webkit.org/show_bug.cgi?id=71031
+
+The test added by the patch doesn't pass on Snow Leopard
+(Requested by rniwa on #webkit).
+
+* Source/autotools/symbols.filter:
+
2011-10-27 Shinya Kawanaka
Implement legacy text check emulation in unified text check interface.
Modified: trunk/LayoutTests/ChangeLog (98597 => 98598)
--- trunk/LayoutTests/ChangeLog 2011-10-27 17:22:18 UTC (rev 98597)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 17:24:49 UTC (rev 98598)
@@ -1,3 +1,15 @@
+2011-10-27 Sheriff Bot
+
+Unreviewed, rolling out r98556.
+http://trac.webkit.org/changeset/98556
+https://bugs.webkit.org/show_bug.cgi?id=71031
+
+The test added by the patch doesn't pass on Snow Leopard
+(Requested by rniwa on #webkit).
+
+* editing/spelling/spelling-unified-emulation-expected.txt: Removed.
+* editing/spelling/spelling-unified-emulation.html: Removed.
+
2011-10-27 Ryosuke Niwa
Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
Deleted: trunk/LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt (98597 => 98598)
--- trunk/LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt 2011-10-27 17:22:18 UTC (rev 98597)
+++ trunk/LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt 2011-10-27 17:24:49 UTC (rev 98598)
@@ -1,31 +0,0 @@
-The spellchecker should work correctly if unified spellcheck path is used.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-PASS numMarked is length
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS str is markedStr
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS str is markedStr
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS numMarked is length
-PASS str is markedStr
-PASS numMarked is length
-PASS numMarked is length
-PASS successfullyParsed is true
-
-TEST COMPLETE
-I would like to sleep, zzz.
Deleted: trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html (98597 => 98598)
--- trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html 2011-10-27 17:22:18 UTC (rev 98597)
+++ trunk/LayoutTests/editing/spelling/spelling-unified-emulation.html 2011-10-27 17:24:49 UTC (rev 98598)
@@ -1,91 +0,0 @@
-
-
-
-
-.editing {
-border: 2px solid red;
-padding: 6px;
-font-size: 18px;
-}
-
-
-
-
-
-
-
-
-description("The spellchecker should work correctly if unified spellcheck path is used.");
-
-var container = document.getElementById('container');
-function removeChildren(node) {
-while (node.firstChild)
-node.removeChild(node.firstChild);
-}
-
-if (window.layoutTestController) {
-layoutTestController.dumpAsText();
-}
-
-if (window.internals)
-internals.setUnifiedTextCheckingEnabled(document, true);
-
-var testData = [
-{ text: 'zz', marked: ['zz'] },
-{ text: 'apple,zz,orange', marked: ['zz'] },
-{ text: 'zz,zz', marked: ['zz','zz'] },
-{ text: 'zz zz zz', marked: ['zz', 'zz', 'zz'] },
-{ tex
[webkit-changes] [98597] trunk/LayoutTests
Title: [98597] trunk/LayoutTests
Revision 98597
Author rn...@webkit.org
Date 2011-10-27 10:22:18 -0700 (Thu, 27 Oct 2011)
Log Message
Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
since r98542 regressed it. The failure is tracked by the bug 71032.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
Diff
Modified: trunk/LayoutTests/ChangeLog (98596 => 98597)
--- trunk/LayoutTests/ChangeLog 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 17:22:18 UTC (rev 98597)
@@ -1,3 +1,14 @@
+2011-10-27 Ryosuke Niwa
+
+Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
+since r98542 regressed it. The failure is tracked by the bug 71032.
+
+* platform/chromium/test_expectations.txt:
+* platform/gtk/Skipped:
+* platform/mac/Skipped:
+* platform/qt/Skipped:
+* platform/win/Skipped:
+
2011-10-27 Mike Reed
[skia] replace offscreen technique with native support for antialiased clipping
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98596 => 98597)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:22:18 UTC (rev 98597)
@@ -3930,3 +3930,5 @@
BUGWK70988 SNOWLEOPARD : jquery/traversing.html = PASS TIMEOUT
BUGWK71004 : inspector/storage-panel-dom-storage.html = PASS TIMEOUT
+
+BUGWK71032 : tables/mozilla_expected_failures/bugs/bug14007-2.html = FAIL
Modified: trunk/LayoutTests/platform/gtk/Skipped (98596 => 98597)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-10-27 17:22:18 UTC (rev 98597)
@@ -1658,5 +1658,5 @@
# https://bugs.webkit.org/show_bug.cgi?id=71022
fast/canvas/canvas-composite-image.html
-# https://bugs.webkit.org/show_bug.cgi?id=71024
-editing/spelling/spelling-unified-emulation.html
+# https://bugs.webkit.org/show_bug.cgi?id=71032
+tables/mozilla_expected_failures/bugs/bug14007-2.html
Modified: trunk/LayoutTests/platform/mac/Skipped (98596 => 98597)
--- trunk/LayoutTests/platform/mac/Skipped 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/platform/mac/Skipped 2011-10-27 17:22:18 UTC (rev 98597)
@@ -450,3 +450,6 @@
# https://bugs.webkit.org/show_bug.cgi?id=68566
fast/css/webkit-mask-crash-fieldset-legend.html
fast/css/webkit-mask-crash-table.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=71032
+tables/mozilla_expected_failures/bugs/bug14007-2.html
Modified: trunk/LayoutTests/platform/qt/Skipped (98596 => 98597)
--- trunk/LayoutTests/platform/qt/Skipped 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/platform/qt/Skipped 2011-10-27 17:22:18 UTC (rev 98597)
@@ -2462,3 +2462,6 @@
# [Qt] inspector/extensions/extensions-console.html is failing
# https://bugs.webkit.org/show_bug.cgi?id=70905
inspector/extensions/extensions-console.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=71032
+tables/mozilla_expected_failures/bugs/bug14007-2.html
Modified: trunk/LayoutTests/platform/win/Skipped (98596 => 98597)
--- trunk/LayoutTests/platform/win/Skipped 2011-10-27 17:19:28 UTC (rev 98596)
+++ trunk/LayoutTests/platform/win/Skipped 2011-10-27 17:22:18 UTC (rev 98597)
@@ -1428,3 +1428,6 @@
# HiDPI tests require test infrastructure enhancements
fast/hidpi
+
+# https://bugs.webkit.org/show_bug.cgi?id=71032
+tables/mozilla_expected_failures/bugs/bug14007-2.html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98596] trunk
Title: [98596] trunk
Revision 98596
Author r...@google.com
Date 2011-10-27 10:19:28 -0700 (Thu, 27 Oct 2011)
Log Message
[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748
Reviewed by Stephen White.
~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.
Source/WebCore:
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
* platform/graphics/skia/PlatformContextSkia.h:
LayoutTests:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp
trunk/Source/WebCore/platform/graphics/skia/PlatformContextSkia.h
Diff
Modified: trunk/LayoutTests/ChangeLog (98595 => 98596)
--- trunk/LayoutTests/ChangeLog 2011-10-27 17:17:39 UTC (rev 98595)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 17:19:28 UTC (rev 98596)
@@ -1,3 +1,18 @@
+2011-10-27 Mike Reed
+
+[skia] replace offscreen technique with native support for antialiased clipping
+https://bugs.webkit.org/show_bug.cgi?id=70748
+
+Reviewed by Stephen White.
+
+~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
+bits of the result. Other than that, the results should be the same, except that now the drawing
+can go directly to the canvas, rather than being direct offscreen and then have that result
+"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
+antialiased clip area.
+
+* platform/chromium/test_expectations.txt:
+
2011-10-27 Leandro Pereira
[EFL] Unreviewed. Add pixel baselines for table tests.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98595 => 98596)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:17:39 UTC (rev 98595)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-10-27 17:19:28 UTC (rev 98596)
@@ -997,6 +997,115 @@
BUGWK64876 LINUX WIN GPU : fast/canvas/canvas-scale-strokePath-shadow.html = TEXT
+// Rebaseline once native aa-clipping has landed
+BUGWK70748 CPU : css2.1/t0805-c5517-brdr-s-00-c.html = IMAGE
+BUGWK70748 CPU : fast/backgrounds/border-radius-split-background-image.html = IMAGE
+BUGWK70748 CPU : fast/backgrounds/gradient-background-leakage.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusAllStylesAllCorners.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusArcs01.html = IMAGE
+BUGWK70748 CPU : fast/borders/border-radius-complex-inner.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDashed01.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDashed02.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDashed03.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDashed04.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDashed05.html = IMAGE
+BUGWK70748 CPU : fast/borders/border-radius-different-width-001.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted01.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted02.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted03.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted04.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted05.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDotted06.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble01.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble02.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble03.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble04.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble05.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble06.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble07.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble08.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusDouble09.html = IMAGE
+BUGWK70748 CPU : fast/borders/border-radius-groove-01.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusGroove01.html = IMAGE
+BUGWK70748 CPU : fast/borders/border-radius-groove-02.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadiusGroove02.html = IMAGE
+BUGWK70748 CPU : fast/borders/border-radius-groove-03.html = IMAGE
+BUGWK70748 CPU : fast/borders/borderRadius
[webkit-changes] [98594] trunk/Source/WebCore
Title: [98594] trunk/Source/WebCore
Revision 98594
Author t...@chromium.org
Date 2011-10-27 10:04:03 -0700 (Thu, 27 Oct 2011)
Log Message
use main/cross instead of logical width/height when talking about flow direction
https://bugs.webkit.org/show_bug.cgi?id=70977
Reviewed by Ojan Vafai.
Flexbox code uses logical in function names to refer to the flow
direction. This is confusing because writing mode also uses logical,
but this is a diffent usage. To avoid confusion, be explicit about
main vs cross axis. Extent is used instead of width/height.
No new tests, just a refactoring.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
(WebCore::RenderFlexibleBox::crossAxisLength):
(WebCore::RenderFlexibleBox::setCrossExtent):
(WebCore::RenderFlexibleBox::crossExtentForChild):
(WebCore::RenderFlexibleBox::mainExtentForChild):
(WebCore::RenderFlexibleBox::crossAxisExtent):
(WebCore::RenderFlexibleBox::mainAxisExtent):
(WebCore::RenderFlexibleBox::crossAxisContentExtent):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only
matters in the main axis, there's no reason to deambiguate it here.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always
in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild): Alignment is always
in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
* rendering/RenderFlexibleBox.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (98593 => 98594)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 17:01:38 UTC (rev 98593)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 17:04:03 UTC (rev 98594)
@@ -1,3 +1,49 @@
+2011-10-27 Tony Chang
+
+use main/cross instead of logical width/height when talking about flow direction
+https://bugs.webkit.org/show_bug.cgi?id=70977
+
+Reviewed by Ojan Vafai.
+
+Flexbox code uses logical in function names to refer to the flow
+direction. This is confusing because writing mode also uses logical,
+but this is a diffent usage. To avoid confusion, be explicit about
+main vs cross axis. Extent is used instead of width/height.
+
+No new tests, just a refactoring.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
+(WebCore::RenderFlexibleBox::crossAxisLength):
+(WebCore::RenderFlexibleBox::setCrossExtent):
+(WebCore::RenderFlexibleBox::crossExtentForChild):
+(WebCore::RenderFlexibleBox::mainExtentForChild):
+(WebCore::RenderFlexibleBox::crossAxisExtent):
+(WebCore::RenderFlexibleBox::mainAxisExtent):
+(WebCore::RenderFlexibleBox::crossAxisContentExtent):
+(WebCore::RenderFlexibleBox::mainAxisContentExtent):
+(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
+(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
+(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
+(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
+(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
+(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
+(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
+(WebCore::RenderFlexibleBox::layoutInlineDirection):
+(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only
+matters in the main axis, there's no reason to deambiguate it here.
+(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
+(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always
+in the cross axis direction, so don't include that in the method name.
+(WebCore::RenderFlexibleBox::marginBoxAscent):
+(WebCore::Render
[webkit-changes] [98593] trunk/Source
Title: [98593] trunk/Source
Revision 98593
Author mhahnenb...@apple.com
Date 2011-10-27 10:01:38 -0700 (Thu, 27 Oct 2011)
Log Message
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958
Reviewed by Geoffrey Garen.
Source/_javascript_Core:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* API/JSContextRef.cpp:
* _javascript_Core.exp:
* _javascript_Core.vcproj/_javascript_Core/_javascript_Core.def:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::toThisObject):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toThisObject):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::toThisObject):
* runtime/JSObject.h:
(JSC::JSValue::toThisObject):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::toThisObject):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::toThisObject):
* runtime/JSString.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::toThisObject):
* runtime/StrictEvalActivation.h:
Source/WebCore:
No new tests.
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::toThisObject):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bridge/NP_jsobject.cpp:
(_NPN_Invoke):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
Source/WebKit/mac:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
Source/WebKit2:
Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::invoke):
Modified Paths
trunk/Source/_javascript_Core/API/JSContextRef.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.exp
trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
trunk/Source/_javascript_Core/runtime/ClassInfo.h
trunk/Source/_javascript_Core/runtime/JSActivation.cpp
trunk/Source/_javascript_Core/runtime/JSActivation.h
trunk/Source/_javascript_Core/runtime/JSCell.cpp
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.cpp
trunk/Source/_javascript_Core/runtime/JSStaticScopeObject.h
trunk/Source/_javascript_Core/runtime/JSString.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/StrictEvalActivation.cpp
trunk/Source/_javascript_Core/runtime/StrictEvalActivation.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h
trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp
trunk/Source/WebCore/bridge/NP_jsobject.cpp
trunk/Source/WebCore/bridge/qt/qt_runtime.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPJSObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/API/JSContextRef.cpp (98592 => 98593)
--- trunk/Source/_javascript_Core/API/JSContextRef.cpp 2011-10-27 16:41:50 UTC (rev 98592)
+++ trunk/Source/_javascript_Core/API/JSContextRef.cpp 2011-10-27 17:01:38 UTC (rev 98593)
@@ -163,7 +163,7 @@
APIEntryShim entryShim(exec);
// It is necessary to call toThisObject to get the wrapper object when used with WebCore.
-return toRef(exec->lexicalGlobalObject()->toThisObject(exec));
+return toRef(exec->lexicalGlobalObject()->methodTable()->toThisObject(exec->lexicalGlobalObject(), exec));
}
JSContextGroupRef JSContextGetGroup(JSContextRef ctx)
Modified: trunk/Source/_javascript_Core/ChangeLog (98592 => 98593)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-27 16:41:50 UTC (rev 98592)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-27 17:01:38 UTC (rev 98593)
@@ -1,3 +1,39 @@
+2011-10-27 Mark Hahnenberg
+
+De-virtualize JSCell::toThisObject
+https://bugs.webkit.org/show_bug.cgi?id=70958
+
+Reviewed by Geoffrey Garen.
+
+Converted all instances of toThisObject to static functions,
+added toThisObject to the MethodTable, and replaced all call sites
+with a correspondi
[webkit-changes] [98592] trunk/Source/WebCore
Title: [98592] trunk/Source/WebCore
Revision 98592
Author aro...@apple.com
Date 2011-10-27 09:41:50 -0700 (Thu, 27 Oct 2011)
Log Message
Windows build fix after r98512
* html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE
guard.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (98591 => 98592)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 16:36:41 UTC (rev 98591)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 16:41:50 UTC (rev 98592)
@@ -1,5 +1,12 @@
2011-10-27 Adam Roben
+Windows build fix after r98512
+
+* html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE
+guard.
+
+2011-10-27 Adam Roben
+
Regenerate WebCore's Localizable.strings file
All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (98591 => 98592)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-10-27 16:36:41 UTC (rev 98591)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2011-10-27 16:41:50 UTC (rev 98592)
@@ -31,7 +31,6 @@
#include "ApplicationCacheHost.h"
#include "ApplicationCacheResource.h"
#include "Attribute.h"
-#include "AudioSourceProvider.h"
#include "Chrome.h"
#include "ChromeClient.h"
#include "ClientRect.h"
@@ -93,6 +92,7 @@
#endif
#if ENABLE(WEB_AUDIO)
+#include "AudioSourceProvider.h"
#include "MediaElementAudioSourceNode.h"
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98591] branches/safari-534.52-branch/Source/WebKit2
Title: [98591] branches/safari-534.52-branch/Source/WebKit2
Revision 98591
Author lforsch...@apple.com
Date 2011-10-27 09:36:41 -0700 (Thu, 27 Oct 2011)
Log Message
Merge 98394.
Modified Paths
branches/safari-534.52-branch/Source/WebKit2/ChangeLog
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
Diff
Modified: branches/safari-534.52-branch/Source/WebKit2/ChangeLog (98590 => 98591)
--- branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 16:32:00 UTC (rev 98590)
+++ branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 16:36:41 UTC (rev 98591)
@@ -1,5 +1,21 @@
2011-10-27 Lucas Forschler
+Merge 98394
+
+2011-10-25 Anders Carlsson
+
+Assertion failure when zooming a PDF in an iframe
+https://bugs.webkit.org/show_bug.cgi?id=70849
+
+Reviewed by Alexey Proskuryakov.
+
+If the plug-in doesn't want window relative coordinates, we shouldn't give the plug-in window relative coordinates.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::viewGeometryDidChange):
+
+2011-10-27 Lucas Forschler
+
Merge 98369
2011-10-25 Anders Carlsson
Modified: branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (98590 => 98591)
--- branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-10-27 16:32:00 UTC (rev 98590)
+++ branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2011-10-27 16:36:41 UTC (rev 98591)
@@ -707,11 +707,17 @@
if (!m_isInitialized || !m_plugin || !parent())
return;
-// Get the frame rect in window coordinates.
-// FIXME: Figure out what we should pass here when m_plugin->wantsWindowRelativeCoordinates() returns false.
-IntRect frameRectInWindowCoordinates = parent()->contentsToWindow(frameRect());
-
-m_plugin->geometryDidChange(frameRectInWindowCoordinates, clipRectInWindowCoordinates());
+IntRect rect;
+
+if (m_plugin->wantsWindowRelativeCoordinates()) {
+// Get the frame rect in window coordinates.
+rect = parent()->contentsToWindow(frameRect());
+} else {
+// FIXME: The plug-in shouldn't know its location relative to its parent frame.
+rect = frameRect();
+}
+
+m_plugin->geometryDidChange(rect, clipRectInWindowCoordinates());
}
void PluginView::viewVisibilityDidChange()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [98590] trunk/Source/WebCore
Title: [98590] trunk/Source/WebCore
Revision 98590
Author aro...@apple.com
Date 2011-10-27 09:32:00 -0700 (Thu, 27 Oct 2011)
Log Message
Regenerate WebCore's Localizable.strings file
All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
some strings (which must have been hand-added) got moved to a different part of the file.
* English.lproj/Localizable.strings:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
Diff
Modified: trunk/Source/WebCore/ChangeLog (98589 => 98590)
--- trunk/Source/WebCore/ChangeLog 2011-10-27 16:26:50 UTC (rev 98589)
+++ trunk/Source/WebCore/ChangeLog 2011-10-27 16:32:00 UTC (rev 98590)
@@ -1,3 +1,12 @@
+2011-10-27 Adam Roben
+
+Regenerate WebCore's Localizable.strings file
+
+All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
+some strings (which must have been hand-added) got moved to a different part of the file.
+
+* English.lproj/Localizable.strings:
+
2011-10-27 Daniel Cheng
Clean up MicroDataItemValue to use const String& instead of String
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (98589 => 98590)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2011-10-27 16:26:50 UTC (rev 98589)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2011-10-27 16:32:00 UTC (rev 98590)
@@ -25,12 +25,6 @@
/ * L a b e l t o d e s c r i b e t h e n u m b e r o f f i l e s s e l e c t e d i n a f i l e u p l o a d c o n t r o l t h a t a l l o w s m u l t i p l e f i l e s * /
" % d f i l e s " = " % d f i l e s " ;
- / * P s e u d o p l u g - i n n a m e , v i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * /
- " W e b K i t b u i l t - i n P D F " = " W e b K i t b u i l t - i n P D F " ;
-
- / * D e s c r i p t i o n o f t h e ( o n l y ) t y p e s u p p o r t e d b y P D F p s e u d o p l u g - i n . V i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * /
- " P o r t a b l e D o c u m e n t F o r m a t " = " P o r t a b l e D o c u m e n t F o r m a t " ;
-
/ * M e n u i t e m t i t l e f o r K E Y G E N p o p - u p m e n u * /
" 1 0 2 4 ( M e d i u m G r a d e ) " = " 1 0 2 4 ( M e d i u m G r a d e ) " ;
@@ -73,10 +67,10 @@
/ * C h e c k s p e l l i n g w h i l e t y p i n g c o n t e x t m e n u i t e m * /
" C h e c k S p e l l i n g W h i l e T y p i n g " = " C h e c k S p e l l i n g W h i l e T y p i n g " ;
- / * t i t l e f o r f i l e b u t t o n u s e d i n H T M L f o r m s * /
+ / * t i t l e f o r a s i n g l e f i l e c h o o s e r b u t t o n u s e d i n H T M L f o r m s * /
" C h o o s e F i l e " = " C h o o s e F i l e " ;
- / * t i t l e f o r f i l e b u t t o n u s e d i n H T M L 5 f i l e c h o o s e r * /
+ / * t i t l e f o r a m u l t i p l e f i l e c h o o s e r b u t t o n u s e d i n H T M L f o r m s . T h i s t i t l e s h o u l d b e a s s h o r t a s p o s s i b l e . * /
" C h o o s e F i l e s " = " C h o o s e F i l e s " ;
/ * m e n u i t e m i n R e c e n t S e a r c h e s m e n u t h a t e m p t i e s m e n u ' s c o n t e n t s * /
@@ -304,6 +298,9 @@
/ * W e b K i t E r r o r P l u g I n W i l l H a n d l e L o a d d e s c r i p t i o n * /
" P l u g - i n h a n d l e d l o a d " = " P l u g - i n h a n d l e d l o a d " ;
+ / * D e s c r i p t i o n o f t h e ( o n l y ) t y p e s u p p o r t e d b y P D F p s e u d o p l u g - i n . V i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * /
+ " P o r t a b l e D o c u m e n t F o r m a t " = " P o r t a b l e D o c u m e n t F o r m a t " ;
+
/ * U n d o a c t i o n n a m e * /
" R a i s e B a s e l i n e ( U n d o a c t i o n n a m e ) " = " R a i s e B a s e l i n e " ;
@@ -493,6 +490,9 @@
/ * W e b I n s p e c t o r w i n d o w t i t l e * /
" W e b I n s p e c t o r % @ " = " W e b I n s p e c t o r % @ " ;
+ / * P s e u d o p l u g - i n n a m e , v i s i b l e i n I n s t a l l e d P l u g - i n s p a g e i n S a f a r i . * /
+ " W e b K i t b u i l t - i n P D F " = " W e b K i t b u i l t - i n P D F " ;
+
/ * m e s s a g e i n a u t h e n t i c a t i o n p a n e l * /
" Y o u r l o g i n i n f o r m a t i o n w i l l b e s e n t s e c u r e l y . " = " Y o u r l o g i n i n f o r m a t i o
[webkit-changes] [98589] branches/safari-534.52-branch/Source/WebKit2
Title: [98589] branches/safari-534.52-branch/Source/WebKit2
Revision 98589
Author lforsch...@apple.com
Date 2011-10-27 09:26:50 -0700 (Thu, 27 Oct 2011)
Log Message
Merge 98369.
Modified Paths
branches/safari-534.52-branch/Source/WebKit2/ChangeLog
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Plugin.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginProxy.h
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.cpp
branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/PluginView.h
Diff
Modified: branches/safari-534.52-branch/Source/WebKit2/ChangeLog (98588 => 98589)
--- branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 16:24:41 UTC (rev 98588)
+++ branches/safari-534.52-branch/Source/WebKit2/ChangeLog 2011-10-27 16:26:50 UTC (rev 98589)
@@ -1,3 +1,66 @@
+2011-10-27 Lucas Forschler
+
+Merge 98369
+
+2011-10-25 Anders Carlsson
+
+PDF SUBFRAMES: Incomplete repaint after pinch to zoom
+https://bugs.webkit.org/show_bug.cgi?id=70821
+
+
+Reviewed by Simon Fraser.
+
+Add a new pure virtual member function, Plugin::wantsWindowRelativeCoordinates.
+If a plug-in subclass returns true, we'll keep giving the plug-in coordinates that
+are relative to the containing window. If a plug-in subclass returns false, we'll give it
+coordinates in a much more sane coordinate system, with the origin at the top left corner of the plug-in.
+
+Change BuiltinPDFView to return false so that it'll work correctly with pinch to zoom.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
+Make wantsWindowRelativeCoordinates return true.
+
+* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
+(WebKit::BuiltInPDFView::paint):
+Remove translation since the graphics context is already set up in the right way.
+
+(WebKit::BuiltInPDFView::paintContent):
+No need to offset by the plug-in view location anymore.
+
+(WebKit::BuiltInPDFView::paintControls):
+Account for the scrollbars being children of the parent scroll view here.
+
+(WebKit::BuiltInPDFView::wantsWindowRelativeCoordinates):
+Return false.
+
+(WebKit::BuiltInPDFView::convertFromContainingViewToScrollbar):
+Implement this so that scrollbar hit testing works correctly.
+
+* WebProcess/Plugins/Plugin.h:
+Add wantsWindowRelativeCoordinates.
+
+* WebProcess/Plugins/PluginProxy.cpp:
+(WebKit::PluginProxy::wantsWindowRelativeCoordinates):
+Return true for now.
+
+* WebProcess/Plugins/PluginView.cpp:
+(WebKit::PluginView::renderer):
+Add simple getter.
+
+(WebKit::PluginView::paint):
+Handle the case when the plug-in doesn't want window relative coordinates.
+
+(WebKit::PluginView::transformsAffectFrameRect):
+Return true here.
+
+(WebKit::PluginView::viewGeometryDidChange):
+No need to adjust the bounds to account for the scale factor now, since the frame rect will always be the
+same regardless of the transform.
+
+(WebKit::PluginView::clipRectInWindowCoordinates):
+Ditto.
+
2011-10-26 Lucas Forschler
Merge 93720
Modified: branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (98588 => 98589)
--- branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 16:24:41 UTC (rev 98588)
+++ branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2011-10-27 16:26:50 UTC (rev 98589)
@@ -775,6 +775,11 @@
return false;
}
+bool NetscapePlugin::wantsWindowRelativeCoordinates()
+{
+return true;
+}
+
Scrollbar* NetscapePlugin::horizontalScrollbar()
{
return 0;
Modified: branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (98588 => 98589)
--- branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 16:24:41 UTC (rev 98588)
+++ branches/safari-534.52-branch/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2011-10-27 16:26:50 UTC (rev 98589)
@@ -190,6 +190,7 @@
virtual void privateBrowsingStateCha
[webkit-changes] [98588] trunk
Title: [98588] trunk
Revision 98588
Author aro...@apple.com
Date 2011-10-27 09:24:41 -0700 (Thu, 27 Oct 2011)
Log Message
Add WKBundlePageGetBackingScaleFactor
Fixes REGRESSION (r97191): Clients
can't reliably determine the scale factor of snapshots returned via
WKBundlePageCreateSnapshot* API
Reviewed by Sam Weinig.
Source/WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetBackingScaleFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added. Calls through to WebPage::deviceScaleFactor.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::deviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Added. Calls through to Page::deviceScaleFactor.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
(TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
(TestWebKitAPI::createWindow): Conjure up a window.
(TestWebKitAPI::TEST): Ask the injected bundle code to call the new
WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
factors and when using a custom scale factor, and check that we get those same scale factors
back.
* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
(TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
members.
(TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
(TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
from the page using the new API and send it back.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WebKit2/mac/
trunk/Tools/TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (98587 => 98588)
--- trunk/Source/WebKit2/ChangeLog 2011-10-27 16:18:11 UTC (rev 98587)
+++ trunk/Source/WebKit2/ChangeLog 2011-10-27 16:24:41 UTC (rev 98588)
@@ -1,3 +1,23 @@
+2011-10-27 Adam Roben
+
+Add WKBundlePageGetBackingScaleFactor
+
+Fixes REGRESSION (r97191): Clients
+can't reliably determine the scale factor of snapshots returned via
+WKBundlePageCreateSnapshot* API
+
+Reviewed by Sam Weinig.
+
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKBundlePageGetBackingScaleFactor):
+* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
+Added. Calls through to WebPage::deviceScaleFactor.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::deviceScaleFactor):
+* WebProcess/WebPage/WebPage.h:
+Added. Calls through to Page::deviceScaleFactor.
+
2011-10-27 Zalan Bujtas
[Qt][WK2]Add setViewportSize API to WebKit2.
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (98587 => 98588)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2011-10-27 16:18:11 UTC (rev 98587)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2011-10-27 16:24:41 UTC (rev 98588)
@@ -239,6 +239,11 @@
return toAPI(webImage.release().leakRef());
}
+double WKBundlePageGetBackingScaleFactor(WKBundlePageRef pageRef)
+{
+return toImpl(pageRef)->deviceScaleFactor();
+}
+
#if defined(ENABLE_INSPECTOR) && ENABLE_INSPECTOR
WKBundleInspectorRef WKBundlePageGetInspector(WKBundlePageRef pageRef)
{
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h (98587 => 98588)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2011-10-27 16:18:11 UTC (rev 98587)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2011-10-27 16:24:41 UTC (rev 98588)
@@ -339,6 +339,8 @@
WK_EXPORT WKImageRef WKBundlePageCreateSnapshotInDocumentCoordinates(WKBundlePageRef page, WKRect rect, WKImageOptions options);
WK_EXPORT WKImageRef WKBundlePageCreateScaledSnapshotInDocumentCoordinates(WKBundlePageRef page, WKRect rect, double scaleFactor, WKImageOptions options);
+WK_EXPORT double WKBundlePageGetBackingScaleFactor(WKBundlePageRef page);
+
#if defined(ENABLE_INSPECTOR) && ENABLE_INSPECTOR
WK_EXPORT WKBundleInspectorRef WKBundlePageGetInspector(WKBundlePageRef page);
#endif
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (98587 => 98588)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2011-10-27 16:18:11 UTC (rev 98587)
+++ trunk/Source/WebKi
[webkit-changes] [98587] trunk/LayoutTests
Title: [98587] trunk/LayoutTests
Revision 98587
Author ph...@webkit.org
Date 2011-10-27 09:18:11 -0700 (Thu, 27 Oct 2011)
Log Message
Unreviewed, GTK rebaseline.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (98586 => 98587)
--- trunk/LayoutTests/ChangeLog 2011-10-27 16:16:32 UTC (rev 98586)
+++ trunk/LayoutTests/ChangeLog 2011-10-27 16:18:11 UTC (rev 98587)
@@ -1,5 +1,11 @@
2011-10-27 Philippe Normand
+Unreviewed, GTK rebaseline.
+
+* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
+
+2011-10-27 Philippe Normand
+
Unreviewed, skipping 2 new failing tests in GTK.
* platform/gtk/Skipped: Skip
Modified: trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt (98586 => 98587)
--- trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt 2011-10-27 16:16:32 UTC (rev 98586)
+++ trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt 2011-10-27 16:18:11 UTC (rev 98587)
@@ -14,29 +14,29 @@
text run at (258,0) width 85: "January 2000"
RenderTableSection {TBODY} at (10,29) size 601x1168
RenderTableRow {TR} at (0,0) size 601x449
- RenderTableCell {TD} at (0,0) size 87x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+ RenderTableCell {TD} at (0,213) size 87x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
- RenderTableCell {TD} at (87,0) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+ RenderTableCell {TD} at (87,213) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
- RenderTableCell {TD} at (171,0) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+ RenderTableCell {TD} at (171,213) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
- RenderTableCell {TD} at (255,0) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+ RenderTableCell {TD} at (255,213) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
- RenderTableCell {TD} at (339,0) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+ RenderTableCell {TD} at (339,213) size 84x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
- RenderTableCell {TD} at (423,0) size 86x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+ RenderTableCell {TD} at (423,213) size 86x23 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
RenderText {#text} at (2,2) size 5x19
text run at (2,2) width 5: "-"
RenderTableCell {TD} at (509,0) size 92x449 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
RenderTable {TABLE} at (2,2) size 88x426 [color=#00]
RenderTableSection {TBODY} at (0,0) size 88x426
RenderTableRow {TR} at (0,0) size 88x426
- RenderTableCell {TD} at (0,0) size 18x26 [color=#00] [bgcolor=#404080] [r=0 c=0 rs=1 cs=1]
+ RenderTableCell {TD} at (0,200) size 18x26 [color=#00] [bgcolor=#404080] [r=0 c=0 rs=1 cs=1]
RenderText {#text} at (1,1) size 16x24
text run at (1,1) width 16: "1."
RenderTableCell {TD} at (18,0) size 70x426 [color=#FF] [bgcolor=#404080] [r=0 c=1 rs=1 cs=1]
@@ -77,11 +77,11 @@
RenderBlock (anonymous) at (2,428) size 88x19
RenderBR {BR} at (0,0) size 0x19
RenderTableRow {TR} at (0,449) size 601x287
- RenderTableCell {TD} at (0,449) size 87x211 [color=#FF] [bgcolor=#404080] [border: (1px inset #808080)] [r=1 c=0 rs=1 cs=1]
+
1 2 >
