[webkit-changes] [100417] trunk/Source/JavaScriptCore
Title: [100417] trunk/Source/_javascript_Core
Revision 100417
Author da...@apple.com
Date 2011-11-16 00:05:40 -0800 (Wed, 16 Nov 2011)
Log Message
Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470
Reviewed by Filip Pizlo.
Hash traits structures need to derive from the base hash traits in
HashTraits.h, but some were not. This is needed for compatibility with
some additional traits we will be adding to make OwnPtr work with HashMap.
* runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from
HashTraitsint. This enabled removal of all the members except for the
ones that control the empty value, because this is otherwise the same
as the standard int hash.
* runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive
from HashTraitsSymbolTableEntry and removed redundant members.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Identifier.h
trunk/Source/_javascript_Core/runtime/SymbolTable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100416 => 100417)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 07:51:03 UTC (rev 100416)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 08:05:40 UTC (rev 100417)
@@ -1,3 +1,22 @@
+2011-11-16 Darin Adler da...@apple.com
+
+Fix some hash traits that don't derive from the base hash traits
+https://bugs.webkit.org/show_bug.cgi?id=72470
+
+Reviewed by Filip Pizlo.
+
+Hash traits structures need to derive from the base hash traits in
+HashTraits.h, but some were not. This is needed for compatibility with
+some additional traits we will be adding to make OwnPtr work with HashMap.
+
+* runtime/Identifier.h: Make IdentifierMapIndexHashTraits derive from
+HashTraitsint. This enabled removal of all the members except for the
+ones that control the empty value, because this is otherwise the same
+as the standard int hash.
+
+* runtime/SymbolTable.h: Changed SymbolTableIndexHashTraits to derive
+from HashTraitsSymbolTableEntry and removed redundant members.
+
2011-11-15 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100375 and r100385.
Modified: trunk/Source/_javascript_Core/runtime/Identifier.h (100416 => 100417)
--- trunk/Source/_javascript_Core/runtime/Identifier.h 2011-11-16 07:51:03 UTC (rev 100416)
+++ trunk/Source/_javascript_Core/runtime/Identifier.h 2011-11-16 08:05:40 UTC (rev 100417)
@@ -235,13 +235,9 @@
static unsigned hash(StringImpl* key) { return key-existingHash(); }
};
-struct IdentifierMapIndexHashTraits {
-typedef int TraitType;
-typedef IdentifierMapIndexHashTraits StorageTraits;
+struct IdentifierMapIndexHashTraits : HashTraitsint {
static int emptyValue() { return std::numeric_limitsint::max(); }
static const bool emptyValueIsZero = false;
-static const bool needsDestruction = false;
-static const bool needsRef = false;
};
typedef HashMapRefPtrStringImpl, int, IdentifierRepHash, HashTraitsRefPtrStringImpl , IdentifierMapIndexHashTraits IdentifierMap;
Modified: trunk/Source/_javascript_Core/runtime/SymbolTable.h (100416 => 100417)
--- trunk/Source/_javascript_Core/runtime/SymbolTable.h 2011-11-16 07:51:03 UTC (rev 100416)
+++ trunk/Source/_javascript_Core/runtime/SymbolTable.h 2011-11-16 08:05:40 UTC (rev 100417)
@@ -32,6 +32,7 @@
#include JSObject.h
#include UString.h
#include wtf/AlwaysInline.h
+#include wtf/HashTraits.h
namespace JSC {
@@ -112,9 +113,7 @@
int m_bits;
};
-struct SymbolTableIndexHashTraits {
-typedef SymbolTableEntry TraitType;
-static SymbolTableEntry emptyValue() { return SymbolTableEntry(); }
+struct SymbolTableIndexHashTraits : HashTraitsSymbolTableEntry {
static const bool emptyValueIsZero = true;
static const bool needsDestruction = false;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100418] trunk/Source/JavaScriptCore
Title: [100418] trunk/Source/_javascript_Core
Revision 100418
Author da...@apple.com
Date 2011-11-16 00:06:09 -0800 (Wed, 16 Nov 2011)
Log Message
Add a pass type and peek type concept to HashTraits
https://bugs.webkit.org/show_bug.cgi?id=72473
Reviewed by Filip Pizlo.
* wtf/HashTraits.h: Added the pass type and peek type.
For OwnPtr, the pass type will be PassOwnPtr and the peek
type will be a raw pointer.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTraits.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100417 => 100418)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 08:05:40 UTC (rev 100417)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 08:06:09 UTC (rev 100418)
@@ -1,5 +1,16 @@
2011-11-16 Darin Adler da...@apple.com
+Add a pass type and peek type concept to HashTraits
+https://bugs.webkit.org/show_bug.cgi?id=72473
+
+Reviewed by Filip Pizlo.
+
+* wtf/HashTraits.h: Added the pass type and peek type.
+For OwnPtr, the pass type will be PassOwnPtr and the peek
+type will be a raw pointer.
+
+2011-11-16 Darin Adler da...@apple.com
+
Fix some hash traits that don't derive from the base hash traits
https://bugs.webkit.org/show_bug.cgi?id=72470
Modified: trunk/Source/_javascript_Core/wtf/HashTraits.h (100417 => 100418)
--- trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-11-16 08:05:40 UTC (rev 100417)
+++ trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-11-16 08:06:09 UTC (rev 100418)
@@ -54,6 +54,10 @@
templatetypename T struct GenericHashTraits : GenericHashTraitsBaseIsIntegerT::value, T {
typedef T TraitType;
static T emptyValue() { return T(); }
+typedef const T PassType;
+static const T pass(const T value) { return value; }
+typedef const T PeekType;
+static const T peek(const T value) { return value; }
};
templatetypename T struct HashTraits : GenericHashTraitsT { };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100419] trunk/Source/WebCore
Title: [100419] trunk/Source/WebCore
Revision 100419
Author ma...@webkit.org
Date 2011-11-16 00:16:33 -0800 (Wed, 16 Nov 2011)
Log Message
[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
https://bugs.webkit.org/show_bug.cgi?id=72394
Reviewed by Martin Robinson.
No new functionality, no new tests needed.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_class_init): Initialize GQuarks.
(getGailTextUtilForAtk): Use gailTextUtilQuark.
(getPangoLayoutForAtk): Remove unused call to
g_object_set_data_full, since that data is no used anywhere.
(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100418 => 100419)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 08:06:09 UTC (rev 100418)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 08:16:33 UTC (rev 100419)
@@ -1,3 +1,19 @@
+2011-11-16 Mario Sanchez Prada msanc...@igalia.com
+
+[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
+https://bugs.webkit.org/show_bug.cgi?id=72394
+
+Reviewed by Martin Robinson.
+
+No new functionality, no new tests needed.
+
+* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+(webkit_accessible_class_init): Initialize GQuarks.
+(getGailTextUtilForAtk): Use gailTextUtilQuark.
+(getPangoLayoutForAtk): Remove unused call to
+g_object_set_data_full, since that data is no used anywhere.
+(webkitAccessibleHyperlinkImplGetHyperlink): Use hyperlinkObjectQuark.
+
2011-11-15 Alexandru Chiculita ach...@adobe.com
[CSSShaders] Implement the style cached resources and computed style for the shader urls
Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (100418 => 100419)
--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp 2011-11-16 08:06:09 UTC (rev 100418)
+++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp 2011-11-16 08:16:33 UTC (rev 100419)
@@ -76,6 +76,9 @@
using namespace WebCore;
+static GQuark gailTextUtilQuark = 0;
+static GQuark hyperlinkObjectQuark = 0;
+
static AccessibilityObject* fallbackObject()
{
// FIXME: An AXObjectCache with a Document is meaningless.
@@ -830,6 +833,9 @@
klass-get_index_in_parent = webkit_accessible_get_index_in_parent;
klass-get_attributes = webkit_accessible_get_attributes;
klass-ref_relation_set = webkit_accessible_ref_relation_set;
+
+gailTextUtilQuark = g_quark_from_static_string(webkit-accessible-gail-text-util);
+hyperlinkObjectQuark = g_quark_from_static_string(webkit-accessible-hyperlink-object);
}
GType
@@ -1275,13 +1281,13 @@
static GailTextUtil* getGailTextUtilForAtk(AtkText* textObject)
{
-gpointer data = "" webkit-accessible-gail-text-util);
+gpointer data = "" gailTextUtilQuark);
if (data)
return static_castGailTextUtil*(data);
GailTextUtil* gailTextUtil = gail_text_util_new();
gail_text_util_text_setup(gailTextUtil, webkit_accessible_text_get_text(textObject, 0, -1));
-g_object_set_data_full(G_OBJECT(textObject), webkit-accessible-gail-text-util, gailTextUtil, g_object_unref);
+g_object_set_qdata_full(G_OBJECT(textObject), gailTextUtilQuark, gailTextUtil, g_object_unref);
return gailTextUtil;
}
@@ -1302,7 +1308,6 @@
// Create a string with the layout as it appears on the screen
PangoLayout* layout = gtk_widget_create_pango_layout(static_castGtkWidget*(webView), textForObject(coreObject));
-g_object_set_data_full(G_OBJECT(textObject), webkit-accessible-pango-layout, layout, g_object_unref);
return layout;
}
@@ -2360,10 +2365,10 @@
static AtkHyperlink* webkitAccessibleHyperlinkImplGetHyperlink(AtkHyperlinkImpl* hyperlink)
{
-AtkHyperlink* hyperlinkObject = ATK_HYPERLINK(g_object_get_data(G_OBJECT(hyperlink), hyperlink-object));
+AtkHyperlink* hyperlinkObject = ATK_HYPERLINK(g_object_get_qdata(G_OBJECT(hyperlink), hyperlinkObjectQuark));
if (!hyperlinkObject) {
hyperlinkObject = ATK_HYPERLINK(webkitAccessibleHyperlinkNew(hyperlink));
-g_object_set_data(G_OBJECT(hyperlink), hyperlink-object, hyperlinkObject);
+g_object_set_qdata(G_OBJECT(hyperlink), hyperlinkObjectQuark, hyperlinkObject);
}
return hyperlinkObject;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100420] trunk/LayoutTests
Title: [100420] trunk/LayoutTests Revision 100420 Author jam...@google.com Date 2011-11-16 00:16:42 -0800 (Wed, 16 Nov 2011) Log Message [chromium] Update chromium win and linux compositing baselines https://bugs.webkit.org/show_bug.cgi?id=72402 * platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png. * platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png: * platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png: * platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png: * platform/chromium-linux/compositing/self-painting-layers-expected.png: * platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png. * platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png: Removed. * platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png: Removed. * platform/chromium-mac/compositing/self-painting-layers-expected.png: Removed. * platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png: * platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png: * platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png: * platform/chromium-win/compositing/self-painting-layers-expected.png: * platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png. * platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png. * platform/chromium/compositing/self-painting-layers-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png trunk/LayoutTests/platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png trunk/LayoutTests/platform/chromium-linux/compositing/self-painting-layers-expected.png trunk/LayoutTests/platform/chromium-win/compositing/layers-inside-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-win/compositing/overflow/overflow-compositing-descendant-expected.png trunk/LayoutTests/platform/chromium-win/compositing/overflow/scroll-ancestor-update-expected.png trunk/LayoutTests/platform/chromium-win/compositing/self-painting-layers-expected.png Added Paths trunk/LayoutTests/platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png trunk/LayoutTests/platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png trunk/LayoutTests/platform/chromium/compositing/self-painting-layers-expected.png trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/ trunk/LayoutTests/platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/compositing/layers-inside-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-cg-mac/compositing/overflow/overflow-compositing-descendant-expected.png trunk/LayoutTests/platform/chromium-cg-mac/compositing/overflow/scroll-ancestor-update-expected.png trunk/LayoutTests/platform/chromium-cg-mac/compositing/self-painting-layers-expected.png trunk/LayoutTests/platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png trunk/LayoutTests/platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png trunk/LayoutTests/platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png trunk/LayoutTests/platform/chromium-mac/compositing/self-painting-layers-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (100419 => 100420) --- trunk/LayoutTests/ChangeLog 2011-11-16 08:16:33 UTC (rev 100419) +++ trunk/LayoutTests/ChangeLog 2011-11-16 08:16:42 UTC (rev 100420) @@ -1,3 +1,26 @@ +2011-11-16 James Robinson jam...@chromium.org + +[chromium] Update chromium win and linux compositing baselines +https://bugs.webkit.org/show_bug.cgi?id=72402 + +* platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png: Renamed from
[webkit-changes] [100421] trunk/Tools
Title: [100421] trunk/Tools
Revision 100421
Author e...@webkit.org
Date 2011-11-16 00:41:36 -0800 (Wed, 16 Nov 2011)
Log Message
check-webkit-style broken by r99773: Could not determine the port
https://bugs.webkit.org/show_bug.cgi?id=72275
Reviewed by Adam Barth.
Engage windows hacks harder.
This is a speculative fix for ChromiumWin. We're now
creating an SCM object much earlier, so we need to
engage our awesome windows hacks earlier.
* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
Diff
Modified: trunk/Tools/ChangeLog (100420 => 100421)
--- trunk/Tools/ChangeLog 2011-11-16 08:16:42 UTC (rev 100420)
+++ trunk/Tools/ChangeLog 2011-11-16 08:41:36 UTC (rev 100421)
@@ -1,3 +1,19 @@
+2011-11-16 Eric Seidel e...@webkit.org
+
+check-webkit-style broken by r99773: Could not determine the port
+https://bugs.webkit.org/show_bug.cgi?id=72275
+
+Reviewed by Adam Barth.
+
+Engage windows hacks harder.
+
+This is a speculative fix for ChromiumWin. We're now
+creating an SCM object much earlier, so we need to
+engage our awesome windows hacks earlier.
+
+* Scripts/webkitpy/common/host.py:
+* Scripts/webkitpy/layout_tests/port/chromium_win.py:
+
2011-11-15 Darin Adler da...@apple.com
DRT's uiElementAttributeValueCallback function is leaky
Modified: trunk/Tools/Scripts/webkitpy/common/host.py (100420 => 100421)
--- trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-16 08:16:42 UTC (rev 100420)
+++ trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-16 08:41:36 UTC (rev 100421)
@@ -27,6 +27,8 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import logging
+import sys
from webkitpy.common.checkout import Checkout
from webkitpy.common.checkout.scm import default_scm
@@ -38,6 +40,9 @@
from webkitpy.layout_tests.port.factory import PortFactory
+_log = logging.getLogger(__name__)
+
+
class Host(object):
def __init__(self):
# These basic environment abstractions should be a separate lower-level object.
@@ -63,7 +68,35 @@
# FIXME: PortFactory doesn't belong on this Host object if Port is going to have a Host (circular dependency).
self.port_factory = PortFactory(self)
+# FIXME: This is a horrible, horrible hack for ChromiumWin and should be removed.
+# Maybe this belongs in SVN in some more generic find the svn binary codepath?
+# Or possibly Executive should have a way to emulate shell path-lookups?
+def _engage_awesome_windows_hacks(self):
+if sys.platform != win32:
+return
+try:
+self._executive.run_command(['svn', 'help'])
+except OSError, e:
+try:
+self._executive.run_command(['svn.bat', 'help'])
+# Chromium Win uses the depot_tools package, which contains a number
+# of development tools, including Python and svn. Instead of using a
+# real svn executable, depot_tools indirects via a batch file, called
+# svn.bat. This batch file allows depot_tools to auto-update the real
+# svn executable, which is contained in a subdirectory.
+#
+# That's all fine and good, except that subprocess.popen can detect
+# the difference between a real svn executable and batch file when we
+# don't provide use shell=True. Rather than use shell=True on Windows,
+# We hack the svn.bat name into the SVN class.
+_log.debug('Engaging svn.bat Windows hack.')
+from webkitpy.common.checkout.scm.svn import SVN
+SVN.executable_name = 'svn.bat'
+except OSError, e:
+_log.debug('Failed to engage svn.bat Windows hack.')
+
def _initialize_scm(self, patch_directories=None):
+self._engage_awesome_windows_hacks()
self._scm = default_scm(patch_directories)
self._checkout = Checkout(self.scm())
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py (100420 => 100421)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2011-11-16 08:16:42 UTC (rev 100420)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py 2011-11-16 08:41:36 UTC (rev 100421)
@@ -95,31 +95,7 @@
self._version = port_name[port_name.index('-win-') + len('-win-'):]
assert self._version in self.SUPPORTED_VERSIONS, %s is not in %s % (self._version, self.SUPPORTED_VERSIONS)
self._operating_system = 'win'
-self._engage_awesome_windows_hacks()
-def _engage_awesome_windows_hacks(self):
-if sys.platform !=
[webkit-changes] [100422] trunk/LayoutTests
Title: [100422] trunk/LayoutTests Revision 100422 Author jam...@google.com Date 2011-11-16 00:48:53 -0800 (Wed, 16 Nov 2011) Log Message [chromium] Update chromium expectations for compositing tests * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100421 => 100422) --- trunk/LayoutTests/ChangeLog 2011-11-16 08:41:36 UTC (rev 100421) +++ trunk/LayoutTests/ChangeLog 2011-11-16 08:48:53 UTC (rev 100422) @@ -1,5 +1,11 @@ 2011-11-16 James Robinson jam...@chromium.org +[chromium] Update chromium expectations for compositing tests + +* platform/chromium/test_expectations.txt: + +2011-11-16 James Robinson jam...@chromium.org + [chromium] Update chromium win and linux compositing baselines https://bugs.webkit.org/show_bug.cgi?id=72402 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100421 => 100422) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 08:41:36 UTC (rev 100421) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 08:48:53 UTC (rev 100422) @@ -255,23 +255,23 @@ // this test will always fail. WONTFIX SKIP LINUX WIN : fast/events/option-tab.html = FAIL -// win+linux failures, probably aren't applicable to this config -BUGWK72402 WIN LINUX : compositing/video-page-visibility.html = FAIL -BUGWK72402 WIN LINUX : compositing/geometry/clipped-video-controller.html = FAIL -BUGWK72402 WIN LINUX : compositing/geometry/video-fixed-scrolling.html = FAIL -BUGWK72402 WIN LINUX : compositing/geometry/video-opacity-overlay.html = FAIL -BUGWK72402 WIN LINUX : compositing/layer-creation/spanOverlapsCanvas.html = FAIL +// probably aren't applicable to this config +BUGWK72402 : compositing/video-page-visibility.html = FAIL +BUGWK72402 : compositing/geometry/clipped-video-controller.html = FAIL +BUGWK72402 : compositing/geometry/video-fixed-scrolling.html = FAIL +BUGWK72402 : compositing/geometry/video-opacity-overlay.html = FAIL +BUGWK72402 : compositing/layer-creation/spanOverlapsCanvas.html = FAIL -// win+linux failures, either real bugs or need rebaselines -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-clipping-ancestor.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-fixed-positioned.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-overflow-root.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-positioned-transition.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-positioned.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT -BUGWK72402 WIN LINUX : compositing/geometry/limit-layer-bounds-transformed.html = TEXT -BUGWK72402 WIN LINUX : compositing/layer-creation/scroll-partial-update.html = TEXT -BUGWK72402 WIN LINUX : compositing/layer-creation/overflow-scroll-overlap.html = TEXT +// text failures on every platform. appears to be a real issue +BUGWK72402 : compositing/geometry/limit-layer-bounds-clipping-ancestor.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-fixed-positioned.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-overflow-root.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-positioned-transition.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-positioned.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT +BUGWK72402 : compositing/geometry/limit-layer-bounds-transformed.html = TEXT +BUGWK72402 : compositing/layer-creation/scroll-partial-update.html = TEXT +BUGWK72402 : compositing/layer-creation/overflow-scroll-overlap.html = TEXT // mac failures BUGWK72402 MAC : compositing/geometry/empty-embed-rects.html = TIMEOUT @@ -3656,8 +3656,6 @@ BUGWK68881 DEBUG : svg/text/selection-background-color.xhtml = CRASH IMAGE BUGWK68881 DEBUG : svg/text/selection-styles.xhtml = CRASH IMAGE -BUGWK68886 DEBUG MAC : compositing/geometry/limit-layer-bounds-transformed-overflow.html = TEXT - BUGWK68970 MAC CPU-CG : fast/multicol/float-paginate-empty-lines.html = IMAGE BUGWK68970 MAC CPU-CG : svg/custom/js-late-gradient-and-object-creation.svg = IMAGE BUGWK68970 MAC CPU-CG : svg/custom/pattern-in-defs.svg = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100423] trunk/Tools
Title: [100423] trunk/Tools
Revision 100423
Author e...@webkit.org
Date 2011-11-16 01:06:49 -0800 (Wed, 16 Nov 2011)
Log Message
check-webkit-style broken by r99773: Could not determine the port
https://bugs.webkit.org/show_bug.cgi?id=72275
Reviewed by Adam Barth.
I will continue engaging hacks, until windows improves.
* Scripts/webkitpy/common/host.py:
- Host uses self.executive instead of self._executive like Port does.
- I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/host.py
Diff
Modified: trunk/Tools/ChangeLog (100422 => 100423)
--- trunk/Tools/ChangeLog 2011-11-16 08:48:53 UTC (rev 100422)
+++ trunk/Tools/ChangeLog 2011-11-16 09:06:49 UTC (rev 100423)
@@ -5,6 +5,19 @@
Reviewed by Adam Barth.
+I will continue engaging hacks, until windows improves.
+
+* Scripts/webkitpy/common/host.py:
+ - Host uses self.executive instead of self._executive like Port does.
+ - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
+
+2011-11-16 Eric Seidel e...@webkit.org
+
+check-webkit-style broken by r99773: Could not determine the port
+https://bugs.webkit.org/show_bug.cgi?id=72275
+
+Reviewed by Adam Barth.
+
Engage windows hacks harder.
This is a speculative fix for ChromiumWin. We're now
Modified: trunk/Tools/Scripts/webkitpy/common/host.py (100422 => 100423)
--- trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-16 08:48:53 UTC (rev 100422)
+++ trunk/Tools/Scripts/webkitpy/common/host.py 2011-11-16 09:06:49 UTC (rev 100423)
@@ -71,14 +71,13 @@
# FIXME: This is a horrible, horrible hack for ChromiumWin and should be removed.
# Maybe this belongs in SVN in some more generic find the svn binary codepath?
# Or possibly Executive should have a way to emulate shell path-lookups?
+# FIXME: Unclear how to test this, since it currently mutates global state on SVN.
def _engage_awesome_windows_hacks(self):
-if sys.platform != win32:
-return
try:
-self._executive.run_command(['svn', 'help'])
+self.executive.run_command(['svn', 'help'])
except OSError, e:
try:
-self._executive.run_command(['svn.bat', 'help'])
+self.executive.run_command(['svn.bat', 'help'])
# Chromium Win uses the depot_tools package, which contains a number
# of development tools, including Python and svn. Instead of using a
# real svn executable, depot_tools indirects via a batch file, called
@@ -96,7 +95,8 @@
_log.debug('Failed to engage svn.bat Windows hack.')
def _initialize_scm(self, patch_directories=None):
-self._engage_awesome_windows_hacks()
+if sys.platform == win32:
+self._engage_awesome_windows_hacks()
self._scm = default_scm(patch_directories)
self._checkout = Checkout(self.scm())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100424] trunk/Source/WebKit/gtk
Title: [100424] trunk/Source/WebKit/gtk
Revision 100424
Author ma...@webkit.org
Date 2011-11-16 01:46:36 -0800 (Wed, 16 Nov 2011)
Log Message
[GTK] Do not hide accessibility root object from AT's
https://bugs.webkit.org/show_bug.cgi?id=72390
Reviewed by Martin Robinson.
* tests/testatk.c:
(getWebAreaObject): New helper function, to bypass the new root
object in the accessibility hierarchy, since it's not usually
needed for the unit tests.
(testWebkitAtkCaretOffsets): Use getWebAreaObject().
(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
(testWebkitAtkComboBox): Ditto.
(testWebkitAtkEmbeddedObjects): Ditto.
(testWebkitAtkGetTextAtOffsetForms): Ditto.
(testWebkitAtkGetTextAtOffset): Ditto.
(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
(testWebkitAtkGetTextInTable): Ditto.
(testWebkitAtkGetHeadersInTable): Ditto.
(testWebkitAtkTextAttributes): Ditto.
(testWebkitAtkTextSelections): Ditto.
(testWebkitAtkGetExtents): Ditto.
(testWebkitAtkLayoutAndDataTables): Ditto.
(testWebkitAtkLinksWithInlineImages): Ditto.
(testWebkitAtkHypertextAndHyperlinks): Ditto.
(testWebkitAtkListsOfItems): Ditto.
(testWebkitAtkTextChangedNotifications): Ditto.
(testWebkitAtkParentForRootObject): New test, to make sure that
both top-down and bottom-up navigation among GTK and WebKit worlds
matches accordingly.
(main): Added new test.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_accessible): Remove the hack introduced
because of bug 51932, to bypass the root object here.
Modified Paths
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatk.c
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (100423 => 100424)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-11-16 09:06:49 UTC (rev 100423)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-11-16 09:46:36 UTC (rev 100424)
@@ -1,3 +1,45 @@
+2011-11-16 Mario Sanchez Prada msanc...@igalia.com
+
+[GTK] Do not hide accessibility root object from AT's
+https://bugs.webkit.org/show_bug.cgi?id=72390
+
+Reviewed by Martin Robinson.
+
+* tests/testatk.c:
+(getWebAreaObject): New helper function, to bypass the new root
+object in the accessibility hierarchy, since it's not usually
+needed for the unit tests.
+(testWebkitAtkCaretOffsets): Use getWebAreaObject().
+(testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): Ditto.
+(testWebkitAtkComboBox): Ditto.
+(testWebkitAtkEmbeddedObjects): Ditto.
+(testWebkitAtkGetTextAtOffsetForms): Ditto.
+(testWebkitAtkGetTextAtOffset): Ditto.
+(testWebkitAtkGetTextAtOffsetNewlines): Ditto.
+(testWebkitAtkGetTextAtOffsetTextarea): Ditto.
+(testWebkitAtkGetTextAtOffsetTextInput): Ditto.
+(testWebkitAtkGetTextAtOffsetWithSpecialCharacters): Ditto.
+(testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
+(testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
+(testWebkitAtkGetTextInTable): Ditto.
+(testWebkitAtkGetHeadersInTable): Ditto.
+(testWebkitAtkTextAttributes): Ditto.
+(testWebkitAtkTextSelections): Ditto.
+(testWebkitAtkGetExtents): Ditto.
+(testWebkitAtkLayoutAndDataTables): Ditto.
+(testWebkitAtkLinksWithInlineImages): Ditto.
+(testWebkitAtkHypertextAndHyperlinks): Ditto.
+(testWebkitAtkListsOfItems): Ditto.
+(testWebkitAtkTextChangedNotifications): Ditto.
+(testWebkitAtkParentForRootObject): New test, to make sure that
+both top-down and bottom-up navigation among GTK and WebKit worlds
+matches accordingly.
+(main): Added new test.
+
+* webkit/webkitwebview.cpp:
+(webkit_web_view_get_accessible): Remove the hack introduced
+because of bug 51932, to bypass the root object here.
+
2011-11-15 Anders Carlsson ander...@apple.com
HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
Modified: trunk/Source/WebKit/gtk/tests/testatk.c (100423 => 100424)
--- trunk/Source/WebKit/gtk/tests/testatk.c 2011-11-16 09:06:49 UTC (rev 100423)
+++ trunk/Source/WebKit/gtk/tests/testatk.c 2011-11-16 09:46:36 UTC (rev 100424)
@@ -68,12 +68,25 @@
static const char* textWithAttributes = htmlheadstyle.st1 {font-family: monospace; color:rgb(120,121,122);} .st2 {text-decoration:underline; background-color:rgb(80,81,82);}/style/headbodyp style=\font-size:14; text-align:right;\This is the ifirst/ib sentence of this text./b/pp class=\st1\This sentence should have an style applied span class=\st2\and this part should have another one/span./ppxsub1/subsup2/sup=xsub2/subsup3/sup/pp
[webkit-changes] [100425] trunk
Title: [100425] trunk
Revision 100425
Author commit-qu...@webkit.org
Date 2011-11-16 02:35:31 -0800 (Wed, 16 Nov 2011)
Log Message
[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
https://bugs.webkit.org/show_bug.cgi?id=70720
Patch by Per-Erik Brodin per-erik.bro...@ericsson.com on 2011-11-16
Reviewed by Philippe Normand.
Source/WebCore:
Added missing overriding of Event::interfaceName()
* mediastream/MediaStreamEvent.cpp:
(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.
* mediastream/MediaStreamEvent.h:
* mediastream/MediaStreamEvent.idl: Changed module name to events.
LayoutTests:
* platform/gtk/Skipped: Unskipped fast/events/event-creation.html
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/mediastream/MediaStreamEvent.cpp
trunk/Source/WebCore/mediastream/MediaStreamEvent.h
trunk/Source/WebCore/mediastream/MediaStreamEvent.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (100424 => 100425)
--- trunk/LayoutTests/ChangeLog 2011-11-16 09:46:36 UTC (rev 100424)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 10:35:31 UTC (rev 100425)
@@ -1,3 +1,12 @@
+2011-11-16 Per-Erik Brodin per-erik.bro...@ericsson.com
+
+[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
+https://bugs.webkit.org/show_bug.cgi?id=70720
+
+Reviewed by Philippe Normand.
+
+* platform/gtk/Skipped: Unskipped fast/events/event-creation.html
+
2011-11-16 James Robinson jam...@chromium.org
[chromium] Update chromium expectations for compositing tests
Modified: trunk/LayoutTests/platform/gtk/Skipped (100424 => 100425)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 09:46:36 UTC (rev 100424)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 10:35:31 UTC (rev 100425)
@@ -1548,10 +1548,6 @@
# Missing DRT AccessibilityController::addNotificationListener implementation
accessibility/menu-list-sends-change-notification.html
-# https://bugs.webkit.org/show_bug.cgi?id=70720
-# [GTK] fast/events/event-creation.html fails creating MediaStreamEvent
-fast/events/event-creation.html
-
# https://bugs.webkit.org/show_bug.cgi?id=71022
fast/canvas/canvas-composite-image.html
fast/canvas/canvas-composite-canvas.html
Modified: trunk/Source/WebCore/ChangeLog (100424 => 100425)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 09:46:36 UTC (rev 100424)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 10:35:31 UTC (rev 100425)
@@ -1,3 +1,18 @@
+2011-11-16 Per-Erik Brodin per-erik.bro...@ericsson.com
+
+[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
+https://bugs.webkit.org/show_bug.cgi?id=70720
+
+Reviewed by Philippe Normand.
+
+Added missing overriding of Event::interfaceName()
+
+* mediastream/MediaStreamEvent.cpp:
+(WebCore::MediaStreamEvent::stream): Changed return value to raw pointer.
+(WebCore::MediaStreamEvent::interfaceName): Added back from r98044.
+* mediastream/MediaStreamEvent.h:
+* mediastream/MediaStreamEvent.idl: Changed module name to events.
+
2011-11-16 Mario Sanchez Prada msanc...@igalia.com
[GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data
Modified: trunk/Source/WebCore/mediastream/MediaStreamEvent.cpp (100424 => 100425)
--- trunk/Source/WebCore/mediastream/MediaStreamEvent.cpp 2011-11-16 09:46:36 UTC (rev 100424)
+++ trunk/Source/WebCore/mediastream/MediaStreamEvent.cpp 2011-11-16 10:35:31 UTC (rev 100425)
@@ -57,11 +57,16 @@
{
}
-PassRefPtrMediaStream MediaStreamEvent::stream() const
+MediaStream* MediaStreamEvent::stream() const
{
-return m_stream;
+return m_stream.get();
}
+const AtomicString MediaStreamEvent::interfaceName() const
+{
+return eventNames().interfaceForMediaStreamEvent;
+}
+
} // namespace WebCore
#endif // ENABLE(MEDIA_STREAM)
Modified: trunk/Source/WebCore/mediastream/MediaStreamEvent.h (100424 => 100425)
--- trunk/Source/WebCore/mediastream/MediaStreamEvent.h 2011-11-16 09:46:36 UTC (rev 100424)
+++ trunk/Source/WebCore/mediastream/MediaStreamEvent.h 2011-11-16 10:35:31 UTC (rev 100425)
@@ -32,8 +32,6 @@
namespace WebCore {
-class Stream;
-
class MediaStreamEvent : public Event {
public:
virtual ~MediaStreamEvent();
@@ -41,10 +39,9 @@
static PassRefPtrMediaStreamEvent create();
static PassRefPtrMediaStreamEvent create(const AtomicString type, bool canBubble, bool cancelable, PassRefPtrMediaStream);
-// From EventTarget.
-virtual bool isMediaStreamEvent() const { return true; }
+MediaStream* stream() const;
-PassRefPtrMediaStream stream() const;
+virtual const AtomicString interfaceName() const;
private:
MediaStreamEvent();
Modified: trunk/Source/WebCore/mediastream/MediaStreamEvent.idl (100424 => 100425)
---
[webkit-changes] [100427] trunk
Title: [100427] trunk
Revision 100427
Author hausm...@webkit.org
Date 2011-11-16 02:56:52 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, rolling out r100266.
http://trac.webkit.org/changeset/100266
Broke WTR.
.:
* Source/api.pri:
Source/_javascript_Core:
* Target.pri:
Source/WebCore:
* Target.pri:
Tools:
* qmake/mkspecs/features/default_post.prf:
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/ChangeLog (100426 => 100427)
--- trunk/ChangeLog 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/ChangeLog 2011-11-16 10:56:52 UTC (rev 100427)
@@ -1,3 +1,12 @@
+2011-11-16 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed, rolling out r100266.
+http://trac.webkit.org/changeset/100266
+
+Broke WTR.
+
+* Source/api.pri:
+
2011-11-15 Simon Hausmann simon.hausm...@nokia.com
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Modified: trunk/Source/_javascript_Core/ChangeLog (100426 => 100427)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 10:56:52 UTC (rev 100427)
@@ -1,3 +1,12 @@
+2011-11-16 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed, rolling out r100266.
+http://trac.webkit.org/changeset/100266
+
+Broke WTR.
+
+* Target.pri:
+
2011-11-16 Darin Adler da...@apple.com
Add a pass type and peek type concept to HashTraits
Modified: trunk/Source/_javascript_Core/Target.pri (100426 => 100427)
--- trunk/Source/_javascript_Core/Target.pri 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Source/_javascript_Core/Target.pri 2011-11-16 10:56:52 UTC (rev 100427)
@@ -20,6 +20,9 @@
QT += core
QT -= gui
+contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
+unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
+
*-g++*:QMAKE_CXXFLAGS_RELEASE -= -O2
*-g++*:QMAKE_CXXFLAGS_RELEASE += -O3
Modified: trunk/Source/WebCore/ChangeLog (100426 => 100427)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 10:56:52 UTC (rev 100427)
@@ -1,3 +1,12 @@
+2011-11-16 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed, rolling out r100266.
+http://trac.webkit.org/changeset/100266
+
+Broke WTR.
+
+* Target.pri:
+
2011-11-16 Per-Erik Brodin per-erik.bro...@ericsson.com
[GTK] fast/events/event-creation.html fails creating MediaStreamEvent
Modified: trunk/Source/WebCore/Target.pri (100426 => 100427)
--- trunk/Source/WebCore/Target.pri 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Source/WebCore/Target.pri 2011-11-16 10:56:52 UTC (rev 100427)
@@ -18,6 +18,8 @@
DEFINES += QT_MAKEDLL
+contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
+
haveQt(5) {
# Add a QtScript dependency for the time being, in order to pull in the include
# path for QtScript when it's built as a standalone module
Modified: trunk/Source/api.pri (100426 => 100427)
--- trunk/Source/api.pri 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Source/api.pri 2011-11-16 10:56:52 UTC (rev 100427)
@@ -35,6 +35,11 @@
contains(DEFINES, ENABLE_WEBGL=1)|contains(CONFIG, texmap): LIBS += $$QMAKE_LIBS_OPENGL
}
+CONFIG(release) {
+contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
+unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
+}
+
!static: DEFINES += QT_MAKEDLL
SOURCES += \
Modified: trunk/Tools/ChangeLog (100426 => 100427)
--- trunk/Tools/ChangeLog 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Tools/ChangeLog 2011-11-16 10:56:52 UTC (rev 100427)
@@ -1,3 +1,12 @@
+2011-11-16 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed, rolling out r100266.
+http://trac.webkit.org/changeset/100266
+
+Broke WTR.
+
+* qmake/mkspecs/features/default_post.prf:
+
2011-11-16 Eric Seidel e...@webkit.org
check-webkit-style broken by r99773: Could not determine the port
Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (100426 => 100427)
--- trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-16 10:51:34 UTC (rev 100426)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf 2011-11-16 10:56:52 UTC (rev 100427)
@@ -130,9 +130,6 @@
DEFINES += QT_ASCII_CAST_WARNINGS
win32-msvc*|win32-icc: INCLUDEPATH += $$ROOT_WEBKIT_DIR/Source/_javascript_Core/os-win32
-
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
}
equals(_PRO_FILE_, $${ROOT_WEBKIT_DIR}/WebKit.pro):!isEmpty(OVERRIDE_SUBDIRS) {
[webkit-changes] [100428] trunk/Tools
Title: [100428] trunk/Tools
Revision 100428
Author commit-qu...@webkit.org
Date 2011-11-16 03:49:52 -0800 (Wed, 16 Nov 2011)
Log Message
[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
https://bugs.webkit.org/show_bug.cgi?id=72384
Update to Android NDK r7, which was released last Friday. This adds
support for RTTI and the -mimplicit-it gcc flag, which are required to
respectively build ICU and Skia.
Patch by Peter Beverloo pe...@chromium.org on 2011-11-16
Reviewed by Steve Block.
* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-chromium
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (100427 => 100428)
--- trunk/Tools/ChangeLog 2011-11-16 10:56:52 UTC (rev 100427)
+++ trunk/Tools/ChangeLog 2011-11-16 11:49:52 UTC (rev 100428)
@@ -1,3 +1,18 @@
+2011-11-16 Peter Beverloo pe...@chromium.org
+
+[Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
+https://bugs.webkit.org/show_bug.cgi?id=72384
+
+Update to Android NDK r7, which was released last Friday. This adds
+support for RTTI and the -mimplicit-it gcc flag, which are required to
+respectively build ICU and Skia.
+
+Reviewed by Steve Block.
+
+* Scripts/update-webkit-chromium:
+* Scripts/webkitdirs.pm:
+(buildChromiumMakefile):
+
2011-11-16 Simon Hausmann simon.hausm...@nokia.com
Unreviewed, rolling out r100266.
Modified: trunk/Tools/Scripts/update-webkit-chromium (100427 => 100428)
--- trunk/Tools/Scripts/update-webkit-chromium 2011-11-16 10:56:52 UTC (rev 100427)
+++ trunk/Tools/Scripts/update-webkit-chromium 2011-11-16 11:49:52 UTC (rev 100428)
@@ -61,20 +61,20 @@
# When building WebKit's Chromium port for Android, we need the Android NDK as
# it will allow us to cross-compile all sources to the target architecture.
if (isChromiumAndroid()) {
-if (! -e third_party/android-ndk-r6b) {
-print Installing the Android NDK, version 6b...\n;
+if (! -e third_party/android-ndk-r7) {
+print Installing the Android NDK, version 7...\n;
if (! -e third_party/) {
mkdir third_party;
}
my $host_os = isLinux() ? linux : darwin;
-my $result = system(curl, -o, third_party/android-ndk-r6b.tar.bz2, http://dl.google.com/android/ndk/android-ndk-r6b- . $host_os . -x86.tar.bz2);
+my $result = system(curl, -o, third_party/android-ndk-r7.tar.bz2, http://dl.google.com/android/ndk/android-ndk-r7- . $host_os . -x86.tar.bz2);
die Couldn't download the Android NDK. if $result;
-$result = system(tar, jxC, third_party, -f, third_party/android-ndk-r6b.tar.bz2);
+$result = system(tar, jxC, third_party, -f, third_party/android-ndk-r7.tar.bz2);
die Couldn't extract the Android NDK. if $result;
}
-$ENV{ANDROID_NDK_ROOT} = sourceDir() . /Source/WebKit/chromium/third_party/android-ndk-r6b;
+$ENV{ANDROID_NDK_ROOT} = sourceDir() . /Source/WebKit/chromium/third_party/android-ndk-r7;
$ENV{WEBKIT_ANDROID_BUILD} = 1;
}
Modified: trunk/Tools/Scripts/webkitdirs.pm (100427 => 100428)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-11-16 10:56:52 UTC (rev 100427)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-11-16 11:49:52 UTC (rev 100428)
@@ -1898,7 +1898,7 @@
# will verify that the installed NDK is indeed available.
if (isChromiumAndroid()) {
$command .= bash -c \source . sourceDir() . /Source/WebKit/chromium/build/android/envsetup.sh ;
-$ENV{ANDROID_NDK_ROOT} = sourceDir() . /Source/WebKit/chromium/third_party/android-ndk-r6b;
+$ENV{ANDROID_NDK_ROOT} = sourceDir() . /Source/WebKit/chromium/third_party/android-ndk-r7;
$ENV{WEBKIT_ANDROID_BUILD} = 1;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100429] trunk/LayoutTests
Title: [100429] trunk/LayoutTests Revision 100429 Author stevebl...@google.com Date 2011-11-16 03:57:09 -0800 (Wed, 16 Nov 2011) Log Message LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots https://bugs.webkit.org/show_bug.cgi?id=72485 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100428 => 100429) --- trunk/LayoutTests/ChangeLog 2011-11-16 11:49:52 UTC (rev 100428) +++ trunk/LayoutTests/ChangeLog 2011-11-16 11:57:09 UTC (rev 100429) @@ -1,3 +1,12 @@ +2011-11-16 Steve Block stevebl...@google.com + +LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots +https://bugs.webkit.org/show_bug.cgi?id=72485 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + 2011-11-16 Gabor Rapcsanyi rga...@webkit.org [Qt][ARMv5] Websocket tests are fail, skip until fix Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100428 => 100429) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 11:49:52 UTC (rev 100428) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 11:57:09 UTC (rev 100429) @@ -3911,3 +3911,5 @@ BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS + +BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100430] trunk/LayoutTests
Title: [100430] trunk/LayoutTests Revision 100430 Author stevebl...@google.com Date 2011-11-16 04:33:04 -0800 (Wed, 16 Nov 2011) Log Message Compositing LayoutTests failing on Chromium Mac https://bugs.webkit.org/show_bug.cgi?id=72487 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100429 => 100430) --- trunk/LayoutTests/ChangeLog 2011-11-16 11:57:09 UTC (rev 100429) +++ trunk/LayoutTests/ChangeLog 2011-11-16 12:33:04 UTC (rev 100430) @@ -1,5 +1,14 @@ 2011-11-16 Steve Block stevebl...@google.com +Compositing LayoutTests failing on Chromium Mac +https://bugs.webkit.org/show_bug.cgi?id=72487 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + +2011-11-16 Steve Block stevebl...@google.com + LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots https://bugs.webkit.org/show_bug.cgi?id=72485 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100429 => 100430) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 11:57:09 UTC (rev 100429) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 12:33:04 UTC (rev 100430) @@ -3913,3 +3913,8 @@ BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS + +BUGWK72487 MAC : compositing/layers-inside-overflow-scroll.html = IMAGE +BUGWK72487 MAC : compositing/overflow/overflow-compositing-descendant.html = IMAGE +BUGWK72487 MAC : compositing/overflow/scroll-ancestor-update.html = IMAGE +BUGWK72487 MAC : compositing/self-painting-layers.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100431] trunk/LayoutTests
Title: [100431] trunk/LayoutTests
Revision 100431
Author rga...@webkit.org
Date 2011-11-16 04:48:30 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] Update Qt specific expected results.
Unreviewed gardening.
* platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
* platform/qt/fast/loader/file-protocol-fragment-expected.txt:
* platform/qt/inspector: Added.
* platform/qt/inspector/console: Added.
* platform/qt/inspector/console/console-format-expected.png: Added.
* platform/qt/inspector/console/console-format-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt
Added Paths
trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png
trunk/LayoutTests/platform/qt/inspector/
trunk/LayoutTests/platform/qt/inspector/console/
trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png
trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100430 => 100431)
--- trunk/LayoutTests/ChangeLog 2011-11-16 12:33:04 UTC (rev 100430)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 12:48:30 UTC (rev 100431)
@@ -1,3 +1,16 @@
+2011-11-16 Gabor Rapcsanyi rga...@webkit.org
+
+[Qt] Update Qt specific expected results.
+
+Unreviewed gardening.
+
+* platform/qt/fast/loader/file-protocol-fragment-expected.png: Added.
+* platform/qt/fast/loader/file-protocol-fragment-expected.txt:
+* platform/qt/inspector: Added.
+* platform/qt/inspector/console: Added.
+* platform/qt/inspector/console/console-format-expected.png: Added.
+* platform/qt/inspector/console/console-format-expected.txt: Added.
+
2011-11-16 Steve Block stevebl...@google.com
Compositing LayoutTests failing on Chromium Mac
Added: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.png
___
Added: svn:mime-type
Modified: trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt (100430 => 100431)
--- trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt 2011-11-16 12:33:04 UTC (rev 100430)
+++ trunk/LayoutTests/platform/qt/fast/loader/file-protocol-fragment-expected.txt 2011-11-16 12:48:30 UTC (rev 100431)
@@ -4,4 +4,5 @@
resources/stylesheet.css#a - didReceiveResponse NSURLResponse resources/stylesheet.css#a, http status code 0
resources/stylesheet.css#a - didFinishLoading
resources/stylesheet.css#b - didReceiveResponse NSURLResponse resources/stylesheet.css#b, http status code 0
+resources/stylesheet.css#b - didFinishLoading
This tests that file: URL are loaded separately even if they differ by the fragment only.
Added: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt (0 => 100431)
--- trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/qt/inspector/console/console-format-expected.txt 2011-11-16 12:48:30 UTC (rev 100431)
@@ -0,0 +1,139 @@
+CONSOLE MESSAGE: line 12: Message format number %i, %d and %f
+CONSOLE MESSAGE: line 13: Message %s for %s
+CONSOLE MESSAGE: line 14: Object %o
+CONSOLE MESSAGE: line 20: test,test2,,,test4
+CONSOLE MESSAGE: line 21: %o
+CONSOLE MESSAGE: line 22: %O
+CONSOLE MESSAGE: line 54: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i
+CONSOLE MESSAGE: line 55: /^url\(\s*(?:(?:(?:[^\\\]|(?:\\[\da-f]{1,6}\s?|\.))*|'(?:[^\\\']|(?:\\[\da-f]{1,6}\s?|\.))*')|(?:[!#$%*-~\w]|(?:\\[\da-f]{1,6}\s?|\.))*)\s*\)/i
+CONSOLE MESSAGE: line 54: /foo\\bar\sbaz/i
+CONSOLE MESSAGE: line 55: /foo\\bar\sbaz/i
+CONSOLE MESSAGE: line 54: test
+CONSOLE MESSAGE: line 55: test
+CONSOLE MESSAGE: line 54: test named test
+CONSOLE MESSAGE: line 55: test named test
+CONSOLE MESSAGE: line 54: Error
+CONSOLE MESSAGE: line 55: Error
+CONSOLE MESSAGE: line 54: [object HTMLBodyElement]
+CONSOLE MESSAGE: line 55: [object HTMLBodyElement]
+CONSOLE MESSAGE: line 54: function () { return 1; }
+CONSOLE MESSAGE: line 55: function () { return 1; }
+CONSOLE MESSAGE: line 54: function () {
+return 2;
+}
+CONSOLE MESSAGE: line 55: function () {
+return 2;
+}
+CONSOLE MESSAGE: line 54: 0.12
+CONSOLE MESSAGE: line 55: 0.12
+CONSOLE MESSAGE: line 54: http://webkit.org/
+CONSOLE MESSAGE: line 55: http://webkit.org/
+CONSOLE
[webkit-changes] [100432] trunk/Tools
Title: [100432] trunk/Tools Revision 100432 Author commit-qu...@webkit.org Date 2011-11-16 04:52:06 -0800 (Wed, 16 Nov 2011) Log Message Explicitly include unistd.h in TestNetscapePlugIn https://bugs.webkit.org/show_bug.cgi?id=72385 This is needed for the sleep() call in the indicateTestFailure method, which seems to be implicitly available for other platforms. This is not the case on Android. Patch by Peter Beverloo pe...@chromium.org on 2011-11-16 Reviewed by Steve Block. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp Diff Modified: trunk/Tools/ChangeLog (100431 => 100432) --- trunk/Tools/ChangeLog 2011-11-16 12:48:30 UTC (rev 100431) +++ trunk/Tools/ChangeLog 2011-11-16 12:52:06 UTC (rev 100432) @@ -1,5 +1,18 @@ 2011-11-16 Peter Beverloo pe...@chromium.org +Explicitly include unistd.h in TestNetscapePlugIn +https://bugs.webkit.org/show_bug.cgi?id=72385 + +This is needed for the sleep() call in the indicateTestFailure method, +which seems to be implicitly available for other platforms. This is not +the case on Android. + +Reviewed by Steve Block. + +* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: + +2011-11-16 Peter Beverloo pe...@chromium.org + [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium https://bugs.webkit.org/show_bug.cgi?id=72384 Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp (100431 => 100432) --- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp 2011-11-16 12:48:30 UTC (rev 100431) +++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp 2011-11-16 12:52:06 UTC (rev 100432) @@ -29,6 +29,10 @@ #include assert.h #include string.h +#if defined(ANDROID) +#include unistd.h +#endif + using namespace std; extern NPNetscapeFuncs *browser; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100433] trunk
Title: [100433] trunk
Revision 100433
Author ca...@chromium.org
Date 2011-11-16 04:56:21 -0800 (Wed, 16 Nov 2011)
Log Message
Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
https://bugs.webkit.org/show_bug.cgi?id=72388
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: inspector/extensions/extensions-panel.html
inspector/extensions/extensions-sidebar.html
- fire ExtensionSidebarPane.on{Hidden,Shown} for non-iframe content (experssions/objects);
- drop ExtensionsSidebarPane.onUpdated, provide callback for setObject()/setExpression() instead;
- fix an exception when a page is replaced with object/_expression_.
inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.ExtensionSidebarPaneImpl):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setObject):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionNotifierView):
(WebInspector.ExtensionNotifierView.prototype.wasShown):
(WebInspector.ExtensionNotifierView.prototype.willHide):
(WebInspector.ExtensionSidebarPane.prototype.setObject):
(WebInspector.ExtensionSidebarPane.prototype.setExpression):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._onEvaluate):
(WebInspector.ExtensionSidebarPane.prototype._makeObjectPropertiesView):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarContent.callback):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
(WebInspector.ExtensionServer.prototype._dispatchCallback):
* inspector/front-end/View.js:
(WebInspector.View.prototype.detach):
LayoutTests:
- split LayoutTests/inspector/extensions.html into extensions-panel.html extensions-sidebar.html.
* inspector/extensions/extensions-panel-expected.txt: Added.
* inspector/extensions/extensions-panel.html: Added.
* inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
* inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js
trunk/Source/WebCore/inspector/front-end/ExtensionPanel.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
trunk/Source/WebCore/inspector/front-end/View.js
Added Paths
trunk/LayoutTests/inspector/extensions/extensions-panel-expected.txt
trunk/LayoutTests/inspector/extensions/extensions-panel.html
trunk/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt
trunk/LayoutTests/inspector/extensions/extensions-sidebar.html
Removed Paths
trunk/LayoutTests/inspector/extensions/extensions-expected.txt
trunk/LayoutTests/inspector/extensions/extensions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100432 => 100433)
--- trunk/LayoutTests/ChangeLog 2011-11-16 12:52:06 UTC (rev 100432)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 12:56:21 UTC (rev 100433)
@@ -1,3 +1,17 @@
+2011-11-15 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
+https://bugs.webkit.org/show_bug.cgi?id=72388
+
+Reviewed by Pavel Feldman.
+
+- split LayoutTests/inspector/extensions.html into extensions-panel.html extensions-sidebar.html.
+
+* inspector/extensions/extensions-panel-expected.txt: Added.
+* inspector/extensions/extensions-panel.html: Added.
+* inspector/extensions/extensions-sidebar-expected.txt: Renamed from LayoutTests/inspector/extensions/extensions-expected.txt.
+* inspector/extensions/extensions-sidebar.html: Renamed from LayoutTests/inspector/extensions/extensions.html.
+
2011-11-16 Gabor Rapcsanyi rga...@webkit.org
[Qt] Update Qt specific expected results.
Deleted: trunk/LayoutTests/inspector/extensions/extensions-expected.txt (100432 => 100433)
--- trunk/LayoutTests/inspector/extensions/extensions-expected.txt 2011-11-16 12:52:06 UTC (rev 100432)
+++ trunk/LayoutTests/inspector/extensions/extensions-expected.txt 2011-11-16 12:56:21 UTC (rev 100433)
@@ -1,68 +0,0 @@
-Tests WebInspector extension API
-
-Started extension.
-Running tests...
-RUNNING TEST: extension_testCreatePanel
-Panel created
-{
-onShown : {
-addListener : function
-removeListener : function
-}
-onHidden : {
-addListener : function
-removeListener : function
-}
-onSearch : {
-addListener : function
-removeListener : function
-}
-}
-Extension panel size correct
-RUNNING TEST: extension_testSidebarPage
-Sidebar created
-{
-onShown : {
-addListener : function
-removeListener : function
-}
-onHidden : {
-addListener : function
-
[webkit-changes] [100434] trunk/LayoutTests
Title: [100434] trunk/LayoutTests Revision 100434 Author rga...@webkit.org Date 2011-11-16 05:09:25 -0800 (Wed, 16 Nov 2011) Log Message [Qt] new test css3/flexbox/line-wrapping.html failing https://bugs.webkit.org/show_bug.cgi?id=72490 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100433 => 100434) --- trunk/LayoutTests/ChangeLog 2011-11-16 12:56:21 UTC (rev 100433) +++ trunk/LayoutTests/ChangeLog 2011-11-16 13:09:25 UTC (rev 100434) @@ -1,3 +1,12 @@ +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test css3/flexbox/line-wrapping.html failing +https://bugs.webkit.org/show_bug.cgi?id=72490 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-15 Andrey Kosyakov ca...@chromium.org Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead Modified: trunk/LayoutTests/platform/qt/Skipped (100433 => 100434) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 12:56:21 UTC (rev 100433) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 13:09:25 UTC (rev 100434) @@ -2482,3 +2482,7 @@ # [Qt] fast/forms/file/file-input-reset.html failing on Qt # https://bugs.webkit.org/show_bug.cgi?id=72429 fast/forms/file/file-input-reset.html + +# [Qt] new test css3/flexbox/line-wrapping.html failing +# https://bugs.webkit.org/show_bug.cgi?id=72490 +css3/flexbox/line-wrapping.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100435] trunk/LayoutTests
Title: [100435] trunk/LayoutTests Revision 100435 Author stevebl...@google.com Date 2011-11-16 05:13:10 -0800 (Wed, 16 Nov 2011) Log Message Layout Test inspector/extensions/extensions-events.html is flaky https://bugs.webkit.org/show_bug.cgi?id=72447 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100434 => 100435) --- trunk/LayoutTests/ChangeLog 2011-11-16 13:09:25 UTC (rev 100434) +++ trunk/LayoutTests/ChangeLog 2011-11-16 13:13:10 UTC (rev 100435) @@ -1,3 +1,12 @@ +2011-11-16 Steve Block stevebl...@google.com + +Layout Test inspector/extensions/extensions-events.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=72447 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + 2011-11-16 Gabor Rapcsanyi rga...@webkit.org [Qt] new test css3/flexbox/line-wrapping.html failing Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100434 => 100435) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 13:09:25 UTC (rev 100434) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 13:13:10 UTC (rev 100435) @@ -3910,7 +3910,7 @@ BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS -BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS +BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS TIMEOUT BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100436] trunk/LayoutTests
Title: [100436] trunk/LayoutTests Revision 100436 Author stevebl...@google.com Date 2011-11-16 05:51:17 -0800 (Wed, 16 Nov 2011) Log Message LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6 https://bugs.webkit.org/show_bug.cgi?id=72494 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100435 => 100436) --- trunk/LayoutTests/ChangeLog 2011-11-16 13:13:10 UTC (rev 100435) +++ trunk/LayoutTests/ChangeLog 2011-11-16 13:51:17 UTC (rev 100436) @@ -1,5 +1,14 @@ 2011-11-16 Steve Block stevebl...@google.com +LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6 +https://bugs.webkit.org/show_bug.cgi?id=72494 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + +2011-11-16 Steve Block stevebl...@google.com + Layout Test inspector/extensions/extensions-events.html is flaky https://bugs.webkit.org/show_bug.cgi?id=72447 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100435 => 100436) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 13:13:10 UTC (rev 100435) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 13:51:17 UTC (rev 100436) @@ -2732,6 +2732,7 @@ BUGWK54322 SNOWLEOPARD : fast/css/transform-default-parameter.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/dom/blur-contenteditable.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/images/favicon-as-image.html = IMAGE+TEXT +BUGWK54322 SNOWLEOPARD : fast/replaced/width100percent-textarea.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/text/international/pop-up-button-text-alignment-and-direction.html = IMAGE BUGWK54322 SNOWLEOPARD : fast/text/international/text-combine-image-test.html = IMAGE BUGWK54322 SNOWLEOPARD : fonts/monospace.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100437] trunk/LayoutTests
Title: [100437] trunk/LayoutTests Revision 100437 Author o...@webkit.org Date 2011-11-16 06:03:42 -0800 (Wed, 16 Nov 2011) Log Message [Qt] Unreviewed gardening after r100281. * platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html again, because it makes all plugin related tests fail intermittently. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100436 => 100437) --- trunk/LayoutTests/ChangeLog 2011-11-16 13:51:17 UTC (rev 100436) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:03:42 UTC (rev 100437) @@ -1,3 +1,10 @@ +2011-11-16 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening after r100281. + +* platform/qt/Skipped: Skip http/tests/plugins/third-party-cookie-accept-policy.html +again, because it makes all plugin related tests fail intermittently. + 2011-11-16 Steve Block stevebl...@google.com LayoutTest fast/replaced/width100percent-textarea.html fails on Chromium Mac 10.6 Modified: trunk/LayoutTests/platform/qt/Skipped (100436 => 100437) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 13:51:17 UTC (rev 100436) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:03:42 UTC (rev 100437) @@ -1666,6 +1666,7 @@ # https://bugs.webkit.org/show_bug.cgi?id=45455 # See also http://bugreports.qt.nokia.com/browse/QTBUG-13601 platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html +http/tests/plugins/third-party-cookie-accept-policy.html # = # # new skipped tests yet to be sorted ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100438] trunk/Source
Title: [100438] trunk/Source
Revision 100438
Author commit-qu...@webkit.org
Date 2011-11-16 06:04:57 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Pass screen refresh rate into compositor.
https://bugs.webkit.org/show_bug.cgi?id=71040
Patch by Iain Merrick hu...@google.com on 2011-11-16
Reviewed by Tony Gentilcore.
Source/WebCore:
* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
(WebCore::screenRefreshRate):
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):
Source/WebKit/chromium:
* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::screenRefreshRate):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformScreen.h
trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebScreenInfo.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100437 => 100438)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 14:03:42 UTC (rev 100437)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 14:04:57 UTC (rev 100438)
@@ -1,3 +1,19 @@
+2011-11-16 Iain Merrick hu...@google.com
+
+[chromium] Pass screen refresh rate into compositor.
+https://bugs.webkit.org/show_bug.cgi?id=71040
+
+Reviewed by Tony Gentilcore.
+
+* platform/PlatformScreen.h:
+* platform/chromium/PlatformScreenChromium.cpp:
+(WebCore::screenRefreshRate):
+* platform/chromium/PlatformSupport.h:
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCSettings::CCSettings):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::initializeImplOnImplThread):
+
2011-11-15 Andrey Kosyakov ca...@chromium.org
Web Inspector: [Extensions API] drop ExtensionSidebarPane.onUpdated, use callbacks instead
Modified: trunk/Source/WebCore/platform/PlatformScreen.h (100437 => 100438)
--- trunk/Source/WebCore/platform/PlatformScreen.h 2011-11-16 14:03:42 UTC (rev 100437)
+++ trunk/Source/WebCore/platform/PlatformScreen.h 2011-11-16 14:04:57 UTC (rev 100438)
@@ -54,6 +54,11 @@
FloatRect screenRect(Widget*);
FloatRect screenAvailableRect(Widget*);
+#if PLATFORM(CHROMIUM)
+// Measured in frames per second. 0 if the refresh rate is unknown, or not applicable.
+double screenRefreshRate(Widget*);
+#endif
+
#if PLATFORM(MAC)
NSScreen *screenForWindow(NSWindow *);
Modified: trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp (100437 => 100438)
--- trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp 2011-11-16 14:03:42 UTC (rev 100437)
+++ trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp 2011-11-16 14:04:57 UTC (rev 100438)
@@ -61,4 +61,9 @@
return PlatformSupport::screenAvailableRect(widget);
}
+double screenRefreshRate(Widget* widget)
+{
+return PlatformSupport::screenRefreshRate(widget);
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (100437 => 100438)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-11-16 14:03:42 UTC (rev 100437)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-11-16 14:04:57 UTC (rev 100438)
@@ -234,6 +234,7 @@
static bool screenIsMonochrome(Widget*);
static IntRect screenRect(Widget*);
static IntRect screenAvailableRect(Widget*);
+static double screenRefreshRate(Widget*);
// SharedTimers ---
static void setSharedTimerFiredFunction(void (*func)());
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (100437 => 100438)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-11-16 14:03:42 UTC (rev 100437)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-11-16 14:04:57 UTC (rev 100438)
@@ -73,13 +73,15 @@
, compositeOffscreen(false)
, enableCompositorThread(false)
, showFPSCounter(false)
-, showPlatformLayerTree(false) { }
+, showPlatformLayerTree(false)
+, refreshRate(0) { }
bool acceleratePainting;
bool compositeOffscreen;
bool enableCompositorThread;
bool showFPSCounter;
bool showPlatformLayerTree;
+double refreshRate;
};
[webkit-changes] [100439] trunk/LayoutTests
Title: [100439] trunk/LayoutTests
Revision 100439
Author ca...@chromium.org
Date 2011-11-16 06:08:28 -0800 (Wed, 16 Nov 2011)
Log Message
Layout Test inspector/extensions/extensions-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72447
Reviewed by Yury Semikhatsky.
* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/extensions/extensions-events-expected.txt
trunk/LayoutTests/inspector/extensions/extensions-events.html
trunk/LayoutTests/platform/chromium/test_expectations.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100438 => 100439)
--- trunk/LayoutTests/ChangeLog 2011-11-16 14:04:57 UTC (rev 100438)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 14:08:28 UTC (rev 100439)
@@ -1,3 +1,14 @@
+2011-11-16 Andrey Kosyakov ca...@chromium.org
+
+Layout Test inspector/extensions/extensions-events.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=72447
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/extensions/extensions-events-expected.txt:
+* inspector/extensions/extensions-events.html:
+* platform/chromium/test_expectations.txt:
+
2011-11-16 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening after r100281.
Modified: trunk/LayoutTests/inspector/extensions/extensions-events-expected.txt (100438 => 100439)
--- trunk/LayoutTests/inspector/extensions/extensions-events-expected.txt 2011-11-16 14:04:57 UTC (rev 100438)
+++ trunk/LayoutTests/inspector/extensions/extensions-events-expected.txt 2011-11-16 14:08:28 UTC (rev 100439)
@@ -14,6 +14,8 @@
RUNNING TEST: extension_testTimelineEvents
Got Layout event from timeline
RUNNING TEST: extension_testViewShowHide
+Got onShown event for sidebar
+Sidebar shown, location: .../extension-sidebar.html
Got onHidden event for sidebar
Got onShown event for panel
Panel shown, location: .../extension-panel.html
Modified: trunk/LayoutTests/inspector/extensions/extensions-events.html (100438 => 100439)
--- trunk/LayoutTests/inspector/extensions/extensions-events.html 2011-11-16 14:04:57 UTC (rev 100438)
+++ trunk/LayoutTests/inspector/extensions/extensions-events.html 2011-11-16 14:08:28 UTC (rev 100439)
@@ -67,6 +67,7 @@
{
var listenersToCleanup = [];
var sidebar;
+var beenToExtensionPanel = false;
function onViewEvent(type, viewName, viewWindow)
{
@@ -75,12 +76,16 @@
return;
if (viewName === panel) {
output(Panel shown, location: + trimURL(viewWindow.location.href));
-addListener(sidebar, sidebar, onShown);
extension_showPanel(elements);
} else if (viewName === sidebar) {
output(Sidebar shown, location: + trimURL(viewWindow.location.href));
-cleanupListeners();
-nextTest();
+if (!beenToExtensionPanel) {
+extension_showPanel(extension);
+beenToExtensionPanel = true;
+} else {
+cleanupListeners();
+nextTest();
+}
}
}
function addListener(view, viewName, type)
@@ -100,8 +105,8 @@
addListener(panel, panel, onShown);
addListener(panel, panel, onHidden);
addListener(sidebar, sidebar, onHidden);
+addListener(sidebar, sidebar, onShown);
sidebar.setPage(basePath + extension-sidebar.html);
-extension_showPanel(extension);
}
extension_showPanel(elements);
var basePath = location.pathname.replace(/\/[^/]*$/, /);
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100438 => 100439)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 14:04:57 UTC (rev 100438)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 14:08:28 UTC (rev 100439)
@@ -3911,8 +3911,6 @@
BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS
-BUGWK72447 : inspector/extensions/extensions-events.html = TEXT PASS TIMEOUT
-
BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS
BUGWK72487 MAC : compositing/layers-inside-overflow-scroll.html = IMAGE
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100440] trunk
Title: [100440] trunk Revision 100440 Author ves...@webkit.org Date 2011-11-16 06:17:24 -0800 (Wed, 16 Nov 2011) Log Message Fix path to module file in root project file Reviewed by Simon Hausmann. * WebKit.pro: Modified Paths trunk/ChangeLog trunk/WebKit.pro Diff Modified: trunk/ChangeLog (100439 => 100440) --- trunk/ChangeLog 2011-11-16 14:08:28 UTC (rev 100439) +++ trunk/ChangeLog 2011-11-16 14:17:24 UTC (rev 100440) @@ -1,3 +1,11 @@ +2011-11-16 Tor Arne Vestbø tor.arne.ves...@nokia.com + +Fix path to module file in root project file + +Reviewed by Simon Hausmann. + +* WebKit.pro: + 2011-11-16 Simon Hausmann simon.hausm...@nokia.com Unreviewed, rolling out r100266. Modified: trunk/WebKit.pro (100439 => 100440) --- trunk/WebKit.pro 2011-11-16 14:08:28 UTC (rev 100439) +++ trunk/WebKit.pro 2011-11-16 14:17:24 UTC (rev 100440) @@ -39,7 +39,7 @@ OTHER_FILES = \ Tools/qmake/README \ -Tools/qmake/qt_webkit.pri \ +Tools/qmake/mkspecs/modules/qt_webkit.pri \ Tools/qmake/mkspecs/features/*.prf \ Tools/qmake/mkspecs/features/mac/*.prf \ Tools/qmake/mkspecs/features/unix/*.prf \ ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100441] trunk
Title: [100441] trunk
Revision 100441
Author hausm...@webkit.org
Date 2011-11-16 06:20:33 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Reviewed by Tor Arne Vestbø.
.:
* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Source/_javascript_Core:
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Source/WebCore:
* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
Tools:
* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
magic here where we handle all TEMPLATE = lib .pro files.
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/api.pri
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/Target.pri
trunk/Tools/qmake/mkspecs/features/default_post.prf
Diff
Modified: trunk/ChangeLog (100440 => 100441)
--- trunk/ChangeLog 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/ChangeLog 2011-11-16 14:20:33 UTC (rev 100441)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Source/api.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-16 Tor Arne Vestbø tor.arne.ves...@nokia.com
Fix path to module file in root project file
Modified: trunk/Source/_javascript_Core/ChangeLog (100440 => 100441)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 14:20:33 UTC (rev 100441)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-16 Simon Hausmann simon.hausm...@nokia.com
Unreviewed, rolling out r100266.
Modified: trunk/Source/_javascript_Core/Target.pri (100440 => 100441)
--- trunk/Source/_javascript_Core/Target.pri 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Source/_javascript_Core/Target.pri 2011-11-16 14:20:33 UTC (rev 100441)
@@ -20,9 +20,6 @@
QT += core
QT -= gui
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
-
*-g++*:QMAKE_CXXFLAGS_RELEASE -= -O2
*-g++*:QMAKE_CXXFLAGS_RELEASE += -O3
Modified: trunk/Source/WebCore/ChangeLog (100440 => 100441)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 14:20:33 UTC (rev 100441)
@@ -1,3 +1,11 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* Target.pri: Eliminate duplicated symbol stuff that lives now in default_post.prf.
+
2011-11-16 Iain Merrick hu...@google.com
[chromium] Pass screen refresh rate into compositor.
Modified: trunk/Source/WebCore/Target.pri (100440 => 100441)
--- trunk/Source/WebCore/Target.pri 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Source/WebCore/Target.pri 2011-11-16 14:20:33 UTC (rev 100441)
@@ -18,8 +18,6 @@
DEFINES += QT_MAKEDLL
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-
haveQt(5) {
# Add a QtScript dependency for the time being, in order to pull in the include
# path for QtScript when it's built as a standalone module
Modified: trunk/Source/api.pri (100440 => 100441)
--- trunk/Source/api.pri 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Source/api.pri 2011-11-16 14:20:33 UTC (rev 100441)
@@ -35,11 +35,6 @@
contains(DEFINES, ENABLE_WEBGL=1)|contains(CONFIG, texmap): LIBS += $$QMAKE_LIBS_OPENGL
}
-CONFIG(release) {
-contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
-unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
-}
-
!static: DEFINES += QT_MAKEDLL
SOURCES += \
Modified: trunk/Tools/ChangeLog (100440 => 100441)
--- trunk/Tools/ChangeLog 2011-11-16 14:17:24 UTC (rev 100440)
+++ trunk/Tools/ChangeLog 2011-11-16 14:20:33 UTC (rev 100441)
@@ -1,3 +1,14 @@
+2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
+magic here where we
[webkit-changes] [100442] trunk/LayoutTests
Title: [100442] trunk/LayoutTests Revision 100442 Author o...@webkit.org Date 2011-11-16 06:28:05 -0800 (Wed, 16 Nov 2011) Log Message Unreviewed, rolling out r100281 and r100437. http://trac.webkit.org/changeset/100281 http://trac.webkit.org/changeset/100437 https://bugs.webkit.org/show_bug.cgi?id=72496 It made all plugin tests fail with paralel NRWT (Requested by ossy on #webkit). Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-16 * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100441 => 100442) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:20:33 UTC (rev 100441) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:28:05 UTC (rev 100442) @@ -1,3 +1,15 @@ +2011-11-16 Sheriff Bot webkit.review@gmail.com + +Unreviewed, rolling out r100281 and r100437. +http://trac.webkit.org/changeset/100281 +http://trac.webkit.org/changeset/100437 +https://bugs.webkit.org/show_bug.cgi?id=72496 + +It made all plugin tests fail with paralel NRWT (Requested by +ossy on #webkit). + +* platform/qt/Skipped: + 2011-11-16 Andrey Kosyakov ca...@chromium.org Layout Test inspector/extensions/extensions-events.html is flaky Modified: trunk/LayoutTests/platform/qt/Skipped (100441 => 100442) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:20:33 UTC (rev 100441) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:28:05 UTC (rev 100442) @@ -260,6 +260,7 @@ http/tests/local/drag-over-remote-content.html http/tests/local/fileapi http/tests/security/drag-drop-same-unique-origin.html +http/tests/misc/drag-not-loaded-image.html # [Qt] DumpRenderTree needs a beginDragWithFiles implementation # https://bugs.webkit.org/show_bug.cgi?id=50902 @@ -335,6 +336,9 @@ fast/events/dropzone-003.html fast/events/dropzone-004.html +# caused by: http://trac.webkit.org/changeset/52192 +http/tests/misc/drag-over-iframe-invalid-source-crash.html + # Missing eventSender.beginDragWithFiles() fast/dom/Window/window-postmessage-clone-frames.html @@ -357,6 +361,10 @@ # no expected results http/tests/misc/favicon-as-image.html +# https://bugs.webkit.org/show_bug.cgi?id=34004 +# [Qt] http/tests/misc/slow-loading-mask.html timed out. +http/tests/misc/slow-loading-mask.html + # No authentication challenge handling http/tests/loading/basic-credentials-sent-automatically.html http/tests/loading/basic-auth-resend-wrong-credentials.html @@ -399,6 +407,7 @@ # Caused by the way Qt caches network connections using user@hostname as the key # See https://bugs.webkit.org/show_bug.cgi?id=37084 and http://bugreports.qt.nokia.com/browse/QTBUG-9619 # Fixed in Qt 4.8 +http/tests/xmlhttprequest/re-login-async.html http/tests/xmlhttprequest/re-login.html # Still fail with Qt 4.7.1 @@ -508,6 +517,9 @@ fast/frames/sandboxed-iframe-scripting.html fast/frames/sandboxed-iframe-storage.html http/tests/cookies/simple-cookies-max-age.html +http/tests/cookies/simple-cookies-expired.html +http/tests/xmlhttprequest/workers/close.html +http/tests/xmlhttprequest/workers/shared-worker-close.html transitions/change-values-during-transition.html @@ -526,6 +538,7 @@ inspector/styles/styles-add-blank-property.html # [Qt] New fails caused by change(s) between r79317-r79320. +http/tests/inspector/change-iframe-src.html inspector/debugger/open-close-open.html # [Qt] fast/frames/flattening/frameset-flattening-subframesets.html fails intermittently on Qt bot @@ -728,6 +741,11 @@ # https://bugs.webkit.org/show_bug.cgi?id=58396 http/tests/misc/favicon-loads-with-icon-loading-override.html +# Missing layoutTestController.setAlwaysAcceptCookies - implemented for Qt version = 4.8 +http/tests/security/cookies/third-party-cookie-blocking-main-frame.html +http/tests/security/cookies/third-party-cookie-blocking-user-action.html +http/tests/security/cookies/third-party-cookie-blocking.html + # = # # Failing SVG tests # = # @@ -1665,8 +1683,11 @@ # Support for third-party cookie blocking # https://bugs.webkit.org/show_bug.cgi?id=45455 # See also http://bugreports.qt.nokia.com/browse/QTBUG-13601 +http/tests/cookies/third-party-cookie-relaxing.html +http/tests/xmlhttprequest/cross-origin-cookie-storage.html +http/tests/xmlhttprequest/access-control-basic-allow-preflight-cache-timeout.html +http/tests/plugins/third-party-cookie-accept-policy.html platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html -http/tests/plugins/third-party-cookie-accept-policy.html # = # # new skipped tests yet to be sorted @@ -1687,7 +1708,9 @@ # Web Timing related bugs # https://bugs.webkit.org/show_bug.cgi?id=51245
[webkit-changes] [100443] trunk/LayoutTests
Title: [100443] trunk/LayoutTests Revision 100443 Author rga...@webkit.org Date 2011-11-16 06:42:14 -0800 (Wed, 16 Nov 2011) Log Message [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 https://bugs.webkit.org/show_bug.cgi?id=72493 [Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 https://bugs.webkit.org/show_bug.cgi?id=72491 Unreviewed gardening. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100442 => 100443) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:28:05 UTC (rev 100442) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:42:14 UTC (rev 100443) @@ -1,3 +1,15 @@ +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + +[Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 +https://bugs.webkit.org/show_bug.cgi?id=72493 + +[Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 +https://bugs.webkit.org/show_bug.cgi?id=72491 + +Unreviewed gardening. + +* platform/qt/Skipped: + 2011-11-16 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r100281 and r100437. Modified: trunk/LayoutTests/platform/qt/Skipped (100442 => 100443) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:28:05 UTC (rev 100442) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 14:42:14 UTC (rev 100443) @@ -2526,3 +2526,11 @@ # [Qt] new test css3/flexbox/line-wrapping.html failing # https://bugs.webkit.org/show_bug.cgi?id=72490 css3/flexbox/line-wrapping.html + +# [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 +# https://bugs.webkit.org/show_bug.cgi?id=72493 +inspector/extensions/extensions-sidebar.html + +# [Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 +# https://bugs.webkit.org/show_bug.cgi?id=72491 +http/tests/misc/onload-remove-iframe-crash-2.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100444] trunk/LayoutTests
Title: [100444] trunk/LayoutTests Revision 100444 Author rga...@webkit.org Date 2011-11-16 06:54:01 -0800 (Wed, 16 Nov 2011) Log Message [Qt] Skip new failing tests. Unreviewed gardening. * platform/qt-mac/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-mac/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100443 => 100444) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:42:14 UTC (rev 100443) +++ trunk/LayoutTests/ChangeLog 2011-11-16 14:54:01 UTC (rev 100444) @@ -1,5 +1,13 @@ 2011-11-16 Gabor Rapcsanyi rga...@webkit.org +[Qt] Skip new failing tests. + +Unreviewed gardening. + +* platform/qt-mac/Skipped: + +2011-11-16 Gabor Rapcsanyi rga...@webkit.org + [Qt] new test inspector/extensions/extensions-sidebar.html crashing after r100433 https://bugs.webkit.org/show_bug.cgi?id=72493 Modified: trunk/LayoutTests/platform/qt-mac/Skipped (100443 => 100444) --- trunk/LayoutTests/platform/qt-mac/Skipped 2011-11-16 14:42:14 UTC (rev 100443) +++ trunk/LayoutTests/platform/qt-mac/Skipped 2011-11-16 14:54:01 UTC (rev 100444) @@ -5219,3 +5219,37 @@ svg/as-image/svg-image-change-content-size.xhtml svg/as-object/svg-embedded-in-html-in-iframe.html svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html + +# crashing tests +canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html +http/tests/misc/onload-remove-iframe-crash-2.html +fast/canvas/2d.text.draw.fill.maxWidth.negative.html +fast/canvas/2d.text.draw.fill.maxWidth.verySmall.html + +# new failing tests +css2.1/20110323/border-spacing-applies-to-015.htm +css2.1/20110323/table-caption-001.htm +css2.1/20110323/table-caption-002.htm +css2.1/20110323/table-caption-horizontal-alignment-001.htm +css2.1/20110323/table-caption-margins-001.htm +css2.1/20110323/table-caption-optional-001.htm +css2.1/20110323/table-caption-optional-002.htm +fast/dom/rtl-scroll-to-leftmost-and-resize.html +fast/multicol/pagination-h-horizontal-bt.html +fast/multicol/pagination-h-horizontal-tb.html +fast/multicol/pagination-h-vertical-lr.html +fast/multicol/pagination-h-vertical-rl.html +fast/multicol/pagination-v-horizontal-bt.html +fast/multicol/pagination-v-horizontal-tb.html +fast/multicol/pagination-v-vertical-lr.html +fast/multicol/pagination-v-vertical-rl.html +http/tests/security/contentSecurityPolicy/policy-does-not-affect-child.html +svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size.html +svg/as-image/animated-svg-as-image-same-image.html +svg/foreignObject/background-render-phase.html +svg/foreignObject/clip.html +svg/foreignObject/filter.html +svg/foreignObject/mask.html +svg/foreignObject/multiple-foreign-objects.html +svg/zoom/page/zoom-background-images.html +svg/zoom/page/zoom-svg-as-background-with-relative-size.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100445] trunk/Source/WebKit2
Title: [100445] trunk/Source/WebKit2 Revision 100445 Author zeno.albis...@nokia.com Date 2011-11-16 06:56:11 -0800 (Wed, 16 Nov 2011) Log Message [Qt][WK2][Mac] MiniBrowser cannot create socketpair. https://bugs.webkit.org/show_bug.cgi?id=72389 Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET. Reviewed by Tor Arne Vestbø. * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (100444 => 100445) --- trunk/Source/WebKit2/ChangeLog 2011-11-16 14:54:01 UTC (rev 100444) +++ trunk/Source/WebKit2/ChangeLog 2011-11-16 14:56:11 UTC (rev 100445) @@ -1,3 +1,14 @@ +2011-11-16 Zeno Albisser z...@webkit.org + +[Qt][WK2][Mac] MiniBrowser cannot create socketpair. +https://bugs.webkit.org/show_bug.cgi?id=72389 + +Use SOCK_DGRAM on mac instead of SOCK_SEQPACKET. + +Reviewed by Tor Arne Vestbø. + +* UIProcess/Launcher/qt/ProcessLauncherQt.cpp: + 2011-11-15 Carlos Garcia Campos cgar...@igalia.com [GTK] Add webkit_web_view_load_request() to WebKit2 GTK+ API Modified: trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp (100444 => 100445) --- trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp 2011-11-16 14:54:01 UTC (rev 100444) +++ trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp 2011-11-16 14:56:11 UTC (rev 100445) @@ -55,7 +55,7 @@ #include signal.h #endif -#ifdef SOCK_SEQPACKET +#if defined(SOCK_SEQPACKET) !defined(Q_OS_MACX) #define SOCKET_TYPE SOCK_SEQPACKET #else #define SOCKET_TYPE SOCK_DGRAM ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100446] trunk/LayoutTests
Title: [100446] trunk/LayoutTests Revision 100446 Author stevebl...@google.com Date 2011-11-16 07:00:10 -0800 (Wed, 16 Nov 2011) Log Message Layout Test inspector/styles/svg-style.xhtml is flaky https://bugs.webkit.org/show_bug.cgi?id=72434 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100445 => 100446) --- trunk/LayoutTests/ChangeLog 2011-11-16 14:56:11 UTC (rev 100445) +++ trunk/LayoutTests/ChangeLog 2011-11-16 15:00:10 UTC (rev 100446) @@ -1,3 +1,12 @@ +2011-11-16 Steve Block stevebl...@google.com + +Layout Test inspector/styles/svg-style.xhtml is flaky +https://bugs.webkit.org/show_bug.cgi?id=72434 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + 2011-11-16 Gabor Rapcsanyi rga...@webkit.org [Qt] Skip new failing tests. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100445 => 100446) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 14:56:11 UTC (rev 100445) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 15:00:10 UTC (rev 100446) @@ -3909,7 +3909,7 @@ BUGWK72376 WIN : fast/forms/file/input-file-label.html = TEXT PASS -BUGWK72434 : inspector/styles/svg-style.xhtml = TEXT PASS +BUGWK72434 : inspector/styles/svg-style.xhtml = PASS TEXT TIMEOUT BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100447] trunk/Source/WebCore
Title: [100447] trunk/Source/WebCore Revision 100447 Author commit-qu...@webkit.org Date 2011-11-16 07:04:58 -0800 (Wed, 16 Nov 2011) Log Message Remove unnecessary if check from RenderListBox::paintItemForeground. https://bugs.webkit.org/show_bug.cgi?id=72488 Patch by Antaryami Pandia antaryami.pan...@motorola.com on 2011-11-16 Reviewed by Andreas Kling. * rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderListBox.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100446 => 100447) --- trunk/Source/WebCore/ChangeLog 2011-11-16 15:00:10 UTC (rev 100446) +++ trunk/Source/WebCore/ChangeLog 2011-11-16 15:04:58 UTC (rev 100447) @@ -1,3 +1,13 @@ +2011-11-16 Antaryami Pandia antaryami.pan...@motorola.com + +Remove unnecessary if check from RenderListBox::paintItemForeground. +https://bugs.webkit.org/show_bug.cgi?id=72488 + +Reviewed by Andreas Kling. + +* rendering/RenderListBox.cpp: +(WebCore::RenderListBox::paintItemForeground): + 2011-11-15 Simon Hausmann simon.hausm...@nokia.com [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions Modified: trunk/Source/WebCore/rendering/RenderListBox.cpp (100446 => 100447) --- trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-11-16 15:00:10 UTC (rev 100446) +++ trunk/Source/WebCore/rendering/RenderListBox.cpp 2011-11-16 15:04:58 UTC (rev 100447) @@ -420,8 +420,7 @@ } // Draw the item text -if (itemStyle-visibility() != HIDDEN) -paintInfo.context-drawBidiText(itemFont, textRun, r.location()); +paintInfo.context-drawBidiText(itemFont, textRun, r.location()); } void RenderListBox::paintItemBackground(PaintInfo paintInfo, const LayoutPoint paintOffset, int listIndex) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100449] trunk/Source/WebCore
Title: [100449] trunk/Source/WebCore
Revision 100449
Author commit-qu...@webkit.org
Date 2011-11-16 07:49:12 -0800 (Wed, 16 Nov 2011)
Log Message
CSSValue: Clean up initial value construction.
http://webkit.org/b/72502
Patch by Andreas Kling kl...@webkit.org on 2011-11-16
Reviewed by Antti Koivisto.
Instead of determining whether a given CSSInitialValue is 'implicit' or not by
querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
add a protected CSSValue member and set it from the CSSInitialValue constructor.
Also get rid of the CSSValue::m_isInitial bit since we can now replace the
checks by classType() == InitialClass.
No new tests, this is a cleanup.
* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):
Poke 'implicit' constructor argument into CSSValue::m_isImplicit.
* css/CSSValue.cpp:
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
Remove ImplicitInitialClass cases.
* css/CSSValue.h:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::CSSValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSInitialValue.h
trunk/Source/WebCore/css/CSSValue.cpp
trunk/Source/WebCore/css/CSSValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (100448 => 100449)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 15:12:30 UTC (rev 100448)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 15:49:12 UTC (rev 100449)
@@ -1,3 +1,35 @@
+2011-11-16 Andreas Kling kl...@webkit.org
+
+CSSValue: Clean up initial value construction.
+http://webkit.org/b/72502
+
+Reviewed by Antti Koivisto.
+
+Instead of determining whether a given CSSInitialValue is 'implicit' or not by
+querying the CSSValue::ClassType (InitialClass vs. ImplicitInitialClass),
+add a protected CSSValue member and set it from the CSSInitialValue constructor.
+
+Also get rid of the CSSValue::m_isInitial bit since we can now replace the
+checks by classType() == InitialClass.
+
+No new tests, this is a cleanup.
+
+* css/CSSInitialValue.h:
+(WebCore::CSSInitialValue::CSSInitialValue):
+
+Poke 'implicit' constructor argument into CSSValue::m_isImplicit.
+
+* css/CSSValue.cpp:
+(WebCore::CSSValue::cssText):
+(WebCore::CSSValue::destroy):
+
+Remove ImplicitInitialClass cases.
+
+* css/CSSValue.h:
+(WebCore::CSSValue::isImplicitInitialValue):
+(WebCore::CSSValue::isInitialValue):
+(WebCore::CSSValue::CSSValue):
+
2011-11-16 Antaryami Pandia antaryami.pan...@motorola.com
Remove unnecessary if check from RenderListBox::paintItemForeground.
Modified: trunk/Source/WebCore/css/CSSInitialValue.h (100448 => 100449)
--- trunk/Source/WebCore/css/CSSInitialValue.h 2011-11-16 15:12:30 UTC (rev 100448)
+++ trunk/Source/WebCore/css/CSSInitialValue.h 2011-11-16 15:49:12 UTC (rev 100449)
@@ -43,8 +43,9 @@
private:
CSSInitialValue(bool implicit)
-: CSSValue(implicit ? ImplicitInitialClass : InitialClass)
+: CSSValue(InitialClass)
{
+m_isImplicit = implicit;
}
static PassRefPtrCSSInitialValue create(bool implicit)
Modified: trunk/Source/WebCore/css/CSSValue.cpp (100448 => 100449)
--- trunk/Source/WebCore/css/CSSValue.cpp 2011-11-16 15:12:30 UTC (rev 100448)
+++ trunk/Source/WebCore/css/CSSValue.cpp 2011-11-16 15:49:12 UTC (rev 100449)
@@ -120,7 +120,6 @@
case InheritedClass:
return static_castconst CSSInheritedValue*(this)-customCssText();
case InitialClass:
-case ImplicitInitialClass:
return static_castconst CSSInitialValue*(this)-customCssText();
case PrimitiveClass:
return static_castconst CSSPrimitiveValue*(this)-customCssText();
@@ -212,7 +211,6 @@
delete static_castCSSInheritedValue*(this);
return;
case InitialClass:
-case ImplicitInitialClass:
delete static_castCSSInitialValue*(this);
return;
case PrimitiveClass:
Modified: trunk/Source/WebCore/css/CSSValue.h (100448 => 100449)
--- trunk/Source/WebCore/css/CSSValue.h 2011-11-16 15:12:30 UTC (rev 100448)
+++ trunk/Source/WebCore/css/CSSValue.h 2011-11-16 15:49:12 UTC (rev 100449)
@@ -58,7 +58,6 @@
bool isPrimitiveValue() const { return m_isPrimitive; }
bool isValueList() const { return m_isList; }
-bool isInitialValue() const { return m_isInitial; }
bool isInheritedValue() const { return m_isInherited; }
bool isBorderImageValue() const { return m_classType == BorderImageClass; }
@@ -69,7 +68,8 @@
bool isFontValue() const { return m_classType == FontClass; }
bool isImageGeneratorValue() const { return m_classType == CanvasClass || m_classType == CrossfadeClass || m_classType == LinearGradientClass || m_classType == RadialGradientClass; }
bool isImageValue() const { return m_classType == ImageClass || m_classType
[webkit-changes] [100450] trunk/LayoutTests
Title: [100450] trunk/LayoutTests Revision 100450 Author kbal...@webkit.org Date 2011-11-16 07:52:43 -0800 (Wed, 16 Nov 2011) Log Message [Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing https://bugs.webkit.org/show_bug.cgi?id=72504 Unreviewed gardening. Skip crashing test. * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100449 => 100450) --- trunk/LayoutTests/ChangeLog 2011-11-16 15:49:12 UTC (rev 100449) +++ trunk/LayoutTests/ChangeLog 2011-11-16 15:52:43 UTC (rev 100450) @@ -1,3 +1,12 @@ +2011-11-16 Balazs Kelemen kbal...@webkit.org + +[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing +https://bugs.webkit.org/show_bug.cgi?id=72504 + +Unreviewed gardening. Skip crashing test. + +* platform/qt/Skipped: + 2011-11-16 Steve Block stevebl...@google.com Layout Test inspector/styles/svg-style.xhtml is flaky Modified: trunk/LayoutTests/platform/qt/Skipped (100449 => 100450) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 15:49:12 UTC (rev 100449) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 15:52:43 UTC (rev 100450) @@ -2534,3 +2534,7 @@ # [Qt] http/tests/misc/onload-remove-iframe-crash-2.html crashing after r100311 # https://bugs.webkit.org/show_bug.cgi?id=72491 http/tests/misc/onload-remove-iframe-crash-2.html + +# [Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing +# https://bugs.webkit.org/show_bug.cgi?id=72504 +inspector/elements/elements-panel-selection-on-refresh.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100451] trunk/LayoutTests
Title: [100451] trunk/LayoutTests
Revision 100451
Author apav...@chromium.org
Date 2011-11-16 07:57:02 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, test fix after http://trac.webkit.org/changeset/100273.
font property is no longer mapped to DOMCSSValue, so use font-family mapped to DOMCSSValueList instead.
* platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
* platform/mac/plugins/jsobjc-dom-wrappers.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers-expected.txt
trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100450 => 100451)
--- trunk/LayoutTests/ChangeLog 2011-11-16 15:52:43 UTC (rev 100450)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 15:57:02 UTC (rev 100451)
@@ -1,3 +1,12 @@
+2011-11-16 Alexander Pavlov apav...@chromium.org
+
+Unreviewed, test fix after http://trac.webkit.org/changeset/100273.
+
+font property is no longer mapped to DOMCSSValue, so use font-family mapped to DOMCSSValueList instead.
+
+* platform/mac/plugins/jsobjc-dom-wrappers-expected.txt:
+* platform/mac/plugins/jsobjc-dom-wrappers.html:
+
2011-11-16 Balazs Kelemen kbal...@webkit.org
[Qt] inspector/elements/elements-panel-selection-on-refresh.html crashing
Modified: trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers-expected.txt (100450 => 100451)
--- trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers-expected.txt 2011-11-16 15:52:43 UTC (rev 100450)
+++ trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers-expected.txt 2011-11-16 15:57:02 UTC (rev 100451)
@@ -14,6 +14,6 @@
document.styleSheets[0].cssRules[0].style == DOMCSSStyleDeclaration ? - PASS
-document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(font) == DOMCSSValue ? - PASS
+document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(font-family) == DOMCSSValueList ? - PASS
document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(width) == DOMCSSPrimitiveValue ? - PASS
Modified: trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers.html (100450 => 100451)
--- trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers.html 2011-11-16 15:52:43 UTC (rev 100450)
+++ trunk/LayoutTests/platform/mac/plugins/jsobjc-dom-wrappers.html 2011-11-16 15:57:02 UTC (rev 100451)
@@ -1,7 +1,7 @@
html
headtitle wrappers.html /title
style
-BODY { font: 11px 'Lucida Grande'; width: 90%; padding: 10px; }
+BODY { font-family: 'Lucida Grande'; width: 90%; padding: 10px; }
.box { border: 1px solid gray; background-color: #EEE; margin: 10px; }
/style
script
@@ -33,7 +33,7 @@
check('document.styleSheets[0].cssRules', 'DOMCSSRuleList');
check('document.styleSheets[0].cssRules[0]', 'DOMCSSStyleRule');
check('document.styleSheets[0].cssRules[0].style', 'DOMCSSStyleDeclaration');
-check('document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(font)', 'DOMCSSValue');
+check('document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(font-family)', 'DOMCSSValueList');
check('document.styleSheets[0].cssRules[0].style.getPropertyCSSValue(width)', 'DOMCSSPrimitiveValue');
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100452] trunk
Title: [100452] trunk
Revision 100452
Author commit-qu...@webkit.org
Date 2011-11-16 07:58:42 -0800 (Wed, 16 Nov 2011)
Log Message
[EFL] Clean up the offline apps-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72132
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.
`ewk_settings_cache' and `ewk_view_setting_cache' are too common
prefixes for code that is related only to the HTML5 app cache
features.
Use `ewk_settings_application_cache' and
`ewk_view_setting_application_cache' instead.
Source/WebKit/efl:
While here, improve the documentation and use a more common naming
scheme for the static variable which holds the cache path.
* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.cpp:
(ewk_settings_application_cache_path_set):
(ewk_settings_application_cache_path_get):
* ewk/ewk_settings.h:
* ewk/ewk_view.cpp:
(ewk_view_setting_application_cache_get):
(ewk_view_setting_application_cache_set):
* ewk/ewk_view.h:
Tools:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_main.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.h
trunk/Source/WebKit/efl/ewk/ewk_view.cpp
trunk/Source/WebKit/efl/ewk/ewk_view.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (100451 => 100452)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-16 15:57:02 UTC (rev 100451)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-16 15:58:42 UTC (rev 100452)
@@ -1,3 +1,31 @@
+2011-11-16 Raphael Kubo da Costa k...@profusion.mobi
+
+[EFL] Clean up the offline apps-related functions in ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72132
+
+Reviewed by Kenneth Rohde Christiansen.
+
+`ewk_settings_cache' and `ewk_view_setting_cache' are too common
+prefixes for code that is related only to the HTML5 app cache
+features.
+
+Use `ewk_settings_application_cache' and
+`ewk_view_setting_application_cache' instead.
+
+While here, improve the documentation and use a more common naming
+scheme for the static variable which holds the cache path.
+
+* ewk/ewk_main.cpp:
+(_ewk_init_body):
+* ewk/ewk_settings.cpp:
+(ewk_settings_application_cache_path_set):
+(ewk_settings_application_cache_path_get):
+* ewk/ewk_settings.h:
+* ewk/ewk_view.cpp:
+(ewk_view_setting_application_cache_get):
+(ewk_view_setting_application_cache_set):
+* ewk/ewk_view.h:
+
2011-11-15 Anders Carlsson ander...@apple.com
HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
Modified: trunk/Source/WebKit/efl/ewk/ewk_main.cpp (100451 => 100452)
--- trunk/Source/WebKit/efl/ewk/ewk_main.cpp 2011-11-16 15:57:02 UTC (rev 100451)
+++ trunk/Source/WebKit/efl/ewk/ewk_main.cpp 2011-11-16 15:58:42 UTC (rev 100452)
@@ -182,7 +182,7 @@
WTF::String webkitDirectory = home + /.webkit;
if (WebCore::makeAllDirectories(webkitDirectory)) {
ewk_settings_web_database_path_set(webkitDirectory.utf8().data());
-ewk_settings_cache_directory_path_set(webkitDirectory.utf8().data());
+ewk_settings_application_cache_path_set(webkitDirectory.utf8().data());
}
// TODO: this should move to WebCore, already reported to webkit-gtk folks:
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (100451 => 100452)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 15:57:02 UTC (rev 100451)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 15:58:42 UTC (rev 100452)
@@ -46,7 +46,7 @@
#include wtf/text/CString.h
#include wtf/text/StringConcatenate.h
-static const char* _ewk_cache_directory_path = 0;
+static const char* s_offlineAppCachePath = 0;
static const char* _ewk_icon_database_path = 0;
#if ENABLE(SQL_DATABASE)
@@ -243,20 +243,15 @@
return eina_stringshare_add(staticUa.utf8().data());
}
-Eina_Bool ewk_settings_cache_directory_path_set(const char* path)
+void ewk_settings_application_cache_path_set(const char* path)
{
-if (!path)
-return false;
-
WebCore::cacheStorage().setCacheDirectory(WTF::String::fromUTF8(path));
-eina_stringshare_replace(_ewk_cache_directory_path, path);
-
-return true;
+eina_stringshare_replace(s_offlineAppCachePath, path);
}
-const char* ewk_settings_cache_directory_path_get()
+const char* ewk_settings_application_cache_path_get()
{
-return _ewk_cache_directory_path;
+return s_offlineAppCachePath;
}
double ewk_settings_default_timer_interval_get(void)
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (100451 => 100452)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.h 2011-11-16 15:57:02 UTC (rev
[webkit-changes] [100453] trunk
Title: [100453] trunk
Revision 100453
Author eric.carl...@apple.com
Date 2011-11-16 08:05:45 -0800 (Wed, 16 Nov 2011)
Log Message
addTrack() must throw an exception if 'kind' is unknown
https://bugs.webkit.org/show_bug.cgi?id=71915
Reviewed by Philippe Normand.
Source/WebCore:
Tests: media/track/track-addtrack-kind.html
media/track/track-kind.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackKindChanged): New. Will be implemented for 62885.
(WebCore::HTMLMediaElement::addTrack): Throw if 'kind' is not a known value.
(WebCore::HTMLMediaElement::addTextTrack): Call textTracks(), it will allocate the track
list object if necessary.
(WebCore::HTMLMediaElement::textTracks): Never return NULL, a TextTrackList with no tracks
is allowed.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::addTrack): Add variants to deal with optional parameters plus
a mandatory ExceptionCode parameter.
* html/HTMLMediaElement.idl: addTrack can generate an exception.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::attributeChanged): kind, label, and srclang attribute changes should
percolate down the the TextTrack.
(WebCore::HTMLTrackElement::kind): Return the TextTrack kind because it is not necessarily the
same as the attribute value.
(WebCore::HTMLTrackElement::ensureTrack): Only pass legal 'kind' keywords to create a TextTrack.
(WebCore::HTMLTrackElement::textTrackKindChanged): Notify parent element, if any.
* html/HTMLTrackElement.h:
* html/TextTrack.cpp:
(WebCore::TextTrack::subtitlesKeyword): New, return legal kind attribute value.
(WebCore::TextTrack::captionsKeyword): Ditto.
(WebCore::TextTrack::descriptionsKeyword): Ditto.
(WebCore::TextTrack::chaptersKeyword): Ditto.
(WebCore::TextTrack::metadataKeyword): Ditto.
(WebCore::TextTrack::TextTrack): Call setKind to make sure m_kind is always set to legal value.
(WebCore::TextTrack::isValidKindKeyword): New, validate 'kind' value.
(WebCore::TextTrack::setKind): Only allow legal values.
* html/TextTrack.h:
(WebCore::TextTrack::kind):
(WebCore::TextTrack::label):
(WebCore::TextTrack::setLabel):
(WebCore::TextTrack::language):
(WebCore::TextTrack::setLanguage):
(WebCore::TextTrack::readyState):
(WebCore::TextTrack::mode):
LayoutTests:
* media/track/track-addtrack-kind-expected.txt: Added.
* media/track/track-addtrack-kind.html: Added.
* media/track/track-kind-expected.txt: Added.
* media/track/track-kind.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLMediaElement.idl
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.h
trunk/Source/WebCore/html/TextTrack.cpp
trunk/Source/WebCore/html/TextTrack.h
Added Paths
trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt
trunk/LayoutTests/media/track/track-addtrack-kind.html
trunk/LayoutTests/media/track/track-kind-expected.txt
trunk/LayoutTests/media/track/track-kind.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100452 => 100453)
--- trunk/LayoutTests/ChangeLog 2011-11-16 15:58:42 UTC (rev 100452)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 16:05:45 UTC (rev 100453)
@@ -1,3 +1,15 @@
+2011-11-16 Eric Carlson eric.carl...@apple.com
+
+addTrack() must throw an exception if 'kind' is unknown
+https://bugs.webkit.org/show_bug.cgi?id=71915
+
+Reviewed by Philippe Normand.
+
+* media/track/track-addtrack-kind-expected.txt: Added.
+* media/track/track-addtrack-kind.html: Added.
+* media/track/track-kind-expected.txt: Added.
+* media/track/track-kind.html: Added.
+
2011-11-16 Alexander Pavlov apav...@chromium.org
Unreviewed, test fix after http://trac.webkit.org/changeset/100273.
Added: trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt (0 => 100453)
--- trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt (rev 0)
+++ trunk/LayoutTests/media/track/track-addtrack-kind-expected.txt 2011-11-16 16:05:45 UTC (rev 100453)
@@ -0,0 +1,21 @@
+Tests that the addTrack() only accepts known 'kind' values.
+
+++ Test invalid 'kind'.
+EXPECTED (video.textTracks.length == '0') OK
+TEST(video.addTrack('kaptions')) THROWS(DOMException.SYNTAX_ERR) OK
+EXPECTED (video.textTracks.length == '0') OK
+
+++ Test all valid 'kind' keywords.
+RUN(video.addTrack('subtitles'))
+EXPECTED (video.textTracks.length == '1') OK
+RUN(video.addTrack('captions'))
+EXPECTED (video.textTracks.length == '2') OK
+RUN(video.addTrack('descriptions'))
+EXPECTED (video.textTracks.length == '3') OK
+RUN(video.addTrack('chapters'))
+EXPECTED (video.textTracks.length == '4') OK
+RUN(video.addTrack('metadata'))
+EXPECTED (video.textTracks.length == '5') OK
+
+END OF TEST
+
Added: trunk/LayoutTests/media/track/track-addtrack-kind.html (0 => 100453)
---
[webkit-changes] [100448] trunk/Source/WebKit/qt
Title: [100448] trunk/Source/WebKit/qt
Revision 100448
Author commit-qu...@webkit.org
Date 2011-11-16 07:12:30 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
https://bugs.webkit.org/show_bug.cgi?id=72169
Patch by Jesus Sanchez-Palencia jesus.palen...@openbossa.org on 2011-11-16
Reviewed by Simon Hausmann.
Currently FrameLoaderClientQt::canShowMIMEType is called after
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
PolicyUse and canShowMIMEType returns false, then we have a bug.
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
return true, following the implemenation of WebKit2.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (100447 => 100448)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-16 15:04:58 UTC (rev 100447)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-16 15:12:30 UTC (rev 100448)
@@ -1,3 +1,19 @@
+2011-11-16 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
+
+[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
+https://bugs.webkit.org/show_bug.cgi?id=72169
+
+Reviewed by Simon Hausmann.
+
+Currently FrameLoaderClientQt::canShowMIMEType is called after
+dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
+PolicyUse and canShowMIMEType returns false, then we have a bug.
+Therefore, FrameLoaderClientQt::canShowMIMEType now will always
+return true, following the implemenation of WebKit2.
+
+* WebCoreSupport/FrameLoaderClientQt.cpp:
+(WebCore::FrameLoaderClientQt::canShowMIMEType):
+
2011-11-15 Huang Dongsung luxte...@company100.net
[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (100447 => 100448)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-16 15:04:58 UTC (rev 100447)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-16 15:12:30 UTC (rev 100448)
@@ -650,25 +650,10 @@
notImplemented();
return false;
}
-
+
bool FrameLoaderClientQt::canShowMIMEType(const String MIMEType) const
{
-String type = MIMEType;
-type.makeLower();
-if (MIMETypeRegistry::isSupportedImageMIMEType(type))
-return true;
-
-if (MIMETypeRegistry::isSupportedNonImageMIMEType(type))
-return true;
-
-if (MIMETypeRegistry::isSupportedMediaMIMEType(type))
-return true;
-
-if (m_frame m_frame-settings() m_frame-settings()-arePluginsEnabled()
- PluginDatabase::installedPlugins()-isMIMETypeRegistered(type))
-return true;
-
-return false;
+return true;
}
bool FrameLoaderClientQt::representationExistsForURLScheme(const String) const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100455] trunk/Source/WebKit2
Title: [100455] trunk/Source/WebKit2
Revision 100455
Author commit-qu...@webkit.org
Date 2011-11-16 08:37:29 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
https://bugs.webkit.org/show_bug.cgi?id=72392
Patch by Viatcheslav Ostapenko ostapenko.viatches...@nokia.com on 2011-11-16
Reviewed by Simon Hausmann.
Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
deallocation of referenced object.
* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (100454 => 100455)
--- trunk/Source/WebKit2/ChangeLog 2011-11-16 16:09:45 UTC (rev 100454)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-16 16:37:29 UTC (rev 100455)
@@ -1,3 +1,17 @@
+2011-11-16 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
+
+[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
+https://bugs.webkit.org/show_bug.cgi?id=72392
+
+Reviewed by Simon Hausmann.
+
+Add QWeakPointer to SocketNotifierResourceGuard::m_socketNotifier to track
+deallocation of referenced object.
+
+* Platform/CoreIPC/unix/ConnectionUnix.cpp:
+(CoreIPC::SocketNotifierResourceGuard::SocketNotifierResourceGuard):
+(CoreIPC::SocketNotifierResourceGuard::~SocketNotifierResourceGuard):
+
2011-11-16 Zeno Albisser z...@webkit.org
[Qt][WK2][Mac] MiniBrowser cannot create socketpair.
Modified: trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp (100454 => 100455)
--- trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp 2011-11-16 16:09:45 UTC (rev 100454)
+++ trunk/Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp 2011-11-16 16:37:29 UTC (rev 100455)
@@ -40,6 +40,7 @@
#if PLATFORM(QT)
#include QSocketNotifier
+#include QWeakPointer
#elif PLATFORM(GTK)
#include glib.h
#endif
@@ -162,16 +163,17 @@
SocketNotifierResourceGuard(QSocketNotifier* socketNotifier)
: m_socketNotifier(socketNotifier)
{
-m_socketNotifier-setEnabled(false);
+m_socketNotifier.data()-setEnabled(false);
}
~SocketNotifierResourceGuard()
{
-m_socketNotifier-setEnabled(true);
+if (m_socketNotifier)
+m_socketNotifier.data()-setEnabled(true);
}
private:
-QSocketNotifier* const m_socketNotifier;
+QWeakPointerQSocketNotifier const m_socketNotifier;
};
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100457] trunk/Tools
Title: [100457] trunk/Tools
Revision 100457
Author aro...@apple.com
Date 2011-11-16 08:50:18 -0800 (Wed, 16 Nov 2011)
Log Message
Move filenames/line numbers off to the right edge in Leaks Viewer
Fixes http://webkit.org/b/72510 Callstacks in Leaks Viewer are a little hard to read
because filenames/line numbers are right next to function names
Reviewed by Andreas Kling.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
function name. Use the filename as the profile node's URL (we don't have enough info to
compute a real URL currently) and the line number as the profile node's line number so the
Inspector code will put them on the right side of the callstack graph.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
passed here, just filenames.
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyResourceAsNode):
Copied and slightly modified from inspector.js.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js (100456 => 100457)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js 2011-11-16 16:50:07 UTC (rev 100456)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js 2011-11-16 16:50:18 UTC (rev 100457)
@@ -54,6 +54,18 @@
},
_createNode: function(functionName) {
+var url;
+var lineNumber;
+var match = /(.*) (\S+):(\d+)$/.exec(functionName);
+if (match) {
+functionName = match[1];
+// FIXME: It would be nice to be able to link straight to the right line in Trac, but to
+// do that we'd have to have some way of translating from filenames to Trac URLs.
+// http://webkit.org/b/72509
+url = ""
+lineNumber = match[3];
+}
+
return {
functionName: functionName,
selfTime: 0,
@@ -63,6 +75,8 @@
children: [],
childrenByName: {},
callUID: functionName,
+url: url,
+lineNumber: lineNumber,
};
},
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js (100456 => 100457)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js 2011-11-16 16:50:07 UTC (rev 100456)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js 2011-11-16 16:50:18 UTC (rev 100457)
@@ -27,6 +27,36 @@
// import.
var WebInspector = {
+displayNameForURL: function(url) {
+return url;
+},
+
+linkifyURLAsNode: function(url, linkText, classes, tooltipText) {
+if (!linkText)
+linkText = url;
+classes = (classes ? classes + : );
+
+// FIXME: Create an a element here once we actually have somewhere useful to link to.
+// http://webkit.org/b/72509
+var a = document.createElement(span);
+a.href = ""
+a.className = classes;
+if (typeof tooltipText === undefined)
+a.title = url;
+else if (typeof tooltipText !== string || tooltipText.length)
+a.title = tooltipText;
+a.textContent = linkText;
+
+return a;
+},
+
+linkifyResourceAsNode: function(url, preferredPanel, lineNumber, classes, tooltipText) {
+var linkText = WebInspector.displayNameForURL(url);
+if (lineNumber)
+linkText += : + lineNumber;
+return WebInspector.linkifyURLAsNode(url, linkText, classes, tooltipText);
+},
+
UIString: function(string) {
return String.vsprintf(string, Array.prototype.slice.call(arguments, 1));
},
Modified: trunk/Tools/ChangeLog (100456 => 100457)
--- trunk/Tools/ChangeLog 2011-11-16 16:50:07 UTC (rev 100456)
+++ trunk/Tools/ChangeLog 2011-11-16 16:50:18 UTC (rev 100457)
@@ -1,5 +1,28 @@
2011-11-16 Adam Roben aro...@apple.com
+Move filenames/line numbers off to the right edge in Leaks Viewer
+
+Fixes http://webkit.org/b/72510 Callstacks in Leaks Viewer are a little hard to read
+because filenames/line numbers are right next to function names
+
+Reviewed by Andreas Kling.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
+(LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
+function name. Use
[webkit-changes] [100458] trunk/LayoutTests
Title: [100458] trunk/LayoutTests Revision 100458 Author stevebl...@google.com Date 2011-11-16 08:55:19 -0800 (Wed, 16 Nov 2011) Log Message Web Inspector: Application cache status should be updated after swapCache(). https://bugs.webkit.org/show_bug.cgi?id=72123 Patch by Vsevolod Vlasov vse...@chromium.org on 2011-11-16 Reviewed by Pavel Feldman. * http/tests/inspector/appcache/appcache-iframe-manifests-expected.txt: Added. * http/tests/inspector/appcache/appcache-iframe-manifests.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-iframe-manifests.html. * http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt. * http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html. * http/tests/inspector/appcache/appcache-swap-expected.txt: Added. * http/tests/inspector/appcache/appcache-swap.html: Added. * http/tests/inspector/appcache/appcache-test.js: Renamed from LayoutTests/http/tests/inspector/resource-tree/appcache-test.js. (createAndNavigateIFrame): (removeIFrame): (navigateIFrame): (swapFrameCache): (initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated): (initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame): (initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated): (initialize_ApplicationCacheTest.InspectorTest.navigateIFrame): (initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached): (initialize_ApplicationCacheTest.InspectorTest.removeIFrame): (initialize_ApplicationCacheTest.InspectorTest.swapFrameCache): (initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache): (initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree): (initialize_ApplicationCacheTest.InspectorTest.frameIdToString): (initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString): (initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc): (initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel): (initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus): (initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording): (initialize_ApplicationCacheTest.InspectorTest.ensureFrameStatusEventsReceived): (initialize_ApplicationCacheTest): * http/tests/inspector/appcache/resources/manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/manifest.php. * http/tests/inspector/appcache/resources/page-with-manifest.php: Renamed from LayoutTests/http/tests/inspector/resource-tree/resources/page-with-manifest.php. * http/tests/inspector/appcache/resources/versioned-manifest.php: Added. * http/tests/inspector/appcache/resources/with-versioned-manifest.php: Added. * http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed. * platform/chromium/http/tests/inspector/appcache/appcache-manifest-with-non-existing-file-expected.txt: Added. * platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Removed. * platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100457 => 100458) --- trunk/LayoutTests/ChangeLog 2011-11-16 16:50:18 UTC (rev 100457) +++ trunk/LayoutTests/ChangeLog 2011-11-16 16:55:19 UTC (rev 100458) @@ -74,6 +74,15 @@ 2011-11-16 Steve Block stevebl...@google.com +LayoutTest animations/animation-direction-normal.html fails on Chromium dbg bots +https://bugs.webkit.org/show_bug.cgi?id=72485 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + +2011-11-16 Steve Block stevebl...@google.com + Layout Test inspector/styles/svg-style.xhtml is flaky https://bugs.webkit.org/show_bug.cgi?id=72434 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100457 => 100458) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 16:50:18 UTC (rev 100457) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 16:55:19 UTC (rev 100458) @@ -3912,6 +3912,7 @@ BUGWK72434 : inspector/styles/svg-style.xhtml = PASS TEXT TIMEOUT BUGWK72485 DEBUG : animations/animation-direction-normal.html = TEXT PASS +BUGWK72485 LEOPARD DEBUG CPU-CG GPU-CG : animations/play-state-paused.html = TEXT PASS BUGWK72487 MAC : compositing/layers-inside-overflow-scroll.html = IMAGE BUGWK72487 MAC : compositing/overflow/overflow-compositing-descendant.html = IMAGE ___ webkit-changes mailing list
[webkit-changes] [100459] trunk/Source/WebKit/qt
Title: [100459] trunk/Source/WebKit/qt
Revision 100459
Author je...@webkit.org
Date 2011-11-16 08:57:11 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, rolling out r100448.
http://trac.webkit.org/changeset/100448
https://bugs.webkit.org/show_bug.cgi?id=72512
It caused a regression breaking LayoutTests/http/tests/loading
/text-content-type-with-binary-extension.html (Requested by
jeez_ on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-16
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::canShowMIMEType):
Modified Paths
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
Diff
Modified: trunk/Source/WebKit/qt/ChangeLog (100458 => 100459)
--- trunk/Source/WebKit/qt/ChangeLog 2011-11-16 16:55:19 UTC (rev 100458)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-11-16 16:57:11 UTC (rev 100459)
@@ -1,3 +1,16 @@
+2011-11-16 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100448.
+http://trac.webkit.org/changeset/100448
+https://bugs.webkit.org/show_bug.cgi?id=72512
+
+It caused a regression breaking LayoutTests/http/tests/loading
+/text-content-type-with-binary-extension.html (Requested by
+jeez_ on #webkit).
+
+* WebCoreSupport/FrameLoaderClientQt.cpp:
+(WebCore::FrameLoaderClientQt::canShowMIMEType):
+
2011-11-16 Jesus Sanchez-Palencia jesus.palen...@openbossa.org
[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
Modified: trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp (100458 => 100459)
--- trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-16 16:55:19 UTC (rev 100458)
+++ trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp 2011-11-16 16:57:11 UTC (rev 100459)
@@ -650,10 +650,25 @@
notImplemented();
return false;
}
-
+
bool FrameLoaderClientQt::canShowMIMEType(const String MIMEType) const
{
-return true;
+String type = MIMEType;
+type.makeLower();
+if (MIMETypeRegistry::isSupportedImageMIMEType(type))
+return true;
+
+if (MIMETypeRegistry::isSupportedNonImageMIMEType(type))
+return true;
+
+if (MIMETypeRegistry::isSupportedMediaMIMEType(type))
+return true;
+
+if (m_frame m_frame-settings() m_frame-settings()-arePluginsEnabled()
+ PluginDatabase::installedPlugins()-isMIMETypeRegistered(type))
+return true;
+
+return false;
}
bool FrameLoaderClientQt::representationExistsForURLScheme(const String) const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100460] trunk/Tools
Title: [100460] trunk/Tools
Revision 100460
Author ves...@webkit.org
Date 2011-11-16 09:20:25 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] Prospective fix for broken plugin tests
Don't hide symbols for the NPAPI test plugin
Rubber-stamped by Andreas Kling.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
Diff
Modified: trunk/Tools/ChangeLog (100459 => 100460)
--- trunk/Tools/ChangeLog 2011-11-16 16:57:11 UTC (rev 100459)
+++ trunk/Tools/ChangeLog 2011-11-16 17:20:25 UTC (rev 100460)
@@ -1,3 +1,13 @@
+2011-11-16 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Prospective fix for broken plugin tests
+
+Don't hide symbols for the NPAPI test plugin
+
+Rubber-stamped by Andreas Kling.
+
+* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
+
2011-11-16 Adam Roben aro...@apple.com
Move filenames/line numbers off to the right edge in Leaks Viewer
Modified: trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro (100459 => 100460)
--- trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro 2011-11-16 16:57:11 UTC (rev 100459)
+++ trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro 2011-11-16 17:20:25 UTC (rev 100460)
@@ -7,6 +7,8 @@
TEMPLATE = lib
TARGET = TestNetscapePlugIn
+CONFIG += plugin
+
SOURCES += \
PluginObject.cpp \
PluginTest.cpp \
@@ -41,7 +43,6 @@
DESTDIR = $${ROOT_BUILD_DIR}/lib/plugins
mac {
-CONFIG += plugin
CONFIG += plugin_bundle
QMAKE_INFO_PLIST = ../../TestNetscapePlugIn/mac/Info.plist
QMAKE_PLUGIN_BUNDLE_NAME = $$TARGET
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100461] trunk/Tools
Title: [100461] trunk/Tools
Revision 100461
Author ves...@webkit.org
Date 2011-11-16 09:27:43 -0800 (Wed, 16 Nov 2011)
Log Message
[Qt] Fix use of config.tests
We were checking @buildArgs to determine if the optional argument was
passed or not, but this is not the right way to do that in Perl. The
right way is to not use a prototype for the function, and to pass
the list as a reference (to avoid list expansion). That way we can
check the number of arguments, and choose the right code path based
on that.
We were also missing a default-value of 0 for any feature that's not
set in features.prf.
Reviewed by Kenneth Rohde Christiansen.
* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(qtFeatureDefaults):
(buildQMakeProject):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (100460 => 100461)
--- trunk/Tools/ChangeLog 2011-11-16 17:20:25 UTC (rev 100460)
+++ trunk/Tools/ChangeLog 2011-11-16 17:27:43 UTC (rev 100461)
@@ -1,5 +1,26 @@
2011-11-16 Tor Arne Vestbø tor.arne.ves...@nokia.com
+[Qt] Fix use of config.tests
+
+We were checking @buildArgs to determine if the optional argument was
+passed or not, but this is not the right way to do that in Perl. The
+right way is to not use a prototype for the function, and to pass
+the list as a reference (to avoid list expansion). That way we can
+check the number of arguments, and choose the right code path based
+on that.
+
+We were also missing a default-value of 0 for any feature that's not
+set in features.prf.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* Scripts/build-webkit:
+* Scripts/webkitdirs.pm:
+(qtFeatureDefaults):
+(buildQMakeProject):
+
+2011-11-16 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
[Qt] Prospective fix for broken plugin tests
Don't hide symbols for the NPAPI test plugin
Modified: trunk/Tools/Scripts/build-webkit (100460 => 100461)
--- trunk/Tools/Scripts/build-webkit 2011-11-16 17:20:25 UTC (rev 100460)
+++ trunk/Tools/Scripts/build-webkit 2011-11-16 17:27:43 UTC (rev 100461)
@@ -348,7 +348,7 @@
}
foreach (@features) {
-$_-{default} = (%qtDefaults ? $qtDefaults{$_-{define}} : -1);
+$_-{default} = (%qtDefaults ? $qtDefaults{$_-{define}} || 0 : -1);
}
}
Modified: trunk/Tools/Scripts/webkitdirs.pm (100460 => 100461)
--- trunk/Tools/Scripts/webkitdirs.pm 2011-11-16 17:20:25 UTC (rev 100460)
+++ trunk/Tools/Scripts/webkitdirs.pm 2011-11-16 17:27:43 UTC (rev 100461)
@@ -731,11 +731,8 @@
return $qtVersion;
}
-sub qtFeatureDefaults(;@)
+sub qtFeatureDefaults
{
-my @buildArgs = @_;
-my %qtFeatureDefaults;
-
die ERROR: qmake missing but required to build WebKit.\n if not commandExists($qmakebin);
my $qmakepath = File::Spec-catfile(sourceDir(), Tools, qmake);
@@ -749,19 +746,23 @@
my $originalCwd = getcwd();
my $file;
-if (!@buildArgs) {
-# Do a quick check of the features without running the config tests
-$file = File::Spec-catfile($qmakepath, mkspecs, features, features.prf);
-push @buildArgs, CONFIG+=compute_defaults;
-} else {
+my @buildArgs;
+
+if (@_) {
+@buildArgs = (@buildArgs, @{$_[0]});
my $dir = File::Spec-catfile(productDir(), Tools, qmake);
File::Path::mkpath($dir);
chdir $dir or die Failed to cd into . $dir . \n;
$file = File::Spec-catfile($qmakepath, configure.pro);
+} else {
+# Do a quick check of the features without running the config tests
+$file = File::Spec-catfile($qmakepath, mkspecs, features, features.prf);
+push @buildArgs, CONFIG+=compute_defaults;
}
my $defaults = `$qmakecommand @buildArgs $file 21`;
+my %qtFeatureDefaults;
while ($defaults =~ m/(\S+?)=(\S+?)/gi) {
$qtFeatureDefaults{$1}=$2;
}
@@ -1769,7 +1770,7 @@
File::Path::mkpath($dir);
chdir $dir or die Failed to cd into . $dir . \n;
-my %defines = qtFeatureDefaults(@buildArgs);
+my %defines = qtFeatureDefaults(\@buildArgs);
my $needsCleanBuild = 0;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100462] trunk/Source/JavaScriptCore
Title: [100462] trunk/Source/_javascript_Core
Revision 100462
Author da...@apple.com
Date 2011-11-16 09:29:52 -0800 (Wed, 16 Nov 2011)
Log Message
Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
https://bugs.webkit.org/show_bug.cgi?id=72475
Reviewed by Adam Roben.
* wtf/HashTraits.h: Specialize HashTraits for OwnPtr.
Do overloads so we can pass a nullptr and also be sure to get the
raw pointer type from the OwnPtr template so we handle both forms
of OwnPtr: OwnPtrT and OwnPtrT*.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashTraits.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100461 => 100462)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 17:27:43 UTC (rev 100461)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 17:29:52 UTC (rev 100462)
@@ -1,5 +1,17 @@
-2011-11-15 Simon Hausmann simon.hausm...@nokia.com
+2011-11-16 Darin Adler da...@apple.com
+Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
+https://bugs.webkit.org/show_bug.cgi?id=72475
+
+Reviewed by Adam Roben.
+
+* wtf/HashTraits.h: Specialize HashTraits for OwnPtr.
+Do overloads so we can pass a nullptr and also be sure to get the
+raw pointer type from the OwnPtr template so we handle both forms
+of OwnPtr: OwnPtrT and OwnPtrT*.
+
+2011-11-16 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility bsymbolic_functions
Reviewed by Tor Arne Vestbø.
Modified: trunk/Source/_javascript_Core/wtf/HashTraits.h (100461 => 100462)
--- trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-11-16 17:27:43 UTC (rev 100461)
+++ trunk/Source/_javascript_Core/wtf/HashTraits.h 2011-11-16 17:29:52 UTC (rev 100462)
@@ -30,6 +30,9 @@
class String;
+templatetypename T class OwnPtr;
+templatetypename T class PassOwnPtr;
+
using std::pair;
using std::make_pair;
@@ -94,6 +97,14 @@
static bool isDeletedValue(const T value) { return value.isHashTableDeletedValue(); }
};
+templatetypename P struct HashTraitsOwnPtrP : SimpleClassHashTraitsOwnPtrP {
+static std::nullptr_t emptyValue() { return nullptr; }
+typedef PassOwnPtrP PassType;
+static PassOwnPtrP pass(const OwnPtrP value) { return value.release(); }
+typedef typename OwnPtrP::PtrType PeekType;
+static PeekType peek(const OwnPtrP value) { return value.get(); }
+static PeekType peek(std::nullptr_t) { return 0; }
+};
templatetypename P struct HashTraitsRefPtrP : SimpleClassHashTraitsRefPtrP { };
template struct HashTraitsString : SimpleClassHashTraitsString { };
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100463] trunk/Source/WebKit/efl
Title: [100463] trunk/Source/WebKit/efl
Revision 100463
Author commit-qu...@webkit.org
Date 2011-11-16 09:33:29 -0800 (Wed, 16 Nov 2011)
Log Message
[EFL] Clean up the web database-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72139
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.
Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
more standard naming scheme for the related static variables.
* ewk/ewk_settings.cpp:
(ewk_settings_web_database_default_quota_get):
(ewk_settings_web_database_path_set):
(ewk_settings_web_database_path_get):
* ewk/ewk_settings.h: Document the default web database path on disk.
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (100462 => 100463)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-16 17:29:52 UTC (rev 100462)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-16 17:33:29 UTC (rev 100463)
@@ -1,5 +1,21 @@
2011-11-16 Raphael Kubo da Costa k...@profusion.mobi
+[EFL] Clean up the web database-related functions in ewk_settings.
+https://bugs.webkit.org/show_bug.cgi?id=72139
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Mostly remove some unnecessary ENABLE(SQL_DATABASE) checks and use a
+more standard naming scheme for the related static variables.
+
+* ewk/ewk_settings.cpp:
+(ewk_settings_web_database_default_quota_get):
+(ewk_settings_web_database_path_set):
+(ewk_settings_web_database_path_get):
+* ewk/ewk_settings.h: Document the default web database path on disk.
+
+2011-11-16 Raphael Kubo da Costa k...@profusion.mobi
+
[EFL] Clean up the offline apps-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72132
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (100462 => 100463)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 17:29:52 UTC (rev 100462)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 17:33:29 UTC (rev 100463)
@@ -21,10 +21,8 @@
#include config.h
#include ewk_settings.h
-#include EWebKit.h
-#if ENABLE(SQL_DATABASE)
#include DatabaseTracker.h
-#endif
+#include EWebKit.h
#include FrameView.h
#include IconDatabase.h
#include Image.h
@@ -49,11 +47,10 @@
static const char* s_offlineAppCachePath = 0;
static const char* _ewk_icon_database_path = 0;
-#if ENABLE(SQL_DATABASE)
-static const char* _ewk_default_web_database_path = 0;
-static uint64_t _ewk_default_web_database_quota = 1 * 1024 * 1024;
-#endif
+static const char* s_webDatabasePath = 0;
+static uint64_t s_webDatabaseQuota = 1 * 1024 * 1024; // 1MB.
+
static WTF::String _ewk_settings_webkit_platform_get()
{
WTF::String uaPlatform;
@@ -80,28 +77,20 @@
uint64_t ewk_settings_web_database_default_quota_get()
{
-#if ENABLE(SQL_DATABASE)
-return _ewk_default_web_database_quota;
-#else
-return 0;
-#endif
+return s_webDatabaseQuota;
}
void ewk_settings_web_database_path_set(const char* path)
{
#if ENABLE(SQL_DATABASE)
WebCore::DatabaseTracker::tracker().setDatabaseDirectoryPath(WTF::String::fromUTF8(path));
-eina_stringshare_replace(_ewk_default_web_database_path, path);
+eina_stringshare_replace(s_webDatabasePath, path);
#endif
}
const char* ewk_settings_web_database_path_get(void)
{
-#if ENABLE(SQL_DATABASE)
-return _ewk_default_web_database_path;
-#else
-return 0;
-#endif
+return s_webDatabasePath;
}
Eina_Bool ewk_settings_icon_database_path_set(const char* directory)
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (100462 => 100463)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.h 2011-11-16 17:29:52 UTC (rev 100462)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h 2011-11-16 17:33:29 UTC (rev 100463)
@@ -47,6 +47,8 @@
* Sets the current path to the directory WebKit will write Web
* Database databases.
*
+ * By default, the value is @c ~/.webkit
+ *
* @param path the new database directory path
*/
EAPI void ewk_settings_web_database_path_set(const char *path);
@@ -54,6 +56,8 @@
/**
* Returns directory path where web database is stored.
*
+ * By default, the value is @c ~/.webkit
+ *
* This is guaranteed to be eina_stringshare, so whenever possible
* save yourself some cpu cycles and use eina_stringshare_ref()
* instead of eina_stringshare_add() or strdup().
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100464] trunk/Source/WebKit2
Title: [100464] trunk/Source/WebKit2
Revision 100464
Author kbal...@webkit.org
Date 2011-11-16 10:05:28 -0800 (Wed, 16 Nov 2011)
Log Message
[WK2][X11] Don't leak the colormap we created for the plugin
https://bugs.webkit.org/show_bug.cgi?id=72144
Reviewed by Xan Lopez.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (100463 => 100464)
--- trunk/Source/WebKit2/ChangeLog 2011-11-16 17:33:29 UTC (rev 100463)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-16 18:05:28 UTC (rev 100464)
@@ -1,3 +1,13 @@
+2011-11-16 Balazs Kelemen kbal...@webkit.org
+
+[WK2][X11] Don't leak the colormap we created for the plugin
+https://bugs.webkit.org/show_bug.cgi?id=72144
+
+Reviewed by Xan Lopez.
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::NetscapePlugin::platformDestroy):
+
2011-11-16 Viatcheslav Ostapenko ostapenko.viatches...@nokia.com
[Qt] [WK2] Crash in Connection::readyReadHandler() on socket error
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (100463 => 100464)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-11-16 17:33:29 UTC (rev 100463)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2011-11-16 18:05:28 UTC (rev 100464)
@@ -193,10 +193,13 @@
void NetscapePlugin::platformDestroy()
{
-delete static_castNPSetWindowCallbackStruct*(m_npWindow.ws_info);
+NPSetWindowCallbackStruct* callbackStruct = static_castNPSetWindowCallbackStruct*(m_npWindow.ws_info);
+Display* hostDisplay = x11HostDisplay();
+XFreeColormap(hostDisplay, callbackStruct-colormap);
+delete callbackStruct;
if (m_drawable) {
-XFreePixmap(x11HostDisplay(), m_drawable);
+XFreePixmap(hostDisplay, m_drawable);
m_drawable = 0;
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100466] trunk/Source/WebCore
Title: [100466] trunk/Source/WebCore
Revision 100466
Author commit-qu...@webkit.org
Date 2011-11-16 10:20:49 -0800 (Wed, 16 Nov 2011)
Log Message
[GTK] Fix platformDefersLoading to handle non-http requests, and
to not use broken-ish libsoup APIs.
https://bugs.webkit.org/show_bug.cgi?id=72227
Patch by Dan Winship d...@gnome.org on 2011-11-16
Reviewed by Martin Robinson.
* platform/network/ResourceHandleInternal.h:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):
(WebCore::hasBeenSent):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::readCallback): rather than deferring by using
soup_session_pause_message(), let the read complete, but just don't
process the result until we're no longer deferred.
(WebCore::startNonHTTPRequest): Don't start the request if
it's deferred.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ResourceHandleInternal.h
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100465 => 100466)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 18:16:04 UTC (rev 100465)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 18:20:49 UTC (rev 100466)
@@ -1,3 +1,23 @@
+2011-11-16 Dan Winship d...@gnome.org
+
+[GTK] Fix platformDefersLoading to handle non-http requests, and
+to not use broken-ish libsoup APIs.
+https://bugs.webkit.org/show_bug.cgi?id=72227
+
+Reviewed by Martin Robinson.
+
+* platform/network/ResourceHandleInternal.h:
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::sendRequestCallback):
+(WebCore::startHTTPRequest):
+(WebCore::hasBeenSent):
+(WebCore::ResourceHandle::platformSetDefersLoading):
+(WebCore::readCallback): rather than deferring by using
+soup_session_pause_message(), let the read complete, but just don't
+process the result until we're no longer deferred.
+(WebCore::startNonHTTPRequest): Don't start the request if
+it's deferred.
+
2011-11-16 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Application cache status should be updated after swapCache().
Modified: trunk/Source/WebCore/platform/network/ResourceHandleInternal.h (100465 => 100466)
--- trunk/Source/WebCore/platform/network/ResourceHandleInternal.h 2011-11-16 18:16:04 UTC (rev 100465)
+++ trunk/Source/WebCore/platform/network/ResourceHandleInternal.h 2011-11-16 18:20:49 UTC (rev 100466)
@@ -194,6 +194,7 @@
GRefPtrSoupRequest m_soupRequest;
GRefPtrGInputStream m_inputStream;
GRefPtrGCancellable m_cancellable;
+GRefPtrGAsyncResult m_deferredResult;
char* m_buffer;
unsigned long m_bodySize;
unsigned long m_bodyDataSent;
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (100465 => 100466)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-11-16 18:16:04 UTC (rev 100465)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-11-16 18:20:49 UTC (rev 100466)
@@ -502,9 +502,6 @@
}
}
-if (d-m_defersLoading)
- soup_session_pause_message(handle-defaultSession(), d-m_soupMessage.get());
-
g_input_stream_read_async(d-m_inputStream.get(), d-m_buffer, READ_BUFFER_SIZE,
G_PRIORITY_DEFAULT, d-m_cancellable.get(), readCallback, handle.get());
}
@@ -678,7 +675,7 @@
if (!soup_message_headers_get_one(soupMessage-request_headers, Accept))
soup_message_headers_append(soupMessage-request_headers, Accept, */*);
-// Send the request only if it's not been explicitely deferred.
+// Send the request only if it's not been explicitly deferred.
if (!d-m_defersLoading) {
d-m_cancellable = adoptGRef(g_cancellable_new());
soup_request_send_async(d-m_soupRequest.get(), d-m_cancellable.get(), sendRequestCallback, handle);
@@ -738,34 +735,33 @@
g_cancellable_cancel(d-m_cancellable.get());
}
+static bool hasBeenSent(ResourceHandle* handle)
+{
+ResourceHandleInternal* d = handle-getInternal();
+
+return d-m_cancellable;
+}
+
void ResourceHandle::platformSetDefersLoading(bool defersLoading)
{
-// Initial implementation of this method was required for bug #44157.
-
if (d-m_cancelled)
return;
-if (!defersLoading !d-m_cancellable d-m_soupRequest.get()) {
+// We only need to take action here to UN-defer loading.
+if (defersLoading)
+return;
+
+if (!hasBeenSent(this)) {
+ASSERT(d-m_soupRequest);
d-m_cancellable = adoptGRef(g_cancellable_new());
soup_request_send_async(d-m_soupRequest.get(), d-m_cancellable.get(), sendRequestCallback, this);
return;
}
-// Only supported for http(s) transfers. Something similar would
-// probably be needed for data transfers done with GIO.
[webkit-changes] [100467] branches/safari-534.54-branch/Source
Title: [100467] branches/safari-534.54-branch/Source Revision 100467 Author lforsch...@apple.com Date 2011-11-16 10:30:21 -0800 (Wed, 16 Nov 2011) Log Message Versioning. Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (100466 => 100467) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-16 18:20:49 UTC (rev 100466) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2011-11-16 18:30:21 UTC (rev 100467) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 52; -TINY_VERSION = 9; +MINOR_VERSION = 54; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (100466 => 100467) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-16 18:20:49 UTC (rev 100466) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2011-11-16 18:30:21 UTC (rev 100467) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 52; -TINY_VERSION = 9; +MINOR_VERSION = 54; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (100466 => 100467) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-16 18:20:49 UTC (rev 100466) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2011-11-16 18:30:21 UTC (rev 100467) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 52; -TINY_VERSION = 9; +MINOR_VERSION = 54; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (100466 => 100467) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-16 18:20:49 UTC (rev 100466) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2011-11-16 18:30:21 UTC (rev 100467) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 52; -TINY_VERSION = 9; +MINOR_VERSION = 54; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (100466 => 100467) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-16 18:20:49 UTC (rev 100466) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2011-11-16 18:30:21 UTC (rev 100467) @@ -22,8 +22,8 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. MAJOR_VERSION = 534; -MINOR_VERSION = 52; -TINY_VERSION = 9; +MINOR_VERSION = 54; +TINY_VERSION = 1; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100468] trunk/Source/WebKit2
Title: [100468] trunk/Source/WebKit2
Revision 100468
Author commit-qu...@webkit.org
Date 2011-11-16 10:32:29 -0800 (Wed, 16 Nov 2011)
Log Message
[GTK][WEBKIT2] Link error running gtkdoc-scangobj
https://bugs.webkit.org/show_bug.cgi?id=72365
Patch by Martin Robinson mrobin...@igalia.com on 2011-11-16
Reviewed by Xan Lopez.
* webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig
file so that the compiler links to it.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/webkit2gtk.pc.in
Diff
Modified: trunk/Source/WebKit2/ChangeLog (100467 => 100468)
--- trunk/Source/WebKit2/ChangeLog 2011-11-16 18:30:21 UTC (rev 100467)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-16 18:32:29 UTC (rev 100468)
@@ -1,3 +1,13 @@
+2011-11-16 Martin Robinson mrobin...@igalia.com
+
+[GTK][WEBKIT2] Link error running gtkdoc-scangobj
+https://bugs.webkit.org/show_bug.cgi?id=72365
+
+Reviewed by Xan Lopez.
+
+* webkit2gtk.pc.in: Add a libjavascriptcore requirement to the WebKit2 pkgconfig
+file so that the compiler links to it.
+
2011-11-16 Balazs Kelemen kbal...@webkit.org
[WK2][X11] Don't leak the colormap we created for the plugin
Modified: trunk/Source/WebKit2/webkit2gtk.pc.in (100467 => 100468)
--- trunk/Source/WebKit2/webkit2gtk.pc.in 2011-11-16 18:30:21 UTC (rev 100467)
+++ trunk/Source/WebKit2/webkit2gtk.pc.in 2011-11-16 18:32:29 UTC (rev 100468)
@@ -6,6 +6,6 @@
Name: WebKit2
Description: Web content engine for GTK+
Version: @VERSION@
-Requires: glib-2.0 gtk+-@GTK_API_VERSION@ libsoup-2.4
+Requires: glib-2.0 gtk+-@GTK_API_VERSION@ libsoup-2.4 _javascript_coregtk-@WEBKITGTK_API_VERSION@
Libs: -L${libdir} -lwebkit2gtk-@WEBKITGTK_API_VERSION@
Cflags: -I${includedir}/webkitgtk-@WEBKITGTK_API_VERSION@ -I${includedir}/webkitgtk-@WEBKITGTK_API_VERSION@/webkit2
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100469] trunk
Title: [100469] trunk
Revision 100469
Author commit-qu...@webkit.org
Date 2011-11-16 10:44:20 -0800 (Wed, 16 Nov 2011)
Log Message
String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
https://bugs.webkit.org/show_bug.cgi?id=71572
Patch by Yusuke Suzuki utatane@gmail.com on 2011-11-16
Reviewed by Gavin Barraclough and Darin Adler.
Source/_javascript_Core:
* runtime/RegExpObject.cpp:
(JSC::regExpObjectSource):
LayoutTests:
* fast/regex/script-tests/toString.js:
(testLineTerminator):
* fast/regex/toString-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regex/script-tests/toString.js
trunk/LayoutTests/fast/regex/toString-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExpObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100468 => 100469)
--- trunk/LayoutTests/ChangeLog 2011-11-16 18:32:29 UTC (rev 100468)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 18:44:20 UTC (rev 100469)
@@ -1,3 +1,14 @@
+2011-11-16 Yusuke Suzuki utatane@gmail.com
+
+String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
+https://bugs.webkit.org/show_bug.cgi?id=71572
+
+Reviewed by Gavin Barraclough and Darin Adler.
+
+* fast/regex/script-tests/toString.js:
+(testLineTerminator):
+* fast/regex/toString-expected.txt:
+
2011-11-16 Florin Malita fmal...@google.com
Recent svg/foreignObject tests failing on Mac Win
Modified: trunk/LayoutTests/fast/regex/script-tests/toString.js (100468 => 100469)
--- trunk/LayoutTests/fast/regex/script-tests/toString.js 2011-11-16 18:32:29 UTC (rev 100468)
+++ trunk/LayoutTests/fast/regex/script-tests/toString.js 2011-11-16 18:44:20 UTC (rev 100469)
@@ -10,6 +10,13 @@
return re1.test(string) re2.test(string);
}
+function testLineTerminator(pattern)
+{
+re1 = new RegExp(pattern);
+
+return /\n|\r|\u2028|\u2029/.test(re1.toString());
+}
+
shouldBe(RegExp('/').source, '/');
shouldBe(RegExp('').source, '');
shouldBe(RegExp.prototype.source, '');
@@ -35,3 +42,14 @@
shouldBeTrue('testForwardSlash(x/x\\/x, x\\/x\\/x);');
shouldBeTrue('testForwardSlash(x\\/x\\/x, x\\/x\\/x);');
+shouldBeFalse('testLineTerminator(\\n);');
+shouldBeFalse('testLineTerminator(n);');
+shouldBeFalse('testLineTerminator(\\r);');
+shouldBeFalse('testLineTerminator(r);');
+shouldBeFalse('testLineTerminator(\\u2028);');
+shouldBeFalse('testLineTerminator(u2028);');
+shouldBeFalse('testLineTerminator(\\u2029);');
+shouldBeFalse('testLineTerminator(u2029);');
+
+shouldBe(RegExp('[/]').source, '[/]');
+shouldBe(RegExp('[/]').source, '[/]');
Modified: trunk/LayoutTests/fast/regex/toString-expected.txt (100468 => 100469)
--- trunk/LayoutTests/fast/regex/toString-expected.txt 2011-11-16 18:32:29 UTC (rev 100468)
+++ trunk/LayoutTests/fast/regex/toString-expected.txt 2011-11-16 18:44:20 UTC (rev 100469)
@@ -20,6 +20,16 @@
PASS testForwardSlash(x\/x/x, x\/x\/x); is true
PASS testForwardSlash(x/x\/x, x\/x\/x); is true
PASS testForwardSlash(x\/x\/x, x\/x\/x); is true
+PASS testLineTerminator(\n); is false
+PASS testLineTerminator(\\n); is false
+PASS testLineTerminator(\r); is false
+PASS testLineTerminator(\\r); is false
+PASS testLineTerminator(\u2028); is false
+PASS testLineTerminator(\\u2028); is false
+PASS testLineTerminator(\u2029); is false
+PASS testLineTerminator(\\u2029); is false
+PASS RegExp('[/]').source is '[/]'
+PASS RegExp('\\[/]').source is '\\[\\/]'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/_javascript_Core/ChangeLog (100468 => 100469)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 18:32:29 UTC (rev 100468)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 18:44:20 UTC (rev 100469)
@@ -1,3 +1,13 @@
+2011-11-16 Yusuke Suzuki utatane@gmail.com
+
+String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
+https://bugs.webkit.org/show_bug.cgi?id=71572
+
+Reviewed by Gavin Barraclough and Darin Adler.
+
+* runtime/RegExpObject.cpp:
+(JSC::regExpObjectSource):
+
2011-11-16 Darin Adler da...@apple.com
Specialize HashTraits for OwnPtr to use PassOwnPtr and raw pointer
Modified: trunk/Source/_javascript_Core/runtime/RegExpObject.cpp (100468 => 100469)
--- trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2011-11-16 18:32:29 UTC (rev 100468)
+++ trunk/Source/_javascript_Core/runtime/RegExpObject.cpp 2011-11-16 18:44:20 UTC (rev 100469)
@@ -26,6 +26,7 @@
#include JSArray.h
#include JSGlobalObject.h
#include JSString.h
+#include Lexer.h
#include Lookup.h
#include RegExpConstructor.h
#include RegExpPrototype.h
@@ -119,39 +120,82 @@
JSValue regExpObjectSource(ExecState* exec, JSValue slotBase, const Identifier)
{
UString pattern = asRegExpObject(slotBase)-regExp()-pattern();
+unsigned length = pattern.length();
[webkit-changes] [100470] trunk/Source/WebCore
Title: [100470] trunk/Source/WebCore Revision 100470 Author commit-qu...@webkit.org Date 2011-11-16 10:56:08 -0800 (Wed, 16 Nov 2011) Log Message [Gtk] display:none has no effect on option element. https://bugs.webkit.org/show_bug.cgi?id=72370 Patch by Antaryami Pandia antaryami.pan...@motorola.com on 2011-11-16 Reviewed by Martin Robinson. * platform/gtk/GtkPopupMenu.cpp: (WebCore::GtkPopupMenu::appendItem): * platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::createGtkActionForMenuItem): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100469 => 100470) --- trunk/Source/WebCore/ChangeLog 2011-11-16 18:44:20 UTC (rev 100469) +++ trunk/Source/WebCore/ChangeLog 2011-11-16 18:56:08 UTC (rev 100470) @@ -1,3 +1,15 @@ +2011-11-16 Antaryami Pandia antaryami.pan...@motorola.com + +[Gtk] display:none has no effect on option element. +https://bugs.webkit.org/show_bug.cgi?id=72370 + +Reviewed by Martin Robinson. + +* platform/gtk/GtkPopupMenu.cpp: +(WebCore::GtkPopupMenu::appendItem): +* platform/gtk/PopupMenuGtk.cpp: +(WebCore::PopupMenuGtk::createGtkActionForMenuItem): + 2011-11-16 Dan Winship d...@gnome.org [GTK] Fix platformDefersLoading to handle non-http requests, and Modified: trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp (100469 => 100470) --- trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2011-11-16 18:44:20 UTC (rev 100469) +++ trunk/Source/WebCore/platform/gtk/GtkPopupMenu.cpp 2011-11-16 18:56:08 UTC (rev 100470) @@ -67,7 +67,9 @@ gtk_widget_set_tooltip_text(menuItem, gtk_action_get_tooltip(action)); g_signal_connect(menuItem, select, G_CALLBACK(GtkPopupMenu::selectItemCallback), this); gtk_menu_shell_append(GTK_MENU_SHELL(m_popup.get()), menuItem); -gtk_widget_show(menuItem); + +if (gtk_action_is_visible(action)) +gtk_widget_show(menuItem); } void GtkPopupMenu::popUp(const IntSize menuSize, const IntPoint menuPosition, int itemCount, int selectedItem, const GdkEvent* event) Modified: trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp (100469 => 100470) --- trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp 2011-11-16 18:44:20 UTC (rev 100469) +++ trunk/Source/WebCore/platform/gtk/PopupMenuGtk.cpp 2011-11-16 18:56:08 UTC (rev 100470) @@ -58,6 +58,7 @@ g_object_set_data(G_OBJECT(action), popup-menu-action-index, GINT_TO_POINTER(itemIndex)); g_signal_connect(action, activate, G_CALLBACK(menuItemActivated), this); // FIXME: Apply the PopupMenuStyle from client()-itemStyle(i) +gtk_action_set_visible(action, !client()-itemStyle(itemIndex).isDisplayNone()); gtk_action_set_sensitive(action, client()-itemIsEnabled(itemIndex)); return action; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100471] trunk/LayoutTests
Title: [100471] trunk/LayoutTests
Revision 100471
Author commit-qu...@webkit.org
Date 2011-11-16 11:03:00 -0800 (Wed, 16 Nov 2011)
Log Message
ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777
Patch by Sergey Glazunov serg.glazu...@gmail.com on 2011-11-16
Reviewed by Adam Barth.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Added.
* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt
trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100470 => 100471)
--- trunk/LayoutTests/ChangeLog 2011-11-16 18:56:08 UTC (rev 100470)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 19:03:00 UTC (rev 100471)
@@ -1,3 +1,13 @@
+2011-11-16 Sergey Glazunov serg.glazu...@gmail.com
+
+ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
+https://bugs.webkit.org/show_bug.cgi?id=69777
+
+Reviewed by Adam Barth.
+
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt: Added.
+* http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html: Added.
+
2011-11-16 Yusuke Suzuki utatane@gmail.com
String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
Added: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (0 => 100471)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url-expected.txt 2011-11-16 19:03:00 UTC (rev 100471)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match.
+
+This test passes if there's no alert dialog.
Added: trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (0 => 100471)
--- trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/xss-DENIED-synchronous-frame-load-in-_javascript_-url.html 2011-11-16 19:03:00 UTC (rev 100471)
@@ -0,0 +1,42 @@
+html
+head
+script
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+ layoutTestController.setCanOpenWindows();
+ layoutTestController.setCloseRemainingWindowsWhenComplete(true);
+}
+
+window._onload_ = function()
+{
+ victim = document.body.appendChild(document.createElement(iframe));
+ wnd = victim.contentWindow.open();
+ victim.src = ""
+ victim._onload_ = function() {
+ victim._onload_ = null;
+
+ wnd.eval(( + function() {
+ location = _javascript_:( + function() {
+a = document.createElement(a);
+a.href = ""
+e = document.createEvent(MouseEvent);
+e.initMouseEvent(click);
+a.dispatchEvent(e);
+
+return script( + function() {
+ opener.location = _javascript_:alert(document.body.innerHTML);
+
+ if (window.layoutTestController)
+ setTimeout(layoutTestController.notifyDone(), 0);
+} + )()\/script;
+ } + )();
+ } + )());
+ }
+}
+/script
+/head
+body
+This test passes if there's no alert dialog.
+/body
+/html
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100472] trunk/Source/WebKit/efl
Title: [100472] trunk/Source/WebKit/efl
Revision 100472
Author commit-qu...@webkit.org
Date 2011-11-16 11:03:49 -0800 (Wed, 16 Nov 2011)
Log Message
[EFL] Add ewk_settings_memory_cache_clear().
https://bugs.webkit.org/show_bug.cgi?id=72141
Patch by Raphael Kubo da Costa k...@profusion.mobi on 2011-11-16
Reviewed by Kenneth Rohde Christiansen.
This is the same as Qt's QWebSettings::clearMemoryCaches() and is
responsible for clearing, among others, the page, memory and font
caches.
* ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
* ewk/ewk_settings.h:
Modified Paths
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.h
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (100471 => 100472)
--- trunk/Source/WebKit/efl/ChangeLog 2011-11-16 19:03:00 UTC (rev 100471)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-11-16 19:03:49 UTC (rev 100472)
@@ -1,5 +1,20 @@
2011-11-16 Raphael Kubo da Costa k...@profusion.mobi
+[EFL] Add ewk_settings_memory_cache_clear().
+https://bugs.webkit.org/show_bug.cgi?id=72141
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This is the same as Qt's QWebSettings::clearMemoryCaches() and is
+responsible for clearing, among others, the page, memory and font
+caches.
+
+* ewk/ewk_settings.cpp:
+(ewk_settings_memory_cache_clear):
+* ewk/ewk_settings.h:
+
+2011-11-16 Raphael Kubo da Costa k...@profusion.mobi
+
[EFL] Clean up the web database-related functions in ewk_settings.
https://bugs.webkit.org/show_bug.cgi?id=72139
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.cpp (100471 => 100472)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 19:03:00 UTC (rev 100471)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.cpp 2011-11-16 19:03:49 UTC (rev 100472)
@@ -21,14 +21,17 @@
#include config.h
#include ewk_settings.h
+#include CrossOriginPreflightResultCache.h
#include DatabaseTracker.h
#include EWebKit.h
+#include FontCache.h
#include FrameView.h
#include IconDatabase.h
#include Image.h
#include IntSize.h
#include KURL.h
#include MemoryCache.h
+#include PageCache.h
// FIXME: Why is there a directory in this include?
#include appcache/ApplicationCacheStorage.h
#include ewk_private.h
@@ -209,6 +212,29 @@
cache-setCapacities(0, capacity, capacity);
}
+void ewk_settings_memory_cache_clear()
+{
+// Turn the cache on and off. Disabling the object cache will remove all
+// resources from the cache. They may still live on if they are referenced
+// by some Web page though.
+if (!WebCore::memoryCache()-disabled()) {
+WebCore::memoryCache()-setDisabled(true);
+WebCore::memoryCache()-setDisabled(false);
+}
+
+int pageCapacity = WebCore::pageCache()-capacity();
+// Setting size to 0, makes all pages be released.
+WebCore::pageCache()-setCapacity(0);
+WebCore::pageCache()-releaseAutoreleasedPagesNow();
+WebCore::pageCache()-setCapacity(pageCapacity);
+
+// Invalidating the font cache and freeing all inactive font data.
+WebCore::fontCache()-invalidate();
+
+// Empty the Cross-Origin Preflight cache
+WebCore::CrossOriginPreflightResultCache::shared().empty();
+}
+
void ewk_settings_repaint_throttling_set(double deferredRepaintDelay, double initialDeferredRepaintDelayDuringLoading, double maxDeferredRepaintDelayDuringLoading, double deferredRepaintDelayIncrementDuringLoading)
{
WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay(deferredRepaintDelay);
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (100471 => 100472)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.h 2011-11-16 19:03:00 UTC (rev 100471)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h 2011-11-16 19:03:49 UTC (rev 100472)
@@ -186,6 +186,15 @@
EAPI void ewk_settings_cache_capacity_set(unsigned capacity);
/**
+ * Clears all memory caches.
+ *
+ * This function clears all memory caches, which include the object cache (for resources such as
+ * images, scripts and stylesheets), the page cache, the font cache and the Cross-Origin Preflight
+ * cache.
+ */
+EAPI void ewk_settings_memory_cache_clear(void);
+
+/**
* Sets values for repaint throttling.
*
* It allows to slow down page loading and
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100475] trunk/Source/WebCore
Title: [100475] trunk/Source/WebCore Revision 100475 Author commit-qu...@webkit.org Date 2011-11-16 11:16:45 -0800 (Wed, 16 Nov 2011) Log Message Remove extra GraphicsContextStateSaver restore() call. https://bugs.webkit.org/show_bug.cgi?id=72497 Patch by Philip Rogers p...@google.com on 2011-11-16 Reviewed by Andreas Kling. * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100474 => 100475) --- trunk/Source/WebCore/ChangeLog 2011-11-16 19:13:25 UTC (rev 100474) +++ trunk/Source/WebCore/ChangeLog 2011-11-16 19:16:45 UTC (rev 100475) @@ -1,3 +1,13 @@ +2011-11-16 Philip Rogers p...@google.com + +Remove extra GraphicsContextStateSaver restore() call. +https://bugs.webkit.org/show_bug.cgi?id=72497 + +Reviewed by Andreas Kling. + +* html/canvas/CanvasRenderingContext2D.cpp: +(WebCore::CanvasRenderingContext2D::drawTextInternal): + 2011-11-08 Robert Hogan rob...@webkit.org CSS 2.1 failure: border-collapse-offset-002.htm fails Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (100474 => 100475) --- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-11-16 19:13:25 UTC (rev 100474) +++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp 2011-11-16 19:16:45 UTC (rev 100475) @@ -2205,7 +2205,6 @@ // We draw when fontWidth is 0 so compositing operations (eg, a copy op) still work. c-scale(FloatSize((fontWidth 0 ? (width / fontWidth) : 0), 1)); c-drawBidiText(font, textRun, FloatPoint(0, 0)); -stateSaver.restore(); } else c-drawBidiText(font, textRun, location); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100476] trunk/LayoutTests
Title: [100476] trunk/LayoutTests Revision 100476 Author aba...@webkit.org Date 2011-11-16 11:29:26 -0800 (Wed, 16 Nov 2011) Log Message Update test results after tightening up SecurityOrigin logic in http://trac.webkit.org/changeset/100182. These new results are (minor) progressions on these tests. * http/tests/security/cross-frame-access-enumeration-expected.txt: * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt trunk/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (100475 => 100476) --- trunk/LayoutTests/ChangeLog 2011-11-16 19:16:45 UTC (rev 100475) +++ trunk/LayoutTests/ChangeLog 2011-11-16 19:29:26 UTC (rev 100476) @@ -1,3 +1,12 @@ +2011-11-16 Adam Barth aba...@webkit.org + +Update test results after tightening up SecurityOrigin logic in +http://trac.webkit.org/changeset/100182. These new results are (minor) +progressions on these tests. + +* http/tests/security/cross-frame-access-enumeration-expected.txt: +* http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt: + 2011-11-08 Robert Hogan rob...@webkit.org CSS 2.1 failure: border-collapse-offset-002.htm fails Modified: trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt (100475 => 100476) --- trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt 2011-11-16 19:16:45 UTC (rev 100475) +++ trunk/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt 2011-11-16 19:29:26 UTC (rev 100476) @@ -20,8 +20,6 @@ CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-enumeration-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-enumeration.html. Domains, protocols and ports must match. -CONSOLE MESSAGE: line 1: Unsafe _javascript_ attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-enumeration-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-enumeration.html. Domains, protocols and ports must match. - This tests that variable names can't be enumerated cross domain (see http://bugs.webkit.org/show_bug.cgi?id=16387) Modified: trunk/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt (100475 => 100476) --- trunk/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt 2011-11-16 19:16:45 UTC (rev 100475) +++ trunk/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt 2011-11-16 19:29:26 UTC (rev 100476) @@ -1,7 +1,5 @@ CONSOLE MESSAGE: line 0: Unable to post message to asdf://. Recipient has origin http://localhost:8000. -CONSOLE MESSAGE: line 0: Unable to post message to null. Recipient has origin http://localhost:8000. - window.location.href = "" waiting... Encountered exception Error: SYNTAX_ERR: DOM Exception 12 while posting message to ''. @@ -9,6 +7,6 @@ Encountered exception Error: SYNTAX_ERR: DOM Exception 12 while posting message to '/tmp/foo'. Encountered exception Error: SYNTAX_ERR: DOM Exception 12 while posting message to '//localhost'. Posted message to 'asdf:' without any exceptions. -Posted message to 'http:' without any exceptions. +Encountered exception Error: SYNTAX_ERR: DOM Exception 12 while posting message to 'http:'. Received message: data="" message: data="" origin=http://127.0.0.1:8000 origin=http://localhost:8000 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100477] branches/safari-534.53-branch/Source/WebCore
Title: [100477] branches/safari-534.53-branch/Source/WebCore
Revision 100477
Author lforsch...@apple.com
Date 2011-11-16 11:31:25 -0800 (Wed, 16 Nov 2011)
Log Message
Merge 89441.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100476 => 100477)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 19:29:26 UTC (rev 100476)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 19:31:25 UTC (rev 100477)
@@ -1,5 +1,33 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 89441
+
+2011-06-22 Simon Fraser simon.fra...@apple.com
+
+Reviewed by Dan Bernstein.
+
+Update position, bounds and anchor point in GraphicsLayerCA all at once
+https://bugs.webkit.org/show_bug.cgi?id=63148
+
+Since position, bounds and anchor point are inter-dependent, avoid
+redundant work by simply updating them all at the same time.
+
+No behavior changes, so no new tests.
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::setPosition):
+(WebCore::GraphicsLayerCA::setAnchorPoint):
+(WebCore::GraphicsLayerCA::setSize):
+(WebCore::GraphicsLayerCA::setBoundsOrigin):
+(WebCore::GraphicsLayerCA::setAllowTiledLayer):
+(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
+(WebCore::GraphicsLayerCA::updateGeometry):
+(WebCore::GraphicsLayerCA::ensureStructuralLayer):
+(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
+* platform/graphics/ca/GraphicsLayerCA.h:
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 91140
2011-07-15 Simon Fraser simon.fra...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (100476 => 100477)
--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-11-16 19:29:26 UTC (rev 100476)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-11-16 19:31:25 UTC (rev 100477)
@@ -380,7 +380,7 @@
return;
GraphicsLayer::setPosition(point);
-noteLayerPropertyChanged(PositionChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setAnchorPoint(const FloatPoint3D point)
@@ -389,7 +389,7 @@
return;
GraphicsLayer::setAnchorPoint(point);
-noteLayerPropertyChanged(AnchorPointChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setSize(const FloatSize size)
@@ -398,7 +398,7 @@
return;
GraphicsLayer::setSize(size);
-noteLayerPropertyChanged(SizeChanged);
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setTransform(const TransformationMatrix t)
@@ -495,8 +495,8 @@
m_allowTiledLayer = allowTiledLayer;
-// Handling this as a SizeChanged will cause use to switch in or out of tiled layer as needed
-noteLayerPropertyChanged(SizeChanged);
+// Handling this as a BoundsChanged will cause use to switch in or out of tiled layer as needed
+noteLayerPropertyChanged(GeometryChanged);
}
void GraphicsLayerCA::setBackgroundColor(const Color color)
@@ -848,14 +848,8 @@
if (m_uncommittedChanges ChildrenChanged)
updateSublayerList();
-if (m_uncommittedChanges PositionChanged)
-updateLayerPosition();
-
-if (m_uncommittedChanges AnchorPointChanged)
-updateAnchorPoint();
-
-if (m_uncommittedChanges SizeChanged)
-updateLayerSize();
+if (m_uncommittedChanges GeometryChanged)
+updateGeometry();
if (m_uncommittedChanges TransformChanged)
updateTransform();
@@ -969,14 +963,18 @@
m_layer-setSublayers(newSublayers);
}
-void GraphicsLayerCA::updateLayerPosition()
+void GraphicsLayerCA::updateGeometry()
{
+bool needTiledLayer = requiresTiledLayer(m_size);
+if (needTiledLayer != m_usingTiledLayer)
+swapFromOrToTiledLayer(needTiledLayer);
+
FloatSize usedSize = m_usingTiledLayer ? constrainedSize() : m_size;
+FloatRect boundsRect(FloatPoint(), usedSize);
+// Update position.
// Position is offset on the layer by the layer anchor point.
-FloatPoint posPoint(m_position.x() + m_anchorPoint.x() * usedSize.width(),
- m_position.y() + m_anchorPoint.y() * usedSize.height());
-
+FloatPoint posPoint(m_position.x() + m_anchorPoint.x() * usedSize.width(), m_position.y() + m_anchorPoint.y() * usedSize.height());
primaryLayer()-setPosition(posPoint);
if (LayerMap* layerCloneMap =
[webkit-changes] [100478] trunk/LayoutTests
Title: [100478] trunk/LayoutTests Revision 100478 Author aba...@webkit.org Date 2011-11-16 11:34:37 -0800 (Wed, 16 Nov 2011) Log Message Unskip these tests now that they should pass again. * platform/gtk/Skipped: * platform/qt/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped trunk/LayoutTests/platform/qt/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (100477 => 100478) --- trunk/LayoutTests/ChangeLog 2011-11-16 19:31:25 UTC (rev 100477) +++ trunk/LayoutTests/ChangeLog 2011-11-16 19:34:37 UTC (rev 100478) @@ -1,5 +1,12 @@ 2011-11-16 Adam Barth aba...@webkit.org +Unskip these tests now that they should pass again. + +* platform/gtk/Skipped: +* platform/qt/Skipped: + +2011-11-16 Adam Barth aba...@webkit.org + Update test results after tightening up SecurityOrigin logic in http://trac.webkit.org/changeset/100182. These new results are (minor) progressions on these tests. Modified: trunk/LayoutTests/platform/gtk/Skipped (100477 => 100478) --- trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 19:31:25 UTC (rev 100477) +++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 19:34:37 UTC (rev 100478) @@ -1601,8 +1601,3 @@ # fast/dom/Window/window-postmessage-arrays.html fails on JSC platforms # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html - -# REGRESSION(r100182): It broke 2 http/tests/security tests -# https://bugs.webkit.org/show_bug.cgi?id=72364 -http/tests/security/cross-frame-access-enumeration.html -http/tests/security/postMessage/invalid-origin-throws-exception.html Modified: trunk/LayoutTests/platform/qt/Skipped (100477 => 100478) --- trunk/LayoutTests/platform/qt/Skipped 2011-11-16 19:31:25 UTC (rev 100477) +++ trunk/LayoutTests/platform/qt/Skipped 2011-11-16 19:34:37 UTC (rev 100478) @@ -2510,11 +2510,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=72363 fast/dom/Window/window-postmessage-arrays.html -# REGRESSION(r100182): It broke 2 http/tests/security tests -# https://bugs.webkit.org/show_bug.cgi?id=72364 -http/tests/security/cross-frame-access-enumeration.html -http/tests/security/postMessage/invalid-origin-throws-exception.html - # [Qt] editing/pasteboard/data-transfer-items-image-png.html is failing due to DataTransferItems for image/png not being implemented # https://bugs.webkit.org/show_bug.cgi?id=72430 editing/pasteboard/data-transfer-items-image-png.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100479] trunk/Source/WebCore
Title: [100479] trunk/Source/WebCore
Revision 100479
Author rob...@webkit.org
Date 2011-11-16 11:39:03 -0800 (Wed, 16 Nov 2011)
Log Message
Fix build on Windows and Mac after r100473
Unreviewed, fix build.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderingAllInOne.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderingAllInOne.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100478 => 100479)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 19:34:37 UTC (rev 100478)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 19:39:03 UTC (rev 100479)
@@ -1,3 +1,13 @@
+2011-11-16 Robert Hogan rob...@webkit.org
+
+Fix build on Windows and Mac after r100473
+
+Unreviewed, fix build.
+
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderingAllInOne.cpp:
+
2011-11-16 Philip Rogers p...@google.com
Remove extra GraphicsContextStateSaver restore() call.
Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (100478 => 100479)
--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-16 19:34:37 UTC (rev 100478)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-16 19:39:03 UTC (rev 100479)
@@ -38178,6 +38178,62 @@
/File
File
+RelativePath=..\rendering\RenderTableCaption.cpp
+
+FileConfiguration
+ Name=Debug|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+FileConfiguration
+ Name=Release|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+FileConfiguration
+ Name=Debug_Cairo_CFLite|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+FileConfiguration
+ Name=Release_Cairo_CFLite|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+FileConfiguration
+ Name=Debug_All|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+FileConfiguration
+ Name=Production|Win32
+ ExcludedFromBuild=true
+
+ Tool
+ Name=VCCLCompilerTool
+ /
+/FileConfiguration
+ /File
+ File
+RelativePath=..\rendering\RenderTableCaption.h
+
+ /File
+ File
RelativePath=..\rendering\RenderTableCell.cpp
FileConfiguration
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (100478 => 100479)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-16 19:34:37 UTC (rev 100478)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-16 19:39:03 UTC (rev 100479)
@@ -3934,6 +3934,8 @@
A8DF4AE80980C42C0052981B /* RenderTableCol.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4ADE0980C42C0052981B /* RenderTableCol.cpp */; };
A8DF4AE90980C42C0052981B /* RenderTableCell.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4ADF0980C42C0052981B /* RenderTableCell.h */; };
A8DF4AEA0980C42C0052981B /* RenderTableCell.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE00980C42C0052981B /* RenderTableCell.cpp */; };
+ A8DF4AE90980C42C0052981B /* RenderTableCaption.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4ADF0980C42C0052981B /* RenderTableCaption.h */; };
+ A8DF4AEA0980C42C0052981B /* RenderTableCaption.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE00980C42C0052981B /* RenderTableCaption.cpp */; };
A8DF4AEB0980C42C0052981B /* RenderTable.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4AE10980C42C0052981B /* RenderTable.h */; };
A8DF4AEC0980C42C0052981B /* RenderTable.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE20980C42C0052981B /* RenderTable.cpp */; };
A8DF4AED0980C42C0052981B /* RenderTableSection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE30980C42C0052981B /* RenderTableSection.cpp */; };
Modified: trunk/Source/WebCore/rendering/RenderingAllInOne.cpp (100478 => 100479)
--- trunk/Source/WebCore/rendering/RenderingAllInOne.cpp 2011-11-16 19:34:37 UTC (rev 100478)
+++ trunk/Source/WebCore/rendering/RenderingAllInOne.cpp 2011-11-16 19:39:03 UTC (rev 100479)
@@ -92,6 +92,7 @@
#include RenderSlider.cpp
#include RenderSummary.cpp
#include RenderTable.cpp
+#include RenderTableCaption.cpp
#include RenderTableCell.cpp
#include RenderTableCol.cpp
#include RenderTableRow.cpp
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100481] trunk/Source/WebCore
Title: [100481] trunk/Source/WebCore
Revision 100481
Author commit-qu...@webkit.org
Date 2011-11-16 11:42:16 -0800 (Wed, 16 Nov 2011)
Log Message
CSSValue: isInheritedValue() doesn't need a dedicated bit.
http://webkit.org/b/72514
Patch by Andreas Kling kl...@webkit.org on 2011-11-16
Reviewed by Antti Koivisto.
Remove CSSValue::m_isInherited and have isInheritedValue() check the
class type instead. There's no compelling reason for CSSInheritedValue
to have a dedicated bit, since nobody subclasses it anyway.
* css/CSSValue.h:
(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::CSSValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSValue.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (100480 => 100481)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 19:42:10 UTC (rev 100480)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 19:42:16 UTC (rev 100481)
@@ -1,3 +1,18 @@
+2011-11-16 Andreas Kling kl...@webkit.org
+
+CSSValue: isInheritedValue() doesn't need a dedicated bit.
+http://webkit.org/b/72514
+
+Reviewed by Antti Koivisto.
+
+Remove CSSValue::m_isInherited and have isInheritedValue() check the
+class type instead. There's no compelling reason for CSSInheritedValue
+to have a dedicated bit, since nobody subclasses it anyway.
+
+* css/CSSValue.h:
+(WebCore::CSSValue::isInheritedValue):
+(WebCore::CSSValue::CSSValue):
+
2011-11-16 Robert Hogan rob...@webkit.org
Fix build on Windows and Mac after r100473
Modified: trunk/Source/WebCore/css/CSSValue.h (100480 => 100481)
--- trunk/Source/WebCore/css/CSSValue.h 2011-11-16 19:42:10 UTC (rev 100480)
+++ trunk/Source/WebCore/css/CSSValue.h 2011-11-16 19:42:16 UTC (rev 100481)
@@ -58,7 +58,6 @@
bool isPrimitiveValue() const { return m_isPrimitive; }
bool isValueList() const { return m_isList; }
-bool isInheritedValue() const { return m_isInherited; }
bool isBorderImageValue() const { return m_classType == BorderImageClass; }
bool isBorderImageSliceValue() const { return m_classType == BorderImageSliceClass; }
@@ -69,6 +68,7 @@
bool isImageGeneratorValue() const { return m_classType == CanvasClass || m_classType == CrossfadeClass || m_classType == LinearGradientClass || m_classType == RadialGradientClass; }
bool isImageValue() const { return m_classType == ImageClass || m_classType == CursorImageClass; }
bool isImplicitInitialValue() const { return m_classType == InitialClass m_isImplicit; }
+bool isInheritedValue() const { return m_classType == InheritedClass; }
bool isInitialValue() const { return m_classType == InitialClass; }
bool isReflectValue() const { return m_classType == ReflectClass; }
bool isShadowValue() const { return m_classType == ShadowClass; }
@@ -141,7 +141,6 @@
, m_classType(classType)
, m_isPrimitive(isPrimitiveType(classType))
, m_isList(isListType(classType))
-, m_isInherited(isInheritedType(classType))
{
}
@@ -168,11 +167,6 @@
|| type == WebKitCSSTransformClass;
}
-static bool isInheritedType(ClassType type)
-{
-return type == InheritedClass;
-}
-
void destroy();
protected:
@@ -191,7 +185,6 @@
unsigned m_classType : 5; // ClassType
bool m_isPrimitive : 1;
bool m_isList : 1;
-bool m_isInherited : 1;
};
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100484] branches/safari-534.53-branch/Source/WebCore
Title: [100484] branches/safari-534.53-branch/Source/WebCore
Revision 100484
Author lforsch...@apple.com
Date 2011-11-16 11:58:46 -0800 (Wed, 16 Nov 2011)
Log Message
Merged r93043.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100483 => 100484)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 19:53:12 UTC (rev 100483)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 19:58:46 UTC (rev 100484)
@@ -1,5 +1,24 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 93043
+
+2011-08-15 Adam Roben aro...@apple.com
+
+Rename an instance of pageScaleFactorChanged I missed in r93040
+
+I tried to make a test for this but failed. It would probably have been easier if we dumped
+layers' content scales in layerTreeAsText output.
+
+Followup to http://webkit.org/b/55787 WebKit uses multiple conflicting names to refer to
+the device scale factor
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):
+* platform/graphics/ca/GraphicsLayerCA.h:
+Renamed from pageScaleFactorChanged to match the base class.
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 93040
2011-08-10 Adam Roben aro...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (100483 => 100484)
--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-11-16 19:53:12 UTC (rev 100483)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2011-11-16 19:58:46 UTC (rev 100484)
@@ -2394,7 +2394,7 @@
noteChangesForScaleSensitiveProperties();
}
-void GraphicsLayerCA::pageScaleFactorChanged()
+void GraphicsLayerCA::deviceOrPageScaleFactorChanged()
{
noteChangesForScaleSensitiveProperties();
}
Modified: branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (100483 => 100484)
--- branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2011-11-16 19:53:12 UTC (rev 100483)
+++ branches/safari-534.53-branch/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2011-11-16 19:58:46 UTC (rev 100484)
@@ -116,7 +116,7 @@
virtual void layerDidDisplay(PlatformLayer*);
virtual void setMaintainsPixelAlignment(bool);
-virtual void pageScaleFactorChanged();
+virtual void deviceOrPageScaleFactorChanged();
void recursiveCommitChanges(float pageScaleFactor = 1, const FloatPoint positionRelativeToBase = FloatPoint(), bool affectedByPageScale = false);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100485] trunk/LayoutTests
Title: [100485] trunk/LayoutTests Revision 100485 Author stevebl...@google.com Date 2011-11-16 11:59:12 -0800 (Wed, 16 Nov 2011) Log Message fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg https://bugs.webkit.org/show_bug.cgi?id=72530 Unreviewed gardening * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (100484 => 100485) --- trunk/LayoutTests/ChangeLog 2011-11-16 19:58:46 UTC (rev 100484) +++ trunk/LayoutTests/ChangeLog 2011-11-16 19:59:12 UTC (rev 100485) @@ -1,3 +1,12 @@ +2011-11-16 Steve Block stevebl...@google.com + +fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg +https://bugs.webkit.org/show_bug.cgi?id=72530 + +Unreviewed gardening + +* platform/chromium/test_expectations.txt: + 2011-11-16 Adam Barth aba...@webkit.org Unskip these tests now that they should pass again. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100484 => 100485) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 19:58:46 UTC (rev 100484) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 19:59:12 UTC (rev 100485) @@ -38,7 +38,6 @@ BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/sandboxed-iframe-navigation-parent.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/js/repeat-cached-vm-reentry.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/dom/Window/window-postmessage-clone-deep-array.html = PASS -BUGCR24182 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = PASS BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/frames/calculate-percentage.html = PASS // See BUGCR104797 //BUGCR24182 SLOW DEBUG SNOWLEOPARD : svg/hixie/perf/007.xml = PASS @@ -3697,6 +3696,7 @@ BUGCR99899 MAC : storage/domstorage/events/case-sensitive.html = CRASH PASS // New failures from WebKit r51577 BUGCR29164 WIN LINUX : fast/frames/sandboxed-iframe-plugins.html = TEXT +BUGWK72530 SLOW DEBUG : fast/frames/sandboxed-iframe-navigation-targetlink.html = CRASH PASS BUGWK69998 LINUX WIN : plugins/refcount-leaks.html = PASS TEXT BUGWK70001 LINUX WIN : fast/images/color-jpeg-with-color-profile.html = FAIL MISSING ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100486] trunk
Title: [100486] trunk
Revision 100486
Author ser...@webkit.org
Date 2011-11-16 12:12:42 -0800 (Wed, 16 Nov 2011)
Log Message
[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
https://bugs.webkit.org/show_bug.cgi?id=69219
Reviewed by Martin Robinson.
Source/WebCore:
Do not stop appending data to the request body if any of the blob
items to upload is not accesible.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::addEncodedBlobToSoupMessageBody):
LayoutTests:
Unskipped a test that now pass.
* platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100485 => 100486)
--- trunk/LayoutTests/ChangeLog 2011-11-16 19:59:12 UTC (rev 100485)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 20:12:42 UTC (rev 100486)
@@ -1,3 +1,14 @@
+2011-11-16 Sergio Villar Senin svil...@igalia.com
+
+[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
+https://bugs.webkit.org/show_bug.cgi?id=69219
+
+Reviewed by Martin Robinson.
+
+Unskipped a test that now pass.
+
+* platform/gtk/Skipped: unskipped http/tests/local/blob/send-hybrid-blob.html
+
2011-11-16 Steve Block stevebl...@google.com
fast/frames/sandboxed-iframe-navigation-targetlink.html crashes occasionally on Chromium Mac dbg
Modified: trunk/LayoutTests/platform/gtk/Skipped (100485 => 100486)
--- trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 19:59:12 UTC (rev 100485)
+++ trunk/LayoutTests/platform/gtk/Skipped 2011-11-16 20:12:42 UTC (rev 100486)
@@ -1533,10 +1533,8 @@
# https://bugs.webkit.org/show_bug.cgi?id=69587
editing/pasteboard/smart-paste-008.html
-# Some tests fail with FAIL Unexpected response data received: Wrong method: GET
-# https://bugs.webkit.org/show_bug.cgi?id=69219
-http/tests/local/fileapi/send-sliced-dragged-file.html
-http/tests/local/blob/send-hybrid-blob.html
+# Fails because it does not throw a couple of expected exceptions
+http/tests/local/fileapi/send-sliced-dragged-file.html
# Microdata DOM API is not yet enabled.
fast/dom/MicroData
Modified: trunk/Source/WebCore/ChangeLog (100485 => 100486)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 19:59:12 UTC (rev 100485)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 20:12:42 UTC (rev 100486)
@@ -1,3 +1,16 @@
+2011-11-16 Sergio Villar Senin svil...@igalia.com
+
+[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
+https://bugs.webkit.org/show_bug.cgi?id=69219
+
+Reviewed by Martin Robinson.
+
+Do not stop appending data to the request body if any of the blob
+items to upload is not accesible.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::addEncodedBlobToSoupMessageBody):
+
2011-11-16 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=72400
Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (100485 => 100486)
--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-11-16 19:59:12 UTC (rev 100485)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2011-11-16 20:12:42 UTC (rev 100486)
@@ -542,37 +542,34 @@
return fileModificationTime != static_casttime_t(blobItem.expectedModificationTime);
}
-static bool addEncodedBlobItemToSoupMessageBody(SoupMessage* message, const BlobDataItem blobItem, unsigned long totalBodySize)
+static void addEncodedBlobItemToSoupMessageBody(SoupMessage* message, const BlobDataItem blobItem, unsigned long totalBodySize)
{
if (blobItem.type == BlobDataItem::Data) {
totalBodySize += blobItem.length;
soup_message_body_append(message-request_body, SOUP_MEMORY_TEMPORARY,
blobItem.data-data() + blobItem.offset, blobItem.length);
-return true;
+return;
}
ASSERT(blobItem.type == BlobDataItem::File);
if (blobIsOutOfDate(blobItem))
-return false;
+return;
-return addFileToSoupMessageBody(message,
-blobItem.path,
-blobItem.offset,
-blobItem.length == BlobDataItem::toEndOfFile ? 0 : blobItem.length,
-totalBodySize);
+addFileToSoupMessageBody(message,
+ blobItem.path,
+ blobItem.offset,
+ blobItem.length == BlobDataItem::toEndOfFile ? 0 : blobItem.length,
+ totalBodySize);
}
-static bool addEncodedBlobToSoupMessageBody(SoupMessage* message, const FormDataElement element, unsigned long totalBodySize)
+static
[webkit-changes] [100487] trunk/Source
Title: [100487] trunk/Source
Revision 100487
Author cfleiz...@apple.com
Date 2011-11-16 12:14:58 -0800 (Wed, 16 Nov 2011)
Log Message
WebKitTestRunner needs to support accessibility-related DRT APIs
https://bugs.webkit.org/show_bug.cgi?id=42131
../WebCore:
Minor changes needed to support AX testing in WKTestRunner.
Reviewed by Beth Dakin.
* WebCore.exp.in:
Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(accessibilitySearchKeyForString):
Remove an unncessary assert that was causing issues with the WK2 test run.
../WebKit2:
Allow the injected bundle to retrieve the focused and root accessibility
objects.
Reviewed by Beth Dakin.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKAccessibilityRootObject):
(WKAccessibilityFocusedObject):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (100486 => 100487)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 20:12:42 UTC (rev 100486)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 20:14:58 UTC (rev 100487)
@@ -1,3 +1,18 @@
+2011-11-16 Chris Fleizach cfleiz...@apple.com
+
+WebKitTestRunner needs to support accessibility-related DRT APIs
+https://bugs.webkit.org/show_bug.cgi?id=42131
+
+Minor changes needed to support AX testing in WKTestRunner.
+
+Reviewed by Beth Dakin.
+
+* WebCore.exp.in:
+ Expose focusedUIElementForPage so that the WK2 injected bundle can retrieve it.
+* accessibility/mac/WebAccessibilityObjectWrapper.mm:
+(accessibilitySearchKeyForString):
+Remove an unncessary assert that was causing issues with the WK2 test run.
+
2011-11-16 Sergio Villar Senin svil...@igalia.com
[Soup] Somet tests fail with FAIL Unexpected response data received: Wrong method: GET
Modified: trunk/Source/WebCore/WebCore.exp.in (100486 => 100487)
--- trunk/Source/WebCore/WebCore.exp.in 2011-11-16 20:12:42 UTC (rev 100486)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-11-16 20:14:58 UTC (rev 100487)
@@ -310,6 +310,7 @@
__ZN7WebCore13AXObjectCache10rootObjectEv
__ZN7WebCore13AXObjectCache18rootObjectForFrameEPNS_5FrameE
__ZN7WebCore13AXObjectCache21gAccessibilityEnabledE
+__ZN7WebCore13AXObjectCache23focusedUIElementForPageEPKNS_4PageE
__ZN7WebCore13AXObjectCache42gAccessibilityEnhancedUserInterfaceEnabledE
__ZN7WebCore13HTTPHeaderMapC1Ev
__ZN7WebCore13HTTPHeaderMapD1Ev
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm (100486 => 100487)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2011-11-16 20:12:42 UTC (rev 100486)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm 2011-11-16 20:14:58 UTC (rev 100487)
@@ -495,7 +495,8 @@
static AccessibilitySearchKey accessibilitySearchKeyForString(const String value)
{
-ASSERT(!value.isEmpty());
+if (value.isEmpty())
+return AnyTypeSearchKey;
static const AccessibilitySearchKeyMap* searchKeyMap = createAccessibilitySearchKeyMap();
Modified: trunk/Source/WebKit2/ChangeLog (100486 => 100487)
--- trunk/Source/WebKit2/ChangeLog 2011-11-16 20:12:42 UTC (rev 100486)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-16 20:14:58 UTC (rev 100487)
@@ -1,3 +1,18 @@
+2011-11-16 Chris Fleizach cfleiz...@apple.com
+
+WebKitTestRunner needs to support accessibility-related DRT APIs
+https://bugs.webkit.org/show_bug.cgi?id=42131
+
+Allow the injected bundle to retrieve the focused and root accessibility
+objects.
+
+Reviewed by Beth Dakin.
+
+* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
+(WKAccessibilityRootObject):
+(WKAccessibilityFocusedObject):
+* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
+
2011-11-16 Beth Dakin bda...@apple.com
https://bugs.webkit.org/show_bug.cgi?id=72400
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (100486 => 100487)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2011-11-16 20:12:42 UTC (rev 100486)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2011-11-16 20:14:58 UTC (rev 100487)
@@ -37,7 +37,11 @@
#include WebURL.h
#include WebURLRequest.h
+#include WebCore/AXObjectCache.h
+#include WebCore/AccessibilityObject.h
+#include WebCore/Frame.h
#include WebCore/KURL.h
+#include WebCore/Page.h
using namespace WebKit;
@@ -126,6 +130,46 @@
return toAPI(toImpl(pageRef)-mainWebFrame());
}
+void*
[webkit-changes] [100489] trunk/Source/WebCore
Title: [100489] trunk/Source/WebCore
Revision 100489
Author rob...@webkit.org
Date 2011-11-16 12:25:19 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, rolling out r100479.
http://trac.webkit.org/changeset/100479
https://bugs.webkit.org/show_bug.cgi?id=72533
Broke the Mac Build (Requested by mwenge2 on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-16
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderingAllInOne.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/RenderingAllInOne.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100488 => 100489)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 20:17:22 UTC (rev 100488)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 20:25:19 UTC (rev 100489)
@@ -1,3 +1,15 @@
+2011-11-16 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100479.
+http://trac.webkit.org/changeset/100479
+https://bugs.webkit.org/show_bug.cgi?id=72533
+
+Broke the Mac Build (Requested by mwenge2 on #webkit).
+
+* WebCore.vcproj/WebCore.vcproj:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/RenderingAllInOne.cpp:
+
2011-11-16 Chris Fleizach cfleiz...@apple.com
WebKitTestRunner needs to support accessibility-related DRT APIs
Modified: trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj (100488 => 100489)
--- trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-16 20:17:22 UTC (rev 100488)
+++ trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj 2011-11-16 20:25:19 UTC (rev 100489)
@@ -38178,62 +38178,6 @@
/File
File
-RelativePath=..\rendering\RenderTableCaption.cpp
-
-FileConfiguration
- Name=Debug|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
-FileConfiguration
- Name=Release|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
-FileConfiguration
- Name=Debug_Cairo_CFLite|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
-FileConfiguration
- Name=Release_Cairo_CFLite|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
-FileConfiguration
- Name=Debug_All|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
-FileConfiguration
- Name=Production|Win32
- ExcludedFromBuild=true
-
- Tool
- Name=VCCLCompilerTool
- /
-/FileConfiguration
- /File
- File
-RelativePath=..\rendering\RenderTableCaption.h
-
- /File
- File
RelativePath=..\rendering\RenderTableCell.cpp
FileConfiguration
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (100488 => 100489)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-16 20:17:22 UTC (rev 100488)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2011-11-16 20:25:19 UTC (rev 100489)
@@ -3934,8 +3934,6 @@
A8DF4AE80980C42C0052981B /* RenderTableCol.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4ADE0980C42C0052981B /* RenderTableCol.cpp */; };
A8DF4AE90980C42C0052981B /* RenderTableCell.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4ADF0980C42C0052981B /* RenderTableCell.h */; };
A8DF4AEA0980C42C0052981B /* RenderTableCell.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE00980C42C0052981B /* RenderTableCell.cpp */; };
- A8DF4AE90980C42C0052981B /* RenderTableCaption.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4ADF0980C42C0052981B /* RenderTableCaption.h */; };
- A8DF4AEA0980C42C0052981B /* RenderTableCaption.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE00980C42C0052981B /* RenderTableCaption.cpp */; };
A8DF4AEB0980C42C0052981B /* RenderTable.h in Headers */ = {isa = PBXBuildFile; fileRef = A8DF4AE10980C42C0052981B /* RenderTable.h */; };
A8DF4AEC0980C42C0052981B /* RenderTable.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE20980C42C0052981B /* RenderTable.cpp */; };
A8DF4AED0980C42C0052981B /* RenderTableSection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A8DF4AE30980C42C0052981B /* RenderTableSection.cpp */; };
Modified: trunk/Source/WebCore/rendering/RenderingAllInOne.cpp (100488 => 100489)
--- trunk/Source/WebCore/rendering/RenderingAllInOne.cpp 2011-11-16 20:17:22 UTC (rev 100488)
+++ trunk/Source/WebCore/rendering/RenderingAllInOne.cpp 2011-11-16 20:25:19 UTC (rev 100489)
@@ -92,7 +92,6 @@
#include RenderSlider.cpp
#include RenderSummary.cpp
#include RenderTable.cpp
-#include RenderTableCaption.cpp
#include RenderTableCell.cpp
#include RenderTableCol.cpp
#include RenderTableRow.cpp
[webkit-changes] [100490] trunk
Title: [100490] trunk
Revision 100490
Author rob...@webkit.org
Date 2011-11-16 12:27:58 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, rolling out r100473.
http://trac.webkit.org/changeset/100473
https://bugs.webkit.org/show_bug.cgi?id=72534
Broke the Mac Build (Requested by mwenge2 on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-16
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
(WebCore::RenderObject::addChild):
* rendering/RenderObject.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/RenderTable.h:
* rendering/RenderTableCaption.cpp: Removed.
* rendering/RenderTableCaption.h: Removed.
LayoutTests:
* css2.1/20110323/border-collapse-offset-002.htm: Removed.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
* platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
* platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
* platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
* platform/mac/fast/repaint/table-section-repaint-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png
trunk/LayoutTests/platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt
trunk/LayoutTests/platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt
trunk/LayoutTests/platform/mac/fast/repaint/table-section-repaint-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/RenderTable.h
Removed Paths
trunk/LayoutTests/css2.1/20110323/border-collapse-offset-002.htm
trunk/LayoutTests/platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png
trunk/LayoutTests/platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt
trunk/Source/WebCore/rendering/RenderTableCaption.cpp
trunk/Source/WebCore/rendering/RenderTableCaption.h
Diff
Modified: trunk/LayoutTests/ChangeLog (100489 => 100490)
--- trunk/LayoutTests/ChangeLog 2011-11-16 20:25:19 UTC (rev 100489)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 20:27:58 UTC (rev 100490)
@@ -1,3 +1,21 @@
+2011-11-16 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100473.
+http://trac.webkit.org/changeset/100473
+https://bugs.webkit.org/show_bug.cgi?id=72534
+
+Broke the Mac Build (Requested by mwenge2 on #webkit).
+
+* css2.1/20110323/border-collapse-offset-002.htm: Removed.
+* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.png: Removed.
+* platform/chromium-linux-x86/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
+* platform/chromium-linux/fast/dom/HTMLTableElement/colSpan-expected.png:
+* platform/chromium-linux/fast/dom/HTMLTableElement/createCaption-expected.png:
+* platform/chromium-win/fast/css/bidi-override-in-anonymous-block-expected.txt:
+* platform/chromium-win/fast/dom/HTMLTableElement/colSpan-expected.txt:
+* platform/chromium-win/fast/dom/HTMLTableElement/createCaption-expected.txt:
+* platform/mac/fast/repaint/table-section-repaint-expected.txt:
+
2011-11-16 Chris Fleizach cfleiz...@apple.com
WebKitTestRunner needs to support accessibility-related DRT APIs
Deleted: trunk/LayoutTests/css2.1/20110323/border-collapse-offset-002.htm (100489 => 100490)
--- trunk/LayoutTests/css2.1/20110323/border-collapse-offset-002.htm 2011-11-16 20:25:19 UTC (rev 100489)
+++ trunk/LayoutTests/css2.1/20110323/border-collapse-offset-002.htm 2011-11-16 20:27:58 UTC (rev 100490)
@@ -1,23 +0,0 @@
-!DOCTYPE html PUBLIC -//W3C//DTD HTML 4.01//EN http://www.w3.org/TR/html4/strict.dtd
-htmlhead
-titleCSS Test: border collapse/title
-link rel=author title=Bernd Mielke href=""
-link rel=help href=""
-link rel=match href=""
-meta name=flags content=
-style type=text/css
-td {width: 100px;
[webkit-changes] [100491] trunk/Tools
Title: [100491] trunk/Tools Revision 100491 Author dpra...@chromium.org Date 2011-11-16 12:42:38 -0800 (Wed, 16 Nov 2011) Log Message Run a dummy test in the gpu configurations if there's nothing to do. https://bugs.webkit.org/show_bug.cgi?id=72498 Reviewed by James Robinson. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py Diff Modified: trunk/Tools/ChangeLog (100490 => 100491) --- trunk/Tools/ChangeLog 2011-11-16 20:27:58 UTC (rev 100490) +++ trunk/Tools/ChangeLog 2011-11-16 20:42:38 UTC (rev 100491) @@ -1,3 +1,12 @@ +2011-11-16 Dirk Pranke dpra...@chromium.org + +Run a dummy test in the gpu configurations if there's nothing to do. +https://bugs.webkit.org/show_bug.cgi?id=72498 + +Reviewed by James Robinson. + +* Scripts/webkitpy/layout_tests/port/chromium_gpu.py: + 2011-11-16 Chris Fleizach cfleiz...@apple.com WebKitTestRunner needs to support accessibility-related DRT APIs Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (100490 => 100491) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 20:27:58 UTC (rev 100490) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 20:42:38 UTC (rev 100491) @@ -92,6 +92,14 @@ # in running the tests there. paths += ['fast/canvas', 'canvas/philip'] +if not paths: +# FIXME: This is a hack until we can turn of the webkit_gpu +# tests on the bots. If paths is empty, test_files.find() +# finds *everything*. However, we have to return something, +# or NRWT thinks there's something wrong. So, we return a single +# dummy test. See https://bugs.webkit.org/show_bug.cgi?id=72498. +paths = ['fast/html/article-element.html'] + return set([port.relative_test_filename(f) for f in test_files.find(port, paths)]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100492] trunk/Source/WebCore
Title: [100492] trunk/Source/WebCore
Revision 100492
Author aes...@apple.com
Date 2011-11-16 12:43:11 -0800 (Wed, 16 Nov 2011)
Log Message
Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=72535
Reviewed by Anders Carlsson.
LayerFlushScheduler attempted to use a counter strategy for calls to
suspend() and resume(), which allowed us to assert that these calls
were balanced. Unfortunately it is hard to guarantee this in WebKit2,
where we sometimes try to call suspend() before we've entered
compositing mode (hence before we have a LayerTreeHost and a
LayerFlushScheduler). When we later call resume(), this call ends up
being unbalanced and asserts.
For now, remove the assertions and allow unbalanced calls to suspend()
and resume().
* platform/graphics/ca/LayerFlushScheduler.cpp:
(WebCore::LayerFlushScheduler::suspend):
(WebCore::LayerFlushScheduler::resume):
* platform/graphics/ca/LayerFlushScheduler.h:
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::LayerFlushScheduler):
(WebCore::LayerFlushScheduler::runLoopObserverCallback):
(WebCore::LayerFlushScheduler::schedule):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp
trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h
trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100491 => 100492)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 20:42:38 UTC (rev 100491)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 20:43:11 UTC (rev 100492)
@@ -1,3 +1,30 @@
+2011-11-16 Andy Estes aes...@apple.com
+
+Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
+https://bugs.webkit.org/show_bug.cgi?id=72535
+
+Reviewed by Anders Carlsson.
+
+LayerFlushScheduler attempted to use a counter strategy for calls to
+suspend() and resume(), which allowed us to assert that these calls
+were balanced. Unfortunately it is hard to guarantee this in WebKit2,
+where we sometimes try to call suspend() before we've entered
+compositing mode (hence before we have a LayerTreeHost and a
+LayerFlushScheduler). When we later call resume(), this call ends up
+being unbalanced and asserts.
+
+For now, remove the assertions and allow unbalanced calls to suspend()
+and resume().
+
+* platform/graphics/ca/LayerFlushScheduler.cpp:
+(WebCore::LayerFlushScheduler::suspend):
+(WebCore::LayerFlushScheduler::resume):
+* platform/graphics/ca/LayerFlushScheduler.h:
+* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
+(WebCore::LayerFlushScheduler::LayerFlushScheduler):
+(WebCore::LayerFlushScheduler::runLoopObserverCallback):
+(WebCore::LayerFlushScheduler::schedule):
+
2011-11-16 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100473.
Modified: trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp (100491 => 100492)
--- trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp 2011-11-16 20:42:38 UTC (rev 100491)
+++ trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp 2011-11-16 20:43:11 UTC (rev 100492)
@@ -33,19 +33,20 @@
void LayerFlushScheduler::suspend()
{
-if (!m_suspendCount)
-invalidate();
+if (m_isSuspended)
+return;
-++m_suspendCount;
+m_isSuspended = true;
+invalidate();
}
void LayerFlushScheduler::resume()
{
-ASSERT(m_suspendCount);
---m_suspendCount;
+if (!m_isSuspended)
+return;
-if (!m_suspendCount)
-schedule();
+m_isSuspended = false;
+schedule();
}
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h (100491 => 100492)
--- trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h 2011-11-16 20:42:38 UTC (rev 100491)
+++ trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h 2011-11-16 20:43:11 UTC (rev 100492)
@@ -47,7 +47,7 @@
void resume();
private:
-unsigned int m_suspendCount;
+bool m_isSuspended;
LayerFlushSchedulerClient* m_client;
#if PLATFORM(MAC)
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp (100491 => 100492)
--- trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp 2011-11-16 20:42:38 UTC (rev 100491)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp 2011-11-16 20:43:11 UTC (rev 100492)
@@ -35,7 +35,7 @@
static const CFIndex LayerFlushRunLoopOrder = CoreAnimationRunLoopOrder - 1;
LayerFlushScheduler::LayerFlushScheduler(LayerFlushSchedulerClient* client)
-: m_suspendCount(0)
+: m_isSuspended(false)
, m_client(client)
{
[webkit-changes] [100493] trunk/Source/JavaScriptCore
Title: [100493] trunk/Source/_javascript_Core
Revision 100493
Author mhahnenb...@apple.com
Date 2011-11-16 12:50:31 -0800 (Wed, 16 Nov 2011)
Log Message
De-virtualize ExecutableBase::clearCodeVirtual
https://bugs.webkit.org/show_bug.cgi?id=72337
Reviewed by Darin Adler.
Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
and had the finalize functions call the corresponding clearCode methods.
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::NativeExecutable::finalize):
(JSC::EvalExecutable::finalize):
(JSC::EvalExecutable::clearCode):
(JSC::ProgramExecutable::finalize):
(JSC::ProgramExecutable::clearCode):
(JSC::FunctionExecutable::discardCode):
(JSC::FunctionExecutable::finalize):
(JSC::FunctionExecutable::clearCode):
* runtime/Executable.h:
(JSC::ExecutableBase::finishCreation):
(JSC::NativeExecutable::create):
(JSC::EvalExecutable::create):
(JSC::ProgramExecutable::create):
(JSC::FunctionExecutable::create):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/Executable.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100492 => 100493)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 20:43:11 UTC (rev 100492)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 20:50:31 UTC (rev 100493)
@@ -1,3 +1,31 @@
+2011-11-16 Mark Hahnenberg mhahnenb...@apple.com
+
+De-virtualize ExecutableBase::clearCodeVirtual
+https://bugs.webkit.org/show_bug.cgi?id=72337
+
+Reviewed by Darin Adler.
+
+Added static finalize functions to the subclasses of ExecutableBase that provide an implementation
+of clearCodeVirtual, changed all of the clearCodeVirtual methods to non-virtual clearCode method,
+and had the finalize functions call the corresponding clearCode methods.
+
+* runtime/Executable.cpp:
+(JSC::ExecutableBase::clearCode):
+(JSC::NativeExecutable::finalize):
+(JSC::EvalExecutable::finalize):
+(JSC::EvalExecutable::clearCode):
+(JSC::ProgramExecutable::finalize):
+(JSC::ProgramExecutable::clearCode):
+(JSC::FunctionExecutable::discardCode):
+(JSC::FunctionExecutable::finalize):
+(JSC::FunctionExecutable::clearCode):
+* runtime/Executable.h:
+(JSC::ExecutableBase::finishCreation):
+(JSC::NativeExecutable::create):
+(JSC::EvalExecutable::create):
+(JSC::ProgramExecutable::create):
+(JSC::FunctionExecutable::create):
+
2011-11-16 Yusuke Suzuki utatane@gmail.com
String new RegExp('\n').toString() returns is invalid RegularExpressionLiteral
Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (100492 => 100493)
--- trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-11-16 20:43:11 UTC (rev 100492)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp 2011-11-16 20:50:31 UTC (rev 100493)
@@ -38,13 +38,8 @@
const ClassInfo ExecutableBase::s_info = { Executable, 0, 0, 0, CREATE_METHOD_TABLE(ExecutableBase) };
-void ExecutableBase::clearCode(JSCell* cell)
+inline void ExecutableBase::clearCode()
{
-jsCastExecutableBase*(cell)-clearCodeVirtual();
-}
-
-void ExecutableBase::clearCodeVirtual()
-{
#if ENABLE(JIT)
m_jitCodeForCall.clear();
m_jitCodeForConstruct.clear();
@@ -89,6 +84,11 @@
}
#endif
+void NativeExecutable::finalize(JSCell* cell)
+{
+jsCastNativeExecutable*(cell)-clearCode();
+}
+
const ClassInfo ScriptExecutable::s_info = { ScriptExecutable, ExecutableBase::s_info, 0, 0, CREATE_METHOD_TABLE(ScriptExecutable) };
const ClassInfo EvalExecutable::s_info = { EvalExecutable, ScriptExecutable::s_info, 0, 0, CREATE_METHOD_TABLE(EvalExecutable) };
@@ -256,13 +256,18 @@
#endif
}
-void EvalExecutable::clearCodeVirtual()
+void EvalExecutable::finalize(JSCell* cell)
{
+jsCastEvalExecutable*(cell)-clearCode();
+}
+
+inline void EvalExecutable::clearCode()
+{
if (m_evalCodeBlock) {
m_evalCodeBlock-clearEvalCache();
m_evalCodeBlock.clear();
}
-Base::clearCodeVirtual();
+Base::clearCode();
}
JSObject* ProgramExecutable::checkSyntax(ExecState* exec)
@@ -395,13 +400,18 @@
thisObject-m_programCodeBlock-visitAggregate(visitor);
}
-void ProgramExecutable::clearCodeVirtual()
+void ProgramExecutable::finalize(JSCell* cell)
{
+jsCastProgramExecutable*(cell)-clearCode();
+}
+
+inline void ProgramExecutable::clearCode()
+{
if (m_programCodeBlock) {
m_programCodeBlock-clearEvalCache();
m_programCodeBlock.clear();
}
-Base::clearCodeVirtual();
+Base::clearCode();
}
FunctionCodeBlock* FunctionExecutable::baselineCodeBlockFor(CodeSpecializationKind kind)
@@ -654,11 +664,16 @@
if (!m_jitCodeForConstruct
[webkit-changes] [100494] trunk/Tools
Title: [100494] trunk/Tools Revision 100494 Author t...@chromium.org Date 2011-11-16 13:03:48 -0800 (Wed, 16 Nov 2011) Log Message [NRWT] refactor drivers to require pixel_tests param https://bugs.webkit.org/show_bug.cgi?id=72517 Reviewed by Ojan Vafai. No tests, just a refactoring. * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py Diff Modified: trunk/Tools/ChangeLog (100493 => 100494) --- trunk/Tools/ChangeLog 2011-11-16 20:50:31 UTC (rev 100493) +++ trunk/Tools/ChangeLog 2011-11-16 21:03:48 UTC (rev 100494) @@ -1,3 +1,17 @@ +2011-11-16 Tony Chang t...@chromium.org + +[NRWT] refactor drivers to require pixel_tests param +https://bugs.webkit.org/show_bug.cgi?id=72517 + +Reviewed by Ojan Vafai. + +No tests, just a refactoring. + +* Scripts/webkitpy/layout_tests/port/chromium.py: +* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: +* Scripts/webkitpy/layout_tests/port/webkit.py: +* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: + 2011-11-16 Dirk Pranke dpra...@chromium.org Run a dummy test in the gpu configurations if there's nothing to do. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (100493 => 100494) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-11-16 20:50:31 UTC (rev 100493) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-11-16 21:03:48 UTC (rev 100494) @@ -399,7 +399,7 @@ # FIXME: This should inherit from WebKitDriver now that Chromium has a DumpRenderTree process like the rest of WebKit. class ChromiumDriver(Driver): -def __init__(self, port, worker_number, pixel_tests=True): +def __init__(self, port, worker_number, pixel_tests): Driver.__init__(self, port, worker_number, pixel_tests) self._proc = None self._image_path = None Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py (100493 => 100494) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2011-11-16 20:50:31 UTC (rev 100493) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2011-11-16 21:03:48 UTC (rev 100494) @@ -50,8 +50,7 @@ class ChromiumDriverTest(unittest.TestCase): def setUp(self): mock_port = Mock() -mock_port.get_option = lambda option_name: '' -self.driver = chromium.ChromiumDriver(mock_port, worker_number=0) +self.driver = chromium.ChromiumDriver(mock_port, worker_number=0, pixel_tests=True) def test_test_shell_command(self): expected_command = test.html 2 checksum\n @@ -123,7 +122,7 @@ class MockDriver(chromium.ChromiumDriver): def __init__(self): -chromium.ChromiumDriver.__init__(self, mock_port, worker_number=0) +chromium.ChromiumDriver.__init__(self, mock_port, worker_number=0, pixel_tests=False) def cmd_line(self): return 'python' Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (100493 => 100494) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-16 20:50:31 UTC (rev 100493) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2011-11-16 21:03:48 UTC (rev 100494) @@ -440,7 +440,7 @@ class WebKitDriver(Driver): WebKit implementation of the DumpRenderTree/WebKitTestRunner interface. -def __init__(self, port, worker_number, pixel_tests=False): +def __init__(self, port, worker_number, pixel_tests): Driver.__init__(self, port, worker_number, pixel_tests) self._driver_tempdir = port._filesystem.mkdtemp(prefix='%s-' % self._port.driver_name()) # WebKitTestRunner can report back subprocess crashes by printing Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py (100493 => 100494) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-11-16 20:50:31 UTC (rev 100493) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py 2011-11-16 21:03:48 UTC (rev 100494) @@ -255,7 +255,7 @@ class WebKitDriverTest(unittest.TestCase): def test_read_block(self): port = TestWebKitPort() -driver = WebKitDriver(port, 0) +driver = WebKitDriver(port, 0, pixel_tests=False) driver._server_process = MockServerProcess([ 'ActualHash: foobar', 'Content-Type: my_type', @@ -269,7 +269,7 @@ def test_read_binary_block(self): port = TestWebKitPort() -driver
[webkit-changes] [100495] trunk/Source
Title: [100495] trunk/Source
Revision 100495
Author commit-qu...@webkit.org
Date 2011-11-16 13:07:20 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed, rolling out r100438.
http://trac.webkit.org/changeset/100438
https://bugs.webkit.org/show_bug.cgi?id=72536
Broke unit tests (Requested by jamesr_ on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-16
Source/WebCore:
* platform/PlatformScreen.h:
* platform/chromium/PlatformScreenChromium.cpp:
* platform/chromium/PlatformSupport.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):
Source/WebKit/chromium:
* public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
* src/PlatformSupport.cpp:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/PlatformScreen.h
trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp
trunk/Source/WebCore/platform/chromium/PlatformSupport.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebScreenInfo.h
trunk/Source/WebKit/chromium/src/PlatformSupport.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100494 => 100495)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 21:03:48 UTC (rev 100494)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 21:07:20 UTC (rev 100495)
@@ -1,3 +1,19 @@
+2011-11-16 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r100438.
+http://trac.webkit.org/changeset/100438
+https://bugs.webkit.org/show_bug.cgi?id=72536
+
+Broke unit tests (Requested by jamesr_ on #webkit).
+
+* platform/PlatformScreen.h:
+* platform/chromium/PlatformScreenChromium.cpp:
+* platform/chromium/PlatformSupport.h:
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::CCSettings::CCSettings):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::initializeImplOnImplThread):
+
2011-11-16 Andy Estes aes...@apple.com
Assertion failure in LayerFlushScheduler::resume() when running some layout tests in WebKitTestRunner
Modified: trunk/Source/WebCore/platform/PlatformScreen.h (100494 => 100495)
--- trunk/Source/WebCore/platform/PlatformScreen.h 2011-11-16 21:03:48 UTC (rev 100494)
+++ trunk/Source/WebCore/platform/PlatformScreen.h 2011-11-16 21:07:20 UTC (rev 100495)
@@ -54,11 +54,6 @@
FloatRect screenRect(Widget*);
FloatRect screenAvailableRect(Widget*);
-#if PLATFORM(CHROMIUM)
-// Measured in frames per second. 0 if the refresh rate is unknown, or not applicable.
-double screenRefreshRate(Widget*);
-#endif
-
#if PLATFORM(MAC)
NSScreen *screenForWindow(NSWindow *);
Modified: trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp (100494 => 100495)
--- trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp 2011-11-16 21:03:48 UTC (rev 100494)
+++ trunk/Source/WebCore/platform/chromium/PlatformScreenChromium.cpp 2011-11-16 21:07:20 UTC (rev 100495)
@@ -61,9 +61,4 @@
return PlatformSupport::screenAvailableRect(widget);
}
-double screenRefreshRate(Widget* widget)
-{
-return PlatformSupport::screenRefreshRate(widget);
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/chromium/PlatformSupport.h (100494 => 100495)
--- trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-11-16 21:03:48 UTC (rev 100494)
+++ trunk/Source/WebCore/platform/chromium/PlatformSupport.h 2011-11-16 21:07:20 UTC (rev 100495)
@@ -234,7 +234,6 @@
static bool screenIsMonochrome(Widget*);
static IntRect screenRect(Widget*);
static IntRect screenAvailableRect(Widget*);
-static double screenRefreshRate(Widget*);
// SharedTimers ---
static void setSharedTimerFiredFunction(void (*func)());
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (100494 => 100495)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-11-16 21:03:48 UTC (rev 100494)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2011-11-16 21:07:20 UTC (rev 100495)
@@ -73,15 +73,13 @@
, compositeOffscreen(false)
, enableCompositorThread(false)
, showFPSCounter(false)
-, showPlatformLayerTree(false)
-, refreshRate(0) { }
+, showPlatformLayerTree(false) { }
bool acceleratePainting;
bool compositeOffscreen;
bool enableCompositorThread;
bool showFPSCounter;
bool showPlatformLayerTree;
-double refreshRate;
};
[webkit-changes] [100496] trunk/Source/WebCore
Title: [100496] trunk/Source/WebCore Revision 100496 Author commit-qu...@webkit.org Date 2011-11-16 13:11:24 -0800 (Wed, 16 Nov 2011) Log Message [chromium] Add null pointer check in setDeviceScaleFactor https://bugs.webkit.org/show_bug.cgi?id=72464 Patch by Alexandre Elias ael...@google.com on 2011-11-16 Reviewed by James Robinson. No new tests. (Tiny fix.) * page/Page.cpp: (WebCore::Page::setDeviceScaleFactor): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/Page.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (100495 => 100496) --- trunk/Source/WebCore/ChangeLog 2011-11-16 21:07:20 UTC (rev 100495) +++ trunk/Source/WebCore/ChangeLog 2011-11-16 21:11:24 UTC (rev 100496) @@ -1,3 +1,15 @@ +2011-11-16 Alexandre Elias ael...@google.com + +[chromium] Add null pointer check in setDeviceScaleFactor +https://bugs.webkit.org/show_bug.cgi?id=72464 + +Reviewed by James Robinson. + +No new tests. (Tiny fix.) + +* page/Page.cpp: +(WebCore::Page::setDeviceScaleFactor): + 2011-11-16 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r100438. Modified: trunk/Source/WebCore/page/Page.cpp (100495 => 100496) --- trunk/Source/WebCore/page/Page.cpp 2011-11-16 21:07:20 UTC (rev 100495) +++ trunk/Source/WebCore/page/Page.cpp 2011-11-16 21:11:24 UTC (rev 100496) @@ -656,7 +656,8 @@ setNeedsRecalcStyleInAllFrames(); #if USE(ACCELERATED_COMPOSITING) -m_mainFrame-deviceOrPageScaleFactorChanged(); +if (mainFrame()) +mainFrame()-deviceOrPageScaleFactorChanged(); #endif for (Frame* frame = mainFrame(); frame; frame = frame-tree()-traverseNext()) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100497] trunk/Source/WebKit/chromium
Title: [100497] trunk/Source/WebKit/chromium
Revision 100497
Author commit-qu...@webkit.org
Date 2011-11-16 13:14:18 -0800 (Wed, 16 Nov 2011)
Log Message
Fix up chromium API for creating events, initializing message events
https://bugs.webkit.org/show_bug.cgi?id=71478
- Fix a mistake when checking the exception code during event creation.
- Change WebFrame parameter to pointer so that NULL may be passed.
This is required for the following chromium CL: http://codereview.chromium.org/8437093/
Tested in Chromium by:
ui_test --gtest_filter=*PPAPITest.PostMessage*
Patch by Dave Michael dmich...@chromium.org on 2011-11-16
Reviewed by Darin Fisher.
* public/WebDOMMessageEvent.h:
* src/WebDOMMessageEvent.cpp:
(WebKit::WebDOMMessageEvent::initMessageEvent):
* src/WebDocument.cpp:
(WebKit::WebDocument::createEvent):
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h
trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
trunk/Source/WebKit/chromium/src/WebDocument.cpp
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (100496 => 100497)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-16 21:11:24 UTC (rev 100496)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-16 21:14:18 UTC (rev 100497)
@@ -1,3 +1,24 @@
+2011-11-16 Dave Michael dmich...@chromium.org
+
+Fix up chromium API for creating events, initializing message events
+https://bugs.webkit.org/show_bug.cgi?id=71478
+
+- Fix a mistake when checking the exception code during event creation.
+- Change WebFrame parameter to pointer so that NULL may be passed.
+
+This is required for the following chromium CL: http://codereview.chromium.org/8437093/
+
+Tested in Chromium by:
+ ui_test --gtest_filter=*PPAPITest.PostMessage*
+
+Reviewed by Darin Fisher.
+
+* public/WebDOMMessageEvent.h:
+* src/WebDOMMessageEvent.cpp:
+(WebKit::WebDOMMessageEvent::initMessageEvent):
+* src/WebDocument.cpp:
+(WebKit::WebDocument::createEvent):
+
2011-11-16 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r100438.
Modified: trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h (100496 => 100497)
--- trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h 2011-11-16 21:11:24 UTC (rev 100496)
+++ trunk/Source/WebKit/chromium/public/WebDOMMessageEvent.h 2011-11-16 21:14:18 UTC (rev 100497)
@@ -45,7 +45,7 @@
class WebDOMMessageEvent : public WebDOMEvent {
public:
-WEBKIT_EXPORT void initMessageEvent(const WebString type, bool canBubble, bool cancelable, const WebSerializedScriptValue messageData, const WebString origin, const WebFrame sourceFrame, const WebString lastEventId);
+WEBKIT_EXPORT void initMessageEvent(const WebString type, bool canBubble, bool cancelable, const WebSerializedScriptValue messageData, const WebString origin, const WebFrame* sourceFrame, const WebString lastEventId);
};
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp (100496 => 100497)
--- trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp 2011-11-16 21:11:24 UTC (rev 100496)
+++ trunk/Source/WebKit/chromium/src/WebDOMMessageEvent.cpp 2011-11-16 21:14:18 UTC (rev 100497)
@@ -49,11 +49,13 @@
namespace WebKit {
-void WebDOMMessageEvent::initMessageEvent(const WebString type, bool canBubble, bool cancelable, const WebSerializedScriptValue messageData, const WebString origin, const WebFrame sourceFrame, const WebString lastEventId)
+void WebDOMMessageEvent::initMessageEvent(const WebString type, bool canBubble, bool cancelable, const WebSerializedScriptValue messageData, const WebString origin, const WebFrame* sourceFrame, const WebString lastEventId)
{
ASSERT(m_private);
ASSERT(isMessageEvent());
-DOMWindow* window = static_castconst WebFrameImpl(sourceFrame).frame()-domWindow();
+DOMWindow* window = 0;
+if (sourceFrame)
+window = static_castconst WebFrameImpl*(sourceFrame)-frame()-domWindow();
OwnPtrMessagePortArray ports;
unwrapMessageEvent()-initMessageEvent(type, canBubble, cancelable, messageData, origin, lastEventId, window, ports.release());
}
Modified: trunk/Source/WebKit/chromium/src/WebDocument.cpp (100496 => 100497)
--- trunk/Source/WebKit/chromium/src/WebDocument.cpp 2011-11-16 21:11:24 UTC (rev 100496)
+++ trunk/Source/WebKit/chromium/src/WebDocument.cpp 2011-11-16 21:14:18 UTC (rev 100497)
@@ -203,7 +203,7 @@
{
ExceptionCode ec = 0;
WebDOMEvent event(unwrapDocument()-createEvent(eventType, ec));
-if (!ec)
+if (ec)
return WebDOMEvent();
return event;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100498] trunk/LayoutTests
Title: [100498] trunk/LayoutTests Revision 100498 Author jam...@google.com Date 2011-11-16 13:22:15 -0800 (Wed, 16 Nov 2011) Log Message [chromium] Update chromium expectations for fast/media/mq-transform-0[23].html to reflect that chromium DRT has 2d and 3d transforms enabled * platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-cg-mac-leopard/fast/media/mq-transform-02-expected.txt: Added. * platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-cg-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added. * platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-cg-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-gpu-cg-mac/fast/media/mq-transform-02-expected.txt: Added. * platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-gpu-cg-mac/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-linux-x86/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-linux-x86/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt. * platform/chromium-linux-x86/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-linux-x86/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-linux/fast/media/mq-transform-02-expected.png: * platform/chromium-linux/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt. * platform/chromium-linux/fast/media/mq-transform-03-expected.png: * platform/chromium-linux/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png: * platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.txt: Added. * platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png: * platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt: Added. * platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-win-vista/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-win-vista/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt. * platform/chromium-win-vista/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-win-vista/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-win-xp/fast/media/mq-transform-02-expected.png: Added. * platform/chromium-win-xp/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.txt. * platform/chromium-win-xp/fast/media/mq-transform-03-expected.png: Added. * platform/chromium-win-xp/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/media/mq-transform-03-expected.txt. * platform/chromium-win/fast/media/mq-transform-02-expected.png: * platform/chromium-win/fast/media/mq-transform-02-expected.txt: * platform/chromium-win/fast/media/mq-transform-03-expected.png: * platform/chromium-win/fast/media/mq-transform-03-expected.txt: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-linux/fast/media/mq-transform-02-expected.png trunk/LayoutTests/platform/chromium-linux/fast/media/mq-transform-03-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/media/mq-transform-02-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/fast/media/mq-transform-03-expected.png trunk/LayoutTests/platform/chromium-win/fast/media/mq-transform-02-expected.png
[webkit-changes] [100499] trunk/Tools
Title: [100499] trunk/Tools
Revision 100499
Author le...@chromium.org
Date 2011-11-16 13:51:15 -0800 (Wed, 16 Nov 2011)
Log Message
check-webkit-style should recognize functions even if they have OVERRIDE after them.
https://bugs.webkit.org/show_bug.cgi?id=72515
Reviewed by Adam Barth.
* Scripts/webkitpy/style/checkers/cpp.py:
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (100498 => 100499)
--- trunk/Tools/ChangeLog 2011-11-16 21:22:15 UTC (rev 100498)
+++ trunk/Tools/ChangeLog 2011-11-16 21:51:15 UTC (rev 100499)
@@ -1,3 +1,13 @@
+2011-11-16 David Levin le...@chromium.org
+
+check-webkit-style should recognize functions even if they have OVERRIDE after them.
+https://bugs.webkit.org/show_bug.cgi?id=72515
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+
2011-11-16 Tony Chang t...@chromium.org
[NRWT] refactor drivers to require pixel_tests param
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (100498 => 100499)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-11-16 21:22:15 UTC (rev 100498)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-11-16 21:51:15 UTC (rev 100499)
@@ -2143,12 +2143,12 @@
# ')', or ') const' and doesn't begin with 'if|for|while|switch|else'.
# We also allow '#' for #endif and '=' for array initialization.
previous_line = get_previous_non_blank_line(clean_lines, line_number)[0]
-if ((not search(r'[;:}{)=]\s*$|\)\s*const\s*$', previous_line)
+if ((not search(r'[;:}{)=]\s*$|\)\s*((const|OVERRIDE)\s*)*\s*$', previous_line)
or search(r'\b(if|for|foreach|while|switch|else)\b', previous_line))
and previous_line.find('#') 0):
error(line_number, 'whitespace/braces', 4,
'This { should be at the end of the previous line')
-elif (search(r'\)\s*(const\s*)?{\s*$', line)
+elif (search(r'\)\s*(((const|OVERRIDE)\s*)*\s*)?{\s*$', line)
and line.count('(') == line.count(')')
and not search(r'\b(if|for|foreach|while|switch)\b', line)
and not match(r'\s+[A-Z_][A-Z_0-9]+\b', line)):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (100498 => 100499)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-11-16 21:22:15 UTC (rev 100498)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-11-16 21:51:15 UTC (rev 100499)
@@ -1530,11 +1530,22 @@
'int foo() const {',
'Place brace on its own line for function definitions. [whitespace/braces] [4]')
self.assert_multi_line_lint(
+'int foo() const OVERRIDE {',
+'Place brace on its own line for function definitions. [whitespace/braces] [4]')
+self.assert_multi_line_lint(
+'int foo() OVERRIDE {',
+'Place brace on its own line for function definitions. [whitespace/braces] [4]')
+self.assert_multi_line_lint(
'int foo() const\n'
'{\n'
'}\n',
'')
self.assert_multi_line_lint(
+'int foo() OVERRIDE\n'
+'{\n'
+'}\n',
+'')
+self.assert_multi_line_lint(
'if (condition\n'
' condition2\n'
' condition3) {\n'
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100500] trunk/Source
Title: [100500] trunk/Source
Revision 100500
Author commit-qu...@webkit.org
Date 2011-11-16 13:54:54 -0800 (Wed, 16 Nov 2011)
Log Message
Page/layer flashes after GPU-accelerated CSS transition
https://bugs.webkit.org/show_bug.cgi?id=72343
LayerRendererChromium was resizing the window to 1x1 at initialization.
In some cases, there is no drawLayers before switching back to
software rendering. This left the window resized to 1x1 and the
following software paints would therefore not be visible. This change
moves the reshape call into drawLayers so that it will only be called
if rendering will occur.
Patch by John Bates jba...@google.com on 2011-11-16
Reviewed by James Robinson.
New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::doViewportChanged):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100499 => 100500)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 21:51:15 UTC (rev 100499)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 21:54:54 UTC (rev 100500)
@@ -1,3 +1,25 @@
+2011-11-16 John Bates jba...@google.com
+
+Page/layer flashes after GPU-accelerated CSS transition
+https://bugs.webkit.org/show_bug.cgi?id=72343
+
+LayerRendererChromium was resizing the window to 1x1 at initialization.
+In some cases, there is no drawLayers before switching back to
+software rendering. This left the window resized to 1x1 and the
+following software paints would therefore not be visible. This change
+moves the reshape call into drawLayers so that it will only be called
+if rendering will occur.
+
+Reviewed by James Robinson.
+
+New test: CCLayerTreeHostImplTest.reshapeNotCalledUntilDraw.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::viewportChanged):
+(WebCore::LayerRendererChromium::doViewportChanged):
+(WebCore::LayerRendererChromium::drawLayersInternal):
+* platform/graphics/chromium/LayerRendererChromium.h:
+
2011-11-16 Alexandre Elias ael...@google.com
[chromium] Add null pointer check in setDeviceScaleFactor
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100499 => 100500)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-16 21:51:15 UTC (rev 100499)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-16 21:54:54 UTC (rev 100500)
@@ -174,6 +174,7 @@
, m_context(context)
, m_defaultRenderSurface(0)
, m_sharedGeometryQuad(FloatRect(-0.5f, -0.5f, 1.0f, 1.0f))
+, m_isViewportChanged(false)
{
}
@@ -275,8 +276,7 @@
void LayerRendererChromium::viewportChanged()
{
-if (m_context)
-m_context-reshape(std::max(1, viewportWidth()), std::max(1, viewportHeight()));
+m_isViewportChanged = true;
// Reset the current render surface to force an update of the viewport and
// projection matrix next time useRenderSurface is called.
@@ -352,6 +352,14 @@
return;
TRACE_EVENT(LayerRendererChromium::drawLayers, this, 0);
+if (m_isViewportChanged) {
+// Only reshape when we know we are going to draw. Otherwise, the reshape
+// can leave the window at the wrong size if we never draw and the proper
+// viewport size is never set.
+m_isViewportChanged = false;
+m_context-reshape(viewportWidth(), viewportHeight());
+}
+
CCLayerImpl* rootDrawLayer = rootLayer();
makeContextCurrent();
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h (100499 => 100500)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-16 21:51:15 UTC (rev 100499)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.h 2011-11-16 21:54:54 UTC (rev 100500)
@@ -231,6 +231,8 @@
CCLayerSorter m_layerSorter;
FloatQuad m_sharedGeometryQuad;
+
+bool m_isViewportChanged;
};
// Setting DEBUG_GL_CALLS to 1 will call glGetError() after almost every GL
Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (100499 => 100500)
--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2011-11-16 21:51:15 UTC (rev 100499)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp 2011-11-16 21:54:54 UTC (rev 100500)
@@ -292,5 +292,50 @@
EXPECT_TRUE(layer2-drawn());
}
+class ReshapeTrackerContext: public
[webkit-changes] [100502] trunk
Title: [100502] trunk
Revision 100502
Author jsc...@chromium.org
Date 2011-11-16 14:07:23 -0800 (Wed, 16 Nov 2011)
Log Message
Clear SVG filter client when its node is detached
https://bugs.webkit.org/show_bug.cgi?id=71741
Reviewed by Eric Seidel.
Source/WebCore:
Test: svg/filters/reparent-animated-filter-target.html
* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientDestroyed):
LayoutTests:
* svg/filters/reparent-animated-filter-target-expected.txt: Added.
* svg/filters/reparent-animated-filter-target.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp
Added Paths
trunk/LayoutTests/svg/filters/reparent-animated-filter-target-expected.txt
trunk/LayoutTests/svg/filters/reparent-animated-filter-target.html
Diff
Modified: trunk/LayoutTests/ChangeLog (100501 => 100502)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:02:37 UTC (rev 100501)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:07:23 UTC (rev 100502)
@@ -1,3 +1,13 @@
+2011-11-16 Justin Schuh jsc...@chromium.org
+
+Clear SVG filter client when its node is detached
+https://bugs.webkit.org/show_bug.cgi?id=71741
+
+Reviewed by Eric Seidel.
+
+* svg/filters/reparent-animated-filter-target-expected.txt: Added.
+* svg/filters/reparent-animated-filter-target.html: Added.
+
2011-11-16 Peter Kasting pkast...@google.com
[chromium] Mark some CoreAnimation plugin model tests as WONTFIX on Win/
Added: trunk/LayoutTests/svg/filters/reparent-animated-filter-target-expected.txt (0 => 100502)
--- trunk/LayoutTests/svg/filters/reparent-animated-filter-target-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/filters/reparent-animated-filter-target-expected.txt 2011-11-16 22:07:23 UTC (rev 100502)
@@ -0,0 +1,3 @@
+This test moves an animated filter target. The test will display a message below if successful.
+
+PASS - Test succeeded.
Added: trunk/LayoutTests/svg/filters/reparent-animated-filter-target.html (0 => 100502)
--- trunk/LayoutTests/svg/filters/reparent-animated-filter-target.html (rev 0)
+++ trunk/LayoutTests/svg/filters/reparent-animated-filter-target.html 2011-11-16 22:07:23 UTC (rev 100502)
@@ -0,0 +1,42 @@
+svg
+filter id=filter
+ feDiffuseLighting
+feSpotLight
+ animate id=animate attributeName=limitingConeAngle from=0 to=1 dur=1s repeatCount=indefinite
+/feSpotLight
+ /feDiffuseLighting
+/filter
+rect id=rect width=1 height=1 filter=url(#filter)
+/svg
+script
+if (window.layoutTestController) {
+layoutTestController.dumpAsText()
+layoutTestController.waitUntilDone()
+}
+
+window._onload_ = function() {
+animate = document.getElementById('animate')
+retry = true
+
+function runTest() {
+if (retry) { // Wait for at least one animation frame before reparenting.
+lastAnimVal = animate.parentElement.limitingConeAngle.animVal
+if (lastAnimVal 0) {
+animate.appendChild(document.getElementById('rect'))
+retry = false
+}
+// Wait for at least one more animation frame so we know it succeeded.
+} else if (lastAnimVal != animate.parentElement.limitingConeAngle.animVal) {
+document.body.appendChild(document.createTextNode('PASS - Test succeeded.'))
+if (window.layoutTestController)
+layoutTestController.notifyDone()
+return
+}
+
+setTimeout(runTest, 0)
+}
+
+runTest()
+}
+/script
+pThis test moves an animated filter target. The test will display a message below if successful./p
Modified: trunk/Source/WebCore/ChangeLog (100501 => 100502)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 22:02:37 UTC (rev 100501)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 22:07:23 UTC (rev 100502)
@@ -1,3 +1,15 @@
+2011-11-16 Justin Schuh jsc...@chromium.org
+
+Clear SVG filter client when its node is detached
+https://bugs.webkit.org/show_bug.cgi?id=71741
+
+Reviewed by Eric Seidel.
+
+Test: svg/filters/reparent-animated-filter-target.html
+
+* rendering/svg/SVGResourcesCache.cpp:
+(WebCore::SVGResourcesCache::clientDestroyed):
+
2011-11-16 John Bates jba...@google.com
Page/layer flashes after GPU-accelerated CSS transition
Modified: trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp (100501 => 100502)
--- trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp 2011-11-16 22:02:37 UTC (rev 100501)
+++ trunk/Source/WebCore/rendering/svg/SVGResourcesCache.cpp 2011-11-16 22:07:23 UTC (rev 100502)
@@ -158,6 +158,11 @@
void SVGResourcesCache::clientDestroyed(RenderObject* renderer)
{
ASSERT(renderer);
+
+SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(renderer);
+if (resources)
+resources-removeClientFromCache(renderer);
+
[webkit-changes] [100503] trunk
Title: [100503] trunk
Revision 100503
Author jap...@chromium.org
Date 2011-11-16 14:10:53 -0800 (Wed, 16 Nov 2011)
Log Message
Source/WebCore: Fix incorrect multipart handling in r100311.
SubresourceLoader::didReceiveData() is getting called
twice, which has unintended side effects.
https://bugs.webkit.org/show_bug.cgi?id=72436
Reviewed by Adam Barth.
http/tests/multipart/invalid-image-data.html should stop
asserting after this.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):
* loader/SubresourceLoader.h:
LayoutTests: Remove CRASH expectation for
http/tests/multipart/invalid-image-data.html.
https://bugs.webkit.org/show_bug.cgi?id=72436
Reviewed by Adam Barth.
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/SubresourceLoader.h
Diff
Modified: trunk/LayoutTests/ChangeLog (100502 => 100503)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:07:23 UTC (rev 100502)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:10:53 UTC (rev 100503)
@@ -1,3 +1,13 @@
+2011-11-16 Nate Chapin jap...@chromium.org
+
+Remove CRASH expectation for
+http/tests/multipart/invalid-image-data.html.
+https://bugs.webkit.org/show_bug.cgi?id=72436
+
+Reviewed by Adam Barth.
+
+* platform/chromium/test_expectations.txt:
+
2011-11-16 Justin Schuh jsc...@chromium.org
Clear SVG filter client when its node is detached
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100502 => 100503)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:07:23 UTC (rev 100502)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:10:53 UTC (rev 100503)
@@ -1253,8 +1253,7 @@
BUGCR10361 WIN : http/tests/misc/single-character-pi-stylesheet.xhtml = FAIL
// Windows is missing the green box. Started to pass in roll to WebKit r50313
-BUGCR8729 WIN RELEASE : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT
-BUGWK72436 WIN DEBUG : http/tests/multipart/invalid-image-data.html = CRASH
+BUGCR8729 WIN : http/tests/multipart/invalid-image-data.html = IMAGE+TEXT
// -
// MAC PORT TESTS
Modified: trunk/Source/WebCore/ChangeLog (100502 => 100503)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 22:07:23 UTC (rev 100502)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 22:10:53 UTC (rev 100503)
@@ -1,3 +1,21 @@
+2011-11-16 Nate Chapin jap...@chromium.org
+
+Fix incorrect multipart handling in r100311.
+SubresourceLoader::didReceiveData() is getting called
+twice, which has unintended side effects.
+https://bugs.webkit.org/show_bug.cgi?id=72436
+
+Reviewed by Adam Barth.
+
+http/tests/multipart/invalid-image-data.html should stop
+asserting after this.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didReceiveResponse):
+(WebCore::SubresourceLoader::didReceiveData):
+(WebCore::SubresourceLoader::sendDataToResource):
+* loader/SubresourceLoader.h:
+
2011-11-16 Justin Schuh jsc...@chromium.org
Clear SVG filter client when its node is detached
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (100502 => 100503)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2011-11-16 22:07:23 UTC (rev 100502)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2011-11-16 22:10:53 UTC (rev 100503)
@@ -179,7 +179,7 @@
// Since a subresource loader does not load multipart sections progressively,
// deliver the previously received data to the loader all at once now.
// Then clear the data to make way for the next multipart section.
-didReceiveData(buffer-data(), buffer-size(), -1, true);
+sendDataToResource(buffer-data(), buffer-size());
clearResourceData();
// After the first multipart section is complete, signal to delegates that this load is finished
@@ -204,6 +204,12 @@
return;
}
+if (!m_loadingMultipartContent)
+sendDataToResource(data, length);
+}
+
+void SubresourceLoader::sendDataToResource(const char* data, int length)
+{
// There are two cases where we might need to create our own SharedBuffer instead of copying the one in ResourceLoader.
// (1) Multipart content: The loader delivers the data in a multipart section all at once, then sends eof.
// The resource data will change as the next part is loaded, so we need to make a copy.
Modified: trunk/Source/WebCore/loader/SubresourceLoader.h (100502 => 100503)
--- trunk/Source/WebCore/loader/SubresourceLoader.h 2011-11-16 22:07:23 UTC (rev
[webkit-changes] [100504] trunk
Title: [100504] trunk
Revision 100504
Author commit-qu...@webkit.org
Date 2011-11-16 14:21:50 -0800 (Wed, 16 Nov 2011)
Log Message
IndexedDB: Reduce nested key depth threshold, re-enable flaky test
https://bugs.webkit.org/show_bug.cgi?id=72529
Patch by Joshua Bell jsb...@chromium.org on 2011-11-16
Reviewed by Adam Barth.
Source/WebCore:
Drop maximum array key depth from 20k to 2k.
* bindings/v8/IDBBindingUtilities.cpp:
LayoutTests:
Re-enable flaky test, and drop the maximum depth tested to avoid
crashes/timeouts on test boxes when prepping the test.
* platform/chromium/test_expectations.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt
trunk/LayoutTests/storage/indexeddb/key-type-array.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100503 => 100504)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:10:53 UTC (rev 100503)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:21:50 UTC (rev 100504)
@@ -1,3 +1,17 @@
+2011-11-16 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Reduce nested key depth threshold, re-enable flaky test
+https://bugs.webkit.org/show_bug.cgi?id=72529
+
+Reviewed by Adam Barth.
+
+Re-enable flaky test, and drop the maximum depth tested to avoid
+crashes/timeouts on test boxes when prepping the test.
+
+* platform/chromium/test_expectations.txt:
+* storage/indexeddb/key-type-array-expected.txt:
+* storage/indexeddb/key-type-array.html:
+
2011-11-16 Nate Chapin jap...@chromium.org
Remove CRASH expectation for
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100503 => 100504)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:10:53 UTC (rev 100503)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:21:50 UTC (rev 100504)
@@ -3832,8 +3832,6 @@
BUGWK71830 : svg/zoom/page/zoom-svg-as-relative-image.html = IMAGE
BUGWK71830 WIN MAC : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE+TEXT
-BUG_OJAN : storage/indexeddb/key-type-array.html = TIMEOUT CRASH
-
BUGWK72037 : storage/indexeddb/factory-deletedatabase-interactions.html = TEXT TIMEOUT PASS
BUGRICOW : fast/js/array-functions-non-arrays.html = TEXT
Modified: trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt (100503 => 100504)
--- trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt 2011-11-16 22:10:53 UTC (rev 100503)
+++ trunk/LayoutTests/storage/indexeddb/key-type-array-expected.txt 2011-11-16 22:21:50 UTC (rev 100504)
@@ -256,11 +256,9 @@
PASS Exception was thrown.
PASS code is IDBDatabaseException.DATA_ERR
-PASS indexedDB.cmp(makeArrayOfDepth(5), 0) is 1
-PASS indexedDB.cmp(makeArrayOfDepth(50), 0) is 1
-PASS indexedDB.cmp(makeArrayOfDepth(500), 0) is 1
-PASS indexedDB.cmp(makeArrayOfDepth(5000), 0) is 1
-Expecting exception from indexedDB.cmp(makeArrayOfDepth(5), 0)
+PASS indexedDB.cmp(makeArrayOfDepth(25), 0) is 1
+PASS indexedDB.cmp(makeArrayOfDepth(250), 0) is 1
+Expecting exception from indexedDB.cmp(makeArrayOfDepth(2500), 0)
PASS Exception was thrown.
PASS code is IDBDatabaseException.DATA_ERR
Modified: trunk/LayoutTests/storage/indexeddb/key-type-array.html (100503 => 100504)
--- trunk/LayoutTests/storage/indexeddb/key-type-array.html 2011-11-16 22:10:53 UTC (rev 100503)
+++ trunk/LayoutTests/storage/indexeddb/key-type-array.html 2011-11-16 22:21:50 UTC (rev 100504)
@@ -189,21 +189,18 @@
function makeArrayOfDepth(n)
{
-var array = [], current = array;
+var array = [];
while (--n) {
-current.push([]);
-current = current[0];
+array = [array];
}
return array;
}
function testDepthLimits()
{
-shouldBe(indexedDB.cmp(makeArrayOfDepth(5), 0), 1);
-shouldBe(indexedDB.cmp(makeArrayOfDepth(50), 0), 1);
-shouldBe(indexedDB.cmp(makeArrayOfDepth(500), 0), 1);
-shouldBe(indexedDB.cmp(makeArrayOfDepth(5000), 0), 1);
-evalAndExpectException(indexedDB.cmp(makeArrayOfDepth(5), 0), IDBDatabaseException.DATA_ERR);
+shouldBe(indexedDB.cmp(makeArrayOfDepth(25), 0), 1);
+shouldBe(indexedDB.cmp(makeArrayOfDepth(250), 0), 1);
+evalAndExpectException(indexedDB.cmp(makeArrayOfDepth(2500), 0), IDBDatabaseException.DATA_ERR);
debug();
done();
Modified: trunk/Source/WebCore/ChangeLog (100503 => 100504)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 22:10:53 UTC (rev 100503)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 22:21:50 UTC (rev 100504)
@@ -1,3 +1,14 @@
+2011-11-16 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Reduce nested key depth threshold, re-enable flaky test
+https://bugs.webkit.org/show_bug.cgi?id=72529
[webkit-changes] [100505] trunk/Tools
Title: [100505] trunk/Tools
Revision 100505
Author rn...@webkit.org
Date 2011-11-16 14:24:00 -0800 (Wed, 16 Nov 2011)
Log Message
contributors_by_fuzzy_match is super slow
https://bugs.webkit.org/show_bug.cgi?id=72540
Reviewed by Eric Seidel.
Make contributors_by_name do case insensitive search using a dictionary.
Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
because that's the most common case.
* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/committers_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py
trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (100504 => 100505)
--- trunk/Tools/ChangeLog 2011-11-16 22:21:50 UTC (rev 100504)
+++ trunk/Tools/ChangeLog 2011-11-16 22:24:00 UTC (rev 100505)
@@ -1,3 +1,18 @@
+2011-11-16 Ryosuke Niwa rn...@webkit.org
+
+contributors_by_fuzzy_match is super slow
+https://bugs.webkit.org/show_bug.cgi?id=72540
+
+Reviewed by Eric Seidel.
+
+Make contributors_by_name do case insensitive search using a dictionary.
+
+Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
+because that's the most common case.
+
+* Scripts/webkitpy/common/config/committers.py:
+* Scripts/webkitpy/common/config/committers_unittest.py:
+
2011-11-16 David Levin le...@chromium.org
check-webkit-style should recognize functions even if they have OVERRIDE after them.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (100504 => 100505)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-16 22:21:50 UTC (rev 100504)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2011-11-16 22:24:00 UTC (rev 100505)
@@ -462,6 +462,7 @@
self._contributors = contributors + committers + reviewers
self._committers = committers + reviewers
self._reviewers = reviewers
+self._contributors_by_name = {}
self._accounts_by_email = {}
self._accounts_by_login = {}
@@ -477,6 +478,14 @@
def reviewers(self):
return self._reviewers
+def _name_to_contributor_map(self):
+if not len(self._contributors_by_name):
+for contributor in self._contributors:
+assert(contributor.full_name)
+assert(contributor.full_name.lower() not in self._contributors_by_name) # We should never have duplicate names.
+self._contributors_by_name[contributor.full_name.lower()] = contributor
+return self._contributors_by_name
+
def _email_to_account_map(self):
if not len(self._accounts_by_email):
for account in self._accounts:
@@ -509,13 +518,6 @@
return None
return record
-def contributor_by_name(self, name):
-# This could be made into a hash lookup if callers need it to be fast.
-for contributor in self.contributors():
-if contributor.full_name and contributor.full_name == name:
-return contributor
-return None
-
def committer_by_name(self, name):
return self._committer_only(self.contributor_by_name(name))
@@ -540,7 +542,7 @@
string = string.lower()
# First path, optimitically match for fullname, email and irc_nicknames
-account = self.account_by_email(string) or self.contributor_by_irc_nickname(string) or self.contributor_by_name(string)
+account = self.contributor_by_name(string) or self.account_by_email(string) or self.contributor_by_irc_nickname(string)
if account:
return [account], 0
@@ -568,6 +570,9 @@
def account_by_email(self, email):
return self._email_to_account_map().get(email.lower())
+def contributor_by_name(self, name):
+return self._name_to_contributor_map().get(name.lower())
+
def contributor_by_email(self, email):
return self._contributor_only(self.account_by_email(email))
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py (100504 => 100505)
--- trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py 2011-11-16 22:21:50 UTC (rev 100504)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers_unittest.py 2011-11-16 22:24:00 UTC (rev 100505)
@@ -52,6 +52,9 @@
self.assertEqual(committer_list.committer_by_name(Test Two), reviewer)
self.assertEqual(committer_list.committer_by_name(Test Three), None)
self.assertEqual(committer_list.contributor_by_name(Test Three), contributor)
+self.assertEqual(committer_list.contributor_by_name(test one), committer)
+self.assertEqual(committer_list.contributor_by_name(test two), reviewer)
+self.assertEqual(committer_list.contributor_by_name(test three), contributor)
# Test that the first
[webkit-changes] [100506] trunk/LayoutTests
Title: [100506] trunk/LayoutTests
Revision 100506
Author commit-qu...@webkit.org
Date 2011-11-16 14:24:49 -0800 (Wed, 16 Nov 2011)
Log Message
Platform specific results for svg/foreignObject/{clip,filter,mask}.html
https://bugs.webkit.org/show_bug.cgi?id=72532
Patch by Florin Malita fmal...@google.com on 2011-11-16
Reviewed by Steve Block.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (100505 => 100506)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:24:00 UTC (rev 100505)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:24:49 UTC (rev 100506)
@@ -1,3 +1,14 @@
+2011-11-16 Florin Malita fmal...@google.com
+
+Platform specific results for svg/foreignObject/{clip,filter,mask}.html
+https://bugs.webkit.org/show_bug.cgi?id=72532
+
+Reviewed by Steve Block.
+
+* platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/svg/foreignObject/filter-expected.png: Added.
+* platform/chromium-cg-mac-snowleopard/svg/foreignObject/mask-expected.png: Added.
+
2011-11-16 Joshua Bell jsb...@chromium.org
IndexedDB: Reduce nested key depth threshold, re-enable flaky test
Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png (0 => 100506)
--- trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/foreignObject/clip-expected.png 2011-11-16 22:24:49 UTC (rev 100506)
@@ -0,0 +1,5 @@
+\x89PNG
+
+
+IHDR X \x9Av\x82p )tEXtchecksum 4e2cfd369222743054caebc04dd5ee55 'O IDATx\x9C\xED\xD9A
+\xC3@\xC18\xC4 \xED -\xCC\xD6\xFC\xEE\x93\xE2*\xF3mͱ~k\xC0\xA3\xEB\xBCvO \xF8+\xDF\xDD \x80\xF7 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x909ffv\x8F \xDE\xC1 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90 @F\x80 d \x90
[webkit-changes] [100507] trunk/LayoutTests
Title: [100507] trunk/LayoutTests
Revision 100507
Author pkast...@chromium.org
Date 2011-11-16 14:34:41 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Attempt to rebaseline a test.
https://bugs.webkit.org/show_bug.cgi?id=54322
Unreviewed, gardening.
* platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png
Added Paths
trunk/LayoutTests/platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (100506 => 100507)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:24:49 UTC (rev 100506)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:34:41 UTC (rev 100507)
@@ -1,3 +1,14 @@
+2011-11-16 Peter Kasting pkast...@google.com
+
+[chromium] Attempt to rebaseline a test.
+https://bugs.webkit.org/show_bug.cgi?id=54322
+
+Unreviewed, gardening.
+
+* platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
+* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png:
+* platform/chromium/test_expectations.txt:
+
2011-11-16 Florin Malita fmal...@google.com
Platform specific results for svg/foreignObject/{clip,filter,mask}.html
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100506 => 100507)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:24:49 UTC (rev 100506)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-16 22:34:41 UTC (rev 100507)
@@ -2749,7 +2749,6 @@
BUGWK54322 SNOWLEOPARD : tables/mozilla/core/misc.html = IMAGE
BUGWK54322 SNOWLEOPARD : tables/mozilla/core/row_span.html = IMAGE
BUGWK54322 SNOWLEOPARD : tables/mozilla/other/cell_widths.html = IMAGE
-BUGWK54322 SNOWLEOPARD : transforms/no_transform_hit_testing.html = IMAGE
BUGWK54322 SNOWLEOPARD : transforms/svg-vs-css.xhtml = IMAGE
BUGWK54322 SNOWLEOPARD : transitions/move-after-transition.html = IMAGE
BUGWK54322 SNOWLEOPARD : fast/dom/scroll-reveal-left-overflow.html = IMAGE
Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/transforms/no_transform_hit_testing-expected.png
___
Added: svn:mime-type
Modified: trunk/LayoutTests/platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png
(Binary files differ)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100508] trunk/Source
Title: [100508] trunk/Source
Revision 100508
Author commit-qu...@webkit.org
Date 2011-11-16 14:37:55 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Improvements for page scale delta during commit
https://bugs.webkit.org/show_bug.cgi?id=72471
Patch by Alexandre Elias ael...@google.com on 2011-11-16
Reviewed by James Robinson.
Page scale now follows the same commit flow as scroll position:
the delta is folded into m_pageScale at BFAC time, and a sent value
is preserved for temporary use until the commit finishes.
I also merged setPageScaleFactor and setPageScaleFactorLimits into one
function on the impl side. The reason is that setPageFactor must
be applied after the limits are updated, but on the other hand setting
the limits first may cause an unnecessary clamp of the scale delta.
Merging the methods avoids this bind.
No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
Source/WebKit/chromium:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyScrollAndScale):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/tests/CCLayerImplTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100507 => 100508)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 22:34:41 UTC (rev 100507)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 22:37:55 UTC (rev 100508)
@@ -1,3 +1,36 @@
+2011-11-16 Alexandre Elias ael...@google.com
+
+[chromium] Improvements for page scale delta during commit
+https://bugs.webkit.org/show_bug.cgi?id=72471
+
+Reviewed by James Robinson.
+
+Page scale now follows the same commit flow as scroll position:
+the delta is folded into m_pageScale at BFAC time, and a sent value
+is preserved for temporary use until the commit finishes.
+
+I also merged setPageScaleFactor and setPageScaleFactorLimits into one
+function on the impl side. The reason is that setPageFactor must
+be applied after the limits are updated, but on the other hand setting
+the limits first may cause an unnecessary clamp of the scale delta.
+Merging the methods avoids this bind.
+
+No new tests. (planning to add later: https://bugs.webkit.org/show_bug.cgi?id=71529)
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
+(WebCore::CCLayerTreeHost::applyScrollAndScale):
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
+(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
+(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
+(WebCore::CCLayerTreeHostImpl::setScaleDelta):
+(WebCore::CCLayerTreeHostImpl::applyScaleDeltaToScrollLayer):
+(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
+(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+
2011-11-16 Joshua Bell jsb...@chromium.org
IndexedDB: Reduce nested key depth threshold, re-enable flaky test
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h (100507 => 100508)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-11-16 22:34:41 UTC (rev 100507)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h 2011-11-16 22:37:55 UTC (rev 100508)
@@ -138,7 +138,7 @@
IntSize scrollDelta() const { return IntSize(); }
-float
[webkit-changes] [100509] trunk/Tools
Title: [100509] trunk/Tools Revision 100509 Author dpra...@chromium.org Date 2011-11-16 14:44:14 -0800 (Wed, 16 Nov 2011) Log Message Run a dummy test in the gpu configurations if there's nothing to do. https://bugs.webkit.org/show_bug.cgi?id=72498 Reviewed by James Robinson. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py Diff Modified: trunk/Tools/ChangeLog (100508 => 100509) --- trunk/Tools/ChangeLog 2011-11-16 22:37:55 UTC (rev 100508) +++ trunk/Tools/ChangeLog 2011-11-16 22:44:14 UTC (rev 100509) @@ -1,3 +1,12 @@ +2011-11-16 Dirk Pranke dpra...@chromium.org + +Run a dummy test in the gpu configurations if there's nothing to do. +https://bugs.webkit.org/show_bug.cgi?id=72498 + +Reviewed by James Robinson. + +* Scripts/webkitpy/layout_tests/port/chromium_gpu.py: + 2011-11-16 Ryosuke Niwa rn...@webkit.org contributors_by_fuzzy_match is super slow Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (100508 => 100509) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 22:37:55 UTC (rev 100508) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 22:44:14 UTC (rev 100509) @@ -100,6 +100,14 @@ # dummy test. See https://bugs.webkit.org/show_bug.cgi?id=72498. paths = ['fast/html/article-element.html'] +if not paths: +# FIXME: This is a hack until we can turn of the webkit_gpu +# tests on the bots. If paths is empty, test_files.find() +# finds *everything*. However, we have to return something, +# or NRWT thinks there's something wrong. So, we return a single +# dummy test. See https://bugs.webkit.org/show_bug.cgi?id=72498. +paths = ['fast/html/article-element.html'] + return set([port.relative_test_filename(f) for f in test_files.find(port, paths)]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100511] trunk/Tools
Title: [100511] trunk/Tools
Revision 100511
Author t...@chromium.org
Date 2011-11-16 14:53:24 -0800 (Wed, 16 Nov 2011)
Log Message
[NRWT] speculative fix for multiple subprocess test on cygwin
https://bugs.webkit.org/show_bug.cgi?id=72518
Reviewed by Adam Barth.
* Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
tries to emulate posix fd behavior.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (100510 => 100511)
--- trunk/Tools/ChangeLog 2011-11-16 22:46:31 UTC (rev 100510)
+++ trunk/Tools/ChangeLog 2011-11-16 22:53:24 UTC (rev 100511)
@@ -1,3 +1,14 @@
+2011-11-16 Tony Chang t...@chromium.org
+
+[NRWT] speculative fix for multiple subprocess test on cygwin
+https://bugs.webkit.org/show_bug.cgi?id=72518
+
+Reviewed by Adam Barth.
+
+* Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
+tries to emulate posix fd behavior.
+* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+
2011-11-16 Dirk Pranke dpra...@chromium.org
Run a dummy test in the gpu configurations if there's nothing to do.
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (100510 => 100511)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-11-16 22:46:31 UTC (rev 100510)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2011-11-16 22:53:24 UTC (rev 100511)
@@ -451,7 +451,7 @@
assert not self._proc
# FIXME: This should use ServerProcess like WebKitDriver does.
# FIXME: We should be reading stderr and stdout separately like how WebKitDriver does.
-close_fds = sys.platform not in ('win32', 'cygwin')
+close_fds = sys.platform != 'win32'
self._proc = subprocess.Popen(self.cmd_line(), stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=close_fds)
def has_crashed(self):
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py (100510 => 100511)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2011-11-16 22:46:31 UTC (rev 100510)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py 2011-11-16 22:53:24 UTC (rev 100511)
@@ -137,9 +137,7 @@
start_time = time.time()
driver1.stop()
driver2.stop()
-# FIXME: This test is timing out it cygwin. Disable until we get a chance to debug.
-if sys.platform != 'cygwin':
-self.assertTrue(time.time() - start_time 20)
+self.assertTrue(time.time() - start_time 20)
class ChromiumPortTest(port_testcase.PortTestCase):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100512] trunk/LayoutTests
Title: [100512] trunk/LayoutTests
Revision 100512
Author jam...@google.com
Date 2011-11-16 14:57:29 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Update text baselines for mq-transform-0[23] tests
* platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
* platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (100511 => 100512)
--- trunk/LayoutTests/ChangeLog 2011-11-16 22:53:24 UTC (rev 100511)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 22:57:29 UTC (rev 100512)
@@ -1,3 +1,10 @@
+2011-11-16 James Robinson jam...@chromium.org
+
+[chromium] Update text baselines for mq-transform-0[23] tests
+
+* platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt:
+* platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt:
+
2011-11-16 Peter Kasting pkast...@google.com
[chromium] Attempt to rebaseline a test.
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt (100511 => 100512)
--- trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt 2011-11-16 22:53:24 UTC (rev 100511)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-02-expected.txt 2011-11-16 22:57:29 UTC (rev 100512)
@@ -3,7 +3,7 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576
- RenderBlock {P} at (0,0) size 784x36 [color=#008000]
+ RenderBlock {P} at (0,0) size 784x36 [color=#FF]
RenderText {#text} at (0,0) size 778x36
text run at (0,0) width 778: This text should be green. If running in a build of WebKit with 3d transforms, it will appear red (and this should not happen
text run at (0,18) width 164: while 3d is not supported)
Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt (100511 => 100512)
--- trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt 2011-11-16 22:53:24 UTC (rev 100511)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/media/mq-transform-03-expected.txt 2011-11-16 22:57:29 UTC (rev 100512)
@@ -3,6 +3,6 @@
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x576
- RenderBlock {P} at (0,0) size 784x18 [color=#008000]
+ RenderBlock {P} at (0,0) size 784x18
RenderText {#text} at (0,0) size 626x18
text run at (0,0) width 626: This text should be green if running in a build of WebKit with support for 2d but not 3d transforms.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100513] trunk/Tools
Title: [100513] trunk/Tools Revision 100513 Author dpra...@chromium.org Date 2011-11-16 15:02:01 -0800 (Wed, 16 Nov 2011) Log Message Revert r100509; change was committed twice (first time as r100491). Unreviewed, build fix. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py Diff Modified: trunk/Tools/ChangeLog (100512 => 100513) --- trunk/Tools/ChangeLog 2011-11-16 22:57:29 UTC (rev 100512) +++ trunk/Tools/ChangeLog 2011-11-16 23:02:01 UTC (rev 100513) @@ -11,6 +11,13 @@ 2011-11-16 Dirk Pranke dpra...@chromium.org +Revert r100509; change was committed twice (first time as r100491). +Unreviewed, build fix. + +* Scripts/webkitpy/layout_tests/port/chromium_gpu.py: + +2011-11-16 Dirk Pranke dpra...@chromium.org + Run a dummy test in the gpu configurations if there's nothing to do. https://bugs.webkit.org/show_bug.cgi?id=72498 Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py (100512 => 100513) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 22:57:29 UTC (rev 100512) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py 2011-11-16 23:02:01 UTC (rev 100513) @@ -100,14 +100,6 @@ # dummy test. See https://bugs.webkit.org/show_bug.cgi?id=72498. paths = ['fast/html/article-element.html'] -if not paths: -# FIXME: This is a hack until we can turn of the webkit_gpu -# tests on the bots. If paths is empty, test_files.find() -# finds *everything*. However, we have to return something, -# or NRWT thinks there's something wrong. So, we return a single -# dummy test. See https://bugs.webkit.org/show_bug.cgi?id=72498. -paths = ['fast/html/article-element.html'] - return set([port.relative_test_filename(f) for f in test_files.find(port, paths)]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100514] trunk
Title: [100514] trunk
Revision 100514
Author fpi...@apple.com
Date 2011-11-16 15:21:39 -0800 (Wed, 16 Nov 2011)
Log Message
DFG global variable CSE mishandles the cross-global-object inlining corner case
https://bugs.webkit.org/show_bug.cgi?id=72542
Source/_javascript_Core:
Reviewed by Geoff Garen.
Moved code to get the global object for a code origin into CodeBlock, so it is
more broadly accessible. Fixed CSE to compare both the variable number, and the
global object, before deciding to perform elimination.
* bytecode/CodeBlock.h:
(JSC::CodeBlock::globalObjectFor):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::globalObjectFor):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
LayoutTests:
Reviewed by Geoff Garen.
* fast/js/cross-global-object-inline-global-var-expected.txt: Added.
* fast/js/cross-global-object-inline-global-var.html: Added.
* fast/js/script-tests/cross-global-object-inline-global-var.js: Added.
(foo):
(done):
(doit):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/dfg/DFGAssemblyHelpers.h
trunk/Source/_javascript_Core/dfg/DFGPropagator.cpp
Added Paths
trunk/LayoutTests/fast/js/cross-global-object-inline-global-var-expected.txt
trunk/LayoutTests/fast/js/cross-global-object-inline-global-var.html
trunk/LayoutTests/fast/js/script-tests/cross-global-object-inline-global-var.js
Diff
Modified: trunk/LayoutTests/ChangeLog (100513 => 100514)
--- trunk/LayoutTests/ChangeLog 2011-11-16 23:02:01 UTC (rev 100513)
+++ trunk/LayoutTests/ChangeLog 2011-11-16 23:21:39 UTC (rev 100514)
@@ -1,3 +1,17 @@
+2011-11-16 Filip Pizlo fpi...@apple.com
+
+DFG global variable CSE mishandles the cross-global-object inlining corner case
+https://bugs.webkit.org/show_bug.cgi?id=72542
+
+Reviewed by Geoff Garen.
+
+* fast/js/cross-global-object-inline-global-var-expected.txt: Added.
+* fast/js/cross-global-object-inline-global-var.html: Added.
+* fast/js/script-tests/cross-global-object-inline-global-var.js: Added.
+(foo):
+(done):
+(doit):
+
2011-11-16 James Robinson jam...@chromium.org
[chromium] Update text baselines for mq-transform-0[23] tests
Added: trunk/LayoutTests/fast/js/cross-global-object-inline-global-var-expected.txt (0 => 100514)
--- trunk/LayoutTests/fast/js/cross-global-object-inline-global-var-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/js/cross-global-object-inline-global-var-expected.txt 2011-11-16 23:21:39 UTC (rev 100514)
@@ -0,0 +1,11 @@
+This tests that function inlining in the DFG JIT doesn't get confused by different global objects.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(3) is 324
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS done() called with 5770500
+
Added: trunk/LayoutTests/fast/js/cross-global-object-inline-global-var.html (0 => 100514)
--- trunk/LayoutTests/fast/js/cross-global-object-inline-global-var.html (rev 0)
+++ trunk/LayoutTests/fast/js/cross-global-object-inline-global-var.html 2011-11-16 23:21:39 UTC (rev 100514)
@@ -0,0 +1,11 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+div id=frameparent/div
+script src=""
+script src=""
+/body
+/html
Added: trunk/LayoutTests/fast/js/script-tests/cross-global-object-inline-global-var.js (0 => 100514)
--- trunk/LayoutTests/fast/js/script-tests/cross-global-object-inline-global-var.js (rev 0)
+++ trunk/LayoutTests/fast/js/script-tests/cross-global-object-inline-global-var.js 2011-11-16 23:21:39 UTC (rev 100514)
@@ -0,0 +1,58 @@
+description(
+This tests that function inlining in the DFG JIT doesn't get confused by different global objects.
+);
+
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+var b = 321;
+
+function foo(a) {
+return a + b;
+}
+
+shouldBe(foo(3), 324);
+
+function done(value) {
+var expected = 5770500;
+if (value == expected)
+testPassed(done() called with + expected);
+else
+testFailed(done() is + value + and should be + expected + .);
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function doit() {
+document.getElementById(frameparent).innerHTML = ;
+document.getElementById(frameparent).innerHTML = iframe id='testframe';
+var testFrame = document.getElementById(testframe);
+testFrame.contentDocument.open();
+
+code = !DOCTYPE html\nhead/headbodyscript type=\text/_javascript_\\n;
+
+// Make sure that we get as many variables as the parent.
+for (var i = 0; i 100; ++i)
+code += var b + i + = +i + ;\n;
+
+code += result = 0;\n +
+function bar(a) {\n +
+
[webkit-changes] [100515] branches/safari-534.53-branch/Source
Title: [100515] branches/safari-534.53-branch/Source
Revision 100515
Author lforsch...@apple.com
Date 2011-11-16 15:33:18 -0800 (Wed, 16 Nov 2011)
Log Message
Merge 93058.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/WebCore.exp.in
branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp
branches/safari-534.53-branch/Source/WebCore/page/Frame.h
branches/safari-534.53-branch/Source/WebKit/mac/ChangeLog
branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-534.53-branch/Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/DrawingAreaProxy.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/DrawingArea.messages.in
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.cpp
branches/safari-534.53-branch/Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.h
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100514 => 100515)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 23:21:39 UTC (rev 100514)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-16 23:33:18 UTC (rev 100515)
@@ -1,5 +1,29 @@
2011-11-15 Lucas Forschler lforsch...@apple.com
+Merge 93058
+
+2011-08-15 Adam Roben aro...@apple.com
+
+Update pages' style and content scale when the window's backing scale factor changes
+
+Unfortunately, I couldn't think of a way to test this in an automated fashion.
+
+Fixes http://webkit.org/b/66229 rdar://problem/9906269 WebKit doesn't react to device
+scale factor changes
+
+Reviewed by Simon Fraser.
+
+* WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.
+
+* page/Frame.cpp:
+(WebCore::Frame::deviceScaleFactorChanged):
+* page/Frame.h:
+Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media
+queries will be reevaluated, and we tell compositing layers about the new scale factor so
+they can rerender at the new resolution.
+
+2011-11-15 Lucas Forschler lforsch...@apple.com
+
Merge 93043
2011-08-15 Adam Roben aro...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/WebCore.exp.in (100514 => 100515)
--- branches/safari-534.53-branch/Source/WebCore/WebCore.exp.in 2011-11-16 23:21:39 UTC (rev 100514)
+++ branches/safari-534.53-branch/Source/WebCore/WebCore.exp.in 2011-11-16 23:33:18 UTC (rev 100515)
@@ -751,6 +751,7 @@
__ZN7WebCore5Frame17setPageZoomFactorEf
__ZN7WebCore5Frame17setTextZoomFactorEf
__ZN7WebCore5Frame23visiblePositionForPointERKNS_8IntPointE
+__ZN7WebCore5Frame24deviceScaleFactorChangedEv
__ZN7WebCore5Frame25matchLabelsAgainstElementEP7NSArrayPNS_7ElementE
__ZN7WebCore5Frame25setPageAndTextZoomFactorsEff
__ZN7WebCore5Frame28searchForLabelsBeforeElementEP7NSArrayPNS_7ElementEPmPb
Modified: branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp (100514 => 100515)
--- branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp 2011-11-16 23:21:39 UTC (rev 100514)
+++ branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp 2011-11-16 23:33:18 UTC (rev 100515)
@@ -1080,6 +1080,17 @@
}
}
+void Frame::deviceScaleFactorChanged()
+{
+if (!m_page)
+return;
+m_page-setNeedsRecalcStyleInAllFrames();
+
+#if USE(ACCELERATED_COMPOSITING)
+deviceOrPageScaleFactorChanged();
+#endif
+}
+
void Frame::notifyChromeClientWheelEventHandlerCountChanged() const
{
// Ensure that this method is being called on the main frame of the page.
Modified: branches/safari-534.53-branch/Source/WebCore/page/Frame.h (100514 => 100515)
--- branches/safari-534.53-branch/Source/WebCore/page/Frame.h 2011-11-16 23:21:39 UTC (rev 100514)
+++ branches/safari-534.53-branch/Source/WebCore/page/Frame.h 2011-11-16 23:33:18 UTC (rev 100515)
@@ -163,8 +163,10 @@
float textZoomFactor() const { return
[webkit-changes] [100516] trunk/Source/JavaScriptCore
Title: [100516] trunk/Source/_javascript_Core
Revision 100516
Author gga...@apple.com
Date 2011-11-16 15:37:15 -0800 (Wed, 16 Nov 2011)
Log Message
Rolled back in r100375 and r100385 with 32-bit build fixed.
* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
* runtime/ArgList.h:
* runtime/JSArray.cpp:
(JSC::JSArray::finishCreation):
* runtime/JSArray.h:
(JSC::JSArray::create):
* runtime/JSGlobalObject.h:
(JSC::constructArray):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/ArgList.cpp
trunk/Source/_javascript_Core/runtime/ArgList.h
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100515 => 100516)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 23:33:18 UTC (rev 100515)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-16 23:37:15 UTC (rev 100516)
@@ -1,3 +1,20 @@
+2011-11-16 Geoffrey Garen gga...@apple.com
+
+Rolled back in r100375 and r100385 with 32-bit build fixed.
+
+* dfg/DFGOperations.cpp:
+* jit/JITStubs.cpp:
+(JSC::DEFINE_STUB_FUNCTION):
+* runtime/ArgList.cpp:
+(JSC::ArgList::getSlice):
+* runtime/ArgList.h:
+* runtime/JSArray.cpp:
+(JSC::JSArray::finishCreation):
+* runtime/JSArray.h:
+(JSC::JSArray::create):
+* runtime/JSGlobalObject.h:
+(JSC::constructArray):
+
2011-11-16 Filip Pizlo fpi...@apple.com
DFG global variable CSE mishandles the cross-global-object inlining corner case
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (100515 => 100516)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-16 23:33:18 UTC (rev 100515)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2011-11-16 23:37:15 UTC (rev 100516)
@@ -773,14 +773,12 @@
EncodedJSValue DFG_OPERATION operationNewArray(ExecState* exec, void* start, size_t size)
{
-ArgList argList(static_castRegister*(start), size);
-return JSValue::encode(constructArray(exec, argList));
+return JSValue::encode(constructArray(exec, static_castJSValue*(start), size));
}
EncodedJSValue DFG_OPERATION operationNewArrayBuffer(ExecState* exec, size_t start, size_t size)
{
-ArgList argList(exec-codeBlock()-constantBuffer(start), size);
-return JSValue::encode(constructArray(exec, argList));
+return JSValue::encode(constructArray(exec, exec-codeBlock()-constantBuffer(start), size));
}
EncodedJSValue DFG_OPERATION operationNewRegexp(ExecState* exec, void* regexpPtr)
Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (100515 => 100516)
--- trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-11-16 23:33:18 UTC (rev 100515)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp 2011-11-16 23:37:15 UTC (rev 100516)
@@ -2432,16 +2432,14 @@
{
STUB_INIT_STACK_FRAME(stackFrame);
-ArgList argList(stackFrame.callFrame-registers()[stackFrame.args[0].int32()], stackFrame.args[1].int32());
-return constructArray(stackFrame.callFrame, argList);
+return constructArray(stackFrame.callFrame, reinterpret_castJSValue*(stackFrame.callFrame-registers()[stackFrame.args[0].int32()]), stackFrame.args[1].int32());
}
DEFINE_STUB_FUNCTION(JSObject*, op_new_array_buffer)
{
STUB_INIT_STACK_FRAME(stackFrame);
-ArgList argList(stackFrame.callFrame-codeBlock()-constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
-return constructArray(stackFrame.callFrame, argList);
+return constructArray(stackFrame.callFrame, stackFrame.callFrame-codeBlock()-constantBuffer(stackFrame.args[0].int32()), stackFrame.args[1].int32());
}
DEFINE_STUB_FUNCTION(EncodedJSValue, op_resolve)
Modified: trunk/Source/_javascript_Core/runtime/ArgList.cpp (100515 => 100516)
--- trunk/Source/_javascript_Core/runtime/ArgList.cpp 2011-11-16 23:33:18 UTC (rev 100515)
+++ trunk/Source/_javascript_Core/runtime/ArgList.cpp 2011-11-16 23:37:15 UTC (rev 100516)
@@ -33,10 +33,12 @@
void ArgList::getSlice(int startIndex, ArgList result) const
{
if (startIndex = 0 || static_castunsigned(startIndex) = m_argCount) {
-result = ArgList(m_args, 0);
+result = ArgList();
return;
}
-result = ArgList(m_args + startIndex, m_argCount - startIndex);
+
+result.m_args = m_args + startIndex;
+result.m_argCount = m_argCount - startIndex;
}
void MarkedArgumentBuffer::markLists(HeapRootVisitor heapRootVisitor, ListSet markSet)
Modified: trunk/Source/_javascript_Core/runtime/ArgList.h (100515 => 100516)
--- trunk/Source/_javascript_Core/runtime/ArgList.h 2011-11-16 23:33:18 UTC (rev 100515)
+++
[webkit-changes] [100517] trunk/Source/WebCore
Title: [100517] trunk/Source/WebCore
Revision 100517
Author wei...@apple.com
Date 2011-11-16 15:46:54 -0800 (Wed, 16 Nov 2011)
Log Message
JS wrappers of DOM objects should have no-op constructors
https://bugs.webkit.org/show_bug.cgi?id=72556
Reviewed by Geoffrey Garen.
Stop using a RefPtr to hold DOM objects contained by _javascript_
wrappers and instead use a raw pointer. We were already releasing
the underlying object before the destructor ran (via the finalizer)
so the default behavior of destroying the RefPtr is always unnecessary
busy work.
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
(WebCore::JSNode::visitChildren):
Call releaseImpl() instead of clearImpl().
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
clearImpl() to releaseImpl(), which explicitly derefs the pointer and
clear it.
(GenerateImplementation):
Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
Change default finalize to call releaseImpl() instead of clearImpl().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp
trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (100516 => 100517)
--- trunk/Source/WebCore/ChangeLog 2011-11-16 23:37:15 UTC (rev 100516)
+++ trunk/Source/WebCore/ChangeLog 2011-11-16 23:46:54 UTC (rev 100517)
@@ -1,3 +1,33 @@
+2011-11-16 Sam Weinig s...@webkit.org
+
+JS wrappers of DOM objects should have no-op constructors
+https://bugs.webkit.org/show_bug.cgi?id=72556
+
+Reviewed by Geoffrey Garen.
+
+Stop using a RefPtr to hold DOM objects contained by _javascript_
+wrappers and instead use a raw pointer. We were already releasing
+the underlying object before the destructor ran (via the finalizer)
+so the default behavior of destroying the RefPtr is always unnecessary
+busy work.
+
+* bindings/js/JSCSSValueCustom.cpp:
+(WebCore::JSCSSValueOwner::finalize):
+* bindings/js/JSNodeCustom.cpp:
+(WebCore::JSNodeOwner::finalize):
+(WebCore::JSNode::visitChildren):
+Call releaseImpl() instead of clearImpl().
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+Stop storing m_impl in a RefPtr and instead use a raw pointer. Switch
+clearImpl() to releaseImpl(), which explicitly derefs the pointer and
+clear it.
+
+(GenerateImplementation):
+Use leakPtr() to explicitly adopt the PassRefPtr into the raw pointer.
+Change default finalize to call releaseImpl() instead of clearImpl().
+
2011-11-16 Michael Saboff msab...@apple.com
Enable 8 Bit Strings in _javascript_Core
Modified: trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp (100516 => 100517)
--- trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp 2011-11-16 23:37:15 UTC (rev 100516)
+++ trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp 2011-11-16 23:46:54 UTC (rev 100517)
@@ -68,7 +68,7 @@
DOMWrapperWorld* world = static_castDOMWrapperWorld*(context);
world-m_cssValueRoots.remove(jsCSSValue-impl());
uncacheWrapper(world, jsCSSValue-impl(), jsCSSValue);
-jsCSSValue-clearImpl();
+jsCSSValue-releaseImpl();
}
JSValue toJS(ExecState* exec, JSDOMGlobalObject* globalObject, CSSValue* value)
Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (100516 => 100517)
--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2011-11-16 23:37:15 UTC (rev 100516)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2011-11-16 23:46:54 UTC (rev 100517)
@@ -141,7 +141,7 @@
JSNode* jsNode = static_castJSNode*(handle.get().asCell());
DOMWrapperWorld* world = static_castDOMWrapperWorld*(context);
uncacheWrapper(world, jsNode-impl(), jsNode);
-jsNode-clearImpl();
+jsNode-releaseImpl();
}
JSValue JSNode::insertBefore(ExecState* exec)
@@ -201,7 +201,7 @@
ASSERT(thisObject-structure()-typeInfo().overridesVisitChildren());
Base::visitChildren(thisObject, visitor);
-Node* node = thisObject-m_impl.get();
+Node* node = thisObject-impl();
node-visitJSEventListeners(visitor);
visitor.addOpaqueRoot(root(node));
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (100516 => 100517)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-16 23:37:15 UTC (rev 100516)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-16 23:46:54 UTC (rev 100517)
@@ -924,10 +924,10 @@
}
if (!$hasParent) {
-push(@headerContent, $implType* impl() const { return m_impl.get(); }\n);
-push(@headerContent, void clearImpl() { m_impl.clear(); }\n\n);
+push(@headerContent,
[webkit-changes] [100518] trunk/Source/JavaScriptCore
Title: [100518] trunk/Source/_javascript_Core
Revision 100518
Author par...@webkit.org
Date 2011-11-16 16:04:09 -0800 (Wed, 16 Nov 2011)
Log Message
Unreviewed. Build fix for !ENABLE(JIT) after r100363.
* bytecode/CodeBlock.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100517 => 100518)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-16 23:46:54 UTC (rev 100517)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-17 00:04:09 UTC (rev 100518)
@@ -1,3 +1,9 @@
+2011-11-16 Patrick Gansterer par...@webkit.org
+
+Unreviewed. Build fix for !ENABLE(JIT) after r100363.
+
+* bytecode/CodeBlock.h:
+
2011-11-16 Geoffrey Garen gga...@apple.com
Rolled back in r100375 and r100385 with 32-bit build fixed.
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (100517 => 100518)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-16 23:46:54 UTC (rev 100517)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-17 00:04:09 UTC (rev 100518)
@@ -997,21 +997,21 @@
static ptrdiff_t offsetOfSpeculativeSuccessCounter() { return OBJECT_OFFSETOF(CodeBlock, m_speculativeSuccessCounter); }
static ptrdiff_t offsetOfSpeculativeFailCounter() { return OBJECT_OFFSETOF(CodeBlock, m_speculativeFailCounter); }
-
+#if ENABLE(JIT)
// The number of failures that triggers the use of the ratio.
unsigned largeFailCountThreshold() { return Heuristics::largeFailCountThresholdBase baselineVersion()-reoptimizationRetryCounter(); }
unsigned largeFailCountThresholdForLoop() { return Heuristics::largeFailCountThresholdBaseForLoop baselineVersion()-reoptimizationRetryCounter(); }
-
+
bool shouldReoptimizeNow()
{
return Heuristics::desiredSpeculativeSuccessFailRatio * speculativeFailCounter() = speculativeSuccessCounter() speculativeFailCounter() = largeFailCountThreshold();
}
-
+
bool shouldReoptimizeFromLoopNow()
{
return Heuristics::desiredSpeculativeSuccessFailRatio * speculativeFailCounter() = speculativeSuccessCounter() speculativeFailCounter() = largeFailCountThresholdForLoop();
}
-
+#endif
#if ENABLE(VALUE_PROFILER)
bool shouldOptimizeNow();
#else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100520] trunk/LayoutTests
Title: [100520] trunk/LayoutTests Revision 100520 Author pkast...@chromium.org Date 2011-11-16 16:20:10 -0800 (Wed, 16 Nov 2011) Log Message [chromium] Clean up some animations/ expectations. https://bugs.webkit.org/show_bug.cgi?id=66953 Rebaselines some tests that clearly just needed that, tries to condense a number of other flaky tests onto one bug, updates the set of bots that are actually failing for some expectations. Unreviewed, gardening. * platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed. * platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed. * platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed. * platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added. * platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added. * platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added. * platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added. * platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added. * platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added. * platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png: Added. * platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png: Added. * platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png: Added. * platform/chromium-win/animations/missing-values-first-keyframe-expected.png: * platform/chromium-win/animations/missing-values-last-keyframe-expected.png: * platform/chromium-win/animations/opacity-transform-animation-expected.png: * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt trunk/LayoutTests/platform/chromium-win/animations/missing-values-first-keyframe-expected.png trunk/LayoutTests/platform/chromium-win/animations/missing-values-last-keyframe-expected.png trunk/LayoutTests/platform/chromium-win/animations/opacity-transform-animation-expected.png Added Paths trunk/LayoutTests/platform/chromium-linux/animations/missing-values-first-keyframe-expected.png trunk/LayoutTests/platform/chromium-linux/animations/missing-values-last-keyframe-expected.png trunk/LayoutTests/platform/chromium-linux/animations/opacity-transform-animation-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png trunk/LayoutTests/platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/animations/missing-values-first-keyframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/animations/missing-values-last-keyframe-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/animations/opacity-transform-animation-expected.png Removed Paths trunk/LayoutTests/platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png trunk/LayoutTests/platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png trunk/LayoutTests/platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (100519 => 100520) --- trunk/LayoutTests/ChangeLog 2011-11-17 00:16:50 UTC (rev 100519) +++ trunk/LayoutTests/ChangeLog 2011-11-17 00:20:10 UTC (rev 100520) @@ -1,3 +1,31 @@ +2011-11-16 Peter Kasting pkast...@google.com + +[chromium] Clean up some animations/ expectations. +https://bugs.webkit.org/show_bug.cgi?id=66953 + +Rebaselines some tests that clearly just needed that, tries to condense +a number of other flaky tests onto one bug, updates the set of bots that +are actually failing for some expectations. + +Unreviewed, gardening. + +* platform/chromium-cg-mac/animations/missing-values-first-keyframe-expected.png: Removed. +* platform/chromium-cg-mac/animations/missing-values-last-keyframe-expected.png: Removed. +* platform/chromium-cg-mac/animations/opacity-transform-animation-expected.png: Removed. +* platform/chromium-linux/animations/missing-values-first-keyframe-expected.png: Added. +* platform/chromium-linux/animations/missing-values-last-keyframe-expected.png: Added. +* platform/chromium-linux/animations/opacity-transform-animation-expected.png: Added. +* platform/chromium-mac-leopard/animations/missing-values-first-keyframe-expected.png: Added. +* platform/chromium-mac-leopard/animations/missing-values-last-keyframe-expected.png: Added. +* platform/chromium-mac-leopard/animations/opacity-transform-animation-expected.png: Added. +
[webkit-changes] [100521] trunk/Source/JavaScriptCore
Title: [100521] trunk/Source/_javascript_Core
Revision 100521
Author gga...@apple.com
Date 2011-11-16 16:21:26 -0800 (Wed, 16 Nov 2011)
Log Message
Interpreter build fixes.
* bytecode/CodeBlock.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100520 => 100521)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-17 00:20:10 UTC (rev 100520)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-17 00:21:26 UTC (rev 100521)
@@ -1,3 +1,11 @@
+2011-11-16 Geoffrey Garen gga...@apple.com
+
+Interpreter build fixes.
+
+* bytecode/CodeBlock.h:
+* interpreter/Interpreter.cpp:
+(JSC::Interpreter::privateExecute):
+
2011-11-16 Patrick Gansterer par...@webkit.org
Unreviewed. Build fix for !ENABLE(JIT) after r100363.
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.h (100520 => 100521)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-17 00:20:10 UTC (rev 100520)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.h 2011-11-17 00:21:26 UTC (rev 100521)
@@ -997,6 +997,7 @@
static ptrdiff_t offsetOfSpeculativeSuccessCounter() { return OBJECT_OFFSETOF(CodeBlock, m_speculativeSuccessCounter); }
static ptrdiff_t offsetOfSpeculativeFailCounter() { return OBJECT_OFFSETOF(CodeBlock, m_speculativeFailCounter); }
+
#if ENABLE(JIT)
// The number of failures that triggers the use of the ratio.
unsigned largeFailCountThreshold() { return Heuristics::largeFailCountThresholdBase baselineVersion()-reoptimizationRetryCounter(); }
@@ -1012,6 +1013,7 @@
return Heuristics::desiredSpeculativeSuccessFailRatio * speculativeFailCounter() = speculativeSuccessCounter() speculativeFailCounter() = largeFailCountThresholdForLoop();
}
#endif
+
#if ENABLE(VALUE_PROFILER)
bool shouldOptimizeNow();
#else
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (100520 => 100521)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-11-17 00:20:10 UTC (rev 100520)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2011-11-17 00:21:26 UTC (rev 100521)
@@ -1784,8 +1784,7 @@
int dst = vPC[1].u.operand;
int firstArg = vPC[2].u.operand;
int argCount = vPC[3].u.operand;
-ArgList args(callFrame-registers() + firstArg, argCount);
-callFrame-uncheckedR(dst) = JSValue(constructArray(callFrame, args));
+callFrame-uncheckedR(dst) = JSValue(constructArray(callFrame, reinterpret_castJSValue*(callFrame-registers()[firstArg]), argCount));
vPC += OPCODE_LENGTH(op_new_array);
NEXT_INSTRUCTION();
@@ -1800,8 +1799,7 @@
int dst = vPC[1].u.operand;
int firstArg = vPC[2].u.operand;
int argCount = vPC[3].u.operand;
-ArgList args(codeBlock-constantBuffer(firstArg), argCount);
-callFrame-uncheckedR(dst) = JSValue(constructArray(callFrame, args));
+callFrame-uncheckedR(dst) = JSValue(constructArray(callFrame, codeBlock-constantBuffer(firstArg), argCount));
vPC += OPCODE_LENGTH(op_new_array);
NEXT_INSTRUCTION();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100525] branches/safari-534.53-branch/Source/WebKit2
Title: [100525] branches/safari-534.53-branch/Source/WebKit2
Revision 100525
Author lforsch...@apple.com
Date 2011-11-16 16:39:55 -0800 (Wed, 16 Nov 2011)
Log Message
Merge 93314.
Modified Paths
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-534.53-branch/Source/WebKit2/UIProcess/PageClient.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/win/WebView.h
Diff
Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (100524 => 100525)
--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-11-17 00:35:05 UTC (rev 100524)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-11-17 00:39:55 UTC (rev 100525)
@@ -1,5 +1,50 @@
2011-11-16 Lucas Forschler lforsch...@apple.com
+Merge 93314
+
+2011-08-18 Adam Roben aro...@apple.com
+
+Make WebPageProxy keep track of the current device scale factor
+
+The device scale factor is no longer considered part of WebPageProxy's view state. It now
+has its own setter/getter. This made the code a little simpler and more similar to the page
+scale factor. Each port-specific WebKit2 view is now responsible for calling
+WebPageProxy::setDeviceScaleFactor whenever it thinks the device scale factor might have
+changed.
+
+Fixes http://webkit.org/b/66466 WebKit2 requires every port-specific view to keep track of
+the current device scale factor
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/efl/PageClientImpl.cpp:
+* UIProcess/API/efl/PageClientImpl.h:
+* UIProcess/API/gtk/PageClientImpl.h:
+* UIProcess/API/mac/PageClientImpl.h:
+* UIProcess/API/mac/PageClientImpl.mm:
+* UIProcess/PageClient.h:
+* UIProcess/qt/QtWebPageProxy.h:
+* UIProcess/win/WebView.h:
+Removed deviceScaleFactor.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _deviceScaleFactor]): Added. Code came from PageClientImpl::deviceScaleFactor.
+(-[WKView _windowDidChangeResolution:]): Changed to call WebPageProxy::setDeviceScaleFactor.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::WebPageProxy): Initialize m_deviceScaleFactor.
+(WebKit::WebPageProxy::viewStateDidChange): Removed device-scale-factor-related code.
+(WebKit::WebPageProxy::setDeviceScaleFactor): Added. Records the new device scale factor and
+tells the DrawingAreaProxy about it if it's actually changed.
+(WebKit::WebPageProxy::creationParameters): Use m_deviceScaleFactor instead of calling out
+to the PageClient.
+
+* UIProcess/WebPageProxy.h: Added m_deviceScaleFactor and setDeviceScaleFactor, which
+replaces the DeviceScaleFactor ViewStateFlag.
+(WebKit::WebPageProxy::deviceScaleFactor): Inlined this now-simple getter.
+
+2011-11-16 Lucas Forschler lforsch...@apple.com
+
Merge 93303
2011-08-17 Adam Roben aro...@apple.com
Modified: branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h (100524 => 100525)
--- branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2011-11-17 00:35:05 UTC (rev 100524)
+++ branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h 2011-11-17 00:39:55 UTC (rev 100525)
@@ -86,7 +86,6 @@
virtual void setFindIndicator(PassRefPtrFindIndicator, bool fadeOut);
virtual void didChangeScrollbarsForMainFrame() const;
virtual void flashBackingStoreUpdates(const VectorWebCore::IntRect updateRects);
-virtual float deviceScaleFactor() const { return 1; }
virtual void getEditorCommandsForKeyEvent(const NativeWebKeyboardEvent, VectorWTF::String);
virtual void findStringInCustomRepresentation(const String, FindOptions, unsigned);
virtual void countStringMatchesInCustomRepresentation(const String, FindOptions, unsigned);
Modified: branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h (100524 => 100525)
--- branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2011-11-17 00:35:05 UTC (rev 100524)
+++ branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/mac/PageClientImpl.h 2011-11-17 00:39:55 UTC (rev 100525)
@@ -120,8 +120,6 @@
virtual String dismissCorrectionPanelSoon(WebCore::ReasonForDismissingCorrectionPanel);
virtual void
[webkit-changes] [100526] branches/safari-534.53-branch/Tools
Title: [100526] branches/safari-534.53-branch/Tools
Revision 100526
Author lforsch...@apple.com
Date 2011-11-16 16:46:21 -0800 (Wed, 16 Nov 2011)
Log Message
Merged r93052.
Modified Paths
branches/safari-534.53-branch/Tools/ChangeLog
branches/safari-534.53-branch/Tools/TestWebKitAPI/_javascript_Test.cpp
branches/safari-534.53-branch/Tools/TestWebKitAPI/_javascript_Test.h
branches/safari-534.53-branch/Tools/TestWebKitAPI/Test.h
branches/safari-534.53-branch/Tools/TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp
branches/safari-534.53-branch/Tools/TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp
branches/safari-534.53-branch/Tools/TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp
Diff
Modified: branches/safari-534.53-branch/Tools/ChangeLog (100525 => 100526)
--- branches/safari-534.53-branch/Tools/ChangeLog 2011-11-17 00:39:55 UTC (rev 100525)
+++ branches/safari-534.53-branch/Tools/ChangeLog 2011-11-17 00:46:21 UTC (rev 100526)
@@ -1,3 +1,42 @@
+2011-11-16 Lucas Forschler lforsch...@apple.com
+
+Merge 93052.
+
+2011-08-15 Adam Roben aro...@apple.com
+
+Teach TestWebKitAPI/gtest how to print _javascript_ failures nicely
+
+Failures now give output of the form: foo should be bar but is baz
+
+Fixes http://webkit.org/b/66240 It's hard to tell what the actual result of a failed JS
+test is in TestWebKitAPI's output
+
+Reviewed by David Levin.
+
+* TestWebKitAPI/_javascript_Test.cpp:
+(TestWebKitAPI::_javascript_CallbackContext::_javascript_CallbackContext): Removed now-unused
+members.
+(TestWebKitAPI::_javascript_Callback): Changed to just store the result string in the context
+object, rather than doing any testing of it here.
+(TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
+to use a pretty error message when the test fails.
+
+* TestWebKitAPI/_javascript_Test.h: Changed runJSTest to a predicate-formatter, and added nice
+gtest-style macros that wrap it.
+
+* TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
+
+* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
+(TestWebKitAPI::TEST): Changed to use the new macros.
+
+* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
+(TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
+longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
+the test passes, though. Returning early seems to have been an unnecessary optimization.
+
+* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
+(TestWebKitAPI::TEST): Changed to use the new macros.
+
2011-08-29 Lucas Forschler lforsch...@apple.com
Merged 92982
Modified: branches/safari-534.53-branch/Tools/TestWebKitAPI/_javascript_Test.cpp (100525 => 100526)
--- branches/safari-534.53-branch/Tools/TestWebKitAPI/_javascript_Test.cpp 2011-11-17 00:39:55 UTC (rev 100525)
+++ branches/safari-534.53-branch/Tools/TestWebKitAPI/_javascript_Test.cpp 2011-11-17 00:46:21 UTC (rev 100526)
@@ -28,17 +28,18 @@
#include PlatformUtilities.h
#include Test.h
#include _javascript_Core/_javascript_Core.h
+#include _javascript_Core/JSRetainPtr.h
#include WebKit2/WKRetainPtr.h
#include WebKit2/WKSerializedScriptValue.h
+#include wtf/OwnArrayPtr.h
namespace TestWebKitAPI {
struct _javascript_CallbackContext {
-_javascript_CallbackContext(const char* expectedString) : didFinish(false), expectedString(expectedString), didMatchExpectedString(false) { }
+_javascript_CallbackContext() : didFinish(false) { }
bool didFinish;
-const char* expectedString;
-bool didMatchExpectedString;
+JSRetainPtrJSStringRef actualString;
};
static void _javascript_Callback(WKSerializedScriptValueRef resultSerializedScriptValue, WKErrorRef error, void* ctx)
@@ -53,24 +54,30 @@
JSValueRef scriptValue = WKSerializedScriptValueDeserialize(resultSerializedScriptValue, scriptContext, 0);
ASSERT_NOT_NULL(scriptValue);
-JSStringRef scriptString = JSValueToStringCopy(scriptContext, scriptValue, 0);
-ASSERT_NOT_NULL(scriptString);
+context-actualString.adopt(JSValueToStringCopy(scriptContext, scriptValue, 0));
+ASSERT_NOT_NULL(context-actualString.get());
context-didFinish = true;
-context-didMatchExpectedString = JSStringIsEqualToUTF8CString(scriptString, context-expectedString);
-JSStringRelease(scriptString);
JSGlobalContextRelease(scriptContext);
EXPECT_NULL(error);
}
-bool runJSTest(WKPageRef page, const char* script, const char* expectedResult)
+::testing::AssertionResult runJSTest(const char*, const char*, const char*, WKPageRef page, const char* script, const char* expectedResult)
{
-
[webkit-changes] [100527] trunk/Source/JavaScriptCore
Title: [100527] trunk/Source/_javascript_Core
Revision 100527
Author fpi...@apple.com
Date 2011-11-16 16:49:50 -0800 (Wed, 16 Nov 2011)
Log Message
JSC::CodeBlock should know which references generated by the DFG are weak
https://bugs.webkit.org/show_bug.cgi?id=72563
Reviewed by Geoff Garen.
CodeBlock::m_dfgData now tracks weak references and weak reference transitions
(like ephemerons) generated by the DFG. The DFG makes sure to notify the
CodeBlock of all uses of weak references and weak reference transitions.
CodeBlock currently marks them strongly, since the weak marking logic is not
in place, yet.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::stronglyVisitWeakReferences):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::appendWeakReference):
(JSC::CodeBlock::shrinkWeakReferencesToFit):
(JSC::CodeBlock::appendWeakReferenceTransition):
(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::codeOriginOwner):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::addWeakReferenceTransition):
(JSC::DFG::JITCompiler::branchWeakPtr):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/CodeOrigin.h
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (100526 => 100527)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-17 00:46:21 UTC (rev 100526)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-17 00:49:50 UTC (rev 100527)
@@ -1,3 +1,44 @@
+2011-11-16 Filip Pizlo fpi...@apple.com
+
+JSC::CodeBlock should know which references generated by the DFG are weak
+https://bugs.webkit.org/show_bug.cgi?id=72563
+
+Reviewed by Geoff Garen.
+
+CodeBlock::m_dfgData now tracks weak references and weak reference transitions
+(like ephemerons) generated by the DFG. The DFG makes sure to notify the
+CodeBlock of all uses of weak references and weak reference transitions.
+CodeBlock currently marks them strongly, since the weak marking logic is not
+in place, yet.
+
+* bytecode/CodeBlock.cpp:
+(JSC::CodeBlock::visitAggregate):
+(JSC::CodeBlock::stronglyVisitWeakReferences):
+* bytecode/CodeBlock.h:
+(JSC::CodeBlock::appendWeakReference):
+(JSC::CodeBlock::shrinkWeakReferencesToFit):
+(JSC::CodeBlock::appendWeakReferenceTransition):
+(JSC::CodeBlock::shrinkWeakReferenceTransitionsToFit):
+(JSC::CodeBlock::WeakReferenceTransition::WeakReferenceTransition):
+* bytecode/CodeOrigin.h:
+(JSC::CodeOrigin::codeOriginOwner):
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleCall):
+(JSC::DFG::ByteCodeParser::handleInlining):
+(JSC::DFG::ByteCodeParser::parseBlock):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::link):
+* dfg/DFGJITCompiler.h:
+(JSC::DFG::JITCompiler::addWeakReference):
+(JSC::DFG::JITCompiler::addWeakReferenceTransition):
+(JSC::DFG::JITCompiler::branchWeakPtr):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::fillJSValue):
+(JSC::DFG::SpeculativeJIT::compile):
+
2011-11-16 Michael Saboff msab...@apple.com
LayoutTests for Debug Builds Crashes in _javascript_Core/yarr/YarrInterpreter.cpp(185)
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (100526 => 100527)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-11-17 00:46:21 UTC (rev 100526)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2011-11-17 00:49:50 UTC (rev 100527)
@@ -1654,8 +1654,26 @@
if (hasInstructions() m_shouldDiscardBytecode)
visitor.addUnconditionalFinalizer(this);
#endif
+
+stronglyVisitWeakReferences(visitor);
}
+void CodeBlock::stronglyVisitWeakReferences(SlotVisitor visitor)
+{
[webkit-changes] [100530] trunk/Source
Title: [100530] trunk/Source
Revision 100530
Author commit-qu...@webkit.org
Date 2011-11-16 16:59:48 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Track property changes for render surfaces.
https://bugs.webkit.org/show_bug.cgi?id=72521
Patch by Shawn Singh shawnsi...@chromium.org on 2011-11-16
Reviewed by James Robinson.
Source/WebCore:
Created CCRenderSurfaceTest for testing.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::setClipRect):
(WebCore::CCRenderSurface::setContentRect):
(WebCore::CCRenderSurface::surfacePropertyChanged):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::resetPropertyChangedFlag):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCLayerImplTest.cpp:
(WebCore::TEST):
* tests/CCRenderSurfaceTest.cpp: Added.
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/tests/CCLayerImplTest.cpp
Added Paths
trunk/Source/WebKit/chromium/tests/CCRenderSurfaceTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (100529 => 100530)
--- trunk/Source/WebCore/ChangeLog 2011-11-17 00:58:40 UTC (rev 100529)
+++ trunk/Source/WebCore/ChangeLog 2011-11-17 00:59:48 UTC (rev 100530)
@@ -1,3 +1,25 @@
+2011-11-16 Shawn Singh shawnsi...@chromium.org
+
+[chromium] Track property changes for render surfaces.
+https://bugs.webkit.org/show_bug.cgi?id=72521
+
+Reviewed by James Robinson.
+
+Created CCRenderSurfaceTest for testing.
+
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
+* platform/graphics/chromium/cc/CCLayerImpl.cpp:
+(WebCore::CCLayerImpl::resetPropertyChangedFlagForSubtree):
+* platform/graphics/chromium/cc/CCLayerImpl.h:
+* platform/graphics/chromium/cc/CCRenderSurface.cpp:
+(WebCore::CCRenderSurface::CCRenderSurface):
+(WebCore::CCRenderSurface::setClipRect):
+(WebCore::CCRenderSurface::setContentRect):
+(WebCore::CCRenderSurface::surfacePropertyChanged):
+* platform/graphics/chromium/cc/CCRenderSurface.h:
+(WebCore::CCRenderSurface::resetPropertyChangedFlag):
+
2011-11-16 Ben Wells benwe...@chromium.org
Seaming on border corners with mixed colour alpha borders
Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (100529 => 100530)
--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-17 00:58:40 UTC (rev 100529)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp 2011-11-17 00:59:48 UTC (rev 100530)
@@ -343,6 +343,9 @@
drawLayer(layerList[layerIndex].get(), renderSurface);
}
}
+
+// The next frame should start by assuming nothing has changed, and changes are noted as they occur.
+rootDrawLayer-resetPropertyChangedFlagForSubtree();
}
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp (100529 => 100530)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp 2011-11-17 00:58:40 UTC (rev 100529)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.cpp 2011-11-17 00:59:48 UTC (rev 100530)
@@ -239,6 +239,17 @@
m_children[i]-noteLayerPropertyChangedForSubtree();
}
+void CCLayerImpl::resetPropertyChangedFlagForSubtree()
+{
+m_layerPropertyChanged = false;
+
+if (m_renderSurface)
+m_renderSurface-resetPropertyChangedFlag();
+
+for (size_t i = 0; i m_children.size(); ++i)
+m_children[i]-resetPropertyChangedFlagForSubtree();
+}
+
void CCLayerImpl::setBounds(const IntSize bounds)
{
if (m_bounds != bounds) {
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h (100529 => 100530)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h 2011-11-17 00:58:40 UTC (rev 100529)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerImpl.h 2011-11-17 00:59:48 UTC (rev 100530)
@@ -192,7 +192,7 @@
String layerTreeAsText() const;
bool layerPropertyChanged() const { return m_layerPropertyChanged; }
-void resetLayerPropertyChanged() {
[webkit-changes] [100531] branches/safari-534.53-branch/Source/WebCore
Title: [100531] branches/safari-534.53-branch/Source/WebCore
Revision 100531
Author lforsch...@apple.com
Date 2011-11-16 17:02:30 -0800 (Wed, 16 Nov 2011)
Log Message
Merged r93669.
Modified Paths
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.cpp
branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.h
branches/safari-534.53-branch/Source/WebCore/history/CachedPage.cpp
branches/safari-534.53-branch/Source/WebCore/history/CachedPage.h
branches/safari-534.53-branch/Source/WebCore/history/HistoryItem.cpp
branches/safari-534.53-branch/Source/WebCore/history/HistoryItem.h
branches/safari-534.53-branch/Source/WebCore/page/Frame.cpp
branches/safari-534.53-branch/Source/WebCore/page/Page.cpp
Diff
Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (100530 => 100531)
--- branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-17 00:59:48 UTC (rev 100530)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog 2011-11-17 01:02:30 UTC (rev 100531)
@@ -1,5 +1,55 @@
2011-11-16 Lucas Forschler lforsch...@apple.com
+Merge 93669
+
+2011-08-23 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=66244
+Cached pages don't fully update when going back after changing the display scale
+factor
+-and corresponding-
+rdar://problem/9955656
+
+Reviewed by Darin Adler.
+
+This patch adds a generalized concept of needing a full style recalc to the
+BackForwardController. So when the display scale factor is changed, the
+BackForwardController can be informed that all pages will need a full style recalc
+when they come out of the cache. This same mechanism is also used to fix a long-
+standing bug with full-page/text zoom.
+
+Iterate through the HistoryItems and mark all CachedPages as needing a full style
+recalc.
+* history/BackForwardController.cpp:
+(WebCore::BackForwardController::markPagesForFullStyleRecalc):
+* history/BackForwardController.h:
+
+ChachedPage has a new bool -- m_needsFullStyleRecalc -- to track whether a full
+style recalc is needed when the CachedPage is restored.
+* history/CachedPage.cpp:
+(WebCore::CachedPage::CachedPage):
+(WebCore::CachedPage::restore):
+(WebCore::CachedPage::clear):
+* history/CachedPage.h:
+(WebCore::CachedPage::markForFullStyleRecalc):
+
+HistoryItem actually takes care of calling into CachedPage.
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::markForFullStyleRecalc):
+* history/HistoryItem.h:
+
+Fix style recalc issues for full-page/text zoom by calling our new function on
+PageCache.
+* page/Frame.cpp:
+(WebCore::Frame::setPageAndTextZoomFactors):
+
+Fix style recalc issues for display scale factor changes by calling our new
+function on PageCache.
+* page/Page.cpp:
+(WebCore::Page::setDeviceScaleFactor):
+
+2011-11-16 Lucas Forschler lforsch...@apple.com
+
Merge 93303
2011-08-17 Adam Roben aro...@apple.com
Modified: branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.cpp (100530 => 100531)
--- branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.cpp 2011-11-17 00:59:48 UTC (rev 100530)
+++ branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.cpp 2011-11-17 01:02:30 UTC (rev 100531)
@@ -104,4 +104,15 @@
m_client-close();
}
+void BackForwardController::markPagesForFullStyleRecalc()
+{
+int first = -backCount();
+int last = forwardCount();
+for (int i = first; i = last; i++) {
+if (!i)
+continue;
+itemAtIndex(i)-markForFullStyleRecalc();
+}
+}
+
} // namespace WebCore
Modified: branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.h (100530 => 100531)
--- branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.h 2011-11-17 00:59:48 UTC (rev 100530)
+++ branches/safari-534.53-branch/Source/WebCore/history/BackForwardController.h 2011-11-17 01:02:30 UTC (rev 100531)
@@ -67,6 +67,8 @@
HistoryItem* currentItem() { return itemAtIndex(0); }
HistoryItem* forwardItem() { return itemAtIndex(1); }
+void markPagesForFullStyleRecalc();
+
private:
Page* m_page;
RefPtrBackForwardList m_client;
Modified: branches/safari-534.53-branch/Source/WebCore/history/CachedPage.cpp (100530 => 100531)
--- branches/safari-534.53-branch/Source/WebCore/history/CachedPage.cpp 2011-11-17 00:59:48 UTC (rev 100530)
+++ branches/safari-534.53-branch/Source/WebCore/history/CachedPage.cpp 2011-11-17
[webkit-changes] [100532] branches/safari-534.53-branch/Source
Title: [100532] branches/safari-534.53-branch/Source
Revision 100532
Author lforsch...@apple.com
Date 2011-11-16 17:08:49 -0800 (Wed, 16 Nov 2011)
Log Message
Merge 94122.
Modified Paths
branches/safari-534.53-branch/Source/WebKit/mac/ChangeLog
branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewData.h
branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewPrivate.h
branches/safari-534.53-branch/Source/WebKit2/ChangeLog
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/C/WKPage.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/API/C/WKPage.h
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp
branches/safari-534.53-branch/Source/WebKit2/UIProcess/WebPageProxy.h
Diff
Modified: branches/safari-534.53-branch/Source/WebKit/mac/ChangeLog (100531 => 100532)
--- branches/safari-534.53-branch/Source/WebKit/mac/ChangeLog 2011-11-17 01:02:30 UTC (rev 100531)
+++ branches/safari-534.53-branch/Source/WebKit/mac/ChangeLog 2011-11-17 01:08:49 UTC (rev 100532)
@@ -1,5 +1,25 @@
2011-11-16 Lucas Forschler lforsch...@apple.com
+Merge 94122
+
+2011-08-30 Beth Dakin bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67150
+Would like API to use a custom device scale factor for a particular WebView/WKView
+-and corresponding-
+rdar://problem/10041016
+
+Reviewed by Darin Adler.
+
+New API is _setOverrideBackingScaleFactor:(CGFloat)
+* WebView/WebView.mm:
+(-[WebView _setOverrideBackingScaleFactor:]):
+(-[WebView _deviceScaleFactor]):
+* WebView/WebViewData.h:
+* WebView/WebViewPrivate.h:
+
+2011-11-16 Lucas Forschler lforsch...@apple.com
+
Merge 99315
2011-08-18 Adam Roben aro...@apple.com
Modified: branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebView.mm (100531 => 100532)
--- branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebView.mm 2011-11-17 01:02:30 UTC (rev 100531)
+++ branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebView.mm 2011-11-17 01:08:49 UTC (rev 100532)
@@ -2832,6 +2832,16 @@
return view-fixedLayoutSize();
}
+- (void)_setOverrideBackingScaleFactor:(CGFloat)overrideScaleFactor
+{
+float oldScaleFactor = [self _deviceScaleFactor];
+
+_private-overrideBackingScaleFactor = overrideScaleFactor;
+
+if (oldScaleFactor != [self _deviceScaleFactor])
+_private-page-setDeviceScaleFactor(overrideScaleFactor);
+}
+
- (NSUInteger)markAllMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(NSUInteger)limit
{
return [self countMatchesForText:string options:(caseFlag ? 0 : WebFindOptionsCaseInsensitive) highlight:highlight limit:limit markMatches:YES];
@@ -5583,7 +5593,10 @@
- (float)_deviceScaleFactor
{
-NSWindow *window = [self window];
+if (_private-overrideBackingScaleFactor != 0)
+return _private-overrideBackingScaleFactor;
+
+NSWindow *window = [self window];
#if !defined(BUILDING_ON_LEOPARD) !defined(BUILDING_ON_SNOW_LEOPARD)
if (window)
return [window backingScaleFactor];
Modified: branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewData.h (100531 => 100532)
--- branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewData.h 2011-11-17 01:02:30 UTC (rev 100531)
+++ branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewData.h 2011-11-17 01:08:49 UTC (rev 100532)
@@ -189,5 +189,7 @@
BOOL interactiveFormValidationEnabled;
int validationMessageTimerMagnification;
+
+float overrideBackingScaleFactor;
}
@end
Modified: branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewPrivate.h (100531 => 100532)
--- branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewPrivate.h 2011-11-17 01:02:30 UTC (rev 100531)
+++ branches/safari-534.53-branch/Source/WebKit/mac/WebView/WebViewPrivate.h 2011-11-17 01:08:49 UTC (rev 100532)
@@ -559,6 +559,8 @@
- (BOOL)_useFixedLayout;
- (NSSize)_fixedLayoutSize;
+- (void)_setOverrideBackingScaleFactor:(CGFloat)overrideScaleFactor;
+
// Deprecated. Use the methods in pending public above instead.
- (WebNSUInteger)markAllMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(WebNSUInteger)limit;
- (WebNSUInteger)countMatchesForText:(NSString *)string caseSensitive:(BOOL)caseFlag highlight:(BOOL)highlight limit:(WebNSUInteger)limit markMatches:(BOOL)markMatches;
Modified: branches/safari-534.53-branch/Source/WebKit2/ChangeLog (100531 => 100532)
--- branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-11-17 01:02:30 UTC (rev 100531)
+++ branches/safari-534.53-branch/Source/WebKit2/ChangeLog 2011-11-17 01:08:49 UTC (rev 100532)
@@ -1,5 +1,30 @@
2011-11-16 Lucas Forschler lforsch...@apple.com
+Merge 94122
+
+
[webkit-changes] [100533] trunk
Title: [100533] trunk
Revision 100533
Author commit-qu...@webkit.org
Date 2011-11-16 17:14:06 -0800 (Wed, 16 Nov 2011)
Log Message
[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
https://bugs.webkit.org/show_bug.cgi?id=72562
Patch by James Robinson jam...@chromium.org on 2011-11-16
Reviewed by Dirk Pranke.
Tools:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):
LayoutTests:
* platform/chromium/test_expectations.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (100532 => 100533)
--- trunk/LayoutTests/ChangeLog 2011-11-17 01:08:49 UTC (rev 100532)
+++ trunk/LayoutTests/ChangeLog 2011-11-17 01:14:06 UTC (rev 100533)
@@ -1,3 +1,12 @@
+2011-11-16 James Robinson jam...@chromium.org
+
+[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
+https://bugs.webkit.org/show_bug.cgi?id=72562
+
+Reviewed by Dirk Pranke.
+
+* platform/chromium/test_expectations.txt:
+
2011-11-16 Ben Wells benwe...@chromium.org
Seaming on border corners with mixed colour alpha borders
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (100532 => 100533)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-17 01:08:49 UTC (rev 100532)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-17 01:14:06 UTC (rev 100533)
@@ -254,12 +254,16 @@
// this test will always fail.
WONTFIX SKIP LINUX WIN : fast/events/option-tab.html = FAIL
-// probably aren't applicable to this config
-BUGWK72402 : compositing/video-page-visibility.html = FAIL
-BUGWK72402 : compositing/geometry/clipped-video-controller.html = FAIL
-BUGWK72402 : compositing/geometry/video-fixed-scrolling.html = FAIL
-BUGWK72402 : compositing/geometry/video-opacity-overlay.html = FAIL
-BUGWK72402 : compositing/layer-creation/spanOverlapsCanvas.html = FAIL
+// Will need rebaselines for new compositing triggers
+BUGJAMESR : compositing/video-page-visibility.html = FAIL
+BUGJAMESR : compositing/geometry/clipped-video-controller.html = FAIL
+BUGJAMESR : compositing/geometry/video-fixed-scrolling.html = FAIL
+BUGJAMESR : compositing/geometry/video-opacity-overlay.html = FAIL
+BUGJAMESR : compositing/layer-creation/spanOverlapsCanvas.html = FAIL
+BUGJAMESR : compositing/layers-inside-overflow-scroll.html = FAIL
+BUGJAMESR : compositing/overflow/overflow-compositing-descendant.html = FAIL
+BUGJAMESR : compositing/overflow/scroll-ancestor-update.html = FAIL
+BUGJAMESR : compositing/self-painting-layers.html = FAIL
// text failures on every platform. appears to be a real issue
BUGWK72402 : compositing/geometry/limit-layer-bounds-clipping-ancestor.html = TEXT
Modified: trunk/Tools/ChangeLog (100532 => 100533)
--- trunk/Tools/ChangeLog 2011-11-17 01:08:49 UTC (rev 100532)
+++ trunk/Tools/ChangeLog 2011-11-17 01:14:06 UTC (rev 100533)
@@ -1,3 +1,13 @@
+2011-11-16 James Robinson jam...@chromium.org
+
+[chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
+https://bugs.webkit.org/show_bug.cgi?id=72562
+
+Reviewed by Dirk Pranke.
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::runFileTest):
+
2011-11-16 Tony Chang t...@chromium.org
[NRWT] speculative fix for multiple subprocess test on cygwin
Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (100532 => 100533)
--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2011-11-17 01:08:49 UTC (rev 100532)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp 2011-11-17 01:14:06 UTC (rev 100533)
@@ -218,6 +218,12 @@
|| testUrl.find(loading\\) != string::npos)
m_layoutTestController-setShouldDumpFrameLoadCallbacks(true);
+if (testUrl.find(compositing/) != string::npos || testUrl.find(compositing\\) != string::npos) {
+m_prefs.acceleratedCompositingForVideoEnabled = true;
+m_prefs.accelerated2dCanvasEnabled = true;
+m_prefs.applyTo(m_webView);
+}
+
if (testUrl.find(/dumpAsText/) != string::npos
|| testUrl.find(\\dumpAsText\\) != string::npos) {
m_layoutTestController-setShouldDumpAsText(true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [100534] trunk/Source
Title: [100534] trunk/Source Revision 100534 Author m...@apple.com Date 2011-11-16 17:19:46 -0800 (Wed, 16 Nov 2011) Log Message Source/WebCore: WebCore part of rdar://problem/10262242 Add API for paginated display https://bugs.webkit.org/show_bug.cgi?id=72537 Reviewed by Anders Carlsson. * WebCore.exp.in: Exported Page::pageCount(). * page/Page.cpp: (WebCore::Page::pageCount): Added this getter. * page/Page.h: Source/WebKit/mac: WebKit/mac part of rdar://problem/10262242 Add API for paginated display https://bugs.webkit.org/show_bug.cgi?id=72537 Reviewed by Anders Carlsson. * WebView/WebView.mm: (-[WebView _setPaginationMode:]): Added this accessor. (-[WebView _paginationMode]): Ditto. (-[WebView _setGapBetweenPages:]): Ditto. (-[WebView _gapBetweenPages]): Ditto. (-[WebView _pageCount]): Ditto. * WebView/WebViewPrivate.h: Defined WebPaginationMode enum and values. Source/WebKit2: WebKit2 part of rdar://problem/10262242 Add API for paginated display https://bugs.webkit.org/show_bug.cgi?id=72537 Reviewed by Anders Carlsson. * Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode): Encode the pagination mode and gap between pages. (WebKit::WebPageCreationParameters::decode): Decode the pagination mode and gap between pages. * Shared/WebPageCreationParameters.h: Added paginationMode and gapBetweenPages members. * UIProcess/API/C/WKPage.cpp: (WKPageSetPaginationMode): Added this API wrapper. (WKPageGetPaginationMode): Ditto. (WKPageSetGapBetweenPages): Ditto. (WKPageGetGapBetweenPages): Ditto. (WKPageGetPageCount): Ditto. * UIProcess/API/C/WKPagePrivate.h: Added an enum and a definition of WKPaginationMode and accessors. * UIProcess/API/mac/WKBrowsingContextController.mm: (-[WKBrowsingContextController setPaginationMode:]): Added this API wrapper. (-[WKBrowsingContextController paginationMode]): Ditto. (-[WKBrowsingContextController setGapBetweenPages:]): Ditto. (-[WKBrowsingContextController gapBetweenPages]): Ditto. (-[WKBrowsingContextController pageCount]): Ditto. * UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added. Includes an enum and a definition of WKBrowsingContextPaginationMode and property declarations. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Added intialization of m_paginationMode, m_gapBetweenPages, and m_pageCount. (WebKit::WebPageProxy::setPaginationMode): Added this accessor, which caches the value and sends a message to the WebPage. (WebKit::WebPageProxy::setGapBetweenPages): Ditto. (WebKit::WebPageProxy::creationParameters): Set the pagination mode and gap between pages in the creation parameters. (WebKit::WebPageProxy::didChangePageCount): Added. Updates the cached page count. * UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::paginationMode): Added this getter that returns a cached value. (WebKit::WebPageProxy::gapBetweenPages): Ditto. (WebKit::WebPageProxy::pageCount): Ditto. * UIProcess/WebPageProxy.messages.in: Added DidChangedPageCount, sent when the page count changes after layout. * WebKit2.xcodeproj/project.pbxproj: Added WKBrowsingContextControllerPrivate.h. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidLayout): Added a call to WebPage::mainFrameDidLayout(), allowing the page to respond to changes in the column count. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): Added initializer for m_cachedPageCount. (WebKit::WebPage::setPaginationMode): Added. (WebKit::WebPage::setGapBetweenPages): Added. (WebKit::WebPage::mainFrameDidLayout): Added. Sends a DidChangePageCount message to the UI process if the page count has changed. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Added SetPaginationMode and SetGapBetweenPages messages. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/page/Page.h trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebView.mm trunk/Source/WebKit/mac/WebView/WebViewPrivate.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebPageCreationParameters.cpp trunk/Source/WebKit2/Shared/WebPageCreationParameters.h trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp trunk/Source/WebKit2/UIProcess/API/C/WKPagePrivate.h trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.h trunk/Source/WebKit2/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in Added Paths trunk/Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h Diff Modified: trunk/Source/WebCore/ChangeLog (100533 => 100534) ---
