[webkit-changes] [101125] trunk/Source/WebCore
Title: [101125] trunk/Source/WebCore Revision 101125 Author yu...@chromium.org Date 2011-11-24 00:01:21 -0800 (Thu, 24 Nov 2011) Log Message Web Inspector: exceptions in shared workers should be logged to web inspector console https://bugs.webkit.org/show_bug.cgi?id=73022 According to section 4.7 Runtime script errors of Web Workers spec For shared workers, if the error is still not handled afterwards, or if the error occurred while handling a previous script error, the error may be reported to the user. This change adds uncaugh exceptions to the shared worker web inspector console. Reviewed by Pavel Feldman. * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::restore): * inspector/InspectorConsoleInstrumentation.h: (WebCore::InspectorInstrumentation::addMessageToConsole): * inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::restore): * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext): * inspector/InspectorInstrumentation.h: * inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend): (WebCore::WorkerInspectorController::disconnectFrontend): (WebCore::WorkerInspectorController::restoreInspectorStateFromCookie): * inspector/WorkerInspectorController.h: * inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.showWorkerTerminatedScreen): * inspector/front-end/inspector.js: * workers/SharedWorkerContext.cpp: (WebCore::SharedWorkerContext::logExceptionToConsole): * workers/SharedWorkerContext.h: * workers/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): console messages are now added to the worker console agent. (WebCore::WorkerContext::addMessageToWorkerConsole): * workers/WorkerContext.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp trunk/Source/WebCore/inspector/InspectorConsoleInstrumentation.h trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp trunk/Source/WebCore/inspector/InspectorInstrumentation.h trunk/Source/WebCore/inspector/WorkerInspectorController.cpp trunk/Source/WebCore/inspector/WorkerInspectorController.h trunk/Source/WebCore/inspector/front-end/WorkerManager.js trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/workers/SharedWorkerContext.cpp trunk/Source/WebCore/workers/SharedWorkerContext.h trunk/Source/WebCore/workers/WorkerContext.cpp trunk/Source/WebCore/workers/WorkerContext.h Diff Modified: trunk/Source/WebCore/ChangeLog (101124 => 101125) --- trunk/Source/WebCore/ChangeLog 2011-11-24 07:47:49 UTC (rev 101124) +++ trunk/Source/WebCore/ChangeLog 2011-11-24 08:01:21 UTC (rev 101125) @@ -1,3 +1,42 @@ +2011-11-23 Yury Semikhatsky yu...@chromium.org + +Web Inspector: exceptions in shared workers should be logged to web inspector console +https://bugs.webkit.org/show_bug.cgi?id=73022 + +According to section 4.7 Runtime script errors of Web Workers spec For shared +workers, if the error is still not handled afterwards, or if the error occurred +while handling a previous script error, the error may be reported to the user. + +This change adds uncaugh exceptions to the shared worker web inspector console. + +Reviewed by Pavel Feldman. + +* inspector/InspectorConsoleAgent.cpp: +(WebCore::InspectorConsoleAgent::restore): +* inspector/InspectorConsoleInstrumentation.h: +(WebCore::InspectorInstrumentation::addMessageToConsole): +* inspector/InspectorDebuggerAgent.cpp: +(WebCore::InspectorDebuggerAgent::restore): +* inspector/InspectorInstrumentation.cpp: +(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerContext): +* inspector/InspectorInstrumentation.h: +* inspector/WorkerInspectorController.cpp: +(WebCore::WorkerInspectorController::connectFrontend): +(WebCore::WorkerInspectorController::disconnectFrontend): +(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie): +* inspector/WorkerInspectorController.h: +* inspector/front-end/WorkerManager.js: +(WebInspector.WorkerManager.showWorkerTerminatedScreen): +* inspector/front-end/inspector.js: +* workers/SharedWorkerContext.cpp: +(WebCore::SharedWorkerContext::logExceptionToConsole): +* workers/SharedWorkerContext.h: +* workers/WorkerContext.cpp: +(WebCore::WorkerContext::addMessage): console messages are now added to +the worker console agent. +(WebCore::WorkerContext::addMessageToWorkerConsole): +* workers/WorkerContext.h: + 2011-11-23 Jeff Timanus t...@chromium.org [Chromium] Prevent DrawingBuffer instances from corrupting the active Modified: trunk/Source/WebCore/inspector/InspectorConsoleAgent.cpp (101124 => 101125) ---
[webkit-changes] [101126] trunk
Title: [101126] trunk Revision 101126 Author pfeld...@chromium.org Date 2011-11-24 00:11:05 -0800 (Thu, 24 Nov 2011) Log Message Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead. https://bugs.webkit.org/show_bug.cgi?id=73024 Source/WebCore: We use it for the URL mostly, no need to create artificial resource for that upon attaching to the existing page. Reviewed by Yury Semikhatsky. * inspector/front-end/AuditsPanel.js: * inspector/front-end/HAREntry.js: (WebInspector.HARLog.prototype._buildPages): (WebInspector.HARLog.prototype._pageEventTime): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkLogView.prototype._updateSummaryBar): (WebInspector.NetworkLogView.prototype._exportAll): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.set url): (WebInspector.Resource.prototype.get displayName): (WebInspector.Resource.prototype.get displayDomain): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel.prototype._processCachedResources): (WebInspector.ResourceTreeModel.prototype._dispatchInspectedURLChanged): (WebInspector.ResourceTreeModel.prototype._frameNavigated): (WebInspector.ResourceTreeModel.prototype._addFramesRecursively): * inspector/front-end/ResourceUtils.js: (WebInspector.displayNameForURL): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype._initDefaultSelection): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._addRecordToTimeline): * inspector/front-end/utilities.js: (String.prototype.asParsedURL): LayoutTests: Reviewed by Yury Semikhatsky. * inspector/debugger/debugger-breakpoints-not-activated-on-reload.html: * inspector/debugger/debugger-scripts.html: * inspector/debugger/linkifier.html: * inspector/debugger/selected-call-frame-after-formatting-source.html: * inspector/debugger/watch-expressions-panel-switch.html: * inspector/extensions/extensions-events.html: * inspector/performance/resources/first-open-resources.html: * inspector/performance/resources/performance-test.js: (initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump): (initialize_TimeTracker.InspectorTest.runPerformanceTest): * inspector/performance/resources/show-panel.html: * inspector/styles/styles-history.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector/debugger/debugger-breakpoints-not-activated-on-reload.html trunk/LayoutTests/inspector/debugger/debugger-scripts.html trunk/LayoutTests/inspector/debugger/linkifier.html trunk/LayoutTests/inspector/debugger/selected-call-frame-after-formatting-source.html trunk/LayoutTests/inspector/debugger/watch-expressions-panel-switch.html trunk/LayoutTests/inspector/extensions/extensions-events.html trunk/LayoutTests/inspector/performance/resources/first-open-resources.html trunk/LayoutTests/inspector/performance/resources/performance-test.js trunk/LayoutTests/inspector/performance/resources/show-panel.html trunk/LayoutTests/inspector/styles/styles-history.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/AuditsPanel.js trunk/Source/WebCore/inspector/front-end/HAREntry.js trunk/Source/WebCore/inspector/front-end/NetworkPanel.js trunk/Source/WebCore/inspector/front-end/Resource.js trunk/Source/WebCore/inspector/front-end/ResourceTreeModel.js trunk/Source/WebCore/inspector/front-end/ResourceUtils.js trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js trunk/Source/WebCore/inspector/front-end/TimelinePanel.js trunk/Source/WebCore/inspector/front-end/inspector.js trunk/Source/WebCore/inspector/front-end/utilities.js Diff Modified: trunk/LayoutTests/ChangeLog (101125 => 101126) --- trunk/LayoutTests/ChangeLog 2011-11-24 08:01:21 UTC (rev 101125) +++ trunk/LayoutTests/ChangeLog 2011-11-24 08:11:05 UTC (rev 101126) @@ -1,3 +1,23 @@ +2011-11-23 Pavel Feldman pfeld...@google.com + +Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead. +https://bugs.webkit.org/show_bug.cgi?id=73024 + +Reviewed by Yury Semikhatsky. + +* inspector/debugger/debugger-breakpoints-not-activated-on-reload.html: +* inspector/debugger/debugger-scripts.html: +* inspector/debugger/linkifier.html: +* inspector/debugger/selected-call-frame-after-formatting-source.html: +* inspector/debugger/watch-expressions-panel-switch.html: +* inspector/extensions/extensions-events.html: +* inspector/performance/resources/first-open-resources.html: +* inspector/performance/resources/performance-test.js: +(initialize_TimeTracker.InspectorTest.runPerformanceTest.Timer.prototype._dump): +(initialize_TimeTracker.InspectorTest.runPerformanceTest): +* inspector/performance/resources/show-panel.html: +* inspector/styles/styles-history.html: + 2011-11-23 Csaba Osztrogonác o...@webkit.org [Qt] Couple of tests
[webkit-changes] [101127] trunk/LayoutTests
Title: [101127] trunk/LayoutTests Revision 101127 Author yu...@chromium.org Date 2011-11-24 00:38:02 -0800 (Thu, 24 Nov 2011) Log Message 2011-11-24 Yury Semikhatsky yu...@chromium.org Unreviewed. Update test expectations. * platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (101126 => 101127) --- trunk/LayoutTests/ChangeLog 2011-11-24 08:11:05 UTC (rev 101126) +++ trunk/LayoutTests/ChangeLog 2011-11-24 08:38:02 UTC (rev 101127) @@ -1,3 +1,9 @@ +2011-11-24 Yury Semikhatsky yu...@chromium.org + +Unreviewed. Update test expectations. + +* platform/chromium/test_expectations.txt: Now that V8 bug 1821 is fixed the test should not crash. + 2011-11-23 Pavel Feldman pfeld...@google.com Web Inspector: get rid of the WebInspector.mainResource, use WebInspector.inspectedPageURL instead. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101126 => 101127) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-24 08:11:05 UTC (rev 101126) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-24 08:38:02 UTC (rev 101127) @@ -3749,8 +3749,7 @@ BUGWK72149 : media/track/tracklist-is-reachable.html = TEXT -BUGV8_1821 WIN LINUX : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH -BUGWK72133 SKIP MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS CRASH TIMEOUT +BUGWK72133 SKIP MAC : http/tests/inspector-enabled/dedicated-workers-list.html = PASS TIMEOUT // use Skia to draw vertical text directly instead of text-on-path BUG_CARYCLARK MAC CPU : editing/selection/vertical-lr-ltr-extend-line-backward-br.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101128] trunk
Title: [101128] trunk
Revision 101128
Author podivi...@chromium.org
Date 2011-11-24 01:10:20 -0800 (Thu, 24 Nov 2011)
Log Message
Web Inspector: add integration test for compiler source maps.
https://bugs.webkit.org/show_bug.cgi?id=72730
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/compiler-source-mapping-debug.html
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setCompilerSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
(WebInspector.DebuggerPresentationModel.DefaultLinkifierFormatter.prototype.formatRawSourceCodeAnchor):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype._updateAnchor):
LayoutTests:
* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
* http/tests/inspector/compiler-source-mapping-debug.html: Added.
* http/tests/inspector/resources/source-map.json:
* http/tests/inspector/resources/source1.js:
* http/tests/inspector/resources/source2.js:
(ClickHandler.prototype.handle):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/LayoutTests/http/tests/inspector/resources/source1.js
trunk/LayoutTests/http/tests/inspector/resources/source2.js
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
Added Paths
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/resources/compiled.js
Diff
Modified: trunk/LayoutTests/ChangeLog (101127 => 101128)
--- trunk/LayoutTests/ChangeLog 2011-11-24 08:38:02 UTC (rev 101127)
+++ trunk/LayoutTests/ChangeLog 2011-11-24 09:10:20 UTC (rev 101128)
@@ -1,3 +1,17 @@
+2011-11-23 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: add integration test for compiler source maps.
+https://bugs.webkit.org/show_bug.cgi?id=72730
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/compiler-source-mapping-debug-expected.txt: Added.
+* http/tests/inspector/compiler-source-mapping-debug.html: Added.
+* http/tests/inspector/resources/source-map.json:
+* http/tests/inspector/resources/source1.js:
+* http/tests/inspector/resources/source2.js:
+(ClickHandler.prototype.handle):
+
2011-11-24 Yury Semikhatsky yu...@chromium.org
Unreviewed. Update test expectations.
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (0 => 101128)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt 2011-11-24 09:10:20 UTC (rev 101128)
@@ -0,0 +1,15 @@
+CONSOLE MESSAGE: line 2: button clicked!
+Tests installing compiler source map in scripts panel.
+
+
+Debugger was enabled.
+
+Running: testSetBreakpoint
+Script source was shown.
+Script execution paused.
+Call stack:
+0) handleClick (compiled.js:2)
+1) clickButton (compiler-source-mapping-debug.html:11)
+Script execution resumed.
+Debugger was disabled.
+
Property changes on: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug-expected.txt
___
Added: svn:eol-style
Added: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (0 => 101128)
--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-debug.html 2011-11-24 09:10:20 UTC (rev 101128)
@@ -0,0 +1,53 @@
+html
+head
+script src=""
+script src=""
+script src=""
+
+script
+
+function clickButton()
+{
+document.getElementById('test').click();
+}
+
+function test()
+{
+
+InspectorTest.runDebuggerTestSuite([
+function testSetBreakpoint(next)
+{
+InspectorTest.showScriptSource(compiled.js, didShowCompiled);
+
+function didShowCompiled(sourceFrame)
+{
+InspectorTest.addResult(Script source was shown.);
+sourceFrame._model.setCompilerSourceMapping(sourceFrame._uiSourceCode,
[webkit-changes] [101129] trunk/Source/WebCore
Title: [101129] trunk/Source/WebCore
Revision 101129
Author apav...@chromium.org
Date 2011-11-24 01:37:27 -0800 (Thu, 24 Nov 2011)
Log Message
Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=69738
Reviewed by Timothy Hatcher.
The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
is traversed with the Up/Down keys.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.focus):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype.focus):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/TextViewer.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (101128 => 101129)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 09:10:20 UTC (rev 101128)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 09:37:27 UTC (rev 101129)
@@ -1,3 +1,20 @@
+2011-11-23 Alexander Pavlov apav...@chromium.org
+
+Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
+https://bugs.webkit.org/show_bug.cgi?id=69738
+
+Reviewed by Timothy Hatcher.
+
+The source viewer is focused whenever a file name option is clicked, and is NOT focused when the script list
+is traversed with the Up/Down keys.
+
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame.prototype.focus):
+* inspector/front-end/TextViewer.js:
+(WebInspector.TextViewer.prototype.focus):
+
2011-11-23 Pavel Podivilov podivi...@chromium.org
Web Inspector: add integration test for compiler source maps.
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (101128 => 101129)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-11-24 09:10:20 UTC (rev 101128)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-11-24 09:37:27 UTC (rev 101129)
@@ -69,8 +69,8 @@
this._filesSelectElement = document.createElement(select);
this._filesSelectElement.className = status-bar-item;
this._filesSelectElement.id = scripts-files;
-this._filesSelectElement.addEventListener(change, this._filesSelectChanged.bind(this), false);
-this._filesSelectElement.addEventListener(keyup, this._filesSelectChanged.bind(this), false);
+this._filesSelectElement.addEventListener(change, this._filesSelectChanged.bind(this, true), false);
+this._filesSelectElement.addEventListener(keyup, this._filesSelectChanged.bind(this, false), false);
this.topStatusBar.appendChild(this._filesSelectElement);
this.functionsSelectElement = document.createElement(select);
@@ -762,13 +762,15 @@
this._updateExecutionLine(this._presentationModel.executionLineLocation);
},
-_filesSelectChanged: function()
+_filesSelectChanged: function(focusSource)
{
if (this._filesSelectElement.selectedIndex === -1)
return;
var uiSourceCode = this._filesSelectElement[this._filesSelectElement.selectedIndex]._uiSourceCode;
-this._showSourceFrameAndAddToHistory(uiSourceCode);
+var sourceFrame = this._showSourceFrameAndAddToHistory(uiSourceCode);
+if (sourceFrame focusSource)
+sourceFrame.focus();
},
sidebarResized: function(event)
Modified: trunk/Source/WebCore/inspector/front-end/SourceFrame.js (101128 => 101129)
--- trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-11-24 09:10:20 UTC (rev 101128)
+++ trunk/Source/WebCore/inspector/front-end/SourceFrame.js 2011-11-24 09:37:27 UTC (rev 101129)
@@ -99,6 +99,11 @@
this.setReadOnly(true);
},
+focus: function()
+{
+this._textViewer.focus();
+},
+
get statusBarItems()
{
return [this._editButton.element];
Modified: trunk/Source/WebCore/inspector/front-end/TextViewer.js (101128 => 101129)
--- trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-11-24 09:10:20 UTC (rev 101128)
+++ trunk/Source/WebCore/inspector/front-end/TextViewer.js 2011-11-24 09:37:27 UTC (rev 101129)
@@ -98,6 +98,11 @@
return this._textModel;
},
+focus: function()
+{
+this._mainPanel.element.focus();
+},
+
revealLine: function(lineNumber)
{
this._mainPanel.revealLine(lineNumber);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101130] trunk/Source/WebCore
Title: [101130] trunk/Source/WebCore
Revision 101130
Author ph...@webkit.org
Date 2011-11-24 01:47:02 -0800 (Thu, 24 Nov 2011)
Log Message
Fix ASSERTs added in r101082.
Rubber-Stamped by Martin Robinson.
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef): Check for valid pointer before
GST_OBJECT_IS_FLOATING().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101129 => 101130)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 09:37:27 UTC (rev 101129)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 09:47:02 UTC (rev 101130)
@@ -1,3 +1,13 @@
+2011-11-24 Philippe Normand pnorm...@igalia.com
+
+Fix ASSERTs added in r101082.
+
+Rubber-Stamped by Martin Robinson.
+
+* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
+(WTF::adoptGRef): Check for valid pointer before
+GST_OBJECT_IS_FLOATING().
+
2011-11-23 Alexander Pavlov apav...@chromium.org
Web Inspector: shift focus to the source view when a resource is selected in the Scripts panel
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp (101129 => 101130)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp 2011-11-24 09:37:27 UTC (rev 101129)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp 2011-11-24 09:47:02 UTC (rev 101130)
@@ -27,7 +27,7 @@
template GRefPtrGstElement adoptGRef(GstElement* ptr)
{
-ASSERT(!GST_OBJECT_IS_FLOATING(GST_OBJECT(ptr)));
+ASSERT(!ptr || !GST_OBJECT_IS_FLOATING(GST_OBJECT(ptr)));
return GRefPtrGstElement(ptr, GRefPtrAdopt);
}
@@ -49,7 +49,7 @@
template GRefPtrGstPad adoptGRef(GstPad* ptr)
{
-ASSERT(!GST_OBJECT_IS_FLOATING(GST_OBJECT(ptr)));
+ASSERT(!ptr || !GST_OBJECT_IS_FLOATING(GST_OBJECT(ptr)));
return GRefPtrGstPad(ptr, GRefPtrAdopt);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101131] trunk/Source/JavaScriptCore
Title: [101131] trunk/Source/_javascript_Core
Revision 101131
Author par...@webkit.org
Date 2011-11-24 03:37:30 -0800 (Thu, 24 Nov 2011)
Log Message
[Qt] Use QEvent for dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=72704
Reviewed by Simon Hausmann.
Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
This is the same as what invokeMethod does internally, but reduces
the dependency on some internal QThread stuff.
* wtf/qt/MainThreadQt.cpp:
(WTF::MainThreadInvoker::MainThreadInvoker):
(WTF::MainThreadInvoker::event):
(WTF::scheduleDispatchFunctionsOnMainThread):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101130 => 101131)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-24 09:47:02 UTC (rev 101130)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-24 11:37:30 UTC (rev 101131)
@@ -1,3 +1,19 @@
+2011-11-24 Patrick Gansterer par...@webkit.org
+
+[Qt] Use QEvent for dispatchFunctionsFromMainThread()
+https://bugs.webkit.org/show_bug.cgi?id=72704
+
+Reviewed by Simon Hausmann.
+
+Replace QMetaObject::invokeMethod with QCoreApplication::postEvent.
+This is the same as what invokeMethod does internally, but reduces
+the dependency on some internal QThread stuff.
+
+* wtf/qt/MainThreadQt.cpp:
+(WTF::MainThreadInvoker::MainThreadInvoker):
+(WTF::MainThreadInvoker::event):
+(WTF::scheduleDispatchFunctionsOnMainThread):
+
2011-11-23 George Staikos stai...@webkit.org
Remove BlackBerry OS support from RandomNumberSeed, making QNX=UNIX.
Modified: trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp (101130 => 101131)
--- trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp 2011-11-24 09:47:02 UTC (rev 101130)
+++ trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp 2011-11-24 11:37:30 UTC (rev 101131)
@@ -31,29 +31,34 @@
#include config.h
#include MainThread.h
-#include QtCore/QObject
-#include QtCore/QCoreApplication
+#include QCoreApplication
+#include QEvent
+#include QObject
#include QThread
namespace WTF {
+static int s_mainThreadInvokerEventType;
+
class MainThreadInvoker : public QObject {
Q_OBJECT
public:
MainThreadInvoker();
-
-private Q_SLOTS:
-void dispatch();
+virtual bool event(QEvent*);
};
MainThreadInvoker::MainThreadInvoker()
{
-moveToThread(QCoreApplication::instance()-thread());
+s_mainThreadInvokerEventType = QEvent::registerEventType();
}
-void MainThreadInvoker::dispatch()
+bool MainThreadInvoker::event(QEvent* e)
{
+if (e-type() != s_mainThreadInvokerEventType)
+return QObject::event(e);
+
dispatchFunctionsFromMainThread();
+return true;
}
Q_GLOBAL_STATIC(MainThreadInvoker, webkit_main_thread_invoker)
@@ -64,7 +69,7 @@
void scheduleDispatchFunctionsOnMainThread()
{
-QMetaObject::invokeMethod(webkit_main_thread_invoker(), dispatch, Qt::QueuedConnection);
+QCoreApplication::postEvent(webkit_main_thread_invoker(), new QEvent(static_castQEvent::Type(s_mainThreadInvokerEventType)));
}
bool isMainThread()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101132] trunk/Source
Title: [101132] trunk/Source
Revision 101132
Author par...@webkit.org
Date 2011-11-24 05:03:51 -0800 (Thu, 24 Nov 2011)
Log Message
[CMake] Add missing source files
https://bugs.webkit.org/show_bug.cgi?id=73052
Reviewed by Andreas Kling.
Source/WebCore:
* CMakeLists.txt:
Source/WebKit2:
Add more generic files to the sources list and remove the EFL specific stuff.
* CMakeLists.txt:
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (101131 => 101132)
--- trunk/Source/WebCore/CMakeLists.txt 2011-11-24 11:37:30 UTC (rev 101131)
+++ trunk/Source/WebCore/CMakeLists.txt 2011-11-24 13:03:51 UTC (rev 101132)
@@ -1050,6 +1050,7 @@
platform/LinkHash.cpp
platform/Logging.cpp
platform/MIMETypeRegistry.cpp
+platform/MemoryPressureHandler.cpp
platform/RuntimeApplicationChecks.cpp
platform/ScrollAnimator.cpp
platform/ScrollableArea.cpp
Modified: trunk/Source/WebCore/ChangeLog (101131 => 101132)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 11:37:30 UTC (rev 101131)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 13:03:51 UTC (rev 101132)
@@ -1,3 +1,12 @@
+2011-11-24 Patrick Gansterer par...@webkit.org
+
+[CMake] Add missing source files
+https://bugs.webkit.org/show_bug.cgi?id=73052
+
+Reviewed by Andreas Kling.
+
+* CMakeLists.txt:
+
2011-11-24 Philippe Normand pnorm...@igalia.com
Fix ASSERTs added in r101082.
Modified: trunk/Source/WebKit2/CMakeLists.txt (101131 => 101132)
--- trunk/Source/WebKit2/CMakeLists.txt 2011-11-24 11:37:30 UTC (rev 101131)
+++ trunk/Source/WebKit2/CMakeLists.txt 2011-11-24 13:03:51 UTC (rev 101132)
@@ -10,7 +10,6 @@
${WEBKIT2_DIR}/Shared/Plugins
${WEBKIT2_DIR}/Shared/Plugins/Netscape
${WEBKIT2_DIR}/Shared/Plugins/Netscape/x11
-${WEBKIT2_DIR}/Shared/efl
${WEBKIT2_DIR}/UIProcess
${WEBKIT2_DIR}/UIProcess/API
${WEBKIT2_DIR}/UIProcess/API/C
@@ -19,7 +18,6 @@
${WEBKIT2_DIR}/UIProcess/Downloads
${WEBKIT2_DIR}/UIProcess/Launcher
${WEBKIT2_DIR}/UIProcess/Plugins
-${WEBKIT2_DIR}/UIProcess/efl
${WEBKIT2_DIR}/WebProcess
${WEBKIT2_DIR}/WebProcess/ApplicationCache
${WEBKIT2_DIR}/WebProcess/Authentication
@@ -93,6 +91,7 @@
)
SET(WebKit2_SOURCES
+Platform/CoreIPC/ArgumentCoders.cpp
Platform/CoreIPC/ArgumentDecoder.cpp
Platform/CoreIPC/ArgumentEncoder.cpp
Platform/CoreIPC/Attachment.cpp
@@ -129,7 +128,7 @@
Shared/API/c/WKURLResponse.cpp
Shared/API/c/WKUserContentURLPattern.cpp
-Shared/ShareableBitmap.cpp
+Shared/APIClientTraits.cpp
Shared/ChildProcess.cpp
Shared/ImmutableArray.cpp
Shared/ImmutableDictionary.cpp
@@ -138,28 +137,19 @@
Shared/OriginAndDatabases.cpp
Shared/PlatformPopupMenuData.cpp
Shared/PrintInfo.cpp
-
-Shared/Plugins/Netscape/NetscapePluginModule.cpp
-Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
-
-Shared/Plugins/NPIdentifierData.cpp
-Shared/Plugins/NPObjectMessageReceiver.cpp
-Shared/Plugins/NPObjectProxy.cpp
-Shared/Plugins/NPRemoteObjectMap.cpp
-Shared/Plugins/NPVariantData.cpp
-Shared/Plugins/PluginProcessCreationParameters.cpp
-
Shared/SecurityOriginData.cpp
Shared/SessionState.cpp
+Shared/ShareableBitmap.cpp
Shared/StatisticsData.cpp
Shared/UpdateInfo.cpp
Shared/VisitedLinkTable.cpp
Shared/WebBackForwardListItem.cpp
Shared/WebContextMenuItem.cpp
Shared/WebContextMenuItemData.cpp
+Shared/WebCoreArgumentCoders.cpp
Shared/WebError.cpp
+Shared/WebEvent.cpp
Shared/WebEventConversion.cpp
-Shared/WebEvent.cpp
Shared/WebGeolocationPosition.cpp
Shared/WebGraphicsContext.cpp
Shared/WebHitTestResult.cpp
@@ -178,6 +168,16 @@
Shared/WebURLResponse.cpp
Shared/WebWheelEvent.cpp
+Shared/Plugins/NPIdentifierData.cpp
+Shared/Plugins/NPObjectMessageReceiver.cpp
+Shared/Plugins/NPObjectProxy.cpp
+Shared/Plugins/NPRemoteObjectMap.cpp
+Shared/Plugins/NPVariantData.cpp
+Shared/Plugins/PluginProcessCreationParameters.cpp
+
+Shared/Plugins/Netscape/NetscapePluginModule.cpp
+Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
+
UIProcess/API/C/WKApplicationCacheManager.cpp
UIProcess/API/C/WKAuthenticationChallenge.cpp
UIProcess/API/C/WKAuthenticationDecisionListener.cpp
@@ -191,6 +191,10 @@
UIProcess/API/C/WKFormSubmissionListener.cpp
UIProcess/API/C/WKFrame.cpp
UIProcess/API/C/WKFramePolicyListener.cpp
+UIProcess/API/C/WKGeolocationManager.cpp
+UIProcess/API/C/WKGeolocationPermissionRequest.cpp
+UIProcess/API/C/WKGeolocationPosition.cpp
+UIProcess/API/C/WKGrammarDetail.cpp
UIProcess/API/C/WKHitTestResult.cpp
UIProcess/API/C/WKIconDatabase.cpp
UIProcess/API/C/WKInspector.cpp
@@ -205,30 +209,14 @@
[webkit-changes] [101133] trunk
Title: [101133] trunk
Revision 101133
Author ves...@webkit.org
Date 2011-11-24 05:07:54 -0800 (Thu, 24 Nov 2011)
Log Message
[Qt] Get rid of the buildDirForSource() function in the build system
At some point the plan was to allow for running qmake on sub-trees
of the sources, into the top level build directory, but this is no
longer possible, so no reason to keep the convenience function around.
Reviewed by Simon Hausmann.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.pri
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/DerivedSources.pri
trunk/Tools/WebKitTestRunner/InjectedBundle/DerivedSources.pri
trunk/Tools/qmake/mkspecs/features/default_post.prf
trunk/Tools/qmake/mkspecs/features/default_pre.prf
trunk/Tools/qmake/mkspecs/features/functions.prf
trunk/Tools/qmake/mkspecs/features/_javascript_core.prf
trunk/Tools/qmake/mkspecs/features/webcore.prf
trunk/Tools/qmake/mkspecs/features/webkit2.prf
Diff
Modified: trunk/Source/WebCore/ChangeLog (101132 => 101133)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 13:03:51 UTC (rev 101132)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 13:07:54 UTC (rev 101133)
@@ -1,3 +1,15 @@
+2011-11-24 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Get rid of the buildDirForSource() function in the build system
+
+At some point the plan was to allow for running qmake on sub-trees
+of the sources, into the top level build directory, but this is no
+longer possible, so no reason to keep the convenience function around.
+
+Reviewed by Simon Hausmann.
+
+* DerivedSources.pri:
+
2011-11-24 Patrick Gansterer par...@webkit.org
[CMake] Add missing source files
Modified: trunk/Source/WebCore/DerivedSources.pri (101132 => 101133)
--- trunk/Source/WebCore/DerivedSources.pri 2011-11-24 13:03:51 UTC (rev 101132)
+++ trunk/Source/WebCore/DerivedSources.pri 2011-11-24 13:07:54 UTC (rev 101133)
@@ -15,7 +15,7 @@
mac {
# FIXME: This runs the perl script every time. Is there a way we can run it only when deps change?
-fwheader_generator.commands = perl $${ROOT_WEBKIT_DIR}/Source/WebKit2/Scripts/generate-forwarding-headers.pl $${ROOT_WEBKIT_DIR}/Source/WebCore $$buildDirForSource(Source/include) mac
+fwheader_generator.commands = perl $${ROOT_WEBKIT_DIR}/Source/WebKit2/Scripts/generate-forwarding-headers.pl $${ROOT_WEBKIT_DIR}/Source/WebCore $${ROOT_BUILD_DIR}/Source/include mac
fwheader_generator.depends = $${ROOT_WEBKIT_DIR}/Source/WebKit2/Scripts/generate-forwarding-headers.pl
GENERATORS += fwheader_generator
}
Modified: trunk/Source/WebKit2/ChangeLog (101132 => 101133)
--- trunk/Source/WebKit2/ChangeLog 2011-11-24 13:03:51 UTC (rev 101132)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-24 13:07:54 UTC (rev 101133)
@@ -1,3 +1,15 @@
+2011-11-24 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Get rid of the buildDirForSource() function in the build system
+
+At some point the plan was to allow for running qmake on sub-trees
+of the sources, into the top level build directory, but this is no
+longer possible, so no reason to keep the convenience function around.
+
+Reviewed by Simon Hausmann.
+
+* DerivedSources.pri:
+
2011-11-24 Patrick Gansterer par...@webkit.org
[CMake] Add missing source files
Modified: trunk/Source/WebKit2/DerivedSources.pri (101132 => 101133)
--- trunk/Source/WebKit2/DerivedSources.pri 2011-11-24 13:03:51 UTC (rev 101132)
+++ trunk/Source/WebKit2/DerivedSources.pri 2011-11-24 13:07:54 UTC (rev 101133)
@@ -111,7 +111,7 @@
message_receiver_generator.output_function = message_receiver_generator_output
GENERATORS += message_receiver_generator
-fwheader_generator.commands = perl $${SOURCE_DIR}/WebKit2/Scripts/generate-forwarding-headers.pl $${SOURCE_DIR}/WebKit2 $$buildDirForSource(Source/include) qt
+fwheader_generator.commands = perl $${SOURCE_DIR}/WebKit2/Scripts/generate-forwarding-headers.pl $${SOURCE_DIR}/WebKit2 $${ROOT_BUILD_DIR}/Source/include qt
fwheader_generator.depends = $${SOURCE_DIR}/WebKit2/Scripts/generate-forwarding-headers.pl
generated_files.depends += fwheader_generator
GENERATORS += fwheader_generator
@@ -121,7 +121,7 @@
HEADER_PATH = $$HEADER
HEADER_TARGET = $$replace(HEADER_PATH, [^a-zA-Z0-9_], -)
HEADER_TARGET = qtheader-$${HEADER_TARGET}
-DESTDIR = $$buildDirForSource(Source/include/WebCore)
+DESTDIR = $${ROOT_BUILD_DIR}/Source/include/WebCore
eval($${HEADER_TARGET}.target = $$DESTDIR/$$HEADER_NAME)
eval($${HEADER_TARGET}.depends = $$HEADER_PATH)
Modified: trunk/Tools/ChangeLog (101132 => 101133)
--- trunk/Tools/ChangeLog 2011-11-24 13:03:51 UTC (rev 101132)
+++ trunk/Tools/ChangeLog 2011-11-24 13:07:54 UTC (rev 101133)
@@ -1,3 +1,22 @@
+2011-11-24 Tor Arne Vestbø tor.arne.ves...@nokia.com
+
+[Qt] Get rid of the
[webkit-changes] [101134] trunk/Source/JavaScriptCore
Title: [101134] trunk/Source/_javascript_Core
Revision 101134
Author hausm...@webkit.org
Date 2011-11-24 05:27:57 -0800 (Thu, 24 Nov 2011)
Log Message
[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably
Reviewed by Andreas Kling.
We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
ways of doing that and this fix seems like the least intrusive one by simply pushing the
invoker to the gui thread if it's not there already.
* wtf/qt/MainThreadQt.cpp:
(WTF::scheduleDispatchFunctionsOnMainThread):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101133 => 101134)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-24 13:07:54 UTC (rev 101133)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-24 13:27:57 UTC (rev 101134)
@@ -1,3 +1,16 @@
+2011-11-24 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably
+
+Reviewed by Andreas Kling.
+
+We must make sure that the MainThreadInvoker object lives in the gui thread. There are a few
+ways of doing that and this fix seems like the least intrusive one by simply pushing the
+invoker to the gui thread if it's not there already.
+
+* wtf/qt/MainThreadQt.cpp:
+(WTF::scheduleDispatchFunctionsOnMainThread):
+
2011-11-24 Patrick Gansterer par...@webkit.org
[Qt] Use QEvent for dispatchFunctionsFromMainThread()
Modified: trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp (101133 => 101134)
--- trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp 2011-11-24 13:07:54 UTC (rev 101133)
+++ trunk/Source/_javascript_Core/wtf/qt/MainThreadQt.cpp 2011-11-24 13:27:57 UTC (rev 101134)
@@ -69,7 +69,12 @@
void scheduleDispatchFunctionsOnMainThread()
{
-QCoreApplication::postEvent(webkit_main_thread_invoker(), new QEvent(static_castQEvent::Type(s_mainThreadInvokerEventType)));
+QObject* invoker = webkit_main_thread_invoker();
+if (invoker-thread() != QCoreApplication::instance()-thread()) {
+ASSERT(invoker-thread() == QThread::currentThread());
+invoker-moveToThread(QCoreApplication::instance()-thread());
+}
+QCoreApplication::postEvent(invoker, new QEvent(static_castQEvent::Type(s_mainThreadInvokerEventType)));
}
bool isMainThread()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101136] trunk/Source/WebKit2
Title: [101136] trunk/Source/WebKit2
Revision 101136
Author hausm...@webkit.org
Date 2011-11-24 05:45:16 -0800 (Thu, 24 Nov 2011)
Log Message
[Qt][WK2] Stop leaking memory in string QWK2 API's
https://bugs.webkit.org/show_bug.cgi?id=72558
Patch by Oleg Romashin rom...@gmail.com on 2011-11-17
Reviewed by Simon Hausmann.
WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
stay alive after destroying the API pointers.
This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
that will be around temporarily and correctly release the object.
* UIProcess/qt/QtWebPageUIClient.cpp:
(QtWebPageUIClient::mouseDidMoveOverElement):
* UIProcess/qt/QtDownloadManager.cpp:
(WebKit::qt_wk_didFailDownload):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::load):
(QtWebPageProxy::url):
(QtWebPageProxy::title):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (101135 => 101136)
--- trunk/Source/WebKit2/ChangeLog 2011-11-24 13:35:10 UTC (rev 101135)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-24 13:45:16 UTC (rev 101136)
@@ -1,3 +1,24 @@
+2011-11-17 Oleg Romashin rom...@gmail.com
+
+[Qt][WK2] Stop leaking memory in string QWK2 API's
+https://bugs.webkit.org/show_bug.cgi?id=72558
+
+Reviewed by Simon Hausmann.
+
+WKRef API pointers don't adopt the implementation pointers by default and the implementation pointers
+stay alive after destroying the API pointers.
+This patch adopts the implementation pointers correctly by using adoptWK that returns a WKRetainPtr
+that will be around temporarily and correctly release the object.
+
+* UIProcess/qt/QtWebPageUIClient.cpp:
+(QtWebPageUIClient::mouseDidMoveOverElement):
+* UIProcess/qt/QtDownloadManager.cpp:
+(WebKit::qt_wk_didFailDownload):
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::load):
+(QtWebPageProxy::url):
+(QtWebPageProxy::title):
+
2011-11-24 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Get rid of the buildDirForSource() function in the build system
Modified: trunk/Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp (101135 => 101136)
--- trunk/Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp 2011-11-24 13:35:10 UTC (rev 101135)
+++ trunk/Source/WebKit2/UIProcess/qt/QtDownloadManager.cpp 2011-11-24 13:45:16 UTC (rev 101136)
@@ -55,7 +55,7 @@
static void qt_wk_didFailDownload(WKContextRef context, WKDownloadRef download, WKErrorRef error, const void *clientInfo)
{
-QUrl failingUrl = WKURLCopyQUrl(WKErrorCopyFailingURL(error));
+QUrl failingUrl = WKURLCopyQUrl(adoptWK(WKErrorCopyFailingURL(error)).get());
toQtDownloadManager(clientInfo)-downloadFailed(toImpl(download), QtWebError(error));
}
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp (101135 => 101136)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-11-24 13:35:10 UTC (rev 101135)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp 2011-11-24 13:45:16 UTC (rev 101136)
@@ -730,7 +730,7 @@
void QtWebPageProxy::load(const QUrl url)
{
-WKRetainPtrWKURLRef wkurl(WKURLCreateWithQUrl(url));
+WKRetainPtrWKURLRef wkurl = adoptWK(WKURLCreateWithQUrl(url));
WKPageLoadURL(pageRef(), wkurl.get());
}
@@ -739,12 +739,12 @@
WKRetainPtrWKFrameRef frame = WKPageGetMainFrame(pageRef());
if (!frame)
return QUrl();
-return WKURLCopyQUrl(WKFrameCopyURL(frame.get()));
+return WKURLCopyQUrl(adoptWK(WKFrameCopyURL(frame.get())).get());
}
QString QtWebPageProxy::title() const
{
-return WKStringCopyQString(WKPageCopyTitle(toAPI(m_webPageProxy.get(;
+return WKStringCopyQString(adoptWK(WKPageCopyTitle(toAPI(m_webPageProxy.get(.get());
}
void QtWebPageProxy::setDrawingAreaSize(const QSize size)
Modified: trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp (101135 => 101136)
--- trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp 2011-11-24 13:35:10 UTC (rev 101135)
+++ trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp 2011-11-24 13:45:16 UTC (rev 101136)
@@ -135,7 +135,7 @@
void QtWebPageUIClient::mouseDidMoveOverElement(WKPageRef page, WKHitTestResultRef hitTestResult, WKEventModifiers modifiers, WKTypeRef userData, const void* clientInfo)
{
-const QUrl absoluteLinkUrl = WKURLCopyQUrl(WKHitTestResultCopyAbsoluteLinkURL(hitTestResult));
-const QString linkTitle = WKStringCopyQString(WKHitTestResultCopyLinkTitle(hitTestResult));
+const QUrl absoluteLinkUrl = WKURLCopyQUrl(adoptWK(WKHitTestResultCopyAbsoluteLinkURL(hitTestResult)).get());
+const QString linkTitle =
[webkit-changes] [101138] trunk/Source/WebCore
Title: [101138] trunk/Source/WebCore Revision 101138 Author ph...@webkit.org Date 2011-11-24 06:57:34 -0800 (Thu, 24 Nov 2011) Log Message [GStreamer] WebAudio AudioDestination https://bugs.webkit.org/show_bug.cgi?id=69835 Reviewed by Martin Robinson. New GStreamer source element pulling data from the AudioBus and outputing audio interleaved GstBuffers suitable for playback. * GNUmakefile.list.am: Added the new GStreamer WebAudio element source files to the build. * platform/audio/gstreamer/AudioDestinationGStreamer.cpp: (WebCore::onGStreamerWavparsePadAddedCallback): Function called when the playback pipeline successfully parsed the audio source into a WAV stream. (WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer): Configure the initial playback pipeline up to the WAV parser. The audio sink is added only after the WAV parser was configured. (WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer): Reset the playback pipeline and delete it. (WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady): Method to add the audio sink to the pipeline and link it to the WAV parser. (WebCore::AudioDestinationGStreamer::start): Set pipeline to PLAYING, at the first run it will trigger the WAV parser and hence the audio-sink plugging. (WebCore::AudioDestinationGStreamer::stop): Pause the pipeline. * platform/audio/gstreamer/AudioDestinationGStreamer.h: * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: Added. (getGStreamerMonoAudioCaps): Utility function to generate GStreamer caps representing a single audio channel for a given sample rate. (webKitWebAudioGStreamerChannelPosition): Utility function to convert AudioBus channel representations to GStreamer positional audio channel values. (webkit_web_audio_src_class_init): GObject configuration of the GStreamer source element. (webkit_web_audio_src_init): Initialization of the private data of the element. (webKitWebAudioSourceConstructed): Configure the GstBin elements depending on the AudioBus layout. (webKitWebAudioSourceFinalize): Clean up the GstBin and free private data of the element. (webKitWebAudioSourceSetProperty): GObject property setter. (webKitWebAudioSourceGetProperty): GObject property getter. (webKitWebAudioSourceLoop): GstTask used to pull data from the AudioBus and push it as GstBuffers to the src pad of the element. (webKitWebAudioSourceChangeState): Start or stop the above GstTask depending on the asked state transition. * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h: Added. * platform/graphics/gstreamer/GRefPtrGStreamer.cpp: GstTask support in GRefPtr. (WTF::adoptGRef): (WTF::GstTask): * platform/graphics/gstreamer/GRefPtrGStreamer.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp trunk/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp trunk/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h Added Paths trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.h Diff Modified: trunk/Source/WebCore/ChangeLog (101137 => 101138) --- trunk/Source/WebCore/ChangeLog 2011-11-24 13:45:34 UTC (rev 101137) +++ trunk/Source/WebCore/ChangeLog 2011-11-24 14:57:34 UTC (rev 101138) @@ -1,3 +1,59 @@ +2011-10-27 Philippe Normand pnorm...@igalia.com + +[GStreamer] WebAudio AudioDestination +https://bugs.webkit.org/show_bug.cgi?id=69835 + +Reviewed by Martin Robinson. + +New GStreamer source element pulling data from the AudioBus and +outputing audio interleaved GstBuffers suitable for playback. + +* GNUmakefile.list.am: Added the new GStreamer WebAudio element +source files to the build. +* platform/audio/gstreamer/AudioDestinationGStreamer.cpp: +(WebCore::onGStreamerWavparsePadAddedCallback): Function called +when the playback pipeline successfully parsed the audio source +into a WAV stream. +(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer): +Configure the initial playback pipeline up to the WAV parser. The +audio sink is added only after the WAV parser was configured. +(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer): +Reset the playback pipeline and delete it. +(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady): +Method to add the audio sink to the pipeline and link it to the +WAV parser. +(WebCore::AudioDestinationGStreamer::start): Set pipeline to +PLAYING, at the first run it will trigger the WAV parser and hence +the audio-sink plugging. +(WebCore::AudioDestinationGStreamer::stop): Pause the pipeline. +*
[webkit-changes] [101139] trunk/Source/WebCore
Title: [101139] trunk/Source/WebCore
Revision 101139
Author ca...@chromium.org
Date 2011-11-24 07:12:41 -0800 (Thu, 24 Nov 2011)
Log Message
Web Inspector: provide context menu items to open resources using extensions
https://bugs.webkit.org/show_bug.cgi?id=73076
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
* inspector/front-end/HandlerRegistry.js:
(get WebInspector.HandlerRegistry.prototype.set dispatch):
(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):
* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
* inspector/front-end/externs.js:
(WebInspector.populateResourceContextMenu):
* inspector/front-end/inspector.js:
(WebInspector.populateResourceContextMenu):
(WebInspector._showAnchorLocation):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ExtensionServer.js
trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js
trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/externs.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (101138 => 101139)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 14:57:34 UTC (rev 101138)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 15:12:41 UTC (rev 101139)
@@ -1,3 +1,29 @@
+2011-11-24 Andrey Kosyakov ca...@chromium.org
+
+Web Inspector: provide context menu items to open resources using extensions
+https://bugs.webkit.org/show_bug.cgi?id=73076
+
+Reviewed by Yury Semikhatsky.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/ExtensionServer.js:
+(WebInspector.ExtensionServer.prototype._onSetOpenResourceHandler):
+(WebInspector.ExtensionServer.prototype._handleOpenURL):
+* inspector/front-end/HandlerRegistry.js:
+(get WebInspector.HandlerRegistry.prototype.set dispatch):
+(get WebInspector.HandlerRegistry.prototype.dispatchToHandler):
+* inspector/front-end/_javascript_SourceFrame.js:
+(WebInspector._javascript_SourceFrame.prototype.populateTextAreaContextMenu):
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
+* inspector/front-end/SourceFrame.js:
+(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
+* inspector/front-end/externs.js:
+(WebInspector.populateResourceContextMenu):
+* inspector/front-end/inspector.js:
+(WebInspector.populateResourceContextMenu):
+(WebInspector._showAnchorLocation):
+
2011-10-27 Philippe Normand pnorm...@igalia.com
[GStreamer] WebAudio AudioDestination
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionServer.js (101138 => 101139)
--- trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2011-11-24 14:57:34 UTC (rev 101138)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionServer.js 2011-11-24 15:12:41 UTC (rev 101139)
@@ -272,14 +272,14 @@
{
var name = this._registeredExtensions[port._extensionOrigin].name || (Extension + port._extensionOrigin);
if (message.handlerPresent)
-WebInspector.openAnchorLocationRegistry.registerHandler(name, this._handleAnchorClicked.bind(this, port));
+WebInspector.openAnchorLocationRegistry.registerHandler(name, this._handleOpenURL.bind(this, port));
else
WebInspector.openAnchorLocationRegistry.unregisterHandler(name);
},
-_handleAnchorClicked: function(port, anchor)
+_handleOpenURL: function(port, url)
{
-var resource = WebInspector.resourceForURL(anchor.href);
+var resource = WebInspector.resourceForURL(url);
if (!resource)
return false;
port.postMessage({
Modified: trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js (101138 => 101139)
--- trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js 2011-11-24 14:57:34 UTC (rev 101138)
+++ trunk/Source/WebCore/inspector/front-end/HandlerRegistry.js 2011-11-24 15:12:41 UTC (rev 101139)
@@ -57,10 +57,22 @@
this._setting.set(value);
},
-dispatch: function()
+/**
+ * @param {Object} data
+
[webkit-changes] [101141] trunk/Source
Title: [101141] trunk/Source Revision 101141 Author zeno.albis...@nokia.com Date 2011-11-24 08:51:13 -0800 (Thu, 24 Nov 2011) Log Message [Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets https://bugs.webkit.org/show_bug.cgi?id=72495 Source/_javascript_Core: Update defines to not use Unix Domain Sockets for platform Qt on Mac. This enables Qt to reuse existing code for mach ports and Grand Central Dispatch based IPC. Reviewed by Simon Hausmann. * wtf/Platform.h: Source/WebKit2: Make Qt using mach ports and Grand Central Dispatch for IPC when building on Mac. Reviewed by Simon Hausmann. * Platform/CoreIPC/Attachment.cpp: * Platform/CoreIPC/Attachment.h: * Platform/CoreIPC/Connection.h: * Platform/CoreIPC/CoreIPCMessageKinds.h: * Platform/SharedMemory.h: * Platform/WorkQueue.h: * Platform/mac/MachUtilities.cpp: * Platform/mac/WorkQueueMac.cpp: * Target.pri: * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::ProcessLauncher::launchProcess): * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching): * WebProcess/qt/WebProcessMainQt.cpp: (WebKit::WebProcessMainQt): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/wtf/Platform.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/CoreIPC/Attachment.cpp trunk/Source/WebKit2/Platform/CoreIPC/Attachment.h trunk/Source/WebKit2/Platform/CoreIPC/Connection.h trunk/Source/WebKit2/Platform/CoreIPC/CoreIPCMessageKinds.h trunk/Source/WebKit2/Platform/SharedMemory.h trunk/Source/WebKit2/Platform/WorkQueue.h trunk/Source/WebKit2/Platform/mac/MachUtilities.cpp trunk/Source/WebKit2/Platform/mac/WorkQueueMac.cpp trunk/Source/WebKit2/Target.pri trunk/Source/WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp trunk/Source/WebKit2/WebProcess/qt/WebProcessMainQt.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (101140 => 101141) --- trunk/Source/_javascript_Core/ChangeLog 2011-11-24 16:36:29 UTC (rev 101140) +++ trunk/Source/_javascript_Core/ChangeLog 2011-11-24 16:51:13 UTC (rev 101141) @@ -1,3 +1,16 @@ +2011-11-24 Zeno Albisser z...@webkit.org + +[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets +https://bugs.webkit.org/show_bug.cgi?id=72495 + +Update defines to not use Unix Domain Sockets for platform Qt on Mac. +This enables Qt to reuse existing code for mach ports and Grand +Central Dispatch based IPC. + +Reviewed by Simon Hausmann. + +* wtf/Platform.h: + 2011-11-24 Simon Hausmann simon.hausm...@nokia.com [Qt] REGRESSION(r101131): WTF::scheduleDispatchFunctionsOnMainThread() doesn't work reliably Modified: trunk/Source/_javascript_Core/wtf/Platform.h (101140 => 101141) --- trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-24 16:36:29 UTC (rev 101140) +++ trunk/Source/_javascript_Core/wtf/Platform.h 2011-11-24 16:51:13 UTC (rev 101141) @@ -563,6 +563,7 @@ #if PLATFORM(QT) OS(DARWIN) #define WTF_USE_CF 1 +#define HAVE_DISPATCH_H 1 #endif #if OS(DARWIN) !PLATFORM(GTK) !PLATFORM(QT) @@ -1109,7 +1110,7 @@ breakages one port at a time. */ #define WTF_USE_EXPORT_MACROS 0 -#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL) +#if (PLATFORM(QT) !OS(DARWIN)) || PLATFORM(GTK) || PLATFORM(EFL) #define WTF_USE_UNIX_DOMAIN_SOCKETS 1 #endif Modified: trunk/Source/WebKit2/ChangeLog (101140 => 101141) --- trunk/Source/WebKit2/ChangeLog 2011-11-24 16:36:29 UTC (rev 101140) +++ trunk/Source/WebKit2/ChangeLog 2011-11-24 16:51:13 UTC (rev 101141) @@ -1,3 +1,29 @@ +2011-11-24 Zeno Albisser z...@webkit.org + +[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets +https://bugs.webkit.org/show_bug.cgi?id=72495 + +Make Qt using mach ports and Grand Central Dispatch for IPC +when building on Mac. + +Reviewed by Simon Hausmann. + +* Platform/CoreIPC/Attachment.cpp: +* Platform/CoreIPC/Attachment.h: +* Platform/CoreIPC/Connection.h: +* Platform/CoreIPC/CoreIPCMessageKinds.h: +* Platform/SharedMemory.h: +* Platform/WorkQueue.h: +* Platform/mac/MachUtilities.cpp: +* Platform/mac/WorkQueueMac.cpp: +* Target.pri: +* UIProcess/Launcher/qt/ProcessLauncherQt.cpp: +(WebKit::ProcessLauncher::launchProcess): +* UIProcess/WebProcessProxy.cpp: +(WebKit::WebProcessProxy::didFinishLaunching): +* WebProcess/qt/WebProcessMainQt.cpp: +(WebKit::WebProcessMainQt): + 2011-11-17 Oleg Romashin rom...@gmail.com [Qt][WK2] Stop leaking memory in string QWK2 API's Modified: trunk/Source/WebKit2/Platform/CoreIPC/Attachment.cpp (101140 => 101141) --- trunk/Source/WebKit2/Platform/CoreIPC/Attachment.cpp 2011-11-24 16:36:29 UTC (rev 101140) +++ trunk/Source/WebKit2/Platform/CoreIPC/Attachment.cpp 2011-11-24 16:51:13 UTC (rev 101141) @@ -36,7
[webkit-changes] [101142] trunk
Title: [101142] trunk
Revision 101142
Author commit-qu...@webkit.org
Date 2011-11-24 10:10:01 -0800 (Thu, 24 Nov 2011)
Log Message
IndexedDB: Indexes should be secondarily sorted on primary key
https://bugs.webkit.org/show_bug.cgi?id=72567
Patch by Joshua Bell jsb...@chromium.org on 2011-11-24
Reviewed by Tony Chang.
Source/WebCore:
Implemented by adding the primary key (i.e. unique key in the
object store) to the IndexDataKey (i.e. the composite key used
in the index. Previously, non-unique entries in the index were
stored with a unique (and hidden) sequenceNumber, so ordering was
not predictable by scripts (or per spec). The sequenceNumber
is now deprecated but still present in the LevelDB backing store
to avoid having to do a data migration.
Test: storage/indexeddb/cursor-primary-key-order.html
* storage/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
* storage/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):
* storage/IDBLevelDBCoding.h:
Source/WebKit/chromium:
Updates the IndexDataKey unit tests to include primary keys. The
deprecated sequenceNumber element of IndexDataKey is still tested,
although no longer used by callers.
* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):
LayoutTests:
* storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
* storage/indexeddb/cursor-primary-key-order.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/IDBLevelDBBackingStore.cpp
trunk/Source/WebCore/storage/IDBLevelDBCoding.cpp
trunk/Source/WebCore/storage/IDBLevelDBCoding.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBLevelDBCodingTest.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/cursor-primary-key-order-expected.txt
trunk/LayoutTests/storage/indexeddb/cursor-primary-key-order.html
Diff
Modified: trunk/LayoutTests/ChangeLog (101141 => 101142)
--- trunk/LayoutTests/ChangeLog 2011-11-24 16:51:13 UTC (rev 101141)
+++ trunk/LayoutTests/ChangeLog 2011-11-24 18:10:01 UTC (rev 101142)
@@ -1,3 +1,13 @@
+2011-11-24 Joshua Bell jsb...@chromium.org
+
+IndexedDB: Indexes should be secondarily sorted on primary key
+https://bugs.webkit.org/show_bug.cgi?id=72567
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/cursor-primary-key-order-expected.txt: Added.
+* storage/indexeddb/cursor-primary-key-order.html: Added.
+
2011-11-23 Pavel Podivilov podivi...@chromium.org
Web Inspector: add integration test for compiler source maps.
Added: trunk/LayoutTests/storage/indexeddb/cursor-primary-key-order-expected.txt (0 => 101142)
--- trunk/LayoutTests/storage/indexeddb/cursor-primary-key-order-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/cursor-primary-key-order-expected.txt 2011-11-24 18:10:01 UTC (rev 101142)
@@ -0,0 +1,97 @@
+Test IndexedDB primary key ordering and readback from cursors.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+IDBCursor = window.IDBCursor || window.webkitIDBCursor;
+PASS IDBCursor == null is false
+IDBTransaction = window.IDBTransaction || window.webkitIDBTransaction
+PASS IDBTransaction == null is false
+
+openRequest = indexedDB.open('cursor-primary-key-order')
+db = openRequest.result
+versionChangeRequest = db.setVersion('1')
+store = db.createObjectStore('store')
+index = store.createIndex('index', 'indexKey')
+
+populating store...
+trans = db.transaction('store', IDBTransaction.READ_WRITE)
+store = trans.objectStore('store');
+store.put({indexKey:0,count:0}, 'c')
+store.put({indexKey:0,count:1}, 'b')
+store.put({indexKey:0,count:2}, 'a')
+store.put({indexKey:0,count:3}, 'C')
+store.put({indexKey:0,count:4}, 'B')
+store.put({indexKey:0,count:5}, 'A')
+store.put({indexKey:0,count:6}, '2')
+store.put({indexKey:0,count:7}, '1')
+store.put({indexKey:0,count:8}, '0')
+store.put({indexKey:0,count:9}, Infinity)
+store.put({indexKey:0,count:10}, 2)
+store.put({indexKey:0,count:11}, 1)
+store.put({indexKey:0,count:12}, 0)
+store.put({indexKey:0,count:13}, -1)
+store.put({indexKey:0,count:14}, -2)
+store.put({indexKey:0,count:15}, -Infinity)
+
+iterating cursor...
+trans = db.transaction('store', IDBTransaction.READ_ONLY)
+store = trans.objectStore('store');
+index = store.index('index');
+cursorRequest = index.openCursor()
+count = 0
+cursor = cursorRequest.result
+PASS cursor.key is 0
+PASS cursor.primaryKey is -Infinity
+cursor = cursorRequest.result
+PASS cursor.key is 0
+PASS cursor.primaryKey is -2
+cursor = cursorRequest.result
+PASS cursor.key is 0
+PASS
[webkit-changes] [101143] trunk/Source/WebKit/chromium
Title: [101143] trunk/Source/WebKit/chromium
Revision 101143
Author fsam...@chromium.org
Date 2011-11-24 10:25:10 -0800 (Thu, 24 Nov 2011)
Log Message
[Chromium] Removed obsolete touchui flag
https://bugs.webkit.org/show_bug.cgi?id=73067
Reviewed by Tony Chang.
* features.gypi:
Modified Paths
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (101142 => 101143)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-11-24 18:10:01 UTC (rev 101142)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-11-24 18:25:10 UTC (rev 101143)
@@ -1,3 +1,12 @@
+2011-11-24 Fady Samuel fsam...@chromium.org
+
+[Chromium] Removed obsolete touchui flag
+https://bugs.webkit.org/show_bug.cgi?id=73067
+
+Reviewed by Tony Chang.
+
+* features.gypi:
+
2011-11-24 Joshua Bell jsb...@chromium.org
IndexedDB: Indexes should be secondarily sorted on primary key
Modified: trunk/Source/WebKit/chromium/features.gypi (101142 => 101143)
--- trunk/Source/WebKit/chromium/features.gypi 2011-11-24 18:10:01 UTC (rev 101142)
+++ trunk/Source/WebKit/chromium/features.gypi 2011-11-24 18:25:10 UTC (rev 101143)
@@ -142,9 +142,6 @@
'ENABLE_ACCELERATED_2D_CANVAS=1',
],
}],
- ['touchui==1', {
-'enable_touch_icon_loading': 1,
- }],
# Mac OS X uses Accelerate.framework FFT by default instead of FFmpeg.
['OS!=mac', {
'feature_defines': [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101145] trunk/Source/WebCore
Title: [101145] trunk/Source/WebCore
Revision 101145
Author par...@webkit.org
Date 2011-11-24 15:16:40 -0800 (Thu, 24 Nov 2011)
Log Message
Build fix for C++ bindings.
* bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (101144 => 101145)
--- trunk/Source/WebCore/ChangeLog 2011-11-24 20:03:01 UTC (rev 101144)
+++ trunk/Source/WebCore/ChangeLog 2011-11-24 23:16:40 UTC (rev 101145)
@@ -1,3 +1,9 @@
+2011-11-24 Patrick Gansterer par...@webkit.org
+
+Build fix for C++ bindings.
+
+* bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards.
+
2011-11-24 Arko Saha a...@motorola.com
Microdata: Support for properties attribute.
Modified: trunk/Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp (101144 => 101145)
--- trunk/Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp 2011-11-24 20:03:01 UTC (rev 101144)
+++ trunk/Source/WebCore/bindings/cpp/WebDOMEventTarget.cpp 2011-11-24 23:16:40 UTC (rev 101145)
@@ -33,15 +33,9 @@
#include ThreadCheck.h
#include WebDOMDOMApplicationCache.h
#include WebDOMDOMWindow.h
-#include WebDOMDedicatedWorkerContext.h
#include WebDOMEventSource.h
#include WebDOMMessagePort.h
#include WebDOMNode.h
-#include WebDOMNotification.h
-#include WebDOMSharedWorker.h
-#include WebDOMSharedWorkerContext.h
-#include WebDOMWebSocket.h
-#include WebDOMWorker.h
#include WebDOMXMLHttpRequest.h
#include WebDOMXMLHttpRequestUpload.h
#include WebExceptionHandler.h
@@ -52,6 +46,24 @@
#include wtf/RefPtr.h
+#if ENABLE(WORKERS)
+#include WebDOMDedicatedWorkerContext.h
+#include WebDOMWorker.h
+#endif
+
+#if ENABLE(SHARED_WORKERS)
+#include WebDOMSharedWorker.h
+#include WebDOMSharedWorkerContext.h
+#endif
+
+#if ENABLE(NOTIFICATIONS)
+#include WebDOMNotification.h
+#endif
+
+#if ENABLE(WEB_SOCKETS)
+#include WebDOMWebSocket.h
+#endif
+
struct WebDOMEventTarget::WebDOMEventTargetPrivate {
WebDOMEventTargetPrivate(WebCore::EventTarget* object = 0)
: impl(object)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101146] trunk/Source/WebCore
Title: [101146] trunk/Source/WebCore Revision 101146 Author par...@webkit.org Date 2011-11-24 15:23:20 -0800 (Thu, 24 Nov 2011) Log Message [CMake] Build fix for NOT ENABLE_WEB_SOCKETS. * CMakeLists.txt: Move CloseEvent.idl to the unconditional files. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/CMakeLists.txt (101145 => 101146) --- trunk/Source/WebCore/CMakeLists.txt 2011-11-24 23:16:40 UTC (rev 101145) +++ trunk/Source/WebCore/CMakeLists.txt 2011-11-24 23:23:20 UTC (rev 101146) @@ -374,6 +374,8 @@ webaudio/LowPass2FilterNode.idl webaudio/RealtimeAnalyserNode.idl +websockets/CloseEvent.idl + xml/DOMParser.idl xml/XMLHttpRequest.idl xml/XMLHttpRequestException.idl @@ -2013,7 +2015,6 @@ ) LIST(APPEND WebCore_IDL_FILES -websockets/CloseEvent.idl websockets/WebSocket.idl ) ENDIF () Modified: trunk/Source/WebCore/ChangeLog (101145 => 101146) --- trunk/Source/WebCore/ChangeLog 2011-11-24 23:16:40 UTC (rev 101145) +++ trunk/Source/WebCore/ChangeLog 2011-11-24 23:23:20 UTC (rev 101146) @@ -1,5 +1,11 @@ 2011-11-24 Patrick Gansterer par...@webkit.org +[CMake] Build fix for NOT ENABLE_WEB_SOCKETS. + +* CMakeLists.txt: Move CloseEvent.idl to the unconditional files. + +2011-11-24 Patrick Gansterer par...@webkit.org + Build fix for C++ bindings. * bindings/cpp/WebDOMEventTarget.cpp: Added #if ENABLE() guards. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101147] trunk/Source/JavaScriptCore
Title: [101147] trunk/Source/_javascript_Core
Revision 101147
Author msab...@apple.com
Date 2011-11-24 22:23:00 -0800 (Thu, 24 Nov 2011)
Log Message
Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683
Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
and building continues with a 16 bit buffer.
Reviewed by Filip Pizlo.
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::upConvert):
(JSC::JSStringBuilder::build):
* runtime/UString.h:
(JSC::UString::adopt):
* wtf/text/StringImpl.h:
(WTF::StringImpl::adopt):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSStringBuilder.h
trunk/Source/_javascript_Core/runtime/UString.h
trunk/Source/_javascript_Core/wtf/text/StringImpl.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101146 => 101147)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-24 23:23:20 UTC (rev 101146)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:23:00 UTC (rev 101147)
@@ -1,3 +1,24 @@
+2011-11-24 Michael Saboff msab...@apple.com
+
+Tune JSStringBuilder for 8 bit Strings
+https://bugs.webkit.org/show_bug.cgi?id=72683
+
+Changed JSStringBuilder to use 8 bit buffers until 16 bit data is added.
+When 16 bit data is to be added, the 8 bit buffer is converted to 16 bit
+and building continues with a 16 bit buffer.
+
+Reviewed by Filip Pizlo.
+
+* runtime/JSStringBuilder.h:
+(JSC::JSStringBuilder::JSStringBuilder):
+(JSC::JSStringBuilder::append):
+(JSC::JSStringBuilder::upConvert):
+(JSC::JSStringBuilder::build):
+* runtime/UString.h:
+(JSC::UString::adopt):
+* wtf/text/StringImpl.h:
+(WTF::StringImpl::adopt):
+
2011-11-24 Zeno Albisser z...@webkit.org
[Qt]WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets
Modified: trunk/Source/_javascript_Core/runtime/JSStringBuilder.h (101146 => 101147)
--- trunk/Source/_javascript_Core/runtime/JSStringBuilder.h 2011-11-24 23:23:20 UTC (rev 101146)
+++ trunk/Source/_javascript_Core/runtime/JSStringBuilder.h 2011-11-25 06:23:00 UTC (rev 101147)
@@ -37,12 +37,21 @@
public:
JSStringBuilder()
: m_okay(true)
+, m_is8Bit(true)
{
}
void append(const UChar u)
{
-m_okay = buffer.tryAppend(u, 1);
+if (m_is8Bit) {
+if (u 0xff) {
+LChar c = u;
+m_okay = buffer8.tryAppend(c, 1);
+return;
+}
+upConvert();
+}
+m_okay = buffer16.tryAppend(u, 1);
}
void append(const char* str)
@@ -52,36 +61,74 @@
void append(const char* str, size_t len)
{
-m_okay = buffer.tryReserveCapacity(buffer.size() + len);
+if (m_is8Bit) {
+m_okay = buffer8.tryAppend(reinterpret_castconst LChar*(str), len);
+return;
+}
+m_okay = buffer8.tryReserveCapacity(buffer16.size() + len);
for (size_t i = 0; i len; i++) {
UChar u = static_castunsigned char(str[i]);
-m_okay = buffer.tryAppend(u, 1);
+m_okay = buffer16.tryAppend(u, 1);
}
}
void append(const UChar* str, size_t len)
{
-m_okay = buffer.tryAppend(str, len);
+if (m_is8Bit)
+upConvert(); // FIXME: We could check character by character its size.
+m_okay = buffer16.tryAppend(str, len);
}
void append(const UString str)
{
-m_okay = buffer.tryAppend(str.characters(), str.length());
+unsigned length = str.length();
+
+if (!length)
+return;
+
+if (m_is8Bit) {
+if (str.is8Bit()) {
+m_okay = buffer8.tryAppend(str.characters8(), length);
+return;
+}
+upConvert();
+}
+m_okay = buffer16.tryAppend(str.characters(), length);
}
+void upConvert()
+{
+ASSERT(m_is8Bit);
+size_t len = buffer8.size();
+
+for (size_t i = 0; i len; i++)
+buffer16.append(buffer8[i]);
+
+buffer8.clear();
+m_is8Bit = false;
+}
+
JSValue build(ExecState* exec)
{
if (!m_okay)
return throwOutOfMemoryError(exec);
-buffer.shrinkToFit();
-if (!buffer.data())
+if (m_is8Bit) {
+buffer8.shrinkToFit();
+if (!buffer8.data())
+return throwOutOfMemoryError(exec);
+return jsString(exec, UString::adopt(buffer8));
+}
+buffer16.shrinkToFit();
+if (!buffer16.data())
return throwOutOfMemoryError(exec);
-return jsString(exec, UString::adopt(buffer));
+return
[webkit-changes] [101148] trunk/Source/JavaScriptCore
Title: [101148] trunk/Source/_javascript_Core
Revision 101148
Author msab...@apple.com
Date 2011-11-24 22:35:52 -0800 (Thu, 24 Nov 2011)
Log Message
Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968
Clear m_is8Bit flag for empty strings.
Reviewed by Filip Pizlo.
* runtime/JSString.h:
(JSC::RopeBuilder::finishCreation):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSString.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101147 => 101148)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:23:00 UTC (rev 101147)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:35:52 UTC (rev 101148)
@@ -1,5 +1,17 @@
2011-11-24 Michael Saboff msab...@apple.com
+Empty JSStrings are created as 16 bit
+https://bugs.webkit.org/show_bug.cgi?id=72968
+
+Clear m_is8Bit flag for empty strings.
+
+Reviewed by Filip Pizlo.
+
+* runtime/JSString.h:
+(JSC::RopeBuilder::finishCreation):
+
+2011-11-24 Michael Saboff msab...@apple.com
+
Tune JSStringBuilder for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=72683
Modified: trunk/Source/_javascript_Core/runtime/JSString.h (101147 => 101148)
--- trunk/Source/_javascript_Core/runtime/JSString.h 2011-11-25 06:23:00 UTC (rev 101147)
+++ trunk/Source/_javascript_Core/runtime/JSString.h 2011-11-25 06:35:52 UTC (rev 101148)
@@ -120,6 +120,7 @@
{
Base::finishCreation(globalData);
m_length = 0;
+m_is8Bit = true;
}
void finishCreation(JSGlobalData globalData, size_t length)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101149] trunk/Tools
Title: [101149] trunk/Tools
Revision 101149
Author hara...@chromium.org
Date 2011-11-24 22:36:26 -0800 (Thu, 24 Nov 2011)
Log Message
Fix the current working directory of run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73106
Reviewed by Adam Barth.
Currently, run-bindings-tests outputs the following error
(although it outputs all tests passed! in the end):
Testing the ObjC generator on TestObj.idl
gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
gcc: warning: '-x objective-c' after last input file has no effect
gcc: no input files
This is because CodeGeneratorObjC.pm assumes that the current working directory
is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
Thus, this patch changes it to WebKit/Source/.
* Scripts/run-bindings-tests:
(generate_from_idl):
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-bindings-tests
Diff
Modified: trunk/Tools/ChangeLog (101148 => 101149)
--- trunk/Tools/ChangeLog 2011-11-25 06:35:52 UTC (rev 101148)
+++ trunk/Tools/ChangeLog 2011-11-25 06:36:26 UTC (rev 101149)
@@ -1,3 +1,26 @@
+2011-11-24 Kentaro Hara hara...@chromium.org
+
+Fix the current working directory of run-bindings-tests
+https://bugs.webkit.org/show_bug.cgi?id=73106
+
+Reviewed by Adam Barth.
+
+Currently, run-bindings-tests outputs the following error
+(although it outputs all tests passed! in the end):
+
+Testing the ObjC generator on TestObj.idl
+gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
+gcc: warning: '-x objective-c' after last input file has no effect
+gcc: no input files
+
+This is because CodeGeneratorObjC.pm assumes that the current working directory
+is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
+Thus, this patch changes it to WebKit/Source/.
+
+* Scripts/run-bindings-tests:
+(generate_from_idl):
+(main):
+
2011-11-24 Tor Arne Vestbø tor.arne.ves...@nokia.com
[Qt] Get rid of the buildDirForSource() function in the build system
Modified: trunk/Tools/Scripts/run-bindings-tests (101148 => 101149)
--- trunk/Tools/Scripts/run-bindings-tests 2011-11-25 06:35:52 UTC (rev 101148)
+++ trunk/Tools/Scripts/run-bindings-tests 2011-11-25 06:36:26 UTC (rev 101149)
@@ -40,8 +40,8 @@
def generate_from_idl(generator, idl_file, output_directory):
cmd = ['perl', '-w',
- '-ISource/WebCore/bindings/scripts',
- 'Source/WebCore/bindings/scripts/generate-bindings.pl',
+ '-IWebCore/bindings/scripts',
+ 'WebCore/bindings/scripts/generate-bindings.pl',
# idl include directories (path relative to generate-bindings.pl)
'--include', '.',
'--defines', 'TESTING_%s' % generator,
@@ -109,7 +109,7 @@
reset_results = --reset-results in argv
current_scm = detect_scm_system(os.curdir)
-os.chdir(current_scm.checkout_root)
+os.chdir(os.path.join(current_scm.checkout_root, 'Source'))
all_tests_passed = True
@@ -122,8 +122,8 @@
]
for generator in generators:
-input_directory = os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test')
-reference_directory = os.path.join('Source', 'WebCore', 'bindings', 'scripts', 'test', generator)
+input_directory = os.path.join('WebCore', 'bindings', 'scripts', 'test')
+reference_directory = os.path.join('WebCore', 'bindings', 'scripts', 'test', generator)
if not run_tests(generator, input_directory, reference_directory, reset_results):
all_tests_passed = False
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [101150] trunk/Tools
Title: [101150] trunk/Tools Revision 101150 Author hara...@chromium.org Date 2011-11-24 22:44:19 -0800 (Thu, 24 Nov 2011) Log Message Replace subprocess.call() with subprocess.Popen() https://bugs.webkit.org/show_bug.cgi?id=73105 Reviewed by Adam Barth. Currently, the stdout and stderr of the child processes of run-bindings-tests are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr between a parent process and a child process. This patch replaces subprocess.call() with subprocess.Popen() and synchronizes the stdout and stderr between them. This patch also makes output messages of run-bindings-tests more readable. With this patch, the output messages of run-bindings-tests look like as follows: PASS: (CPP) WebDOMTestObj.h PASS: (CPP) WebDOMTestObj.cpp FAIL: (CPP) WebDOMTestInterface.h --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900 +++ /tmp/tmpDAV87G/WebDOMTestInterface.h2011-11-25 13:44:42.712946812 +0900 @@ -23,7 +23,7 @@ #ifndef WebDOMTestInterface_h #define WebDOMTestInterface_h -#if ENABLE(Condition1) || ENABLE(Condition2) +#if ENABLE(Condition1) || ENABLE(Condition3) #include WebDOMObject.h #include WebDOMString.h @@ -53,5 +53,5 @@ WebDOMTestInterface toWebKit(WebCore::TestInterface*); #endif -#endif // ENABLE(Condition1) || ENABLE(Condition2) +#endif // ENABLE(Condition1) || ENABLE(Condition3) PASS: (CPP) WebDOMFloat64Array.cpp PASS: (CPP) WebDOMFloat64Array.h Some tests FAIL! (To update the reference files, execute run-bindings-tests --reset-results) * Scripts/run-bindings-tests: (generate_from_idl): (detect_changes): (run_tests): (main): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-bindings-tests Diff Modified: trunk/Tools/ChangeLog (101149 => 101150) --- trunk/Tools/ChangeLog 2011-11-25 06:36:26 UTC (rev 101149) +++ trunk/Tools/ChangeLog 2011-11-25 06:44:19 UTC (rev 101150) @@ -1,5 +1,52 @@ 2011-11-24 Kentaro Hara hara...@chromium.org +Replace subprocess.call() with subprocess.Popen() +https://bugs.webkit.org/show_bug.cgi?id=73105 + +Reviewed by Adam Barth. + +Currently, the stdout and stderr of the child processes of run-bindings-tests +are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself. +This is the problem of subprocess.call(), which does not synchronize the stdout and stderr +between a parent process and a child process. This patch replaces subprocess.call() with +subprocess.Popen() and synchronizes the stdout and stderr between them. +This patch also makes output messages of run-bindings-tests more readable. + +With this patch, the output messages of run-bindings-tests look like as follows: + +PASS: (CPP) WebDOMTestObj.h +PASS: (CPP) WebDOMTestObj.cpp +FAIL: (CPP) WebDOMTestInterface.h +--- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900 ++++ /tmp/tmpDAV87G/WebDOMTestInterface.h2011-11-25 13:44:42.712946812 +0900 +@@ -23,7 +23,7 @@ + #ifndef WebDOMTestInterface_h + #define WebDOMTestInterface_h + +-#if ENABLE(Condition1) || ENABLE(Condition2) ++#if ENABLE(Condition1) || ENABLE(Condition3) + + #include WebDOMObject.h + #include WebDOMString.h + @@ -53,5 +53,5 @@ + WebDOMTestInterface toWebKit(WebCore::TestInterface*); + + #endif +-#endif // ENABLE(Condition1) || ENABLE(Condition2) ++#endif // ENABLE(Condition1) || ENABLE(Condition3) +PASS: (CPP) WebDOMFloat64Array.cpp +PASS: (CPP) WebDOMFloat64Array.h + +Some tests FAIL! (To update the reference files, execute run-bindings-tests --reset-results) + +* Scripts/run-bindings-tests: +(generate_from_idl): +(detect_changes): +(run_tests): +(main): + +2011-11-24 Kentaro Hara hara...@chromium.org + Fix the current working directory of run-bindings-tests https://bugs.webkit.org/show_bug.cgi?id=73106 Modified: trunk/Tools/Scripts/run-bindings-tests (101149 => 101150) --- trunk/Tools/Scripts/run-bindings-tests 2011-11-25 06:36:26 UTC (rev 101149) +++ trunk/Tools/Scripts/run-bindings-tests 2011-11-25 06:44:19 UTC (rev 101150) @@ -48,22 +48,32 @@ '--generator', generator, '--outputDir', output_directory, idl_file] -return subprocess.call(cmd) == 0 +process = subprocess.Popen(cmd, stdout = subprocess.PIPE, stderr = subprocess.STDOUT) +exit_code = process.wait() +output = process.communicate()[0] +if
[webkit-changes] [101151] trunk/Source/JavaScriptCore
Title: [101151] trunk/Source/_javascript_Core
Revision 101151
Author msab...@apple.com
Date 2011-11-24 22:47:48 -0800 (Thu, 24 Nov 2011)
Log Message
_javascript_ string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974
Change the various JS to number routines to process strings
using characters8() or characters16() as appropriate.
Implemented using static template methods.
Reviewed by Filip Pizlo.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::isInfinity):
(JSC::jsHexIntegerLiteral):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101150 => 101151)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:44:19 UTC (rev 101150)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:47:48 UTC (rev 101151)
@@ -1,5 +1,23 @@
2011-11-24 Michael Saboff msab...@apple.com
+_javascript_ string to number conversion functions use characters()
+https://bugs.webkit.org/show_bug.cgi?id=72974
+
+Change the various JS to number routines to process strings
+using characters8() or characters16() as appropriate.
+Implemented using static template methods.
+
+Reviewed by Filip Pizlo.
+
+* runtime/JSGlobalObjectFunctions.cpp:
+(JSC::isInfinity):
+(JSC::jsHexIntegerLiteral):
+(JSC::jsStrDecimalLiteral):
+(JSC::toDouble):
+(JSC::jsToNumber):
+
+2011-11-24 Michael Saboff msab...@apple.com
+
Empty JSStrings are created as 16 bit
https://bugs.webkit.org/show_bug.cgi?id=72968
Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp (101150 => 101151)
--- trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp 2011-11-25 06:44:19 UTC (rev 101150)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp 2011-11-25 06:47:48 UTC (rev 101151)
@@ -277,7 +277,8 @@
static const int SizeOfInfinity = 8;
-static bool isInfinity(const UChar* data, const UChar* end)
+template typename CharType
+static bool isInfinity(const CharType* data, const CharType* end)
{
return (end - data) = SizeOfInfinity
data[0] == 'I'
@@ -291,11 +292,12 @@
}
// See ecma-262 9.3.1
-static double jsHexIntegerLiteral(const UChar* data, const UChar* end)
+template typename CharType
+static double jsHexIntegerLiteral(const CharType* data, const CharType* end)
{
// Hex number.
data += 2;
-const UChar* firstDigitPosition = data;
+const CharType* firstDigitPosition = data;
double number = 0;
while (true) {
number = number * 16 + toASCIIHexValue(*data);
@@ -312,15 +314,16 @@
}
// See ecma-262 9.3.1
-static double jsStrDecimalLiteral(const UChar* data, const UChar* end)
+template typename CharType
+static double jsStrDecimalLiteral(const CharType* data, const CharType* end)
{
ASSERT(data end);
// Copy the sting into a null-terminated byte buffer, and call strtod.
Vectorchar, 32 byteBuffer;
-for (const UChar* characters = data; characters end; ++characters) {
-UChar character = *characters;
-byteBuffer.append(isASCII(character) ? character : 0);
+for (const CharType* characters = data; characters end; ++characters) {
+CharType character = *characters;
+byteBuffer.append(isASCII(character) ? static_castchar(character) : 0);
}
byteBuffer.append(0);
char* endOfNumber;
@@ -361,50 +364,57 @@
return std::numeric_limitsdouble::quiet_NaN();
}
-// See ecma-262 9.3.1
-double jsToNumber(const UString s)
+template typename CharType
+static double toDouble(const CharType* characters, unsigned size)
{
-unsigned size = s.length();
+const CharType* endCharacters = characters + size;
-if (size == 1) {
-UChar c = s[0];
-if (isASCIIDigit(c))
-return c - '0';
-if (isStrWhiteSpace(c))
-return 0;
-return std::numeric_limitsdouble::quiet_NaN();
-}
-
-const UChar* data = ""
-const UChar* end = data + size;
-
// Skip leading white space.
-for (; data end; ++data) {
-if (!isStrWhiteSpace(*data))
+for (; characters endCharacters; ++characters) {
+if (!isStrWhiteSpace(*characters))
break;
}
-
+
// Empty string.
-if (data == end)
+if (characters == endCharacters)
return 0.0;
-
+
double number;
-if (data[0] == '0' data + 2 end (data[1] | 0x20) == 'x' isASCIIHexDigit(data[2]))
-number = jsHexIntegerLiteral(data, end);
+if (characters[0] == '0' characters + 2 endCharacters (characters[1] | 0x20) == 'x' isASCIIHexDigit(characters[2]))
+number = jsHexIntegerLiteral(characters, endCharacters);
else
-number = jsStrDecimalLiteral(data,
[webkit-changes] [101152] trunk/Source/JavaScriptCore
Title: [101152] trunk/Source/_javascript_Core
Revision 101152
Author msab...@apple.com
Date 2011-11-24 22:55:34 -0800 (Thu, 24 Nov 2011)
Log Message
UString methods are not character size aware
https://bugs.webkit.org/show_bug.cgi?id=72975
Changed the UString number constructors to build 8 bit strings.
Modified the other methods to check string bitness and process
with 8 bits wherre appropriate.
* runtime/UString.cpp:
(JSC::UString::number):
(JSC::operator==):
(JSC::operator):
(JSC::UString::ascii):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/UString.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (101151 => 101152)
--- trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:47:48 UTC (rev 101151)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-11-25 06:55:34 UTC (rev 101152)
@@ -1,5 +1,20 @@
2011-11-24 Michael Saboff msab...@apple.com
+UString methods are not character size aware
+https://bugs.webkit.org/show_bug.cgi?id=72975
+
+Changed the UString number constructors to build 8 bit strings.
+Modified the other methods to check string bitness and process
+with 8 bits wherre appropriate.
+
+* runtime/UString.cpp:
+(JSC::UString::number):
+(JSC::operator==):
+(JSC::operator):
+(JSC::UString::ascii):
+
+2011-11-24 Michael Saboff msab...@apple.com
+
_javascript_ string to number conversion functions use characters()
https://bugs.webkit.org/show_bug.cgi?id=72974
Modified: trunk/Source/_javascript_Core/runtime/UString.cpp (101151 => 101152)
--- trunk/Source/_javascript_Core/runtime/UString.cpp 2011-11-25 06:47:48 UTC (rev 101151)
+++ trunk/Source/_javascript_Core/runtime/UString.cpp 2011-11-25 06:55:34 UTC (rev 101152)
@@ -96,9 +96,9 @@
UString UString::number(int i)
{
-UChar buf[1 + sizeof(i) * 3];
-UChar* end = buf + WTF_ARRAY_LENGTH(buf);
-UChar* p = end;
+LChar buf[1 + sizeof(i) * 3];
+LChar* end = buf + WTF_ARRAY_LENGTH(buf);
+LChar* p = end;
if (i == 0)
*--p = '0';
@@ -125,9 +125,9 @@
UString UString::number(long long i)
{
-UChar buf[1 + sizeof(i) * 3];
-UChar* end = buf + WTF_ARRAY_LENGTH(buf);
-UChar* p = end;
+LChar buf[1 + sizeof(i) * 3];
+LChar* end = buf + WTF_ARRAY_LENGTH(buf);
+LChar* p = end;
if (i == 0)
*--p = '0';
@@ -158,9 +158,9 @@
UString UString::number(unsigned u)
{
-UChar buf[sizeof(u) * 3];
-UChar* end = buf + WTF_ARRAY_LENGTH(buf);
-UChar* p = end;
+LChar buf[sizeof(u) * 3];
+LChar* end = buf + WTF_ARRAY_LENGTH(buf);
+LChar* p = end;
if (u == 0)
*--p = '0';
@@ -176,9 +176,9 @@
UString UString::number(long l)
{
-UChar buf[1 + sizeof(l) * 3];
-UChar* end = buf + WTF_ARRAY_LENGTH(buf);
-UChar* p = end;
+LChar buf[1 + sizeof(l) * 3];
+LChar* end = buf + WTF_ARRAY_LENGTH(buf);
+LChar* p = end;
if (l == 0)
*--p = '0';
@@ -224,19 +224,10 @@
bool operator==(const UString s1, const char *s2)
{
-if (s2 == 0)
-return s1.isEmpty();
+if (s1.isEmpty())
+return !s2;
-const UChar* u = s1.characters();
-const UChar* uend = u + s1.length();
-while (u != uend *s2) {
-if (u[0] != (unsigned char)*s2)
-return false;
-s2++;
-u++;
-}
-
-return u == uend *s2 == 0;
+return equal(s1.impl(), s2);
}
// This method assumes that all simple checks have been performed by
@@ -315,15 +306,29 @@
const unsigned l1 = s1.length();
const unsigned l2 = s2.length();
const unsigned lmin = l1 l2 ? l1 : l2;
+if (s1.is8Bit() s2.is8Bit()) {
+const LChar* c1 = s1.characters8();
+const LChar* c2 = s2.characters8();
+unsigned length = 0;
+while (length lmin *c1 == *c2) {
+c1++;
+c2++;
+length++;
+}
+if (length lmin)
+return (c1[0] c2[0]);
+
+return (l1 l2);
+}
const UChar* c1 = s1.characters();
const UChar* c2 = s2.characters();
-unsigned l = 0;
-while (l lmin *c1 == *c2) {
+unsigned length = 0;
+while (length lmin *c1 == *c2) {
c1++;
c2++;
-l++;
+length++;
}
-if (l lmin)
+if (length lmin)
return (c1[0] c2[0]);
return (l1 l2);
@@ -354,8 +359,23 @@
// preserved, characters outside of this range are converted to '?'.
unsigned length = this-length();
-const UChar* characters = this-characters();
+if (this-is8Bit()) {
+const LChar* characters = this-characters8();
+
+char* characterBuffer;
+CString result = CString::newUninitialized(length, characterBuffer);
+
+for (unsigned i = 0; i length; ++i) {
+LChar ch = characters[i];
+characterBuffer[i] = ch (ch
[webkit-changes] [101153] trunk/Source/WebCore
Title: [101153] trunk/Source/WebCore
Revision 101153
Author hara...@chromium.org
Date 2011-11-24 23:10:38 -0800 (Thu, 24 Nov 2011)
Log Message
Initialize global variables during IDLParser object creation
https://bugs.webkit.org/show_bug.cgi?id=73108
Reviewed by Adam Barth.
Currently, IDLParser.pm initializes global variables in a global scope,
which means that the global variables are initialized just once at the beginning.
On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
on generate-bindings.pl that initializes the global variables whenever a new IDLParser
object is created. Thus, this patch initializes the global variables during
the IDLParser object creation.
No new tests. No change in behavior.
* bindings/scripts/IDLParser.pm:
(InitializeGlobalData):
(new):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
Diff
Modified: trunk/Source/WebCore/ChangeLog (101152 => 101153)
--- trunk/Source/WebCore/ChangeLog 2011-11-25 06:55:34 UTC (rev 101152)
+++ trunk/Source/WebCore/ChangeLog 2011-11-25 07:10:38 UTC (rev 101153)
@@ -1,3 +1,23 @@
+2011-11-24 Kentaro Hara hara...@chromium.org
+
+Initialize global variables during IDLParser object creation
+https://bugs.webkit.org/show_bug.cgi?id=73108
+
+Reviewed by Adam Barth.
+
+Currently, IDLParser.pm initializes global variables in a global scope,
+which means that the global variables are initialized just once at the beginning.
+On the other hand, implementing [Supplemental] IDL (bug 72138) requires a change
+on generate-bindings.pl that initializes the global variables whenever a new IDLParser
+object is created. Thus, this patch initializes the global variables during
+the IDLParser object creation.
+
+No new tests. No change in behavior.
+
+* bindings/scripts/IDLParser.pm:
+(InitializeGlobalData):
+(new):
+
2011-11-24 Patrick Gansterer par...@webkit.org
[CMake] Build fix for NOT ENABLE_WEB_SOCKETS.
Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (101152 => 101153)
--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-11-25 06:55:34 UTC (rev 101152)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-11-25 07:10:38 UTC (rev 101153)
@@ -34,22 +34,34 @@
use constant MODE_INTERFACE = 11; # 'interface' section
# Helper variables
-my @temporaryContent = ;
+my @temporaryContent;
-my $parseMode = MODE_UNDEF;
-my $preservedParseMode = MODE_UNDEF;
+my $parseMode;
+my $preservedParseMode;
my $beQuiet; # Should not display anything on STDOUT?
-my $document = 0; # Will hold the resulting 'idlDocument'
-my $parentsOnly = 0; # If 1, parse only enough to populate parents list
+my $document; # Will hold the resulting 'idlDocument'
+my $parentsOnly; # If 1, parse only enough to populate parents list
+sub InitializeGlobalData
+{
+@temporaryContent = ;
+
+$parseMode = MODE_UNDEF;
+$preservedParseMode = MODE_UNDEF;
+
+$document = 0;
+$parentsOnly = 0;
+}
+
# Default Constructor
sub new
{
my $object = shift;
my $reference = { };
-$document = 0;
+InitializeGlobalData();
+
$beQuiet = shift;
bless($reference, $object);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
