[webkit-changes] [101336] trunk/Source/WebCore

[commit-queue]

Title: [101336] trunk/Source/WebCore








Revision 101336
Author commit-qu...@webkit.org
Date 2011-11-29 00:10:30 -0800 (Tue, 29 Nov 2011)


Log Message
Upstream BlackBerry porting of platform/image-decoders
https://bugs.webkit.org/show_bug.cgi?id=73118

Patch by Sean Wang xuewen.w...@torchmobile.com.cn on 2011-11-29
Reviewed by Daniel Bates.

Initial upstream, can't be built yet, no test cases.

The initial author is David Tapuska dtapu...@rim.com.

* platform/image-decoders/blackberry/JPEGImageDecoder.cpp: Added.
(WebCore::libInit):
(WebCore::ImageReader::ImageReader):
(WebCore::imgDecodeSetup):
(WebCore::ImageReader::updateData):
(WebCore::ImageReader::setSize):
(WebCore::ImageReader::sizeExtract):
(WebCore::ImageReader::decode):
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
(WebCore::JPEGImageDecoder::setData):
(WebCore::JPEGImageDecoder::isSizeAvailable):
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
* platform/image-decoders/blackberry/JPEGImageDecoder.h: Added.
(WebCore::JPEGImageDecoder::filenameExtension):
(WebCore::JPEGImageDecoder::supportsAlpha):

Modified Paths

trunk/Source/WebCore/ChangeLog


Added Paths

trunk/Source/WebCore/platform/image-decoders/blackberry/
trunk/Source/WebCore/platform/image-decoders/blackberry/JPEGImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/blackberry/JPEGImageDecoder.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101335 => 101336)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 07:59:22 UTC (rev 101335)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 08:10:30 UTC (rev 101336)
@@ -1,3 +1,30 @@
+2011-11-29  Sean Wang  xuewen.w...@torchmobile.com.cn
+
+Upstream BlackBerry porting of platform/image-decoders
+https://bugs.webkit.org/show_bug.cgi?id=73118
+
+Reviewed by Daniel Bates.
+
+Initial upstream, can't be built yet, no test cases.
+
+The initial author is David Tapuska dtapu...@rim.com.
+
+* platform/image-decoders/blackberry/JPEGImageDecoder.cpp: Added.
+(WebCore::libInit):
+(WebCore::ImageReader::ImageReader):
+(WebCore::imgDecodeSetup):
+(WebCore::ImageReader::updateData):
+(WebCore::ImageReader::setSize):
+(WebCore::ImageReader::sizeExtract):
+(WebCore::ImageReader::decode):
+(WebCore::JPEGImageDecoder::JPEGImageDecoder):
+(WebCore::JPEGImageDecoder::setData):
+(WebCore::JPEGImageDecoder::isSizeAvailable):
+(WebCore::JPEGImageDecoder::frameBufferAtIndex):
+* platform/image-decoders/blackberry/JPEGImageDecoder.h: Added.
+(WebCore::JPEGImageDecoder::filenameExtension):
+(WebCore::JPEGImageDecoder::supportsAlpha):
+
 2011-11-28  David Grogan  dgro...@chromium.org
 
 WebWorkerRunLoop wrapper around WorkerRunLoop


Added: trunk/Source/WebCore/platform/image-decoders/blackberry/JPEGImageDecoder.cpp (0 => 101336)

--- trunk/Source/WebCore/platform/image-decoders/blackberry/JPEGImageDecoder.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/image-decoders/blackberry/JPEGImageDecoder.cpp	2011-11-29 08:10:30 UTC (rev 101336)
@@ -0,0 +1,240 @@
+/*
+ * Copyright (C) 2010, 2011 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+// Implementation notes:
+// Current implementation provides the source image size without doing a full
+// decode. It seems that libimg does not support partial decoding.
+
+#include config.h
+#include JPEGImageDecoder.h
+
+#include errno.h
+#include img/img.h
+#include string.h
+#include wtf/OwnArrayPtr.h
+#include wtf/PassOwnPtr.h
+
+namespace WebCore {
+
+static img_lib_t s_ilib;
+
+static inline int libInit()
+{
+static bool s_initialized;
+if (s_initialized)
+return 0;
+
+if (img_lib_attach(s_ilib) != IMG_ERR_OK) {
+LOG_ERROR(Unable to attach to libimg.);
+return -1;
+}
+s_initialized = true;
+return 0;
+}
+
+class ImageReader {
+public:
+ImageReader(const char* data, size_t dataSize)
+: m_data(data)
+, m_size(dataSize)
+, m_width(0)
+, m_height(0)
+{
+libInit();
+}
+
+void updateData(const char* data, size_t dataSize);
+int setSize(size_t width, size_t height);
+int 

[webkit-changes] [101337] trunk

[commit-queue]

Title: [101337] trunk








Revision 101337
Author commit-qu...@webkit.org
Date 2011-11-29 00:13:02 -0800 (Tue, 29 Nov 2011)


Log Message
Assertion fails when opening two popup menus
https://bugs.webkit.org/show_bug.cgi?id=73189

Patch by Jing Zhao jingz...@chromium.org on 2011-11-29
Reviewed by Kent Tamura.

By using element.dispatchEvent(), a user written script can open two
popup menus, which causes the assertion in WebViewImpl::popupOpened()
fail.

Check if there is an opened popup menu before opening a popup menu.

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::popupOpened):

LayoutTests:

* fast/forms/select-popup-crash-expected.txt: Added.
* fast/forms/select-popup-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp


Added Paths

trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt
trunk/LayoutTests/fast/forms/select-popup-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101336 => 101337)

--- trunk/LayoutTests/ChangeLog	2011-11-29 08:10:30 UTC (rev 101336)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 08:13:02 UTC (rev 101337)
@@ -1,3 +1,19 @@
+2011-11-29  Jing Zhao  jingz...@chromium.org
+
+Assertion fails when opening two popup menus
+https://bugs.webkit.org/show_bug.cgi?id=73189
+
+Reviewed by Kent Tamura.
+
+By using element.dispatchEvent(), a user written script can open two
+popup menus, which causes the assertion in WebViewImpl::popupOpened()
+fail.
+
+Check if there is an opened popup menu before opening a popup menu.
+
+* fast/forms/select-popup-crash-expected.txt: Added.
+* fast/forms/select-popup-crash.html: Added.
+
 2011-11-29  Alexandru Chiculita  ach...@adobe.com
 
 [CSS Filters] Filters do not render correctly when the layer has a transform


Added: trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt (0 => 101337)

--- trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt	2011-11-29 08:13:02 UTC (rev 101337)
@@ -0,0 +1,5 @@
+select test for opening two popup menus.
+
+PASS if the test didn't crash.
+
+


Added: trunk/LayoutTests/fast/forms/select-popup-crash.html (0 => 101337)

--- trunk/LayoutTests/fast/forms/select-popup-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/select-popup-crash.html	2011-11-29 08:13:02 UTC (rev 101337)
@@ -0,0 +1,53 @@
+!DOCTYPE HTML
+html
+head
+/head
+body
+p id=descriptionlt;select test for opening two popup menus./p
+div id=console/div
+p id=debugPASS if the test didn't crash./p
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var parent = document.createElement('div');
+parent.innerHTML = 'select id=sl1'
++ 'optionone/option'
++ 'optiontwo/option'
++ 'optionthree/option'
++ 'optionfour/option'
++ 'optionfive/option'
++ 'optionsix/option'
++ 'optionseven/option'
++ 'optioneight/option'
++ 'optionnine/option'
++ 'optionten/option'
++ 'optioneleven/option'
++ 'optiontwelve/option'
++ 'optionthirteen/option'
++ 'optionfourteen/option'
++ 'optionfifteen/option'
++ 'optionsixteen/option'
++ 'optionseventeen/option'
++ '/select'
++ 'select id=sl2'
++ 'optionone/option'
++ 'optiontwo/option'
++ 'optionthree/option'
++ '/select';
+document.body.appendChild(parent);
+
+function mouseDownOnSelect(selId)
+{
+var sl = document.getElementById(selId);
+var event = document.createEvent(MouseEvent);
+event.initMouseEvent(mousedown, true, true, document.defaultView, 1, sl.offsetLeft, sl.offsetTop, sl.offsetLeft, sl.offsetTop, false, false, false, false, 0, document);
+sl.dispatchEvent(event);
+}
+
+mouseDownOnSelect(sl1);
+mouseDownOnSelect(sl2);
+
+/script
+/body
+/html


Modified: trunk/Source/WebKit/chromium/ChangeLog (101336 => 101337)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 08:10:30 UTC (rev 101336)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 08:13:02 UTC (rev 101337)
@@ -1,3 +1,19 @@
+2011-11-29  Jing Zhao  jingz...@chromium.org
+
+Assertion fails when opening two popup menus
+https://bugs.webkit.org/show_bug.cgi?id=73189
+
+Reviewed by Kent Tamura.
+
+By using element.dispatchEvent(), a user written script can open two
+popup menus, which causes the assertion in WebViewImpl::popupOpened()
+fail.
+
+Check if there is an opened popup menu before opening a popup menu.
+
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::popupOpened):
+
 2011-11-28  David Grogan  dgro...@chromium.org
 
 WebWorkerRunLoop wrapper around 

[webkit-changes] [101338] trunk/LayoutTests

[philn]

Title: [101338] trunk/LayoutTests








Revision 101338
Author ph...@webkit.org
Date 2011-11-29 00:53:11 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, unskip fixed flaky test after r101326.

* platform/gtk/test_expectations.txt: Unskip http/tests/websocket/tests/hixie76/error-detect.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101337 => 101338)

--- trunk/LayoutTests/ChangeLog	2011-11-29 08:13:02 UTC (rev 101337)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 08:53:11 UTC (rev 101338)
@@ -1,3 +1,9 @@
+2011-11-29  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, unskip fixed flaky test after r101326.
+
+* platform/gtk/test_expectations.txt: Unskip http/tests/websocket/tests/hixie76/error-detect.html
+
 2011-11-29  Jing Zhao  jingz...@chromium.org
 
 Assertion fails when opening two popup menus


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (101337 => 101338)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-11-29 08:13:02 UTC (rev 101337)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2011-11-29 08:53:11 UTC (rev 101338)
@@ -26,8 +26,6 @@
 
 BUGWK68520 : svg/W3C-SVG-1.1-SE/filters-image-05-f.svg = PASS TEXT
 
-BUGWK68522 : http/tests/websocket/tests/hixie76/error-detect.html = PASS TEXT
-
 BUGWK68516 : fast/workers/shared-worker-lifecycle.html = PASS TEXT
 BUGWK68516 : fast/workers/shared-worker-frame-lifecycle.html = PASS TEXT
 BUGWK68516 : fast/workers/worker-close-more.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101339] trunk/Source/WebKit2

[kenneth]

Title: [101339] trunk/Source/WebKit2








Revision 101339
Author kenn...@webkit.org
Date 2011-11-29 01:15:49 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] QQuickWebView gets wrong position after reload https://bugs.webkit.org/show_bug.cgi?id=73292

Reviewed by Simon Hausmann.

The ensureContentWithinViewportBoundary, animates the current viewport
item into boundaries. That ofcourse breaks when we try to animate it,
given the initial-scale which hasn't been applied; so apply it.

Also put the QScroller settings code in the ctor as it never changes.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
* UIProcess/qt/QtViewportInteractionEngine.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (101338 => 101339)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 08:53:11 UTC (rev 101338)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 09:15:49 UTC (rev 101339)
@@ -1,3 +1,23 @@
+2011-11-29  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] QQuickWebView gets wrong position after reload
+https://bugs.webkit.org/show_bug.cgi?id=73292
+
+Reviewed by Simon Hausmann.
+
+The ensureContentWithinViewportBoundary animates the current viewport
+item into boundaries. That of course breaks when we try to animate it,
+given the initial-scale which hasn't been applied; so apply it.
+
+Also put the QScroller settings code in the ctor as it never changes.
+
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
+(WebKit::QtViewportInteractionEngine::reset):
+(WebKit::QtViewportInteractionEngine::applyConstraints):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+
 2011-11-29  Roland Steiner  rolandstei...@chromium.org
 
 style scoped: add ENABLE(STYLE_SCOPED) flag to WebKit


Modified: trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp (101338 => 101339)

--- trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2011-11-29 08:53:11 UTC (rev 101338)
+++ trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp	2011-11-29 09:15:49 UTC (rev 101339)
@@ -102,6 +102,22 @@
 {
 reset();
 
+QScrollerProperties properties = scroller()-scrollerProperties();
+
+// The QtPanGestureRecognizer is responsible for recognizing the gesture
+// thus we need to disable the drag start distance.
+properties.setScrollMetric(QScrollerProperties::DragStartDistance, 0.0);
+
+// Set some default QScroller constrains to mimic the physics engine of the N9 browser.
+properties.setScrollMetric(QScrollerProperties::AxisLockThreshold, 0.66);
+properties.setScrollMetric(QScrollerProperties::ScrollingCurve, QEasingCurve(QEasingCurve::OutExpo));
+properties.setScrollMetric(QScrollerProperties::DecelerationFactor, 0.05);
+properties.setScrollMetric(QScrollerProperties::MaximumVelocity, 0.635);
+properties.setScrollMetric(QScrollerProperties::OvershootDragResistanceFactor, 0.33);
+properties.setScrollMetric(QScrollerProperties::OvershootScrollDistanceFactor, 0.33);
+
+scroller()-setScrollerProperties(properties);
+
 connect(m_content, SIGNAL(widthChanged()), this, SLOT(itemSizeChanged()), Qt::DirectConnection);
 connect(m_content, SIGNAL(heightChanged()), this, SLOT(itemSizeChanged()), Qt::DirectConnection);
 
@@ -308,21 +324,17 @@
 animateItemRectVisible(endVisibleContentRect);
 }
 
-void QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
+void QtViewportInteractionEngine::ensureContentWithinViewportBoundary(bool immediate)
 {
 if (scrollAnimationActive() || scaleAnimationActive())
 return;
 
 qreal currentCSSScale = cssScaleFromItem(m_content-scale());
-bool userHasScaledContent = m_userInteractionFlags  UserHasScaledContent;
 
-if (!userHasScaledContent)
-currentCSSScale = m_constraints.initialScale;
-
 qreal endItemScale = itemScaleFromCSS(innerBoundedCSSScale(currentCSSScale));
 
 const QRectF viewportRect = m_viewport-boundingRect();
-const QPointF viewportHotspot = viewportRect.center();
+QPointF viewportHotspot = viewportRect.center();
 
 QPointF endPosition = m_content-mapFromItem(m_viewport, viewportHotspot) * endItemScale - viewportHotspot;
 
@@ -331,7 +343,7 @@
 
 QRectF endVisibleContentRect(endPosition / endItemScale, viewportRect.size() / endItemScale);
 
-if (!userHasScaledContent)
+if (immediate)
 

[webkit-changes] [101341] trunk/Source/WebCore

[caseq]

Title: [101341] trunk/Source/WebCore








Revision 101341
Author ca...@chromium.org
Date 2011-11-29 01:27:27 -0800 (Tue, 29 Nov 2011)


Log Message
Web Inspector: remove WebInspector.linkifyURL and TreeElement.titleHTML
https://bugs.webkit.org/show_bug.cgi?id=73217

Reviewed by Pavel Feldman.

* inspector/front-end/AuditFormatters.js:
(WebInspector.applyFormatters):
* inspector/front-end/AuditResultView.js:
(WebInspector.AuditCategoryResultPane.prototype._appendResult):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditRuleResult):
(WebInspector.AuditRuleResult.linkifyDisplayName):
(WebInspector.AuditRuleResult.prototype.addSnippet):
(WebInspector.AuditRuleResult.prototype.addFormatted):
(WebInspector.AuditRuleResult.prototype._append):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._formatHeader):
(WebInspector.ResourceHeadersView.prototype._formatParameter):
(WebInspector.ResourceHeadersView.prototype._refreshURL):
(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
(WebInspector.ResourceHeadersView.prototype._refreshRequestPayload):
(WebInspector.ResourceHeadersView.prototype._refreshParms):
(WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):
(WebInspector.ResourceHeadersView.prototype._refreshHeaders):
* inspector/front-end/ResourceUtils.js:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype.addWorker):
* inspector/front-end/treeoutline.js:
(TreeElement.prototype._setListItemNodeContent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/AuditFormatters.js
trunk/Source/WebCore/inspector/front-end/AuditResultView.js
trunk/Source/WebCore/inspector/front-end/AuditRules.js
trunk/Source/WebCore/inspector/front-end/AuditsPanel.js
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
trunk/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js
trunk/Source/WebCore/inspector/front-end/ResourceHeadersView.js
trunk/Source/WebCore/inspector/front-end/ResourceUtils.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/WorkersSidebarPane.js
trunk/Source/WebCore/inspector/front-end/treeoutline.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (101340 => 101341)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 09:23:28 UTC (rev 101340)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 09:27:27 UTC (rev 101341)
@@ -1,3 +1,46 @@
+2011-11-28  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: remove WebInspector.linkifyURL and TreeElement.titleHTML
+https://bugs.webkit.org/show_bug.cgi?id=73217
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/AuditFormatters.js:
+(WebInspector.applyFormatters):
+* inspector/front-end/AuditResultView.js:
+(WebInspector.AuditCategoryResultPane.prototype._appendResult):
+* inspector/front-end/AuditRules.js:
+(WebInspector.AuditRules.GzipRule.prototype.doRun):
+(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
+(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
+(WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
+* inspector/front-end/AuditsPanel.js:
+(WebInspector.AuditRuleResult):
+(WebInspector.AuditRuleResult.linkifyDisplayName):
+(WebInspector.AuditRuleResult.prototype.addSnippet):
+(WebInspector.AuditRuleResult.prototype.addFormatted):
+(WebInspector.AuditRuleResult.prototype._append):
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeElement.prototype.adjustCollapsedRange):
+* inspector/front-end/ObjectPropertiesSection.js:
+(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
+* inspector/front-end/ResourceHeadersView.js:
+(WebInspector.ResourceHeadersView.prototype._formatHeader):
+(WebInspector.ResourceHeadersView.prototype._formatParameter):
+(WebInspector.ResourceHeadersView.prototype._refreshURL):
+(WebInspector.ResourceHeadersView.prototype._refreshUrlFragment):
+(WebInspector.ResourceHeadersView.prototype._refreshRequestPayload):
+

[webkit-changes] [101343] trunk/Source/WebCore

[philn]

Title: [101343] trunk/Source/WebCore








Revision 101343
Author ph...@webkit.org
Date 2011-11-29 01:42:34 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] Improve FontMetrics accuracy
https://bugs.webkit.org/show_bug.cgi?id=72614

Reviewed by Martin Robinson.
Patch by Nikolas Zimmermann.

* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::setCairoFontOptionsFromFontConfigPattern):
* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp
trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101342 => 101343)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 09:40:51 UTC (rev 101342)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 09:42:34 UTC (rev 101343)
@@ -1,3 +1,16 @@
+2011-11-25  Philippe Normand  pnorm...@igalia.com
+
+[GTK] Improve FontMetrics accuracy
+https://bugs.webkit.org/show_bug.cgi?id=72614
+
+Reviewed by Martin Robinson.
+Patch by Nikolas Zimmermann.
+
+* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
+(WebCore::setCairoFontOptionsFromFontConfigPattern):
+* platform/graphics/freetype/SimpleFontDataFreeType.cpp:
+(WebCore::SimpleFontData::platformInit):
+
 2011-11-29  Nikolas Zimmermann  nzimmerm...@rim.com
 
 SVG path DRT dumps have rounding problems across platforms


Modified: trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp (101342 => 101343)

--- trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp	2011-11-29 09:40:51 UTC (rev 101342)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp	2011-11-29 09:42:34 UTC (rev 101343)
@@ -98,6 +98,9 @@
 cairo_font_options_set_hint_style(options, convertFontConfigHintStyle(integerResult));
 if (FcPatternGetBool(pattern, FC_HINTING, 0, booleanResult) == FcResultMatch  !booleanResult)
 cairo_font_options_set_hint_style(options, CAIRO_HINT_STYLE_NONE);
+
+// Turn off text metrics hinting, which quantizes metrics to pixels in device space.
+cairo_font_options_set_hint_metrics(options, CAIRO_HINT_METRICS_OFF);
 }
 
 static cairo_font_options_t* getDefaultFontOptions()


Modified: trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp (101342 => 101343)

--- trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp	2011-11-29 09:40:51 UTC (rev 101342)
+++ trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp	2011-11-29 09:42:34 UTC (rev 101343)
@@ -33,6 +33,7 @@
 #include config.h
 #include SimpleFontData.h
 
+#include FloatConversion.h
 #include FloatRect.h
 #include Font.h
 #include FontCache.h
@@ -55,26 +56,22 @@
 cairo_text_extents_t text_extents;
 cairo_scaled_font_extents(m_platformData.scaledFont(), font_extents);
 
-m_fontMetrics.setAscent(font_extents.ascent);
-m_fontMetrics.setDescent(font_extents.descent);
+float ascent = narrowPrecisionToFloat(font_extents.ascent);
+float descent = narrowPrecisionToFloat(font_extents.descent);
+float lineGap = narrowPrecisionToFloat(font_extents.height - font_extents.ascent - font_extents.descent);
 
-// There seems to be some rounding error in cairo (or in how we
-// use cairo) with some fonts, like DejaVu Sans Mono, which makes
-// cairo report a height smaller than ascent + descent, which is
-// wrong and confuses WebCore's layout system. Workaround this
-// while we figure out what's going on.
-float lineSpacing = font_extents.height;
-if (lineSpacing  font_extents.ascent + font_extents.descent)
-lineSpacing = font_extents.ascent + font_extents.descent;
+m_fontMetrics.setAscent(ascent);
+m_fontMetrics.setDescent(descent);
 
-m_fontMetrics.setLineSpacing(lroundf(lineSpacing));
-m_fontMetrics.setLineGap(lineSpacing - font_extents.ascent - font_extents.descent);
+// Match CoreGraphics metrics.
+m_fontMetrics.setLineSpacing(lroundf(ascent) + lroundf(descent) + lroundf(lineGap));
+m_fontMetrics.setLineGap(lineGap);
 
 cairo_scaled_font_text_extents(m_platformData.scaledFont(), x, text_extents);
-m_fontMetrics.setXHeight(text_extents.height);
+m_fontMetrics.setXHeight(narrowPrecisionToFloat(text_extents.height));
 
 cairo_scaled_font_text_extents(m_platformData.scaledFont(),  , text_extents);
-m_spaceWidth = static_castfloat(text_extents.x_advance);
+m_spaceWidth = narrowPrecisionToFloat(text_extents.x_advance);
 
 m_syntheticBoldOffset = m_platformData.syntheticBold() ? 1.0f : 0.f;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101347] trunk

[commit-queue]

Title: [101347] trunk








Revision 101347
Author commit-qu...@webkit.org
Date 2011-11-29 02:47:32 -0800 (Tue, 29 Nov 2011)


Log Message
[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
https://bugs.webkit.org/show_bug.cgi?id=73111

.:

Add feature define for TextureMapper and OpenGL package.

Patch by Hyowon Kim hw1008@samsung.com on 2011-11-29
Reviewed by Noam Rosenthal.

* Source/cmake/OptionsEfl.cmake:

Source/WebCore:

This patch adds Texture Mapper related files to PlatformEfl.cmake
and removes Qt-specific types in TextureMapperNode.cpp.

Patch by Hyowon Kim hw1008@samsung.com on 2011-11-29
Reviewed by Noam Rosenthal.

* PlatformEfl.cmake:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/efl/GraphicsLayerEfl.cpp: Removed.
* platform/graphics/efl/GraphicsLayerEfl.h: Removed.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp
trunk/Source/cmake/OptionsEfl.cmake


Removed Paths

trunk/Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.cpp
trunk/Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.h




Diff

Modified: trunk/ChangeLog (101346 => 101347)

--- trunk/ChangeLog	2011-11-29 10:30:41 UTC (rev 101346)
+++ trunk/ChangeLog	2011-11-29 10:47:32 UTC (rev 101347)
@@ -1,3 +1,14 @@
+2011-11-29  Hyowon Kim  hw1008@samsung.com
+
+[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
+https://bugs.webkit.org/show_bug.cgi?id=73111
+
+Add feature define for TextureMapper and OpenGL package.
+
+Reviewed by Noam Rosenthal.
+
+* Source/cmake/OptionsEfl.cmake:
+
 2011-11-29  Roland Steiner  rolandstei...@chromium.org
 
 style scoped: add ENABLE(STYLE_SCOPED) flag to WebKit


Modified: trunk/Source/WebCore/ChangeLog (101346 => 101347)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 10:30:41 UTC (rev 101346)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 10:47:32 UTC (rev 101347)
@@ -1,3 +1,22 @@
+2011-11-29  Hyowon Kim  hw1008@samsung.com
+
+[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
+https://bugs.webkit.org/show_bug.cgi?id=73111
+
+This patch adds Texture Mapper related files to PlatformEfl.cmake
+and removes Qt-specific types in TextureMapperNode.cpp.
+
+Reviewed by Noam Rosenthal.
+
+* PlatformEfl.cmake:
+* platform/graphics/GraphicsLayer.cpp:
+* platform/graphics/GraphicsLayer.h:
+* platform/graphics/efl/GraphicsLayerEfl.cpp: Removed.
+* platform/graphics/efl/GraphicsLayerEfl.h: Removed.
+* platform/graphics/texmap/TextureMapperNode.cpp:
+(WebCore::solveCubicBezierFunction):
+(WebCore::solveStepsFunction):
+
 2011-11-28  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: put inspector agents into a vector in the InspectorController.


Modified: trunk/Source/WebCore/PlatformEfl.cmake (101346 => 101347)

--- trunk/Source/WebCore/PlatformEfl.cmake	2011-11-29 10:30:41 UTC (rev 101346)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2011-11-29 10:47:32 UTC (rev 101347)
@@ -55,7 +55,6 @@
   platform/efl/TemporaryLinkStubs.cpp
   platform/efl/WidgetEfl.cpp
   platform/graphics/ImageSource.cpp
-  platform/graphics/efl/GraphicsLayerEfl.cpp
   platform/graphics/efl/IconEfl.cpp
   platform/graphics/efl/ImageEfl.cpp
   platform/graphics/efl/IntPointEfl.cpp
@@ -208,6 +207,21 @@
   )
 ENDIF ()
 
+IF (WTF_USE_TEXTURE_MAPPER)
+  LIST(APPEND WebCore_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIR}
+${WEBCORE_DIR}/platform/graphics/texmap
+  )
+  LIST(APPEND WebCore_SOURCES
+platform/graphics/opengl/TextureMapperGL.cpp
+platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
+platform/graphics/texmap/TextureMapperNode.cpp
+  )
+   LIST(APPEND WebCore_LIBRARIES
+${OPENGL_gl_LIBRARY}
+  )
+ENDIF ()
+
 LIST(APPEND WebCore_LIBRARIES
   ${Cairo_LIBRARIES}
   ${ECORE_X_LIBRARIES}


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (101346 => 101347)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2011-11-29 10:30:41 UTC (rev 101346)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp	2011-11-29 10:47:32 UTC (rev 101347)
@@ -347,7 +347,7 @@
 }
 }
 
-#if PLATFORM(QT)
+#if PLATFORM(QT) || PLATFORM(EFL)
 GraphicsLayer::GraphicsLayerFactory* GraphicsLayer::s_graphicsLayerFactory = 0;
 
 void GraphicsLayer::setGraphicsLayerFactory(GraphicsLayer::GraphicsLayerFactory factory)


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (101346 => 101347)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h	

[webkit-changes] [101348] trunk

[mario]

Title: [101348] trunk








Revision 101348
Author ma...@webkit.org
Date 2011-11-29 03:00:58 -0800 (Tue, 29 Nov 2011)


Log Message
[Gtk] Regression: Push buttons no longer expose their displayed text/name
https://bugs.webkit.org/show_bug.cgi?id=72804

Reviewed by Chris Fleizach.

Source/WebCore:

Use AccessibilityObject::title() as the last fallback in
webkit_accessible_get_name() right before relying on the
stringValue() method, if no better alternative was found.

Test: platform/gtk/accessibility/button-accessible-name.html

* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name): Use title() as the last fallback
method before using stringValue().

LayoutTests:

Add new GTK-specific layout test and expections.

* platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
* platform/gtk/accessibility/button-accessible-name.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp


Added Paths

trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt
trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101347 => 101348)

--- trunk/LayoutTests/ChangeLog	2011-11-29 10:47:32 UTC (rev 101347)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 11:00:58 UTC (rev 101348)
@@ -1,3 +1,15 @@
+2011-11-29  Mario Sanchez Prada  msanc...@igalia.com
+
+[Gtk] Regression: Push buttons no longer expose their displayed text/name
+https://bugs.webkit.org/show_bug.cgi?id=72804
+
+Reviewed by Chris Fleizach.
+
+Add new GTK-specific layout test and expections.
+
+* platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
+* platform/gtk/accessibility/button-accessible-name.html: Added.
+
 2011-11-29  Csaba Osztrogonác  o...@webkit.org
 
 SVG path DRT dumps have rounding problems across platforms


Added: trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt (0 => 101348)

--- trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt	2011-11-29 11:00:58 UTC (rev 101348)
@@ -0,0 +1,12 @@
+
+This tests that the text of a button is exposed to Assistive Technologies.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS axButton.role is 'AXRole: push button'
+PASS axButton.title is 'AXTitle: The Button'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html (0 => 101348)

--- trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html	(rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html	2011-11-29 11:00:58 UTC (rev 101348)
@@ -0,0 +1,29 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+form
+input id=button type=submit value=The Button/
+/form
+p id=description/p
+div id=console/div
+script
+description(This tests that the text of a button is exposed to Assistive Technologies.);
+
+if (window.layoutTestController)
+  layoutTestController.dumpAsText();
+
+if (window.accessibilityController) {
+  button = document.getElementById(button);
+  button.focus();
+
+  axButton = accessibilityController.focusedElement;
+  shouldBe(axButton.role, 'AXRole: push button');
+  shouldBe(axButton.title, 'AXTitle: The Button');
+}
+/script
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (101347 => 101348)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 10:47:32 UTC (rev 101347)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 11:00:58 UTC (rev 101348)
@@ -1,3 +1,20 @@
+2011-11-29  Mario Sanchez Prada  msanc...@igalia.com
+
+[Gtk] Regression: Push buttons no longer expose their displayed text/name
+https://bugs.webkit.org/show_bug.cgi?id=72804
+
+Reviewed by Chris Fleizach.
+
+Use AccessibilityObject::title() as the last fallback in
+webkit_accessible_get_name() right before relying on the
+stringValue() method, if no better alternative was found.
+
+Test: platform/gtk/accessibility/button-accessible-name.html
+
+* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+(webkit_accessible_get_name): Use title() as the last fallback
+method before using stringValue().
+
 2011-11-29  Hyowon Kim  hw1008@samsung.com
 
 [Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port


Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (101347 => 101348)

--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp	2011-11-29 10:47:32 UTC (rev 101347)
+++ 

[webkit-changes] [101349] trunk/Source

[mario]

Title: [101349] trunk/Source








Revision 101349
Author ma...@webkit.org
Date 2011-11-29 03:04:43 -0800 (Tue, 29 Nov 2011)


Log Message
[Gtk] Regression: text-inserted events lack text inserted and current line
https://bugs.webkit.org/show_bug.cgi?id=72830

Reviewed by Chris Fleizach.

Source/WebCore:

Replace the emission of the old (and now deprecated) AtkObject's
'text-changed:insert' and 'text-changed:remove' signals with the
new 'text-insert' and 'text-remove' ones, which are better and
less fragile since they emit the modified text too, along with the
typical 'offset' and 'count' values associated to the change.

Also, change the signature of the nodeTextChangeNotification() and
nodeTextChangePlatformNotification() to allow specifying the text
being modified from the place we better know about it, that is,
the text editing commands.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::emitTextChanged): Emit 'text-insert' and 'text-remove',
instead of the old and now deprecated 'text-changed' signal.
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
Update this function to receive a String with the text being
modified, instead of just the number of characters.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::nodeTextChangeNotification): Update this
function to receive a String with the text being modified.
* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::nodeTextChangeNotification): Ditto.
(WebCore::AXObjectCache::nodeTextChangePlatformNotification): Ditto.

Adapt the text editing commants to pass the whole text string
being modified, instead of just its number of characters.

* editing/AppendNodeCommand.cpp:
(WebCore::sendAXTextChangedIgnoringLineBreaks): Adapt to the new
signature of nodeTextChangeNotification(), so pass the whole text.
* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply): Ditto.
(WebCore::DeleteFromTextNodeCommand::doUnapply): Ditto.
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply): Ditto.
(WebCore::InsertIntoTextNodeCommand::doUnapply): Ditto.
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply): Ditto.
(WebCore::InsertNodeBeforeCommand::doUnapply): Ditto.

Update mac, win and chromium's specific parts of AXObjectCache to
match the new signature for nodeTextChangePlatformNotification(),
which won't affect their behaviour as they were not implementing
that method anyway.

* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::nodeTextChangePlatformNotification):

Source/WebKit/gtk:

Updated unit test to handle the new 'text-insert' and
'text-remove' signals, instead of the 'text-changed' one.

* tests/testatk.c:
(textChangedCb): Update a global variable with the result of the
text change, so we can check its value later.
(testWebkitAtkTextChangedNotifications): Connect to the
'text-insert' and 'text-remove' signals and check, in a way more
carefully way than it was done before, that the signals are being
properly emitted, and that the information attached to them is the
right one for each case (insert/remove, offset, count and text).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp
trunk/Source/WebCore/editing/AppendNodeCommand.cpp
trunk/Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
trunk/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
trunk/Source/WebCore/editing/InsertNodeBeforeCommand.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testatk.c




Diff

Modified: trunk/Source/WebCore/ChangeLog (101348 => 101349)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 11:00:58 UTC (rev 101348)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 11:04:43 UTC (rev 101349)
@@ -1,5 +1,65 @@
 2011-11-29  Mario Sanchez Prada  msanc...@igalia.com
 
+[Gtk] Regression: text-inserted events lack text inserted and current line
+https://bugs.webkit.org/show_bug.cgi?id=72830
+
+Reviewed by Chris Fleizach.
+
+Replace the emission of the old (and now deprecated) AtkObject's
+'text-changed:insert' and 'text-changed:remove' signals with the
+new 'text-insert' and 'text-remove' ones, which are better and
+less fragile since they emit the modified text too, along with the
+typical 'offset' and 'count' values associated to the change.
+
+Also, change the signature of the nodeTextChangeNotification() and
+  

[webkit-changes] [101350] trunk/Source/WebKit2

[carlosgc]

Title: [101350] trunk/Source/WebKit2








Revision 101350
Author carlo...@webkit.org
Date 2011-11-29 03:10:53 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] Add WebKitURIResponse to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72946

Reviewed by Martin Robinson.

* GNUmakefile.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitURIResponse.cpp: Added.
(webkitURIResponseFinalize):
(webkitURIResponseGetProperty):
(webkitURIResponseSetProperty):
(webkit_uri_response_class_init):
(webkit_uri_response_init):
(webkit_uri_response_get_uri): Return the URI of the response.
(webkit_uri_response_get_status_code): Return the status code of
the response, or SOUP_STATUS_NONE.
(webkit_uri_response_get_content_length): Return the expected
content length of the response.
(webkitURIResponseCreateForSoupMessage): Private function to
create a response object from a SoupMessage.
(webkitURIResponseGetSoupMessage): Return the soup message
associated to the response.
(webkitURIResponseSetContentLength): Set the expected content
length of the response. This is useful for non http responses.
* UIProcess/API/gtk/WebKitURIResponse.h: Added.
* UIProcess/API/gtk/WebKitURIResponsePrivate.h: Added.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_uri_response_get_type().
* UIProcess/API/gtk/webkit2.h: Add WebKitURIResponse.h.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk.types
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitURIResponsePrivate.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (101349 => 101350)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 11:04:43 UTC (rev 101349)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 11:10:53 UTC (rev 101350)
@@ -1,3 +1,36 @@
+2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add WebKitURIResponse to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=72946
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Add new files to compilation.
+* UIProcess/API/gtk/WebKitURIResponse.cpp: Added.
+(webkitURIResponseFinalize):
+(webkitURIResponseGetProperty):
+(webkitURIResponseSetProperty):
+(webkit_uri_response_class_init):
+(webkit_uri_response_init):
+(webkit_uri_response_get_uri): Return the URI of the response.
+(webkit_uri_response_get_status_code): Return the status code of
+the response, or SOUP_STATUS_NONE.
+(webkit_uri_response_get_content_length): Return the expected
+content length of the response.
+(webkitURIResponseCreateForSoupMessage): Private function to
+create a response object from a SoupMessage.
+(webkitURIResponseGetSoupMessage): Return the soup message
+associated to the response.
+(webkitURIResponseSetContentLength): Set the expected content
+length of the response. This is useful for non http responses.
+* UIProcess/API/gtk/WebKitURIResponse.h: Added.
+* UIProcess/API/gtk/WebKitURIResponsePrivate.h: Added.
+* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section.
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
+* UIProcess/API/gtk/docs/webkit2gtk.types: Add
+webkit_uri_response_get_type().
+* UIProcess/API/gtk/webkit2.h: Add WebKitURIResponse.h.
+
 2011-11-29  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] QQuickWebView gets wrong position after reload


Modified: trunk/Source/WebKit2/GNUmakefile.am (101349 => 101350)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-11-29 11:04:43 UTC (rev 101349)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-11-29 11:10:53 UTC (rev 101350)
@@ -83,6 +83,7 @@
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebLoaderClient.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitSettings.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitURIRequest.h \
+	$(WebKit2)/UIProcess/API/gtk/WebKitURIResponse.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebView.h \
 	$(WebKit2)/UIProcess/API/gtk/WebKitWebViewBase.h \
 	$(WebKit2)/UIProcess/API/gtk/webkit2.h
@@ -508,6 +509,9 @@
 	Source/WebKit2/UIProcess/API/gtk/WebKitSettingsPrivate.h \
 	Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.cpp \
 	Source/WebKit2/UIProcess/API/gtk/WebKitURIRequest.h \
+	Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp \
+	Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.h \
+	Source/WebKit2/UIProcess/API/gtk/WebKitURIResponsePrivate.h \
 	

[webkit-changes] [101346] trunk/LayoutTests

[ossy]

Title: [101346] trunk/LayoutTests








Revision 101346
Author o...@webkit.org
Date 2011-11-29 02:30:41 -0800 (Tue, 29 Nov 2011)


Log Message
SVG path DRT dumps have rounding problems across platforms
https://bugs.webkit.org/show_bug.cgi?id=47467

One more update after r101342.

* platform/qt/svg/transforms/svg-css-transforms-expected.txt: Updated.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/svg/transforms/svg-css-transforms-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101345 => 101346)

--- trunk/LayoutTests/ChangeLog	2011-11-29 10:02:05 UTC (rev 101345)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 10:30:41 UTC (rev 101346)
@@ -3,8 +3,17 @@
 SVG path DRT dumps have rounding problems across platforms
 https://bugs.webkit.org/show_bug.cgi?id=47467
 
-Update Qt specific expected results aftert r101342.
+One more update after r101342.
 
+* platform/qt/svg/transforms/svg-css-transforms-expected.txt: Updated.
+
+2011-11-29  Csaba Osztrogonác  o...@webkit.org
+
+SVG path DRT dumps have rounding problems across platforms
+https://bugs.webkit.org/show_bug.cgi?id=47467
+
+Update Qt specific expected results after r101342.
+
 * platform/qt/ [...]: Updated.
 
 2011-11-29  Nikolas Zimmermann  nzimmerm...@rim.com


Modified: trunk/LayoutTests/platform/qt/svg/transforms/svg-css-transforms-expected.txt (101345 => 101346)

--- trunk/LayoutTests/platform/qt/svg/transforms/svg-css-transforms-expected.txt	2011-11-29 10:02:05 UTC (rev 101345)
+++ trunk/LayoutTests/platform/qt/svg/transforms/svg-css-transforms-expected.txt	2011-11-29 10:30:41 UTC (rev 101346)
@@ -25,9 +25,9 @@
 RenderSVGRoot {svg} at (29,112) size 196x174
   RenderSVGContainer {g} at (29,112) size 196x174 [transform={m=((1.00,0.00)(0.00,1.00)) t=(75.00,25.00)}]
 RenderSVGPath {rect} at (103,113) size 62x62 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
-RenderSVGContainer {g} at (29,112) size 197x174 [transform={m=((2.00,0.00)(0.00,2.00)) t=(0.00,0.00)}]
-  RenderSVGPath {rect} at (102,112) size 124x124 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
-  RenderSVGPath {rect} at (29,110) size 163x178 [transform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
+RenderSVGContainer {g} at (29,112) size 196x174 [transform={m=((2.00,0.00)(0.00,2.00)) t=(0.00,0.00)}]
+  RenderSVGPath {rect} at (103,113) size 122x122 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
+  RenderSVGPath {rect} at (29,112) size 162x174 [transform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
 RenderText {#text} at (0,0) size 0x0
 layer at (28,358) size 200x200
   RenderBlock (relative positioned) {div} at (10,340) size 200x200 [bgcolor=#C0C0C0] [border: (1px solid #00)]
@@ -40,7 +40,7 @@
 layer at (272,88) size 200x200
   RenderBlock (relative positioned) {div} at (10,70) size 200x200 [bgcolor=#C0C0C0] [border: (1px solid #00)]
 RenderSVGRoot {svg} at (273,112) size 162x174
-  RenderSVGPath {rect} at (273,111) size 163x176 [transform={m=((1.41,1.41)(-1.41,1.41)) t=(75.00,25.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
+  RenderSVGPath {rect} at (273,112) size 162x174 [transform={m=((1.41,1.41)(-1.41,1.41)) t=(75.00,25.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
 RenderText {#text} at (0,0) size 0x0
 layer at (272,358) size 200x200
   RenderBlock (relative positioned) {div} at (10,340) size 200x200 [bgcolor=#C0C0C0] [border: (1px solid #00)]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101353] trunk/LayoutTests

[ossy]

Title: [101353] trunk/LayoutTests








Revision 101353
Author o...@webkit.org
Date 2011-11-29 03:37:25 -0800 (Tue, 29 Nov 2011)


Log Message
SVG path DRT dumps have rounding problems across platforms
https://bugs.webkit.org/show_bug.cgi?id=47467

* platform/qt/Skipped: Skip new failing tests after r101342.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (101352 => 101353)

--- trunk/LayoutTests/ChangeLog	2011-11-29 11:24:54 UTC (rev 101352)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 11:37:25 UTC (rev 101353)
@@ -1,3 +1,10 @@
+2011-11-29  Csaba Osztrogonác  o...@webkit.org
+
+SVG path DRT dumps have rounding problems across platforms
+https://bugs.webkit.org/show_bug.cgi?id=47467
+
+* platform/qt/Skipped: Skip new failing tests after r101342.
+
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK css2.1 rebaseline after r101343.


Modified: trunk/LayoutTests/platform/qt/Skipped (101352 => 101353)

--- trunk/LayoutTests/platform/qt/Skipped	2011-11-29 11:24:54 UTC (rev 101352)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-11-29 11:37:25 UTC (rev 101353)
@@ -2013,6 +2013,29 @@
 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
 svg/dom/css-transforms.xhtml
 
+# [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
+# https://bugs.webkit.org/show_bug.cgi?id=52810
+# new failing tests after r101342 on 64 bit.
+svg/batik/text/textAnchor.svg
+svg/text/select-x-list-with-tspans-1.svg
+svg/text/select-x-list-with-tspans-3.svg
+svg/text/select-textLength-spacing-stretch-3.svg
+svg/text/select-textLength-spacingAndGlyphs-stretch-4.svg
+svg/text/select-x-list-2.svg
+svg/text/select-textLength-spacing-stretch-4.svg
+svg/text/select-textLength-spacing-squeeze-4.svg
+svg/text/select-textLength-spacing-stretch-1.svg
+svg/text/select-textLength-spacing-squeeze-1.svg
+svg/text/select-x-list-3.svg
+svg/text/select-x-list-with-tspans-4.svg
+svg/text/select-textLength-spacing-stretch-2.svg
+svg/text/select-x-list-4.svg
+svg/text/select-x-list-with-tspans-2.svg
+svg/text/select-textLength-spacing-squeeze-3.svg
+svg/text/select-x-list-1.svg
+svg/text/select-textLength-spacing-squeeze-2.svg
+svg/W3C-SVG-1.1/text-text-01-b.svg
+
 # [Qt] inspector/styles/styles-disable-then-enable.html make inspector/styles/styles-iframe.html fail in debug mode
 # https://bugs.webkit.org/show_bug.cgi?id=58313
 inspector/styles/styles-disable-then-enable.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101356] trunk/LayoutTests

[zimmermann]

Title: [101356] trunk/LayoutTests








Revision 101356
Author zimmerm...@webkit.org
Date 2011-11-29 04:22:59 -0800 (Tue, 29 Nov 2011)


Log Message
2011-11-29  Nikolas Zimmermann  nzimmerm...@rim.com

Not reviewed. Update SVG pixel results which showed small 1% diffs since a while, on both of my 32/64bit machines.

* platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/mac/svg/batik/filters/feTile-expected.png:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/textFeatures-expected.png:
* platform/mac/svg/custom/external-paintserver-reference-expected.png:
* platform/mac/svg/custom/linking-base-external-reference-expected.png:
* platform/mac/svg/custom/mask-colorspace-expected.png:
* platform/mac/svg/custom/mask-with-all-units-expected.png:
* platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
* platform/mac/svg/custom/text-rotated-gradient-expected.png:
* platform/mac/svg/filters/filter-clip-expected.png:
* platform/mac/svg/filters/filterRes-expected.png:
* platform/mac/svg/text/selection-background-color-expected.png:
* svg/css/getComputedStyle-basic-expected.txt: The grid-columns parsing patch did not update this file, I've fixed that.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png
trunk/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-expected.png
trunk/LayoutTests/platform/mac/svg/batik/filters/feTile-expected.png
trunk/LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.png
trunk/LayoutTests/platform/mac/svg/batik/text/textFeatures-expected.png
trunk/LayoutTests/platform/mac/svg/custom/external-paintserver-reference-expected.png
trunk/LayoutTests/platform/mac/svg/custom/linking-base-external-reference-expected.png
trunk/LayoutTests/platform/mac/svg/custom/mask-colorspace-expected.png
trunk/LayoutTests/platform/mac/svg/custom/mask-with-all-units-expected.png
trunk/LayoutTests/platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png
trunk/LayoutTests/platform/mac/svg/custom/text-rotated-gradient-expected.png
trunk/LayoutTests/platform/mac/svg/filters/filter-clip-expected.png
trunk/LayoutTests/platform/mac/svg/filters/filterRes-expected.png
trunk/LayoutTests/platform/mac/svg/text/selection-background-color-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png
trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101355 => 101356)

--- trunk/LayoutTests/ChangeLog	2011-11-29 12:01:40 UTC (rev 101355)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 12:22:59 UTC (rev 101356)
@@ -1,3 +1,24 @@
+2011-11-29  Nikolas Zimmermann  nzimmerm...@rim.com
+
+Not reviewed. Update SVG pixel results which showed small 1% diffs since a while, on both of my 32/64bit machines.
+
+* platform/mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
+* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
+* platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
+* platform/mac/svg/batik/filters/feTile-expected.png:
+* platform/mac/svg/batik/text/smallFonts-expected.png:
+* platform/mac/svg/batik/text/textFeatures-expected.png:
+* platform/mac/svg/custom/external-paintserver-reference-expected.png:
+* platform/mac/svg/custom/linking-base-external-reference-expected.png:
+* platform/mac/svg/custom/mask-colorspace-expected.png:
+* platform/mac/svg/custom/mask-with-all-units-expected.png:
+* platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.png:
+* platform/mac/svg/custom/text-rotated-gradient-expected.png:
+* platform/mac/svg/filters/filter-clip-expected.png:
+* platform/mac/svg/filters/filterRes-expected.png:
+* platform/mac/svg/text/selection-background-color-expected.png:
+* svg/css/getComputedStyle-basic-expected.txt: The grid-columns parsing patch did not update this file, I've fixed that.
+
 2011-11-29  Martin Robinson  mrobin...@igalia.com
 
 Rebaseline GTK+ results after the recent changes to text metrics.


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/svg/as-border-image/svg-as-border-image-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/svg/batik/filters/feTile-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/svg/batik/text/smallFonts-expected.png

(Binary files differ)


Modified: 

[webkit-changes] [101359] trunk

[podivilov]

Title: [101359] trunk








Revision 101359
Author podivi...@chromium.org
Date 2011-11-29 04:46:34 -0800 (Tue, 29 Nov 2011)


Log Message
Web Inspector: support concatenated source maps.
https://bugs.webkit.org/show_bug.cgi?id=73138

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.loadSourceCode):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMappingPayload):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseSections):
(WebInspector.ClosureCompilerSourceMapping.prototype._parseMap):
(WebInspector.ClosureCompilerSourceMapping.prototype._canonicalizeURL):
* inspector/front-end/inspector.js:
(WebInspector.installSourceMappingForTest):

LayoutTests:

* http/tests/inspector/compiler-source-mapping-expected.txt:
* http/tests/inspector/compiler-source-mapping.html:
* http/tests/inspector/resources/source-map.json:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt
trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html
trunk/LayoutTests/http/tests/inspector/resources/source-map.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js
trunk/Source/WebCore/inspector/front-end/inspector.js




Diff

Modified: trunk/LayoutTests/ChangeLog (101358 => 101359)

--- trunk/LayoutTests/ChangeLog	2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 12:46:34 UTC (rev 101359)
@@ -1,3 +1,14 @@
+2011-11-25  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: support concatenated source maps.
+https://bugs.webkit.org/show_bug.cgi?id=73138
+
+Reviewed by Yury Semikhatsky.
+
+* http/tests/inspector/compiler-source-mapping-expected.txt:
+* http/tests/inspector/compiler-source-mapping.html:
+* http/tests/inspector/resources/source-map.json:
+
 2011-11-29  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Not reviewed. Rebaseline Win SVG results after r101342.


Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt (101358 => 101359)

--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt	2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping-expected.txt	2011-11-29 12:46:34 UTC (rev 101359)
@@ -7,5 +7,7 @@
 
 Running: testEmptyLine
 
+Running: testSections
+
 Running: testLoad
 


Modified: trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html (101358 => 101359)

--- trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html	2011-11-29 12:40:45 UTC (rev 101358)
+++ trunk/LayoutTests/http/tests/inspector/compiler-source-mapping.html	2011-11-29 12:46:34 UTC (rev 101359)
@@ -90,6 +90,32 @@
 next();
 },
 
+function testSections(next)
+{
+var mappingPayload = {
+sections: [{
+offset: { line: 1, column: 0 },
+map: {
+mappings:,CAEC,
+sources:[source1.js]
+}
+}, {
+offset: { line: 3, column: 10 },
+map: {
+mappings:,CAEC,
+sources:[source2.js]
+}
+}
+]};
+var mapping = new WebInspector.ClosureCompilerSourceMapping();
+mapping._parseMappingPayload(mappingPayload);
+checkMapping(0, 0, source1.js, 0, 0, mapping);
+checkMapping(0, 1, source1.js, 2, 1, mapping);
+checkMapping(2, 10, source2.js, 0, 0, mapping);
+checkMapping(2, 11, source2.js, 2, 1, mapping);
+next();
+},
+
 function testLoad(next)
 {
 var sourceMapping = new WebInspector.ClosureCompilerSourceMapping(http://localhost:8000/inspector/resources/source-map.json);
@@ -98,8 +124,8 @@
 
 var sources = sourceMapping.sources();
 InspectorTest.assertEquals(2, sources.length);
-InspectorTest.assertEquals(source1.js, sources[0]);
-InspectorTest.assertEquals(source2.js, sources[1]);
+InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source1.js, sources[0]);
+InspectorTest.assertEquals(http://localhost:8000/inspector/resources/source2.js, sources[1]);
 
 var sourceCode1 = sourceMapping.loadSourceCode(sourceMapping.sources()[0]);
 InspectorTest.assertEquals(0, sourceCode1.indexOf(window.addEventListener));


Modified: trunk/LayoutTests/http/tests/inspector/resources/source-map.json (101358 => 101359)

--- trunk/LayoutTests/http/tests/inspector/resources/source-map.json	2011-11-29 12:40:45 UTC (rev 101358)
+++ 

[webkit-changes] [101360] trunk

[zimmermann]

Title: [101360] trunk








Revision 101360
Author zimmerm...@webkit.org
Date 2011-11-29 05:00:27 -0800 (Tue, 29 Nov 2011)


Log Message
2011-11-29  Zoltan Herczeg  zherc...@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Reviewed by Nikolas Zimmermann.

Update baseline after switching getCTM() to use double-precision internally.

* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
* platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
* platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
* platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt:
* platform/mac/svg/custom/use-detach-expected.txt:
* platform/mac/svg/hixie/links/001-expected.txt:
* platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
* platform/mac/svg/text/small-fonts-2-expected.txt:
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:

2011-11-29  Zoltan Herczeg  zherc...@webkit.org

[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

Reviewed by Nikolas Zimmermann.

This avoids precision loss in getCTM, which is used whenever mapping repaint rects to a parent coordinate system
- it affects several DRT results on Mac, all of them are progressions.

* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::getCTM): Use double-precision internally.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt
trunk/LayoutTests/platform/mac/svg/custom/non-circular-marker-reference-expected.txt
trunk/LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt
trunk/LayoutTests/platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt
trunk/LayoutTests/platform/mac/svg/custom/use-detach-expected.txt
trunk/LayoutTests/platform/mac/svg/hixie/links/001-expected.txt
trunk/LayoutTests/platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt
trunk/LayoutTests/platform/mac/svg/text/small-fonts-2-expected.txt
trunk/LayoutTests/platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGPreserveAspectRatio.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (101359 => 101360)

--- trunk/LayoutTests/ChangeLog	2011-11-29 12:46:34 UTC (rev 101359)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 13:00:27 UTC (rev 101360)
@@ -1,3 +1,25 @@
+2011-11-29  Zoltan Herczeg  zherc...@webkit.org
+
+[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
+https://bugs.webkit.org/show_bug.cgi?id=52810
+
+Reviewed by Nikolas Zimmermann.
+
+Update baseline after switching getCTM() to use double-precision internally.
+
+* platform/mac-snowleopard/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
+* platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
+* platform/mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
+* platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
+* platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
+* platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt:
+* platform/mac/svg/custom/object-sizing-explicit-width-height-expected.txt:
+* platform/mac/svg/custom/use-detach-expected.txt:
+* platform/mac/svg/hixie/links/001-expected.txt:
+* platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
+* platform/mac/svg/text/small-fonts-2-expected.txt:
+* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
+
 2011-11-25  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: support concatenated source maps.


Modified: trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt (101359 => 101360)

--- trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt	2011-11-29 12:46:34 UTC (rev 101359)
+++ trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt	

[webkit-changes] [101361] trunk/LayoutTests

[kbalazs]

Title: [101361] trunk/LayoutTests








Revision 101361
Author kbal...@webkit.org
Date 2011-11-29 05:10:47 -0800 (Tue, 29 Nov 2011)


Log Message
[WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

Unreviewed gardening.

Unskip the test on Win-WK2 after fixed in r101232.

* platform/win-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (101360 => 101361)

--- trunk/LayoutTests/ChangeLog	2011-11-29 13:00:27 UTC (rev 101360)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 13:10:47 UTC (rev 101361)
@@ -1,3 +1,14 @@
+2011-11-29  Balazs Kelemen  kbal...@webkit.org
+
+[WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
+https://bugs.webkit.org/show_bug.cgi?id=63321
+
+Unreviewed gardening.
+
+Unskip the test on Win-WK2 after fixed in r101232.
+
+* platform/win-wk2/Skipped:
+
 2011-11-29  Zoltan Herczeg  zherc...@webkit.org
 
 [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode


Modified: trunk/LayoutTests/platform/win-wk2/Skipped (101360 => 101361)

--- trunk/LayoutTests/platform/win-wk2/Skipped	2011-11-29 13:00:27 UTC (rev 101360)
+++ trunk/LayoutTests/platform/win-wk2/Skipped	2011-11-29 13:10:47 UTC (rev 101361)
@@ -935,9 +935,6 @@
 # requires video.buffered to be able to return multiple timeranges
 http/tests/media/video-buffered.html
 
-# Crashes http://webkit.org/b/55778
-fast/frames/iframe-plugin-load-remove-document-crash.html
-
 # No keygen support
 fast/html/keygen.html
 fast/invalid/residual-style.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101364] trunk/Source/WebCore

[caseq]

Title: [101364] trunk/Source/WebCore








Revision 101364
Author ca...@chromium.org
Date 2011-11-29 05:39:15 -0800 (Tue, 29 Nov 2011)


Log Message
Web Inspector: remove usage of innerHTML from inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=73305

Reviewed by Yury Semikhatsky.

* inspector/front-end/FontView.js:
(WebInspector.FontView.prototype._createContentIfNeeded):
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsSection.prototype.addKey):
(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
(WebInspector.ShortcutsSection.prototype._addLine):
(WebInspector.ShortcutsSection.prototype.renderSection):
(WebInspector.ShortcutsSection.prototype._renderSequence):
(WebInspector.ShortcutsSection.prototype._renderKey):
(WebInspector.ShortcutsSection.prototype.get _height):
(WebInspector.ShortcutsSection.prototype._createSpan):
(WebInspector.ShortcutsSection.prototype._joinNodes):
* inspector/front-end/WelcomeView.js:
(WebInspector.WelcomeView.prototype.addMessage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/FontView.js
trunk/Source/WebCore/inspector/front-end/ShortcutsScreen.js
trunk/Source/WebCore/inspector/front-end/WelcomeView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (101363 => 101364)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 13:30:12 UTC (rev 101363)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 13:39:15 UTC (rev 101364)
@@ -1,3 +1,26 @@
+2011-11-29  Andrey Kosyakov  ca...@chromium.org
+
+Web Inspector: remove usage of innerHTML from inspector front-end
+https://bugs.webkit.org/show_bug.cgi?id=73305
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/FontView.js:
+(WebInspector.FontView.prototype._createContentIfNeeded):
+* inspector/front-end/ShortcutsScreen.js:
+(WebInspector.ShortcutsSection.prototype.addKey):
+(WebInspector.ShortcutsSection.prototype.addRelatedKeys):
+(WebInspector.ShortcutsSection.prototype.addAlternateKeys):
+(WebInspector.ShortcutsSection.prototype._addLine):
+(WebInspector.ShortcutsSection.prototype.renderSection):
+(WebInspector.ShortcutsSection.prototype._renderSequence):
+(WebInspector.ShortcutsSection.prototype._renderKey):
+(WebInspector.ShortcutsSection.prototype.get _height):
+(WebInspector.ShortcutsSection.prototype._createSpan):
+(WebInspector.ShortcutsSection.prototype._joinNodes):
+* inspector/front-end/WelcomeView.js:
+(WebInspector.WelcomeView.prototype.addMessage):
+
 2011-11-29  Zoltan Herczeg  zherc...@webkit.org
 
 [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode


Modified: trunk/Source/WebCore/inspector/front-end/FontView.js (101363 => 101364)

--- trunk/Source/WebCore/inspector/front-end/FontView.js	2011-11-29 13:30:12 UTC (rev 101363)
+++ trunk/Source/WebCore/inspector/front-end/FontView.js	2011-11-29 13:39:15 UTC (rev 101364)
@@ -37,7 +37,7 @@
 this.element.addStyleClass(font);
 }
 
-WebInspector.FontView._fontInnerHTML = ABCDEFGHIJKLMbrNOPQRSTUVWXYZbrabcdefghijklmbrnopqrstuvwxyzbr1234567890;
+WebInspector.FontView._fontPreviewLines = [ ABCDEFGHIJKLM, NOPQRSTUVWXYZ, abcdefghijklm, nopqrstuvwxyz, 1234567890 ];
 
 WebInspector.FontView._fontId = 0;
 
@@ -60,19 +60,23 @@
 this.fontStyleElement.textContent = @font-face { font-family: \ + uniqueFontName + \; src: url( + this.resource.url + ); };
 document.head.appendChild(this.fontStyleElement);
 
-this.fontPreviewElement = document.createElement(div);
-this.fontPreviewElement.innerHTML = WebInspector.FontView._fontInnerHTML;
+var fontPreview = document.createElement(div);
+for (var i = 0; i  WebInspector.FontView._fontPreviewLines.length; ++i) {
+if (i  0)
+fontPreview.appendChild(document.createElement(br));
+fontPreview.appendChild(document.createTextNode(WebInspector.FontView._fontPreviewLines[i]));
+}
+this.fontPreviewElement = fontPreview.cloneNode(true);
 this.fontPreviewElement.style.setProperty(font-family, uniqueFontName);
 this.fontPreviewElement.style.setProperty(visibility, hidden);
 
-this._dummyElement = document.createElement(div);
+this._dummyElement = fontPreview;
 this._dummyElement.style.visibility = hidden;
 this._dummyElement.style.zIndex = -1;
 this._dummyElement.style.display = inline;
 this._dummyElement.style.position = absolute;
 this._dummyElement.style.setProperty(font-family, uniqueFontName);
 this._dummyElement.style.setProperty(font-size, WebInspector.FontView._measureFontSize + px);
-this._dummyElement.innerHTML = WebInspector.FontView._fontInnerHTML;
 
 this.element.appendChild(this.fontPreviewElement);
  

[webkit-changes] [101365] trunk/Source/WebCore

[hausmann]

Title: [101365] trunk/Source/WebCore








Revision 101365
Author hausm...@webkit.org
Date 2011-11-29 06:36:39 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt][V8] Add missing ExceptionCode.h include for SVG bindings
https://bugs.webkit.org/show_bug.cgi?id=73314

Reviewed by Kenneth Rohde Christiansen.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter): Similarly to other places where we use DOM
exceptions, make sure we include ExceptionCode.h here. It appears to be
an implicit inclusion in the Chromium build, but it should be explicit
like in the rest of the bindings.
(GenerateFunctionCallback): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (101364 => 101365)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 13:39:15 UTC (rev 101364)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 14:36:39 UTC (rev 101365)
@@ -1,3 +1,17 @@
+2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt][V8] Add missing ExceptionCode.h include for SVG bindings
+https://bugs.webkit.org/show_bug.cgi?id=73314
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrSetter): Similarly to other places where we use DOM
+exceptions, make sure we include ExceptionCode.h here. It appears to be
+an implicit inclusion in the Chromium build, but it should be explicit
+like in the rest of the bindings.
+(GenerateFunctionCallback): Ditto.
+
 2011-11-29  Andrey Kosyakov  ca...@chromium.org
 
 Web Inspector: remove usage of innerHTML from inspector front-end


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (101364 => 101365)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-11-29 13:39:15 UTC (rev 101364)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-11-29 14:36:39 UTC (rev 101365)
@@ -1021,6 +1021,7 @@
 $svgNativeType* imp = V8${implClassName}::toNative(info.Holder());
 END
 } else {
+AddToImplIncludes(ExceptionCode.h);
 push(@implContentDecls, $svgNativeType* wrapper = V8${implClassName}::toNative(info.Holder());\n);
 push(@implContentDecls, if (wrapper-role() == AnimValRole) {\n);
 push(@implContentDecls, V8Proxy::setDOMException(NO_MODIFICATION_ALLOWED_ERR);\n);
@@ -1324,6 +1325,7 @@
 if ($implClassName =~ /List$/) {
 push(@implContentDecls, $nativeClassName imp = V8${implClassName}::toNative(args.Holder());\n);
 } else {
+AddToImplIncludes(ExceptionCode.h);
 push(@implContentDecls, $nativeClassName wrapper = V8${implClassName}::toNative(args.Holder());\n);
 push(@implContentDecls, if (wrapper-role() == AnimValRole) {\n);
 push(@implContentDecls, V8Proxy::setDOMException(NO_MODIFICATION_ALLOWED_ERR);\n);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101366] trunk/Source

[hausmann]

Title: [101366] trunk/Source








Revision 101366
Author hausm...@webkit.org
Date 2011-11-29 06:39:09 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Make WebKit/qt build with V8 and Qt 5
https://bugs.webkit.org/show_bug.cgi?id=73315

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

For the Qt 5 / V8 build we use QJSEngine/QJSValue instead of
QScriptEngine/QScriptValue.

* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
* bindings/v8/ScriptControllerQt.cpp:
(WebCore::ScriptController::qtScriptEngine):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QtWebElementRuntime::initialize): #ifdef JSC code
properly. There's no V8 equivalent just yet.
* Api/qwebelement.h: Get rid of old V8 cruft.
* Api/qwebframe.cpp:
(QWebFrame::addToJavaScriptWindowObject): QScriptEngine - QJSEngine.
(QWebFrame::evaluateJavaScript): Ditto.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(QtDRTNodeRuntime::initialize): #ifdef JSC code.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::didCreateScriptContext): Adapt to FrameLoaderClient
V8 API changes that happened long time ago.
(WebCore::FrameLoaderClientQt::willReleaseScriptContext): Ditto.
* WebCoreSupport/FrameLoaderClientQt.h: Ditto.
* WebCoreSupport/InspectorClientQt.cpp: Add missing include for V8 build.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/bindings/v8/ScriptControllerQt.cpp
trunk/Source/WebKit/qt/Api/qwebelement.cpp
trunk/Source/WebKit/qt/Api/qwebelement.h
trunk/Source/WebKit/qt/Api/qwebframe.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
trunk/Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.h
trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101365 => 101366)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 14:36:39 UTC (rev 101365)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 14:39:09 UTC (rev 101366)
@@ -1,5 +1,20 @@
 2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
 
+[Qt] Make WebKit/qt build with V8 and Qt 5
+https://bugs.webkit.org/show_bug.cgi?id=73315
+
+Reviewed by Kenneth Rohde Christiansen.
+
+For the Qt 5 / V8 build we use QJSEngine/QJSValue instead of
+QScriptEngine/QScriptValue.
+
+* bindings/v8/ScriptController.cpp:
+* bindings/v8/ScriptController.h:
+* bindings/v8/ScriptControllerQt.cpp:
+(WebCore::ScriptController::qtScriptEngine):
+
+2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
+
 [Qt][V8] Add missing ExceptionCode.h include for SVG bindings
 https://bugs.webkit.org/show_bug.cgi?id=73314
 


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.cpp (101365 => 101366)

--- trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2011-11-29 14:36:39 UTC (rev 101365)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.cpp	2011-11-29 14:39:09 UTC (rev 101366)
@@ -67,7 +67,7 @@
 #include wtf/text/CString.h
 
 #if PLATFORM(QT)
-#include QScriptEngine
+#include QJSEngine
 #endif
 
 namespace WebCore {


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (101365 => 101366)

--- trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-11-29 14:36:39 UTC (rev 101365)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-11-29 14:39:09 UTC (rev 101366)
@@ -47,7 +47,7 @@
 #if PLATFORM(QT)
 #include qglobal.h
 QT_BEGIN_NAMESPACE
-class QScriptEngine;
+class QJSEngine;
 QT_END_NAMESPACE
 #endif
 
@@ -181,7 +181,7 @@
 #endif
 
 #if PLATFORM(QT)
-QScriptEngine* qtScriptEngine();
+QJSEngine* qtScriptEngine();
 #endif
 
 // Dummy method to avoid a bunch of ifdef's in WebCore.
@@ -199,7 +199,7 @@
 OwnPtrV8Proxy m_proxy;
 typedef HashMapWidget*, NPObject* PluginObjectMap;
 #if PLATFORM(QT)
-OwnPtrQScriptEngine m_qtScriptEngine;
+OwnPtrQJSEngine m_qtScriptEngine;
 #endif
 
 // A mapping between Widgets and their corresponding script object.


Modified: trunk/Source/WebCore/bindings/v8/ScriptControllerQt.cpp (101365 => 101366)

--- trunk/Source/WebCore/bindings/v8/ScriptControllerQt.cpp	2011-11-29 14:36:39 UTC (rev 101365)
+++ trunk/Source/WebCore/bindings/v8/ScriptControllerQt.cpp	2011-11-29 14:39:09 UTC (rev 101366)
@@ -28,11 +28,11 @@
 #include config.h
 #include ScriptController.h
 
-#include QScriptEngine
+#include QJSEngine
 
 namespace WebCore {
 
-QScriptEngine* ScriptController::qtScriptEngine()
+QJSEngine* ScriptController::qtScriptEngine()
 {
 if (!m_qtScriptEngine) {
 v8::HandleScope handleScope;
@@ -40,7 +40,7 @@
 v8::Context::Scope scope(v8Context);
 if (v8Context.IsEmpty())
 return 0;
-m_qtScriptEngine = adoptPtr(new QScriptEngine(QScriptEngine::AdoptCurrentContext));
+m_qtScriptEngine = 

[webkit-changes] [101372] trunk/LayoutTests

[philn]

Title: [101372] trunk/LayoutTests








Revision 101372
Author ph...@webkit.org
Date 2011-11-29 07:13:26 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, GTK dom/xhtml/level3 rebaseline after r101343.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri07-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri09-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri10-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri11-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri15-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri17-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri18-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.txt
trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodelookupprefix19-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101371 => 101372)

--- trunk/LayoutTests/ChangeLog	2011-11-29 15:11:26 UTC (rev 101371)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 15:13:26 UTC (rev 101372)
@@ -6,7 +6,7 @@
 
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
-Unreviewed, GTK editing/ rebaseline after r101343.
+Unreviewed, GTK dom/xhtml/level3 rebaseline after r101343.
 
 2011-11-29  Martin Robinson  mrobin...@igalia.com
 


Modified: trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt (101371 => 101372)

--- trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt	2011-11-29 15:11:26 UTC (rev 101371)
+++ trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/documentgetinputencoding03-expected.txt	2011-11-29 15:13:26 UTC (rev 101372)
@@ -1,8 +1,8 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x51
-  RenderBlock {html} at (0,0) size 800x51
-RenderBody {body} at (8,16) size 784x19
-  RenderBlock {p} at (0,0) size 784x19
-RenderText {#text} at (0,0) size 20x19
-  text run at (0,0) width 20: bar
+layer at (0,0) size 800x50
+  RenderBlock {html} at (0,0) size 800x50
+RenderBody {body} at (8,16) size 784x18
+  RenderBlock {p} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 21x17
+  text run at (0,0) width 21: bar


Modified: trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt (101371 => 101372)

--- trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt	2011-11-29 15:11:26 UTC (rev 101371)
+++ trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetinputencoding02-expected.txt	2011-11-29 15:13:26 UTC (rev 101372)
@@ -1,8 +1,8 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x51
-  RenderBlock {html} at (0,0) size 800x51
-RenderBody {body} at (8,16) size 784x19
-  RenderBlock {p} at (0,0) size 784x19
-RenderText {#text} at (0,0) size 20x19
-  text run at (0,0) width 20: bar
+layer at (0,0) size 800x50
+  RenderBlock {html} at (0,0) size 800x50
+RenderBody {body} at (8,16) size 784x18
+  RenderBlock {p} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 21x17
+  text run at (0,0) width 21: bar


Modified: trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt (101371 => 101372)

--- trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt	2011-11-29 15:11:26 UTC (rev 101371)
+++ trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/entitygetxmlversion02-expected.txt	2011-11-29 15:13:26 UTC (rev 101372)
@@ -1,8 +1,8 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x51
-  RenderBlock {html} at (0,0) size 800x51
-RenderBody {body} at (8,16) size 784x19
-  RenderBlock {p} at (0,0) size 784x19
-RenderText {#text} at (0,0) size 20x19
-  text run at (0,0) width 20: bar
+layer at (0,0) size 800x50
+  RenderBlock {html} at (0,0) size 800x50
+RenderBody {body} at (8,16) size 784x18
+  RenderBlock {p} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 21x17
+  text run at (0,0) width 21: bar


Modified: trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt (101371 => 101372)

--- trunk/LayoutTests/platform/gtk/dom/xhtml/level3/core/nodegetbaseuri05-expected.txt	2011-11-29 15:11:26 UTC (rev 101371)
+++ 

[webkit-changes] [101373] trunk/Source/WebCore

[pfeldman]

Title: [101373] trunk/Source/WebCore








Revision 101373
Author pfeld...@chromium.org
Date 2011-11-29 07:16:22 -0800 (Tue, 29 Nov 2011)


Log Message
2011-11-29  Pavel Feldman  pfeld...@google.com

Not reviewed: fixing clang build.

* inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgentInterface::getAgentCapabilities):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getAgentCapabilities):
* inspector/InspectorDebuggerAgent.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorBaseAgent.h
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp
trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h
trunk/Source/WebCore/inspector/InspectorMetaAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101372 => 101373)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 15:13:26 UTC (rev 101372)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 15:16:22 UTC (rev 101373)
@@ -1,5 +1,15 @@
 2011-11-29  Pavel Feldman  pfeld...@google.com
 
+Not reviewed: fixing clang build.
+
+* inspector/InspectorBaseAgent.h:
+(WebCore::InspectorBaseAgentInterface::getAgentCapabilities):
+* inspector/InspectorDebuggerAgent.cpp:
+(WebCore::InspectorDebuggerAgent::getAgentCapabilities):
+* inspector/InspectorDebuggerAgent.h:
+
+2011-11-29  Pavel Feldman  pfeld...@google.com
+
 Web Inspector: introduce generic capabilities concept, migrate debugger domain to generic capabilities.
 https://bugs.webkit.org/show_bug.cgi?id=73311
 


Modified: trunk/Source/WebCore/inspector/InspectorBaseAgent.h (101372 => 101373)

--- trunk/Source/WebCore/inspector/InspectorBaseAgent.h	2011-11-29 15:13:26 UTC (rev 101372)
+++ trunk/Source/WebCore/inspector/InspectorBaseAgent.h	2011-11-29 15:16:22 UTC (rev 101373)
@@ -50,7 +50,7 @@
 virtual void clearFrontend() { }
 virtual void restore() { }
 virtual void registerInDispatcher(InspectorBackendDispatcher*) = 0;
-virtual void getCapabilities(InspectorArray*) { };
+virtual void getAgentCapabilities(InspectorArray*) { };
 
 String name() { return m_name; }
 private:


Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp (101372 => 101373)

--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp	2011-11-29 15:13:26 UTC (rev 101372)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.cpp	2011-11-29 15:16:22 UTC (rev 101373)
@@ -99,7 +99,7 @@
 return m_state-getBoolean(DebuggerAgentState::debuggerEnabled);
 }
 
-void InspectorDebuggerAgent::getCapabilities(InspectorArray* capabilities)
+void InspectorDebuggerAgent::getAgentCapabilities(InspectorArray* capabilities)
 {
 if (scriptDebugServer().canSetScriptSource())
 capabilities-pushString(InspectorFrontend::Debugger::capabilitySetScriptSource);


Modified: trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h (101372 => 101373)

--- trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h	2011-11-29 15:13:26 UTC (rev 101372)
+++ trunk/Source/WebCore/inspector/InspectorDebuggerAgent.h	2011-11-29 15:16:22 UTC (rev 101373)
@@ -71,7 +71,7 @@
 virtual void setFrontend(InspectorFrontend*);
 virtual void clearFrontend();
 virtual void restore();
-virtual void getCapabilities(InspectorArray*);
+virtual void getAgentCapabilities(InspectorArray*);
 
 void didClearMainFrameWindowObject();
 


Modified: trunk/Source/WebCore/inspector/InspectorMetaAgent.cpp (101372 => 101373)

--- trunk/Source/WebCore/inspector/InspectorMetaAgent.cpp	2011-11-29 15:13:26 UTC (rev 101372)
+++ trunk/Source/WebCore/inspector/InspectorMetaAgent.cpp	2011-11-29 15:16:22 UTC (rev 101373)
@@ -60,7 +60,7 @@
 RefPtrInspectorObject domainDescriptor = InspectorObject::create();
 domainDescriptor-setString(domainName, agent-name());
 RefPtrInspectorArray agentCapabilities = InspectorArray::create();
-agent-getCapabilities(agentCapabilities.get());
+agent-getAgentCapabilities(agentCapabilities.get());
 domainDescriptor-setArray(capabilities, agentCapabilities);
 (*capabilities)-pushObject(domainDescriptor);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101376] trunk/Source/WebCore

[hausmann]

Title: [101376] trunk/Source/WebCore








Revision 101376
Author hausm...@webkit.org
Date 2011-11-29 07:37:51 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Make WebCore compile with Qt 5 and V8
https://bugs.webkit.org/show_bug.cgi?id=73313

Reviewed by Tor Arne Vestbø.

* DerivedSources.pri: Add missing V8 specific IDL files to the build.
* Target.pri: Ditto.
* bindings/v8/ScriptController.h: V8 NPAPI bindings don't really support
building with ENABLE_NETSCAPE_PLUGIN_API=0. These functions are always
defined, so they also need to be declared.
* platform/qt/PlatformSupportQt.cpp:
(WebCore::PlatformSupport::pluginScriptableObject): Don't return a
scriptable object when compiling without npapi.
* storage/StorageAreaImpl.cpp: Add missing Document.h include that is
included implicitly with the Chromium build but not with Qt.
* xml/XSLTProcessorQt.cpp: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/platform/qt/PlatformSupportQt.cpp
trunk/Source/WebCore/storage/StorageAreaImpl.cpp
trunk/Source/WebCore/xml/XSLTProcessorQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101375 => 101376)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 15:33:10 UTC (rev 101375)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 15:37:51 UTC (rev 101376)
@@ -1,3 +1,22 @@
+2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Make WebCore compile with Qt 5 and V8
+https://bugs.webkit.org/show_bug.cgi?id=73313
+
+Reviewed by Tor Arne Vestbø.
+
+* DerivedSources.pri: Add missing V8 specific IDL files to the build.
+* Target.pri: Ditto.
+* bindings/v8/ScriptController.h: V8 NPAPI bindings don't really support
+building with ENABLE_NETSCAPE_PLUGIN_API=0. These functions are always
+defined, so they also need to be declared.
+* platform/qt/PlatformSupportQt.cpp: 
+(WebCore::PlatformSupport::pluginScriptableObject): Don't return a
+scriptable object when compiling without npapi.
+* storage/StorageAreaImpl.cpp: Add missing Document.h include that is
+included implicitly with the Chromium build but not with Qt.
+* xml/XSLTProcessorQt.cpp: Ditto.
+
 2011-11-29  Pavel Feldman  pfeld...@google.com
 
 Not reviewed: fixing clang build.


Modified: trunk/Source/WebCore/DerivedSources.pri (101375 => 101376)

--- trunk/Source/WebCore/DerivedSources.pri	2011-11-29 15:33:10 UTC (rev 101375)
+++ trunk/Source/WebCore/DerivedSources.pri	2011-11-29 15:37:51 UTC (rev 101376)
@@ -225,6 +225,8 @@
 html/canvas/WebGLBuffer.idl \
 html/canvas/WebGLContextAttributes.idl \
 html/canvas/WebGLContextEvent.idl \
+html/canvas/WebGLDebugRendererInfo.idl \
+html/canvas/WebGLDebugShaders.idl \
 html/canvas/WebGLFramebuffer.idl \
 html/canvas/WebGLProgram.idl \
 html/canvas/WebGLRenderbuffer.idl \


Modified: trunk/Source/WebCore/Target.pri (101375 => 101376)

--- trunk/Source/WebCore/Target.pri	2011-11-29 15:33:10 UTC (rev 101375)
+++ trunk/Source/WebCore/Target.pri	2011-11-29 15:37:51 UTC (rev 101376)
@@ -3648,8 +3648,11 @@
 platform/graphics/gpu/DrawingBuffer.h \
 platform/graphics/qt/Extensions3DQt.h
 
-!v8 {
+v8 {
 SOURCES += \
+bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
+} else {
+SOURCES += \
 bindings/js/JSWebGLRenderingContextCustom.cpp
 }
 


Modified: trunk/Source/WebCore/bindings/v8/ScriptController.h (101375 => 101376)

--- trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-11-29 15:33:10 UTC (rev 101375)
+++ trunk/Source/WebCore/bindings/v8/ScriptController.h	2011-11-29 15:37:51 UTC (rev 101376)
@@ -175,10 +175,8 @@
 void updatePlatformScriptObjects();
 void cleanupScriptObjectsForPlugin(Widget*);
 
-#if ENABLE(NETSCAPE_PLUGIN_API)
 NPObject* createScriptObjectForPluginElement(HTMLPlugInElement*);
 NPObject* windowScriptNPObject();
-#endif
 
 #if PLATFORM(QT)
 QJSEngine* qtScriptEngine();
@@ -207,7 +205,6 @@
 // invalidate all sub-objects which are associated with that plugin.
 // The frame keeps a NPObject reference for each item on the list.
 PluginObjectMap m_pluginObjects;
-#if ENABLE(NETSCAPE_PLUGIN_API)
 // The window script object can get destroyed while there are outstanding
 // references to it. Please refer to ScriptController::clearScriptObjects
 // for more information as to why this is necessary. To avoid crashes due
@@ -216,7 +213,6 @@
 // pointer in this object is cleared out when the window object is
 // destroyed.
 NPObject* m_wrappedWindowScriptNPObject;
-#endif
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/qt/PlatformSupportQt.cpp (101375 => 101376)

--- trunk/Source/WebCore/platform/qt/PlatformSupportQt.cpp	2011-11-29 15:33:10 UTC (rev 101375)
+++ 

[webkit-changes] [101377] trunk/LayoutTests

[mrobinson]

Title: [101377] trunk/LayoutTests








Revision 101377
Author mrobin...@webkit.org
Date 2011-11-29 07:40:38 -0800 (Tue, 29 Nov 2011)


Log Message
Finish up some miscellaneous GTK+ rebaselines after font metrics changes.

* platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
* platform/gtk/transforms/2d/hindi-rotated-expected.txt:
* platform/gtk/transforms/2d/transform-borderbox-expected.txt:
* platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
* platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
* platform/gtk/transforms/2d/zoom-menulist-expected.txt:
* platform/gtk/transforms/no_transform_hit_testing-expected.txt:
* platform/gtk/transforms/svg-vs-css-expected.txt:
* platform/gtk/transitions/default-timing-function-expected.txt:
* platform/gtk/transitions/move-after-transition-expected.txt:
* platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt
trunk/LayoutTests/platform/gtk/transforms/2d/hindi-rotated-expected.txt
trunk/LayoutTests/platform/gtk/transforms/2d/transform-borderbox-expected.txt
trunk/LayoutTests/platform/gtk/transforms/2d/transform-fixed-container-expected.txt
trunk/LayoutTests/platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt
trunk/LayoutTests/platform/gtk/transforms/2d/zoom-menulist-expected.txt
trunk/LayoutTests/platform/gtk/transforms/no_transform_hit_testing-expected.txt
trunk/LayoutTests/platform/gtk/transforms/svg-vs-css-expected.txt
trunk/LayoutTests/platform/gtk/transitions/default-timing-function-expected.txt
trunk/LayoutTests/platform/gtk/transitions/move-after-transition-expected.txt
trunk/LayoutTests/platform/gtk/transitions/svg-text-shadow-transition-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101376 => 101377)

--- trunk/LayoutTests/ChangeLog	2011-11-29 15:37:51 UTC (rev 101376)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 15:40:38 UTC (rev 101377)
@@ -1,5 +1,21 @@
 2011-11-29  Martin Robinson  mrobin...@igalia.com
 
+Finish up some miscellaneous GTK+ rebaselines after font metrics changes.
+
+* platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
+* platform/gtk/transforms/2d/hindi-rotated-expected.txt:
+* platform/gtk/transforms/2d/transform-borderbox-expected.txt:
+* platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
+* platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
+* platform/gtk/transforms/2d/zoom-menulist-expected.txt:
+* platform/gtk/transforms/no_transform_hit_testing-expected.txt:
+* platform/gtk/transforms/svg-vs-css-expected.txt:
+* platform/gtk/transitions/default-timing-function-expected.txt:
+* platform/gtk/transitions/move-after-transition-expected.txt:
+* platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
+
+2011-11-29  Martin Robinson  mrobin...@igalia.com
+
 Finish rebaselining table GTK+ results after metrics changes.
 
 * platform/gtk/tables: Finish rebaselining tables.


Modified: trunk/LayoutTests/platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt (101376 => 101377)

--- trunk/LayoutTests/platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt	2011-11-29 15:37:51 UTC (rev 101376)
+++ trunk/LayoutTests/platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt	2011-11-29 15:40:38 UTC (rev 101377)
@@ -1,43 +1,43 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x558
-  RenderBlock {HTML} at (0,0) size 800x558
-RenderBody {BODY} at (8,16) size 784x522
-  RenderBlock {P} at (0,0) size 784x38
-RenderText {#text} at (0,0) size 769x38
-  text run at (0,0) width 769: Test ensures that nested transformed elements produce the same result as a single compound transform.You should not see
-  text run at (0,19) width 188: any red in the two tests below
-layer at (78,74) size 402x222
-  RenderBlock (relative positioned) {DIV} at (20,58) size 402x222 [border: (1px solid #00)]
-RenderBlock {P} at (1,17) size 400x19
-  RenderText {#text} at (0,0) size 86x19
-text run at (0,0) width 86: Translate first
-layer at (79,126) size 80x80
-  RenderBlock (positioned) {DIV} at (1,52) size 80x80
-layer at (79,126) size 80x80
+layer at (0,0) size 800x556
+  RenderBlock {HTML} at (0,0) size 800x556
+RenderBody {BODY} at (8,16) size 784x520
+  RenderBlock {P} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 762x35
+  text run at (0,0) width 762: Test ensures that nested transformed elements produce the same result as a single compound transform.You should not
+  text run at (0,18) width 216: see any red in the two tests below
+layer at (78,72) size 402x222
+  RenderBlock 

[webkit-changes] [101378] trunk/LayoutTests

[senorblanco]

Title: [101378] trunk/LayoutTests








Revision 101378
Author senorbla...@chromium.org
Date 2011-11-29 07:49:04 -0800 (Tue, 29 Nov 2011)


Log Message
[chromium] Unreviewed; new baselines for new test added in r101325.

* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium-win/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
* platform/chromium/platform/chromium/compositing/accelerated-drawing: Added.
* platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/
trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/
trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/accelerated-drawing/
trunk/LayoutTests/platform/chromium-win/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (101377 => 101378)

--- trunk/LayoutTests/ChangeLog	2011-11-29 15:40:38 UTC (rev 101377)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 15:49:04 UTC (rev 101378)
@@ -1,3 +1,17 @@
+2011-11-29  Stephen White  senorbla...@chromium.org
+
+[chromium] Unreviewed; new baselines for new test added in r101325.
+
+* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
+* platform/chromium-cg-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing: Added.
+* platform/chromium-mac-snowleopard/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
+* platform/chromium-win/platform/chromium/compositing/accelerated-drawing: Added.
+* platform/chromium-win/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Added.
+* platform/chromium/platform/chromium/compositing/accelerated-drawing: Added.
+* platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-11-29  Martin Robinson  mrobin...@igalia.com
 
 Finish up some miscellaneous GTK+ rebaselines after font metrics changes.


Added: trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt (0 => 101378)

--- trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt	2011-11-29 15:49:04 UTC (rev 101378)
@@ -0,0 +1 @@
+
Property changes on: trunk/LayoutTests/platform/chromium/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.txt
___


Added: svn:eol-style

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101377 => 101378)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 15:40:38 UTC (rev 101377)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 15:49:04 UTC (rev 101378)
@@ -3840,9 +3840,6 @@
 BUGCR105025 MAC CPU GPU : fast/canvas/webgl/css-webkit-canvas.html = IMAGE
 BUGCR105025 MAC CPU GPU : fast/canvas/webgl/css-webkit-canvas-repaint.html = IMAGE
 
-// New test; needs new baselines.
-BUG_SENORBLANCO : platform/chromium/compositing/accelerated-drawing/svg-filters.html = MISSING
-
 BUGWK73227 : fast/dom/clone-node-style.html = CRASH PASS
 BUGWK73250 DEBUG : fast/block/child-not-removed-from-parent-lineboxes-crash.html = CRASH PASS
 


Added: 

[webkit-changes] [101379] trunk/Source/WebKit/gtk

[mrobinson]

Title: [101379] trunk/Source/WebKit/gtk








Revision 101379
Author mrobin...@webkit.org
Date 2011-11-29 07:49:58 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] Custom fonts on surlybikes.com and boingboing.net do not load
https://bugs.webkit.org/show_bug.cgi?id=69115

Reviewed by Gustavo Noronha Silva.

Instead of pretending to be Safari/Linux, pretend to be a Linux Chrome.
This fixes pages that assume that if a browser is Safari, but not OS X, it is
the iOS version of Safari.

* tests/testwebsettings.c:
(test_webkit_web_settings_user_agent): Update the test to reflect that the
user agent does not change.
* webkit/webkitwebsettings.cpp:
(chromeUserAgent): Renamed this from webkitUserAgent to more accurately
describe what it is.
(webkit_web_settings_class_init): Just use an empty string when initializing
the user agent to reduce code duplication.
(webkit_web_settings_set_property): Updated to reflect new method name.
(userAgentForURL): We don't need to special case Google Calendar any longer.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/tests/testwebsettings.c
trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (101378 => 101379)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 15:49:04 UTC (rev 101378)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 15:49:58 UTC (rev 101379)
@@ -1,3 +1,25 @@
+2011-11-29  Martin Robinson  mrobin...@igalia.com
+
+[GTK] Custom fonts on surlybikes.com and boingboing.net do not load
+https://bugs.webkit.org/show_bug.cgi?id=69115
+
+Reviewed by Gustavo Noronha Silva.
+
+Instead of pretending to be Safari/Linux, pretend to be a Linux Chrome.
+This fixes pages that assume that if a browser is Safari, but not OS X, it is
+the iOS version of Safari.
+
+* tests/testwebsettings.c:
+(test_webkit_web_settings_user_agent): Update the test to reflect that the
+user agent does not change.
+* webkit/webkitwebsettings.cpp:
+(chromeUserAgent): Renamed this from webkitUserAgent to more accurately
+describe what it is.
+(webkit_web_settings_class_init): Just use an empty string when initializing
+the user agent to reduce code duplication.
+(webkit_web_settings_set_property): Updated to reflect new method name.
+(userAgentForURL): We don't need to special case Google Calendar any longer.
+
 2011-11-29  Mario Sanchez Prada  msanc...@igalia.com
 
 [Gtk] Regression: text-inserted events lack text inserted and current line


Modified: trunk/Source/WebKit/gtk/tests/testwebsettings.c (101378 => 101379)

--- trunk/Source/WebKit/gtk/tests/testwebsettings.c	2011-11-29 15:49:04 UTC (rev 101378)
+++ trunk/Source/WebKit/gtk/tests/testwebsettings.c	2011-11-29 15:49:58 UTC (rev 101379)
@@ -139,10 +139,6 @@
 g_assert_cmpstr(userAgent, ==, testwebsettings/0.1);
 g_free(userAgent);
 
-userAgent = webkitWebSettingsUserAgentForURI(settings, http://calendar.google.com/);
-g_assert(g_str_has_prefix(userAgent, Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en_US) AppleWebKit/));
-g_free(userAgent);
-
 g_free(defaultUserAgent);
 g_object_unref(webView);
 }


Modified: trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp (101378 => 101379)

--- trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp	2011-11-29 15:49:04 UTC (rev 101378)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp	2011-11-29 15:49:58 UTC (rev 101379)
@@ -172,30 +172,20 @@
 return uaOSVersion;
 }
 
-static String webkitUserAgent()
+static String chromeUserAgent()
 {
 // We mention Safari since many broken sites check for it (OmniWeb does this too)
 // We re-use the WebKit version, though it doesn't seem to matter much in practice
+// We claim to be Chrome as well, which prevents sites that look for Safari and assume
+// that since we are not OS X, that we are the mobile version of Safari.
 
 DEFINE_STATIC_LOCAL(const String, uaVersion, (makeString(String::number(WEBKIT_USER_AGENT_MAJOR_VERSION), '.', String::number(WEBKIT_USER_AGENT_MINOR_VERSION), '+')));
 DEFINE_STATIC_LOCAL(const String, staticUA, (makeString(Mozilla/5.0 (, webkitPlatform(), webkitOSVersion(), ) AppleWebKit/, uaVersion) +
- makeString( (KHTML, like Gecko) Version/5.0 Safari/, uaVersion)));
+ makeString( (KHTML, like Gecko) Chromium/15.0.874.120 Chrome/15.0.874.120 Safari/, uaVersion)));
 
 return staticUA;
 }
 
-static String safariUserAgent()
-{
-// We mention Safari since many broken sites check for it (OmniWeb does this too)
-// We re-use the WebKit version, though it doesn't seem to matter much in practice
-
-DEFINE_STATIC_LOCAL(const String, uaVersion, (makeString(String::number(WEBKIT_USER_AGENT_MAJOR_VERSION), '.', String::number(WEBKIT_USER_AGENT_MINOR_VERSION), '+')));
-

[webkit-changes] [101380] trunk/Source/WebKit2

[kenneth]

Title: [101380] trunk/Source/WebKit2








Revision 101380
Author kenn...@webkit.org
Date 2011-11-29 07:56:04 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Add the infrastructure for enabling suspend/resume.

Reviewed by Simon Hausmann.

Also, remove the painting optimization as it is broken in some
situations, as there is an assumption in that comparison that
the guards cannot be nested, which goes against the design and
its use.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_suspend):
(QQuickWebViewPrivate::_q_resume):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
(WebKit::QtViewportInteractionEngine::scrollStateChanged):
(WebKit::QtViewportInteractionEngine::event):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::reset):
(WebKit::QtViewportInteractionEngine::applyConstraints):
(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::panGestureEnded):
(WebKit::QtViewportInteractionEngine::pinchGestureActive):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::itemSizeChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp
trunk/Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (101379 => 101380)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 15:49:58 UTC (rev 101379)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 15:56:04 UTC (rev 101380)
@@ -1,3 +1,41 @@
+2011-11-29  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Add the infrastructure for enabling suspend/resume.
+
+Reviewed by Simon Hausmann.
+
+Also, remove the painting optimization as it is broken in some
+situations, as there is an assumption in that comparison that
+the guards cannot be nested, which goes against the design and
+its use.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::initializeDesktop):
+(QQuickWebViewPrivate::initializeTouch):
+(QQuickWebViewPrivate::_q_suspend):
+(QQuickWebViewPrivate::_q_resume):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/qquickwebview_p_p.h:
+* UIProcess/qt/QtViewportInteractionEngine.cpp:
+(WebKit::ViewportUpdateGuard::ViewportUpdateGuard):
+(WebKit::ViewportUpdateGuard::~ViewportUpdateGuard):
+(WebKit::QtViewportInteractionEngine::QtViewportInteractionEngine):
+(WebKit::QtViewportInteractionEngine::scaleAnimationStateChanged):
+(WebKit::QtViewportInteractionEngine::scrollStateChanged):
+(WebKit::QtViewportInteractionEngine::event):
+(WebKit::QtViewportInteractionEngine::pagePositionRequest):
+(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
+(WebKit::QtViewportInteractionEngine::reset):
+(WebKit::QtViewportInteractionEngine::applyConstraints):
+(WebKit::QtViewportInteractionEngine::panGestureRequestUpdate):
+(WebKit::QtViewportInteractionEngine::panGestureEnded):
+(WebKit::QtViewportInteractionEngine::pinchGestureActive):
+(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
+(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
+(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
+(WebKit::QtViewportInteractionEngine::itemSizeChanged):
+* UIProcess/qt/QtViewportInteractionEngine.h:
+
 2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add WebKitURIResponse to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (101379 => 101380)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-29 15:49:58 UTC (rev 101379)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-11-29 15:56:04 UTC (rev 101380)
@@ -87,7 +87,8 @@
 void QQuickWebViewPrivate::initializeDesktop(QQuickWebView* viewport)
 {
 if (interactionEngine) {
-QObject::disconnect(interactionEngine.data(), SIGNAL(viewportUpdateRequested()), 

[webkit-changes] [101381] trunk

[pfeldman]

Title: [101381] trunk








Revision 101381
Author pfeld...@chromium.org
Date 2011-11-29 08:01:30 -0800 (Tue, 29 Nov 2011)


Log Message
Web Inspector: split Preferences into Preferences and Capabilities.
https://bugs.webkit.org/show_bug.cgi?id=73321

Source/WebCore:

Part of the Preferences defined in Settings.js are in fact backend capabilities.
Split them into two separate objects for further capabilities refactoring.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerModel.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
* inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkLogView.prototype._contextMenu):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._enableDetailedHeapProfiles):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.populateImageSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/inspector.js:

Source/WebKit/chromium:

Reviewed by Yury Semikhatsky.

* src/js/DevTools.js:

Modified Paths

trunk/LayoutTests/inspector/profiler/detailed-heapshots-test.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DebuggerModel.js
trunk/Source/WebCore/inspector/front-end/ElementsPanel.js
trunk/Source/WebCore/inspector/front-end/NetworkItemView.js
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js
trunk/Source/WebCore/inspector/front-end/ProfileDataGridTree.js
trunk/Source/WebCore/inspector/front-end/ProfileView.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/Resource.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
trunk/Source/WebCore/inspector/front-end/Settings.js
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js
trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js
trunk/Source/WebCore/inspector/front-end/inspector.js
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/js/DevTools.js




Diff

Modified: trunk/LayoutTests/inspector/profiler/detailed-heapshots-test.js (101380 => 101381)

--- trunk/LayoutTests/inspector/profiler/detailed-heapshots-test.js	2011-11-29 15:56:04 UTC (rev 101380)
+++ trunk/LayoutTests/inspector/profiler/detailed-heapshots-test.js	2011-11-29 16:01:30 UTC (rev 101381)
@@ -13,7 +13,7 @@
 InspectorTest._panelReset = InspectorTest.override(WebInspector.panels.profiles, _reset, function(){}, true);
 InspectorTest.addSniffer(WebInspector.DetailedHeapshotView.prototype, _updatePercentButton, InspectorTest._snapshotViewShown, true);
 
-if (Preferences.detailedHeapProfiles)
+if (Capabilities.detailedHeapProfiles)
 detailedHeapProfilesEnabled();
 else {
 InspectorTest.addSniffer(WebInspector.panels.profiles, _populateProfiles, detailedHeapProfilesEnabled);
@@ -62,7 +62,7 @@
 
 InspectorTest.runDetailedHeapshotTestSuite = function(testSuite)
 {
-if (!Preferences.heapProfilerPresent) {
+if (!Capabilities.heapProfilerPresent) {
 InspectorTest.addResult(Heap profiler is disabled);
 InspectorTest.completeTest();
 return;


Modified: trunk/Source/WebCore/ChangeLog (101380 => 101381)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 15:56:04 UTC (rev 101380)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 16:01:30 UTC (rev 101381)
@@ -1,3 +1,43 @@
+2011-11-29  Pavel Feldman  pfeld...@google.com
+
+Web Inspector: split Preferences into Preferences and Capabilities.
+https://bugs.webkit.org/show_bug.cgi?id=73321
+
+Part of the Preferences defined in Settings.js are in fact backend capabilities.
+Split them into two separate objects for further capabilities refactoring.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DebuggerModel.js:
+* inspector/front-end/ElementsPanel.js:
+(WebInspector.ElementsPanel):
+(WebInspector.ElementsPanel.prototype.wasShown):
+(WebInspector.ElementsPanel.prototype._populateContextMenu):
+* inspector/front-end/NetworkItemView.js:
+(WebInspector.NetworkItemView):

[webkit-changes] [101382] trunk/Tools

[hausmann]

Title: [101382] trunk/Tools








Revision 101382
Author hausm...@webkit.org
Date 2011-11-29 08:10:05 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Fix debug-shlib build without webkit2

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/qtwebkit.prf




Diff

Modified: trunk/Tools/ChangeLog (101381 => 101382)

--- trunk/Tools/ChangeLog	2011-11-29 16:01:30 UTC (rev 101381)
+++ trunk/Tools/ChangeLog	2011-11-29 16:10:05 UTC (rev 101382)
@@ -1,3 +1,11 @@
+2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Fix debug-shlib build without webkit2
+
+Reviewed by Tor Arne Vestbø.
+
+* qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
+
 2011-11-28  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2] Unreviewed buildfix after r101307.


Modified: trunk/Tools/qmake/mkspecs/features/qtwebkit.prf (101381 => 101382)

--- trunk/Tools/qmake/mkspecs/features/qtwebkit.prf	2011-11-29 16:01:30 UTC (rev 101381)
+++ trunk/Tools/qmake/mkspecs/features/qtwebkit.prf	2011-11-29 16:10:05 UTC (rev 101382)
@@ -27,7 +27,8 @@
 INCLUDEPATH += $${ROOT_BUILD_DIR}/include/QtWebKit
 
 force_static_libs_as_shared {
-LIBS += -lwebkit2 -lwebcore -ljscore -lwtf
+!no_webkit2: LIBS += -lwebkit2
+LIBS += -lwebcore -ljscore -lwtf
 }
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101383] trunk/Source

[carlosgc]

Title: [101383] trunk/Source








Revision 101383
Author carlo...@webkit.org
Date 2011-11-29 08:12:09 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed. Fix the GTK+ port build after r101307.

Source/WebCore:

* GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

* GNUmakefile.am: Add missing files to compilation.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (101382 => 101383)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 16:10:05 UTC (rev 101382)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 16:12:09 UTC (rev 101383)
@@ -1,3 +1,9 @@
+2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix the GTK+ port build after r101307.
+
+* GNUmakefile.list.am: Add missing files to compilation.
+
 2011-11-29  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: split Preferences into Preferences and Capabilities.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (101382 => 101383)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-11-29 16:10:05 UTC (rev 101382)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-11-29 16:12:09 UTC (rev 101383)
@@ -2299,6 +2299,8 @@
 	Source/WebCore/notifications/NotificationCenter.cpp \
 	Source/WebCore/notifications/NotificationCenter.h \
 	Source/WebCore/notifications/NotificationContents.h \
+	Source/WebCore/notifications/NotificationController.cpp \
+	Source/WebCore/notifications/NotificationController.h \
 	Source/WebCore/notifications/Notification.cpp \
 	Source/WebCore/notifications/Notification.h \
 	Source/WebCore/notifications/NotificationPresenter.h \


Modified: trunk/Source/WebKit2/ChangeLog (101382 => 101383)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 16:10:05 UTC (rev 101382)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 16:12:09 UTC (rev 101383)
@@ -1,3 +1,9 @@
+2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix the GTK+ port build after r101307.
+
+* GNUmakefile.am: Add missing files to compilation.
+
 2011-11-29  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Add the infrastructure for enabling suspend/resume.


Modified: trunk/Source/WebKit2/GNUmakefile.am (101382 => 101383)

--- trunk/Source/WebKit2/GNUmakefile.am	2011-11-29 16:10:05 UTC (rev 101382)
+++ trunk/Source/WebKit2/GNUmakefile.am	2011-11-29 16:12:09 UTC (rev 101383)
@@ -57,6 +57,9 @@
 	$(WebKit2)/UIProcess/API/C/WKInspector.h \
 	$(WebKit2)/UIProcess/API/C/WKKeyValueStorageManager.h \
 	$(WebKit2)/UIProcess/API/C/WKMediaCacheManager.h \
+	$(WebKit2)/UIProcess/API/C/WKNotification.h \
+	$(WebKit2)/UIProcess/API/C/WKNotificationManager.h \
+	$(WebKit2)/UIProcess/API/C/WKNotificationProvider.h \
 	$(WebKit2)/UIProcess/API/C/WKNativeEvent.h \
 	$(WebKit2)/UIProcess/API/C/WKNavigationData.h \
 	$(WebKit2)/UIProcess/API/C/WKOpenPanelParameters.h \
@@ -147,6 +150,8 @@
 	DerivedSources/WebKit2/WebMediaCacheManagerMessages.h \
 	DerivedSources/WebKit2/WebMediaCacheManagerProxyMessageReceiver.cpp \
 	DerivedSources/WebKit2/WebMediaCacheManagerProxyMessages.h \
+	DerivedSources/WebKit2/WebNotificationManagerProxyMessageReceiver.cpp \
+	DerivedSources/WebKit2/WebNotificationManagerProxyMessages.h \
 	DerivedSources/WebKit2/WebPageProxyMessageReceiver.cpp \
 	DerivedSources/WebKit2/WebPageProxyMessages.h \
 	DerivedSources/WebKit2/WebPageMessageReceiver.cpp \
@@ -471,6 +476,11 @@
 	Source/WebKit2/UIProcess/API/C/WKNativeEvent.h \
 	Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp \
 	Source/WebKit2/UIProcess/API/C/WKNavigationData.h \
+	Source/WebKit2/UIProcess/API/C/WKNotification.cpp \
+	Source/WebKit2/UIProcess/API/C/WKNotification.h \
+	Source/WebKit2/UIProcess/API/C/WKNotificationManager.cpp \
+	Source/WebKit2/UIProcess/API/C/WKNotificationManager.h \
+	Source/WebKit2/UIProcess/API/C/WKNotificationProvider.h \
 	Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp \
 	Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.h \
 	Source/WebKit2/UIProcess/API/C/WKOpenPanelResultListener.cpp \
@@ -642,6 +652,12 @@
 	Source/WebKit2/UIProcess/WebKeyValueStorageManagerProxy.h \
 	Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp \
 	Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h \
+	Source/WebKit2/UIProcess/WebNotification.cpp \
+	Source/WebKit2/UIProcess/WebNotification.h \
+	Source/WebKit2/UIProcess/WebNotificationManagerProxy.cpp \
+	Source/WebKit2/UIProcess/WebNotificationManagerProxy.h \
+	Source/WebKit2/UIProcess/WebNotificationProvider.cpp \
+	Source/WebKit2/UIProcess/WebNotificationProvider.h \
 	Source/WebKit2/UIProcess/WebLoaderClient.cpp \
 	Source/WebKit2/UIProcess/WebLoaderClient.h \
 	Source/WebKit2/UIProcess/WebNavigationData.cpp \
@@ -772,6 +788,8 @@
 	Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.h \
 	Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp \
 	

[webkit-changes] [101384] trunk/Tools

[vestbo]

Title: [101384] trunk/Tools








Revision 101384
Author ves...@webkit.org
Date 2011-11-29 08:18:13 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Remove use of internal headers in the MiniBrowser

Reviewed by Simon Hausmann.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowser.pro




Diff

Modified: trunk/Tools/ChangeLog (101383 => 101384)

--- trunk/Tools/ChangeLog	2011-11-29 16:12:09 UTC (rev 101383)
+++ trunk/Tools/ChangeLog	2011-11-29 16:18:13 UTC (rev 101384)
@@ -1,3 +1,11 @@
+2011-11-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Remove use of internal headers in the MiniBrowser
+
+Reviewed by Simon Hausmann.
+
+* MiniBrowser/qt/MiniBrowser.pro:
+
 2011-11-29  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Fix debug-shlib build without webkit2


Modified: trunk/Tools/MiniBrowser/qt/MiniBrowser.pro (101383 => 101384)

--- trunk/Tools/MiniBrowser/qt/MiniBrowser.pro	2011-11-29 16:12:09 UTC (rev 101383)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowser.pro	2011-11-29 16:18:13 UTC (rev 101384)
@@ -22,13 +22,8 @@
 TARGET = MiniBrowser
 DESTDIR = $${ROOT_BUILD_DIR}/bin
 
-CONFIG += qtwebkit
+CONFIG += qtwebkit qtwebkit-private
 
-# FIXME: When webkit-private works let's use it.
-load(_javascript_core)
-load(webcore)
-load(webkit2)
-
 QT += network declarative widgets
 macx: QT += xml
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101385] trunk/Source/WebCore

[vsevik]

Title: [101385] trunk/Source/WebCore








Revision 101385
Author vse...@chromium.org
Date 2011-11-29 08:24:47 -0800 (Tue, 29 Nov 2011)


Log Message
Web Inspector: TextPrompt should show suggest above or under so that it has maximal height.
https://bugs.webkit.org/show_bug.cgi?id=73239

Reviewed by Pavel Feldman.

Fixed suggest box vertical position / height calculation.
Added round corners when suggest box is positioned under text prompt.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
* inspector/front-end/inspector.css:
(.suggest-box.generic-suggest.under-anchor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/TextPrompt.js
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (101384 => 101385)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 16:18:13 UTC (rev 101384)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 16:24:47 UTC (rev 101385)
@@ -1,3 +1,18 @@
+2011-11-28  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: TextPrompt should show suggest above or under so that it has maximal height.
+https://bugs.webkit.org/show_bug.cgi?id=73239
+
+Reviewed by Pavel Feldman.
+
+Fixed suggest box vertical position / height calculation.
+Added round corners when suggest box is positioned under text prompt.
+
+* inspector/front-end/TextPrompt.js:
+(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
+* inspector/front-end/inspector.css:
+(.suggest-box.generic-suggest.under-anchor):
+
 2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Fix the GTK+ port build after r101307.


Modified: trunk/Source/WebCore/inspector/front-end/TextPrompt.js (101384 => 101385)

--- trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2011-11-29 16:18:13 UTC (rev 101384)
+++ trunk/Source/WebCore/inspector/front-end/TextPrompt.js	2011-11-29 16:24:47 UTC (rev 101385)
@@ -897,37 +897,38 @@
 
 // Lay out the suggest-box relative to the anchorBox.
 this._anchorBox = anchorBox;
+const spacer = 6;
+
 const suggestBoxPaddingX = 21;
-const suggestBoxPaddingY = 2;
-const spacer = 6;
-const minHeight = 25;
 var maxWidth = document.body.offsetWidth - anchorBox.x - spacer;
 var width = Math.min(contentWidth, maxWidth - suggestBoxPaddingX) + suggestBoxPaddingX;
-
-var maxHeight = document.body.offsetHeight - anchorBox.y - anchorBox.height - spacer;
 var paddedWidth = contentWidth + suggestBoxPaddingX;
-var paddedHeight = contentHeight + suggestBoxPaddingY;
-var height = Math.min(paddedHeight, maxHeight);
 var boxX = anchorBox.x;
+if (width  paddedWidth) {
+// Shift the suggest box to the left to accommodate the content without trimming to the BODY edge.
+maxWidth = document.body.offsetWidth - spacer;
+width = Math.min(contentWidth, maxWidth - suggestBoxPaddingX) + suggestBoxPaddingX;
+boxX = document.body.offsetWidth - width;
+}
+
+const suggestBoxPaddingY = 2;
 var boxY;
-if (height = minHeight || height === paddedHeight) {
+var aboveHeight = anchorBox.y;
+var underHeight = document.body.offsetHeight - anchorBox.y - anchorBox.height;
+var maxHeight = Math.max(underHeight, aboveHeight) - spacer;
+height = Math.min(contentHeight, maxHeight - suggestBoxPaddingY) + suggestBoxPaddingY;
+if (underHeight = aboveHeight) {
 // Locate the suggest box under the anchorBox.
 boxY = anchorBox.y + anchorBox.height;
 this._element.removeStyleClass(above-anchor);
+this._element.addStyleClass(under-anchor);
 } else {
 // Locate the suggest box above the anchorBox.
-maxHeight = anchorBox.y - spacer;
-height = Math.min(contentHeight, maxHeight - suggestBoxPaddingY) + suggestBoxPaddingY;
 boxY = anchorBox.y - height;
+this._element.removeStyleClass(under-anchor);
 this._element.addStyleClass(above-anchor);
 }
 
-if (width  paddedWidth) {
-// Shift the suggest box to the left to accommodate the content without trimming to the BODY edge.
-maxWidth = document.body.offsetWidth - spacer;
-width = Math.min(contentWidth, maxWidth - suggestBoxPaddingX) + suggestBoxPaddingX;
-boxX = document.body.offsetWidth - width;
-}
 this._element.positionAt(boxX, boxY);
 this._element.style.width = width + px;
 this._element.style.height = height + px;


Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (101384 => 101385)

--- trunk/Source/WebCore/inspector/front-end/inspector.css	2011-11-29 16:18:13 UTC (rev 101384)
+++ 

[webkit-changes] [101390] trunk/LayoutTests

[senorblanco]

Title: [101390] trunk/LayoutTests








Revision 101390
Author senorbla...@chromium.org
Date 2011-11-29 09:21:56 -0800 (Tue, 29 Nov 2011)


Log Message
[chromium] Unreviewed test_expectations update (added a bug ID).

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101389 => 101390)

--- trunk/LayoutTests/ChangeLog	2011-11-29 17:10:40 UTC (rev 101389)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 17:21:56 UTC (rev 101390)
@@ -1,3 +1,9 @@
+2011-11-29  Stephen White  senorbla...@chromium.org
+
+[chromium] Unreviewed test_expectations update (added a bug ID).
+
+* platform/chromium/test_expectations.txt:
+
 2011-11-29  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed evening gardening.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101389 => 101390)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 17:10:40 UTC (rev 101389)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 17:21:56 UTC (rev 101390)
@@ -1748,8 +1748,8 @@
 BUGCR26291 : transforms/2d/hindi-rotated.html = IMAGE+TEXT IMAGE
 
 // I don't think we've ever passed this test correctly.
-BUG_SENORBLANCO WIN LINUX : fast/text/international/hindi-whitespace.html = IMAGE+TEXT
-BUG_SENORBLANCO LEOPARD : fast/text/international/hindi-whitespace.html = IMAGE PASS
+BUGWK73329 WIN LINUX : fast/text/international/hindi-whitespace.html = IMAGE+TEXT
+BUGWK73329 LEOPARD : fast/text/international/hindi-whitespace.html = IMAGE PASS
 
 // The following upstream patches add -Webkit-color-correction support:
 // http://trac.webkit.org/changeset/50760






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101391] trunk/LayoutTests

[philn]

Title: [101391] trunk/LayoutTests








Revision 101391
Author ph...@webkit.org
Date 2011-11-29 09:28:10 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, GTK svg/W3C-I18N rebaseline.

* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
* platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt
trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101390 => 101391)

--- trunk/LayoutTests/ChangeLog	2011-11-29 17:21:56 UTC (rev 101390)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 17:28:10 UTC (rev 101391)
@@ -1,3 +1,24 @@
+2011-11-29  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, GTK svg/W3C-I18N rebaseline.
+
+* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
+* platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
+
 2011-11-29  Stephen White  senorbla...@chromium.org
 
 [chromium] Unreviewed test_expectations update (added a bug ID).


Modified: trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt (101390 => 101391)

--- trunk/LayoutTests/platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt	2011-11-29 17:21:56 UTC (rev 101390)
+++ 

[webkit-changes] [101392] trunk

[philn]

Title: [101392] trunk








Revision 101392
Author ph...@webkit.org
Date 2011-11-29 09:34:50 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] hide WebAudio build option until support for FFTW is removed
https://bugs.webkit.org/show_bug.cgi?id=73295

Reviewed by Martin Robinson.

* configure.ac: Disable WebAudio until the FFTW dependency is removed.

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (101391 => 101392)

--- trunk/ChangeLog	2011-11-29 17:28:10 UTC (rev 101391)
+++ trunk/ChangeLog	2011-11-29 17:34:50 UTC (rev 101392)
@@ -1,3 +1,12 @@
+2011-11-29  Philippe Normand  pnorm...@igalia.com
+
+[GTK] hide WebAudio build option until support for FFTW is removed
+https://bugs.webkit.org/show_bug.cgi?id=73295
+
+Reviewed by Martin Robinson.
+
+* configure.ac: Disable WebAudio until the FFTW dependency is removed.
+
 2011-11-29  Hyowon Kim  hw1008@samsung.com
 
 [Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port


Modified: trunk/configure.ac (101391 => 101392)

--- trunk/configure.ac	2011-11-29 17:28:10 UTC (rev 101391)
+++ trunk/configure.ac	2011-11-29 17:34:50 UTC (rev 101392)
@@ -725,11 +725,7 @@
 AC_MSG_RESULT([$enable_web_sockets])
 
 # check whether to enable Web Audio support
-AC_MSG_CHECKING([whether to enable Web Audio support])
-AC_ARG_ENABLE(web_audio,
-  AC_HELP_STRING([--enable-web-audio],
- [enable support for Web Audio [default=no]]),
-  [],[enable_web_audio=no])
+enable_web_audio=no
 AC_MSG_RESULT([$enable_web_audio])
 
 # check whether to enable Web Timing support
@@ -1143,9 +1139,6 @@
 # GStreamer feature conditional
 AM_CONDITIONAL([USE_GSTREAMER], [test $have_gstreamer = yes])
 
-# Web Audio feature conditional
-AM_CONDITIONAL([USE_WEBAUDIO_FFTW], [test $have_fftw = yes])
-
 # WebKit feature conditionals
 AM_CONDITIONAL([ENABLE_DEBUG],[test $enable_debug_features = yes])
 AM_CONDITIONAL([ENABLE_3D_RENDERING],[test $enable_3d_rendering = yes])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101393] trunk/Source/WebKit/gtk

[sergio]

Title: [101393] trunk/Source/WebKit/gtk








Revision 101393
Author ser...@webkit.org
Date 2011-11-29 09:36:35 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] SIGSEV when a WebKitDownload fails
https://bugs.webkit.org/show_bug.cgi?id=72883

Reviewed by Xan Lopez.

After r100769 http status codes = 400 trigger download
failures. We must ensure that the download is properly cancelled
before clearing the ResourceHandle client to avoid crashes.

* webkit/webkitdownload.cpp:
(DownloadClient::didReceiveResponse):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (101392 => 101393)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 17:34:50 UTC (rev 101392)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 17:36:35 UTC (rev 101393)
@@ -1,3 +1,17 @@
+2011-11-29  Sergio Villar Senin  svil...@igalia.com
+
+[GTK] SIGSEV when a WebKitDownload fails
+https://bugs.webkit.org/show_bug.cgi?id=72883
+
+Reviewed by Xan Lopez.
+
+After r100769 http status codes = 400 trigger download
+failures. We must ensure that the download is properly cancelled
+before clearing the ResourceHandle client to avoid crashes.
+
+* webkit/webkitdownload.cpp:
+(DownloadClient::didReceiveResponse):
+
 2011-11-29  Martin Robinson  mrobin...@igalia.com
 
 [GTK] Custom fonts on surlybikes.com and boingboing.net do not load


Modified: trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp (101392 => 101393)

--- trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp	2011-11-29 17:34:50 UTC (rev 101392)
+++ trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp	2011-11-29 17:36:35 UTC (rev 101393)
@@ -941,6 +941,7 @@
 {
 webkit_download_set_response(m_download, response);
 if (response.httpStatusCode() = 400) {
+m_download-priv-resourceHandle-cancel();
 webkit_download_error(m_download, ResourceError(errorDomainDownload, response.httpStatusCode(),
 response.url().string(), response.httpStatusText()));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101394] trunk/Source/WebCore

[philn]

Title: [101394] trunk/Source/WebCore








Revision 101394
Author ph...@webkit.org
Date 2011-11-29 09:53:17 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, GTK build fix after r101392.

* GNUmakefile.am: USE_WEBAUDIO_FFTW was removed, don't use it anymore.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (101393 => 101394)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 17:36:35 UTC (rev 101393)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 17:53:17 UTC (rev 101394)
@@ -1,3 +1,9 @@
+2011-11-29  Philippe Normand  pnorm...@igalia.com
+
+Unreviewed, GTK build fix after r101392.
+
+* GNUmakefile.am: USE_WEBAUDIO_FFTW was removed, don't use it anymore.
+
 2011-11-28  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: TextPrompt should show suggest above or under so that it has maximal height.


Modified: trunk/Source/WebCore/GNUmakefile.am (101393 => 101394)

--- trunk/Source/WebCore/GNUmakefile.am	2011-11-29 17:36:35 UTC (rev 101393)
+++ trunk/Source/WebCore/GNUmakefile.am	2011-11-29 17:53:17 UTC (rev 101394)
@@ -509,16 +509,8 @@
 if ENABLE_WEB_AUDIO
 FEATURE_DEFINES += ENABLE_WEB_AUDIO=1
 webcore_cppflags += -DENABLE_WEB_AUDIO=1
-
-if USE_WEBAUDIO_FFTW
-FEATURE_DEFINES += WTF_USE_WEBAUDIO_FFTW=1
-webcore_cppflags += -DWTF_USE_WEBAUDIO_FFTW=1
-webcore_sources += \
-	Source/WebCore/platform/audio/fftw/FFTFrameFFTW.cpp
 endif
 
-endif
-
 # 
 # Web Sockets Support
 # 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101396] trunk/Source/WebCore

[oliver]

Title: [101396] trunk/Source/WebCore








Revision 101396
Author oli...@apple.com
Date 2011-11-29 10:32:25 -0800 (Tue, 29 Nov 2011)


Log Message
DOM wrapper cache doesn't need to use JSDOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=7

Reviewed by Sam Weinig.

Make JSDOMWrapperCache use JSObject rather than JSDOMWrapper
and propagate the type change out.

* bindings/js/DOMWrapperWorld.h:
* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::toJSArrayBufferView):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::wrap):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::toJS):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSTrackCustom.cpp:
(WebCore::toJS):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h
trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h
trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp
trunk/Source/WebCore/bindings/js/JSEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLCollectionCustom.cpp
trunk/Source/WebCore/bindings/js/JSImageDataCustom.cpp
trunk/Source/WebCore/bindings/js/JSSVGPathSegCustom.cpp
trunk/Source/WebCore/bindings/js/JSStyleSheetCustom.cpp
trunk/Source/WebCore/bindings/js/JSTrackCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101395 => 101396)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 18:26:14 UTC (rev 101395)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 18:32:25 UTC (rev 101396)
@@ -1,3 +1,45 @@
+2011-11-29  Oliver Hunt  oli...@apple.com
+
+DOM wrapper cache doesn't need to use JSDOMWrapper
+https://bugs.webkit.org/show_bug.cgi?id=7
+
+Reviewed by Sam Weinig.
+
+Make JSDOMWrapperCache use JSObject rather than JSDOMWrapper
+and propagate the type change out. 
+
+* bindings/js/DOMWrapperWorld.h:
+* bindings/js/JSArrayBufferViewHelper.h:
+(WebCore::toJSArrayBufferView):
+* bindings/js/JSCSSRuleCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSCSSValueCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSDOMBinding.h:
+(WebCore::setInlineCachedWrapper):
+(WebCore::clearInlineCachedWrapper):
+(WebCore::getCachedWrapper):
+(WebCore::cacheWrapper):
+(WebCore::wrap):
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::JSDOMWindow::history):
+(WebCore::JSDOMWindow::location):
+* bindings/js/JSDocumentCustom.cpp:
+(WebCore::JSDocument::location):
+(WebCore::toJS):
+* bindings/js/JSEventCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSHTMLCollectionCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSImageDataCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSSVGPathSegCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSStyleSheetCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSTrackCustom.cpp:
+(WebCore::toJS):
+
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK build fix after r101392.


Modified: trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h (101395 => 101396)

--- trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 18:26:14 UTC (rev 101395)
+++ trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 18:32:25 UTC (rev 101396)
@@ -33,7 +33,7 @@
 class JSDOMWrapper;
 class ScriptController;
 
-typedef HashMapvoid*, JSC::WeakJSDOMWrapper  DOMObjectWrapperMap;
+typedef HashMapvoid*, JSC::WeakJSC::JSObject  DOMObjectWrapperMap;
 typedef HashMapStringImpl*, JSC::WeakJSC::JSString  JSStringCache;
 
 class JSDOMWrapperOwner : public JSC::WeakHandleOwner {


Modified: trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h (101395 => 101396)

--- trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h	2011-11-29 18:26:14 UTC (rev 101395)
+++ trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h	2011-11-29 18:32:25 UTC (rev 101396)
@@ -168,7 +168,7 @@
 if (!object)
 return JSC::jsNull();
 
-if (JSDOMWrapper* wrapper = getCachedWrapper(currentWorld(exec), object))
+if (JSC::JSObject* wrapper = getCachedWrapper(currentWorld(exec), object))
 return wrapper;
 
 

[webkit-changes] [101397] trunk/LayoutTests

[philn]

Title: [101397] trunk/LayoutTests








Revision 101397
Author ph...@webkit.org
Date 2011-11-29 10:56:40 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, other round of GTK rebaseline.

* platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Added.
* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/gtk/editing/selection/fake-drag-expected.txt: Added.
* platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
* platform/gtk/fast/table/multiple-captions-display-expected.txt:
* platform/gtk/plugins/embed-attributes-style-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/execCommand/insertImage-expected.txt
trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt
trunk/LayoutTests/platform/gtk/fast/table/multiple-captions-display-expected.txt
trunk/LayoutTests/platform/gtk/plugins/embed-attributes-style-expected.txt


Added Paths

trunk/LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt
trunk/LayoutTests/platform/gtk/editing/selection/fake-drag-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/onselect-textarea-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101396 => 101397)

--- trunk/LayoutTests/ChangeLog	2011-11-29 18:32:25 UTC (rev 101396)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 18:56:40 UTC (rev 101397)
@@ -1,5 +1,17 @@
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
+Unreviewed, other round of GTK rebaseline.
+
+* platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Added.
+* platform/gtk/editing/execCommand/insertImage-expected.txt:
+* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
+* platform/gtk/editing/selection/fake-drag-expected.txt: Added.
+* platform/gtk/fast/forms/onselect-textarea-expected.txt: Added.
+* platform/gtk/fast/table/multiple-captions-display-expected.txt:
+* platform/gtk/plugins/embed-attributes-style-expected.txt:
+
+2011-11-29  Philippe Normand  pnorm...@igalia.com
+
 Unreviewed, another GTK svg rebaseline after r101342.
 
 * platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:


Added: trunk/LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt (0 => 101397)

--- trunk/LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt	2011-11-29 18:56:40 UTC (rev 101397)
@@ -0,0 +1 @@
+link 1 dimensions: 100 x 100; link 2 dimensions: 100 x 99


Modified: trunk/LayoutTests/platform/gtk/editing/execCommand/insertImage-expected.txt (101396 => 101397)

--- trunk/LayoutTests/platform/gtk/editing/execCommand/insertImage-expected.txt	2011-11-29 18:32:25 UTC (rev 101396)
+++ trunk/LayoutTests/platform/gtk/editing/execCommand/insertImage-expected.txt	2011-11-29 18:56:40 UTC (rev 101397)
@@ -19,6 +19,6 @@
   text run at (0,18) width 375: passes execCommand a path where no image should exist.
   RenderBlock {DIV} at (0,52) size 784x103
 RenderImage {IMG} at (0,0) size 76x103
-RenderImage {IMG} at (76,99) size 4x4
+RenderImage {IMG} at (76,83) size 20x20
   RenderBlock {UL} at (0,171) size 784x0
 caret: position 1 of child 1 {IMG} of child 3 {DIV} of body


Modified: trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt (101396 => 101397)

--- trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt	2011-11-29 18:32:25 UTC (rev 101396)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt	2011-11-29 18:56:40 UTC (rev 101397)
@@ -18,6 +18,6 @@
 RenderBlock {HTML} at (0,0) size 300x150
   RenderBody {BODY} at (8,8) size 284x134
 RenderBlock {DIV} at (0,0) size 271x129 [border: (1px solid #00)]
-  RenderImage {IMG} at (1,1) size 4x4
+  RenderImage {IMG} at (1,1) size 20x20
 RenderText {#text} at (0,0) size 0x0
   RenderBlock {UL} at (0,226) size 784x0


Added: trunk/LayoutTests/platform/gtk/editing/selection/fake-drag-expected.txt (0 => 101397)

--- trunk/LayoutTests/platform/gtk/editing/selection/fake-drag-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/selection/fake-drag-expected.txt	2011-11-29 18:56:40 UTC (rev 101397)
@@ -0,0 +1,9 @@
+EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV  BODY  HTML  #document to 1 of DIV  BODY  HTML  #document
+EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
+EDITING DELEGATE: 

[webkit-changes] [101398] trunk/Source/WebCore

[tony]

Title: [101398] trunk/Source/WebCore








Revision 101398
Author t...@chromium.org
Date 2011-11-29 11:05:08 -0800 (Tue, 29 Nov 2011)


Log Message
[chromium] Remove unused variable (gcc 4.6 complains about this)
https://bugs.webkit.org/show_bug.cgi?id=73335

../../third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:296:19:
error: variable 'oldReplicaMaskRect' set but not used [-Werror=unused-but-set-variable]

* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101397 => 101398)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 18:56:40 UTC (rev 101397)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 19:05:08 UTC (rev 101398)
@@ -1,3 +1,14 @@
+2011-11-29  Tony Chang  t...@chromium.org
+
+[chromium] Remove unused variable (gcc 4.6 complains about this)
+https://bugs.webkit.org/show_bug.cgi?id=73335
+
+../../third_party/WebKit/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:296:19:
+error: variable 'oldReplicaMaskRect' set but not used [-Werror=unused-but-set-variable]
+
+* platform/graphics/chromium/cc/CCDamageTracker.cpp:
+(WebCore::CCDamageTracker::extendDamageForRenderSurface):
+
 2011-11-29  Oliver Hunt  oli...@apple.com
 
 DOM wrapper cache doesn't need to use JSDOMWrapper


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp (101397 => 101398)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp	2011-11-29 18:56:40 UTC (rev 101397)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp	2011-11-29 19:05:08 UTC (rev 101398)
@@ -293,7 +293,7 @@
 if (layer-replicaLayer()  layer-replicaLayer()-maskLayer()) {
 CCLayerImpl* replicaMaskLayer = layer-replicaLayer()-maskLayer();
 
-FloatRect oldReplicaMaskRect = removeRectFromCurrentFrame(replicaMaskLayer-id());
+removeRectFromCurrentFrame(replicaMaskLayer-id());
 
 // Compute the replica's originTransform that maps from the replica's origin space to the target surface origin space.
 TransformationMatrix replicaOriginTransform = layer-renderSurface()-originTransform();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101399] trunk

[tony]

Title: [101399] trunk








Revision 101399
Author t...@chromium.org
Date 2011-11-29 11:07:57 -0800 (Tue, 29 Nov 2011)


Log Message
flex-align:stretch + max-height needs to clamp to max-height and position appropriately
https://bugs.webkit.org/show_bug.cgi?id=70780

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/flex-align-max.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth): When laying out columns, if the flex item is stretching,
we don't need to shrink wrap.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isColumnFlow): Switch to RenderStyle helper method.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection): For columns, we don't need to do anything.
For rows, handle max logical height by setting the height and recomputing (which will take max-height
into consideration).
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::isColumnFlexFlow): Helper method.

LayoutTests:

* css3/flexbox/flex-align-max-expected.txt: Added.
* css3/flexbox/flex-align-max.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h


Added Paths

trunk/LayoutTests/css3/flexbox/flex-align-max-expected.txt
trunk/LayoutTests/css3/flexbox/flex-align-max.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101398 => 101399)

--- trunk/LayoutTests/ChangeLog	2011-11-29 19:05:08 UTC (rev 101398)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 19:07:57 UTC (rev 101399)
@@ -1,3 +1,13 @@
+2011-11-29  Tony Chang  t...@chromium.org
+
+flex-align:stretch + max-height needs to clamp to max-height and position appropriately
+https://bugs.webkit.org/show_bug.cgi?id=70780
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/flex-align-max-expected.txt: Added.
+* css3/flexbox/flex-align-max.html: Added.
+
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, other round of GTK rebaseline.


Added: trunk/LayoutTests/css3/flexbox/flex-align-max-expected.txt (0 => 101399)

--- trunk/LayoutTests/css3/flexbox/flex-align-max-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flex-align-max-expected.txt	2011-11-29 19:07:57 UTC (rev 101399)
@@ -0,0 +1,4 @@
+PASS
+PASS
+PASS
+PASS
Property changes on: trunk/LayoutTests/css3/flexbox/flex-align-max-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/flex-align-max.html (0 => 101399)

--- trunk/LayoutTests/css3/flexbox/flex-align-max.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/flex-align-max.html	2011-11-29 19:07:57 UTC (rev 101399)
@@ -0,0 +1,63 @@
+!DOCTYPE html
+html
+style
+body {
+margin: 0;
+}
+.flexbox {
+display: -webkit-flexbox;
+background-color: #aaa;
+position: relative;
+}
+.flexbox div {
+border: 0;
+}
+.column {
+-webkit-flex-flow: column;
+}
+.vertical-rl {
+-webkit-writing-mode: vertical-rl;
+}
+.flexbox :nth-child(1) {
+background-color: blue;
+}
+.flexbox :nth-child(2) {
+background-color: green;
+}
+.flexbox :nth-child(3) {
+background-color: red;
+}
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+script src=""
+body _onload_=checkFlexBoxen()
+
+div class=flexbox
+  div data-expected-height=50 style=width: -webkit-flex(1 0 0); max-height: 100px/div
+  div data-expected-height=50 style=width: -webkit-flex(1 0 0); height: 50px/div
+  div data-expected-height=25 style=width: -webkit-flex(1 0 0); max-height: 25px/div
+/div
+
+div class=flexbox column style=width: 200px
+  div data-expected-width=150 style=height: -webkit-flex(1 0 20px); max-width: 150px/div
+  div data-expected-width=100 style=height: -webkit-flex(1 0 20px); width: 100px/div
+  div data-expected-width=200 style=height: -webkit-flex(1 0 20px);/div
+/div
+
+div class=flexbox vertical-rl style=height: 60px
+  div data-expected-width=100 style=height: -webkit-flex(1 0 20px); max-width: 110px/div
+  div data-expected-width=100 style=height: -webkit-flex(1 0 20px); width: 100px/div
+  div data-expected-width=50 style=height: -webkit-flex(1 0 20px); max-width: 50px/div
+/div
+
+div class=flexbox column vertical-rl style=height: 50px
+  div data-expected-height=50 style=width: -webkit-flex(1 0 100px); max-height: 100px/div
+  div data-expected-height=50 style=width: -webkit-flex(1 0 100px); height: 50px/div
+  div data-expected-height=25 style=width: -webkit-flex(1 0 100px); max-height: 25px/div
+/div
+
+/body
+/html
Property changes on: trunk/LayoutTests/css3/flexbox/flex-align-max.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (101398 => 101399)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 19:05:08 

[webkit-changes] [101400] trunk/LayoutTests

[xji]

Title: [101400] trunk/LayoutTests








Revision 101400
Author x...@chromium.org
Date 2011-11-29 11:31:09 -0800 (Tue, 29 Nov 2011)


Log Message
Rebase after r100819.

* platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Removed.
* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (101399 => 101400)

--- trunk/LayoutTests/ChangeLog	2011-11-29 19:07:57 UTC (rev 101399)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 19:31:09 UTC (rev 101400)
@@ -1,3 +1,14 @@
+2011-11-29  Xiaomei Ji  x...@chromium.org
+
+Rebase after r100819.
+
+* platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
+* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Removed.
+* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
+* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
+* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-11-29  Tony Chang  t...@chromium.org
 
 flex-align:stretch + max-height needs to clamp to max-height and position appropriately


Added: trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt (0 => 101400)

--- trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt	2011-11-29 19:31:09 UTC (rev 101400)
@@ -0,0 +1,8 @@
+layer at (0,0) size 329x4018
+  RenderView at (0,0) size 329x573
+layer at (0,0) size 329x4018
+  RenderBlock {HTML} at (0,0) size 329x4018
+RenderBody {BODY} at (8,8) size 313x4002
+  RenderBlock {DIV} at (-689,0) size 1002x4002 [border: (1px solid #FF)]
+RenderText {#text} at (-491,1) size 1492x18
+  text run at (-491,1) width 1492: BEGINEND


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101399 => 101400)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 19:07:57 UTC (rev 101399)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 19:31:09 UTC (rev 101400)
@@ -3723,8 +3723,6 @@
 BUGWK72053 MAC DEBUG : fast/borders/inline-mask-overlay-image-outset-vertical-rl.html = PASS CRASH
 BUGWK72053 MAC DEBUG : fast/borders/block-mask-overlay-image-outset.html = PASS CRASH
 
-BUGWK70395 MAC : fast/dom/rtl-scroll-to-leftmost-and-resize.html = IMAGE+TEXT
-
 BUGWK72264 MAC : inspector/debugger/script-formatter.html = TIMEOUT
 
 // Fixed ES5 bugs during the V8 roll, upstream in progress.


Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101401] trunk/Source/WebCore

[oliver]

Title: [101401] trunk/Source/WebCore








Revision 101401
Author oli...@apple.com
Date 2011-11-29 11:44:07 -0800 (Tue, 29 Nov 2011)


Log Message
Revert that last change, apparently it destroys everything in the world.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h
trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h
trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp
trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp
trunk/Source/WebCore/bindings/js/JSEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSHTMLCollectionCustom.cpp
trunk/Source/WebCore/bindings/js/JSImageDataCustom.cpp
trunk/Source/WebCore/bindings/js/JSSVGPathSegCustom.cpp
trunk/Source/WebCore/bindings/js/JSStyleSheetCustom.cpp
trunk/Source/WebCore/bindings/js/JSTrackCustom.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101400 => 101401)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 19:31:09 UTC (rev 101400)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 19:44:07 UTC (rev 101401)
@@ -1,3 +1,39 @@
+2011-11-29  Oliver Hunt  oli...@apple.com
+
+Revert that last change, apparently it destroys everything in the world.
+
+* bindings/js/DOMWrapperWorld.h:
+* bindings/js/JSArrayBufferViewHelper.h:
+(WebCore::toJSArrayBufferView):
+* bindings/js/JSCSSRuleCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSCSSValueCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSDOMBinding.h:
+(WebCore::setInlineCachedWrapper):
+(WebCore::clearInlineCachedWrapper):
+(WebCore::getCachedWrapper):
+(WebCore::cacheWrapper):
+(WebCore::wrap):
+* bindings/js/JSDOMWindowCustom.cpp:
+(WebCore::JSDOMWindow::history):
+(WebCore::JSDOMWindow::location):
+* bindings/js/JSDocumentCustom.cpp:
+(WebCore::JSDocument::location):
+(WebCore::toJS):
+* bindings/js/JSEventCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSHTMLCollectionCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSImageDataCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSSVGPathSegCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSStyleSheetCustom.cpp:
+(WebCore::toJS):
+* bindings/js/JSTrackCustom.cpp:
+(WebCore::toJS):
+
 2011-11-29  Tony Chang  t...@chromium.org
 
 flex-align:stretch + max-height needs to clamp to max-height and position appropriately


Modified: trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h (101400 => 101401)

--- trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 19:31:09 UTC (rev 101400)
+++ trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 19:44:07 UTC (rev 101401)
@@ -33,7 +33,7 @@
 class JSDOMWrapper;
 class ScriptController;
 
-typedef HashMapvoid*, JSC::WeakJSC::JSObject  DOMObjectWrapperMap;
+typedef HashMapvoid*, JSC::WeakJSDOMWrapper  DOMObjectWrapperMap;
 typedef HashMapStringImpl*, JSC::WeakJSC::JSString  JSStringCache;
 
 class JSDOMWrapperOwner : public JSC::WeakHandleOwner {


Modified: trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h (101400 => 101401)

--- trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h	2011-11-29 19:31:09 UTC (rev 101400)
+++ trunk/Source/WebCore/bindings/js/JSArrayBufferViewHelper.h	2011-11-29 19:44:07 UTC (rev 101401)
@@ -168,7 +168,7 @@
 if (!object)
 return JSC::jsNull();
 
-if (JSC::JSObject* wrapper = getCachedWrapper(currentWorld(exec), object))
+if (JSDOMWrapper* wrapper = getCachedWrapper(currentWorld(exec), object))
 return wrapper;
 
 exec-heap()-reportExtraMemoryCost(object-byteLength());


Modified: trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp (101400 => 101401)

--- trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp	2011-11-29 19:31:09 UTC (rev 101400)
+++ trunk/Source/WebCore/bindings/js/JSCSSRuleCustom.cpp	2011-11-29 19:44:07 UTC (rev 101401)
@@ -63,7 +63,7 @@
 if (!rule)
 return jsNull();
 
-JSObject* wrapper = getCachedWrapper(currentWorld(exec), rule);
+JSDOMWrapper* wrapper = getCachedWrapper(currentWorld(exec), rule);
 if (wrapper)
 return wrapper;
 


Modified: trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp (101400 => 101401)

--- trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp	2011-11-29 19:31:09 UTC (rev 101400)
+++ trunk/Source/WebCore/bindings/js/JSCSSValueCustom.cpp	2011-11-29 19:44:07 UTC (rev 101401)
@@ -76,7 +76,7 @@
 if (!value)
 return jsNull();
 
-JSObject* wrapper = getCachedWrapper(currentWorld(exec), value);
+JSDOMWrapper* wrapper = getCachedWrapper(currentWorld(exec), value);
 
 if (wrapper)
 return wrapper;


Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (101400 => 101401)

--- 

[webkit-changes] [101404] trunk/Tools

[mrobinson]

Title: [101404] trunk/Tools








Revision 101404
Author mrobin...@webkit.org
Date 2011-11-29 12:30:17 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] Add a method to detect 'make dist' errors without running 'make dist'
https://bugs.webkit.org/show_bug.cgi?id=73216

Reviewed by Philippe Normand.

Add a script that tries to sniff out 'make dist' problems without running
'make dist.' 'make distcheck' takes a very long time to run and this should
reduce the amount of times it needs to be run consecutively.

* gtk/common.py:
(get_build_path.is_valid_build_directory): Guess the source directory
by the existence of the GNUmakefile instead of the .libs directory. This
allows one to run the script after running autogen.sh but before fully
building.
* gtk/find-make-dist-errors: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/common.py


Added Paths

trunk/Tools/gtk/find-make-dist-errors




Diff

Modified: trunk/Tools/ChangeLog (101403 => 101404)

--- trunk/Tools/ChangeLog	2011-11-29 20:11:48 UTC (rev 101403)
+++ trunk/Tools/ChangeLog	2011-11-29 20:30:17 UTC (rev 101404)
@@ -1,3 +1,21 @@
+2011-11-29  Martin Robinson  mrobin...@igalia.com
+
+[GTK] Add a method to detect 'make dist' errors without running 'make dist'
+https://bugs.webkit.org/show_bug.cgi?id=73216
+
+Reviewed by Philippe Normand.
+
+Add a script that tries to sniff out 'make dist' problems without running
+'make dist.' 'make distcheck' takes a very long time to run and this should
+reduce the amount of times it needs to be run consecutively.
+
+* gtk/common.py:
+(get_build_path.is_valid_build_directory): Guess the source directory
+by the existence of the GNUmakefile instead of the .libs directory. This
+allows one to run the script after running autogen.sh but before fully
+building.
+* gtk/find-make-dist-errors: Added.
+
 2011-11-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Remove use of internal headers in the MiniBrowser


Modified: trunk/Tools/gtk/common.py (101403 => 101404)

--- trunk/Tools/gtk/common.py	2011-11-29 20:11:48 UTC (rev 101403)
+++ trunk/Tools/gtk/common.py	2011-11-29 20:30:17 UTC (rev 101404)
@@ -40,7 +40,7 @@
 return build_dir
 
 def is_valid_build_directory(path):
-return os.path.exists(os.path.join(path, '.libs'))
+return os.path.exists(os.path.join(path, 'GNUmakefile'))
 
 build_dir = top_level_path('WebKitBuild', 'Release')
 if is_valid_build_directory(build_dir):


Added: trunk/Tools/gtk/find-make-dist-errors (0 => 101404)

--- trunk/Tools/gtk/find-make-dist-errors	(rev 0)
+++ trunk/Tools/gtk/find-make-dist-errors	2011-11-29 20:30:17 UTC (rev 101404)
@@ -0,0 +1,108 @@
+#!/usr/bin/python
+# Copyright (C) 2011 Igalia S.L.
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+import common
+import os
+import subprocess
+import sys
+
+def is_source_file_listing(line):
+return line.strip().startswith('Source')
+
+def get_listed_makefile_headers():
+makefile_text = open(os.path.join(common.build_path('GNUmakefile'))).read()
+
+# Automake often places separate includes on the same line.
+makefile_text = makefile_text.replace(' ', '\n')
+
+headers = []
+for line in makefile_text.splitlines():
+# $(srcdir)/ is the same as an empty string in a source file listing.
+line = line.replace('$(srcdir)/', '')
+
+# If the line doesn't start with 'Source' it isn't listing for
+# a source file.
+if not is_source_file_listing(line):
+continue
+
+# Most source listings end with \ indicating that the listing
+# continues onto the next line.
+line = line.replace('\\', '')
+
+# We only care about header files. Source files result in build
+# breakage, so we will detect them without this script.
+line = line.strip()
+if not line.endswith('.h'):
+continue
+
+# If the line contains a makefile variable we do not care about it.
+if line.find('$') != -1:
+continue
+
+headers.append(line)
+
+return headers
+
+def scan_headers_from_dependency_files():
+process = subprocess.Popen(['find . -name *.Plo | xargs 

[webkit-changes] [101406] trunk

[rniwa]

Title: [101406] trunk








Revision 101406
Author rn...@webkit.org
Date 2011-11-29 12:37:24 -0800 (Tue, 29 Nov 2011)


Log Message
Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount = 1)
in IsolateTracker::exitIsolate()
https://bugs.webkit.org/show_bug.cgi?id=69275

Reviewed by Eric Seidel.

Source/WebCore: 

The crash was caused by our false assumption that at most one isolated container exists between the start
and the root when appending a new run. Fixed the crash by computing the actual number of isolated containers
between the start and the root.

Test: fast/text/nested-bidi-isolate-crash.html

* rendering/InlineIterator.h:
(WebCore::numberOfIsolateAncestors):
(WebCore::IsolateTracker::IsolateTracker):
(WebCore::InlineBidiResolver::appendRun):

LayoutTests: 

Add a regression test.

* fast/text/nested-bidi-isolate-crash-expected.txt: Added.
* fast/text/nested-bidi-isolate-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineIterator.h


Added Paths

trunk/LayoutTests/fast/text/nested-bidi-isolate-crash-expected.txt
trunk/LayoutTests/fast/text/nested-bidi-isolate-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101405 => 101406)

--- trunk/LayoutTests/ChangeLog	2011-11-29 20:31:11 UTC (rev 101405)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 20:37:24 UTC (rev 101406)
@@ -1,3 +1,16 @@
+2011-11-28  Ryosuke Niwa  rn...@webkit.org
+
+Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount = 1)
+in IsolateTracker::exitIsolate()
+https://bugs.webkit.org/show_bug.cgi?id=69275
+
+Reviewed by Eric Seidel.
+
+Add a regression test.
+
+* fast/text/nested-bidi-isolate-crash-expected.txt: Added.
+* fast/text/nested-bidi-isolate-crash.html: Added.
+
 2011-11-29  Xiaomei Ji  x...@chromium.org
 
 Rebase after r100819.


Added: trunk/LayoutTests/fast/text/nested-bidi-isolate-crash-expected.txt (0 => 101406)

--- trunk/LayoutTests/fast/text/nested-bidi-isolate-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/nested-bidi-isolate-crash-expected.txt	2011-11-29 20:37:24 UTC (rev 101406)
@@ -0,0 +1,4 @@
+This tests nesting two spans with -webkit-isolate followed by a br. The test passes if WebKit doesn't crash.
+
+a
+


Added: trunk/LayoutTests/fast/text/nested-bidi-isolate-crash.html (0 => 101406)

--- trunk/LayoutTests/fast/text/nested-bidi-isolate-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/text/nested-bidi-isolate-crash.html	2011-11-29 20:37:24 UTC (rev 101406)
@@ -0,0 +1,9 @@
+!DOCTYPE html
+pThis tests nesting two spans with -webkit-isolate followed by a br. The test passes if WebKit doesn't crash./p
+span style=unicode-bidi:-webkit-isolate;span style=unicode-bidi:-webkit-isolate;a/span/spanbr
+script
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+/script


Modified: trunk/Source/WebCore/ChangeLog (101405 => 101406)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 20:31:11 UTC (rev 101405)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 20:37:24 UTC (rev 101406)
@@ -1,3 +1,22 @@
+2011-11-28  Ryosuke Niwa  rn...@webkit.org
+
+Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount = 1)
+in IsolateTracker::exitIsolate()
+https://bugs.webkit.org/show_bug.cgi?id=69275
+
+Reviewed by Eric Seidel.
+
+The crash was caused by our false assumption that at most one isolated container exists between the start
+and the root when appending a new run. Fixed the crash by computing the actual number of isolated containers
+between the start and the root.
+
+Test: fast/text/nested-bidi-isolate-crash.html
+
+* rendering/InlineIterator.h:
+(WebCore::numberOfIsolateAncestors):
+(WebCore::IsolateTracker::IsolateTracker):
+(WebCore::InlineBidiResolver::appendRun):
+
 2011-11-29  Oliver Hunt  oli...@apple.com
 
 Revert that last change, apparently it destroys everything in the world.


Modified: trunk/Source/WebCore/rendering/InlineIterator.h (101405 => 101406)

--- trunk/Source/WebCore/rendering/InlineIterator.h	2011-11-29 20:31:11 UTC (rev 101405)
+++ trunk/Source/WebCore/rendering/InlineIterator.h	2011-11-29 20:37:24 UTC (rev 101406)
@@ -406,6 +406,18 @@
 return 0;
 }
 
+static inline unsigned numberOfIsolateAncestors(RenderObject* object, RenderObject* root)
+{
+ASSERT(object);
+unsigned count = 0;
+while (object  object != root) {
+if (isIsolatedInline(object))
+count++;
+object = object-parent();
+}
+return count;
+}
+
 // FIXME: This belongs on InlineBidiResolver, except it's a template specialization
 // of BidiResolver which knows nothing about RenderObjects.
 static inline void 

[webkit-changes] [101408] trunk

[vestbo]

Title: [101408] trunk








Revision 101408
Author ves...@webkit.org
Date 2011-11-29 12:47:28 -0800 (Tue, 29 Nov 2011)


Log Message
[Qt] Don't hard-code the list of WebKit2 generated sources

The generated sources are... wait for it... generated. So
use the generator itself to figure out which sources we need
to compile.

Reviewed by Simon Hausmann.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.pri
trunk/Source/WebKit2/Target.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Source/WebKit2/ChangeLog (101407 => 101408)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 20:47:12 UTC (rev 101407)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 20:47:28 UTC (rev 101408)
@@ -1,3 +1,16 @@
+2011-11-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
+
+[Qt] Don't hard-code the list of WebKit2 generated sources
+
+The generated sources are... wait for it... generated. So
+use the generator itself to figure out which sources we need
+to compile.
+
+Reviewed by Simon Hausmann.
+
+* DerivedSources.pri:
+* Target.pri:
+
 2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Fix the GTK+ port build after r101307.


Modified: trunk/Source/WebKit2/DerivedSources.pri (101407 => 101408)

--- trunk/Source/WebKit2/DerivedSources.pri	2011-11-29 20:47:12 UTC (rev 101407)
+++ trunk/Source/WebKit2/DerivedSources.pri	2011-11-29 20:47:28 UTC (rev 101408)
@@ -4,7 +4,12 @@
 # See 'Tools/qmake/README' for an overview of the build system
 # ---
 
-TEMPLATE = derived
+# This file is both a top level target, and included from Target.pri,
+# so that the resulting generated sources can be added to SOURCES.
+# We only set the template if we're a top level target, so that we
+# don't override what Target.pri has already set.
+sanitizedFile = $$toSanitizedPath($$_FILE_)
+equals(sanitizedFile, $$toSanitizedPath($$_PRO_FILE_)):TEMPLATE = derived
 
 load(features)
 
@@ -105,6 +110,7 @@
 message_header_generator.input = MESSAGE_RECEIVERS
 message_header_generator.depends = $$SCRIPTS
 message_header_generator.output_function = message_header_generator_output
+message_header_generator.add_output_to_sources = false
 GENERATORS += message_header_generator
 
 message_receiver_generator.commands = $${PYTHON} $${SOURCE_DIR}/WebKit2/Scripts/generate-message-receiver.py  ${QMAKE_FILE_IN}  ${QMAKE_FILE_OUT}
@@ -118,17 +124,17 @@
 generated_files.depends += fwheader_generator
 GENERATORS += fwheader_generator
 
-for(HEADER, WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2) {
-HEADER_NAME = $$basename(HEADER)
-HEADER_PATH = $$HEADER
-HEADER_TARGET = $$replace(HEADER_PATH, [^a-zA-Z0-9_], -)
-HEADER_TARGET = qtheader-$${HEADER_TARGET}
-DESTDIR = $${ROOT_BUILD_DIR}/Source/include/WebCore
+for(header, WEBCORE_GENERATED_HEADERS_FOR_WEBKIT2) {
+header_name = $$basename(header)
+header_path = $$header
+header_target = $$replace(header_path, [^a-zA-Z0-9_], -)
+header_target = qtheader-$${header_target}
+dest_dir = $${ROOT_BUILD_DIR}/Source/include/WebCore
 
-eval($${HEADER_TARGET}.target = $$DESTDIR/$$HEADER_NAME)
-eval($${HEADER_TARGET}.depends = $$HEADER_PATH)
-eval($${HEADER_TARGET}.commands = echo $${DOUBLE_ESCAPED_QUOTE}\$${LITERAL_HASH}include \\\$$HEADER_PATH\\\$${DOUBLE_ESCAPED_QUOTE}  $$eval($${HEADER_TARGET}.target))
+eval($${header_target}.target = $$dest_dir/$$header_name)
+eval($${header_target}.depends = $$header_path)
+eval($${header_target}.commands = echo $${DOUBLE_ESCAPED_QUOTE}\$${LITERAL_HASH}include \\\$$header_path\\\$${DOUBLE_ESCAPED_QUOTE}  $$eval($${header_target}.target))
 
-GENERATORS += $$HEADER_TARGET
+GENERATORS += $$header_target
 }
 


Modified: trunk/Source/WebKit2/Target.pri (101407 => 101408)

--- trunk/Source/WebKit2/Target.pri	2011-11-29 20:47:12 UTC (rev 101407)
+++ trunk/Source/WebKit2/Target.pri	2011-11-29 20:47:28 UTC (rev 101408)
@@ -20,86 +20,6 @@
 
 QT += declarative
 
-WEBKIT2_GENERATED_HEADERS = \
-$$WEBKIT2_GENERATED_SOURCES_DIR/AuthenticationManagerMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/DownloadProxyMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/LayerTreeHostMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/LayerTreeHostProxyMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/NPObjectMessageReceiverMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/PluginControllerProxyMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/PluginProcessConnectionMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/PluginProcessMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/PluginProcessProxyMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/PluginProxyMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/WebApplicationCacheManagerMessages.h \
-$$WEBKIT2_GENERATED_SOURCES_DIR/WebApplicationCacheManagerProxyMessages.h \
-

[webkit-changes] [101411] trunk

[ojan]

Title: [101411] trunk








Revision 101411
Author o...@chromium.org
Date 2011-11-29 13:22:10 -0800 (Tue, 29 Nov 2011)


Log Message
invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
https://bugs.webkit.org/show_bug.cgi?id=72668

Reviewed by David Hyatt.

Source/WebCore:

For new flexible boxes, we were setting childrenInline to true when
merging anonymous blocks, which we should never do. Do the same thing
we do for the deprecated flexboxes.

Test: css3/flexbox/anonymous-block-merge-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
* rendering/RenderObject.h:
(WebCore::RenderObject::setChildrenInline):
The default value of true was never used. Better to keep it explicit.

LayoutTests:

* css3/flexbox/anonymous-block-merge-crash-expected.txt: Added.
* css3/flexbox/anonymous-block-merge-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderObject.h


Added Paths

trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash-expected.txt
trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101410 => 101411)

--- trunk/LayoutTests/ChangeLog	2011-11-29 21:12:40 UTC (rev 101410)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 21:22:10 UTC (rev 101411)
@@ -1,3 +1,13 @@
+2011-11-29  Ojan Vafai  o...@chromium.org
+
+invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
+https://bugs.webkit.org/show_bug.cgi?id=72668
+
+Reviewed by David Hyatt.
+
+* css3/flexbox/anonymous-block-merge-crash-expected.txt: Added.
+* css3/flexbox/anonymous-block-merge-crash.html: Added.
+
 2011-11-28  Ryosuke Niwa  rn...@webkit.org
 
 Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount = 1)


Added: trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash-expected.txt (0 => 101411)

--- trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash-expected.txt	2011-11-29 21:22:10 UTC (rev 101411)
@@ -0,0 +1 @@
+If this page doesn't crash then this test passes.
Property changes on: trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html (0 => 101411)

--- trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html	(rev 0)
+++ trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html	2011-11-29 21:22:10 UTC (rev 101411)
@@ -0,0 +1,7 @@
+div style=display:-webkit-flexboxdiv id=inner/divIf this page doesn't crash then this test passes./div
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText()
+var inner = document.getElementById(inner);
+inner.parentNode.removeChild(inner);
+/script
\ No newline at end of file
Property changes on: trunk/LayoutTests/css3/flexbox/anonymous-block-merge-crash.html
___


Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (101410 => 101411)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 21:12:40 UTC (rev 101410)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 21:22:10 UTC (rev 101411)
@@ -1,3 +1,22 @@
+2011-11-29  Ojan Vafai  o...@chromium.org
+
+invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox
+https://bugs.webkit.org/show_bug.cgi?id=72668
+
+Reviewed by David Hyatt.
+
+For new flexible boxes, we were setting childrenInline to true when
+merging anonymous blocks, which we should never do. Do the same thing
+we do for the deprecated flexboxes.
+
+Test: css3/flexbox/anonymous-block-merge-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::removeChild):
+* rendering/RenderObject.h:
+(WebCore::RenderObject::setChildrenInline):
+The default value of true was never used. Better to keep it explicit.
+
 2011-11-28  Ryosuke Niwa  rn...@webkit.org
 
 Crash in IsolateTracker::addFakeRunIfNecessary(), preceded by assertion failure (m_nestedIsolateCount = 1)


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (101410 => 101411)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-11-29 21:12:40 UTC (rev 101410)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2011-11-29 21:22:10 UTC (rev 101411)
@@ -1070,7 +1070,7 @@
 RenderBox::removeChild(oldChild);
 
 RenderObject* child = prev ? prev : next;
-if (canMergeAnonymousBlocks  child  !child-previousSibling()  !child-nextSibling()  !isDeprecatedFlexibleBox()) {
+if (canMergeAnonymousBlocks  child  !child-previousSibling()  !child-nextSibling()  

[webkit-changes] [101412] trunk/Source/WebKit2

[carlosgc]

Title: [101412] trunk/Source/WebKit2








Revision 101412
Author carlo...@webkit.org
Date 2011-11-29 13:22:55 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed. Fix GTK+ WebKit2 build after r101312.

* Scripts/generate-forwarding-headers.pl: Add blackberry to the
list of platforms.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl




Diff

Modified: trunk/Source/WebKit2/ChangeLog (101411 => 101412)

--- trunk/Source/WebKit2/ChangeLog	2011-11-29 21:22:10 UTC (rev 101411)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-29 21:22:55 UTC (rev 101412)
@@ -1,3 +1,10 @@
+2011-11-29  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix GTK+ WebKit2 build after r101312.
+
+* Scripts/generate-forwarding-headers.pl: Add blackberry to the
+list of platforms.
+
 2011-11-29  Tor Arne Vestbø  tor.arne.ves...@nokia.com
 
 [Qt] Don't hard-code the list of WebKit2 generated sources


Modified: trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl (101411 => 101412)

--- trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2011-11-29 21:22:10 UTC (rev 101411)
+++ trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2011-11-29 21:22:55 UTC (rev 101412)
@@ -35,7 +35,7 @@
 
 my $srcRoot = realpath(File::Spec-catfile(dirname(abs_path($0)), ../..));
 my $incFromRoot = abs_path($ARGV[0]);
-my @platformPrefixes = (cf, chromium, curl, efl, gtk, mac, qt, soup, v8, win, wx);
+my @platformPrefixes = (blackberry, cf, chromium, curl, efl, gtk, mac, qt, soup, v8, win, wx);
 my @frameworks = ( _javascript_Core, WebCore, WebKit2);
 my @skippedPrefixes;
 my @frameworkHeaders;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101413] trunk/Source

[andersca]

Title: [101413] trunk/Source








Revision 101413
Author ander...@apple.com
Date 2011-11-29 13:29:00 -0800 (Tue, 29 Nov 2011)


Log Message
EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72408

Reviewed by Sam Weinig.

Source/WebCore:

Rename windowRectForRange to rootViewRectForRange and use contentsToRootView instead of contentsToWindow.

* editing/SpellingCorrectionController.cpp:
(WebCore::SpellingCorrectionController::show):
(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
(WebCore::SpellingCorrectionController::rootViewRectForRange):
* editing/SpellingCorrectionController.h:

Source/WebKit/mac:

* WebCoreSupport/CorrectionPanel.mm:
(CorrectionPanel::show):
Convert the bounding rect to web view coordinates.

* WebView/WebView.mm:
(-[WebView _convertPointFromRootView:]):
(-[WebView _convertRectFromRootView:]):
* WebView/WebViewInternal.h:
Add helper methods for converting from root view coordinates to web view coordinates.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/SpellingCorrectionController.cpp
trunk/Source/WebCore/editing/SpellingCorrectionController.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/CorrectionPanel.mm
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewInternal.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101412 => 101413)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 21:22:55 UTC (rev 101412)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 21:29:00 UTC (rev 101413)
@@ -1,3 +1,18 @@
+2011-11-15  Anders Carlsson  ander...@apple.com
+
+EditorClient::showCorrectionPanel should pass the string bounding box in root view coordinates
+https://bugs.webkit.org/show_bug.cgi?id=72408
+
+Reviewed by Sam Weinig.
+
+Rename windowRectForRange to rootViewRectForRange and use contentsToRootView instead of contentsToWindow.
+
+* editing/SpellingCorrectionController.cpp:
+(WebCore::SpellingCorrectionController::show):
+(WebCore::SpellingCorrectionController::correctionPanelTimerFired):
+(WebCore::SpellingCorrectionController::rootViewRectForRange):
+* editing/SpellingCorrectionController.h:
+
 2011-11-29  Ojan Vafai  o...@chromium.org
 
 invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox


Modified: trunk/Source/WebCore/editing/SpellingCorrectionController.cpp (101412 => 101413)

--- trunk/Source/WebCore/editing/SpellingCorrectionController.cpp	2011-11-29 21:22:55 UTC (rev 101412)
+++ trunk/Source/WebCore/editing/SpellingCorrectionController.cpp	2011-11-29 21:29:00 UTC (rev 101413)
@@ -155,7 +155,7 @@
 
 void SpellingCorrectionController::show(PassRefPtrRange rangeToReplace, const String replacement)
 {
-FloatRect boundingBox = windowRectForRange(rangeToReplace.get());
+FloatRect boundingBox = rootViewRectForRange(rangeToReplace.get());
 if (boundingBox.isEmpty())
 return;
 m_correctionPanelInfo.replacedString = plainText(rangeToReplace.get());
@@ -298,7 +298,7 @@
 break;
 m_correctionPanelInfo.isActive = true;
 m_correctionPanelInfo.replacedString = plainText(m_correctionPanelInfo.rangeToBeReplaced.get());
-FloatRect boundingBox = windowRectForRange(m_correctionPanelInfo.rangeToBeReplaced.get());
+FloatRect boundingBox = rootViewRectForRange(m_correctionPanelInfo.rangeToBeReplaced.get());
 if (!boundingBox.isEmpty())
 client()-showCorrectionPanel(m_correctionPanelInfo.panelType, boundingBox, m_correctionPanelInfo.replacedString, m_correctionPanelInfo.replacementString, VectorString());
 }
@@ -316,7 +316,7 @@
 String topSuggestion = suggestions.first();
 suggestions.remove(0);
 m_correctionPanelInfo.isActive = true;
-FloatRect boundingBox = windowRectForRange(m_correctionPanelInfo.rangeToBeReplaced.get());
+FloatRect boundingBox = rootViewRectForRange(m_correctionPanelInfo.rangeToBeReplaced.get());
 if (!boundingBox.isEmpty())
 client()-showCorrectionPanel(m_correctionPanelInfo.panelType, boundingBox, m_correctionPanelInfo.replacedString, topSuggestion, suggestions);
 }
@@ -362,7 +362,7 @@
 return client()  client()-isAutomaticSpellingCorrectionEnabled();
 }
 
-FloatRect SpellingCorrectionController::windowRectForRange(const Range* range) const
+FloatRect SpellingCorrectionController::rootViewRectForRange(const Range* range) const
 {
 FrameView* view = m_frame-view();
 if (!view)
@@ -373,7 +373,7 @@
 size_t size = textQuads.size();
 for (size_t i = 0; i  size; ++i)
 boundingRect.unite(textQuads[i].boundingBox());
-return view-contentsToWindow(IntRect(boundingRect));
+return view-contentsToRootView(IntRect(boundingRect));
 }
 
 void SpellingCorrectionController::respondToChangedSelection(const 

[webkit-changes] [101417] trunk/LayoutTests

[tony]

Title: [101417] trunk/LayoutTests








Revision 101417
Author t...@chromium.org
Date 2011-11-29 13:31:47 -0800 (Tue, 29 Nov 2011)


Log Message
Clean up fast/regions/no-split-line-box.html test
https://bugs.webkit.org/show_bug.cgi?id=73343

Patch by Alan Stearns stea...@adobe.com on 2011-11-29
Reviewed by Tony Chang.

* fast/regions/no-split-line-box.html:
* platform/efl/fast/regions/no-split-line-box-expected.png: Removed.
* platform/mac/fast/regions/no-split-line-box-expected.png: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/regions/no-split-line-box.html


Removed Paths

trunk/LayoutTests/platform/efl/fast/regions/no-split-line-box-expected.png
trunk/LayoutTests/platform/mac/fast/regions/no-split-line-box-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (101416 => 101417)

--- trunk/LayoutTests/ChangeLog	2011-11-29 21:29:18 UTC (rev 101416)
+++ trunk/LayoutTests/ChangeLog	2011-11-29 21:31:47 UTC (rev 101417)
@@ -1,3 +1,14 @@
+2011-11-29  Alan Stearns  stea...@adobe.com
+
+Clean up fast/regions/no-split-line-box.html test
+https://bugs.webkit.org/show_bug.cgi?id=73343
+
+Reviewed by Tony Chang.
+
+* fast/regions/no-split-line-box.html:
+* platform/efl/fast/regions/no-split-line-box-expected.png: Removed.
+* platform/mac/fast/regions/no-split-line-box-expected.png: Removed.
+
 2011-11-29  Ojan Vafai  o...@chromium.org
 
 invalid cast in WebCore::toRenderBox / WebCore::RenderBox::firstChildBox


Modified: trunk/LayoutTests/fast/regions/no-split-line-box.html (101416 => 101417)

--- trunk/LayoutTests/fast/regions/no-split-line-box.html	2011-11-29 21:29:18 UTC (rev 101416)
+++ trunk/LayoutTests/fast/regions/no-split-line-box.html	2011-11-29 21:31:47 UTC (rev 101417)
@@ -29,7 +29,7 @@
   div class=divider/div 
   div id=secondRegion class=region/div 
   div class=article 
-mnopqr mnopqr span id=testSpanm/spannopqr mnopqr mnopqr mnopqr
+mnopqr mnopqr span id=testSpanm/spannopqr mnopqr
   /div
   p class=descriptionThe two regions on either side of the divider should each have two text lines./p
   p class=descriptionThere should be no text line split between the regions./p
@@ -39,7 +39,7 @@
 
 script
   if (window.layoutTestController)
-layoutTestController.dumpAsText(true);
+layoutTestController.dumpAsText();
 
   var testElement = document.getElementById(testSpan)
   var testRect = testElement.getBoundingClientRect();


Deleted: trunk/LayoutTests/platform/efl/fast/regions/no-split-line-box-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/mac/fast/regions/no-split-line-box-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101418] trunk/Source/WebKit/chromium

[adamk]

Title: [101418] trunk/Source/WebKit/chromium








Revision 101418
Author ad...@chromium.org
Date 2011-11-29 13:33:55 -0800 (Tue, 29 Nov 2011)


Log Message
[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=71242

Reviewed by Darin Fisher.

Add addTaskObserver and removeTaskObserver to WebThread,
along with a new WebThread::TaskObserver interface.

For mutation observers, add a TaskObserver to the main thread
to deliver mutations after each task runs.

The Chromium side of this patch is http://codereview.chromium.org/8586038/

* public/platform/WebThread.h:
(WebKit::WebThread::TaskObserver::~TaskObserver):
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebThread.h
trunk/Source/WebKit/chromium/src/WebKit.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (101417 => 101418)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 21:31:47 UTC (rev 101417)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 21:33:55 UTC (rev 101418)
@@ -1,3 +1,24 @@
+2011-11-28  Adam Klein  ad...@chromium.org
+
+[chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API
+https://bugs.webkit.org/show_bug.cgi?id=71242
+
+Reviewed by Darin Fisher.
+
+Add addTaskObserver and removeTaskObserver to WebThread,
+along with a new WebThread::TaskObserver interface.
+
+For mutation observers, add a TaskObserver to the main thread
+to deliver mutations after each task runs.
+
+The Chromium side of this patch is http://codereview.chromium.org/8586038/
+
+* public/platform/WebThread.h:
+(WebKit::WebThread::TaskObserver::~TaskObserver):
+* src/WebKit.cpp:
+(WebKit::initialize):
+(WebKit::shutdown):
+
 2011-11-29  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: split Preferences into Preferences and Capabilities.


Modified: trunk/Source/WebKit/chromium/public/platform/WebThread.h (101417 => 101418)

--- trunk/Source/WebKit/chromium/public/platform/WebThread.h	2011-11-29 21:31:47 UTC (rev 101417)
+++ trunk/Source/WebKit/chromium/public/platform/WebThread.h	2011-11-29 21:33:55 UTC (rev 101418)
@@ -43,8 +43,16 @@
 virtual void run() = 0;
 };
 
+class TaskObserver {
+public:
+virtual ~TaskObserver() { }
+virtual void didProcessTask() = 0;
+};
+
 virtual void postTask(Task*) = 0;
 virtual void postDelayedTask(Task*, long long delayMs) = 0;
+virtual void addTaskObserver(TaskObserver*) { }
+virtual void removeTaskObserver(TaskObserver*) { }
 
 virtual ~WebThread() { }
 };


Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (101417 => 101418)

--- trunk/Source/WebKit/chromium/src/WebKit.cpp	2011-11-29 21:31:47 UTC (rev 101417)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp	2011-11-29 21:33:55 UTC (rev 101418)
@@ -39,9 +39,11 @@
 #include Settings.h
 #include TextEncoding.h
 #include V8Binding.h
+#include WebKitMutationObserver.h
 #include WebKitPlatformSupport.h
 #include WebMediaPlayerClientImpl.h
 #include WebSocket.h
+#include WebThread.h
 #include WorkerContextExecutionProxy.h
 #include v8.h
 
@@ -52,6 +54,22 @@
 
 namespace WebKit {
 
+#if ENABLE(MUTATION_OBSERVERS)
+namespace {
+
+class EndOfTaskRunner : public WebThread::TaskObserver {
+public:
+virtual void didProcessTask()
+{
+WebCore::WebKitMutationObserver::deliverAllMutations();
+}
+};
+
+} // namespace
+
+static WebThread::TaskObserver* s_endOfTaskRunner = 0;
+#endif // ENABLE(MUTATION_OBSERVERS)
+
 // Make sure we are not re-initialized in the same address space.
 // Doing so may cause hard to reproduce crashes.
 static bool s_webKitInitialized = false;
@@ -75,6 +93,12 @@
 v8::V8::SetEntropySource(generateEntropy);
 v8::V8::Initialize();
 WebCore::V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
+
+#if ENABLE(MUTATION_OBSERVERS)
+ASSERT(!s_endOfTaskRunner);
+s_endOfTaskRunner = new EndOfTaskRunner;
+webKitPlatformSupport-currentThread()-addTaskObserver(s_endOfTaskRunner);
+#endif
 }
 
 void initializeWithoutV8(WebKitPlatformSupport* webKitPlatformSupport)
@@ -107,6 +131,13 @@
 {
 delete WebCore::CCProxy::mainThread();
 WebCore::CCProxy::setMainThread(0);
+#if ENABLE(MUTATION_OBSERVERS)
+if (s_endOfTaskRunner) {
+s_webKitPlatformSupport-currentThread()-removeTaskObserver(s_endOfTaskRunner);
+delete s_endOfTaskRunner;
+s_endOfTaskRunner = 0;
+}
+#endif
 s_webKitPlatformSupport = 0;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101419] trunk/Source/WebCore

[weinig]

Title: [101419] trunk/Source/WebCore








Revision 101419
Author wei...@apple.com
Date 2011-11-29 13:47:11 -0800 (Tue, 29 Nov 2011)


Log Message
Remove unused JSDOMWrapperOwner
https://bugs.webkit.org/show_bug.cgi?id=73357

Reviewed by Adam Barth.

* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::globalData):
Remove JSDOMWrapperOwner. It is unused.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.cpp
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101418 => 101419)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 21:33:55 UTC (rev 101418)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 21:47:11 UTC (rev 101419)
@@ -1,3 +1,16 @@
+2011-11-29  Sam Weinig  s...@webkit.org
+
+Remove unused JSDOMWrapperOwner
+https://bugs.webkit.org/show_bug.cgi?id=73357
+
+Reviewed by Adam Barth.
+
+* bindings/js/DOMWrapperWorld.cpp:
+(WebCore::DOMWrapperWorld::DOMWrapperWorld):
+* bindings/js/DOMWrapperWorld.h:
+(WebCore::DOMWrapperWorld::globalData):
+Remove JSDOMWrapperOwner. It is unused.
+
 2011-11-29  Anders Carlsson  ander...@apple.com
 
 Use contentsToRootView when converting the mouse coordinates for the context menu key event


Modified: trunk/Source/WebCore/bindings/js/DOMWrapperWorld.cpp (101418 => 101419)

--- trunk/Source/WebCore/bindings/js/DOMWrapperWorld.cpp	2011-11-29 21:33:55 UTC (rev 101418)
+++ trunk/Source/WebCore/bindings/js/DOMWrapperWorld.cpp	2011-11-29 21:47:11 UTC (rev 101419)
@@ -30,13 +30,6 @@
 
 namespace WebCore {
 
-void JSDOMWrapperOwner::finalize(JSC::HandleJSC::Unknown handle, void* context)
-{
-JSDOMWrapper* wrapper = static_castJSDOMWrapper*(handle.get().asCell());
-void* domObject = context;
-uncacheWrapper(m_world, domObject, wrapper);
-}
-
 void JSStringOwner::finalize(JSC::HandleJSC::Unknown handle, void* context)
 {
 JSString* jsString = static_castJSString*(handle.get().asCell());
@@ -48,7 +41,6 @@
 DOMWrapperWorld::DOMWrapperWorld(JSC::JSGlobalData* globalData, bool isNormal)
 : m_globalData(globalData)
 , m_isNormal(isNormal)
-, m_defaultWrapperOwner(this)
 , m_stringWrapperOwner(this)
 {
 JSGlobalData::ClientData* clientData = m_globalData-clientData;


Modified: trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h (101418 => 101419)

--- trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 21:33:55 UTC (rev 101418)
+++ trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h	2011-11-29 21:47:11 UTC (rev 101419)
@@ -36,20 +36,6 @@
 typedef HashMapvoid*, JSC::WeakJSDOMWrapper  DOMObjectWrapperMap;
 typedef HashMapStringImpl*, JSC::WeakJSC::JSString  JSStringCache;
 
-class JSDOMWrapperOwner : public JSC::WeakHandleOwner {
-public:
-JSDOMWrapperOwner(DOMWrapperWorld*);
-virtual void finalize(JSC::HandleJSC::Unknown, void* context);
-
-private:
-DOMWrapperWorld* m_world;
-};
-
-inline JSDOMWrapperOwner::JSDOMWrapperOwner(DOMWrapperWorld* world)
-: m_world(world)
-{
-}
-
 class JSStringOwner : public JSC::WeakHandleOwner {
 public:
 JSStringOwner(DOMWrapperWorld*);
@@ -86,7 +72,6 @@
 bool isNormal() const { return m_isNormal; }
 
 JSC::JSGlobalData* globalData() const { return m_globalData; }
-JSDOMWrapperOwner* defaultWrapperOwner() { return m_defaultWrapperOwner; }
 JSStringOwner* stringWrapperOwner() { return m_stringWrapperOwner; }
 
 protected:
@@ -96,7 +81,6 @@
 JSC::JSGlobalData* m_globalData;
 HashSetScriptController* m_scriptControllersWithWindowShells;
 bool m_isNormal;
-JSDOMWrapperOwner m_defaultWrapperOwner;
 JSStringOwner m_stringWrapperOwner;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101421] trunk/Source/WebCore

[arv]

Title: [101421] trunk/Source/WebCore








Revision 101421
Author a...@chromium.org
Date 2011-11-29 13:58:18 -0800 (Tue, 29 Nov 2011)


Log Message
Add support for [ClassMethod] to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=73342

Reviewed by Adam Barth.

If a method is annotated with [ClassMethod] it will become a method on the JS constructor object and it will
call a static function on the C++ class.

This was previously only implemented in CodeGeneratorV8.pm so this brings JSC up to par.

No new tests: Covered by bindings/scripts/test/

* bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionName): Refactor to reduce code duplication.
(GenerateHeader): Ditto.
(GenerateOverloadedFunction): This now handles both prototype functions and constructor functions.
(GenerateImplementation): Define class methods too.
(GenerateParametersCheck): Generate the right function access string.
(GenerateImplementationFunctionCall): SVG properties are not static methods.
(GenerateConstructorDefinition): For classes that have static methods we may now return function properties.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot): Ditto.
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): Ditto.
(WebCore::jsTestObjConstructorFunctionClassMethod): Now calls a static function.
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Ditto.
* bindings/scripts/test/JS/JSTestObj.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101420 => 101421)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 21:55:35 UTC (rev 101420)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 21:58:18 UTC (rev 101421)
@@ -1,3 +1,32 @@
+2011-11-29  Erik Arvidsson  a...@chromium.org
+
+Add support for [ClassMethod] to CodeGeneratorJS.pm
+https://bugs.webkit.org/show_bug.cgi?id=73342
+
+Reviewed by Adam Barth.
+
+If a method is annotated with [ClassMethod] it will become a method on the JS constructor object and it will
+call a static function on the C++ class. 
+
+This was previously only implemented in CodeGeneratorV8.pm so this brings JSC up to par.
+
+No new tests: Covered by bindings/scripts/test/
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GetFunctionName): Refactor to reduce code duplication.
+(GenerateHeader): Ditto.
+(GenerateOverloadedFunction): This now handles both prototype functions and constructor functions.
+(GenerateImplementation): Define class methods too. 
+(GenerateParametersCheck): Generate the right function access string.
+(GenerateImplementationFunctionCall): SVG properties are not static methods.
+(GenerateConstructorDefinition): For classes that have static methods we may now return function properties.
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::JSTestObjConstructor::getOwnPropertySlot): Ditto.
+(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor): Ditto.
+(WebCore::jsTestObjConstructorFunctionClassMethod): Now calls a static function.
+(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional): Ditto.
+* bindings/scripts/test/JS/JSTestObj.h:
+
 2011-11-29  Sam Weinig  s...@webkit.org
 
 Remove unused JSDOMWrapperOwner


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (101420 => 101421)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-29 21:55:35 UTC (rev 101420)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-29 21:58:18 UTC (rev 101421)
@@ -648,6 +648,14 @@
 TouchList = 1
 );
 
+sub GetFunctionName
+{
+my ($className, $function) = @_;
+my $isStatic = $function-signature-extendedAttributes-{ClassMethod};
+my $kind = $isStatic ? Constructor : Prototype;
+return $codeGenerator-WK_lcfirst($className) . $kind . Function . $codeGenerator-WK_ucfirst($function-signature-name);
+}
+
 sub GenerateHeader
 {
 my $object = shift;
@@ -1086,7 +1094,7 @@
 push(@headerContent,// Functions\n\n);
 foreach my $function (@{$dataNode-functions}) {
 next if $function-{overloadIndex}  $function-{overloadIndex}  1;
-my $functionName = $codeGenerator-WK_lcfirst($className) . PrototypeFunction . $codeGenerator-WK_ucfirst($function-signature-name);
+my $functionName = GetFunctionName($className, $function);
 push(@headerContent, JSC::EncodedJSValue JSC_HOST_CALL ${functionName}(JSC::ExecState*);\n);
 }
 }
@@ -1274,7 +1282,7 @@
 return (join( || , @orExpression), @neededArguments);
 }
 
-sub GenerateOverloadedPrototypeFunction
+sub GenerateOverloadedFunction
 {
 my $function = shift;
 my $dataNode = shift;

[webkit-changes] [101423] trunk/LayoutTests/platform

[zmo]

Title: [101423] trunk/LayoutTests/platform








Revision 101423
Author z...@google.com
Date 2011-11-29 14:22:00 -0800 (Tue, 29 Nov 2011)


Log Message
Webkit gardening: rebaseline.

Modified Paths

trunk/LayoutTests/platform/chromium-win/svg/text/select-x-list-1-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/text/select-x-list-2-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/text/select-x-list-3-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/text/select-x-list-4-expected.txt
trunk/LayoutTests/platform/chromium-win/transforms/svg-vs-css-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt
trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-1-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-2-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-3-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-4-expected.png
trunk/LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt




Diff

Deleted: trunk/LayoutTests/platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt (101422 => 101423)

--- trunk/LayoutTests/platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt	2011-11-29 22:08:09 UTC (rev 101422)
+++ trunk/LayoutTests/platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.txt	2011-11-29 22:22:00 UTC (rev 101423)
@@ -1,9 +0,0 @@
-layer at (0,0) size 785x616
-  RenderView at (0,0) size 785x600
-layer at (0,0) size 785x616
-  RenderBlock {HTML} at (0,0) size 785x616
-RenderBody {BODY} at (8,8) size 769x600
-  RenderSVGRoot {svg} at (8,8) size 458x163
-RenderSVGPath {path} at (8,8) size 88x78 [stroke={[type=SOLID] [color=#00] [stroke width=10.00]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-15 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-14 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
-RenderSVGPath {path} at (200,46) size 138x135 [transform={m=((1.00,0.00)(0.00,1.00)) t=(250.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-15 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-14 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
-RenderSVGPath {path} at (349,46) size 127x132 [transform={m=((1.00,0.00)(0.00,1.00)) t=(400.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.53081e-15 25 L -29.3893 40.4509 L -23.7764 7.72542 L -47.5528 -15.4508 L -14.6946 -20.2254 L -9.18455e-15 -50 L 14.6946 -20.2254 L 47.5528 -15.4508 L 23.7764 7.72542 L 29.3893 40.4509 Z]


Deleted: trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-1-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-2-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-3-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac/svg/text/select-x-list-4-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt (101422 => 101423)

--- trunk/LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt	2011-11-29 22:08:09 UTC (rev 101422)
+++ trunk/LayoutTests/platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.txt	2011-11-29 22:22:00 UTC (rev 101423)
@@ -1,9 +0,0 @@
-layer at (0,0) size 785x616
-  RenderView at (0,0) size 785x600
-layer at (0,0) size 785x616
-  RenderBlock {HTML} at (0,0) size 785x616
-RenderBody {BODY} at (8,8) size 769x600
-  RenderSVGRoot {svg} at (8,8) size 458x163
-RenderSVGPath {path} at (8,8) size 88x78 [stroke={[type=SOLID] [color=#00] [stroke width=10.00]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-015 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-014 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
-RenderSVGPath {path} at (200,46) size 138x135 [transform={m=((1.00,0.00)(0.00,1.00)) t=(250.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] [fill={[type=SOLID] [color=#99]}] [data="" 1.83697e-015 30 L -35.2671 48.541 L -28.5317 9.27051 L -57.0634 -18.541 L -17.6336 -24.2705 L -1.10215e-014 -60 L 17.6336 -24.2705 L 57.0634 -18.541 L 28.5317 9.27051 L 35.2671 48.541 Z]
-RenderSVGPath {path} at (349,46) size 127x132 [transform={m=((1.00,0.00)(0.00,1.00)) t=(400.00,100.00)}] [stroke={[type=SOLID] [color=#00] [stroke width=10.00] [dash array={20.00}]}] 

[webkit-changes] [101424] trunk/Source/WebCore

[tony]

Title: [101424] trunk/Source/WebCore








Revision 101424
Author t...@chromium.org
Date 2011-11-29 14:42:16 -0800 (Tue, 29 Nov 2011)


Log Message
Rename some flexbox functions to be less confusing
https://bugs.webkit.org/show_bug.cgi?id=73363

Reviewed by Ojan Vafai.

These methods no longer have anything to do with block/inline direction.

No new tests, just renaming some functions.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/RenderFlexibleBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101423 => 101424)

--- trunk/Source/WebCore/ChangeLog	2011-11-29 22:22:00 UTC (rev 101423)
+++ trunk/Source/WebCore/ChangeLog	2011-11-29 22:42:16 UTC (rev 101424)
@@ -1,3 +1,22 @@
+2011-11-29  Tony Chang  t...@chromium.org
+
+Rename some flexbox functions to be less confusing
+https://bugs.webkit.org/show_bug.cgi?id=73363
+
+Reviewed by Ojan Vafai.
+
+These methods no longer have anything to do with block/inline direction.
+
+No new tests, just renaming some functions.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::layoutBlock):
+(WebCore::RenderFlexibleBox::layoutFlexItems):
+(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
+(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
+(WebCore::RenderFlexibleBox::alignChildren):
+* rendering/RenderFlexibleBox.h:
+
 2011-11-29  Erik Arvidsson  a...@chromium.org
 
 Add support for [ClassMethod] to CodeGeneratorJS.pm


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (101423 => 101424)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-11-29 22:22:00 UTC (rev 101423)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-11-29 22:42:16 UTC (rev 101424)
@@ -168,14 +168,13 @@
 IntSize previousSize = size();
 
 setLogicalHeight(0);
-// We need to call both of these because we grab both crossAxisExtent and mainAxisExtent in layoutInlineDirection.
+// We need to call both of these because we grab both crossAxisExtent and mainAxisExtent in layoutFlexItems.
 computeLogicalWidth();
 computeLogicalHeight();
 
 m_overflow.clear();
 
-// FIXME: This is no longer named correctly. This should just be layoutFlexItems.
-layoutInlineDirection(relayoutChildren);
+layoutFlexItems(relayoutChildren);
 
 LayoutUnit oldClientAfterEdge = clientLogicalBottom();
 computeLogicalHeight();
@@ -498,7 +497,7 @@
 return mainAxisLength.calcMinValue(mainAxisContentExtent());
 }
 
-void RenderFlexibleBox::layoutInlineDirection(bool relayoutChildren)
+void RenderFlexibleBox::layoutFlexItems(bool relayoutChildren)
 {
 LayoutUnit preferredMainAxisExtent;
 float totalPositiveFlexibility;
@@ -511,12 +510,12 @@
 FlexOrderIterator flexIterator(this, treeIterator.flexOrderValues());
 InflexibleFlexItemSize inflexibleItems;
 WTF::VectorLayoutUnit childSizes;
-while (!runFreeSpaceAllocationAlgorithmInlineDirection(flexIterator, availableFreeSpace, totalPositiveFlexibility, totalNegativeFlexibility, inflexibleItems, childSizes)) {
+while (!runFreeSpaceAllocationAlgorithm(flexIterator, availableFreeSpace, totalPositiveFlexibility, totalNegativeFlexibility, inflexibleItems, childSizes)) {
 ASSERT(totalPositiveFlexibility = 0  totalNegativeFlexibility = 0);
 ASSERT(inflexibleItems.size()  0);
 }
 
-layoutAndPlaceChildrenInlineDirection(flexIterator, childSizes, availableFreeSpace, totalPositiveFlexibility);
+layoutAndPlaceChildren(flexIterator, childSizes, availableFreeSpace, totalPositiveFlexibility);
 }
 
 float RenderFlexibleBox::positiveFlexForChild(RenderBox* child) const
@@ -580,7 +579,7 @@
 }
 
 // Returns true if we successfully ran the algorithm and sized the flex items.
-bool RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection(FlexOrderIterator iterator, LayoutUnit availableFreeSpace, float totalPositiveFlexibility, float totalNegativeFlexibility, InflexibleFlexItemSize inflexibleItems, WTF::VectorLayoutUnit childSizes)
+bool RenderFlexibleBox::runFreeSpaceAllocationAlgorithm(FlexOrderIterator iterator, LayoutUnit availableFreeSpace, float totalPositiveFlexibility, float totalNegativeFlexibility, InflexibleFlexItemSize inflexibleItems, WTF::VectorLayoutUnit childSizes)
 {
 childSizes.clear();
 
@@ -636,7 +635,7 @@
 child-setOverrideWidth(childPreferredSize);
 }
 
-void RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection(FlexOrderIterator iterator, const WTF::VectorLayoutUnit childSizes, LayoutUnit 

[webkit-changes] [101425] trunk/Source/WebKit/chromium

[dpranke]

Title: [101425] trunk/Source/WebKit/chromium








Revision 101425
Author dpra...@chromium.org
Date 2011-11-29 14:46:17 -0800 (Tue, 29 Nov 2011)


Log Message
add webkit_user_agent to DRT and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=73362

Reviewed by Tony Chang.

In preparation for building webkit_glue as a separate component,
we need to explicitly declare DRT's and webkit_unit_tests'
dependencies on webkit_user_agent.

* WebKit.gyp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (101424 => 101425)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 22:42:16 UTC (rev 101424)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-29 22:46:17 UTC (rev 101425)
@@ -1,3 +1,16 @@
+2011-11-29  Dirk Pranke  dpra...@chromium.org
+
+add webkit_user_agent to DRT and webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=73362
+
+Reviewed by Tony Chang.
+
+In preparation for building webkit_glue as a separate component,
+we need to explicitly declare DRT's and webkit_unit_tests'
+dependencies on webkit_user_agent.
+
+* WebKit.gyp:
+
 2011-11-28  Adam Klein  ad...@chromium.org
 
 [chromium] WebKitMutationObserver::deliverAllMutations should be exposed through the Chromium API


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (101424 => 101425)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-11-29 22:42:16 UTC (rev 101424)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-11-29 22:46:17 UTC (rev 101425)
@@ -1008,6 +1008,7 @@
 '(chromium_src_dir)/base/base.gyp:base_i18n',
 '(chromium_src_dir)/base/base.gyp:test_support_base',
 '(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support',
+'(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_user_agent',
 ],
 'sources': [
 'tests/RunAllTests.cpp',
@@ -1082,6 +1083,7 @@
 '(chromium_src_dir)/v8/tools/gyp/v8.gyp:v8',
 '(chromium_src_dir)/webkit/support/webkit_support.gyp:blob',
 '(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_support',
+'(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_user_agent',
 ],
 'include_dirs': [
 '(chromium_src_dir)',






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101426] trunk/Source

[oliver]

Title: [101426] trunk/Source








Revision 101426
Author oli...@apple.com
Date 2011-11-29 15:36:33 -0800 (Tue, 29 Nov 2011)


Log Message
Allow WebCore to describe typed arrays to JSC
https://bugs.webkit.org/show_bug.cgi?id=73355

Reviewed by Gavin Barraclough.

Source/_javascript_Core:

Allow globaldata to track the structure of typed arrays.

* runtime/JSGlobalData.h:
(JSC::TypedArrayDescriptor::TypedArrayDescriptor):

Source/WebCore:

Update bindings codegen to report the data layout to JSC.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::finishCreation):
* bindings/scripts/test/JS/JSFloat64Array.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ClassInfo.h
trunk/Source/_javascript_Core/runtime/JSCell.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101425 => 101426)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-29 22:46:17 UTC (rev 101425)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-29 23:36:33 UTC (rev 101426)
@@ -1,3 +1,15 @@
+2011-11-29  Oliver Hunt  oli...@apple.com
+
+Allow WebCore to describe typed arrays to JSC
+https://bugs.webkit.org/show_bug.cgi?id=73355
+
+Reviewed by Gavin Barraclough.
+
+Allow globaldata to track the structure of typed arrays.
+
+* runtime/JSGlobalData.h:
+(JSC::TypedArrayDescriptor::TypedArrayDescriptor):
+
 2011-11-28  Filip Pizlo  fpi...@apple.com
 
 DFG debugCall() mechanism only works on X86 and X86-64


Modified: trunk/Source/_javascript_Core/runtime/ClassInfo.h (101425 => 101426)

--- trunk/Source/_javascript_Core/runtime/ClassInfo.h	2011-11-29 22:46:17 UTC (rev 101425)
+++ trunk/Source/_javascript_Core/runtime/ClassInfo.h	2011-11-29 23:36:33 UTC (rev 101426)
@@ -135,7 +135,8 @@
 ClassName::defineOwnProperty, \
 ClassName::getOwnPropertyDescriptor, \
 }, \
-sizeof(ClassName)
+sizeof(ClassName), \
+ClassName::TypedArrayStorageType
 
 struct ClassInfo {
 /**
@@ -184,6 +185,8 @@
 MethodTable methodTable;
 
 size_t cellSize;
+
+TypedArrayType typedArrayStorageType;
 };
 
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/runtime/JSCell.h (101425 => 101426)

--- trunk/Source/_javascript_Core/runtime/JSCell.h	2011-11-29 22:46:17 UTC (rev 101425)
+++ trunk/Source/_javascript_Core/runtime/JSCell.h	2011-11-29 23:36:33 UTC (rev 101426)
@@ -45,6 +45,18 @@
 IncludeDontEnumProperties
 };
 
+enum TypedArrayType {
+TypedArrayNone,
+TypedArrayInt8,
+TypedArrayInt16,
+TypedArrayInt32,
+TypedArrayUint8,
+TypedArrayUint16,
+TypedArrayUint32,
+TypedArrayFloat32,
+TypedArrayFloat64
+};
+
 class JSCell {
 friend class JSValue;
 friend class MarkedBlock;
@@ -131,6 +143,7 @@
 Structure* unvalidatedStructure() { return m_structure.unvalidatedGet(); }
 #endif
 
+static const TypedArrayType TypedArrayStorageType = TypedArrayNone;
 protected:
 
 void finishCreation(JSGlobalData);


Modified: trunk/Source/_javascript_Core/runtime/JSGlobalData.h (101425 => 101426)

--- trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-11-29 22:46:17 UTC (rev 101425)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalData.h	2011-11-29 23:36:33 UTC (rev 101426)
@@ -103,6 +103,24 @@
 ThreadStackTypeSmall
 };
 
+struct TypedArrayDescriptor {
+TypedArrayDescriptor()
+: m_vptr(0)
+, m_storageOffset(0)
+, m_lengthOffset(0)
+{
+}
+TypedArrayDescriptor(void* vptr, size_t storageOffset, size_t lengthOffset)
+: m_vptr(vptr)
+, m_storageOffset(storageOffset)
+, m_lengthOffset(lengthOffset)
+{
+}
+void* m_vptr;
+size_t m_storageOffset;
+size_t m_lengthOffset;
+};
+
 class JSGlobalData : public RefCountedJSGlobalData {
 public:
 // WebCore has a one-to-one mapping of threads to JSGlobalDatas;
@@ -319,6 +337,22 @@
 unsigned m_timeoutCount;
 #endif
 
+#define registerTypedArrayFunction(type, capitalizedType) \
+void registerTypedArrayDescriptor(const capitalizedType##Array*, const TypedArrayDescriptor descriptor) \
+{ \
+ASSERT(!m_##type##ArrayDescriptor.m_vptr || m_##type##ArrayDescriptor.m_vptr == descriptor.m_vptr); \
+m_##type##ArrayDescriptor = descriptor; \
+}
+registerTypedArrayFunction(int8, Int8);
+

[webkit-changes] [101427] trunk/LayoutTests/platform

[zmo]

Title: [101427] trunk/LayoutTests/platform








Revision 101427
Author z...@google.com
Date 2011-11-29 15:49:09 -0800 (Tue, 29 Nov 2011)


Log Message
Webkit gardening: rebaseline.

Modified Paths

trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt
trunk/LayoutTests/platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-creation-expected.png
trunk/LayoutTests/platform/mac-future/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-gradient-creation-expected.png
trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-pattern-creation-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png
trunk/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png




Diff

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101426 => 101427)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 23:36:33 UTC (rev 101426)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-11-29 23:49:09 UTC (rev 101427)
@@ -2308,7 +2308,6 @@
 
 // Failing somewhere between after Webkit r69367 and r69417.
 BUGCR58970 LINUX : svg/text/text-tselect-02-f.svg = PASS IMAGE
-BUGCR58931 LINUX WIN : svg/W3C-SVG-1.1/pservers-grad-17-b.svg = PASS IMAGE
 
 // Failing from r69420, mac failing from r71493:r71496
 BUGCR58735 SLOW : http/tests/misc/prefetch-purpose.html = PASS
@@ -2322,7 +2321,6 @@
 BUGWK46600 SKIP : fast/dom/nodesFromRect-inner-documents.html = TEXT
 
 // Many flaky SVG tests
-BUGCR59671 LINUX : svg/W3C-SVG-1.1-SE/pservers-grad-17-b.svg = PASS IMAGE+TEXT
 BUGCR59671 LINUX : svg/custom/convolution-crash.svg = PASS TEXT
 BUGCR59671 LINUX : svg/custom/repaint-on-constant-size-change.svg = PASS IMAGE
 BUGCR59671 LINUX : svg/carto.net/slider.svg = PASS IMAGE
@@ -3367,9 +3365,6 @@
 
 BUGWK66873 SLOW WIN RELEASE : http/tests/loading/redirect-methods.html = PASS TEXT
 
-BUGWK66882 WIN : svg/W3C-SVG-1.1-SE/text-intro-09-b.svg = PASS IMAGE+TEXT
-BUGWK66882 LINUX MAC : svg/W3C-SVG-1.1-SE/text-intro-09-b.svg = PASS IMAGE
-
 BUGWK66888 DEBUG : svg/animations/svginteger-animation-1.html = PASS TEXT
 
 BUGWK66900 LINUX DEBUG : fast/writing-mode/japanese-rl-text-with-broken-font.html = PASS IMAGE+TEXT
@@ -3579,8 +3574,6 @@
 BUGWK70298 : fast/table/border-collapsing/cached-69296.html = IMAGE PASS
 BUGWK70298 : http/tests/security/xssAuditor/cookie-injection.html = TEXT PASS
 BUGWK70298 : plugins/hidden-iframe-with-swf-plugin.html = FAIL TIMEOUT PASS
-BUGWK70298 : svg/custom/js-late-gradient-creation.svg = IMAGE PASS
-BUGWK70298 : svg/custom/js-late-pattern-creation.svg = IMAGE PASS
 
 // Failing since ~r97700.
 BUGWK70298 WIN LINUX SNOWLEOPARD : fast/selectors/unqualified-hover-strict.html = IMAGE+TEXT PASS


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-gradient-creation-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/js-late-pattern-creation-expected.png

(Binary files differ)


Added: 

[webkit-changes] [101429] trunk/Source/WebKit/chromium

[commit-queue]

Title: [101429] trunk/Source/WebKit/chromium








Revision 101429
Author commit-qu...@webkit.org
Date 2011-11-29 16:19:58 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed, rolling out r101418.
http://trac.webkit.org/changeset/101418
https://bugs.webkit.org/show_bug.cgi?id=73372

Chromium renderer crashes with ENABLE(MUTATION_OBSERVERS)
(Requested by aklein on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-11-29

* public/platform/WebThread.h:
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::shutdown):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebThread.h
trunk/Source/WebKit/chromium/src/WebKit.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (101428 => 101429)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-30 00:19:50 UTC (rev 101428)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-30 00:19:58 UTC (rev 101429)
@@ -1,3 +1,17 @@
+2011-11-29  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r101418.
+http://trac.webkit.org/changeset/101418
+https://bugs.webkit.org/show_bug.cgi?id=73372
+
+Chromium renderer crashes with ENABLE(MUTATION_OBSERVERS)
+(Requested by aklein on #webkit).
+
+* public/platform/WebThread.h:
+* src/WebKit.cpp:
+(WebKit::initialize):
+(WebKit::shutdown):
+
 2011-11-29  Dirk Pranke  dpra...@chromium.org
 
 add webkit_user_agent to DRT and webkit_unit_tests


Modified: trunk/Source/WebKit/chromium/public/platform/WebThread.h (101428 => 101429)

--- trunk/Source/WebKit/chromium/public/platform/WebThread.h	2011-11-30 00:19:50 UTC (rev 101428)
+++ trunk/Source/WebKit/chromium/public/platform/WebThread.h	2011-11-30 00:19:58 UTC (rev 101429)
@@ -43,16 +43,8 @@
 virtual void run() = 0;
 };
 
-class TaskObserver {
-public:
-virtual ~TaskObserver() { }
-virtual void didProcessTask() = 0;
-};
-
 virtual void postTask(Task*) = 0;
 virtual void postDelayedTask(Task*, long long delayMs) = 0;
-virtual void addTaskObserver(TaskObserver*) { }
-virtual void removeTaskObserver(TaskObserver*) { }
 
 virtual ~WebThread() { }
 };


Modified: trunk/Source/WebKit/chromium/src/WebKit.cpp (101428 => 101429)

--- trunk/Source/WebKit/chromium/src/WebKit.cpp	2011-11-30 00:19:50 UTC (rev 101428)
+++ trunk/Source/WebKit/chromium/src/WebKit.cpp	2011-11-30 00:19:58 UTC (rev 101429)
@@ -39,11 +39,9 @@
 #include Settings.h
 #include TextEncoding.h
 #include V8Binding.h
-#include WebKitMutationObserver.h
 #include WebKitPlatformSupport.h
 #include WebMediaPlayerClientImpl.h
 #include WebSocket.h
-#include WebThread.h
 #include WorkerContextExecutionProxy.h
 #include v8.h
 
@@ -54,22 +52,6 @@
 
 namespace WebKit {
 
-#if ENABLE(MUTATION_OBSERVERS)
-namespace {
-
-class EndOfTaskRunner : public WebThread::TaskObserver {
-public:
-virtual void didProcessTask()
-{
-WebCore::WebKitMutationObserver::deliverAllMutations();
-}
-};
-
-} // namespace
-
-static WebThread::TaskObserver* s_endOfTaskRunner = 0;
-#endif // ENABLE(MUTATION_OBSERVERS)
-
 // Make sure we are not re-initialized in the same address space.
 // Doing so may cause hard to reproduce crashes.
 static bool s_webKitInitialized = false;
@@ -93,12 +75,6 @@
 v8::V8::SetEntropySource(generateEntropy);
 v8::V8::Initialize();
 WebCore::V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
-
-#if ENABLE(MUTATION_OBSERVERS)
-ASSERT(!s_endOfTaskRunner);
-s_endOfTaskRunner = new EndOfTaskRunner;
-webKitPlatformSupport-currentThread()-addTaskObserver(s_endOfTaskRunner);
-#endif
 }
 
 void initializeWithoutV8(WebKitPlatformSupport* webKitPlatformSupport)
@@ -131,13 +107,6 @@
 {
 delete WebCore::CCProxy::mainThread();
 WebCore::CCProxy::setMainThread(0);
-#if ENABLE(MUTATION_OBSERVERS)
-if (s_endOfTaskRunner) {
-s_webKitPlatformSupport-currentThread()-removeTaskObserver(s_endOfTaskRunner);
-delete s_endOfTaskRunner;
-s_endOfTaskRunner = 0;
-}
-#endif
 s_webKitPlatformSupport = 0;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101430] trunk

[xji]

Title: [101430] trunk








Revision 101430
Author x...@chromium.org
Date 2011-11-29 16:23:23 -0800 (Tue, 29 Nov 2011)


Log Message
--webkit-visual-word should be able to reach end of text, instead of end of line
https://bugs.webkit.org/show_bug.cgi?id=72048

Reviewed by Ryosuke Niwa.

Source/WebCore: 

Revert r92223 -- webkit-visual-word should reach boundary of line.
When there is no more left or right words in the same editing boundary and
current position is an editable position, return start or end position in this
editable content.

Test: editing/selection/move-by-word-visually-textarea.html

* editing/visible_units.cpp:
(WebCore::collectWordBreaksInBoxInsideBlockWithSameDirectionality):
(WebCore::collectWordBreaksInBoxInsideBlockWithDifferntDirectionality):
(WebCore::leftWordPosition):
(WebCore::rightWordPosition):

LayoutTests: 

* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
* editing/selection/move-by-word-visually-multi-line-expected.txt:
* editing/selection/move-by-word-visually-multi-line.html:
* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
* editing/selection/move-by-word-visually-textarea-expected.txt: Added.
* editing/selection/move-by-word-visually-textarea.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element.html
trunk/LayoutTests/editing/selection/move-by-word-visually-multi-line-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-multi-line.html
trunk/LayoutTests/editing/selection/move-by-word-visually-single-space-inline-element-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/visible_units.cpp


Added Paths

trunk/LayoutTests/editing/selection/move-by-word-visually-textarea-expected.txt
trunk/LayoutTests/editing/selection/move-by-word-visually-textarea.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101429 => 101430)

--- trunk/LayoutTests/ChangeLog	2011-11-30 00:19:58 UTC (rev 101429)
+++ trunk/LayoutTests/ChangeLog	2011-11-30 00:23:23 UTC (rev 101430)
@@ -1,3 +1,18 @@
+2011-11-10  Xiaomei Ji  x...@chromium.org
+
+--webkit-visual-word should be able to reach end of text, instead of end of line
+https://bugs.webkit.org/show_bug.cgi?id=72048
+
+Reviewed by Ryosuke Niwa.
+
+* editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt:
+* editing/selection/move-by-word-visually-inline-block-positioned-element.html:
+* editing/selection/move-by-word-visually-multi-line-expected.txt:
+* editing/selection/move-by-word-visually-multi-line.html:
+* editing/selection/move-by-word-visually-single-space-inline-element-expected.txt:
+* editing/selection/move-by-word-visually-textarea-expected.txt: Added.
+* editing/selection/move-by-word-visually-textarea.html: Added.
+
 2011-11-29  Alan Stearns  stea...@adobe.com
 
 Clean up fast/regions/no-split-line-box.html test


Modified: trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt (101429 => 101430)

--- trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt	2011-11-30 00:19:58 UTC (rev 101429)
+++ trunk/LayoutTests/editing/selection/move-by-word-visually-inline-block-positioned-element-expected.txt	2011-11-30 00:23:23 UTC (rev 101430)
@@ -2,32 +2,32 @@
  Move By Word 
 Test 1, LTR:
 Move right by one word
-begin start[0, 6, 11], abc def[0, 4, 7], end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+begin start[0, 6], abc def[0, 4], end ing[0, 4], this is float[0, 5, 8], this is fixed[5, 8], this is relative[0, 5, 8], this is absolute[0, 5, 8, 16]
 Move left by one word
 this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
 Test 2, LTR:
 Move right by one word
-abc def[0, 4, 7], end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+abc def[0, 4], end ing[0, 4], this is float[0, 5, 8], this is fixed[5, 8], this is relative[0, 5, 8], this is absolute[0, 5, 8, 16]
 Move left by one word
 this is absolute[16, 8, 5, 0], this is relative[8, 5, 0], this is fixed[8, 5], this is float[8, 5, 0], end ing[4, 0], abc def[4, 0], begin start[6, 0]
 Test 3, LTR:
 Move right by one word
-end ing[0, 4, 7], this is float[0, 5, 8, 13], this is fixed[5, 8, 13], this is relative[0, 5, 8, 16], this is absolute[0, 5, 8, 16]
+end ing[0, 4], this is float[0, 5, 8], this is fixed[5, 8], this is 

[webkit-changes] [101431] trunk/Source/WebCore

[haraken]

Title: [101431] trunk/Source/WebCore








Revision 101431
Author hara...@chromium.org
Date 2011-11-29 16:30:19 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed. Rebaselined a run-bindings-tests result.

* bindings/scripts/test/JS/JSFloat64Array.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101430 => 101431)

--- trunk/Source/WebCore/ChangeLog	2011-11-30 00:23:23 UTC (rev 101430)
+++ trunk/Source/WebCore/ChangeLog	2011-11-30 00:30:19 UTC (rev 101431)
@@ -1,3 +1,9 @@
+2011-11-29  Kentaro Hara  hara...@chromium.org
+
+Unreviewed. Rebaselined a run-bindings-tests result.
+
+* bindings/scripts/test/JS/JSFloat64Array.h:
+
 2011-11-10  Xiaomei Ji  x...@chromium.org
 
 --webkit-visual-word should be able to reach end of text, instead of end of line


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h (101430 => 101431)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h	2011-11-30 00:23:23 UTC (rev 101430)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSFloat64Array.h	2011-11-30 00:30:19 UTC (rev 101431)
@@ -57,7 +57,7 @@
 {
 return static_castFloat64Array*(Base::impl());
 }
-static const TypedArrayType TypedArrayStorageType = TypedArrayFloat64;
+static const JSC::TypedArrayType TypedArrayStorageType = JSC::TypedArrayFloat64;
 intptr_t m_storageLength;
 void* m_storage;
 protected:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101433] trunk/Source/WebCore

[arv]

Title: [101433] trunk/Source/WebCore








Revision 101433
Author a...@chromium.org
Date 2011-11-29 16:38:05 -0800 (Tue, 29 Nov 2011)


Log Message
WebIDL: Add support for static for JSC and V8
https://bugs.webkit.org/show_bug.cgi?id=72998

Reviewed by Adam Barth.

WebIDL uses static for class methods. We used to use [ClassMethod]. This change makes us use the WebIDL syntax instead.

No new tests: Covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GetFunctionName): Use isStatic instead.
(GenerateOverloadedFunction): Ditto.
(GenerateImplementation): Ditto.
(GenerateParametersCheck): Ditto.
(GenerateImplementationFunctionCall): Ditto.
(GenerateConstructorDefinition): Ditto.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback): Ditto.
(GenerateImplementation): Ditto.
(GenerateFunctionCallString): Ditto.
* bindings/scripts/IDLParser.pm:
(ParseInterface): Set isStatic as needed.
* bindings/scripts/IDLStructure.pm: Update regular _expression_ to parse static.
* bindings/scripts/test/TestObj.idl: Use static instead of [ClassMethod].
* storage/IDBKeyRange.idl: Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/IDLParser.pm
trunk/Source/WebCore/bindings/scripts/IDLStructure.pm
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
trunk/Source/WebCore/storage/IDBKeyRange.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (101432 => 101433)

--- trunk/Source/WebCore/ChangeLog	2011-11-30 00:30:48 UTC (rev 101432)
+++ trunk/Source/WebCore/ChangeLog	2011-11-30 00:38:05 UTC (rev 101433)
@@ -1,3 +1,31 @@
+2011-11-29  Erik Arvidsson  a...@chromium.org
+
+WebIDL: Add support for static for JSC and V8
+https://bugs.webkit.org/show_bug.cgi?id=72998
+
+Reviewed by Adam Barth.
+
+WebIDL uses static for class methods. We used to use [ClassMethod]. This change makes us use the WebIDL syntax instead.
+
+No new tests: Covered by existing tests.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GetFunctionName): Use isStatic instead.
+(GenerateOverloadedFunction): Ditto.
+(GenerateImplementation): Ditto.
+(GenerateParametersCheck): Ditto.
+(GenerateImplementationFunctionCall): Ditto.
+(GenerateConstructorDefinition): Ditto.
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateFunctionCallback): Ditto.
+(GenerateImplementation): Ditto.
+(GenerateFunctionCallString): Ditto.
+* bindings/scripts/IDLParser.pm:
+(ParseInterface): Set isStatic as needed.
+* bindings/scripts/IDLStructure.pm: Update regular _expression_ to parse static.
+* bindings/scripts/test/TestObj.idl: Use static instead of [ClassMethod].
+* storage/IDBKeyRange.idl: Ditto.
+
 2011-11-29  Kentaro Hara  hara...@chromium.org
 
 Unreviewed. Rebaselined a run-bindings-tests result.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (101432 => 101433)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-30 00:30:48 UTC (rev 101432)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-11-30 00:38:05 UTC (rev 101433)
@@ -651,8 +651,7 @@
 sub GetFunctionName
 {
 my ($className, $function) = @_;
-my $isStatic = $function-signature-extendedAttributes-{ClassMethod};
-my $kind = $isStatic ? Constructor : Prototype;
+my $kind = $function-isStatic ? Constructor : Prototype;
 return $codeGenerator-WK_lcfirst($className) . $kind . Function . $codeGenerator-WK_ucfirst($function-signature-name);
 }
 
@@ -1309,8 +1308,7 @@
 # overload is applicable, precedence is given according to the order of
 # declaration in the IDL.
 
-my $isStatic = $function-signature-extendedAttributes-{ClassMethod};
-my $kind = $isStatic ? Constructor : Prototype;
+my $kind = $function-isStatic ? Constructor : Prototype;
 my $functionName = js${implClassName}${kind}Function . $codeGenerator-WK_ucfirst($function-signature-name);
 
 push(@implContent, EncodedJSValue JSC_HOST_CALL ${functionName}(ExecState* exec)\n);
@@ -1405,7 +1403,7 @@
 }
 
 foreach my $function (@{$dataNode-functions}) {
-next unless ($function-signature-extendedAttributes-{ClassMethod});
+next unless ($function-isStatic);
 next if $function-{overloadIndex}  $function-{overloadIndex}  1;
 my $name = $function-signature-name;
 push(@hashKeys, $name);
@@ -1466,7 +1464,7 @@
 }
 
 foreach my $function (@{$dataNode-functions}) {
-next if ($function-signature-extendedAttributes-{ClassMethod});
+next if ($function-isStatic);
 next if $function-{overloadIndex}  $function-{overloadIndex}  1;
 my $name = $function-signature-name;
 push(@hashKeys, $name);
@@ -2064,8 +2062,6 @@
 
 

[webkit-changes] [101434] trunk

[kevino]

Title: [101434] trunk








Revision 101434
Author kev...@webkit.org
Date 2011-11-29 16:45:37 -0800 (Tue, 29 Nov 2011)


Log Message
[wx] Unreviewed build fix for Leopard compilation.

Modified Paths

trunk/ChangeLog
trunk/wscript




Diff

Modified: trunk/ChangeLog (101433 => 101434)

--- trunk/ChangeLog	2011-11-30 00:38:05 UTC (rev 101433)
+++ trunk/ChangeLog	2011-11-30 00:45:37 UTC (rev 101434)
@@ -1,3 +1,9 @@
+2011-11-29  Kevin Ollivier  kev...@theolliviers.com
+
+[wx] Unreviewed build fix for Leopard compilation.
+
+* wscript:
+
 2011-11-29  Philippe Normand  pnorm...@igalia.com
 
 [GTK] hide WebAudio build option until support for FFTW is removed


Modified: trunk/wscript (101433 => 101434)

--- trunk/wscript	2011-11-30 00:38:05 UTC (rev 101433)
+++ trunk/wscript	2011-11-30 00:45:37 UTC (rev 101434)
@@ -177,7 +177,6 @@
 elif sys.platform.startswith('darwin'):
 webcore_dirs.append('Source/WebCore/plugins/mac')
 webcore_dirs.append('Source/WebCore/platform/wx/wxcode/mac/carbon')
-webcore_dirs.append('Source/WebCore/platform/mac')
 webcore_dirs.append('Source/WebCore/platform/text/mac')
 webcore_sources['wx-mac'] = [
'Source/WebCore/platform/mac/PurgeableBufferMac.cpp',
@@ -354,7 +353,7 @@
 excludes.append('HyphenationCF.cpp')
 
 if sys.platform.startswith('darwin'):
-webcore.includes += ' Source/WebKit/mac/WebCoreSupport WebCore/platform/mac'
+webcore.includes += ' Source/WebKit/mac/WebCoreSupport Source/WebCore/platform/mac'
 webcore.source += ' Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm'
 
 if building_on_win32:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101439] trunk/LayoutTests

[simon . fraser]

Title: [101439] trunk/LayoutTests








Revision 101439
Author simon.fra...@apple.com
Date 2011-11-29 17:44:00 -0800 (Tue, 29 Nov 2011)


Log Message
Update Mac results after r101342.

* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/transforms/svg-vs-css-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt
trunk/LayoutTests/platform/mac/transforms/svg-vs-css-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101438 => 101439)

--- trunk/LayoutTests/ChangeLog	2011-11-30 01:20:23 UTC (rev 101438)
+++ trunk/LayoutTests/ChangeLog	2011-11-30 01:44:00 UTC (rev 101439)
@@ -1,3 +1,10 @@
+2011-11-29  Simon Fraser  simon.fra...@apple.com
+
+Update Mac results after r101342.
+
+* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
+* platform/mac/transforms/svg-vs-css-expected.txt:
+
 2011-11-29  Zhenyao Mo  z...@google.com
 
 Webkit gardening: chromium rebaseline.


Modified: trunk/LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt (101438 => 101439)

--- trunk/LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt	2011-11-30 01:20:23 UTC (rev 101438)
+++ trunk/LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt	2011-11-30 01:44:00 UTC (rev 101439)
@@ -1,11 +1,11 @@
-layer at (0,0) size 800x130028
+layer at (0,0) size 800x130018
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x130028 backgroundClip at (0,0) size 800x1073741823 clip at (0,0) size 800x1073741823 outlineClip at (0,0) size 800x1073741823
-  RenderBlock {HTML} at (0,0) size 800x130028
-RenderBody {BODY} at (8,8) size 784x130012
-  RenderBlock {DIV} at (0,0) size 784x130010
-  RenderBlock {DIV} at (0,130012) size 784x0
-  RenderBlock {DIV} at (0,130014) size 784x0
-layer at (10,10) size 161x130006 backgroundClip at (10,10) size 161x1073741813 clip at (11,11) size 159x1073741812 outlineClip at (0,0) size 800x1073741823
-  RenderTextControl {TEXTAREA} at (2,2) size 161x130006 [bgcolor=#FF] [border: (1px solid #00)]
+layer at (0,0) size 800x130018 backgroundClip at (0,0) size 800x1073741823 clip at (0,0) size 800x1073741823 outlineClip at (0,0) size 800x1073741823
+  RenderBlock {HTML} at (0,0) size 800x130018
+RenderBody {BODY} at (8,8) size 784x130002
+  RenderBlock {DIV} at (0,0) size 784x13
+  RenderBlock {DIV} at (0,130002) size 784x0
+  RenderBlock {DIV} at (0,130004) size 784x0
+layer at (10,0) size 161x130006 backgroundClip at (10,0) size 161x1073741823 clip at (11,1) size 159x1073741822 outlineClip at (0,0) size 800x1073741823
+  RenderTextControl {TEXTAREA} at (2,-8) size 161x130006 [bgcolor=#FF] [border: (1px solid #00)]
 RenderBlock {DIV} at (3,3) size 155x13


Modified: trunk/LayoutTests/platform/mac/transforms/svg-vs-css-expected.txt (101438 => 101439)

--- trunk/LayoutTests/platform/mac/transforms/svg-vs-css-expected.txt	2011-11-30 01:20:23 UTC (rev 101438)
+++ trunk/LayoutTests/platform/mac/transforms/svg-vs-css-expected.txt	2011-11-30 01:44:00 UTC (rev 101439)
@@ -34,9 +34,9 @@
 RenderSVGRoot {svg} at (29,108) size 196x174
   RenderSVGContainer {g} at (29,108) size 196x174 [transform={m=((1.00,0.00)(0.00,1.00)) t=(75.00,25.00)}]
 RenderSVGPath {rect} at (103,109) size 62x62 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
-RenderSVGContainer {g} at (29,108) size 197x174 [transform={m=((2.00,0.00)(0.00,2.00)) t=(0.00,0.00)}]
-  RenderSVGPath {rect} at (102,108) size 124x124 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
-  RenderSVGPath {rect} at (29,106) size 163x178 [transform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
+RenderSVGContainer {g} at (29,108) size 196x174 [transform={m=((2.00,0.00)(0.00,2.00)) t=(0.00,0.00)}]
+  RenderSVGPath {rect} at (103,109) size 122x122 [stroke={[type=SOLID] [color=#00] [dash array={1.00, 1.00}]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
+  RenderSVGPath {rect} at (29,108) size 162x174 [transform={m=((0.71,0.71)(-0.71,0.71)) t=(0.00,0.00)}] [stroke={[type=SOLID] [color=#FF]}] [x=0.00] [y=0.00] [width=60.00] [height=60.00]
 RenderText {#text} at (0,0) size 0x0
 layer at (28,350) size 200x200
   RenderBlock (relative positioned) {div} at (10,332) size 200x200 [bgcolor=#C0C0C0] [border: (1px solid #00)]
@@ -49,7 +49,7 @@
 layer at (272,84) size 200x200
   RenderBlock (relative positioned) {div} at (10,66) size 200x200 [bgcolor=#C0C0C0] [border: (1px solid #00)]
 RenderSVGRoot {svg} at (273,108) size 162x174

[webkit-changes] [101441] trunk/Source

[jberlin]

Title: [101441] trunk/Source








Revision 101441
Author jber...@webkit.org
Date 2011-11-29 18:29:06 -0800 (Tue, 29 Nov 2011)


Log Message
WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
the first time it is called.
https://bugs.webkit.org/show_bug.cgi?id=73374 (rdar://problem/10196057)

Reviewed by Brady Eidson.

Source/WebCore:

Add a callback for when the Storage Tracker is done loading the list of origins with Local
Storage.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::StorageTracker):
Keep track of whether the import from disk has been completed.
(WebCore::StorageTracker::notifyFinishedImportingOriginIdentifiersOnMainThread):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
Set m_finishedImportingOriginIdentifiers to true and tell the client.
(WebCore::StorageTracker::syncImportOriginIdentifiers):
When finished, notify the shared StorageTracker on the main thread.
* storage/StorageTracker.h:
(WebCore::StorageTracker::originsLoaded):

* storage/StorageTrackerClient.h:
Add didFinishLoadingOrigins.

Source/WebKit/mac:

* Storage/WebStorageTrackerClient.h:
* Storage/WebStorageTrackerClient.mm:
(WebStorageTrackerClient::didFinishLoadingOrigins):

Source/WebKit2:

Queue any requests for the origins that have Local Storage until the StorageTracker is done
loading the list of those origins from disk.

* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
(WebKit::keyValueStorageOriginIdentifiers):
Refactored here from getKeyValueStorageOrigins so it can be used by didFinishLoadingOrigins.
(WebKit::dispatchDidGetKeyValueStorageOrigins):
Ditto.
(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
If the StorageTracker is not done loading the list of origins from disk, queue up the
request to be handled later.
(WebKit::WebKeyValueStorageManager::didFinishLoadingOrigins):
Dispatch the results for any requests that were make before the StorageTracker was done
loading the list of origins from disk.
(WebKit::WebKeyValueStorageManager::dispatchDidModifyOrigin):
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Set the WebKeyValueStorageManager as the StorageTrackerClient.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/storage/StorageTracker.cpp
trunk/Source/WebCore/storage/StorageTracker.h
trunk/Source/WebCore/storage/StorageTrackerClient.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.h
trunk/Source/WebKit/mac/Storage/WebStorageTrackerClient.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp
trunk/Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.h
trunk/Source/WebKit2/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101440 => 101441)

--- trunk/Source/WebCore/ChangeLog	2011-11-30 02:09:26 UTC (rev 101440)
+++ trunk/Source/WebCore/ChangeLog	2011-11-30 02:29:06 UTC (rev 101441)
@@ -1,3 +1,28 @@
+2011-11-29  Jessie Berlin  jber...@apple.com
+
+WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins
+the first time it is called.
+https://bugs.webkit.org/show_bug.cgi?id=73374 (rdar://problem/10196057)
+
+Reviewed by Brady Eidson.
+
+Add a callback for when the Storage Tracker is done loading the list of origins with Local
+Storage.
+
+* storage/StorageTracker.cpp:
+(WebCore::StorageTracker::StorageTracker):
+Keep track of whether the import from disk has been completed.
+(WebCore::StorageTracker::notifyFinishedImportingOriginIdentifiersOnMainThread):
+(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
+Set m_finishedImportingOriginIdentifiers to true and tell the client.
+(WebCore::StorageTracker::syncImportOriginIdentifiers):
+When finished, notify the shared StorageTracker on the main thread.
+* storage/StorageTracker.h:
+(WebCore::StorageTracker::originsLoaded):
+
+* storage/StorageTrackerClient.h:
+Add didFinishLoadingOrigins.
+
 2011-11-18  Nat Duca  nd...@chromium.org
 
 [chromium] Enable threaded compositing via CCThreadProxy::hasThread only


Modified: trunk/Source/WebCore/storage/StorageTracker.cpp (101440 => 101441)

--- trunk/Source/WebCore/storage/StorageTracker.cpp	2011-11-30 02:09:26 UTC (rev 101440)
+++ trunk/Source/WebCore/storage/StorageTracker.cpp	2011-11-30 02:29:06 UTC (rev 101441)
@@ -90,6 +90,7 @@
 , m_thread(LocalStorageThread::create())
 , m_isActive(false)
 , m_needsInitialization(false)
+, m_finishedImportingOriginIdentifiers(false)
 {
 }
 
@@ -140,6 +141,19 @@
 m_thread-scheduleTask(LocalStorageTask::createOriginIdentifiersImport());
 }
 
+void StorageTracker::notifyFinishedImportingOriginIdentifiersOnMainThread(void*)
+{
+

[webkit-changes] [101442] trunk/Source/WebKit/chromium

[nduca]

Title: [101442] trunk/Source/WebKit/chromium








Revision 101442
Author nd...@chromium.org
Date 2011-11-29 18:29:34 -0800 (Tue, 29 Nov 2011)


Log Message
Unreviewed. Fix clang build by using raw pointers instead of static OwnPtrs
for WebCompositor managment.

* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::initialize):
(WebKit::WebCompositorImpl::shutdown):
* src/WebCompositorImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp
trunk/Source/WebKit/chromium/src/WebCompositorImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (101441 => 101442)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-11-30 02:29:06 UTC (rev 101441)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-11-30 02:29:34 UTC (rev 101442)
@@ -1,3 +1,13 @@
+2011-11-29  Nat Duca  nd...@chromium.org
+
+Unreviewed. Fix clang build by using raw pointers instead of static OwnPtrs
+for WebCompositor managment.
+
+* src/WebCompositorImpl.cpp:
+(WebKit::WebCompositorImpl::initialize):
+(WebKit::WebCompositorImpl::shutdown):
+* src/WebCompositorImpl.h:
+
 2011-11-18  Nat Duca  nd...@chromium.org
 
 [chromium] Enable threaded compositing via CCThreadProxy::hasThread only


Modified: trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp (101441 => 101442)

--- trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp	2011-11-30 02:29:06 UTC (rev 101441)
+++ trunk/Source/WebKit/chromium/src/WebCompositorImpl.cpp	2011-11-30 02:29:34 UTC (rev 101442)
@@ -41,8 +41,8 @@
 namespace WebKit {
 
 bool WebCompositorImpl::s_initialized = false;
-OwnPtrCCThread WebCompositorImpl::s_mainThread;
-OwnPtrCCThread WebCompositorImpl::s_implThread;
+CCThread* WebCompositorImpl::s_mainThread = 0;
+CCThread* WebCompositorImpl::s_implThread = 0;
 
 void WebCompositor::initialize(WebThread* implThread)
 {
@@ -58,11 +58,11 @@
 ASSERT(!s_initialized);
 s_initialized = true;
 
-s_mainThread = CCThreadImpl::create(webKitPlatformSupport()-currentThread());
-CCProxy::setMainThread(s_mainThread.get());
+s_mainThread = CCThreadImpl::create(webKitPlatformSupport()-currentThread()).leakPtr();
+CCProxy::setMainThread(s_mainThread);
 if (implThread) {
-s_implThread = CCThreadImpl::create(implThread);
-CCProxy::setImplThread(s_implThread.get());
+s_implThread = CCThreadImpl::create(implThread).leakPtr();
+CCProxy::setImplThread(s_implThread);
 } else
 CCProxy::setImplThread(0);
 }
@@ -77,8 +77,12 @@
 ASSERT(s_initialized);
 ASSERT(!CCLayerTreeHost::anyLayerTreeHostInstanceExists());
 
-s_implThread.clear();
-s_mainThread.clear();
+if (s_implThread) {
+delete s_implThread;
+s_implThread = 0;
+}
+delete s_mainThread;
+s_mainThread = 0;
 CCProxy::setImplThread(0);
 CCProxy::setMainThread(0);
 s_initialized = false;


Modified: trunk/Source/WebKit/chromium/src/WebCompositorImpl.h (101441 => 101442)

--- trunk/Source/WebKit/chromium/src/WebCompositorImpl.h	2011-11-30 02:29:06 UTC (rev 101441)
+++ trunk/Source/WebKit/chromium/src/WebCompositorImpl.h	2011-11-30 02:29:34 UTC (rev 101442)
@@ -52,8 +52,8 @@
 static void shutdown();
 
 static bool s_initialized;
-static OwnPtrWebCore::CCThread s_mainThread;
-static OwnPtrWebCore::CCThread s_implThread;
+static WebCore::CCThread* s_mainThread;
+static WebCore::CCThread* s_implThread;
 };
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101443] trunk/Source/JavaScriptCore

[weinig]

Title: [101443] trunk/Source/_javascript_Core








Revision 101443
Author wei...@apple.com
Date 2011-11-29 19:05:09 -0800 (Tue, 29 Nov 2011)


Log Message
Add COMPILER_SUPPORTS macro to allow for compiler feature testing
https://bugs.webkit.org/show_bug.cgi?id=73386

Reviewed by Anders Carlsson.

* wtf/Compiler.h:
Add COMPILER_SUPPORTS and #defines for C++11 variadic templates and
rvalue references for Clang.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Compiler.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101442 => 101443)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-30 02:29:34 UTC (rev 101442)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-30 03:05:09 UTC (rev 101443)
@@ -1,3 +1,14 @@
+2011-11-29  Sam Weinig  s...@webkit.org
+
+Add COMPILER_SUPPORTS macro to allow for compiler feature testing
+https://bugs.webkit.org/show_bug.cgi?id=73386
+
+Reviewed by Anders Carlsson.
+
+* wtf/Compiler.h:
+Add COMPILER_SUPPORTS and #defines for C++11 variadic templates and
+rvalue references for Clang.
+
 2011-11-29  Oliver Hunt  oli...@apple.com
 
 Allow WebCore to describe typed arrays to JSC


Modified: trunk/Source/_javascript_Core/wtf/Compiler.h (101442 => 101443)

--- trunk/Source/_javascript_Core/wtf/Compiler.h	2011-11-30 02:29:34 UTC (rev 101442)
+++ trunk/Source/_javascript_Core/wtf/Compiler.h	2011-11-30 03:05:09 UTC (rev 101443)
@@ -29,6 +29,9 @@
 /* COMPILER() - the compiler being used to build the project */
 #define COMPILER(WTF_FEATURE) (defined WTF_COMPILER_##WTF_FEATURE   WTF_COMPILER_##WTF_FEATURE)
 
+/* COMPILER_SUPPORTS() - whether the compiler being used to build the project supports the given feature. */
+#define COMPILER_SUPPORTS(WTF_COMPILER_FEATURE) (defined WTF_COMPILER_SUPPORTS_##WTF_COMPILER_FEATURE   WTF_COMPILER_SUPPORTS_##WTF_COMPILER_FEATURE)
+
 /*  COMPILER() - the compiler being used to build the project  */
 
 /* COMPILER(CLANG) - Clang  */
@@ -39,6 +42,9 @@
 #define __has_extension __has_feature /* Compatibility with older versions of clang */
 #endif
 
+#define WTF_COMPILER_SUPPORTS_CXX_VARIADIC_TEMPLATES __has_feature(cxx_variadic_templates)
+#define WTF_COMPILER_SUPPORTS_CXX_RVALUE_REFERENCES __has_feature(cxx_rvalue_references)
+
 #endif
 
 /* COMPILER(MSVC) - Microsoft Visual C++ */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101444] trunk/Source/WebCore

[leo . yang]

Title: [101444] trunk/Source/WebCore








Revision 101444
Author leo.y...@torchmobile.com.cn
Date 2011-11-29 19:19:19 -0800 (Tue, 29 Nov 2011)


Log Message
Upstream platform/network/blackberry/ProxyServerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=73288

Reviewed by Antonio Gomes.

Initial upstream, can't be built yet, no new tests.

* platform/network/blackberry/ProxyServerBlackBerry.cpp: Added.
(WebCore::proxyServersForURL):

Modified Paths

trunk/Source/WebCore/ChangeLog


Added Paths

trunk/Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101443 => 101444)

--- trunk/Source/WebCore/ChangeLog	2011-11-30 03:05:09 UTC (rev 101443)
+++ trunk/Source/WebCore/ChangeLog	2011-11-30 03:19:19 UTC (rev 101444)
@@ -1,3 +1,15 @@
+2011-11-29  Leo Yang  leo.y...@torchmobile.com.cn
+
+Upstream platform/network/blackberry/ProxyServerBlackBerry.cpp
+https://bugs.webkit.org/show_bug.cgi?id=73288
+
+Reviewed by Antonio Gomes.
+
+Initial upstream, can't be built yet, no new tests.
+
+* platform/network/blackberry/ProxyServerBlackBerry.cpp: Added.
+(WebCore::proxyServersForURL):
+
 2011-11-29  Jessie Berlin  jber...@apple.com
 
 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins


Added: trunk/Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp (0 => 101444)

--- trunk/Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/network/blackberry/ProxyServerBlackBerry.cpp	2011-11-30 03:19:19 UTC (rev 101444)
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2010 Brent Fulgham bfulg...@webkit.org. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include config.h
+#include ProxyServer.h
+
+#include KURL.h
+#include NotImplemented.h
+
+namespace WebCore {
+
+VectorProxyServer proxyServersForURL(const KURL, const NetworkingContext*)
+{
+notImplemented();
+return VectorProxyServer();
+}
+
+} // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101446] trunk

[levin]

Title: [101446] trunk








Revision 101446
Author le...@chromium.org
Date 2011-11-29 21:36:03 -0800 (Tue, 29 Nov 2011)


Log Message
Add a way to revert a variable to its previous value after leaving a scope.
https://bugs.webkit.org/show_bug.cgi?id=73371

Reviewed by Adam Barth.

Source/_javascript_Core:

In case anyone from Chromium sees this, it is nearly identical to AutoReset
but if the same name were used, it causes unnecessary ambiguity.

* _javascript_Core.xcodeproj/project.pbxproj:
* wtf/TemporarilyChange.h: Added.
(WTF::TemporarilyChange::TemporarilyChange):
(WTF::TemporarilyChange::~TemporarilyChange):

Source/_javascript_Glue:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebCore:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Source/WebKit/mac:

* ForwardingHeaders/wtf/TemporarilyChange.h: Added.

Tools:

* DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
* TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
* TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
(TestWebKitAPI::TEST): Added a test for TemporarilyChange.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.gypi
trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Glue/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebKit/mac/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.gypi
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj


Added Paths

trunk/Source/_javascript_Core/wtf/TemporarilyChange.h
trunk/Source/_javascript_Glue/ForwardingHeaders/wtf/TemporarilyChange.h
trunk/Source/WebCore/ForwardingHeaders/wtf/TemporarilyChange.h
trunk/Source/WebKit/mac/ForwardingHeaders/wtf/TemporarilyChange.h
trunk/Tools/DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h
trunk/Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101445 => 101446)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-30 04:35:47 UTC (rev 101445)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-30 05:36:03 UTC (rev 101446)
@@ -1,3 +1,18 @@
+2011-11-29  David Levin  le...@chromium.org
+
+Add a way to revert a variable to its previous value after leaving a scope.
+https://bugs.webkit.org/show_bug.cgi?id=73371
+
+Reviewed by Adam Barth.
+
+In case anyone from Chromium sees this, it is nearly identical to AutoReset
+but if the same name were used, it causes unnecessary ambiguity.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* wtf/TemporarilyChange.h: Added.
+(WTF::TemporarilyChange::TemporarilyChange):
+(WTF::TemporarilyChange::~TemporarilyChange):
+
 2011-11-29  Sam Weinig  s...@webkit.org
 
 Add COMPILER_SUPPORTS macro to allow for compiler feature testing


Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (101445 => 101446)

--- trunk/Source/_javascript_Core/_javascript_Core.gypi	2011-11-30 04:35:47 UTC (rev 101445)
+++ trunk/Source/_javascript_Core/_javascript_Core.gypi	2011-11-30 05:36:03 UTC (rev 101446)
@@ -207,6 +207,7 @@
 'wtf/StdLibExtras.h',
 'wtf/StringExtras.h',
 'wtf/StringHasher.h',
+'wtf/TemporarilyChange.h',
 'wtf/ThreadSafeRefCounted.h',
 'wtf/ThreadSpecific.h',
 'wtf/ThreadRestrictionVerifier.h',


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj (101445 => 101446)

--- trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj	2011-11-30 04:35:47 UTC (rev 101445)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/WTF/WTF.vcproj	2011-11-30 05:36:03 UTC (rev 101446)
@@ -1153,6 +1153,10 @@
 			
 		/File
 		File
+			RelativePath=..\..\wtf\TemporarilyChange.h
+			
+		/File
+		File
 			RelativePath=..\..\wtf\Threading.cpp
 			
 		/File


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (101445 => 101446)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-11-30 04:35:47 UTC (rev 101445)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2011-11-30 05:36:03 UTC (rev 101446)
@@ -46,6 +46,7 @@
 		0B330C270F38C62300692DE3 /* TypeTraits.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 0B330C260F38C62300692DE3 /* TypeTraits.cpp */; };
 		0B4D7E630F319AC800AD7E58 /* TypeTraits.h in Headers */ = {isa = PBXBuildFile; fileRef = 0B4D7E620F319AC800AD7E58 /* TypeTraits.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		0BAC94A01338728400CF135B /* ThreadRestrictionVerifier.h in Headers */ = {isa = PBXBuildFile; fileRef = 0BAC949E1338728400CF135B /* 

[webkit-changes] [101448] trunk/Source/JavaScriptCore

[weinig]

Title: [101448] trunk/Source/_javascript_Core








Revision 101448
Author wei...@apple.com
Date 2011-11-29 21:42:14 -0800 (Tue, 29 Nov 2011)


Log Message
Add move semantics to RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=73393

Reviewed by Anders Carlsson.

* wtf/RetainPtr.h:
(WTF::RetainPtr::RetainPtr):
Add a move constructor and move enabled assignment operators
to RetainPtr if the compiler being used supports rvalue
references. If the compiler does not support it, we fallback
to the copy semantics we have always had.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/RetainPtr.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101447 => 101448)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-30 05:39:07 UTC (rev 101447)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-30 05:42:14 UTC (rev 101448)
@@ -1,3 +1,17 @@
+2011-11-29  Sam Weinig  s...@webkit.org
+
+Add move semantics to RetainPtr
+https://bugs.webkit.org/show_bug.cgi?id=73393
+
+Reviewed by Anders Carlsson.
+
+* wtf/RetainPtr.h:
+(WTF::RetainPtr::RetainPtr):
+Add a move constructor and move enabled assignment operators
+to RetainPtr if the compiler being used supports rvalue
+references. If the compiler does not support it, we fallback
+to the copy semantics we have always had.
+
 2011-11-29  Yuqiang Xian  yuqiang.x...@intel.com
 
 DFG local CSE may cause incorrect reference counting for a node


Modified: trunk/Source/_javascript_Core/wtf/RetainPtr.h (101447 => 101448)

--- trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 05:39:07 UTC (rev 101447)
+++ trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 05:42:14 UTC (rev 101448)
@@ -65,6 +65,10 @@
 
 RetainPtr(const RetainPtr o) : m_ptr(o.m_ptr) { if (PtrType ptr = m_ptr) CFRetain(ptr); }
 
+#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)
+RetainPtr(RetainPtr o) : m_ptr(o.leakRef()) { }
+#endif
+
 // Hash table deleted values, which are only constructed and never copied or destroyed.
 RetainPtr(HashTableDeletedValueType) : m_ptr(hashTableDeletedValue()) { }
 bool isHashTableDeletedValue() const { return m_ptr == hashTableDeletedValue(); }
@@ -90,6 +94,12 @@
 templatetypename U RetainPtr operator=(const RetainPtrU);
 RetainPtr operator=(PtrType);
 templatetypename U RetainPtr operator=(U*);
+
+#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)
+RetainPtr operator=(RetainPtr);
+templatetypename U RetainPtr operator=(RetainPtrU);
+#endif
+
 #if !HAVE(NULLPTR)
 RetainPtr operator=(std::nullptr_t) { clear(); return *this; }
 #endif
@@ -153,7 +163,7 @@
 CFRelease(ptr);
 return *this;
 }
-
+
 templatetypename T inline RetainPtrT RetainPtrT::operator=(PtrType optr)
 {
 if (optr)
@@ -165,33 +175,47 @@
 return *this;
 }
 
-templatetypename T inline void RetainPtrT::adoptCF(PtrType optr)
+templatetypename T templatetypename U inline RetainPtrT RetainPtrT::operator=(U* optr)
 {
+if (optr)
+CFRetain(optr);
 PtrType ptr = m_ptr;
 m_ptr = optr;
 if (ptr)
 CFRelease(ptr);
+return *this;
 }
 
-templatetypename T inline void RetainPtrT::adoptNS(PtrType optr)
+#if COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES)
+templatetypename T inline RetainPtrT RetainPtrT::operator=(RetainPtrT o)
 {
-adoptNSReference(optr);
-
+adoptCF(leakRef());
+return *this;
+}
+
+templatetypename T templatetypename U inline RetainPtrT RetainPtrT::operator=(RetainPtrU o)
+{
+adoptCF(leakRef());
+return *this;
+}
+#endif
+
+templatetypename T inline void RetainPtrT::adoptCF(PtrType optr)
+{
 PtrType ptr = m_ptr;
 m_ptr = optr;
 if (ptr)
 CFRelease(ptr);
 }
-
-templatetypename T templatetypename U inline RetainPtrT RetainPtrT::operator=(U* optr)
+
+templatetypename T inline void RetainPtrT::adoptNS(PtrType optr)
 {
-if (optr)
-CFRetain(optr);
+adoptNSReference(optr);
+
 PtrType ptr = m_ptr;
 m_ptr = optr;
 if (ptr)
 CFRelease(ptr);
-return *this;
 }
 
 templatetypename T inline void RetainPtrT::swap(RetainPtrT o)
@@ -233,7 +257,7 @@
 { 
 return a != b.get(); 
 }
-
+
 templatetypename P struct HashTraitsRetainPtrP  : SimpleClassHashTraitsRetainPtrP  { };
 
 templatetypename P struct PtrHashRetainPtrP  : PtrHashtypename RetainPtrP::PtrType {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101450] trunk/Source

[weinig]

Title: [101450] trunk/Source








Revision 101450
Author wei...@apple.com
Date 2011-11-29 22:03:13 -0800 (Tue, 29 Nov 2011)


Log Message
Remove RetainPtr::releaseRef
https://bugs.webkit.org/show_bug.cgi?id=73396

Reviewed by Dan Bernstein.

../_javascript_Core: 

* wtf/RetainPtr.h:
Be gone releaseRef! Long live leakRef!

../WebKit2: 

* Platform/mac/ModuleMac.mm:
(WebKit::Module::unload):
Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
its sexy replacement.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/RetainPtr.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/mac/ModuleMac.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101449 => 101450)

--- trunk/Source/_javascript_Core/ChangeLog	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-11-30 06:03:13 UTC (rev 101450)
@@ -1,5 +1,15 @@
 2011-11-29  Sam Weinig  s...@webkit.org
 
+Remove RetainPtr::releaseRef
+https://bugs.webkit.org/show_bug.cgi?id=73396
+
+Reviewed by Dan Bernstein.
+
+* wtf/RetainPtr.h:
+Be gone releaseRef! Long live leakRef!
+
+2011-11-29  Sam Weinig  s...@webkit.org
+
 Add move semantics to RetainPtr
 https://bugs.webkit.org/show_bug.cgi?id=73393
 


Modified: trunk/Source/_javascript_Core/wtf/RetainPtr.h (101449 => 101450)

--- trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/_javascript_Core/wtf/RetainPtr.h	2011-11-30 06:03:13 UTC (rev 101450)
@@ -109,9 +109,6 @@
 
 void swap(RetainPtr);
 
-// FIXME: Remove releaseRef once we change all callers to call leakRef instead.
-PtrType releaseRef() { return leakRef(); }
-
 private:
 static PtrType hashTableDeletedValue() { return reinterpret_castPtrType(-1); }
 


Modified: trunk/Source/WebKit2/ChangeLog (101449 => 101450)

--- trunk/Source/WebKit2/ChangeLog	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/WebKit2/ChangeLog	2011-11-30 06:03:13 UTC (rev 101450)
@@ -1,3 +1,15 @@
+2011-11-29  Sam Weinig  s...@webkit.org
+
+Remove RetainPtr::releaseRef
+https://bugs.webkit.org/show_bug.cgi?id=73396
+
+Reviewed by Dan Bernstein.
+
+* Platform/mac/ModuleMac.mm:
+(WebKit::Module::unload):
+Replace the final use of RetainPtr::releaseRef() with RetainPtr::leakRef(),
+its sexy replacement.
+
 2011-11-29  Jessie Berlin  jber...@apple.com
 
 WKKeyValueStorageManagerGetKeyValueStorageOrigins may not report the correct list of origins


Modified: trunk/Source/WebKit2/Platform/mac/ModuleMac.mm (101449 => 101450)

--- trunk/Source/WebKit2/Platform/mac/ModuleMac.mm	2011-11-30 05:51:22 UTC (rev 101449)
+++ trunk/Source/WebKit2/Platform/mac/ModuleMac.mm	2011-11-30 06:03:13 UTC (rev 101450)
@@ -57,7 +57,7 @@
 #endif
 
 // See the comment in Module.h for why we leak the bundle here.
-m_bundle.releaseRef();
+(void)m_bundle.leakRef();
 }
 
 void* Module::platformFunctionPointer(const char* functionName) const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101452] trunk

[commit-queue]

Title: [101452] trunk








Revision 101452
Author commit-qu...@webkit.org
Date 2011-11-29 23:56:23 -0800 (Tue, 29 Nov 2011)


Log Message
Fix for fill color not being applied inside visited links
https://bugs.webkit.org/show_bug.cgi?id=70434

Patch by Philip Rogers p...@google.com on 2011-11-29
Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/custom/visited-link-color.svg

* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):

LayoutTests:

* svg/custom/visited-link-color-expected.png: Added.
* svg/custom/visited-link-color-expected.txt: Added.
* svg/custom/visited-link-color.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/SVGRenderStyle.h


Added Paths

trunk/LayoutTests/svg/custom/visited-link-color-expected.png
trunk/LayoutTests/svg/custom/visited-link-color-expected.txt
trunk/LayoutTests/svg/custom/visited-link-color.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (101451 => 101452)

--- trunk/LayoutTests/ChangeLog	2011-11-30 07:53:47 UTC (rev 101451)
+++ trunk/LayoutTests/ChangeLog	2011-11-30 07:56:23 UTC (rev 101452)
@@ -1,3 +1,14 @@
+2011-11-29  Philip Rogers  p...@google.com
+
+Fix for fill color not being applied inside visited links
+https://bugs.webkit.org/show_bug.cgi?id=70434
+
+Reviewed by Antti Koivisto.
+
+* svg/custom/visited-link-color-expected.png: Added.
+* svg/custom/visited-link-color-expected.txt: Added.
+* svg/custom/visited-link-color.svg: Added.
+
 2011-11-29  Hayato Ito  hay...@chromium.org
 
 Webkit gardening: chromium rebaseline for svg tests.


Added: trunk/LayoutTests/svg/custom/visited-link-color-expected.png (0 => 101452)

--- trunk/LayoutTests/svg/custom/visited-link-color-expected.png	(rev 0)
+++ trunk/LayoutTests/svg/custom/visited-link-color-expected.png	2011-11-30 07:56:23 UTC (rev 101452)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum815216b00eca718237fe0f889da74585\xBC!\xF0\x85
+\xCFIDATx\x9C\xED\xD9\xC1	\xC30A9\xB8/\x93\xC6T\xB9\xD3B\x8A\xCDL\xF7\\xB8m|?:\x8Fs\xBE\xE7\xEA\xC0\xBF\xDB\xC7c[\xBD\xE0A^\xAB\x8D\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88	,\x80\x98\xC0\x88