date:20111205

[webkit-changes] [101976] trunk/LayoutTests

2011-12-05 Thread ossy

Title: [101976] trunk/LayoutTests








Revision 101976
Author o...@webkit.org
Date 2011-12-05 00:19:46 -0800 (Mon, 05 Dec 2011)


Log Message
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

* platform/qt/Skipped: Skip the failing test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (101975 => 101976)

--- trunk/LayoutTests/ChangeLog	2011-12-05 07:58:18 UTC (rev 101975)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 08:19:46 UTC (rev 101976)
@@ -1,3 +1,10 @@
+2011-12-05  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
+https://bugs.webkit.org/show_bug.cgi?id=73802
+
+* platform/qt/Skipped: Skip the failing test.
+
 2011-12-04  Takashi Toyoshima  toyos...@chromium.org
 
 Add binary support in WebSocket test server's echo handler.


Modified: trunk/LayoutTests/platform/qt/Skipped (101975 => 101976)

--- trunk/LayoutTests/platform/qt/Skipped	2011-12-05 07:58:18 UTC (rev 101975)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-12-05 08:19:46 UTC (rev 101976)
@@ -2516,3 +2516,7 @@
 http/tests/security/mixedContent/insecure-video-in-main-frame.html
 http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame.html
 http/tests/security/mixedContent/redirect-https-to-http-video-in-main-frame.html
+
+# [Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
+# https://bugs.webkit.org/show_bug.cgi?id=73802
+editing/style/iframe-onload-crash-mac.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101977] trunk/Source

2011-12-05 Thread eric . carlson

Title: [101977] trunk/Source








Revision 101977
Author eric.carl...@apple.com
Date 2011-12-05 00:42:27 -0800 (Mon, 05 Dec 2011)


Log Message
Source/WebCore: WebCore part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

No new tests yet, still nothing to test.

* page/Settings.cpp:
(WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they
aren't inlined.
(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
* page/Settings.h:

Source/WebKit/chromium: WebKit/chromium part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::shouldDisplaySubtitles): Added.
(WebKit::WebSettingsImpl::shouldDisplayCaptions): Ditto.
(WebKit::WebSettingsImpl::shouldDisplayTextDescriptions): Ditto.
* src/WebSettingsImpl.h:

Source/WebKit/mac: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize new preferences to NO.
(-[WebPreferences setShouldDisplaySubtitles:]): Added.
(-[WebPreferences shouldDisplaySubtitles]): Ditto.
(-[WebPreferences setShouldDisplayCaptions:]): Ditto.
(-[WebPreferences shouldDisplayCaptions]): Ditto.
(-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
(-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
* WebView/WebPreferencesPrivate.h:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.

Source/WebKit/win: WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.

* WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebPreferences.cpp:
(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.
* WebPreferences.h: Declare new methods.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Shared/WebPreferencesStore.h: Declared shouldDisplaySubtitles, shouldDisplayCaptions, and
shouldDisplayTextDescriptions properties with macros. All default to false.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShouldDisplaySubtitles): Added.
(WKPreferencesGetShouldDisplaySubtitles): Ditto.
(WKPreferencesSetShouldDisplayCaptions): Ditto.
(WKPreferencesGetShouldDisplayCaptions): Ditto.
(WKPreferencesSetShouldDisplayTextDescriptions): Ditto.
(WKPreferencesGetShouldDisplayTextDescriptions): Ditto.
* UIProcess/API/C/WKPreferences.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Updates WebCore settings from WebKit2 prefs.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/Interfaces/IWebPreferences.idl
trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h
trunk/Source/WebKit/win/WebPreferences.cpp
trunk/Source/WebKit/win/WebPreferences.h
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (101976 => 101977)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 08:19:46 UTC (rev 101976)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 08:42:27 UTC (rev 101977)
@@ -1,3 +1,19 @@
+2011-12-05  Eric Carlson  eric.carl...@apple.com
+
+WebCore part of: Add WebKit preferences for text track settings
+https://bugs.webkit.org/show_bug.cgi?id=73721
+
+Reviewed by

[webkit-changes] [101978] trunk

2011-12-05 Thread commit-queue

Title: [101978] trunk








Revision 101978
Author commit-qu...@webkit.org
Date 2011-12-05 00:47:33 -0800 (Mon, 05 Dec 2011)


Log Message
Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka shin...@google.com on 2011-12-05
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request

Test: editing/spelling/spellcheck-queue.html

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):
  A structure to have spell check request.
(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):
  When timer is fired, queued request is processed if any.
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):
  When the spellchecker is processing another request, the latest request is queued.
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):
  Enqueues a request. If there is an older request whose root editable element is the same as the request,
  it will be replaced.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

* editing/spelling/spellcheck-queue-expected.txt: Added.
* editing/spelling/spellcheck-queue.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/SpellChecker.cpp
trunk/Source/WebCore/editing/SpellChecker.h


Added Paths

trunk/LayoutTests/editing/spelling/spellcheck-queue-expected.txt
trunk/LayoutTests/editing/spelling/spellcheck-queue.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101977 => 101978)

--- trunk/LayoutTests/ChangeLog	2011-12-05 08:42:27 UTC (rev 101977)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 08:47:33 UTC (rev 101978)
@@ -1,3 +1,17 @@
+2011-12-05  Shinya Kawanaka  shin...@google.com
+
+Asynchronous SpellChecker should consider multiple requests.
+https://bugs.webkit.org/show_bug.cgi?id=72939
+
+Reviewed by Hajime Morita.
+
+Tests for multiple spellcheck requests.
+
+* editing/spelling/spellcheck-queue-expected.txt: Added.
+* editing/spelling/spellcheck-queue.html: Added.
+* platform/gtk/Skipped:
+* platform/qt/Skipped:
+
 2011-12-05  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout


Added: trunk/LayoutTests/editing/spelling/spellcheck-queue-expected.txt (0 => 101978)

--- trunk/LayoutTests/editing/spelling/spellcheck-queue-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-queue-expected.txt	2011-12-05 08:47:33 UTC (rev 101978)
@@ -0,0 +1,18 @@
+For Bug 72939: Asynchronous SpellChecker should consider multiple requests.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS INPUT has a marker on 'zz apple orange'
+PASS TEXTAREA has a marker on 'zz apple orange'
+PASS DIV has a marker on 'zz apple orange'
+PASS INPUT has a marker on 'zz apple orange'
+PASS TEXTAREA has a marker on 'zz apple orange'
+PASS DIV has a marker on 'zz apple orange'
+PASS INPUT has a marker on 'zz apple orange'
+PASS TEXTAREA has a marker on 'zz apple orange'
+PASS DIV has a marker on 'zz apple orange'
+


Added: trunk/LayoutTests/editing/spelling/spellcheck-queue.html (0 => 101978)

--- trunk/LayoutTests/editing/spelling/spellcheck-queue.html	(rev 0)
+++ trunk/LayoutTests/editing/spelling/spellcheck-queue.html	2011-12-05 08:47:33 UTC (rev 101978)
@@ -0,0 +1,188 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+script src=""
+/head
+body
+p id=description/p
+div id=console/div
+script
+description('For Bug 72939: Asynchronous SpellChecker should consider multiple requests.');
+
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.setAsynchronousSpellCheckingEnabled(true);
+}
+
+var testRoot = document.createElement(div);
+document.body.insertBefore(testRoot, document.body.firstChild);
+
+var source1 = document.createElement(div);
+source1.innerHTML = foo bar;
+testRoot.appendChild(source1);
+
+var source2 = document.createElement(div);
+source2.innerHTML = zz apple orange;

[webkit-changes] [101980] trunk/Source/JavaScriptCore

2011-12-05 Thread ossy

Title: [101980] trunk/Source/_javascript_Core








Revision 101980
Author o...@webkit.org
Date 2011-12-05 01:41:04 -0800 (Mon, 05 Dec 2011)


Log Message
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg zherc...@webkit.org on 2011-12-05
Reviewed by Csaba Osztrogonác.

* assembler/MacroAssemblerSH4.h: Support for SH4.
(JSC::MacroAssemblerSH4::readCallTarget):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h
trunk/Source/_javascript_Core/assembler/SH4Assembler.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (101979 => 101980)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 09:28:10 UTC (rev 101979)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 09:41:04 UTC (rev 101980)
@@ -1,3 +1,15 @@
+2011-12-05  Zoltan Herczeg  zherc...@webkit.org
+
+MacroAssemblerSH4 does not implement readCallTarget
+https://bugs.webkit.org/show_bug.cgi?id=73434
+
+Reviewed by Csaba Osztrogonác.
+
+* assembler/MacroAssemblerSH4.h: Support for SH4.
+(JSC::MacroAssemblerSH4::readCallTarget):
+* assembler/SH4Assembler.h:
+(JSC::SH4Assembler::readCallTarget):
+
 2011-12-04  Filip Pizlo  fpi...@apple.com
 
 DFG should optimize strict equality


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h (101979 => 101980)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2011-12-05 09:28:10 UTC (rev 101979)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerSH4.h	2011-12-05 09:41:04 UTC (rev 101980)
@@ -1758,6 +1758,11 @@
 m_assembler.nop();
 }
 
+static FunctionPtr readCallTarget(CodeLocationCall call)
+{
+return FunctionPtr(reinterpret_castvoid(*)()(SH4Assembler::readCallTarget(call.dataLocation(;
+}
+
 protected:
 SH4Assembler::Condition SH4Condition(RelationalCondition cond)
 {


Modified: trunk/Source/_javascript_Core/assembler/SH4Assembler.h (101979 => 101980)

--- trunk/Source/_javascript_Core/assembler/SH4Assembler.h	2011-12-05 09:28:10 UTC (rev 101979)
+++ trunk/Source/_javascript_Core/assembler/SH4Assembler.h	2011-12-05 09:41:04 UTC (rev 101980)
@@ -1506,6 +1506,13 @@
 return readPCrelativeAddress((*(reinterpret_castuint16_t*(code))  0xff), reinterpret_castuint16_t*(code));
 }
 
+static void* readCallTarget(void* from)
+{
+uint16_t* instructionPtr = static_castuint16_t*(from);
+instructionPtr -= 3;
+return reinterpret_castvoid*(readPCrelativeAddress((*instructionPtr  0xff), instructionPtr));
+}
+
 PassRefPtrExecutableMemoryHandle executableCopy(JSGlobalData globalData)
 {
 return m_buffer.executableCopy(globalData);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101981] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101981] trunk/LayoutTests








Revision 101981
Author vse...@chromium.org
Date 2011-12-05 01:50:27 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium expectations update.

* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-win/http/tests/security/mixedContent/
trunk/LayoutTests/platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101980 => 101981)

--- trunk/LayoutTests/ChangeLog	2011-12-05 09:41:04 UTC (rev 101980)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 09:50:27 UTC (rev 101981)
@@ -1,3 +1,12 @@
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium expectations update.
+
+* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
+* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
+* platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
+* platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
+
 2011-12-05  Shinya Kawanaka  shin...@google.com
 
 Asynchronous SpellChecker should consider multiple requests.


Added: trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt (0 => 101981)

--- trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt	2011-12-05 09:50:27 UTC (rev 101981)
@@ -0,0 +1,15 @@
+main frame - didStartProvisionalLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+CONSOLE MESSAGE: line 1: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.ogv.
+
+didDisplayInsecureContent
+CONSOLE MESSAGE: line 1: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.ogv.
+
+didDisplayInsecureContent
+This test opens a window that loads an insecure video. We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content.
Property changes on: trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt (0 => 101981)

--- trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt	2011-12-05 09:50:27 UTC (rev 101981)
@@ -0,0 +1,15 @@
+main frame - didStartProvisionalLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+CONSOLE MESSAGE: line 1: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html displayed insecure content from http://127.0.0.1:8080/security/resources/redir.php?url=""
+
+didDisplayInsecureContent
+CONSOLE MESSAGE: line 1: The page at

[webkit-changes] [101983] trunk/Source/WebCore

2011-12-05 Thread morrita

Title: [101983] trunk/Source/WebCore








Revision 101983
Author morr...@google.com
Date 2011-12-05 03:15:19 -0800 (Mon, 05 Dec 2011)


Log Message
[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101982 => 101983)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 10:00:11 UTC (rev 101982)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 11:15:19 UTC (rev 101983)
@@ -1,3 +1,23 @@
+2011-12-05  Hajime Morrita  morr...@chromium.org
+
+[Refactoring] Accessing Node::m_document should be minimized.
+https://bugs.webkit.org/show_bug.cgi?id=73800
+
+Reviewed by Kent Tamura.
+
+No new tests. No behavioral change.
+
+Replaced m_document reference with the document() accessor
+or temporaril variables. This is a preparation for using
+m_document space to point a shadow root pointer.
+
+* dom/Document.h:
+(WebCore::Node::Node):
+* dom/Node.cpp:
+(WebCore::Node::~Node):
+* dom/Node.h:
+(WebCore::Node::inDocument):
+
 2011-12-05  Shinya Kawanaka  shin...@google.com
 
 Asynchronous SpellChecker should consider multiple requests.


Modified: trunk/Source/WebCore/dom/Document.h (101982 => 101983)

--- trunk/Source/WebCore/dom/Document.h	2011-12-05 10:00:11 UTC (rev 101982)
+++ trunk/Source/WebCore/dom/Document.h	2011-12-05 11:15:19 UTC (rev 101983)
@@ -1449,8 +1449,8 @@
 , m_next(0)
 , m_renderer(0)
 {
-if (m_document)
-m_document-guardRef();
+if (document)
+document-guardRef();
 #if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS)  DUMP_NODE_STATISTICS)
 trackForDebugging();
 #endif


Modified: trunk/Source/WebCore/dom/Node.cpp (101982 => 101983)

--- trunk/Source/WebCore/dom/Node.cpp	2011-12-05 10:00:11 UTC (rev 101982)
+++ trunk/Source/WebCore/dom/Node.cpp	2011-12-05 11:15:19 UTC (rev 101983)
@@ -404,16 +404,17 @@
 if (renderer())
 detach();
 
-if (AXObjectCache::accessibilityEnabled()  m_document  m_document-axObjectCacheExists())
-m_document-axObjectCache()-removeNodeForUse(this);
+Document* doc = document();
+if (AXObjectCache::accessibilityEnabled()  doc  doc-axObjectCacheExists())
+doc-axObjectCache()-removeNodeForUse(this);
 
 if (m_previous)
 m_previous-setNextSibling(0);
 if (m_next)
 m_next-setPreviousSibling(0);
 
-if (m_document)
-m_document-guardDeref();
+if (doc)
+doc-guardDeref();
 }
 
 #ifdef NDEBUG


Modified: trunk/Source/WebCore/dom/Node.h (101982 => 101983)

--- trunk/Source/WebCore/dom/Node.h	2011-12-05 10:00:11 UTC (rev 101982)
+++ trunk/Source/WebCore/dom/Node.h	2011-12-05 11:15:19 UTC (rev 101983)
@@ -388,7 +388,7 @@
 // node tree, false otherwise.
 bool inDocument() const 
 { 
-ASSERT(m_document || !getFlag(InDocumentFlag));
+ASSERT(document() || !getFlag(InDocumentFlag));
 return getFlag(InDocumentFlag);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101984] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101984] trunk/LayoutTests








Revision 101984
Author vse...@chromium.org
Date 2011-12-05 03:20:10 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium test expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101983 => 101984)

--- trunk/LayoutTests/ChangeLog	2011-12-05 11:15:19 UTC (rev 101983)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 11:20:10 UTC (rev 101984)
@@ -1,3 +1,9 @@
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium test expectations update.
+
+* platform/chromium/test_expectations.txt:
+
 2011-12-05  Czene Tamás  tcz...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening. Add platform specific results.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101983 => 101984)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 11:15:19 UTC (rev 101983)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 11:20:10 UTC (rev 101984)
@@ -3824,6 +3824,6 @@
 
 BUGWK73681 : http/tests/appcache/video.html = TIMEOUT PASS
 
-BUGWK73692 WIN : media/event-attributes.html = TEXT PASS
+BUGWK73692 WIN LEOPARD : media/event-attributes.html = TEXT PASS
 
 BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = FAIL






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101985] trunk/LayoutTests

2011-12-05 Thread tkent

Title: [101985] trunk/LayoutTests








Revision 101985
Author tk...@chromium.org
Date 2011-12-05 03:26:23 -0800 (Mon, 05 Dec 2011)


Log Message
Convert input-appearance-spinbutton-visibility.html to a reftest
https://bugs.webkit.org/show_bug.cgi?id=73807

Reviewed by Hajime Morita.

* fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/forms/input-appearance-spinbutton-visibility-expected.html


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt
trunk/LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt
trunk/LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png
trunk/LayoutTests/platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101984 => 101985)

--- trunk/LayoutTests/ChangeLog	2011-12-05 11:20:10 UTC (rev 101984)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 11:26:23 UTC (rev 101985)
@@ -1,3 +1,25 @@
+2011-12-05  Kent Tamura  tk...@chromium.org
+
+Convert input-appearance-spinbutton-visibility.html to a reftest
+https://bugs.webkit.org/show_bug.cgi?id=73807
+
+Reviewed by Hajime Morita.
+
+* fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
+* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
+* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
+* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
+* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
+* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
+* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
+
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium test expectations update.


Added:

[webkit-changes] [101986] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101986] trunk/LayoutTests








Revision 101986
Author vse...@chromium.org
Date 2011-12-05 03:38:44 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101985 => 101986)

--- trunk/LayoutTests/ChangeLog	2011-12-05 11:26:23 UTC (rev 101985)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 11:38:44 UTC (rev 101986)
@@ -1,3 +1,10 @@
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium tests rebaseline.
+
+* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
+* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
+
 2011-12-05  Kent Tamura  tk...@chromium.org
 
 Convert input-appearance-spinbutton-visibility.html to a reftest


Added: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt (0 => 101986)

--- trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt	2011-12-05 11:38:44 UTC (rev 101986)
@@ -0,0 +1,12 @@
+main frame - didStartProvisionalLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+CONSOLE MESSAGE: line 1: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-insecure-video.html displayed insecure content from http://127.0.0.1:8080/resources/test.ogv.
+
+didDisplayInsecureContent
+This test opens a window that loads an insecure video. We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content.
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt (0 => 101986)

--- trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt	2011-12-05 11:38:44 UTC (rev 101986)
@@ -0,0 +1,12 @@
+main frame - didStartProvisionalLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+main frame - didCommitLoadForFrame
+main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
+CONSOLE MESSAGE: line 1: The page at https://127.0.0.1:8443/security/mixedContent/resources/frame-with-redirect-http-to-https-video.html displayed insecure content from http://127.0.0.1:8080/security/resources/redir.php?url=""
+
+didDisplayInsecureContent
+This test opens a window that loads an insecure video(via a tricky redirect). We should trigger a mixed content callback because the main frame in the window is HTTPS but is displaying insecure content.
Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt
___


Added: svn:eol-style




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101988] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101988] trunk/LayoutTests








Revision 101988
Author vse...@chromium.org
Date 2011-12-05 03:54:02 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png
trunk/LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (101987 => 101988)

--- trunk/LayoutTests/ChangeLog	2011-12-05 11:48:28 UTC (rev 101987)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 11:54:02 UTC (rev 101988)
@@ -1,3 +1,12 @@
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed chromium tests rebaseline.
+
+* platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
+* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
+* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
+* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.
+
 2011-12-05  Roland Steiner  rolandstei...@chromium.org
 
 style scoped: Add 'scoped' attribute


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png

(Binary files differ)


Copied: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png (from rev 101987, trunk/LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png)

(Binary files differ)


Property changes: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png



Added: svn:mime-type

Deleted: trunk/LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png

(Binary files differ)


Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt (0 => 101988)

--- trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt	2011-12-05 11:54:02 UTC (rev 101988)
@@ -0,0 +1,77 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x574
+  RenderBlock (anonymous) at (0,0) size 784x18
+RenderText {#text} at (0,0) size 72x18
+  text run at (0,0) width 72: no spacing:
+  RenderBlock {P} at (0,36) size 784x22
+RenderText {#text} at (0,0) size 85x22
+  text run at (0,0) width 85: abc abc abc
+  RenderBlock (anonymous) at (0,76) size 784x18
+RenderText {#text} at (0,0) size 294x18
+  text run at (0,0) width 294: word-spacing: 100px, all should look the same
+  RenderBlock {P} at (0,112) size 784x22
+RenderText {#text} at (0,0) size 285x22
+  text run at (0,0) width 285: abc abc abc
+  RenderBlock {P} at (0,152) size 784x22
+RenderText {#text} at (0,0) size 130x22
+  text run at (0,0) width 130: abc 
+RenderInline {SPAN} at (0,0) size 17x22
+  RenderText {#text} at (130,0) size 17x22
+text run at (130,0) width 17: ab
+RenderText {#text} at (147,0) size 138x22
+  text run at (147,0) width 138: c abc
+  RenderBlock {P} at (0,192) size 784x22
+

[webkit-changes] [101989] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101989] trunk/LayoutTests








Revision 101989
Author vse...@chromium.org
Date 2011-12-05 04:24:19 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101988 => 101989)

--- trunk/LayoutTests/ChangeLog	2011-12-05 11:54:02 UTC (rev 101988)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 12:24:19 UTC (rev 101989)
@@ -1,5 +1,11 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium tests expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium tests rebaseline.
 
 * platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101988 => 101989)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 11:54:02 UTC (rev 101988)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 12:24:19 UTC (rev 101989)
@@ -3790,7 +3790,7 @@
 
 BUGWK72631 LINUX : fast/filesystem/file-writer-abort.html = CRASH PASS
 BUGWK72631 MAC DEBUG : fast/filesystem/file-writer-abort.html = CRASH PASS
-BUGWK72631 WIN DEBUG : fast/filesystem/file-writer-abort-depth.html = CRASH PASS
+BUGWK72631 WIN : fast/filesystem/file-writer-abort-depth.html = CRASH PASS
 
 BUGWK73133 LINUX : inspector/elements/remove-node.html = PASS CRASH
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101990] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101990] trunk/LayoutTests








Revision 101990
Author vse...@chromium.org
Date 2011-12-05 05:35:05 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chrmoium tests rebaseline.

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101989 => 101990)

--- trunk/LayoutTests/ChangeLog	2011-12-05 12:24:19 UTC (rev 101989)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 13:35:05 UTC (rev 101990)
@@ -1,5 +1,11 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chrmoium tests rebaseline.
+
+* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
+
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium tests expectations update.
 
 * platform/chromium/test_expectations.txt:


Deleted: trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt (101989 => 101990)

--- trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	2011-12-05 12:24:19 UTC (rev 101989)
+++ trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	2011-12-05 13:35:05 UTC (rev 101990)
@@ -1,12 +0,0 @@
-Test Checkbox
-This tests that checking of an aria checkbox sends a notification.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-Got notification: CheckedStateChanged
-Got notification: CheckedStateChanged
-PASS successfullyParsed is true
-
-TEST COMPLETE
-






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101991] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101991] trunk/LayoutTests








Revision 101991
Author vse...@chromium.org
Date 2011-12-05 05:44:40 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101990 => 101991)

--- trunk/LayoutTests/ChangeLog	2011-12-05 13:35:05 UTC (rev 101990)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 13:44:40 UTC (rev 101991)
@@ -1,5 +1,11 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium tests rebaseline.
+
+* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.
+
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chrmoium tests rebaseline.
 
 * platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.


Deleted: trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt (101990 => 101991)

--- trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt	2011-12-05 13:35:05 UTC (rev 101990)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt	2011-12-05 13:44:40 UTC (rev 101991)
@@ -1,77 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x574
-  RenderBlock (anonymous) at (0,0) size 784x18
-RenderText {#text} at (0,0) size 72x18
-  text run at (0,0) width 72: no spacing:
-  RenderBlock {P} at (0,36) size 784x22
-RenderText {#text} at (0,0) size 85x22
-  text run at (0,0) width 85: abc abc abc
-  RenderBlock (anonymous) at (0,76) size 784x18
-RenderText {#text} at (0,0) size 294x18
-  text run at (0,0) width 294: word-spacing: 100px, all should look the same
-  RenderBlock {P} at (0,112) size 784x22
-RenderText {#text} at (0,0) size 285x22
-  text run at (0,0) width 285: abc abc abc
-  RenderBlock {P} at (0,152) size 784x22
-RenderText {#text} at (0,0) size 130x22
-  text run at (0,0) width 130: abc 
-RenderInline {SPAN} at (0,0) size 17x22
-  RenderText {#text} at (130,0) size 17x22
-text run at (130,0) width 17: ab
-RenderText {#text} at (147,0) size 138x22
-  text run at (147,0) width 138: c abc
-  RenderBlock {P} at (0,192) size 784x22
-RenderText {#text} at (0,0) size 130x22
-  text run at (0,0) width 130: abc 
-RenderInline {SPAN} at (0,0) size 8x22
-  RenderText {#text} at (130,0) size 8x22
-text run at (130,0) width 8: a
-RenderInline {SPAN} at (0,0) size 9x22
-  RenderText {#text} at (138,0) size 9x22
-text run at (138,0) width 9: b
-RenderText {#text} at (147,0) size 138x22
-  text run at (147,0) width 138: c abc
-  RenderBlock {P} at (0,232) size 784x22
-RenderText {#text} at (0,0) size 130x22
-  text run at (0,0) width 130: abc 
-RenderInline {SPAN} at (0,0) size 8x22
-  RenderText {#text} at (130,0) size 8x22
-text run at (130,0) width 8: a
-RenderText {#text} at (138,0) size 9x22
-  text run at (138,0) width 9: b
-RenderInline {SPAN} at (0,0) size 8x22
-  RenderText {#text} at (147,0) size 8x22
-text run at (147,0) width 8: c
-RenderText {#text} at (255,0) size 30x22
-  text run at (255,0) width 30:  abc
-  RenderBlock {P} at (0,272) size 784x22
-RenderText {#text} at (0,0) size 138x22
-  text run at (0,0) width 138: abc a
-RenderInline {SPAN} at (0,0) size 9x22
-  RenderText {#text} at (138,0) size 9x22
-text run at (138,0) width 9: b
-RenderInline {SPAN} at (0,0) size 8x22
-  RenderText {#text} at (147,0) size 8x22
-text run at (147,0) width 8: c
-RenderText {#text} at (255,0) size 30x22
-  text run at (255,0) width 30:  abc
-  RenderBlock {P} at (0,312) size 784x22
-RenderText {#text} at (0,0) size 138x22
-  text run at (0,0) width 138: abc a
-RenderInline {SPAN} at (0,0) size 9x22
-  RenderText {#text} at (138,0) size 9x22
-text run at (138,0) width 9: b
-RenderText {#text} at (147,0) size 138x22
-  text run at (147,0) width 138: c abc
-  RenderBlock {P} at (0,352) size 784x22
-RenderText {#text} at (0,0) size 130x22
-  text run at (0,0) width 130: abc 
-RenderInline {SPAN} at (0,0) size 0x22
-RenderText {#text} at (130,0) size 130x22
-  text run at

[webkit-changes] [101993] trunk/Source/WebKit/chromium

2011-12-05 Thread vsevik

Title: [101993] trunk/Source/WebKit/chromium








Revision 101993
Author vse...@chromium.org
Date 2011-12-05 06:16:56 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed, fixed chromium DEPS syntax.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (101992 => 101993)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 13:50:49 UTC (rev 101992)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 14:16:56 UTC (rev 101993)
@@ -1,5 +1,11 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed, fixed chromium DEPS syntax.
+
+* DEPS:
+
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed.  Rolled DEPS.
 
 * DEPS:


Modified: trunk/Source/WebKit/chromium/DEPS (101992 => 101993)

--- trunk/Source/WebKit/chromium/DEPS	2011-12-05 13:50:49 UTC (rev 101992)
+++ trunk/Source/WebKit/chromium/DEPS	2011-12-05 14:16:56 UTC (rev 101993)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '112974'
+  'chromium_rev': '112974',
   'nacl_svn': 'http://src.chromium.org/native_client/trunk',
   'nacl_rev': '7169',
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101994] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101994] trunk/LayoutTests








Revision 101994
Author vse...@chromium.org
Date 2011-12-05 06:32:31 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101993 => 101994)

--- trunk/LayoutTests/ChangeLog	2011-12-05 14:16:56 UTC (rev 101993)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 14:32:31 UTC (rev 101994)
@@ -1,5 +1,11 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium tests expectations update.
+
+* platform/chromium/test_expectations.txt:
+
+2011-12-05  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed chromium tests rebaseline.
 
 * platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (101993 => 101994)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 14:16:56 UTC (rev 101993)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 14:32:31 UTC (rev 101994)
@@ -3756,9 +3756,9 @@
 BUGALOKP : platform/chromium/compositing/huge-layer-rotated.html = IMAGE
 BUGALOKP : platform/chromium/compositing/layout-width-change.html = IMAGE
 BUGALOKP : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE
-BUGALOKP GPU : media/video-layer-crash.html = IMAGE
-BUGALOKP GPU : media/video-transformed.html = IMAGE
-BUGALOKP GPU : media/video-zoom-controls.html = IMAGE
+BUGALOKP GPU GPU-CG : media/video-layer-crash.html = IMAGE
+BUGALOKP GPU GPU-CG : media/video-transformed.html = IMAGE
+BUGALOKP GPU GPU-CG : media/video-zoom-controls.html = IMAGE
 
 BUGWK72271 MAC DEBUG : fast/loader/_javascript_-url-in-embed.html = PASS CRASH
 BUGWK72271 SNOWLEOPARD DEBUG : fast/dom/node-iterator-reference-node-moved-crash.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101995] trunk/Source/WebCore

2011-12-05 Thread commit-queue

Title: [101995] trunk/Source/WebCore








Revision 101995
Author commit-qu...@webkit.org
Date 2011-12-05 06:46:36 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-05

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (101994 => 101995)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 14:32:31 UTC (rev 101994)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 14:46:36 UTC (rev 101995)
@@ -1,3 +1,19 @@
+2011-12-05  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r101983.
+http://trac.webkit.org/changeset/101983
+https://bugs.webkit.org/show_bug.cgi?id=73827
+
+It broke all tests on GTK and on Qt in debug mode (Requested
+by Ossy on #webkit).
+
+* dom/Document.h:
+(WebCore::Node::Node):
+* dom/Node.cpp:
+(WebCore::Node::~Node):
+* dom/Node.h:
+(WebCore::Node::inDocument):
+
 2011-12-05  Roland Steiner  rolandstei...@chromium.org
 
 style scoped: Add 'scoped' attribute


Modified: trunk/Source/WebCore/dom/Document.h (101994 => 101995)

--- trunk/Source/WebCore/dom/Document.h	2011-12-05 14:32:31 UTC (rev 101994)
+++ trunk/Source/WebCore/dom/Document.h	2011-12-05 14:46:36 UTC (rev 101995)
@@ -1449,8 +1449,8 @@
 , m_next(0)
 , m_renderer(0)
 {
-if (document)
-document-guardRef();
+if (m_document)
+m_document-guardRef();
 #if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS)  DUMP_NODE_STATISTICS)
 trackForDebugging();
 #endif


Modified: trunk/Source/WebCore/dom/Node.cpp (101994 => 101995)

--- trunk/Source/WebCore/dom/Node.cpp	2011-12-05 14:32:31 UTC (rev 101994)
+++ trunk/Source/WebCore/dom/Node.cpp	2011-12-05 14:46:36 UTC (rev 101995)
@@ -404,17 +404,16 @@
 if (renderer())
 detach();
 
-Document* doc = document();
-if (AXObjectCache::accessibilityEnabled()  doc  doc-axObjectCacheExists())
-doc-axObjectCache()-removeNodeForUse(this);
+if (AXObjectCache::accessibilityEnabled()  m_document  m_document-axObjectCacheExists())
+m_document-axObjectCache()-removeNodeForUse(this);
 
 if (m_previous)
 m_previous-setNextSibling(0);
 if (m_next)
 m_next-setPreviousSibling(0);
 
-if (doc)
-doc-guardDeref();
+if (m_document)
+m_document-guardDeref();
 }
 
 #ifdef NDEBUG


Modified: trunk/Source/WebCore/dom/Node.h (101994 => 101995)

--- trunk/Source/WebCore/dom/Node.h	2011-12-05 14:32:31 UTC (rev 101994)
+++ trunk/Source/WebCore/dom/Node.h	2011-12-05 14:46:36 UTC (rev 101995)
@@ -388,7 +388,7 @@
 // node tree, false otherwise.
 bool inDocument() const 
 { 
-ASSERT(document() || !getFlag(InDocumentFlag));
+ASSERT(m_document || !getFlag(InDocumentFlag));
 return getFlag(InDocumentFlag);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101996] trunk/Tools

2011-12-05 Thread kenneth

Title: [101996] trunk/Tools








Revision 101996
Author kenn...@webkit.org
Date 2011-12-05 06:47:46 -0800 (Mon, 05 Dec 2011)


Log Message
[Qt] Make the UI of the MiniBrowser slightly nicer

Rubberstamped by Simon Hausmann.

- Add proper padding
- Show feedback when pressing on the toolbar icons
- Make the text entry better looking

* MiniBrowser/qt/qml/BrowserWindow.qml:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml




Diff

Modified: trunk/Tools/ChangeLog (101995 => 101996)

--- trunk/Tools/ChangeLog	2011-12-05 14:46:36 UTC (rev 101995)
+++ trunk/Tools/ChangeLog	2011-12-05 14:47:46 UTC (rev 101996)
@@ -1,3 +1,15 @@
+2011-12-05  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Qt] Make the UI of the MiniBrowser slightly nicer
+
+Rubberstamped by Simon Hausmann.
+
+- Add proper padding
+- Show feedback when pressing on the toolbar icons
+- Make the text entry better looking
+
+* MiniBrowser/qt/qml/BrowserWindow.qml:
+
 2011-12-05  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 NRWT should handle duplicated expectations


Modified: trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml (101995 => 101996)

--- trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml	2011-12-05 14:46:36 UTC (rev 101995)
+++ trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml	2011-12-05 14:47:46 UTC (rev 101996)
@@ -48,7 +48,7 @@
 Rectangle {
 id: navigationBar
 color: #efefef
-height: 30
+height: 38
 anchors {
 top: parent.top
 left: parent.left
@@ -56,14 +56,23 @@
 }
 
 Row {
+height: parent.height - 6
+anchors {
+verticalCenter: parent.verticalCenter
+left: parent.left
+leftMargin: 3
+}
+spacing: 3
 id: controlsRow
-spacing: 4
 Rectangle {
 id: backButton
-height: navigationBar.height - 2
+height: parent.height
 width: height
 color: #efefef
+radius: 6
 
+property alias enabled: webView.canGoBack
+
 Image {
 anchors.centerIn: parent
 source: ../icons/previous.png
@@ -71,25 +80,33 @@
 
 Rectangle {
 anchors.fill: parent
-color: reloadButton.color
+color: parent.color
+radius: parent.radius
 opacity: 0.8
-visible: !webView.canGoBack
+visible: !parent.enabled
 }
 
 MouseArea {
 anchors.fill: parent
+onPressed: { if (parent.enabled) parent.color = #cfcfcf }
+onReleased: { parent.color = #efefef }
 onClicked: {
-console.log(going back)
-webView.goBack()
+if (parent.enabled) {
+console.log(MiniBrowser: Going backward in session history.)
+webView.goBack()
+}
 }
 }
 }
 Rectangle {
 id: forwardButton
-height: navigationBar.height - 2
+height: parent.height
 width: height
 color: #efefef
+radius: 6
 
+property alias enabled: webView.canGoForward
+
 Image {
 anchors.centerIn: parent
 source: ../icons/next.png
@@ -97,24 +114,30 @@
 
 Rectangle {
 anchors.fill: parent
-color: forwardButton.color
+color: parent.color
+radius: parent.radius
 opacity: 0.8
-visible: !webView.canGoForward
+visible: !parent.enabled
 }
 
 MouseArea {
 anchors.fill: parent
+onPressed: { if (parent.enabled) parent.color = #cfcfcf }
+onReleased: { parent.color = #efefef }
 onClicked: {
-console.log(going forward)
-webView.goForward()
+if (parent.enabled) {
+console.log(MiniBrowser: Going forward in session history.)
+webView.goForward()
+}
 }
 }
 }
 Rectangle {
 id: reloadButton
-height: navigationBar.height - 2
+height: parent.height
 width: height
 color: #efefef
+radius: 6
 
 Image

[webkit-changes] [101997] trunk/LayoutTests

2011-12-05 Thread vsevik

Title: [101997] trunk/LayoutTests








Revision 101997
Author vse...@chromium.org
Date 2011-12-05 07:21:18 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/http/tests/security/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/security/mixedContent/
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt
trunk/LayoutTests/platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (101996 => 101997)

--- trunk/LayoutTests/ChangeLog	2011-12-05 14:47:46 UTC (rev 101996)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 15:21:18 UTC (rev 101997)
@@ -1,5 +1,18 @@
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
+Unreviewed chromium tests rebaseline.
+
+* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
+* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
+* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
+* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
+* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
+* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
+* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
+

[webkit-changes] [101998] trunk

2011-12-05 Thread rolandsteiner

Title: [101998] trunk








Revision 101998
Author rolandstei...@chromium.org
Date 2011-12-05 07:30:38 -0800 (Mon, 05 Dec 2011)


Log Message
Raw pseudo selectors don't match if immediately after a child or descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Source/WebCore:

Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.

Reviewed by Antti Koivisto.

* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):

LayoutTests:

Add tests cases for raw shadow pseudo-element selectors with various combinators.
Also add cases with explicit universal '*' selector.

Reviewed by Antti Koivisto.

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/css/unknown-pseudo-element-matching-expected.txt:
* fast/css/unknown-pseudo-element-matching.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/css-selector-text-expected.txt
trunk/LayoutTests/fast/css/css-selector-text.html
trunk/LayoutTests/fast/css/css-set-selector-text-expected.txt
trunk/LayoutTests/fast/css/css-set-selector-text.html
trunk/LayoutTests/fast/css/unknown-pseudo-element-matching-expected.txt
trunk/LayoutTests/fast/css/unknown-pseudo-element-matching.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (101997 => 101998)

--- trunk/LayoutTests/ChangeLog	2011-12-05 15:21:18 UTC (rev 101997)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 15:30:38 UTC (rev 101998)
@@ -1,3 +1,20 @@
+2011-12-05  Roland Steiner  rolandstei...@chromium.org
+
+Raw pseudo selectors don't match if immediately after a child or descendant combinator
+https://bugs.webkit.org/show_bug.cgi?id=72933
+
+Add tests cases for raw shadow pseudo-element selectors with various combinators.
+Also add cases with explicit universal '*' selector.
+
+Reviewed by Antti Koivisto.
+
+* fast/css/css-selector-text-expected.txt:
+* fast/css/css-selector-text.html:
+* fast/css/css-set-selector-text-expected.txt:
+* fast/css/css-set-selector-text.html:
+* fast/css/unknown-pseudo-element-matching-expected.txt:
+* fast/css/unknown-pseudo-element-matching.html:
+
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed chromium tests rebaseline.


Modified: trunk/LayoutTests/fast/css/css-selector-text-expected.txt (101997 => 101998)

--- trunk/LayoutTests/fast/css/css-selector-text-expected.txt	2011-12-05 15:21:18 UTC (rev 101997)
+++ trunk/LayoutTests/fast/css/css-selector-text-expected.txt	2011-12-05 15:30:38 UTC (rev 101998)
@@ -58,22 +58,28 @@
 PASS parseThenSerializeRule(':-webkit-autofill { }') is ':-webkit-autofill { }'
 PASS parseThenSerializeRule(':-webkit-drag { }') is ':-webkit-drag { }'
 
-PASS parseThenSerializeRule('::-webkit-file-upload-button { }') is '::-webkit-file-upload-button { }'
-PASS parseThenSerializeRule('::-webkit-search-cancel-button { }') is '::-webkit-search-cancel-button { }'
-PASS parseThenSerializeRule('::-webkit-search-decoration { }') is '::-webkit-search-decoration { }'
-PASS parseThenSerializeRule('::-webkit-search-results-button { }') is '::-webkit-search-results-button { }'
-PASS parseThenSerializeRule('::-webkit-search-results-decoration { }') is '::-webkit-search-results-decoration { }'
-PASS parseThenSerializeRule('::-webkit-slider-thumb { }') is '::-webkit-slider-thumb { }'
+PASS parseThenSerializeRule('::-webkit-file-upload-button { }') is '*::-webkit-file-upload-button { }'
+PASS parseThenSerializeRule('::-webkit-search-cancel-button { }') is '*::-webkit-search-cancel-button { }'
+PASS parseThenSerializeRule('::-webkit-search-decoration { }') is '*::-webkit-search-decoration { }'
+PASS parseThenSerializeRule('::-webkit-search-results-button { }') is '*::-webkit-search-results-button { }'
+PASS parseThenSerializeRule('::-webkit-search-results-decoration { }') is '*::-webkit-search-results-decoration { }'
+PASS parseThenSerializeRule('::-webkit-slider-thumb { }') is '*::-webkit-slider-thumb { }'
 
 PASS parseThenSerializeRule('a::-webkit-slider-thumb { }') is 'a::-webkit-slider-thumb { }'
-PASS parseThenSerializeRule('a ::-webkit-slider-thumb { }') is 'a ::-webkit-slider-thumb { }'
+PASS parseThenSerializeRule('a ::-webkit-slider-thumb { }') is 'a *::-webkit-slider-thumb { }'
 PASS parseThenSerializeRule('[a]::-webkit-slider-thumb { }') is '[a]::-webkit-slider-thumb { }'
-PASS parseThenSerializeRule('[a] ::-webkit-slider-thumb { }') is '[a] ::-webkit-slider-thumb { }'
+PASS parseThenSerializeRule('[a] ::-webkit-slider-thumb { }') is '[a] *::-webkit-slider-thumb { }'
 PASS parseThenSerializeRule('.a::-webkit-slider-thumb { }') is '.a::-webkit-slider-thumb { }'
-PASS parseThenSerializeRule('.a ::-webkit-slider-thumb { }') is '.a ::-webkit-slider-thumb { }'
+PASS

[webkit-changes] [101999] trunk

2011-12-05 Thread eric . carlson

Title: [101999] trunk








Revision 101999
Author eric.carl...@apple.com
Date 2011-12-05 07:38:11 -0800 (Mon, 05 Dec 2011)


Log Message
Out-of-band text tracks may only load from same origin as the media element's Document's origin
https://bugs.webkit.org/show_bug.cgi?id=73184

Reviewed by Sam Weinig.

Source/WebCore: 

Test: http/tests/security/text-track-crossorigin.html

* html/HTMLTrackElement.cpp:
(WebCore::urlForLogging): Debug-only function for logging urls.
(WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to
the Track.
(WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the
requirements for track are different from video.
(WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin' 
attribute value.
* html/HTMLTrackElement.h:

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
(WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know 
if the loader refuses the url immediately.
(WebCore::LoadableTextTrack::cueLoadingStarted): The track deals with readyState.
(WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes
an enum, not a bool.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
(WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
(WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we
can make the correct checks.
* loader/TextTrackLoader.h:

LayoutTests: 

* http/tests/security/resources/captions-with-access-control-headers.php: Added
* http/tests/security/resources/captions.vtt: Added.
* http/tests/security/text-track-crossorigin-expected.txt: Added.
* http/tests/security/text-track-crossorigin.html: Added.
* media/track/track-add-track-expected.txt: Updated results.
* media/track/track-add-track.html: readyState changes as soon as the track url is set.
* platform/efl/Skipped: Skip new test.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
* platform/wincairo/Skipped: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/track/track-add-track-expected.txt
trunk/LayoutTests/media/track/track-add-track.html
trunk/LayoutTests/platform/efl/Skipped
trunk/LayoutTests/platform/gtk/Skipped
trunk/LayoutTests/platform/mac/Skipped
trunk/LayoutTests/platform/qt/Skipped
trunk/LayoutTests/platform/win/Skipped
trunk/LayoutTests/platform/wincairo/Skipped
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLTrackElement.cpp
trunk/Source/WebCore/html/HTMLTrackElement.h
trunk/Source/WebCore/html/LoadableTextTrack.cpp
trunk/Source/WebCore/loader/TextTrackLoader.cpp
trunk/Source/WebCore/loader/TextTrackLoader.h


Added Paths

trunk/LayoutTests/http/tests/security/resources/captions-with-access-control-headers.php
trunk/LayoutTests/http/tests/security/resources/captions.vtt
trunk/LayoutTests/http/tests/security/text-track-crossorigin-expected.txt
trunk/LayoutTests/http/tests/security/text-track-crossorigin.html




Diff

Modified: trunk/LayoutTests/ChangeLog (101998 => 101999)

--- trunk/LayoutTests/ChangeLog	2011-12-05 15:30:38 UTC (rev 101998)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 15:38:11 UTC (rev 101999)
@@ -1,3 +1,23 @@
+2011-12-05  Eric Carlson  eric.carl...@apple.com
+
+Out-of-band text tracks may only load from same origin as the media element's Document's origin
+https://bugs.webkit.org/show_bug.cgi?id=73184
+
+Reviewed by Sam Weinig.
+
+* http/tests/security/resources/captions-with-access-control-headers.php: Added
+* http/tests/security/resources/captions.vtt: Added.
+* http/tests/security/text-track-crossorigin-expected.txt: Added.
+* http/tests/security/text-track-crossorigin.html: Added.
+* media/track/track-add-track-expected.txt: Updated results.
+* media/track/track-add-track.html: readyState changes as soon as the track url is set.
+* platform/efl/Skipped: Skip new test.
+* platform/gtk/Skipped: Ditto.
+* platform/mac/Skipped: Ditto.
+* platform/qt/Skipped: Ditto.
+* platform/win/Skipped: Ditto.
+* platform/wincairo/Skipped: Ditto.
+
 2011-12-05  Roland Steiner  rolandstei...@chromium.org
 
 Raw pseudo selectors don't match if immediately after a child or descendant combinator


Added: trunk/LayoutTests/http/tests/security/resources/captions-with-access-control-headers.php (0 => 101999)

--- trunk/LayoutTests/http/tests/security/resources/captions-with-access-control-headers.php	(rev 0)
+++ trunk/LayoutTests/http/tests/security/resources/captions-with-access-control-headers.php	2011-12-05

[webkit-changes] [102000] trunk/Tools

2011-12-05 Thread aroben

Title: [102000] trunk/Tools








Revision 102000
Author aro...@apple.com
Date 2011-12-05 07:52:21 -0800 (Mon, 05 Dec 2011)


Log Message
Redeploy apple-macpro-7 and apple-xserve-1

These slaves have been sitting idle since we removed our Leopard builders in r97496.

Fixes http://webkit.org/b/73829 REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
sitting idle

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
apple-xserve-1. The former is now doing SnowLeopard Intel Debug (WebKit2 Tests), which
allows apple-xserve-9 to be a build-only slave, and the latter is doing Lion Intel Debug
(WebKit2 Tests).

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (101999 => 102000)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-12-05 15:38:11 UTC (rev 101999)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2011-12-05 15:52:21 UTC (rev 102000)
@@ -10,12 +10,14 @@
 { name: apple-xserve-9, platform: mac-snowleopard },	
 { name: apple-macpro-1, platform: mac-snowleopard },
 { name: apple-macpro-2, platform: mac-snowleopard },
+{ name: apple-macpro-7, platform: mac-snowleopard },
 
 { name: apple-macpro-3, platform: mac-lion },
 { name: apple-macpro-4, platform: mac-lion },
 { name: apple-macpro-5, platform: mac-lion },	
 { name: apple-macpro-6, platform: mac-lion },
 { name: apple-macpro-8, platform: mac-lion },	
+{ name: apple-xserve-1, platform: mac-lion },
 { name: apple-xserve-2, platform: mac-lion },
 { name: apple-xserve-3, platform: mac-lion },
 { name: apple-xserve-10, platform: mac-lion },
@@ -99,7 +101,7 @@
 },
 { name: SnowLeopard Intel Debug (WebKit2 Tests), type: TestWebKit2, builddir: snowleopard-intel-debug-tests-wk2,
   platform: mac-snowleopard, configuration: debug, architectures: [x86_64],
-  slavenames: [apple-xserve-9]
+  slavenames: [apple-macpro-7]
 },
 { name: Lion Intel Debug (Build), type: Build, builddir: lion-intel-debug,
   platform: mac-lion, configuration: debug, architectures: [x86_64],
@@ -117,7 +119,7 @@
 },
 { name: Lion Intel Debug (WebKit2 Tests), type: TestWebKit2, builddir: lion-intel-debug-tests-wk2,
   platform: mac-lion, configuration: debug, architectures: [x86_64],
-  slavenames: [apple-macpro-8]
+  slavenames: [apple-macpro-8, apple-xserve-1]
 },
 { name: Lion Intel Release (Tests), type: Test, builddir: lion-intel-release-tests,
   platform: mac-lion, configuration: release, architectures: [x86_64],


Modified: trunk/Tools/ChangeLog (101999 => 102000)

--- trunk/Tools/ChangeLog	2011-12-05 15:38:11 UTC (rev 101999)
+++ trunk/Tools/ChangeLog	2011-12-05 15:52:21 UTC (rev 102000)
@@ -1,3 +1,19 @@
+2011-12-05  Adam Roben  aro...@apple.com
+
+Redeploy apple-macpro-7 and apple-xserve-1
+
+These slaves have been sitting idle since we removed our Leopard builders in r97496.
+
+Fixes http://webkit.org/b/73829 REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
+sitting idle
+
+Reviewed by Sam Weinig.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
+apple-xserve-1. The former is now doing SnowLeopard Intel Debug (WebKit2 Tests), which
+allows apple-xserve-9 to be a build-only slave, and the latter is doing Lion Intel Debug
+(WebKit2 Tests).
+
 2011-12-05  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Qt] Make the UI of the MiniBrowser slightly nicer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102001] trunk

2011-12-05 Thread commit-queue

Title: [102001] trunk








Revision 102001
Author commit-qu...@webkit.org
Date 2011-12-05 07:53:02 -0800 (Mon, 05 Dec 2011)


Log Message
[Qt] Add Source/qtwebkitversion.h to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=73823

Patch by Alexander Færøy alexander.fae...@nokia.com on 2011-12-05
Reviewed by Tor Arne Vestbø.

* .gitignore:

Modified Paths

trunk/.gitignore
trunk/ChangeLog




Diff

Modified: trunk/.gitignore (102000 => 102001)

--- trunk/.gitignore	2011-12-05 15:52:21 UTC (rev 102000)
+++ trunk/.gitignore	2011-12-05 15:53:02 UTC (rev 102001)
@@ -168,3 +168,6 @@
 /WebKitLibraries/win/lib/libxslt.lib
 /WebKitLibraries/win/lib/pthreadVC2.lib
 /WebKitLibraries/win/lib/zdll.lib
+
+# Ignore files generated by the Qt build-system:
+Source/qtwebkitversion.h


Modified: trunk/ChangeLog (102000 => 102001)

--- trunk/ChangeLog	2011-12-05 15:52:21 UTC (rev 102000)
+++ trunk/ChangeLog	2011-12-05 15:53:02 UTC (rev 102001)
@@ -1,3 +1,12 @@
+2011-12-05  Alexander Færøy  alexander.fae...@nokia.com
+
+[Qt] Add Source/qtwebkitversion.h to .gitignore
+https://bugs.webkit.org/show_bug.cgi?id=73823
+
+Reviewed by Tor Arne Vestbø.
+
+* .gitignore:
+
 2011-12-03  Dan Winship  d...@gnome.org
 
 [GTK] Update required libsoup version






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102002] trunk/Source/WebKit2

2011-12-05 Thread laszlo . 1 . gombos

Title: [102002] trunk/Source/WebKit2








Revision 102002
Author laszlo.1.gom...@nokia.com
Date 2011-12-05 08:17:51 -0800 (Mon, 05 Dec 2011)


Log Message
[Qt] Remove viewModeChanged() from QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=73828

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/qquickwebview_p.h: viewModeChanged is not used
and we should not expose it.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102001 => 102002)

--- trunk/Source/WebKit2/ChangeLog	2011-12-05 15:53:02 UTC (rev 102001)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-05 16:17:51 UTC (rev 102002)
@@ -1,3 +1,13 @@
+2011-12-05  Laszlo Gombos  laszlo.1.gom...@nokia.com
+
+[Qt] Remove viewModeChanged() from QQuickWebView
+https://bugs.webkit.org/show_bug.cgi?id=73828
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* UIProcess/API/qt/qquickwebview_p.h: viewModeChanged is not used
+and we should not expose it.
+
 2011-12-05  Eric Carlson  eric.carl...@apple.com
 
 WebKit2 part of: Add WebKit preferences for text track settings


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (102001 => 102002)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-05 15:53:02 UTC (rev 102001)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-05 16:17:51 UTC (rev 102002)
@@ -111,7 +111,6 @@
 void urlChanged(const QUrl url);
 void messageReceived(const QVariantMap message);
 void linkHovered(const QUrl url, const QString title);
-void viewModeChanged();
 void navigationStateChanged();
 void navigationRequested(QObject* request);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102003] trunk/Source/WebCore

2011-12-05 Thread podivilov

Title: [102003] trunk/Source/WebCore








Revision 102003
Author podivi...@chromium.org
Date 2011-12-05 08:24:52 -0800 (Mon, 05 Dec 2011)


Log Message
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=73831

Reviewed by Yury Semikhatsky.

* inspector/front-end/CompilerSourceMapping.js:
(WebInspector.ClosureCompilerSourceMappingPayload):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (102002 => 102003)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 16:17:51 UTC (rev 102002)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 16:24:52 UTC (rev 102003)
@@ -1,3 +1,13 @@
+2011-12-05  Pavel Podivilov  podivi...@chromium.org
+
+Web Inspector: fix fronted compilation.
+https://bugs.webkit.org/show_bug.cgi?id=73831
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/CompilerSourceMapping.js:
+(WebInspector.ClosureCompilerSourceMappingPayload):
+
 2011-12-05  Eric Carlson  eric.carl...@apple.com
 
 Out-of-band text tracks may only load from same origin as the media element's Document's origin


Modified: trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js (102002 => 102003)

--- trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js	2011-12-05 16:17:51 UTC (rev 102002)
+++ trunk/Source/WebCore/inspector/front-end/CompilerSourceMapping.js	2011-12-05 16:24:52 UTC (rev 102003)
@@ -62,6 +62,7 @@
 WebInspector.ClosureCompilerSourceMappingPayload = function()
 {
 this.mappings = ;
+this.sourceRoot = ;
 this.sources = [];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102004] trunk/Source/WebCore

2011-12-05 Thread commit-queue

Title: [102004] trunk/Source/WebCore








Revision 102004
Author commit-qu...@webkit.org
Date 2011-12-05 08:56:01 -0800 (Mon, 05 Dec 2011)


Log Message
Web Inspector: [protocol] generate C++ classes for protocol JSON named types
https://bugs.webkit.org/show_bug.cgi?id=72835

Patch by Peter Rybin peter.ry...@gmail.com on 2011-12-05
Reviewed by Yury Semikhatsky.

Extends python generator functionality.
Makes constructor in InspectorObject public.

* inspector/CodeGeneratorInspector.py:
* inspector/InspectorValues.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
trunk/Source/WebCore/inspector/InspectorValues.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102003 => 102004)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 16:24:52 UTC (rev 102003)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 16:56:01 UTC (rev 102004)
@@ -1,3 +1,16 @@
+2011-12-05  Peter Rybin  peter.ry...@gmail.com
+
+Web Inspector: [protocol] generate C++ classes for protocol JSON named types
+https://bugs.webkit.org/show_bug.cgi?id=72835
+
+Reviewed by Yury Semikhatsky.
+
+Extends python generator functionality.
+Makes constructor in InspectorObject public.
+
+* inspector/CodeGeneratorInspector.py:
+* inspector/InspectorValues.h:
+
 2011-12-05  Pavel Podivilov  podivi...@chromium.org
 
 Web Inspector: fix fronted compilation.


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (102003 => 102004)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-05 16:24:52 UTC (rev 102003)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-05 16:56:01 UTC (rev 102004)
@@ -104,6 +104,12 @@
 
 class Capitalizer:
 @staticmethod
+def lower_camel_case_to_upper(str):
+if len(str)  0 and str[0].islower():
+str = str[0].upper() + str[1:]
+return str
+
+@staticmethod
 def upper_camel_case_to_lower(str):
 pos = 0
 while pos  len(str) and str[pos].isupper():
@@ -120,6 +126,47 @@
 str = possible_abbreviation.lower() + str[pos:]
 return str
 
+@staticmethod
+def camel_case_to_capitalized_with_underscores(str):
+if len(str) == 0:
+return str
+output = Capitalizer.split_camel_case_(str)
+pos = 0
+while pos  len(output):
+output[pos] = output[pos].upper()
+pos += 1
+return _.join(output)
+
+@staticmethod
+def split_camel_case_(str):
+output = []
+pos_being = 0
+pos = 1
+has_oneletter = False
+while pos  len(str):
+if str[pos].isupper():
+output.append(str[pos_being:pos].upper())
+if pos - pos_being == 1:
+has_oneletter = True
+pos_being = pos
+pos += 1
+output.append(str[pos_being:])
+if has_oneletter:
+array_pos = 0
+while array_pos  len(output) - 1:
+if len(output[array_pos]) == 1:
+array_pos_end = array_pos + 1
+while array_pos_end  len(output) and len(output[array_pos_end]) == 1:
+array_pos_end += 1
+if array_pos_end - array_pos  1:
+possible_abbreviation = .join(output[array_pos:array_pos_end])
+if possible_abbreviation.upper() in Capitalizer.ABBREVIATION:
+output[array_pos:array_pos_end] = [possible_abbreviation]
+else:
+array_pos = array_pos_end - 1
+array_pos += 1
+return output
+
 ABBREVIATION = frozenset([XHR, DOM, CSS])
 
 
@@ -186,6 +233,8 @@
 return RawTypes.Int
 elif json_type == number:
 return RawTypes.Number
+elif json_type == any:
+return RawTypes.Any
 else:
 raise Exception(Unknown type: %s % json_type)
 
@@ -201,7 +250,7 @@
 class String(BaseType):
 @classmethod
 def get_c_param_type(cls, param_type, optional):
-if param_type == ParamType.EVENT:
+if param_type == ParamType.EVENT or param_type == ParamType.TYPE_BUILDER_OUTPUT:
 return cls._ref_c_type
 else:
 return cls._plain_c_type
@@ -296,7 +345,7 @@
 class Object(BaseType):
 @classmethod
 def get_c_param_type(cls, param_type, optional):
-if param_type == ParamType.EVENT:
+if param_type == ParamType.EVENT or param_type == ParamType.TYPE_BUILDER_OUTPUT:
 return cls._ref_c_type
 else:
 return cls._plain_c_type
@@ -322,6 +371,35 @@
 _plain_c_type = CParamType(RefPtrInspectorObject)
 _ref_c_type = CParamType(PassRefPtrInspectorObject)
 
+class Any(BaseType):
+

[webkit-changes] [102005] trunk/Source/WebCore

2011-12-05 Thread vsevik

Title: [102005] trunk/Source/WebCore








Revision 102005
Author vse...@chromium.org
Date 2011-12-05 09:07:30 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed, rolling out r102004.
http://trac.webkit.org/changeset/102004
https://bugs.webkit.org/show_bug.cgi?id=73835

Breaks qt minimal release compilation (Requested by vsevik on
#webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2011-12-05

* inspector/CodeGeneratorInspector.py:
(Capitalizer.upper_camel_case_to_lower):
(RawTypes.get):
(RawTypes.String.get_c_param_type):
(RawTypes.Object.get_c_param_type):
(RawTypes.Object):
(ParamType):
(TypeData.__init__):
(TypeData.get_raw_type):
(TypeMap.__init__):
(InspectorFrontend_h):
(InspectorArray):
(InspectorObject):
(String):
(InspectorBackendDispatcher_h):
(Generator.process_command):
* inspector/InspectorValues.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py
trunk/Source/WebCore/inspector/InspectorValues.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102004 => 102005)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 16:56:01 UTC (rev 102004)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 17:07:30 UTC (rev 102005)
@@ -1,3 +1,30 @@
+2011-12-05  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r102004.
+http://trac.webkit.org/changeset/102004
+https://bugs.webkit.org/show_bug.cgi?id=73835
+
+Breaks qt minimal release compilation (Requested by vsevik on
+#webkit).
+
+* inspector/CodeGeneratorInspector.py:
+(Capitalizer.upper_camel_case_to_lower):
+(RawTypes.get):
+(RawTypes.String.get_c_param_type):
+(RawTypes.Object.get_c_param_type):
+(RawTypes.Object):
+(ParamType):
+(TypeData.__init__):
+(TypeData.get_raw_type):
+(TypeMap.__init__):
+(InspectorFrontend_h):
+(InspectorArray):
+(InspectorObject):
+(String):
+(InspectorBackendDispatcher_h):
+(Generator.process_command):
+* inspector/InspectorValues.h:
+
 2011-12-05  Peter Rybin  peter.ry...@gmail.com
 
 Web Inspector: [protocol] generate C++ classes for protocol JSON named types


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (102004 => 102005)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-05 16:56:01 UTC (rev 102004)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2011-12-05 17:07:30 UTC (rev 102005)
@@ -104,12 +104,6 @@
 
 class Capitalizer:
 @staticmethod
-def lower_camel_case_to_upper(str):
-if len(str)  0 and str[0].islower():
-str = str[0].upper() + str[1:]
-return str
-
-@staticmethod
 def upper_camel_case_to_lower(str):
 pos = 0
 while pos  len(str) and str[pos].isupper():
@@ -126,47 +120,6 @@
 str = possible_abbreviation.lower() + str[pos:]
 return str
 
-@staticmethod
-def camel_case_to_capitalized_with_underscores(str):
-if len(str) == 0:
-return str
-output = Capitalizer.split_camel_case_(str)
-pos = 0
-while pos  len(output):
-output[pos] = output[pos].upper()
-pos += 1
-return _.join(output)
-
-@staticmethod
-def split_camel_case_(str):
-output = []
-pos_being = 0
-pos = 1
-has_oneletter = False
-while pos  len(str):
-if str[pos].isupper():
-output.append(str[pos_being:pos].upper())
-if pos - pos_being == 1:
-has_oneletter = True
-pos_being = pos
-pos += 1
-output.append(str[pos_being:])
-if has_oneletter:
-array_pos = 0
-while array_pos  len(output) - 1:
-if len(output[array_pos]) == 1:
-array_pos_end = array_pos + 1
-while array_pos_end  len(output) and len(output[array_pos_end]) == 1:
-array_pos_end += 1
-if array_pos_end - array_pos  1:
-possible_abbreviation = .join(output[array_pos:array_pos_end])
-if possible_abbreviation.upper() in Capitalizer.ABBREVIATION:
-output[array_pos:array_pos_end] = [possible_abbreviation]
-else:
-array_pos = array_pos_end - 1
-array_pos += 1
-return output
-
 ABBREVIATION = frozenset([XHR, DOM, CSS])
 
 
@@ -233,8 +186,6 @@
 return RawTypes.Int
 elif json_type == number:
 return RawTypes.Number
-elif json_type == any:
-return RawTypes.Any
 else:
 raise Exception(Unknown type: %s % json_type)
 
@@ -250,7 +201,7 @@
 class String(BaseType):
 @classmethod
 def get_c_param_type(cls, param_type, optional):
-

[webkit-changes] [102006] trunk/Source/WebCore

2011-12-05 Thread mnaganov

Title: [102006] trunk/Source/WebCore








Revision 102006
Author mnaga...@chromium.org
Date 2011-12-05 09:29:50 -0800 (Mon, 05 Dec 2011)


Log Message
Web Inspector: [Chromium] Heap profiler should designate weak references.
https://bugs.webkit.org/show_bug.cgi?id=69948

Weak references are now ignored when tracing paths to GC roots.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdge.prototype.get isWeak):
(WebInspector.HeapSnapshotEdge.prototype.toString):
(WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
(WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (102005 => 102006)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 17:07:30 UTC (rev 102005)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 17:29:50 UTC (rev 102006)
@@ -1,3 +1,21 @@
+2011-12-05  Mikhail Naganov  mnaga...@chromium.org
+
+Web Inspector: [Chromium] Heap profiler should designate weak references.
+https://bugs.webkit.org/show_bug.cgi?id=69948
+
+Weak references are now ignored when tracing paths to GC roots.
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshotEdge.prototype.get isWeak):
+(WebInspector.HeapSnapshotEdge.prototype.toString):
+(WebInspector.HeapSnapshotEdge.prototype.get _hasStringName):
+(WebInspector.HeapSnapshotRetainerEdge.prototype.get isWeak):
+(WebInspector.HeapSnapshot.prototype._init):
+(WebInspector.HeapSnapshotPathFinder.prototype._fillRootChildren):
+(WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
+
 2011-12-05  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r102004.


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (102005 => 102006)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2011-12-05 17:07:30 UTC (rev 102005)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2011-12-05 17:29:50 UTC (rev 102006)
@@ -236,6 +236,11 @@
 return this._type() === this._snapshot._edgeHiddenType;
 },
 
+get isWeak()
+{
+return this._type() === this._snapshot._edgeWeakType;
+},
+
 get isInternal()
 {
 return this._type() === this._snapshot._edgeInternalType;
@@ -279,6 +284,7 @@
 switch (this.type) {
 case context: return - + this.name;
 case element: return [ + this.name + ];
+case weak: return [[ + this.name + ]];
 case property:
 return this.name.indexOf( ) === -1 ? . + this.name : [\ + this.name + \];
 case shortcut:
@@ -302,7 +308,7 @@
 
 get _hasStringName()
 {
-return !this.isElement  !this.isHidden;
+return !this.isElement  !this.isHidden  !this.isWeak;
 },
 
 get _name()
@@ -401,6 +407,11 @@
 return this._edge.isShortcut;
 },
 
+get isWeak()
+{
+return this._edge.isWeak;
+},
+
 get name()
 {
 return this._edge.name;
@@ -695,6 +706,7 @@
 this._edgeHiddenType = this._edgeTypes.indexOf(hidden);
 this._edgeInternalType = this._edgeTypes.indexOf(internal);
 this._edgeShortcutType = this._edgeTypes.indexOf(shortcut);
+this._edgeWeakType = this._edgeTypes.indexOf(weak);
 this._edgeInvisibleType = this._edgeTypes.length;
 this._edgeTypes.push(invisible);
 
@@ -1406,8 +1418,12 @@
 {
 var result = [];
 for (var iter = this._snapshot.rootNode.edges; iter.hasNext(); iter.next()) {
-if (!filter || filter(iter.edge.node))
+if (!filter) {
+if (!iter.edge.isShortcut)
+result[iter.edge.nodeIndex] = true;
+} else if (filter(iter.edge.node)) {
 result[iter.edge.nodeIndex] = true;
+}
 }
 return result;
 },
@@ -1450,6 +1466,7 @@
 {
 return edge.isInvisible
 || (this._skipHidden  (edge.isHidden || edge.node.isHidden))
+|| edge.isWeak
 || this._hasInPath(edge.nodeIndex);
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102007] trunk/LayoutTests

2011-12-05 Thread scheib

Title: [102007] trunk/LayoutTests








Revision 102007
Author sch...@chromium.org
Date 2011-12-05 09:42:21 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Expected flakey tests after fix for 65796 is committed
https://bugs.webkit.org/show_bug.cgi?id=73587

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney schen...@chromium.org on 2011-12-05

* platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/chromium/test_expectations.txt: Removed redundant flakey

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102006 => 102007)

--- trunk/LayoutTests/ChangeLog	2011-12-05 17:29:50 UTC (rev 102006)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 17:42:21 UTC (rev 102007)
@@ -1,3 +1,16 @@
+2011-12-05  Stephen Chenney  schen...@chromium.org
+
+[Chromium] Expected flakey tests after fix for 65796 is committed
+https://bugs.webkit.org/show_bug.cgi?id=73587
+
+Unreviewed chromium tests expectations update.
+
+* platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
+* platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png: Added.
+* platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
+* platform/chromium/test_expectations.txt: Removed redundant flakey
+
 2011-12-05  Eric Carlson  eric.carl...@apple.com
 
 Out-of-band text tracks may only load from same origin as the media element's Document's origin


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102006 => 102007)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 17:29:50 UTC (rev 102006)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 17:42:21 UTC (rev 102007)
@@ -3810,8 +3810,6 @@
 BUGWK73494 : svg/as-image/svg-non-integer-scaled-image.html = IMAGE PASS
 BUGWK73494 DEBUG : svg/hixie/perf/007.xml = PASS TIMEOUT
 
-BUGWK73587 : svg/custom/path-moveto-only-rendering.svg = PASS IMAGE
-BUGWK73587 : svg/custom/subpaths-moveto-only-rendering.svg = PASS IMAGE
 
 BUGWK73514 WIN DEBUG : platform/chromium/compositing/lost-compositor-context-permanently.html = TIMEOUT
 BUGWK73517 WIN DEBUG : inspector/console/console-command-clear.html = CRASH


Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/path-moveto-only-rendering-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/subpaths-moveto-only-rendering-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/svg/custom/path-moveto-only-rendering-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/svg/custom/subpaths-moveto-only-rendering-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102008] trunk/LayoutTests

2011-12-05 Thread scheib

Title: [102008] trunk/LayoutTests








Revision 102008
Author sch...@chromium.org
Date 2011-12-05 09:47:57 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Expected flakey tests after fix for 73021 is committed
https://bugs.webkit.org/show_bug.cgi?id=73677

Unreviewed chromium tests expectations update.

Patch by Stephen Chenney schen...@chromium.org on 2011-12-05

* platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke: Added.
* platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/stroke/
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png
trunk/LayoutTests/platform/chromium-win/svg/stroke/
trunk/LayoutTests/platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102007 => 102008)

--- trunk/LayoutTests/ChangeLog	2011-12-05 17:42:21 UTC (rev 102007)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 17:47:57 UTC (rev 102008)
@@ -1,5 +1,19 @@
 2011-12-05  Stephen Chenney  schen...@chromium.org
 
+[Chromium] Expected flakey tests after fix for 73021 is committed
+https://bugs.webkit.org/show_bug.cgi?id=73677
+
+Unreviewed chromium tests expectations update.
+
+* platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/stroke: Added.
+* platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
+* platform/chromium-win/svg/stroke: Added.
+* platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
+2011-12-05  Stephen Chenney  schen...@chromium.org
+
 [Chromium] Expected flakey tests after fix for 65796 is committed
 https://bugs.webkit.org/show_bug.cgi?id=73587
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102007 => 102008)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 17:42:21 UTC (rev 102007)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 17:47:57 UTC (rev 102008)
@@ -816,7 +816,6 @@
 // SVG TESTS
 // -
 
-BUGWK73677 : svg/stroke/zero-length-arc-linecaps-rendering.svg = PASS IMAGE
 
 BUGCR8763 MAC : svg/custom/use-on-g-containing-foreignObject-and-image.svg = IMAGE
 


Added: trunk/LayoutTests/platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/svg/stroke/zero-length-arc-linecaps-rendering-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/stroke/zero-length-arc-linecaps-rendering-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-win/svg/stroke/zero-length-arc-linecaps-rendering-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102009] trunk/LayoutTests

2011-12-05 Thread scheib

Title: [102009] trunk/LayoutTests








Revision 102009
Author sch...@chromium.org
Date 2011-12-05 09:59:01 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Rebaselining aria-checkbox-sends-notification-expected

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt
trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt
trunk/LayoutTests/platform/chromium-mac-leopard/accessibility/
trunk/LayoutTests/platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102008 => 102009)

--- trunk/LayoutTests/ChangeLog	2011-12-05 17:47:57 UTC (rev 102008)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 17:59:01 UTC (rev 102009)
@@ -1,3 +1,12 @@
+2011-12-05  Vincent Scheib  sch...@chromium.org
+
+[Chromium] Rebaselining aria-checkbox-sends-notification-expected
+
+* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
+* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
+* platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
+* platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.
+
 2011-12-05  Stephen Chenney  schen...@chromium.org
 
 [Chromium] Expected flakey tests after fix for 73021 is committed


Added: trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt (0 => 102009)

--- trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	2011-12-05 17:59:01 UTC (rev 102009)
@@ -0,0 +1,12 @@
+Test Checkbox
+This tests that checking of an aria checkbox sends a notification.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Got notification: CheckedStateChanged
+Got notification: CheckedStateChanged
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt (0 => 102009)

--- trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt	2011-12-05 17:59:01 UTC (rev 102009)
@@ -0,0 +1,14 @@
+Test Checkbox
+This tests that checking of an aria checkbox sends a notification.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Got notification: CheckedStateChanged
+Got notification: CheckedStateChanged
+Got notification: LayoutComplete
+Got notification: LayoutComplete
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on: trunk/LayoutTests/platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt (0 => 102009)

--- trunk/LayoutTests/platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt	2011-12-05 17:59:01 UTC (rev 102009)
@@ -0,0 +1,12 @@
+Test Checkbox
+This tests that checking of an aria checkbox sends a notification.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Got notification: CheckedStateChanged
+Got notification: CheckedStateChanged
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Property changes on:

[webkit-changes] [102010] trunk/LayoutTests

2011-12-05 Thread scheib

Title: [102010] trunk/LayoutTests








Revision 102010
Author sch...@chromium.org
Date 2011-12-05 10:13:13 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (102009 => 102010)

--- trunk/LayoutTests/ChangeLog	2011-12-05 17:59:01 UTC (rev 102009)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 18:13:13 UTC (rev 102010)
@@ -1,5 +1,11 @@
 2011-12-05  Vincent Scheib  sch...@chromium.org
 
+[Chromium] Marking animations/animation-add-events-in-handler CRASH in test_expectations
+
+* platform/chromium/test_expectations.txt:
+
+2011-12-05  Vincent Scheib  sch...@chromium.org
+
 [Chromium] Rebaselining aria-checkbox-sends-notification-expected
 
 * platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Added.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102009 => 102010)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 17:59:01 UTC (rev 102009)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 18:13:13 UTC (rev 102010)
@@ -3827,3 +3827,5 @@
 BUGWK73692 WIN LEOPARD : media/event-attributes.html = TEXT PASS
 
 BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = FAIL
+
+BUGWK73838 LEOPARD DEBUG : animations/animation-add-events-in-handler.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102011] trunk/Source/JavaScriptCore

2011-12-05 Thread barraclough

Title: [102011] trunk/Source/_javascript_Core








Revision 102011
Author barraclo...@apple.com
Date 2011-12-05 10:25:45 -0800 (Mon, 05 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=73624
JIT + INTERPRETER builds are broken

Reviewed by Geoff Garen, Sam Weinig.

These don't fallback to the interpreter correctly.
Thunk creation assumes that is the JIT is compiled in, then it is enabled.

* jit/JITStubs.cpp:
(JSC::JITThunks::JITThunks):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/Interpreter.cpp
trunk/Source/_javascript_Core/jit/JITStubs.cpp
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/Lookup.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102010 => 102011)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 18:13:13 UTC (rev 102010)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 18:25:45 UTC (rev 102011)
@@ -1,3 +1,21 @@
+2011-12-01  Gavin Barraclough  barraclo...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73624
+JIT + INTERPRETER builds are broken
+
+Reviewed by Geoff Garen, Sam Weinig.
+
+These don't fallback to the interpreter correctly.
+Thunk creation assumes that is the JIT is compiled in, then it is enabled.
+
+* jit/JITStubs.cpp:
+(JSC::JITThunks::JITThunks):
+* runtime/Executable.h:
+(JSC::NativeExecutable::create):
+(JSC::NativeExecutable::finishCreation):
+* runtime/JSGlobalData.cpp:
+(JSC::JSGlobalData::getHostFunction):
+
 2011-12-05  Zoltan Herczeg  zherc...@webkit.org
 
 MacroAssemblerSH4 does not implement readCallTarget


Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (102010 => 102011)

--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-12-05 18:13:13 UTC (rev 102010)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp	2011-12-05 18:25:45 UTC (rev 102011)
@@ -3704,6 +3704,7 @@
 }
 DEFINE_OPCODE(op_loop_hint) {
 // This is a no-op unless we intend on doing OSR from the interpreter.
+vPC += OPCODE_LENGTH(op_loop_hint);
 NEXT_INSTRUCTION();
 }
 DEFINE_OPCODE(op_loop_if_true) {


Modified: trunk/Source/_javascript_Core/jit/JITStubs.cpp (102010 => 102011)

--- trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-12-05 18:13:13 UTC (rev 102010)
+++ trunk/Source/_javascript_Core/jit/JITStubs.cpp	2011-12-05 18:25:45 UTC (rev 102011)
@@ -760,7 +760,7 @@
 JITThunks::JITThunks(JSGlobalData* globalData)
 : m_hostFunctionStubMap(adoptPtr(new HostFunctionStubMap))
 {
-if (!globalData-executableAllocator.isValid())
+if (!globalData-canUseJIT())
 return;
 
 m_executableMemory = JIT::compileCTIMachineTrampolines(globalData, m_trampolineStructure);


Modified: trunk/Source/_javascript_Core/runtime/Executable.h (102010 => 102011)

--- trunk/Source/_javascript_Core/runtime/Executable.h	2011-12-05 18:13:13 UTC (rev 102010)
+++ trunk/Source/_javascript_Core/runtime/Executable.h	2011-12-05 18:25:45 UTC (rev 102011)
@@ -183,6 +183,7 @@
 #if ENABLE(JIT)
 static NativeExecutable* create(JSGlobalData globalData, MacroAssemblerCodeRef callThunk, NativeFunction function, MacroAssemblerCodeRef constructThunk, NativeFunction constructor, DFG::Intrinsic intrinsic)
 {
+ASSERT(globalData.canUseJIT());
 NativeExecutable* executable;
 if (!callThunk) {
 executable = new (allocateCellNativeExecutable(globalData.heap)) NativeExecutable(globalData, function, constructor);
@@ -194,9 +195,12 @@
 globalData.heap.addFinalizer(executable, finalize);
 return executable;
 }
-#else
+#endif
+
+#if ENABLE(INTERPRETER)
 static NativeExecutable* create(JSGlobalData globalData, NativeFunction function, NativeFunction constructor)
 {
+ASSERT(!globalData.canUseJIT());
 NativeExecutable* executable = new (allocateCellNativeExecutable(globalData.heap)) NativeExecutable(globalData, function, constructor);
 executable-finishCreation(globalData);
 globalData.heap.addFinalizer(executable, finalize);
@@ -221,6 +225,7 @@
 #if ENABLE(JIT)
 void finishCreation(JSGlobalData globalData, JITCode callThunk, JITCode constructThunk, DFG::Intrinsic intrinsic)
 {
+ASSERT(globalData.canUseJIT());
 Base::finishCreation(globalData);
 m_jitCodeForCall = callThunk;
 m_jitCodeForConstruct = constructThunk;
@@ -233,7 +238,15 @@
 #endif
 }
 #endif
-
+
+#if ENABLE(INTERPRETER)
+void finishCreation(JSGlobalData globalData)
+{
+

[webkit-changes] [102012] trunk/Source/WebCore

2011-12-05 Thread timothy

Title: [102012] trunk/Source/WebCore








Revision 102012
Author timo...@apple.com
Date 2011-12-05 10:40:06 -0800 (Mon, 05 Dec 2011)


Log Message
Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
they have been combined into inspector.js.

The InspectorBackend.js file split out of the generated InspectorBackendStub.js
in r101670, and both files are needed to be useful.

https://webkit.org/b/73839

Reviewed by Joseph Pecoraro and Brian Weinstein.

* WebCore.xcodeproj/project.pbxproj: Pass -not -name InspectorBackend*.js to find
instead of -not -name InspectorBackendStub.js.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (102011 => 102012)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 18:25:45 UTC (rev 102011)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 18:40:06 UTC (rev 102012)
@@ -1,3 +1,18 @@
+2011-12-05  Timothy Hatcher  timo...@apple.com
+
+Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after
+they have been combined into inspector.js.
+
+The InspectorBackend.js file split out of the generated InspectorBackendStub.js
+in r101670, and both files are needed to be useful.
+
+https://webkit.org/b/73839
+
+Reviewed by Joseph Pecoraro and Brian Weinstein.
+
+* WebCore.xcodeproj/project.pbxproj: Pass -not -name InspectorBackend*.js to find
+instead of -not -name InspectorBackendStub.js.
+
 2011-12-05  Mikhail Naganov  mnaga...@chromium.org
 
 Web Inspector: [Chromium] Heap profiler should designate weak references.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (102011 => 102012)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-05 18:25:45 UTC (rev 102011)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-12-05 18:40:06 UTC (rev 102012)
@@ -24919,7 +24919,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = # Don't do anything for Debug builds, so the Inspector is easier to debug.\nif [[ ${CONFIGURATION:=Debug} == \Debug\ ]]; then\nexit\nfi\n\n# Combine all script resources in the inspector.html file.\n\$SRCROOT/inspector/combine-_javascript_-resources.pl\ --input-html \${SRCROOT}/inspector/front-end/inspector.html\ --generated-scripts-dir \${BUILT_PRODUCTS_DIR}/DerivedSources/WebCore\ --output-dir \${DERIVED_FILE_DIR}/WebCore\ --output-script-name inspector.js\n\n# Inline script imports in ScriptFormatterWorker.js file.\n\$SRCROOT/inspector/inline-_javascript_-imports.py\ \${SRCROOT}/inspector/front-end/ScriptFormatterWorker.js\ \${SRCROOT}/inspector/front-end\ \${DERIVED_FILE_DIR}/WebCore/scriptFormatterWorker.js\\n\nif [ -d \${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\ ]; then\ncd \${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\\n\n# Remove any top-level _javascript_ files, since they will be replaced with the combined file.\n# Keep InspectorBackendStub.js so it can be used by other front-ends.\nfind . -depth 1 -name \*.js\ -not -name InspectorBackendStub.js | xargs rm -rf\n\n# Copy the modified HTML file and the combined scripts.\ncp \${DERIVED_FILE_DIR}/WebCore/inspector.html\ inspector.html\ncp \${DERIVED_FILE_DIR}/WebCore/inspector.js\ inspector.js\ncp \${DERIVED_FILE_DIR}/WebCore/scriptFormatterWorker.js\ scriptFormatterWorker.js\nfi\n;
+			shellScript = # Don't do anything for Debug builds, so the Inspector is easier to debug.\nif [[ ${CONFIGURATION:=Debug} == \Debug\ ]]; then\nexit\nfi\n\n# Combine all script resources in the inspector.html file.\n\$SRCROOT/inspector/combine-_javascript_-resources.pl\ --input-html \${SRCROOT}/inspector/front-end/inspector.html\ --generated-scripts-dir \${BUILT_PRODUCTS_DIR}/DerivedSources/WebCore\ --output-dir \${DERIVED_FILE_DIR}/WebCore\ --output-script-name inspector.js\n\n# Inline script imports in ScriptFormatterWorker.js file.\n\$SRCROOT/inspector/inline-_javascript_-imports.py\ \${SRCROOT}/inspector/front-end/ScriptFormatterWorker.js\ \${SRCROOT}/inspector/front-end\ \${DERIVED_FILE_DIR}/WebCore/scriptFormatterWorker.js\\n\nif [ -d \${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\ ]; then\ncd \${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\\n\n# Remove any top-level _javascript_ files, since they will be replaced with the combined file.\n# Keep InspectorBackend*.js files so they can be used by other front-ends.\nfind . -depth 1 -name \*.js\ -not -name \InspectorBackend*.js\ | xargs rm -rf\n\n# Copy the modified HTML file and the combined scripts.\ncp \${DERIVED_FILE_DIR}/WebCore/inspector.html\ inspector.html\ncp \${DERIVED_FILE_DIR}/WebCore/inspector.js\ inspector.js\ncp \${DERIVED_FILE_DIR}/WebCore/scriptFormatterWorker.js\ scriptFormatterWorker.js\nfi\n;
 		};

[webkit-changes] [102013] trunk/Tools

2011-12-05 Thread rniwa

Title: [102013] trunk/Tools








Revision 102013
Author rn...@webkit.org
Date 2011-12-05 10:40:15 -0800 (Mon, 05 Dec 2011)


Log Message
Temporarily set --child-process=1 on Mac because 20+ tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=73840

Reviewed by Simon Fraser.

Temporarily go back to single process mode on Mac.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests




Diff

Modified: trunk/Tools/ChangeLog (102012 => 102013)

--- trunk/Tools/ChangeLog	2011-12-05 18:40:06 UTC (rev 102012)
+++ trunk/Tools/ChangeLog	2011-12-05 18:40:15 UTC (rev 102013)
@@ -1,3 +1,15 @@
+2011-12-05  Ryosuke Niwa  rn...@webkit.org
+
+Temporarily set --child-process=1 on Mac because 20+ tests are timing out
+https://bugs.webkit.org/show_bug.cgi?id=73840
+
+Reviewed by Simon Fraser.
+
+Temporarily go back to single process mode on Mac.
+
+* Scripts/run-webkit-tests:
+(platformIsReadyForParallelTesting):
+
 2011-12-05  Adam Roben  aro...@apple.com
 
 Redeploy apple-macpro-7 and apple-xserve-1


Modified: trunk/Tools/Scripts/run-webkit-tests (102012 => 102013)

--- trunk/Tools/Scripts/run-webkit-tests	2011-12-05 18:40:06 UTC (rev 102012)
+++ trunk/Tools/Scripts/run-webkit-tests	2011-12-05 18:40:15 UTC (rev 102013)
@@ -76,7 +76,7 @@
 # We believe all platforms are ready for default parallel testing except
 # Qt, as Qt runs more than one build-slave per-server.
 # Ossy has asked me to blacklist Qt for now.
-return !isQt();
+return !isQt() and !isMac();
 }
 
 my $harnessName = old-run-webkit-tests;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102016] trunk/Source/WebCore

2011-12-05 Thread sfalken

Title: [102016] trunk/Source/WebCore








Revision 102016
Author sfal...@apple.com
Date 2011-12-05 10:46:55 -0800 (Mon, 05 Dec 2011)


Log Message
2011-12-05  Steve Falkenburg  sfal...@apple.com

Reviewed by Sam Weinig.

On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
https://bugs.webkit.org/show_bug.cgi?id=73841
rdar://problem/10521879

No test since repro case involves dropping a file onto the WebView.

Calling characters() explicitly causes a non-terminated string buffer to get passed back
to the String() constructor that expects a terminated buffer. The characters() call isn't
necessary at all, since we have a String and the method we're calling expects a String.

* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/win/ClipboardWin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102015 => 102016)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 18:45:30 UTC (rev 102015)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 18:46:55 UTC (rev 102016)
@@ -1,3 +1,20 @@
+2011-12-05  Steve Falkenburg  sfal...@apple.com
+
+Reviewed by Sam Weinig.
+
+On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
+https://bugs.webkit.org/show_bug.cgi?id=73841
+rdar://problem/10521879
+
+No test since repro case involves dropping a file onto the WebView.
+
+Calling characters() explicitly causes a non-terminated string buffer to get passed back
+to the String() constructor that expects a terminated buffer. The characters() call isn't
+necessary at all, since we have a String and the method we're calling expects a String.
+
+* platform/win/ClipboardWin.cpp:
+(WebCore::ClipboardWin::files): Remove characters() since it doesn't null terminate.
+
 2011-12-05  Timothy Hatcher  timo...@apple.com
 
 Keep both InspectorBackend.js and InspectorBackendStub.js in Release builds after


Modified: trunk/Source/WebCore/platform/win/ClipboardWin.cpp (102015 => 102016)

--- trunk/Source/WebCore/platform/win/ClipboardWin.cpp	2011-12-05 18:45:30 UTC (rev 102015)
+++ trunk/Source/WebCore/platform/win/ClipboardWin.cpp	2011-12-05 18:46:55 UTC (rev 102016)
@@ -572,7 +572,7 @@
 return files.release();
 VectorString filesVector = m_dragDataMap.get(cfHDropFormat()-cfFormat);
 for (VectorString::iterator it = filesVector.begin(); it != filesVector.end(); ++it)
-files-append(File::create((*it).characters()));
+files-append(File::create(*it));
 return files.release();
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102017] trunk/Source/JavaScriptCore

2011-12-05 Thread msaboff

Title: [102017] trunk/Source/_javascript_Core








Revision 102017
Author msab...@apple.com
Date 2011-12-05 11:08:44 -0800 (Mon, 05 Dec 2011)


Log Message
8 bit string work slows down Kraken json-stringify-tinderbox
https://bugs.webkit.org/show_bug.cgi?id=73457

Added 8 bit path to StringBuilder.  StringBuilder starts
assuming 8 bit contents and gets converted to 16 bit upon
seeing the first 16 bit character or string.  Split
appendUninitialiezed into an inlined fast and function call
slow case.

Factored out the processing of the UString argument from
Stringifier::appendQuotedString() to a static templated function
based on character size.

This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
This change introduces a 4.8% slowdown to json-parse-financial.
This slowdown will be addressed in a subsequent patch to StringImpl::equal.

Reviewed by Oliver Hunt.

* runtime/JSONObject.cpp:
(JSC::appendStringToUStringBuilder):
(JSC::Stringifier::appendQuotedString):
* wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::LChar):
(WTF::UChar):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::shrinkToFit):
* wtf/text/StringBuilder.h:
(WTF::StringBuilder::StringBuilder):
(WTF::StringBuilder::append):
(WTF::StringBuilder::operator[]):
(WTF::StringBuilder::characters8):
(WTF::StringBuilder::characters16):
(WTF::StringBuilder::charactersBlah):
(WTF::LChar):
(WTF::UChar):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/wtf/text/StringBuilder.cpp
trunk/Source/_javascript_Core/wtf/text/StringBuilder.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102016 => 102017)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 18:46:55 UTC (rev 102016)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 19:08:44 UTC (rev 102017)
@@ -1,3 +1,48 @@
+2011-12-05  Michael Saboff  msab...@apple.com
+
+8 bit string work slows down Kraken json-stringify-tinderbox
+https://bugs.webkit.org/show_bug.cgi?id=73457
+
+Added 8 bit path to StringBuilder.  StringBuilder starts
+assuming 8 bit contents and gets converted to 16 bit upon
+seeing the first 16 bit character or string.  Split
+appendUninitialiezed into an inlined fast and function call
+slow case.
+
+Factored out the processing of the UString argument from
+Stringifier::appendQuotedString() to a static templated function
+based on character size.
+
+This change eliminates 5% of the 7% slowdown to json-stringify-tinderbox.
+This change introduces a 4.8% slowdown to json-parse-financial.
+This slowdown will be addressed in a subsequent patch to StringImpl::equal.
+
+Reviewed by Oliver Hunt.
+
+* runtime/JSONObject.cpp:
+(JSC::appendStringToUStringBuilder):
+(JSC::Stringifier::appendQuotedString):
+* wtf/text/StringBuilder.cpp:
+(WTF::StringBuilder::resize):
+(WTF::StringBuilder::allocateBuffer):
+(WTF::StringBuilder::allocateBufferUpConvert):
+(WTF::LChar):
+(WTF::UChar):
+(WTF::StringBuilder::reserveCapacity):
+(WTF::StringBuilder::appendUninitialized):
+(WTF::StringBuilder::appendUninitializedSlow):
+(WTF::StringBuilder::append):
+(WTF::StringBuilder::shrinkToFit):
+* wtf/text/StringBuilder.h:
+(WTF::StringBuilder::StringBuilder):
+(WTF::StringBuilder::append):
+(WTF::StringBuilder::operator[]):
+(WTF::StringBuilder::characters8):
+(WTF::StringBuilder::characters16):
+(WTF::StringBuilder::charactersBlah):
+(WTF::LChar):
+(WTF::UChar):
+
 2011-12-01  Gavin Barraclough  barraclo...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=73624


Modified: trunk/Source/_javascript_Core/runtime/JSONObject.cpp (102016 => 102017)

--- trunk/Source/_javascript_Core/runtime/JSONObject.cpp	2011-12-05 18:46:55 UTC (rev 102016)
+++ trunk/Source/_javascript_Core/runtime/JSONObject.cpp	2011-12-05 19:08:44 UTC (rev 102017)
@@ -266,13 +266,9 @@
 return LocalUnknown(m_exec-globalData(), jsString(m_exec, result.toUString()));
 }
 
-void Stringifier::appendQuotedString(UStringBuilder builder, const UString value)
+template typename CharType
+static void appendStringToUStringBuilder(UStringBuilder builder, const CharType* data, int length)
 {
-int length = value.length();
-
-builder.append('');
-
-const UChar* data = ""
 for (int i = 0; i  length; ++i) {
 int start = i;
 while (i  length  (data[i]  0x1F  data[i] != ''  data[i] != '\\'))
@@ -281,44 +277,56 @@
 if (i = length)
 break;
 switch

[webkit-changes] [102018] trunk/Source/WebCore

2011-12-05 Thread peter

Title: [102018] trunk/Source/WebCore








Revision 102018
Author pe...@chromium.org
Date 2011-12-05 11:10:21 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
https://bugs.webkit.org/show_bug.cgi?id=73672

Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
of an older file from the Android port:
http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704

Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
file upload boxes, which is not something we want to support now. Also
include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
as their functionality can be re-used for Android.

Reviewed by Adam Barth.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/KeyCodeConversionAndroid.cpp: Added.
(WebCore::windowsKeyCodeForKeyEvent):
* platform/graphics/chromium/IconChromiumAndroid.cpp: Added.
(WebCore::Icon::Icon):
(WebCore::Icon::~Icon):
(WebCore::Icon::paint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi


Added Paths

trunk/Source/WebCore/platform/chromium/KeyCodeConversionAndroid.cpp
trunk/Source/WebCore/platform/graphics/chromium/IconChromiumAndroid.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102017 => 102018)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 19:08:44 UTC (rev 102017)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 19:10:21 UTC (rev 102018)
@@ -1,3 +1,28 @@
+2011-12-05  Peter Beverloo  pe...@chromium.org
+
+[Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
+https://bugs.webkit.org/show_bug.cgi?id=73672
+
+Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land
+of an older file from the Android port:
+http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704
+
+Add IconChromiumAndroid.cpp which nullifies the rendering of icons in
+file upload boxes, which is not something we want to support now. Also
+include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp
+as their functionality can be re-used for Android.
+
+Reviewed by Adam Barth.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* platform/chromium/KeyCodeConversionAndroid.cpp: Added.
+(WebCore::windowsKeyCodeForKeyEvent):
+* platform/graphics/chromium/IconChromiumAndroid.cpp: Added.
+(WebCore::Icon::Icon):
+(WebCore::Icon::~Icon):
+(WebCore::Icon::paint):
+
 2011-12-05  Steve Falkenburg  sfal...@apple.com
 
 Reviewed by Sam Weinig.


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (102017 => 102018)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-05 19:08:44 UTC (rev 102017)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2011-12-05 19:10:21 UTC (rev 102018)
@@ -1643,12 +1643,15 @@
 }],
 ['OS==android', {
   'sources/': [
+['include', 'platform/chromium/ClipboardChromiumLinux\\.cpp$'],
+['include', 'platform/chromium/FileSystemChromiumLinux\\.cpp$'],
 ['include', 'platform/graphics/chromium/ComplexTextControllerLinux\\.cpp$'],
 ['include', 'platform/graphics/chromium/FontLinux\\.cpp$'],
 ['include', 'platform/graphics/chromium/FontPlatformDataLinux\\.cpp$'],
 ['include', 'platform/graphics/chromium/GlyphPageTreeNodeLinux\\.cpp$'],
+['include', 'platform/graphics/chromium/HarfbuzzSkia\\.cpp$'],
+['exclude', 'platform/graphics/chromium/IconChromium\\.cpp$'],
 ['include', 'platform/graphics/chromium/SimpleFontDataLinux\\.cpp$'],
-['include', 'platform/graphics/chromium/HarfbuzzSkia\\.cpp$'],
 ['include', 'platform/graphics/chromium/VDMXParser\\.cpp$'],
   ],
 }, { # OS!=android


Modified: trunk/Source/WebCore/WebCore.gypi (102017 => 102018)

--- trunk/Source/WebCore/WebCore.gypi	2011-12-05 19:08:44 UTC (rev 102017)
+++ trunk/Source/WebCore/WebCore.gypi	2011-12-05 19:10:21 UTC (rev 102018)
@@ -3261,6 +3261,7 @@
 'platform/chromium/GestureRecognizerChromium.cpp',
 'platform/chromium/GestureRecognizerChromium.h',
 'platform/chromium/KeyCodeConversion.h',
+'platform/chromium/KeyCodeConversionAndroid.cpp',
 'platform/chromium/KeyCodeConversionGtk.cpp',
 'platform/chromium/KeyboardCodes.h',
 'platform/chromium/LanguageChromium.cpp',
@@ -3517,6 +3518,7 @@
 'platform/graphics/chromium/HarfbuzzSkia.cpp',
 'platform/graphics/chromium/HarfbuzzSkia.h',
 'platform/graphics/chromium/IconChromium.cpp',
+'platform/graphics/chromium/IconChromiumAndroid.cpp',
 'platform/graphics/chromium/ImageBufferDataSkia.h',

[webkit-changes] [102019] trunk/Source/WebKit/chromium

2011-12-05 Thread jamesr

Title: [102019] trunk/Source/WebKit/chromium








Revision 102019
Author jam...@google.com
Date 2011-12-05 11:12:26 -0800 (Mon, 05 Dec 2011)


Log Message
[chromium] Remove forwarding headers for WebLayer APIs
https://bugs.webkit.org/show_bug.cgi?id=73729

Reviewed by Adam Barth.

These are no longer necessary.

* WebKit.gyp:
* public/WebContentLayer.h: Removed.
* public/WebContentLayerClient.h: Removed.
* public/WebExternalTextureLayer.h: Removed.
* public/WebLayer.h: Removed.
* public/WebLayerClient.h: Removed.
* public/WebLayerTreeView.h: Removed.
* public/WebLayerTreeViewClient.h: Removed.
* src/WebLayerTreeView.cpp:
* src/WebLayerTreeViewImpl.cpp:
* tests/WebLayerTest.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp
trunk/Source/WebKit/chromium/src/WebLayerTreeViewImpl.cpp
trunk/Source/WebKit/chromium/tests/WebLayerTest.cpp


Removed Paths

trunk/Source/WebKit/chromium/public/WebContentLayer.h
trunk/Source/WebKit/chromium/public/WebContentLayerClient.h
trunk/Source/WebKit/chromium/public/WebExternalTextureLayer.h
trunk/Source/WebKit/chromium/public/WebLayer.h
trunk/Source/WebKit/chromium/public/WebLayerClient.h
trunk/Source/WebKit/chromium/public/WebLayerTreeView.h
trunk/Source/WebKit/chromium/public/WebLayerTreeViewClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102018 => 102019)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 19:10:21 UTC (rev 102018)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 19:12:26 UTC (rev 102019)
@@ -1,3 +1,24 @@
+2011-12-02  James Robinson  jam...@chromium.org
+
+[chromium] Remove forwarding headers for WebLayer APIs
+https://bugs.webkit.org/show_bug.cgi?id=73729
+
+Reviewed by Adam Barth.
+
+These are no longer necessary.
+
+* WebKit.gyp:
+* public/WebContentLayer.h: Removed.
+* public/WebContentLayerClient.h: Removed.
+* public/WebExternalTextureLayer.h: Removed.
+* public/WebLayer.h: Removed.
+* public/WebLayerClient.h: Removed.
+* public/WebLayerTreeView.h: Removed.
+* public/WebLayerTreeViewClient.h: Removed.
+* src/WebLayerTreeView.cpp:
+* src/WebLayerTreeViewImpl.cpp:
+* tests/WebLayerTest.cpp:
+
 2011-12-05  Vsevolod Vlasov  vse...@chromium.org
 
 Unreviewed, fixed chromium DEPS syntax.


Modified: trunk/Source/WebKit/chromium/WebKit.gyp (102018 => 102019)

--- trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-05 19:10:21 UTC (rev 102018)
+++ trunk/Source/WebKit/chromium/WebKit.gyp	2011-12-05 19:12:26 UTC (rev 102019)
@@ -103,29 +103,34 @@
 'public/linux/WebFontRenderStyle.h',
 'public/linux/WebRenderTheme.h',
 'public/linux/WebThemeEngine.h',
-'public/x11/WebScreenInfoFactory.h',
 'public/mac/WebInputEventFactory.h',
 'public/mac/WebSandboxSupport.h',
 'public/mac/WebScreenInfoFactory.h',
 'public/mac/WebSubstringUtil.h',
 'public/mac/WebThemeEngine.h',
+'public/platform/WebContentLayerClient.h',
+'public/platform/WebContentLayer.h',
+'public/platform/WebExternalTextureLayer.h',
+'public/platform/WebLayerClient.h',
+'public/platform/WebLayer.h',
+'public/platform/WebLayerTreeViewClient.h',
+'public/platform/WebLayerTreeView.h',
 'public/WebAccessibilityNotification.h',
 'public/WebAccessibilityObject.h',
 'public/WebAccessibilityRole.h',
 'public/WebAnimationController.h',
-'public/WebApplicationCacheHost.h',
 'public/WebApplicationCacheHostClient.h',
 'public/WebArrayBuffer.h',
 'public/WebArrayBufferView.h',
 'public/WebAttribute.h',
 'public/WebAudioBus.h',
 'public/WebAudioDevice.h',
-'public/WebAudioSourceProvider.h',
 'public/WebAudioSourceProviderClient.h',
+'public/WebAudioSourceProvider.h',
 'public/WebAutofillClient.h',
 'public/WebBindings.h',
-'public/WebBlob.h',
 'public/WebBlobData.h',
+'public/WebBlob.h',
 'public/WebBlobRegistry.h',
 'public/WebCache.h',
 'public/WebCanvas.h',
@@ -140,62 +145,59 @@
 'public/WebCompositorInputHandlerClient.h',
 'public/WebCompositorInputHandler.h',
 'public/WebConsoleMessage.h',
-'public/WebContentLayer.h',
-'public/WebContentLayerClient.h',
 'public/WebContextMenuData.h',
 'public/WebCookie.h',
 'public/WebCookieJar.h',

[webkit-changes] [102020] tags/Safari-535.53.5/

2011-12-05 Thread lforschler

Title: [102020] tags/Safari-535.53.5/








Revision 102020
Author lforsch...@apple.com
Date 2011-12-05 11:17:33 -0800 (Mon, 05 Dec 2011)


Log Message
New Tag.

Added Paths

tags/Safari-535.53.5/




Diff

Property changes: tags/Safari-535.53.5



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102021] tags/Safari-535.53.5/

2011-12-05 Thread lforschler

Title: [102021] tags/Safari-535.53.5/








Revision 102021
Author lforsch...@apple.com
Date 2011-12-05 11:22:12 -0800 (Mon, 05 Dec 2011)


Log Message
Remove incorrect tag.

Removed Paths

tags/Safari-535.53.5/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102022] tags/Safari-534.53.5/

2011-12-05 Thread lforschler

Title: [102022] tags/Safari-534.53.5/








Revision 102022
Author lforsch...@apple.com
Date 2011-12-05 11:22:33 -0800 (Mon, 05 Dec 2011)


Log Message
New Tag.

Added Paths

tags/Safari-534.53.5/




Diff

Property changes: tags/Safari-534.53.5



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102024] trunk/Source

2011-12-05 Thread jer . noble

Title: [102024] trunk/Source








Revision 102024
Author jer.no...@apple.com
Date 2011-12-05 11:47:19 -0800 (Mon, 05 Dec 2011)


Log Message
video elements should disable the system and display sleep when playing on OS X.
https://bugs.webkit.org/show_bug.cgi?id=73730
rdar://problem/9502155

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests; platform specific system behavior only.

Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
that object when the playback rate drops back to zero.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
* html/HTMLMediaElement.h:

Source/WebKit2:

Allow the WebProcess to make connections to the PowerManagement control mach server.

* WebProcess/com.apple.WebProcess.sb:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb




Diff

Modified: trunk/Source/WebCore/ChangeLog (102023 => 102024)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 19:33:12 UTC (rev 102023)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 19:47:19 UTC (rev 102024)
@@ -1,3 +1,20 @@
+2011-12-02  Jer Noble  jer.no...@apple.com
+
+video elements should disable the system and display sleep when playing on OS X.
+https://bugs.webkit.org/show_bug.cgi?id=73730
+rdar://problem/9502155
+
+Reviewed by Alexey Proskuryakov.
+
+No new tests; platform specific system behavior only.
+
+Create a new DisplaySleepDisabler object when the playback rate becomes non-zero, and destroy
+that object when the playback rate drops back to zero.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
+* html/HTMLMediaElement.h:
+
 2011-12-05  Peter Beverloo  pe...@chromium.org
 
 [Chromium] Add Android keycodes and build Linux clipboard/filesystem files.


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (102023 => 102024)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-12-05 19:33:12 UTC (rev 102023)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2011-12-05 19:47:19 UTC (rev 102024)
@@ -99,6 +99,10 @@
 #include MediaElementAudioSourceNode.h
 #endif
 
+#if PLATFORM(MAC)
+#include DisplaySleepDisabler.h
+#endif
+
 using namespace std;
 
 namespace WebCore {
@@ -2496,6 +2500,14 @@
 m_playbackRate = m_player-rate();
 if (m_playing)
 invalidateCachedTime();
+
+#if PLATFORM(MAC)
+if (m_player-paused()  m_sleepDisabler)
+m_sleepDisabler = nullptr;
+else if (!m_player-paused()  !m_sleepDisabler)
+m_sleepDisabler = DisplaySleepDisabler::create(com.apple.WebCore: HTMLMediaElement playback);
+#endif
+
 endProcessingMediaPlayerCallback();
 }
 


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (102023 => 102024)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2011-12-05 19:33:12 UTC (rev 102023)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2011-12-05 19:47:19 UTC (rev 102024)
@@ -62,6 +62,9 @@
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
 class Widget;
 #endif
+#if PLATFORM(MAC)
+class DisplaySleepDisabler;
+#endif
 
 // FIXME: The inheritance from MediaPlayerClient here should be private inheritance.
 // But it can't be until the Chromium WebMediaPlayerClientImpl class is fixed so it
@@ -557,6 +560,10 @@
 String m_mediaGroup;
 friend class MediaController;
 RefPtrMediaController m_mediaController;
+
+#if PLATFORM(MAC)
+OwnPtrDisplaySleepDisabler m_sleepDisabler;
+#endif
 };
 
 #if ENABLE(VIDEO_TRACK)


Modified: trunk/Source/WebKit2/ChangeLog (102023 => 102024)

--- trunk/Source/WebKit2/ChangeLog	2011-12-05 19:33:12 UTC (rev 102023)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-05 19:47:19 UTC (rev 102024)
@@ -1,3 +1,15 @@
+2011-12-03  Jer Noble  jer.no...@apple.com
+
+video elements should disable the system and display sleep when playing on OS X.
+https://bugs.webkit.org/show_bug.cgi?id=73730
+rdar://problem/9502155
+
+Reviewed by Alexey Proskuryakov.
+
+Allow the WebProcess to make connections to the PowerManagement control mach server.
+
+* WebProcess/com.apple.WebProcess.sb:
+
 2011-12-04  Sam Weinig  s...@webkit.org
 
 Move code for connections to/from the UIProcess/WebProcess into WebConnection subclasses


Modified: trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb (102023 => 102024)

--- trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-12-05 19:33:12 UTC (rev 102023)
+++ trunk/Source/WebKit2/WebProcess/com.apple.WebProcess.sb	2011-12-05 19:47:19 UTC (rev 102024)
@@ -163,6 +163,7 @@
(global-name com.apple.window_proxies)
(global-name com.apple.windowserver.active)
(global-name com.apple.cfnetwork.AuthBrokerAgent)
+   (global-name com.apple.PowerManagement.control)
 
;;

[webkit-changes] [102026] branches/safari-534.53-branch/Source/WebCore

2011-12-05 Thread lforschler

Title: [102026] branches/safari-534.53-branch/Source/WebCore








Revision 102026
Author lforsch...@apple.com
Date 2011-12-05 12:07:10 -0800 (Mon, 05 Dec 2011)


Log Message
Fixes to the branch made by Simon to get us building again.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
(WebCore::CSSStyleSelector::loadPendingImages):
* rendering/RenderBoxModelObject.cpp:
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/css/CSSStyleSelector.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderBoxModelObject.cpp




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102025 => 102026)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-05 20:03:59 UTC (rev 102025)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-05 20:07:10 UTC (rev 102026)
@@ -1,3 +1,14 @@
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
+Fixes to the branch made by Simon to get us building again.
+
+* css/CSSStyleSelector.cpp:
+(WebCore::CSSStyleSelector::mapNinePieceImageWidth):
+(WebCore::CSSStyleSelector::loadPendingImages):
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::computeBorderImageSide):
+(WebCore::RenderBoxModelObject::paintNinePieceImage):
+
 2011-12-02  Lucas Forschler  lforsch...@apple.com
 
 Merge 90959


Modified: branches/safari-534.53-branch/Source/WebCore/css/CSSStyleSelector.cpp (102025 => 102026)

--- branches/safari-534.53-branch/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-05 20:03:59 UTC (rev 102025)
+++ branches/safari-534.53-branch/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-05 20:07:10 UTC (rev 102026)
@@ -6269,7 +6269,7 @@
 return;
 
 // Get our zoom value.
-float zoom = useSVGZoomRules() ? 1.0f : style()-effectiveZoom();
+float zoom = useSVGZoomRules(m_element) ? 1.0f : style()-effectiveZoom();
 
 // Retrieve the primitive value.
 CSSPrimitiveValue* borderWidths = static_castCSSPrimitiveValue*(value);
@@ -6282,28 +6282,28 @@
 else if (slices-top()-primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
 box.m_top = Length(slices-top()-getDoubleValue(CSSPrimitiveValue::CSS_PERCENTAGE), Percent);
 else
-box.m_top = slices-top()-computeLengthLength(style(), rootElementStyle(), zoom);
+box.m_top = Length(slices-top()-computeLengthIntForLength(style(), m_rootElementStyle, zoom), Fixed);
 
 if (slices-right()-primitiveType() == CSSPrimitiveValue::CSS_NUMBER)
 box.m_right = Length(slices-right()-getIntValue(), Relative);
 else if (slices-right()-primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
 box.m_right = Length(slices-right()-getDoubleValue(CSSPrimitiveValue::CSS_PERCENTAGE), Percent);
 else
-box.m_right = slices-right()-computeLengthLength(style(), rootElementStyle(), zoom);
+box.m_right = Length(slices-right()-computeLengthIntForLength(style(), m_rootElementStyle, zoom), Fixed);
 
 if (slices-bottom()-primitiveType() == CSSPrimitiveValue::CSS_NUMBER)
 box.m_bottom = Length(slices-bottom()-getIntValue(), Relative);
 else if (slices-bottom()-primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
 box.m_bottom = Length(slices-bottom()-getDoubleValue(CSSPrimitiveValue::CSS_PERCENTAGE), Percent);
 else
-box.m_bottom = slices-bottom()-computeLengthLength(style(), rootElementStyle(), zoom);
+box.m_bottom = Length(slices-bottom()-computeLengthIntForLength(style(), m_rootElementStyle, zoom), Fixed);
 
 if (slices-left()-primitiveType() == CSSPrimitiveValue::CSS_NUMBER)
 box.m_left = Length(slices-left()-getIntValue(), Relative);
 else if (slices-left()-primitiveType() == CSSPrimitiveValue::CSS_PERCENTAGE)
 box.m_left = Length(slices-left()-getDoubleValue(CSSPrimitiveValue::CSS_PERCENTAGE), Percent);
 else
-box.m_left = slices-left()-computeLengthLength(style(), rootElementStyle(), zoom);
+box.m_left = Length(slices-left()-computeLengthIntForLength(style(), m_rootElementStyle, zoom), Fixed);
 
 image.setBorderSlices(box);
 }
@@ -7058,6 +7058,7 @@
 if (maskImage.image()  maskImage.image()-isPendingImage()) {
 CSSImageValue* imageValue = static_castStylePendingImage*(maskImage.image())-cssImageValue();
 reflection-setMask(NinePieceImage(imageValue-cachedImage(cachedResourceLoader), maskImage.imageSlices(), maskImage.fill(), maskImage.borderSlices(), maskImage.horizontalRule(), maskImage.verticalRule()));
+}
 }
 break;
 }


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderBoxModelObject.cpp (102025 => 102026)

---

[webkit-changes] [102027] branches/safari-534.53-branch/Source

2011-12-05 Thread lforschler

Title: [102027] branches/safari-534.53-branch/Source








Revision 102027
Author lforsch...@apple.com
Date 2011-12-05 12:08:59 -0800 (Mon, 05 Dec 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (102026 => 102027)

--- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-05 20:07:10 UTC (rev 102026)
+++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-05 20:08:59 UTC (rev 102027)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (102026 => 102027)

--- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-05 20:07:10 UTC (rev 102026)
+++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-05 20:08:59 UTC (rev 102027)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (102026 => 102027)

--- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-05 20:07:10 UTC (rev 102026)
+++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-05 20:08:59 UTC (rev 102027)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (102026 => 102027)

--- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-05 20:07:10 UTC (rev 102026)
+++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-05 20:08:59 UTC (rev 102027)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (102026 => 102027)

--- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-05 20:07:10 UTC (rev 102026)
+++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-05 20:08:59 UTC (rev 102027)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 5;
+TINY_VERSION = 6;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102028] trunk/Source/JavaScriptCore

2011-12-05 Thread benjamin

Title: [102028] trunk/Source/_javascript_Core








Revision 102028
Author benja...@webkit.org
Date 2011-12-05 12:27:47 -0800 (Mon, 05 Dec 2011)


Log Message
Update String::containsOnlyLatin1() to avoid converting to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=73797

Reviewed by Andreas Kling.

When the String use 8bits StringImpl, there is no need to iterate
over the string.

The function charactersAreAllLatin1() is removed because it is not
used anywhere.

* wtf/text/WTFString.h:
(WTF::String::containsOnlyLatin1):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/WTFString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102027 => 102028)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 20:08:59 UTC (rev 102027)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 20:27:47 UTC (rev 102028)
@@ -1,3 +1,19 @@
+2011-12-05  Benjamin Poulain  benja...@webkit.org
+
+Update String::containsOnlyLatin1() to avoid converting to 16 bits
+https://bugs.webkit.org/show_bug.cgi?id=73797
+
+Reviewed by Andreas Kling.
+
+When the String use 8bits StringImpl, there is no need to iterate
+over the string.
+
+The function charactersAreAllLatin1() is removed because it is not
+used anywhere.
+
+* wtf/text/WTFString.h:
+(WTF::String::containsOnlyLatin1):
+
 2011-12-05  Michael Saboff  msab...@apple.com
 
 8 bit string work slows down Kraken json-stringify-tinderbox


Modified: trunk/Source/_javascript_Core/wtf/text/WTFString.h (102027 => 102028)

--- trunk/Source/_javascript_Core/wtf/text/WTFString.h	2011-12-05 20:08:59 UTC (rev 102027)
+++ trunk/Source/_javascript_Core/wtf/text/WTFString.h	2011-12-05 20:27:47 UTC (rev 102028)
@@ -62,7 +62,6 @@
 // Declarations of string operations
 
 bool charactersAreAllASCII(const UChar*, size_t);
-bool charactersAreAllLatin1(const UChar*, size_t);
 WTF_EXPORT_PRIVATE int charactersToIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE int charactersToIntStrict(const UChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE unsigned charactersToUIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
@@ -375,7 +374,7 @@
 }
 
 bool containsOnlyASCII() const { return charactersAreAllASCII(characters(), length()); }
-bool containsOnlyLatin1() const { return charactersAreAllLatin1(characters(), length()); }
+bool containsOnlyLatin1() const;
 bool containsOnlyWhitespace() const { return !m_impl || m_impl-containsOnlyWhitespace(); }
 
 // Hash table deleted values, which are only constructed and never copied or destroyed.
@@ -460,7 +459,22 @@
 return characters16();
 }
 
+inline bool String::containsOnlyLatin1() const
+{
+if (isEmpty())
+return true;
 
+if (is8Bit())
+return true;
+
+const UChar* characters = characters16();
+UChar ored = 0;
+for (size_t i = 0; i  m_impl-length(); ++i)
+ored |= characters[i];
+return !(ored  0xFF00);
+}
+
+
 #ifdef __OBJC__
 // This is for situations in WebKit where the long standing behavior has been
 // nil if empty, so we try to maintain longstanding behavior for the sake of
@@ -476,14 +490,6 @@
 return !(ored  0xFF80);
 }
 
-inline bool charactersAreAllLatin1(const UChar* characters, size_t length)
-{
-UChar ored = 0;
-for (size_t i = 0; i  length; ++i)
-ored |= characters[i];
-return !(ored  0xFF00);
-}
-
 WTF_EXPORT_PRIVATE int codePointCompare(const String, const String);
 
 inline size_t find(const LChar* characters, unsigned length, LChar matchCharacter, unsigned index = 0)
@@ -610,7 +616,6 @@
 using WTF::append;
 using WTF::appendNumber;
 using WTF::charactersAreAllASCII;
-using WTF::charactersAreAllLatin1;
 using WTF::charactersToIntStrict;
 using WTF::charactersToUIntStrict;
 using WTF::charactersToInt64Strict;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102029] branches/safari-534.53-branch

2011-12-05 Thread lforschler

Title: [102029] branches/safari-534.53-branch








Revision 102029
Author lforsch...@apple.com
Date 2011-12-05 12:37:21 -0800 (Mon, 05 Dec 2011)


Log Message
Merge 94597.

Modified Paths

branches/safari-534.53-branch/LayoutTests/ChangeLog
branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt
branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt
branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/resources/parsing-background-size-values.js
branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/resources/parsing-inherit.js
branches/safari-534.53-branch/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
branches/safari-534.53-branch/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
branches/safari-534.53-branch/LayoutTests/fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt
branches/safari-534.53-branch/LayoutTests/fast/css/value-list-out-of-bounds-crash.html
branches/safari-534.53-branch/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
branches/safari-534.53-branch/Source/WebCore/css/CSSParser.cpp
branches/safari-534.53-branch/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: branches/safari-534.53-branch/LayoutTests/ChangeLog (102028 => 102029)

--- branches/safari-534.53-branch/LayoutTests/ChangeLog	2011-12-05 20:27:47 UTC (rev 102028)
+++ branches/safari-534.53-branch/LayoutTests/ChangeLog	2011-12-05 20:37:21 UTC (rev 102029)
@@ -1,3 +1,29 @@
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
+Merge 94597
+
+2011-09-06  David Hyatt  hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67672
+
+Improve background-size parsing. Make it actually dump auto values properly, and also make it omit
+auto if it is the second value. Fix the parsing to not create a value list when only a singleton value
+is specified.
+
+Reviewed by Beth Dakin.
+
+Covered well by existing tests.
+
+* fast/backgrounds/size/parsing-background-size-values-expected.txt:
+* fast/backgrounds/size/parsing-inherit-expected.txt:
+* fast/backgrounds/size/resources/parsing-background-size-values.js:
+* fast/backgrounds/size/resources/parsing-inherit.js:
+* fast/css/getComputedStyle/computed-style-expected.txt:
+* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+* fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt:
+* fast/css/value-list-out-of-bounds-crash.html:
+* svg/css/getComputedStyle-basic-expected.txt:
+
 2011-11-30  Lucas Forschler  lforsch...@apple.com
 
 Merge 94595


Modified: branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt (102028 => 102029)

--- branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt	2011-12-05 20:27:47 UTC (rev 102028)
+++ branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt	2011-12-05 20:37:21 UTC (rev 102029)
@@ -7,19 +7,19 @@
 PASS test(background-size: cover;) is cover
 PASS test(background-size: 100 100;) is 100px
 PASS test(background-size: 100px 100px;) is 100px
-PASS test(background-size: auto 50px;) is  50px
-PASS test(background-size: 50px auto;) is 50px 
-PASS test(background-size: auto auto;) is  
+PASS test(background-size: auto 50px;) is auto 50px
+PASS test(background-size: 50px auto;) is 50px
+PASS test(background-size: auto auto;) is auto
 PASS test(background-size: 30% 20%;) is 30% 20%
-PASS test(background-size: 4em auto;) is 4em 
-PASS test(background-size: 5em;) is 5em 
+PASS test(background-size: 4em auto;) is 4em
+PASS test(background-size: 5em;) is 5em
 PASS test(-webkit-background-size: 5em ;) is 5em
 PASS test(background-size: 100 100 100;) is null
 PASS test(background-size: coconut;) is null
 PASS test(background-size: 100px,;) is null
-PASS test(background-size: 100px, 50%;) is 100px , 50% 
+PASS test(background-size: 100px, 50%;) is 100px, 50%
 PASS test(-webkit-background-size: 100px, 50%;) is 100px, 50%
-PASS test(background-size: 50% 100px, 2em, 100px 50%;) is 50% 100px, 2em , 100px 50%
+PASS test(background-size: 50% 100px, 2em, 100px 50%;) is 50% 100px, 2em, 100px 50%
 PASS test(-webkit-background-size: 50% 100px, 2em, 100px 50%;) is 50% 100px, 2em, 100px 50%
 PASS successfullyParsed is true
 


Modified: branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt (102028 => 102029)

--- branches/safari-534.53-branch/LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt	2011-12-05 20:27:47 UTC (rev

[webkit-changes] [102030] trunk/Tools

2011-12-05 Thread dpranke

Title: [102030] trunk/Tools








Revision 102030
Author dpra...@chromium.org
Date 2011-12-05 12:47:59 -0800 (Mon, 05 Dec 2011)


Log Message
run-webkit-tests: limit --child-processes properly on apple mac
https://bugs.webkit.org/show_bug.cgi?id=73856

Reviewed by Adam Roben.

Fix typos in r102013 so that we correctly pass --child-processes=1 on
the apple mac bots temporarily.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests




Diff

Modified: trunk/Tools/ChangeLog (102029 => 102030)

--- trunk/Tools/ChangeLog	2011-12-05 20:37:21 UTC (rev 102029)
+++ trunk/Tools/ChangeLog	2011-12-05 20:47:59 UTC (rev 102030)
@@ -1,3 +1,16 @@
+2011-12-05  Dirk Pranke  dpra...@chromium.org
+
+run-webkit-tests: limit --child-processes properly on apple mac
+https://bugs.webkit.org/show_bug.cgi?id=73856
+
+Reviewed by Adam Roben.
+
+Fix typos in r102013 so that we correctly pass --child-processes=1 on
+the apple mac bots temporarily.
+
+* Scripts/run-webkit-tests:
+(platformIsReadyForParallelTesting):
+
 2011-12-05  Ryosuke Niwa  rn...@webkit.org
 
 Temporarily set --child-process=1 on Mac because 20+ tests are timing out


Modified: trunk/Tools/Scripts/run-webkit-tests (102029 => 102030)

--- trunk/Tools/Scripts/run-webkit-tests	2011-12-05 20:37:21 UTC (rev 102029)
+++ trunk/Tools/Scripts/run-webkit-tests	2011-12-05 20:47:59 UTC (rev 102030)
@@ -76,7 +76,7 @@
 # We believe all platforms are ready for default parallel testing except
 # Qt, as Qt runs more than one build-slave per-server.
 # Ossy has asked me to blacklist Qt for now.
-return !isQt() and !isMac();
+return !isQt()  !isAppleMacWebKit();
 }
 
 my $harnessName = old-run-webkit-tests;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102031] trunk

2011-12-05 Thread cfleizach

Title: [102031] trunk








Revision 102031
Author cfleiz...@apple.com
Date 2011-12-05 12:59:24 -0800 (Mon, 05 Dec 2011)


Log Message
platform/mac/accessibility/search-when-element-starts-in-table.html is failing
https://bugs.webkit.org/show_bug.cgi?id=73751

Source/WebCore: 

When encountering a table, the rows() and not the cells() should be queried (otherwise
we can end up finding the element we started with).

When searching in reverse, we also need to account for searching elements within the
parent hierarchy. because technically it is behind the start element.

Reviewed by Darin Adler.

* accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit):
(WebCore::AccessibilityObject::findMatchingObjects):
* accessibility/AccessibilityObject.h:

LayoutTests: 

Updated tests to be more comprehensive.

Reviewed by Darin Adler.

* platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
* platform/mac/accessibility/search-when-element-starts-in-table.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt
trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h




Diff

Modified: trunk/LayoutTests/ChangeLog (102030 => 102031)

--- trunk/LayoutTests/ChangeLog	2011-12-05 20:47:59 UTC (rev 102030)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 20:59:24 UTC (rev 102031)
@@ -1,3 +1,15 @@
+2011-12-05  Chris Fleizach  cfleiz...@apple.com
+
+platform/mac/accessibility/search-when-element-starts-in-table.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=73751
+
+Updated tests to be more comprehensive.
+
+Reviewed by Darin Adler.
+
+* platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
+* platform/mac/accessibility/search-when-element-starts-in-table.html:
+
 2011-12-05  Alok Priyadarshi  al...@chromium.org
 
 Rebaseline tests after the patch for BUGWK73247


Modified: trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt (102030 => 102031)

--- trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt	2011-12-05 20:47:59 UTC (rev 102030)
+++ trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt	2011-12-05 20:59:24 UTC (rev 102031)
@@ -11,7 +11,14 @@
 PASS resultElement.role is 'AXRole: AXHeading'
 PASS resultElement.title is 'AXTitle: outside heading'
 PASS resultElement.role is 'AXRole: '
+PASS resultElement.role is 'AXRole: AXHeading'
 PASS resultElement.role is 'AXRole: AXCell'
+PASS resultElement.role is 'AXRole: AXRow'
+PASS resultElement.role is 'AXRole: AXStaticText'
+PASS resultElement.stringValue is 'AXValue: Column'
+PASS resultElement.role is 'AXRole: AXCell'
+PASS resultElement.rowIndexRange() is '{0, 1}'
+PASS resultElement.columnIndexRange() is '{0, 1}'
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html (102030 => 102031)

--- trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html	2011-12-05 20:47:59 UTC (rev 102030)
+++ trunk/LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html	2011-12-05 20:59:24 UTC (rev 102031)
@@ -26,19 +26,37 @@
 var heading = accessibilityController.focusedElement;
 
 // The next heading should be outside the table
-searchKey = AXHeadingSearchKey;
-resultElement = containerElement.uiElementForSearchPredicate(heading, true, searchKey, );
+resultElement = containerElement.uiElementForSearchPredicate(heading, true, AXHeadingSearchKey, );
 shouldBe(resultElement.role, 'AXRole: AXHeading');
 shouldBe(resultElement.title, 'AXTitle: outside heading');
 
 // A search for the previous heading should return nothing.
-resultElement = containerElement.uiElementForSearchPredicate(heading, false, searchKey, );
+resultElement = containerElement.uiElementForSearchPredicate(heading, false, AXHeadingSearchKey, );
 shouldBe(resultElement.role, 'AXRole: ');
 
-// The previous any type of element should be an AXCell.
-searchKey = AXAnyTypeSearchKey;
-resultElement = containerElement.uiElementForSearchPredicate(heading.childAtIndex(0), false, searchKey, );
+// When asking the child of the heading for the previous element, it should return the heading.
+resultElement = containerElement.uiElementForSearchPredicate(heading.childAtIndex(0), false, AXAnyTypeSearchKey, );
+shouldBe(resultElement.role, 'AXRole: AXHeading');
+
+// When asking

[webkit-changes] [102033] branches/safari-534.53-branch/Source/WebCore

2011-12-05 Thread lforschler

Title: [102033] branches/safari-534.53-branch/Source/WebCore








Revision 102033
Author lforsch...@apple.com
Date 2011-12-05 13:07:00 -0800 (Mon, 05 Dec 2011)


Log Message
Merged r94901.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp
branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102032 => 102033)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-05 21:03:34 UTC (rev 102032)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-05 21:07:00 UTC (rev 102033)
@@ -1,5 +1,18 @@
 2011-12-05  Lucas Forschler  lforsch...@apple.com
 
+Merge 94901
+
+2011-09-09  Beth Dakin  bda...@apple.com
+
+Attempted Leopard build fix.
+
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::paintReplaced):
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::drawPlatformResizerImage):
+
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
 Merge 94900
 
 2011-09-09  Beth Dakin  bda...@apple.com


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp (102032 => 102033)

--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-05 21:03:34 UTC (rev 102032)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-05 21:07:00 UTC (rev 102033)
@@ -272,7 +272,7 @@
 image = m_imageResource-cachedImage()-brokenImage(deviceScaleFactor);
 IntSize imageSize = image-size();
 if (deviceScaleFactor = 2)
-imageSize.scale(0.5);
+imageSize.scale(0.5f);
 // Center the error image, accounting for border and padding.
 int centerX = (usableWidth - imageSize.width()) / 2; 
 if (centerX  0)


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp (102032 => 102033)

--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp	2011-12-05 21:03:34 UTC (rev 102032)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderLayer.cpp	2011-12-05 21:07:00 UTC (rev 102033)
@@ -2373,7 +2373,7 @@
 DEFINE_STATIC_LOCAL(Image*, resizeCornerImageHiRes, (Image::loadPlatformResource(textAreaResizeCorner@2x).leakRef()));
 resizeCornerImage = resizeCornerImageHiRes;
 cornerResizerSize = resizeCornerImage-size();
-cornerResizerSize.scale(0.5);
+cornerResizerSize.scale(0.5f);
 } else {
 DEFINE_STATIC_LOCAL(Image*, resizeCornerImageLoRes, (Image::loadPlatformResource(textAreaResizeCorner).leakRef()));
 resizeCornerImage = resizeCornerImageLoRes;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102034] trunk/LayoutTests

2011-12-05 Thread alokp

Title: [102034] trunk/LayoutTests








Revision 102034
Author al...@chromium.org
Date 2011-12-05 13:13:36 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
https://bugs.webkit.org/show_bug.cgi?id=69062

Unreviewed chromium rebaseline.

* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-win/compositing/shadows/shadow-drawing-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102033 => 102034)

--- trunk/LayoutTests/ChangeLog	2011-12-05 21:07:00 UTC (rev 102033)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 21:13:36 UTC (rev 102034)
@@ -1,3 +1,13 @@
+2011-12-05  Alok Priyadarshi  al...@chromium.org
+
+[Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=69062
+
+Unreviewed chromium rebaseline.
+
+* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
+* platform/chromium/test_expectations.txt:
+
 2011-12-05  Chris Fleizach  cfleiz...@apple.com
 
 platform/mac/accessibility/search-when-element-starts-in-table.html is failing


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102033 => 102034)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 21:07:00 UTC (rev 102033)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 21:13:36 UTC (rev 102034)
@@ -3530,7 +3530,6 @@
 
 BUGWK69060 WIN LINUX : fast/repaint/selection-clear.html = IMAGE+TEXT
 
-BUGWK69062 WIN : compositing/shadows/shadow-drawing.html = IMAGE
 
 BUGWK69070 MAC CPU-CG : svg/filters/animate-fill.svg = IMAGE
 


Modified: trunk/LayoutTests/platform/chromium-win/compositing/shadows/shadow-drawing-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102035] trunk

2011-12-05 Thread commit-queue

Title: [102035] trunk








Revision 102035
Author commit-qu...@webkit.org
Date 2011-12-05 13:16:02 -0800 (Mon, 05 Dec 2011)


Log Message
[Qt] Rename QQuickWebView::canStop property to just loading
https://bugs.webkit.org/show_bug.cgi?id=73813

Patch by Michael Brüning michael.brun...@nokia.com on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Renamed canStop property of QQuickWebView and QtWebPageProxy
to loading and updated tests.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::loading):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::loading):
* UIProcess/qt/QtWebPageProxy.h:

Tools:

Replaced references to WebView.canStop with WebView.loading.

* MiniBrowser/qt/qml/BrowserWindow.qml:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageProxy.h
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/qml/BrowserWindow.qml




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102034 => 102035)

--- trunk/Source/WebKit2/ChangeLog	2011-12-05 21:13:36 UTC (rev 102034)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-05 21:16:02 UTC (rev 102035)
@@ -1,3 +1,24 @@
+2011-12-05  Michael Brüning  michael.brun...@nokia.com
+
+[Qt] Rename QQuickWebView::canStop property to just loading 
+https://bugs.webkit.org/show_bug.cgi?id=73813
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Renamed canStop property of QQuickWebView and QtWebPageProxy
+to loading and updated tests.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::loading):
+* UIProcess/API/qt/qquickwebview_p.h:
+* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
+(tst_QQuickWebView::navigationStatusAtStartup):
+(LoadStartedCatcher::onLoadStarted):
+(tst_QQuickWebView::stopEnabledAfterLoadStarted):
+* UIProcess/qt/QtWebPageProxy.cpp:
+(QtWebPageProxy::loading):
+* UIProcess/qt/QtWebPageProxy.h:
+
 2011-12-03  Jer Noble  jer.no...@apple.com
 
 video elements should disable the system and display sleep when playing on OS X.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (102034 => 102035)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-05 21:13:36 UTC (rev 102034)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2011-12-05 21:16:02 UTC (rev 102035)
@@ -576,10 +576,10 @@
 return d-pageProxy-canGoForward();
 }
 
-bool QQuickWebView::canStop() const
+bool QQuickWebView::loading() const
 {
 Q_D(const QQuickWebView);
-return d-pageProxy-canStop();
+return d-pageProxy-loading();
 }
 
 bool QQuickWebView::canReload() const


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (102034 => 102035)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-05 21:13:36 UTC (rev 102034)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2011-12-05 21:16:02 UTC (rev 102035)
@@ -53,7 +53,7 @@
 Q_PROPERTY(int loadProgress READ loadProgress NOTIFY loadProgressChanged)
 Q_PROPERTY(bool canGoBack READ canGoBack NOTIFY navigationStateChanged FINAL)
 Q_PROPERTY(bool canGoForward READ canGoForward NOTIFY navigationStateChanged FINAL)
-Q_PROPERTY(bool canStop READ canStop NOTIFY navigationStateChanged FINAL)
+Q_PROPERTY(bool loading READ loading NOTIFY navigationStateChanged FINAL)
 Q_PROPERTY(bool canReload READ canReload NOTIFY navigationStateChanged FINAL)
 Q_PROPERTY(QWebPreferences* preferences READ preferences CONSTANT FINAL)
 Q_PROPERTY(QQuickWebPage* page READ page CONSTANT FINAL)
@@ -82,7 +82,7 @@
 
 bool canGoBack() const;
 bool canGoForward() const;
-bool canStop() const;
+bool loading() const;
 bool canReload() const;
 
 QWebPreferences* preferences() const;


Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp (102034 => 102035)

--- trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp	2011-12-05 21:13:36 UTC (rev 102034)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp	2011-12-05 21:16:02 UTC (rev 102035)
@@ -92,7 +92,7 @@
 
 QCOMPARE(webView()-canGoForward(), false);
 
-QCOMPARE(webView()-canStop(), false);
+QCOMPARE(webView()-loading(), false);
 
 QCOMPARE(webView()-canReload(), false);
 }
@@ -111,7 +111,7 @@
 {
 QMetaObject::invokeMethod(this, finished, Qt::QueuedConnection);
 
-QCOMPARE(m_webView-canStop(),

[webkit-changes] [102036] trunk/Tools

2011-12-05 Thread kubo

Title: [102036] trunk/Tools








Revision 102036
Author k...@profusion.mobi
Date 2011-12-05 13:22:10 -0800 (Mon, 05 Dec 2011)


Log Message
Add myself as a committer.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (102035 => 102036)

--- trunk/Tools/ChangeLog	2011-12-05 21:16:02 UTC (rev 102035)
+++ trunk/Tools/ChangeLog	2011-12-05 21:22:10 UTC (rev 102036)
@@ -1,3 +1,9 @@
+2011-12-05  Raphael Kubo da Costa  k...@profusion.mobi
+
+Add myself as a committer.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-12-05  Michael Brüning  michael.brun...@nokia.com
 
 [Qt] Rename QQuickWebView::canStop property to just loading 


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (102035 => 102036)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-12-05 21:16:02 UTC (rev 102035)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-12-05 21:22:10 UTC (rev 102036)
@@ -303,6 +303,7 @@
 Committer(Pratik Solanki, psola...@apple.com, psolanki),
 Committer(Qi Zhang, [qi.2.zh...@nokia.com, qi.zhang02...@gmail.com], qi),
 Committer(Rafael Antognolli, antogno...@profusion.mobi, antognolli),
+Committer(Raphael Kubo da Costa, [k...@profusion.mobi, rak...@freebsd.org], rakuco),
 Committer(Ravi Kasibhatla, ravi.kasibha...@motorola.com, kphanee),
 Committer(Renata Hodovan, r...@webkit.org, reni),
 Committer(Robert Hogan, [rob...@webkit.org, rob...@roberthogan.net, li...@roberthogan.net], mwenge),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102038] trunk/Source/JavaScriptCore

2011-12-05 Thread fpizlo

Title: [102038] trunk/Source/_javascript_Core








Revision 102038
Author fpi...@apple.com
Date 2011-12-05 13:25:18 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed, build fixes for ARM.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::unreachableForPlatform):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::loadDouble):
(JSC::MacroAssemblerARMv7::loadFloat):
(JSC::MacroAssemblerARMv7::storeFloat):
(JSC::MacroAssemblerARMv7::convertFloatToDouble):
(JSC::MacroAssemblerARMv7::convertDoubleToFloat):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102037 => 102038)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 21:25:18 UTC (rev 102038)
@@ -1,3 +1,16 @@
+2011-12-05  Filip Pizlo  fpi...@apple.com
+
+Unreviewed, build fixes for ARM.
+
+* assembler/AbstractMacroAssembler.h:
+(JSC::AbstractMacroAssembler::unreachableForPlatform):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::loadDouble):
+(JSC::MacroAssemblerARMv7::loadFloat):
+(JSC::MacroAssemblerARMv7::storeFloat):
+(JSC::MacroAssemblerARMv7::convertFloatToDouble):
+(JSC::MacroAssemblerARMv7::convertDoubleToFloat):
+
 2011-12-05  Benjamin Poulain  benja...@webkit.org
 
 Update String::containsOnlyLatin1() to avoid converting to 16 bits


Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (102037 => 102038)

--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2011-12-05 21:25:18 UTC (rev 102038)
@@ -597,6 +597,18 @@
 {
 return AssemblerType::readPointer(dataLabelPtr.dataLocation());
 }
+
+static void unreachableForPlatform()
+{
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored -Wmissing-noreturn
+ASSERT_NOT_REACHED();
+#pragma clang diagnostic pop
+#else
+ASSERT_NOT_REACHED();
+#endif
+}
 };
 
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (102037 => 102038)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2011-12-05 21:23:54 UTC (rev 102037)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h	2011-12-05 21:25:18 UTC (rev 102038)
@@ -713,12 +713,16 @@
 
 void loadDouble(BaseIndex address, FPRegisterID dest)
 {
-ASSERT_NOT_REACHED();
+UNUSED_PARAM(address);
+UNUSED_PARAM(dest);
+unreachableForPlatform();
 }
 
 void loadFloat(BaseIndex address, FPRegisterID dest)
 {
-ASSERT_NOT_REACHED();
+UNUSED_PARAM(address);
+UNUSED_PARAM(dest);
+unreachableForPlatform();
 }
 
 void moveDouble(FPRegisterID src, FPRegisterID dest)
@@ -765,7 +769,7 @@
 {
 move(address.index, addressTempRegister);
 mul32(TrustedImm32(address.scale), addressTempRegister, addressTempRegister);
-storeDouble(ARMRegisters::asSingle(src), Address(addressTempRegister, address.offset));
+storeDouble(src, Address(addressTempRegister, address.offset));
 }
 
 void addDouble(FPRegisterID src, FPRegisterID dest)
@@ -866,12 +870,16 @@
 
 void convertFloatToDouble(FPRegisterID src, FPRegisterID dst)
 {
-ASSERT_NOT_REACHED();
+UNUSED_PARAM(src);
+UNUSED_PARAM(dst);
+unreachableForPlatform();
 }
 
 void convertDoubleToFloat(FPRegisterID src, FPRegisterID dst)
 {
-ASSERT_NOT_REACHED();
+UNUSED_PARAM(src);
+UNUSED_PARAM(dst);
+unreachableForPlatform();
 }
 
 Jump branchDouble(DoubleCondition cond, FPRegisterID left, FPRegisterID right)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102039] trunk/LayoutTests

2011-12-05 Thread alokp

Title: [102039] trunk/LayoutTests








Revision 102039
Author al...@chromium.org
Date 2011-12-05 13:27:38 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed chromium tests rebaseline.

* platform/chromium/compositing/scaling: Added.
* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium/compositing/scaling/
trunk/LayoutTests/platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102038 => 102039)

--- trunk/LayoutTests/ChangeLog	2011-12-05 21:25:18 UTC (rev 102038)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 21:27:38 UTC (rev 102039)
@@ -1,5 +1,12 @@
 2011-12-05  Alok Priyadarshi  al...@chromium.org
 
+Unreviewed chromium tests rebaseline.
+
+* platform/chromium/compositing/scaling: Added.
+* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Added.
+
+2011-12-05  Alok Priyadarshi  al...@chromium.org
+
 [Chromium] Layout Test compositing/shadows/shadow-drawing.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=69062
 


Added: trunk/LayoutTests/platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102042] trunk/Source/JavaScriptCore

2011-12-05 Thread fpizlo

Title: [102042] trunk/Source/_javascript_Core








Revision 102042
Author fpi...@apple.com
Date 2011-12-05 13:45:30 -0800 (Mon, 05 Dec 2011)


Log Message
Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
were compact offsets
https://bugs.webkit.org/show_bug.cgi?id=73861

Reviewed by Gavin Barraclough.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchPutById):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102041 => 102042)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 21:44:23 UTC (rev 102041)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 21:45:30 UTC (rev 102042)
@@ -1,5 +1,16 @@
 2011-12-05  Filip Pizlo  fpi...@apple.com
 
+Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
+were compact offsets
+https://bugs.webkit.org/show_bug.cgi?id=73861
+
+Reviewed by Gavin Barraclough.
+
+* jit/JITPropertyAccess32_64.cpp:
+(JSC::JIT::resetPatchPutById):
+
+2011-12-05  Filip Pizlo  fpi...@apple.com
+
 Unreviewed, build fixes for ARM.
 
 * assembler/AbstractMacroAssembler.h:


Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp (102041 => 102042)

--- trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-12-05 21:44:23 UTC (rev 102041)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess32_64.cpp	2011-12-05 21:45:30 UTC (rev 102042)
@@ -1123,8 +1123,8 @@
 else
 repatchBuffer.relink(stubInfo-callReturnLocation, cti_op_put_by_id);
 repatchBuffer.repatch(stubInfo-hotPathBegin.dataLabelPtrAtOffset(patchOffsetPutByIdStructure), reinterpret_castvoid*(-1));
-repatchBuffer.repatch(stubInfo-hotPathBegin.dataLabelCompactAtOffset(patchOffsetPutByIdPropertyMapOffset1), 0);
-repatchBuffer.repatch(stubInfo-hotPathBegin.dataLabelCompactAtOffset(patchOffsetPutByIdPropertyMapOffset2), 0);
+repatchBuffer.repatch(stubInfo-hotPathBegin.dataLabel32AtOffset(patchOffsetPutByIdPropertyMapOffset1), 0);
+repatchBuffer.repatch(stubInfo-hotPathBegin.dataLabel32AtOffset(patchOffsetPutByIdPropertyMapOffset2), 0);
 }
 
 } // namespace JSC






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102043] trunk/Source

2011-12-05 Thread commit-queue

Title: [102043] trunk/Source








Revision 102043
Author commit-qu...@webkit.org
Date 2011-12-05 13:55:56 -0800 (Mon, 05 Dec 2011)


Log Message
[chromium] Set opaque flag for ImageLayerChromium
https://bugs.webkit.org/show_bug.cgi?id=72964

Patch by Dana Jansens dan...@chromium.org on 2011-12-05
Reviewed by James Robinson.

Source/WebCore:

New unit test in tests/ImageLayerChromiumTest.cpp.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::setContents):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/ImageLayerChromiumTest.cpp: Added.
(WebCore::MockGraphicsLayerClient::notifyAnimationStarted):
(WebCore::MockGraphicsLayerClient::notifySyncRequired):
(WebCore::MockGraphicsLayerClient::paintContents):
(WebCore::MockGraphicsLayerClient::showDebugBorders):
(WebCore::MockGraphicsLayerClient::showRepaintCounter):
(WebCore::TestImage::create):
(WebCore::TestImage::TestImage):
(WebCore::TestImage::~TestImage):
(WebCore::TestImage::isBitmapImage):
(WebCore::TestImage::currentFrameHasAlpha):
(WebCore::TestImage::size):
(WebCore::TestImage::nativeImageForCurrentFrame):
(WebCore::TestImage::destroyDecodedData):
(WebCore::TestImage::decodedSize):
(WebCore::TestImage::draw):
(WebCore::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gypi


Added Paths

trunk/Source/WebKit/chromium/tests/ImageLayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102042 => 102043)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 21:45:30 UTC (rev 102042)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 21:55:56 UTC (rev 102043)
@@ -1,3 +1,19 @@
+2011-12-05  Dana Jansens  dan...@chromium.org
+
+[chromium] Set opaque flag for ImageLayerChromium
+https://bugs.webkit.org/show_bug.cgi?id=72964
+
+Reviewed by James Robinson.
+
+New unit test in tests/ImageLayerChromiumTest.cpp.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::setContentsToImage):
+* platform/graphics/chromium/GraphicsLayerChromium.h:
+(WebCore::GraphicsLayerChromium::contentsLayer):
+* platform/graphics/chromium/ImageLayerChromium.cpp:
+(WebCore::ImageLayerChromium::setContents):
+
 2011-12-05  Julien Chaffraix  jchaffr...@webkit.org
 
 TD width in precentage doesn't work.


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp (102042 => 102043)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2011-12-05 21:45:30 UTC (rev 102042)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp	2011-12-05 21:55:56 UTC (rev 102043)
@@ -350,6 +350,7 @@
 }
 ImageLayerChromium* imageLayer = static_castImageLayerChromium*(m_contentsLayer.get());
 imageLayer-setContents(image);
+imageLayer-setOpaque(image-isBitmapImage()  !image-currentFrameHasAlpha());
 updateContentsRect();
 } else {
 if (m_contentsLayer) {


Modified: trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h (102042 => 102043)

--- trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h	2011-12-05 21:45:30 UTC (rev 102042)
+++ trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h	2011-12-05 21:55:56 UTC (rev 102043)
@@ -101,6 +101,9 @@
 virtual void paintContents(GraphicsContext, const IntRect clip);
 virtual void notifySyncRequired();
 
+// Exposed for tests.
+LayerChromium* contentsLayer() const { return m_contentsLayer.get(); }
+
 private:
 void updateOpacityOnLayer();
 
@@ -128,7 +131,6 @@
 void updateContentsScale();
 
 void setupContentsLayer(LayerChromium*);
-LayerChromium* contentsLayer() const { return m_contentsLayer.get(); }
 float contentsScale() const;
 
 String m_nameBase;


Modified: trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp (102042 => 102043)

--- trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp	2011-12-05 21:45:30 UTC (rev 102042)
+++ trunk/Source/WebCore/platform/graphics/chromium/ImageLayerChromium.cpp	2011-12-05 21:55:56 UTC (rev 102043)
@@ -164,7 +164,6 @@
 m_contents = contents;
 m_imageForCurrentFrame = m_contents-nativeImageForCurrentFrame();
 setNeedsDisplay();
-setOpaque(!m_contents-currentFrameHasAlpha());
 }
 
 void ImageLayerChromium::paintContentsIfDirty()


Modified: trunk/Source/WebKit/chromium/ChangeLog (102042 => 102043)

[webkit-changes] [102045] trunk/Source

2011-12-05 Thread andersca

Title: [102045] trunk/Source








Revision 102045
Author ander...@apple.com
Date 2011-12-05 14:13:56 -0800 (Mon, 05 Dec 2011)


Log Message
Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
https://bugs.webkit.org/show_bug.cgi?id=73862

Reviewed by Andy Estes.

Source/WebCore:

Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
successful and the run loop observer will be invalidated.

* platform/graphics/ca/LayerFlushScheduler.h:
* platform/graphics/ca/LayerFlushSchedulerClient.h:
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::runLoopObserverCallback):

Source/WebKit/mac:

Remove the call to LayerFlushScheduler::invalidate and return true instead. Return false for the cases
where we don't want the layer flush scheduler to be invalidated.

* WebView/WebView.mm:
(LayerFlushController::flushLayers):
* WebView/WebViewData.h:

Source/WebKit2:

Change LayerTreeHostCAMac::flushLayers to always return true and remove the call to LayerFlushScheduler::invalidate.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::flushLayers):
(WebKit::LayerTreeHostCAMac::didPerformScheduledLayerFlush):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h
trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h
trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewData.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h
trunk/Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (102044 => 102045)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 22:07:37 UTC (rev 102044)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 22:13:56 UTC (rev 102045)
@@ -1,3 +1,18 @@
+2011-12-05  Anders Carlsson  ander...@apple.com
+
+Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not
+https://bugs.webkit.org/show_bug.cgi?id=73862
+
+Reviewed by Andy Estes.
+
+Change LayerFlushSchedulerClient::flushLayers to return a boolean. If it returns true, the flush was
+successful and the run loop observer will be invalidated.
+
+* platform/graphics/ca/LayerFlushScheduler.h:
+* platform/graphics/ca/LayerFlushSchedulerClient.h:
+* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
+(WebCore::LayerFlushScheduler::runLoopObserverCallback):
+
 2011-12-05  Dana Jansens  dan...@chromium.org
 
 [chromium] Set opaque flag for ImageLayerChromium


Modified: trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h (102044 => 102045)

--- trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h	2011-12-05 22:07:37 UTC (rev 102044)
+++ trunk/Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h	2011-12-05 22:13:56 UTC (rev 102045)
@@ -53,6 +53,7 @@
 #if PLATFORM(MAC)
 RetainPtrCFRunLoopObserverRef m_runLoopObserver;
 static void runLoopObserverCallback(CFRunLoopObserverRef, CFRunLoopActivity, void* context);
+void runLoopObserverCallback();
 #endif
 };
 


Modified: trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h (102044 => 102045)

--- trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h	2011-12-05 22:07:37 UTC (rev 102044)
+++ trunk/Source/WebCore/platform/graphics/ca/LayerFlushSchedulerClient.h	2011-12-05 22:13:56 UTC (rev 102045)
@@ -31,9 +31,12 @@
 namespace WebCore {
 
 class LayerFlushSchedulerClient {
+protected:
+virtual ~LayerFlushSchedulerClient() { }
+
 public:
-virtual ~LayerFlushSchedulerClient() { }
-virtual void flushLayers() = 0;
+// Flush the layers. Returns true on success.
+virtual bool flushLayers() = 0;
 };
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp (102044 => 102045)

--- trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp	2011-12-05 22:07:37 UTC (rev 102044)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp	2011-12-05 22:13:56 UTC (rev 102045)
@@ -48,12 +48,18 @@
 
 void LayerFlushScheduler::runLoopObserverCallback(CFRunLoopObserverRef, CFRunLoopActivity, void* context)
 {
-LayerFlushScheduler* layerFlushScheduler = static_castLayerFlushScheduler*(context);
-ASSERT(layerFlushScheduler-m_runLoopObserver);
-ASSERT(!layerFlushScheduler-m_isSuspended);
-layerFlushScheduler-m_client-flushLayers();
+static_castLayerFlushScheduler*(context)-runLoopObserverCallback();
 }
 
+void LayerFlushScheduler::runLoopObserverCallback()
+{
+ASSERT(m_runLoopObserver);
+ASSERT(!m_isSuspended);
+
+if

[webkit-changes] [102046] trunk/Source/WebKit2

2011-12-05 Thread ap

Title: [102046] trunk/Source/WebKit2








Revision 102046
Author a...@apple.com
Date 2011-12-05 14:16:48 -0800 (Mon, 05 Dec 2011)


Log Message
REGRESSION: Full keyboard access doesn't work if enabled before Safari started
https://bugs.webkit.org/show_bug.cgi?id=73864

Reviewed by Darin Adler.

* WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Actually use the
parameter passed at process creation.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebProcess.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102045 => 102046)

--- trunk/Source/WebKit2/ChangeLog	2011-12-05 22:13:56 UTC (rev 102045)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-05 22:16:48 UTC (rev 102046)
@@ -1,3 +1,13 @@
+2011-12-05  Alexey Proskuryakov  a...@apple.com
+
+REGRESSION: Full keyboard access doesn't work if enabled before Safari started
+https://bugs.webkit.org/show_bug.cgi?id=73864
+
+Reviewed by Darin Adler.
+
+* WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): Actually use the
+parameter passed at process creation.
+
 2011-12-05  Anders Carlsson  ander...@apple.com
 
 Make LayerFlushSchedulerClient::flushLayers indicate whether the flush was successful or not


Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (102045 => 102046)

--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2011-12-05 22:13:56 UTC (rev 102045)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp	2011-12-05 22:16:48 UTC (rev 102046)
@@ -213,6 +213,8 @@
 
 m_textCheckerState = parameters.textCheckerState;
 
+m_fullKeyboardAccessEnabled = parameters.fullKeyboardAccessEnabled;
+
 for (size_t i = 0; i  parameters.urlSchemesRegistererdAsEmptyDocument.size(); ++i)
 registerURLSchemeAsEmptyDocument(parameters.urlSchemesRegistererdAsEmptyDocument[i]);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102047] trunk/Source/WebKit/chromium

2011-12-05 Thread abarth

Title: [102047] trunk/Source/WebKit/chromium








Revision 102047
Author aba...@webkit.org
Date 2011-12-05 14:27:59 -0800 (Mon, 05 Dec 2011)


Log Message
Fix Linux build.

* public/linux/WebFontInfo.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102046 => 102047)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 22:16:48 UTC (rev 102046)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 22:27:59 UTC (rev 102047)
@@ -1,5 +1,11 @@
 2011-12-05  Adam Barth  aba...@webkit.org
 
+Fix Linux build.
+
+* public/linux/WebFontInfo.h:
+
+2011-12-05  Adam Barth  aba...@webkit.org
+
 [Chromium] Remove no-longer-used forwarding headers in the WebKit API
 https://bugs.webkit.org/show_bug.cgi?id=73845
 


Modified: trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h (102046 => 102047)

--- trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h	2011-12-05 22:16:48 UTC (rev 102046)
+++ trunk/Source/WebKit/chromium/public/linux/WebFontInfo.h	2011-12-05 22:27:59 UTC (rev 102047)
@@ -31,9 +31,9 @@
 #ifndef WebFontInfo_h
 #define WebFontInfo_h
 
-#include ../linux/WebFontFamily.h
 #include ../linux/WebFontRenderStyle.h
 #include ../platform/WebCString.h
+#include ../platform/linux/WebFontFamily.h
 
 #include string.h
 #include unistd.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102048] trunk

2011-12-05 Thread commit-queue

Title: [102048] trunk








Revision 102048
Author commit-qu...@webkit.org
Date 2011-12-05 14:33:18 -0800 (Mon, 05 Dec 2011)


Log Message
Last mouse event could be lost if a JS call to eventSender.leapForward is made
https://bugs.webkit.org/show_bug.cgi?id=73366

Patch by Hugo Parente Lima hugo.l...@openbossa.org on 2011-12-05
Reviewed by Kenneth Rohde Christiansen.

Tools:

Empty the entire event queue when requested besides using
sendEvent instead of postEvent to make sure all events were
delivered.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::EventSenderProxy::replaySavedEvents):

LayoutTests:

Add test to check if the test driver doesn't eat mouse events when
a JS call to eventSender.leapForward was made. This bug happened at
least on Qt version of WebKitTestRunner.

* fast/events/dont-loose-last-event-expected.txt: Added.
* fast/events/dont-loose-last-event.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp


Added Paths

trunk/LayoutTests/fast/events/dont-loose-last-event-expected.txt
trunk/LayoutTests/fast/events/dont-loose-last-event.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102047 => 102048)

--- trunk/LayoutTests/ChangeLog	2011-12-05 22:27:59 UTC (rev 102047)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 22:33:18 UTC (rev 102048)
@@ -1,3 +1,17 @@
+2011-12-05  Hugo Parente Lima  hugo.l...@openbossa.org
+
+Last mouse event could be lost if a JS call to eventSender.leapForward is made
+https://bugs.webkit.org/show_bug.cgi?id=73366
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Add test to check if the test driver doesn't eat mouse events when
+a JS call to eventSender.leapForward was made. This bug happened at
+least on Qt version of WebKitTestRunner.
+
+* fast/events/dont-loose-last-event-expected.txt: Added.
+* fast/events/dont-loose-last-event.html: Added.
+
 2011-12-05  Julien Chaffraix  jchaffr...@webkit.org
 
 TD width in precentage doesn't work.


Added: trunk/LayoutTests/fast/events/dont-loose-last-event-expected.txt (0 => 102048)

--- trunk/LayoutTests/fast/events/dont-loose-last-event-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/dont-loose-last-event-expected.txt	2011-12-05 22:33:18 UTC (rev 102048)
@@ -0,0 +1,3 @@
+This should test if the test driver doesn't eat the last event if there's a leapForward call beforehand.
+
+PASS


Added: trunk/LayoutTests/fast/events/dont-loose-last-event.html (0 => 102048)

--- trunk/LayoutTests/fast/events/dont-loose-last-event.html	(rev 0)
+++ trunk/LayoutTests/fast/events/dont-loose-last-event.html	2011-12-05 22:33:18 UTC (rev 102048)
@@ -0,0 +1,61 @@
+html
+head
+script type=text/_javascript_
+var startElem;
+var targetElem;
+var consoleElm;
+
+window._onload_ = function()
+{
+startElem = document.getElementById(startElem);
+targetElem = document.getElementById(targetElem);
+consoleElm = document.getElementById(console);
+
+if (!startElem || !targetElem || !consoleElm)
+return;
+
+runTest();
+}
+
+function pass()
+{
+var div = document.createElement(div);
+document.getElementById(console).appendChild(div);
+div.innerHTML = PASS;
+};
+
+function runTest()
+{
+if (!window.eventSender)
+return;
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+var startX = startElem.offsetLeft + 10;
+var startY = startElem.offsetTop + startElem.offsetHeight / 2;
+var endX = targetElem.offsetLeft + 10;
+var endY = targetElem.offsetTop + targetElem.offsetHeight / 2;
+
+eventSender.mouseMoveTo(startX, startY);
+eventSender.leapForward(100);
+eventSender.mouseMoveTo(endX, endY);
+
+var testContainer = document.getElementById(test-container);
+if (testContainer)
+document.body.removeChild(testContainer);
+}
+/script
+/head
+body
+p id=descriptionThis should test if the test driver doesn't eat the last event if there's a leapForward call beforehand./p
+div id=test-container
+br/br/
+div id=targetElem style=border: 1px dashed _onmouseover_=pass()Pass the mouse over me.br/br//div
+hr/
+div id=startElemMouse start location/div
+hr/
+/div
+div id=console/div
+/body
+/html


Modified: trunk/Tools/ChangeLog (102047 => 102048)

--- trunk/Tools/ChangeLog	2011-12-05 22:27:59 UTC (rev 102047)
+++ trunk/Tools/ChangeLog	2011-12-05 22:33:18 UTC (rev 102048)
@@ -1,3 +1,19 @@
+2011-12-05  Hugo Parente Lima  hugo.l...@openbossa.org
+
+Last mouse event could be lost if a JS call to eventSender.leapForward is made
+

[webkit-changes] [102049] trunk

2011-12-05 Thread cfleizach

Title: [102049] trunk








Revision 102049
Author cfleiz...@apple.com
Date 2011-12-05 14:41:52 -0800 (Mon, 05 Dec 2011)


Log Message
AX: web search mechanism does not work with frames
https://bugs.webkit.org/show_bug.cgi?id=73836

Reviewed by Beth Dakin.

Source/WebCore: 

This allows searching for, and within, frames for elements using the accessibility
search mechanism.

Test: platform/mac/accessibility/search-with-frames.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore::appendAccessibilityObject):
(WebCore::appendChildrenToArray):

LayoutTests: 

* platform/mac/accessibility/search-with-frames-expected.txt: Added.
* platform/mac/accessibility/search-with-frames.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp


Added Paths

trunk/LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt
trunk/LayoutTests/platform/mac/accessibility/search-with-frames.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102048 => 102049)

--- trunk/LayoutTests/ChangeLog	2011-12-05 22:33:18 UTC (rev 102048)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 22:41:52 UTC (rev 102049)
@@ -1,3 +1,13 @@
+2011-12-05  Chris Fleizach  cfleiz...@apple.com
+
+AX: web search mechanism does not work with frames
+https://bugs.webkit.org/show_bug.cgi?id=73836
+
+Reviewed by Beth Dakin.
+
+* platform/mac/accessibility/search-with-frames-expected.txt: Added.
+* platform/mac/accessibility/search-with-frames.html: Added.
+
 2011-12-05  Hugo Parente Lima  hugo.l...@openbossa.org
 
 Last mouse event could be lost if a JS call to eventSender.leapForward is made


Added: trunk/LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt (0 => 102049)

--- trunk/LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt	2011-12-05 22:41:52 UTC (rev 102049)
@@ -0,0 +1,24 @@
+  
+This tests whether searching works to find frames and to find elements within frames.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS resultElement.role is 'AXRole: AXButton'
+PASS resultElement.title is 'AXTitle: button1'
+PASS resultElement.role is 'AXRole: AXButton'
+PASS resultElement.title is 'AXTitle: button2'
+PASS resultElement.role is 'AXRole: AXButton'
+PASS resultElement.title is 'AXTitle: button3'
+PASS resultElement.role is 'AXRole: AXButton'
+PASS resultElement.title is 'AXTitle: button2'
+PASS resultElement.role is 'AXRole: AXWebArea'
+PASS resultElement.description is 'AXDescription: frame1'
+PASS resultElement.role is 'AXRole: AXWebArea'
+PASS resultElement.description is 'AXDescription: frame1a'
+PASS resultElement.role is 'AXRole: AXWebArea'
+PASS resultElement.description is 'AXDescription: frame2'
+


Added: trunk/LayoutTests/platform/mac/accessibility/search-with-frames.html (0 => 102049)

--- trunk/LayoutTests/platform/mac/accessibility/search-with-frames.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/search-with-frames.html	2011-12-05 22:41:52 UTC (rev 102049)
@@ -0,0 +1,111 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+iframe width=500 height=500 id=frame1 title=frame1/iframe
+iframe width=500 height=500 id=frame2 title=frame2/iframe
+iframe width=500 height=500 id=frame3 title=frame3/iframe
+
+p id=description/p
+div id=console/div
+
+script
+window.layoutTestController.waitUntilDone();
+
+// We have to play some games to get these frames to load their sources in a timely fashion.
+document.getElementById(frame1).src = "" id='body1'button id=button1button1/buttonBRBRBR/body;
+document.getElementById(frame2).src = ""
+document.getElementById(frame3).src = "" id=button3button3/buttonBRBRBR/body;
+
+/script
+script
+   for (var k = 1; k = 3; k++) {
+
+  // This block adds sub frames to each of the frames, with some content in them. 
+  // When the last frame loads, it runs the test.
+
+  document.getElementById(frame + k)._onload_ = function(e) { 
+  var ifrm = document.createElement(iframe); 
+  ifrm.setAttribute(name, e.target.id + a);
+
+  if (e.target.id == frame2) {
+  ifrm.setAttribute(src, data:text/html,bodybutton id=button2button2/button/body); 
+  } else {
+  ifrm.setAttribute(src, data:text/html,bodytext/body); 
+  }
+
+  ifrm.style.width = 200; 
+  ifrm.style.height = 200; 
+  this.contentDocument.childNodes[0].childNodes[1].appendChild(ifrm); 
+  if (e.target.id == frame3) {
+

[webkit-changes] [102050] trunk/Source/WebKit/chromium

2011-12-05 Thread abarth

Title: [102050] trunk/Source/WebKit/chromium








Revision 102050
Author aba...@webkit.org
Date 2011-12-05 14:43:24 -0800 (Mon, 05 Dec 2011)


Log Message
Another attempted build fix.

* src/linux/WebFontInfo.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102049 => 102050)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 22:41:52 UTC (rev 102049)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-05 22:43:24 UTC (rev 102050)
@@ -1,5 +1,11 @@
 2011-12-05  Adam Barth  aba...@webkit.org
 
+Another attempted build fix.
+
+* src/linux/WebFontInfo.cpp:
+
+2011-12-05  Adam Barth  aba...@webkit.org
+
 Fix Linux build.
 
 * public/linux/WebFontInfo.h:


Modified: trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp (102049 => 102050)

--- trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp	2011-12-05 22:41:52 UTC (rev 102049)
+++ trunk/Source/WebKit/chromium/src/linux/WebFontInfo.cpp	2011-12-05 22:43:24 UTC (rev 102050)
@@ -31,9 +31,8 @@
 #include config.h
 #include WebFontInfo.h
 
-#include WebFontFamily.h
 #include WebFontRenderStyle.h
-
+#include platform/linux/WebFontFamily.h
 #include fontconfig/fontconfig.h
 #include string.h
 #include unicode/utf16.h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102051] trunk

2011-12-05 Thread cfleizach

Title: [102051] trunk








Revision 102051
Author cfleiz...@apple.com
Date 2011-12-05 14:44:28 -0800 (Mon, 05 Dec 2011)


Log Message
AX: aria-hidden doesn't work on iframe elements
https://bugs.webkit.org/show_bug.cgi?id=73857

Reviewed by Darin Adler.

Source/WebCore: 

Test: platform/mac/accessibility/iframe-aria-hidden.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addAttachmentChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::accessibilityIsIgnored):
(WebCore::AccessibilityScrollView::addChildren):
* accessibility/AccessibilityScrollView.h:

LayoutTests: 

* platform/mac/accessibility/iframe-aria-hidden-expected.txt: Added.
* platform/mac/accessibility/iframe-aria-hidden.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.h
trunk/Source/WebCore/accessibility/AccessibilityScrollView.cpp
trunk/Source/WebCore/accessibility/AccessibilityScrollView.h


Added Paths

trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt
trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102050 => 102051)

--- trunk/LayoutTests/ChangeLog	2011-12-05 22:43:24 UTC (rev 102050)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 22:44:28 UTC (rev 102051)
@@ -1,5 +1,15 @@
 2011-12-05  Chris Fleizach  cfleiz...@apple.com
 
+AX: aria-hidden doesn't work on iframe elements
+https://bugs.webkit.org/show_bug.cgi?id=73857
+
+Reviewed by Darin Adler.
+
+* platform/mac/accessibility/iframe-aria-hidden-expected.txt: Added.
+* platform/mac/accessibility/iframe-aria-hidden.html: Added.
+
+2011-12-05  Chris Fleizach  cfleiz...@apple.com
+
 AX: web search mechanism does not work with frames
 https://bugs.webkit.org/show_bug.cgi?id=73836
 


Added: trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt (0 => 102051)

--- trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt	2011-12-05 22:44:28 UTC (rev 102051)
@@ -0,0 +1,14 @@
+
+This tests that aria-hidden will affect the visibility of the web area and scroll view.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS body.childrenCount is 3
+PASS body.childAtIndex(0).childrenCount is 0
+PASS body.childrenCount is 4
+PASS body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role is 'AXRole: AXWebArea'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html (0 => 102051)

--- trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html	2011-12-05 22:44:28 UTC (rev 102051)
@@ -0,0 +1,40 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+link rel=stylesheet href=""
+script
+var successfullyParsed = false;
+/script
+script src=""
+/head
+body id=body
+
+iframe aria-hidden=true id=iframe src="" width=400 height=500 scrolling=auto frameborder=1fall back content/iframe
+
+p id=description/p
+div id=console/div
+
+script
+
+description(This tests that aria-hidden will affect the visibility of the web area and scroll view.);
+
+if (window.accessibilityController) {
+
+document.getElementById(body).focus();
+
+// Get the iframe reference.
+var body = accessibilityController.focusedElement;
+shouldBe(body.childrenCount, 3);
+shouldBe(body.childAtIndex(0).childrenCount, 0);
+
+document.getElementById(iframe).setAttribute(aria-hidden, false);
+shouldBe(body.childrenCount, 4);
+shouldBe(body.childAtIndex(0).childAtIndex(0).childAtIndex(0).role, 'AXRole: AXWebArea');
+}
+
+successfullyParsed = true;
+/script
+
+script src=""
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (102050 => 102051)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 22:43:24 UTC (rev 102050)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 22:44:28 UTC (rev 102051)
@@ -1,5 +1,23 @@
 2011-12-05  Chris Fleizach  cfleiz...@apple.com
 
+AX: aria-hidden doesn't work on iframe elements
+https://bugs.webkit.org/show_bug.cgi?id=73857
+
+Reviewed by Darin Adler.
+
+Test: platform/mac/accessibility/iframe-aria-hidden.html
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::addAttachmentChildren):
+(WebCore::AccessibilityRenderObject::addChildren):
+* accessibility/AccessibilityRenderObject.h:
+*

[webkit-changes] [102052] trunk/LayoutTests

2011-12-05 Thread jchaffraix

Title: [102052] trunk/LayoutTests








Revision 102052
Author jchaffr...@webkit.org
Date 2011-12-05 15:02:34 -0800 (Mon, 05 Dec 2011)


Log Message
TD width in precentage doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=34758

Unreviewed rebaselining on Chromium after r102040.

* platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
* platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png: Removed.
* platform/chromium-win/fast/table/027-expected.png:
* platform/chromium-win/fast/table/027-vertical-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium/tables/mozilla/bugs/bug14929-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-win/fast/table/027-expected.png
trunk/LayoutTests/platform/chromium-win/fast/table/027-vertical-expected.png
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png
trunk/LayoutTests/platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png


Removed Paths

trunk/LayoutTests/platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png
trunk/LayoutTests/platform/chromium-mac/fast/table/027-vertical-expected.png
trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png
trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102051 => 102052)

--- trunk/LayoutTests/ChangeLog	2011-12-05 22:44:28 UTC (rev 102051)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 23:02:34 UTC (rev 102052)
@@ -1,3 +1,23 @@
+2011-12-05  Julien Chaffraix  jchaffr...@webkit.org
+
+TD width in precentage doesn't work.
+https://bugs.webkit.org/show_bug.cgi?id=34758
+
+Unreviewed rebaselining on Chromium after r102040.
+
+* platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
+* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png: Added.
+* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2947-expected.png: Added.
+* platform/chromium-mac/fast/table/027-vertical-expected.png: Removed.
+* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png: Removed.
+* platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png: Removed.
+* platform/chromium-win/fast/table/027-expected.png:
+* platform/chromium-win/fast/table/027-vertical-expected.png:
+* platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
+* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
+* platform/chromium/tables/mozilla/bugs/bug14929-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-12-05  Chris Fleizach  cfleiz...@apple.com
 
 AX: aria-hidden doesn't work on iframe elements


Added: trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium/tables/mozilla/bugs/bug14929-expected.png
___

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (102051 => 102052)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 22:44:28 UTC (rev 102051)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-12-05 23:02:34 UTC (rev 102052)
@@ -3807,9 +3807,3 @@
 BUGWK73766 : css3/unicode-bidi-isolate-aharon-failing.html = FAIL
 
 BUGWK73838 LEOPARD DEBUG : animations/animation-add-events-in-handler.html = CRASH
-
-// Needs a rebaseline.
-BUGWK34758 WIN : fast/table/027.html = IMAGE
-BUGWK34758 WIN : fast/table/027-vertical.html = IMAGE
-BUGWK34758 WIN : tables/mozilla/bugs/bug14929.html = IMAGE
-BUGWK34758 WIN : tables/mozilla/bugs/bug2947.html = IMAGE


Deleted: trunk/LayoutTests/platform/chromium-cg-mac/tables/mozilla/bugs/bug14929-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac/fast/table/027-vertical-expected.png

(Binary files differ)


Deleted: trunk/LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.png

(Binary files differ)


Deleted:

[webkit-changes] [102053] trunk/Source/WebKit2

2011-12-05 Thread cfleizach

Title: [102053] trunk/Source/WebKit2








Revision 102053
Author cfleiz...@apple.com
Date 2011-12-05 15:34:41 -0800 (Mon, 05 Dec 2011)


Log Message
AX: WK2: AX hierarchy is not restored after web process crash
https://bugs.webkit.org/show_bug.cgi?id=73870

The accessibility tokens that need to be sent between UI and Web process
were not being sent by the UI process - the web process when the web
process crashed.

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _accessibilityRegisterUIProcessTokens]):
(-[WKView _didRelaunchProcess]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (102052 => 102053)

--- trunk/Source/WebKit2/ChangeLog	2011-12-05 23:02:34 UTC (rev 102052)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-05 23:34:41 UTC (rev 102053)
@@ -1,3 +1,19 @@
+2011-12-05  Chris Fleizach  cfleiz...@apple.com
+
+AX: WK2: AX hierarchy is not restored after web process crash
+https://bugs.webkit.org/show_bug.cgi?id=73870
+
+The accessibility tokens that need to be sent between UI and Web process
+were not being sent by the UI process - the web process when the web
+process crashed.
+
+Reviewed by Darin Adler.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView viewDidMoveToWindow]):
+(-[WKView _accessibilityRegisterUIProcessTokens]):
+(-[WKView _didRelaunchProcess]):
+
 2011-12-05  Alexey Proskuryakov  a...@apple.com
 
 REGRESSION: Full keyboard access doesn't work if enabled before Safari started


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (102052 => 102053)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2011-12-05 23:02:34 UTC (rev 102052)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2011-12-05 23:34:41 UTC (rev 102053)
@@ -123,6 +123,7 @@
 - (void)_setPluginComplexTextInputState:(PluginComplexTextInputState)pluginComplexTextInputState;
 - (void)_disableComplexTextInputIfNecessary;
 - (BOOL)_shouldUseTiledDrawingArea;
+- (void)_accessibilityRegisterUIProcessTokens;
 @end
 
 @interface WKViewData : NSObject {
@@ -1818,13 +1819,7 @@
 [self _updateWindowVisibility];
 [self _updateWindowAndViewFrames];
 
-// Initialize remote accessibility when the window connection has been established.
-NSData *remoteElementToken = WKAXRemoteTokenForElement(self);
-NSData *remoteWindowToken = WKAXRemoteTokenForElement([self accessibilityAttributeValue:NSAccessibilityWindowAttribute]);
-CoreIPC::DataReference elementToken = CoreIPC::DataReference(reinterpret_castconst uint8_t*([remoteElementToken bytes]), [remoteElementToken length]);
-CoreIPC::DataReference windowToken = CoreIPC::DataReference(reinterpret_castconst uint8_t*([remoteWindowToken bytes]), [remoteWindowToken length]);
-_data-_page-registerUIProcessAccessibilityTokens(elementToken, windowToken);
-
+[self _accessibilityRegisterUIProcessTokens];
 } else {
 _data-_page-viewStateDidChange(WebPageProxy::ViewIsVisible);
 _data-_page-viewStateDidChange(WebPageProxy::ViewWindowIsActive | WebPageProxy::ViewIsInWindow);
@@ -1988,6 +1983,16 @@
 _data-_page-viewStateDidChange(WebPageProxy::ViewIsVisible);
 }
 
+- (void)_accessibilityRegisterUIProcessTokens
+{
+// Initialize remote accessibility when the window connection has been established.
+NSData *remoteElementToken = WKAXRemoteTokenForElement(self);
+NSData *remoteWindowToken = WKAXRemoteTokenForElement([self accessibilityAttributeValue:NSAccessibilityWindowAttribute]);
+CoreIPC::DataReference elementToken = CoreIPC::DataReference(reinterpret_castconst uint8_t*([remoteElementToken bytes]), [remoteElementToken length]);
+CoreIPC::DataReference windowToken = CoreIPC::DataReference(reinterpret_castconst uint8_t*([remoteWindowToken bytes]), [remoteWindowToken length]);
+_data-_page-registerUIProcessAccessibilityTokens(elementToken, windowToken);
+}
+
 - (void)_updateRemoteAccessibilityRegistration:(BOOL)registerProcess
 {
 // When the tree is connected/disconnected, the remote accessibility registration
@@ -2126,6 +2131,7 @@
 
 - (void)_didRelaunchProcess
 {
+[self _accessibilityRegisterUIProcessTokens];
 }
 
 - (void)_setCursor:(NSCursor *)cursor






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102055] trunk/Source

2011-12-05 Thread vangelis

Title: [102055] trunk/Source








Revision 102055
Author vange...@chromium.org
Date 2011-12-05 15:43:15 -0800 (Mon, 05 Dec 2011)


Log Message
Source/WebCore: [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
https://bugs.webkit.org/show_bug.cgi?id=73621

When the extensions are available, compositor textures are allocated via
glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
is specified for all textures used by RenderSurfaces to eliminate the need for
a system memory bitmap allocation.

Reviewed by Kenneth Russell.

* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):
* platform/graphics/chromium/TrackingTextureAllocator.cpp:
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::textureToStorageFormat):
(WebCore::isTextureFormatSupportedForStorage):
(WebCore::TrackingTextureAllocator::createTexture):
* platform/graphics/chromium/TrackingTextureAllocator.h:
(WebCore::TrackingTextureAllocator::setTextureUsageHint):
(WebCore::TrackingTextureAllocator::setUseTextureStorageExt):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):

Source/WebKit/chromium: Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures.
https://bugs.webkit.org/show_bug.cgi?id=73621

Add the necessary entry points and enums to GraphicsContext3D.

Reviewed by Kenneth Russell.

* public/platform/WebGraphicsContext3D.h:
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::texStorage2DEXT):
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* tests/MockWebGraphicsContext3D.h:
(WebKit::MockWebGraphicsContext3D::texStorage2DEXT):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/TrackingTextureAllocator.cpp
trunk/Source/WebCore/platform/graphics/chromium/TrackingTextureAllocator.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h
trunk/Source/WebKit/chromium/src/Extensions3DChromium.cpp
trunk/Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp
trunk/Source/WebKit/chromium/src/GraphicsContext3DPrivate.h
trunk/Source/WebKit/chromium/tests/MockWebGraphicsContext3D.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102054 => 102055)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 23:39:26 UTC (rev 102054)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 23:43:15 UTC (rev 102055)
@@ -1,3 +1,31 @@
+2011-12-01  Vangelis Kokkevis  vange...@chromium.org
+
+[chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures
+https://bugs.webkit.org/show_bug.cgi?id=73621
+
+When the extensions are available, compositor textures are allocated via
+glTexStorage2DEXT instead of glTexImage2D to eliminate creation of unnecessary
+mip levels on the service side. In addition, the GL_FRAMEBUFFER_ATTACHMENT_ANGLE
+is specified for all textures used by RenderSurfaces to eliminate the need for
+a system memory bitmap allocation.
+
+Reviewed by Kenneth Russell.
+
+* platform/graphics/chromium/Extensions3DChromium.h:
+* platform/graphics/chromium/LayerRendererChromium.cpp:
+(WebCore::LayerRendererChromium::initialize):
+(WebCore::LayerRendererChromium::initializeSharedObjects):
+* platform/graphics/chromium/TrackingTextureAllocator.cpp:
+(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
+(WebCore::textureToStorageFormat):
+(WebCore::isTextureFormatSupportedForStorage):
+(WebCore::TrackingTextureAllocator::createTexture):
+* platform/graphics/chromium/TrackingTextureAllocator.h:
+(WebCore::TrackingTextureAllocator::setTextureUsageHint):
+(WebCore::TrackingTextureAllocator::setUseTextureStorageExt):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
+
 2011-12-05  Chris Fleizach  cfleiz...@apple.com
 
 AX: aria-hidden doesn't work on iframe elements


Modified: trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h (102054 => 102055)

--- trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h	2011-12-05 23:39:26 UTC (rev 102054)
+++ trunk/Source/WebCore/platform/graphics/chromium/Extensions3DChromium.h	2011-12-05 23:43:15 UTC (rev 102055)
@@ -46,6 +46,8 @@

[webkit-changes] [102056] trunk/Tools

2011-12-05 Thread eric

Title: [102056] trunk/Tools








Revision 102056
Author e...@webkit.org
Date 2011-12-05 15:48:47 -0800 (Mon, 05 Dec 2011)


Log Message
NRWT creates too many workers on RAM-limited machines
https://bugs.webkit.org/show_bug.cgi?id=73847

Reviewed by Dirk Pranke.

Make NRWT restrict its number of workers when there isn't enough
RAM to support them.
Also re-enable parallel testing on the Mac bots which were
failing due to not enough ram.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):
* Scripts/webkitpy/common/host.py:
(Host.__init__):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.cpu_count):
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo.display_name):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.display_name):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_os_error):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-webkit-tests
trunk/Tools/Scripts/webkitpy/common/host.py
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
trunk/Tools/Scripts/webkitpy/common/system/platforminfo_mock.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (102055 => 102056)

--- trunk/Tools/ChangeLog	2011-12-05 23:43:15 UTC (rev 102055)
+++ trunk/Tools/ChangeLog	2011-12-05 23:48:47 UTC (rev 102056)
@@ -1,3 +1,32 @@
+2011-12-05  Eric Seidel  e...@webkit.org
+
+NRWT creates too many workers on RAM-limited machines
+https://bugs.webkit.org/show_bug.cgi?id=73847
+
+Reviewed by Dirk Pranke.
+
+Make NRWT restrict its number of workers when there isn't enough
+RAM to support them.
+Also re-enable parallel testing on the Mac bots which were
+failing due to not enough ram.
+
+* Scripts/run-webkit-tests:
+(platformIsReadyForParallelTesting):
+* Scripts/webkitpy/common/host.py:
+(Host.__init__):
+* Scripts/webkitpy/common/system/executive_mock.py:
+(MockExecutive.cpu_count):
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo.__init__):
+(PlatformInfo.display_name):
+* Scripts/webkitpy/common/system/platforminfo_mock.py:
+(MockPlatformInfo.display_name):
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.default_child_processes):
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+(PortTest.test_default_child_processes):
+(PortTest.test_pretty_patch_os_error):
+
 2011-12-05  Hugo Parente Lima  hugo.l...@openbossa.org
 
 Last mouse event could be lost if a JS call to eventSender.leapForward is made


Modified: trunk/Tools/Scripts/run-webkit-tests (102055 => 102056)

--- trunk/Tools/Scripts/run-webkit-tests	2011-12-05 23:43:15 UTC (rev 102055)
+++ trunk/Tools/Scripts/run-webkit-tests	2011-12-05 23:48:47 UTC (rev 102056)
@@ -76,7 +76,7 @@
 # We believe all platforms are ready for default parallel testing except
 # Qt, as Qt runs more than one build-slave per-server.
 # Ossy has asked me to blacklist Qt for now.
-return !isQt()  !isAppleMacWebKit();
+return !isQt();
 }
 
 my $harnessName = old-run-webkit-tests;


Modified: trunk/Tools/Scripts/webkitpy/common/host.py (102055 => 102056)

--- trunk/Tools/Scripts/webkitpy/common/host.py	2011-12-05 23:43:15 UTC (rev 102055)
+++ trunk/Tools/Scripts/webkitpy/common/host.py	2011-12-05 23:48:47 UTC (rev 102056)
@@ -52,7 +52,7 @@
 self.executive = executive.Executive()
 self.filesystem = filesystem.FileSystem()
 self.user = user.User()
-self.platform = platforminfo.PlatformInfo()
+self.platform = platforminfo.PlatformInfo(self.executive)
 self.workspace = workspace.Workspace(self.filesystem, self.executive)
 self.web = web.Web()
 


Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (102055 => 102056)

--- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py	2011-12-05 23:43:15 UTC (rev 102055)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py	2011-12-05 23:48:47 UTC (rev 102056)
@@ -74,7 +74,10 @@
 raise ScriptError(MOCK ScriptError, output=output)
 return output
 
+def cpu_count(self):
+return 2
 
+
 class MockExecutive2(object):
 def __init__(self, output='', exit_code=0, exception=None,
  run_command_fn=None, stderr=''):


Modified: trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py (102055 => 102056)

--- trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py	2011-12-05 23:43:15 UTC (rev 102055)
+++ trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py

[webkit-changes] [102057] trunk/Source/JavaScriptCore

2011-12-05 Thread fpizlo

Title: [102057] trunk/Source/_javascript_Core








Revision 102057
Author fpi...@apple.com
Date 2011-12-05 15:50:15 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed build fix for non-DFG platforms.

* dfg/DFGRepatch.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGRepatch.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102056 => 102057)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 23:48:47 UTC (rev 102056)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 23:50:15 UTC (rev 102057)
@@ -1,5 +1,11 @@
 2011-12-05  Filip Pizlo  fpi...@apple.com
 
+Unreviewed build fix for non-DFG platforms.
+
+* dfg/DFGRepatch.h:
+
+2011-12-05  Filip Pizlo  fpi...@apple.com
+
 Old JIT emits 32-bit offsets for put_by_id but sometimes patches them as if they
 were compact offsets
 https://bugs.webkit.org/show_bug.cgi?id=73861


Modified: trunk/Source/_javascript_Core/dfg/DFGRepatch.h (102056 => 102057)

--- trunk/Source/_javascript_Core/dfg/DFGRepatch.h	2011-12-05 23:48:47 UTC (rev 102056)
+++ trunk/Source/_javascript_Core/dfg/DFGRepatch.h	2011-12-05 23:50:15 UTC (rev 102057)
@@ -50,7 +50,7 @@
 namespace JSC {
 
 class RepatchBuffer;
-class StructureStubInfo;
+struct StructureStubInfo;
 
 namespace DFG {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102059] trunk/Source

2011-12-05 Thread benjamin

Title: [102059] trunk/Source








Revision 102059
Author benja...@webkit.org
Date 2011-12-05 15:56:49 -0800 (Mon, 05 Dec 2011)


Log Message
Update String::containsOnlyASCII() to handle 8 bits strings
https://bugs.webkit.org/show_bug.cgi?id=73799

Reviewed by Darin Adler.

Source/_javascript_Core: 

Implement String::containsOnlyASCII() so that it does not
call String::characters().

* wtf/text/WTFString.h:
(WTF::String::containsOnlyASCII):

Source/WebCore: 

When possible, change the call sites from charactersAreAllASCII()
to the optimized version String::containsOnlyASCII().

* platform/KURL.cpp:
(WebCore::KURL::init):
* platform/cf/BinaryPropertyList.cpp:
(WebCore::BinaryPropertyListPlan::writeStringObject):
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::FontCodepage::if):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KURL.cpp
trunk/Source/WebCore/platform/cf/BinaryPropertyList.cpp
trunk/Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102058 => 102059)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 23:54:02 UTC (rev 102058)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-05 23:56:49 UTC (rev 102059)
@@ -1,3 +1,16 @@
+2011-12-05  Benjamin Poulain  benja...@webkit.org
+
+Update String::containsOnlyASCII() to handle 8 bits strings
+https://bugs.webkit.org/show_bug.cgi?id=73799
+
+Reviewed by Darin Adler.
+
+Implement String::containsOnlyASCII() so that it does not
+call String::characters().
+
+* wtf/text/WTFString.h:
+(WTF::String::containsOnlyASCII):
+
 2011-12-05  Filip Pizlo  fpi...@apple.com
 
 Unreviewed build fix for non-DFG platforms.


Modified: trunk/Source/_javascript_Core/wtf/text/WTFString.h (102058 => 102059)

--- trunk/Source/_javascript_Core/wtf/text/WTFString.h	2011-12-05 23:54:02 UTC (rev 102058)
+++ trunk/Source/_javascript_Core/wtf/text/WTFString.h	2011-12-05 23:56:49 UTC (rev 102059)
@@ -61,7 +61,7 @@
 
 // Declarations of string operations
 
-bool charactersAreAllASCII(const UChar*, size_t);
+templatetypename CharType inline bool charactersAreAllASCII(const CharType* characters, size_t length);
 WTF_EXPORT_PRIVATE int charactersToIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE int charactersToIntStrict(const UChar*, size_t, bool* ok = 0, int base = 10);
 WTF_EXPORT_PRIVATE unsigned charactersToUIntStrict(const LChar*, size_t, bool* ok = 0, int base = 10);
@@ -373,7 +373,7 @@
 return WTF::Unicode::LeftToRight;
 }
 
-bool containsOnlyASCII() const { return charactersAreAllASCII(characters(), length()); }
+bool containsOnlyASCII() const;
 bool containsOnlyLatin1() const;
 bool containsOnlyWhitespace() const { return !m_impl || m_impl-containsOnlyWhitespace(); }
 
@@ -482,14 +482,28 @@
 inline NSString* nsStringNilIfEmpty(const String str) {  return str.isEmpty() ? nil : (NSString*)str; }
 #endif
 
-inline bool charactersAreAllASCII(const UChar* characters, size_t length)
+templatetypename CharType
+inline bool charactersAreAllASCII(const CharType* characters, size_t length)
 {
-UChar ored = 0;
+CharType ored = 0;
 for (size_t i = 0; i  length; ++i)
 ored |= characters[i];
-return !(ored  0xFF80);
+
+CharType lowBits = 0x7F;
+return !(ored  ~lowBits);
 }
 
+inline bool String::containsOnlyASCII() const
+{
+if (isEmpty())
+return true;
+
+if (is8Bit())
+return charactersAreAllASCII(characters8(), m_impl-length());
+
+return charactersAreAllASCII(characters16(), m_impl-length());
+}
+
 WTF_EXPORT_PRIVATE int codePointCompare(const String, const String);
 
 inline size_t find(const LChar* characters, unsigned length, LChar matchCharacter, unsigned index = 0)


Modified: trunk/Source/WebCore/ChangeLog (102058 => 102059)

--- trunk/Source/WebCore/ChangeLog	2011-12-05 23:54:02 UTC (rev 102058)
+++ trunk/Source/WebCore/ChangeLog	2011-12-05 23:56:49 UTC (rev 102059)
@@ -1,3 +1,20 @@
+2011-12-05  Benjamin Poulain  benja...@webkit.org
+
+Update String::containsOnlyASCII() to handle 8 bits strings
+https://bugs.webkit.org/show_bug.cgi?id=73799
+
+Reviewed by Darin Adler.
+
+When possible, change the call sites from charactersAreAllASCII()
+to the optimized version String::containsOnlyASCII().
+
+* platform/KURL.cpp:
+(WebCore::KURL::init):
+* platform/cf/BinaryPropertyList.cpp:
+(WebCore::BinaryPropertyListPlan::writeStringObject):
+* platform/graphics/chromium/FontCacheChromiumWin.cpp:
+(WebCore::FontCodepage::if):
+
 2011-12-01  Vangelis Kokkevis  vange...@chromium.org
 
 [chromium] Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures


Modified:

[webkit-changes] [102060] trunk/LayoutTests

2011-12-05 Thread rniwa

Title: [102060] trunk/LayoutTests








Revision 102060
Author rn...@webkit.org
Date 2011-12-05 15:57:28 -0800 (Mon, 05 Dec 2011)


Log Message
REGRESSION(r101949): css3/bdi-element.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=73859

Reviewed by Dan Bernstein.

The failure was caused by span that contains the text inside bdi in the reference file
was using display: inline-block. Because the width of an inline-block is always rounded up
like any other inline element, it causes the text in the reference file to be one pixel
longer than the one in the test file in certain cases.

Fixed the bug by using unicode-bidi: override instead of display: inline-block in
the reference file.

* css3/bdi-element-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/bdi-element-expected.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102059 => 102060)

--- trunk/LayoutTests/ChangeLog	2011-12-05 23:56:49 UTC (rev 102059)
+++ trunk/LayoutTests/ChangeLog	2011-12-05 23:57:28 UTC (rev 102060)
@@ -1,3 +1,20 @@
+2011-12-05  Ryosuke Niwa  rn...@webkit.org
+
+REGRESSION(r101949): css3/bdi-element.html fails on Lion
+https://bugs.webkit.org/show_bug.cgi?id=73859
+
+Reviewed by Dan Bernstein.
+
+The failure was caused by span that contains the text inside bdi in the reference file
+was using display: inline-block. Because the width of an inline-block is always rounded up
+like any other inline element, it causes the text in the reference file to be one pixel
+longer than the one in the test file in certain cases.
+
+Fixed the bug by using unicode-bidi: override instead of display: inline-block in
+the reference file.
+
+* css3/bdi-element-expected.html:
+
 2011-12-05  Adam Barth  aba...@webkit.org
 
 Mark this test as flaky.


Modified: trunk/LayoutTests/css3/bdi-element-expected.html (102059 => 102060)

--- trunk/LayoutTests/css3/bdi-element-expected.html	2011-12-05 23:56:49 UTC (rev 102059)
+++ trunk/LayoutTests/css3/bdi-element-expected.html	2011-12-05 23:57:28 UTC (rev 102060)
@@ -13,7 +13,7 @@
 ul
  liUser jcranmer: 12 posts.
  liUser hober: 5 posts.
- liUser span style=display: inline-block;إيان/spanspan dir=ltr: 3 posts./span/span
+ liUser span style=unicode-bidi: embed;إيان/spanspan style=direction: ltr; unicode-bidi: override;: 3 posts./span/span
 /ul
 /body
 /html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102061] trunk/Source/JavaScriptCore

2011-12-05 Thread oliver

Title: [102061] trunk/Source/_javascript_Core








Revision 102061
Author oli...@apple.com
Date 2011-12-05 16:06:21 -0800 (Mon, 05 Dec 2011)


Log Message
Land uncommitted bit of float array support
https://bugs.webkit.org/show_bug.cgi?id=73873

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102060 => 102061)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-05 23:57:28 UTC (rev 102060)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-06 00:06:21 UTC (rev 102061)
@@ -1,3 +1,13 @@
+2011-12-05  Oliver Hunt  oli...@apple.com
+
+Land uncommitted bit of float array support
+https://bugs.webkit.org/show_bug.cgi?id=73873
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
+
 2011-12-05  Benjamin Poulain  benja...@webkit.org
 
 Update String::containsOnlyASCII() to handle 8 bits strings


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (102060 => 102061)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-12-05 23:57:28 UTC (rev 102060)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2011-12-06 00:06:21 UTC (rev 102061)
@@ -1735,7 +1735,9 @@
 FPRReg resultReg = result.fpr();
 ASSERT(speculationRequirements != NoTypedArraySpecCheck);
 MacroAssembler::Jump inBounds = m_jit.branch32(MacroAssembler::Below, propertyReg, MacroAssembler::Address(baseReg, descriptor.m_lengthOffset));
-m_jit.breakpoint();
+GPRTemporary scratch(this);
+m_jit.move(MacroAssembler::Imm32(0), scratch.gpr());
+m_jit.convertInt32ToDouble(scratch.gpr(), resultReg);
 MacroAssembler::Jump outOfBounds = m_jit.jump();
 inBounds.link(m_jit);
 switch (elementSize) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102062] trunk/Source

2011-12-05 Thread mario

Title: [102062] trunk/Source








Revision 102062
Author ma...@webkit.org
Date 2011-12-05 16:10:55 -0800 (Mon, 05 Dec 2011)


Log Message
[GTK] Move emissions of AtkDocument signals down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=73750

Reviewed by Chris Fleizach.

Source/WebCore:

Implement the needed infrastructure to allow notifying
accessibility, in a cross-platform way, when a event related to
the load of a document happens. Added a generic method, which will
be called from the FrameLoader, and platform specific versions of
it so every port has a chance to decide what to do with those
notifications.

This patch doesn't include a new test because the one testing this
functionality is the GTK-specific unit test added along with patch
for bug 73746: testWebkitAtkDocumentLoadingEvents.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::frameLoadingEventNotification): New, called
from the FrameLoader to notify accessibility when an event happens.
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
platform specific function to let ports decide what to do.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::frameLoadingEventNotification): New.
* accessibility/chromium/AXObjectCacheChromium.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for chromium.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for the Mac.
* accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
implementation of the platform specific function for Windows.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart): Notify accessibility
by calling the new frameLoadingEventNotification() function.
(WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto.

Source/WebKit/gtk:

Removed code for emission of AtkDocument signals.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::notifyStatus): Removed no longer used code.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/chromium/AXObjectCacheChromium.cpp
trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp
trunk/Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
trunk/Source/WebCore/accessibility/win/AXObjectCacheWin.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102061 => 102062)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 00:06:21 UTC (rev 102061)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 00:10:55 UTC (rev 102062)
@@ -1,3 +1,45 @@
+2011-12-05  Mario Sanchez Prada  msanc...@igalia.com
+
+[GTK] Move emissions of AtkDocument signals down to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=73750
+
+Reviewed by Chris Fleizach.
+
+Implement the needed infrastructure to allow notifying
+accessibility, in a cross-platform way, when a event related to
+the load of a document happens. Added a generic method, which will
+be called from the FrameLoader, and platform specific versions of
+it so every port has a chance to decide what to do with those
+notifications.
+
+This patch doesn't include a new test because the one testing this
+functionality is the GTK-specific unit test added along with patch
+for bug 73746: testWebkitAtkDocumentLoadingEvents.
+
+* accessibility/AXObjectCache.h:
+(WebCore::AXObjectCache::frameLoadingEventNotification): New, called
+from the FrameLoader to notify accessibility when an event happens.
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): New,
+platform specific function to let ports decide what to do.
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::frameLoadingEventNotification): New.
+* accessibility/chromium/AXObjectCacheChromium.cpp:
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
+implementation of the platform specific function for chromium.
+* accessibility/gtk/AXObjectCacheAtk.cpp:
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
+* accessibility/mac/AXObjectCacheMac.mm:
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
+implementation of the platform specific function for the Mac.
+* accessibility/win/AXObjectCacheWin.cpp:
+(WebCore::AXObjectCache::frameLoadingEventPlatformNotification): Dummy
+implementation of the platform

[webkit-changes] [102063] trunk/Source/WebCore

2011-12-05 Thread darin

Title: [102063] trunk/Source/WebCore








Revision 102063
Author da...@apple.com
Date 2011-12-05 16:15:16 -0800 (Mon, 05 Dec 2011)


Log Message
Change RuleSet to use HashMapOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=73783

Reviewed by Andreas Kling.

* css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.
(WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
map or find the old entry in the map.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102062 => 102063)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 00:10:55 UTC (rev 102062)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 00:15:16 UTC (rev 102063)
@@ -1,3 +1,14 @@
+2011-12-05  Darin Adler  da...@apple.com
+
+Change RuleSet to use HashMapOwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=73783
+
+Reviewed by Andreas Kling.
+
+* css/CSSStyleSelector.cpp: Make RuleSet::AtomRuleMap use OwnPtr for the mapped values.
+(WebCore::RuleSet::addToRuleSet): Use add instead of get/set to set up a new entry in the
+map or find the old entry in the map.
+
 2011-12-05  Mario Sanchez Prada  msanc...@igalia.com
 
 [GTK] Move emissions of AtkDocument signals down to WebCore


Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (102062 => 102063)

--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-06 00:10:55 UTC (rev 102062)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2011-12-06 00:15:16 UTC (rev 102063)
@@ -54,9 +54,6 @@
 #include CSSTimingFunctionValue.h
 #include CSSValueList.h
 #include CursorList.h
-#if ENABLE(CSS_FILTERS)
-#include FilterOperation.h
-#endif
 #include FontFamilyValue.h
 #include FontFeatureValue.h
 #include FontValue.h
@@ -102,9 +99,6 @@
 #include TransformationMatrix.h
 #include TranslateTransformOperation.h
 #include UserAgentStyleSheets.h
-#if ENABLE(CSS_FILTERS)
-#include WebKitCSSFilterValue.h
-#endif
 #include WebKitCSSKeyframeRule.h
 #include WebKitCSSKeyframesRule.h
 #include WebKitCSSRegionRule.h
@@ -114,6 +108,11 @@
 #include wtf/StdLibExtras.h
 #include wtf/Vector.h
 
+#if ENABLE(CSS_FILTERS)
+#include FilterOperation.h
+#include WebKitCSSFilterValue.h
+#endif
+
 #if ENABLE(DASHBOARD_SUPPORT)
 #include DashboardRegion.h
 #endif
@@ -203,17 +202,15 @@
 WTF_MAKE_NONCOPYABLE(RuleSet);
 public:
 RuleSet();
-~RuleSet();
 
-typedef HashMapAtomicStringImpl*, VectorRuleData* AtomRuleMap;
+typedef HashMapAtomicStringImpl*, OwnPtrVectorRuleData   AtomRuleMap;
 
 void addRulesFromSheet(CSSStyleSheet*, const MediaQueryEvaluator, CSSStyleSelector* = 0);
 
 void addStyleRule(CSSStyleRule* item);
 void addRule(CSSStyleRule* rule, CSSSelector* sel);
 void addPageRule(CSSPageRule*);
-void addToRuleSet(AtomicStringImpl* key, AtomRuleMap map,
-  CSSStyleRule* rule, CSSSelector* sel);
+void addToRuleSet(AtomicStringImpl* key, AtomRuleMap, CSSStyleRule*, CSSSelector*);
 void shrinkToFit();
 void disableAutoShrinkToFit() { m_autoShrinkToFitEnabled = false; }
 
@@ -1858,27 +1855,16 @@
 {
 }
 
-RuleSet::~RuleSet()
+void RuleSet::addToRuleSet(AtomicStringImpl* key, AtomRuleMap map, CSSStyleRule* rule, CSSSelector* selector)
 {
-deleteAllValues(m_idRules);
-deleteAllValues(m_classRules);
-deleteAllValues(m_shadowPseudoElementRules);
-deleteAllValues(m_tagRules);
+if (!key)
+return;
+OwnPtrVectorRuleData  rules = map.add(key, nullptr).first-second;
+if (!rules)
+rules = adoptPtr(new VectorRuleData);
+rules-append(RuleData(rule, selector, m_ruleCount++));
 }
 
-
-void RuleSet::addToRuleSet(AtomicStringImpl* key, AtomRuleMap map,
-  CSSStyleRule* rule, CSSSelector* sel)
-{
-if (!key) return;
-VectorRuleData* rules = map.get(key);
-if (!rules) {
-rules = new VectorRuleData;
-map.set(key, rules);
-}
-rules-append(RuleData(rule, sel, m_ruleCount++));
-}
-
 void RuleSet::addRule(CSSStyleRule* rule, CSSSelector* sel)
 {
 if (sel-m_match == CSSSelector::Id) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102064] trunk/Source/WebCore

2011-12-05 Thread benjamin

Title: [102064] trunk/Source/WebCore








Revision 102064
Author benja...@webkit.org
Date 2011-12-05 16:17:13 -0800 (Mon, 05 Dec 2011)


Log Message
Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined

Patch by Benjamin Poulain bpoul...@apple.com on 2011-12-05
Reviewed by David Kilzer.

When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.

* page/SecurityOrigin.cpp:
(WebCore::shouldUseInnerURL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SecurityOrigin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102063 => 102064)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 00:15:16 UTC (rev 102063)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 00:17:13 UTC (rev 102064)
@@ -1,3 +1,14 @@
+2011-12-05  Benjamin Poulain  bpoul...@apple.com
+
+Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined
+
+Reviewed by David Kilzer.
+
+When neither BLOB nor FILE_SYSTEM are defined, the parameter is unused.
+
+* page/SecurityOrigin.cpp:
+(WebCore::shouldUseInnerURL):
+
 2011-12-05  Darin Adler  da...@apple.com
 
 Change RuleSet to use HashMapOwnPtr


Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (102063 => 102064)

--- trunk/Source/WebCore/page/SecurityOrigin.cpp	2011-12-06 00:15:16 UTC (rev 102063)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp	2011-12-06 00:17:13 UTC (rev 102064)
@@ -73,6 +73,7 @@
 if (url.protocolIs(filesystem))
 return true;
 #endif
+UNUSED_PARAM(url);
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102065] trunk/Source/JavaScriptCore

2011-12-05 Thread darin

Title: [102065] trunk/Source/_javascript_Core








Revision 102065
Author da...@apple.com
Date 2011-12-05 16:17:34 -0800 (Mon, 05 Dec 2011)


Log Message
Convert JSClassRef to use HashMapOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=73780

Reviewed by Andreas Kling.

* API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::getOwnPropertyNames): Use get() on the hash map
entries because the hash map now has an OwnPtr instead of a raw pointer.

* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass): No need to initialize m_staticValues and
m_staticFunctions since they are now OwnPtr. Use adoptPtr when allocating.
Removed the code that gets and deletes existing entries, and just use set,
which now handles deletion automatically due to it being OwnPtr.
(OpaqueJSClass::~OpaqueJSClass): Replaced code to do all the deletion
with assertion-only NDEBUG-only code.
(OpaqueJSClassContextData::OpaqueJSClassContextData): Use adoptPtr when
allocating. Use OwnPtr when adding. Removed unneeded code to set
staticValues and staticFunctions to 0. Removed unneeded destructor.
(OpaqueJSClass::staticValues): Added get call. Also removed unneeded local.
(OpaqueJSClass::staticFunctions): Ditto.
(OpaqueJSClass::prototype): Added use of adoptPtr.

* API/JSClassRef.h: Made the static values and static functions tables
use OwnPtr for the entries. Also used OwnPtr for the pointers to the
tables themselves. Also removed ~OpaqueJSClassContextData(), letting
the compiler generate it.

Modified Paths

trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h
trunk/Source/_javascript_Core/API/JSClassRef.cpp
trunk/Source/_javascript_Core/API/JSClassRef.h
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h (102064 => 102065)

--- trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h	2011-12-06 00:17:13 UTC (rev 102064)
+++ trunk/Source/_javascript_Core/API/JSCallbackObjectFunctions.h	2011-12-06 00:17:34 UTC (rev 102065)
@@ -439,7 +439,7 @@
 iterator end = staticValues-end();
 for (iterator it = staticValues-begin(); it != end; ++it) {
 StringImpl* name = it-first.get();
-StaticValueEntry* entry = it-second;
+StaticValueEntry* entry = it-second.get();
 if (entry-getProperty  (!(entry-attributes  kJSPropertyAttributeDontEnum) || (mode == IncludeDontEnumProperties)))
 propertyNames.add(Identifier(exec, name));
 }
@@ -450,7 +450,7 @@
 iterator end = staticFunctions-end();
 for (iterator it = staticFunctions-begin(); it != end; ++it) {
 StringImpl* name = it-first.get();
-StaticFunctionEntry* entry = it-second;
+StaticFunctionEntry* entry = it-second.get();
 if (!(entry-attributes  kJSPropertyAttributeDontEnum) || (mode == IncludeDontEnumProperties))
 propertyNames.add(Identifier(exec, name));
 }


Modified: trunk/Source/_javascript_Core/API/JSClassRef.cpp (102064 => 102065)

--- trunk/Source/_javascript_Core/API/JSClassRef.cpp	2011-12-06 00:17:13 UTC (rev 102064)
+++ trunk/Source/_javascript_Core/API/JSClassRef.cpp	2011-12-06 00:17:34 UTC (rev 102065)
@@ -71,38 +71,30 @@
 , hasInstance(definition-hasInstance)
 , convertToType(definition-convertToType)
 , m_className(tryCreateStringFromUTF8(definition-className))
-, m_staticValues(0)
-, m_staticFunctions(0)
 {
 initializeThreading();
 
 if (const JSStaticValue* staticValue = definition-staticValues) {
-m_staticValues = new OpaqueJSClassStaticValuesTable();
+m_staticValues = adoptPtr(new OpaqueJSClassStaticValuesTable);
 while (staticValue-name) {
 UString valueName = tryCreateStringFromUTF8(staticValue-name);
 if (!valueName.isNull()) {
 // Use a local variable here to sidestep an RVCT compiler bug.
-StaticValueEntry* entry = new StaticValueEntry(staticValue-getProperty, staticValue-setProperty, staticValue-attributes);
-StringImpl* impl = valueName.impl();
-StaticValueEntry* existingEntry = m_staticValues-get(impl);
-m_staticValues-set(impl, entry);
-delete existingEntry;
+OwnPtrStaticValueEntry entry = adoptPtr(new StaticValueEntry(staticValue-getProperty, staticValue-setProperty, staticValue-attributes));
+m_staticValues-set(valueName.impl(), entry.release());
 }
 ++staticValue;
 }
 }
 
 if (const JSStaticFunction* staticFunction = definition-staticFunctions) {
-m_staticFunctions = new OpaqueJSClassStaticFunctionsTable();
+m_staticFunctions = adoptPtr(new OpaqueJSClassStaticFunctionsTable);
 while (staticFunction-name) {
 UString functionName = tryCreateStringFromUTF8(staticFunction-name);

[webkit-changes] [102067] trunk/Source/WebCore

2011-12-05 Thread adamk

Title: [102067] trunk/Source/WebCore








Revision 102067
Author ad...@chromium.org
Date 2011-12-05 16:33:28 -0800 (Mon, 05 Dec 2011)


Log Message
V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
https://bugs.webkit.org/show_bug.cgi?id=73867

Reviewed by Adam Barth.

Moved V8RecursionScope into its own file, and moved
V8Proxy::didLeaveScriptContext into that file, along with a static
recursionLevel accessor, hiding the V8BindingPerIsolateData methods
from V8Proxy.

This will make it easy and less error-prone to use V8RecursionScope
properly. I plan to make use of it in V8LazyEventListener to fix
https://bugs.webkit.org/show_bug.cgi?id=73492.

No new tests, refactoring only.

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.
* bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.
(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.
* bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
* bindings/v8/V8RecursionScope.cpp: Added.
(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.
* bindings/v8/V8RecursionScope.h: Added.
(WebCore::V8RecursionScope::V8RecursionScope):
(WebCore::V8RecursionScope::~V8RecursionScope):
(WebCore::V8RecursionScope::recursionLevel):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/UseV8.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8Proxy.cpp
trunk/Source/WebCore/bindings/v8/V8Proxy.h


Added Paths

trunk/Source/WebCore/bindings/v8/V8RecursionScope.cpp
trunk/Source/WebCore/bindings/v8/V8RecursionScope.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102066 => 102067)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 00:32:23 UTC (rev 102066)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 00:33:28 UTC (rev 102067)
@@ -1,3 +1,38 @@
+2011-12-05  Adam Klein  ad...@chromium.org
+
+V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
+https://bugs.webkit.org/show_bug.cgi?id=73867
+
+Reviewed by Adam Barth.
+
+Moved V8RecursionScope into its own file, and moved
+V8Proxy::didLeaveScriptContext into that file, along with a static
+recursionLevel accessor, hiding the V8BindingPerIsolateData methods
+from V8Proxy.
+
+This will make it easy and less error-prone to use V8RecursionScope
+properly. I plan to make use of it in V8LazyEventListener to fix
+https://bugs.webkit.org/show_bug.cgi?id=73492.
+
+No new tests, refactoring only.
+
+* Target.pri:
+* UseV8.cmake:
+* WebCore.gypi:
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::incrementRecursionLevel): return the new recursion level.
+(WebCore::V8BindingPerIsolateData::decrementRecursionLevel): return the new recursion level.
+* bindings/v8/V8Proxy.cpp: remove didLeaveScriptContext.
+(WebCore::V8Proxy::runScript): remove explicit call to didLeaveScriptContext.
+(WebCore::V8Proxy::instrumentedCallFunction): remove explicit call to didLeaveScriptContext.
+* bindings/v8/V8Proxy.h: remove didLeaveScriptContext.
+* bindings/v8/V8RecursionScope.cpp: Added.
+(WebCore::V8RecursionScope::didLeaveScriptContext): copied from V8Proxy.cpp.
+* bindings/v8/V8RecursionScope.h: Added.
+(WebCore::V8RecursionScope::V8RecursionScope):
+(WebCore::V8RecursionScope::~V8RecursionScope):
+(WebCore::V8RecursionScope::recursionLevel):
+
 2011-12-05  Benjamin Poulain  bpoul...@apple.com
 
 Build fix for SecurityOrigin.cpp when neither BLOB nor FILE_SYSTEM are defined


Modified: trunk/Source/WebCore/Target.pri (102066 => 102067)

--- trunk/Source/WebCore/Target.pri	2011-12-06 00:32:23 UTC (rev 102066)
+++ trunk/Source/WebCore/Target.pri	2011-12-06 00:33:28 UTC (rev 102067)
@@ -134,6 +134,7 @@
 bindings/v8/V8NPUtils.cpp \
 bindings/v8/V8NodeFilterCondition.cpp \
 bindings/v8/V8Proxy.cpp \
+bindings/v8/V8RecursionScope.cpp \
 bindings/v8/V8Utilities.cpp \
 bindings/v8/V8WindowErrorHandler.cpp \
 bindings/v8/V8WorkerContextEventListener.cpp \
@@ -1389,6 +1390,7 @@
 bindings/v8/V8NPObject.h \
 bindings/v8/V8NPUtils.h \
 bindings/v8/V8Proxy.h \
+bindings/v8/V8RecursionScope.h \
 bindings/v8/V8Utilities.h \
 bindings/v8/V8WindowErrorHandler.h \
 bindings/v8/V8WorkerContextEventListener.h \


Modified: trunk/Source/WebCore/UseV8.cmake (102066 => 102067)

--- trunk/Source/WebCore/UseV8.cmake

[webkit-changes] [102068] branches/safari-534.53-branch/Source/WebCore

2011-12-05 Thread lforschler

Title: [102068] branches/safari-534.53-branch/Source/WebCore








Revision 102068
Author lforsch...@apple.com
Date 2011-12-05 16:37:11 -0800 (Mon, 05 Dec 2011)


Log Message
Merged r95048.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102067 => 102068)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:33:28 UTC (rev 102067)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:37:11 UTC (rev 102068)
@@ -1,5 +1,22 @@
 2011-12-05  Lucas Forschler  lforsch...@apple.com
 
+Merge 95048
+
+2011-09-13  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67885
+Outline for the high-resolution broken image icon draws at 2x
+-and corresponding-
+rdar://problem/10104637
+
+Reviewed by Dan Bernstein.
+
+Scaled the image size to account for the deviceScaleFactor. 
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
 Merge 94980
 
 2011-09-12  Beth Dakin  bda...@apple.com


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp (102067 => 102068)

--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-06 00:33:28 UTC (rev 102067)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-06 00:37:11 UTC (rev 102068)
@@ -85,15 +85,18 @@
 ASSERT_ARG(newImage, newImage);
 ASSERT_ARG(newImage, newImage-image());
 
-Image* brokenImage;
-if (newImage-willPaintBrokenImage())
-brokenImage = newImage-brokenImage(Page::deviceScaleFactor(frame()));
-else
-brokenImage = newImage-image();
+IntSize imageSize;
+if (newImage-willPaintBrokenImage()) {
+float deviceScaleFactor = Page::deviceScaleFactor(frame());
+imageSize = newImage-brokenImage(deviceScaleFactor)-size();
+if (deviceScaleFactor = 2)
+imageSize.scale(0.5f);
+} else
+imageSize = newImage-image()-size();
 
 // imageSize() returns 0 for the error image. We need the true size of the
 // error image, so we have to get it by grabbing image() directly.
-return IntSize(paddingWidth + brokenImage-width() * style()-effectiveZoom(), paddingHeight + brokenImage-height() * style()-effectiveZoom()); 
+return IntSize(paddingWidth + imageSize.width() * style()-effectiveZoom(), paddingHeight + imageSize.height() * style()-effectiveZoom());
 }
 
 // Sets the image height and width to fit the alt text.  Returns true if the






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102069] branches/safari-534.53-branch/Source/WebCore/ChangeLog

2011-12-05 Thread lforschler

Title: [102069] branches/safari-534.53-branch/Source/WebCore/ChangeLog








Revision 102069
Author lforsch...@apple.com
Date 2011-12-05 16:40:58 -0800 (Mon, 05 Dec 2011)


Log Message
Merged r95051.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102068 => 102069)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:37:11 UTC (rev 102068)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:40:58 UTC (rev 102069)
@@ -1,5 +1,23 @@
 2011-12-05  Lucas Forschler  lforsch...@apple.com
 
+Merge 95051.
+This restored a broken Changelog, which isn't necessary for the branch anyway.
+
+2011-09-13  Beth Dakin  bda...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=67885
+Outline for the high-resolution broken image icon draws at 2x
+-and corresponding-
+rdar://problem/10104637
+
+Reviewed by Dan Bernstein.
+
+Scaled the image size to account for the deviceScaleFactor. 
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
 Merge 95048
 
 2011-09-13  Beth Dakin  bda...@apple.com






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102070] branches/safari-534.53-branch/Source/WebCore

2011-12-05 Thread lforschler

Title: [102070] branches/safari-534.53-branch/Source/WebCore








Revision 102070
Author lforsch...@apple.com
Date 2011-12-05 16:43:12 -0800 (Mon, 05 Dec 2011)


Log Message
Merged r95053.

Modified Paths

branches/safari-534.53-branch/Source/WebCore/ChangeLog
branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp




Diff

Modified: branches/safari-534.53-branch/Source/WebCore/ChangeLog (102069 => 102070)

--- branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:40:58 UTC (rev 102069)
+++ branches/safari-534.53-branch/Source/WebCore/ChangeLog	2011-12-06 00:43:12 UTC (rev 102070)
@@ -1,5 +1,16 @@
 2011-12-05  Lucas Forschler  lforsch...@apple.com
 
+Merge 95053
+
+2011-09-13  Beth Dakin  bda...@apple.com
+
+Adding a comment I forgot to add before.
+
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::imageSizeForError):
+
+2011-12-05  Lucas Forschler  lforsch...@apple.com
+
 Merge 95051.
 This restored a broken Changelog, which isn't necessary for the branch anyway.
 


Modified: branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp (102069 => 102070)

--- branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-06 00:40:58 UTC (rev 102069)
+++ branches/safari-534.53-branch/Source/WebCore/rendering/RenderImage.cpp	2011-12-06 00:43:12 UTC (rev 102070)
@@ -89,8 +89,15 @@
 if (newImage-willPaintBrokenImage()) {
 float deviceScaleFactor = Page::deviceScaleFactor(frame());
 imageSize = newImage-brokenImage(deviceScaleFactor)-size();
-if (deviceScaleFactor = 2)
-imageSize.scale(0.5f);
+if (deviceScaleFactor = 2) {
+// It is important to scale by 0.5 instead of the deviceScaleFactor because the
+// high resolution broken image artwork is actually a 2x image. We should 
+// consider adding functionality to Image to ask about the image's resolution,
+// and then we could scale by 1 / resolution. This is a solution that would
+// scale better since this hardcoded number will have to change if we ever get
+// artwork at other, higher resolutions. 
+imageSize.scale(0.5f);
+}
 } else
 imageSize = newImage-image()-size();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102071] trunk/Source/WebCore

2011-12-05 Thread darin

Title: [102071] trunk/Source/WebCore








Revision 102071
Author da...@apple.com
Date 2011-12-05 17:03:53 -0800 (Mon, 05 Dec 2011)


Log Message
Change CSSFontSelector to use HashMapOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=73781

Reviewed by Dan Bernstein.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.

* css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts
be HashMapOwnPtr.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSFontSelector.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102070 => 102071)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 00:43:12 UTC (rev 102070)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 01:03:53 UTC (rev 102071)
@@ -1,3 +1,20 @@
+2011-12-05  Darin Adler  da...@apple.com
+
+Change CSSFontSelector to use HashMapOwnPtr
+https://bugs.webkit.org/show_bug.cgi?id=73781
+
+Reviewed by Dan Bernstein.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::~CSSFontSelector): Removed calls to deleteAllValues.
+(WebCore::CSSFontSelector::addFontFaceRule): Updated to use OwnPtr instead of raw
+pointer for the entry in m_fontFaces and m_locallyInstalledFontFaces.
+(WebCore::CSSFontSelector::getFontData): Updated to use OwnPtr instead of raw
+pointer for the entry in m_fonts. Also removed an unneeded std:: prefix.
+
+* css/CSSFontSelector.h: Made m_fontFaces, m_locallyInstalledFontFaces, and m_fonts
+be HashMapOwnPtr.
+
 2011-12-05  Adam Klein  ad...@chromium.org
 
 V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero


Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (102070 => 102071)

--- trunk/Source/WebCore/css/CSSFontSelector.cpp	2011-12-06 00:43:12 UTC (rev 102070)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp	2011-12-06 01:03:53 UTC (rev 102071)
@@ -56,6 +56,8 @@
 #include SVGNames.h
 #endif
 
+using namespace std;
+
 namespace WebCore {
 
 CSSFontSelector::CSSFontSelector(Document* document)
@@ -74,9 +76,6 @@
 {
 clearDocument();
 fontCache()-removeClient(this);
-deleteAllValues(m_fontFaces);
-deleteAllValues(m_locallyInstalledFontFaces);
-deleteAllValues(m_fonts);
 }
 
 bool CSSFontSelector::isEmpty() const
@@ -320,20 +319,16 @@
 if (familyName.isEmpty())
 continue;
 
-VectorRefPtrCSSFontFace * familyFontFaces = m_fontFaces.get(familyName);
+OwnPtrVectorRefPtrCSSFontFace   familyFontFaces = m_fontFaces.add(familyName, nullptr).first-second;
 if (!familyFontFaces) {
-familyFontFaces = new VectorRefPtrCSSFontFace ;
-m_fontFaces.set(familyName, familyFontFaces);
+familyFontFaces = adoptPtr(new VectorRefPtrCSSFontFace );
 
 ASSERT(!m_locallyInstalledFontFaces.contains(familyName));
-VectorRefPtrCSSFontFace * familyLocallyInstalledFaces;
 
 Vectorunsigned locallyInstalledFontsTraitsMasks;
 fontCache()-getTraitsInFamily(familyName, locallyInstalledFontsTraitsMasks);
-unsigned numLocallyInstalledFaces = locallyInstalledFontsTraitsMasks.size();
-if (numLocallyInstalledFaces) {
-familyLocallyInstalledFaces = new VectorRefPtrCSSFontFace ;
-m_locallyInstalledFontFaces.set(familyName, familyLocallyInstalledFaces);
+if (unsigned numLocallyInstalledFaces = locallyInstalledFontsTraitsMasks.size()) {
+OwnPtrVectorRefPtrCSSFontFace   familyLocallyInstalledFaces = adoptPtr(new VectorRefPtrCSSFontFace );
 
 for (unsigned i = 0; i  numLocallyInstalledFaces; ++i) {
 RefPtrCSSFontFace locallyInstalledFontFace = CSSFontFace::create(static_castFontTraitsMask(locallyInstalledFontsTraitsMasks[i]), true);
@@ -341,6 +336,8 @@
 ASSERT(locallyInstalledFontFace-isValid());
 familyLocallyInstalledFaces-append(locallyInstalledFontFace);
 }
+
+m_locallyInstalledFontFaces.set(familyName, familyLocallyInstalledFaces.release());
 }
 }
 
@@ -522,19 +519,16 @@
 return fontDataForGenericFamily(m_document, fontDescription, familyName);
 }
 
-HashMapunsigned, RefPtrCSSSegmentedFontFace * segmentedFontFaceCache = m_fonts.get(family);
-if (!segmentedFontFaceCache) {
-segmentedFontFaceCache = new HashMapunsigned, RefPtrCSSSegmentedFontFace ;
-m_fonts.set(family, segmentedFontFaceCache);
-}
+OwnPtrHashMapunsigned,

[webkit-changes] [102072] trunk/Tools

2011-12-05 Thread eric

Title: [102072] trunk/Tools








Revision 102072
Author e...@webkit.org
Date 2011-12-05 17:08:04 -0800 (Mon, 05 Dec 2011)


Log Message
Up the expected ram for each DRT instance to 400MB instead of 300MB
in hopes of making the Snow Leopard bot stop timing out.

Unreviewed.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (102071 => 102072)

--- trunk/Tools/ChangeLog	2011-12-06 01:03:53 UTC (rev 102071)
+++ trunk/Tools/ChangeLog	2011-12-06 01:08:04 UTC (rev 102072)
@@ -1,5 +1,17 @@
 2011-12-05  Eric Seidel  e...@webkit.org
 
+Up the expected ram for each DRT instance to 400MB instead of 300MB
+in hopes of making the Snow Leopard bot stop timing out.
+
+Unreviewed.
+
+* Scripts/webkitpy/layout_tests/port/base.py:
+(Port.default_child_processes):
+* Scripts/webkitpy/layout_tests/port/base_unittest.py:
+(PortTest.test_default_child_processes):
+
+2011-12-05  Eric Seidel  e...@webkit.org
+
 NRWT creates too many workers on RAM-limited machines
 https://bugs.webkit.org/show_bug.cgi?id=73847
 


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py (102071 => 102072)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2011-12-06 01:03:53 UTC (rev 102071)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py	2011-12-06 01:08:04 UTC (rev 102072)
@@ -168,7 +168,7 @@
 # Make sure we have enough ram to support that many instances:
 total_memory = self.host.platform.total_bytes_memory()
 if total_memory:
-bytes_per_drt = 300 * 1024 * 1024  # Assume each DRT needs 300MB to run.
+bytes_per_drt = 400 * 1024 * 1024  # Assume each DRT needs 400MB to run.
 supportable_instances = total_memory / bytes_per_drt
 if supportable_instances  cpu_count:
 # FIXME: The Printer isn't initialized when this is called, so using _log would just show an unitialized logger error.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py (102071 => 102072)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py	2011-12-06 01:03:53 UTC (rev 102071)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py	2011-12-06 01:08:04 UTC (rev 102072)
@@ -56,7 +56,7 @@
 def test_default_child_processes(self):
 port = self.make_port()
 self.assertEqual(port.default_child_processes(), 2)
-bytes_for_drt = 300 * 1024 * 1024
+bytes_for_drt = 400 * 1024 * 1024
 
 port.host.platform.total_bytes_memory = lambda: bytes_for_drt
 expected_stdout = This machine could support 2 child processes, but only has enough memory for 1.\n






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102073] trunk/Source/WebCore

2011-12-05 Thread benjamin

Title: [102073] trunk/Source/WebCore








Revision 102073
Author benja...@webkit.org
Date 2011-12-05 17:10:13 -0800 (Mon, 05 Dec 2011)


Log Message
Remove methods declared but never implemented with GOOGLEURL
https://bugs.webkit.org/show_bug.cgi?id=73795

Reviewed by Adam Barth.

* platform/KURL.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/KURL.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102072 => 102073)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 01:08:04 UTC (rev 102072)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 01:10:13 UTC (rev 102073)
@@ -1,3 +1,12 @@
+2011-12-05  Benjamin Poulain  benja...@webkit.org
+
+Remove methods declared but never implemented with GOOGLEURL
+https://bugs.webkit.org/show_bug.cgi?id=73795
+
+Reviewed by Adam Barth.
+
+* platform/KURL.h:
+
 2011-12-05  Darin Adler  da...@apple.com
 
 Change CSSFontSelector to use HashMapOwnPtr


Modified: trunk/Source/WebCore/platform/KURL.h (102072 => 102073)

--- trunk/Source/WebCore/platform/KURL.h	2011-12-06 01:08:04 UTC (rev 102072)
+++ trunk/Source/WebCore/platform/KURL.h	2011-12-06 01:10:13 UTC (rev 102073)
@@ -236,9 +236,6 @@
 static bool protocolIs(const String, const char*);
 #if USE(GOOGLEURL)
 friend class KURLGooglePrivate;
-void parse(const char* url, const String originalString = String()) { parse(url, originalString); };
-void parse(const char* url, const String* originalString);  // KURLMac calls this.
-void copyToBuffer(Vectorchar, 512 buffer) const;  // KURLCFNet uses this.
 KURLGooglePrivate m_url;
 #else  // !USE(GOOGLEURL)
 void init(const KURL, const String, const TextEncoding);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102074] trunk/Source/WebKit/chromium

2011-12-05 Thread abarth

Title: [102074] trunk/Source/WebKit/chromium








Revision 102074
Author aba...@webkit.org
Date 2011-12-05 17:29:25 -0800 (Mon, 05 Dec 2011)


Log Message
Add a shim to fix the downstream Chromium compile.  The real fix should
be made downstream via http://codereview.chromium.org/8801036/, but the
Chromium tree is closed at the moment.

* public/WebRect.h: Added.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog


Added Paths

trunk/Source/WebKit/chromium/public/WebRect.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102073 => 102074)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-06 01:10:13 UTC (rev 102073)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-06 01:29:25 UTC (rev 102074)
@@ -1,3 +1,11 @@
+2011-12-05  Adam Barth  aba...@webkit.org
+
+Add a shim to fix the downstream Chromium compile.  The real fix should
+be made downstream via http://codereview.chromium.org/8801036/, but the
+Chromium tree is closed at the moment.
+
+* public/WebRect.h: Added.
+
 2011-12-01  Vangelis Kokkevis  vange...@chromium.org
 
 Use ANGLE's texture_usage and texture_storage extensions when allocating compositor textures.


Added: trunk/Source/WebKit/chromium/public/WebRect.h (0 => 102074)

--- trunk/Source/WebKit/chromium/public/WebRect.h	(rev 0)
+++ trunk/Source/WebKit/chromium/public/WebRect.h	2011-12-06 01:29:25 UTC (rev 102074)
@@ -0,0 +1,33 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WEBKIT_MIGRATE_HEADERS_TO_PLATFORM
+#include platform/WebRect.h
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102075] trunk/LayoutTests

2011-12-05 Thread timothy_horton

Title: [102075] trunk/LayoutTests








Revision 102075
Author timothy_hor...@apple.com
Date 2011-12-05 17:30:21 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed feGaussianBlur rebaseline for Mac after r101638.

* platform/mac/svg/filters/feGaussianBlur-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/filters/feGaussianBlur-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102074 => 102075)

--- trunk/LayoutTests/ChangeLog	2011-12-06 01:29:25 UTC (rev 102074)
+++ trunk/LayoutTests/ChangeLog	2011-12-06 01:30:21 UTC (rev 102075)
@@ -1,3 +1,9 @@
+2011-12-05  Tim Horton  timothy_hor...@apple.com
+
+Unreviewed feGaussianBlur rebaseline for Mac after r101638.
+
+* platform/mac/svg/filters/feGaussianBlur-expected.png:
+
 2011-12-05  Ryosuke Niwa  rn...@webkit.org
 
 REGRESSION(r101949): css3/bdi-element.html fails on Lion


Modified: trunk/LayoutTests/platform/mac/svg/filters/feGaussianBlur-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102076] tags/Safari-534.53.6/

2011-12-05 Thread lforschler

Title: [102076] tags/Safari-534.53.6/








Revision 102076
Author lforsch...@apple.com
Date 2011-12-05 17:34:00 -0800 (Mon, 05 Dec 2011)


Log Message
New tag.

Added Paths

tags/Safari-534.53.6/




Diff

Property changes: tags/Safari-534.53.6



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102077] branches/safari-534.53-branch/Source

2011-12-05 Thread lforschler

Title: [102077] branches/safari-534.53-branch/Source








Revision 102077
Author lforsch...@apple.com
Date 2011-12-05 17:35:33 -0800 (Mon, 05 Dec 2011)


Log Message
Versioning.

Modified Paths

branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig (102076 => 102077)

--- branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-06 01:34:00 UTC (rev 102076)
+++ branches/safari-534.53-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2011-12-06 01:35:33 UTC (rev 102077)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (102076 => 102077)

--- branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-06 01:34:00 UTC (rev 102076)
+++ branches/safari-534.53-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2011-12-06 01:35:33 UTC (rev 102077)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig (102076 => 102077)

--- branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-06 01:34:00 UTC (rev 102076)
+++ branches/safari-534.53-branch/Source/WebCore/Configurations/Version.xcconfig	2011-12-06 01:35:33 UTC (rev 102077)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig (102076 => 102077)

--- branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-06 01:34:00 UTC (rev 102076)
+++ branches/safari-534.53-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2011-12-06 01:35:33 UTC (rev 102077)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig (102076 => 102077)

--- branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-06 01:34:00 UTC (rev 102076)
+++ branches/safari-534.53-branch/Source/WebKit2/Configurations/Version.xcconfig	2011-12-06 01:35:33 UTC (rev 102077)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 53;
-TINY_VERSION = 6;
+TINY_VERSION = 7;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102078] trunk/Source/WebKit/chromium

2011-12-05 Thread abarth

Title: [102078] trunk/Source/WebKit/chromium








Revision 102078
Author aba...@webkit.org
Date 2011-12-05 17:35:50 -0800 (Mon, 05 Dec 2011)


Log Message
[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
https://bugs.webkit.org/show_bug.cgi?id=73881

This patch adds a forwarding header to fix the downstream Windows build:
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio

* public/WebContentLayerClient.h: Added.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog


Added Paths

trunk/Source/WebKit/chromium/public/WebContentLayerClient.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (102077 => 102078)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-06 01:35:33 UTC (rev 102077)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-06 01:35:50 UTC (rev 102078)
@@ -1,5 +1,15 @@
 2011-12-05  Adam Barth  aba...@webkit.org
 
+[Chromium] Chromium fails to compile due to missing WebContentLayerClient.h
+https://bugs.webkit.org/show_bug.cgi?id=73881
+
+This patch adds a forwarding header to fix the downstream Windows build:
+http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/12955/steps/compile/logs/stdio
+
+* public/WebContentLayerClient.h: Added.
+
+2011-12-05  Adam Barth  aba...@webkit.org
+
 Add a shim to fix the downstream Chromium compile.  The real fix should
 be made downstream via http://codereview.chromium.org/8801036/, but the
 Chromium tree is closed at the moment.


Added: trunk/Source/WebKit/chromium/public/WebContentLayerClient.h (0 => 102078)

--- trunk/Source/WebKit/chromium/public/WebContentLayerClient.h	(rev 0)
+++ trunk/Source/WebKit/chromium/public/WebContentLayerClient.h	2011-12-06 01:35:50 UTC (rev 102078)
@@ -0,0 +1,33 @@
+/*
+ * Copyright (C) 2011 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WEBKIT_MIGRATE_HEADERS_TO_PLATFORM
+#include platform/WebContentLayerClient.h
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102079] trunk/LayoutTests

2011-12-05 Thread timothy_horton

Title: [102079] trunk/LayoutTests








Revision 102079
Author timothy_hor...@apple.com
Date 2011-12-05 17:41:16 -0800 (Mon, 05 Dec 2011)


Log Message
Unreviewed extremely minor SVG filter pixel rebaselines for Lion.

Mostly text antialiasing differences, all only noticeable at tolerances very near 0.

* platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
* platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
* platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
* platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
* platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
* platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
* platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png.
* platform/mac/svg/filters/feComposite-expected.png:
* platform/mac/svg/filters/feLighting-crash-expected.png:
* platform/mac/svg/filters/feOffset-expected.png:
* platform/mac/svg/filters/filter-on-tspan-expected.png:
* platform/mac/svg/filters/filter-width-update-expected.png:
* platform/mac/svg/filters/sourceAlpha-expected.png:
* platform/mac/svg/filters/subRegion-one-effect-expected.png:
* platform/mac/svg/filters/subRegion-two-effects-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/svg/filters/feComposite-expected.png
trunk/LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png
trunk/LayoutTests/platform/mac/svg/filters/feOffset-expected.png
trunk/LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png
trunk/LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png
trunk/LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png
trunk/LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png
trunk/LayoutTests/platform/mac/svg/filters/subRegion-two-effects-expected.png


Added Paths

trunk/LayoutTests/platform/mac-snowleopard/svg/filters/
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/feComposite-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/feOffset-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/filter-width-update-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (102078 => 102079)

--- trunk/LayoutTests/ChangeLog	2011-12-06 01:35:50 UTC (rev 102078)
+++ trunk/LayoutTests/ChangeLog	2011-12-06 01:41:16 UTC (rev 102079)
@@ -1,5 +1,28 @@
 2011-12-05  Tim Horton  timothy_hor...@apple.com
 
+Unreviewed extremely minor SVG filter pixel rebaselines for Lion.
+
+Mostly text antialiasing differences, all only noticeable at tolerances very near 0.
+
+* platform/mac-snowleopard/svg/filters/feComposite-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feComposite-expected.png.
+* platform/mac-snowleopard/svg/filters/feLighting-crash-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feLighting-crash-expected.png.
+* platform/mac-snowleopard/svg/filters/feOffset-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feOffset-expected.png.
+* platform/mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-on-tspan-expected.png.
+* platform/mac-snowleopard/svg/filters/filter-width-update-expected.png: Copied from LayoutTests/platform/mac/svg/filters/filter-width-update-expected.png.
+* platform/mac-snowleopard/svg/filters/sourceAlpha-expected.png: Copied from LayoutTests/platform/mac/svg/filters/sourceAlpha-expected.png.
+* platform/mac-snowleopard/svg/filters/subRegion-one-effect-expected.png: Copied from LayoutTests/platform/mac/svg/filters/subRegion-one-effect-expected.png.
+* platform/mac-snowleopard/svg/filters/subRegion-two-effects-expected.png: Copied from

[webkit-changes] [102080] trunk/Source/WebCore

2011-12-05 Thread benjamin

Title: [102080] trunk/Source/WebCore








Revision 102080
Author benja...@webkit.org
Date 2011-12-05 17:51:27 -0800 (Mon, 05 Dec 2011)


Log Message
Get rid of KURL::KURL(ParsedURLStringTag, const char*);
https://bugs.webkit.org/show_bug.cgi?id=73792

Reviewed by Andreas Kling.

In all cases where the constructor is used, the constructor
taking a String is as effective because the string is valid and converted
to String for m_string.

This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
and change the call sites that were using that constructor to build
empty URLs.

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
* platform/KURL.cpp:
* platform/KURL.h:
* platform/KURLGoogle.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/platform/KURL.cpp
trunk/Source/WebCore/platform/KURL.h
trunk/Source/WebCore/platform/KURLGoogle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102079 => 102080)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 01:41:16 UTC (rev 102079)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 01:51:27 UTC (rev 102080)
@@ -1,5 +1,32 @@
 2011-12-05  Benjamin Poulain  benja...@webkit.org
 
+Get rid of KURL::KURL(ParsedURLStringTag, const char*);
+https://bugs.webkit.org/show_bug.cgi?id=73792
+
+Reviewed by Andreas Kling.
+
+In all cases where the constructor is used, the constructor
+taking a String is as effective because the string is valid and converted
+to String for m_string.
+
+This patch remove the constructor KURL::KURL(ParsedURLStringTag, const char*)
+and change the call sites that were using that constructor to build
+empty URLs.
+
+* dom/Document.cpp:
+(WebCore::Document::initSecurityContext):
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::init):
+* loader/archive/cf/LegacyWebArchive.cpp:
+(WebCore::LegacyWebArchive::create):
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::createWindow):
+* platform/KURL.cpp:
+* platform/KURL.h:
+* platform/KURLGoogle.cpp:
+
+2011-12-05  Benjamin Poulain  benja...@webkit.org
+
 Remove methods declared but never implemented with GOOGLEURL
 https://bugs.webkit.org/show_bug.cgi?id=73795
 


Modified: trunk/Source/WebCore/dom/Document.cpp (102079 => 102080)

--- trunk/Source/WebCore/dom/Document.cpp	2011-12-06 01:41:16 UTC (rev 102079)
+++ trunk/Source/WebCore/dom/Document.cpp	2011-12-06 01:51:27 UTC (rev 102080)
@@ -4472,7 +4472,7 @@
 if (!m_frame) {
 // No source for a security context.
 // This can occur via document.implementation.createDocument().
-m_cookieURL = KURL(ParsedURLString, );
+m_cookieURL = KURL(ParsedURLString, emptyString());
 setSecurityOrigin(SecurityOrigin::createUnique());
 setContentSecurityPolicy(ContentSecurityPolicy::create(this));
 return;


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (102079 => 102080)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2011-12-06 01:41:16 UTC (rev 102079)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2011-12-06 01:51:27 UTC (rev 102080)
@@ -220,7 +220,7 @@
 // This somewhat odd set of steps gives the frame an initial empty document.
 // It would be better if this could be done with even fewer steps.
 m_stateMachine.advanceTo(FrameLoaderStateMachine::CreatingInitialEmptyDocument);
-setPolicyDocumentLoader(m_client-createDocumentLoader(ResourceRequest(KURL(ParsedURLString, )), SubstituteData()).get());
+setPolicyDocumentLoader(m_client-createDocumentLoader(ResourceRequest(KURL(ParsedURLString, emptyString())), SubstituteData()).get());
 setProvisionalDocumentLoader(m_policyDocumentLoader.get());
 setState(FrameStateProvisional);
 m_provisionalDocumentLoader-setResponse(ResourceResponse(KURL(), text/html, 0, String(), String()));


Modified: trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp (102079 => 102080)

--- trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp	2011-12-06 01:41:16 UTC (rev 102079)
+++ trunk/Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp	2011-12-06 01:51:27 UTC (rev 102080)
@@ -507,7 +507,7 @@
 // it's possible to have a response without a URL here
 // rdar://problem/5454935
 if (responseURL.isNull())
-responseURL = KURL(ParsedURLString, );
+responseURL = KURL(ParsedURLString, emptyString());
 
 PassRefPtrArchiveResource mainResource = ArchiveResource::create(utf8Buffer(markupString), responseURL,

[webkit-changes] [102081] trunk/Source/WebCore

2011-12-05 Thread darin

Title: [102081] trunk/Source/WebCore








Revision 102081
Author da...@apple.com
Date 2011-12-05 18:04:16 -0800 (Mon, 05 Dec 2011)


Log Message
Some small improvements to ContainerNode.h
https://bugs.webkit.org/show_bug.cgi?id=73786

Reviewed by Alexey Proskuryakov.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
peculiar behavior of this function. Somehow the post-attach suspend state is both
global and specific to a certain Page object. That can't be right. If it was truly
global then this would be a static member function. If it was truly per-page, then
the related functions could not be static.

* dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes
function up with the other basic getters. Put the other getters, childNodeCount and
childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
mutation functions so they can be used in a cleaner fashion in C++ code where we have
some reason to know an exception won't occur. Grouped all the overrides of functions
from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.

* dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.

* dom/Node.cpp:
(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
(WebCore::Node::isDescendantOf): Ditto.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/ContainerNode.h
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102080 => 102081)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 01:51:27 UTC (rev 102080)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 02:04:16 UTC (rev 102081)
@@ -1,3 +1,31 @@
+2011-12-05  Darin Adler  da...@apple.com
+
+Some small improvements to ContainerNode.h
+https://bugs.webkit.org/show_bug.cgi?id=73786
+
+Reviewed by Alexey Proskuryakov.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::suspendPostAttachCallbacks): Added a FIXME comment about the
+peculiar behavior of this function. Somehow the post-attach suspend state is both
+global and specific to a certain Page object. That can't be right. If it was truly
+global then this would be a static member function. If it was truly per-page, then
+the related functions could not be static.
+
+* dom/ContainerNode.h: Removed some unneeded argument names. Moved the hasChildNodes
+function up with the other basic getters. Put the other getters, childNodeCount and
+childNode, right after the basic getters. Used ASSERT_NO_EXCEPTION in all the basic
+mutation functions so they can be used in a cleaner fashion in C++ code where we have
+some reason to know an exception won't occur. Grouped all the overrides of functions
+from Node into a single paragraph and used the OVERRIDE macro on all of them. Made the
+queuePostAttachCallback and postAttachCallbacksAreSuspended functions protected.
+
+* dom/Element.h: Moved the include of ExceptionCodePlaceholder.h into ContainerNode.h.
+
+* dom/Node.cpp:
+(WebCore::Node::lazyAttach): Use hasChildNodes instead of firstChild for clarity.
+(WebCore::Node::isDescendantOf): Ditto.
+
 2011-12-05  Benjamin Poulain  benja...@webkit.org
 
 Get rid of KURL::KURL(ParsedURLStringTag, const char*);


Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (102080 => 102081)

--- trunk/Source/WebCore/dom/ContainerNode.cpp	2011-12-06 01:51:27 UTC (rev 102080)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp	2011-12-06 02:04:16 UTC (rev 102081)
@@ -713,6 +713,8 @@
 if (!s_attachDepth) {
 ASSERT(!s_shouldReEnableMemoryCacheCallsAfterAttach);
 if (Page* page = document()-page()) {
+// FIXME: How can this call be specific to one Page, while the
+// s_attachDepth is a global? Doesn't make sense.
 if (page-areMemoryCacheClientCallsEnabled()) {
 page-setMemoryCacheClientCallsEnabled(false);
 s_shouldReEnableMemoryCacheCallsAfterAttach = true;


Modified: trunk/Source/WebCore/dom/ContainerNode.h (102080 => 102081)

--- trunk/Source/WebCore/dom/ContainerNode.h	2011-12-06 01:51:27 UTC (rev 102080)
+++ trunk/Source/WebCore/dom/ContainerNode.h	2011-12-06 02:04:16 UTC (rev 102081)
@@ -2,7 +2,7 @@
  * Copyright (C) 1999 Lars Knoll (kn...@kde.org)
  *   (C) 1999 Antti Koivisto (koivi...@kde.org)
  *   (C) 2001 Dirk Mueller (muel...@kde.org)
- * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.
+ * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can

[webkit-changes] [102082] trunk/Source/JavaScriptCore

2011-12-05 Thread msaboff

Title: [102082] trunk/Source/_javascript_Core








Revision 102082
Author msab...@apple.com
Date 2011-12-05 18:06:48 -0800 (Mon, 05 Dec 2011)


Log Message
Create StringImpl::empty() as an 8 bit string
https://bugs.webkit.org/show_bug.cgi?id=73871

Reviewed by Oliver Hunt.

* wtf/text/StringStatics.cpp:
(WTF::StringImpl::empty): Changed to be an 8 bit string.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/text/StringStatics.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102081 => 102082)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-06 02:04:16 UTC (rev 102081)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-06 02:06:48 UTC (rev 102082)
@@ -1,3 +1,13 @@
+2011-12-05  Michael Saboff  msab...@apple.com
+
+Create StringImpl::empty() as an 8 bit string
+https://bugs.webkit.org/show_bug.cgi?id=73871
+
+Reviewed by Oliver Hunt.
+
+* wtf/text/StringStatics.cpp:
+(WTF::StringImpl::empty): Changed to be an 8 bit string.
+
 2011-12-05  Darin Adler  da...@apple.com
 
 Convert JSClassRef to use HashMapOwnPtr


Modified: trunk/Source/_javascript_Core/wtf/text/StringStatics.cpp (102081 => 102082)

--- trunk/Source/_javascript_Core/wtf/text/StringStatics.cpp	2011-12-06 02:04:16 UTC (rev 102081)
+++ trunk/Source/_javascript_Core/wtf/text/StringStatics.cpp	2011-12-06 02:06:48 UTC (rev 102082)
@@ -46,8 +46,8 @@
 // into the zero-page.
 // Replace this with 'reinterpret_castUChar*(static_castintptr_t(1))' once
 // PCRE goes away.
-static UChar emptyUCharData = 0;
-DEFINE_STATIC_LOCAL(StringImpl, emptyString, (emptyUCharData, 0, ConstructStaticString));
+static LChar emptyLCharData = 0;
+DEFINE_STATIC_LOCAL(StringImpl, emptyString, (emptyLCharData, 0, ConstructStaticString));
 WTF_ANNOTATE_BENIGN_RACE(emptyString, Benign race on StringImpl::emptyString reference counter);
 return emptyString;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102083] trunk/Tools

2011-12-05 Thread kubo

Title: [102083] trunk/Tools








Revision 102083
Author k...@profusion.mobi
Date 2011-12-05 18:07:23 -0800 (Mon, 05 Dec 2011)


Log Message
webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
https://bugs.webkit.org/show_bug.cgi?id=73878

Reviewed by Tony Chang.

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
r98785 made webkit.py always use m_data16, which does not work when
the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python
code, so I just reproduced the implementation there.

* gdb/webkit.py:
(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(WTFStringPrinter.to_string):
(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
(JSCUStringPrinter.to_string):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gdb/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (102082 => 102083)

--- trunk/Tools/ChangeLog	2011-12-06 02:06:48 UTC (rev 102082)
+++ trunk/Tools/ChangeLog	2011-12-06 02:07:23 UTC (rev 102083)
@@ -1,3 +1,23 @@
+2011-12-05  Raphael Kubo da Costa  k...@profusion.mobi
+
+webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
+https://bugs.webkit.org/show_bug.cgi?id=73878
+
+Reviewed by Tony Chang.
+
+r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
+r98785 made webkit.py always use m_data16, which does not work when
+the string is an 8-bit string (such as KURL::string()).
+
+I was not able to directly call StringImpl::is8Bit() in the Python
+code, so I just reproduced the implementation there.
+
+* gdb/webkit.py:
+(WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
+(WTFStringPrinter.to_string):
+(JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
+(JSCUStringPrinter.to_string):
+
 2011-12-05  Eric Seidel  e...@webkit.org
 
 Up the expected ram for each DRT instance to 400MB instead of 300MB


Modified: trunk/Tools/gdb/webkit.py (102082 => 102083)

--- trunk/Tools/gdb/webkit.py	2011-12-06 02:06:48 UTC (rev 102082)
+++ trunk/Tools/gdb/webkit.py	2011-12-06 02:07:23 UTC (rev 102083)
@@ -107,11 +107,19 @@
 return 0
 return self.val['m_impl']['m_ptr']['m_length']
 
+def is_8bit(self):
+return self.val['m_impl']['m_ptr']['m_hashAndFlags']  self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']
+
 def to_string(self):
 if self.get_length() == 0:
 return '(null)'
 
-return ustring_to_string(self.val['m_impl']['m_ptr']['m_data16'],
+if self.is_8bit():
+data_member = 'm_data8'
+else:
+data_member = 'm_data16'
+
+return ustring_to_string(self.val['m_impl']['m_ptr'][data_member],
  self.get_length())
 
 
@@ -122,11 +130,19 @@
 return 0
 return self.val['m_impl']['m_ptr']['m_length']
 
+def is_8bit(self):
+return self.val['m_impl']['m_ptr']['m_hashAndFlags']  self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']
+
 def to_string(self):
 if self.get_length() == 0:
 return ''
 
-return ustring_to_string(self.val['m_impl']['m_ptr']['m_data16'],
+if self.is_8bit():
+data_member = 'm_data8'
+else:
+data_member = 'm_data16'
+
+return ustring_to_string(self.val['m_impl']['m_ptr'][data_member],
  self.get_length())
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102084] trunk/Source/JavaScriptCore

2011-12-05 Thread andersca

Title: [102084] trunk/Source/_javascript_Core








Revision 102084
Author ander...@apple.com
Date 2011-12-05 18:17:22 -0800 (Mon, 05 Dec 2011)


Log Message
Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.

Reviewed by Darin Adler.

* wtf/HashMap.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/HashMap.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (102083 => 102084)

--- trunk/Source/_javascript_Core/ChangeLog	2011-12-06 02:07:23 UTC (rev 102083)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-12-06 02:17:22 UTC (rev 102084)
@@ -1,3 +1,11 @@
+2011-12-05  Anders Carlsson  ander...@apple.com
+
+Add HashMap::keys() and HashMap::values() for easy iteration of hash map keys and values in C++11.
+
+Reviewed by Darin Adler.
+
+* wtf/HashMap.h:
+
 2011-12-05  Michael Saboff  msab...@apple.com
 
 Create StringImpl::empty() as an 8 bit string


Modified: trunk/Source/_javascript_Core/wtf/HashMap.h (102083 => 102084)

--- trunk/Source/_javascript_Core/wtf/HashMap.h	2011-12-06 02:07:23 UTC (rev 102083)
+++ trunk/Source/_javascript_Core/wtf/HashMap.h	2011-12-06 02:17:22 UTC (rev 102084)
@@ -60,10 +60,14 @@
 typedef HashTableKeyType, ValueType, PairFirstExtractorValueType,
 HashFunctions, ValueTraits, KeyTraits HashTableType;
 
+class HashMapKeysProxy;
+class HashMapValuesProxy;
+
 public:
 typedef HashTableIteratorAdapterHashTableType, ValueType iterator;
 typedef HashTableConstIteratorAdapterHashTableType, ValueType const_iterator;
 
+public:
 void swap(HashMap);
 
 int size() const;
@@ -76,6 +80,12 @@
 const_iterator begin() const;
 const_iterator end() const;
 
+HashMapKeysProxy keys() { return static_castHashMapKeysProxy(*this); }
+const HashMapKeysProxy keys() const { return static_castconst HashMapKeysProxy(*this); }
+
+HashMapValuesProxy values() { return static_castHashMapValuesProxy(*this); }
+const HashMapValuesProxy values() const { return static_castconst HashMapValuesProxy(*this); }
+
 iterator find(const KeyType);
 const_iterator find(const KeyType) const;
 bool contains(const KeyType) const;
@@ -119,6 +129,76 @@
 private:
 pairiterator, bool inlineAdd(const KeyType, MappedPassInReferenceType);
 
+class HashMapKeysProxy : private HashMap {
+public:
+typedef typename HashMap::iterator::Keys iterator;
+typedef typename HashMap::const_iterator::Keys const_iterator;
+
+iterator begin()
+{
+return HashMap::begin().keys();
+}
+
+iterator end()
+{
+return HashMap::end().keys();
+}
+
+const_iterator begin() const
+{
+return HashMap::begin().keys();
+}
+
+const_iterator end() const
+{
+return HashMap::end().keys();
+}
+
+private:
+friend class HashMap;
+
+// These are intentionally not implemented.
+HashMapKeysProxy();
+HashMapKeysProxy(const HashMapKeysProxy);
+HashMapKeysProxy operator=(const HashMapKeysProxy);
+~HashMapKeysProxy();
+};
+
+class HashMapValuesProxy : private HashMap {
+public:
+typedef typename HashMap::iterator::Values iterator;
+typedef typename HashMap::const_iterator::Values const_iterator;
+
+iterator begin()
+{
+return HashMap::begin().values();
+}
+
+iterator end()
+{
+return HashMap::end().values();
+}
+
+const_iterator begin() const
+{
+return HashMap::begin().values();
+}
+
+const_iterator end() const
+{
+return HashMap::end().values();
+}
+
+private:
+friend class HashMap;
+
+// These are intentionally not implemented.
+HashMapValuesProxy();
+HashMapValuesProxy(const HashMapValuesProxy);
+HashMapValuesProxy operator=(const HashMapValuesProxy);
+~HashMapValuesProxy();
+};
+
 HashTableType m_impl;
 };
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102085] trunk/Source/WebCore

2011-12-05 Thread darin

Title: [102085] trunk/Source/WebCore








Revision 102085
Author da...@apple.com
Date 2011-12-05 18:55:47 -0800 (Mon, 05 Dec 2011)


Log Message
Use HashMapOwnPtr in CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=73785

Reviewed by Andreas Kling.

* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
instead of add, since it wants to replace existing entries. Also removed leakPtr
and removed the FIXME that documented the memory leak now fixed here.
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
std:: prefix here and also unneeded explicit delete call.
(WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
call here.

* loader/CrossOriginPreflightResultCache.h: Make mapped value of the
CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp
trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102084 => 102085)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 02:17:22 UTC (rev 102084)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 02:55:47 UTC (rev 102085)
@@ -1,5 +1,24 @@
 2011-12-05  Darin Adler  da...@apple.com
 
+Use HashMapOwnPtr in CrossOriginPreflightResultCache
+https://bugs.webkit.org/show_bug.cgi?id=73785
+
+Reviewed by Andreas Kling.
+
+* loader/CrossOriginPreflightResultCache.cpp:
+(WebCore::CrossOriginPreflightResultCache::appendEntry): Changed code to use set
+instead of add, since it wants to replace existing entries. Also removed leakPtr
+and removed the FIXME that documented the memory leak now fixed here.
+(WebCore::CrossOriginPreflightResultCache::canSkipPreflight): Removed unneeded
+std:: prefix here and also unneeded explicit delete call.
+(WebCore::CrossOriginPreflightResultCache::empty): Removed unneeded deleteAllValues
+call here.
+
+* loader/CrossOriginPreflightResultCache.h: Make mapped value of the
+CrossOriginPreflightResultHashMap be OwnPtr instead of raw pointer.
+
+2011-12-05  Darin Adler  da...@apple.com
+
 Some small improvements to ContainerNode.h
 https://bugs.webkit.org/show_bug.cgi?id=73786
 


Modified: trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp (102084 => 102085)

--- trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp	2011-12-06 02:17:22 UTC (rev 102084)
+++ trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.cpp	2011-12-06 02:55:47 UTC (rev 102085)
@@ -159,25 +159,19 @@
 void CrossOriginPreflightResultCache::appendEntry(const String origin, const KURL url, PassOwnPtrCrossOriginPreflightResultCacheItem preflightResult)
 {
 ASSERT(isMainThread());
-CrossOriginPreflightResultCacheItem* resultPtr = preflightResult.leakPtr();
-pairCrossOriginPreflightResultHashMap::iterator, bool addResult = m_preflightHashMap.add(make_pair(origin, url), resultPtr);
-if (!addResult.second) {
-// FIXME: We need to delete the old value before replacing with the new one.
-addResult.first-second = resultPtr;
-}
+m_preflightHashMap.set(make_pair(origin, url), preflightResult);
 }
 
 bool CrossOriginPreflightResultCache::canSkipPreflight(const String origin, const KURL url, StoredCredentials includeCredentials, const String method, const HTTPHeaderMap requestHeaders)
 {
 ASSERT(isMainThread());
-CrossOriginPreflightResultHashMap::iterator cacheIt = m_preflightHashMap.find(std::make_pair(origin, url));
+CrossOriginPreflightResultHashMap::iterator cacheIt = m_preflightHashMap.find(make_pair(origin, url));
 if (cacheIt == m_preflightHashMap.end())
 return false;
 
 if (cacheIt-second-allowsRequest(includeCredentials, method, requestHeaders))
 return true;
 
-delete cacheIt-second;
 m_preflightHashMap.remove(cacheIt);
 return false;
 }
@@ -185,7 +179,6 @@
 void CrossOriginPreflightResultCache::empty()
 {
 ASSERT(isMainThread());
-deleteAllValues(m_preflightHashMap);
 m_preflightHashMap.clear();
 }
 


Modified: trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h (102084 => 102085)

--- trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h	2011-12-06 02:17:22 UTC (rev 102084)
+++ trunk/Source/WebCore/loader/CrossOriginPreflightResultCache.h	2011-12-06 02:55:47 UTC (rev 102085)
@@ -78,7 +78,7 @@
 private:
 CrossOriginPreflightResultCache() { }
 
-typedef HashMapstd::pairString, KURL, CrossOriginPreflightResultCacheItem* CrossOriginPreflightResultHashMap;
+typedef HashMapstd::pairString, KURL, OwnPtrCrossOriginPreflightResultCacheItem  CrossOriginPreflightResultHashMap;
 
 CrossOriginPreflightResultHashMap m_preflightHashMap;
 };

[webkit-changes] [102086] trunk/Source/WebCore

2011-12-05 Thread benjamin

Title: [102086] trunk/Source/WebCore








Revision 102086
Author benja...@webkit.org
Date 2011-12-05 19:48:35 -0800 (Mon, 05 Dec 2011)


Log Message
Upstream htmlSelectMultipleItems needed for select multiple by iOS
https://bugs.webkit.org/show_bug.cgi?id=73734

Patch by Benjamin Poulain bpoul...@apple.com on 2011-12-05
Reviewed by David Kilzer.

* platform/DefaultLocalizationStrategy.cpp:
(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
* platform/DefaultLocalizationStrategy.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp
trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102085 => 102086)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 02:55:47 UTC (rev 102085)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 03:48:35 UTC (rev 102086)
@@ -1,3 +1,14 @@
+2011-12-05  Benjamin Poulain  bpoul...@apple.com
+
+Upstream htmlSelectMultipleItems needed for select multiple by iOS
+https://bugs.webkit.org/show_bug.cgi?id=73734
+
+Reviewed by David Kilzer.
+
+* platform/DefaultLocalizationStrategy.cpp:
+(WebCore::DefaultLocalizationStrategy::htmlSelectMultipleItems):
+* platform/DefaultLocalizationStrategy.h:
+
 2011-12-05  Darin Adler  da...@apple.com
 
 Use HashMapOwnPtr in CrossOriginPreflightResultCache


Modified: trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp (102085 => 102086)

--- trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp	2011-12-06 02:55:47 UTC (rev 102085)
+++ trunk/Source/WebCore/platform/DefaultLocalizationStrategy.cpp	2011-12-06 03:48:35 UTC (rev 102086)
@@ -767,7 +767,13 @@
 return formatLocalizedString(WEB_UI_STRING(Key from %@, Name of keychain key generated by the KEYGEN tag), hostCFString.get());
 }
 
-#endif
+#if PLATFORM(IOS)
+String DefaultLocalizationStrategy::htmlSelectMultipleItems(int count)
+{
+return formatLocalizedString(WEB_UI_STRING(%d Items, Present the number of selected option items in a select multiple element (iOS only)), count);
+}
+#endif // PLATFORM(IOS)
+#endif // PLATFORM(MAC)
 
 String DefaultLocalizationStrategy::imageTitle(const String filename, const IntSize size)
 {


Modified: trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h (102085 => 102086)

--- trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h	2011-12-06 02:55:47 UTC (rev 102085)
+++ trunk/Source/WebCore/platform/DefaultLocalizationStrategy.h	2011-12-06 03:48:35 UTC (rev 102086)
@@ -169,7 +169,10 @@
 virtual String keygenMenuItem1024();
 virtual String keygenMenuItem2048();
 virtual String keygenKeychainItemName(const String host);
-#endif
+#if PLATFORM(IOS)
+virtual String htmlSelectMultipleItems(int);
+#endif // PLATFORM(IOS)
+#endif // PLATFORM(MAC)
 virtual String imageTitle(const String filename, const IntSize);
 virtual String mediaElementLoadingStateText();
 virtual String mediaElementLiveBroadcastStateText();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102088] trunk/Source

2011-12-05 Thread senorblanco

Title: [102088] trunk/Source








Revision 102088
Author senorbla...@chromium.org
Date 2011-12-05 20:16:28 -0800 (Mon, 05 Dec 2011)


Log Message
Allow the ImageBuffers used by SVG filters to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=73842

Reviewed by Kenneth Russell.

Source/WebCore:

Regressions covered by existing SVG tests; new functionality to be
tested by the API exposed on Internals.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setAcceleratedFiltersEnabled):
(WebCore::Settings::acceleratedFiltersEnabled):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* platform/graphics/filters/Filter.h:
(WebCore::Filter::Filter):
(WebCore::Filter::renderingMode):
(WebCore::Filter::setRenderingMode):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/SVGImageBufferTools.cpp:
(WebCore::SVGImageBufferTools::createImageBuffer):
* rendering/svg/SVGImageBufferTools.h:
* testing/Internals.cpp:
(WebCore::Internals::setAcceleratedFiltersEnabled):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setAcceleratedFiltersEnabled):
* src/WebSettingsImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.cpp
trunk/Source/WebCore/page/Settings.h
trunk/Source/WebCore/platform/graphics/filters/FETile.cpp
trunk/Source/WebCore/platform/graphics/filters/Filter.h
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp
trunk/Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourcePattern.cpp
trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.cpp
trunk/Source/WebCore/rendering/svg/SVGImageBufferTools.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102087 => 102088)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 04:07:02 UTC (rev 102087)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 04:16:28 UTC (rev 102088)
@@ -1,3 +1,45 @@
+2011-12-05  Stephen White  senorbla...@chromium.org
+
+Allow the ImageBuffers used by SVG filters to be accelerated
+https://bugs.webkit.org/show_bug.cgi?id=73842
+
+Reviewed by Kenneth Russell.
+
+Regressions covered by existing SVG tests; new functionality to be
+tested by the API exposed on Internals.
+
+* page/Settings.cpp:
+(WebCore::Settings::Settings):
+* page/Settings.h:
+(WebCore::Settings::setAcceleratedFiltersEnabled):
+(WebCore::Settings::acceleratedFiltersEnabled):
+* platform/graphics/filters/FETile.cpp:
+(WebCore::FETile::platformApplySoftware):
+* platform/graphics/filters/Filter.h:
+(WebCore::Filter::Filter):
+(WebCore::Filter::renderingMode):
+(WebCore::Filter::setRenderingMode):
+* platform/graphics/filters/FilterEffect.cpp:
+(WebCore::FilterEffect::asImageBuffer):
+(WebCore::FilterEffect::createImageBufferResult):
+* platform/graphics/skia/ImageBufferSkia.cpp:
+(WebCore::ImageBuffer::platformTransformColorSpace):
+* rendering/svg/RenderSVGResourceClipper.cpp:
+(WebCore::RenderSVGResourceClipper::applyClippingToContext):
+* rendering/svg/RenderSVGResourceFilter.cpp:
+(WebCore::RenderSVGResourceFilter::applyResource):
+* rendering/svg/RenderSVGResourceMasker.cpp:
+(WebCore::RenderSVGResourceMasker::applyResource):
+* rendering/svg/RenderSVGResourcePattern.cpp:
+(WebCore::RenderSVGResourcePattern::createTileImage):
+* rendering/svg/SVGImageBufferTools.cpp:
+(WebCore::SVGImageBufferTools::createImageBuffer):
+* rendering/svg/SVGImageBufferTools.h:
+* testing/Internals.cpp:
+

[webkit-changes] [102089] trunk

2011-12-05 Thread commit-queue

Title: [102089] trunk








Revision 102089
Author commit-qu...@webkit.org
Date 2011-12-05 20:46:01 -0800 (Mon, 05 Dec 2011)


Log Message
Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
https://bugs.webkit.org/show_bug.cgi?id=73765

Patch by Florin Malita fmal...@google.com on 2011-12-05
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/foreign-content-crash.html

Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

* fast/parser/foreign-content-crash-expected.txt: Added.
* fast/parser/foreign-content-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp


Added Paths

trunk/LayoutTests/fast/parser/foreign-content-crash-expected.txt
trunk/LayoutTests/fast/parser/foreign-content-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (102088 => 102089)

--- trunk/LayoutTests/ChangeLog	2011-12-06 04:16:28 UTC (rev 102088)
+++ trunk/LayoutTests/ChangeLog	2011-12-06 04:46:01 UTC (rev 102089)
@@ -1,3 +1,13 @@
+2011-12-05  Florin Malita  fmal...@google.com
+
+Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
+https://bugs.webkit.org/show_bug.cgi?id=73765
+
+Reviewed by Adam Barth.
+
+* fast/parser/foreign-content-crash-expected.txt: Added.
+* fast/parser/foreign-content-crash.html: Added.
+
 2011-12-05  Tim Horton  timothy_hor...@apple.com
 
 Unreviewed extremely minor SVG filter pixel rebaselines for Lion.


Added: trunk/LayoutTests/fast/parser/foreign-content-crash-expected.txt (0 => 102089)

--- trunk/LayoutTests/fast/parser/foreign-content-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/parser/foreign-content-crash-expected.txt	2011-12-06 04:46:01 UTC (rev 102089)
@@ -0,0 +1 @@
+This test passes if it doesn't crash.


Added: trunk/LayoutTests/fast/parser/foreign-content-crash.html (0 => 102089)

--- trunk/LayoutTests/fast/parser/foreign-content-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/parser/foreign-content-crash.html	2011-12-06 04:46:01 UTC (rev 102089)
@@ -0,0 +1,8 @@
+script
+var svgElement = document.createElementNS(http://www.w3.org/2000/svg, svg);
+svgElement.appendChild(document.createElement(div)).insertAdjacentHTML(beforeBegin, /p);
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+pThis test passes if it doesn't crash./p


Modified: trunk/Source/WebCore/ChangeLog (102088 => 102089)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 04:16:28 UTC (rev 102088)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 04:46:01 UTC (rev 102089)
@@ -1,3 +1,17 @@
+2011-12-05  Florin Malita  fmal...@google.com
+
+Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag
+https://bugs.webkit.org/show_bug.cgi?id=73765
+
+Reviewed by Adam Barth.
+
+Test: fast/parser/foreign-content-crash.html
+
+Use m_tree.currentNode() instead of m_tree.currentElement() as the top node is not always an Element.
+
+* html/parser/HTMLTreeBuilder.cpp:
+(WebCore::HTMLTreeBuilder::processEndTag):
+
 2011-12-05  Stephen White  senorbla...@chromium.org
 
 Allow the ImageBuffers used by SVG filters to be accelerated


Modified: trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp (102088 => 102089)

--- trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2011-12-06 04:16:28 UTC (rev 102088)
+++ trunk/Source/WebCore/html/parser/HTMLTreeBuilder.cpp	2011-12-06 04:46:01 UTC (rev 102089)
@@ -2313,7 +2313,7 @@
 processEndTag(token);
 break;
 case InForeignContentMode:
-if (m_tree.currentElement()-namespaceURI() == SVGNames::svgNamespaceURI)
+if (m_tree.currentNode()-namespaceURI() == SVGNames::svgNamespaceURI)
 adjustSVGTagNameCase(token);
 
 if (token.name() == SVGNames::scriptTag  m_tree.currentNode()-hasTagName(SVGNames::scriptTag)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [102090] trunk/Source/WebCore

2011-12-05 Thread tony

Title: [102090] trunk/Source/WebCore








Revision 102090
Author t...@chromium.org
Date 2011-12-05 20:59:11 -0800 (Mon, 05 Dec 2011)


Log Message
small refactor of RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=73854

Reviewed by Darin Adler.

No new tests, just a refactor.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
to mainAxisOffset.  Rename logicalTop to crossAxisOffset.  Get rid of
logicalLeft local variable since it's confusing.  Move shouldFlipMainAxis
out of the for loop to avoid computing it each iteration.
* rendering/RenderFlexibleBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102089 => 102090)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 04:46:01 UTC (rev 102089)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 04:59:11 UTC (rev 102090)
@@ -1,3 +1,20 @@
+2011-12-05  Tony Chang  t...@chromium.org
+
+small refactor of RenderFlexibleBox
+https://bugs.webkit.org/show_bug.cgi?id=73854
+
+Reviewed by Darin Adler.
+
+No new tests, just a refactor.
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::isLeftToRightFlow): Inline isReverseFlow since it's only used in one place.
+(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Rename startEdge
+to mainAxisOffset.  Rename logicalTop to crossAxisOffset.  Get rid of
+logicalLeft local variable since it's confusing.  Move shouldFlipMainAxis
+out of the for loop to avoid computing it each iteration.
+* rendering/RenderFlexibleBox.h:
+
 2011-12-05  Florin Malita  fmal...@google.com
 
 Heap-buffer-overflow in WebCore::HTMLTreeBuilder::processEndTag


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (102089 => 102090)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-12-06 04:46:01 UTC (rev 102089)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2011-12-06 04:59:11 UTC (rev 102090)
@@ -206,11 +206,6 @@
 return style()-isColumnFlexFlow();
 }
 
-bool RenderFlexibleBox::isReverseFlow() const
-{
-return style()-flexFlow() == FlowColumnReverse || style()-flexFlow() == FlowRowReverse;
-}
-
 bool RenderFlexibleBox::isHorizontalFlow() const
 {
 if (isHorizontalWritingMode())
@@ -222,7 +217,7 @@
 {
 if (isColumnFlow())
 return style()-writingMode() == TopToBottomWritingMode || style()-writingMode() == LeftToRightWritingMode;
-return style()-isLeftToRightDirection() ^ isReverseFlow();
+return style()-isLeftToRightDirection() ^ (style()-flexFlow() == FlowRowReverse);
 }
 
 Length RenderFlexibleBox::mainAxisLengthForChild(RenderBox* child) const
@@ -598,12 +593,13 @@
 
 void RenderFlexibleBox::layoutAndPlaceChildren(FlexOrderIterator iterator, const WTF::VectorLayoutUnit childSizes, LayoutUnit availableFreeSpace, float totalPositiveFlexibility)
 {
-LayoutUnit startEdge = flowAwareBorderStart() + flowAwarePaddingStart();
-startEdge += initialPackingOffset(availableFreeSpace, totalPositiveFlexibility, style()-flexPack());
+LayoutUnit mainAxisOffset = flowAwareBorderStart() + flowAwarePaddingStart();
+mainAxisOffset += initialPackingOffset(availableFreeSpace, totalPositiveFlexibility, style()-flexPack());
 
-LayoutUnit logicalTop = flowAwareBorderBefore() + flowAwarePaddingBefore();
+LayoutUnit crossAxisOffset = flowAwareBorderBefore() + flowAwarePaddingBefore();
 LayoutUnit totalMainExtent = mainAxisExtent();
 LayoutUnit maxAscent = 0, maxDescent = 0; // Used when flex-align: baseline.
+bool shouldFlipMainAxis = !isColumnFlow()  !isLeftToRightFlow();
 size_t i = 0;
 for (RenderBox* child = iterator.first(); child; child = iterator.next(), ++i) {
 LayoutUnit childPreferredSize = childSizes[i] + mainAxisBorderAndPaddingExtentForChild(child);
@@ -624,20 +620,20 @@
 } else if (crossAxisLength().isAuto())
 setCrossAxisExtent(std::max(crossAxisExtent(), crossAxisBorderAndPaddingExtent() + crossAxisMarginExtentForChild(child) + crossAxisExtentForChild(child) + scrollbarLogicalHeight()));
 
-startEdge += flowAwareMarginStartForChild(child);
+mainAxisOffset += flowAwareMarginStartForChild(child);
 
 LayoutUnit childMainExtent = mainAxisExtentForChild(child);
-bool shouldFlipMainAxis = !isColumnFlow()  !isLeftToRightFlow();
-LayoutUnit logicalLeft = shouldFlipMainAxis ? totalMainExtent - startEdge - childMainExtent : startEdge;
+IntPoint childLocation(shouldFlipMainAxis ? totalMainExtent - mainAxisOffset - childMainExtent : mainAxisOffset,
+crossAxisOffset + flowAwareMarginBeforeForChild(child));
 
 // FIXME: Supporting layout

[webkit-changes] [102091] trunk/Source

2011-12-05 Thread enne

Title: [102091] trunk/Source








Revision 102091
Author e...@google.com
Date 2011-12-05 21:05:06 -0800 (Mon, 05 Dec 2011)


Log Message
[chromium] setNeedsCommit on non-composited host layers should trigger commit
https://bugs.webkit.org/show_bug.cgi?id=73711

Reviewed by James Robinson.

Source/WebCore:

Pipe non-composited content host syncs to setNeedsCommit.

Since now the NonCompositedContentHost generates setNeedsCommit, don't
call it unnecessarily, e.g. calling setBackgroundColor to the same
color each frame should not retrigger more commits.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAnchorPoint):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setChildrenTransform):
(WebCore::GraphicsLayerChromium::setMasksToBounds):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setNeedsCommit):
(WebCore::LayerChromium::setAnchorPoint):
(WebCore::LayerChromium::setAnchorPointZ):
(WebCore::LayerChromium::setBackgroundColor):
(WebCore::LayerChromium::setMasksToBounds):
(WebCore::LayerChromium::setMaskLayer):
(WebCore::LayerChromium::setOpacity):
(WebCore::LayerChromium::setOpaque):
(WebCore::LayerChromium::setPosition):
(WebCore::LayerChromium::setSublayerTransform):
(WebCore::LayerChromium::setTransform):
(WebCore::LayerChromium::setScrollPosition):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::setDoubleSided):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setReplicaLayer):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::notifySyncRequired):
* platform/graphics/chromium/NonCompositedContentHost.h:

Source/WebKit/chromium:

Add some tests to make sure that modifying the noncomposited content
host triggers commits.

Properties that trigger setNeedsCommit should only do so when the
property changes. Additionally, make more property changes properly
trigger commits.

* tests/LayerChromiumTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/LayerChromium.h
trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/LayerChromiumTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (102090 => 102091)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 04:59:11 UTC (rev 102090)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 05:05:06 UTC (rev 102091)
@@ -1,3 +1,47 @@
+2011-12-05  Adrienne Walker  e...@google.com
+
+[chromium] setNeedsCommit on non-composited host layers should trigger commit
+https://bugs.webkit.org/show_bug.cgi?id=73711
+
+Reviewed by James Robinson.
+
+Pipe non-composited content host syncs to setNeedsCommit.
+
+Since now the NonCompositedContentHost generates setNeedsCommit, don't
+call it unnecessarily, e.g. calling setBackgroundColor to the same
+color each frame should not retrigger more commits.
+
+* platform/graphics/chromium/GraphicsLayerChromium.cpp:
+(WebCore::GraphicsLayerChromium::setAnchorPoint):
+(WebCore::GraphicsLayerChromium::setTransform):
+(WebCore::GraphicsLayerChromium::setChildrenTransform):
+(WebCore::GraphicsLayerChromium::setMasksToBounds):
+(WebCore::GraphicsLayerChromium::setBackgroundColor):
+(WebCore::GraphicsLayerChromium::clearBackgroundColor):
+(WebCore::GraphicsLayerChromium::setContentsOpaque):
+(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
+(WebCore::GraphicsLayerChromium::setOpacity):
+* platform/graphics/chromium/LayerChromium.cpp:
+(WebCore::LayerChromium::setNeedsCommit):
+(WebCore::LayerChromium::setAnchorPoint):
+(WebCore::LayerChromium::setAnchorPointZ):
+(WebCore::LayerChromium::setBackgroundColor):
+(WebCore::LayerChromium::setMasksToBounds):
+(WebCore::LayerChromium::setMaskLayer):
+(WebCore::LayerChromium::setOpacity):
+(WebCore::LayerChromium::setOpaque):
+(WebCore::LayerChromium::setPosition):
+(WebCore::LayerChromium::setSublayerTransform):
+(WebCore::LayerChromium::setTransform):
+(WebCore::LayerChromium::setScrollPosition):
+(WebCore::LayerChromium::setScrollable):
+(WebCore::LayerChromium::setDoubleSided):
+* platform/graphics/chromium/LayerChromium.h:
+

[webkit-changes] [102092] trunk/Source/WebCore

2011-12-05 Thread commit-queue

Title: [102092] trunk/Source/WebCore








Revision 102092
Author commit-qu...@webkit.org
Date 2011-12-05 21:30:08 -0800 (Mon, 05 Dec 2011)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=73683
Implement KeyframeValueList::operator=() and KeyframeValueList::swap().

Patch by Yong Li y...@rim.com on 2011-12-05
Reviewed by Darin Adler.

No new tests as no functional change.

* platform/graphics/GraphicsLayer.h:
(WebCore::KeyframeValueList::operator=): Added
(WebCore::KeyframeValueList::swap): Added

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (102091 => 102092)

--- trunk/Source/WebCore/ChangeLog	2011-12-06 05:05:06 UTC (rev 102091)
+++ trunk/Source/WebCore/ChangeLog	2011-12-06 05:30:08 UTC (rev 102092)
@@ -1,3 +1,16 @@
+2011-12-05  Yong Li  y...@rim.com
+
+https://bugs.webkit.org/show_bug.cgi?id=73683
+Implement KeyframeValueList::operator=() and KeyframeValueList::swap().
+
+Reviewed by Darin Adler.
+
+No new tests as no functional change.
+
+* platform/graphics/GraphicsLayer.h: 
+(WebCore::KeyframeValueList::operator=): Added
+(WebCore::KeyframeValueList::swap): Added
+
 2011-12-05  Adrienne Walker  e...@google.com
 
 [chromium] setNeedsCommit on non-composited host layers should trigger commit


Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.h (102091 => 102092)

--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.h	2011-12-06 05:05:06 UTC (rev 102091)
+++ trunk/Source/WebCore/platform/graphics/GraphicsLayer.h	2011-12-06 05:30:08 UTC (rev 102092)
@@ -170,7 +170,20 @@
 {
 deleteAllValues(m_values);
 }
-
+
+KeyframeValueList operator=(const KeyframeValueList other)
+{
+KeyframeValueList copy(other);
+swap(copy);
+return *this;
+}
+
+void swap(KeyframeValueList other)
+{
+std::swap(m_property, other.m_property);
+m_values.swap(other.m_values);
+}
+
 AnimatedPropertyID property() const { return m_property; }
 
 size_t size() const { return m_values.size(); }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

1 2 >

1 - 100 of 108 matches

Mail list logo